~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_merge.py

Add a NEWS entry and prepare submission.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
29
29
    transform,
30
30
    versionedfile,
31
31
    )
 
32
from bzrlib.branch import Branch
32
33
from bzrlib.conflicts import ConflictList, TextConflict
33
 
from bzrlib.errors import UnrelatedBranches, NoCommits
 
34
from bzrlib.errors import UnrelatedBranches, NoCommits, BzrCommandError
34
35
from bzrlib.merge import transform_tree, merge_inner, _PlanMerge
35
36
from bzrlib.osutils import pathjoin, file_kind
36
 
from bzrlib.tests import (
37
 
    TestCaseWithMemoryTransport,
38
 
    TestCaseWithTransport,
39
 
    test_merge_core,
40
 
    )
 
37
from bzrlib.tests import TestCaseWithTransport, TestCaseWithMemoryTransport
41
38
from bzrlib.workingtree import WorkingTree
 
39
from bzrlib.transform import TreeTransform
42
40
 
43
41
 
44
42
class TestMerge(TestCaseWithTransport):
154
152
        log = StringIO()
155
153
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
156
154
                    this_tree=tree_b, ignore_zero=True)
157
 
        self.failUnless('All changes applied successfully.\n' not in
158
 
            self.get_log())
 
155
        log = self._get_log(keep_log_file=True)
 
156
        self.failUnless('All changes applied successfully.\n' not in log)
159
157
        tree_b.revert()
160
158
        merge_inner(tree_b.branch, tree_a, tree_b.basis_tree(),
161
159
                    this_tree=tree_b, ignore_zero=False)
162
 
        self.failUnless('All changes applied successfully.\n' in self.get_log())
 
160
        log = self._get_log(keep_log_file=True)
 
161
        self.failUnless('All changes applied successfully.\n' in log)
163
162
 
164
163
    def test_merge_inner_conflicts(self):
165
164
        tree_a = self.make_branch_and_tree('a')
295
294
        tree_a.commit('commit 2')
296
295
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
297
296
        tree_b.rename_one('file_1', 'renamed')
298
 
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
 
297
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b,
 
298
                                                    progress.DummyProgress())
299
299
        merger.merge_type = _mod_merge.Merge3Merger
300
300
        merger.do_merge()
301
301
        self.assertEqual(tree_a.get_parent_ids(), [tree_b.last_revision()])
309
309
        tree_a.commit('commit 2')
310
310
        tree_b = tree_a.bzrdir.sprout('b').open_workingtree()
311
311
        tree_b.rename_one('file_1', 'renamed')
312
 
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b)
 
312
        merger = _mod_merge.Merger.from_uncommitted(tree_a, tree_b,
 
313
                                                    progress.DummyProgress())
313
314
        merger.merge_type = _mod_merge.WeaveMerger
314
315
        merger.do_merge()
315
316
        self.assertEqual(tree_a.get_parent_ids(), [tree_b.last_revision()])
316
317
 
 
318
    def test_Merger_defaults_to_DummyProgress(self):
 
319
        branch = self.make_branch('branch')
 
320
        merger = _mod_merge.Merger(branch, pb=None)
 
321
        self.assertIsInstance(merger._pb, progress.DummyProgress)
 
322
 
317
323
    def prepare_cherrypick(self):
318
324
        """Prepare a pair of trees for cherrypicking tests.
319
325
 
340
346
 
341
347
    def test_weave_cherrypick(self):
342
348
        this_tree, other_tree = self.prepare_cherrypick()
343
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
349
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
344
350
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
345
351
        merger.merge_type = _mod_merge.WeaveMerger
346
352
        merger.do_merge()
348
354
 
349
355
    def test_weave_cannot_reverse_cherrypick(self):
350
356
        this_tree, other_tree = self.prepare_cherrypick()
351
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
357
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
352
358
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
353
359
        merger.merge_type = _mod_merge.WeaveMerger
354
360
        self.assertRaises(errors.CannotReverseCherrypick, merger.do_merge)
355
361
 
356
362
    def test_merge3_can_reverse_cherrypick(self):
357
363
        this_tree, other_tree = self.prepare_cherrypick()
358
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
364
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
359
365
            this_tree, 'rev2b', 'rev3b', other_tree.branch)
360
366
        merger.merge_type = _mod_merge.Merge3Merger
361
367
        merger.do_merge()
373
379
        this_tree.lock_write()
374
380
        self.addCleanup(this_tree.unlock)
375
381
 
376
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
382
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
377
383
            this_tree, 'rev3b', 'rev2b', other_tree.branch)
378
384
        merger.merge_type = _mod_merge.Merge3Merger
379
385
        merger.do_merge()
392
398
        other_tree.commit('rev2', rev_id='rev2b')
393
399
        this_tree.lock_write()
394
400
        self.addCleanup(this_tree.unlock)
395
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
401
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress,
396
402
            this_tree, 'rev2b', other_branch=other_tree.branch)
397
403
        merger.merge_type = _mod_merge.Merge3Merger
398
404
        tree_merger = merger.make_merger()
412
418
        other_tree.commit('rev2', rev_id='rev2b')
413
419
        this_tree.lock_write()
414
420
        self.addCleanup(this_tree.unlock)
415
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
421
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
416
422
            this_tree, 'rev2b', other_branch=other_tree.branch)
417
423
        merger.merge_type = _mod_merge.Merge3Merger
418
424
        tree_merger = merger.make_merger()
442
448
        other_tree.commit('rev2', rev_id='rev2b')
443
449
        this_tree.lock_write()
444
450
        self.addCleanup(this_tree.unlock)
445
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
451
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
446
452
            this_tree, 'rev2b', other_branch=other_tree.branch)
447
453
        merger.merge_type = _mod_merge.Merge3Merger
448
454
        tree_merger = merger.make_merger()
1138
1144
                         ], list(plan))
1139
1145
 
1140
1146
 
 
1147
class TestMergeImplementation(object):
 
1148
 
 
1149
    def do_merge(self, target_tree, source_tree, **kwargs):
 
1150
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
 
1151
            target_tree, source_tree.last_revision(),
 
1152
            other_branch=source_tree.branch)
 
1153
        merger.merge_type=self.merge_type
 
1154
        for name, value in kwargs.items():
 
1155
            setattr(merger, name, value)
 
1156
        merger.do_merge()
 
1157
 
 
1158
    def test_merge_specific_file(self):
 
1159
        this_tree = self.make_branch_and_tree('this')
 
1160
        this_tree.lock_write()
 
1161
        self.addCleanup(this_tree.unlock)
 
1162
        self.build_tree_contents([
 
1163
            ('this/file1', 'a\nb\n'),
 
1164
            ('this/file2', 'a\nb\n')
 
1165
        ])
 
1166
        this_tree.add(['file1', 'file2'])
 
1167
        this_tree.commit('Added files')
 
1168
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
1169
        self.build_tree_contents([
 
1170
            ('other/file1', 'a\nb\nc\n'),
 
1171
            ('other/file2', 'a\nb\nc\n')
 
1172
        ])
 
1173
        other_tree.commit('modified both')
 
1174
        self.build_tree_contents([
 
1175
            ('this/file1', 'd\na\nb\n'),
 
1176
            ('this/file2', 'd\na\nb\n')
 
1177
        ])
 
1178
        this_tree.commit('modified both')
 
1179
        self.do_merge(this_tree, other_tree, interesting_files=['file1'])
 
1180
        self.assertFileEqual('d\na\nb\nc\n', 'this/file1')
 
1181
        self.assertFileEqual('d\na\nb\n', 'this/file2')
 
1182
 
 
1183
    def test_merge_move_and_change(self):
 
1184
        this_tree = self.make_branch_and_tree('this')
 
1185
        this_tree.lock_write()
 
1186
        self.addCleanup(this_tree.unlock)
 
1187
        self.build_tree_contents([
 
1188
            ('this/file1', 'line 1\nline 2\nline 3\nline 4\n'),
 
1189
        ])
 
1190
        this_tree.add('file1',)
 
1191
        this_tree.commit('Added file')
 
1192
        other_tree = this_tree.bzrdir.sprout('other').open_workingtree()
 
1193
        self.build_tree_contents([
 
1194
            ('other/file1', 'line 1\nline 2 to 2.1\nline 3\nline 4\n'),
 
1195
        ])
 
1196
        other_tree.commit('Changed 2 to 2.1')
 
1197
        self.build_tree_contents([
 
1198
            ('this/file1', 'line 1\nline 3\nline 2\nline 4\n'),
 
1199
        ])
 
1200
        this_tree.commit('Swapped 2 & 3')
 
1201
        self.do_merge(this_tree, other_tree)
 
1202
        self.assertFileEqual('line 1\n'
 
1203
            '<<<<<<< TREE\n'
 
1204
            'line 3\n'
 
1205
            'line 2\n'
 
1206
            '=======\n'
 
1207
            'line 2 to 2.1\n'
 
1208
            'line 3\n'
 
1209
            '>>>>>>> MERGE-SOURCE\n'
 
1210
            'line 4\n', 'this/file1')
 
1211
 
 
1212
    def test_modify_conflicts_with_delete(self):
 
1213
        # If one side deletes a line, and the other modifies that line, then
 
1214
        # the modification should be considered a conflict
 
1215
        builder = self.make_branch_builder('test')
 
1216
        builder.start_series()
 
1217
        builder.build_snapshot('BASE-id', None,
 
1218
            [('add', ('', None, 'directory', None)),
 
1219
             ('add', ('foo', 'foo-id', 'file', 'a\nb\nc\nd\ne\n')),
 
1220
            ])
 
1221
        # Delete 'b\n'
 
1222
        builder.build_snapshot('OTHER-id', ['BASE-id'],
 
1223
            [('modify', ('foo-id', 'a\nc\nd\ne\n'))])
 
1224
        # Modify 'b\n', add 'X\n'
 
1225
        builder.build_snapshot('THIS-id', ['BASE-id'],
 
1226
            [('modify', ('foo-id', 'a\nb2\nc\nd\nX\ne\n'))])
 
1227
        builder.finish_series()
 
1228
        branch = builder.get_branch()
 
1229
        this_tree = branch.bzrdir.create_workingtree()
 
1230
        this_tree.lock_write()
 
1231
        self.addCleanup(this_tree.unlock)
 
1232
        other_tree = this_tree.bzrdir.sprout('other', 'OTHER-id').open_workingtree()
 
1233
        self.do_merge(this_tree, other_tree)
 
1234
        if self.merge_type is _mod_merge.LCAMerger:
 
1235
            self.expectFailure("lca merge doesn't track deleted lines",
 
1236
                self.assertFileEqual,
 
1237
                    'a\n'
 
1238
                    '<<<<<<< TREE\n'
 
1239
                    'b2\n'
 
1240
                    '=======\n'
 
1241
                    '>>>>>>> MERGE-SOURCE\n'
 
1242
                    'c\n'
 
1243
                    'd\n'
 
1244
                    'X\n'
 
1245
                    'e\n', 'test/foo')
 
1246
        else:
 
1247
            self.assertFileEqual(
 
1248
                'a\n'
 
1249
                '<<<<<<< TREE\n'
 
1250
                'b2\n'
 
1251
                '=======\n'
 
1252
                '>>>>>>> MERGE-SOURCE\n'
 
1253
                'c\n'
 
1254
                'd\n'
 
1255
                'X\n'
 
1256
                'e\n', 'test/foo')
 
1257
 
 
1258
    def get_limbodir_deletiondir(self, wt):
 
1259
        transform = TreeTransform(wt)
 
1260
        limbodir = transform._limbodir
 
1261
        deletiondir = transform._deletiondir
 
1262
        transform.finalize()
 
1263
        return (limbodir, deletiondir)
 
1264
    
 
1265
    def test_merge_with_existing_limbo(self):
 
1266
        wt = self.make_branch_and_tree('this')
 
1267
        (limbodir, deletiondir) =  self.get_limbodir_deletiondir(wt)
 
1268
        os.mkdir(limbodir)
 
1269
        self.assertRaises(errors.ExistingLimbo, self.do_merge, wt, wt)
 
1270
        self.assertRaises(errors.LockError, wt.unlock)
 
1271
 
 
1272
    def test_merge_with_pending_deletion(self):
 
1273
        wt = self.make_branch_and_tree('this')
 
1274
        (limbodir, deletiondir) =  self.get_limbodir_deletiondir(wt)
 
1275
        os.mkdir(deletiondir)
 
1276
        self.assertRaises(errors.ExistingPendingDeletion, self.do_merge, wt, wt)
 
1277
        self.assertRaises(errors.LockError, wt.unlock)
 
1278
 
 
1279
 
 
1280
class TestMerge3Merge(TestCaseWithTransport, TestMergeImplementation):
 
1281
 
 
1282
    merge_type = _mod_merge.Merge3Merger
 
1283
 
 
1284
 
 
1285
class TestWeaveMerge(TestCaseWithTransport, TestMergeImplementation):
 
1286
 
 
1287
    merge_type = _mod_merge.WeaveMerger
 
1288
 
 
1289
 
 
1290
class TestLCAMerge(TestCaseWithTransport, TestMergeImplementation):
 
1291
 
 
1292
    merge_type = _mod_merge.LCAMerger
 
1293
 
 
1294
    def test_merge_move_and_change(self):
 
1295
        self.expectFailure("lca merge doesn't conflict for move and change",
 
1296
            super(TestLCAMerge, self).test_merge_move_and_change)
 
1297
 
 
1298
 
1141
1299
class LoggingMerger(object):
1142
1300
    # These seem to be the required attributes
1143
1301
    requires_base = False
1198
1356
        mem_tree = memorytree.MemoryTree.create_on_branch(builder.get_branch())
1199
1357
        mem_tree.lock_write()
1200
1358
        self.addCleanup(mem_tree.unlock)
1201
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
1359
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
1202
1360
            mem_tree, other_revision_id)
1203
1361
        merger.set_interesting_files(interesting_files)
1204
1362
        # It seems there is no matching function for set_interesting_ids
1978
2136
 
1979
2137
    def do_merge(self, builder, other_revision_id):
1980
2138
        wt = self.get_wt_from_builder(builder)
1981
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2139
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
1982
2140
            wt, other_revision_id)
1983
2141
        merger.merge_type = _mod_merge.Merge3Merger
1984
2142
        return wt, merger.do_merge()
2244
2402
        wt.commit('D merges B & C', rev_id='D-id')
2245
2403
        self.assertEqual('barry', wt.id2path('foo-id'))
2246
2404
        # Check the output of the Merger object directly
2247
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2405
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2248
2406
            wt, 'F-id')
2249
2407
        merger.merge_type = _mod_merge.Merge3Merger
2250
2408
        merge_obj = merger.make_merger()
2300
2458
        wt.commit('F foo => bing', rev_id='F-id')
2301
2459
 
2302
2460
        # Check the output of the Merger object directly
2303
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2461
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2304
2462
            wt, 'E-id')
2305
2463
        merger.merge_type = _mod_merge.Merge3Merger
2306
2464
        merge_obj = merger.make_merger()
2351
2509
        list(wt.iter_changes(wt.basis_tree()))
2352
2510
        wt.commit('D merges B & C, makes it a file', rev_id='D-id')
2353
2511
 
2354
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2512
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2355
2513
            wt, 'E-id')
2356
2514
        merger.merge_type = _mod_merge.Merge3Merger
2357
2515
        merge_obj = merger.make_merger()
2566
2724
        wt.branch.set_last_revision_info(2, 'B-id')
2567
2725
        wt.commit('D', rev_id='D-id', recursive=None)
2568
2726
 
2569
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2727
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2570
2728
            wt, 'E-id')
2571
2729
        merger.merge_type = _mod_merge.Merge3Merger
2572
2730
        merge_obj = merger.make_merger()
2603
2761
        wt.branch.set_last_revision_info(2, 'B-id')
2604
2762
        wt.commit('D', rev_id='D-id', recursive=None)
2605
2763
 
2606
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2764
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2607
2765
            wt, 'E-id')
2608
2766
        merger.merge_type = _mod_merge.Merge3Merger
2609
2767
        merge_obj = merger.make_merger()
2643
2801
        wt.branch.set_last_revision_info(2, 'B-id')
2644
2802
        wt.commit('D', rev_id='D-id', recursive=None)
2645
2803
 
2646
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2804
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2647
2805
            wt, 'E-id')
2648
2806
        merger.merge_type = _mod_merge.Merge3Merger
2649
2807
        merge_obj = merger.make_merger()
2688
2846
        wt.branch.set_last_revision_info(2, 'B-id')
2689
2847
        wt.commit('D', rev_id='D-id', recursive=None)
2690
2848
 
2691
 
        merger = _mod_merge.Merger.from_revision_ids(None,
 
2849
        merger = _mod_merge.Merger.from_revision_ids(progress.DummyProgress(),
2692
2850
            wt, 'E-id')
2693
2851
        merger.merge_type = _mod_merge.Merge3Merger
2694
2852
        merge_obj = merger.make_merger()
2830
2988
            'bval', ['lca1val', 'lca2val', 'lca2val'], 'oval', 'tval')
2831
2989
        self.assertLCAMultiWay('conflict',
2832
2990
            'bval', ['lca1val', 'lca2val', 'lca3val'], 'oval', 'tval')
2833
 
 
2834
 
 
2835
 
class TestConfigurableFileMerger(tests.TestCaseWithTransport):
2836
 
 
2837
 
    def setUp(self):
2838
 
        super(TestConfigurableFileMerger, self).setUp()
2839
 
        self.calls = []
2840
 
 
2841
 
    def get_merger_factory(self):
2842
 
        # Allows  the inner methods to access the test attributes
2843
 
        test = self
2844
 
 
2845
 
        class FooMerger(_mod_merge.ConfigurableFileMerger):
2846
 
            name_prefix = "foo"
2847
 
            default_files = ['bar']
2848
 
 
2849
 
            def merge_text(self, params):
2850
 
                test.calls.append('merge_text')
2851
 
                return ('not_applicable', None)
2852
 
 
2853
 
        def factory(merger):
2854
 
            result = FooMerger(merger)
2855
 
            # Make sure we start with a clean slate
2856
 
            self.assertEqual(None, result.affected_files)
2857
 
            # Track the original merger
2858
 
            self.merger = result
2859
 
            return result
2860
 
 
2861
 
        return factory
2862
 
 
2863
 
    def _install_hook(self, factory):
2864
 
        _mod_merge.Merger.hooks.install_named_hook('merge_file_content',
2865
 
                                                   factory, 'test factory')
2866
 
 
2867
 
    def make_builder(self):
2868
 
        builder = test_merge_core.MergeBuilder(self.test_base_dir)
2869
 
        self.addCleanup(builder.cleanup)
2870
 
        return builder
2871
 
 
2872
 
    def make_text_conflict(self, file_name='bar'):
2873
 
        factory = self.get_merger_factory()
2874
 
        self._install_hook(factory)
2875
 
        builder = self.make_builder()
2876
 
        builder.add_file('bar-id', builder.tree_root, file_name, 'text1', True)
2877
 
        builder.change_contents('bar-id', other='text4', this='text3')
2878
 
        return builder
2879
 
 
2880
 
    def make_kind_change(self):
2881
 
        factory = self.get_merger_factory()
2882
 
        self._install_hook(factory)
2883
 
        builder = self.make_builder()
2884
 
        builder.add_file('bar-id', builder.tree_root, 'bar', 'text1', True,
2885
 
                         this=False)
2886
 
        builder.add_dir('bar-dir', builder.tree_root, 'bar-id',
2887
 
                        base=False, other=False)
2888
 
        return builder
2889
 
 
2890
 
    def test_uses_this_branch(self):
2891
 
        builder = self.make_text_conflict()
2892
 
        tt = builder.make_preview_transform()
2893
 
        self.addCleanup(tt.finalize)
2894
 
 
2895
 
    def test_affected_files_cached(self):
2896
 
        """Ensures that the config variable is cached"""
2897
 
        builder = self.make_text_conflict()
2898
 
        conflicts = builder.merge()
2899
 
        # The hook should set the variable
2900
 
        self.assertEqual(['bar'], self.merger.affected_files)
2901
 
        self.assertEqual(1, len(conflicts))
2902
 
 
2903
 
    def test_hook_called_for_text_conflicts(self):
2904
 
        builder = self.make_text_conflict()
2905
 
        conflicts = builder.merge()
2906
 
        # The hook should call the merge_text() method
2907
 
        self.assertEqual(['merge_text'], self.calls)
2908
 
 
2909
 
    def test_hook_not_called_for_kind_change(self):
2910
 
        builder = self.make_kind_change()
2911
 
        conflicts = builder.merge()
2912
 
        # The hook should not call the merge_text() method
2913
 
        self.assertEqual([], self.calls)
2914
 
 
2915
 
    def test_hook_not_called_for_other_files(self):
2916
 
        builder = self.make_text_conflict('foobar')
2917
 
        conflicts = builder.merge()
2918
 
        # The hook should not call the merge_text() method
2919
 
        self.assertEqual([], self.calls)