~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/repofmt/pack_repo.py

  • Committer: John Arbash Meinel
  • Date: 2009-06-19 17:53:37 UTC
  • mto: This revision was merged to the branch mainline in revision 4466.
  • Revision ID: john@arbash-meinel.com-20090619175337-uozt3bntdd48lh4z
Update time_graph to use X:1 ratios rather than 0.xxx ratios.
It is just easier to track now that the new code is much faster.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2007-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
24
24
 
25
25
from bzrlib import (
26
26
    chk_map,
27
 
    cleanup,
28
27
    debug,
29
28
    graph,
30
29
    osutils,
37
36
    )
38
37
from bzrlib.index import (
39
38
    CombinedGraphIndex,
 
39
    GraphIndex,
 
40
    GraphIndexBuilder,
40
41
    GraphIndexPrefixAdapter,
 
42
    InMemoryGraphIndex,
41
43
    )
42
44
from bzrlib.knit import (
43
45
    KnitPlainFactory,
49
51
""")
50
52
from bzrlib import (
51
53
    bzrdir,
52
 
    btree_index,
53
54
    errors,
54
55
    lockable_files,
55
56
    lockdir,
56
57
    revision as _mod_revision,
 
58
    symbol_versioning,
57
59
    )
58
60
 
59
 
from bzrlib.decorators import needs_write_lock, only_raises
 
61
from bzrlib.decorators import needs_write_lock
 
62
from bzrlib.btree_index import (
 
63
    BTreeGraphIndex,
 
64
    BTreeBuilder,
 
65
    )
60
66
from bzrlib.index import (
61
67
    GraphIndex,
62
68
    InMemoryGraphIndex,
63
69
    )
64
 
from bzrlib.lock import LogicalLockResult
65
70
from bzrlib.repofmt.knitrepo import KnitRepository
66
71
from bzrlib.repository import (
67
72
    CommitBuilder,
68
73
    MetaDirRepositoryFormat,
69
74
    RepositoryFormat,
70
 
    RepositoryWriteLockResult,
71
75
    RootCommitBuilder,
72
 
    StreamSource,
73
76
    )
 
77
import bzrlib.revision as _mod_revision
74
78
from bzrlib.trace import (
75
79
    mutter,
76
 
    note,
77
80
    warning,
78
81
    )
79
82
 
225
228
        return self.index_name('text', name)
226
229
 
227
230
    def _replace_index_with_readonly(self, index_type):
228
 
        unlimited_cache = False
229
 
        if index_type == 'chk':
230
 
            unlimited_cache = True
231
 
        index = self.index_class(self.index_transport,
232
 
                    self.index_name(index_type, self.name),
233
 
                    self.index_sizes[self.index_offset(index_type)],
234
 
                    unlimited_cache=unlimited_cache)
235
 
        if index_type == 'chk':
236
 
            index._leaf_factory = btree_index._gcchk_factory
237
 
        setattr(self, index_type + '_index', index)
 
231
        setattr(self, index_type + '_index',
 
232
            self.index_class(self.index_transport,
 
233
                self.index_name(index_type, self.name),
 
234
                self.index_sizes[self.index_offset(index_type)]))
238
235
 
239
236
 
240
237
class ExistingPack(Pack):
315
312
 
316
313
    def finish(self):
317
314
        self._check_references()
 
315
        new_name = '../packs/' + self.file_name()
 
316
        self.upload_transport.rename(self.file_name(), new_name)
318
317
        index_types = ['revision', 'inventory', 'text', 'signature']
319
318
        if self.chk_index is not None:
320
319
            index_types.append('chk')
323
322
            new_name = '../indices/' + old_name
324
323
            self.upload_transport.rename(old_name, new_name)
325
324
            self._replace_index_with_readonly(index_type)
326
 
        new_name = '../packs/' + self.file_name()
327
 
        self.upload_transport.rename(self.file_name(), new_name)
328
325
        self._state = 'finished'
329
326
 
330
327
    def _get_external_refs(self, index):
429
426
        self._writer.begin()
430
427
        # what state is the pack in? (open, finished, aborted)
431
428
        self._state = 'open'
432
 
        # no name until we finish writing the content
433
 
        self.name = None
434
429
 
435
430
    def abort(self):
436
431
        """Cancel creating this pack."""
457
452
            self.signature_index.key_count() or
458
453
            (self.chk_index is not None and self.chk_index.key_count()))
459
454
 
460
 
    def finish_content(self):
461
 
        if self.name is not None:
462
 
            return
463
 
        self._writer.end()
464
 
        if self._buffer[1]:
465
 
            self._write_data('', flush=True)
466
 
        self.name = self._hash.hexdigest()
467
 
 
468
455
    def finish(self, suspend=False):
469
456
        """Finish the new pack.
470
457
 
476
463
         - stores the index size tuple for the pack in the index_sizes
477
464
           attribute.
478
465
        """
479
 
        self.finish_content()
 
466
        self._writer.end()
 
467
        if self._buffer[1]:
 
468
            self._write_data('', flush=True)
 
469
        self.name = self._hash.hexdigest()
480
470
        if not suspend:
481
471
            self._check_references()
482
472
        # write indices
588
578
                                             flush_func=flush_func)
589
579
        self.add_callback = None
590
580
 
 
581
    def replace_indices(self, index_to_pack, indices):
 
582
        """Replace the current mappings with fresh ones.
 
583
 
 
584
        This should probably not be used eventually, rather incremental add and
 
585
        removal of indices. It has been added during refactoring of existing
 
586
        code.
 
587
 
 
588
        :param index_to_pack: A mapping from index objects to
 
589
            (transport, name) tuples for the pack file data.
 
590
        :param indices: A list of indices.
 
591
        """
 
592
        # refresh the revision pack map dict without replacing the instance.
 
593
        self.index_to_pack.clear()
 
594
        self.index_to_pack.update(index_to_pack)
 
595
        # XXX: API break - clearly a 'replace' method would be good?
 
596
        self.combined_index._indices[:] = indices
 
597
        # the current add nodes callback for the current writable index if
 
598
        # there is one.
 
599
        self.add_callback = None
 
600
 
591
601
    def add_index(self, index, pack):
592
602
        """Add index to the aggregate, which is an index for Pack pack.
593
603
 
600
610
        # expose it to the index map
601
611
        self.index_to_pack[index] = pack.access_tuple()
602
612
        # put it at the front of the linear index list
603
 
        self.combined_index.insert_index(0, index, pack.name)
 
613
        self.combined_index.insert_index(0, index)
604
614
 
605
615
    def add_writable_index(self, index, pack):
606
616
        """Add an index which is able to have data added to it.
626
636
        self.data_access.set_writer(None, None, (None, None))
627
637
        self.index_to_pack.clear()
628
638
        del self.combined_index._indices[:]
629
 
        del self.combined_index._index_names[:]
630
639
        self.add_callback = None
631
640
 
632
 
    def remove_index(self, index):
 
641
    def remove_index(self, index, pack):
633
642
        """Remove index from the indices used to answer queries.
634
643
 
635
644
        :param index: An index from the pack parameter.
 
645
        :param pack: A Pack instance.
636
646
        """
637
647
        del self.index_to_pack[index]
638
 
        pos = self.combined_index._indices.index(index)
639
 
        del self.combined_index._indices[pos]
640
 
        del self.combined_index._index_names[pos]
 
648
        self.combined_index._indices.remove(index)
641
649
        if (self.add_callback is not None and
642
650
            getattr(index, 'add_nodes', None) == self.add_callback):
643
651
            self.add_callback = None
722
730
        :return: A Pack object, or None if nothing was copied.
723
731
        """
724
732
        # open a pack - using the same name as the last temporary file
725
 
        # - which has already been flushed, so it's safe.
 
733
        # - which has already been flushed, so its safe.
726
734
        # XXX: - duplicate code warning with start_write_group; fix before
727
735
        #      considering 'done'.
728
736
        if self._pack_collection._new_pack is not None:
1101
1109
            iterator is a tuple with:
1102
1110
            index, readv_vector, node_vector. readv_vector is a list ready to
1103
1111
            hand to the transport readv method, and node_vector is a list of
1104
 
            (key, eol_flag, references) for the node retrieved by the
 
1112
            (key, eol_flag, references) for the the node retrieved by the
1105
1113
            matching readv_vector.
1106
1114
        """
1107
1115
        # group by pack so we do one readv per pack
1292
1300
        # reinserted, and if d3 has incorrect parents it will also be
1293
1301
        # reinserted. If we insert d3 first, d2 is present (as it was bulk
1294
1302
        # copied), so we will try to delta, but d2 is not currently able to be
1295
 
        # extracted because its basis d1 is not present. Topologically sorting
 
1303
        # extracted because it's basis d1 is not present. Topologically sorting
1296
1304
        # addresses this. The following generates a sort for all the texts that
1297
1305
        # are being inserted without having to reference the entire text key
1298
1306
        # space (we only topo sort the revisions, which is smaller).
1399
1407
        self.inventory_index = AggregateIndex(self.reload_pack_names, flush)
1400
1408
        self.text_index = AggregateIndex(self.reload_pack_names, flush)
1401
1409
        self.signature_index = AggregateIndex(self.reload_pack_names, flush)
1402
 
        all_indices = [self.revision_index, self.inventory_index,
1403
 
                self.text_index, self.signature_index]
1404
1410
        if use_chk_index:
1405
1411
            self.chk_index = AggregateIndex(self.reload_pack_names, flush)
1406
 
            all_indices.append(self.chk_index)
1407
1412
        else:
1408
1413
            # used to determine if we're using a chk_index elsewhere.
1409
1414
            self.chk_index = None
1410
 
        # Tell all the CombinedGraphIndex objects about each other, so they can
1411
 
        # share hints about which pack names to search first.
1412
 
        all_combined = [agg_idx.combined_index for agg_idx in all_indices]
1413
 
        for combined_idx in all_combined:
1414
 
            combined_idx.set_sibling_indices(
1415
 
                set(all_combined).difference([combined_idx]))
1416
1415
        # resumed packs
1417
1416
        self._resumed_packs = []
1418
1417
 
1419
 
    def __repr__(self):
1420
 
        return '%s(%r)' % (self.__class__.__name__, self.repo)
1421
 
 
1422
1418
    def add_pack_to_memory(self, pack):
1423
1419
        """Make a Pack object available to the repository to satisfy queries.
1424
1420
 
1462
1458
        in synchronisation with certain steps. Otherwise the names collection
1463
1459
        is not flushed.
1464
1460
 
1465
 
        :return: Something evaluating true if packing took place.
 
1461
        :return: True if packing took place.
1466
1462
        """
1467
1463
        while True:
1468
1464
            try:
1469
1465
                return self._do_autopack()
1470
 
            except errors.RetryAutopack:
 
1466
            except errors.RetryAutopack, e:
1471
1467
                # If we get a RetryAutopack exception, we should abort the
1472
1468
                # current action, and retry.
1473
1469
                pass
1477
1473
        total_revisions = self.revision_index.combined_index.key_count()
1478
1474
        total_packs = len(self._names)
1479
1475
        if self._max_pack_count(total_revisions) >= total_packs:
1480
 
            return None
 
1476
            return False
1481
1477
        # determine which packs need changing
1482
1478
        pack_distribution = self.pack_distribution(total_revisions)
1483
1479
        existing_packs = []
1505
1501
            'containing %d revisions. Packing %d files into %d affecting %d'
1506
1502
            ' revisions', self, total_packs, total_revisions, num_old_packs,
1507
1503
            num_new_packs, num_revs_affected)
1508
 
        result = self._execute_pack_operations(pack_operations,
 
1504
        self._execute_pack_operations(pack_operations,
1509
1505
                                      reload_func=self._restart_autopack)
1510
1506
        mutter('Auto-packing repository %s completed', self)
1511
 
        return result
 
1507
        return True
1512
1508
 
1513
1509
    def _execute_pack_operations(self, pack_operations, _packer_class=Packer,
1514
1510
                                 reload_func=None):
1516
1512
 
1517
1513
        :param pack_operations: A list of [revision_count, packs_to_combine].
1518
1514
        :param _packer_class: The class of packer to use (default: Packer).
1519
 
        :return: The new pack names.
 
1515
        :return: None.
1520
1516
        """
1521
1517
        for revision_count, packs in pack_operations:
1522
1518
            # we may have no-ops from the setup logic
1538
1534
                self._remove_pack_from_memory(pack)
1539
1535
        # record the newly available packs and stop advertising the old
1540
1536
        # packs
1541
 
        to_be_obsoleted = []
1542
 
        for _, packs in pack_operations:
1543
 
            to_be_obsoleted.extend(packs)
1544
 
        result = self._save_pack_names(clear_obsolete_packs=True,
1545
 
                                       obsolete_packs=to_be_obsoleted)
1546
 
        return result
 
1537
        self._save_pack_names(clear_obsolete_packs=True)
 
1538
        # Move the old packs out of the way now they are no longer referenced.
 
1539
        for revision_count, packs in pack_operations:
 
1540
            self._obsolete_packs(packs)
1547
1541
 
1548
1542
    def _flush_new_pack(self):
1549
1543
        if self._new_pack is not None:
1559
1553
 
1560
1554
    def _already_packed(self):
1561
1555
        """Is the collection already packed?"""
1562
 
        return not (self.repo._format.pack_compresses or (len(self._names) > 1))
 
1556
        return len(self._names) < 2
1563
1557
 
1564
 
    def pack(self, hint=None, clean_obsolete_packs=False):
 
1558
    def pack(self):
1565
1559
        """Pack the pack collection totally."""
1566
1560
        self.ensure_loaded()
1567
1561
        total_packs = len(self._names)
1568
1562
        if self._already_packed():
 
1563
            # This is arguably wrong because we might not be optimal, but for
 
1564
            # now lets leave it in. (e.g. reconcile -> one pack. But not
 
1565
            # optimal.
1569
1566
            return
1570
1567
        total_revisions = self.revision_index.combined_index.key_count()
1571
1568
        # XXX: the following may want to be a class, to pack with a given
1572
1569
        # policy.
1573
1570
        mutter('Packing repository %s, which has %d pack files, '
1574
 
            'containing %d revisions with hint %r.', self, total_packs,
1575
 
            total_revisions, hint)
 
1571
            'containing %d revisions into 1 packs.', self, total_packs,
 
1572
            total_revisions)
1576
1573
        # determine which packs need changing
 
1574
        pack_distribution = [1]
1577
1575
        pack_operations = [[0, []]]
1578
1576
        for pack in self.all_packs():
1579
 
            if hint is None or pack.name in hint:
1580
 
                # Either no hint was provided (so we are packing everything),
1581
 
                # or this pack was included in the hint.
1582
 
                pack_operations[-1][0] += pack.get_revision_count()
1583
 
                pack_operations[-1][1].append(pack)
 
1577
            pack_operations[-1][0] += pack.get_revision_count()
 
1578
            pack_operations[-1][1].append(pack)
1584
1579
        self._execute_pack_operations(pack_operations, OptimisingPacker)
1585
1580
 
1586
 
        if clean_obsolete_packs:
1587
 
            self._clear_obsolete_packs()
1588
 
 
1589
1581
    def plan_autopack_combinations(self, existing_packs, pack_distribution):
1590
1582
        """Plan a pack operation.
1591
1583
 
1600
1592
        pack_operations = [[0, []]]
1601
1593
        # plan out what packs to keep, and what to reorganise
1602
1594
        while len(existing_packs):
1603
 
            # take the largest pack, and if it's less than the head of the
 
1595
            # take the largest pack, and if its less than the head of the
1604
1596
            # distribution chart we will include its contents in the new pack
1605
 
            # for that position. If it's larger, we remove its size from the
 
1597
            # for that position. If its larger, we remove its size from the
1606
1598
            # distribution chart
1607
1599
            next_pack_rev_count, next_pack = existing_packs.pop(0)
1608
1600
            if next_pack_rev_count >= pack_distribution[0]:
1643
1635
 
1644
1636
        :return: True if the disk names had not been previously read.
1645
1637
        """
1646
 
        # NB: if you see an assertion error here, it's probably access against
 
1638
        # NB: if you see an assertion error here, its probably access against
1647
1639
        # an unlocked repo. Naughty.
1648
1640
        if not self.repo.is_locked():
1649
1641
            raise errors.ObjectNotLocked(self.repo)
1679
1671
            txt_index = self._make_index(name, '.tix')
1680
1672
            sig_index = self._make_index(name, '.six')
1681
1673
            if self.chk_index is not None:
1682
 
                chk_index = self._make_index(name, '.cix', is_chk=True)
 
1674
                chk_index = self._make_index(name, '.cix')
1683
1675
            else:
1684
1676
                chk_index = None
1685
1677
            result = ExistingPack(self._pack_transport, name, rev_index,
1704
1696
            txt_index = self._make_index(name, '.tix', resume=True)
1705
1697
            sig_index = self._make_index(name, '.six', resume=True)
1706
1698
            if self.chk_index is not None:
1707
 
                chk_index = self._make_index(name, '.cix', resume=True,
1708
 
                                             is_chk=True)
 
1699
                chk_index = self._make_index(name, '.cix', resume=True)
1709
1700
            else:
1710
1701
                chk_index = None
1711
1702
            result = self.resumed_pack_factory(name, rev_index, inv_index,
1741
1732
        return self._index_class(self.transport, 'pack-names', None
1742
1733
                ).iter_all_entries()
1743
1734
 
1744
 
    def _make_index(self, name, suffix, resume=False, is_chk=False):
 
1735
    def _make_index(self, name, suffix, resume=False):
1745
1736
        size_offset = self._suffix_offsets[suffix]
1746
1737
        index_name = name + suffix
1747
1738
        if resume:
1750
1741
        else:
1751
1742
            transport = self._index_transport
1752
1743
            index_size = self._names[name][size_offset]
1753
 
        index = self._index_class(transport, index_name, index_size,
1754
 
                                  unlimited_cache=is_chk)
1755
 
        if is_chk and self._index_class is btree_index.BTreeGraphIndex: 
1756
 
            index._leaf_factory = btree_index._gcchk_factory
1757
 
        return index
 
1744
        return self._index_class(transport, index_name, index_size)
1758
1745
 
1759
1746
    def _max_pack_count(self, total_revisions):
1760
1747
        """Return the maximum number of packs to use for total revisions.
1788
1775
        :param return: None.
1789
1776
        """
1790
1777
        for pack in packs:
1791
 
            try:
1792
 
                pack.pack_transport.rename(pack.file_name(),
1793
 
                    '../obsolete_packs/' + pack.file_name())
1794
 
            except (errors.PathError, errors.TransportError), e:
1795
 
                # TODO: Should these be warnings or mutters?
1796
 
                mutter("couldn't rename obsolete pack, skipping it:\n%s"
1797
 
                       % (e,))
 
1778
            pack.pack_transport.rename(pack.file_name(),
 
1779
                '../obsolete_packs/' + pack.file_name())
1798
1780
            # TODO: Probably needs to know all possible indices for this pack
1799
1781
            # - or maybe list the directory and move all indices matching this
1800
1782
            # name whether we recognize it or not?
1802
1784
            if self.chk_index is not None:
1803
1785
                suffixes.append('.cix')
1804
1786
            for suffix in suffixes:
1805
 
                try:
1806
 
                    self._index_transport.rename(pack.name + suffix,
1807
 
                        '../obsolete_packs/' + pack.name + suffix)
1808
 
                except (errors.PathError, errors.TransportError), e:
1809
 
                    mutter("couldn't rename obsolete index, skipping it:\n%s"
1810
 
                           % (e,))
 
1787
                self._index_transport.rename(pack.name + suffix,
 
1788
                    '../obsolete_packs/' + pack.name + suffix)
1811
1789
 
1812
1790
    def pack_distribution(self, total_revisions):
1813
1791
        """Generate a list of the number of revisions to put in each pack.
1839
1817
        self._remove_pack_indices(pack)
1840
1818
        self.packs.remove(pack)
1841
1819
 
1842
 
    def _remove_pack_indices(self, pack, ignore_missing=False):
1843
 
        """Remove the indices for pack from the aggregated indices.
1844
 
        
1845
 
        :param ignore_missing: Suppress KeyErrors from calling remove_index.
1846
 
        """
1847
 
        for index_type in Pack.index_definitions.keys():
1848
 
            attr_name = index_type + '_index'
1849
 
            aggregate_index = getattr(self, attr_name)
1850
 
            if aggregate_index is not None:
1851
 
                pack_index = getattr(pack, attr_name)
1852
 
                try:
1853
 
                    aggregate_index.remove_index(pack_index)
1854
 
                except KeyError:
1855
 
                    if ignore_missing:
1856
 
                        continue
1857
 
                    raise
 
1820
    def _remove_pack_indices(self, pack):
 
1821
        """Remove the indices for pack from the aggregated indices."""
 
1822
        self.revision_index.remove_index(pack.revision_index, pack)
 
1823
        self.inventory_index.remove_index(pack.inventory_index, pack)
 
1824
        self.text_index.remove_index(pack.text_index, pack)
 
1825
        self.signature_index.remove_index(pack.signature_index, pack)
 
1826
        if self.chk_index is not None:
 
1827
            self.chk_index.remove_index(pack.chk_index, pack)
1858
1828
 
1859
1829
    def reset(self):
1860
1830
        """Clear all cached data."""
1893
1863
        disk_nodes = set()
1894
1864
        for index, key, value in self._iter_disk_pack_index():
1895
1865
            disk_nodes.add((key, value))
1896
 
        orig_disk_nodes = set(disk_nodes)
1897
1866
 
1898
1867
        # do a two-way diff against our original content
1899
1868
        current_nodes = set()
1912
1881
        disk_nodes.difference_update(deleted_nodes)
1913
1882
        disk_nodes.update(new_nodes)
1914
1883
 
1915
 
        return disk_nodes, deleted_nodes, new_nodes, orig_disk_nodes
 
1884
        return disk_nodes, deleted_nodes, new_nodes
1916
1885
 
1917
1886
    def _syncronize_pack_names_from_disk_nodes(self, disk_nodes):
1918
1887
        """Given the correct set of pack files, update our saved info.
1946
1915
                    # disk index because the set values are the same, unless
1947
1916
                    # the only index shows up as deleted by the set difference
1948
1917
                    # - which it may. Until there is a specific test for this,
1949
 
                    # assume it's broken. RBC 20071017.
 
1918
                    # assume its broken. RBC 20071017.
1950
1919
                    self._remove_pack_from_memory(self.get_pack_by_name(name))
1951
1920
                    self._names[name] = sizes
1952
1921
                    self.get_pack_by_name(name)
1958
1927
                added.append(name)
1959
1928
        return removed, added, modified
1960
1929
 
1961
 
    def _save_pack_names(self, clear_obsolete_packs=False, obsolete_packs=None):
 
1930
    def _save_pack_names(self, clear_obsolete_packs=False):
1962
1931
        """Save the list of packs.
1963
1932
 
1964
1933
        This will take out the mutex around the pack names list for the
1968
1937
 
1969
1938
        :param clear_obsolete_packs: If True, clear out the contents of the
1970
1939
            obsolete_packs directory.
1971
 
        :param obsolete_packs: Packs that are obsolete once the new pack-names
1972
 
            file has been written.
1973
 
        :return: A list of the names saved that were not previously on disk.
1974
1940
        """
1975
 
        already_obsolete = []
1976
1941
        self.lock_names()
1977
1942
        try:
1978
1943
            builder = self._index_builder_class()
1979
 
            (disk_nodes, deleted_nodes, new_nodes,
1980
 
             orig_disk_nodes) = self._diff_pack_names()
 
1944
            disk_nodes, deleted_nodes, new_nodes = self._diff_pack_names()
1981
1945
            # TODO: handle same-name, index-size-changes here -
1982
1946
            # e.g. use the value from disk, not ours, *unless* we're the one
1983
1947
            # changing it.
1985
1949
                builder.add_node(key, value)
1986
1950
            self.transport.put_file('pack-names', builder.finish(),
1987
1951
                mode=self.repo.bzrdir._get_file_mode())
 
1952
            # move the baseline forward
1988
1953
            self._packs_at_load = disk_nodes
1989
1954
            if clear_obsolete_packs:
1990
 
                to_preserve = None
1991
 
                if obsolete_packs:
1992
 
                    to_preserve = set([o.name for o in obsolete_packs])
1993
 
                already_obsolete = self._clear_obsolete_packs(to_preserve)
 
1955
                self._clear_obsolete_packs()
1994
1956
        finally:
1995
1957
            self._unlock_names()
1996
1958
        # synchronise the memory packs list with what we just wrote:
1997
1959
        self._syncronize_pack_names_from_disk_nodes(disk_nodes)
1998
 
        if obsolete_packs:
1999
 
            # TODO: We could add one more condition here. "if o.name not in
2000
 
            #       orig_disk_nodes and o != the new_pack we haven't written to
2001
 
            #       disk yet. However, the new pack object is not easily
2002
 
            #       accessible here (it would have to be passed through the
2003
 
            #       autopacking code, etc.)
2004
 
            obsolete_packs = [o for o in obsolete_packs
2005
 
                              if o.name not in already_obsolete]
2006
 
            self._obsolete_packs(obsolete_packs)
2007
 
        return [new_node[0][0] for new_node in new_nodes]
2008
1960
 
2009
1961
    def reload_pack_names(self):
2010
1962
        """Sync our pack listing with what is present in the repository.
2017
1969
        """
2018
1970
        # The ensure_loaded call is to handle the case where the first call
2019
1971
        # made involving the collection was to reload_pack_names, where we 
2020
 
        # don't have a view of disk contents. It's a bit of a bandaid, and
2021
 
        # causes two reads of pack-names, but it's a rare corner case not
2022
 
        # struck with regular push/pull etc.
 
1972
        # don't have a view of disk contents. Its a bit of a bandaid, and
 
1973
        # causes two reads of pack-names, but its a rare corner case not struck
 
1974
        # with regular push/pull etc.
2023
1975
        first_read = self.ensure_loaded()
2024
1976
        if first_read:
2025
1977
            return True
2026
1978
        # out the new value.
2027
 
        (disk_nodes, deleted_nodes, new_nodes,
2028
 
         orig_disk_nodes) = self._diff_pack_names()
2029
 
        # _packs_at_load is meant to be the explicit list of names in
2030
 
        # 'pack-names' at then start. As such, it should not contain any
2031
 
        # pending names that haven't been written out yet.
2032
 
        self._packs_at_load = orig_disk_nodes
 
1979
        disk_nodes, _, _ = self._diff_pack_names()
 
1980
        self._packs_at_load = disk_nodes
2033
1981
        (removed, added,
2034
1982
         modified) = self._syncronize_pack_names_from_disk_nodes(disk_nodes)
2035
1983
        if removed or added or modified:
2044
1992
            raise
2045
1993
        raise errors.RetryAutopack(self.repo, False, sys.exc_info())
2046
1994
 
2047
 
    def _clear_obsolete_packs(self, preserve=None):
 
1995
    def _clear_obsolete_packs(self):
2048
1996
        """Delete everything from the obsolete-packs directory.
2049
 
 
2050
 
        :return: A list of pack identifiers (the filename without '.pack') that
2051
 
            were found in obsolete_packs.
2052
1997
        """
2053
 
        found = []
2054
1998
        obsolete_pack_transport = self.transport.clone('obsolete_packs')
2055
 
        if preserve is None:
2056
 
            preserve = set()
2057
1999
        for filename in obsolete_pack_transport.list_dir('.'):
2058
 
            name, ext = osutils.splitext(filename)
2059
 
            if ext == '.pack':
2060
 
                found.append(name)
2061
 
            if name in preserve:
2062
 
                continue
2063
2000
            try:
2064
2001
                obsolete_pack_transport.delete(filename)
2065
2002
            except (errors.PathError, errors.TransportError), e:
2066
 
                warning("couldn't delete obsolete pack, skipping it:\n%s"
2067
 
                        % (e,))
2068
 
        return found
 
2003
                warning("couldn't delete obsolete pack, skipping it:\n%s" % (e,))
2069
2004
 
2070
2005
    def _start_write_group(self):
2071
2006
        # Do not permit preparation for writing if we're not in a 'write lock'.
2098
2033
        # FIXME: just drop the transient index.
2099
2034
        # forget what names there are
2100
2035
        if self._new_pack is not None:
2101
 
            operation = cleanup.OperationWithCleanups(self._new_pack.abort)
2102
 
            operation.add_cleanup(setattr, self, '_new_pack', None)
2103
 
            # If we aborted while in the middle of finishing the write
2104
 
            # group, _remove_pack_indices could fail because the indexes are
2105
 
            # already gone.  But they're not there we shouldn't fail in this
2106
 
            # case, so we pass ignore_missing=True.
2107
 
            operation.add_cleanup(self._remove_pack_indices, self._new_pack,
2108
 
                ignore_missing=True)
2109
 
            operation.run_simple()
 
2036
            try:
 
2037
                self._new_pack.abort()
 
2038
            finally:
 
2039
                # XXX: If we aborted while in the middle of finishing the write
 
2040
                # group, _remove_pack_indices can fail because the indexes are
 
2041
                # already gone.  If they're not there we shouldn't fail in this
 
2042
                # case.  -- mbp 20081113
 
2043
                self._remove_pack_indices(self._new_pack)
 
2044
                self._new_pack = None
2110
2045
        for resumed_pack in self._resumed_packs:
2111
 
            operation = cleanup.OperationWithCleanups(resumed_pack.abort)
2112
 
            # See comment in previous finally block.
2113
 
            operation.add_cleanup(self._remove_pack_indices, resumed_pack,
2114
 
                ignore_missing=True)
2115
 
            operation.run_simple()
 
2046
            try:
 
2047
                resumed_pack.abort()
 
2048
            finally:
 
2049
                # See comment in previous finally block.
 
2050
                try:
 
2051
                    self._remove_pack_indices(resumed_pack)
 
2052
                except KeyError:
 
2053
                    pass
2116
2054
        del self._resumed_packs[:]
2117
2055
 
2118
2056
    def _remove_resumed_pack_indices(self):
2120
2058
            self._remove_pack_indices(resumed_pack)
2121
2059
        del self._resumed_packs[:]
2122
2060
 
2123
 
    def _check_new_inventories(self):
2124
 
        """Detect missing inventories in this write group.
2125
 
 
2126
 
        :returns: list of strs, summarising any problems found.  If the list is
2127
 
            empty no problems were found.
2128
 
        """
2129
 
        # The base implementation does no checks.  GCRepositoryPackCollection
2130
 
        # overrides this.
2131
 
        return []
2132
 
        
2133
2061
    def _commit_write_group(self):
2134
2062
        all_missing = set()
2135
2063
        for prefix, versioned_file in (
2144
2072
            raise errors.BzrCheckError(
2145
2073
                "Repository %s has missing compression parent(s) %r "
2146
2074
                 % (self.repo, sorted(all_missing)))
2147
 
        problems = self._check_new_inventories()
2148
 
        if problems:
2149
 
            problems_summary = '\n'.join(problems)
2150
 
            raise errors.BzrCheckError(
2151
 
                "Cannot add revision(s) to repository: " + problems_summary)
2152
2075
        self._remove_pack_indices(self._new_pack)
2153
 
        any_new_content = False
 
2076
        should_autopack = False
2154
2077
        if self._new_pack.data_inserted():
2155
2078
            # get all the data to disk and read to use
2156
2079
            self._new_pack.finish()
2157
2080
            self.allocate(self._new_pack)
2158
2081
            self._new_pack = None
2159
 
            any_new_content = True
 
2082
            should_autopack = True
2160
2083
        else:
2161
2084
            self._new_pack.abort()
2162
2085
            self._new_pack = None
2167
2090
            self._remove_pack_from_memory(resumed_pack)
2168
2091
            resumed_pack.finish()
2169
2092
            self.allocate(resumed_pack)
2170
 
            any_new_content = True
 
2093
            should_autopack = True
2171
2094
        del self._resumed_packs[:]
2172
 
        if any_new_content:
2173
 
            result = self.autopack()
2174
 
            if not result:
 
2095
        if should_autopack:
 
2096
            if not self.autopack():
2175
2097
                # when autopack takes no steps, the names list is still
2176
2098
                # unsaved.
2177
 
                return self._save_pack_names()
2178
 
            return result
2179
 
        return []
 
2099
                self._save_pack_names()
2180
2100
 
2181
2101
    def _suspend_write_group(self):
2182
2102
        tokens = [pack.name for pack in self._resumed_packs]
2284
2204
        self._reconcile_fixes_text_parents = True
2285
2205
        self._reconcile_backsup_inventory = False
2286
2206
 
2287
 
    def _warn_if_deprecated(self, branch=None):
 
2207
    def _warn_if_deprecated(self):
2288
2208
        # This class isn't deprecated, but one sub-format is
2289
2209
        if isinstance(self._format, RepositoryFormatKnitPack5RichRootBroken):
2290
 
            super(KnitPackRepository, self)._warn_if_deprecated(branch)
 
2210
            from bzrlib import repository
 
2211
            if repository._deprecation_warning_done:
 
2212
                return
 
2213
            repository._deprecation_warning_done = True
 
2214
            warning("Format %s for %s is deprecated - please use"
 
2215
                    " 'bzr upgrade --1.6.1-rich-root'"
 
2216
                    % (self._format, self.bzrdir.transport.base))
2291
2217
 
2292
2218
    def _abort_write_group(self):
2293
 
        self.revisions._index._key_dependencies.clear()
 
2219
        self.revisions._index._key_dependencies.refs.clear()
2294
2220
        self._pack_collection._abort_write_group()
2295
2221
 
2296
 
    def _get_source(self, to_format):
2297
 
        if to_format.network_name() == self._format.network_name():
2298
 
            return KnitPackStreamSource(self, to_format)
2299
 
        return super(KnitPackRepository, self)._get_source(to_format)
 
2222
    def _find_inconsistent_revision_parents(self):
 
2223
        """Find revisions with incorrectly cached parents.
 
2224
 
 
2225
        :returns: an iterator yielding tuples of (revison-id, parents-in-index,
 
2226
            parents-in-revision).
 
2227
        """
 
2228
        if not self.is_locked():
 
2229
            raise errors.ObjectNotLocked(self)
 
2230
        pb = ui.ui_factory.nested_progress_bar()
 
2231
        result = []
 
2232
        try:
 
2233
            revision_nodes = self._pack_collection.revision_index \
 
2234
                .combined_index.iter_all_entries()
 
2235
            index_positions = []
 
2236
            # Get the cached index values for all revisions, and also the
 
2237
            # location in each index of the revision text so we can perform
 
2238
            # linear IO.
 
2239
            for index, key, value, refs in revision_nodes:
 
2240
                node = (index, key, value, refs)
 
2241
                index_memo = self.revisions._index._node_to_position(node)
 
2242
                if index_memo[0] != index:
 
2243
                    raise AssertionError('%r != %r' % (index_memo[0], index))
 
2244
                index_positions.append((index_memo, key[0],
 
2245
                                       tuple(parent[0] for parent in refs[0])))
 
2246
                pb.update("Reading revision index", 0, 0)
 
2247
            index_positions.sort()
 
2248
            batch_size = 1000
 
2249
            pb.update("Checking cached revision graph", 0,
 
2250
                      len(index_positions))
 
2251
            for offset in xrange(0, len(index_positions), 1000):
 
2252
                pb.update("Checking cached revision graph", offset)
 
2253
                to_query = index_positions[offset:offset + batch_size]
 
2254
                if not to_query:
 
2255
                    break
 
2256
                rev_ids = [item[1] for item in to_query]
 
2257
                revs = self.get_revisions(rev_ids)
 
2258
                for revision, item in zip(revs, to_query):
 
2259
                    index_parents = item[2]
 
2260
                    rev_parents = tuple(revision.parent_ids)
 
2261
                    if index_parents != rev_parents:
 
2262
                        result.append((revision.revision_id, index_parents,
 
2263
                                       rev_parents))
 
2264
        finally:
 
2265
            pb.finished()
 
2266
        return result
2300
2267
 
2301
2268
    def _make_parents_provider(self):
2302
2269
        return graph.CachingParentsProvider(self)
2310
2277
        self._pack_collection._start_write_group()
2311
2278
 
2312
2279
    def _commit_write_group(self):
2313
 
        hint = self._pack_collection._commit_write_group()
2314
 
        self.revisions._index._key_dependencies.clear()
2315
 
        return hint
 
2280
        self.revisions._index._key_dependencies.refs.clear()
 
2281
        return self._pack_collection._commit_write_group()
2316
2282
 
2317
2283
    def suspend_write_group(self):
2318
2284
        # XXX check self._write_group is self.get_transaction()?
2319
2285
        tokens = self._pack_collection._suspend_write_group()
2320
 
        self.revisions._index._key_dependencies.clear()
 
2286
        self.revisions._index._key_dependencies.refs.clear()
2321
2287
        self._write_group = None
2322
2288
        return tokens
2323
2289
 
2344
2310
        return self._write_lock_count
2345
2311
 
2346
2312
    def lock_write(self, token=None):
2347
 
        """Lock the repository for writes.
2348
 
 
2349
 
        :return: A bzrlib.repository.RepositoryWriteLockResult.
2350
 
        """
2351
2313
        locked = self.is_locked()
2352
2314
        if not self._write_lock_count and locked:
2353
2315
            raise errors.ReadOnlyError(self)
2355
2317
        if self._write_lock_count == 1:
2356
2318
            self._transaction = transactions.WriteTransaction()
2357
2319
        if not locked:
2358
 
            if 'relock' in debug.debug_flags and self._prev_lock == 'w':
2359
 
                note('%r was write locked again', self)
2360
 
            self._prev_lock = 'w'
2361
2320
            for repo in self._fallback_repositories:
2362
2321
                # Writes don't affect fallback repos
2363
2322
                repo.lock_read()
2364
2323
            self._refresh_data()
2365
 
        return RepositoryWriteLockResult(self.unlock, None)
2366
2324
 
2367
2325
    def lock_read(self):
2368
 
        """Lock the repository for reads.
2369
 
 
2370
 
        :return: A bzrlib.lock.LogicalLockResult.
2371
 
        """
2372
2326
        locked = self.is_locked()
2373
2327
        if self._write_lock_count:
2374
2328
            self._write_lock_count += 1
2375
2329
        else:
2376
2330
            self.control_files.lock_read()
2377
2331
        if not locked:
2378
 
            if 'relock' in debug.debug_flags and self._prev_lock == 'r':
2379
 
                note('%r was read locked again', self)
2380
 
            self._prev_lock = 'r'
2381
2332
            for repo in self._fallback_repositories:
2382
2333
                repo.lock_read()
2383
2334
            self._refresh_data()
2384
 
        return LogicalLockResult(self.unlock)
2385
2335
 
2386
2336
    def leave_lock_in_place(self):
2387
2337
        # not supported - raise an error
2392
2342
        raise NotImplementedError(self.dont_leave_lock_in_place)
2393
2343
 
2394
2344
    @needs_write_lock
2395
 
    def pack(self, hint=None, clean_obsolete_packs=False):
 
2345
    def pack(self):
2396
2346
        """Compress the data within the repository.
2397
2347
 
2398
2348
        This will pack all the data to a single pack. In future it may
2399
2349
        recompress deltas or do other such expensive operations.
2400
2350
        """
2401
 
        self._pack_collection.pack(hint=hint, clean_obsolete_packs=clean_obsolete_packs)
 
2351
        self._pack_collection.pack()
2402
2352
 
2403
2353
    @needs_write_lock
2404
2354
    def reconcile(self, other=None, thorough=False):
2412
2362
        packer = ReconcilePacker(collection, packs, extension, revs)
2413
2363
        return packer.pack(pb)
2414
2364
 
2415
 
    @only_raises(errors.LockNotHeld, errors.LockBroken)
2416
2365
    def unlock(self):
2417
2366
        if self._write_lock_count == 1 and self._write_group is not None:
2418
2367
            self.abort_write_group()
2435
2384
                repo.unlock()
2436
2385
 
2437
2386
 
2438
 
class KnitPackStreamSource(StreamSource):
2439
 
    """A StreamSource used to transfer data between same-format KnitPack repos.
2440
 
 
2441
 
    This source assumes:
2442
 
        1) Same serialization format for all objects
2443
 
        2) Same root information
2444
 
        3) XML format inventories
2445
 
        4) Atomic inserts (so we can stream inventory texts before text
2446
 
           content)
2447
 
        5) No chk_bytes
2448
 
    """
2449
 
 
2450
 
    def __init__(self, from_repository, to_format):
2451
 
        super(KnitPackStreamSource, self).__init__(from_repository, to_format)
2452
 
        self._text_keys = None
2453
 
        self._text_fetch_order = 'unordered'
2454
 
 
2455
 
    def _get_filtered_inv_stream(self, revision_ids):
2456
 
        from_repo = self.from_repository
2457
 
        parent_ids = from_repo._find_parent_ids_of_revisions(revision_ids)
2458
 
        parent_keys = [(p,) for p in parent_ids]
2459
 
        find_text_keys = from_repo._find_text_key_references_from_xml_inventory_lines
2460
 
        parent_text_keys = set(find_text_keys(
2461
 
            from_repo._inventory_xml_lines_for_keys(parent_keys)))
2462
 
        content_text_keys = set()
2463
 
        knit = KnitVersionedFiles(None, None)
2464
 
        factory = KnitPlainFactory()
2465
 
        def find_text_keys_from_content(record):
2466
 
            if record.storage_kind not in ('knit-delta-gz', 'knit-ft-gz'):
2467
 
                raise ValueError("Unknown content storage kind for"
2468
 
                    " inventory text: %s" % (record.storage_kind,))
2469
 
            # It's a knit record, it has a _raw_record field (even if it was
2470
 
            # reconstituted from a network stream).
2471
 
            raw_data = record._raw_record
2472
 
            # read the entire thing
2473
 
            revision_id = record.key[-1]
2474
 
            content, _ = knit._parse_record(revision_id, raw_data)
2475
 
            if record.storage_kind == 'knit-delta-gz':
2476
 
                line_iterator = factory.get_linedelta_content(content)
2477
 
            elif record.storage_kind == 'knit-ft-gz':
2478
 
                line_iterator = factory.get_fulltext_content(content)
2479
 
            content_text_keys.update(find_text_keys(
2480
 
                [(line, revision_id) for line in line_iterator]))
2481
 
        revision_keys = [(r,) for r in revision_ids]
2482
 
        def _filtered_inv_stream():
2483
 
            source_vf = from_repo.inventories
2484
 
            stream = source_vf.get_record_stream(revision_keys,
2485
 
                                                 'unordered', False)
2486
 
            for record in stream:
2487
 
                if record.storage_kind == 'absent':
2488
 
                    raise errors.NoSuchRevision(from_repo, record.key)
2489
 
                find_text_keys_from_content(record)
2490
 
                yield record
2491
 
            self._text_keys = content_text_keys - parent_text_keys
2492
 
        return ('inventories', _filtered_inv_stream())
2493
 
 
2494
 
    def _get_text_stream(self):
2495
 
        # Note: We know we don't have to handle adding root keys, because both
2496
 
        # the source and target are the identical network name.
2497
 
        text_stream = self.from_repository.texts.get_record_stream(
2498
 
                        self._text_keys, self._text_fetch_order, False)
2499
 
        return ('texts', text_stream)
2500
 
 
2501
 
    def get_stream(self, search):
2502
 
        revision_ids = search.get_keys()
2503
 
        for stream_info in self._fetch_revision_texts(revision_ids):
2504
 
            yield stream_info
2505
 
        self._revision_keys = [(rev_id,) for rev_id in revision_ids]
2506
 
        yield self._get_filtered_inv_stream(revision_ids)
2507
 
        yield self._get_text_stream()
2508
 
 
2509
 
 
2510
 
 
2511
2387
class RepositoryFormatPack(MetaDirRepositoryFormat):
2512
2388
    """Format logic for pack structured repositories.
2513
2389
 
2560
2436
        utf8_files = [('format', self.get_format_string())]
2561
2437
 
2562
2438
        self._upload_blank_content(a_bzrdir, dirs, files, utf8_files, shared)
2563
 
        repository = self.open(a_bzrdir=a_bzrdir, _found=True)
2564
 
        self._run_post_repo_init_hooks(repository, a_bzrdir, shared)
2565
 
        return repository
 
2439
        return self.open(a_bzrdir=a_bzrdir, _found=True)
2566
2440
 
2567
2441
    def open(self, a_bzrdir, _found=False, _override_transport=None):
2568
2442
        """See RepositoryFormat.open().
2617
2491
        """See RepositoryFormat.get_format_description()."""
2618
2492
        return "Packs containing knits without subtree support"
2619
2493
 
 
2494
    def check_conversion_target(self, target_format):
 
2495
        pass
 
2496
 
2620
2497
 
2621
2498
class RepositoryFormatKnitPack3(RepositoryFormatPack):
2622
2499
    """A subtrees parameterized Pack repository.
2631
2508
    repository_class = KnitPackRepository
2632
2509
    _commit_builder_class = PackRootCommitBuilder
2633
2510
    rich_root_data = True
2634
 
    experimental = True
2635
2511
    supports_tree_reference = True
2636
2512
    @property
2637
2513
    def _serializer(self):
2649
2525
 
2650
2526
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2651
2527
 
 
2528
    def check_conversion_target(self, target_format):
 
2529
        if not target_format.rich_root_data:
 
2530
            raise errors.BadConversionTarget(
 
2531
                'Does not support rich root data.', target_format)
 
2532
        if not getattr(target_format, 'supports_tree_reference', False):
 
2533
            raise errors.BadConversionTarget(
 
2534
                'Does not support nested trees', target_format)
 
2535
 
2652
2536
    def get_format_string(self):
2653
2537
        """See RepositoryFormat.get_format_string()."""
2654
2538
        return "Bazaar pack repository format 1 with subtree support (needs bzr 0.92)\n"
2687
2571
 
2688
2572
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2689
2573
 
 
2574
    def check_conversion_target(self, target_format):
 
2575
        if not target_format.rich_root_data:
 
2576
            raise errors.BadConversionTarget(
 
2577
                'Does not support rich root data.', target_format)
 
2578
 
2690
2579
    def get_format_string(self):
2691
2580
        """See RepositoryFormat.get_format_string()."""
2692
2581
        return ("Bazaar pack repository format 1 with rich root"
2733
2622
        """See RepositoryFormat.get_format_description()."""
2734
2623
        return "Packs 5 (adds stacking support, requires bzr 1.6)"
2735
2624
 
 
2625
    def check_conversion_target(self, target_format):
 
2626
        pass
 
2627
 
2736
2628
 
2737
2629
class RepositoryFormatKnitPack5RichRoot(RepositoryFormatPack):
2738
2630
    """A repository with rich roots and stacking.
2765
2657
 
2766
2658
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2767
2659
 
 
2660
    def check_conversion_target(self, target_format):
 
2661
        if not target_format.rich_root_data:
 
2662
            raise errors.BadConversionTarget(
 
2663
                'Does not support rich root data.', target_format)
 
2664
 
2768
2665
    def get_format_string(self):
2769
2666
        """See RepositoryFormat.get_format_string()."""
2770
2667
        return "Bazaar RepositoryFormatKnitPack5RichRoot (bzr 1.6.1)\n"
2811
2708
 
2812
2709
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2813
2710
 
 
2711
    def check_conversion_target(self, target_format):
 
2712
        if not target_format.rich_root_data:
 
2713
            raise errors.BadConversionTarget(
 
2714
                'Does not support rich root data.', target_format)
 
2715
 
2814
2716
    def get_format_string(self):
2815
2717
        """See RepositoryFormat.get_format_string()."""
2816
2718
        return "Bazaar RepositoryFormatKnitPack5RichRoot (bzr 1.6)\n"
2831
2733
    _commit_builder_class = PackCommitBuilder
2832
2734
    supports_external_lookups = True
2833
2735
    # What index classes to use
2834
 
    index_builder_class = btree_index.BTreeBuilder
2835
 
    index_class = btree_index.BTreeGraphIndex
 
2736
    index_builder_class = BTreeBuilder
 
2737
    index_class = BTreeGraphIndex
2836
2738
 
2837
2739
    @property
2838
2740
    def _serializer(self):
2854
2756
        """See RepositoryFormat.get_format_description()."""
2855
2757
        return "Packs 6 (uses btree indexes, requires bzr 1.9)"
2856
2758
 
 
2759
    def check_conversion_target(self, target_format):
 
2760
        pass
 
2761
 
2857
2762
 
2858
2763
class RepositoryFormatKnitPack6RichRoot(RepositoryFormatPack):
2859
2764
    """A repository with rich roots, no subtrees, stacking and btree indexes.
2867
2772
    supports_tree_reference = False # no subtrees
2868
2773
    supports_external_lookups = True
2869
2774
    # What index classes to use
2870
 
    index_builder_class = btree_index.BTreeBuilder
2871
 
    index_class = btree_index.BTreeGraphIndex
 
2775
    index_builder_class = BTreeBuilder
 
2776
    index_class = BTreeGraphIndex
2872
2777
 
2873
2778
    @property
2874
2779
    def _serializer(self):
2883
2788
 
2884
2789
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2885
2790
 
 
2791
    def check_conversion_target(self, target_format):
 
2792
        if not target_format.rich_root_data:
 
2793
            raise errors.BadConversionTarget(
 
2794
                'Does not support rich root data.', target_format)
 
2795
 
2886
2796
    def get_format_string(self):
2887
2797
        """See RepositoryFormat.get_format_string()."""
2888
2798
        return "Bazaar RepositoryFormatKnitPack6RichRoot (bzr 1.9)\n"
2905
2815
    repository_class = KnitPackRepository
2906
2816
    _commit_builder_class = PackRootCommitBuilder
2907
2817
    rich_root_data = True
2908
 
    experimental = True
2909
2818
    supports_tree_reference = True
2910
2819
    supports_external_lookups = True
2911
2820
    # What index classes to use
2912
 
    index_builder_class = btree_index.BTreeBuilder
2913
 
    index_class = btree_index.BTreeGraphIndex
 
2821
    index_builder_class = BTreeBuilder
 
2822
    index_class = BTreeGraphIndex
2914
2823
 
2915
2824
    @property
2916
2825
    def _serializer(self):
2918
2827
 
2919
2828
    def _get_matching_bzrdir(self):
2920
2829
        return bzrdir.format_registry.make_bzrdir(
2921
 
            'development5-subtree')
 
2830
            'development-subtree')
2922
2831
 
2923
2832
    def _ignore_setting_bzrdir(self, format):
2924
2833
        pass
2925
2834
 
2926
2835
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2927
2836
 
 
2837
    def check_conversion_target(self, target_format):
 
2838
        if not target_format.rich_root_data:
 
2839
            raise errors.BadConversionTarget(
 
2840
                'Does not support rich root data.', target_format)
 
2841
        if not getattr(target_format, 'supports_tree_reference', False):
 
2842
            raise errors.BadConversionTarget(
 
2843
                'Does not support nested trees', target_format)
 
2844
 
2928
2845
    def get_format_string(self):
2929
2846
        """See RepositoryFormat.get_format_string()."""
2930
2847
        return ("Bazaar development format 2 with subtree support "