← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_shelf.py

  • Committer: Vincent Ladeuil
  • Date: 2009-04-27 16:10:10 UTC
  • mto: (4310.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 4311.
  • Revision ID: v.ladeuil+lp@free.fr-20090427161010-7swfzeagf63cpixd
Fix bug #367726 by reverting some default user handling introduced
while fixing bug #256612.

* bzrlib/transport/ssh.py:
(_paramiko_auth): Explicitly use getpass.getuser() as default
user.

* bzrlib/transport/ftp/_gssapi.py:
(GSSAPIFtpTransport._create_connection): Explicitly use
getpass.getuser() as default user.

* bzrlib/transport/ftp/__init__.py:
(FtpTransport._create_connection): Explicitly use
getpass.getuser() as default user.

* bzrlib/tests/test_sftp_transport.py:
(TestUsesAuthConfig.test_sftp_is_none_if_no_config)
(TestUsesAuthConfig.test_sftp_doesnt_prompt_username): Revert to
None as the default user.

* bzrlib/tests/test_remote.py:
(TestRemoteSSHTransportAuthentication): The really offending one:
revert to None as the default user.

* bzrlib/tests/test_config.py:
(TestAuthenticationConfig.test_username_default_no_prompt): Update
test (and some PEP8).

* bzrlib/smtp_connection.py:
(SMTPConnection._authenticate): Revert to None as the default
user.

* bzrlib/plugins/launchpad/account.py:
(_get_auth_user): Revert default value handling.

* bzrlib/config.py:
(AuthenticationConfig.get_user): Fix doc-string. Leave default
value handling to callers.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_shelf.py
1
 
# Copyright (C) 2008, 2009, 2010 Canonical Ltd
 
1
# Copyright (C) 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
40
40
 
41
41
class TestPrepareShelf(tests.TestCaseWithTransport):
42
42
 
43
 
    def prepare_shelve_rename(self):
 
43
    def test_shelve_rename(self):
44
44
        tree = self.make_branch_and_tree('.')
45
45
        self.build_tree(['foo'])
46
46
        tree.add(['foo'], ['foo-id'])
47
47
        tree.commit('foo')
48
48
        tree.rename_one('foo', 'bar')
49
 
        tree.lock_tree_write()
50
 
        self.addCleanup(tree.unlock)
51
49
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
52
50
        self.addCleanup(creator.finalize)
53
51
        self.assertEqual([('rename', 'foo-id', 'foo', 'bar')],
54
52
                          list(creator.iter_shelvable()))
55
 
        return creator
56
 
 
57
 
    def check_shelve_rename(self, creator):
 
53
        creator.shelve_rename('foo-id')
58
54
        work_trans_id = creator.work_transform.trans_id_file_id('foo-id')
59
55
        self.assertEqual('foo', creator.work_transform.final_name(
60
56
                         work_trans_id))
62
58
        self.assertEqual('bar', creator.shelf_transform.final_name(
63
59
                         shelf_trans_id))
64
60
 
65
 
    def test_shelve_rename(self):
66
 
        creator = self.prepare_shelve_rename()
67
 
        creator.shelve_rename('foo-id')
68
 
        self.check_shelve_rename(creator)
69
 
 
70
 
    def test_shelve_change_handles_rename(self):
71
 
        creator = self.prepare_shelve_rename()
72
 
        creator.shelve_change(('rename', 'foo-id', 'foo', 'bar'))
73
 
        self.check_shelve_rename(creator)
74
 
 
75
 
    def prepare_shelve_move(self):
 
61
    def test_shelve_move(self):
76
62
        tree = self.make_branch_and_tree('.')
77
63
        self.build_tree(['foo/', 'bar/', 'foo/baz'])
78
64
        tree.add(['foo', 'bar', 'foo/baz'], ['foo-id', 'bar-id', 'baz-id'])
79
65
        tree.commit('foo')
80
66
        tree.rename_one('foo/baz', 'bar/baz')
81
 
        tree.lock_tree_write()
82
 
        self.addCleanup(tree.unlock)
83
67
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
84
68
        self.addCleanup(creator.finalize)
85
69
        self.assertEqual([('rename', 'baz-id', 'foo/baz', 'bar/baz')],
86
70
                         list(creator.iter_shelvable()))
87
 
        return creator, tree
88
 
 
89
 
    def check_shelve_move(self, creator, tree):
 
71
        creator.shelve_rename('baz-id')
90
72
        work_trans_id = creator.work_transform.trans_id_file_id('baz-id')
91
73
        work_foo = creator.work_transform.trans_id_file_id('foo-id')
92
74
        self.assertEqual(work_foo, creator.work_transform.final_parent(
98
80
        creator.transform()
99
81
        self.assertEqual('foo/baz', tree.id2path('baz-id'))
100
82
 
101
 
    def test_shelve_move(self):
102
 
        creator, tree = self.prepare_shelve_move()
103
 
        creator.shelve_rename('baz-id')
104
 
        self.check_shelve_move(creator, tree)
105
 
 
106
 
    def test_shelve_change_handles_move(self):
107
 
        creator, tree = self.prepare_shelve_move()
108
 
        creator.shelve_change(('rename', 'baz-id', 'foo/baz', 'bar/baz'))
109
 
        self.check_shelve_move(creator, tree)
110
 
 
111
 
    def test_shelve_changed_root_id(self):
112
 
        tree = self.make_branch_and_tree('.')
113
 
        self.build_tree(['foo'])
114
 
        tree.set_root_id('first-root-id')
115
 
        tree.add(['foo'], ['foo-id'])
116
 
        tree.commit('foo')
117
 
        tree.set_root_id('second-root-id')
118
 
        tree.lock_tree_write()
119
 
        self.addCleanup(tree.unlock)
120
 
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
121
 
        self.addCleanup(creator.finalize)
122
 
        self.expectFailure('shelf doesn\'t support shelving root changes yet',
123
 
            self.assertEqual, [
124
 
                ('delete file', 'first-root-id', 'directory', ''),
125
 
                ('add file', 'second-root-id', 'directory', ''),
126
 
                ('rename', 'foo-id', u'foo', u'foo'),
127
 
                ], list(creator.iter_shelvable()))
128
 
 
129
 
        self.assertEqual([('delete file', 'first-root-id', 'directory', ''),
130
 
                          ('add file', 'second-root-id', 'directory', ''),
131
 
                          ('rename', 'foo-id', u'foo', u'foo'),
132
 
                         ], list(creator.iter_shelvable()))
133
 
 
134
83
    def assertShelvedFileEqual(self, expected_content, creator, file_id):
135
84
        s_trans_id = creator.shelf_transform.trans_id_file_id(file_id)
136
85
        shelf_file = creator.shelf_transform._limbo_name(s_trans_id)
137
86
        self.assertFileEqual(expected_content, shelf_file)
138
87
 
139
 
    def prepare_content_change(self):
 
88
    def test_shelve_content_change(self):
140
89
        tree = self.make_branch_and_tree('.')
141
90
        tree.lock_write()
142
91
        self.addCleanup(tree.unlock)
146
95
        self.build_tree_contents([('foo', 'b\na\nc\n')])
147
96
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
148
97
        self.addCleanup(creator.finalize)
149
 
        return creator
150
 
 
151
 
    def test_shelve_content_change(self):
152
 
        creator = self.prepare_content_change()
153
98
        self.assertEqual([('modify text', 'foo-id')],
154
99
                         list(creator.iter_shelvable()))
155
100
        creator.shelve_lines('foo-id', ['a\n', 'c\n'])
157
102
        self.assertFileEqual('a\nc\n', 'foo')
158
103
        self.assertShelvedFileEqual('b\na\n', creator, 'foo-id')
159
104
 
160
 
    def test_shelve_change_handles_modify_text(self):
161
 
        creator = self.prepare_content_change()
162
 
        creator.shelve_change(('modify text', 'foo-id'))
163
 
        creator.transform()
164
 
        self.assertFileEqual('a\n', 'foo')
165
 
        self.assertShelvedFileEqual('b\na\nc\n', creator, 'foo-id')
166
 
 
167
 
    def test_shelve_all(self):
168
 
        creator = self.prepare_content_change()
169
 
        creator.shelve_all()
170
 
        creator.transform()
171
 
        self.assertFileEqual('a\n', 'foo')
172
 
        self.assertShelvedFileEqual('b\na\nc\n', creator, 'foo-id')
173
 
 
174
 
    def prepare_shelve_creation(self):
 
105
    def test_shelve_creation(self):
175
106
        tree = self.make_branch_and_tree('.')
176
107
        tree.lock_write()
177
108
        self.addCleanup(tree.unlock)
183
114
        self.assertEqual([('add file', 'bar-id', 'directory', 'bar'),
184
115
                          ('add file', 'foo-id', 'file', 'foo')],
185
116
                          sorted(list(creator.iter_shelvable())))
186
 
        return creator, tree
187
 
 
188
 
    def check_shelve_creation(self, creator, tree):
 
117
        creator.shelve_creation('foo-id')
 
118
        creator.shelve_creation('bar-id')
 
119
        creator.transform()
189
120
        self.assertRaises(StopIteration,
190
121
                          tree.iter_entries_by_dir(['foo-id']).next)
191
122
        s_trans_id = creator.shelf_transform.trans_id_file_id('foo-id')
198
129
        self.assertEqual('directory',
199
130
            creator.shelf_transform.final_kind(s_bar_trans_id))
200
131
 
201
 
    def test_shelve_creation(self):
202
 
        creator, tree = self.prepare_shelve_creation()
203
 
        creator.shelve_creation('foo-id')
204
 
        creator.shelve_creation('bar-id')
205
 
        creator.transform()
206
 
        self.check_shelve_creation(creator, tree)
207
 
 
208
 
    def test_shelve_change_handles_creation(self):
209
 
        creator, tree = self.prepare_shelve_creation()
210
 
        creator.shelve_change(('add file', 'foo-id', 'file', 'foo'))
211
 
        creator.shelve_change(('add file', 'bar-id', 'directory', 'bar'))
212
 
        creator.transform()
213
 
        self.check_shelve_creation(creator, tree)
214
 
 
215
 
    def _test_shelve_symlink_creation(self, link_name, link_target,
216
 
                                      shelve_change=False):
217
 
        self.requireFeature(tests.SymlinkFeature)
218
 
        tree = self.make_branch_and_tree('.')
219
 
        tree.lock_write()
220
 
        self.addCleanup(tree.unlock)
221
 
        tree.commit('Empty tree')
222
 
        os.symlink(link_target, link_name)
223
 
        tree.add(link_name, 'foo-id')
224
 
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
225
 
        self.addCleanup(creator.finalize)
226
 
        self.assertEqual([('add file', 'foo-id', 'symlink', link_name)],
227
 
                         list(creator.iter_shelvable()))
228
 
        if shelve_change:
229
 
            creator.shelve_change(('add file', 'foo-id', 'symlink', link_name))
230
 
        else:
231
 
            creator.shelve_creation('foo-id')
232
 
        creator.transform()
233
 
        s_trans_id = creator.shelf_transform.trans_id_file_id('foo-id')
234
 
        self.failIfExists(link_name)
235
 
        limbo_name = creator.shelf_transform._limbo_name(s_trans_id)
236
 
        self.assertEqual(link_target, osutils.readlink(limbo_name))
237
 
        ptree = creator.shelf_transform.get_preview_tree()
238
 
        self.assertEqual(link_target, ptree.get_symlink_target('foo-id'))
239
 
 
240
132
    def test_shelve_symlink_creation(self):
241
 
        self._test_shelve_symlink_creation('foo', 'bar')
242
 
 
243
 
    def test_shelve_unicode_symlink_creation(self):
244
 
        self.requireFeature(tests.UnicodeFilenameFeature)
245
 
        self._test_shelve_symlink_creation(u'fo\N{Euro Sign}o',
246
 
                                           u'b\N{Euro Sign}ar')
247
 
 
248
 
    def test_shelve_change_handles_symlink_creation(self):
249
 
        self._test_shelve_symlink_creation('foo', 'bar', shelve_change=True)
250
 
 
251
 
    def _test_shelve_symlink_target_change(self, link_name,
252
 
                                           old_target, new_target,
253
 
                                           shelve_change=False):
254
 
        self.requireFeature(tests.SymlinkFeature)
255
 
        tree = self.make_branch_and_tree('.')
256
 
        tree.lock_write()
257
 
        self.addCleanup(tree.unlock)
258
 
        os.symlink(old_target, link_name)
259
 
        tree.add(link_name, 'foo-id')
 
133
        self.requireFeature(tests.SymlinkFeature)
 
134
        tree = self.make_branch_and_tree('.')
 
135
        tree.lock_write()
 
136
        self.addCleanup(tree.unlock)
 
137
        tree.commit('Empty tree')
 
138
        os.symlink('bar', 'foo')
 
139
        tree.add('foo', 'foo-id')
 
140
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
 
141
        self.addCleanup(creator.finalize)
 
142
        self.assertEqual([('add file', 'foo-id', 'symlink', 'foo')],
 
143
                         list(creator.iter_shelvable()))
 
144
        creator.shelve_creation('foo-id')
 
145
        creator.transform()
 
146
        s_trans_id = creator.shelf_transform.trans_id_file_id('foo-id')
 
147
        self.failIfExists('foo')
 
148
        limbo_name = creator.shelf_transform._limbo_name(s_trans_id)
 
149
        self.assertEqual('bar', os.readlink(limbo_name))
 
150
 
 
151
    def test_shelve_symlink_target_change(self):
 
152
        self.requireFeature(tests.SymlinkFeature)
 
153
        tree = self.make_branch_and_tree('.')
 
154
        tree.lock_write()
 
155
        self.addCleanup(tree.unlock)
 
156
        os.symlink('bar', 'foo')
 
157
        tree.add('foo', 'foo-id')
260
158
        tree.commit("commit symlink")
261
 
        os.unlink(link_name)
262
 
        os.symlink(new_target, link_name)
 
159
        os.unlink("foo")
 
160
        os.symlink('baz', 'foo')
263
161
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
264
162
        self.addCleanup(creator.finalize)
265
 
        self.assertEqual([('modify target', 'foo-id', link_name,
266
 
                           old_target, new_target)],
 
163
        self.assertEqual([('modify target', 'foo-id', 'foo', 'bar', 'baz')],
267
164
                         list(creator.iter_shelvable()))
268
 
        if shelve_change:
269
 
            creator.shelve_change(('modify target', 'foo-id', link_name,
270
 
                                   old_target, new_target))
271
 
        else:
272
 
            creator.shelve_modify_target('foo-id')
 
165
        creator.shelve_modify_target('foo-id')
273
166
        creator.transform()
274
 
        self.assertEqual(old_target, osutils.readlink(link_name))
 
167
        self.assertEqual('bar', os.readlink('foo'))
275
168
        s_trans_id = creator.shelf_transform.trans_id_file_id('foo-id')
276
169
        limbo_name = creator.shelf_transform._limbo_name(s_trans_id)
277
 
        self.assertEqual(new_target, osutils.readlink(limbo_name))
278
 
        ptree = creator.shelf_transform.get_preview_tree()
279
 
        self.assertEqual(new_target, ptree.get_symlink_target('foo-id'))
280
 
 
281
 
    def test_shelve_symlink_target_change(self):
282
 
        self._test_shelve_symlink_target_change('foo', 'bar', 'baz')
283
 
 
284
 
    def test_shelve_unicode_symlink_target_change(self):
285
 
        self.requireFeature(tests.UnicodeFilenameFeature)
286
 
        self._test_shelve_symlink_target_change(
287
 
            u'fo\N{Euro Sign}o', u'b\N{Euro Sign}ar', u'b\N{Euro Sign}az')
288
 
 
289
 
    def test_shelve_change_handles_symlink_target_change(self):
290
 
        self._test_shelve_symlink_target_change('foo', 'bar', 'baz',
291
 
                                                shelve_change=True)
 
170
        self.assertEqual('baz', os.readlink(limbo_name))
292
171
 
293
172
    def test_shelve_creation_no_contents(self):
294
173
        tree = self.make_branch_and_tree('.')
312
191
                         creator.shelf_transform.final_file_id(s_trans_id))
313
192
        self.failIfExists('foo')
314
193
 
315
 
    def prepare_shelve_deletion(self):
 
194
    def test_shelve_deletion(self):
316
195
        tree = self.make_branch_and_tree('tree')
317
196
        tree.lock_write()
318
197
        self.addCleanup(tree.unlock)
327
206
        self.assertEqual([('delete file', 'bar-id', 'file', 'foo/bar'),
328
207
                          ('delete file', 'foo-id', 'directory', 'foo')],
329
208
                          sorted(list(creator.iter_shelvable())))
330
 
        return creator, tree
331
 
 
332
 
    def check_shelve_deletion(self, tree):
 
209
        creator.shelve_deletion('foo-id')
 
210
        creator.shelve_deletion('bar-id')
 
211
        creator.transform()
333
212
        self.assertTrue('foo-id' in tree)
334
213
        self.assertTrue('bar-id' in tree)
335
214
        self.assertFileEqual('baz', 'tree/foo/bar')
336
215
 
337
 
    def test_shelve_deletion(self):
338
 
        creator, tree = self.prepare_shelve_deletion()
339
 
        creator.shelve_deletion('foo-id')
340
 
        creator.shelve_deletion('bar-id')
341
 
        creator.transform()
342
 
        self.check_shelve_deletion(tree)
343
 
 
344
 
    def test_shelve_change_handles_deletion(self):
345
 
        creator, tree = self.prepare_shelve_deletion()
346
 
        creator.shelve_change(('delete file', 'foo-id', 'directory', 'foo'))
347
 
        creator.shelve_change(('delete file', 'bar-id', 'file', 'foo/bar'))
348
 
        creator.transform()
349
 
        self.check_shelve_deletion(tree)
350
 
 
351
216
    def test_shelve_delete_contents(self):
352
217
        tree = self.make_branch_and_tree('tree')
353
218
        self.build_tree(['tree/foo',])
354
219
        tree.add('foo', 'foo-id')
355
220
        tree.commit('Added file and directory')
356
221
        os.unlink('tree/foo')
357
 
        tree.lock_tree_write()
358
 
        self.addCleanup(tree.unlock)
359
222
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
360
223
        self.addCleanup(creator.finalize)
361
224
        self.assertEqual([('delete file', 'foo-id', 'file', 'foo')],
364
227
        creator.transform()
365
228
        self.failUnlessExists('tree/foo')
366
229
 
367
 
    def prepare_shelve_change_kind(self):
 
230
    def test_shelve_change_kind(self):
368
231
        tree = self.make_branch_and_tree('tree')
369
232
        self.build_tree_contents([('tree/foo', 'bar')])
370
233
        tree.add('foo', 'foo-id')
371
234
        tree.commit('Added file and directory')
372
235
        os.unlink('tree/foo')
373
236
        os.mkdir('tree/foo')
374
 
        tree.lock_tree_write()
375
 
        self.addCleanup(tree.unlock)
376
237
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
377
238
        self.addCleanup(creator.finalize)
378
239
        self.assertEqual([('change kind', 'foo-id', 'file', 'directory',
379
240
                           'foo')], sorted(list(creator.iter_shelvable())))
380
 
        return creator
381
 
 
382
 
    def check_shelve_change_kind(self, creator):
 
241
        creator.shelve_content_change('foo-id')
 
242
        creator.transform()
383
243
        self.assertFileEqual('bar', 'tree/foo')
384
244
        s_trans_id = creator.shelf_transform.trans_id_file_id('foo-id')
385
245
        self.assertEqual('directory',
386
246
                         creator.shelf_transform._new_contents[s_trans_id])
387
247
 
388
 
    def test_shelve_change_kind(self):
389
 
        creator = self.prepare_shelve_change_kind()
390
 
        creator.shelve_content_change('foo-id')
391
 
        creator.transform()
392
 
        self.check_shelve_change_kind(creator)
393
 
 
394
 
    def test_shelve_change_handles_change_kind(self):
395
 
        creator = self.prepare_shelve_change_kind()
396
 
        creator.shelve_change(('change kind', 'foo-id', 'file', 'directory',
397
 
                               'foo'))
398
 
        creator.transform()
399
 
        self.check_shelve_change_kind(creator)
400
 
 
401
 
    def test_shelve_change_unknown_change(self):
402
 
        tree = self.make_branch_and_tree('tree')
403
 
        tree.lock_tree_write()
404
 
        self.addCleanup(tree.unlock)
405
 
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
406
 
        self.addCleanup(creator.finalize)
407
 
        e = self.assertRaises(ValueError, creator.shelve_change, ('unknown',))
408
 
        self.assertEqual('Unknown change kind: "unknown"', str(e))
409
 
 
410
248
    def test_shelve_unversion(self):
411
249
        tree = self.make_branch_and_tree('tree')
412
250
        self.build_tree(['tree/foo',])
413
251
        tree.add('foo', 'foo-id')
414
252
        tree.commit('Added file and directory')
415
253
        tree.unversion(['foo-id'])
416
 
        tree.lock_tree_write()
417
 
        self.addCleanup(tree.unlock)
418
254
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
419
255
        self.addCleanup(creator.finalize)
420
256
        self.assertEqual([('delete file', 'foo-id', 'file', 'foo')],
425
261
 
426
262
    def test_shelve_serialization(self):
427
263
        tree = self.make_branch_and_tree('.')
428
 
        tree.lock_tree_write()
429
 
        self.addCleanup(tree.unlock)
430
264
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
431
265
        self.addCleanup(creator.finalize)
432
266
        shelf_file = open('shelf', 'wb')
441
275
        tree = self.make_branch_and_tree('tree')
442
276
        self.build_tree(['tree/foo'])
443
277
        tree.add('foo', 'foo-id')
444
 
        tree.lock_tree_write()
445
 
        self.addCleanup(tree.unlock)
446
278
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
447
279
        self.addCleanup(creator.finalize)
448
280
        list(creator.iter_shelvable())
467
299
 
468
300
    def test_shelve_unversioned(self):
469
301
        tree = self.make_branch_and_tree('tree')
470
 
        tree.lock_tree_write()
471
 
        try:
472
 
            self.assertRaises(errors.PathsNotVersionedError,
473
 
                              shelf.ShelfCreator, tree, tree.basis_tree(), ['foo'])
474
 
        finally:
475
 
            tree.unlock()
 
302
        self.assertRaises(errors.PathsNotVersionedError,
 
303
                          shelf.ShelfCreator, tree, tree.basis_tree(), ['foo'])
476
304
        # We should be able to lock/unlock the tree if ShelfCreator cleaned
477
305
        # after itself.
478
306
        wt = workingtree.WorkingTree.open('tree')
480
308
        wt.unlock()
481
309
        # And a second tentative should raise the same error (no
482
310
        # limbo/pending_deletion leftovers).
483
 
        tree.lock_tree_write()
484
 
        try:
485
 
            self.assertRaises(errors.PathsNotVersionedError,
486
 
                              shelf.ShelfCreator, tree, tree.basis_tree(), ['foo'])
487
 
        finally:
488
 
            tree.unlock()
489
 
 
490
 
    def test_shelve_skips_added_root(self):
491
 
        """Skip adds of the root when iterating through shelvable changes."""
492
 
        tree = self.make_branch_and_tree('tree')
493
 
        tree.lock_tree_write()
494
 
        self.addCleanup(tree.unlock)
495
 
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
496
 
        self.addCleanup(creator.finalize)
497
 
        self.assertEqual([], list(creator.iter_shelvable()))
498
 
 
499
 
    def test_shelve_skips_added_root(self):
500
 
        """Skip adds of the root when iterating through shelvable changes."""
501
 
        tree = self.make_branch_and_tree('tree')
502
 
        tree.lock_tree_write()
503
 
        self.addCleanup(tree.unlock)
504
 
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
505
 
        self.addCleanup(creator.finalize)
506
 
        self.assertEqual([], list(creator.iter_shelvable()))
 
311
        self.assertRaises(errors.PathsNotVersionedError,
 
312
                          shelf.ShelfCreator, tree, tree.basis_tree(), ['foo'])
507
313
 
508
314
 
509
315
class TestUnshelver(tests.TestCaseWithTransport):
526
332
            shelf_file.seek(0)
527
333
            unshelver = shelf.Unshelver.from_tree_and_shelf(tree, shelf_file)
528
334
            unshelver.make_merger().do_merge()
529
 
            self.addCleanup(unshelver.finalize)
530
335
            self.assertFileEqual('bar', 'tree/foo')
531
336
        finally:
532
337
            shelf_file.close()
550
355
        self.build_tree_contents([('tree/foo', 'z\na\nb\nc\n')])
551
356
        shelf_file.seek(0)
552
357
        unshelver = shelf.Unshelver.from_tree_and_shelf(tree, shelf_file)
553
 
        self.addCleanup(unshelver.finalize)
554
358
        unshelver.make_merger().do_merge()
555
359
        self.assertFileEqual('z\na\nb\nd\n', 'tree/foo')
556
360
 
579
383
        self.assertFileEqual('baz', 'tree/foo/bar')
580
384
        shelf_file.seek(0)
581
385
        unshelver = shelf.Unshelver.from_tree_and_shelf(tree, shelf_file)
582
 
        self.addCleanup(unshelver.finalize)
583
386
        unshelver.make_merger().do_merge()
584
387
        self.assertFalse('foo-id' in tree)
585
388
        self.assertFalse('bar-id' in tree)
610
413
        shelf_file = open('shelf', 'rb')
611
414
        self.addCleanup(shelf_file.close)
612
415
        unshelver = shelf.Unshelver.from_tree_and_shelf(tree, shelf_file)
613
 
        unshelver.finalize()
614
416
 
615
417
    def test_corrupt_shelf(self):
616
418
        tree = self.make_branch_and_tree('.')
725
527
        shelf_id = shelf_manager.shelve_changes(creator)
726
528
        self.failIfExists('tree/foo')
727
529
        unshelver = shelf_manager.get_unshelver(shelf_id)
728
 
        self.addCleanup(unshelver.finalize)
729
530
        unshelver.make_merger().do_merge()
730
531
        self.assertFileEqual('bar', 'tree/foo')
731
532
 
732
533
    def test_get_metadata(self):
733
534
        tree = self.make_branch_and_tree('.')
734
 
        tree.lock_tree_write()
735
 
        self.addCleanup(tree.unlock)
736
535
        creator = shelf.ShelfCreator(tree, tree.basis_tree())
737
 
        self.addCleanup(creator.finalize)
738
536
        shelf_manager = tree.get_shelf_manager()
739
537
        shelf_id = shelf_manager.shelve_changes(creator, 'foo')
740
538
        metadata = shelf_manager.get_metadata(shelf_id)