← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/bundle/__init__.py

  • Committer: Vincent Ladeuil
  • Date: 2009-04-27 16:10:10 UTC
  • mto: (4310.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 4311.
  • Revision ID: v.ladeuil+lp@free.fr-20090427161010-7swfzeagf63cpixd
Fix bug #367726 by reverting some default user handling introduced
while fixing bug #256612.

* bzrlib/transport/ssh.py:
(_paramiko_auth): Explicitly use getpass.getuser() as default
user.

* bzrlib/transport/ftp/_gssapi.py:
(GSSAPIFtpTransport._create_connection): Explicitly use
getpass.getuser() as default user.

* bzrlib/transport/ftp/__init__.py:
(FtpTransport._create_connection): Explicitly use
getpass.getuser() as default user.

* bzrlib/tests/test_sftp_transport.py:
(TestUsesAuthConfig.test_sftp_is_none_if_no_config)
(TestUsesAuthConfig.test_sftp_doesnt_prompt_username): Revert to
None as the default user.

* bzrlib/tests/test_remote.py:
(TestRemoteSSHTransportAuthentication): The really offending one:
revert to None as the default user.

* bzrlib/tests/test_config.py:
(TestAuthenticationConfig.test_username_default_no_prompt): Update
test (and some PEP8).

* bzrlib/smtp_connection.py:
(SMTPConnection._authenticate): Revert to None as the default
user.

* bzrlib/plugins/launchpad/account.py:
(_get_auth_user): Revert default value handling.

* bzrlib/config.py:
(AuthenticationConfig.get_user): Fix doc-string. Leave default
value handling to callers.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/bundle/__init__.py
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
16
 
17
 
from cStringIO import StringIO
18
 
 
 
17
from bzrlib.symbol_versioning import deprecated_function, deprecated_in
19
18
from bzrlib.lazy_import import lazy_import
20
19
lazy_import(globals(), """
21
20
from bzrlib import (
23
22
    urlutils,
24
23
    )
25
24
from bzrlib.bundle import serializer as _serializer
26
 
from bzrlib.merge_directive import MergeDirective
27
25
from bzrlib.transport import (
28
26
    do_catching_redirections,
29
27
    get_transport,
32
30
from bzrlib.trace import note
33
31
 
34
32
 
 
33
@deprecated_function(deprecated_in((1, 12, 0)))
 
34
def read_bundle_from_url(url):
 
35
    return read_mergeable_from_url(url, _do_directive=False)
 
36
 
 
37
 
35
38
def read_mergeable_from_url(url, _do_directive=True, possible_transports=None):
36
39
    """Read mergable object from a given URL.
37
40
 
42
45
        possible_transports=possible_transports)
43
46
    transport = child_transport.clone('..')
44
47
    filename = transport.relpath(child_transport.base)
 
48
    if filename.endswith('/'):
 
49
        # A path to a directory was passed in
 
50
        # definitely not a bundle
 
51
        raise errors.NotABundle('A directory cannot be a bundle')
45
52
    mergeable, transport = read_mergeable_from_transport(transport, filename,
46
53
                                                         _do_directive)
47
54
    return mergeable
48
55
 
49
56
 
50
57
def read_mergeable_from_transport(transport, filename, _do_directive=True):
51
 
    def get_bundle(transport):
52
 
        return StringIO(transport.get_bytes(filename)), transport
53
 
 
54
 
    def redirected_transport(transport, exception, redirection_notice):
55
 
        note(redirection_notice)
56
 
        url, filename = urlutils.split(exception.target,
57
 
                                       exclude_trailing_slash=False)
58
 
        if not filename:
59
 
            raise errors.NotABundle('A directory cannot be a bundle')
60
 
        return get_transport(url)
61
 
 
 
58
    # All of this must be in the try/except
 
59
    # Some transports cannot detect that we are trying to read a
 
60
    # directory until we actually issue read() on the handle.
62
61
    try:
63
 
        bytef, transport = do_catching_redirections(get_bundle, transport,
 
62
        def get_bundle(transport):
 
63
            return transport.get(filename), transport
 
64
 
 
65
        def redirected_transport(transport, exception, redirection_notice):
 
66
            note(redirection_notice)
 
67
            url, filename = urlutils.split(exception.target,
 
68
                                           exclude_trailing_slash=False)
 
69
            if not filename:
 
70
                raise errors.NotABundle('A directory cannot be a bundle')
 
71
            return get_transport(url)
 
72
 
 
73
        try:
 
74
            f, transport = do_catching_redirections(get_bundle, transport,
64
75
                                                    redirected_transport)
65
 
    except errors.TooManyRedirections:
66
 
        raise errors.NotABundle(transport.clone(filename).base)
67
 
    except (errors.ConnectionReset, errors.ConnectionError), e:
 
76
        except errors.TooManyRedirections:
 
77
            raise errors.NotABundle(str(url))
 
78
 
 
79
        if _do_directive:
 
80
            from bzrlib.merge_directive import MergeDirective
 
81
            directive = MergeDirective.from_lines(f.readlines())
 
82
            return directive, transport
 
83
        else:
 
84
            return _serializer.read_bundle(f), transport
 
85
    except errors.ConnectionReset:
68
86
        raise
69
87
    except (errors.TransportError, errors.PathError), e:
70
88
        raise errors.NotABundle(str(e))
77
95
        # StubSFTPServer does fail during get() (because of prefetch)
78
96
        # so it has an opportunity to translate the error.
79
97
        raise errors.NotABundle(str(e))
80
 
 
81
 
    if _do_directive:
82
 
        try:
83
 
            return MergeDirective.from_lines(bytef), transport
84
 
        except errors.NotAMergeDirective:
85
 
            bytef.seek(0)
86
 
 
87
 
    return _serializer.read_bundle(bytef), transport
 
98
    except errors.NotAMergeDirective:
 
99
        f.seek(0)
 
100
        return _serializer.read_bundle(f), transport