~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_remote.py

  • Committer: Andrew Bennetts
  • Date: 2009-04-02 05:53:12 UTC
  • mto: This revision was merged to the branch mainline in revision 4242.
  • Revision ID: andrew.bennetts@canonical.com-20090402055312-h7mvgumvm7e620mj
Fix nits in spelling and naming.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2011 Canonical Ltd
 
1
# Copyright (C) 2006, 2007, 2008, 2009 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
27
27
from cStringIO import StringIO
28
28
 
29
29
from bzrlib import (
30
 
    branch,
31
30
    bzrdir,
32
31
    config,
33
 
    controldir,
34
32
    errors,
35
 
    graph as _mod_graph,
36
 
    inventory,
37
 
    inventory_delta,
 
33
    graph,
 
34
    pack,
38
35
    remote,
39
36
    repository,
 
37
    smart,
40
38
    tests,
41
 
    transport,
42
39
    treebuilder,
43
 
    versionedfile,
 
40
    urlutils,
44
41
    )
45
42
from bzrlib.branch import Branch
46
 
from bzrlib.bzrdir import (
47
 
    BzrDir,
48
 
    BzrDirFormat,
49
 
    RemoteBzrProber,
50
 
    )
 
43
from bzrlib.bzrdir import BzrDir, BzrDirFormat
51
44
from bzrlib.remote import (
52
45
    RemoteBranch,
53
46
    RemoteBranchFormat,
56
49
    RemoteRepository,
57
50
    RemoteRepositoryFormat,
58
51
    )
59
 
from bzrlib.repofmt import groupcompress_repo, knitpack_repo
 
52
from bzrlib.repofmt import pack_repo
60
53
from bzrlib.revision import NULL_REVISION
61
 
from bzrlib.smart import medium, request
 
54
from bzrlib.smart import server, medium
62
55
from bzrlib.smart.client import _SmartClient
63
 
from bzrlib.smart.repository import (
64
 
    SmartServerRepositoryGetParentMap,
65
 
    SmartServerRepositoryGetStream_1_19,
66
 
    )
67
56
from bzrlib.tests import (
68
 
    test_server,
 
57
    condition_isinstance,
 
58
    split_suite_by_condition,
 
59
    multiply_tests,
69
60
    )
70
 
from bzrlib.tests.scenarios import load_tests_apply_scenarios
 
61
from bzrlib.transport import get_transport, http
71
62
from bzrlib.transport.memory import MemoryTransport
72
63
from bzrlib.transport.remote import (
73
64
    RemoteTransport,
74
65
    RemoteSSHTransport,
75
66
    RemoteTCPTransport,
76
 
    )
77
 
 
78
 
 
79
 
load_tests = load_tests_apply_scenarios
80
 
 
81
 
 
82
 
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
83
 
 
84
 
    scenarios = [
 
67
)
 
68
 
 
69
def load_tests(standard_tests, module, loader):
 
70
    to_adapt, result = split_suite_by_condition(
 
71
        standard_tests, condition_isinstance(BasicRemoteObjectTests))
 
72
    smart_server_version_scenarios = [
85
73
        ('HPSS-v2',
86
 
            {'transport_server': test_server.SmartTCPServer_for_testing_v2_only}),
 
74
            {'transport_server': server.SmartTCPServer_for_testing_v2_only}),
87
75
        ('HPSS-v3',
88
 
            {'transport_server': test_server.SmartTCPServer_for_testing})]
89
 
 
 
76
            {'transport_server': server.SmartTCPServer_for_testing})]
 
77
    return multiply_tests(to_adapt, smart_server_version_scenarios, result)
 
78
 
 
79
 
 
80
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
90
81
 
91
82
    def setUp(self):
92
83
        super(BasicRemoteObjectTests, self).setUp()
93
84
        self.transport = self.get_transport()
94
85
        # make a branch that can be opened over the smart transport
95
86
        self.local_wt = BzrDir.create_standalone_workingtree('.')
96
 
        self.addCleanup(self.transport.disconnect)
 
87
 
 
88
    def tearDown(self):
 
89
        self.transport.disconnect()
 
90
        tests.TestCaseWithTransport.tearDown(self)
97
91
 
98
92
    def test_create_remote_bzrdir(self):
99
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
93
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
100
94
        self.assertIsInstance(b, BzrDir)
101
95
 
102
96
    def test_open_remote_branch(self):
103
97
        # open a standalone branch in the working directory
104
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
98
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
105
99
        branch = b.open_branch()
106
100
        self.assertIsInstance(branch, Branch)
107
101
 
123
117
    def test_find_correct_format(self):
124
118
        """Should open a RemoteBzrDir over a RemoteTransport"""
125
119
        fmt = BzrDirFormat.find_format(self.transport)
126
 
        self.assertTrue(bzrdir.RemoteBzrProber
127
 
                        in controldir.ControlDirFormat._server_probers)
128
 
        self.assertIsInstance(fmt, RemoteBzrDirFormat)
 
120
        self.assertTrue(RemoteBzrDirFormat
 
121
                        in BzrDirFormat._control_server_formats)
 
122
        self.assertIsInstance(fmt, remote.RemoteBzrDirFormat)
129
123
 
130
124
    def test_open_detected_smart_format(self):
131
125
        fmt = BzrDirFormat.find_format(self.transport)
136
130
        b = BzrDir.open_from_transport(self.transport).open_branch()
137
131
        self.assertStartsWith(str(b), 'RemoteBranch(')
138
132
 
139
 
    def test_remote_bzrdir_repr(self):
140
 
        b = BzrDir.open_from_transport(self.transport)
141
 
        self.assertStartsWith(str(b), 'RemoteBzrDir(')
142
 
 
143
133
    def test_remote_branch_format_supports_stacking(self):
144
134
        t = self.transport
145
135
        self.make_branch('unstackable', format='pack-0.92')
162
152
        r = BzrDir.open_from_transport(t.clone('stackable')).open_repository()
163
153
        self.assertTrue(r._format.supports_external_lookups)
164
154
 
165
 
    def test_remote_branch_set_append_revisions_only(self):
166
 
        # Make a format 1.9 branch, which supports append_revisions_only
167
 
        branch = self.make_branch('branch', format='1.9')
168
 
        config = branch.get_config()
169
 
        branch.set_append_revisions_only(True)
170
 
        self.assertEqual(
171
 
            'True', config.get_user_option('append_revisions_only'))
172
 
        branch.set_append_revisions_only(False)
173
 
        self.assertEqual(
174
 
            'False', config.get_user_option('append_revisions_only'))
175
 
 
176
 
    def test_remote_branch_set_append_revisions_only_upgrade_reqd(self):
177
 
        branch = self.make_branch('branch', format='knit')
178
 
        config = branch.get_config()
179
 
        self.assertRaises(
180
 
            errors.UpgradeRequired, branch.set_append_revisions_only, True)
181
 
 
182
155
 
183
156
class FakeProtocol(object):
184
157
    """Lookalike SmartClientRequestProtocolOne allowing body reading tests."""
285
258
        self.expecting_body = True
286
259
        return result[1], FakeProtocol(result[2], self)
287
260
 
288
 
    def call_with_body_bytes(self, method, args, body):
289
 
        self._check_call(method, args)
290
 
        self._calls.append(('call_with_body_bytes', method, args, body))
291
 
        result = self._get_next_response()
292
 
        return result[1], FakeProtocol(result[2], self)
293
 
 
294
261
    def call_with_body_bytes_expecting_body(self, method, args, body):
295
262
        self._check_call(method, args)
296
263
        self._calls.append(('call_with_body_bytes_expecting_body', method,
346
313
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
347
314
        return reference_bzrdir_format.repository_format
348
315
 
349
 
    def assertFinished(self, fake_client):
350
 
        """Assert that all of a FakeClient's expected calls have occurred."""
351
 
        fake_client.finished_test()
 
316
    def disable_verb(self, verb):
 
317
        """Disable a verb for one test."""
 
318
        request_handlers = smart.request.request_handlers
 
319
        orig_method = request_handlers.get(verb)
 
320
        request_handlers.remove(verb)
 
321
        def restoreVerb():
 
322
            request_handlers.register(verb, orig_method)
 
323
        self.addCleanup(restoreVerb)
352
324
 
353
325
 
354
326
class Test_ClientMedium_remote_path_from_transport(tests.TestCase):
360
332
        a given client_base and transport_base.
361
333
        """
362
334
        client_medium = medium.SmartClientMedium(client_base)
363
 
        t = transport.get_transport(transport_base)
364
 
        result = client_medium.remote_path_from_transport(t)
 
335
        transport = get_transport(transport_base)
 
336
        result = client_medium.remote_path_from_transport(transport)
365
337
        self.assertEqual(expected, result)
366
338
 
367
339
    def test_remote_path_from_transport(self):
378
350
        a given transport_base and relpath of that transport.  (Note that
379
351
        HttpTransportBase is a subclass of SmartClientMedium)
380
352
        """
381
 
        base_transport = transport.get_transport(transport_base)
 
353
        base_transport = get_transport(transport_base)
382
354
        client_medium = base_transport.get_smart_medium()
383
355
        cloned_transport = base_transport.clone(relpath)
384
356
        result = client_medium.remote_path_from_transport(cloned_transport)
419
391
        # Calling _remember_remote_is_before again with a lower value works.
420
392
        client_medium._remember_remote_is_before((1, 5))
421
393
        self.assertTrue(client_medium._is_remote_before((1, 5)))
422
 
        # If you call _remember_remote_is_before with a higher value it logs a
423
 
        # warning, and continues to remember the lower value.
424
 
        self.assertNotContainsRe(self.get_log(), '_remember_remote_is_before')
425
 
        client_medium._remember_remote_is_before((1, 9))
426
 
        self.assertContainsRe(self.get_log(), '_remember_remote_is_before')
427
 
        self.assertTrue(client_medium._is_remote_before((1, 5)))
 
394
        # You cannot call _remember_remote_is_before with a larger value.
 
395
        self.assertRaises(
 
396
            AssertionError, client_medium._remember_remote_is_before, (1, 9))
428
397
 
429
398
 
430
399
class TestBzrDirCloningMetaDir(TestRemote):
449
418
            'BzrDir.cloning_metadir', ('quack/', 'False'),
450
419
            'error', ('BranchReference',)),
451
420
        client.add_expected_call(
452
 
            'BzrDir.open_branchV3', ('quack/',),
 
421
            'BzrDir.open_branchV2', ('quack/',),
453
422
            'success', ('ref', self.get_url('referenced'))),
454
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
423
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
455
424
            _client=client)
456
425
        result = a_bzrdir.cloning_metadir()
457
426
        # We should have got a control dir matching the referenced branch.
458
427
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
459
428
        self.assertEqual(expected._repository_format, result._repository_format)
460
429
        self.assertEqual(expected._branch_format, result._branch_format)
461
 
        self.assertFinished(client)
 
430
        client.finished_test()
462
431
 
463
432
    def test_current_server(self):
464
433
        transport = self.get_transport('.')
470
439
        client.add_expected_call(
471
440
            'BzrDir.cloning_metadir', ('quack/', 'False'),
472
441
            'success', (control_name, '', ('branch', ''))),
473
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
442
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
474
443
            _client=client)
475
444
        result = a_bzrdir.cloning_metadir()
476
445
        # We should have got a reference control dir with default branch and
479
448
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
480
449
        self.assertEqual(None, result._repository_format)
481
450
        self.assertEqual(None, result._branch_format)
482
 
        self.assertFinished(client)
483
 
 
484
 
 
485
 
class TestBzrDirOpen(TestRemote):
486
 
 
487
 
    def make_fake_client_and_transport(self, path='quack'):
488
 
        transport = MemoryTransport()
489
 
        transport.mkdir(path)
490
 
        transport = transport.clone(path)
491
 
        client = FakeClient(transport.base)
492
 
        return client, transport
493
 
 
494
 
    def test_absent(self):
495
 
        client, transport = self.make_fake_client_and_transport()
496
 
        client.add_expected_call(
497
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('no',))
498
 
        self.assertRaises(errors.NotBranchError, RemoteBzrDir, transport,
499
 
                RemoteBzrDirFormat(), _client=client, _force_probe=True)
500
 
        self.assertFinished(client)
501
 
 
502
 
    def test_present_without_workingtree(self):
503
 
        client, transport = self.make_fake_client_and_transport()
504
 
        client.add_expected_call(
505
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'no'))
506
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
507
 
            _client=client, _force_probe=True)
508
 
        self.assertIsInstance(bd, RemoteBzrDir)
509
 
        self.assertFalse(bd.has_workingtree())
510
 
        self.assertRaises(errors.NoWorkingTree, bd.open_workingtree)
511
 
        self.assertFinished(client)
512
 
 
513
 
    def test_present_with_workingtree(self):
514
 
        client, transport = self.make_fake_client_and_transport()
515
 
        client.add_expected_call(
516
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'yes'))
517
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
518
 
            _client=client, _force_probe=True)
519
 
        self.assertIsInstance(bd, RemoteBzrDir)
520
 
        self.assertTrue(bd.has_workingtree())
521
 
        self.assertRaises(errors.NotLocalUrl, bd.open_workingtree)
522
 
        self.assertFinished(client)
523
 
 
524
 
    def test_backwards_compat(self):
525
 
        client, transport = self.make_fake_client_and_transport()
526
 
        client.add_expected_call(
527
 
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
528
 
        client.add_expected_call(
529
 
            'BzrDir.open', ('quack/',), 'success', ('yes',))
530
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
531
 
            _client=client, _force_probe=True)
532
 
        self.assertIsInstance(bd, RemoteBzrDir)
533
 
        self.assertFinished(client)
534
 
 
535
 
    def test_backwards_compat_hpss_v2(self):
536
 
        client, transport = self.make_fake_client_and_transport()
537
 
        # Monkey-patch fake client to simulate real-world behaviour with v2
538
 
        # server: upon first RPC call detect the protocol version, and because
539
 
        # the version is 2 also do _remember_remote_is_before((1, 6)) before
540
 
        # continuing with the RPC.
541
 
        orig_check_call = client._check_call
542
 
        def check_call(method, args):
543
 
            client._medium._protocol_version = 2
544
 
            client._medium._remember_remote_is_before((1, 6))
545
 
            client._check_call = orig_check_call
546
 
            client._check_call(method, args)
547
 
        client._check_call = check_call
548
 
        client.add_expected_call(
549
 
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
550
 
        client.add_expected_call(
551
 
            'BzrDir.open', ('quack/',), 'success', ('yes',))
552
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
553
 
            _client=client, _force_probe=True)
554
 
        self.assertIsInstance(bd, RemoteBzrDir)
555
 
        self.assertFinished(client)
 
451
        client.finished_test()
556
452
 
557
453
 
558
454
class TestBzrDirOpenBranch(TestRemote):
562
458
        self.make_branch('.')
563
459
        a_dir = BzrDir.open(self.get_url('.'))
564
460
        self.reset_smart_call_log()
565
 
        verb = 'BzrDir.open_branchV3'
 
461
        verb = 'BzrDir.open_branchV2'
566
462
        self.disable_verb(verb)
567
463
        format = a_dir.open_branch()
568
464
        call_count = len([call for call in self.hpss_calls if
578
474
        transport = transport.clone('quack')
579
475
        client = FakeClient(transport.base)
580
476
        client.add_expected_call(
581
 
            'BzrDir.open_branchV3', ('quack/',),
 
477
            'BzrDir.open_branchV2', ('quack/',),
582
478
            'success', ('branch', branch_network_name))
583
479
        client.add_expected_call(
584
480
            'BzrDir.find_repositoryV3', ('quack/',),
586
482
        client.add_expected_call(
587
483
            'Branch.get_stacked_on_url', ('quack/',),
588
484
            'error', ('NotStacked',))
589
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
485
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
590
486
            _client=client)
591
487
        result = bzrdir.open_branch()
592
488
        self.assertIsInstance(result, RemoteBranch)
593
489
        self.assertEqual(bzrdir, result.bzrdir)
594
 
        self.assertFinished(client)
 
490
        client.finished_test()
595
491
 
596
492
    def test_branch_missing(self):
597
493
        transport = MemoryTransport()
599
495
        transport = transport.clone('quack')
600
496
        client = FakeClient(transport.base)
601
497
        client.add_error_response('nobranch')
602
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
498
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
603
499
            _client=client)
604
500
        self.assertRaises(errors.NotBranchError, bzrdir.open_branch)
605
501
        self.assertEqual(
606
 
            [('call', 'BzrDir.open_branchV3', ('quack/',))],
 
502
            [('call', 'BzrDir.open_branchV2', ('quack/',))],
607
503
            client._calls)
608
504
 
609
505
    def test__get_tree_branch(self):
610
506
        # _get_tree_branch is a form of open_branch, but it should only ask for
611
507
        # branch opening, not any other network requests.
612
508
        calls = []
613
 
        def open_branch(name=None):
 
509
        def open_branch():
614
510
            calls.append("Called")
615
511
            return "a-branch"
616
512
        transport = MemoryTransport()
617
513
        # no requests on the network - catches other api calls being made.
618
514
        client = FakeClient(transport.base)
619
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
515
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
620
516
            _client=client)
621
517
        # patch the open_branch call to record that it was called.
622
518
        bzrdir.open_branch = open_branch
633
529
        network_name = reference_format.network_name()
634
530
        branch_network_name = self.get_branch_format().network_name()
635
531
        client.add_expected_call(
636
 
            'BzrDir.open_branchV3', ('~hello/',),
 
532
            'BzrDir.open_branchV2', ('~hello/',),
637
533
            'success', ('branch', branch_network_name))
638
534
        client.add_expected_call(
639
535
            'BzrDir.find_repositoryV3', ('~hello/',),
641
537
        client.add_expected_call(
642
538
            'Branch.get_stacked_on_url', ('~hello/',),
643
539
            'error', ('NotStacked',))
644
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
540
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
645
541
            _client=client)
646
542
        result = bzrdir.open_branch()
647
 
        self.assertFinished(client)
 
543
        client.finished_test()
648
544
 
649
545
    def check_open_repository(self, rich_root, subtrees, external_lookup='no'):
650
546
        reference_format = self.get_repo_format()
664
560
        client.add_success_response(
665
561
            'ok', '', rich_response, subtree_response, external_lookup,
666
562
            network_name)
667
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
563
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
668
564
            _client=client)
669
565
        result = bzrdir.open_repository()
670
566
        self.assertEqual(
687
583
        old.
688
584
        """
689
585
        self.assertRaises(errors.NotBranchError,
690
 
            RemoteBzrProber.probe_transport, OldServerTransport())
 
586
            RemoteBzrDirFormat.probe_transport, OldServerTransport())
691
587
 
692
588
 
693
589
class TestBzrDirCreateBranch(TestRemote):
716
612
            'BzrDir.create_branch', ('quack/', network_name),
717
613
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
718
614
            reference_repo_name))
719
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
615
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
720
616
            _client=client)
721
617
        branch = a_bzrdir.create_branch()
722
618
        # We should have got a remote branch
725
621
        format = branch._format
726
622
        self.assertEqual(network_name, format.network_name())
727
623
 
728
 
    def test_already_open_repo_and_reused_medium(self):
729
 
        """Bug 726584: create_branch(..., repository=repo) should work
730
 
        regardless of what the smart medium's base URL is.
731
 
        """
732
 
        self.transport_server = test_server.SmartTCPServer_for_testing
733
 
        transport = self.get_transport('.')
734
 
        repo = self.make_repository('quack')
735
 
        # Client's medium rooted a transport root (not at the bzrdir)
736
 
        client = FakeClient(transport.base)
737
 
        transport = transport.clone('quack')
738
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
739
 
        reference_format = reference_bzrdir_format.get_branch_format()
740
 
        network_name = reference_format.network_name()
741
 
        reference_repo_fmt = reference_bzrdir_format.repository_format
742
 
        reference_repo_name = reference_repo_fmt.network_name()
743
 
        client.add_expected_call(
744
 
            'BzrDir.create_branch', ('extra/quack/', network_name),
745
 
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
746
 
            reference_repo_name))
747
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
748
 
            _client=client)
749
 
        branch = a_bzrdir.create_branch(repository=repo)
750
 
        # We should have got a remote branch
751
 
        self.assertIsInstance(branch, remote.RemoteBranch)
752
 
        # its format should have the settings from the response
753
 
        format = branch._format
754
 
        self.assertEqual(network_name, format.network_name())
755
 
 
756
624
 
757
625
class TestBzrDirCreateRepository(TestRemote):
758
626
 
776
644
        network_name = reference_format.network_name()
777
645
        client.add_expected_call(
778
646
            'BzrDir.create_repository', ('quack/',
779
 
                'Bazaar repository format 2a (needs bzr 1.16 or later)\n',
780
 
                'False'),
781
 
            'success', ('ok', 'yes', 'yes', 'yes', network_name))
782
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
647
                'Bazaar pack repository format 1 (needs bzr 0.92)\n', 'False'),
 
648
            'success', ('ok', 'no', 'no', 'no', network_name))
 
649
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
783
650
            _client=client)
784
651
        repo = a_bzrdir.create_repository()
785
652
        # We should have got a remote repository
786
653
        self.assertIsInstance(repo, remote.RemoteRepository)
787
654
        # its format should have the settings from the response
788
655
        format = repo._format
789
 
        self.assertTrue(format.rich_root_data)
790
 
        self.assertTrue(format.supports_tree_reference)
791
 
        self.assertTrue(format.supports_external_lookups)
 
656
        self.assertFalse(format.rich_root_data)
 
657
        self.assertFalse(format.supports_tree_reference)
 
658
        self.assertFalse(format.supports_external_lookups)
792
659
        self.assertEqual(network_name, format.network_name())
793
660
 
794
661
 
798
665
        # fallback all the way to the first version.
799
666
        reference_format = self.get_repo_format()
800
667
        network_name = reference_format.network_name()
801
 
        server_url = 'bzr://example.com/'
802
 
        self.permit_url(server_url)
803
 
        client = FakeClient(server_url)
 
668
        client = FakeClient('bzr://example.com/')
804
669
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
805
670
        client.add_unknown_method_response('BzrDir.find_repositoryV2')
806
671
        client.add_success_response('ok', '', 'no', 'no')
812
677
            reference_format.get_format_string(), 'ok')
813
678
        # PackRepository wants to do a stat
814
679
        client.add_success_response('stat', '0', '65535')
815
 
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
 
680
        remote_transport = RemoteTransport('bzr://example.com/quack/', medium=False,
816
681
            _client=client)
817
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
 
682
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
818
683
            _client=client)
819
684
        repo = bzrdir.open_repository()
820
685
        self.assertEqual(
832
697
        # fallback to find_repositoryV2
833
698
        reference_format = self.get_repo_format()
834
699
        network_name = reference_format.network_name()
835
 
        server_url = 'bzr://example.com/'
836
 
        self.permit_url(server_url)
837
 
        client = FakeClient(server_url)
 
700
        client = FakeClient('bzr://example.com/')
838
701
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
839
702
        client.add_success_response('ok', '', 'no', 'no', 'no')
840
703
        # A real repository instance will be created to determine the network
845
708
            reference_format.get_format_string(), 'ok')
846
709
        # PackRepository wants to do a stat
847
710
        client.add_success_response('stat', '0', '65535')
848
 
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
 
711
        remote_transport = RemoteTransport('bzr://example.com/quack/', medium=False,
849
712
            _client=client)
850
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
 
713
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
851
714
            _client=client)
852
715
        repo = bzrdir.open_repository()
853
716
        self.assertEqual(
868
731
        transport = transport.clone('quack')
869
732
        client = FakeClient(transport.base)
870
733
        client.add_success_response('ok', '', 'no', 'no', 'no', network_name)
871
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
734
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
872
735
            _client=client)
873
736
        repo = bzrdir.open_repository()
874
737
        self.assertEqual(
877
740
        self.assertEqual(network_name, repo._format.network_name())
878
741
 
879
742
 
880
 
class TestBzrDirFormatInitializeEx(TestRemote):
881
 
 
882
 
    def test_success(self):
883
 
        """Simple test for typical successful call."""
884
 
        fmt = RemoteBzrDirFormat()
885
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
886
 
        transport = self.get_transport()
887
 
        client = FakeClient(transport.base)
888
 
        client.add_expected_call(
889
 
            'BzrDirFormat.initialize_ex_1.16',
890
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
891
 
                 '', '', '', 'False'),
892
 
            'success',
893
 
                ('.', 'no', 'no', 'yes', 'repo fmt', 'repo bzrdir fmt',
894
 
                 'bzrdir fmt', 'False', '', '', 'repo lock token'))
895
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
896
 
        # it's currently hard to test that without supplying a real remote
897
 
        # transport connected to a real server.
898
 
        result = fmt._initialize_on_transport_ex_rpc(client, 'path',
899
 
            transport, False, False, False, None, None, None, None, False)
900
 
        self.assertFinished(client)
901
 
 
902
 
    def test_error(self):
903
 
        """Error responses are translated, e.g. 'PermissionDenied' raises the
904
 
        corresponding error from the client.
905
 
        """
906
 
        fmt = RemoteBzrDirFormat()
907
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
908
 
        transport = self.get_transport()
909
 
        client = FakeClient(transport.base)
910
 
        client.add_expected_call(
911
 
            'BzrDirFormat.initialize_ex_1.16',
912
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
913
 
                 '', '', '', 'False'),
914
 
            'error',
915
 
                ('PermissionDenied', 'path', 'extra info'))
916
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
917
 
        # it's currently hard to test that without supplying a real remote
918
 
        # transport connected to a real server.
919
 
        err = self.assertRaises(errors.PermissionDenied,
920
 
            fmt._initialize_on_transport_ex_rpc, client, 'path', transport,
921
 
            False, False, False, None, None, None, None, False)
922
 
        self.assertEqual('path', err.path)
923
 
        self.assertEqual(': extra info', err.extra)
924
 
        self.assertFinished(client)
925
 
 
926
 
    def test_error_from_real_server(self):
927
 
        """Integration test for error translation."""
928
 
        transport = self.make_smart_server('foo')
929
 
        transport = transport.clone('no-such-path')
930
 
        fmt = RemoteBzrDirFormat()
931
 
        err = self.assertRaises(errors.NoSuchFile,
932
 
            fmt.initialize_on_transport_ex, transport, create_prefix=False)
933
 
 
934
 
 
935
743
class OldSmartClient(object):
936
744
    """A fake smart client for test_old_version that just returns a version one
937
745
    response to the 'hello' (query version) command.
960
768
        return OldSmartClient()
961
769
 
962
770
 
963
 
class RemoteBzrDirTestCase(TestRemote):
964
 
 
965
 
    def make_remote_bzrdir(self, transport, client):
966
 
        """Make a RemotebzrDir using 'client' as the _client."""
967
 
        return RemoteBzrDir(transport, RemoteBzrDirFormat(),
968
 
            _client=client)
969
 
 
970
 
 
971
 
class RemoteBranchTestCase(RemoteBzrDirTestCase):
972
 
 
973
 
    def lock_remote_branch(self, branch):
974
 
        """Trick a RemoteBranch into thinking it is locked."""
975
 
        branch._lock_mode = 'w'
976
 
        branch._lock_count = 2
977
 
        branch._lock_token = 'branch token'
978
 
        branch._repo_lock_token = 'repo token'
979
 
        branch.repository._lock_mode = 'w'
980
 
        branch.repository._lock_count = 2
981
 
        branch.repository._lock_token = 'repo token'
 
771
class RemoteBranchTestCase(TestRemote):
982
772
 
983
773
    def make_remote_branch(self, transport, client):
984
774
        """Make a RemoteBranch using 'client' as its _SmartClient.
989
779
        # we do not want bzrdir to make any remote calls, so use False as its
990
780
        # _client.  If it tries to make a remote call, this will fail
991
781
        # immediately.
992
 
        bzrdir = self.make_remote_bzrdir(transport, False)
 
782
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
 
783
            _client=False)
993
784
        repo = RemoteRepository(bzrdir, None, _client=client)
994
785
        branch_format = self.get_branch_format()
995
786
        format = RemoteBranchFormat(network_name=branch_format.network_name())
1012
803
        transport = transport.clone('quack')
1013
804
        branch = self.make_remote_branch(transport, client)
1014
805
        result = branch.get_parent()
1015
 
        self.assertFinished(client)
 
806
        client.finished_test()
1016
807
        self.assertEqual(None, result)
1017
808
 
1018
809
    def test_parent_relative(self):
1044
835
        branch = self.make_remote_branch(transport, client)
1045
836
        result = branch.get_parent()
1046
837
        self.assertEqual('http://foo/', result)
1047
 
        self.assertFinished(client)
1048
 
 
1049
 
 
1050
 
class TestBranchSetParentLocation(RemoteBranchTestCase):
1051
 
 
1052
 
    def test_no_parent(self):
1053
 
        # We call the verb when setting parent to None
1054
 
        transport = MemoryTransport()
1055
 
        client = FakeClient(transport.base)
1056
 
        client.add_expected_call(
1057
 
            'Branch.get_stacked_on_url', ('quack/',),
1058
 
            'error', ('NotStacked',))
1059
 
        client.add_expected_call(
1060
 
            'Branch.set_parent_location', ('quack/', 'b', 'r', ''),
1061
 
            'success', ())
1062
 
        transport.mkdir('quack')
1063
 
        transport = transport.clone('quack')
1064
 
        branch = self.make_remote_branch(transport, client)
1065
 
        branch._lock_token = 'b'
1066
 
        branch._repo_lock_token = 'r'
1067
 
        branch._set_parent_location(None)
1068
 
        self.assertFinished(client)
1069
 
 
1070
 
    def test_parent(self):
1071
 
        transport = MemoryTransport()
1072
 
        client = FakeClient(transport.base)
1073
 
        client.add_expected_call(
1074
 
            'Branch.get_stacked_on_url', ('kwaak/',),
1075
 
            'error', ('NotStacked',))
1076
 
        client.add_expected_call(
1077
 
            'Branch.set_parent_location', ('kwaak/', 'b', 'r', 'foo'),
1078
 
            'success', ())
1079
 
        transport.mkdir('kwaak')
1080
 
        transport = transport.clone('kwaak')
1081
 
        branch = self.make_remote_branch(transport, client)
1082
 
        branch._lock_token = 'b'
1083
 
        branch._repo_lock_token = 'r'
1084
 
        branch._set_parent_location('foo')
1085
 
        self.assertFinished(client)
1086
 
 
1087
 
    def test_backwards_compat(self):
1088
 
        self.setup_smart_server_with_call_log()
1089
 
        branch = self.make_branch('.')
1090
 
        self.reset_smart_call_log()
1091
 
        verb = 'Branch.set_parent_location'
1092
 
        self.disable_verb(verb)
1093
 
        branch.set_parent('http://foo/')
1094
 
        self.assertLength(12, self.hpss_calls)
1095
838
 
1096
839
 
1097
840
class TestBranchGetTagsBytes(RemoteBranchTestCase):
1120
863
        transport = transport.clone('quack')
1121
864
        branch = self.make_remote_branch(transport, client)
1122
865
        result = branch.tags.get_tag_dict()
1123
 
        self.assertFinished(client)
 
866
        client.finished_test()
1124
867
        self.assertEqual({}, result)
1125
868
 
1126
869
 
1127
 
class TestBranchSetTagsBytes(RemoteBranchTestCase):
1128
 
 
1129
 
    def test_trivial(self):
1130
 
        transport = MemoryTransport()
1131
 
        client = FakeClient(transport.base)
1132
 
        client.add_expected_call(
1133
 
            'Branch.get_stacked_on_url', ('quack/',),
1134
 
            'error', ('NotStacked',))
1135
 
        client.add_expected_call(
1136
 
            'Branch.set_tags_bytes', ('quack/', 'branch token', 'repo token'),
1137
 
            'success', ('',))
1138
 
        transport.mkdir('quack')
1139
 
        transport = transport.clone('quack')
1140
 
        branch = self.make_remote_branch(transport, client)
1141
 
        self.lock_remote_branch(branch)
1142
 
        branch._set_tags_bytes('tags bytes')
1143
 
        self.assertFinished(client)
1144
 
        self.assertEqual('tags bytes', client._calls[-1][-1])
1145
 
 
1146
 
    def test_backwards_compatible(self):
1147
 
        transport = MemoryTransport()
1148
 
        client = FakeClient(transport.base)
1149
 
        client.add_expected_call(
1150
 
            'Branch.get_stacked_on_url', ('quack/',),
1151
 
            'error', ('NotStacked',))
1152
 
        client.add_expected_call(
1153
 
            'Branch.set_tags_bytes', ('quack/', 'branch token', 'repo token'),
1154
 
            'unknown', ('Branch.set_tags_bytes',))
1155
 
        transport.mkdir('quack')
1156
 
        transport = transport.clone('quack')
1157
 
        branch = self.make_remote_branch(transport, client)
1158
 
        self.lock_remote_branch(branch)
1159
 
        class StubRealBranch(object):
1160
 
            def __init__(self):
1161
 
                self.calls = []
1162
 
            def _set_tags_bytes(self, bytes):
1163
 
                self.calls.append(('set_tags_bytes', bytes))
1164
 
        real_branch = StubRealBranch()
1165
 
        branch._real_branch = real_branch
1166
 
        branch._set_tags_bytes('tags bytes')
1167
 
        # Call a second time, to exercise the 'remote version already inferred'
1168
 
        # code path.
1169
 
        branch._set_tags_bytes('tags bytes')
1170
 
        self.assertFinished(client)
1171
 
        self.assertEqual(
1172
 
            [('set_tags_bytes', 'tags bytes')] * 2, real_branch.calls)
1173
 
 
1174
 
 
1175
 
class TestBranchHeadsToFetch(RemoteBranchTestCase):
1176
 
 
1177
 
    def test_uses_last_revision_info_and_tags_by_default(self):
1178
 
        transport = MemoryTransport()
1179
 
        client = FakeClient(transport.base)
1180
 
        client.add_expected_call(
1181
 
            'Branch.get_stacked_on_url', ('quack/',),
1182
 
            'error', ('NotStacked',))
1183
 
        client.add_expected_call(
1184
 
            'Branch.last_revision_info', ('quack/',),
1185
 
            'success', ('ok', '1', 'rev-tip'))
1186
 
        client.add_expected_call(
1187
 
            'Branch.get_config_file', ('quack/',),
1188
 
            'success', ('ok',), '')
1189
 
        transport.mkdir('quack')
1190
 
        transport = transport.clone('quack')
1191
 
        branch = self.make_remote_branch(transport, client)
1192
 
        result = branch.heads_to_fetch()
1193
 
        self.assertFinished(client)
1194
 
        self.assertEqual((set(['rev-tip']), set()), result)
1195
 
 
1196
 
    def test_uses_last_revision_info_and_tags_when_set(self):
1197
 
        transport = MemoryTransport()
1198
 
        client = FakeClient(transport.base)
1199
 
        client.add_expected_call(
1200
 
            'Branch.get_stacked_on_url', ('quack/',),
1201
 
            'error', ('NotStacked',))
1202
 
        client.add_expected_call(
1203
 
            'Branch.last_revision_info', ('quack/',),
1204
 
            'success', ('ok', '1', 'rev-tip'))
1205
 
        client.add_expected_call(
1206
 
            'Branch.get_config_file', ('quack/',),
1207
 
            'success', ('ok',), 'branch.fetch_tags = True')
1208
 
        # XXX: this will break if the default format's serialization of tags
1209
 
        # changes, or if the RPC for fetching tags changes from get_tags_bytes.
1210
 
        client.add_expected_call(
1211
 
            'Branch.get_tags_bytes', ('quack/',),
1212
 
            'success', ('d5:tag-17:rev-foo5:tag-27:rev-bare',))
1213
 
        transport.mkdir('quack')
1214
 
        transport = transport.clone('quack')
1215
 
        branch = self.make_remote_branch(transport, client)
1216
 
        result = branch.heads_to_fetch()
1217
 
        self.assertFinished(client)
1218
 
        self.assertEqual(
1219
 
            (set(['rev-tip']), set(['rev-foo', 'rev-bar'])), result)
1220
 
 
1221
 
    def test_uses_rpc_for_formats_with_non_default_heads_to_fetch(self):
1222
 
        transport = MemoryTransport()
1223
 
        client = FakeClient(transport.base)
1224
 
        client.add_expected_call(
1225
 
            'Branch.get_stacked_on_url', ('quack/',),
1226
 
            'error', ('NotStacked',))
1227
 
        client.add_expected_call(
1228
 
            'Branch.heads_to_fetch', ('quack/',),
1229
 
            'success', (['tip'], ['tagged-1', 'tagged-2']))
1230
 
        transport.mkdir('quack')
1231
 
        transport = transport.clone('quack')
1232
 
        branch = self.make_remote_branch(transport, client)
1233
 
        branch._format._use_default_local_heads_to_fetch = lambda: False
1234
 
        result = branch.heads_to_fetch()
1235
 
        self.assertFinished(client)
1236
 
        self.assertEqual((set(['tip']), set(['tagged-1', 'tagged-2'])), result)
1237
 
 
1238
 
    def make_branch_with_tags(self):
1239
 
        self.setup_smart_server_with_call_log()
1240
 
        # Make a branch with a single revision.
1241
 
        builder = self.make_branch_builder('foo')
1242
 
        builder.start_series()
1243
 
        builder.build_snapshot('tip', None, [
1244
 
            ('add', ('', 'root-id', 'directory', ''))])
1245
 
        builder.finish_series()
1246
 
        branch = builder.get_branch()
1247
 
        # Add two tags to that branch
1248
 
        branch.tags.set_tag('tag-1', 'rev-1')
1249
 
        branch.tags.set_tag('tag-2', 'rev-2')
1250
 
        return branch
1251
 
 
1252
 
    def test_backwards_compatible(self):
1253
 
        branch = self.make_branch_with_tags()
1254
 
        c = branch.get_config()
1255
 
        c.set_user_option('branch.fetch_tags', 'True')
1256
 
        self.addCleanup(branch.lock_read().unlock)
1257
 
        # Disable the heads_to_fetch verb
1258
 
        verb = 'Branch.heads_to_fetch'
1259
 
        self.disable_verb(verb)
1260
 
        self.reset_smart_call_log()
1261
 
        result = branch.heads_to_fetch()
1262
 
        self.assertEqual((set(['tip']), set(['rev-1', 'rev-2'])), result)
1263
 
        self.assertEqual(
1264
 
            ['Branch.last_revision_info', 'Branch.get_config_file',
1265
 
             'Branch.get_tags_bytes'],
1266
 
            [call.call.method for call in self.hpss_calls])
1267
 
 
1268
 
    def test_backwards_compatible_no_tags(self):
1269
 
        branch = self.make_branch_with_tags()
1270
 
        c = branch.get_config()
1271
 
        c.set_user_option('branch.fetch_tags', 'False')
1272
 
        self.addCleanup(branch.lock_read().unlock)
1273
 
        # Disable the heads_to_fetch verb
1274
 
        verb = 'Branch.heads_to_fetch'
1275
 
        self.disable_verb(verb)
1276
 
        self.reset_smart_call_log()
1277
 
        result = branch.heads_to_fetch()
1278
 
        self.assertEqual((set(['tip']), set()), result)
1279
 
        self.assertEqual(
1280
 
            ['Branch.last_revision_info', 'Branch.get_config_file'],
1281
 
            [call.call.method for call in self.hpss_calls])
1282
 
 
1283
 
 
1284
870
class TestBranchLastRevisionInfo(RemoteBranchTestCase):
1285
871
 
1286
872
    def test_empty_branch(self):
1297
883
        transport = transport.clone('quack')
1298
884
        branch = self.make_remote_branch(transport, client)
1299
885
        result = branch.last_revision_info()
1300
 
        self.assertFinished(client)
 
886
        client.finished_test()
1301
887
        self.assertEqual((0, NULL_REVISION), result)
1302
888
 
1303
889
    def test_non_empty_branch(self):
1341
927
        client.add_expected_call(
1342
928
            'Branch.get_stacked_on_url', ('stacked/',),
1343
929
            'success', ('ok', vfs_url))
1344
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
930
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1345
931
            _client=client)
1346
932
        repo_fmt = remote.RemoteRepositoryFormat()
1347
933
        repo_fmt._custom_format = stacked_branch.repository._format
1358
944
        client = FakeClient(self.get_url())
1359
945
        branch_network_name = self.get_branch_format().network_name()
1360
946
        client.add_expected_call(
1361
 
            'BzrDir.open_branchV3', ('stacked/',),
 
947
            'BzrDir.open_branchV2', ('stacked/',),
1362
948
            'success', ('branch', branch_network_name))
1363
949
        client.add_expected_call(
1364
950
            'BzrDir.find_repositoryV3', ('stacked/',),
1374
960
        # this will also do vfs access, but that goes direct to the transport
1375
961
        # and isn't seen by the FakeClient.
1376
962
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1377
 
            RemoteBzrDirFormat(), _client=client)
 
963
            remote.RemoteBzrDirFormat(), _client=client)
1378
964
        branch = bzrdir.open_branch()
1379
965
        result = branch.get_stacked_on_url()
1380
966
        self.assertEqual('../base', result)
1381
 
        self.assertFinished(client)
 
967
        client.finished_test()
1382
968
        # it's in the fallback list both for the RemoteRepository and its vfs
1383
969
        # repository
1384
970
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1386
972
            len(branch.repository._real_repository._fallback_repositories))
1387
973
 
1388
974
    def test_get_stacked_on_real_branch(self):
1389
 
        base_branch = self.make_branch('base')
1390
 
        stacked_branch = self.make_branch('stacked')
 
975
        base_branch = self.make_branch('base', format='1.6')
 
976
        stacked_branch = self.make_branch('stacked', format='1.6')
1391
977
        stacked_branch.set_stacked_on_url('../base')
1392
978
        reference_format = self.get_repo_format()
1393
979
        network_name = reference_format.network_name()
1394
980
        client = FakeClient(self.get_url())
1395
981
        branch_network_name = self.get_branch_format().network_name()
1396
982
        client.add_expected_call(
1397
 
            'BzrDir.open_branchV3', ('stacked/',),
 
983
            'BzrDir.open_branchV2', ('stacked/',),
1398
984
            'success', ('branch', branch_network_name))
1399
985
        client.add_expected_call(
1400
986
            'BzrDir.find_repositoryV3', ('stacked/',),
1401
 
            'success', ('ok', '', 'yes', 'no', 'yes', network_name))
 
987
            'success', ('ok', '', 'no', 'no', 'yes', network_name))
1402
988
        # called twice, once from constructor and then again by us
1403
989
        client.add_expected_call(
1404
990
            'Branch.get_stacked_on_url', ('stacked/',),
1407
993
            'Branch.get_stacked_on_url', ('stacked/',),
1408
994
            'success', ('ok', '../base'))
1409
995
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1410
 
            RemoteBzrDirFormat(), _client=client)
 
996
            remote.RemoteBzrDirFormat(), _client=client)
1411
997
        branch = bzrdir.open_branch()
1412
998
        result = branch.get_stacked_on_url()
1413
999
        self.assertEqual('../base', result)
1414
 
        self.assertFinished(client)
1415
 
        # it's in the fallback list both for the RemoteRepository.
 
1000
        client.finished_test()
 
1001
        # it's in the fallback list both for the RemoteRepository and its vfs
 
1002
        # repository
1416
1003
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1417
 
        # And we haven't had to construct a real repository.
1418
 
        self.assertEqual(None, branch.repository._real_repository)
 
1004
        self.assertEqual(1,
 
1005
            len(branch.repository._real_repository._fallback_repositories))
1419
1006
 
1420
1007
 
1421
1008
class TestBranchSetLastRevision(RemoteBranchTestCase):
1422
1009
 
1423
1010
    def test_set_empty(self):
1424
 
        # _set_last_revision_info('null:') is translated to calling
 
1011
        # set_revision_history([]) is translated to calling
1425
1012
        # Branch.set_last_revision(path, '') on the wire.
1426
1013
        transport = MemoryTransport()
1427
1014
        transport.mkdir('branch')
1449
1036
        # unnecessarily invokes _ensure_real upon a call to lock_write.
1450
1037
        branch._ensure_real = lambda: None
1451
1038
        branch.lock_write()
1452
 
        result = branch._set_last_revision(NULL_REVISION)
 
1039
        result = branch.set_revision_history([])
1453
1040
        branch.unlock()
1454
1041
        self.assertEqual(None, result)
1455
 
        self.assertFinished(client)
 
1042
        client.finished_test()
1456
1043
 
1457
1044
    def test_set_nonempty(self):
1458
 
        # set_last_revision_info(N, rev-idN) is translated to calling
 
1045
        # set_revision_history([rev-id1, ..., rev-idN]) is translated to calling
1459
1046
        # Branch.set_last_revision(path, rev-idN) on the wire.
1460
1047
        transport = MemoryTransport()
1461
1048
        transport.mkdir('branch')
1487
1074
        branch._ensure_real = lambda: None
1488
1075
        # Lock the branch, reset the record of remote calls.
1489
1076
        branch.lock_write()
1490
 
        result = branch._set_last_revision('rev-id2')
 
1077
        result = branch.set_revision_history(['rev-id1', 'rev-id2'])
1491
1078
        branch.unlock()
1492
1079
        self.assertEqual(None, result)
1493
 
        self.assertFinished(client)
 
1080
        client.finished_test()
1494
1081
 
1495
1082
    def test_no_such_revision(self):
1496
1083
        transport = MemoryTransport()
1523
1110
        branch = self.make_remote_branch(transport, client)
1524
1111
        branch.lock_write()
1525
1112
        self.assertRaises(
1526
 
            errors.NoSuchRevision, branch._set_last_revision, 'rev-id')
 
1113
            errors.NoSuchRevision, branch.set_revision_history, ['rev-id'])
1527
1114
        branch.unlock()
1528
 
        self.assertFinished(client)
 
1115
        client.finished_test()
1529
1116
 
1530
1117
    def test_tip_change_rejected(self):
1531
1118
        """TipChangeRejected responses cause a TipChangeRejected exception to
1560
1147
        branch._ensure_real = lambda: None
1561
1148
        branch.lock_write()
1562
1149
        # The 'TipChangeRejected' error response triggered by calling
1563
 
        # set_last_revision_info causes a TipChangeRejected exception.
 
1150
        # set_revision_history causes a TipChangeRejected exception.
1564
1151
        err = self.assertRaises(
1565
 
            errors.TipChangeRejected,
1566
 
            branch._set_last_revision, 'rev-id')
 
1152
            errors.TipChangeRejected, branch.set_revision_history, ['rev-id'])
1567
1153
        # The UTF-8 message from the response has been decoded into a unicode
1568
1154
        # object.
1569
1155
        self.assertIsInstance(err.msg, unicode)
1570
1156
        self.assertEqual(rejection_msg_unicode, err.msg)
1571
1157
        branch.unlock()
1572
 
        self.assertFinished(client)
 
1158
        client.finished_test()
1573
1159
 
1574
1160
 
1575
1161
class TestBranchSetLastRevisionInfo(RemoteBranchTestCase):
1629
1215
            errors.NoSuchRevision, branch.set_last_revision_info, 123, 'revid')
1630
1216
        branch.unlock()
1631
1217
 
 
1218
    def lock_remote_branch(self, branch):
 
1219
        """Trick a RemoteBranch into thinking it is locked."""
 
1220
        branch._lock_mode = 'w'
 
1221
        branch._lock_count = 2
 
1222
        branch._lock_token = 'branch token'
 
1223
        branch._repo_lock_token = 'repo token'
 
1224
        branch.repository._lock_mode = 'w'
 
1225
        branch.repository._lock_count = 2
 
1226
        branch.repository._lock_token = 'repo token'
 
1227
 
1632
1228
    def test_backwards_compatibility(self):
1633
1229
        """If the server does not support the Branch.set_last_revision_info
1634
1230
        verb (which is new in 1.4), then the client falls back to VFS methods.
1675
1271
        self.assertEqual(
1676
1272
            [('set_last_revision_info', 1234, 'a-revision-id')],
1677
1273
            real_branch.calls)
1678
 
        self.assertFinished(client)
 
1274
        client.finished_test()
1679
1275
 
1680
1276
    def test_unexpected_error(self):
1681
1277
        # If the server sends an error the client doesn't understand, it gets
1736
1332
        self.assertEqual('rejection message', err.msg)
1737
1333
 
1738
1334
 
1739
 
class TestBranchGetSetConfig(RemoteBranchTestCase):
 
1335
class TestBranchControlGetBranchConf(tests.TestCaseWithMemoryTransport):
 
1336
    """Getting the branch configuration should use an abstract method not vfs.
 
1337
    """
1740
1338
 
1741
1339
    def test_get_branch_conf(self):
1742
 
        # in an empty branch we decode the response properly
1743
 
        client = FakeClient()
1744
 
        client.add_expected_call(
1745
 
            'Branch.get_stacked_on_url', ('memory:///',),
1746
 
            'error', ('NotStacked',),)
1747
 
        client.add_success_response_with_body('# config file body', 'ok')
1748
 
        transport = MemoryTransport()
1749
 
        branch = self.make_remote_branch(transport, client)
1750
 
        config = branch.get_config()
1751
 
        config.has_explicit_nickname()
1752
 
        self.assertEqual(
1753
 
            [('call', 'Branch.get_stacked_on_url', ('memory:///',)),
1754
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',))],
1755
 
            client._calls)
1756
 
 
1757
 
    def test_get_multi_line_branch_conf(self):
1758
 
        # Make sure that multiple-line branch.conf files are supported
1759
 
        #
1760
 
        # https://bugs.launchpad.net/bzr/+bug/354075
1761
 
        client = FakeClient()
1762
 
        client.add_expected_call(
1763
 
            'Branch.get_stacked_on_url', ('memory:///',),
1764
 
            'error', ('NotStacked',),)
1765
 
        client.add_success_response_with_body('a = 1\nb = 2\nc = 3\n', 'ok')
1766
 
        transport = MemoryTransport()
1767
 
        branch = self.make_remote_branch(transport, client)
1768
 
        config = branch.get_config()
1769
 
        self.assertEqual(u'2', config.get_user_option('b'))
1770
 
 
1771
 
    def test_set_option(self):
1772
 
        client = FakeClient()
1773
 
        client.add_expected_call(
1774
 
            'Branch.get_stacked_on_url', ('memory:///',),
1775
 
            'error', ('NotStacked',),)
1776
 
        client.add_expected_call(
1777
 
            'Branch.lock_write', ('memory:///', '', ''),
1778
 
            'success', ('ok', 'branch token', 'repo token'))
1779
 
        client.add_expected_call(
1780
 
            'Branch.set_config_option', ('memory:///', 'branch token',
1781
 
            'repo token', 'foo', 'bar', ''),
1782
 
            'success', ())
1783
 
        client.add_expected_call(
1784
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1785
 
            'success', ('ok',))
1786
 
        transport = MemoryTransport()
1787
 
        branch = self.make_remote_branch(transport, client)
1788
 
        branch.lock_write()
1789
 
        config = branch._get_config()
1790
 
        config.set_option('foo', 'bar')
1791
 
        branch.unlock()
1792
 
        self.assertFinished(client)
1793
 
 
1794
 
    def test_set_option_with_dict(self):
1795
 
        client = FakeClient()
1796
 
        client.add_expected_call(
1797
 
            'Branch.get_stacked_on_url', ('memory:///',),
1798
 
            'error', ('NotStacked',),)
1799
 
        client.add_expected_call(
1800
 
            'Branch.lock_write', ('memory:///', '', ''),
1801
 
            'success', ('ok', 'branch token', 'repo token'))
1802
 
        encoded_dict_value = 'd5:ascii1:a11:unicode \xe2\x8c\x9a3:\xe2\x80\xbde'
1803
 
        client.add_expected_call(
1804
 
            'Branch.set_config_option_dict', ('memory:///', 'branch token',
1805
 
            'repo token', encoded_dict_value, 'foo', ''),
1806
 
            'success', ())
1807
 
        client.add_expected_call(
1808
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1809
 
            'success', ('ok',))
1810
 
        transport = MemoryTransport()
1811
 
        branch = self.make_remote_branch(transport, client)
1812
 
        branch.lock_write()
1813
 
        config = branch._get_config()
1814
 
        config.set_option(
1815
 
            {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'},
1816
 
            'foo')
1817
 
        branch.unlock()
1818
 
        self.assertFinished(client)
1819
 
 
1820
 
    def test_backwards_compat_set_option(self):
1821
 
        self.setup_smart_server_with_call_log()
1822
 
        branch = self.make_branch('.')
1823
 
        verb = 'Branch.set_config_option'
1824
 
        self.disable_verb(verb)
1825
 
        branch.lock_write()
1826
 
        self.addCleanup(branch.unlock)
1827
 
        self.reset_smart_call_log()
1828
 
        branch._get_config().set_option('value', 'name')
1829
 
        self.assertLength(10, self.hpss_calls)
1830
 
        self.assertEqual('value', branch._get_config().get_option('name'))
1831
 
 
1832
 
    def test_backwards_compat_set_option_with_dict(self):
1833
 
        self.setup_smart_server_with_call_log()
1834
 
        branch = self.make_branch('.')
1835
 
        verb = 'Branch.set_config_option_dict'
1836
 
        self.disable_verb(verb)
1837
 
        branch.lock_write()
1838
 
        self.addCleanup(branch.unlock)
1839
 
        self.reset_smart_call_log()
1840
 
        config = branch._get_config()
1841
 
        value_dict = {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'}
1842
 
        config.set_option(value_dict, 'name')
1843
 
        self.assertLength(10, self.hpss_calls)
1844
 
        self.assertEqual(value_dict, branch._get_config().get_option('name'))
 
1340
        raise tests.KnownFailure('branch.conf is not retrieved by get_config_file')
 
1341
        ## # We should see that branch.get_config() does a single rpc to get the
 
1342
        ## # remote configuration file, abstracting away where that is stored on
 
1343
        ## # the server.  However at the moment it always falls back to using the
 
1344
        ## # vfs, and this would need some changes in config.py.
 
1345
 
 
1346
        ## # in an empty branch we decode the response properly
 
1347
        ## client = FakeClient([(('ok', ), '# config file body')], self.get_url())
 
1348
        ## # we need to make a real branch because the remote_branch.control_files
 
1349
        ## # will trigger _ensure_real.
 
1350
        ## branch = self.make_branch('quack')
 
1351
        ## transport = branch.bzrdir.root_transport
 
1352
        ## # we do not want bzrdir to make any remote calls
 
1353
        ## bzrdir = RemoteBzrDir(transport, _client=False)
 
1354
        ## branch = RemoteBranch(bzrdir, None, _client=client)
 
1355
        ## config = branch.get_config()
 
1356
        ## self.assertEqual(
 
1357
        ##     [('call_expecting_body', 'Branch.get_config_file', ('quack/',))],
 
1358
        ##     client._calls)
1845
1359
 
1846
1360
 
1847
1361
class TestBranchLockWrite(RemoteBranchTestCase):
1859
1373
        transport = transport.clone('quack')
1860
1374
        branch = self.make_remote_branch(transport, client)
1861
1375
        self.assertRaises(errors.UnlockableTransport, branch.lock_write)
1862
 
        self.assertFinished(client)
1863
 
 
1864
 
 
1865
 
class TestBzrDirGetSetConfig(RemoteBzrDirTestCase):
1866
 
 
1867
 
    def test__get_config(self):
1868
 
        client = FakeClient()
1869
 
        client.add_success_response_with_body('default_stack_on = /\n', 'ok')
1870
 
        transport = MemoryTransport()
1871
 
        bzrdir = self.make_remote_bzrdir(transport, client)
1872
 
        config = bzrdir.get_config()
1873
 
        self.assertEqual('/', config.get_default_stack_on())
1874
 
        self.assertEqual(
1875
 
            [('call_expecting_body', 'BzrDir.get_config_file', ('memory:///',))],
1876
 
            client._calls)
1877
 
 
1878
 
    def test_set_option_uses_vfs(self):
1879
 
        self.setup_smart_server_with_call_log()
1880
 
        bzrdir = self.make_bzrdir('.')
1881
 
        self.reset_smart_call_log()
1882
 
        config = bzrdir.get_config()
1883
 
        config.set_default_stack_on('/')
1884
 
        self.assertLength(3, self.hpss_calls)
1885
 
 
1886
 
    def test_backwards_compat_get_option(self):
1887
 
        self.setup_smart_server_with_call_log()
1888
 
        bzrdir = self.make_bzrdir('.')
1889
 
        verb = 'BzrDir.get_config_file'
1890
 
        self.disable_verb(verb)
1891
 
        self.reset_smart_call_log()
1892
 
        self.assertEqual(None,
1893
 
            bzrdir._get_config().get_option('default_stack_on'))
1894
 
        self.assertLength(3, self.hpss_calls)
 
1376
        client.finished_test()
1895
1377
 
1896
1378
 
1897
1379
class TestTransportIsReadonly(tests.TestCase):
1984
1466
        client = FakeClient(transport.base)
1985
1467
        transport = transport.clone(transport_path)
1986
1468
        # we do not want bzrdir to make any remote calls
1987
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
 
1469
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1988
1470
            _client=False)
1989
1471
        repo = RemoteRepository(bzrdir, None, _client=client)
1990
1472
        return repo, client
1991
1473
 
1992
1474
 
1993
 
def remoted_description(format):
1994
 
    return 'Remote: ' + format.get_format_description()
1995
 
 
1996
 
 
1997
 
class TestBranchFormat(tests.TestCase):
1998
 
 
1999
 
    def test_get_format_description(self):
2000
 
        remote_format = RemoteBranchFormat()
2001
 
        real_format = branch.format_registry.get_default()
2002
 
        remote_format._network_name = real_format.network_name()
2003
 
        self.assertEqual(remoted_description(real_format),
2004
 
            remote_format.get_format_description())
2005
 
 
2006
 
 
2007
1475
class TestRepositoryFormat(TestRemoteRepository):
2008
1476
 
2009
1477
    def test_fast_delta(self):
2010
 
        true_name = groupcompress_repo.RepositoryFormat2a().network_name()
 
1478
        true_name = pack_repo.RepositoryFormatPackDevelopment2().network_name()
2011
1479
        true_format = RemoteRepositoryFormat()
2012
1480
        true_format._network_name = true_name
2013
1481
        self.assertEqual(True, true_format.fast_deltas)
2014
 
        false_name = knitpack_repo.RepositoryFormatKnitPack1().network_name()
 
1482
        false_name = pack_repo.RepositoryFormatKnitPack1().network_name()
2015
1483
        false_format = RemoteRepositoryFormat()
2016
1484
        false_format._network_name = false_name
2017
1485
        self.assertEqual(False, false_format.fast_deltas)
2018
1486
 
2019
 
    def test_get_format_description(self):
2020
 
        remote_repo_format = RemoteRepositoryFormat()
2021
 
        real_format = repository.format_registry.get_default()
2022
 
        remote_repo_format._network_name = real_format.network_name()
2023
 
        self.assertEqual(remoted_description(real_format),
2024
 
            remote_repo_format.get_format_description())
2025
 
 
2026
1487
 
2027
1488
class TestRepositoryGatherStats(TestRemoteRepository):
2028
1489
 
2212
1673
                'more-missing']))
2213
1674
        self.assertLength(1, self.hpss_calls)
2214
1675
 
2215
 
    def disableExtraResults(self):
2216
 
        self.overrideAttr(SmartServerRepositoryGetParentMap,
2217
 
                          'no_extra_results', True)
2218
 
 
2219
 
    def test_null_cached_missing_and_stop_key(self):
2220
 
        self.setup_smart_server_with_call_log()
2221
 
        # Make a branch with a single revision.
2222
 
        builder = self.make_branch_builder('foo')
2223
 
        builder.start_series()
2224
 
        builder.build_snapshot('first', None, [
2225
 
            ('add', ('', 'root-id', 'directory', ''))])
2226
 
        builder.finish_series()
2227
 
        branch = builder.get_branch()
2228
 
        repo = branch.repository
2229
 
        self.assertIsInstance(repo, RemoteRepository)
2230
 
        # Stop the server from sending extra results.
2231
 
        self.disableExtraResults()
2232
 
        repo.lock_read()
2233
 
        self.addCleanup(repo.unlock)
2234
 
        self.reset_smart_call_log()
2235
 
        graph = repo.get_graph()
2236
 
        # Query for 'first' and 'null:'.  Because 'null:' is a parent of
2237
 
        # 'first' it will be a candidate for the stop_keys of subsequent
2238
 
        # requests, and because 'null:' was queried but not returned it will be
2239
 
        # cached as missing.
2240
 
        self.assertEqual({'first': ('null:',)},
2241
 
            graph.get_parent_map(['first', 'null:']))
2242
 
        # Now query for another key.  This request will pass along a recipe of
2243
 
        # start and stop keys describing the already cached results, and this
2244
 
        # recipe's revision count must be correct (or else it will trigger an
2245
 
        # error from the server).
2246
 
        self.assertEqual({}, graph.get_parent_map(['another-key']))
2247
 
        # This assertion guards against disableExtraResults silently failing to
2248
 
        # work, thus invalidating the test.
2249
 
        self.assertLength(2, self.hpss_calls)
2250
 
 
2251
1676
    def test_get_parent_map_gets_ghosts_from_result(self):
2252
1677
        # asking for a revision should negatively cache close ghosts in its
2253
1678
        # ancestry.
2279
1704
 
2280
1705
    def test_allows_new_revisions(self):
2281
1706
        """get_parent_map's results can be updated by commit."""
2282
 
        smart_server = test_server.SmartTCPServer_for_testing()
2283
 
        self.start_server(smart_server)
 
1707
        smart_server = server.SmartTCPServer_for_testing()
 
1708
        smart_server.setUp()
 
1709
        self.addCleanup(smart_server.tearDown)
2284
1710
        self.make_branch('branch')
2285
1711
        branch = Branch.open(smart_server.get_url() + '/branch')
2286
1712
        tree = branch.create_checkout('tree', lightweight=True)
2369
1795
        self.assertEqual(('AnUnexpectedError',), e.error_tuple)
2370
1796
 
2371
1797
 
2372
 
class TestRepositoryGetRevIdForRevno(TestRemoteRepository):
2373
 
 
2374
 
    def test_ok(self):
2375
 
        repo, client = self.setup_fake_client_and_repository('quack')
2376
 
        client.add_expected_call(
2377
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2378
 
            'success', ('ok', 'rev-five'))
2379
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2380
 
        self.assertEqual((True, 'rev-five'), result)
2381
 
        self.assertFinished(client)
2382
 
 
2383
 
    def test_history_incomplete(self):
2384
 
        repo, client = self.setup_fake_client_and_repository('quack')
2385
 
        client.add_expected_call(
2386
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2387
 
            'success', ('history-incomplete', 10, 'rev-ten'))
2388
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2389
 
        self.assertEqual((False, (10, 'rev-ten')), result)
2390
 
        self.assertFinished(client)
2391
 
 
2392
 
    def test_history_incomplete_with_fallback(self):
2393
 
        """A 'history-incomplete' response causes the fallback repository to be
2394
 
        queried too, if one is set.
2395
 
        """
2396
 
        # Make a repo with a fallback repo, both using a FakeClient.
2397
 
        format = remote.response_tuple_to_repo_format(
2398
 
            ('yes', 'no', 'yes', self.get_repo_format().network_name()))
2399
 
        repo, client = self.setup_fake_client_and_repository('quack')
2400
 
        repo._format = format
2401
 
        fallback_repo, ignored = self.setup_fake_client_and_repository(
2402
 
            'fallback')
2403
 
        fallback_repo._client = client
2404
 
        fallback_repo._format = format
2405
 
        repo.add_fallback_repository(fallback_repo)
2406
 
        # First the client should ask the primary repo
2407
 
        client.add_expected_call(
2408
 
            'Repository.get_rev_id_for_revno', ('quack/', 1, (42, 'rev-foo')),
2409
 
            'success', ('history-incomplete', 2, 'rev-two'))
2410
 
        # Then it should ask the fallback, using revno/revid from the
2411
 
        # history-incomplete response as the known revno/revid.
2412
 
        client.add_expected_call(
2413
 
            'Repository.get_rev_id_for_revno',('fallback/', 1, (2, 'rev-two')),
2414
 
            'success', ('ok', 'rev-one'))
2415
 
        result = repo.get_rev_id_for_revno(1, (42, 'rev-foo'))
2416
 
        self.assertEqual((True, 'rev-one'), result)
2417
 
        self.assertFinished(client)
2418
 
 
2419
 
    def test_nosuchrevision(self):
2420
 
        # 'nosuchrevision' is returned when the known-revid is not found in the
2421
 
        # remote repo.  The client translates that response to NoSuchRevision.
2422
 
        repo, client = self.setup_fake_client_and_repository('quack')
2423
 
        client.add_expected_call(
2424
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2425
 
            'error', ('nosuchrevision', 'rev-foo'))
2426
 
        self.assertRaises(
2427
 
            errors.NoSuchRevision,
2428
 
            repo.get_rev_id_for_revno, 5, (42, 'rev-foo'))
2429
 
        self.assertFinished(client)
2430
 
 
2431
 
    def test_branch_fallback_locking(self):
2432
 
        """RemoteBranch.get_rev_id takes a read lock, and tries to call the
2433
 
        get_rev_id_for_revno verb.  If the verb is unknown the VFS fallback
2434
 
        will be invoked, which will fail if the repo is unlocked.
2435
 
        """
2436
 
        self.setup_smart_server_with_call_log()
2437
 
        tree = self.make_branch_and_memory_tree('.')
2438
 
        tree.lock_write()
2439
 
        tree.add('')
2440
 
        rev1 = tree.commit('First')
2441
 
        rev2 = tree.commit('Second')
2442
 
        tree.unlock()
2443
 
        branch = tree.branch
2444
 
        self.assertFalse(branch.is_locked())
2445
 
        self.reset_smart_call_log()
2446
 
        verb = 'Repository.get_rev_id_for_revno'
2447
 
        self.disable_verb(verb)
2448
 
        self.assertEqual(rev1, branch.get_rev_id(1))
2449
 
        self.assertLength(1, [call for call in self.hpss_calls if
2450
 
                              call.call.method == verb])
2451
 
 
2452
 
 
2453
1798
class TestRepositoryIsShared(TestRemoteRepository):
2454
1799
 
2455
1800
    def test_is_shared(self):
2481
1826
        transport_path = 'quack'
2482
1827
        repo, client = self.setup_fake_client_and_repository(transport_path)
2483
1828
        client.add_success_response('ok', 'a token')
2484
 
        token = repo.lock_write().repository_token
 
1829
        result = repo.lock_write()
2485
1830
        self.assertEqual(
2486
1831
            [('call', 'Repository.lock_write', ('quack/', ''))],
2487
1832
            client._calls)
2488
 
        self.assertEqual('a token', token)
 
1833
        self.assertEqual('a token', result)
2489
1834
 
2490
1835
    def test_lock_write_already_locked(self):
2491
1836
        transport_path = 'quack'
2570
1915
        self.assertEqual([], client._calls)
2571
1916
 
2572
1917
 
2573
 
class TestRepositoryInsertStreamBase(TestRemoteRepository):
2574
 
    """Base class for Repository.insert_stream and .insert_stream_1.19
2575
 
    tests.
2576
 
    """
2577
 
    
2578
 
    def checkInsertEmptyStream(self, repo, client):
2579
 
        """Insert an empty stream, checking the result.
2580
 
 
2581
 
        This checks that there are no resume_tokens or missing_keys, and that
2582
 
        the client is finished.
2583
 
        """
2584
 
        sink = repo._get_sink()
2585
 
        fmt = repository.format_registry.get_default()
2586
 
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
2587
 
        self.assertEqual([], resume_tokens)
2588
 
        self.assertEqual(set(), missing_keys)
2589
 
        self.assertFinished(client)
2590
 
 
2591
 
 
2592
 
class TestRepositoryInsertStream(TestRepositoryInsertStreamBase):
2593
 
    """Tests for using Repository.insert_stream verb when the _1.19 variant is
2594
 
    not available.
2595
 
 
2596
 
    This test case is very similar to TestRepositoryInsertStream_1_19.
2597
 
    """
2598
 
 
2599
 
    def setUp(self):
2600
 
        TestRemoteRepository.setUp(self)
2601
 
        self.disable_verb('Repository.insert_stream_1.19')
2602
 
 
2603
 
    def test_unlocked_repo(self):
2604
 
        transport_path = 'quack'
2605
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2606
 
        client.add_expected_call(
2607
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2608
 
            'unknown', ('Repository.insert_stream_1.19',))
2609
 
        client.add_expected_call(
2610
 
            'Repository.insert_stream', ('quack/', ''),
2611
 
            'success', ('ok',))
2612
 
        client.add_expected_call(
2613
 
            'Repository.insert_stream', ('quack/', ''),
2614
 
            'success', ('ok',))
2615
 
        self.checkInsertEmptyStream(repo, client)
2616
 
 
2617
 
    def test_locked_repo_with_no_lock_token(self):
2618
 
        transport_path = 'quack'
2619
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2620
 
        client.add_expected_call(
2621
 
            'Repository.lock_write', ('quack/', ''),
2622
 
            'success', ('ok', ''))
2623
 
        client.add_expected_call(
2624
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2625
 
            'unknown', ('Repository.insert_stream_1.19',))
2626
 
        client.add_expected_call(
2627
 
            'Repository.insert_stream', ('quack/', ''),
2628
 
            'success', ('ok',))
2629
 
        client.add_expected_call(
2630
 
            'Repository.insert_stream', ('quack/', ''),
2631
 
            'success', ('ok',))
2632
 
        repo.lock_write()
2633
 
        self.checkInsertEmptyStream(repo, client)
2634
 
 
2635
 
    def test_locked_repo_with_lock_token(self):
2636
 
        transport_path = 'quack'
2637
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2638
 
        client.add_expected_call(
2639
 
            'Repository.lock_write', ('quack/', ''),
2640
 
            'success', ('ok', 'a token'))
2641
 
        client.add_expected_call(
2642
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2643
 
            'unknown', ('Repository.insert_stream_1.19',))
2644
 
        client.add_expected_call(
2645
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2646
 
            'success', ('ok',))
2647
 
        client.add_expected_call(
2648
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2649
 
            'success', ('ok',))
2650
 
        repo.lock_write()
2651
 
        self.checkInsertEmptyStream(repo, client)
2652
 
 
2653
 
    def test_stream_with_inventory_deltas(self):
2654
 
        """'inventory-deltas' substreams cannot be sent to the
2655
 
        Repository.insert_stream verb, because not all servers that implement
2656
 
        that verb will accept them.  So when one is encountered the RemoteSink
2657
 
        immediately stops using that verb and falls back to VFS insert_stream.
2658
 
        """
2659
 
        transport_path = 'quack'
2660
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2661
 
        client.add_expected_call(
2662
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2663
 
            'unknown', ('Repository.insert_stream_1.19',))
2664
 
        client.add_expected_call(
2665
 
            'Repository.insert_stream', ('quack/', ''),
2666
 
            'success', ('ok',))
2667
 
        client.add_expected_call(
2668
 
            'Repository.insert_stream', ('quack/', ''),
2669
 
            'success', ('ok',))
2670
 
        # Create a fake real repository for insert_stream to fall back on, so
2671
 
        # that we can directly see the records the RemoteSink passes to the
2672
 
        # real sink.
2673
 
        class FakeRealSink:
2674
 
            def __init__(self):
2675
 
                self.records = []
2676
 
            def insert_stream(self, stream, src_format, resume_tokens):
2677
 
                for substream_kind, substream in stream:
2678
 
                    self.records.append(
2679
 
                        (substream_kind, [record.key for record in substream]))
2680
 
                return ['fake tokens'], ['fake missing keys']
2681
 
        fake_real_sink = FakeRealSink()
2682
 
        class FakeRealRepository:
2683
 
            def _get_sink(self):
2684
 
                return fake_real_sink
2685
 
            def is_in_write_group(self):
2686
 
                return False
2687
 
            def refresh_data(self):
2688
 
                return True
2689
 
        repo._real_repository = FakeRealRepository()
2690
 
        sink = repo._get_sink()
2691
 
        fmt = repository.format_registry.get_default()
2692
 
        stream = self.make_stream_with_inv_deltas(fmt)
2693
 
        resume_tokens, missing_keys = sink.insert_stream(stream, fmt, [])
2694
 
        # Every record from the first inventory delta should have been sent to
2695
 
        # the VFS sink.
2696
 
        expected_records = [
2697
 
            ('inventory-deltas', [('rev2',), ('rev3',)]),
2698
 
            ('texts', [('some-rev', 'some-file')])]
2699
 
        self.assertEqual(expected_records, fake_real_sink.records)
2700
 
        # The return values from the real sink's insert_stream are propagated
2701
 
        # back to the original caller.
2702
 
        self.assertEqual(['fake tokens'], resume_tokens)
2703
 
        self.assertEqual(['fake missing keys'], missing_keys)
2704
 
        self.assertFinished(client)
2705
 
 
2706
 
    def make_stream_with_inv_deltas(self, fmt):
2707
 
        """Make a simple stream with an inventory delta followed by more
2708
 
        records and more substreams to test that all records and substreams
2709
 
        from that point on are used.
2710
 
 
2711
 
        This sends, in order:
2712
 
           * inventories substream: rev1, rev2, rev3.  rev2 and rev3 are
2713
 
             inventory-deltas.
2714
 
           * texts substream: (some-rev, some-file)
2715
 
        """
2716
 
        # Define a stream using generators so that it isn't rewindable.
2717
 
        inv = inventory.Inventory(revision_id='rev1')
2718
 
        inv.root.revision = 'rev1'
2719
 
        def stream_with_inv_delta():
2720
 
            yield ('inventories', inventories_substream())
2721
 
            yield ('inventory-deltas', inventory_delta_substream())
2722
 
            yield ('texts', [
2723
 
                versionedfile.FulltextContentFactory(
2724
 
                    ('some-rev', 'some-file'), (), None, 'content')])
2725
 
        def inventories_substream():
2726
 
            # An empty inventory fulltext.  This will be streamed normally.
2727
 
            text = fmt._serializer.write_inventory_to_string(inv)
2728
 
            yield versionedfile.FulltextContentFactory(
2729
 
                ('rev1',), (), None, text)
2730
 
        def inventory_delta_substream():
2731
 
            # An inventory delta.  This can't be streamed via this verb, so it
2732
 
            # will trigger a fallback to VFS insert_stream.
2733
 
            entry = inv.make_entry(
2734
 
                'directory', 'newdir', inv.root.file_id, 'newdir-id')
2735
 
            entry.revision = 'ghost'
2736
 
            delta = [(None, 'newdir', 'newdir-id', entry)]
2737
 
            serializer = inventory_delta.InventoryDeltaSerializer(
2738
 
                versioned_root=True, tree_references=False)
2739
 
            lines = serializer.delta_to_lines('rev1', 'rev2', delta)
2740
 
            yield versionedfile.ChunkedContentFactory(
2741
 
                ('rev2',), (('rev1',)), None, lines)
2742
 
            # Another delta.
2743
 
            lines = serializer.delta_to_lines('rev1', 'rev3', delta)
2744
 
            yield versionedfile.ChunkedContentFactory(
2745
 
                ('rev3',), (('rev1',)), None, lines)
2746
 
        return stream_with_inv_delta()
2747
 
 
2748
 
 
2749
 
class TestRepositoryInsertStream_1_19(TestRepositoryInsertStreamBase):
2750
 
 
2751
 
    def test_unlocked_repo(self):
2752
 
        transport_path = 'quack'
2753
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2754
 
        client.add_expected_call(
2755
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2756
 
            'success', ('ok',))
2757
 
        client.add_expected_call(
2758
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2759
 
            'success', ('ok',))
2760
 
        self.checkInsertEmptyStream(repo, client)
2761
 
 
2762
 
    def test_locked_repo_with_no_lock_token(self):
2763
 
        transport_path = 'quack'
2764
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2765
 
        client.add_expected_call(
2766
 
            'Repository.lock_write', ('quack/', ''),
2767
 
            'success', ('ok', ''))
2768
 
        client.add_expected_call(
2769
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2770
 
            'success', ('ok',))
2771
 
        client.add_expected_call(
2772
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2773
 
            'success', ('ok',))
2774
 
        repo.lock_write()
2775
 
        self.checkInsertEmptyStream(repo, client)
2776
 
 
2777
 
    def test_locked_repo_with_lock_token(self):
2778
 
        transport_path = 'quack'
2779
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2780
 
        client.add_expected_call(
2781
 
            'Repository.lock_write', ('quack/', ''),
2782
 
            'success', ('ok', 'a token'))
2783
 
        client.add_expected_call(
2784
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2785
 
            'success', ('ok',))
2786
 
        client.add_expected_call(
2787
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2788
 
            'success', ('ok',))
2789
 
        repo.lock_write()
2790
 
        self.checkInsertEmptyStream(repo, client)
 
1918
class TestRepositoryInsertStream(TestRemoteRepository):
 
1919
 
 
1920
    def test_unlocked_repo(self):
 
1921
        transport_path = 'quack'
 
1922
        repo, client = self.setup_fake_client_and_repository(transport_path)
 
1923
        client.add_expected_call(
 
1924
            'Repository.insert_stream', ('quack/', ''),
 
1925
            'success', ('ok',))
 
1926
        client.add_expected_call(
 
1927
            'Repository.insert_stream', ('quack/', ''),
 
1928
            'success', ('ok',))
 
1929
        sink = repo._get_sink()
 
1930
        fmt = repository.RepositoryFormat.get_default_format()
 
1931
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
 
1932
        self.assertEqual([], resume_tokens)
 
1933
        self.assertEqual(set(), missing_keys)
 
1934
        client.finished_test()
 
1935
 
 
1936
    def test_locked_repo_with_no_lock_token(self):
 
1937
        transport_path = 'quack'
 
1938
        repo, client = self.setup_fake_client_and_repository(transport_path)
 
1939
        client.add_expected_call(
 
1940
            'Repository.lock_write', ('quack/', ''),
 
1941
            'success', ('ok', ''))
 
1942
        client.add_expected_call(
 
1943
            'Repository.insert_stream', ('quack/', ''),
 
1944
            'success', ('ok',))
 
1945
        client.add_expected_call(
 
1946
            'Repository.insert_stream', ('quack/', ''),
 
1947
            'success', ('ok',))
 
1948
        repo.lock_write()
 
1949
        sink = repo._get_sink()
 
1950
        fmt = repository.RepositoryFormat.get_default_format()
 
1951
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
 
1952
        self.assertEqual([], resume_tokens)
 
1953
        self.assertEqual(set(), missing_keys)
 
1954
        client.finished_test()
 
1955
 
 
1956
    def test_locked_repo_with_lock_token(self):
 
1957
        transport_path = 'quack'
 
1958
        repo, client = self.setup_fake_client_and_repository(transport_path)
 
1959
        client.add_expected_call(
 
1960
            'Repository.lock_write', ('quack/', ''),
 
1961
            'success', ('ok', 'a token'))
 
1962
        client.add_expected_call(
 
1963
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
 
1964
            'success', ('ok',))
 
1965
        client.add_expected_call(
 
1966
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
 
1967
            'success', ('ok',))
 
1968
        repo.lock_write()
 
1969
        sink = repo._get_sink()
 
1970
        fmt = repository.RepositoryFormat.get_default_format()
 
1971
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
 
1972
        self.assertEqual([], resume_tokens)
 
1973
        self.assertEqual(set(), missing_keys)
 
1974
        client.finished_test()
2791
1975
 
2792
1976
 
2793
1977
class TestRepositoryTarball(TestRemoteRepository):
2829
2013
    """RemoteRepository.copy_content_into optimizations"""
2830
2014
 
2831
2015
    def test_copy_content_remote_to_local(self):
2832
 
        self.transport_server = test_server.SmartTCPServer_for_testing
 
2016
        self.transport_server = server.SmartTCPServer_for_testing
2833
2017
        src_repo = self.make_repository('repo1')
2834
2018
        src_repo = repository.Repository.open(self.get_url('repo1'))
2835
2019
        # At the moment the tarball-based copy_content_into can't write back
2878
2062
        client.add_expected_call(
2879
2063
            'PackRepository.autopack', ('quack/',), 'success', ('ok',))
2880
2064
        repo.autopack()
2881
 
        self.assertFinished(client)
 
2065
        client.finished_test()
2882
2066
 
2883
2067
    def test_ok_with_real_repo(self):
2884
2068
        """When the server returns 'ok' and there is a _real_repository, then
2914
2098
             ('pack collection autopack',)],
2915
2099
            client._calls)
2916
2100
 
2917
 
    def test_oom_error_reporting(self):
2918
 
        """An out-of-memory condition on the server is reported clearly"""
2919
 
        transport_path = 'quack'
2920
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2921
 
        client.add_expected_call(
2922
 
            'PackRepository.autopack', ('quack/',),
2923
 
            'error', ('MemoryError',))
2924
 
        err = self.assertRaises(errors.BzrError, repo.autopack)
2925
 
        self.assertContainsRe(str(err), "^remote server out of mem")
2926
 
 
2927
2101
 
2928
2102
class TestErrorTranslationBase(tests.TestCaseWithMemoryTransport):
2929
2103
    """Base class for unit tests for bzrlib.remote._translate_error."""
2993
2167
        expected_error = errors.NotBranchError(path=bzrdir.root_transport.base)
2994
2168
        self.assertEqual(expected_error, translated_error)
2995
2169
 
2996
 
    def test_nobranch_one_arg(self):
2997
 
        bzrdir = self.make_bzrdir('')
2998
 
        translated_error = self.translateTuple(
2999
 
            ('nobranch', 'extra detail'), bzrdir=bzrdir)
3000
 
        expected_error = errors.NotBranchError(
3001
 
            path=bzrdir.root_transport.base,
3002
 
            detail='extra detail')
3003
 
        self.assertEqual(expected_error, translated_error)
3004
 
 
3005
 
    def test_norepository(self):
3006
 
        bzrdir = self.make_bzrdir('')
3007
 
        translated_error = self.translateTuple(('norepository',),
3008
 
            bzrdir=bzrdir)
3009
 
        expected_error = errors.NoRepositoryPresent(bzrdir)
3010
 
        self.assertEqual(expected_error, translated_error)
3011
 
 
3012
2170
    def test_LockContention(self):
3013
2171
        translated_error = self.translateTuple(('LockContention',))
3014
2172
        expected_error = errors.LockContention('(remote lock)')
3042
2200
        expected_error = errors.DivergedBranches(branch, other_branch)
3043
2201
        self.assertEqual(expected_error, translated_error)
3044
2202
 
3045
 
    def test_NotStacked(self):
3046
 
        branch = self.make_branch('')
3047
 
        translated_error = self.translateTuple(('NotStacked',), branch=branch)
3048
 
        expected_error = errors.NotStacked(branch)
3049
 
        self.assertEqual(expected_error, translated_error)
3050
 
 
3051
2203
    def test_ReadError_no_args(self):
3052
2204
        path = 'a path'
3053
2205
        translated_error = self.translateTuple(('ReadError',), path=path)
3060
2212
        expected_error = errors.ReadError(path)
3061
2213
        self.assertEqual(expected_error, translated_error)
3062
2214
 
3063
 
    def test_IncompatibleRepositories(self):
3064
 
        translated_error = self.translateTuple(('IncompatibleRepositories',
3065
 
            "repo1", "repo2", "details here"))
3066
 
        expected_error = errors.IncompatibleRepositories("repo1", "repo2",
3067
 
            "details here")
3068
 
        self.assertEqual(expected_error, translated_error)
3069
 
 
3070
2215
    def test_PermissionDenied_no_args(self):
3071
2216
        path = 'a path'
3072
 
        translated_error = self.translateTuple(('PermissionDenied',),
3073
 
            path=path)
 
2217
        translated_error = self.translateTuple(('PermissionDenied',), path=path)
3074
2218
        expected_error = errors.PermissionDenied(path)
3075
2219
        self.assertEqual(expected_error, translated_error)
3076
2220
 
3099
2243
        expected_error = errors.PermissionDenied(path, extra)
3100
2244
        self.assertEqual(expected_error, translated_error)
3101
2245
 
3102
 
    # GZ 2011-03-02: TODO test for PermissionDenied with non-ascii 'extra'
3103
 
 
3104
 
    def test_NoSuchFile_context_path(self):
3105
 
        local_path = "local path"
3106
 
        translated_error = self.translateTuple(('ReadError', "remote path"),
3107
 
            path=local_path)
3108
 
        expected_error = errors.ReadError(local_path)
3109
 
        self.assertEqual(expected_error, translated_error)
3110
 
 
3111
 
    def test_NoSuchFile_without_context(self):
3112
 
        remote_path = "remote path"
3113
 
        translated_error = self.translateTuple(('ReadError', remote_path))
3114
 
        expected_error = errors.ReadError(remote_path)
3115
 
        self.assertEqual(expected_error, translated_error)
3116
 
 
3117
 
    def test_ReadOnlyError(self):
3118
 
        translated_error = self.translateTuple(('ReadOnlyError',))
3119
 
        expected_error = errors.TransportNotPossible("readonly transport")
3120
 
        self.assertEqual(expected_error, translated_error)
3121
 
 
3122
 
    def test_MemoryError(self):
3123
 
        translated_error = self.translateTuple(('MemoryError',))
3124
 
        self.assertStartsWith(str(translated_error),
3125
 
            "remote server out of memory")
3126
 
 
3127
 
    def test_generic_IndexError_no_classname(self):
3128
 
        err = errors.ErrorFromSmartServer(('error', "list index out of range"))
3129
 
        translated_error = self.translateErrorFromSmartServer(err)
3130
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3131
 
        self.assertEqual(expected_error, translated_error)
3132
 
 
3133
 
    # GZ 2011-03-02: TODO test generic non-ascii error string
3134
 
 
3135
 
    def test_generic_KeyError(self):
3136
 
        err = errors.ErrorFromSmartServer(('error', 'KeyError', "1"))
3137
 
        translated_error = self.translateErrorFromSmartServer(err)
3138
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3139
 
        self.assertEqual(expected_error, translated_error)
3140
 
 
3141
2246
 
3142
2247
class TestErrorTranslationRobustness(TestErrorTranslationBase):
3143
2248
    """Unit tests for bzrlib.remote._translate_error's robustness.
3173
2278
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3174
2279
        # been muttered to the log file for developer to look at.
3175
2280
        self.assertContainsRe(
3176
 
            self.get_log(),
 
2281
            self._get_log(keep_log_file=True),
3177
2282
            "Missing key 'branch' in context")
3178
2283
 
3179
2284
    def test_path_missing(self):
3187
2292
        self.assertEqual(server_error, translated_error)
3188
2293
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3189
2294
        # been muttered to the log file for developer to look at.
3190
 
        self.assertContainsRe(self.get_log(), "Missing key 'path' in context")
 
2295
        self.assertContainsRe(
 
2296
            self._get_log(keep_log_file=True), "Missing key 'path' in context")
3191
2297
 
3192
2298
 
3193
2299
class TestStacking(tests.TestCaseWithTransport):
3211
2317
        stacked_branch = self.make_branch('stacked', format='1.9')
3212
2318
        stacked_branch.set_stacked_on_url('../base')
3213
2319
        # start a server looking at this
3214
 
        smart_server = test_server.SmartTCPServer_for_testing()
3215
 
        self.start_server(smart_server)
 
2320
        smart_server = server.SmartTCPServer_for_testing()
 
2321
        smart_server.setUp()
 
2322
        self.addCleanup(smart_server.tearDown)
3216
2323
        remote_bzrdir = BzrDir.open(smart_server.get_url() + '/stacked')
3217
2324
        # can get its branch and repository
3218
2325
        remote_branch = remote_bzrdir.open_branch()
3221
2328
        try:
3222
2329
            # it should have an appropriate fallback repository, which should also
3223
2330
            # be a RemoteRepository
3224
 
            self.assertLength(1, remote_repo._fallback_repositories)
 
2331
            self.assertEquals(len(remote_repo._fallback_repositories), 1)
3225
2332
            self.assertIsInstance(remote_repo._fallback_repositories[0],
3226
2333
                RemoteRepository)
3227
2334
            # and it has the revision committed to the underlying repository;
3240
2347
        tree1.commit('rev1', rev_id='rev1')
3241
2348
        tree2 = tree1.branch.bzrdir.sprout('tree2', stacked=True
3242
2349
            ).open_workingtree()
3243
 
        local_tree = tree2.branch.create_checkout('local')
3244
 
        local_tree.commit('local changes make me feel good.')
 
2350
        tree2.commit('local changes make me feel good.')
3245
2351
        branch2 = Branch.open(self.get_url('tree2'))
3246
2352
        branch2.lock_read()
3247
2353
        self.addCleanup(branch2.unlock)
3269
2375
                    result.append(content.key[-1])
3270
2376
        return result
3271
2377
 
3272
 
    def get_ordered_revs(self, format, order, branch_factory=None):
 
2378
    def get_ordered_revs(self, format, order):
3273
2379
        """Get a list of the revisions in a stream to format format.
3274
2380
 
3275
2381
        :param format: The format of the target.
3276
2382
        :param order: the order that target should have requested.
3277
 
        :param branch_factory: A callable to create a trunk and stacked branch
3278
 
            to fetch from. If none, self.prepare_stacked_remote_branch is used.
3279
2383
        :result: The revision ids in the stream, in the order seen,
3280
2384
            the topological order of revisions in the source.
3281
2385
        """
3283
2387
        target_repository_format = unordered_format.repository_format
3284
2388
        # Cross check
3285
2389
        self.assertEqual(order, target_repository_format._fetch_order)
3286
 
        if branch_factory is None:
3287
 
            branch_factory = self.prepare_stacked_remote_branch
3288
 
        _, stacked = branch_factory()
 
2390
        trunk, stacked = self.prepare_stacked_remote_branch()
3289
2391
        source = stacked.repository._get_source(target_repository_format)
3290
2392
        tip = stacked.last_revision()
3291
 
        stacked.repository._ensure_real()
3292
 
        graph = stacked.repository.get_graph()
3293
 
        revs = [r for (r,ps) in graph.iter_ancestry([tip])
3294
 
                if r != NULL_REVISION]
3295
 
        revs.reverse()
3296
 
        search = _mod_graph.PendingAncestryResult([tip], stacked.repository)
 
2393
        revs = stacked.repository.get_ancestry(tip)
 
2394
        search = graph.PendingAncestryResult([tip], stacked.repository)
3297
2395
        self.reset_smart_call_log()
3298
2396
        stream = source.get_stream(search)
 
2397
        if None in revs:
 
2398
            revs.remove(None)
3299
2399
        # We trust that if a revision is in the stream the rest of the new
3300
2400
        # content for it is too, as per our main fetch tests; here we are
3301
2401
        # checking that the revisions are actually included at all, and their
3312
2412
        # from the server, then one from the backing branch.
3313
2413
        self.assertLength(2, self.hpss_calls)
3314
2414
 
3315
 
    def test_stacked_on_stacked_get_stream_unordered(self):
3316
 
        # Repository._get_source.get_stream() from a stacked repository which
3317
 
        # is itself stacked yields the full data from all three sources.
3318
 
        def make_stacked_stacked():
3319
 
            _, stacked = self.prepare_stacked_remote_branch()
3320
 
            tree = stacked.bzrdir.sprout('tree3', stacked=True
3321
 
                ).open_workingtree()
3322
 
            local_tree = tree.branch.create_checkout('local-tree3')
3323
 
            local_tree.commit('more local changes are better')
3324
 
            branch = Branch.open(self.get_url('tree3'))
3325
 
            branch.lock_read()
3326
 
            self.addCleanup(branch.unlock)
3327
 
            return None, branch
3328
 
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered',
3329
 
            branch_factory=make_stacked_stacked)
3330
 
        self.assertEqual(set(expected_revs), set(rev_ord))
3331
 
        # Getting unordered results should have made a streaming data request
3332
 
        # from the server, and one from each backing repo
3333
 
        self.assertLength(3, self.hpss_calls)
3334
 
 
3335
2415
    def test_stacked_get_stream_topological(self):
3336
2416
        # Repository._get_source.get_stream() from a stacked repository with
3337
2417
        # topological sorting yields the full data from both stacked and
3338
2418
        # stacked upon sources in topological order.
3339
2419
        rev_ord, expected_revs = self.get_ordered_revs('knit', 'topological')
3340
2420
        self.assertEqual(expected_revs, rev_ord)
3341
 
        # Getting topological sort requires VFS calls still - one of which is
3342
 
        # pushing up from the bound branch.
3343
 
        self.assertLength(14, self.hpss_calls)
 
2421
        # Getting topological sort requires VFS calls still
 
2422
        self.assertLength(12, self.hpss_calls)
3344
2423
 
3345
2424
    def test_stacked_get_stream_groupcompress(self):
3346
2425
        # Repository._get_source.get_stream() from a stacked repository with
3353
2432
        # from the backing branch, and one from the stacked on branch.
3354
2433
        self.assertLength(2, self.hpss_calls)
3355
2434
 
3356
 
    def test_stacked_pull_more_than_stacking_has_bug_360791(self):
3357
 
        # When pulling some fixed amount of content that is more than the
3358
 
        # source has (because some is coming from a fallback branch, no error
3359
 
        # should be received. This was reported as bug 360791.
3360
 
        # Need three branches: a trunk, a stacked branch, and a preexisting
3361
 
        # branch pulling content from stacked and trunk.
3362
 
        self.setup_smart_server_with_call_log()
3363
 
        trunk = self.make_branch_and_tree('trunk', format="1.9-rich-root")
3364
 
        r1 = trunk.commit('start')
3365
 
        stacked_branch = trunk.branch.create_clone_on_transport(
3366
 
            self.get_transport('stacked'), stacked_on=trunk.branch.base)
3367
 
        local = self.make_branch('local', format='1.9-rich-root')
3368
 
        local.repository.fetch(stacked_branch.repository,
3369
 
            stacked_branch.last_revision())
3370
 
 
3371
2435
 
3372
2436
class TestRemoteBranchEffort(tests.TestCaseWithTransport):
3373
2437
 
3375
2439
        super(TestRemoteBranchEffort, self).setUp()
3376
2440
        # Create a smart server that publishes whatever the backing VFS server
3377
2441
        # does.
3378
 
        self.smart_server = test_server.SmartTCPServer_for_testing()
3379
 
        self.start_server(self.smart_server, self.get_server())
 
2442
        self.smart_server = server.SmartTCPServer_for_testing()
 
2443
        self.smart_server.setUp(self.get_server())
 
2444
        self.addCleanup(self.smart_server.tearDown)
3380
2445
        # Log all HPSS calls into self.hpss_calls.
3381
2446
        _SmartClient.hooks.install_named_hook(
3382
2447
            'call', self.capture_hpss_call, None)
3387
2452
 
3388
2453
    def test_copy_content_into_avoids_revision_history(self):
3389
2454
        local = self.make_branch('local')
3390
 
        builder = self.make_branch_builder('remote')
3391
 
        builder.build_commit(message="Commit.")
 
2455
        remote_backing_tree = self.make_branch_and_tree('remote')
 
2456
        remote_backing_tree.commit("Commit.")
3392
2457
        remote_branch_url = self.smart_server.get_url() + 'remote'
3393
2458
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3394
2459
        local.repository.fetch(remote_branch.repository)
3395
2460
        self.hpss_calls = []
3396
2461
        remote_branch.copy_content_into(local)
3397
2462
        self.assertFalse('Branch.revision_history' in self.hpss_calls)
3398
 
 
3399
 
    def test_fetch_everything_needs_just_one_call(self):
3400
 
        local = self.make_branch('local')
3401
 
        builder = self.make_branch_builder('remote')
3402
 
        builder.build_commit(message="Commit.")
3403
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
3404
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3405
 
        self.hpss_calls = []
3406
 
        local.repository.fetch(
3407
 
            remote_branch.repository,
3408
 
            fetch_spec=_mod_graph.EverythingResult(remote_branch.repository))
3409
 
        self.assertEqual(['Repository.get_stream_1.19'], self.hpss_calls)
3410
 
 
3411
 
    def override_verb(self, verb_name, verb):
3412
 
        request_handlers = request.request_handlers
3413
 
        orig_verb = request_handlers.get(verb_name)
3414
 
        request_handlers.register(verb_name, verb, override_existing=True)
3415
 
        self.addCleanup(request_handlers.register, verb_name, orig_verb,
3416
 
                override_existing=True)
3417
 
 
3418
 
    def test_fetch_everything_backwards_compat(self):
3419
 
        """Can fetch with EverythingResult even with pre 2.4 servers.
3420
 
        
3421
 
        Pre-2.4 do not support 'everything' searches with the
3422
 
        Repository.get_stream_1.19 verb.
3423
 
        """
3424
 
        verb_log = []
3425
 
        class OldGetStreamVerb(SmartServerRepositoryGetStream_1_19):
3426
 
            """A version of the Repository.get_stream_1.19 verb patched to
3427
 
            reject 'everything' searches the way 2.3 and earlier do.
3428
 
            """
3429
 
            def recreate_search(self, repository, search_bytes,
3430
 
                                discard_excess=False):
3431
 
                verb_log.append(search_bytes.split('\n', 1)[0])
3432
 
                if search_bytes == 'everything':
3433
 
                    return (None,
3434
 
                            request.FailedSmartServerResponse(('BadSearch',)))
3435
 
                return super(OldGetStreamVerb,
3436
 
                        self).recreate_search(repository, search_bytes,
3437
 
                            discard_excess=discard_excess)
3438
 
        self.override_verb('Repository.get_stream_1.19', OldGetStreamVerb)
3439
 
        local = self.make_branch('local')
3440
 
        builder = self.make_branch_builder('remote')
3441
 
        builder.build_commit(message="Commit.")
3442
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
3443
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3444
 
        self.hpss_calls = []
3445
 
        local.repository.fetch(
3446
 
            remote_branch.repository,
3447
 
            fetch_spec=_mod_graph.EverythingResult(remote_branch.repository))
3448
 
        # make sure the overridden verb was used
3449
 
        self.assertLength(1, verb_log)
3450
 
        # more than one HPSS call is needed, but because it's a VFS callback
3451
 
        # its hard to predict exactly how many.
3452
 
        self.assertTrue(len(self.hpss_calls) > 1)
3453
 
 
3454
 
 
3455
 
class TestUpdateBoundBranchWithModifiedBoundLocation(
3456
 
    tests.TestCaseWithTransport):
3457
 
    """Ensure correct handling of bound_location modifications.
3458
 
 
3459
 
    This is tested against a smart server as http://pad.lv/786980 was about a
3460
 
    ReadOnlyError (write attempt during a read-only transaction) which can only
3461
 
    happen in this context.
3462
 
    """
3463
 
 
3464
 
    def setUp(self):
3465
 
        super(TestUpdateBoundBranchWithModifiedBoundLocation, self).setUp()
3466
 
        self.transport_server = test_server.SmartTCPServer_for_testing
3467
 
 
3468
 
    def make_master_and_checkout(self, master_name, checkout_name):
3469
 
        # Create the master branch and its associated checkout
3470
 
        self.master = self.make_branch_and_tree(master_name)
3471
 
        self.checkout = self.master.branch.create_checkout(checkout_name)
3472
 
        # Modify the master branch so there is something to update
3473
 
        self.master.commit('add stuff')
3474
 
        self.last_revid = self.master.commit('even more stuff')
3475
 
        self.bound_location = self.checkout.branch.get_bound_location()
3476
 
 
3477
 
    def assertUpdateSucceeds(self, new_location):
3478
 
        self.checkout.branch.set_bound_location(new_location)
3479
 
        self.checkout.update()
3480
 
        self.assertEquals(self.last_revid, self.checkout.last_revision())
3481
 
 
3482
 
    def test_without_final_slash(self):
3483
 
        self.make_master_and_checkout('master', 'checkout')
3484
 
        # For unclear reasons some users have a bound_location without a final
3485
 
        # '/', simulate that by forcing such a value
3486
 
        self.assertEndsWith(self.bound_location, '/')
3487
 
        self.assertUpdateSucceeds(self.bound_location.rstrip('/'))
3488
 
 
3489
 
    def test_plus_sign(self):
3490
 
        self.make_master_and_checkout('+master', 'checkout')
3491
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2B', '+', 1))
3492
 
 
3493
 
    def test_tilda(self):
3494
 
        # Embed ~ in the middle of the path just to avoid any $HOME
3495
 
        # interpretation
3496
 
        self.make_master_and_checkout('mas~ter', 'checkout')
3497
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2E', '~', 1))