~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/repofmt/pack_repo.py

  • Committer: Aaron Bentley
  • Date: 2009-05-11 18:35:20 UTC
  • mto: This revision was merged to the branch mainline in revision 4351.
  • Revision ID: aaron@aaronbentley.com-20090511183520-xtvepoauy7zjtb7x
Move hook to MergeDirective, implement MergeDirective.compose_merge_request.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2007-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
24
24
 
25
25
from bzrlib import (
26
26
    chk_map,
27
 
    cleanup,
28
27
    debug,
29
28
    graph,
30
29
    osutils,
37
36
    )
38
37
from bzrlib.index import (
39
38
    CombinedGraphIndex,
 
39
    GraphIndex,
 
40
    GraphIndexBuilder,
40
41
    GraphIndexPrefixAdapter,
 
42
    InMemoryGraphIndex,
41
43
    )
42
44
from bzrlib.knit import (
43
45
    KnitPlainFactory,
53
55
    lockable_files,
54
56
    lockdir,
55
57
    revision as _mod_revision,
 
58
    symbol_versioning,
56
59
    )
57
60
 
58
 
from bzrlib.decorators import needs_write_lock, only_raises
 
61
from bzrlib.decorators import needs_write_lock
59
62
from bzrlib.btree_index import (
60
63
    BTreeGraphIndex,
61
64
    BTreeBuilder,
70
73
    MetaDirRepositoryFormat,
71
74
    RepositoryFormat,
72
75
    RootCommitBuilder,
73
 
    StreamSource,
74
76
    )
 
77
import bzrlib.revision as _mod_revision
75
78
from bzrlib.trace import (
76
79
    mutter,
77
 
    note,
78
80
    warning,
79
81
    )
80
82
 
226
228
        return self.index_name('text', name)
227
229
 
228
230
    def _replace_index_with_readonly(self, index_type):
229
 
        unlimited_cache = False
230
 
        if index_type == 'chk':
231
 
            unlimited_cache = True
232
231
        setattr(self, index_type + '_index',
233
232
            self.index_class(self.index_transport,
234
233
                self.index_name(index_type, self.name),
235
 
                self.index_sizes[self.index_offset(index_type)],
236
 
                unlimited_cache=unlimited_cache))
 
234
                self.index_sizes[self.index_offset(index_type)]))
237
235
 
238
236
 
239
237
class ExistingPack(Pack):
270
268
 
271
269
    def __init__(self, name, revision_index, inventory_index, text_index,
272
270
        signature_index, upload_transport, pack_transport, index_transport,
273
 
        pack_collection, chk_index=None):
 
271
        pack_collection):
274
272
        """Create a ResumedPack object."""
275
273
        ExistingPack.__init__(self, pack_transport, name, revision_index,
276
 
            inventory_index, text_index, signature_index,
277
 
            chk_index=chk_index)
 
274
            inventory_index, text_index, signature_index)
278
275
        self.upload_transport = upload_transport
279
276
        self.index_transport = index_transport
280
277
        self.index_sizes = [None, None, None, None]
284
281
            ('text', text_index),
285
282
            ('signature', signature_index),
286
283
            ]
287
 
        if chk_index is not None:
288
 
            indices.append(('chk', chk_index))
289
 
            self.index_sizes.append(None)
290
284
        for index_type, index in indices:
291
285
            offset = self.index_offset(index_type)
292
286
            self.index_sizes[offset] = index._size
307
301
        self.upload_transport.delete(self.file_name())
308
302
        indices = [self.revision_index, self.inventory_index, self.text_index,
309
303
            self.signature_index]
310
 
        if self.chk_index is not None:
311
 
            indices.append(self.chk_index)
312
304
        for index in indices:
313
305
            index._transport.delete(index._name)
314
306
 
315
307
    def finish(self):
316
308
        self._check_references()
317
 
        index_types = ['revision', 'inventory', 'text', 'signature']
318
 
        if self.chk_index is not None:
319
 
            index_types.append('chk')
320
 
        for index_type in index_types:
 
309
        new_name = '../packs/' + self.file_name()
 
310
        self.upload_transport.rename(self.file_name(), new_name)
 
311
        for index_type in ['revision', 'inventory', 'text', 'signature']:
321
312
            old_name = self.index_name(index_type, self.name)
322
313
            new_name = '../indices/' + old_name
323
314
            self.upload_transport.rename(old_name, new_name)
324
315
            self._replace_index_with_readonly(index_type)
325
 
        new_name = '../packs/' + self.file_name()
326
 
        self.upload_transport.rename(self.file_name(), new_name)
327
316
        self._state = 'finished'
328
317
 
329
318
    def _get_external_refs(self, index):
330
 
        """Return compression parents for this index that are not present.
331
 
 
332
 
        This returns any compression parents that are referenced by this index,
333
 
        which are not contained *in* this index. They may be present elsewhere.
334
 
        """
335
319
        return index.external_references(1)
336
320
 
337
321
 
428
412
        self._writer.begin()
429
413
        # what state is the pack in? (open, finished, aborted)
430
414
        self._state = 'open'
431
 
        # no name until we finish writing the content
432
 
        self.name = None
433
415
 
434
416
    def abort(self):
435
417
        """Cancel creating this pack."""
456
438
            self.signature_index.key_count() or
457
439
            (self.chk_index is not None and self.chk_index.key_count()))
458
440
 
459
 
    def finish_content(self):
460
 
        if self.name is not None:
461
 
            return
462
 
        self._writer.end()
463
 
        if self._buffer[1]:
464
 
            self._write_data('', flush=True)
465
 
        self.name = self._hash.hexdigest()
466
 
 
467
441
    def finish(self, suspend=False):
468
442
        """Finish the new pack.
469
443
 
475
449
         - stores the index size tuple for the pack in the index_sizes
476
450
           attribute.
477
451
        """
478
 
        self.finish_content()
 
452
        self._writer.end()
 
453
        if self._buffer[1]:
 
454
            self._write_data('', flush=True)
 
455
        self.name = self._hash.hexdigest()
479
456
        if not suspend:
480
457
            self._check_references()
481
458
        # write indices
587
564
                                             flush_func=flush_func)
588
565
        self.add_callback = None
589
566
 
 
567
    def replace_indices(self, index_to_pack, indices):
 
568
        """Replace the current mappings with fresh ones.
 
569
 
 
570
        This should probably not be used eventually, rather incremental add and
 
571
        removal of indices. It has been added during refactoring of existing
 
572
        code.
 
573
 
 
574
        :param index_to_pack: A mapping from index objects to
 
575
            (transport, name) tuples for the pack file data.
 
576
        :param indices: A list of indices.
 
577
        """
 
578
        # refresh the revision pack map dict without replacing the instance.
 
579
        self.index_to_pack.clear()
 
580
        self.index_to_pack.update(index_to_pack)
 
581
        # XXX: API break - clearly a 'replace' method would be good?
 
582
        self.combined_index._indices[:] = indices
 
583
        # the current add nodes callback for the current writable index if
 
584
        # there is one.
 
585
        self.add_callback = None
 
586
 
590
587
    def add_index(self, index, pack):
591
588
        """Add index to the aggregate, which is an index for Pack pack.
592
589
 
599
596
        # expose it to the index map
600
597
        self.index_to_pack[index] = pack.access_tuple()
601
598
        # put it at the front of the linear index list
602
 
        self.combined_index.insert_index(0, index, pack.name)
 
599
        self.combined_index.insert_index(0, index)
603
600
 
604
601
    def add_writable_index(self, index, pack):
605
602
        """Add an index which is able to have data added to it.
625
622
        self.data_access.set_writer(None, None, (None, None))
626
623
        self.index_to_pack.clear()
627
624
        del self.combined_index._indices[:]
628
 
        del self.combined_index._index_names[:]
629
625
        self.add_callback = None
630
626
 
631
 
    def remove_index(self, index):
 
627
    def remove_index(self, index, pack):
632
628
        """Remove index from the indices used to answer queries.
633
629
 
634
630
        :param index: An index from the pack parameter.
 
631
        :param pack: A Pack instance.
635
632
        """
636
633
        del self.index_to_pack[index]
637
 
        pos = self.combined_index._indices.index(index)
638
 
        del self.combined_index._indices[pos]
639
 
        del self.combined_index._index_names[pos]
 
634
        self.combined_index._indices.remove(index)
640
635
        if (self.add_callback is not None and
641
636
            getattr(index, 'add_nodes', None) == self.add_callback):
642
637
            self.add_callback = None
1100
1095
            iterator is a tuple with:
1101
1096
            index, readv_vector, node_vector. readv_vector is a list ready to
1102
1097
            hand to the transport readv method, and node_vector is a list of
1103
 
            (key, eol_flag, references) for the node retrieved by the
 
1098
            (key, eol_flag, references) for the the node retrieved by the
1104
1099
            matching readv_vector.
1105
1100
        """
1106
1101
        # group by pack so we do one readv per pack
1297
1292
        # space (we only topo sort the revisions, which is smaller).
1298
1293
        topo_order = tsort.topo_sort(ancestors)
1299
1294
        rev_order = dict(zip(topo_order, range(len(topo_order))))
1300
 
        bad_texts.sort(key=lambda key:rev_order.get(key[0][1], 0))
 
1295
        bad_texts.sort(key=lambda key:rev_order[key[0][1]])
1301
1296
        transaction = repo.get_transaction()
1302
1297
        file_id_index = GraphIndexPrefixAdapter(
1303
1298
            self.new_pack.text_index,
1357
1352
    """
1358
1353
 
1359
1354
    pack_factory = NewPack
1360
 
    resumed_pack_factory = ResumedPack
1361
1355
 
1362
1356
    def __init__(self, repo, transport, index_transport, upload_transport,
1363
1357
                 pack_transport, index_builder_class, index_class,
1398
1392
        self.inventory_index = AggregateIndex(self.reload_pack_names, flush)
1399
1393
        self.text_index = AggregateIndex(self.reload_pack_names, flush)
1400
1394
        self.signature_index = AggregateIndex(self.reload_pack_names, flush)
1401
 
        all_indices = [self.revision_index, self.inventory_index,
1402
 
                self.text_index, self.signature_index]
1403
1395
        if use_chk_index:
1404
1396
            self.chk_index = AggregateIndex(self.reload_pack_names, flush)
1405
 
            all_indices.append(self.chk_index)
1406
1397
        else:
1407
1398
            # used to determine if we're using a chk_index elsewhere.
1408
1399
            self.chk_index = None
1409
 
        # Tell all the CombinedGraphIndex objects about each other, so they can
1410
 
        # share hints about which pack names to search first.
1411
 
        all_combined = [agg_idx.combined_index for agg_idx in all_indices]
1412
 
        for combined_idx in all_combined:
1413
 
            combined_idx.set_sibling_indices(
1414
 
                set(all_combined).difference([combined_idx]))
1415
1400
        # resumed packs
1416
1401
        self._resumed_packs = []
1417
1402
 
1418
 
    def __repr__(self):
1419
 
        return '%s(%r)' % (self.__class__.__name__, self.repo)
1420
 
 
1421
1403
    def add_pack_to_memory(self, pack):
1422
1404
        """Make a Pack object available to the repository to satisfy queries.
1423
1405
 
1461
1443
        in synchronisation with certain steps. Otherwise the names collection
1462
1444
        is not flushed.
1463
1445
 
1464
 
        :return: Something evaluating true if packing took place.
 
1446
        :return: True if packing took place.
1465
1447
        """
1466
1448
        while True:
1467
1449
            try:
1468
1450
                return self._do_autopack()
1469
 
            except errors.RetryAutopack:
 
1451
            except errors.RetryAutopack, e:
1470
1452
                # If we get a RetryAutopack exception, we should abort the
1471
1453
                # current action, and retry.
1472
1454
                pass
1476
1458
        total_revisions = self.revision_index.combined_index.key_count()
1477
1459
        total_packs = len(self._names)
1478
1460
        if self._max_pack_count(total_revisions) >= total_packs:
1479
 
            return None
 
1461
            return False
1480
1462
        # determine which packs need changing
1481
1463
        pack_distribution = self.pack_distribution(total_revisions)
1482
1464
        existing_packs = []
1504
1486
            'containing %d revisions. Packing %d files into %d affecting %d'
1505
1487
            ' revisions', self, total_packs, total_revisions, num_old_packs,
1506
1488
            num_new_packs, num_revs_affected)
1507
 
        result = self._execute_pack_operations(pack_operations,
 
1489
        self._execute_pack_operations(pack_operations,
1508
1490
                                      reload_func=self._restart_autopack)
1509
1491
        mutter('Auto-packing repository %s completed', self)
1510
 
        return result
 
1492
        return True
1511
1493
 
1512
1494
    def _execute_pack_operations(self, pack_operations, _packer_class=Packer,
1513
1495
                                 reload_func=None):
1515
1497
 
1516
1498
        :param pack_operations: A list of [revision_count, packs_to_combine].
1517
1499
        :param _packer_class: The class of packer to use (default: Packer).
1518
 
        :return: The new pack names.
 
1500
        :return: None.
1519
1501
        """
1520
1502
        for revision_count, packs in pack_operations:
1521
1503
            # we may have no-ops from the setup logic
1537
1519
                self._remove_pack_from_memory(pack)
1538
1520
        # record the newly available packs and stop advertising the old
1539
1521
        # packs
1540
 
        to_be_obsoleted = []
1541
 
        for _, packs in pack_operations:
1542
 
            to_be_obsoleted.extend(packs)
1543
 
        result = self._save_pack_names(clear_obsolete_packs=True,
1544
 
                                       obsolete_packs=to_be_obsoleted)
1545
 
        return result
 
1522
        self._save_pack_names(clear_obsolete_packs=True)
 
1523
        # Move the old packs out of the way now they are no longer referenced.
 
1524
        for revision_count, packs in pack_operations:
 
1525
            self._obsolete_packs(packs)
1546
1526
 
1547
1527
    def _flush_new_pack(self):
1548
1528
        if self._new_pack is not None:
1558
1538
 
1559
1539
    def _already_packed(self):
1560
1540
        """Is the collection already packed?"""
1561
 
        return not (self.repo._format.pack_compresses or (len(self._names) > 1))
 
1541
        return len(self._names) < 2
1562
1542
 
1563
 
    def pack(self, hint=None, clean_obsolete_packs=False):
 
1543
    def pack(self):
1564
1544
        """Pack the pack collection totally."""
1565
1545
        self.ensure_loaded()
1566
1546
        total_packs = len(self._names)
1567
1547
        if self._already_packed():
 
1548
            # This is arguably wrong because we might not be optimal, but for
 
1549
            # now lets leave it in. (e.g. reconcile -> one pack. But not
 
1550
            # optimal.
1568
1551
            return
1569
1552
        total_revisions = self.revision_index.combined_index.key_count()
1570
1553
        # XXX: the following may want to be a class, to pack with a given
1571
1554
        # policy.
1572
1555
        mutter('Packing repository %s, which has %d pack files, '
1573
 
            'containing %d revisions with hint %r.', self, total_packs,
1574
 
            total_revisions, hint)
 
1556
            'containing %d revisions into 1 packs.', self, total_packs,
 
1557
            total_revisions)
1575
1558
        # determine which packs need changing
 
1559
        pack_distribution = [1]
1576
1560
        pack_operations = [[0, []]]
1577
1561
        for pack in self.all_packs():
1578
 
            if hint is None or pack.name in hint:
1579
 
                # Either no hint was provided (so we are packing everything),
1580
 
                # or this pack was included in the hint.
1581
 
                pack_operations[-1][0] += pack.get_revision_count()
1582
 
                pack_operations[-1][1].append(pack)
 
1562
            pack_operations[-1][0] += pack.get_revision_count()
 
1563
            pack_operations[-1][1].append(pack)
1583
1564
        self._execute_pack_operations(pack_operations, OptimisingPacker)
1584
1565
 
1585
 
        if clean_obsolete_packs:
1586
 
            self._clear_obsolete_packs()
1587
 
 
1588
1566
    def plan_autopack_combinations(self, existing_packs, pack_distribution):
1589
1567
        """Plan a pack operation.
1590
1568
 
1678
1656
            txt_index = self._make_index(name, '.tix')
1679
1657
            sig_index = self._make_index(name, '.six')
1680
1658
            if self.chk_index is not None:
1681
 
                chk_index = self._make_index(name, '.cix', unlimited_cache=True)
 
1659
                chk_index = self._make_index(name, '.cix')
1682
1660
            else:
1683
1661
                chk_index = None
1684
1662
            result = ExistingPack(self._pack_transport, name, rev_index,
1702
1680
            inv_index = self._make_index(name, '.iix', resume=True)
1703
1681
            txt_index = self._make_index(name, '.tix', resume=True)
1704
1682
            sig_index = self._make_index(name, '.six', resume=True)
1705
 
            if self.chk_index is not None:
1706
 
                chk_index = self._make_index(name, '.cix', resume=True,
1707
 
                                             unlimited_cache=True)
1708
 
            else:
1709
 
                chk_index = None
1710
 
            result = self.resumed_pack_factory(name, rev_index, inv_index,
1711
 
                txt_index, sig_index, self._upload_transport,
1712
 
                self._pack_transport, self._index_transport, self,
1713
 
                chk_index=chk_index)
 
1683
            result = ResumedPack(name, rev_index, inv_index, txt_index,
 
1684
                sig_index, self._upload_transport, self._pack_transport,
 
1685
                self._index_transport, self)
1714
1686
        except errors.NoSuchFile, e:
1715
1687
            raise errors.UnresumableWriteGroup(self.repo, [name], str(e))
1716
1688
        self.add_pack_to_memory(result)
1740
1712
        return self._index_class(self.transport, 'pack-names', None
1741
1713
                ).iter_all_entries()
1742
1714
 
1743
 
    def _make_index(self, name, suffix, resume=False, unlimited_cache=False):
 
1715
    def _make_index(self, name, suffix, resume=False):
1744
1716
        size_offset = self._suffix_offsets[suffix]
1745
1717
        index_name = name + suffix
1746
1718
        if resume:
1749
1721
        else:
1750
1722
            transport = self._index_transport
1751
1723
            index_size = self._names[name][size_offset]
1752
 
        return self._index_class(transport, index_name, index_size,
1753
 
                                 unlimited_cache=unlimited_cache)
 
1724
        return self._index_class(transport, index_name, index_size)
1754
1725
 
1755
1726
    def _max_pack_count(self, total_revisions):
1756
1727
        """Return the maximum number of packs to use for total revisions.
1784
1755
        :param return: None.
1785
1756
        """
1786
1757
        for pack in packs:
1787
 
            try:
1788
 
                pack.pack_transport.rename(pack.file_name(),
1789
 
                    '../obsolete_packs/' + pack.file_name())
1790
 
            except (errors.PathError, errors.TransportError), e:
1791
 
                # TODO: Should these be warnings or mutters?
1792
 
                mutter("couldn't rename obsolete pack, skipping it:\n%s"
1793
 
                       % (e,))
 
1758
            pack.pack_transport.rename(pack.file_name(),
 
1759
                '../obsolete_packs/' + pack.file_name())
1794
1760
            # TODO: Probably needs to know all possible indices for this pack
1795
1761
            # - or maybe list the directory and move all indices matching this
1796
1762
            # name whether we recognize it or not?
1798
1764
            if self.chk_index is not None:
1799
1765
                suffixes.append('.cix')
1800
1766
            for suffix in suffixes:
1801
 
                try:
1802
 
                    self._index_transport.rename(pack.name + suffix,
1803
 
                        '../obsolete_packs/' + pack.name + suffix)
1804
 
                except (errors.PathError, errors.TransportError), e:
1805
 
                    mutter("couldn't rename obsolete index, skipping it:\n%s"
1806
 
                           % (e,))
 
1767
                self._index_transport.rename(pack.name + suffix,
 
1768
                    '../obsolete_packs/' + pack.name + suffix)
1807
1769
 
1808
1770
    def pack_distribution(self, total_revisions):
1809
1771
        """Generate a list of the number of revisions to put in each pack.
1835
1797
        self._remove_pack_indices(pack)
1836
1798
        self.packs.remove(pack)
1837
1799
 
1838
 
    def _remove_pack_indices(self, pack, ignore_missing=False):
1839
 
        """Remove the indices for pack from the aggregated indices.
1840
 
        
1841
 
        :param ignore_missing: Suppress KeyErrors from calling remove_index.
1842
 
        """
1843
 
        for index_type in Pack.index_definitions.keys():
1844
 
            attr_name = index_type + '_index'
1845
 
            aggregate_index = getattr(self, attr_name)
1846
 
            if aggregate_index is not None:
1847
 
                pack_index = getattr(pack, attr_name)
1848
 
                try:
1849
 
                    aggregate_index.remove_index(pack_index)
1850
 
                except KeyError:
1851
 
                    if ignore_missing:
1852
 
                        continue
1853
 
                    raise
 
1800
    def _remove_pack_indices(self, pack):
 
1801
        """Remove the indices for pack from the aggregated indices."""
 
1802
        self.revision_index.remove_index(pack.revision_index, pack)
 
1803
        self.inventory_index.remove_index(pack.inventory_index, pack)
 
1804
        self.text_index.remove_index(pack.text_index, pack)
 
1805
        self.signature_index.remove_index(pack.signature_index, pack)
 
1806
        if self.chk_index is not None:
 
1807
            self.chk_index.remove_index(pack.chk_index, pack)
1854
1808
 
1855
1809
    def reset(self):
1856
1810
        """Clear all cached data."""
1857
1811
        # cached revision data
 
1812
        self.repo._revision_knit = None
1858
1813
        self.revision_index.clear()
1859
1814
        # cached signature data
 
1815
        self.repo._signature_knit = None
1860
1816
        self.signature_index.clear()
1861
1817
        # cached file text data
1862
1818
        self.text_index.clear()
 
1819
        self.repo._text_knit = None
1863
1820
        # cached inventory data
1864
1821
        self.inventory_index.clear()
1865
1822
        # cached chk data
1889
1846
        disk_nodes = set()
1890
1847
        for index, key, value in self._iter_disk_pack_index():
1891
1848
            disk_nodes.add((key, value))
1892
 
        orig_disk_nodes = set(disk_nodes)
1893
1849
 
1894
1850
        # do a two-way diff against our original content
1895
1851
        current_nodes = set()
1908
1864
        disk_nodes.difference_update(deleted_nodes)
1909
1865
        disk_nodes.update(new_nodes)
1910
1866
 
1911
 
        return disk_nodes, deleted_nodes, new_nodes, orig_disk_nodes
 
1867
        return disk_nodes, deleted_nodes, new_nodes
1912
1868
 
1913
1869
    def _syncronize_pack_names_from_disk_nodes(self, disk_nodes):
1914
1870
        """Given the correct set of pack files, update our saved info.
1954
1910
                added.append(name)
1955
1911
        return removed, added, modified
1956
1912
 
1957
 
    def _save_pack_names(self, clear_obsolete_packs=False, obsolete_packs=None):
 
1913
    def _save_pack_names(self, clear_obsolete_packs=False):
1958
1914
        """Save the list of packs.
1959
1915
 
1960
1916
        This will take out the mutex around the pack names list for the
1964
1920
 
1965
1921
        :param clear_obsolete_packs: If True, clear out the contents of the
1966
1922
            obsolete_packs directory.
1967
 
        :param obsolete_packs: Packs that are obsolete once the new pack-names
1968
 
            file has been written.
1969
 
        :return: A list of the names saved that were not previously on disk.
1970
1923
        """
1971
 
        already_obsolete = []
1972
1924
        self.lock_names()
1973
1925
        try:
1974
1926
            builder = self._index_builder_class()
1975
 
            (disk_nodes, deleted_nodes, new_nodes,
1976
 
             orig_disk_nodes) = self._diff_pack_names()
 
1927
            disk_nodes, deleted_nodes, new_nodes = self._diff_pack_names()
1977
1928
            # TODO: handle same-name, index-size-changes here -
1978
1929
            # e.g. use the value from disk, not ours, *unless* we're the one
1979
1930
            # changing it.
1981
1932
                builder.add_node(key, value)
1982
1933
            self.transport.put_file('pack-names', builder.finish(),
1983
1934
                mode=self.repo.bzrdir._get_file_mode())
 
1935
            # move the baseline forward
1984
1936
            self._packs_at_load = disk_nodes
1985
1937
            if clear_obsolete_packs:
1986
 
                to_preserve = None
1987
 
                if obsolete_packs:
1988
 
                    to_preserve = set([o.name for o in obsolete_packs])
1989
 
                already_obsolete = self._clear_obsolete_packs(to_preserve)
 
1938
                self._clear_obsolete_packs()
1990
1939
        finally:
1991
1940
            self._unlock_names()
1992
1941
        # synchronise the memory packs list with what we just wrote:
1993
1942
        self._syncronize_pack_names_from_disk_nodes(disk_nodes)
1994
 
        if obsolete_packs:
1995
 
            # TODO: We could add one more condition here. "if o.name not in
1996
 
            #       orig_disk_nodes and o != the new_pack we haven't written to
1997
 
            #       disk yet. However, the new pack object is not easily
1998
 
            #       accessible here (it would have to be passed through the
1999
 
            #       autopacking code, etc.)
2000
 
            obsolete_packs = [o for o in obsolete_packs
2001
 
                              if o.name not in already_obsolete]
2002
 
            self._obsolete_packs(obsolete_packs)
2003
 
        return [new_node[0][0] for new_node in new_nodes]
2004
1943
 
2005
1944
    def reload_pack_names(self):
2006
1945
        """Sync our pack listing with what is present in the repository.
2020
1959
        if first_read:
2021
1960
            return True
2022
1961
        # out the new value.
2023
 
        (disk_nodes, deleted_nodes, new_nodes,
2024
 
         orig_disk_nodes) = self._diff_pack_names()
2025
 
        # _packs_at_load is meant to be the explicit list of names in
2026
 
        # 'pack-names' at then start. As such, it should not contain any
2027
 
        # pending names that haven't been written out yet.
2028
 
        self._packs_at_load = orig_disk_nodes
 
1962
        disk_nodes, _, _ = self._diff_pack_names()
 
1963
        self._packs_at_load = disk_nodes
2029
1964
        (removed, added,
2030
1965
         modified) = self._syncronize_pack_names_from_disk_nodes(disk_nodes)
2031
1966
        if removed or added or modified:
2040
1975
            raise
2041
1976
        raise errors.RetryAutopack(self.repo, False, sys.exc_info())
2042
1977
 
2043
 
    def _clear_obsolete_packs(self, preserve=None):
 
1978
    def _clear_obsolete_packs(self):
2044
1979
        """Delete everything from the obsolete-packs directory.
2045
 
 
2046
 
        :return: A list of pack identifiers (the filename without '.pack') that
2047
 
            were found in obsolete_packs.
2048
1980
        """
2049
 
        found = []
2050
1981
        obsolete_pack_transport = self.transport.clone('obsolete_packs')
2051
 
        if preserve is None:
2052
 
            preserve = set()
2053
1982
        for filename in obsolete_pack_transport.list_dir('.'):
2054
 
            name, ext = osutils.splitext(filename)
2055
 
            if ext == '.pack':
2056
 
                found.append(name)
2057
 
            if name in preserve:
2058
 
                continue
2059
1983
            try:
2060
1984
                obsolete_pack_transport.delete(filename)
2061
1985
            except (errors.PathError, errors.TransportError), e:
2062
 
                warning("couldn't delete obsolete pack, skipping it:\n%s"
2063
 
                        % (e,))
2064
 
        return found
 
1986
                warning("couldn't delete obsolete pack, skipping it:\n%s" % (e,))
2065
1987
 
2066
1988
    def _start_write_group(self):
2067
1989
        # Do not permit preparation for writing if we're not in a 'write lock'.
2094
2016
        # FIXME: just drop the transient index.
2095
2017
        # forget what names there are
2096
2018
        if self._new_pack is not None:
2097
 
            operation = cleanup.OperationWithCleanups(self._new_pack.abort)
2098
 
            operation.add_cleanup(setattr, self, '_new_pack', None)
2099
 
            # If we aborted while in the middle of finishing the write
2100
 
            # group, _remove_pack_indices could fail because the indexes are
2101
 
            # already gone.  But they're not there we shouldn't fail in this
2102
 
            # case, so we pass ignore_missing=True.
2103
 
            operation.add_cleanup(self._remove_pack_indices, self._new_pack,
2104
 
                ignore_missing=True)
2105
 
            operation.run_simple()
 
2019
            try:
 
2020
                self._new_pack.abort()
 
2021
            finally:
 
2022
                # XXX: If we aborted while in the middle of finishing the write
 
2023
                # group, _remove_pack_indices can fail because the indexes are
 
2024
                # already gone.  If they're not there we shouldn't fail in this
 
2025
                # case.  -- mbp 20081113
 
2026
                self._remove_pack_indices(self._new_pack)
 
2027
                self._new_pack = None
2106
2028
        for resumed_pack in self._resumed_packs:
2107
 
            operation = cleanup.OperationWithCleanups(resumed_pack.abort)
2108
 
            # See comment in previous finally block.
2109
 
            operation.add_cleanup(self._remove_pack_indices, resumed_pack,
2110
 
                ignore_missing=True)
2111
 
            operation.run_simple()
 
2029
            try:
 
2030
                resumed_pack.abort()
 
2031
            finally:
 
2032
                # See comment in previous finally block.
 
2033
                try:
 
2034
                    self._remove_pack_indices(resumed_pack)
 
2035
                except KeyError:
 
2036
                    pass
2112
2037
        del self._resumed_packs[:]
 
2038
        self.repo._text_knit = None
2113
2039
 
2114
2040
    def _remove_resumed_pack_indices(self):
2115
2041
        for resumed_pack in self._resumed_packs:
2116
2042
            self._remove_pack_indices(resumed_pack)
2117
2043
        del self._resumed_packs[:]
2118
2044
 
2119
 
    def _check_new_inventories(self):
2120
 
        """Detect missing inventories in this write group.
2121
 
 
2122
 
        :returns: list of strs, summarising any problems found.  If the list is
2123
 
            empty no problems were found.
2124
 
        """
2125
 
        # The base implementation does no checks.  GCRepositoryPackCollection
2126
 
        # overrides this.
2127
 
        return []
2128
 
        
2129
2045
    def _commit_write_group(self):
2130
2046
        all_missing = set()
2131
2047
        for prefix, versioned_file in (
2140
2056
            raise errors.BzrCheckError(
2141
2057
                "Repository %s has missing compression parent(s) %r "
2142
2058
                 % (self.repo, sorted(all_missing)))
2143
 
        problems = self._check_new_inventories()
2144
 
        if problems:
2145
 
            problems_summary = '\n'.join(problems)
2146
 
            raise errors.BzrCheckError(
2147
 
                "Cannot add revision(s) to repository: " + problems_summary)
2148
2059
        self._remove_pack_indices(self._new_pack)
2149
 
        any_new_content = False
 
2060
        should_autopack = False
2150
2061
        if self._new_pack.data_inserted():
2151
2062
            # get all the data to disk and read to use
2152
2063
            self._new_pack.finish()
2153
2064
            self.allocate(self._new_pack)
2154
2065
            self._new_pack = None
2155
 
            any_new_content = True
 
2066
            should_autopack = True
2156
2067
        else:
2157
2068
            self._new_pack.abort()
2158
2069
            self._new_pack = None
2163
2074
            self._remove_pack_from_memory(resumed_pack)
2164
2075
            resumed_pack.finish()
2165
2076
            self.allocate(resumed_pack)
2166
 
            any_new_content = True
 
2077
            should_autopack = True
2167
2078
        del self._resumed_packs[:]
2168
 
        if any_new_content:
2169
 
            result = self.autopack()
2170
 
            if not result:
 
2079
        if should_autopack:
 
2080
            if not self.autopack():
2171
2081
                # when autopack takes no steps, the names list is still
2172
2082
                # unsaved.
2173
 
                return self._save_pack_names()
2174
 
            return result
2175
 
        return []
 
2083
                self._save_pack_names()
 
2084
        self.repo._text_knit = None
2176
2085
 
2177
2086
    def _suspend_write_group(self):
2178
2087
        tokens = [pack.name for pack in self._resumed_packs]
2186
2095
            self._new_pack.abort()
2187
2096
            self._new_pack = None
2188
2097
        self._remove_resumed_pack_indices()
 
2098
        self.repo._text_knit = None
2189
2099
        return tokens
2190
2100
 
2191
2101
    def _resume_write_group(self, tokens):
2280
2190
        self._reconcile_fixes_text_parents = True
2281
2191
        self._reconcile_backsup_inventory = False
2282
2192
 
2283
 
    def _warn_if_deprecated(self, branch=None):
 
2193
    def _warn_if_deprecated(self):
2284
2194
        # This class isn't deprecated, but one sub-format is
2285
2195
        if isinstance(self._format, RepositoryFormatKnitPack5RichRootBroken):
2286
 
            super(KnitPackRepository, self)._warn_if_deprecated(branch)
 
2196
            from bzrlib import repository
 
2197
            if repository._deprecation_warning_done:
 
2198
                return
 
2199
            repository._deprecation_warning_done = True
 
2200
            warning("Format %s for %s is deprecated - please use"
 
2201
                    " 'bzr upgrade --1.6.1-rich-root'"
 
2202
                    % (self._format, self.bzrdir.transport.base))
2287
2203
 
2288
2204
    def _abort_write_group(self):
2289
 
        self.revisions._index._key_dependencies.clear()
2290
2205
        self._pack_collection._abort_write_group()
2291
2206
 
2292
 
    def _get_source(self, to_format):
2293
 
        if to_format.network_name() == self._format.network_name():
2294
 
            return KnitPackStreamSource(self, to_format)
2295
 
        return super(KnitPackRepository, self)._get_source(to_format)
 
2207
    def _find_inconsistent_revision_parents(self):
 
2208
        """Find revisions with incorrectly cached parents.
 
2209
 
 
2210
        :returns: an iterator yielding tuples of (revison-id, parents-in-index,
 
2211
            parents-in-revision).
 
2212
        """
 
2213
        if not self.is_locked():
 
2214
            raise errors.ObjectNotLocked(self)
 
2215
        pb = ui.ui_factory.nested_progress_bar()
 
2216
        result = []
 
2217
        try:
 
2218
            revision_nodes = self._pack_collection.revision_index \
 
2219
                .combined_index.iter_all_entries()
 
2220
            index_positions = []
 
2221
            # Get the cached index values for all revisions, and also the
 
2222
            # location in each index of the revision text so we can perform
 
2223
            # linear IO.
 
2224
            for index, key, value, refs in revision_nodes:
 
2225
                node = (index, key, value, refs)
 
2226
                index_memo = self.revisions._index._node_to_position(node)
 
2227
                if index_memo[0] != index:
 
2228
                    raise AssertionError('%r != %r' % (index_memo[0], index))
 
2229
                index_positions.append((index_memo, key[0],
 
2230
                                       tuple(parent[0] for parent in refs[0])))
 
2231
                pb.update("Reading revision index", 0, 0)
 
2232
            index_positions.sort()
 
2233
            batch_size = 1000
 
2234
            pb.update("Checking cached revision graph", 0,
 
2235
                      len(index_positions))
 
2236
            for offset in xrange(0, len(index_positions), 1000):
 
2237
                pb.update("Checking cached revision graph", offset)
 
2238
                to_query = index_positions[offset:offset + batch_size]
 
2239
                if not to_query:
 
2240
                    break
 
2241
                rev_ids = [item[1] for item in to_query]
 
2242
                revs = self.get_revisions(rev_ids)
 
2243
                for revision, item in zip(revs, to_query):
 
2244
                    index_parents = item[2]
 
2245
                    rev_parents = tuple(revision.parent_ids)
 
2246
                    if index_parents != rev_parents:
 
2247
                        result.append((revision.revision_id, index_parents,
 
2248
                                       rev_parents))
 
2249
        finally:
 
2250
            pb.finished()
 
2251
        return result
2296
2252
 
2297
2253
    def _make_parents_provider(self):
2298
2254
        return graph.CachingParentsProvider(self)
2306
2262
        self._pack_collection._start_write_group()
2307
2263
 
2308
2264
    def _commit_write_group(self):
2309
 
        hint = self._pack_collection._commit_write_group()
2310
 
        self.revisions._index._key_dependencies.clear()
2311
 
        return hint
 
2265
        return self._pack_collection._commit_write_group()
2312
2266
 
2313
2267
    def suspend_write_group(self):
2314
2268
        # XXX check self._write_group is self.get_transaction()?
2315
2269
        tokens = self._pack_collection._suspend_write_group()
2316
 
        self.revisions._index._key_dependencies.clear()
2317
2270
        self._write_group = None
2318
2271
        return tokens
2319
2272
 
2320
2273
    def _resume_write_group(self, tokens):
2321
2274
        self._start_write_group()
2322
 
        try:
2323
 
            self._pack_collection._resume_write_group(tokens)
2324
 
        except errors.UnresumableWriteGroup:
2325
 
            self._abort_write_group()
2326
 
            raise
 
2275
        self._pack_collection._resume_write_group(tokens)
2327
2276
        for pack in self._pack_collection._resumed_packs:
2328
2277
            self.revisions._index.scan_unvalidated_index(pack.revision_index)
2329
2278
 
2346
2295
        self._write_lock_count += 1
2347
2296
        if self._write_lock_count == 1:
2348
2297
            self._transaction = transactions.WriteTransaction()
2349
 
        if not locked:
2350
 
            if 'relock' in debug.debug_flags and self._prev_lock == 'w':
2351
 
                note('%r was write locked again', self)
2352
 
            self._prev_lock = 'w'
2353
2298
            for repo in self._fallback_repositories:
2354
2299
                # Writes don't affect fallback repos
2355
2300
                repo.lock_read()
 
2301
        if not locked:
2356
2302
            self._refresh_data()
2357
2303
 
2358
2304
    def lock_read(self):
2361
2307
            self._write_lock_count += 1
2362
2308
        else:
2363
2309
            self.control_files.lock_read()
2364
 
        if not locked:
2365
 
            if 'relock' in debug.debug_flags and self._prev_lock == 'r':
2366
 
                note('%r was read locked again', self)
2367
 
            self._prev_lock = 'r'
2368
2310
            for repo in self._fallback_repositories:
 
2311
                # Writes don't affect fallback repos
2369
2312
                repo.lock_read()
 
2313
        if not locked:
2370
2314
            self._refresh_data()
2371
2315
 
2372
2316
    def leave_lock_in_place(self):
2378
2322
        raise NotImplementedError(self.dont_leave_lock_in_place)
2379
2323
 
2380
2324
    @needs_write_lock
2381
 
    def pack(self, hint=None, clean_obsolete_packs=False):
 
2325
    def pack(self):
2382
2326
        """Compress the data within the repository.
2383
2327
 
2384
2328
        This will pack all the data to a single pack. In future it may
2385
2329
        recompress deltas or do other such expensive operations.
2386
2330
        """
2387
 
        self._pack_collection.pack(hint=hint, clean_obsolete_packs=clean_obsolete_packs)
 
2331
        self._pack_collection.pack()
2388
2332
 
2389
2333
    @needs_write_lock
2390
2334
    def reconcile(self, other=None, thorough=False):
2398
2342
        packer = ReconcilePacker(collection, packs, extension, revs)
2399
2343
        return packer.pack(pb)
2400
2344
 
2401
 
    @only_raises(errors.LockNotHeld, errors.LockBroken)
2402
2345
    def unlock(self):
2403
2346
        if self._write_lock_count == 1 and self._write_group is not None:
2404
2347
            self.abort_write_group()
2413
2356
                transaction = self._transaction
2414
2357
                self._transaction = None
2415
2358
                transaction.finish()
 
2359
                for repo in self._fallback_repositories:
 
2360
                    repo.unlock()
2416
2361
        else:
2417
2362
            self.control_files.unlock()
2418
 
 
2419
 
        if not self.is_locked():
2420
2363
            for repo in self._fallback_repositories:
2421
2364
                repo.unlock()
2422
2365
 
2423
2366
 
2424
 
class KnitPackStreamSource(StreamSource):
2425
 
    """A StreamSource used to transfer data between same-format KnitPack repos.
2426
 
 
2427
 
    This source assumes:
2428
 
        1) Same serialization format for all objects
2429
 
        2) Same root information
2430
 
        3) XML format inventories
2431
 
        4) Atomic inserts (so we can stream inventory texts before text
2432
 
           content)
2433
 
        5) No chk_bytes
2434
 
    """
2435
 
 
2436
 
    def __init__(self, from_repository, to_format):
2437
 
        super(KnitPackStreamSource, self).__init__(from_repository, to_format)
2438
 
        self._text_keys = None
2439
 
        self._text_fetch_order = 'unordered'
2440
 
 
2441
 
    def _get_filtered_inv_stream(self, revision_ids):
2442
 
        from_repo = self.from_repository
2443
 
        parent_ids = from_repo._find_parent_ids_of_revisions(revision_ids)
2444
 
        parent_keys = [(p,) for p in parent_ids]
2445
 
        find_text_keys = from_repo._find_text_key_references_from_xml_inventory_lines
2446
 
        parent_text_keys = set(find_text_keys(
2447
 
            from_repo._inventory_xml_lines_for_keys(parent_keys)))
2448
 
        content_text_keys = set()
2449
 
        knit = KnitVersionedFiles(None, None)
2450
 
        factory = KnitPlainFactory()
2451
 
        def find_text_keys_from_content(record):
2452
 
            if record.storage_kind not in ('knit-delta-gz', 'knit-ft-gz'):
2453
 
                raise ValueError("Unknown content storage kind for"
2454
 
                    " inventory text: %s" % (record.storage_kind,))
2455
 
            # It's a knit record, it has a _raw_record field (even if it was
2456
 
            # reconstituted from a network stream).
2457
 
            raw_data = record._raw_record
2458
 
            # read the entire thing
2459
 
            revision_id = record.key[-1]
2460
 
            content, _ = knit._parse_record(revision_id, raw_data)
2461
 
            if record.storage_kind == 'knit-delta-gz':
2462
 
                line_iterator = factory.get_linedelta_content(content)
2463
 
            elif record.storage_kind == 'knit-ft-gz':
2464
 
                line_iterator = factory.get_fulltext_content(content)
2465
 
            content_text_keys.update(find_text_keys(
2466
 
                [(line, revision_id) for line in line_iterator]))
2467
 
        revision_keys = [(r,) for r in revision_ids]
2468
 
        def _filtered_inv_stream():
2469
 
            source_vf = from_repo.inventories
2470
 
            stream = source_vf.get_record_stream(revision_keys,
2471
 
                                                 'unordered', False)
2472
 
            for record in stream:
2473
 
                if record.storage_kind == 'absent':
2474
 
                    raise errors.NoSuchRevision(from_repo, record.key)
2475
 
                find_text_keys_from_content(record)
2476
 
                yield record
2477
 
            self._text_keys = content_text_keys - parent_text_keys
2478
 
        return ('inventories', _filtered_inv_stream())
2479
 
 
2480
 
    def _get_text_stream(self):
2481
 
        # Note: We know we don't have to handle adding root keys, because both
2482
 
        # the source and target are the identical network name.
2483
 
        text_stream = self.from_repository.texts.get_record_stream(
2484
 
                        self._text_keys, self._text_fetch_order, False)
2485
 
        return ('texts', text_stream)
2486
 
 
2487
 
    def get_stream(self, search):
2488
 
        revision_ids = search.get_keys()
2489
 
        for stream_info in self._fetch_revision_texts(revision_ids):
2490
 
            yield stream_info
2491
 
        self._revision_keys = [(rev_id,) for rev_id in revision_ids]
2492
 
        yield self._get_filtered_inv_stream(revision_ids)
2493
 
        yield self._get_text_stream()
2494
 
 
2495
 
 
2496
 
 
2497
2367
class RepositoryFormatPack(MetaDirRepositoryFormat):
2498
2368
    """Format logic for pack structured repositories.
2499
2369
 
2546
2416
        utf8_files = [('format', self.get_format_string())]
2547
2417
 
2548
2418
        self._upload_blank_content(a_bzrdir, dirs, files, utf8_files, shared)
2549
 
        repository = self.open(a_bzrdir=a_bzrdir, _found=True)
2550
 
        self._run_post_repo_init_hooks(repository, a_bzrdir, shared)
2551
 
        return repository
 
2419
        return self.open(a_bzrdir=a_bzrdir, _found=True)
2552
2420
 
2553
2421
    def open(self, a_bzrdir, _found=False, _override_transport=None):
2554
2422
        """See RepositoryFormat.open().
2603
2471
        """See RepositoryFormat.get_format_description()."""
2604
2472
        return "Packs containing knits without subtree support"
2605
2473
 
 
2474
    def check_conversion_target(self, target_format):
 
2475
        pass
 
2476
 
2606
2477
 
2607
2478
class RepositoryFormatKnitPack3(RepositoryFormatPack):
2608
2479
    """A subtrees parameterized Pack repository.
2617
2488
    repository_class = KnitPackRepository
2618
2489
    _commit_builder_class = PackRootCommitBuilder
2619
2490
    rich_root_data = True
2620
 
    experimental = True
2621
2491
    supports_tree_reference = True
2622
2492
    @property
2623
2493
    def _serializer(self):
2635
2505
 
2636
2506
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2637
2507
 
 
2508
    def check_conversion_target(self, target_format):
 
2509
        if not target_format.rich_root_data:
 
2510
            raise errors.BadConversionTarget(
 
2511
                'Does not support rich root data.', target_format)
 
2512
        if not getattr(target_format, 'supports_tree_reference', False):
 
2513
            raise errors.BadConversionTarget(
 
2514
                'Does not support nested trees', target_format)
 
2515
 
2638
2516
    def get_format_string(self):
2639
2517
        """See RepositoryFormat.get_format_string()."""
2640
2518
        return "Bazaar pack repository format 1 with subtree support (needs bzr 0.92)\n"
2673
2551
 
2674
2552
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2675
2553
 
 
2554
    def check_conversion_target(self, target_format):
 
2555
        if not target_format.rich_root_data:
 
2556
            raise errors.BadConversionTarget(
 
2557
                'Does not support rich root data.', target_format)
 
2558
 
2676
2559
    def get_format_string(self):
2677
2560
        """See RepositoryFormat.get_format_string()."""
2678
2561
        return ("Bazaar pack repository format 1 with rich root"
2719
2602
        """See RepositoryFormat.get_format_description()."""
2720
2603
        return "Packs 5 (adds stacking support, requires bzr 1.6)"
2721
2604
 
 
2605
    def check_conversion_target(self, target_format):
 
2606
        pass
 
2607
 
2722
2608
 
2723
2609
class RepositoryFormatKnitPack5RichRoot(RepositoryFormatPack):
2724
2610
    """A repository with rich roots and stacking.
2751
2637
 
2752
2638
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2753
2639
 
 
2640
    def check_conversion_target(self, target_format):
 
2641
        if not target_format.rich_root_data:
 
2642
            raise errors.BadConversionTarget(
 
2643
                'Does not support rich root data.', target_format)
 
2644
 
2754
2645
    def get_format_string(self):
2755
2646
        """See RepositoryFormat.get_format_string()."""
2756
2647
        return "Bazaar RepositoryFormatKnitPack5RichRoot (bzr 1.6.1)\n"
2797
2688
 
2798
2689
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2799
2690
 
 
2691
    def check_conversion_target(self, target_format):
 
2692
        if not target_format.rich_root_data:
 
2693
            raise errors.BadConversionTarget(
 
2694
                'Does not support rich root data.', target_format)
 
2695
 
2800
2696
    def get_format_string(self):
2801
2697
        """See RepositoryFormat.get_format_string()."""
2802
2698
        return "Bazaar RepositoryFormatKnitPack5RichRoot (bzr 1.6)\n"
2840
2736
        """See RepositoryFormat.get_format_description()."""
2841
2737
        return "Packs 6 (uses btree indexes, requires bzr 1.9)"
2842
2738
 
 
2739
    def check_conversion_target(self, target_format):
 
2740
        pass
 
2741
 
2843
2742
 
2844
2743
class RepositoryFormatKnitPack6RichRoot(RepositoryFormatPack):
2845
2744
    """A repository with rich roots, no subtrees, stacking and btree indexes.
2869
2768
 
2870
2769
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2871
2770
 
 
2771
    def check_conversion_target(self, target_format):
 
2772
        if not target_format.rich_root_data:
 
2773
            raise errors.BadConversionTarget(
 
2774
                'Does not support rich root data.', target_format)
 
2775
 
2872
2776
    def get_format_string(self):
2873
2777
        """See RepositoryFormat.get_format_string()."""
2874
2778
        return "Bazaar RepositoryFormatKnitPack6RichRoot (bzr 1.9)\n"
2891
2795
    repository_class = KnitPackRepository
2892
2796
    _commit_builder_class = PackRootCommitBuilder
2893
2797
    rich_root_data = True
2894
 
    experimental = True
2895
2798
    supports_tree_reference = True
2896
2799
    supports_external_lookups = True
2897
2800
    # What index classes to use
2911
2814
 
2912
2815
    _matchingbzrdir = property(_get_matching_bzrdir, _ignore_setting_bzrdir)
2913
2816
 
 
2817
    def check_conversion_target(self, target_format):
 
2818
        if not target_format.rich_root_data:
 
2819
            raise errors.BadConversionTarget(
 
2820
                'Does not support rich root data.', target_format)
 
2821
        if not getattr(target_format, 'supports_tree_reference', False):
 
2822
            raise errors.BadConversionTarget(
 
2823
                'Does not support nested trees', target_format)
 
2824
 
2914
2825
    def get_format_string(self):
2915
2826
        """See RepositoryFormat.get_format_string()."""
2916
2827
        return ("Bazaar development format 2 with subtree support "