~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_remote.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2009-01-13 05:14:24 UTC
  • mfrom: (3936.1.3 integration)
  • Revision ID: pqm@pqm.ubuntu.com-20090113051424-nrk3zkfe09h46i9y
(mbp) merge 1.11 and advance to 1.12

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2011 Canonical Ltd
 
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
"""Tests for remote bzrdir/branch/repo/etc
18
18
 
19
19
These are proxy objects which act on remote objects by sending messages
20
20
through a smart client.  The proxies are to be created when attempting to open
21
 
the object given a transport that supports smartserver rpc operations.
 
21
the object given a transport that supports smartserver rpc operations. 
22
22
 
23
23
These tests correspond to tests.test_smart, which exercises the server side.
24
24
"""
27
27
from cStringIO import StringIO
28
28
 
29
29
from bzrlib import (
30
 
    branch,
31
30
    bzrdir,
32
31
    config,
33
 
    controldir,
34
32
    errors,
35
 
    graph as _mod_graph,
36
 
    inventory,
37
 
    inventory_delta,
 
33
    graph,
 
34
    pack,
38
35
    remote,
39
36
    repository,
40
37
    tests,
41
 
    transport,
42
 
    treebuilder,
43
 
    versionedfile,
 
38
    urlutils,
44
39
    )
45
40
from bzrlib.branch import Branch
46
 
from bzrlib.bzrdir import (
47
 
    BzrDir,
48
 
    BzrDirFormat,
49
 
    RemoteBzrProber,
50
 
    )
 
41
from bzrlib.bzrdir import BzrDir, BzrDirFormat
51
42
from bzrlib.remote import (
52
43
    RemoteBranch,
53
 
    RemoteBranchFormat,
54
44
    RemoteBzrDir,
55
45
    RemoteBzrDirFormat,
56
46
    RemoteRepository,
57
 
    RemoteRepositoryFormat,
58
47
    )
59
 
from bzrlib.repofmt import groupcompress_repo, knitpack_repo
60
48
from bzrlib.revision import NULL_REVISION
61
 
from bzrlib.smart import medium, request
 
49
from bzrlib.smart import server, medium
62
50
from bzrlib.smart.client import _SmartClient
63
 
from bzrlib.smart.repository import (
64
 
    SmartServerRepositoryGetParentMap,
65
 
    SmartServerRepositoryGetStream_1_19,
66
 
    )
67
 
from bzrlib.tests import (
68
 
    test_server,
69
 
    )
70
 
from bzrlib.tests.scenarios import load_tests_apply_scenarios
 
51
from bzrlib.symbol_versioning import one_four
 
52
from bzrlib.transport import get_transport, http
71
53
from bzrlib.transport.memory import MemoryTransport
72
54
from bzrlib.transport.remote import (
73
55
    RemoteTransport,
74
56
    RemoteSSHTransport,
75
57
    RemoteTCPTransport,
76
 
    )
77
 
 
78
 
 
79
 
load_tests = load_tests_apply_scenarios
 
58
)
80
59
 
81
60
 
82
61
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
83
62
 
84
 
    scenarios = [
85
 
        ('HPSS-v2',
86
 
            {'transport_server': test_server.SmartTCPServer_for_testing_v2_only}),
87
 
        ('HPSS-v3',
88
 
            {'transport_server': test_server.SmartTCPServer_for_testing})]
89
 
 
90
 
 
91
63
    def setUp(self):
 
64
        self.transport_server = server.SmartTCPServer_for_testing
92
65
        super(BasicRemoteObjectTests, self).setUp()
93
66
        self.transport = self.get_transport()
94
67
        # make a branch that can be opened over the smart transport
95
68
        self.local_wt = BzrDir.create_standalone_workingtree('.')
96
 
        self.addCleanup(self.transport.disconnect)
 
69
 
 
70
    def tearDown(self):
 
71
        self.transport.disconnect()
 
72
        tests.TestCaseWithTransport.tearDown(self)
97
73
 
98
74
    def test_create_remote_bzrdir(self):
99
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
75
        b = remote.RemoteBzrDir(self.transport)
100
76
        self.assertIsInstance(b, BzrDir)
101
77
 
102
78
    def test_open_remote_branch(self):
103
79
        # open a standalone branch in the working directory
104
 
        b = remote.RemoteBzrDir(self.transport, RemoteBzrDirFormat())
 
80
        b = remote.RemoteBzrDir(self.transport)
105
81
        branch = b.open_branch()
106
82
        self.assertIsInstance(branch, Branch)
107
83
 
123
99
    def test_find_correct_format(self):
124
100
        """Should open a RemoteBzrDir over a RemoteTransport"""
125
101
        fmt = BzrDirFormat.find_format(self.transport)
126
 
        self.assertTrue(bzrdir.RemoteBzrProber
127
 
                        in controldir.ControlDirFormat._server_probers)
128
 
        self.assertIsInstance(fmt, RemoteBzrDirFormat)
 
102
        self.assertTrue(RemoteBzrDirFormat
 
103
                        in BzrDirFormat._control_server_formats)
 
104
        self.assertIsInstance(fmt, remote.RemoteBzrDirFormat)
129
105
 
130
106
    def test_open_detected_smart_format(self):
131
107
        fmt = BzrDirFormat.find_format(self.transport)
136
112
        b = BzrDir.open_from_transport(self.transport).open_branch()
137
113
        self.assertStartsWith(str(b), 'RemoteBranch(')
138
114
 
139
 
    def test_remote_bzrdir_repr(self):
140
 
        b = BzrDir.open_from_transport(self.transport)
141
 
        self.assertStartsWith(str(b), 'RemoteBzrDir(')
142
 
 
143
 
    def test_remote_branch_format_supports_stacking(self):
144
 
        t = self.transport
145
 
        self.make_branch('unstackable', format='pack-0.92')
146
 
        b = BzrDir.open_from_transport(t.clone('unstackable')).open_branch()
147
 
        self.assertFalse(b._format.supports_stacking())
148
 
        self.make_branch('stackable', format='1.9')
149
 
        b = BzrDir.open_from_transport(t.clone('stackable')).open_branch()
150
 
        self.assertTrue(b._format.supports_stacking())
151
 
 
152
 
    def test_remote_repo_format_supports_external_references(self):
153
 
        t = self.transport
154
 
        bd = self.make_bzrdir('unstackable', format='pack-0.92')
155
 
        r = bd.create_repository()
156
 
        self.assertFalse(r._format.supports_external_lookups)
157
 
        r = BzrDir.open_from_transport(t.clone('unstackable')).open_repository()
158
 
        self.assertFalse(r._format.supports_external_lookups)
159
 
        bd = self.make_bzrdir('stackable', format='1.9')
160
 
        r = bd.create_repository()
161
 
        self.assertTrue(r._format.supports_external_lookups)
162
 
        r = BzrDir.open_from_transport(t.clone('stackable')).open_repository()
163
 
        self.assertTrue(r._format.supports_external_lookups)
164
 
 
165
 
    def test_remote_branch_set_append_revisions_only(self):
166
 
        # Make a format 1.9 branch, which supports append_revisions_only
167
 
        branch = self.make_branch('branch', format='1.9')
168
 
        config = branch.get_config()
169
 
        branch.set_append_revisions_only(True)
170
 
        self.assertEqual(
171
 
            'True', config.get_user_option('append_revisions_only'))
172
 
        branch.set_append_revisions_only(False)
173
 
        self.assertEqual(
174
 
            'False', config.get_user_option('append_revisions_only'))
175
 
 
176
 
    def test_remote_branch_set_append_revisions_only_upgrade_reqd(self):
177
 
        branch = self.make_branch('branch', format='knit')
178
 
        config = branch.get_config()
179
 
        self.assertRaises(
180
 
            errors.UpgradeRequired, branch.set_append_revisions_only, True)
 
115
 
 
116
class FakeRemoteTransport(object):
 
117
    """This class provides the minimum support for use in place of a RemoteTransport.
 
118
    
 
119
    It doesn't actually transmit requests, but rather expects them to be
 
120
    handled by a FakeClient which holds canned responses.  It does not allow
 
121
    any vfs access, therefore is not suitable for testing any operation that
 
122
    will fallback to vfs access.  Backing the test by an instance of this
 
123
    class guarantees that it's - done using non-vfs operations.
 
124
    """
 
125
 
 
126
    _default_url = 'fakeremotetransport://host/path/'
 
127
 
 
128
    def __init__(self, url=None):
 
129
        if url is None:
 
130
            url = self._default_url
 
131
        self.base = url
 
132
 
 
133
    def __repr__(self):
 
134
        return "%r(%r)" % (self.__class__.__name__,
 
135
            self.base)
 
136
 
 
137
    def clone(self, relpath):
 
138
        return FakeRemoteTransport(urlutils.join(self.base, relpath))
 
139
 
 
140
    def get(self, relpath):
 
141
        # only get is specifically stubbed out, because it's usually the first
 
142
        # thing we do.  anything else will fail with an AttributeError.
 
143
        raise AssertionError("%r doesn't support file access to %r"
 
144
            % (self, relpath))
 
145
 
181
146
 
182
147
 
183
148
class FakeProtocol(object):
205
170
 
206
171
class FakeClient(_SmartClient):
207
172
    """Lookalike for _SmartClient allowing testing."""
208
 
 
 
173
    
209
174
    def __init__(self, fake_medium_base='fake base'):
210
175
        """Create a FakeClient."""
211
176
        self.responses = []
213
178
        self.expecting_body = False
214
179
        # if non-None, this is the list of expected calls, with only the
215
180
        # method name and arguments included.  the body might be hard to
216
 
        # compute so is not included. If a call is None, that call can
217
 
        # be anything.
 
181
        # compute so is not included
218
182
        self._expected_calls = None
219
183
        _SmartClient.__init__(self, FakeMedium(self._calls, fake_medium_base))
220
184
 
230
194
 
231
195
    def add_success_response_with_body(self, body, *args):
232
196
        self.responses.append(('success', args, body))
233
 
        if self._expected_calls is not None:
234
 
            self._expected_calls.append(None)
235
197
 
236
198
    def add_error_response(self, *args):
237
199
        self.responses.append(('error', args))
266
228
            raise AssertionError("%r didn't expect any more calls "
267
229
                "but got %r%r"
268
230
                % (self, method, args,))
269
 
        if next_call is None:
270
 
            return
271
231
        if method != next_call[0] or args != next_call[1]:
272
232
            raise AssertionError("%r expected %r%r "
273
233
                "but got %r%r"
285
245
        self.expecting_body = True
286
246
        return result[1], FakeProtocol(result[2], self)
287
247
 
288
 
    def call_with_body_bytes(self, method, args, body):
289
 
        self._check_call(method, args)
290
 
        self._calls.append(('call_with_body_bytes', method, args, body))
291
 
        result = self._get_next_response()
292
 
        return result[1], FakeProtocol(result[2], self)
293
 
 
294
248
    def call_with_body_bytes_expecting_body(self, method, args, body):
295
249
        self._check_call(method, args)
296
250
        self._calls.append(('call_with_body_bytes_expecting_body', method,
299
253
        self.expecting_body = True
300
254
        return result[1], FakeProtocol(result[2], self)
301
255
 
302
 
    def call_with_body_stream(self, args, stream):
303
 
        # Explicitly consume the stream before checking for an error, because
304
 
        # that's what happens a real medium.
305
 
        stream = list(stream)
306
 
        self._check_call(args[0], args[1:])
307
 
        self._calls.append(('call_with_body_stream', args[0], args[1:], stream))
308
 
        result = self._get_next_response()
309
 
        # The second value returned from call_with_body_stream is supposed to
310
 
        # be a response_handler object, but so far no tests depend on that.
311
 
        response_handler = None 
312
 
        return result[1], response_handler
313
 
 
314
256
 
315
257
class FakeMedium(medium.SmartClientMedium):
316
258
 
336
278
        self.assertTrue(result)
337
279
 
338
280
 
339
 
class TestRemote(tests.TestCaseWithMemoryTransport):
340
 
 
341
 
    def get_branch_format(self):
342
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
343
 
        return reference_bzrdir_format.get_branch_format()
344
 
 
345
 
    def get_repo_format(self):
346
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
347
 
        return reference_bzrdir_format.repository_format
348
 
 
349
 
    def assertFinished(self, fake_client):
350
 
        """Assert that all of a FakeClient's expected calls have occurred."""
351
 
        fake_client.finished_test()
352
 
 
353
 
 
354
281
class Test_ClientMedium_remote_path_from_transport(tests.TestCase):
355
282
    """Tests for the behaviour of client_medium.remote_path_from_transport."""
356
283
 
360
287
        a given client_base and transport_base.
361
288
        """
362
289
        client_medium = medium.SmartClientMedium(client_base)
363
 
        t = transport.get_transport(transport_base)
364
 
        result = client_medium.remote_path_from_transport(t)
 
290
        transport = get_transport(transport_base)
 
291
        result = client_medium.remote_path_from_transport(transport)
365
292
        self.assertEqual(expected, result)
366
293
 
367
294
    def test_remote_path_from_transport(self):
378
305
        a given transport_base and relpath of that transport.  (Note that
379
306
        HttpTransportBase is a subclass of SmartClientMedium)
380
307
        """
381
 
        base_transport = transport.get_transport(transport_base)
 
308
        base_transport = get_transport(transport_base)
382
309
        client_medium = base_transport.get_smart_medium()
383
310
        cloned_transport = base_transport.clone(relpath)
384
311
        result = client_medium.remote_path_from_transport(cloned_transport)
385
312
        self.assertEqual(expected, result)
386
 
 
 
313
        
387
314
    def test_remote_path_from_transport_http(self):
388
315
        """Remote paths for HTTP transports are calculated differently to other
389
316
        transports.  They are just relative to the client base, not the root
405
332
        """
406
333
        client_medium = medium.SmartClientMedium('dummy base')
407
334
        self.assertFalse(client_medium._is_remote_before((99, 99)))
408
 
 
 
335
    
409
336
    def test__remember_remote_is_before(self):
410
337
        """Calling _remember_remote_is_before ratchets down the known remote
411
338
        version.
419
346
        # Calling _remember_remote_is_before again with a lower value works.
420
347
        client_medium._remember_remote_is_before((1, 5))
421
348
        self.assertTrue(client_medium._is_remote_before((1, 5)))
422
 
        # If you call _remember_remote_is_before with a higher value it logs a
423
 
        # warning, and continues to remember the lower value.
424
 
        self.assertNotContainsRe(self.get_log(), '_remember_remote_is_before')
425
 
        client_medium._remember_remote_is_before((1, 9))
426
 
        self.assertContainsRe(self.get_log(), '_remember_remote_is_before')
427
 
        self.assertTrue(client_medium._is_remote_before((1, 5)))
428
 
 
429
 
 
430
 
class TestBzrDirCloningMetaDir(TestRemote):
431
 
 
432
 
    def test_backwards_compat(self):
433
 
        self.setup_smart_server_with_call_log()
434
 
        a_dir = self.make_bzrdir('.')
435
 
        self.reset_smart_call_log()
436
 
        verb = 'BzrDir.cloning_metadir'
437
 
        self.disable_verb(verb)
438
 
        format = a_dir.cloning_metadir()
439
 
        call_count = len([call for call in self.hpss_calls if
440
 
            call.call.method == verb])
441
 
        self.assertEqual(1, call_count)
442
 
 
443
 
    def test_branch_reference(self):
444
 
        transport = self.get_transport('quack')
445
 
        referenced = self.make_branch('referenced')
446
 
        expected = referenced.bzrdir.cloning_metadir()
447
 
        client = FakeClient(transport.base)
448
 
        client.add_expected_call(
449
 
            'BzrDir.cloning_metadir', ('quack/', 'False'),
450
 
            'error', ('BranchReference',)),
451
 
        client.add_expected_call(
452
 
            'BzrDir.open_branchV3', ('quack/',),
453
 
            'success', ('ref', self.get_url('referenced'))),
454
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
455
 
            _client=client)
456
 
        result = a_bzrdir.cloning_metadir()
457
 
        # We should have got a control dir matching the referenced branch.
458
 
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
459
 
        self.assertEqual(expected._repository_format, result._repository_format)
460
 
        self.assertEqual(expected._branch_format, result._branch_format)
461
 
        self.assertFinished(client)
462
 
 
463
 
    def test_current_server(self):
464
 
        transport = self.get_transport('.')
465
 
        transport = transport.clone('quack')
466
 
        self.make_bzrdir('quack')
467
 
        client = FakeClient(transport.base)
468
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
469
 
        control_name = reference_bzrdir_format.network_name()
470
 
        client.add_expected_call(
471
 
            'BzrDir.cloning_metadir', ('quack/', 'False'),
472
 
            'success', (control_name, '', ('branch', ''))),
473
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
474
 
            _client=client)
475
 
        result = a_bzrdir.cloning_metadir()
476
 
        # We should have got a reference control dir with default branch and
477
 
        # repository formats.
478
 
        # This pokes a little, just to be sure.
479
 
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
480
 
        self.assertEqual(None, result._repository_format)
481
 
        self.assertEqual(None, result._branch_format)
482
 
        self.assertFinished(client)
483
 
 
484
 
 
485
 
class TestBzrDirOpen(TestRemote):
486
 
 
487
 
    def make_fake_client_and_transport(self, path='quack'):
488
 
        transport = MemoryTransport()
489
 
        transport.mkdir(path)
490
 
        transport = transport.clone(path)
491
 
        client = FakeClient(transport.base)
492
 
        return client, transport
493
 
 
494
 
    def test_absent(self):
495
 
        client, transport = self.make_fake_client_and_transport()
496
 
        client.add_expected_call(
497
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('no',))
498
 
        self.assertRaises(errors.NotBranchError, RemoteBzrDir, transport,
499
 
                RemoteBzrDirFormat(), _client=client, _force_probe=True)
500
 
        self.assertFinished(client)
501
 
 
502
 
    def test_present_without_workingtree(self):
503
 
        client, transport = self.make_fake_client_and_transport()
504
 
        client.add_expected_call(
505
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'no'))
506
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
507
 
            _client=client, _force_probe=True)
508
 
        self.assertIsInstance(bd, RemoteBzrDir)
509
 
        self.assertFalse(bd.has_workingtree())
510
 
        self.assertRaises(errors.NoWorkingTree, bd.open_workingtree)
511
 
        self.assertFinished(client)
512
 
 
513
 
    def test_present_with_workingtree(self):
514
 
        client, transport = self.make_fake_client_and_transport()
515
 
        client.add_expected_call(
516
 
            'BzrDir.open_2.1', ('quack/',), 'success', ('yes', 'yes'))
517
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
518
 
            _client=client, _force_probe=True)
519
 
        self.assertIsInstance(bd, RemoteBzrDir)
520
 
        self.assertTrue(bd.has_workingtree())
521
 
        self.assertRaises(errors.NotLocalUrl, bd.open_workingtree)
522
 
        self.assertFinished(client)
523
 
 
524
 
    def test_backwards_compat(self):
525
 
        client, transport = self.make_fake_client_and_transport()
526
 
        client.add_expected_call(
527
 
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
528
 
        client.add_expected_call(
529
 
            'BzrDir.open', ('quack/',), 'success', ('yes',))
530
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
531
 
            _client=client, _force_probe=True)
532
 
        self.assertIsInstance(bd, RemoteBzrDir)
533
 
        self.assertFinished(client)
534
 
 
535
 
    def test_backwards_compat_hpss_v2(self):
536
 
        client, transport = self.make_fake_client_and_transport()
537
 
        # Monkey-patch fake client to simulate real-world behaviour with v2
538
 
        # server: upon first RPC call detect the protocol version, and because
539
 
        # the version is 2 also do _remember_remote_is_before((1, 6)) before
540
 
        # continuing with the RPC.
541
 
        orig_check_call = client._check_call
542
 
        def check_call(method, args):
543
 
            client._medium._protocol_version = 2
544
 
            client._medium._remember_remote_is_before((1, 6))
545
 
            client._check_call = orig_check_call
546
 
            client._check_call(method, args)
547
 
        client._check_call = check_call
548
 
        client.add_expected_call(
549
 
            'BzrDir.open_2.1', ('quack/',), 'unknown', ('BzrDir.open_2.1',))
550
 
        client.add_expected_call(
551
 
            'BzrDir.open', ('quack/',), 'success', ('yes',))
552
 
        bd = RemoteBzrDir(transport, RemoteBzrDirFormat(),
553
 
            _client=client, _force_probe=True)
554
 
        self.assertIsInstance(bd, RemoteBzrDir)
555
 
        self.assertFinished(client)
556
 
 
557
 
 
558
 
class TestBzrDirOpenBranch(TestRemote):
559
 
 
560
 
    def test_backwards_compat(self):
561
 
        self.setup_smart_server_with_call_log()
562
 
        self.make_branch('.')
563
 
        a_dir = BzrDir.open(self.get_url('.'))
564
 
        self.reset_smart_call_log()
565
 
        verb = 'BzrDir.open_branchV3'
566
 
        self.disable_verb(verb)
567
 
        format = a_dir.open_branch()
568
 
        call_count = len([call for call in self.hpss_calls if
569
 
            call.call.method == verb])
570
 
        self.assertEqual(1, call_count)
 
349
        # You cannot call _remember_remote_is_before with a larger value.
 
350
        self.assertRaises(
 
351
            AssertionError, client_medium._remember_remote_is_before, (1, 9))
 
352
 
 
353
 
 
354
class TestBzrDirOpenBranch(tests.TestCase):
571
355
 
572
356
    def test_branch_present(self):
573
 
        reference_format = self.get_repo_format()
574
 
        network_name = reference_format.network_name()
575
 
        branch_network_name = self.get_branch_format().network_name()
576
357
        transport = MemoryTransport()
577
358
        transport.mkdir('quack')
578
359
        transport = transport.clone('quack')
579
360
        client = FakeClient(transport.base)
580
361
        client.add_expected_call(
581
 
            'BzrDir.open_branchV3', ('quack/',),
582
 
            'success', ('branch', branch_network_name))
 
362
            'BzrDir.open_branch', ('quack/',),
 
363
            'success', ('ok', ''))
583
364
        client.add_expected_call(
584
 
            'BzrDir.find_repositoryV3', ('quack/',),
585
 
            'success', ('ok', '', 'no', 'no', 'no', network_name))
 
365
            'BzrDir.find_repositoryV2', ('quack/',),
 
366
            'success', ('ok', '', 'no', 'no', 'no'))
586
367
        client.add_expected_call(
587
368
            'Branch.get_stacked_on_url', ('quack/',),
588
369
            'error', ('NotStacked',))
589
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
590
 
            _client=client)
 
370
        bzrdir = RemoteBzrDir(transport, _client=client)
591
371
        result = bzrdir.open_branch()
592
372
        self.assertIsInstance(result, RemoteBranch)
593
373
        self.assertEqual(bzrdir, result.bzrdir)
594
 
        self.assertFinished(client)
 
374
        client.finished_test()
595
375
 
596
376
    def test_branch_missing(self):
597
377
        transport = MemoryTransport()
599
379
        transport = transport.clone('quack')
600
380
        client = FakeClient(transport.base)
601
381
        client.add_error_response('nobranch')
602
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
603
 
            _client=client)
 
382
        bzrdir = RemoteBzrDir(transport, _client=client)
604
383
        self.assertRaises(errors.NotBranchError, bzrdir.open_branch)
605
384
        self.assertEqual(
606
 
            [('call', 'BzrDir.open_branchV3', ('quack/',))],
 
385
            [('call', 'BzrDir.open_branch', ('quack/',))],
607
386
            client._calls)
608
387
 
609
388
    def test__get_tree_branch(self):
610
389
        # _get_tree_branch is a form of open_branch, but it should only ask for
611
390
        # branch opening, not any other network requests.
612
391
        calls = []
613
 
        def open_branch(name=None):
 
392
        def open_branch():
614
393
            calls.append("Called")
615
394
            return "a-branch"
616
395
        transport = MemoryTransport()
617
396
        # no requests on the network - catches other api calls being made.
618
397
        client = FakeClient(transport.base)
619
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
620
 
            _client=client)
 
398
        bzrdir = RemoteBzrDir(transport, _client=client)
621
399
        # patch the open_branch call to record that it was called.
622
400
        bzrdir.open_branch = open_branch
623
401
        self.assertEqual((None, "a-branch"), bzrdir._get_tree_branch())
629
407
        # transmitted as "~", not "%7E".
630
408
        transport = RemoteTCPTransport('bzr://localhost/~hello/')
631
409
        client = FakeClient(transport.base)
632
 
        reference_format = self.get_repo_format()
633
 
        network_name = reference_format.network_name()
634
 
        branch_network_name = self.get_branch_format().network_name()
635
 
        client.add_expected_call(
636
 
            'BzrDir.open_branchV3', ('~hello/',),
637
 
            'success', ('branch', branch_network_name))
638
 
        client.add_expected_call(
639
 
            'BzrDir.find_repositoryV3', ('~hello/',),
640
 
            'success', ('ok', '', 'no', 'no', 'no', network_name))
 
410
        client.add_expected_call(
 
411
            'BzrDir.open_branch', ('~hello/',),
 
412
            'success', ('ok', ''))
 
413
        client.add_expected_call(
 
414
            'BzrDir.find_repositoryV2', ('~hello/',),
 
415
            'success', ('ok', '', 'no', 'no', 'no'))
641
416
        client.add_expected_call(
642
417
            'Branch.get_stacked_on_url', ('~hello/',),
643
418
            'error', ('NotStacked',))
644
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
645
 
            _client=client)
 
419
        bzrdir = RemoteBzrDir(transport, _client=client)
646
420
        result = bzrdir.open_branch()
647
 
        self.assertFinished(client)
 
421
        client.finished_test()
648
422
 
649
423
    def check_open_repository(self, rich_root, subtrees, external_lookup='no'):
650
 
        reference_format = self.get_repo_format()
651
 
        network_name = reference_format.network_name()
652
424
        transport = MemoryTransport()
653
425
        transport.mkdir('quack')
654
426
        transport = transport.clone('quack')
662
434
            subtree_response = 'no'
663
435
        client = FakeClient(transport.base)
664
436
        client.add_success_response(
665
 
            'ok', '', rich_response, subtree_response, external_lookup,
666
 
            network_name)
667
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
668
 
            _client=client)
 
437
            'ok', '', rich_response, subtree_response, external_lookup)
 
438
        bzrdir = RemoteBzrDir(transport, _client=client)
669
439
        result = bzrdir.open_repository()
670
440
        self.assertEqual(
671
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',))],
 
441
            [('call', 'BzrDir.find_repositoryV2', ('quack/',))],
672
442
            client._calls)
673
443
        self.assertIsInstance(result, RemoteRepository)
674
444
        self.assertEqual(bzrdir, result.bzrdir)
687
457
        old.
688
458
        """
689
459
        self.assertRaises(errors.NotBranchError,
690
 
            RemoteBzrProber.probe_transport, OldServerTransport())
691
 
 
692
 
 
693
 
class TestBzrDirCreateBranch(TestRemote):
694
 
 
695
 
    def test_backwards_compat(self):
696
 
        self.setup_smart_server_with_call_log()
697
 
        repo = self.make_repository('.')
698
 
        self.reset_smart_call_log()
699
 
        self.disable_verb('BzrDir.create_branch')
700
 
        branch = repo.bzrdir.create_branch()
701
 
        create_branch_call_count = len([call for call in self.hpss_calls if
702
 
            call.call.method == 'BzrDir.create_branch'])
703
 
        self.assertEqual(1, create_branch_call_count)
704
 
 
705
 
    def test_current_server(self):
706
 
        transport = self.get_transport('.')
707
 
        transport = transport.clone('quack')
708
 
        self.make_repository('quack')
709
 
        client = FakeClient(transport.base)
710
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
711
 
        reference_format = reference_bzrdir_format.get_branch_format()
712
 
        network_name = reference_format.network_name()
713
 
        reference_repo_fmt = reference_bzrdir_format.repository_format
714
 
        reference_repo_name = reference_repo_fmt.network_name()
715
 
        client.add_expected_call(
716
 
            'BzrDir.create_branch', ('quack/', network_name),
717
 
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
718
 
            reference_repo_name))
719
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
720
 
            _client=client)
721
 
        branch = a_bzrdir.create_branch()
722
 
        # We should have got a remote branch
723
 
        self.assertIsInstance(branch, remote.RemoteBranch)
724
 
        # its format should have the settings from the response
725
 
        format = branch._format
726
 
        self.assertEqual(network_name, format.network_name())
727
 
 
728
 
    def test_already_open_repo_and_reused_medium(self):
729
 
        """Bug 726584: create_branch(..., repository=repo) should work
730
 
        regardless of what the smart medium's base URL is.
731
 
        """
732
 
        self.transport_server = test_server.SmartTCPServer_for_testing
733
 
        transport = self.get_transport('.')
734
 
        repo = self.make_repository('quack')
735
 
        # Client's medium rooted a transport root (not at the bzrdir)
736
 
        client = FakeClient(transport.base)
737
 
        transport = transport.clone('quack')
738
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
739
 
        reference_format = reference_bzrdir_format.get_branch_format()
740
 
        network_name = reference_format.network_name()
741
 
        reference_repo_fmt = reference_bzrdir_format.repository_format
742
 
        reference_repo_name = reference_repo_fmt.network_name()
743
 
        client.add_expected_call(
744
 
            'BzrDir.create_branch', ('extra/quack/', network_name),
745
 
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
746
 
            reference_repo_name))
747
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
748
 
            _client=client)
749
 
        branch = a_bzrdir.create_branch(repository=repo)
750
 
        # We should have got a remote branch
751
 
        self.assertIsInstance(branch, remote.RemoteBranch)
752
 
        # its format should have the settings from the response
753
 
        format = branch._format
754
 
        self.assertEqual(network_name, format.network_name())
755
 
 
756
 
 
757
 
class TestBzrDirCreateRepository(TestRemote):
758
 
 
759
 
    def test_backwards_compat(self):
760
 
        self.setup_smart_server_with_call_log()
761
 
        bzrdir = self.make_bzrdir('.')
762
 
        self.reset_smart_call_log()
763
 
        self.disable_verb('BzrDir.create_repository')
764
 
        repo = bzrdir.create_repository()
765
 
        create_repo_call_count = len([call for call in self.hpss_calls if
766
 
            call.call.method == 'BzrDir.create_repository'])
767
 
        self.assertEqual(1, create_repo_call_count)
768
 
 
769
 
    def test_current_server(self):
770
 
        transport = self.get_transport('.')
771
 
        transport = transport.clone('quack')
772
 
        self.make_bzrdir('quack')
773
 
        client = FakeClient(transport.base)
774
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
775
 
        reference_format = reference_bzrdir_format.repository_format
776
 
        network_name = reference_format.network_name()
777
 
        client.add_expected_call(
778
 
            'BzrDir.create_repository', ('quack/',
779
 
                'Bazaar repository format 2a (needs bzr 1.16 or later)\n',
780
 
                'False'),
781
 
            'success', ('ok', 'yes', 'yes', 'yes', network_name))
782
 
        a_bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
783
 
            _client=client)
784
 
        repo = a_bzrdir.create_repository()
785
 
        # We should have got a remote repository
786
 
        self.assertIsInstance(repo, remote.RemoteRepository)
787
 
        # its format should have the settings from the response
788
 
        format = repo._format
789
 
        self.assertTrue(format.rich_root_data)
790
 
        self.assertTrue(format.supports_tree_reference)
791
 
        self.assertTrue(format.supports_external_lookups)
792
 
        self.assertEqual(network_name, format.network_name())
793
 
 
794
 
 
795
 
class TestBzrDirOpenRepository(TestRemote):
796
 
 
797
 
    def test_backwards_compat_1_2_3(self):
798
 
        # fallback all the way to the first version.
799
 
        reference_format = self.get_repo_format()
800
 
        network_name = reference_format.network_name()
801
 
        server_url = 'bzr://example.com/'
802
 
        self.permit_url(server_url)
803
 
        client = FakeClient(server_url)
804
 
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
805
 
        client.add_unknown_method_response('BzrDir.find_repositoryV2')
 
460
            RemoteBzrDirFormat.probe_transport, OldServerTransport())
 
461
 
 
462
 
 
463
class TestBzrDirOpenRepository(tests.TestCase):
 
464
 
 
465
    def test_backwards_compat_1_2(self):
 
466
        transport = MemoryTransport()
 
467
        transport.mkdir('quack')
 
468
        transport = transport.clone('quack')
 
469
        client = FakeClient(transport.base)
 
470
        client.add_unknown_method_response('RemoteRepository.find_repositoryV2')
806
471
        client.add_success_response('ok', '', 'no', 'no')
807
 
        # A real repository instance will be created to determine the network
808
 
        # name.
809
 
        client.add_success_response_with_body(
810
 
            "Bazaar-NG meta directory, format 1\n", 'ok')
811
 
        client.add_success_response_with_body(
812
 
            reference_format.get_format_string(), 'ok')
813
 
        # PackRepository wants to do a stat
814
 
        client.add_success_response('stat', '0', '65535')
815
 
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
816
 
            _client=client)
817
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
818
 
            _client=client)
819
 
        repo = bzrdir.open_repository()
820
 
        self.assertEqual(
821
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',)),
822
 
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
823
 
             ('call', 'BzrDir.find_repository', ('quack/',)),
824
 
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
825
 
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
826
 
             ('call', 'stat', ('/quack/.bzr/repository',)),
827
 
             ],
828
 
            client._calls)
829
 
        self.assertEqual(network_name, repo._format.network_name())
830
 
 
831
 
    def test_backwards_compat_2(self):
832
 
        # fallback to find_repositoryV2
833
 
        reference_format = self.get_repo_format()
834
 
        network_name = reference_format.network_name()
835
 
        server_url = 'bzr://example.com/'
836
 
        self.permit_url(server_url)
837
 
        client = FakeClient(server_url)
838
 
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
839
 
        client.add_success_response('ok', '', 'no', 'no', 'no')
840
 
        # A real repository instance will be created to determine the network
841
 
        # name.
842
 
        client.add_success_response_with_body(
843
 
            "Bazaar-NG meta directory, format 1\n", 'ok')
844
 
        client.add_success_response_with_body(
845
 
            reference_format.get_format_string(), 'ok')
846
 
        # PackRepository wants to do a stat
847
 
        client.add_success_response('stat', '0', '65535')
848
 
        remote_transport = RemoteTransport(server_url + 'quack/', medium=False,
849
 
            _client=client)
850
 
        bzrdir = RemoteBzrDir(remote_transport, RemoteBzrDirFormat(),
851
 
            _client=client)
852
 
        repo = bzrdir.open_repository()
853
 
        self.assertEqual(
854
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',)),
855
 
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
856
 
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
857
 
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
858
 
             ('call', 'stat', ('/quack/.bzr/repository',)),
859
 
             ],
860
 
            client._calls)
861
 
        self.assertEqual(network_name, repo._format.network_name())
862
 
 
863
 
    def test_current_server(self):
864
 
        reference_format = self.get_repo_format()
865
 
        network_name = reference_format.network_name()
866
 
        transport = MemoryTransport()
867
 
        transport.mkdir('quack')
868
 
        transport = transport.clone('quack')
869
 
        client = FakeClient(transport.base)
870
 
        client.add_success_response('ok', '', 'no', 'no', 'no', network_name)
871
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
872
 
            _client=client)
873
 
        repo = bzrdir.open_repository()
874
 
        self.assertEqual(
875
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',))],
876
 
            client._calls)
877
 
        self.assertEqual(network_name, repo._format.network_name())
878
 
 
879
 
 
880
 
class TestBzrDirFormatInitializeEx(TestRemote):
881
 
 
882
 
    def test_success(self):
883
 
        """Simple test for typical successful call."""
884
 
        fmt = RemoteBzrDirFormat()
885
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
886
 
        transport = self.get_transport()
887
 
        client = FakeClient(transport.base)
888
 
        client.add_expected_call(
889
 
            'BzrDirFormat.initialize_ex_1.16',
890
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
891
 
                 '', '', '', 'False'),
892
 
            'success',
893
 
                ('.', 'no', 'no', 'yes', 'repo fmt', 'repo bzrdir fmt',
894
 
                 'bzrdir fmt', 'False', '', '', 'repo lock token'))
895
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
896
 
        # it's currently hard to test that without supplying a real remote
897
 
        # transport connected to a real server.
898
 
        result = fmt._initialize_on_transport_ex_rpc(client, 'path',
899
 
            transport, False, False, False, None, None, None, None, False)
900
 
        self.assertFinished(client)
901
 
 
902
 
    def test_error(self):
903
 
        """Error responses are translated, e.g. 'PermissionDenied' raises the
904
 
        corresponding error from the client.
905
 
        """
906
 
        fmt = RemoteBzrDirFormat()
907
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
908
 
        transport = self.get_transport()
909
 
        client = FakeClient(transport.base)
910
 
        client.add_expected_call(
911
 
            'BzrDirFormat.initialize_ex_1.16',
912
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
913
 
                 '', '', '', 'False'),
914
 
            'error',
915
 
                ('PermissionDenied', 'path', 'extra info'))
916
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
917
 
        # it's currently hard to test that without supplying a real remote
918
 
        # transport connected to a real server.
919
 
        err = self.assertRaises(errors.PermissionDenied,
920
 
            fmt._initialize_on_transport_ex_rpc, client, 'path', transport,
921
 
            False, False, False, None, None, None, None, False)
922
 
        self.assertEqual('path', err.path)
923
 
        self.assertEqual(': extra info', err.extra)
924
 
        self.assertFinished(client)
925
 
 
926
 
    def test_error_from_real_server(self):
927
 
        """Integration test for error translation."""
928
 
        transport = self.make_smart_server('foo')
929
 
        transport = transport.clone('no-such-path')
930
 
        fmt = RemoteBzrDirFormat()
931
 
        err = self.assertRaises(errors.NoSuchFile,
932
 
            fmt.initialize_on_transport_ex, transport, create_prefix=False)
 
472
        bzrdir = RemoteBzrDir(transport, _client=client)
 
473
        repo = bzrdir.open_repository()
 
474
        self.assertEqual(
 
475
            [('call', 'BzrDir.find_repositoryV2', ('quack/',)),
 
476
             ('call', 'BzrDir.find_repository', ('quack/',))],
 
477
            client._calls)
933
478
 
934
479
 
935
480
class OldSmartClient(object):
960
505
        return OldSmartClient()
961
506
 
962
507
 
963
 
class RemoteBzrDirTestCase(TestRemote):
964
 
 
965
 
    def make_remote_bzrdir(self, transport, client):
966
 
        """Make a RemotebzrDir using 'client' as the _client."""
967
 
        return RemoteBzrDir(transport, RemoteBzrDirFormat(),
968
 
            _client=client)
969
 
 
970
 
 
971
 
class RemoteBranchTestCase(RemoteBzrDirTestCase):
972
 
 
973
 
    def lock_remote_branch(self, branch):
974
 
        """Trick a RemoteBranch into thinking it is locked."""
975
 
        branch._lock_mode = 'w'
976
 
        branch._lock_count = 2
977
 
        branch._lock_token = 'branch token'
978
 
        branch._repo_lock_token = 'repo token'
979
 
        branch.repository._lock_mode = 'w'
980
 
        branch.repository._lock_count = 2
981
 
        branch.repository._lock_token = 'repo token'
 
508
class RemoteBranchTestCase(tests.TestCase):
982
509
 
983
510
    def make_remote_branch(self, transport, client):
984
511
        """Make a RemoteBranch using 'client' as its _SmartClient.
985
 
 
 
512
        
986
513
        A RemoteBzrDir and RemoteRepository will also be created to fill out
987
514
        the RemoteBranch, albeit with stub values for some of their attributes.
988
515
        """
989
516
        # we do not want bzrdir to make any remote calls, so use False as its
990
517
        # _client.  If it tries to make a remote call, this will fail
991
518
        # immediately.
992
 
        bzrdir = self.make_remote_bzrdir(transport, False)
 
519
        bzrdir = RemoteBzrDir(transport, _client=False)
993
520
        repo = RemoteRepository(bzrdir, None, _client=client)
994
 
        branch_format = self.get_branch_format()
995
 
        format = RemoteBranchFormat(network_name=branch_format.network_name())
996
 
        return RemoteBranch(bzrdir, repo, _client=client, format=format)
997
 
 
998
 
 
999
 
class TestBranchGetParent(RemoteBranchTestCase):
1000
 
 
1001
 
    def test_no_parent(self):
1002
 
        # in an empty branch we decode the response properly
1003
 
        transport = MemoryTransport()
1004
 
        client = FakeClient(transport.base)
1005
 
        client.add_expected_call(
1006
 
            'Branch.get_stacked_on_url', ('quack/',),
1007
 
            'error', ('NotStacked',))
1008
 
        client.add_expected_call(
1009
 
            'Branch.get_parent', ('quack/',),
1010
 
            'success', ('',))
1011
 
        transport.mkdir('quack')
1012
 
        transport = transport.clone('quack')
1013
 
        branch = self.make_remote_branch(transport, client)
1014
 
        result = branch.get_parent()
1015
 
        self.assertFinished(client)
1016
 
        self.assertEqual(None, result)
1017
 
 
1018
 
    def test_parent_relative(self):
1019
 
        transport = MemoryTransport()
1020
 
        client = FakeClient(transport.base)
1021
 
        client.add_expected_call(
1022
 
            'Branch.get_stacked_on_url', ('kwaak/',),
1023
 
            'error', ('NotStacked',))
1024
 
        client.add_expected_call(
1025
 
            'Branch.get_parent', ('kwaak/',),
1026
 
            'success', ('../foo/',))
1027
 
        transport.mkdir('kwaak')
1028
 
        transport = transport.clone('kwaak')
1029
 
        branch = self.make_remote_branch(transport, client)
1030
 
        result = branch.get_parent()
1031
 
        self.assertEqual(transport.clone('../foo').base, result)
1032
 
 
1033
 
    def test_parent_absolute(self):
1034
 
        transport = MemoryTransport()
1035
 
        client = FakeClient(transport.base)
1036
 
        client.add_expected_call(
1037
 
            'Branch.get_stacked_on_url', ('kwaak/',),
1038
 
            'error', ('NotStacked',))
1039
 
        client.add_expected_call(
1040
 
            'Branch.get_parent', ('kwaak/',),
1041
 
            'success', ('http://foo/',))
1042
 
        transport.mkdir('kwaak')
1043
 
        transport = transport.clone('kwaak')
1044
 
        branch = self.make_remote_branch(transport, client)
1045
 
        result = branch.get_parent()
1046
 
        self.assertEqual('http://foo/', result)
1047
 
        self.assertFinished(client)
1048
 
 
1049
 
 
1050
 
class TestBranchSetParentLocation(RemoteBranchTestCase):
1051
 
 
1052
 
    def test_no_parent(self):
1053
 
        # We call the verb when setting parent to None
1054
 
        transport = MemoryTransport()
1055
 
        client = FakeClient(transport.base)
1056
 
        client.add_expected_call(
1057
 
            'Branch.get_stacked_on_url', ('quack/',),
1058
 
            'error', ('NotStacked',))
1059
 
        client.add_expected_call(
1060
 
            'Branch.set_parent_location', ('quack/', 'b', 'r', ''),
1061
 
            'success', ())
1062
 
        transport.mkdir('quack')
1063
 
        transport = transport.clone('quack')
1064
 
        branch = self.make_remote_branch(transport, client)
1065
 
        branch._lock_token = 'b'
1066
 
        branch._repo_lock_token = 'r'
1067
 
        branch._set_parent_location(None)
1068
 
        self.assertFinished(client)
1069
 
 
1070
 
    def test_parent(self):
1071
 
        transport = MemoryTransport()
1072
 
        client = FakeClient(transport.base)
1073
 
        client.add_expected_call(
1074
 
            'Branch.get_stacked_on_url', ('kwaak/',),
1075
 
            'error', ('NotStacked',))
1076
 
        client.add_expected_call(
1077
 
            'Branch.set_parent_location', ('kwaak/', 'b', 'r', 'foo'),
1078
 
            'success', ())
1079
 
        transport.mkdir('kwaak')
1080
 
        transport = transport.clone('kwaak')
1081
 
        branch = self.make_remote_branch(transport, client)
1082
 
        branch._lock_token = 'b'
1083
 
        branch._repo_lock_token = 'r'
1084
 
        branch._set_parent_location('foo')
1085
 
        self.assertFinished(client)
1086
 
 
1087
 
    def test_backwards_compat(self):
1088
 
        self.setup_smart_server_with_call_log()
1089
 
        branch = self.make_branch('.')
1090
 
        self.reset_smart_call_log()
1091
 
        verb = 'Branch.set_parent_location'
1092
 
        self.disable_verb(verb)
1093
 
        branch.set_parent('http://foo/')
1094
 
        self.assertLength(12, self.hpss_calls)
1095
 
 
1096
 
 
1097
 
class TestBranchGetTagsBytes(RemoteBranchTestCase):
1098
 
 
1099
 
    def test_backwards_compat(self):
1100
 
        self.setup_smart_server_with_call_log()
1101
 
        branch = self.make_branch('.')
1102
 
        self.reset_smart_call_log()
1103
 
        verb = 'Branch.get_tags_bytes'
1104
 
        self.disable_verb(verb)
1105
 
        branch.tags.get_tag_dict()
1106
 
        call_count = len([call for call in self.hpss_calls if
1107
 
            call.call.method == verb])
1108
 
        self.assertEqual(1, call_count)
1109
 
 
1110
 
    def test_trivial(self):
1111
 
        transport = MemoryTransport()
1112
 
        client = FakeClient(transport.base)
1113
 
        client.add_expected_call(
1114
 
            'Branch.get_stacked_on_url', ('quack/',),
1115
 
            'error', ('NotStacked',))
1116
 
        client.add_expected_call(
1117
 
            'Branch.get_tags_bytes', ('quack/',),
1118
 
            'success', ('',))
1119
 
        transport.mkdir('quack')
1120
 
        transport = transport.clone('quack')
1121
 
        branch = self.make_remote_branch(transport, client)
1122
 
        result = branch.tags.get_tag_dict()
1123
 
        self.assertFinished(client)
1124
 
        self.assertEqual({}, result)
1125
 
 
1126
 
 
1127
 
class TestBranchSetTagsBytes(RemoteBranchTestCase):
1128
 
 
1129
 
    def test_trivial(self):
1130
 
        transport = MemoryTransport()
1131
 
        client = FakeClient(transport.base)
1132
 
        client.add_expected_call(
1133
 
            'Branch.get_stacked_on_url', ('quack/',),
1134
 
            'error', ('NotStacked',))
1135
 
        client.add_expected_call(
1136
 
            'Branch.set_tags_bytes', ('quack/', 'branch token', 'repo token'),
1137
 
            'success', ('',))
1138
 
        transport.mkdir('quack')
1139
 
        transport = transport.clone('quack')
1140
 
        branch = self.make_remote_branch(transport, client)
1141
 
        self.lock_remote_branch(branch)
1142
 
        branch._set_tags_bytes('tags bytes')
1143
 
        self.assertFinished(client)
1144
 
        self.assertEqual('tags bytes', client._calls[-1][-1])
1145
 
 
1146
 
    def test_backwards_compatible(self):
1147
 
        transport = MemoryTransport()
1148
 
        client = FakeClient(transport.base)
1149
 
        client.add_expected_call(
1150
 
            'Branch.get_stacked_on_url', ('quack/',),
1151
 
            'error', ('NotStacked',))
1152
 
        client.add_expected_call(
1153
 
            'Branch.set_tags_bytes', ('quack/', 'branch token', 'repo token'),
1154
 
            'unknown', ('Branch.set_tags_bytes',))
1155
 
        transport.mkdir('quack')
1156
 
        transport = transport.clone('quack')
1157
 
        branch = self.make_remote_branch(transport, client)
1158
 
        self.lock_remote_branch(branch)
1159
 
        class StubRealBranch(object):
1160
 
            def __init__(self):
1161
 
                self.calls = []
1162
 
            def _set_tags_bytes(self, bytes):
1163
 
                self.calls.append(('set_tags_bytes', bytes))
1164
 
        real_branch = StubRealBranch()
1165
 
        branch._real_branch = real_branch
1166
 
        branch._set_tags_bytes('tags bytes')
1167
 
        # Call a second time, to exercise the 'remote version already inferred'
1168
 
        # code path.
1169
 
        branch._set_tags_bytes('tags bytes')
1170
 
        self.assertFinished(client)
1171
 
        self.assertEqual(
1172
 
            [('set_tags_bytes', 'tags bytes')] * 2, real_branch.calls)
1173
 
 
1174
 
 
1175
 
class TestBranchHeadsToFetch(RemoteBranchTestCase):
1176
 
 
1177
 
    def test_uses_last_revision_info_and_tags_by_default(self):
1178
 
        transport = MemoryTransport()
1179
 
        client = FakeClient(transport.base)
1180
 
        client.add_expected_call(
1181
 
            'Branch.get_stacked_on_url', ('quack/',),
1182
 
            'error', ('NotStacked',))
1183
 
        client.add_expected_call(
1184
 
            'Branch.last_revision_info', ('quack/',),
1185
 
            'success', ('ok', '1', 'rev-tip'))
1186
 
        client.add_expected_call(
1187
 
            'Branch.get_config_file', ('quack/',),
1188
 
            'success', ('ok',), '')
1189
 
        transport.mkdir('quack')
1190
 
        transport = transport.clone('quack')
1191
 
        branch = self.make_remote_branch(transport, client)
1192
 
        result = branch.heads_to_fetch()
1193
 
        self.assertFinished(client)
1194
 
        self.assertEqual((set(['rev-tip']), set()), result)
1195
 
 
1196
 
    def test_uses_last_revision_info_and_tags_when_set(self):
1197
 
        transport = MemoryTransport()
1198
 
        client = FakeClient(transport.base)
1199
 
        client.add_expected_call(
1200
 
            'Branch.get_stacked_on_url', ('quack/',),
1201
 
            'error', ('NotStacked',))
1202
 
        client.add_expected_call(
1203
 
            'Branch.last_revision_info', ('quack/',),
1204
 
            'success', ('ok', '1', 'rev-tip'))
1205
 
        client.add_expected_call(
1206
 
            'Branch.get_config_file', ('quack/',),
1207
 
            'success', ('ok',), 'branch.fetch_tags = True')
1208
 
        # XXX: this will break if the default format's serialization of tags
1209
 
        # changes, or if the RPC for fetching tags changes from get_tags_bytes.
1210
 
        client.add_expected_call(
1211
 
            'Branch.get_tags_bytes', ('quack/',),
1212
 
            'success', ('d5:tag-17:rev-foo5:tag-27:rev-bare',))
1213
 
        transport.mkdir('quack')
1214
 
        transport = transport.clone('quack')
1215
 
        branch = self.make_remote_branch(transport, client)
1216
 
        result = branch.heads_to_fetch()
1217
 
        self.assertFinished(client)
1218
 
        self.assertEqual(
1219
 
            (set(['rev-tip']), set(['rev-foo', 'rev-bar'])), result)
1220
 
 
1221
 
    def test_uses_rpc_for_formats_with_non_default_heads_to_fetch(self):
1222
 
        transport = MemoryTransport()
1223
 
        client = FakeClient(transport.base)
1224
 
        client.add_expected_call(
1225
 
            'Branch.get_stacked_on_url', ('quack/',),
1226
 
            'error', ('NotStacked',))
1227
 
        client.add_expected_call(
1228
 
            'Branch.heads_to_fetch', ('quack/',),
1229
 
            'success', (['tip'], ['tagged-1', 'tagged-2']))
1230
 
        transport.mkdir('quack')
1231
 
        transport = transport.clone('quack')
1232
 
        branch = self.make_remote_branch(transport, client)
1233
 
        branch._format._use_default_local_heads_to_fetch = lambda: False
1234
 
        result = branch.heads_to_fetch()
1235
 
        self.assertFinished(client)
1236
 
        self.assertEqual((set(['tip']), set(['tagged-1', 'tagged-2'])), result)
1237
 
 
1238
 
    def make_branch_with_tags(self):
1239
 
        self.setup_smart_server_with_call_log()
1240
 
        # Make a branch with a single revision.
1241
 
        builder = self.make_branch_builder('foo')
1242
 
        builder.start_series()
1243
 
        builder.build_snapshot('tip', None, [
1244
 
            ('add', ('', 'root-id', 'directory', ''))])
1245
 
        builder.finish_series()
1246
 
        branch = builder.get_branch()
1247
 
        # Add two tags to that branch
1248
 
        branch.tags.set_tag('tag-1', 'rev-1')
1249
 
        branch.tags.set_tag('tag-2', 'rev-2')
1250
 
        return branch
1251
 
 
1252
 
    def test_backwards_compatible(self):
1253
 
        branch = self.make_branch_with_tags()
1254
 
        c = branch.get_config()
1255
 
        c.set_user_option('branch.fetch_tags', 'True')
1256
 
        self.addCleanup(branch.lock_read().unlock)
1257
 
        # Disable the heads_to_fetch verb
1258
 
        verb = 'Branch.heads_to_fetch'
1259
 
        self.disable_verb(verb)
1260
 
        self.reset_smart_call_log()
1261
 
        result = branch.heads_to_fetch()
1262
 
        self.assertEqual((set(['tip']), set(['rev-1', 'rev-2'])), result)
1263
 
        self.assertEqual(
1264
 
            ['Branch.last_revision_info', 'Branch.get_config_file',
1265
 
             'Branch.get_tags_bytes'],
1266
 
            [call.call.method for call in self.hpss_calls])
1267
 
 
1268
 
    def test_backwards_compatible_no_tags(self):
1269
 
        branch = self.make_branch_with_tags()
1270
 
        c = branch.get_config()
1271
 
        c.set_user_option('branch.fetch_tags', 'False')
1272
 
        self.addCleanup(branch.lock_read().unlock)
1273
 
        # Disable the heads_to_fetch verb
1274
 
        verb = 'Branch.heads_to_fetch'
1275
 
        self.disable_verb(verb)
1276
 
        self.reset_smart_call_log()
1277
 
        result = branch.heads_to_fetch()
1278
 
        self.assertEqual((set(['tip']), set()), result)
1279
 
        self.assertEqual(
1280
 
            ['Branch.last_revision_info', 'Branch.get_config_file'],
1281
 
            [call.call.method for call in self.hpss_calls])
 
521
        return RemoteBranch(bzrdir, repo, _client=client)
1282
522
 
1283
523
 
1284
524
class TestBranchLastRevisionInfo(RemoteBranchTestCase):
1297
537
        transport = transport.clone('quack')
1298
538
        branch = self.make_remote_branch(transport, client)
1299
539
        result = branch.last_revision_info()
1300
 
        self.assertFinished(client)
 
540
        client.finished_test()
1301
541
        self.assertEqual((0, NULL_REVISION), result)
1302
542
 
1303
543
    def test_non_empty_branch(self):
1318
558
        self.assertEqual((2, revid), result)
1319
559
 
1320
560
 
1321
 
class TestBranch_get_stacked_on_url(TestRemote):
 
561
class TestBranch_get_stacked_on_url(tests.TestCaseWithMemoryTransport):
1322
562
    """Test Branch._get_stacked_on_url rpc"""
1323
563
 
1324
564
    def test_get_stacked_on_invalid_url(self):
1325
 
        # test that asking for a stacked on url the server can't access works.
1326
 
        # This isn't perfect, but then as we're in the same process there
1327
 
        # really isn't anything we can do to be 100% sure that the server
1328
 
        # doesn't just open in - this test probably needs to be rewritten using
1329
 
        # a spawn()ed server.
1330
 
        stacked_branch = self.make_branch('stacked', format='1.9')
1331
 
        memory_branch = self.make_branch('base', format='1.9')
1332
 
        vfs_url = self.get_vfs_only_url('base')
1333
 
        stacked_branch.set_stacked_on_url(vfs_url)
1334
 
        transport = stacked_branch.bzrdir.root_transport
 
565
        raise tests.KnownFailure('opening a branch requires the server to open the fallback repository')
 
566
        transport = FakeRemoteTransport('fakeremotetransport:///')
1335
567
        client = FakeClient(transport.base)
1336
568
        client.add_expected_call(
1337
 
            'Branch.get_stacked_on_url', ('stacked/',),
1338
 
            'success', ('ok', vfs_url))
1339
 
        # XXX: Multiple calls are bad, this second call documents what is
1340
 
        # today.
1341
 
        client.add_expected_call(
1342
 
            'Branch.get_stacked_on_url', ('stacked/',),
1343
 
            'success', ('ok', vfs_url))
1344
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
1345
 
            _client=client)
1346
 
        repo_fmt = remote.RemoteRepositoryFormat()
1347
 
        repo_fmt._custom_format = stacked_branch.repository._format
1348
 
        branch = RemoteBranch(bzrdir, RemoteRepository(bzrdir, repo_fmt),
1349
 
            _client=client)
 
569
            'Branch.get_stacked_on_url', ('.',),
 
570
            'success', ('ok', 'file:///stacked/on'))
 
571
        bzrdir = RemoteBzrDir(transport, _client=client)
 
572
        branch = RemoteBranch(bzrdir, None, _client=client)
1350
573
        result = branch.get_stacked_on_url()
1351
 
        self.assertEqual(vfs_url, result)
 
574
        self.assertEqual(
 
575
            'file:///stacked/on', result)
1352
576
 
1353
577
    def test_backwards_compatible(self):
1354
578
        # like with bzr1.6 with no Branch.get_stacked_on_url rpc
1356
580
        stacked_branch = self.make_branch('stacked', format='1.6')
1357
581
        stacked_branch.set_stacked_on_url('../base')
1358
582
        client = FakeClient(self.get_url())
1359
 
        branch_network_name = self.get_branch_format().network_name()
1360
 
        client.add_expected_call(
1361
 
            'BzrDir.open_branchV3', ('stacked/',),
1362
 
            'success', ('branch', branch_network_name))
1363
 
        client.add_expected_call(
1364
 
            'BzrDir.find_repositoryV3', ('stacked/',),
1365
 
            'success', ('ok', '', 'no', 'no', 'yes',
1366
 
                stacked_branch.repository._format.network_name()))
 
583
        client.add_expected_call(
 
584
            'BzrDir.open_branch', ('stacked/',),
 
585
            'success', ('ok', ''))
 
586
        client.add_expected_call(
 
587
            'BzrDir.find_repositoryV2', ('stacked/',),
 
588
            'success', ('ok', '', 'no', 'no', 'no'))
1367
589
        # called twice, once from constructor and then again by us
1368
590
        client.add_expected_call(
1369
591
            'Branch.get_stacked_on_url', ('stacked/',),
1373
595
            'unknown', ('Branch.get_stacked_on_url',))
1374
596
        # this will also do vfs access, but that goes direct to the transport
1375
597
        # and isn't seen by the FakeClient.
1376
 
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1377
 
            RemoteBzrDirFormat(), _client=client)
 
598
        bzrdir = RemoteBzrDir(self.get_transport('stacked'), _client=client)
1378
599
        branch = bzrdir.open_branch()
1379
600
        result = branch.get_stacked_on_url()
1380
601
        self.assertEqual('../base', result)
1381
 
        self.assertFinished(client)
 
602
        client.finished_test()
1382
603
        # it's in the fallback list both for the RemoteRepository and its vfs
1383
604
        # repository
1384
605
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1386
607
            len(branch.repository._real_repository._fallback_repositories))
1387
608
 
1388
609
    def test_get_stacked_on_real_branch(self):
1389
 
        base_branch = self.make_branch('base')
1390
 
        stacked_branch = self.make_branch('stacked')
 
610
        base_branch = self.make_branch('base', format='1.6')
 
611
        stacked_branch = self.make_branch('stacked', format='1.6')
1391
612
        stacked_branch.set_stacked_on_url('../base')
1392
 
        reference_format = self.get_repo_format()
1393
 
        network_name = reference_format.network_name()
1394
613
        client = FakeClient(self.get_url())
1395
 
        branch_network_name = self.get_branch_format().network_name()
1396
 
        client.add_expected_call(
1397
 
            'BzrDir.open_branchV3', ('stacked/',),
1398
 
            'success', ('branch', branch_network_name))
1399
 
        client.add_expected_call(
1400
 
            'BzrDir.find_repositoryV3', ('stacked/',),
1401
 
            'success', ('ok', '', 'yes', 'no', 'yes', network_name))
 
614
        client.add_expected_call(
 
615
            'BzrDir.open_branch', ('stacked/',),
 
616
            'success', ('ok', ''))
 
617
        client.add_expected_call(
 
618
            'BzrDir.find_repositoryV2', ('stacked/',),
 
619
            'success', ('ok', '', 'no', 'no', 'no'))
1402
620
        # called twice, once from constructor and then again by us
1403
621
        client.add_expected_call(
1404
622
            'Branch.get_stacked_on_url', ('stacked/',),
1406
624
        client.add_expected_call(
1407
625
            'Branch.get_stacked_on_url', ('stacked/',),
1408
626
            'success', ('ok', '../base'))
1409
 
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1410
 
            RemoteBzrDirFormat(), _client=client)
 
627
        bzrdir = RemoteBzrDir(self.get_transport('stacked'), _client=client)
1411
628
        branch = bzrdir.open_branch()
1412
629
        result = branch.get_stacked_on_url()
1413
630
        self.assertEqual('../base', result)
1414
 
        self.assertFinished(client)
1415
 
        # it's in the fallback list both for the RemoteRepository.
 
631
        client.finished_test()
 
632
        # it's in the fallback list both for the RemoteRepository and its vfs
 
633
        # repository
1416
634
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1417
 
        # And we haven't had to construct a real repository.
1418
 
        self.assertEqual(None, branch.repository._real_repository)
 
635
        self.assertEqual(1,
 
636
            len(branch.repository._real_repository._fallback_repositories))
1419
637
 
1420
638
 
1421
639
class TestBranchSetLastRevision(RemoteBranchTestCase):
1422
640
 
1423
641
    def test_set_empty(self):
1424
 
        # _set_last_revision_info('null:') is translated to calling
 
642
        # set_revision_history([]) is translated to calling
1425
643
        # Branch.set_last_revision(path, '') on the wire.
1426
644
        transport = MemoryTransport()
1427
645
        transport.mkdir('branch')
1435
653
            'Branch.lock_write', ('branch/', '', ''),
1436
654
            'success', ('ok', 'branch token', 'repo token'))
1437
655
        client.add_expected_call(
1438
 
            'Branch.last_revision_info',
1439
 
            ('branch/',),
1440
 
            'success', ('ok', '0', 'null:'))
1441
 
        client.add_expected_call(
1442
656
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'null:',),
1443
657
            'success', ('ok',))
1444
658
        client.add_expected_call(
1449
663
        # unnecessarily invokes _ensure_real upon a call to lock_write.
1450
664
        branch._ensure_real = lambda: None
1451
665
        branch.lock_write()
1452
 
        result = branch._set_last_revision(NULL_REVISION)
 
666
        result = branch.set_revision_history([])
1453
667
        branch.unlock()
1454
668
        self.assertEqual(None, result)
1455
 
        self.assertFinished(client)
 
669
        client.finished_test()
1456
670
 
1457
671
    def test_set_nonempty(self):
1458
 
        # set_last_revision_info(N, rev-idN) is translated to calling
 
672
        # set_revision_history([rev-id1, ..., rev-idN]) is translated to calling
1459
673
        # Branch.set_last_revision(path, rev-idN) on the wire.
1460
674
        transport = MemoryTransport()
1461
675
        transport.mkdir('branch')
1469
683
            'Branch.lock_write', ('branch/', '', ''),
1470
684
            'success', ('ok', 'branch token', 'repo token'))
1471
685
        client.add_expected_call(
1472
 
            'Branch.last_revision_info',
1473
 
            ('branch/',),
1474
 
            'success', ('ok', '0', 'null:'))
1475
 
        lines = ['rev-id2']
1476
 
        encoded_body = bz2.compress('\n'.join(lines))
1477
 
        client.add_success_response_with_body(encoded_body, 'ok')
1478
 
        client.add_expected_call(
1479
686
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id2',),
1480
687
            'success', ('ok',))
1481
688
        client.add_expected_call(
1487
694
        branch._ensure_real = lambda: None
1488
695
        # Lock the branch, reset the record of remote calls.
1489
696
        branch.lock_write()
1490
 
        result = branch._set_last_revision('rev-id2')
 
697
        result = branch.set_revision_history(['rev-id1', 'rev-id2'])
1491
698
        branch.unlock()
1492
699
        self.assertEqual(None, result)
1493
 
        self.assertFinished(client)
 
700
        client.finished_test()
1494
701
 
1495
702
    def test_no_such_revision(self):
1496
703
        transport = MemoryTransport()
1505
712
            'Branch.lock_write', ('branch/', '', ''),
1506
713
            'success', ('ok', 'branch token', 'repo token'))
1507
714
        client.add_expected_call(
1508
 
            'Branch.last_revision_info',
1509
 
            ('branch/',),
1510
 
            'success', ('ok', '0', 'null:'))
1511
 
        # get_graph calls to construct the revision history, for the set_rh
1512
 
        # hook
1513
 
        lines = ['rev-id']
1514
 
        encoded_body = bz2.compress('\n'.join(lines))
1515
 
        client.add_success_response_with_body(encoded_body, 'ok')
1516
 
        client.add_expected_call(
1517
715
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id',),
1518
716
            'error', ('NoSuchRevision', 'rev-id'))
1519
717
        client.add_expected_call(
1523
721
        branch = self.make_remote_branch(transport, client)
1524
722
        branch.lock_write()
1525
723
        self.assertRaises(
1526
 
            errors.NoSuchRevision, branch._set_last_revision, 'rev-id')
 
724
            errors.NoSuchRevision, branch.set_revision_history, ['rev-id'])
1527
725
        branch.unlock()
1528
 
        self.assertFinished(client)
 
726
        client.finished_test()
1529
727
 
1530
728
    def test_tip_change_rejected(self):
1531
729
        """TipChangeRejected responses cause a TipChangeRejected exception to
1544
742
            'Branch.lock_write', ('branch/', '', ''),
1545
743
            'success', ('ok', 'branch token', 'repo token'))
1546
744
        client.add_expected_call(
1547
 
            'Branch.last_revision_info',
1548
 
            ('branch/',),
1549
 
            'success', ('ok', '0', 'null:'))
1550
 
        lines = ['rev-id']
1551
 
        encoded_body = bz2.compress('\n'.join(lines))
1552
 
        client.add_success_response_with_body(encoded_body, 'ok')
1553
 
        client.add_expected_call(
1554
745
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id',),
1555
746
            'error', ('TipChangeRejected', rejection_msg_utf8))
1556
747
        client.add_expected_call(
1559
750
        branch = self.make_remote_branch(transport, client)
1560
751
        branch._ensure_real = lambda: None
1561
752
        branch.lock_write()
 
753
        self.addCleanup(branch.unlock)
1562
754
        # The 'TipChangeRejected' error response triggered by calling
1563
 
        # set_last_revision_info causes a TipChangeRejected exception.
 
755
        # set_revision_history causes a TipChangeRejected exception.
1564
756
        err = self.assertRaises(
1565
 
            errors.TipChangeRejected,
1566
 
            branch._set_last_revision, 'rev-id')
 
757
            errors.TipChangeRejected, branch.set_revision_history, ['rev-id'])
1567
758
        # The UTF-8 message from the response has been decoded into a unicode
1568
759
        # object.
1569
760
        self.assertIsInstance(err.msg, unicode)
1570
761
        self.assertEqual(rejection_msg_unicode, err.msg)
1571
762
        branch.unlock()
1572
 
        self.assertFinished(client)
 
763
        client.finished_test()
1573
764
 
1574
765
 
1575
766
class TestBranchSetLastRevisionInfo(RemoteBranchTestCase):
1585
776
        client.add_error_response('NotStacked')
1586
777
        # lock_write
1587
778
        client.add_success_response('ok', 'branch token', 'repo token')
1588
 
        # query the current revision
1589
 
        client.add_success_response('ok', '0', 'null:')
1590
779
        # set_last_revision
1591
780
        client.add_success_response('ok')
1592
781
        # unlock
1598
787
        client._calls = []
1599
788
        result = branch.set_last_revision_info(1234, 'a-revision-id')
1600
789
        self.assertEqual(
1601
 
            [('call', 'Branch.last_revision_info', ('branch/',)),
1602
 
             ('call', 'Branch.set_last_revision_info',
 
790
            [('call', 'Branch.set_last_revision_info',
1603
791
                ('branch/', 'branch token', 'repo token',
1604
792
                 '1234', 'a-revision-id'))],
1605
793
            client._calls)
1629
817
            errors.NoSuchRevision, branch.set_last_revision_info, 123, 'revid')
1630
818
        branch.unlock()
1631
819
 
 
820
    def lock_remote_branch(self, branch):
 
821
        """Trick a RemoteBranch into thinking it is locked."""
 
822
        branch._lock_mode = 'w'
 
823
        branch._lock_count = 2
 
824
        branch._lock_token = 'branch token'
 
825
        branch._repo_lock_token = 'repo token'
 
826
        branch.repository._lock_mode = 'w'
 
827
        branch.repository._lock_count = 2
 
828
        branch.repository._lock_token = 'repo token'
 
829
 
1632
830
    def test_backwards_compatibility(self):
1633
831
        """If the server does not support the Branch.set_last_revision_info
1634
832
        verb (which is new in 1.4), then the client falls back to VFS methods.
1649
847
            'Branch.get_stacked_on_url', ('branch/',),
1650
848
            'error', ('NotStacked',))
1651
849
        client.add_expected_call(
1652
 
            'Branch.last_revision_info',
1653
 
            ('branch/',),
1654
 
            'success', ('ok', '0', 'null:'))
1655
 
        client.add_expected_call(
1656
850
            'Branch.set_last_revision_info',
1657
851
            ('branch/', 'branch token', 'repo token', '1234', 'a-revision-id',),
1658
852
            'unknown', 'Branch.set_last_revision_info')
1675
869
        self.assertEqual(
1676
870
            [('set_last_revision_info', 1234, 'a-revision-id')],
1677
871
            real_branch.calls)
1678
 
        self.assertFinished(client)
 
872
        client.finished_test()
1679
873
 
1680
874
    def test_unexpected_error(self):
1681
875
        # If the server sends an error the client doesn't understand, it gets
1736
930
        self.assertEqual('rejection message', err.msg)
1737
931
 
1738
932
 
1739
 
class TestBranchGetSetConfig(RemoteBranchTestCase):
 
933
class TestBranchControlGetBranchConf(tests.TestCaseWithMemoryTransport):
 
934
    """Getting the branch configuration should use an abstract method not vfs.
 
935
    """
1740
936
 
1741
937
    def test_get_branch_conf(self):
1742
 
        # in an empty branch we decode the response properly
1743
 
        client = FakeClient()
1744
 
        client.add_expected_call(
1745
 
            'Branch.get_stacked_on_url', ('memory:///',),
1746
 
            'error', ('NotStacked',),)
1747
 
        client.add_success_response_with_body('# config file body', 'ok')
1748
 
        transport = MemoryTransport()
1749
 
        branch = self.make_remote_branch(transport, client)
1750
 
        config = branch.get_config()
1751
 
        config.has_explicit_nickname()
1752
 
        self.assertEqual(
1753
 
            [('call', 'Branch.get_stacked_on_url', ('memory:///',)),
1754
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',))],
1755
 
            client._calls)
1756
 
 
1757
 
    def test_get_multi_line_branch_conf(self):
1758
 
        # Make sure that multiple-line branch.conf files are supported
1759
 
        #
1760
 
        # https://bugs.launchpad.net/bzr/+bug/354075
1761
 
        client = FakeClient()
1762
 
        client.add_expected_call(
1763
 
            'Branch.get_stacked_on_url', ('memory:///',),
1764
 
            'error', ('NotStacked',),)
1765
 
        client.add_success_response_with_body('a = 1\nb = 2\nc = 3\n', 'ok')
1766
 
        transport = MemoryTransport()
1767
 
        branch = self.make_remote_branch(transport, client)
1768
 
        config = branch.get_config()
1769
 
        self.assertEqual(u'2', config.get_user_option('b'))
1770
 
 
1771
 
    def test_set_option(self):
1772
 
        client = FakeClient()
1773
 
        client.add_expected_call(
1774
 
            'Branch.get_stacked_on_url', ('memory:///',),
1775
 
            'error', ('NotStacked',),)
1776
 
        client.add_expected_call(
1777
 
            'Branch.lock_write', ('memory:///', '', ''),
1778
 
            'success', ('ok', 'branch token', 'repo token'))
1779
 
        client.add_expected_call(
1780
 
            'Branch.set_config_option', ('memory:///', 'branch token',
1781
 
            'repo token', 'foo', 'bar', ''),
1782
 
            'success', ())
1783
 
        client.add_expected_call(
1784
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1785
 
            'success', ('ok',))
1786
 
        transport = MemoryTransport()
1787
 
        branch = self.make_remote_branch(transport, client)
1788
 
        branch.lock_write()
1789
 
        config = branch._get_config()
1790
 
        config.set_option('foo', 'bar')
1791
 
        branch.unlock()
1792
 
        self.assertFinished(client)
1793
 
 
1794
 
    def test_set_option_with_dict(self):
1795
 
        client = FakeClient()
1796
 
        client.add_expected_call(
1797
 
            'Branch.get_stacked_on_url', ('memory:///',),
1798
 
            'error', ('NotStacked',),)
1799
 
        client.add_expected_call(
1800
 
            'Branch.lock_write', ('memory:///', '', ''),
1801
 
            'success', ('ok', 'branch token', 'repo token'))
1802
 
        encoded_dict_value = 'd5:ascii1:a11:unicode \xe2\x8c\x9a3:\xe2\x80\xbde'
1803
 
        client.add_expected_call(
1804
 
            'Branch.set_config_option_dict', ('memory:///', 'branch token',
1805
 
            'repo token', encoded_dict_value, 'foo', ''),
1806
 
            'success', ())
1807
 
        client.add_expected_call(
1808
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1809
 
            'success', ('ok',))
1810
 
        transport = MemoryTransport()
1811
 
        branch = self.make_remote_branch(transport, client)
1812
 
        branch.lock_write()
1813
 
        config = branch._get_config()
1814
 
        config.set_option(
1815
 
            {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'},
1816
 
            'foo')
1817
 
        branch.unlock()
1818
 
        self.assertFinished(client)
1819
 
 
1820
 
    def test_backwards_compat_set_option(self):
1821
 
        self.setup_smart_server_with_call_log()
1822
 
        branch = self.make_branch('.')
1823
 
        verb = 'Branch.set_config_option'
1824
 
        self.disable_verb(verb)
1825
 
        branch.lock_write()
1826
 
        self.addCleanup(branch.unlock)
1827
 
        self.reset_smart_call_log()
1828
 
        branch._get_config().set_option('value', 'name')
1829
 
        self.assertLength(10, self.hpss_calls)
1830
 
        self.assertEqual('value', branch._get_config().get_option('name'))
1831
 
 
1832
 
    def test_backwards_compat_set_option_with_dict(self):
1833
 
        self.setup_smart_server_with_call_log()
1834
 
        branch = self.make_branch('.')
1835
 
        verb = 'Branch.set_config_option_dict'
1836
 
        self.disable_verb(verb)
1837
 
        branch.lock_write()
1838
 
        self.addCleanup(branch.unlock)
1839
 
        self.reset_smart_call_log()
1840
 
        config = branch._get_config()
1841
 
        value_dict = {'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'}
1842
 
        config.set_option(value_dict, 'name')
1843
 
        self.assertLength(10, self.hpss_calls)
1844
 
        self.assertEqual(value_dict, branch._get_config().get_option('name'))
 
938
        raise tests.KnownFailure('branch.conf is not retrieved by get_config_file')
 
939
        ## # We should see that branch.get_config() does a single rpc to get the
 
940
        ## # remote configuration file, abstracting away where that is stored on
 
941
        ## # the server.  However at the moment it always falls back to using the
 
942
        ## # vfs, and this would need some changes in config.py.
 
943
 
 
944
        ## # in an empty branch we decode the response properly
 
945
        ## client = FakeClient([(('ok', ), '# config file body')], self.get_url())
 
946
        ## # we need to make a real branch because the remote_branch.control_files
 
947
        ## # will trigger _ensure_real.
 
948
        ## branch = self.make_branch('quack')
 
949
        ## transport = branch.bzrdir.root_transport
 
950
        ## # we do not want bzrdir to make any remote calls
 
951
        ## bzrdir = RemoteBzrDir(transport, _client=False)
 
952
        ## branch = RemoteBranch(bzrdir, None, _client=client)
 
953
        ## config = branch.get_config()
 
954
        ## self.assertEqual(
 
955
        ##     [('call_expecting_body', 'Branch.get_config_file', ('quack/',))],
 
956
        ##     client._calls)
1845
957
 
1846
958
 
1847
959
class TestBranchLockWrite(RemoteBranchTestCase):
1859
971
        transport = transport.clone('quack')
1860
972
        branch = self.make_remote_branch(transport, client)
1861
973
        self.assertRaises(errors.UnlockableTransport, branch.lock_write)
1862
 
        self.assertFinished(client)
1863
 
 
1864
 
 
1865
 
class TestBzrDirGetSetConfig(RemoteBzrDirTestCase):
1866
 
 
1867
 
    def test__get_config(self):
1868
 
        client = FakeClient()
1869
 
        client.add_success_response_with_body('default_stack_on = /\n', 'ok')
1870
 
        transport = MemoryTransport()
1871
 
        bzrdir = self.make_remote_bzrdir(transport, client)
1872
 
        config = bzrdir.get_config()
1873
 
        self.assertEqual('/', config.get_default_stack_on())
1874
 
        self.assertEqual(
1875
 
            [('call_expecting_body', 'BzrDir.get_config_file', ('memory:///',))],
1876
 
            client._calls)
1877
 
 
1878
 
    def test_set_option_uses_vfs(self):
1879
 
        self.setup_smart_server_with_call_log()
1880
 
        bzrdir = self.make_bzrdir('.')
1881
 
        self.reset_smart_call_log()
1882
 
        config = bzrdir.get_config()
1883
 
        config.set_default_stack_on('/')
1884
 
        self.assertLength(3, self.hpss_calls)
1885
 
 
1886
 
    def test_backwards_compat_get_option(self):
1887
 
        self.setup_smart_server_with_call_log()
1888
 
        bzrdir = self.make_bzrdir('.')
1889
 
        verb = 'BzrDir.get_config_file'
1890
 
        self.disable_verb(verb)
1891
 
        self.reset_smart_call_log()
1892
 
        self.assertEqual(None,
1893
 
            bzrdir._get_config().get_option('default_stack_on'))
1894
 
        self.assertLength(3, self.hpss_calls)
 
974
        client.finished_test()
1895
975
 
1896
976
 
1897
977
class TestTransportIsReadonly(tests.TestCase):
1918
998
 
1919
999
    def test_error_from_old_server(self):
1920
1000
        """bzr 0.15 and earlier servers don't recognise the is_readonly verb.
1921
 
 
 
1001
        
1922
1002
        Clients should treat it as a "no" response, because is_readonly is only
1923
1003
        advisory anyway (a transport could be read-write, but then the
1924
1004
        underlying filesystem could be readonly anyway).
1962
1042
        self.assertEqual('bar', t._get_credentials()[0])
1963
1043
 
1964
1044
 
1965
 
class TestRemoteRepository(TestRemote):
 
1045
class TestRemoteRepository(tests.TestCase):
1966
1046
    """Base for testing RemoteRepository protocol usage.
1967
 
 
1968
 
    These tests contain frozen requests and responses.  We want any changes to
 
1047
    
 
1048
    These tests contain frozen requests and responses.  We want any changes to 
1969
1049
    what is sent or expected to be require a thoughtful update to these tests
1970
1050
    because they might break compatibility with different-versioned servers.
1971
1051
    """
1972
1052
 
1973
1053
    def setup_fake_client_and_repository(self, transport_path):
1974
1054
        """Create the fake client and repository for testing with.
1975
 
 
 
1055
        
1976
1056
        There's no real server here; we just have canned responses sent
1977
1057
        back one by one.
1978
 
 
 
1058
        
1979
1059
        :param transport_path: Path below the root of the MemoryTransport
1980
1060
            where the repository will be created.
1981
1061
        """
1984
1064
        client = FakeClient(transport.base)
1985
1065
        transport = transport.clone(transport_path)
1986
1066
        # we do not want bzrdir to make any remote calls
1987
 
        bzrdir = RemoteBzrDir(transport, RemoteBzrDirFormat(),
1988
 
            _client=False)
 
1067
        bzrdir = RemoteBzrDir(transport, _client=False)
1989
1068
        repo = RemoteRepository(bzrdir, None, _client=client)
1990
1069
        return repo, client
1991
1070
 
1992
1071
 
1993
 
def remoted_description(format):
1994
 
    return 'Remote: ' + format.get_format_description()
1995
 
 
1996
 
 
1997
 
class TestBranchFormat(tests.TestCase):
1998
 
 
1999
 
    def test_get_format_description(self):
2000
 
        remote_format = RemoteBranchFormat()
2001
 
        real_format = branch.format_registry.get_default()
2002
 
        remote_format._network_name = real_format.network_name()
2003
 
        self.assertEqual(remoted_description(real_format),
2004
 
            remote_format.get_format_description())
2005
 
 
2006
 
 
2007
 
class TestRepositoryFormat(TestRemoteRepository):
2008
 
 
2009
 
    def test_fast_delta(self):
2010
 
        true_name = groupcompress_repo.RepositoryFormat2a().network_name()
2011
 
        true_format = RemoteRepositoryFormat()
2012
 
        true_format._network_name = true_name
2013
 
        self.assertEqual(True, true_format.fast_deltas)
2014
 
        false_name = knitpack_repo.RepositoryFormatKnitPack1().network_name()
2015
 
        false_format = RemoteRepositoryFormat()
2016
 
        false_format._network_name = false_name
2017
 
        self.assertEqual(False, false_format.fast_deltas)
2018
 
 
2019
 
    def test_get_format_description(self):
2020
 
        remote_repo_format = RemoteRepositoryFormat()
2021
 
        real_format = repository.format_registry.get_default()
2022
 
        remote_repo_format._network_name = real_format.network_name()
2023
 
        self.assertEqual(remoted_description(real_format),
2024
 
            remote_repo_format.get_format_description())
2025
 
 
2026
 
 
2027
1072
class TestRepositoryGatherStats(TestRemoteRepository):
2028
1073
 
2029
1074
    def test_revid_none(self):
2117
1162
        self.assertEqual({r1: (NULL_REVISION,)}, parents)
2118
1163
        self.assertEqual(
2119
1164
            [('call_with_body_bytes_expecting_body',
2120
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
2121
 
              '\n\n0')],
 
1165
              'Repository.get_parent_map', ('quack/', r2), '\n\n0')],
2122
1166
            client._calls)
2123
1167
        repo.unlock()
2124
1168
        # now we call again, and it should use the second response.
2128
1172
        self.assertEqual({r1: (NULL_REVISION,)}, parents)
2129
1173
        self.assertEqual(
2130
1174
            [('call_with_body_bytes_expecting_body',
2131
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
2132
 
              '\n\n0'),
 
1175
              'Repository.get_parent_map', ('quack/', r2), '\n\n0'),
2133
1176
             ('call_with_body_bytes_expecting_body',
2134
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r1),
2135
 
              '\n\n0'),
 
1177
              'Repository.get_parent_map', ('quack/', r1), '\n\n0'),
2136
1178
            ],
2137
1179
            client._calls)
2138
1180
        repo.unlock()
2139
1181
 
2140
1182
    def test_get_parent_map_reconnects_if_unknown_method(self):
2141
1183
        transport_path = 'quack'
2142
 
        rev_id = 'revision-id'
2143
1184
        repo, client = self.setup_fake_client_and_repository(transport_path)
2144
 
        client.add_unknown_method_response('Repository.get_parent_map')
2145
 
        client.add_success_response_with_body(rev_id, 'ok')
 
1185
        client.add_unknown_method_response('Repository,get_parent_map')
 
1186
        client.add_success_response_with_body('', 'ok')
2146
1187
        self.assertFalse(client._medium._is_remote_before((1, 2)))
2147
 
        parents = repo.get_parent_map([rev_id])
 
1188
        rev_id = 'revision-id'
 
1189
        expected_deprecations = [
 
1190
            'bzrlib.remote.RemoteRepository.get_revision_graph was deprecated '
 
1191
            'in version 1.4.']
 
1192
        parents = self.callDeprecated(
 
1193
            expected_deprecations, repo.get_parent_map, [rev_id])
2148
1194
        self.assertEqual(
2149
1195
            [('call_with_body_bytes_expecting_body',
2150
 
              'Repository.get_parent_map',
2151
 
              ('quack/', 'include-missing:', rev_id), '\n\n0'),
 
1196
              'Repository.get_parent_map', ('quack/', rev_id), '\n\n0'),
2152
1197
             ('disconnect medium',),
2153
1198
             ('call_expecting_body', 'Repository.get_revision_graph',
2154
1199
              ('quack/', ''))],
2155
1200
            client._calls)
2156
1201
        # The medium is now marked as being connected to an older server
2157
1202
        self.assertTrue(client._medium._is_remote_before((1, 2)))
2158
 
        self.assertEqual({rev_id: ('null:',)}, parents)
2159
1203
 
2160
1204
    def test_get_parent_map_fallback_parentless_node(self):
2161
1205
        """get_parent_map falls back to get_revision_graph on old servers.  The
2173
1217
        repo, client = self.setup_fake_client_and_repository(transport_path)
2174
1218
        client.add_success_response_with_body(rev_id, 'ok')
2175
1219
        client._medium._remember_remote_is_before((1, 2))
2176
 
        parents = repo.get_parent_map([rev_id])
 
1220
        expected_deprecations = [
 
1221
            'bzrlib.remote.RemoteRepository.get_revision_graph was deprecated '
 
1222
            'in version 1.4.']
 
1223
        parents = self.callDeprecated(
 
1224
            expected_deprecations, repo.get_parent_map, [rev_id])
2177
1225
        self.assertEqual(
2178
1226
            [('call_expecting_body', 'Repository.get_revision_graph',
2179
1227
             ('quack/', ''))],
2187
1235
            errors.UnexpectedSmartServerResponse,
2188
1236
            repo.get_parent_map, ['a-revision-id'])
2189
1237
 
2190
 
    def test_get_parent_map_negative_caches_missing_keys(self):
2191
 
        self.setup_smart_server_with_call_log()
2192
 
        repo = self.make_repository('foo')
2193
 
        self.assertIsInstance(repo, RemoteRepository)
2194
 
        repo.lock_read()
2195
 
        self.addCleanup(repo.unlock)
2196
 
        self.reset_smart_call_log()
2197
 
        graph = repo.get_graph()
2198
 
        self.assertEqual({},
2199
 
            graph.get_parent_map(['some-missing', 'other-missing']))
2200
 
        self.assertLength(1, self.hpss_calls)
2201
 
        # No call if we repeat this
2202
 
        self.reset_smart_call_log()
2203
 
        graph = repo.get_graph()
2204
 
        self.assertEqual({},
2205
 
            graph.get_parent_map(['some-missing', 'other-missing']))
2206
 
        self.assertLength(0, self.hpss_calls)
2207
 
        # Asking for more unknown keys makes a request.
2208
 
        self.reset_smart_call_log()
2209
 
        graph = repo.get_graph()
2210
 
        self.assertEqual({},
2211
 
            graph.get_parent_map(['some-missing', 'other-missing',
2212
 
                'more-missing']))
2213
 
        self.assertLength(1, self.hpss_calls)
2214
 
 
2215
 
    def disableExtraResults(self):
2216
 
        self.overrideAttr(SmartServerRepositoryGetParentMap,
2217
 
                          'no_extra_results', True)
2218
 
 
2219
 
    def test_null_cached_missing_and_stop_key(self):
2220
 
        self.setup_smart_server_with_call_log()
2221
 
        # Make a branch with a single revision.
2222
 
        builder = self.make_branch_builder('foo')
2223
 
        builder.start_series()
2224
 
        builder.build_snapshot('first', None, [
2225
 
            ('add', ('', 'root-id', 'directory', ''))])
2226
 
        builder.finish_series()
2227
 
        branch = builder.get_branch()
2228
 
        repo = branch.repository
2229
 
        self.assertIsInstance(repo, RemoteRepository)
2230
 
        # Stop the server from sending extra results.
2231
 
        self.disableExtraResults()
2232
 
        repo.lock_read()
2233
 
        self.addCleanup(repo.unlock)
2234
 
        self.reset_smart_call_log()
2235
 
        graph = repo.get_graph()
2236
 
        # Query for 'first' and 'null:'.  Because 'null:' is a parent of
2237
 
        # 'first' it will be a candidate for the stop_keys of subsequent
2238
 
        # requests, and because 'null:' was queried but not returned it will be
2239
 
        # cached as missing.
2240
 
        self.assertEqual({'first': ('null:',)},
2241
 
            graph.get_parent_map(['first', 'null:']))
2242
 
        # Now query for another key.  This request will pass along a recipe of
2243
 
        # start and stop keys describing the already cached results, and this
2244
 
        # recipe's revision count must be correct (or else it will trigger an
2245
 
        # error from the server).
2246
 
        self.assertEqual({}, graph.get_parent_map(['another-key']))
2247
 
        # This assertion guards against disableExtraResults silently failing to
2248
 
        # work, thus invalidating the test.
2249
 
        self.assertLength(2, self.hpss_calls)
2250
 
 
2251
 
    def test_get_parent_map_gets_ghosts_from_result(self):
2252
 
        # asking for a revision should negatively cache close ghosts in its
2253
 
        # ancestry.
2254
 
        self.setup_smart_server_with_call_log()
2255
 
        tree = self.make_branch_and_memory_tree('foo')
2256
 
        tree.lock_write()
2257
 
        try:
2258
 
            builder = treebuilder.TreeBuilder()
2259
 
            builder.start_tree(tree)
2260
 
            builder.build([])
2261
 
            builder.finish_tree()
2262
 
            tree.set_parent_ids(['non-existant'], allow_leftmost_as_ghost=True)
2263
 
            rev_id = tree.commit('')
2264
 
        finally:
2265
 
            tree.unlock()
2266
 
        tree.lock_read()
2267
 
        self.addCleanup(tree.unlock)
2268
 
        repo = tree.branch.repository
2269
 
        self.assertIsInstance(repo, RemoteRepository)
2270
 
        # ask for rev_id
2271
 
        repo.get_parent_map([rev_id])
2272
 
        self.reset_smart_call_log()
2273
 
        # Now asking for rev_id's ghost parent should not make calls
2274
 
        self.assertEqual({}, repo.get_parent_map(['non-existant']))
2275
 
        self.assertLength(0, self.hpss_calls)
2276
 
 
2277
 
    def test_exposes_get_cached_parent_map(self):
2278
 
        """RemoteRepository exposes get_cached_parent_map from
2279
 
        _unstacked_provider
2280
 
        """
2281
 
        r1 = u'\u0e33'.encode('utf8')
2282
 
        r2 = u'\u0dab'.encode('utf8')
2283
 
        lines = [' '.join([r2, r1]), r1]
2284
 
        encoded_body = bz2.compress('\n'.join(lines))
2285
 
 
2286
 
        transport_path = 'quack'
2287
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2288
 
        client.add_success_response_with_body(encoded_body, 'ok')
2289
 
        repo.lock_read()
2290
 
        # get_cached_parent_map should *not* trigger an RPC
2291
 
        self.assertEqual({}, repo.get_cached_parent_map([r1]))
2292
 
        self.assertEqual([], client._calls)
2293
 
        self.assertEqual({r2: (r1,)}, repo.get_parent_map([r2]))
2294
 
        self.assertEqual({r1: (NULL_REVISION,)},
2295
 
            repo.get_cached_parent_map([r1]))
2296
 
        self.assertEqual(
2297
 
            [('call_with_body_bytes_expecting_body',
2298
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
2299
 
              '\n\n0')],
2300
 
            client._calls)
2301
 
        repo.unlock()
2302
 
 
2303
1238
 
2304
1239
class TestGetParentMapAllowsNew(tests.TestCaseWithTransport):
2305
1240
 
2306
1241
    def test_allows_new_revisions(self):
2307
1242
        """get_parent_map's results can be updated by commit."""
2308
 
        smart_server = test_server.SmartTCPServer_for_testing()
2309
 
        self.start_server(smart_server)
 
1243
        smart_server = server.SmartTCPServer_for_testing()
 
1244
        smart_server.setUp()
 
1245
        self.addCleanup(smart_server.tearDown)
2310
1246
        self.make_branch('branch')
2311
1247
        branch = Branch.open(smart_server.get_url() + '/branch')
2312
1248
        tree = branch.create_checkout('tree', lightweight=True)
2321
1257
 
2322
1258
 
2323
1259
class TestRepositoryGetRevisionGraph(TestRemoteRepository):
2324
 
 
 
1260
    
2325
1261
    def test_null_revision(self):
2326
1262
        # a null revision has the predictable result {}, we should have no wire
2327
1263
        # traffic when calling it with this argument
2328
1264
        transport_path = 'empty'
2329
1265
        repo, client = self.setup_fake_client_and_repository(transport_path)
2330
1266
        client.add_success_response('notused')
2331
 
        # actual RemoteRepository.get_revision_graph is gone, but there's an
2332
 
        # equivalent private method for testing
2333
 
        result = repo._get_revision_graph(NULL_REVISION)
 
1267
        result = self.applyDeprecated(one_four, repo.get_revision_graph,
 
1268
            NULL_REVISION)
2334
1269
        self.assertEqual([], client._calls)
2335
1270
        self.assertEqual({}, result)
2336
1271
 
2344
1279
        transport_path = 'sinhala'
2345
1280
        repo, client = self.setup_fake_client_and_repository(transport_path)
2346
1281
        client.add_success_response_with_body(encoded_body, 'ok')
2347
 
        # actual RemoteRepository.get_revision_graph is gone, but there's an
2348
 
        # equivalent private method for testing
2349
 
        result = repo._get_revision_graph(None)
 
1282
        result = self.applyDeprecated(one_four, repo.get_revision_graph)
2350
1283
        self.assertEqual(
2351
1284
            [('call_expecting_body', 'Repository.get_revision_graph',
2352
1285
             ('sinhala/', ''))],
2365
1298
        transport_path = 'sinhala'
2366
1299
        repo, client = self.setup_fake_client_and_repository(transport_path)
2367
1300
        client.add_success_response_with_body(encoded_body, 'ok')
2368
 
        result = repo._get_revision_graph(r2)
 
1301
        result = self.applyDeprecated(one_four, repo.get_revision_graph, r2)
2369
1302
        self.assertEqual(
2370
1303
            [('call_expecting_body', 'Repository.get_revision_graph',
2371
1304
             ('sinhala/', r2))],
2379
1312
        client.add_error_response('nosuchrevision', revid)
2380
1313
        # also check that the right revision is reported in the error
2381
1314
        self.assertRaises(errors.NoSuchRevision,
2382
 
            repo._get_revision_graph, revid)
 
1315
            self.applyDeprecated, one_four, repo.get_revision_graph, revid)
2383
1316
        self.assertEqual(
2384
1317
            [('call_expecting_body', 'Repository.get_revision_graph',
2385
1318
             ('sinhala/', revid))],
2391
1324
        repo, client = self.setup_fake_client_and_repository(transport_path)
2392
1325
        client.add_error_response('AnUnexpectedError')
2393
1326
        e = self.assertRaises(errors.UnknownErrorFromSmartServer,
2394
 
            repo._get_revision_graph, revid)
 
1327
            self.applyDeprecated, one_four, repo.get_revision_graph, revid)
2395
1328
        self.assertEqual(('AnUnexpectedError',), e.error_tuple)
2396
1329
 
2397
 
 
2398
 
class TestRepositoryGetRevIdForRevno(TestRemoteRepository):
2399
 
 
2400
 
    def test_ok(self):
2401
 
        repo, client = self.setup_fake_client_and_repository('quack')
2402
 
        client.add_expected_call(
2403
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2404
 
            'success', ('ok', 'rev-five'))
2405
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2406
 
        self.assertEqual((True, 'rev-five'), result)
2407
 
        self.assertFinished(client)
2408
 
 
2409
 
    def test_history_incomplete(self):
2410
 
        repo, client = self.setup_fake_client_and_repository('quack')
2411
 
        client.add_expected_call(
2412
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2413
 
            'success', ('history-incomplete', 10, 'rev-ten'))
2414
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2415
 
        self.assertEqual((False, (10, 'rev-ten')), result)
2416
 
        self.assertFinished(client)
2417
 
 
2418
 
    def test_history_incomplete_with_fallback(self):
2419
 
        """A 'history-incomplete' response causes the fallback repository to be
2420
 
        queried too, if one is set.
2421
 
        """
2422
 
        # Make a repo with a fallback repo, both using a FakeClient.
2423
 
        format = remote.response_tuple_to_repo_format(
2424
 
            ('yes', 'no', 'yes', self.get_repo_format().network_name()))
2425
 
        repo, client = self.setup_fake_client_and_repository('quack')
2426
 
        repo._format = format
2427
 
        fallback_repo, ignored = self.setup_fake_client_and_repository(
2428
 
            'fallback')
2429
 
        fallback_repo._client = client
2430
 
        fallback_repo._format = format
2431
 
        repo.add_fallback_repository(fallback_repo)
2432
 
        # First the client should ask the primary repo
2433
 
        client.add_expected_call(
2434
 
            'Repository.get_rev_id_for_revno', ('quack/', 1, (42, 'rev-foo')),
2435
 
            'success', ('history-incomplete', 2, 'rev-two'))
2436
 
        # Then it should ask the fallback, using revno/revid from the
2437
 
        # history-incomplete response as the known revno/revid.
2438
 
        client.add_expected_call(
2439
 
            'Repository.get_rev_id_for_revno',('fallback/', 1, (2, 'rev-two')),
2440
 
            'success', ('ok', 'rev-one'))
2441
 
        result = repo.get_rev_id_for_revno(1, (42, 'rev-foo'))
2442
 
        self.assertEqual((True, 'rev-one'), result)
2443
 
        self.assertFinished(client)
2444
 
 
2445
 
    def test_nosuchrevision(self):
2446
 
        # 'nosuchrevision' is returned when the known-revid is not found in the
2447
 
        # remote repo.  The client translates that response to NoSuchRevision.
2448
 
        repo, client = self.setup_fake_client_and_repository('quack')
2449
 
        client.add_expected_call(
2450
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2451
 
            'error', ('nosuchrevision', 'rev-foo'))
2452
 
        self.assertRaises(
2453
 
            errors.NoSuchRevision,
2454
 
            repo.get_rev_id_for_revno, 5, (42, 'rev-foo'))
2455
 
        self.assertFinished(client)
2456
 
 
2457
 
    def test_branch_fallback_locking(self):
2458
 
        """RemoteBranch.get_rev_id takes a read lock, and tries to call the
2459
 
        get_rev_id_for_revno verb.  If the verb is unknown the VFS fallback
2460
 
        will be invoked, which will fail if the repo is unlocked.
2461
 
        """
2462
 
        self.setup_smart_server_with_call_log()
2463
 
        tree = self.make_branch_and_memory_tree('.')
2464
 
        tree.lock_write()
2465
 
        tree.add('')
2466
 
        rev1 = tree.commit('First')
2467
 
        rev2 = tree.commit('Second')
2468
 
        tree.unlock()
2469
 
        branch = tree.branch
2470
 
        self.assertFalse(branch.is_locked())
2471
 
        self.reset_smart_call_log()
2472
 
        verb = 'Repository.get_rev_id_for_revno'
2473
 
        self.disable_verb(verb)
2474
 
        self.assertEqual(rev1, branch.get_rev_id(1))
2475
 
        self.assertLength(1, [call for call in self.hpss_calls if
2476
 
                              call.call.method == verb])
2477
 
 
2478
 
 
 
1330
        
2479
1331
class TestRepositoryIsShared(TestRemoteRepository):
2480
1332
 
2481
1333
    def test_is_shared(self):
2507
1359
        transport_path = 'quack'
2508
1360
        repo, client = self.setup_fake_client_and_repository(transport_path)
2509
1361
        client.add_success_response('ok', 'a token')
2510
 
        token = repo.lock_write().repository_token
 
1362
        result = repo.lock_write()
2511
1363
        self.assertEqual(
2512
1364
            [('call', 'Repository.lock_write', ('quack/', ''))],
2513
1365
            client._calls)
2514
 
        self.assertEqual('a token', token)
 
1366
        self.assertEqual('a token', result)
2515
1367
 
2516
1368
    def test_lock_write_already_locked(self):
2517
1369
        transport_path = 'quack'
2532
1384
            client._calls)
2533
1385
 
2534
1386
 
2535
 
class TestRepositorySetMakeWorkingTrees(TestRemoteRepository):
2536
 
 
2537
 
    def test_backwards_compat(self):
2538
 
        self.setup_smart_server_with_call_log()
2539
 
        repo = self.make_repository('.')
2540
 
        self.reset_smart_call_log()
2541
 
        verb = 'Repository.set_make_working_trees'
2542
 
        self.disable_verb(verb)
2543
 
        repo.set_make_working_trees(True)
2544
 
        call_count = len([call for call in self.hpss_calls if
2545
 
            call.call.method == verb])
2546
 
        self.assertEqual(1, call_count)
2547
 
 
2548
 
    def test_current(self):
2549
 
        transport_path = 'quack'
2550
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2551
 
        client.add_expected_call(
2552
 
            'Repository.set_make_working_trees', ('quack/', 'True'),
2553
 
            'success', ('ok',))
2554
 
        client.add_expected_call(
2555
 
            'Repository.set_make_working_trees', ('quack/', 'False'),
2556
 
            'success', ('ok',))
2557
 
        repo.set_make_working_trees(True)
2558
 
        repo.set_make_working_trees(False)
2559
 
 
2560
 
 
2561
1387
class TestRepositoryUnlock(TestRemoteRepository):
2562
1388
 
2563
1389
    def test_unlock(self):
2596
1422
        self.assertEqual([], client._calls)
2597
1423
 
2598
1424
 
2599
 
class TestRepositoryInsertStreamBase(TestRemoteRepository):
2600
 
    """Base class for Repository.insert_stream and .insert_stream_1.19
2601
 
    tests.
2602
 
    """
2603
 
    
2604
 
    def checkInsertEmptyStream(self, repo, client):
2605
 
        """Insert an empty stream, checking the result.
2606
 
 
2607
 
        This checks that there are no resume_tokens or missing_keys, and that
2608
 
        the client is finished.
2609
 
        """
2610
 
        sink = repo._get_sink()
2611
 
        fmt = repository.format_registry.get_default()
2612
 
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
2613
 
        self.assertEqual([], resume_tokens)
2614
 
        self.assertEqual(set(), missing_keys)
2615
 
        self.assertFinished(client)
2616
 
 
2617
 
 
2618
 
class TestRepositoryInsertStream(TestRepositoryInsertStreamBase):
2619
 
    """Tests for using Repository.insert_stream verb when the _1.19 variant is
2620
 
    not available.
2621
 
 
2622
 
    This test case is very similar to TestRepositoryInsertStream_1_19.
2623
 
    """
2624
 
 
2625
 
    def setUp(self):
2626
 
        TestRemoteRepository.setUp(self)
2627
 
        self.disable_verb('Repository.insert_stream_1.19')
2628
 
 
2629
 
    def test_unlocked_repo(self):
2630
 
        transport_path = 'quack'
2631
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2632
 
        client.add_expected_call(
2633
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2634
 
            'unknown', ('Repository.insert_stream_1.19',))
2635
 
        client.add_expected_call(
2636
 
            'Repository.insert_stream', ('quack/', ''),
2637
 
            'success', ('ok',))
2638
 
        client.add_expected_call(
2639
 
            'Repository.insert_stream', ('quack/', ''),
2640
 
            'success', ('ok',))
2641
 
        self.checkInsertEmptyStream(repo, client)
2642
 
 
2643
 
    def test_locked_repo_with_no_lock_token(self):
2644
 
        transport_path = 'quack'
2645
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2646
 
        client.add_expected_call(
2647
 
            'Repository.lock_write', ('quack/', ''),
2648
 
            'success', ('ok', ''))
2649
 
        client.add_expected_call(
2650
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2651
 
            'unknown', ('Repository.insert_stream_1.19',))
2652
 
        client.add_expected_call(
2653
 
            'Repository.insert_stream', ('quack/', ''),
2654
 
            'success', ('ok',))
2655
 
        client.add_expected_call(
2656
 
            'Repository.insert_stream', ('quack/', ''),
2657
 
            'success', ('ok',))
2658
 
        repo.lock_write()
2659
 
        self.checkInsertEmptyStream(repo, client)
2660
 
 
2661
 
    def test_locked_repo_with_lock_token(self):
2662
 
        transport_path = 'quack'
2663
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2664
 
        client.add_expected_call(
2665
 
            'Repository.lock_write', ('quack/', ''),
2666
 
            'success', ('ok', 'a token'))
2667
 
        client.add_expected_call(
2668
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2669
 
            'unknown', ('Repository.insert_stream_1.19',))
2670
 
        client.add_expected_call(
2671
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2672
 
            'success', ('ok',))
2673
 
        client.add_expected_call(
2674
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2675
 
            'success', ('ok',))
2676
 
        repo.lock_write()
2677
 
        self.checkInsertEmptyStream(repo, client)
2678
 
 
2679
 
    def test_stream_with_inventory_deltas(self):
2680
 
        """'inventory-deltas' substreams cannot be sent to the
2681
 
        Repository.insert_stream verb, because not all servers that implement
2682
 
        that verb will accept them.  So when one is encountered the RemoteSink
2683
 
        immediately stops using that verb and falls back to VFS insert_stream.
2684
 
        """
2685
 
        transport_path = 'quack'
2686
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2687
 
        client.add_expected_call(
2688
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2689
 
            'unknown', ('Repository.insert_stream_1.19',))
2690
 
        client.add_expected_call(
2691
 
            'Repository.insert_stream', ('quack/', ''),
2692
 
            'success', ('ok',))
2693
 
        client.add_expected_call(
2694
 
            'Repository.insert_stream', ('quack/', ''),
2695
 
            'success', ('ok',))
2696
 
        # Create a fake real repository for insert_stream to fall back on, so
2697
 
        # that we can directly see the records the RemoteSink passes to the
2698
 
        # real sink.
2699
 
        class FakeRealSink:
2700
 
            def __init__(self):
2701
 
                self.records = []
2702
 
            def insert_stream(self, stream, src_format, resume_tokens):
2703
 
                for substream_kind, substream in stream:
2704
 
                    self.records.append(
2705
 
                        (substream_kind, [record.key for record in substream]))
2706
 
                return ['fake tokens'], ['fake missing keys']
2707
 
        fake_real_sink = FakeRealSink()
2708
 
        class FakeRealRepository:
2709
 
            def _get_sink(self):
2710
 
                return fake_real_sink
2711
 
            def is_in_write_group(self):
2712
 
                return False
2713
 
            def refresh_data(self):
2714
 
                return True
2715
 
        repo._real_repository = FakeRealRepository()
2716
 
        sink = repo._get_sink()
2717
 
        fmt = repository.format_registry.get_default()
2718
 
        stream = self.make_stream_with_inv_deltas(fmt)
2719
 
        resume_tokens, missing_keys = sink.insert_stream(stream, fmt, [])
2720
 
        # Every record from the first inventory delta should have been sent to
2721
 
        # the VFS sink.
2722
 
        expected_records = [
2723
 
            ('inventory-deltas', [('rev2',), ('rev3',)]),
2724
 
            ('texts', [('some-rev', 'some-file')])]
2725
 
        self.assertEqual(expected_records, fake_real_sink.records)
2726
 
        # The return values from the real sink's insert_stream are propagated
2727
 
        # back to the original caller.
2728
 
        self.assertEqual(['fake tokens'], resume_tokens)
2729
 
        self.assertEqual(['fake missing keys'], missing_keys)
2730
 
        self.assertFinished(client)
2731
 
 
2732
 
    def make_stream_with_inv_deltas(self, fmt):
2733
 
        """Make a simple stream with an inventory delta followed by more
2734
 
        records and more substreams to test that all records and substreams
2735
 
        from that point on are used.
2736
 
 
2737
 
        This sends, in order:
2738
 
           * inventories substream: rev1, rev2, rev3.  rev2 and rev3 are
2739
 
             inventory-deltas.
2740
 
           * texts substream: (some-rev, some-file)
2741
 
        """
2742
 
        # Define a stream using generators so that it isn't rewindable.
2743
 
        inv = inventory.Inventory(revision_id='rev1')
2744
 
        inv.root.revision = 'rev1'
2745
 
        def stream_with_inv_delta():
2746
 
            yield ('inventories', inventories_substream())
2747
 
            yield ('inventory-deltas', inventory_delta_substream())
2748
 
            yield ('texts', [
2749
 
                versionedfile.FulltextContentFactory(
2750
 
                    ('some-rev', 'some-file'), (), None, 'content')])
2751
 
        def inventories_substream():
2752
 
            # An empty inventory fulltext.  This will be streamed normally.
2753
 
            text = fmt._serializer.write_inventory_to_string(inv)
2754
 
            yield versionedfile.FulltextContentFactory(
2755
 
                ('rev1',), (), None, text)
2756
 
        def inventory_delta_substream():
2757
 
            # An inventory delta.  This can't be streamed via this verb, so it
2758
 
            # will trigger a fallback to VFS insert_stream.
2759
 
            entry = inv.make_entry(
2760
 
                'directory', 'newdir', inv.root.file_id, 'newdir-id')
2761
 
            entry.revision = 'ghost'
2762
 
            delta = [(None, 'newdir', 'newdir-id', entry)]
2763
 
            serializer = inventory_delta.InventoryDeltaSerializer(
2764
 
                versioned_root=True, tree_references=False)
2765
 
            lines = serializer.delta_to_lines('rev1', 'rev2', delta)
2766
 
            yield versionedfile.ChunkedContentFactory(
2767
 
                ('rev2',), (('rev1',)), None, lines)
2768
 
            # Another delta.
2769
 
            lines = serializer.delta_to_lines('rev1', 'rev3', delta)
2770
 
            yield versionedfile.ChunkedContentFactory(
2771
 
                ('rev3',), (('rev1',)), None, lines)
2772
 
        return stream_with_inv_delta()
2773
 
 
2774
 
 
2775
 
class TestRepositoryInsertStream_1_19(TestRepositoryInsertStreamBase):
2776
 
 
2777
 
    def test_unlocked_repo(self):
2778
 
        transport_path = 'quack'
2779
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2780
 
        client.add_expected_call(
2781
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2782
 
            'success', ('ok',))
2783
 
        client.add_expected_call(
2784
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2785
 
            'success', ('ok',))
2786
 
        self.checkInsertEmptyStream(repo, client)
2787
 
 
2788
 
    def test_locked_repo_with_no_lock_token(self):
2789
 
        transport_path = 'quack'
2790
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2791
 
        client.add_expected_call(
2792
 
            'Repository.lock_write', ('quack/', ''),
2793
 
            'success', ('ok', ''))
2794
 
        client.add_expected_call(
2795
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2796
 
            'success', ('ok',))
2797
 
        client.add_expected_call(
2798
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2799
 
            'success', ('ok',))
2800
 
        repo.lock_write()
2801
 
        self.checkInsertEmptyStream(repo, client)
2802
 
 
2803
 
    def test_locked_repo_with_lock_token(self):
2804
 
        transport_path = 'quack'
2805
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2806
 
        client.add_expected_call(
2807
 
            'Repository.lock_write', ('quack/', ''),
2808
 
            'success', ('ok', 'a token'))
2809
 
        client.add_expected_call(
2810
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2811
 
            'success', ('ok',))
2812
 
        client.add_expected_call(
2813
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2814
 
            'success', ('ok',))
2815
 
        repo.lock_write()
2816
 
        self.checkInsertEmptyStream(repo, client)
2817
 
 
2818
 
 
2819
1425
class TestRepositoryTarball(TestRemoteRepository):
2820
1426
 
2821
1427
    # This is a canned tarball reponse we can validate against
2855
1461
    """RemoteRepository.copy_content_into optimizations"""
2856
1462
 
2857
1463
    def test_copy_content_remote_to_local(self):
2858
 
        self.transport_server = test_server.SmartTCPServer_for_testing
 
1464
        self.transport_server = server.SmartTCPServer_for_testing
2859
1465
        src_repo = self.make_repository('repo1')
2860
1466
        src_repo = repository.Repository.open(self.get_url('repo1'))
2861
1467
        # At the moment the tarball-based copy_content_into can't write back
2873
1479
class _StubRealPackRepository(object):
2874
1480
 
2875
1481
    def __init__(self, calls):
2876
 
        self.calls = calls
2877
1482
        self._pack_collection = _StubPackCollection(calls)
2878
1483
 
2879
 
    def is_in_write_group(self):
2880
 
        return False
2881
 
 
2882
 
    def refresh_data(self):
2883
 
        self.calls.append(('pack collection reload_pack_names',))
2884
 
 
2885
1484
 
2886
1485
class _StubPackCollection(object):
2887
1486
 
2891
1490
    def autopack(self):
2892
1491
        self.calls.append(('pack collection autopack',))
2893
1492
 
 
1493
    def reload_pack_names(self):
 
1494
        self.calls.append(('pack collection reload_pack_names',))
2894
1495
 
 
1496
    
2895
1497
class TestRemotePackRepositoryAutoPack(TestRemoteRepository):
2896
1498
    """Tests for RemoteRepository.autopack implementation."""
2897
1499
 
2904
1506
        client.add_expected_call(
2905
1507
            'PackRepository.autopack', ('quack/',), 'success', ('ok',))
2906
1508
        repo.autopack()
2907
 
        self.assertFinished(client)
 
1509
        client.finished_test()
2908
1510
 
2909
1511
    def test_ok_with_real_repo(self):
2910
1512
        """When the server returns 'ok' and there is a _real_repository, then
2921
1523
            [('call', 'PackRepository.autopack', ('quack/',)),
2922
1524
             ('pack collection reload_pack_names',)],
2923
1525
            client._calls)
2924
 
 
 
1526
        
2925
1527
    def test_backwards_compatibility(self):
2926
1528
        """If the server does not recognise the PackRepository.autopack verb,
2927
1529
        fallback to the real_repository's implementation.
2940
1542
             ('pack collection autopack',)],
2941
1543
            client._calls)
2942
1544
 
2943
 
    def test_oom_error_reporting(self):
2944
 
        """An out-of-memory condition on the server is reported clearly"""
2945
 
        transport_path = 'quack'
2946
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2947
 
        client.add_expected_call(
2948
 
            'PackRepository.autopack', ('quack/',),
2949
 
            'error', ('MemoryError',))
2950
 
        err = self.assertRaises(errors.BzrError, repo.autopack)
2951
 
        self.assertContainsRe(str(err), "^remote server out of mem")
2952
 
 
2953
1545
 
2954
1546
class TestErrorTranslationBase(tests.TestCaseWithMemoryTransport):
2955
1547
    """Base class for unit tests for bzrlib.remote._translate_error."""
2987
1579
 
2988
1580
class TestErrorTranslationSuccess(TestErrorTranslationBase):
2989
1581
    """Unit tests for bzrlib.remote._translate_error.
2990
 
 
 
1582
    
2991
1583
    Given an ErrorFromSmartServer (which has an error tuple from a smart
2992
1584
    server) and some context, _translate_error raises more specific errors from
2993
1585
    bzrlib.errors.
3019
1611
        expected_error = errors.NotBranchError(path=bzrdir.root_transport.base)
3020
1612
        self.assertEqual(expected_error, translated_error)
3021
1613
 
3022
 
    def test_nobranch_one_arg(self):
3023
 
        bzrdir = self.make_bzrdir('')
3024
 
        translated_error = self.translateTuple(
3025
 
            ('nobranch', 'extra detail'), bzrdir=bzrdir)
3026
 
        expected_error = errors.NotBranchError(
3027
 
            path=bzrdir.root_transport.base,
3028
 
            detail='extra detail')
3029
 
        self.assertEqual(expected_error, translated_error)
3030
 
 
3031
 
    def test_norepository(self):
3032
 
        bzrdir = self.make_bzrdir('')
3033
 
        translated_error = self.translateTuple(('norepository',),
3034
 
            bzrdir=bzrdir)
3035
 
        expected_error = errors.NoRepositoryPresent(bzrdir)
3036
 
        self.assertEqual(expected_error, translated_error)
3037
 
 
3038
1614
    def test_LockContention(self):
3039
1615
        translated_error = self.translateTuple(('LockContention',))
3040
1616
        expected_error = errors.LockContention('(remote lock)')
3068
1644
        expected_error = errors.DivergedBranches(branch, other_branch)
3069
1645
        self.assertEqual(expected_error, translated_error)
3070
1646
 
3071
 
    def test_NotStacked(self):
3072
 
        branch = self.make_branch('')
3073
 
        translated_error = self.translateTuple(('NotStacked',), branch=branch)
3074
 
        expected_error = errors.NotStacked(branch)
3075
 
        self.assertEqual(expected_error, translated_error)
3076
 
 
3077
1647
    def test_ReadError_no_args(self):
3078
1648
        path = 'a path'
3079
1649
        translated_error = self.translateTuple(('ReadError',), path=path)
3086
1656
        expected_error = errors.ReadError(path)
3087
1657
        self.assertEqual(expected_error, translated_error)
3088
1658
 
3089
 
    def test_IncompatibleRepositories(self):
3090
 
        translated_error = self.translateTuple(('IncompatibleRepositories',
3091
 
            "repo1", "repo2", "details here"))
3092
 
        expected_error = errors.IncompatibleRepositories("repo1", "repo2",
3093
 
            "details here")
3094
 
        self.assertEqual(expected_error, translated_error)
3095
 
 
3096
1659
    def test_PermissionDenied_no_args(self):
3097
1660
        path = 'a path'
3098
 
        translated_error = self.translateTuple(('PermissionDenied',),
3099
 
            path=path)
 
1661
        translated_error = self.translateTuple(('PermissionDenied',), path=path)
3100
1662
        expected_error = errors.PermissionDenied(path)
3101
1663
        self.assertEqual(expected_error, translated_error)
3102
1664
 
3125
1687
        expected_error = errors.PermissionDenied(path, extra)
3126
1688
        self.assertEqual(expected_error, translated_error)
3127
1689
 
3128
 
    # GZ 2011-03-02: TODO test for PermissionDenied with non-ascii 'extra'
3129
 
 
3130
 
    def test_NoSuchFile_context_path(self):
3131
 
        local_path = "local path"
3132
 
        translated_error = self.translateTuple(('ReadError', "remote path"),
3133
 
            path=local_path)
3134
 
        expected_error = errors.ReadError(local_path)
3135
 
        self.assertEqual(expected_error, translated_error)
3136
 
 
3137
 
    def test_NoSuchFile_without_context(self):
3138
 
        remote_path = "remote path"
3139
 
        translated_error = self.translateTuple(('ReadError', remote_path))
3140
 
        expected_error = errors.ReadError(remote_path)
3141
 
        self.assertEqual(expected_error, translated_error)
3142
 
 
3143
 
    def test_ReadOnlyError(self):
3144
 
        translated_error = self.translateTuple(('ReadOnlyError',))
3145
 
        expected_error = errors.TransportNotPossible("readonly transport")
3146
 
        self.assertEqual(expected_error, translated_error)
3147
 
 
3148
 
    def test_MemoryError(self):
3149
 
        translated_error = self.translateTuple(('MemoryError',))
3150
 
        self.assertStartsWith(str(translated_error),
3151
 
            "remote server out of memory")
3152
 
 
3153
 
    def test_generic_IndexError_no_classname(self):
3154
 
        err = errors.ErrorFromSmartServer(('error', "list index out of range"))
3155
 
        translated_error = self.translateErrorFromSmartServer(err)
3156
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3157
 
        self.assertEqual(expected_error, translated_error)
3158
 
 
3159
 
    # GZ 2011-03-02: TODO test generic non-ascii error string
3160
 
 
3161
 
    def test_generic_KeyError(self):
3162
 
        err = errors.ErrorFromSmartServer(('error', 'KeyError', "1"))
3163
 
        translated_error = self.translateErrorFromSmartServer(err)
3164
 
        expected_error = errors.UnknownErrorFromSmartServer(err)
3165
 
        self.assertEqual(expected_error, translated_error)
3166
 
 
3167
1690
 
3168
1691
class TestErrorTranslationRobustness(TestErrorTranslationBase):
3169
1692
    """Unit tests for bzrlib.remote._translate_error's robustness.
3170
 
 
 
1693
    
3171
1694
    TestErrorTranslationSuccess is for cases where _translate_error can
3172
1695
    translate successfully.  This class about how _translate_err behaves when
3173
1696
    it fails to translate: it re-raises the original error.
3199
1722
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3200
1723
        # been muttered to the log file for developer to look at.
3201
1724
        self.assertContainsRe(
3202
 
            self.get_log(),
 
1725
            self._get_log(keep_log_file=True),
3203
1726
            "Missing key 'branch' in context")
3204
 
 
 
1727
        
3205
1728
    def test_path_missing(self):
3206
1729
        """Some translations (PermissionDenied, ReadError) can determine the
3207
1730
        'path' variable from either the wire or the local context.  If neither
3213
1736
        self.assertEqual(server_error, translated_error)
3214
1737
        # In addition to re-raising ErrorFromSmartServer, some debug info has
3215
1738
        # been muttered to the log file for developer to look at.
3216
 
        self.assertContainsRe(self.get_log(), "Missing key 'path' in context")
 
1739
        self.assertContainsRe(
 
1740
            self._get_log(keep_log_file=True), "Missing key 'path' in context")
3217
1741
 
3218
1742
 
3219
1743
class TestStacking(tests.TestCaseWithTransport):
3220
1744
    """Tests for operations on stacked remote repositories.
3221
 
 
 
1745
    
3222
1746
    The underlying format type must support stacking.
3223
1747
    """
3224
1748
 
3228
1752
        # revision, then open it over hpss - we should be able to see that
3229
1753
        # revision.
3230
1754
        base_transport = self.get_transport()
3231
 
        base_builder = self.make_branch_builder('base', format='1.9')
 
1755
        base_builder = self.make_branch_builder('base', format='1.6')
3232
1756
        base_builder.start_series()
3233
1757
        base_revid = base_builder.build_snapshot('rev-id', None,
3234
1758
            [('add', ('', None, 'directory', None))],
3235
1759
            'message')
3236
1760
        base_builder.finish_series()
3237
 
        stacked_branch = self.make_branch('stacked', format='1.9')
 
1761
        stacked_branch = self.make_branch('stacked', format='1.6')
3238
1762
        stacked_branch.set_stacked_on_url('../base')
3239
1763
        # start a server looking at this
3240
 
        smart_server = test_server.SmartTCPServer_for_testing()
3241
 
        self.start_server(smart_server)
 
1764
        smart_server = server.SmartTCPServer_for_testing()
 
1765
        smart_server.setUp()
 
1766
        self.addCleanup(smart_server.tearDown)
3242
1767
        remote_bzrdir = BzrDir.open(smart_server.get_url() + '/stacked')
3243
1768
        # can get its branch and repository
3244
1769
        remote_branch = remote_bzrdir.open_branch()
3247
1772
        try:
3248
1773
            # it should have an appropriate fallback repository, which should also
3249
1774
            # be a RemoteRepository
3250
 
            self.assertLength(1, remote_repo._fallback_repositories)
 
1775
            self.assertEquals(len(remote_repo._fallback_repositories), 1)
3251
1776
            self.assertIsInstance(remote_repo._fallback_repositories[0],
3252
1777
                RemoteRepository)
3253
1778
            # and it has the revision committed to the underlying repository;
3260
1785
            remote_repo.unlock()
3261
1786
 
3262
1787
    def prepare_stacked_remote_branch(self):
3263
 
        """Get stacked_upon and stacked branches with content in each."""
3264
 
        self.setup_smart_server_with_call_log()
3265
 
        tree1 = self.make_branch_and_tree('tree1', format='1.9')
 
1788
        smart_server = server.SmartTCPServer_for_testing()
 
1789
        smart_server.setUp()
 
1790
        self.addCleanup(smart_server.tearDown)
 
1791
        tree1 = self.make_branch_and_tree('tree1')
3266
1792
        tree1.commit('rev1', rev_id='rev1')
3267
 
        tree2 = tree1.branch.bzrdir.sprout('tree2', stacked=True
3268
 
            ).open_workingtree()
3269
 
        local_tree = tree2.branch.create_checkout('local')
3270
 
        local_tree.commit('local changes make me feel good.')
3271
 
        branch2 = Branch.open(self.get_url('tree2'))
 
1793
        tree2 = self.make_branch_and_tree('tree2', format='1.6')
 
1794
        tree2.branch.set_stacked_on_url(tree1.branch.base)
 
1795
        branch2 = Branch.open(smart_server.get_url() + '/tree2')
3272
1796
        branch2.lock_read()
3273
1797
        self.addCleanup(branch2.unlock)
3274
 
        return tree1.branch, branch2
 
1798
        return branch2
3275
1799
 
3276
1800
    def test_stacked_get_parent_map(self):
3277
1801
        # the public implementation of get_parent_map obeys stacking
3278
 
        _, branch = self.prepare_stacked_remote_branch()
 
1802
        branch = self.prepare_stacked_remote_branch()
3279
1803
        repo = branch.repository
3280
1804
        self.assertEqual(['rev1'], repo.get_parent_map(['rev1']).keys())
3281
1805
 
3282
1806
    def test_unstacked_get_parent_map(self):
3283
1807
        # _unstacked_provider.get_parent_map ignores stacking
3284
 
        _, branch = self.prepare_stacked_remote_branch()
 
1808
        branch = self.prepare_stacked_remote_branch()
3285
1809
        provider = branch.repository._unstacked_provider
3286
1810
        self.assertEqual([], provider.get_parent_map(['rev1']).keys())
3287
1811
 
3288
 
    def fetch_stream_to_rev_order(self, stream):
3289
 
        result = []
3290
 
        for kind, substream in stream:
3291
 
            if not kind == 'revisions':
3292
 
                list(substream)
3293
 
            else:
3294
 
                for content in substream:
3295
 
                    result.append(content.key[-1])
3296
 
        return result
3297
 
 
3298
 
    def get_ordered_revs(self, format, order, branch_factory=None):
3299
 
        """Get a list of the revisions in a stream to format format.
3300
 
 
3301
 
        :param format: The format of the target.
3302
 
        :param order: the order that target should have requested.
3303
 
        :param branch_factory: A callable to create a trunk and stacked branch
3304
 
            to fetch from. If none, self.prepare_stacked_remote_branch is used.
3305
 
        :result: The revision ids in the stream, in the order seen,
3306
 
            the topological order of revisions in the source.
3307
 
        """
3308
 
        unordered_format = bzrdir.format_registry.get(format)()
3309
 
        target_repository_format = unordered_format.repository_format
3310
 
        # Cross check
3311
 
        self.assertEqual(order, target_repository_format._fetch_order)
3312
 
        if branch_factory is None:
3313
 
            branch_factory = self.prepare_stacked_remote_branch
3314
 
        _, stacked = branch_factory()
3315
 
        source = stacked.repository._get_source(target_repository_format)
3316
 
        tip = stacked.last_revision()
3317
 
        stacked.repository._ensure_real()
3318
 
        graph = stacked.repository.get_graph()
3319
 
        revs = [r for (r,ps) in graph.iter_ancestry([tip])
3320
 
                if r != NULL_REVISION]
3321
 
        revs.reverse()
3322
 
        search = _mod_graph.PendingAncestryResult([tip], stacked.repository)
3323
 
        self.reset_smart_call_log()
3324
 
        stream = source.get_stream(search)
3325
 
        # We trust that if a revision is in the stream the rest of the new
3326
 
        # content for it is too, as per our main fetch tests; here we are
3327
 
        # checking that the revisions are actually included at all, and their
3328
 
        # order.
3329
 
        return self.fetch_stream_to_rev_order(stream), revs
3330
 
 
3331
 
    def test_stacked_get_stream_unordered(self):
3332
 
        # Repository._get_source.get_stream() from a stacked repository with
3333
 
        # unordered yields the full data from both stacked and stacked upon
3334
 
        # sources.
3335
 
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered')
3336
 
        self.assertEqual(set(expected_revs), set(rev_ord))
3337
 
        # Getting unordered results should have made a streaming data request
3338
 
        # from the server, then one from the backing branch.
3339
 
        self.assertLength(2, self.hpss_calls)
3340
 
 
3341
 
    def test_stacked_on_stacked_get_stream_unordered(self):
3342
 
        # Repository._get_source.get_stream() from a stacked repository which
3343
 
        # is itself stacked yields the full data from all three sources.
3344
 
        def make_stacked_stacked():
3345
 
            _, stacked = self.prepare_stacked_remote_branch()
3346
 
            tree = stacked.bzrdir.sprout('tree3', stacked=True
3347
 
                ).open_workingtree()
3348
 
            local_tree = tree.branch.create_checkout('local-tree3')
3349
 
            local_tree.commit('more local changes are better')
3350
 
            branch = Branch.open(self.get_url('tree3'))
3351
 
            branch.lock_read()
3352
 
            self.addCleanup(branch.unlock)
3353
 
            return None, branch
3354
 
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered',
3355
 
            branch_factory=make_stacked_stacked)
3356
 
        self.assertEqual(set(expected_revs), set(rev_ord))
3357
 
        # Getting unordered results should have made a streaming data request
3358
 
        # from the server, and one from each backing repo
3359
 
        self.assertLength(3, self.hpss_calls)
3360
 
 
3361
 
    def test_stacked_get_stream_topological(self):
3362
 
        # Repository._get_source.get_stream() from a stacked repository with
3363
 
        # topological sorting yields the full data from both stacked and
3364
 
        # stacked upon sources in topological order.
3365
 
        rev_ord, expected_revs = self.get_ordered_revs('knit', 'topological')
3366
 
        self.assertEqual(expected_revs, rev_ord)
3367
 
        # Getting topological sort requires VFS calls still - one of which is
3368
 
        # pushing up from the bound branch.
3369
 
        self.assertLength(14, self.hpss_calls)
3370
 
 
3371
 
    def test_stacked_get_stream_groupcompress(self):
3372
 
        # Repository._get_source.get_stream() from a stacked repository with
3373
 
        # groupcompress sorting yields the full data from both stacked and
3374
 
        # stacked upon sources in groupcompress order.
3375
 
        raise tests.TestSkipped('No groupcompress ordered format available')
3376
 
        rev_ord, expected_revs = self.get_ordered_revs('dev5', 'groupcompress')
3377
 
        self.assertEqual(expected_revs, reversed(rev_ord))
3378
 
        # Getting unordered results should have made a streaming data request
3379
 
        # from the backing branch, and one from the stacked on branch.
3380
 
        self.assertLength(2, self.hpss_calls)
3381
 
 
3382
 
    def test_stacked_pull_more_than_stacking_has_bug_360791(self):
3383
 
        # When pulling some fixed amount of content that is more than the
3384
 
        # source has (because some is coming from a fallback branch, no error
3385
 
        # should be received. This was reported as bug 360791.
3386
 
        # Need three branches: a trunk, a stacked branch, and a preexisting
3387
 
        # branch pulling content from stacked and trunk.
3388
 
        self.setup_smart_server_with_call_log()
3389
 
        trunk = self.make_branch_and_tree('trunk', format="1.9-rich-root")
3390
 
        r1 = trunk.commit('start')
3391
 
        stacked_branch = trunk.branch.create_clone_on_transport(
3392
 
            self.get_transport('stacked'), stacked_on=trunk.branch.base)
3393
 
        local = self.make_branch('local', format='1.9-rich-root')
3394
 
        local.repository.fetch(stacked_branch.repository,
3395
 
            stacked_branch.last_revision())
3396
 
 
3397
1812
 
3398
1813
class TestRemoteBranchEffort(tests.TestCaseWithTransport):
3399
1814
 
3401
1816
        super(TestRemoteBranchEffort, self).setUp()
3402
1817
        # Create a smart server that publishes whatever the backing VFS server
3403
1818
        # does.
3404
 
        self.smart_server = test_server.SmartTCPServer_for_testing()
3405
 
        self.start_server(self.smart_server, self.get_server())
 
1819
        self.smart_server = server.SmartTCPServer_for_testing()
 
1820
        self.smart_server.setUp(self.get_server())
 
1821
        self.addCleanup(self.smart_server.tearDown)
3406
1822
        # Log all HPSS calls into self.hpss_calls.
3407
1823
        _SmartClient.hooks.install_named_hook(
3408
1824
            'call', self.capture_hpss_call, None)
3413
1829
 
3414
1830
    def test_copy_content_into_avoids_revision_history(self):
3415
1831
        local = self.make_branch('local')
3416
 
        builder = self.make_branch_builder('remote')
3417
 
        builder.build_commit(message="Commit.")
 
1832
        remote_backing_tree = self.make_branch_and_tree('remote')
 
1833
        remote_backing_tree.commit("Commit.")
3418
1834
        remote_branch_url = self.smart_server.get_url() + 'remote'
3419
1835
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3420
1836
        local.repository.fetch(remote_branch.repository)
3421
1837
        self.hpss_calls = []
3422
1838
        remote_branch.copy_content_into(local)
3423
1839
        self.assertFalse('Branch.revision_history' in self.hpss_calls)
3424
 
 
3425
 
    def test_fetch_everything_needs_just_one_call(self):
3426
 
        local = self.make_branch('local')
3427
 
        builder = self.make_branch_builder('remote')
3428
 
        builder.build_commit(message="Commit.")
3429
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
3430
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3431
 
        self.hpss_calls = []
3432
 
        local.repository.fetch(
3433
 
            remote_branch.repository,
3434
 
            fetch_spec=_mod_graph.EverythingResult(remote_branch.repository))
3435
 
        self.assertEqual(['Repository.get_stream_1.19'], self.hpss_calls)
3436
 
 
3437
 
    def override_verb(self, verb_name, verb):
3438
 
        request_handlers = request.request_handlers
3439
 
        orig_verb = request_handlers.get(verb_name)
3440
 
        request_handlers.register(verb_name, verb, override_existing=True)
3441
 
        self.addCleanup(request_handlers.register, verb_name, orig_verb,
3442
 
                override_existing=True)
3443
 
 
3444
 
    def test_fetch_everything_backwards_compat(self):
3445
 
        """Can fetch with EverythingResult even with pre 2.4 servers.
3446
 
        
3447
 
        Pre-2.4 do not support 'everything' searches with the
3448
 
        Repository.get_stream_1.19 verb.
3449
 
        """
3450
 
        verb_log = []
3451
 
        class OldGetStreamVerb(SmartServerRepositoryGetStream_1_19):
3452
 
            """A version of the Repository.get_stream_1.19 verb patched to
3453
 
            reject 'everything' searches the way 2.3 and earlier do.
3454
 
            """
3455
 
            def recreate_search(self, repository, search_bytes,
3456
 
                                discard_excess=False):
3457
 
                verb_log.append(search_bytes.split('\n', 1)[0])
3458
 
                if search_bytes == 'everything':
3459
 
                    return (None,
3460
 
                            request.FailedSmartServerResponse(('BadSearch',)))
3461
 
                return super(OldGetStreamVerb,
3462
 
                        self).recreate_search(repository, search_bytes,
3463
 
                            discard_excess=discard_excess)
3464
 
        self.override_verb('Repository.get_stream_1.19', OldGetStreamVerb)
3465
 
        local = self.make_branch('local')
3466
 
        builder = self.make_branch_builder('remote')
3467
 
        builder.build_commit(message="Commit.")
3468
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
3469
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
3470
 
        self.hpss_calls = []
3471
 
        local.repository.fetch(
3472
 
            remote_branch.repository,
3473
 
            fetch_spec=_mod_graph.EverythingResult(remote_branch.repository))
3474
 
        # make sure the overridden verb was used
3475
 
        self.assertLength(1, verb_log)
3476
 
        # more than one HPSS call is needed, but because it's a VFS callback
3477
 
        # its hard to predict exactly how many.
3478
 
        self.assertTrue(len(self.hpss_calls) > 1)
3479
 
 
3480
 
 
3481
 
class TestUpdateBoundBranchWithModifiedBoundLocation(
3482
 
    tests.TestCaseWithTransport):
3483
 
    """Ensure correct handling of bound_location modifications.
3484
 
 
3485
 
    This is tested against a smart server as http://pad.lv/786980 was about a
3486
 
    ReadOnlyError (write attempt during a read-only transaction) which can only
3487
 
    happen in this context.
3488
 
    """
3489
 
 
3490
 
    def setUp(self):
3491
 
        super(TestUpdateBoundBranchWithModifiedBoundLocation, self).setUp()
3492
 
        self.transport_server = test_server.SmartTCPServer_for_testing
3493
 
 
3494
 
    def make_master_and_checkout(self, master_name, checkout_name):
3495
 
        # Create the master branch and its associated checkout
3496
 
        self.master = self.make_branch_and_tree(master_name)
3497
 
        self.checkout = self.master.branch.create_checkout(checkout_name)
3498
 
        # Modify the master branch so there is something to update
3499
 
        self.master.commit('add stuff')
3500
 
        self.last_revid = self.master.commit('even more stuff')
3501
 
        self.bound_location = self.checkout.branch.get_bound_location()
3502
 
 
3503
 
    def assertUpdateSucceeds(self, new_location):
3504
 
        self.checkout.branch.set_bound_location(new_location)
3505
 
        self.checkout.update()
3506
 
        self.assertEquals(self.last_revid, self.checkout.last_revision())
3507
 
 
3508
 
    def test_without_final_slash(self):
3509
 
        self.make_master_and_checkout('master', 'checkout')
3510
 
        # For unclear reasons some users have a bound_location without a final
3511
 
        # '/', simulate that by forcing such a value
3512
 
        self.assertEndsWith(self.bound_location, '/')
3513
 
        self.assertUpdateSucceeds(self.bound_location.rstrip('/'))
3514
 
 
3515
 
    def test_plus_sign(self):
3516
 
        self.make_master_and_checkout('+master', 'checkout')
3517
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2B', '+', 1))
3518
 
 
3519
 
    def test_tilda(self):
3520
 
        # Embed ~ in the middle of the path just to avoid any $HOME
3521
 
        # interpretation
3522
 
        self.make_master_and_checkout('mas~ter', 'checkout')
3523
 
        self.assertUpdateSucceeds(self.bound_location.replace('%2E', '~', 1))