~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test__dirstate_helpers.py

  • Committer: Canonical.com Patch Queue Manager
  • Date: 2009-01-13 05:14:24 UTC
  • mfrom: (3936.1.3 integration)
  • Revision ID: pqm@pqm.ubuntu.com-20090113051424-nrk3zkfe09h46i9y
(mbp) merge 1.11 and advance to 1.12

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2007-2011 Canonical Ltd
 
1
# Copyright (C) 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
"""Tests for the compiled dirstate helpers."""
18
18
 
23
23
from bzrlib import (
24
24
    dirstate,
25
25
    errors,
26
 
    osutils,
27
26
    tests,
28
27
    )
29
28
from bzrlib.tests import (
30
 
    test_dirstate,
31
 
    )
32
 
from bzrlib.tests.test_osutils import dir_reader_scenarios
33
 
from bzrlib.tests.scenarios import (
34
 
    load_tests_apply_scenarios,
35
 
    multiply_scenarios,
36
 
    )
37
 
from bzrlib.tests import (
38
 
    features,
39
 
    )
40
 
 
41
 
 
42
 
load_tests = load_tests_apply_scenarios
43
 
 
44
 
 
45
 
compiled_dirstate_helpers_feature = features.ModuleAvailableFeature(
46
 
    'bzrlib._dirstate_helpers_pyx')
47
 
 
48
 
 
49
 
# FIXME: we should also parametrize against SHA1Provider !
50
 
 
51
 
ue_scenarios = [('dirstate_Python',
52
 
    {'update_entry': dirstate.py_update_entry})]
53
 
if compiled_dirstate_helpers_feature.available():
54
 
    update_entry = compiled_dirstate_helpers_feature.module.update_entry
55
 
    ue_scenarios.append(('dirstate_Pyrex', {'update_entry': update_entry}))
56
 
 
57
 
pe_scenarios = [('dirstate_Python',
58
 
    {'_process_entry': dirstate.ProcessEntryPython})]
59
 
if compiled_dirstate_helpers_feature.available():
60
 
    process_entry = compiled_dirstate_helpers_feature.module.ProcessEntryC
61
 
    pe_scenarios.append(('dirstate_Pyrex', {'_process_entry': process_entry}))
 
29
        SymlinkFeature,
 
30
        )
 
31
from bzrlib.tests import test_dirstate
 
32
 
 
33
 
 
34
class _CompiledDirstateHelpersFeature(tests.Feature):
 
35
    def _probe(self):
 
36
        try:
 
37
            import bzrlib._dirstate_helpers_c
 
38
        except ImportError:
 
39
            return False
 
40
        return True
 
41
 
 
42
    def feature_name(self):
 
43
        return 'bzrlib._dirstate_helpers_c'
 
44
 
 
45
CompiledDirstateHelpersFeature = _CompiledDirstateHelpersFeature()
62
46
 
63
47
 
64
48
class TestBisectPathMixin(object):
217
201
 
218
202
 
219
203
class TestBisectPathLeft(tests.TestCase, TestBisectPathMixin):
220
 
    """Run all Bisect Path tests against _bisect_path_left."""
 
204
    """Run all Bisect Path tests against _bisect_path_left_py."""
221
205
 
222
206
    def get_bisect_path(self):
223
 
        from bzrlib._dirstate_helpers_py import _bisect_path_left
224
 
        return _bisect_path_left
 
207
        from bzrlib._dirstate_helpers_py import _bisect_path_left_py
 
208
        return _bisect_path_left_py
225
209
 
226
210
    def get_bisect(self):
227
211
        return bisect.bisect_left, 0
228
212
 
229
213
 
230
214
class TestCompiledBisectPathLeft(TestBisectPathLeft):
231
 
    """Run all Bisect Path tests against _bisect_path_lect"""
 
215
    """Run all Bisect Path tests against _bisect_path_right_c"""
232
216
 
233
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
217
    _test_needs_features = [CompiledDirstateHelpersFeature]
234
218
 
235
219
    def get_bisect_path(self):
236
 
        from bzrlib._dirstate_helpers_pyx import _bisect_path_left
237
 
        return _bisect_path_left
 
220
        from bzrlib._dirstate_helpers_c import _bisect_path_left_c
 
221
        return _bisect_path_left_c
238
222
 
239
223
 
240
224
class TestBisectPathRight(tests.TestCase, TestBisectPathMixin):
241
 
    """Run all Bisect Path tests against _bisect_path_right"""
 
225
    """Run all Bisect Path tests against _bisect_path_right_py"""
242
226
 
243
227
    def get_bisect_path(self):
244
 
        from bzrlib._dirstate_helpers_py import _bisect_path_right
245
 
        return _bisect_path_right
 
228
        from bzrlib._dirstate_helpers_py import _bisect_path_right_py
 
229
        return _bisect_path_right_py
246
230
 
247
231
    def get_bisect(self):
248
232
        return bisect.bisect_right, -1
249
233
 
250
234
 
251
235
class TestCompiledBisectPathRight(TestBisectPathRight):
252
 
    """Run all Bisect Path tests against _bisect_path_right"""
 
236
    """Run all Bisect Path tests against _bisect_path_right_c"""
253
237
 
254
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
238
    _test_needs_features = [CompiledDirstateHelpersFeature]
255
239
 
256
240
    def get_bisect_path(self):
257
 
        from bzrlib._dirstate_helpers_pyx import _bisect_path_right
258
 
        return _bisect_path_right
 
241
        from bzrlib._dirstate_helpers_c import _bisect_path_right_c
 
242
        return _bisect_path_right_c
259
243
 
260
244
 
261
245
class TestBisectDirblock(tests.TestCase):
272
256
 
273
257
    def get_bisect_dirblock(self):
274
258
        """Return an implementation of bisect_dirblock"""
275
 
        from bzrlib._dirstate_helpers_py import bisect_dirblock
276
 
        return bisect_dirblock
 
259
        from bzrlib._dirstate_helpers_py import bisect_dirblock_py
 
260
        return bisect_dirblock_py
277
261
 
278
262
    def assertBisect(self, dirblocks, split_dirblocks, path, *args, **kwargs):
279
263
        """Assert that bisect_split works like bisect_left on the split paths.
363
347
    compiled version.
364
348
    """
365
349
 
366
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
350
    _test_needs_features = [CompiledDirstateHelpersFeature]
367
351
 
368
352
    def get_bisect_dirblock(self):
369
 
        from bzrlib._dirstate_helpers_pyx import bisect_dirblock
370
 
        return bisect_dirblock
 
353
        from bzrlib._dirstate_helpers_c import bisect_dirblock_c
 
354
        return bisect_dirblock_c
371
355
 
372
356
 
373
357
class TestCmpByDirs(tests.TestCase):
382
366
 
383
367
    def get_cmp_by_dirs(self):
384
368
        """Get a specific implementation of cmp_by_dirs."""
385
 
        from bzrlib._dirstate_helpers_py import cmp_by_dirs
386
 
        return cmp_by_dirs
 
369
        from bzrlib._dirstate_helpers_py import cmp_by_dirs_py
 
370
        return cmp_by_dirs_py
387
371
 
388
372
    def assertCmpByDirs(self, expected, str1, str2):
389
373
        """Compare the two strings, in both directions.
485
469
class TestCompiledCmpByDirs(TestCmpByDirs):
486
470
    """Test the pyrex implementation of cmp_by_dirs"""
487
471
 
488
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
472
    _test_needs_features = [CompiledDirstateHelpersFeature]
489
473
 
490
474
    def get_cmp_by_dirs(self):
491
 
        from bzrlib._dirstate_helpers_pyx import cmp_by_dirs
492
 
        return cmp_by_dirs
 
475
        from bzrlib._dirstate_helpers_c import cmp_by_dirs_c
 
476
        return cmp_by_dirs_c
493
477
 
494
478
 
495
479
class TestCmpPathByDirblock(tests.TestCase):
504
488
 
505
489
    def get_cmp_path_by_dirblock(self):
506
490
        """Get a specific implementation of _cmp_path_by_dirblock."""
507
 
        from bzrlib._dirstate_helpers_py import _cmp_path_by_dirblock
508
 
        return _cmp_path_by_dirblock
 
491
        from bzrlib._dirstate_helpers_py import _cmp_path_by_dirblock_py
 
492
        return _cmp_path_by_dirblock_py
509
493
 
510
494
    def assertCmpPathByDirblock(self, paths):
511
495
        """Compare all paths and make sure they evaluate to the correct order.
636
620
class TestCompiledCmpPathByDirblock(TestCmpPathByDirblock):
637
621
    """Test the pyrex implementation of _cmp_path_by_dirblock"""
638
622
 
639
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
623
    _test_needs_features = [CompiledDirstateHelpersFeature]
640
624
 
641
625
    def get_cmp_by_dirs(self):
642
 
        from bzrlib._dirstate_helpers_pyx import _cmp_path_by_dirblock
643
 
        return _cmp_path_by_dirblock
 
626
        from bzrlib._dirstate_helpers_c import _cmp_path_by_dirblock_c
 
627
        return _cmp_path_by_dirblock_c
644
628
 
645
629
 
646
630
class TestMemRChr(tests.TestCase):
647
631
    """Test memrchr functionality"""
648
632
 
649
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
633
    _test_needs_features = [CompiledDirstateHelpersFeature]
650
634
 
651
635
    def assertMemRChr(self, expected, s, c):
652
 
        from bzrlib._dirstate_helpers_pyx import _py_memrchr
 
636
        from bzrlib._dirstate_helpers_c import _py_memrchr
653
637
        self.assertEqual(expected, _py_memrchr(s, c))
654
638
 
655
639
    def test_missing(self):
696
680
    implementation.
697
681
    """
698
682
 
699
 
    # inherits scenarios from test_dirstate
700
 
 
701
683
    def get_read_dirblocks(self):
702
 
        from bzrlib._dirstate_helpers_py import _read_dirblocks
703
 
        return _read_dirblocks
 
684
        from bzrlib._dirstate_helpers_py import _read_dirblocks_py
 
685
        return _read_dirblocks_py
704
686
 
705
687
    def test_smoketest(self):
706
688
        """Make sure that we can create and read back a simple file."""
716
698
 
717
699
    def test_trailing_garbage(self):
718
700
        tree, state, expected = self.create_basic_dirstate()
719
 
        # On Unix, we can write extra data as long as we haven't read yet, but
720
 
        # on Win32, if you've opened the file with FILE_SHARE_READ, trying to
721
 
        # open it in append mode will fail.
722
 
        state.unlock()
 
701
        # We can modify the file as long as it hasn't been read yet.
723
702
        f = open('dirstate', 'ab')
724
703
        try:
725
704
            # Add bogus trailing garbage
726
705
            f.write('bogus\n')
727
706
        finally:
728
707
            f.close()
729
 
            state.lock_read()
730
708
        e = self.assertRaises(errors.DirstateCorrupt,
731
709
                              state._read_dirblocks_if_needed)
732
710
        # Make sure we mention the bogus characters in the error
736
714
class TestCompiledReadDirblocks(TestReadDirblocks):
737
715
    """Test the pyrex implementation of _read_dirblocks"""
738
716
 
739
 
    _test_needs_features = [compiled_dirstate_helpers_feature]
 
717
    _test_needs_features = [CompiledDirstateHelpersFeature]
740
718
 
741
719
    def get_read_dirblocks(self):
742
 
        from bzrlib._dirstate_helpers_pyx import _read_dirblocks
743
 
        return _read_dirblocks
 
720
        from bzrlib._dirstate_helpers_c import _read_dirblocks_c
 
721
        return _read_dirblocks_c
744
722
 
745
723
 
746
724
class TestUsingCompiledIfAvailable(tests.TestCase):
747
725
    """Check that any compiled functions that are available are the default.
748
726
 
749
727
    It is possible to have typos, etc in the import line, such that
750
 
    _dirstate_helpers_pyx is actually available, but the compiled functions are
 
728
    _dirstate_helpers_c is actually available, but the compiled functions are
751
729
    not being used.
752
730
    """
753
731
 
754
732
    def test_bisect_dirblock(self):
755
 
        if compiled_dirstate_helpers_feature.available():
756
 
            from bzrlib._dirstate_helpers_pyx import bisect_dirblock
 
733
        if CompiledDirstateHelpersFeature.available():
 
734
            from bzrlib._dirstate_helpers_c import bisect_dirblock_c
 
735
            self.assertIs(bisect_dirblock_c, dirstate.bisect_dirblock)
757
736
        else:
758
 
            from bzrlib._dirstate_helpers_py import bisect_dirblock
759
 
        self.assertIs(bisect_dirblock, dirstate.bisect_dirblock)
 
737
            from bzrlib._dirstate_helpers_py import bisect_dirblock_py
 
738
            self.assertIs(bisect_dirblock_py, dirstate.bisect_dirblock)
760
739
 
761
740
    def test__bisect_path_left(self):
762
 
        if compiled_dirstate_helpers_feature.available():
763
 
            from bzrlib._dirstate_helpers_pyx import _bisect_path_left
 
741
        if CompiledDirstateHelpersFeature.available():
 
742
            from bzrlib._dirstate_helpers_c import _bisect_path_left_c
 
743
            self.assertIs(_bisect_path_left_c, dirstate._bisect_path_left)
764
744
        else:
765
 
            from bzrlib._dirstate_helpers_py import _bisect_path_left
766
 
        self.assertIs(_bisect_path_left, dirstate._bisect_path_left)
 
745
            from bzrlib._dirstate_helpers_py import _bisect_path_left_py
 
746
            self.assertIs(_bisect_path_left_py, dirstate._bisect_path_left)
767
747
 
768
748
    def test__bisect_path_right(self):
769
 
        if compiled_dirstate_helpers_feature.available():
770
 
            from bzrlib._dirstate_helpers_pyx import _bisect_path_right
 
749
        if CompiledDirstateHelpersFeature.available():
 
750
            from bzrlib._dirstate_helpers_c import _bisect_path_right_c
 
751
            self.assertIs(_bisect_path_right_c, dirstate._bisect_path_right)
771
752
        else:
772
 
            from bzrlib._dirstate_helpers_py import _bisect_path_right
773
 
        self.assertIs(_bisect_path_right, dirstate._bisect_path_right)
 
753
            from bzrlib._dirstate_helpers_py import _bisect_path_right_py
 
754
            self.assertIs(_bisect_path_right_py, dirstate._bisect_path_right)
774
755
 
775
756
    def test_cmp_by_dirs(self):
776
 
        if compiled_dirstate_helpers_feature.available():
777
 
            from bzrlib._dirstate_helpers_pyx import cmp_by_dirs
 
757
        if CompiledDirstateHelpersFeature.available():
 
758
            from bzrlib._dirstate_helpers_c import cmp_by_dirs_c
 
759
            self.assertIs(cmp_by_dirs_c, dirstate.cmp_by_dirs)
778
760
        else:
779
 
            from bzrlib._dirstate_helpers_py import cmp_by_dirs
780
 
        self.assertIs(cmp_by_dirs, dirstate.cmp_by_dirs)
 
761
            from bzrlib._dirstate_helpers_py import cmp_by_dirs_py
 
762
            self.assertIs(cmp_by_dirs_py, dirstate.cmp_by_dirs)
781
763
 
782
764
    def test__read_dirblocks(self):
783
 
        if compiled_dirstate_helpers_feature.available():
784
 
            from bzrlib._dirstate_helpers_pyx import _read_dirblocks
 
765
        if CompiledDirstateHelpersFeature.available():
 
766
            from bzrlib._dirstate_helpers_c import _read_dirblocks_c
 
767
            self.assertIs(_read_dirblocks_c, dirstate._read_dirblocks)
785
768
        else:
786
 
            from bzrlib._dirstate_helpers_py import _read_dirblocks
787
 
        self.assertIs(_read_dirblocks, dirstate._read_dirblocks)
 
769
            from bzrlib._dirstate_helpers_py import _read_dirblocks_py
 
770
            self.assertIs(_read_dirblocks_py, dirstate._read_dirblocks)
788
771
 
789
772
    def test_update_entry(self):
790
 
        if compiled_dirstate_helpers_feature.available():
791
 
            from bzrlib._dirstate_helpers_pyx import update_entry
 
773
        if CompiledDirstateHelpersFeature.available():
 
774
            from bzrlib._dirstate_helpers_c import update_entry
 
775
            self.assertIs(update_entry, dirstate.update_entry)
792
776
        else:
793
 
            from bzrlib.dirstate import update_entry
794
 
        self.assertIs(update_entry, dirstate.update_entry)
 
777
            from bzrlib.dirstate import py_update_entry
 
778
            self.assertIs(py_update_entry, dirstate.py_update_entry)
795
779
 
796
780
    def test_process_entry(self):
797
 
        if compiled_dirstate_helpers_feature.available():
798
 
            from bzrlib._dirstate_helpers_pyx import ProcessEntryC
 
781
        if CompiledDirstateHelpersFeature.available():
 
782
            from bzrlib._dirstate_helpers_c import ProcessEntryC
799
783
            self.assertIs(ProcessEntryC, dirstate._process_entry)
800
784
        else:
801
785
            from bzrlib.dirstate import ProcessEntryPython
805
789
class TestUpdateEntry(test_dirstate.TestCaseWithDirState):
806
790
    """Test the DirState.update_entry functions"""
807
791
 
808
 
    scenarios = multiply_scenarios(
809
 
        dir_reader_scenarios(), ue_scenarios)
810
 
 
811
 
    # Set by load_tests
812
 
    update_entry = None
813
 
 
814
 
    def setUp(self):
815
 
        super(TestUpdateEntry, self).setUp()
816
 
        self.overrideAttr(dirstate, 'update_entry', self.update_entry)
817
 
 
818
792
    def get_state_with_a(self):
819
793
        """Create a DirState tracking a single object named 'a'"""
820
794
        state = test_dirstate.InstrumentedDirState.initialize('dirstate')
821
795
        self.addCleanup(state.unlock)
822
796
        state.add('a', 'a-id', 'file', None, '')
823
797
        entry = state._get_entry(0, path_utf8='a')
 
798
        self.set_update_entry()
824
799
        return state, entry
825
800
 
 
801
    def set_update_entry(self):
 
802
        self.update_entry = dirstate.py_update_entry
 
803
 
826
804
    def test_observed_sha1_cachable(self):
827
805
        state, entry = self.get_state_with_a()
828
 
        state.save()
829
806
        atime = time.time() - 10
830
807
        self.build_tree(['a'])
831
 
        statvalue = test_dirstate._FakeStat.from_stat(os.lstat('a'))
832
 
        statvalue.st_mtime = statvalue.st_ctime = atime
833
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
834
 
                         state._dirblock_state)
 
808
        statvalue = os.lstat('a')
 
809
        statvalue = test_dirstate._FakeStat(statvalue.st_size, atime, atime,
 
810
            statvalue.st_dev, statvalue.st_ino, statvalue.st_mode)
835
811
        state._observed_sha1(entry, "foo", statvalue)
836
812
        self.assertEqual('foo', entry[1][0][1])
837
813
        packed_stat = dirstate.pack_stat(statvalue)
838
814
        self.assertEqual(packed_stat, entry[1][0][4])
839
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_HASH_MODIFIED,
840
 
                         state._dirblock_state)
841
815
 
842
816
    def test_observed_sha1_not_cachable(self):
843
817
        state, entry = self.get_state_with_a()
844
 
        state.save()
845
818
        oldval = entry[1][0][1]
846
819
        oldstat = entry[1][0][4]
847
820
        self.build_tree(['a'])
848
821
        statvalue = os.lstat('a')
849
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
850
 
                         state._dirblock_state)
851
822
        state._observed_sha1(entry, "foo", statvalue)
852
823
        self.assertEqual(oldval, entry[1][0][1])
853
824
        self.assertEqual(oldstat, entry[1][0][4])
854
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
855
 
                         state._dirblock_state)
856
825
 
857
826
    def test_update_entry(self):
858
827
        state, _ = self.get_state_with_a()
883
852
                                          stat_value=stat_value)
884
853
        self.assertEqual(None, link_or_sha1)
885
854
 
886
 
        # The dirblock entry should not have computed or cached the file's
887
 
        # sha1, but it did update the files' st_size. However, this is not
888
 
        # worth writing a dirstate file for, so we leave the state UNMODIFIED
 
855
        # The dirblock entry should not have cached the file's sha1 (too new)
889
856
        self.assertEqual(('f', '', 14, False, dirstate.DirState.NULLSTAT),
890
857
                         entry[1][0])
891
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
 
858
        self.assertEqual(dirstate.DirState.IN_MEMORY_MODIFIED,
892
859
                         state._dirblock_state)
893
860
        mode = stat_value.st_mode
894
861
        self.assertEqual([('is_exec', mode, False)], state._log)
897
864
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
898
865
                         state._dirblock_state)
899
866
 
900
 
        # Roll the clock back so the file is guaranteed to look too new. We
901
 
        # should still not compute the sha1.
 
867
        # If we do it again right away, we don't know if the file has changed
 
868
        # so we will re-read the file. Roll the clock back so the file is
 
869
        # guaranteed to look too new.
902
870
        state.adjust_time(-10)
903
871
        del state._log[:]
904
872
 
906
874
                                          stat_value=stat_value)
907
875
        self.assertEqual([('is_exec', mode, False)], state._log)
908
876
        self.assertEqual(None, link_or_sha1)
909
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
 
877
        self.assertEqual(dirstate.DirState.IN_MEMORY_MODIFIED,
910
878
                         state._dirblock_state)
911
879
        self.assertEqual(('f', '', 14, False, dirstate.DirState.NULLSTAT),
912
880
                         entry[1][0])
922
890
        self.assertEqual([('is_exec', mode, False)], state._log)
923
891
        self.assertEqual(('f', '', 14, False, dirstate.DirState.NULLSTAT),
924
892
                         entry[1][0])
925
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
926
 
                         state._dirblock_state)
927
893
 
928
894
        # If the file is no longer new, and the clock has been moved forward
929
895
        # sufficiently, it will cache the sha.
954
920
 
955
921
    def test_update_entry_symlink(self):
956
922
        """Update entry should read symlinks."""
957
 
        self.requireFeature(features.SymlinkFeature)
 
923
        self.requireFeature(SymlinkFeature)
958
924
        state, entry = self.get_state_with_a()
959
925
        state.save()
960
926
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
971
937
        # Dirblock is not updated (the link is too new)
972
938
        self.assertEqual([('l', '', 6, False, dirstate.DirState.NULLSTAT)],
973
939
                         entry[1])
974
 
        # The file entry turned into a symlink, that is considered
975
 
        # HASH modified worthy.
976
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_HASH_MODIFIED,
 
940
        self.assertEqual(dirstate.DirState.IN_MEMORY_MODIFIED,
977
941
                         state._dirblock_state)
978
942
 
979
943
        # Because the stat_value looks new, we should re-read the target
980
 
        del state._log[:]
981
944
        link_or_sha1 = self.update_entry(state, entry, abspath='a',
982
945
                                          stat_value=stat_value)
983
946
        self.assertEqual('target', link_or_sha1)
984
 
        self.assertEqual([('read_link', 'a', '')], state._log)
 
947
        self.assertEqual([('read_link', 'a', ''),
 
948
                          ('read_link', 'a', ''),
 
949
                         ], state._log)
985
950
        self.assertEqual([('l', '', 6, False, dirstate.DirState.NULLSTAT)],
986
951
                         entry[1])
987
 
        state.save()
988
952
        state.adjust_time(+20) # Skip into the future, all files look old
989
 
        del state._log[:]
990
953
        link_or_sha1 = self.update_entry(state, entry, abspath='a',
991
954
                                          stat_value=stat_value)
992
 
        # The symlink stayed a symlink. So while it is new enough to cache, we
993
 
        # don't bother setting the flag, because it is not really worth saving
994
 
        # (when we stat the symlink, we'll have paged in the target.)
995
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
996
 
                         state._dirblock_state)
997
955
        self.assertEqual('target', link_or_sha1)
998
956
        # We need to re-read the link because only now can we cache it
999
 
        self.assertEqual([('read_link', 'a', '')], state._log)
 
957
        self.assertEqual([('read_link', 'a', ''),
 
958
                          ('read_link', 'a', ''),
 
959
                          ('read_link', 'a', ''),
 
960
                         ], state._log)
1000
961
        self.assertEqual([('l', 'target', 6, False, packed_stat)],
1001
962
                         entry[1])
1002
963
 
1003
 
        del state._log[:]
1004
964
        # Another call won't re-read the link
1005
 
        self.assertEqual([], state._log)
 
965
        self.assertEqual([('read_link', 'a', ''),
 
966
                          ('read_link', 'a', ''),
 
967
                          ('read_link', 'a', ''),
 
968
                         ], state._log)
1006
969
        link_or_sha1 = self.update_entry(state, entry, abspath='a',
1007
970
                                          stat_value=stat_value)
1008
971
        self.assertEqual('target', link_or_sha1)
1023
986
        self.build_tree(['a/'])
1024
987
        state.adjust_time(+20)
1025
988
        self.assertIs(None, self.do_update_entry(state, entry, 'a'))
1026
 
        # a/ used to be a file, but is now a directory, worth saving
1027
989
        self.assertEqual(dirstate.DirState.IN_MEMORY_MODIFIED,
1028
990
                         state._dirblock_state)
1029
991
        state.save()
1030
992
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
1031
993
                         state._dirblock_state)
1032
 
        # No changes to a/ means not worth saving.
1033
 
        self.assertIs(None, self.do_update_entry(state, entry, 'a'))
1034
 
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
1035
 
                         state._dirblock_state)
1036
 
        # Change the last-modified time for the directory
1037
 
        t = time.time() - 100.0
1038
 
        try:
1039
 
            os.utime('a', (t, t))
1040
 
        except OSError:
1041
 
            # It looks like Win32 + FAT doesn't allow to change times on a dir.
1042
 
            raise tests.TestSkipped("can't update mtime of a dir on FAT")
1043
 
        saved_packed_stat = entry[1][0][-1]
1044
 
        self.assertIs(None, self.do_update_entry(state, entry, 'a'))
1045
 
        # We *do* go ahead and update the information in the dirblocks, but we
1046
 
        # don't bother setting IN_MEMORY_MODIFIED because it is trivial to
1047
 
        # recompute.
1048
 
        self.assertNotEqual(saved_packed_stat, entry[1][0][-1])
 
994
        self.assertIs(None, self.do_update_entry(state, entry, 'a'))
1049
995
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
1050
996
                         state._dirblock_state)
1051
997
 
1074
1020
        self.assertEqual(dirstate.DirState.IN_MEMORY_UNMODIFIED,
1075
1021
                         state._dirblock_state)
1076
1022
 
1077
 
    def test_update_entry_tree_reference(self):
1078
 
        state = test_dirstate.InstrumentedDirState.initialize('dirstate')
1079
 
        self.addCleanup(state.unlock)
1080
 
        state.add('r', 'r-id', 'tree-reference', None, '')
1081
 
        self.build_tree(['r/'])
1082
 
        entry = state._get_entry(0, path_utf8='r')
1083
 
        self.do_update_entry(state, entry, 'r')
1084
 
        entry = state._get_entry(0, path_utf8='r')
1085
 
        self.assertEqual('t', entry[1][0][0])
1086
 
 
1087
1023
    def create_and_test_file(self, state, entry):
1088
1024
        """Create a file at 'a' and verify the state finds it during update.
1089
1025
 
1116
1052
 
1117
1053
        return packed_stat
1118
1054
 
1119
 
    # FIXME: Add unicode version
1120
1055
    def create_and_test_symlink(self, state, entry):
1121
1056
        """Create a symlink at 'a' and verify the state finds it.
1122
1057
 
1151
1086
 
1152
1087
    def test_update_file_to_symlink(self):
1153
1088
        """File becomes a symlink"""
1154
 
        self.requireFeature(features.SymlinkFeature)
 
1089
        self.requireFeature(SymlinkFeature)
1155
1090
        state, entry = self.get_state_with_a()
1156
1091
        # The file sha1 won't be cached unless the file is old
1157
1092
        state.adjust_time(+10)
1170
1105
 
1171
1106
    def test_update_dir_to_symlink(self):
1172
1107
        """Directory becomes a symlink"""
1173
 
        self.requireFeature(features.SymlinkFeature)
 
1108
        self.requireFeature(SymlinkFeature)
1174
1109
        state, entry = self.get_state_with_a()
1175
1110
        # The symlink target won't be cached if it isn't old
1176
1111
        state.adjust_time(+10)
1180
1115
 
1181
1116
    def test_update_symlink_to_file(self):
1182
1117
        """Symlink becomes a file"""
1183
 
        self.requireFeature(features.SymlinkFeature)
 
1118
        self.requireFeature(SymlinkFeature)
1184
1119
        state, entry = self.get_state_with_a()
1185
1120
        # The symlink and file info won't be cached unless old
1186
1121
        state.adjust_time(+10)
1190
1125
 
1191
1126
    def test_update_symlink_to_dir(self):
1192
1127
        """Symlink becomes a directory"""
1193
 
        self.requireFeature(features.SymlinkFeature)
 
1128
        self.requireFeature(SymlinkFeature)
1194
1129
        state, entry = self.get_state_with_a()
1195
1130
        # The symlink target won't be cached if it isn't old
1196
1131
        state.adjust_time(+10)
1219
1154
        self.assertEqual([('f', '', 14, True, dirstate.DirState.NULLSTAT)],
1220
1155
                         entry[1])
1221
1156
 
1222
 
        # Make the disk object look old enough to cache (but it won't cache the
1223
 
        # sha as it is a new file).
 
1157
        # Make the disk object look old enough to cache (but it won't cache the sha
 
1158
        # as it is a new file).
1224
1159
        state.adjust_time(+20)
1225
1160
        digest = 'b50e5406bb5e153ebbeb20268fcf37c87e1ecfb6'
1226
1161
        self.update_entry(state, entry, abspath='a', stat_value=stat_value)
1227
1162
        self.assertEqual([('f', '', 14, True, dirstate.DirState.NULLSTAT)],
1228
1163
            entry[1])
1229
1164
 
1230
 
    def _prepare_tree(self):
1231
 
        # Create a tree
1232
 
        text = 'Hello World\n'
1233
 
        tree = self.make_branch_and_tree('tree')
1234
 
        self.build_tree_contents([('tree/a file', text)])
1235
 
        tree.add('a file', 'a-file-id')
1236
 
        # Note: dirstate does not sha prior to the first commit
1237
 
        # so commit now in order for the test to work
1238
 
        tree.commit('first')
1239
 
        return tree, text
1240
 
 
1241
 
    def test_sha1provider_sha1_used(self):
1242
 
        tree, text = self._prepare_tree()
1243
 
        state = dirstate.DirState.from_tree(tree, 'dirstate',
1244
 
            UppercaseSHA1Provider())
1245
 
        self.addCleanup(state.unlock)
1246
 
        expected_sha = osutils.sha_string(text.upper() + "foo")
1247
 
        entry = state._get_entry(0, path_utf8='a file')
1248
 
        state._sha_cutoff_time()
1249
 
        state._cutoff_time += 10
1250
 
        sha1 = self.update_entry(state, entry, 'tree/a file',
1251
 
                                 os.lstat('tree/a file'))
1252
 
        self.assertEqual(expected_sha, sha1)
1253
 
 
1254
 
    def test_sha1provider_stat_and_sha1_used(self):
1255
 
        tree, text = self._prepare_tree()
1256
 
        tree.lock_write()
1257
 
        self.addCleanup(tree.unlock)
1258
 
        state = tree._current_dirstate()
1259
 
        state._sha1_provider = UppercaseSHA1Provider()
1260
 
        # If we used the standard provider, it would look like nothing has
1261
 
        # changed
1262
 
        file_ids_changed = [change[0] for change
1263
 
                            in tree.iter_changes(tree.basis_tree())]
1264
 
        self.assertEqual(['a-file-id'], file_ids_changed)
1265
 
 
1266
 
 
1267
 
class UppercaseSHA1Provider(dirstate.SHA1Provider):
1268
 
    """A custom SHA1Provider."""
1269
 
 
1270
 
    def sha1(self, abspath):
1271
 
        return self.stat_and_sha1(abspath)[1]
1272
 
 
1273
 
    def stat_and_sha1(self, abspath):
1274
 
        file_obj = file(abspath, 'rb')
1275
 
        try:
1276
 
            statvalue = os.fstat(file_obj.fileno())
1277
 
            text = ''.join(file_obj.readlines())
1278
 
            sha1 = osutils.sha_string(text.upper() + "foo")
1279
 
        finally:
1280
 
            file_obj.close()
1281
 
        return statvalue, sha1
1282
 
 
1283
 
 
1284
 
class TestProcessEntry(test_dirstate.TestCaseWithDirState):
1285
 
 
1286
 
    scenarios = multiply_scenarios(dir_reader_scenarios(), pe_scenarios)
1287
 
 
1288
 
    # Set by load_tests
1289
 
    _process_entry = None
1290
 
 
1291
 
    def setUp(self):
1292
 
        super(TestProcessEntry, self).setUp()
1293
 
        self.overrideAttr(dirstate, '_process_entry', self._process_entry)
1294
 
 
1295
 
    def assertChangedFileIds(self, expected, tree):
1296
 
        tree.lock_read()
1297
 
        try:
1298
 
            file_ids = [info[0] for info
1299
 
                        in tree.iter_changes(tree.basis_tree())]
1300
 
        finally:
1301
 
            tree.unlock()
1302
 
        self.assertEqual(sorted(expected), sorted(file_ids))
1303
 
 
1304
 
    def test_exceptions_raised(self):
1305
 
        # This is a direct test of bug #495023, it relies on osutils.is_inside
1306
 
        # getting called in an inner function. Which makes it a bit brittle,
1307
 
        # but at least it does reproduce the bug.
1308
 
        tree = self.make_branch_and_tree('tree')
1309
 
        self.build_tree(['tree/file', 'tree/dir/', 'tree/dir/sub',
1310
 
                         'tree/dir2/', 'tree/dir2/sub2'])
1311
 
        tree.add(['file', 'dir', 'dir/sub', 'dir2', 'dir2/sub2'])
1312
 
        tree.commit('first commit')
1313
 
        tree.lock_read()
1314
 
        self.addCleanup(tree.unlock)
1315
 
        basis_tree = tree.basis_tree()
1316
 
        def is_inside_raises(*args, **kwargs):
1317
 
            raise RuntimeError('stop this')
1318
 
        self.overrideAttr(osutils, 'is_inside', is_inside_raises)
1319
 
        self.assertListRaises(RuntimeError, tree.iter_changes, basis_tree)
1320
 
 
1321
 
    def test_simple_changes(self):
1322
 
        tree = self.make_branch_and_tree('tree')
1323
 
        self.build_tree(['tree/file'])
1324
 
        tree.add(['file'], ['file-id'])
1325
 
        self.assertChangedFileIds([tree.get_root_id(), 'file-id'], tree)
1326
 
        tree.commit('one')
1327
 
        self.assertChangedFileIds([], tree)
1328
 
 
1329
 
    def test_sha1provider_stat_and_sha1_used(self):
1330
 
        tree = self.make_branch_and_tree('tree')
1331
 
        self.build_tree(['tree/file'])
1332
 
        tree.add(['file'], ['file-id'])
1333
 
        tree.commit('one')
1334
 
        tree.lock_write()
1335
 
        self.addCleanup(tree.unlock)
1336
 
        state = tree._current_dirstate()
1337
 
        state._sha1_provider = UppercaseSHA1Provider()
1338
 
        self.assertChangedFileIds(['file-id'], tree)
1339
 
 
 
1165
 
 
1166
class TestCompiledUpdateEntry(TestUpdateEntry):
 
1167
    """Test the pyrex implementation of _read_dirblocks"""
 
1168
 
 
1169
    _test_needs_features = [CompiledDirstateHelpersFeature]
 
1170
 
 
1171
    def set_update_entry(self):
 
1172
        from bzrlib._dirstate_helpers_c import update_entry
 
1173
        self.update_entry = update_entry