~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_commit.py

  • Committer: John Arbash Meinel
  • Date: 2008-09-26 22:14:42 UTC
  • mto: This revision was merged to the branch mainline in revision 3747.
  • Revision ID: john@arbash-meinel.com-20080926221442-3r67j99sr9rwe9w0
Make message optional, don't check the memory flag directly.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005, 2006 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
18
18
"""Tests for the commit CLI of bzr."""
19
19
 
20
20
import os
21
 
import re
22
21
import sys
23
22
 
 
23
import bzrlib
24
24
from bzrlib import (
 
25
    osutils,
25
26
    ignores,
 
27
    osutils,
26
28
    )
27
 
from bzrlib.branch import Branch
28
29
from bzrlib.bzrdir import BzrDir
29
 
from bzrlib.errors import BzrCommandError
 
30
from bzrlib.tests import (
 
31
    probe_bad_non_ascii,
 
32
    TestSkipped,
 
33
    )
30
34
from bzrlib.tests.blackbox import ExternalBase
31
 
from bzrlib.workingtree import WorkingTree
32
35
 
33
36
 
34
37
class TestCommit(ExternalBase):
36
39
    def test_05_empty_commit(self):
37
40
        """Commit of tree with no versioned files should fail"""
38
41
        # If forced, it should succeed, but this is not tested here.
39
 
        self.run_bzr("init")
 
42
        self.make_branch_and_tree('.')
40
43
        self.build_tree(['hello.txt'])
41
44
        out,err = self.run_bzr('commit -m empty', retcode=3)
42
45
        self.assertEqual('', out)
43
 
        self.assertStartsWith(err, 'bzr: ERROR: no changes to commit.'
 
46
        self.assertContainsRe(err, 'bzr: ERROR: no changes to commit\.'
44
47
                                  ' use --unchanged to commit anyhow\n')
45
48
 
46
49
    def test_commit_success(self):
47
50
        """Successful commit should not leave behind a bzr-commit-* file"""
48
 
        self.run_bzr("init")
 
51
        self.make_branch_and_tree('.')
49
52
        self.run_bzr('commit --unchanged -m message')
50
53
        self.assertEqual('', self.run_bzr('unknowns')[0])
51
54
 
55
58
 
56
59
    def test_commit_with_path(self):
57
60
        """Commit tree with path of root specified"""
58
 
        self.run_bzr('init a')
 
61
        a_tree = self.make_branch_and_tree('a')
59
62
        self.build_tree(['a/a_file'])
60
 
        self.run_bzr('add a/a_file')
 
63
        a_tree.add('a_file')
61
64
        self.run_bzr(['commit', '-m', 'first commit', 'a'])
62
65
 
63
 
        self.run_bzr('branch a b')
 
66
        b_tree = a_tree.bzrdir.sprout('b').open_workingtree()
64
67
        self.build_tree_contents([('b/a_file', 'changes in b')])
65
68
        self.run_bzr(['commit', '-m', 'first commit in b', 'b'])
66
69
 
67
70
        self.build_tree_contents([('a/a_file', 'new contents')])
68
71
        self.run_bzr(['commit', '-m', 'change in a', 'a'])
69
72
 
70
 
        os.chdir('b')
71
 
        self.run_bzr('merge ../a', retcode=1) # will conflict
72
 
        os.chdir('..')
 
73
        b_tree.merge_from_branch(a_tree.branch)
 
74
        self.assertEqual(len(b_tree.conflicts()), 1)
73
75
        self.run_bzr('resolved b/a_file')
74
76
        self.run_bzr(['commit', '-m', 'merge into b', 'b'])
75
77
 
76
78
 
77
79
    def test_10_verbose_commit(self):
78
80
        """Add one file and examine verbose commit output"""
79
 
        self.run_bzr("init")
 
81
        tree = self.make_branch_and_tree('.')
80
82
        self.build_tree(['hello.txt'])
81
 
        self.run_bzr("add hello.txt")
 
83
        tree.add("hello.txt")
82
84
        out,err = self.run_bzr('commit -m added')
83
85
        self.assertEqual('', out)
84
 
        self.assertEqual('added hello.txt\n'
85
 
                         'Committed revision 1.\n',
86
 
                         err)
 
86
        self.assertContainsRe(err, '^Committing to: .*\n'
 
87
                              'added hello.txt\n'
 
88
                              'Committed revision 1.\n$',)
87
89
 
88
90
    def prepare_simple_history(self):
89
91
        """Prepare and return a working tree with one commit of one file"""
100
102
        self.build_tree_contents([('hello.txt', 'new contents')])
101
103
        out, err = self.run_bzr('commit -m modified')
102
104
        self.assertEqual('', out)
103
 
        self.assertEqual('modified hello.txt\n'
104
 
                         'Committed revision 2.\n',
105
 
                         err)
 
105
        self.assertContainsRe(err, '^Committing to: .*\n'
 
106
                              'modified hello\.txt\n'
 
107
                              'Committed revision 2\.\n$')
106
108
 
107
109
    def test_verbose_commit_renamed(self):
108
110
        # Verbose commit of renamed file should say so
110
112
        wt.rename_one('hello.txt', 'gutentag.txt')
111
113
        out, err = self.run_bzr('commit -m renamed')
112
114
        self.assertEqual('', out)
113
 
        self.assertEqual('renamed hello.txt => gutentag.txt\n'
114
 
                         'Committed revision 2.\n',
115
 
                         err)
 
115
        self.assertContainsRe(err, '^Committing to: .*\n'
 
116
                              'renamed hello\.txt => gutentag\.txt\n'
 
117
                              'Committed revision 2\.$\n')
116
118
 
117
119
    def test_verbose_commit_moved(self):
118
120
        # Verbose commit of file moved to new directory should say so
122
124
        wt.rename_one('hello.txt', 'subdir/hello.txt')
123
125
        out, err = self.run_bzr('commit -m renamed')
124
126
        self.assertEqual('', out)
125
 
        self.assertEqualDiff('added subdir\n'
126
 
                             'renamed hello.txt => subdir/hello.txt\n'
127
 
                             'Committed revision 2.\n',
128
 
                             err)
 
127
        self.assertContainsRe(err, '^Committing to: .*\n'
 
128
                              'added subdir\n'
 
129
                              'renamed hello\.txt => subdir/hello\.txt\n'
 
130
                              'Committed revision 2\.\n$')
129
131
 
130
132
    def test_verbose_commit_with_unknown(self):
131
133
        """Unknown files should not be listed by default in verbose output"""
135
137
        wt.add(['hello.txt'])
136
138
        out,err = self.run_bzr('commit -m added')
137
139
        self.assertEqual('', out)
138
 
        self.assertEqual('added hello.txt\n'
139
 
                         'Committed revision 1.\n',
140
 
                         err)
 
140
        self.assertContainsRe(err, '^Committing to: .*\n'
 
141
                              'added hello\.txt\n'
 
142
                              'Committed revision 1\.\n$')
141
143
 
142
144
    def test_verbose_commit_with_unchanged(self):
143
145
        """Unchanged files should not be listed by default in verbose output"""
144
 
        self.run_bzr("init")
 
146
        tree = self.make_branch_and_tree('.')
145
147
        self.build_tree(['hello.txt', 'unchanged.txt'])
146
 
        self.run_bzr('add unchanged.txt')
 
148
        tree.add('unchanged.txt')
147
149
        self.run_bzr('commit -m unchanged unchanged.txt')
148
 
        self.run_bzr("add hello.txt")
 
150
        tree.add("hello.txt")
149
151
        out,err = self.run_bzr('commit -m added')
150
152
        self.assertEqual('', out)
151
 
        self.assertEqual('added hello.txt\n'
152
 
                         'Committed revision 2.\n',
153
 
                         err)
 
153
        self.assertContainsRe(err, '^Committing to: .*\n'
 
154
                              'added hello\.txt\n'
 
155
                              'Committed revision 2\.$\n')
 
156
 
 
157
    def test_verbose_commit_includes_master_location(self):
 
158
        """Location of master is displayed when committing to bound branch"""
 
159
        a_tree = self.make_branch_and_tree('a')
 
160
        self.build_tree(['a/b'])
 
161
        a_tree.add('b')
 
162
        a_tree.commit(message='Initial message')
 
163
 
 
164
        b_tree = a_tree.branch.create_checkout('b')
 
165
        expected = "%s/" % (osutils.abspath('a'), )
 
166
        out, err = self.run_bzr('commit -m blah --unchanged', working_dir='b')
 
167
        self.assertEqual(err, 'Committing to: %s\n'
 
168
                         'Committed revision 2.\n' % expected)
154
169
 
155
170
    def test_commit_merge_reports_all_modified_files(self):
156
171
        # the commit command should show all the files that are shown by
189
204
            other_tree.rename_one('dirtorename', 'renameddir')
190
205
            other_tree.rename_one('dirtoreparent', 'renameddir/reparenteddir')
191
206
            other_tree.rename_one('filetorename', 'renamedfile')
192
 
            other_tree.rename_one('filetoreparent', 'renameddir/reparentedfile')
 
207
            other_tree.rename_one('filetoreparent',
 
208
                                  'renameddir/reparentedfile')
193
209
            other_tree.remove(['dirtoremove', 'filetoremove'])
194
210
            self.build_tree_contents([
195
 
                ('other/newdir/', ),
 
211
                ('other/newdir/',),
196
212
                ('other/filetomodify', 'new content'),
197
213
                ('other/newfile', 'new file content')])
198
214
            other_tree.add('newfile')
203
219
        this_tree.merge_from_branch(other_tree.branch)
204
220
        os.chdir('this')
205
221
        out,err = self.run_bzr('commit -m added')
206
 
        os.chdir('..')
207
222
        self.assertEqual('', out)
 
223
        expected = '%s/' % (osutils.getcwd(), )
208
224
        self.assertEqualDiff(
 
225
            'Committing to: %s\n'
209
226
            'modified filetomodify\n'
210
227
            'added newdir\n'
211
228
            'added newfile\n'
212
229
            'renamed dirtorename => renameddir\n'
 
230
            'renamed filetorename => renamedfile\n'
213
231
            'renamed dirtoreparent => renameddir/reparenteddir\n'
214
232
            'renamed filetoreparent => renameddir/reparentedfile\n'
215
 
            'renamed filetorename => renamedfile\n'
216
233
            'deleted dirtoremove\n'
217
234
            'deleted filetoremove\n'
218
 
            'Committed revision 2.\n',
 
235
            'Committed revision 2.\n' % (expected, ),
219
236
            err)
220
237
 
221
238
    def test_empty_commit_message(self):
222
 
        self.run_bzr("init")
223
 
        file('foo.c', 'wt').write('int main() {}')
224
 
        self.run_bzr('add foo.c')
 
239
        tree = self.make_branch_and_tree('.')
 
240
        self.build_tree_contents([('foo.c', 'int main() {}')])
 
241
        tree.add('foo.c')
225
242
        self.run_bzr('commit -m ""', retcode=3)
226
243
 
 
244
    def test_unsupported_encoding_commit_message(self):
 
245
        tree = self.make_branch_and_tree('.')
 
246
        self.build_tree_contents([('foo.c', 'int main() {}')])
 
247
        tree.add('foo.c')
 
248
        # LANG env variable has no effect on Windows
 
249
        # but some characters anyway cannot be represented
 
250
        # in default user encoding
 
251
        char = probe_bad_non_ascii(bzrlib.user_encoding)
 
252
        if char is None:
 
253
            raise TestSkipped('Cannot find suitable non-ascii character'
 
254
                'for user_encoding (%s)' % bzrlib.user_encoding)
 
255
        out,err = self.run_bzr_subprocess('commit -m "%s"' % char,
 
256
                                          retcode=1,
 
257
                                          env_changes={'LANG': 'C'})
 
258
        self.assertContainsRe(err, r'bzrlib.errors.BzrError: Parameter.*is '
 
259
                                    'unsupported by the current encoding.')
 
260
 
227
261
    def test_other_branch_commit(self):
228
262
        # this branch is to ensure consistent behaviour, whether we're run
229
263
        # inside a branch, or not.
230
 
        os.mkdir('empty_branch')
231
 
        os.chdir('empty_branch')
232
 
        self.run_bzr('init')
233
 
        os.mkdir('branch')
234
 
        os.chdir('branch')
235
 
        self.run_bzr('init')
236
 
        file('foo.c', 'wt').write('int main() {}')
237
 
        file('bar.c', 'wt').write('int main() {}')
238
 
        os.chdir('..')
239
 
        self.run_bzr('add branch/foo.c')
240
 
        self.run_bzr('add branch')
 
264
        outer_tree = self.make_branch_and_tree('.')
 
265
        inner_tree = self.make_branch_and_tree('branch')
 
266
        self.build_tree_contents([
 
267
            ('branch/foo.c', 'int main() {}'),
 
268
            ('branch/bar.c', 'int main() {}')])
 
269
        inner_tree.add('foo.c')
 
270
        inner_tree.add('bar.c')
241
271
        # can't commit files in different trees; sane error
242
272
        self.run_bzr('commit -m newstuff branch/foo.c .', retcode=3)
243
273
        self.run_bzr('commit -m newstuff branch/foo.c')
247
277
    def test_out_of_date_tree_commit(self):
248
278
        # check we get an error code and a clear message committing with an out
249
279
        # of date checkout
250
 
        self.make_branch_and_tree('branch')
 
280
        tree = self.make_branch_and_tree('branch')
251
281
        # make a checkout
252
 
        self.run_bzr('checkout --lightweight branch checkout')
 
282
        checkout = tree.branch.create_checkout('checkout', lightweight=True)
253
283
        # commit to the original branch to make the checkout out of date
254
 
        self.run_bzr('commit --unchanged -m message branch')
 
284
        tree.commit('message branch', allow_pointless=True)
255
285
        # now commit to the checkout should emit
256
286
        # ERROR: Out of date with the branch, 'bzr update' is suggested
257
287
        output = self.run_bzr('commit --unchanged -m checkout_message '
258
288
                             'checkout', retcode=3)
259
289
        self.assertEqual(output,
260
290
                         ('',
261
 
                          "bzr: ERROR: Working tree is out of date, please run "
262
 
                          "'bzr update'.\n"))
 
291
                          "bzr: ERROR: Working tree is out of date, please "
 
292
                          "run 'bzr update'.\n"))
263
293
 
264
294
    def test_local_commit_unbound(self):
265
295
        # a --local commit on an unbound branch is an error
275
305
        # past. This is a user story reported to fail in bug #43959 where 
276
306
        # a merge done in a checkout (using the update command) failed to
277
307
        # commit correctly.
278
 
        self.run_bzr('init trunk')
 
308
        trunk = self.make_branch_and_tree('trunk')
279
309
 
280
 
        self.run_bzr('checkout trunk u1')
 
310
        u1 = trunk.branch.create_checkout('u1')
281
311
        self.build_tree_contents([('u1/hosts', 'initial contents')])
282
 
        self.run_bzr('add u1/hosts')
 
312
        u1.add('hosts')
283
313
        self.run_bzr('commit -m add-hosts u1')
284
314
 
285
 
        self.run_bzr('checkout trunk u2')
 
315
        u2 = trunk.branch.create_checkout('u2')
286
316
        self.build_tree_contents([('u2/hosts', 'altered in u2')])
287
317
        self.run_bzr('commit -m checkin-from-u2 u2')
288
318
 
301
331
        self.build_tree_contents([('u1/hosts', 'merge resolution\n')])
302
332
        self.run_bzr('commit -m checkin-merge-of-the-offline-work-from-u1 u1')
303
333
 
 
334
    def test_commit_exclude_excludes_modified_files(self):
 
335
        """Commit -x foo should ignore changes to foo."""
 
336
        tree = self.make_branch_and_tree('.')
 
337
        self.build_tree(['a', 'b', 'c'])
 
338
        tree.smart_add(['.'])
 
339
        out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b'])
 
340
        self.assertFalse('added b' in out)
 
341
        self.assertFalse('added b' in err)
 
342
        # If b was excluded it will still be 'added' in status.
 
343
        out, err = self.run_bzr(['added'])
 
344
        self.assertEqual('b\n', out)
 
345
        self.assertEqual('', err)
 
346
 
 
347
    def test_commit_exclude_twice_uses_both_rules(self):
 
348
        """Commit -x foo -x bar should ignore changes to foo and bar."""
 
349
        tree = self.make_branch_and_tree('.')
 
350
        self.build_tree(['a', 'b', 'c'])
 
351
        tree.smart_add(['.'])
 
352
        out, err = self.run_bzr(['commit', '-m', 'test', '-x', 'b', '-x', 'c'])
 
353
        self.assertFalse('added b' in out)
 
354
        self.assertFalse('added c' in out)
 
355
        self.assertFalse('added b' in err)
 
356
        self.assertFalse('added c' in err)
 
357
        # If b was excluded it will still be 'added' in status.
 
358
        out, err = self.run_bzr(['added'])
 
359
        self.assertTrue('b\n' in out)
 
360
        self.assertTrue('c\n' in out)
 
361
        self.assertEqual('', err)
 
362
 
304
363
    def test_commit_respects_spec_for_removals(self):
305
364
        """Commit with a file spec should only commit removals that match"""
306
365
        t = self.make_branch_and_tree('.')
367
426
        output, err = self.run_bzr(
368
427
            'commit -m hello --fixes=lp:23452 tree/hello.txt')
369
428
        self.assertEqual('', output)
370
 
        self.assertEqual('added hello.txt\nCommitted revision 1.\n', err)
 
429
        self.assertContainsRe(err, 'Committing to: .*\n'
 
430
                              'added hello\.txt\n'
 
431
                              'Committed revision 1\.\n')
371
432
 
372
433
    def test_no_bugs_no_properties(self):
373
434
        """If no bugs are fixed, the bugs property is not set.
470
531
             r"Commit refused\."],
471
532
            'commit -m add-b --fixes=orange',
472
533
            working_dir='tree')
 
534
 
 
535
    def test_no_author(self):
 
536
        """If the author is not specified, the author property is not set."""
 
537
        tree = self.make_branch_and_tree('tree')
 
538
        self.build_tree(['tree/hello.txt'])
 
539
        tree.add('hello.txt')
 
540
        self.run_bzr( 'commit -m hello tree/hello.txt')
 
541
        last_rev = tree.branch.repository.get_revision(tree.last_revision())
 
542
        properties = last_rev.properties
 
543
        self.assertFalse('author' in properties)
 
544
 
 
545
    def test_author_sets_property(self):
 
546
        """commit --author='John Doe <jdoe@example.com>' sets the author
 
547
           revprop.
 
548
        """
 
549
        tree = self.make_branch_and_tree('tree')
 
550
        self.build_tree(['tree/hello.txt'])
 
551
        tree.add('hello.txt')
 
552
        self.run_bzr(["commit", '-m', 'hello',
 
553
                      '--author', u'John D\xf6 <jdoe@example.com>',
 
554
                     "tree/hello.txt"])
 
555
        last_rev = tree.branch.repository.get_revision(tree.last_revision())
 
556
        properties = last_rev.properties
 
557
        self.assertEqual(u'John D\xf6 <jdoe@example.com>', properties['author'])
 
558
 
 
559
    def test_author_no_email(self):
 
560
        """Author's name without an email address is allowed, too."""
 
561
        tree = self.make_branch_and_tree('tree')
 
562
        self.build_tree(['tree/hello.txt'])
 
563
        tree.add('hello.txt')
 
564
        out, err = self.run_bzr("commit -m hello --author='John Doe' "
 
565
                                "tree/hello.txt")
 
566
        last_rev = tree.branch.repository.get_revision(tree.last_revision())
 
567
        properties = last_rev.properties
 
568
        self.assertEqual('John Doe', properties['author'])
 
569
 
 
570
    def test_partial_commit_with_renames_in_tree(self):
 
571
        # this test illustrates bug #140419
 
572
        t = self.make_branch_and_tree('.')
 
573
        self.build_tree(['dir/', 'dir/a', 'test'])
 
574
        t.add(['dir/', 'dir/a', 'test'])
 
575
        t.commit('initial commit')
 
576
        # important part: file dir/a should change parent
 
577
        # and should appear before old parent
 
578
        # then during partial commit we have error
 
579
        # parent_id {dir-XXX} not in inventory
 
580
        t.rename_one('dir/a', 'a')
 
581
        self.build_tree_contents([('test', 'changes in test')])
 
582
        # partial commit
 
583
        out, err = self.run_bzr('commit test -m "partial commit"')
 
584
        self.assertEquals('', out)
 
585
        self.assertContainsRe(err, r'modified test\nCommitted revision 2.')
 
586
 
 
587
    def test_commit_readonly_checkout(self):
 
588
        # https://bugs.edge.launchpad.net/bzr/+bug/129701
 
589
        # "UnlockableTransport error trying to commit in checkout of readonly
 
590
        # branch"
 
591
        self.make_branch('master')
 
592
        master = BzrDir.open_from_transport(
 
593
            self.get_readonly_transport('master')).open_branch()
 
594
        master.create_checkout('checkout')
 
595
        out, err = self.run_bzr(['commit', '--unchanged', '-mfoo', 'checkout'],
 
596
            retcode=3)
 
597
        self.assertContainsRe(err,
 
598
            r'^bzr: ERROR: Cannot lock.*readonly transport')