~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_remote.py

  • Committer: John Arbash Meinel
  • Author(s): Mark Hammond
  • Date: 2008-09-09 17:02:21 UTC
  • mto: This revision was merged to the branch mainline in revision 3697.
  • Revision ID: john@arbash-meinel.com-20080909170221-svim3jw2mrz0amp3
An updated transparent icon for bzr.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006, 2007, 2008, 2009 Canonical Ltd
 
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
"""Tests for remote bzrdir/branch/repo/etc
18
18
 
19
19
These are proxy objects which act on remote objects by sending messages
20
20
through a smart client.  The proxies are to be created when attempting to open
21
 
the object given a transport that supports smartserver rpc operations.
 
21
the object given a transport that supports smartserver rpc operations. 
22
22
 
23
23
These tests correspond to tests.test_smart, which exercises the server side.
24
24
"""
27
27
from cStringIO import StringIO
28
28
 
29
29
from bzrlib import (
30
 
    bzrdir,
31
 
    config,
32
30
    errors,
33
31
    graph,
34
 
    inventory,
35
 
    inventory_delta,
36
32
    pack,
37
33
    remote,
38
34
    repository,
39
 
    smart,
40
35
    tests,
41
 
    treebuilder,
42
 
    urlutils,
43
 
    versionedfile,
44
36
    )
45
37
from bzrlib.branch import Branch
46
38
from bzrlib.bzrdir import BzrDir, BzrDirFormat
47
39
from bzrlib.remote import (
48
40
    RemoteBranch,
49
 
    RemoteBranchFormat,
50
41
    RemoteBzrDir,
51
42
    RemoteBzrDirFormat,
52
43
    RemoteRepository,
53
 
    RemoteRepositoryFormat,
54
44
    )
55
 
from bzrlib.repofmt import groupcompress_repo, pack_repo
56
45
from bzrlib.revision import NULL_REVISION
57
46
from bzrlib.smart import server, medium
58
47
from bzrlib.smart.client import _SmartClient
59
 
from bzrlib.smart.repository import SmartServerRepositoryGetParentMap
60
 
from bzrlib.tests import (
61
 
    condition_isinstance,
62
 
    split_suite_by_condition,
63
 
    multiply_tests,
64
 
    KnownFailure,
65
 
    )
 
48
from bzrlib.symbol_versioning import one_four
66
49
from bzrlib.transport import get_transport, http
67
50
from bzrlib.transport.memory import MemoryTransport
68
 
from bzrlib.transport.remote import (
69
 
    RemoteTransport,
70
 
    RemoteSSHTransport,
71
 
    RemoteTCPTransport,
72
 
)
73
 
 
74
 
def load_tests(standard_tests, module, loader):
75
 
    to_adapt, result = split_suite_by_condition(
76
 
        standard_tests, condition_isinstance(BasicRemoteObjectTests))
77
 
    smart_server_version_scenarios = [
78
 
        ('HPSS-v2',
79
 
            {'transport_server': server.SmartTCPServer_for_testing_v2_only}),
80
 
        ('HPSS-v3',
81
 
            {'transport_server': server.SmartTCPServer_for_testing})]
82
 
    return multiply_tests(to_adapt, smart_server_version_scenarios, result)
 
51
from bzrlib.transport.remote import RemoteTransport, RemoteTCPTransport
83
52
 
84
53
 
85
54
class BasicRemoteObjectTests(tests.TestCaseWithTransport):
86
55
 
87
56
    def setUp(self):
 
57
        self.transport_server = server.SmartTCPServer_for_testing
88
58
        super(BasicRemoteObjectTests, self).setUp()
89
59
        self.transport = self.get_transport()
90
60
        # make a branch that can be opened over the smart transport
95
65
        tests.TestCaseWithTransport.tearDown(self)
96
66
 
97
67
    def test_create_remote_bzrdir(self):
98
 
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
 
68
        b = remote.RemoteBzrDir(self.transport)
99
69
        self.assertIsInstance(b, BzrDir)
100
70
 
101
71
    def test_open_remote_branch(self):
102
72
        # open a standalone branch in the working directory
103
 
        b = remote.RemoteBzrDir(self.transport, remote.RemoteBzrDirFormat())
 
73
        b = remote.RemoteBzrDir(self.transport)
104
74
        branch = b.open_branch()
105
75
        self.assertIsInstance(branch, Branch)
106
76
 
135
105
        b = BzrDir.open_from_transport(self.transport).open_branch()
136
106
        self.assertStartsWith(str(b), 'RemoteBranch(')
137
107
 
138
 
    def test_remote_branch_format_supports_stacking(self):
139
 
        t = self.transport
140
 
        self.make_branch('unstackable', format='pack-0.92')
141
 
        b = BzrDir.open_from_transport(t.clone('unstackable')).open_branch()
142
 
        self.assertFalse(b._format.supports_stacking())
143
 
        self.make_branch('stackable', format='1.9')
144
 
        b = BzrDir.open_from_transport(t.clone('stackable')).open_branch()
145
 
        self.assertTrue(b._format.supports_stacking())
146
 
 
147
 
    def test_remote_repo_format_supports_external_references(self):
148
 
        t = self.transport
149
 
        bd = self.make_bzrdir('unstackable', format='pack-0.92')
150
 
        r = bd.create_repository()
151
 
        self.assertFalse(r._format.supports_external_lookups)
152
 
        r = BzrDir.open_from_transport(t.clone('unstackable')).open_repository()
153
 
        self.assertFalse(r._format.supports_external_lookups)
154
 
        bd = self.make_bzrdir('stackable', format='1.9')
155
 
        r = bd.create_repository()
156
 
        self.assertTrue(r._format.supports_external_lookups)
157
 
        r = BzrDir.open_from_transport(t.clone('stackable')).open_repository()
158
 
        self.assertTrue(r._format.supports_external_lookups)
159
 
 
160
 
    def test_remote_branch_set_append_revisions_only(self):
161
 
        # Make a format 1.9 branch, which supports append_revisions_only
162
 
        branch = self.make_branch('branch', format='1.9')
163
 
        config = branch.get_config()
164
 
        branch.set_append_revisions_only(True)
165
 
        self.assertEqual(
166
 
            'True', config.get_user_option('append_revisions_only'))
167
 
        branch.set_append_revisions_only(False)
168
 
        self.assertEqual(
169
 
            'False', config.get_user_option('append_revisions_only'))
170
 
 
171
 
    def test_remote_branch_set_append_revisions_only_upgrade_reqd(self):
172
 
        branch = self.make_branch('branch', format='knit')
173
 
        config = branch.get_config()
174
 
        self.assertRaises(
175
 
            errors.UpgradeRequired, branch.set_append_revisions_only, True)
176
 
 
177
108
 
178
109
class FakeProtocol(object):
179
110
    """Lookalike SmartClientRequestProtocolOne allowing body reading tests."""
200
131
 
201
132
class FakeClient(_SmartClient):
202
133
    """Lookalike for _SmartClient allowing testing."""
203
 
 
 
134
    
204
135
    def __init__(self, fake_medium_base='fake base'):
205
 
        """Create a FakeClient."""
 
136
        """Create a FakeClient.
 
137
 
 
138
        :param responses: A list of response-tuple, body-data pairs to be sent
 
139
            back to callers.  A special case is if the response-tuple is
 
140
            'unknown verb', then a UnknownSmartMethod will be raised for that
 
141
            call, using the second element of the tuple as the verb in the
 
142
            exception.
 
143
        """
206
144
        self.responses = []
207
145
        self._calls = []
208
146
        self.expecting_body = False
209
 
        # if non-None, this is the list of expected calls, with only the
210
 
        # method name and arguments included.  the body might be hard to
211
 
        # compute so is not included. If a call is None, that call can
212
 
        # be anything.
213
 
        self._expected_calls = None
214
147
        _SmartClient.__init__(self, FakeMedium(self._calls, fake_medium_base))
215
148
 
216
 
    def add_expected_call(self, call_name, call_args, response_type,
217
 
        response_args, response_body=None):
218
 
        if self._expected_calls is None:
219
 
            self._expected_calls = []
220
 
        self._expected_calls.append((call_name, call_args))
221
 
        self.responses.append((response_type, response_args, response_body))
222
 
 
223
149
    def add_success_response(self, *args):
224
150
        self.responses.append(('success', args, None))
225
151
 
226
152
    def add_success_response_with_body(self, body, *args):
227
153
        self.responses.append(('success', args, body))
228
 
        if self._expected_calls is not None:
229
 
            self._expected_calls.append(None)
230
154
 
231
155
    def add_error_response(self, *args):
232
156
        self.responses.append(('error', args))
234
158
    def add_unknown_method_response(self, verb):
235
159
        self.responses.append(('unknown', verb))
236
160
 
237
 
    def finished_test(self):
238
 
        if self._expected_calls:
239
 
            raise AssertionError("%r finished but was still expecting %r"
240
 
                % (self, self._expected_calls[0]))
241
 
 
242
161
    def _get_next_response(self):
243
 
        try:
244
 
            response_tuple = self.responses.pop(0)
245
 
        except IndexError, e:
246
 
            raise AssertionError("%r didn't expect any more calls"
247
 
                % (self,))
 
162
        response_tuple = self.responses.pop(0)
248
163
        if response_tuple[0] == 'unknown':
249
164
            raise errors.UnknownSmartMethod(response_tuple[1])
250
165
        elif response_tuple[0] == 'error':
251
166
            raise errors.ErrorFromSmartServer(response_tuple[1])
252
167
        return response_tuple
253
168
 
254
 
    def _check_call(self, method, args):
255
 
        if self._expected_calls is None:
256
 
            # the test should be updated to say what it expects
257
 
            return
258
 
        try:
259
 
            next_call = self._expected_calls.pop(0)
260
 
        except IndexError:
261
 
            raise AssertionError("%r didn't expect any more calls "
262
 
                "but got %r%r"
263
 
                % (self, method, args,))
264
 
        if next_call is None:
265
 
            return
266
 
        if method != next_call[0] or args != next_call[1]:
267
 
            raise AssertionError("%r expected %r%r "
268
 
                "but got %r%r"
269
 
                % (self, next_call[0], next_call[1], method, args,))
270
 
 
271
169
    def call(self, method, *args):
272
 
        self._check_call(method, args)
273
170
        self._calls.append(('call', method, args))
274
171
        return self._get_next_response()[1]
275
172
 
276
173
    def call_expecting_body(self, method, *args):
277
 
        self._check_call(method, args)
278
174
        self._calls.append(('call_expecting_body', method, args))
279
175
        result = self._get_next_response()
280
176
        self.expecting_body = True
281
177
        return result[1], FakeProtocol(result[2], self)
282
178
 
283
179
    def call_with_body_bytes_expecting_body(self, method, args, body):
284
 
        self._check_call(method, args)
285
180
        self._calls.append(('call_with_body_bytes_expecting_body', method,
286
181
            args, body))
287
182
        result = self._get_next_response()
288
183
        self.expecting_body = True
289
184
        return result[1], FakeProtocol(result[2], self)
290
185
 
291
 
    def call_with_body_stream(self, args, stream):
292
 
        # Explicitly consume the stream before checking for an error, because
293
 
        # that's what happens a real medium.
294
 
        stream = list(stream)
295
 
        self._check_call(args[0], args[1:])
296
 
        self._calls.append(('call_with_body_stream', args[0], args[1:], stream))
297
 
        result = self._get_next_response()
298
 
        # The second value returned from call_with_body_stream is supposed to
299
 
        # be a response_handler object, but so far no tests depend on that.
300
 
        response_handler = None 
301
 
        return result[1], response_handler
302
 
 
303
186
 
304
187
class FakeMedium(medium.SmartClientMedium):
305
188
 
325
208
        self.assertTrue(result)
326
209
 
327
210
 
328
 
class TestRemote(tests.TestCaseWithMemoryTransport):
329
 
 
330
 
    def get_branch_format(self):
331
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
332
 
        return reference_bzrdir_format.get_branch_format()
333
 
 
334
 
    def get_repo_format(self):
335
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
336
 
        return reference_bzrdir_format.repository_format
337
 
 
338
 
    def assertFinished(self, fake_client):
339
 
        """Assert that all of a FakeClient's expected calls have occurred."""
340
 
        fake_client.finished_test()
341
 
 
342
 
 
343
211
class Test_ClientMedium_remote_path_from_transport(tests.TestCase):
344
212
    """Tests for the behaviour of client_medium.remote_path_from_transport."""
345
213
 
372
240
        cloned_transport = base_transport.clone(relpath)
373
241
        result = client_medium.remote_path_from_transport(cloned_transport)
374
242
        self.assertEqual(expected, result)
375
 
 
 
243
        
376
244
    def test_remote_path_from_transport_http(self):
377
245
        """Remote paths for HTTP transports are calculated differently to other
378
246
        transports.  They are just relative to the client base, not the root
394
262
        """
395
263
        client_medium = medium.SmartClientMedium('dummy base')
396
264
        self.assertFalse(client_medium._is_remote_before((99, 99)))
397
 
 
 
265
    
398
266
    def test__remember_remote_is_before(self):
399
267
        """Calling _remember_remote_is_before ratchets down the known remote
400
268
        version.
413
281
            AssertionError, client_medium._remember_remote_is_before, (1, 9))
414
282
 
415
283
 
416
 
class TestBzrDirCloningMetaDir(TestRemote):
417
 
 
418
 
    def test_backwards_compat(self):
419
 
        self.setup_smart_server_with_call_log()
420
 
        a_dir = self.make_bzrdir('.')
421
 
        self.reset_smart_call_log()
422
 
        verb = 'BzrDir.cloning_metadir'
423
 
        self.disable_verb(verb)
424
 
        format = a_dir.cloning_metadir()
425
 
        call_count = len([call for call in self.hpss_calls if
426
 
            call.call.method == verb])
427
 
        self.assertEqual(1, call_count)
428
 
 
429
 
    def test_branch_reference(self):
430
 
        transport = self.get_transport('quack')
431
 
        referenced = self.make_branch('referenced')
432
 
        expected = referenced.bzrdir.cloning_metadir()
433
 
        client = FakeClient(transport.base)
434
 
        client.add_expected_call(
435
 
            'BzrDir.cloning_metadir', ('quack/', 'False'),
436
 
            'error', ('BranchReference',)),
437
 
        client.add_expected_call(
438
 
            'BzrDir.open_branchV2', ('quack/',),
439
 
            'success', ('ref', self.get_url('referenced'))),
440
 
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
441
 
            _client=client)
442
 
        result = a_bzrdir.cloning_metadir()
443
 
        # We should have got a control dir matching the referenced branch.
444
 
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
445
 
        self.assertEqual(expected._repository_format, result._repository_format)
446
 
        self.assertEqual(expected._branch_format, result._branch_format)
447
 
        self.assertFinished(client)
448
 
 
449
 
    def test_current_server(self):
450
 
        transport = self.get_transport('.')
451
 
        transport = transport.clone('quack')
452
 
        self.make_bzrdir('quack')
453
 
        client = FakeClient(transport.base)
454
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
455
 
        control_name = reference_bzrdir_format.network_name()
456
 
        client.add_expected_call(
457
 
            'BzrDir.cloning_metadir', ('quack/', 'False'),
458
 
            'success', (control_name, '', ('branch', ''))),
459
 
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
460
 
            _client=client)
461
 
        result = a_bzrdir.cloning_metadir()
462
 
        # We should have got a reference control dir with default branch and
463
 
        # repository formats.
464
 
        # This pokes a little, just to be sure.
465
 
        self.assertEqual(bzrdir.BzrDirMetaFormat1, type(result))
466
 
        self.assertEqual(None, result._repository_format)
467
 
        self.assertEqual(None, result._branch_format)
468
 
        self.assertFinished(client)
469
 
 
470
 
 
471
 
class TestBzrDirOpenBranch(TestRemote):
472
 
 
473
 
    def test_backwards_compat(self):
474
 
        self.setup_smart_server_with_call_log()
475
 
        self.make_branch('.')
476
 
        a_dir = BzrDir.open(self.get_url('.'))
477
 
        self.reset_smart_call_log()
478
 
        verb = 'BzrDir.open_branchV2'
479
 
        self.disable_verb(verb)
480
 
        format = a_dir.open_branch()
481
 
        call_count = len([call for call in self.hpss_calls if
482
 
            call.call.method == verb])
483
 
        self.assertEqual(1, call_count)
 
284
class TestBzrDirOpenBranch(tests.TestCase):
484
285
 
485
286
    def test_branch_present(self):
486
 
        reference_format = self.get_repo_format()
487
 
        network_name = reference_format.network_name()
488
 
        branch_network_name = self.get_branch_format().network_name()
489
287
        transport = MemoryTransport()
490
288
        transport.mkdir('quack')
491
289
        transport = transport.clone('quack')
492
290
        client = FakeClient(transport.base)
493
 
        client.add_expected_call(
494
 
            'BzrDir.open_branchV2', ('quack/',),
495
 
            'success', ('branch', branch_network_name))
496
 
        client.add_expected_call(
497
 
            'BzrDir.find_repositoryV3', ('quack/',),
498
 
            'success', ('ok', '', 'no', 'no', 'no', network_name))
499
 
        client.add_expected_call(
500
 
            'Branch.get_stacked_on_url', ('quack/',),
501
 
            'error', ('NotStacked',))
502
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
503
 
            _client=client)
 
291
        client.add_success_response('ok', '')
 
292
        client.add_success_response('ok', '', 'no', 'no', 'no')
 
293
        bzrdir = RemoteBzrDir(transport, _client=client)
504
294
        result = bzrdir.open_branch()
 
295
        self.assertEqual(
 
296
            [('call', 'BzrDir.open_branch', ('quack/',)),
 
297
             ('call', 'BzrDir.find_repositoryV2', ('quack/',))],
 
298
            client._calls)
505
299
        self.assertIsInstance(result, RemoteBranch)
506
300
        self.assertEqual(bzrdir, result.bzrdir)
507
 
        self.assertFinished(client)
508
301
 
509
302
    def test_branch_missing(self):
510
303
        transport = MemoryTransport()
512
305
        transport = transport.clone('quack')
513
306
        client = FakeClient(transport.base)
514
307
        client.add_error_response('nobranch')
515
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
516
 
            _client=client)
 
308
        bzrdir = RemoteBzrDir(transport, _client=client)
517
309
        self.assertRaises(errors.NotBranchError, bzrdir.open_branch)
518
310
        self.assertEqual(
519
 
            [('call', 'BzrDir.open_branchV2', ('quack/',))],
 
311
            [('call', 'BzrDir.open_branch', ('quack/',))],
520
312
            client._calls)
521
313
 
522
314
    def test__get_tree_branch(self):
529
321
        transport = MemoryTransport()
530
322
        # no requests on the network - catches other api calls being made.
531
323
        client = FakeClient(transport.base)
532
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
533
 
            _client=client)
 
324
        bzrdir = RemoteBzrDir(transport, _client=client)
534
325
        # patch the open_branch call to record that it was called.
535
326
        bzrdir.open_branch = open_branch
536
327
        self.assertEqual((None, "a-branch"), bzrdir._get_tree_branch())
542
333
        # transmitted as "~", not "%7E".
543
334
        transport = RemoteTCPTransport('bzr://localhost/~hello/')
544
335
        client = FakeClient(transport.base)
545
 
        reference_format = self.get_repo_format()
546
 
        network_name = reference_format.network_name()
547
 
        branch_network_name = self.get_branch_format().network_name()
548
 
        client.add_expected_call(
549
 
            'BzrDir.open_branchV2', ('~hello/',),
550
 
            'success', ('branch', branch_network_name))
551
 
        client.add_expected_call(
552
 
            'BzrDir.find_repositoryV3', ('~hello/',),
553
 
            'success', ('ok', '', 'no', 'no', 'no', network_name))
554
 
        client.add_expected_call(
555
 
            'Branch.get_stacked_on_url', ('~hello/',),
556
 
            'error', ('NotStacked',))
557
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
558
 
            _client=client)
 
336
        client.add_success_response('ok', '')
 
337
        client.add_success_response('ok', '', 'no', 'no', 'no')
 
338
        bzrdir = RemoteBzrDir(transport, _client=client)
559
339
        result = bzrdir.open_branch()
560
 
        self.assertFinished(client)
 
340
        self.assertEqual(
 
341
            [('call', 'BzrDir.open_branch', ('~hello/',)),
 
342
             ('call', 'BzrDir.find_repositoryV2', ('~hello/',))],
 
343
            client._calls)
561
344
 
562
345
    def check_open_repository(self, rich_root, subtrees, external_lookup='no'):
563
 
        reference_format = self.get_repo_format()
564
 
        network_name = reference_format.network_name()
565
346
        transport = MemoryTransport()
566
347
        transport.mkdir('quack')
567
348
        transport = transport.clone('quack')
575
356
            subtree_response = 'no'
576
357
        client = FakeClient(transport.base)
577
358
        client.add_success_response(
578
 
            'ok', '', rich_response, subtree_response, external_lookup,
579
 
            network_name)
580
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
581
 
            _client=client)
 
359
            'ok', '', rich_response, subtree_response, external_lookup)
 
360
        bzrdir = RemoteBzrDir(transport, _client=client)
582
361
        result = bzrdir.open_repository()
583
362
        self.assertEqual(
584
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',))],
 
363
            [('call', 'BzrDir.find_repositoryV2', ('quack/',))],
585
364
            client._calls)
586
365
        self.assertIsInstance(result, RemoteRepository)
587
366
        self.assertEqual(bzrdir, result.bzrdir)
603
382
            RemoteBzrDirFormat.probe_transport, OldServerTransport())
604
383
 
605
384
 
606
 
class TestBzrDirCreateBranch(TestRemote):
607
 
 
608
 
    def test_backwards_compat(self):
609
 
        self.setup_smart_server_with_call_log()
610
 
        repo = self.make_repository('.')
611
 
        self.reset_smart_call_log()
612
 
        self.disable_verb('BzrDir.create_branch')
613
 
        branch = repo.bzrdir.create_branch()
614
 
        create_branch_call_count = len([call for call in self.hpss_calls if
615
 
            call.call.method == 'BzrDir.create_branch'])
616
 
        self.assertEqual(1, create_branch_call_count)
617
 
 
618
 
    def test_current_server(self):
619
 
        transport = self.get_transport('.')
620
 
        transport = transport.clone('quack')
621
 
        self.make_repository('quack')
622
 
        client = FakeClient(transport.base)
623
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
624
 
        reference_format = reference_bzrdir_format.get_branch_format()
625
 
        network_name = reference_format.network_name()
626
 
        reference_repo_fmt = reference_bzrdir_format.repository_format
627
 
        reference_repo_name = reference_repo_fmt.network_name()
628
 
        client.add_expected_call(
629
 
            'BzrDir.create_branch', ('quack/', network_name),
630
 
            'success', ('ok', network_name, '', 'no', 'no', 'yes',
631
 
            reference_repo_name))
632
 
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
633
 
            _client=client)
634
 
        branch = a_bzrdir.create_branch()
635
 
        # We should have got a remote branch
636
 
        self.assertIsInstance(branch, remote.RemoteBranch)
637
 
        # its format should have the settings from the response
638
 
        format = branch._format
639
 
        self.assertEqual(network_name, format.network_name())
640
 
 
641
 
 
642
 
class TestBzrDirCreateRepository(TestRemote):
643
 
 
644
 
    def test_backwards_compat(self):
645
 
        self.setup_smart_server_with_call_log()
646
 
        bzrdir = self.make_bzrdir('.')
647
 
        self.reset_smart_call_log()
648
 
        self.disable_verb('BzrDir.create_repository')
649
 
        repo = bzrdir.create_repository()
650
 
        create_repo_call_count = len([call for call in self.hpss_calls if
651
 
            call.call.method == 'BzrDir.create_repository'])
652
 
        self.assertEqual(1, create_repo_call_count)
653
 
 
654
 
    def test_current_server(self):
655
 
        transport = self.get_transport('.')
656
 
        transport = transport.clone('quack')
657
 
        self.make_bzrdir('quack')
658
 
        client = FakeClient(transport.base)
659
 
        reference_bzrdir_format = bzrdir.format_registry.get('default')()
660
 
        reference_format = reference_bzrdir_format.repository_format
661
 
        network_name = reference_format.network_name()
662
 
        client.add_expected_call(
663
 
            'BzrDir.create_repository', ('quack/',
664
 
                'Bazaar repository format 2a (needs bzr 1.16 or later)\n',
665
 
                'False'),
666
 
            'success', ('ok', 'yes', 'yes', 'yes', network_name))
667
 
        a_bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
668
 
            _client=client)
669
 
        repo = a_bzrdir.create_repository()
670
 
        # We should have got a remote repository
671
 
        self.assertIsInstance(repo, remote.RemoteRepository)
672
 
        # its format should have the settings from the response
673
 
        format = repo._format
674
 
        self.assertTrue(format.rich_root_data)
675
 
        self.assertTrue(format.supports_tree_reference)
676
 
        self.assertTrue(format.supports_external_lookups)
677
 
        self.assertEqual(network_name, format.network_name())
678
 
 
679
 
 
680
 
class TestBzrDirOpenRepository(TestRemote):
681
 
 
682
 
    def test_backwards_compat_1_2_3(self):
683
 
        # fallback all the way to the first version.
684
 
        reference_format = self.get_repo_format()
685
 
        network_name = reference_format.network_name()
686
 
        client = FakeClient('bzr://example.com/')
687
 
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
688
 
        client.add_unknown_method_response('BzrDir.find_repositoryV2')
 
385
class TestBzrDirOpenRepository(tests.TestCase):
 
386
 
 
387
    def test_backwards_compat_1_2(self):
 
388
        transport = MemoryTransport()
 
389
        transport.mkdir('quack')
 
390
        transport = transport.clone('quack')
 
391
        client = FakeClient(transport.base)
 
392
        client.add_unknown_method_response('RemoteRepository.find_repositoryV2')
689
393
        client.add_success_response('ok', '', 'no', 'no')
690
 
        # A real repository instance will be created to determine the network
691
 
        # name.
692
 
        client.add_success_response_with_body(
693
 
            "Bazaar-NG meta directory, format 1\n", 'ok')
694
 
        client.add_success_response_with_body(
695
 
            reference_format.get_format_string(), 'ok')
696
 
        # PackRepository wants to do a stat
697
 
        client.add_success_response('stat', '0', '65535')
698
 
        remote_transport = RemoteTransport('bzr://example.com/quack/', medium=False,
699
 
            _client=client)
700
 
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
701
 
            _client=client)
702
 
        repo = bzrdir.open_repository()
703
 
        self.assertEqual(
704
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',)),
705
 
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
706
 
             ('call', 'BzrDir.find_repository', ('quack/',)),
707
 
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
708
 
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
709
 
             ('call', 'stat', ('/quack/.bzr/repository',)),
710
 
             ],
711
 
            client._calls)
712
 
        self.assertEqual(network_name, repo._format.network_name())
713
 
 
714
 
    def test_backwards_compat_2(self):
715
 
        # fallback to find_repositoryV2
716
 
        reference_format = self.get_repo_format()
717
 
        network_name = reference_format.network_name()
718
 
        client = FakeClient('bzr://example.com/')
719
 
        client.add_unknown_method_response('BzrDir.find_repositoryV3')
720
 
        client.add_success_response('ok', '', 'no', 'no', 'no')
721
 
        # A real repository instance will be created to determine the network
722
 
        # name.
723
 
        client.add_success_response_with_body(
724
 
            "Bazaar-NG meta directory, format 1\n", 'ok')
725
 
        client.add_success_response_with_body(
726
 
            reference_format.get_format_string(), 'ok')
727
 
        # PackRepository wants to do a stat
728
 
        client.add_success_response('stat', '0', '65535')
729
 
        remote_transport = RemoteTransport('bzr://example.com/quack/', medium=False,
730
 
            _client=client)
731
 
        bzrdir = RemoteBzrDir(remote_transport, remote.RemoteBzrDirFormat(),
732
 
            _client=client)
733
 
        repo = bzrdir.open_repository()
734
 
        self.assertEqual(
735
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',)),
736
 
             ('call', 'BzrDir.find_repositoryV2', ('quack/',)),
737
 
             ('call_expecting_body', 'get', ('/quack/.bzr/branch-format',)),
738
 
             ('call_expecting_body', 'get', ('/quack/.bzr/repository/format',)),
739
 
             ('call', 'stat', ('/quack/.bzr/repository',)),
740
 
             ],
741
 
            client._calls)
742
 
        self.assertEqual(network_name, repo._format.network_name())
743
 
 
744
 
    def test_current_server(self):
745
 
        reference_format = self.get_repo_format()
746
 
        network_name = reference_format.network_name()
747
 
        transport = MemoryTransport()
748
 
        transport.mkdir('quack')
749
 
        transport = transport.clone('quack')
750
 
        client = FakeClient(transport.base)
751
 
        client.add_success_response('ok', '', 'no', 'no', 'no', network_name)
752
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
753
 
            _client=client)
754
 
        repo = bzrdir.open_repository()
755
 
        self.assertEqual(
756
 
            [('call', 'BzrDir.find_repositoryV3', ('quack/',))],
757
 
            client._calls)
758
 
        self.assertEqual(network_name, repo._format.network_name())
759
 
 
760
 
 
761
 
class TestBzrDirFormatInitializeEx(TestRemote):
762
 
 
763
 
    def test_success(self):
764
 
        """Simple test for typical successful call."""
765
 
        fmt = bzrdir.RemoteBzrDirFormat()
766
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
767
 
        transport = self.get_transport()
768
 
        client = FakeClient(transport.base)
769
 
        client.add_expected_call(
770
 
            'BzrDirFormat.initialize_ex_1.16',
771
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
772
 
                 '', '', '', 'False'),
773
 
            'success',
774
 
                ('.', 'no', 'no', 'yes', 'repo fmt', 'repo bzrdir fmt',
775
 
                 'bzrdir fmt', 'False', '', '', 'repo lock token'))
776
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
777
 
        # it's currently hard to test that without supplying a real remote
778
 
        # transport connected to a real server.
779
 
        result = fmt._initialize_on_transport_ex_rpc(client, 'path',
780
 
            transport, False, False, False, None, None, None, None, False)
781
 
        self.assertFinished(client)
782
 
 
783
 
    def test_error(self):
784
 
        """Error responses are translated, e.g. 'PermissionDenied' raises the
785
 
        corresponding error from the client.
786
 
        """
787
 
        fmt = bzrdir.RemoteBzrDirFormat()
788
 
        default_format_name = BzrDirFormat.get_default_format().network_name()
789
 
        transport = self.get_transport()
790
 
        client = FakeClient(transport.base)
791
 
        client.add_expected_call(
792
 
            'BzrDirFormat.initialize_ex_1.16',
793
 
                (default_format_name, 'path', 'False', 'False', 'False', '',
794
 
                 '', '', '', 'False'),
795
 
            'error',
796
 
                ('PermissionDenied', 'path', 'extra info'))
797
 
        # XXX: It would be better to call fmt.initialize_on_transport_ex, but
798
 
        # it's currently hard to test that without supplying a real remote
799
 
        # transport connected to a real server.
800
 
        err = self.assertRaises(errors.PermissionDenied,
801
 
            fmt._initialize_on_transport_ex_rpc, client, 'path', transport,
802
 
            False, False, False, None, None, None, None, False)
803
 
        self.assertEqual('path', err.path)
804
 
        self.assertEqual(': extra info', err.extra)
805
 
        self.assertFinished(client)
806
 
 
807
 
    def test_error_from_real_server(self):
808
 
        """Integration test for error translation."""
809
 
        transport = self.make_smart_server('foo')
810
 
        transport = transport.clone('no-such-path')
811
 
        fmt = bzrdir.RemoteBzrDirFormat()
812
 
        err = self.assertRaises(errors.NoSuchFile,
813
 
            fmt.initialize_on_transport_ex, transport, create_prefix=False)
 
394
        bzrdir = RemoteBzrDir(transport, _client=client)
 
395
        repo = bzrdir.open_repository()
 
396
        self.assertEqual(
 
397
            [('call', 'BzrDir.find_repositoryV2', ('quack/',)),
 
398
             ('call', 'BzrDir.find_repository', ('quack/',))],
 
399
            client._calls)
814
400
 
815
401
 
816
402
class OldSmartClient(object):
841
427
        return OldSmartClient()
842
428
 
843
429
 
844
 
class RemoteBzrDirTestCase(TestRemote):
845
 
 
846
 
    def make_remote_bzrdir(self, transport, client):
847
 
        """Make a RemotebzrDir using 'client' as the _client."""
848
 
        return RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
849
 
            _client=client)
850
 
 
851
 
 
852
 
class RemoteBranchTestCase(RemoteBzrDirTestCase):
853
 
 
854
 
    def make_remote_branch(self, transport, client):
855
 
        """Make a RemoteBranch using 'client' as its _SmartClient.
856
 
 
857
 
        A RemoteBzrDir and RemoteRepository will also be created to fill out
858
 
        the RemoteBranch, albeit with stub values for some of their attributes.
859
 
        """
860
 
        # we do not want bzrdir to make any remote calls, so use False as its
861
 
        # _client.  If it tries to make a remote call, this will fail
862
 
        # immediately.
863
 
        bzrdir = self.make_remote_bzrdir(transport, False)
864
 
        repo = RemoteRepository(bzrdir, None, _client=client)
865
 
        branch_format = self.get_branch_format()
866
 
        format = RemoteBranchFormat(network_name=branch_format.network_name())
867
 
        return RemoteBranch(bzrdir, repo, _client=client, format=format)
868
 
 
869
 
 
870
 
class TestBranchGetParent(RemoteBranchTestCase):
871
 
 
872
 
    def test_no_parent(self):
873
 
        # in an empty branch we decode the response properly
874
 
        transport = MemoryTransport()
875
 
        client = FakeClient(transport.base)
876
 
        client.add_expected_call(
877
 
            'Branch.get_stacked_on_url', ('quack/',),
878
 
            'error', ('NotStacked',))
879
 
        client.add_expected_call(
880
 
            'Branch.get_parent', ('quack/',),
881
 
            'success', ('',))
882
 
        transport.mkdir('quack')
883
 
        transport = transport.clone('quack')
884
 
        branch = self.make_remote_branch(transport, client)
885
 
        result = branch.get_parent()
886
 
        self.assertFinished(client)
887
 
        self.assertEqual(None, result)
888
 
 
889
 
    def test_parent_relative(self):
890
 
        transport = MemoryTransport()
891
 
        client = FakeClient(transport.base)
892
 
        client.add_expected_call(
893
 
            'Branch.get_stacked_on_url', ('kwaak/',),
894
 
            'error', ('NotStacked',))
895
 
        client.add_expected_call(
896
 
            'Branch.get_parent', ('kwaak/',),
897
 
            'success', ('../foo/',))
898
 
        transport.mkdir('kwaak')
899
 
        transport = transport.clone('kwaak')
900
 
        branch = self.make_remote_branch(transport, client)
901
 
        result = branch.get_parent()
902
 
        self.assertEqual(transport.clone('../foo').base, result)
903
 
 
904
 
    def test_parent_absolute(self):
905
 
        transport = MemoryTransport()
906
 
        client = FakeClient(transport.base)
907
 
        client.add_expected_call(
908
 
            'Branch.get_stacked_on_url', ('kwaak/',),
909
 
            'error', ('NotStacked',))
910
 
        client.add_expected_call(
911
 
            'Branch.get_parent', ('kwaak/',),
912
 
            'success', ('http://foo/',))
913
 
        transport.mkdir('kwaak')
914
 
        transport = transport.clone('kwaak')
915
 
        branch = self.make_remote_branch(transport, client)
916
 
        result = branch.get_parent()
917
 
        self.assertEqual('http://foo/', result)
918
 
        self.assertFinished(client)
919
 
 
920
 
 
921
 
class TestBranchSetParentLocation(RemoteBranchTestCase):
922
 
 
923
 
    def test_no_parent(self):
924
 
        # We call the verb when setting parent to None
925
 
        transport = MemoryTransport()
926
 
        client = FakeClient(transport.base)
927
 
        client.add_expected_call(
928
 
            'Branch.get_stacked_on_url', ('quack/',),
929
 
            'error', ('NotStacked',))
930
 
        client.add_expected_call(
931
 
            'Branch.set_parent_location', ('quack/', 'b', 'r', ''),
932
 
            'success', ())
933
 
        transport.mkdir('quack')
934
 
        transport = transport.clone('quack')
935
 
        branch = self.make_remote_branch(transport, client)
936
 
        branch._lock_token = 'b'
937
 
        branch._repo_lock_token = 'r'
938
 
        branch._set_parent_location(None)
939
 
        self.assertFinished(client)
940
 
 
941
 
    def test_parent(self):
942
 
        transport = MemoryTransport()
943
 
        client = FakeClient(transport.base)
944
 
        client.add_expected_call(
945
 
            'Branch.get_stacked_on_url', ('kwaak/',),
946
 
            'error', ('NotStacked',))
947
 
        client.add_expected_call(
948
 
            'Branch.set_parent_location', ('kwaak/', 'b', 'r', 'foo'),
949
 
            'success', ())
950
 
        transport.mkdir('kwaak')
951
 
        transport = transport.clone('kwaak')
952
 
        branch = self.make_remote_branch(transport, client)
953
 
        branch._lock_token = 'b'
954
 
        branch._repo_lock_token = 'r'
955
 
        branch._set_parent_location('foo')
956
 
        self.assertFinished(client)
957
 
 
958
 
    def test_backwards_compat(self):
959
 
        self.setup_smart_server_with_call_log()
960
 
        branch = self.make_branch('.')
961
 
        self.reset_smart_call_log()
962
 
        verb = 'Branch.set_parent_location'
963
 
        self.disable_verb(verb)
964
 
        branch.set_parent('http://foo/')
965
 
        self.assertLength(12, self.hpss_calls)
966
 
 
967
 
 
968
 
class TestBranchGetTagsBytes(RemoteBranchTestCase):
969
 
 
970
 
    def test_backwards_compat(self):
971
 
        self.setup_smart_server_with_call_log()
972
 
        branch = self.make_branch('.')
973
 
        self.reset_smart_call_log()
974
 
        verb = 'Branch.get_tags_bytes'
975
 
        self.disable_verb(verb)
976
 
        branch.tags.get_tag_dict()
977
 
        call_count = len([call for call in self.hpss_calls if
978
 
            call.call.method == verb])
979
 
        self.assertEqual(1, call_count)
980
 
 
981
 
    def test_trivial(self):
982
 
        transport = MemoryTransport()
983
 
        client = FakeClient(transport.base)
984
 
        client.add_expected_call(
985
 
            'Branch.get_stacked_on_url', ('quack/',),
986
 
            'error', ('NotStacked',))
987
 
        client.add_expected_call(
988
 
            'Branch.get_tags_bytes', ('quack/',),
989
 
            'success', ('',))
990
 
        transport.mkdir('quack')
991
 
        transport = transport.clone('quack')
992
 
        branch = self.make_remote_branch(transport, client)
993
 
        result = branch.tags.get_tag_dict()
994
 
        self.assertFinished(client)
995
 
        self.assertEqual({}, result)
996
 
 
997
 
 
998
 
class TestBranchLastRevisionInfo(RemoteBranchTestCase):
 
430
class TestBranchLastRevisionInfo(tests.TestCase):
999
431
 
1000
432
    def test_empty_branch(self):
1001
433
        # in an empty branch we decode the response properly
1002
434
        transport = MemoryTransport()
1003
435
        client = FakeClient(transport.base)
1004
 
        client.add_expected_call(
1005
 
            'Branch.get_stacked_on_url', ('quack/',),
1006
 
            'error', ('NotStacked',))
1007
 
        client.add_expected_call(
1008
 
            'Branch.last_revision_info', ('quack/',),
1009
 
            'success', ('ok', '0', 'null:'))
 
436
        client.add_success_response('ok', '0', 'null:')
1010
437
        transport.mkdir('quack')
1011
438
        transport = transport.clone('quack')
1012
 
        branch = self.make_remote_branch(transport, client)
 
439
        # we do not want bzrdir to make any remote calls
 
440
        bzrdir = RemoteBzrDir(transport, _client=False)
 
441
        branch = RemoteBranch(bzrdir, None, _client=client)
1013
442
        result = branch.last_revision_info()
1014
 
        self.assertFinished(client)
 
443
 
 
444
        self.assertEqual(
 
445
            [('call', 'Branch.last_revision_info', ('quack/',))],
 
446
            client._calls)
1015
447
        self.assertEqual((0, NULL_REVISION), result)
1016
448
 
1017
449
    def test_non_empty_branch(self):
1019
451
        revid = u'\xc8'.encode('utf8')
1020
452
        transport = MemoryTransport()
1021
453
        client = FakeClient(transport.base)
1022
 
        client.add_expected_call(
1023
 
            'Branch.get_stacked_on_url', ('kwaak/',),
1024
 
            'error', ('NotStacked',))
1025
 
        client.add_expected_call(
1026
 
            'Branch.last_revision_info', ('kwaak/',),
1027
 
            'success', ('ok', '2', revid))
 
454
        client.add_success_response('ok', '2', revid)
1028
455
        transport.mkdir('kwaak')
1029
456
        transport = transport.clone('kwaak')
1030
 
        branch = self.make_remote_branch(transport, client)
 
457
        # we do not want bzrdir to make any remote calls
 
458
        bzrdir = RemoteBzrDir(transport, _client=False)
 
459
        branch = RemoteBranch(bzrdir, None, _client=client)
1031
460
        result = branch.last_revision_info()
 
461
 
 
462
        self.assertEqual(
 
463
            [('call', 'Branch.last_revision_info', ('kwaak/',))],
 
464
            client._calls)
1032
465
        self.assertEqual((2, revid), result)
1033
466
 
1034
467
 
1035
 
class TestBranch_get_stacked_on_url(TestRemote):
1036
 
    """Test Branch._get_stacked_on_url rpc"""
1037
 
 
1038
 
    def test_get_stacked_on_invalid_url(self):
1039
 
        # test that asking for a stacked on url the server can't access works.
1040
 
        # This isn't perfect, but then as we're in the same process there
1041
 
        # really isn't anything we can do to be 100% sure that the server
1042
 
        # doesn't just open in - this test probably needs to be rewritten using
1043
 
        # a spawn()ed server.
1044
 
        stacked_branch = self.make_branch('stacked', format='1.9')
1045
 
        memory_branch = self.make_branch('base', format='1.9')
1046
 
        vfs_url = self.get_vfs_only_url('base')
1047
 
        stacked_branch.set_stacked_on_url(vfs_url)
1048
 
        transport = stacked_branch.bzrdir.root_transport
1049
 
        client = FakeClient(transport.base)
1050
 
        client.add_expected_call(
1051
 
            'Branch.get_stacked_on_url', ('stacked/',),
1052
 
            'success', ('ok', vfs_url))
1053
 
        # XXX: Multiple calls are bad, this second call documents what is
1054
 
        # today.
1055
 
        client.add_expected_call(
1056
 
            'Branch.get_stacked_on_url', ('stacked/',),
1057
 
            'success', ('ok', vfs_url))
1058
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1059
 
            _client=client)
1060
 
        repo_fmt = remote.RemoteRepositoryFormat()
1061
 
        repo_fmt._custom_format = stacked_branch.repository._format
1062
 
        branch = RemoteBranch(bzrdir, RemoteRepository(bzrdir, repo_fmt),
1063
 
            _client=client)
1064
 
        result = branch.get_stacked_on_url()
1065
 
        self.assertEqual(vfs_url, result)
1066
 
 
1067
 
    def test_backwards_compatible(self):
1068
 
        # like with bzr1.6 with no Branch.get_stacked_on_url rpc
1069
 
        base_branch = self.make_branch('base', format='1.6')
1070
 
        stacked_branch = self.make_branch('stacked', format='1.6')
1071
 
        stacked_branch.set_stacked_on_url('../base')
1072
 
        client = FakeClient(self.get_url())
1073
 
        branch_network_name = self.get_branch_format().network_name()
1074
 
        client.add_expected_call(
1075
 
            'BzrDir.open_branchV2', ('stacked/',),
1076
 
            'success', ('branch', branch_network_name))
1077
 
        client.add_expected_call(
1078
 
            'BzrDir.find_repositoryV3', ('stacked/',),
1079
 
            'success', ('ok', '', 'no', 'no', 'yes',
1080
 
                stacked_branch.repository._format.network_name()))
1081
 
        # called twice, once from constructor and then again by us
1082
 
        client.add_expected_call(
1083
 
            'Branch.get_stacked_on_url', ('stacked/',),
1084
 
            'unknown', ('Branch.get_stacked_on_url',))
1085
 
        client.add_expected_call(
1086
 
            'Branch.get_stacked_on_url', ('stacked/',),
1087
 
            'unknown', ('Branch.get_stacked_on_url',))
1088
 
        # this will also do vfs access, but that goes direct to the transport
1089
 
        # and isn't seen by the FakeClient.
1090
 
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1091
 
            remote.RemoteBzrDirFormat(), _client=client)
1092
 
        branch = bzrdir.open_branch()
1093
 
        result = branch.get_stacked_on_url()
1094
 
        self.assertEqual('../base', result)
1095
 
        self.assertFinished(client)
1096
 
        # it's in the fallback list both for the RemoteRepository and its vfs
1097
 
        # repository
1098
 
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1099
 
        self.assertEqual(1,
1100
 
            len(branch.repository._real_repository._fallback_repositories))
1101
 
 
1102
 
    def test_get_stacked_on_real_branch(self):
1103
 
        base_branch = self.make_branch('base', format='1.6')
1104
 
        stacked_branch = self.make_branch('stacked', format='1.6')
1105
 
        stacked_branch.set_stacked_on_url('../base')
1106
 
        reference_format = self.get_repo_format()
1107
 
        network_name = reference_format.network_name()
1108
 
        client = FakeClient(self.get_url())
1109
 
        branch_network_name = self.get_branch_format().network_name()
1110
 
        client.add_expected_call(
1111
 
            'BzrDir.open_branchV2', ('stacked/',),
1112
 
            'success', ('branch', branch_network_name))
1113
 
        client.add_expected_call(
1114
 
            'BzrDir.find_repositoryV3', ('stacked/',),
1115
 
            'success', ('ok', '', 'no', 'no', 'yes', network_name))
1116
 
        # called twice, once from constructor and then again by us
1117
 
        client.add_expected_call(
1118
 
            'Branch.get_stacked_on_url', ('stacked/',),
1119
 
            'success', ('ok', '../base'))
1120
 
        client.add_expected_call(
1121
 
            'Branch.get_stacked_on_url', ('stacked/',),
1122
 
            'success', ('ok', '../base'))
1123
 
        bzrdir = RemoteBzrDir(self.get_transport('stacked'),
1124
 
            remote.RemoteBzrDirFormat(), _client=client)
1125
 
        branch = bzrdir.open_branch()
1126
 
        result = branch.get_stacked_on_url()
1127
 
        self.assertEqual('../base', result)
1128
 
        self.assertFinished(client)
1129
 
        # it's in the fallback list both for the RemoteRepository.
1130
 
        self.assertEqual(1, len(branch.repository._fallback_repositories))
1131
 
        # And we haven't had to construct a real repository.
1132
 
        self.assertEqual(None, branch.repository._real_repository)
1133
 
 
1134
 
 
1135
 
class TestBranchSetLastRevision(RemoteBranchTestCase):
 
468
class TestBranchSetLastRevision(tests.TestCase):
1136
469
 
1137
470
    def test_set_empty(self):
1138
471
        # set_revision_history([]) is translated to calling
1142
475
        transport = transport.clone('branch')
1143
476
 
1144
477
        client = FakeClient(transport.base)
1145
 
        client.add_expected_call(
1146
 
            'Branch.get_stacked_on_url', ('branch/',),
1147
 
            'error', ('NotStacked',))
1148
 
        client.add_expected_call(
1149
 
            'Branch.lock_write', ('branch/', '', ''),
1150
 
            'success', ('ok', 'branch token', 'repo token'))
1151
 
        client.add_expected_call(
1152
 
            'Branch.last_revision_info',
1153
 
            ('branch/',),
1154
 
            'success', ('ok', '0', 'null:'))
1155
 
        client.add_expected_call(
1156
 
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'null:',),
1157
 
            'success', ('ok',))
1158
 
        client.add_expected_call(
1159
 
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1160
 
            'success', ('ok',))
1161
 
        branch = self.make_remote_branch(transport, client)
 
478
        # lock_write
 
479
        client.add_success_response('ok', 'branch token', 'repo token')
 
480
        # set_last_revision
 
481
        client.add_success_response('ok')
 
482
        # unlock
 
483
        client.add_success_response('ok')
 
484
        bzrdir = RemoteBzrDir(transport, _client=False)
 
485
        branch = RemoteBranch(bzrdir, None, _client=client)
1162
486
        # This is a hack to work around the problem that RemoteBranch currently
1163
487
        # unnecessarily invokes _ensure_real upon a call to lock_write.
1164
488
        branch._ensure_real = lambda: None
1165
489
        branch.lock_write()
 
490
        client._calls = []
1166
491
        result = branch.set_revision_history([])
 
492
        self.assertEqual(
 
493
            [('call', 'Branch.set_last_revision',
 
494
                ('branch/', 'branch token', 'repo token', 'null:'))],
 
495
            client._calls)
1167
496
        branch.unlock()
1168
497
        self.assertEqual(None, result)
1169
 
        self.assertFinished(client)
1170
498
 
1171
499
    def test_set_nonempty(self):
1172
500
        # set_revision_history([rev-id1, ..., rev-idN]) is translated to calling
1176
504
        transport = transport.clone('branch')
1177
505
 
1178
506
        client = FakeClient(transport.base)
1179
 
        client.add_expected_call(
1180
 
            'Branch.get_stacked_on_url', ('branch/',),
1181
 
            'error', ('NotStacked',))
1182
 
        client.add_expected_call(
1183
 
            'Branch.lock_write', ('branch/', '', ''),
1184
 
            'success', ('ok', 'branch token', 'repo token'))
1185
 
        client.add_expected_call(
1186
 
            'Branch.last_revision_info',
1187
 
            ('branch/',),
1188
 
            'success', ('ok', '0', 'null:'))
1189
 
        lines = ['rev-id2']
1190
 
        encoded_body = bz2.compress('\n'.join(lines))
1191
 
        client.add_success_response_with_body(encoded_body, 'ok')
1192
 
        client.add_expected_call(
1193
 
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id2',),
1194
 
            'success', ('ok',))
1195
 
        client.add_expected_call(
1196
 
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1197
 
            'success', ('ok',))
1198
 
        branch = self.make_remote_branch(transport, client)
 
507
        # lock_write
 
508
        client.add_success_response('ok', 'branch token', 'repo token')
 
509
        # set_last_revision
 
510
        client.add_success_response('ok')
 
511
        # unlock
 
512
        client.add_success_response('ok')
 
513
        bzrdir = RemoteBzrDir(transport, _client=False)
 
514
        branch = RemoteBranch(bzrdir, None, _client=client)
1199
515
        # This is a hack to work around the problem that RemoteBranch currently
1200
516
        # unnecessarily invokes _ensure_real upon a call to lock_write.
1201
517
        branch._ensure_real = lambda: None
1202
518
        # Lock the branch, reset the record of remote calls.
1203
519
        branch.lock_write()
 
520
        client._calls = []
 
521
 
1204
522
        result = branch.set_revision_history(['rev-id1', 'rev-id2'])
 
523
        self.assertEqual(
 
524
            [('call', 'Branch.set_last_revision',
 
525
                ('branch/', 'branch token', 'repo token', 'rev-id2'))],
 
526
            client._calls)
1205
527
        branch.unlock()
1206
528
        self.assertEqual(None, result)
1207
 
        self.assertFinished(client)
1208
529
 
1209
530
    def test_no_such_revision(self):
1210
531
        transport = MemoryTransport()
1212
533
        transport = transport.clone('branch')
1213
534
        # A response of 'NoSuchRevision' is translated into an exception.
1214
535
        client = FakeClient(transport.base)
1215
 
        client.add_expected_call(
1216
 
            'Branch.get_stacked_on_url', ('branch/',),
1217
 
            'error', ('NotStacked',))
1218
 
        client.add_expected_call(
1219
 
            'Branch.lock_write', ('branch/', '', ''),
1220
 
            'success', ('ok', 'branch token', 'repo token'))
1221
 
        client.add_expected_call(
1222
 
            'Branch.last_revision_info',
1223
 
            ('branch/',),
1224
 
            'success', ('ok', '0', 'null:'))
1225
 
        # get_graph calls to construct the revision history, for the set_rh
1226
 
        # hook
1227
 
        lines = ['rev-id']
1228
 
        encoded_body = bz2.compress('\n'.join(lines))
1229
 
        client.add_success_response_with_body(encoded_body, 'ok')
1230
 
        client.add_expected_call(
1231
 
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id',),
1232
 
            'error', ('NoSuchRevision', 'rev-id'))
1233
 
        client.add_expected_call(
1234
 
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1235
 
            'success', ('ok',))
 
536
        # lock_write
 
537
        client.add_success_response('ok', 'branch token', 'repo token')
 
538
        # set_last_revision
 
539
        client.add_error_response('NoSuchRevision', 'rev-id')
 
540
        # unlock
 
541
        client.add_success_response('ok')
1236
542
 
1237
 
        branch = self.make_remote_branch(transport, client)
 
543
        bzrdir = RemoteBzrDir(transport, _client=False)
 
544
        repo = RemoteRepository(bzrdir, None, _client=client)
 
545
        branch = RemoteBranch(bzrdir, repo, _client=client)
 
546
        branch._ensure_real = lambda: None
1238
547
        branch.lock_write()
 
548
        client._calls = []
 
549
 
1239
550
        self.assertRaises(
1240
551
            errors.NoSuchRevision, branch.set_revision_history, ['rev-id'])
1241
552
        branch.unlock()
1242
 
        self.assertFinished(client)
1243
553
 
1244
554
    def test_tip_change_rejected(self):
1245
555
        """TipChangeRejected responses cause a TipChangeRejected exception to
1249
559
        transport.mkdir('branch')
1250
560
        transport = transport.clone('branch')
1251
561
        client = FakeClient(transport.base)
 
562
        # lock_write
 
563
        client.add_success_response('ok', 'branch token', 'repo token')
 
564
        # set_last_revision
1252
565
        rejection_msg_unicode = u'rejection message\N{INTERROBANG}'
1253
566
        rejection_msg_utf8 = rejection_msg_unicode.encode('utf8')
1254
 
        client.add_expected_call(
1255
 
            'Branch.get_stacked_on_url', ('branch/',),
1256
 
            'error', ('NotStacked',))
1257
 
        client.add_expected_call(
1258
 
            'Branch.lock_write', ('branch/', '', ''),
1259
 
            'success', ('ok', 'branch token', 'repo token'))
1260
 
        client.add_expected_call(
1261
 
            'Branch.last_revision_info',
1262
 
            ('branch/',),
1263
 
            'success', ('ok', '0', 'null:'))
1264
 
        lines = ['rev-id']
1265
 
        encoded_body = bz2.compress('\n'.join(lines))
1266
 
        client.add_success_response_with_body(encoded_body, 'ok')
1267
 
        client.add_expected_call(
1268
 
            'Branch.set_last_revision', ('branch/', 'branch token', 'repo token', 'rev-id',),
1269
 
            'error', ('TipChangeRejected', rejection_msg_utf8))
1270
 
        client.add_expected_call(
1271
 
            'Branch.unlock', ('branch/', 'branch token', 'repo token'),
1272
 
            'success', ('ok',))
1273
 
        branch = self.make_remote_branch(transport, client)
 
567
        client.add_error_response('TipChangeRejected', rejection_msg_utf8)
 
568
        # unlock
 
569
        client.add_success_response('ok')
 
570
 
 
571
        bzrdir = RemoteBzrDir(transport, _client=False)
 
572
        repo = RemoteRepository(bzrdir, None, _client=client)
 
573
        branch = RemoteBranch(bzrdir, repo, _client=client)
1274
574
        branch._ensure_real = lambda: None
1275
575
        branch.lock_write()
 
576
        self.addCleanup(branch.unlock)
 
577
        client._calls = []
 
578
 
1276
579
        # The 'TipChangeRejected' error response triggered by calling
1277
580
        # set_revision_history causes a TipChangeRejected exception.
1278
581
        err = self.assertRaises(
1281
584
        # object.
1282
585
        self.assertIsInstance(err.msg, unicode)
1283
586
        self.assertEqual(rejection_msg_unicode, err.msg)
1284
 
        branch.unlock()
1285
 
        self.assertFinished(client)
1286
 
 
1287
 
 
1288
 
class TestBranchSetLastRevisionInfo(RemoteBranchTestCase):
 
587
 
 
588
 
 
589
class TestBranchSetLastRevisionInfo(tests.TestCase):
1289
590
 
1290
591
    def test_set_last_revision_info(self):
1291
592
        # set_last_revision_info(num, 'rev-id') is translated to calling
1294
595
        transport.mkdir('branch')
1295
596
        transport = transport.clone('branch')
1296
597
        client = FakeClient(transport.base)
1297
 
        # get_stacked_on_url
1298
 
        client.add_error_response('NotStacked')
1299
598
        # lock_write
1300
599
        client.add_success_response('ok', 'branch token', 'repo token')
1301
 
        # query the current revision
1302
 
        client.add_success_response('ok', '0', 'null:')
1303
600
        # set_last_revision
1304
601
        client.add_success_response('ok')
1305
602
        # unlock
1306
603
        client.add_success_response('ok')
1307
604
 
1308
 
        branch = self.make_remote_branch(transport, client)
 
605
        bzrdir = RemoteBzrDir(transport, _client=False)
 
606
        branch = RemoteBranch(bzrdir, None, _client=client)
 
607
        # This is a hack to work around the problem that RemoteBranch currently
 
608
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
609
        branch._ensure_real = lambda: None
1309
610
        # Lock the branch, reset the record of remote calls.
1310
611
        branch.lock_write()
1311
612
        client._calls = []
1312
613
        result = branch.set_last_revision_info(1234, 'a-revision-id')
1313
614
        self.assertEqual(
1314
 
            [('call', 'Branch.last_revision_info', ('branch/',)),
1315
 
             ('call', 'Branch.set_last_revision_info',
 
615
            [('call', 'Branch.set_last_revision_info',
1316
616
                ('branch/', 'branch token', 'repo token',
1317
617
                 '1234', 'a-revision-id'))],
1318
618
            client._calls)
1324
624
        transport.mkdir('branch')
1325
625
        transport = transport.clone('branch')
1326
626
        client = FakeClient(transport.base)
1327
 
        # get_stacked_on_url
1328
 
        client.add_error_response('NotStacked')
1329
627
        # lock_write
1330
628
        client.add_success_response('ok', 'branch token', 'repo token')
1331
629
        # set_last_revision
1333
631
        # unlock
1334
632
        client.add_success_response('ok')
1335
633
 
1336
 
        branch = self.make_remote_branch(transport, client)
 
634
        bzrdir = RemoteBzrDir(transport, _client=False)
 
635
        repo = RemoteRepository(bzrdir, None, _client=client)
 
636
        branch = RemoteBranch(bzrdir, repo, _client=client)
 
637
        # This is a hack to work around the problem that RemoteBranch currently
 
638
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
639
        branch._ensure_real = lambda: None
1337
640
        # Lock the branch, reset the record of remote calls.
1338
641
        branch.lock_write()
1339
642
        client._calls = []
1348
651
        branch._lock_count = 2
1349
652
        branch._lock_token = 'branch token'
1350
653
        branch._repo_lock_token = 'repo token'
1351
 
        branch.repository._lock_mode = 'w'
1352
 
        branch.repository._lock_count = 2
1353
 
        branch.repository._lock_token = 'repo token'
1354
654
 
1355
655
    def test_backwards_compatibility(self):
1356
656
        """If the server does not support the Branch.set_last_revision_info
1368
668
        transport.mkdir('branch')
1369
669
        transport = transport.clone('branch')
1370
670
        client = FakeClient(transport.base)
1371
 
        client.add_expected_call(
1372
 
            'Branch.get_stacked_on_url', ('branch/',),
1373
 
            'error', ('NotStacked',))
1374
 
        client.add_expected_call(
1375
 
            'Branch.last_revision_info',
1376
 
            ('branch/',),
1377
 
            'success', ('ok', '0', 'null:'))
1378
 
        client.add_expected_call(
1379
 
            'Branch.set_last_revision_info',
1380
 
            ('branch/', 'branch token', 'repo token', '1234', 'a-revision-id',),
1381
 
            'unknown', 'Branch.set_last_revision_info')
1382
 
 
1383
 
        branch = self.make_remote_branch(transport, client)
 
671
        client.add_unknown_method_response('Branch.set_last_revision_info')
 
672
        bzrdir = RemoteBzrDir(transport, _client=False)
 
673
        branch = RemoteBranch(bzrdir, None, _client=client)
1384
674
        class StubRealBranch(object):
1385
675
            def __init__(self):
1386
676
                self.calls = []
1396
686
        # Call set_last_revision_info, and verify it behaved as expected.
1397
687
        result = branch.set_last_revision_info(1234, 'a-revision-id')
1398
688
        self.assertEqual(
 
689
            [('call', 'Branch.set_last_revision_info',
 
690
                ('branch/', 'branch token', 'repo token',
 
691
                 '1234', 'a-revision-id')),],
 
692
            client._calls)
 
693
        self.assertEqual(
1399
694
            [('set_last_revision_info', 1234, 'a-revision-id')],
1400
695
            real_branch.calls)
1401
 
        self.assertFinished(client)
1402
696
 
1403
697
    def test_unexpected_error(self):
1404
 
        # If the server sends an error the client doesn't understand, it gets
1405
 
        # turned into an UnknownErrorFromSmartServer, which is presented as a
1406
 
        # non-internal error to the user.
 
698
        # A response of 'NoSuchRevision' is translated into an exception.
1407
699
        transport = MemoryTransport()
1408
700
        transport.mkdir('branch')
1409
701
        transport = transport.clone('branch')
1410
702
        client = FakeClient(transport.base)
1411
 
        # get_stacked_on_url
1412
 
        client.add_error_response('NotStacked')
1413
703
        # lock_write
1414
704
        client.add_success_response('ok', 'branch token', 'repo token')
1415
705
        # set_last_revision
1417
707
        # unlock
1418
708
        client.add_success_response('ok')
1419
709
 
1420
 
        branch = self.make_remote_branch(transport, client)
 
710
        bzrdir = RemoteBzrDir(transport, _client=False)
 
711
        repo = RemoteRepository(bzrdir, None, _client=client)
 
712
        branch = RemoteBranch(bzrdir, repo, _client=client)
 
713
        # This is a hack to work around the problem that RemoteBranch currently
 
714
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
715
        branch._ensure_real = lambda: None
1421
716
        # Lock the branch, reset the record of remote calls.
1422
717
        branch.lock_write()
1423
718
        client._calls = []
1424
719
 
1425
720
        err = self.assertRaises(
1426
 
            errors.UnknownErrorFromSmartServer,
 
721
            errors.ErrorFromSmartServer,
1427
722
            branch.set_last_revision_info, 123, 'revid')
1428
723
        self.assertEqual(('UnexpectedError',), err.error_tuple)
1429
724
        branch.unlock()
1436
731
        transport.mkdir('branch')
1437
732
        transport = transport.clone('branch')
1438
733
        client = FakeClient(transport.base)
1439
 
        # get_stacked_on_url
1440
 
        client.add_error_response('NotStacked')
1441
734
        # lock_write
1442
735
        client.add_success_response('ok', 'branch token', 'repo token')
1443
736
        # set_last_revision
1445
738
        # unlock
1446
739
        client.add_success_response('ok')
1447
740
 
1448
 
        branch = self.make_remote_branch(transport, client)
 
741
        bzrdir = RemoteBzrDir(transport, _client=False)
 
742
        repo = RemoteRepository(bzrdir, None, _client=client)
 
743
        branch = RemoteBranch(bzrdir, repo, _client=client)
 
744
        # This is a hack to work around the problem that RemoteBranch currently
 
745
        # unnecessarily invokes _ensure_real upon a call to lock_write.
 
746
        branch._ensure_real = lambda: None
1449
747
        # Lock the branch, reset the record of remote calls.
1450
748
        branch.lock_write()
1451
749
        self.addCleanup(branch.unlock)
1459
757
        self.assertEqual('rejection message', err.msg)
1460
758
 
1461
759
 
1462
 
class TestBranchGetSetConfig(RemoteBranchTestCase):
 
760
class TestBranchControlGetBranchConf(tests.TestCaseWithMemoryTransport):
 
761
    """Getting the branch configuration should use an abstract method not vfs.
 
762
    """
1463
763
 
1464
764
    def test_get_branch_conf(self):
1465
 
        # in an empty branch we decode the response properly
1466
 
        client = FakeClient()
1467
 
        client.add_expected_call(
1468
 
            'Branch.get_stacked_on_url', ('memory:///',),
1469
 
            'error', ('NotStacked',),)
1470
 
        client.add_success_response_with_body('# config file body', 'ok')
1471
 
        transport = MemoryTransport()
1472
 
        branch = self.make_remote_branch(transport, client)
1473
 
        config = branch.get_config()
1474
 
        config.has_explicit_nickname()
1475
 
        self.assertEqual(
1476
 
            [('call', 'Branch.get_stacked_on_url', ('memory:///',)),
1477
 
             ('call_expecting_body', 'Branch.get_config_file', ('memory:///',))],
1478
 
            client._calls)
1479
 
 
1480
 
    def test_get_multi_line_branch_conf(self):
1481
 
        # Make sure that multiple-line branch.conf files are supported
1482
 
        #
1483
 
        # https://bugs.edge.launchpad.net/bzr/+bug/354075
1484
 
        client = FakeClient()
1485
 
        client.add_expected_call(
1486
 
            'Branch.get_stacked_on_url', ('memory:///',),
1487
 
            'error', ('NotStacked',),)
1488
 
        client.add_success_response_with_body('a = 1\nb = 2\nc = 3\n', 'ok')
1489
 
        transport = MemoryTransport()
1490
 
        branch = self.make_remote_branch(transport, client)
1491
 
        config = branch.get_config()
1492
 
        self.assertEqual(u'2', config.get_user_option('b'))
1493
 
 
1494
 
    def test_set_option(self):
1495
 
        client = FakeClient()
1496
 
        client.add_expected_call(
1497
 
            'Branch.get_stacked_on_url', ('memory:///',),
1498
 
            'error', ('NotStacked',),)
1499
 
        client.add_expected_call(
1500
 
            'Branch.lock_write', ('memory:///', '', ''),
1501
 
            'success', ('ok', 'branch token', 'repo token'))
1502
 
        client.add_expected_call(
1503
 
            'Branch.set_config_option', ('memory:///', 'branch token',
1504
 
            'repo token', 'foo', 'bar', ''),
1505
 
            'success', ())
1506
 
        client.add_expected_call(
1507
 
            'Branch.unlock', ('memory:///', 'branch token', 'repo token'),
1508
 
            'success', ('ok',))
1509
 
        transport = MemoryTransport()
1510
 
        branch = self.make_remote_branch(transport, client)
1511
 
        branch.lock_write()
1512
 
        config = branch._get_config()
1513
 
        config.set_option('foo', 'bar')
1514
 
        branch.unlock()
1515
 
        self.assertFinished(client)
1516
 
 
1517
 
    def test_backwards_compat_set_option(self):
1518
 
        self.setup_smart_server_with_call_log()
1519
 
        branch = self.make_branch('.')
1520
 
        verb = 'Branch.set_config_option'
1521
 
        self.disable_verb(verb)
1522
 
        branch.lock_write()
1523
 
        self.addCleanup(branch.unlock)
1524
 
        self.reset_smart_call_log()
1525
 
        branch._get_config().set_option('value', 'name')
1526
 
        self.assertLength(10, self.hpss_calls)
1527
 
        self.assertEqual('value', branch._get_config().get_option('name'))
1528
 
 
1529
 
 
1530
 
class TestBranchLockWrite(RemoteBranchTestCase):
 
765
        raise tests.KnownFailure('branch.conf is not retrieved by get_config_file')
 
766
        ## # We should see that branch.get_config() does a single rpc to get the
 
767
        ## # remote configuration file, abstracting away where that is stored on
 
768
        ## # the server.  However at the moment it always falls back to using the
 
769
        ## # vfs, and this would need some changes in config.py.
 
770
 
 
771
        ## # in an empty branch we decode the response properly
 
772
        ## client = FakeClient([(('ok', ), '# config file body')], self.get_url())
 
773
        ## # we need to make a real branch because the remote_branch.control_files
 
774
        ## # will trigger _ensure_real.
 
775
        ## branch = self.make_branch('quack')
 
776
        ## transport = branch.bzrdir.root_transport
 
777
        ## # we do not want bzrdir to make any remote calls
 
778
        ## bzrdir = RemoteBzrDir(transport, _client=False)
 
779
        ## branch = RemoteBranch(bzrdir, None, _client=client)
 
780
        ## config = branch.get_config()
 
781
        ## self.assertEqual(
 
782
        ##     [('call_expecting_body', 'Branch.get_config_file', ('quack/',))],
 
783
        ##     client._calls)
 
784
 
 
785
 
 
786
class TestBranchLockWrite(tests.TestCase):
1531
787
 
1532
788
    def test_lock_write_unlockable(self):
1533
789
        transport = MemoryTransport()
1534
790
        client = FakeClient(transport.base)
1535
 
        client.add_expected_call(
1536
 
            'Branch.get_stacked_on_url', ('quack/',),
1537
 
            'error', ('NotStacked',),)
1538
 
        client.add_expected_call(
1539
 
            'Branch.lock_write', ('quack/', '', ''),
1540
 
            'error', ('UnlockableTransport',))
 
791
        client.add_error_response('UnlockableTransport')
1541
792
        transport.mkdir('quack')
1542
793
        transport = transport.clone('quack')
1543
 
        branch = self.make_remote_branch(transport, client)
 
794
        # we do not want bzrdir to make any remote calls
 
795
        bzrdir = RemoteBzrDir(transport, _client=False)
 
796
        repo = RemoteRepository(bzrdir, None, _client=client)
 
797
        branch = RemoteBranch(bzrdir, repo, _client=client)
1544
798
        self.assertRaises(errors.UnlockableTransport, branch.lock_write)
1545
 
        self.assertFinished(client)
1546
 
 
1547
 
 
1548
 
class TestBzrDirGetSetConfig(RemoteBzrDirTestCase):
1549
 
 
1550
 
    def test__get_config(self):
1551
 
        client = FakeClient()
1552
 
        client.add_success_response_with_body('default_stack_on = /\n', 'ok')
1553
 
        transport = MemoryTransport()
1554
 
        bzrdir = self.make_remote_bzrdir(transport, client)
1555
 
        config = bzrdir.get_config()
1556
 
        self.assertEqual('/', config.get_default_stack_on())
1557
799
        self.assertEqual(
1558
 
            [('call_expecting_body', 'BzrDir.get_config_file', ('memory:///',))],
 
800
            [('call', 'Branch.lock_write', ('quack/', '', ''))],
1559
801
            client._calls)
1560
802
 
1561
 
    def test_set_option_uses_vfs(self):
1562
 
        self.setup_smart_server_with_call_log()
1563
 
        bzrdir = self.make_bzrdir('.')
1564
 
        self.reset_smart_call_log()
1565
 
        config = bzrdir.get_config()
1566
 
        config.set_default_stack_on('/')
1567
 
        self.assertLength(3, self.hpss_calls)
1568
 
 
1569
 
    def test_backwards_compat_get_option(self):
1570
 
        self.setup_smart_server_with_call_log()
1571
 
        bzrdir = self.make_bzrdir('.')
1572
 
        verb = 'BzrDir.get_config_file'
1573
 
        self.disable_verb(verb)
1574
 
        self.reset_smart_call_log()
1575
 
        self.assertEqual(None,
1576
 
            bzrdir._get_config().get_option('default_stack_on'))
1577
 
        self.assertLength(3, self.hpss_calls)
1578
 
 
1579
803
 
1580
804
class TestTransportIsReadonly(tests.TestCase):
1581
805
 
1601
825
 
1602
826
    def test_error_from_old_server(self):
1603
827
        """bzr 0.15 and earlier servers don't recognise the is_readonly verb.
1604
 
 
 
828
        
1605
829
        Clients should treat it as a "no" response, because is_readonly is only
1606
830
        advisory anyway (a transport could be read-write, but then the
1607
831
        underlying filesystem could be readonly anyway).
1616
840
            client._calls)
1617
841
 
1618
842
 
1619
 
class TestTransportMkdir(tests.TestCase):
1620
 
 
1621
 
    def test_permissiondenied(self):
1622
 
        client = FakeClient()
1623
 
        client.add_error_response('PermissionDenied', 'remote path', 'extra')
1624
 
        transport = RemoteTransport('bzr://example.com/', medium=False,
1625
 
                                    _client=client)
1626
 
        exc = self.assertRaises(
1627
 
            errors.PermissionDenied, transport.mkdir, 'client path')
1628
 
        expected_error = errors.PermissionDenied('/client path', 'extra')
1629
 
        self.assertEqual(expected_error, exc)
1630
 
 
1631
 
 
1632
 
class TestRemoteSSHTransportAuthentication(tests.TestCaseInTempDir):
1633
 
 
1634
 
    def test_defaults_to_none(self):
1635
 
        t = RemoteSSHTransport('bzr+ssh://example.com')
1636
 
        self.assertIs(None, t._get_credentials()[0])
1637
 
 
1638
 
    def test_uses_authentication_config(self):
1639
 
        conf = config.AuthenticationConfig()
1640
 
        conf._get_config().update(
1641
 
            {'bzr+sshtest': {'scheme': 'ssh', 'user': 'bar', 'host':
1642
 
            'example.com'}})
1643
 
        conf._save()
1644
 
        t = RemoteSSHTransport('bzr+ssh://example.com')
1645
 
        self.assertEqual('bar', t._get_credentials()[0])
1646
 
 
1647
 
 
1648
 
class TestRemoteRepository(TestRemote):
 
843
class TestRemoteRepository(tests.TestCase):
1649
844
    """Base for testing RemoteRepository protocol usage.
1650
 
 
1651
 
    These tests contain frozen requests and responses.  We want any changes to
 
845
    
 
846
    These tests contain frozen requests and responses.  We want any changes to 
1652
847
    what is sent or expected to be require a thoughtful update to these tests
1653
848
    because they might break compatibility with different-versioned servers.
1654
849
    """
1655
850
 
1656
851
    def setup_fake_client_and_repository(self, transport_path):
1657
852
        """Create the fake client and repository for testing with.
1658
 
 
 
853
        
1659
854
        There's no real server here; we just have canned responses sent
1660
855
        back one by one.
1661
 
 
 
856
        
1662
857
        :param transport_path: Path below the root of the MemoryTransport
1663
858
            where the repository will be created.
1664
859
        """
1667
862
        client = FakeClient(transport.base)
1668
863
        transport = transport.clone(transport_path)
1669
864
        # we do not want bzrdir to make any remote calls
1670
 
        bzrdir = RemoteBzrDir(transport, remote.RemoteBzrDirFormat(),
1671
 
            _client=False)
 
865
        bzrdir = RemoteBzrDir(transport, _client=False)
1672
866
        repo = RemoteRepository(bzrdir, None, _client=client)
1673
867
        return repo, client
1674
868
 
1675
869
 
1676
 
class TestRepositoryFormat(TestRemoteRepository):
1677
 
 
1678
 
    def test_fast_delta(self):
1679
 
        true_name = groupcompress_repo.RepositoryFormatCHK1().network_name()
1680
 
        true_format = RemoteRepositoryFormat()
1681
 
        true_format._network_name = true_name
1682
 
        self.assertEqual(True, true_format.fast_deltas)
1683
 
        false_name = pack_repo.RepositoryFormatKnitPack1().network_name()
1684
 
        false_format = RemoteRepositoryFormat()
1685
 
        false_format._network_name = false_name
1686
 
        self.assertEqual(False, false_format.fast_deltas)
1687
 
 
1688
 
 
1689
870
class TestRepositoryGatherStats(TestRemoteRepository):
1690
871
 
1691
872
    def test_revid_none(self):
1747
928
class TestRepositoryGetGraph(TestRemoteRepository):
1748
929
 
1749
930
    def test_get_graph(self):
1750
 
        # get_graph returns a graph with a custom parents provider.
 
931
        # get_graph returns a graph with the repository as the
 
932
        # parents_provider.
1751
933
        transport_path = 'quack'
1752
934
        repo, client = self.setup_fake_client_and_repository(transport_path)
1753
935
        graph = repo.get_graph()
1754
 
        self.assertNotEqual(graph._parents_provider, repo)
 
936
        self.assertEqual(graph._parents_provider, repo)
1755
937
 
1756
938
 
1757
939
class TestRepositoryGetParentMap(TestRemoteRepository):
1779
961
        self.assertEqual({r1: (NULL_REVISION,)}, parents)
1780
962
        self.assertEqual(
1781
963
            [('call_with_body_bytes_expecting_body',
1782
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
1783
 
              '\n\n0')],
 
964
              'Repository.get_parent_map', ('quack/', r2), '\n\n0')],
1784
965
            client._calls)
1785
966
        repo.unlock()
1786
967
        # now we call again, and it should use the second response.
1790
971
        self.assertEqual({r1: (NULL_REVISION,)}, parents)
1791
972
        self.assertEqual(
1792
973
            [('call_with_body_bytes_expecting_body',
1793
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r2),
1794
 
              '\n\n0'),
 
974
              'Repository.get_parent_map', ('quack/', r2), '\n\n0'),
1795
975
             ('call_with_body_bytes_expecting_body',
1796
 
              'Repository.get_parent_map', ('quack/', 'include-missing:', r1),
1797
 
              '\n\n0'),
 
976
              'Repository.get_parent_map', ('quack/', r1), '\n\n0'),
1798
977
            ],
1799
978
            client._calls)
1800
979
        repo.unlock()
1801
980
 
1802
981
    def test_get_parent_map_reconnects_if_unknown_method(self):
1803
982
        transport_path = 'quack'
1804
 
        rev_id = 'revision-id'
1805
983
        repo, client = self.setup_fake_client_and_repository(transport_path)
1806
 
        client.add_unknown_method_response('Repository.get_parent_map')
1807
 
        client.add_success_response_with_body(rev_id, 'ok')
 
984
        client.add_unknown_method_response('Repository,get_parent_map')
 
985
        client.add_success_response_with_body('', 'ok')
1808
986
        self.assertFalse(client._medium._is_remote_before((1, 2)))
1809
 
        parents = repo.get_parent_map([rev_id])
 
987
        rev_id = 'revision-id'
 
988
        expected_deprecations = [
 
989
            'bzrlib.remote.RemoteRepository.get_revision_graph was deprecated '
 
990
            'in version 1.4.']
 
991
        parents = self.callDeprecated(
 
992
            expected_deprecations, repo.get_parent_map, [rev_id])
1810
993
        self.assertEqual(
1811
994
            [('call_with_body_bytes_expecting_body',
1812
 
              'Repository.get_parent_map', ('quack/', 'include-missing:',
1813
 
              rev_id), '\n\n0'),
 
995
              'Repository.get_parent_map', ('quack/', rev_id), '\n\n0'),
1814
996
             ('disconnect medium',),
1815
997
             ('call_expecting_body', 'Repository.get_revision_graph',
1816
998
              ('quack/', ''))],
1817
999
            client._calls)
1818
1000
        # The medium is now marked as being connected to an older server
1819
1001
        self.assertTrue(client._medium._is_remote_before((1, 2)))
1820
 
        self.assertEqual({rev_id: ('null:',)}, parents)
1821
1002
 
1822
1003
    def test_get_parent_map_fallback_parentless_node(self):
1823
1004
        """get_parent_map falls back to get_revision_graph on old servers.  The
1835
1016
        repo, client = self.setup_fake_client_and_repository(transport_path)
1836
1017
        client.add_success_response_with_body(rev_id, 'ok')
1837
1018
        client._medium._remember_remote_is_before((1, 2))
1838
 
        parents = repo.get_parent_map([rev_id])
 
1019
        expected_deprecations = [
 
1020
            'bzrlib.remote.RemoteRepository.get_revision_graph was deprecated '
 
1021
            'in version 1.4.']
 
1022
        parents = self.callDeprecated(
 
1023
            expected_deprecations, repo.get_parent_map, [rev_id])
1839
1024
        self.assertEqual(
1840
1025
            [('call_expecting_body', 'Repository.get_revision_graph',
1841
1026
             ('quack/', ''))],
1849
1034
            errors.UnexpectedSmartServerResponse,
1850
1035
            repo.get_parent_map, ['a-revision-id'])
1851
1036
 
1852
 
    def test_get_parent_map_negative_caches_missing_keys(self):
1853
 
        self.setup_smart_server_with_call_log()
1854
 
        repo = self.make_repository('foo')
1855
 
        self.assertIsInstance(repo, RemoteRepository)
1856
 
        repo.lock_read()
1857
 
        self.addCleanup(repo.unlock)
1858
 
        self.reset_smart_call_log()
1859
 
        graph = repo.get_graph()
1860
 
        self.assertEqual({},
1861
 
            graph.get_parent_map(['some-missing', 'other-missing']))
1862
 
        self.assertLength(1, self.hpss_calls)
1863
 
        # No call if we repeat this
1864
 
        self.reset_smart_call_log()
1865
 
        graph = repo.get_graph()
1866
 
        self.assertEqual({},
1867
 
            graph.get_parent_map(['some-missing', 'other-missing']))
1868
 
        self.assertLength(0, self.hpss_calls)
1869
 
        # Asking for more unknown keys makes a request.
1870
 
        self.reset_smart_call_log()
1871
 
        graph = repo.get_graph()
1872
 
        self.assertEqual({},
1873
 
            graph.get_parent_map(['some-missing', 'other-missing',
1874
 
                'more-missing']))
1875
 
        self.assertLength(1, self.hpss_calls)
1876
 
 
1877
 
    def disableExtraResults(self):
1878
 
        old_flag = SmartServerRepositoryGetParentMap.no_extra_results
1879
 
        SmartServerRepositoryGetParentMap.no_extra_results = True
1880
 
        def reset_values():
1881
 
            SmartServerRepositoryGetParentMap.no_extra_results = old_flag
1882
 
        self.addCleanup(reset_values)
1883
 
 
1884
 
    def test_null_cached_missing_and_stop_key(self):
1885
 
        self.setup_smart_server_with_call_log()
1886
 
        # Make a branch with a single revision.
1887
 
        builder = self.make_branch_builder('foo')
1888
 
        builder.start_series()
1889
 
        builder.build_snapshot('first', None, [
1890
 
            ('add', ('', 'root-id', 'directory', ''))])
1891
 
        builder.finish_series()
1892
 
        branch = builder.get_branch()
1893
 
        repo = branch.repository
1894
 
        self.assertIsInstance(repo, RemoteRepository)
1895
 
        # Stop the server from sending extra results.
1896
 
        self.disableExtraResults()
1897
 
        repo.lock_read()
1898
 
        self.addCleanup(repo.unlock)
1899
 
        self.reset_smart_call_log()
1900
 
        graph = repo.get_graph()
1901
 
        # Query for 'first' and 'null:'.  Because 'null:' is a parent of
1902
 
        # 'first' it will be a candidate for the stop_keys of subsequent
1903
 
        # requests, and because 'null:' was queried but not returned it will be
1904
 
        # cached as missing.
1905
 
        self.assertEqual({'first': ('null:',)},
1906
 
            graph.get_parent_map(['first', 'null:']))
1907
 
        # Now query for another key.  This request will pass along a recipe of
1908
 
        # start and stop keys describing the already cached results, and this
1909
 
        # recipe's revision count must be correct (or else it will trigger an
1910
 
        # error from the server).
1911
 
        self.assertEqual({}, graph.get_parent_map(['another-key']))
1912
 
        # This assertion guards against disableExtraResults silently failing to
1913
 
        # work, thus invalidating the test.
1914
 
        self.assertLength(2, self.hpss_calls)
1915
 
 
1916
 
    def test_get_parent_map_gets_ghosts_from_result(self):
1917
 
        # asking for a revision should negatively cache close ghosts in its
1918
 
        # ancestry.
1919
 
        self.setup_smart_server_with_call_log()
1920
 
        tree = self.make_branch_and_memory_tree('foo')
1921
 
        tree.lock_write()
1922
 
        try:
1923
 
            builder = treebuilder.TreeBuilder()
1924
 
            builder.start_tree(tree)
1925
 
            builder.build([])
1926
 
            builder.finish_tree()
1927
 
            tree.set_parent_ids(['non-existant'], allow_leftmost_as_ghost=True)
1928
 
            rev_id = tree.commit('')
1929
 
        finally:
1930
 
            tree.unlock()
1931
 
        tree.lock_read()
1932
 
        self.addCleanup(tree.unlock)
1933
 
        repo = tree.branch.repository
1934
 
        self.assertIsInstance(repo, RemoteRepository)
1935
 
        # ask for rev_id
1936
 
        repo.get_parent_map([rev_id])
1937
 
        self.reset_smart_call_log()
1938
 
        # Now asking for rev_id's ghost parent should not make calls
1939
 
        self.assertEqual({}, repo.get_parent_map(['non-existant']))
1940
 
        self.assertLength(0, self.hpss_calls)
1941
 
 
1942
 
 
1943
 
class TestGetParentMapAllowsNew(tests.TestCaseWithTransport):
1944
 
 
1945
 
    def test_allows_new_revisions(self):
1946
 
        """get_parent_map's results can be updated by commit."""
1947
 
        smart_server = server.SmartTCPServer_for_testing()
1948
 
        smart_server.setUp()
1949
 
        self.addCleanup(smart_server.tearDown)
1950
 
        self.make_branch('branch')
1951
 
        branch = Branch.open(smart_server.get_url() + '/branch')
1952
 
        tree = branch.create_checkout('tree', lightweight=True)
1953
 
        tree.lock_write()
1954
 
        self.addCleanup(tree.unlock)
1955
 
        graph = tree.branch.repository.get_graph()
1956
 
        # This provides an opportunity for the missing rev-id to be cached.
1957
 
        self.assertEqual({}, graph.get_parent_map(['rev1']))
1958
 
        tree.commit('message', rev_id='rev1')
1959
 
        graph = tree.branch.repository.get_graph()
1960
 
        self.assertEqual({'rev1': ('null:',)}, graph.get_parent_map(['rev1']))
1961
 
 
1962
1037
 
1963
1038
class TestRepositoryGetRevisionGraph(TestRemoteRepository):
1964
 
 
 
1039
    
1965
1040
    def test_null_revision(self):
1966
1041
        # a null revision has the predictable result {}, we should have no wire
1967
1042
        # traffic when calling it with this argument
1968
1043
        transport_path = 'empty'
1969
1044
        repo, client = self.setup_fake_client_and_repository(transport_path)
1970
1045
        client.add_success_response('notused')
1971
 
        # actual RemoteRepository.get_revision_graph is gone, but there's an
1972
 
        # equivalent private method for testing
1973
 
        result = repo._get_revision_graph(NULL_REVISION)
 
1046
        result = self.applyDeprecated(one_four, repo.get_revision_graph,
 
1047
            NULL_REVISION)
1974
1048
        self.assertEqual([], client._calls)
1975
1049
        self.assertEqual({}, result)
1976
1050
 
1984
1058
        transport_path = 'sinhala'
1985
1059
        repo, client = self.setup_fake_client_and_repository(transport_path)
1986
1060
        client.add_success_response_with_body(encoded_body, 'ok')
1987
 
        # actual RemoteRepository.get_revision_graph is gone, but there's an
1988
 
        # equivalent private method for testing
1989
 
        result = repo._get_revision_graph(None)
 
1061
        result = self.applyDeprecated(one_four, repo.get_revision_graph)
1990
1062
        self.assertEqual(
1991
1063
            [('call_expecting_body', 'Repository.get_revision_graph',
1992
1064
             ('sinhala/', ''))],
2005
1077
        transport_path = 'sinhala'
2006
1078
        repo, client = self.setup_fake_client_and_repository(transport_path)
2007
1079
        client.add_success_response_with_body(encoded_body, 'ok')
2008
 
        result = repo._get_revision_graph(r2)
 
1080
        result = self.applyDeprecated(one_four, repo.get_revision_graph, r2)
2009
1081
        self.assertEqual(
2010
1082
            [('call_expecting_body', 'Repository.get_revision_graph',
2011
1083
             ('sinhala/', r2))],
2019
1091
        client.add_error_response('nosuchrevision', revid)
2020
1092
        # also check that the right revision is reported in the error
2021
1093
        self.assertRaises(errors.NoSuchRevision,
2022
 
            repo._get_revision_graph, revid)
 
1094
            self.applyDeprecated, one_four, repo.get_revision_graph, revid)
2023
1095
        self.assertEqual(
2024
1096
            [('call_expecting_body', 'Repository.get_revision_graph',
2025
1097
             ('sinhala/', revid))],
2030
1102
        transport_path = 'sinhala'
2031
1103
        repo, client = self.setup_fake_client_and_repository(transport_path)
2032
1104
        client.add_error_response('AnUnexpectedError')
2033
 
        e = self.assertRaises(errors.UnknownErrorFromSmartServer,
2034
 
            repo._get_revision_graph, revid)
 
1105
        e = self.assertRaises(errors.ErrorFromSmartServer,
 
1106
            self.applyDeprecated, one_four, repo.get_revision_graph, revid)
2035
1107
        self.assertEqual(('AnUnexpectedError',), e.error_tuple)
2036
1108
 
2037
 
 
2038
 
class TestRepositoryGetRevIdForRevno(TestRemoteRepository):
2039
 
 
2040
 
    def test_ok(self):
2041
 
        repo, client = self.setup_fake_client_and_repository('quack')
2042
 
        client.add_expected_call(
2043
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2044
 
            'success', ('ok', 'rev-five'))
2045
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2046
 
        self.assertEqual((True, 'rev-five'), result)
2047
 
        self.assertFinished(client)
2048
 
 
2049
 
    def test_history_incomplete(self):
2050
 
        repo, client = self.setup_fake_client_and_repository('quack')
2051
 
        client.add_expected_call(
2052
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2053
 
            'success', ('history-incomplete', 10, 'rev-ten'))
2054
 
        result = repo.get_rev_id_for_revno(5, (42, 'rev-foo'))
2055
 
        self.assertEqual((False, (10, 'rev-ten')), result)
2056
 
        self.assertFinished(client)
2057
 
 
2058
 
    def test_history_incomplete_with_fallback(self):
2059
 
        """A 'history-incomplete' response causes the fallback repository to be
2060
 
        queried too, if one is set.
2061
 
        """
2062
 
        # Make a repo with a fallback repo, both using a FakeClient.
2063
 
        format = remote.response_tuple_to_repo_format(
2064
 
            ('yes', 'no', 'yes', 'fake-network-name'))
2065
 
        repo, client = self.setup_fake_client_and_repository('quack')
2066
 
        repo._format = format
2067
 
        fallback_repo, ignored = self.setup_fake_client_and_repository(
2068
 
            'fallback')
2069
 
        fallback_repo._client = client
2070
 
        repo.add_fallback_repository(fallback_repo)
2071
 
        # First the client should ask the primary repo
2072
 
        client.add_expected_call(
2073
 
            'Repository.get_rev_id_for_revno', ('quack/', 1, (42, 'rev-foo')),
2074
 
            'success', ('history-incomplete', 2, 'rev-two'))
2075
 
        # Then it should ask the fallback, using revno/revid from the
2076
 
        # history-incomplete response as the known revno/revid.
2077
 
        client.add_expected_call(
2078
 
            'Repository.get_rev_id_for_revno',('fallback/', 1, (2, 'rev-two')),
2079
 
            'success', ('ok', 'rev-one'))
2080
 
        result = repo.get_rev_id_for_revno(1, (42, 'rev-foo'))
2081
 
        self.assertEqual((True, 'rev-one'), result)
2082
 
        self.assertFinished(client)
2083
 
 
2084
 
    def test_nosuchrevision(self):
2085
 
        # 'nosuchrevision' is returned when the known-revid is not found in the
2086
 
        # remote repo.  The client translates that response to NoSuchRevision.
2087
 
        repo, client = self.setup_fake_client_and_repository('quack')
2088
 
        client.add_expected_call(
2089
 
            'Repository.get_rev_id_for_revno', ('quack/', 5, (42, 'rev-foo')),
2090
 
            'error', ('nosuchrevision', 'rev-foo'))
2091
 
        self.assertRaises(
2092
 
            errors.NoSuchRevision,
2093
 
            repo.get_rev_id_for_revno, 5, (42, 'rev-foo'))
2094
 
        self.assertFinished(client)
2095
 
 
2096
 
 
 
1109
        
2097
1110
class TestRepositoryIsShared(TestRemoteRepository):
2098
1111
 
2099
1112
    def test_is_shared(self):
2150
1163
            client._calls)
2151
1164
 
2152
1165
 
2153
 
class TestRepositorySetMakeWorkingTrees(TestRemoteRepository):
2154
 
 
2155
 
    def test_backwards_compat(self):
2156
 
        self.setup_smart_server_with_call_log()
2157
 
        repo = self.make_repository('.')
2158
 
        self.reset_smart_call_log()
2159
 
        verb = 'Repository.set_make_working_trees'
2160
 
        self.disable_verb(verb)
2161
 
        repo.set_make_working_trees(True)
2162
 
        call_count = len([call for call in self.hpss_calls if
2163
 
            call.call.method == verb])
2164
 
        self.assertEqual(1, call_count)
2165
 
 
2166
 
    def test_current(self):
2167
 
        transport_path = 'quack'
2168
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2169
 
        client.add_expected_call(
2170
 
            'Repository.set_make_working_trees', ('quack/', 'True'),
2171
 
            'success', ('ok',))
2172
 
        client.add_expected_call(
2173
 
            'Repository.set_make_working_trees', ('quack/', 'False'),
2174
 
            'success', ('ok',))
2175
 
        repo.set_make_working_trees(True)
2176
 
        repo.set_make_working_trees(False)
2177
 
 
2178
 
 
2179
1166
class TestRepositoryUnlock(TestRemoteRepository):
2180
1167
 
2181
1168
    def test_unlock(self):
2214
1201
        self.assertEqual([], client._calls)
2215
1202
 
2216
1203
 
2217
 
class TestRepositoryInsertStreamBase(TestRemoteRepository):
2218
 
    """Base class for Repository.insert_stream and .insert_stream_1.19
2219
 
    tests.
2220
 
    """
2221
 
    
2222
 
    def checkInsertEmptyStream(self, repo, client):
2223
 
        """Insert an empty stream, checking the result.
2224
 
 
2225
 
        This checks that there are no resume_tokens or missing_keys, and that
2226
 
        the client is finished.
2227
 
        """
2228
 
        sink = repo._get_sink()
2229
 
        fmt = repository.RepositoryFormat.get_default_format()
2230
 
        resume_tokens, missing_keys = sink.insert_stream([], fmt, [])
2231
 
        self.assertEqual([], resume_tokens)
2232
 
        self.assertEqual(set(), missing_keys)
2233
 
        self.assertFinished(client)
2234
 
 
2235
 
 
2236
 
class TestRepositoryInsertStream(TestRepositoryInsertStreamBase):
2237
 
    """Tests for using Repository.insert_stream verb when the _1.19 variant is
2238
 
    not available.
2239
 
 
2240
 
    This test case is very similar to TestRepositoryInsertStream_1_19.
2241
 
    """
2242
 
 
2243
 
    def setUp(self):
2244
 
        TestRemoteRepository.setUp(self)
2245
 
        self.disable_verb('Repository.insert_stream_1.19')
2246
 
 
2247
 
    def test_unlocked_repo(self):
2248
 
        transport_path = 'quack'
2249
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2250
 
        client.add_expected_call(
2251
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2252
 
            'unknown', ('Repository.insert_stream_1.19',))
2253
 
        client.add_expected_call(
2254
 
            'Repository.insert_stream', ('quack/', ''),
2255
 
            'success', ('ok',))
2256
 
        client.add_expected_call(
2257
 
            'Repository.insert_stream', ('quack/', ''),
2258
 
            'success', ('ok',))
2259
 
        self.checkInsertEmptyStream(repo, client)
2260
 
 
2261
 
    def test_locked_repo_with_no_lock_token(self):
2262
 
        transport_path = 'quack'
2263
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2264
 
        client.add_expected_call(
2265
 
            'Repository.lock_write', ('quack/', ''),
2266
 
            'success', ('ok', ''))
2267
 
        client.add_expected_call(
2268
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2269
 
            'unknown', ('Repository.insert_stream_1.19',))
2270
 
        client.add_expected_call(
2271
 
            'Repository.insert_stream', ('quack/', ''),
2272
 
            'success', ('ok',))
2273
 
        client.add_expected_call(
2274
 
            'Repository.insert_stream', ('quack/', ''),
2275
 
            'success', ('ok',))
2276
 
        repo.lock_write()
2277
 
        self.checkInsertEmptyStream(repo, client)
2278
 
 
2279
 
    def test_locked_repo_with_lock_token(self):
2280
 
        transport_path = 'quack'
2281
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2282
 
        client.add_expected_call(
2283
 
            'Repository.lock_write', ('quack/', ''),
2284
 
            'success', ('ok', 'a token'))
2285
 
        client.add_expected_call(
2286
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2287
 
            'unknown', ('Repository.insert_stream_1.19',))
2288
 
        client.add_expected_call(
2289
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2290
 
            'success', ('ok',))
2291
 
        client.add_expected_call(
2292
 
            'Repository.insert_stream_locked', ('quack/', '', 'a token'),
2293
 
            'success', ('ok',))
2294
 
        repo.lock_write()
2295
 
        self.checkInsertEmptyStream(repo, client)
2296
 
 
2297
 
    def test_stream_with_inventory_deltas(self):
2298
 
        """'inventory-deltas' substreams cannot be sent to the
2299
 
        Repository.insert_stream verb, because not all servers that implement
2300
 
        that verb will accept them.  So when one is encountered the RemoteSink
2301
 
        immediately stops using that verb and falls back to VFS insert_stream.
2302
 
        """
2303
 
        transport_path = 'quack'
2304
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2305
 
        client.add_expected_call(
2306
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2307
 
            'unknown', ('Repository.insert_stream_1.19',))
2308
 
        client.add_expected_call(
2309
 
            'Repository.insert_stream', ('quack/', ''),
2310
 
            'success', ('ok',))
2311
 
        client.add_expected_call(
2312
 
            'Repository.insert_stream', ('quack/', ''),
2313
 
            'success', ('ok',))
2314
 
        # Create a fake real repository for insert_stream to fall back on, so
2315
 
        # that we can directly see the records the RemoteSink passes to the
2316
 
        # real sink.
2317
 
        class FakeRealSink:
2318
 
            def __init__(self):
2319
 
                self.records = []
2320
 
            def insert_stream(self, stream, src_format, resume_tokens):
2321
 
                for substream_kind, substream in stream:
2322
 
                    self.records.append(
2323
 
                        (substream_kind, [record.key for record in substream]))
2324
 
                return ['fake tokens'], ['fake missing keys']
2325
 
        fake_real_sink = FakeRealSink()
2326
 
        class FakeRealRepository:
2327
 
            def _get_sink(self):
2328
 
                return fake_real_sink
2329
 
        repo._real_repository = FakeRealRepository()
2330
 
        sink = repo._get_sink()
2331
 
        fmt = repository.RepositoryFormat.get_default_format()
2332
 
        stream = self.make_stream_with_inv_deltas(fmt)
2333
 
        resume_tokens, missing_keys = sink.insert_stream(stream, fmt, [])
2334
 
        # Every record from the first inventory delta should have been sent to
2335
 
        # the VFS sink.
2336
 
        expected_records = [
2337
 
            ('inventory-deltas', [('rev2',), ('rev3',)]),
2338
 
            ('texts', [('some-rev', 'some-file')])]
2339
 
        self.assertEqual(expected_records, fake_real_sink.records)
2340
 
        # The return values from the real sink's insert_stream are propagated
2341
 
        # back to the original caller.
2342
 
        self.assertEqual(['fake tokens'], resume_tokens)
2343
 
        self.assertEqual(['fake missing keys'], missing_keys)
2344
 
        self.assertFinished(client)
2345
 
 
2346
 
    def make_stream_with_inv_deltas(self, fmt):
2347
 
        """Make a simple stream with an inventory delta followed by more
2348
 
        records and more substreams to test that all records and substreams
2349
 
        from that point on are used.
2350
 
 
2351
 
        This sends, in order:
2352
 
           * inventories substream: rev1, rev2, rev3.  rev2 and rev3 are
2353
 
             inventory-deltas.
2354
 
           * texts substream: (some-rev, some-file)
2355
 
        """
2356
 
        # Define a stream using generators so that it isn't rewindable.
2357
 
        inv = inventory.Inventory(revision_id='rev1')
2358
 
        inv.root.revision = 'rev1'
2359
 
        def stream_with_inv_delta():
2360
 
            yield ('inventories', inventories_substream())
2361
 
            yield ('inventory-deltas', inventory_delta_substream())
2362
 
            yield ('texts', [
2363
 
                versionedfile.FulltextContentFactory(
2364
 
                    ('some-rev', 'some-file'), (), None, 'content')])
2365
 
        def inventories_substream():
2366
 
            # An empty inventory fulltext.  This will be streamed normally.
2367
 
            text = fmt._serializer.write_inventory_to_string(inv)
2368
 
            yield versionedfile.FulltextContentFactory(
2369
 
                ('rev1',), (), None, text)
2370
 
        def inventory_delta_substream():
2371
 
            # An inventory delta.  This can't be streamed via this verb, so it
2372
 
            # will trigger a fallback to VFS insert_stream.
2373
 
            entry = inv.make_entry(
2374
 
                'directory', 'newdir', inv.root.file_id, 'newdir-id')
2375
 
            entry.revision = 'ghost'
2376
 
            delta = [(None, 'newdir', 'newdir-id', entry)]
2377
 
            serializer = inventory_delta.InventoryDeltaSerializer(
2378
 
                versioned_root=True, tree_references=False)
2379
 
            lines = serializer.delta_to_lines('rev1', 'rev2', delta)
2380
 
            yield versionedfile.ChunkedContentFactory(
2381
 
                ('rev2',), (('rev1',)), None, lines)
2382
 
            # Another delta.
2383
 
            lines = serializer.delta_to_lines('rev1', 'rev3', delta)
2384
 
            yield versionedfile.ChunkedContentFactory(
2385
 
                ('rev3',), (('rev1',)), None, lines)
2386
 
        return stream_with_inv_delta()
2387
 
 
2388
 
 
2389
 
class TestRepositoryInsertStream_1_19(TestRepositoryInsertStreamBase):
2390
 
 
2391
 
    def test_unlocked_repo(self):
2392
 
        transport_path = 'quack'
2393
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2394
 
        client.add_expected_call(
2395
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2396
 
            'success', ('ok',))
2397
 
        client.add_expected_call(
2398
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2399
 
            'success', ('ok',))
2400
 
        self.checkInsertEmptyStream(repo, client)
2401
 
 
2402
 
    def test_locked_repo_with_no_lock_token(self):
2403
 
        transport_path = 'quack'
2404
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2405
 
        client.add_expected_call(
2406
 
            'Repository.lock_write', ('quack/', ''),
2407
 
            'success', ('ok', ''))
2408
 
        client.add_expected_call(
2409
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2410
 
            'success', ('ok',))
2411
 
        client.add_expected_call(
2412
 
            'Repository.insert_stream_1.19', ('quack/', ''),
2413
 
            'success', ('ok',))
2414
 
        repo.lock_write()
2415
 
        self.checkInsertEmptyStream(repo, client)
2416
 
 
2417
 
    def test_locked_repo_with_lock_token(self):
2418
 
        transport_path = 'quack'
2419
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2420
 
        client.add_expected_call(
2421
 
            'Repository.lock_write', ('quack/', ''),
2422
 
            'success', ('ok', 'a token'))
2423
 
        client.add_expected_call(
2424
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2425
 
            'success', ('ok',))
2426
 
        client.add_expected_call(
2427
 
            'Repository.insert_stream_1.19', ('quack/', '', 'a token'),
2428
 
            'success', ('ok',))
2429
 
        repo.lock_write()
2430
 
        self.checkInsertEmptyStream(repo, client)
2431
 
 
2432
 
 
2433
1204
class TestRepositoryTarball(TestRemoteRepository):
2434
1205
 
2435
1206
    # This is a canned tarball reponse we can validate against
2484
1255
        src_repo.copy_content_into(dest_repo)
2485
1256
 
2486
1257
 
2487
 
class _StubRealPackRepository(object):
2488
 
 
2489
 
    def __init__(self, calls):
2490
 
        self.calls = calls
2491
 
        self._pack_collection = _StubPackCollection(calls)
2492
 
 
2493
 
    def is_in_write_group(self):
2494
 
        return False
2495
 
 
2496
 
    def refresh_data(self):
2497
 
        self.calls.append(('pack collection reload_pack_names',))
2498
 
 
2499
 
 
2500
 
class _StubPackCollection(object):
2501
 
 
2502
 
    def __init__(self, calls):
2503
 
        self.calls = calls
2504
 
 
2505
 
    def autopack(self):
2506
 
        self.calls.append(('pack collection autopack',))
2507
 
 
2508
 
 
2509
 
class TestRemotePackRepositoryAutoPack(TestRemoteRepository):
2510
 
    """Tests for RemoteRepository.autopack implementation."""
2511
 
 
2512
 
    def test_ok(self):
2513
 
        """When the server returns 'ok' and there's no _real_repository, then
2514
 
        nothing else happens: the autopack method is done.
2515
 
        """
2516
 
        transport_path = 'quack'
2517
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2518
 
        client.add_expected_call(
2519
 
            'PackRepository.autopack', ('quack/',), 'success', ('ok',))
2520
 
        repo.autopack()
2521
 
        self.assertFinished(client)
2522
 
 
2523
 
    def test_ok_with_real_repo(self):
2524
 
        """When the server returns 'ok' and there is a _real_repository, then
2525
 
        the _real_repository's reload_pack_name's method will be called.
2526
 
        """
2527
 
        transport_path = 'quack'
2528
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2529
 
        client.add_expected_call(
2530
 
            'PackRepository.autopack', ('quack/',),
2531
 
            'success', ('ok',))
2532
 
        repo._real_repository = _StubRealPackRepository(client._calls)
2533
 
        repo.autopack()
2534
 
        self.assertEqual(
2535
 
            [('call', 'PackRepository.autopack', ('quack/',)),
2536
 
             ('pack collection reload_pack_names',)],
2537
 
            client._calls)
2538
 
 
2539
 
    def test_backwards_compatibility(self):
2540
 
        """If the server does not recognise the PackRepository.autopack verb,
2541
 
        fallback to the real_repository's implementation.
2542
 
        """
2543
 
        transport_path = 'quack'
2544
 
        repo, client = self.setup_fake_client_and_repository(transport_path)
2545
 
        client.add_unknown_method_response('PackRepository.autopack')
2546
 
        def stub_ensure_real():
2547
 
            client._calls.append(('_ensure_real',))
2548
 
            repo._real_repository = _StubRealPackRepository(client._calls)
2549
 
        repo._ensure_real = stub_ensure_real
2550
 
        repo.autopack()
2551
 
        self.assertEqual(
2552
 
            [('call', 'PackRepository.autopack', ('quack/',)),
2553
 
             ('_ensure_real',),
2554
 
             ('pack collection autopack',)],
2555
 
            client._calls)
2556
 
 
2557
 
 
2558
1258
class TestErrorTranslationBase(tests.TestCaseWithMemoryTransport):
2559
1259
    """Base class for unit tests for bzrlib.remote._translate_error."""
2560
1260
 
2588
1288
                **context)
2589
1289
        return translated_error
2590
1290
 
2591
 
 
 
1291
    
2592
1292
class TestErrorTranslationSuccess(TestErrorTranslationBase):
2593
1293
    """Unit tests for bzrlib.remote._translate_error.
2594
 
 
 
1294
    
2595
1295
    Given an ErrorFromSmartServer (which has an error tuple from a smart
2596
1296
    server) and some context, _translate_error raises more specific errors from
2597
1297
    bzrlib.errors.
2656
1356
        expected_error = errors.DivergedBranches(branch, other_branch)
2657
1357
        self.assertEqual(expected_error, translated_error)
2658
1358
 
2659
 
    def test_ReadError_no_args(self):
2660
 
        path = 'a path'
2661
 
        translated_error = self.translateTuple(('ReadError',), path=path)
2662
 
        expected_error = errors.ReadError(path)
2663
 
        self.assertEqual(expected_error, translated_error)
2664
 
 
2665
 
    def test_ReadError(self):
2666
 
        path = 'a path'
2667
 
        translated_error = self.translateTuple(('ReadError', path))
2668
 
        expected_error = errors.ReadError(path)
2669
 
        self.assertEqual(expected_error, translated_error)
2670
 
 
2671
 
    def test_PermissionDenied_no_args(self):
2672
 
        path = 'a path'
2673
 
        translated_error = self.translateTuple(('PermissionDenied',), path=path)
2674
 
        expected_error = errors.PermissionDenied(path)
2675
 
        self.assertEqual(expected_error, translated_error)
2676
 
 
2677
 
    def test_PermissionDenied_one_arg(self):
2678
 
        path = 'a path'
2679
 
        translated_error = self.translateTuple(('PermissionDenied', path))
2680
 
        expected_error = errors.PermissionDenied(path)
2681
 
        self.assertEqual(expected_error, translated_error)
2682
 
 
2683
 
    def test_PermissionDenied_one_arg_and_context(self):
2684
 
        """Given a choice between a path from the local context and a path on
2685
 
        the wire, _translate_error prefers the path from the local context.
2686
 
        """
2687
 
        local_path = 'local path'
2688
 
        remote_path = 'remote path'
2689
 
        translated_error = self.translateTuple(
2690
 
            ('PermissionDenied', remote_path), path=local_path)
2691
 
        expected_error = errors.PermissionDenied(local_path)
2692
 
        self.assertEqual(expected_error, translated_error)
2693
 
 
2694
 
    def test_PermissionDenied_two_args(self):
2695
 
        path = 'a path'
2696
 
        extra = 'a string with extra info'
2697
 
        translated_error = self.translateTuple(
2698
 
            ('PermissionDenied', path, extra))
2699
 
        expected_error = errors.PermissionDenied(path, extra)
2700
 
        self.assertEqual(expected_error, translated_error)
2701
 
 
2702
1359
 
2703
1360
class TestErrorTranslationRobustness(TestErrorTranslationBase):
2704
1361
    """Unit tests for bzrlib.remote._translate_error's robustness.
2705
 
 
 
1362
    
2706
1363
    TestErrorTranslationSuccess is for cases where _translate_error can
2707
1364
    translate successfully.  This class about how _translate_err behaves when
2708
1365
    it fails to translate: it re-raises the original error.
2715
1372
        error_tuple = ('An unknown error tuple',)
2716
1373
        server_error = errors.ErrorFromSmartServer(error_tuple)
2717
1374
        translated_error = self.translateErrorFromSmartServer(server_error)
2718
 
        expected_error = errors.UnknownErrorFromSmartServer(server_error)
2719
 
        self.assertEqual(expected_error, translated_error)
 
1375
        self.assertEqual(server_error, translated_error)
2720
1376
 
2721
1377
    def test_context_missing_a_key(self):
2722
1378
        """In case of a bug in the client, or perhaps an unexpected response
2736
1392
        self.assertContainsRe(
2737
1393
            self._get_log(keep_log_file=True),
2738
1394
            "Missing key 'branch' in context")
2739
 
 
2740
 
    def test_path_missing(self):
2741
 
        """Some translations (PermissionDenied, ReadError) can determine the
2742
 
        'path' variable from either the wire or the local context.  If neither
2743
 
        has it, then an error is raised.
2744
 
        """
2745
 
        error_tuple = ('ReadError',)
2746
 
        server_error = errors.ErrorFromSmartServer(error_tuple)
2747
 
        translated_error = self.translateErrorFromSmartServer(server_error)
2748
 
        self.assertEqual(server_error, translated_error)
2749
 
        # In addition to re-raising ErrorFromSmartServer, some debug info has
2750
 
        # been muttered to the log file for developer to look at.
2751
 
        self.assertContainsRe(
2752
 
            self._get_log(keep_log_file=True), "Missing key 'path' in context")
2753
 
 
2754
 
 
2755
 
class TestStacking(tests.TestCaseWithTransport):
2756
 
    """Tests for operations on stacked remote repositories.
2757
 
 
2758
 
    The underlying format type must support stacking.
2759
 
    """
2760
 
 
2761
 
    def test_access_stacked_remote(self):
2762
 
        # based on <http://launchpad.net/bugs/261315>
2763
 
        # make a branch stacked on another repository containing an empty
2764
 
        # revision, then open it over hpss - we should be able to see that
2765
 
        # revision.
2766
 
        base_transport = self.get_transport()
2767
 
        base_builder = self.make_branch_builder('base', format='1.9')
2768
 
        base_builder.start_series()
2769
 
        base_revid = base_builder.build_snapshot('rev-id', None,
2770
 
            [('add', ('', None, 'directory', None))],
2771
 
            'message')
2772
 
        base_builder.finish_series()
2773
 
        stacked_branch = self.make_branch('stacked', format='1.9')
2774
 
        stacked_branch.set_stacked_on_url('../base')
2775
 
        # start a server looking at this
2776
 
        smart_server = server.SmartTCPServer_for_testing()
2777
 
        smart_server.setUp()
2778
 
        self.addCleanup(smart_server.tearDown)
2779
 
        remote_bzrdir = BzrDir.open(smart_server.get_url() + '/stacked')
2780
 
        # can get its branch and repository
2781
 
        remote_branch = remote_bzrdir.open_branch()
2782
 
        remote_repo = remote_branch.repository
2783
 
        remote_repo.lock_read()
2784
 
        try:
2785
 
            # it should have an appropriate fallback repository, which should also
2786
 
            # be a RemoteRepository
2787
 
            self.assertLength(1, remote_repo._fallback_repositories)
2788
 
            self.assertIsInstance(remote_repo._fallback_repositories[0],
2789
 
                RemoteRepository)
2790
 
            # and it has the revision committed to the underlying repository;
2791
 
            # these have varying implementations so we try several of them
2792
 
            self.assertTrue(remote_repo.has_revisions([base_revid]))
2793
 
            self.assertTrue(remote_repo.has_revision(base_revid))
2794
 
            self.assertEqual(remote_repo.get_revision(base_revid).message,
2795
 
                'message')
2796
 
        finally:
2797
 
            remote_repo.unlock()
2798
 
 
2799
 
    def prepare_stacked_remote_branch(self):
2800
 
        """Get stacked_upon and stacked branches with content in each."""
2801
 
        self.setup_smart_server_with_call_log()
2802
 
        tree1 = self.make_branch_and_tree('tree1', format='1.9')
2803
 
        tree1.commit('rev1', rev_id='rev1')
2804
 
        tree2 = tree1.branch.bzrdir.sprout('tree2', stacked=True
2805
 
            ).open_workingtree()
2806
 
        local_tree = tree2.branch.create_checkout('local')
2807
 
        local_tree.commit('local changes make me feel good.')
2808
 
        branch2 = Branch.open(self.get_url('tree2'))
2809
 
        branch2.lock_read()
2810
 
        self.addCleanup(branch2.unlock)
2811
 
        return tree1.branch, branch2
2812
 
 
2813
 
    def test_stacked_get_parent_map(self):
2814
 
        # the public implementation of get_parent_map obeys stacking
2815
 
        _, branch = self.prepare_stacked_remote_branch()
2816
 
        repo = branch.repository
2817
 
        self.assertEqual(['rev1'], repo.get_parent_map(['rev1']).keys())
2818
 
 
2819
 
    def test_unstacked_get_parent_map(self):
2820
 
        # _unstacked_provider.get_parent_map ignores stacking
2821
 
        _, branch = self.prepare_stacked_remote_branch()
2822
 
        provider = branch.repository._unstacked_provider
2823
 
        self.assertEqual([], provider.get_parent_map(['rev1']).keys())
2824
 
 
2825
 
    def fetch_stream_to_rev_order(self, stream):
2826
 
        result = []
2827
 
        for kind, substream in stream:
2828
 
            if not kind == 'revisions':
2829
 
                list(substream)
2830
 
            else:
2831
 
                for content in substream:
2832
 
                    result.append(content.key[-1])
2833
 
        return result
2834
 
 
2835
 
    def get_ordered_revs(self, format, order, branch_factory=None):
2836
 
        """Get a list of the revisions in a stream to format format.
2837
 
 
2838
 
        :param format: The format of the target.
2839
 
        :param order: the order that target should have requested.
2840
 
        :param branch_factory: A callable to create a trunk and stacked branch
2841
 
            to fetch from. If none, self.prepare_stacked_remote_branch is used.
2842
 
        :result: The revision ids in the stream, in the order seen,
2843
 
            the topological order of revisions in the source.
2844
 
        """
2845
 
        unordered_format = bzrdir.format_registry.get(format)()
2846
 
        target_repository_format = unordered_format.repository_format
2847
 
        # Cross check
2848
 
        self.assertEqual(order, target_repository_format._fetch_order)
2849
 
        if branch_factory is None:
2850
 
            branch_factory = self.prepare_stacked_remote_branch
2851
 
        _, stacked = branch_factory()
2852
 
        source = stacked.repository._get_source(target_repository_format)
2853
 
        tip = stacked.last_revision()
2854
 
        revs = stacked.repository.get_ancestry(tip)
2855
 
        search = graph.PendingAncestryResult([tip], stacked.repository)
2856
 
        self.reset_smart_call_log()
2857
 
        stream = source.get_stream(search)
2858
 
        if None in revs:
2859
 
            revs.remove(None)
2860
 
        # We trust that if a revision is in the stream the rest of the new
2861
 
        # content for it is too, as per our main fetch tests; here we are
2862
 
        # checking that the revisions are actually included at all, and their
2863
 
        # order.
2864
 
        return self.fetch_stream_to_rev_order(stream), revs
2865
 
 
2866
 
    def test_stacked_get_stream_unordered(self):
2867
 
        # Repository._get_source.get_stream() from a stacked repository with
2868
 
        # unordered yields the full data from both stacked and stacked upon
2869
 
        # sources.
2870
 
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered')
2871
 
        self.assertEqual(set(expected_revs), set(rev_ord))
2872
 
        # Getting unordered results should have made a streaming data request
2873
 
        # from the server, then one from the backing branch.
2874
 
        self.assertLength(2, self.hpss_calls)
2875
 
 
2876
 
    def test_stacked_on_stacked_get_stream_unordered(self):
2877
 
        # Repository._get_source.get_stream() from a stacked repository which
2878
 
        # is itself stacked yields the full data from all three sources.
2879
 
        def make_stacked_stacked():
2880
 
            _, stacked = self.prepare_stacked_remote_branch()
2881
 
            tree = stacked.bzrdir.sprout('tree3', stacked=True
2882
 
                ).open_workingtree()
2883
 
            local_tree = tree.branch.create_checkout('local-tree3')
2884
 
            local_tree.commit('more local changes are better')
2885
 
            branch = Branch.open(self.get_url('tree3'))
2886
 
            branch.lock_read()
2887
 
            return None, branch
2888
 
        rev_ord, expected_revs = self.get_ordered_revs('1.9', 'unordered',
2889
 
            branch_factory=make_stacked_stacked)
2890
 
        self.assertEqual(set(expected_revs), set(rev_ord))
2891
 
        # Getting unordered results should have made a streaming data request
2892
 
        # from the server, and one from each backing repo
2893
 
        self.assertLength(3, self.hpss_calls)
2894
 
 
2895
 
    def test_stacked_get_stream_topological(self):
2896
 
        # Repository._get_source.get_stream() from a stacked repository with
2897
 
        # topological sorting yields the full data from both stacked and
2898
 
        # stacked upon sources in topological order.
2899
 
        rev_ord, expected_revs = self.get_ordered_revs('knit', 'topological')
2900
 
        self.assertEqual(expected_revs, rev_ord)
2901
 
        # Getting topological sort requires VFS calls still - one of which is
2902
 
        # pushing up from the bound branch.
2903
 
        self.assertLength(13, self.hpss_calls)
2904
 
 
2905
 
    def test_stacked_get_stream_groupcompress(self):
2906
 
        # Repository._get_source.get_stream() from a stacked repository with
2907
 
        # groupcompress sorting yields the full data from both stacked and
2908
 
        # stacked upon sources in groupcompress order.
2909
 
        raise tests.TestSkipped('No groupcompress ordered format available')
2910
 
        rev_ord, expected_revs = self.get_ordered_revs('dev5', 'groupcompress')
2911
 
        self.assertEqual(expected_revs, reversed(rev_ord))
2912
 
        # Getting unordered results should have made a streaming data request
2913
 
        # from the backing branch, and one from the stacked on branch.
2914
 
        self.assertLength(2, self.hpss_calls)
2915
 
 
2916
 
    def test_stacked_pull_more_than_stacking_has_bug_360791(self):
2917
 
        # When pulling some fixed amount of content that is more than the
2918
 
        # source has (because some is coming from a fallback branch, no error
2919
 
        # should be received. This was reported as bug 360791.
2920
 
        # Need three branches: a trunk, a stacked branch, and a preexisting
2921
 
        # branch pulling content from stacked and trunk.
2922
 
        self.setup_smart_server_with_call_log()
2923
 
        trunk = self.make_branch_and_tree('trunk', format="1.9-rich-root")
2924
 
        r1 = trunk.commit('start')
2925
 
        stacked_branch = trunk.branch.create_clone_on_transport(
2926
 
            self.get_transport('stacked'), stacked_on=trunk.branch.base)
2927
 
        local = self.make_branch('local', format='1.9-rich-root')
2928
 
        local.repository.fetch(stacked_branch.repository,
2929
 
            stacked_branch.last_revision())
2930
 
 
2931
 
 
2932
 
class TestRemoteBranchEffort(tests.TestCaseWithTransport):
2933
 
 
2934
 
    def setUp(self):
2935
 
        super(TestRemoteBranchEffort, self).setUp()
2936
 
        # Create a smart server that publishes whatever the backing VFS server
2937
 
        # does.
2938
 
        self.smart_server = server.SmartTCPServer_for_testing()
2939
 
        self.smart_server.setUp(self.get_server())
2940
 
        self.addCleanup(self.smart_server.tearDown)
2941
 
        # Log all HPSS calls into self.hpss_calls.
2942
 
        _SmartClient.hooks.install_named_hook(
2943
 
            'call', self.capture_hpss_call, None)
2944
 
        self.hpss_calls = []
2945
 
 
2946
 
    def capture_hpss_call(self, params):
2947
 
        self.hpss_calls.append(params.method)
2948
 
 
2949
 
    def test_copy_content_into_avoids_revision_history(self):
2950
 
        local = self.make_branch('local')
2951
 
        remote_backing_tree = self.make_branch_and_tree('remote')
2952
 
        remote_backing_tree.commit("Commit.")
2953
 
        remote_branch_url = self.smart_server.get_url() + 'remote'
2954
 
        remote_branch = bzrdir.BzrDir.open(remote_branch_url).open_branch()
2955
 
        local.repository.fetch(remote_branch.repository)
2956
 
        self.hpss_calls = []
2957
 
        remote_branch.copy_content_into(local)
2958
 
        self.assertFalse('Branch.revision_history' in self.hpss_calls)
 
1395