← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_revision.py

  • Committer: Vincent Ladeuil
  • Date: 2008-08-26 08:25:27 UTC
  • mto: (3668.1.1 trunk) (3703.1.1 trunk)
  • mto: This revision was merged to the branch mainline in revision 3669.
  • Revision ID: v.ladeuil+lp@free.fr-20080826082527-109yyxzc0u24oeel
Fix all calls to tempfile.mkdtemp to osutils.mkdtemp.

* bzrlib/transform.py:
(TransformPreview.__init__): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

* bzrlib/tests/test_whitebox.py:
(MoreTests.test_relpath): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

* bzrlib/tests/test_setup.py:
(TestSetup.test_build_and_install): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

* bzrlib/tests/test_bundle.py:
(BundleTester.get_checkout): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

* bzrlib/tests/blackbox/test_outside_wt.py:
(TestOutsideWT.test_cwd_log,
TestOutsideWT.test_diff_outside_tree): Use osutils.mkdtemp instead
of tempfile.mkdtemp.

* bzrlib/smart/repository.py:
(SmartServerRepositoryTarball._copy_to_tempdir): Use
osutils.mkdtemp instead of tempfile.mkdtemp.
(SmartServerRepositoryTarball._tarfile_response): Line too long.

* bzrlib/remote.py:
(RemoteRepository._copy_repository_tarball): Use osutils.mkdtemp
instead of tempfile.mkdtemp.

* bzrlib/osutils.py:
(_mac_mkdtemp): Add docstring.

* bzrlib/mail_client.py:
(ExternalMailClient.compose): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

* bzrlib/diff.py:
(DiffFromTool.__init__): Use osutils.mkdtemp instead of
tempfile.mkdtemp.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_revision.py
1
 
# (C) 2005 Canonical Ltd
2
 
 
 
1
# Copyright (C) 2005 Canonical Ltd
 
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
5
5
# the Free Software Foundation; either version 2 of the License, or
6
6
# (at your option) any later version.
7
 
 
 
7
#
8
8
# This program is distributed in the hope that it will be useful,
9
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
11
# GNU General Public License for more details.
12
 
 
 
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
18
import os
19
19
import warnings
20
20
 
 
21
from bzrlib import (
 
22
    revision,
 
23
    symbol_versioning,
 
24
    )
21
25
from bzrlib.branch import Branch
22
26
from bzrlib.errors import NoSuchRevision
23
 
from bzrlib.graph import Graph
24
 
from bzrlib.revision import (find_present_ancestors, combined_graph,
25
 
                             common_ancestor,
26
 
                             is_ancestor, MultipleRevisionSources,
 
27
from bzrlib.deprecated_graph import Graph
 
28
from bzrlib.revision import (find_present_ancestors,
27
29
                             NULL_REVISION)
28
 
from bzrlib.tests import TestCaseWithTransport
 
30
from bzrlib.symbol_versioning import one_three
 
31
from bzrlib.tests import TestCase, TestCaseWithTransport
29
32
from bzrlib.trace import mutter
30
33
from bzrlib.workingtree import WorkingTree
31
34
 
36
39
        r'bzrlib\.tests\.test_revision')
37
40
 
38
41
# XXX: Make this a method of a merge base case
39
 
def make_branches(self):
 
42
def make_branches(self, format=None):
40
43
    """Create two branches
41
44
 
42
45
    branch 1 has 6 commits, branch 2 has 3 commits
55
58
    so A is missing b6 at the start
56
59
    and B is missing a3, a4, a5
57
60
    """
58
 
    tree1 = self.make_branch_and_tree("branch1")
 
61
    tree1 = self.make_branch_and_tree("branch1", format=format)
59
62
    br1 = tree1.branch
60
63
    
61
64
    tree1.commit("Commit one", rev_id="a@u-0-0")
67
70
    tree2.commit("Commit four", rev_id="b@u-0-3")
68
71
    tree2.commit("Commit five", rev_id="b@u-0-4")
69
72
    revisions_2 = br2.revision_history()
 
73
    self.assertEquals(revisions_2[-1], 'b@u-0-4')
70
74
    
71
 
    br1.fetch(br2)
72
 
    tree1.add_pending_merge(revisions_2[4])
73
 
    self.assertEquals(revisions_2[4], 'b@u-0-4')
 
75
    tree1.merge_from_branch(br2)
74
76
    tree1.commit("Commit six", rev_id="a@u-0-3")
75
77
    tree1.commit("Commit seven", rev_id="a@u-0-4")
76
78
    tree2.commit("Commit eight", rev_id="b@u-0-5")
 
79
    self.assertEquals(br2.revision_history()[-1], 'b@u-0-5')
77
80
    
78
 
    br1.fetch(br2)
79
 
    tree1.add_pending_merge(br2.revision_history()[5])
 
81
    tree1.merge_from_branch(br2)
80
82
    tree1.commit("Commit nine", rev_id="a@u-0-5")
81
 
    # DO NOT FETCH HERE - we WANT a GHOST.
82
 
    # br2.fetch(br1)
83
 
    tree2.add_pending_merge(br1.revision_history()[4])
 
83
    # DO NOT MERGE HERE - we WANT a GHOST.
 
84
    tree2.add_parent_tree_id(br1.revision_history()[4])
84
85
    tree2.commit("Commit ten - ghost merge", rev_id="b@u-0-6")
85
86
    
86
87
    return br1, br2
123
124
                result = sorted(branch.repository.get_ancestry(rev_id))
124
125
                self.assertEquals(result, [None] + sorted(anc))
125
126
    
126
 
    
127
 
    def test_is_ancestor(self):
128
 
        """Test checking whether a revision is an ancestor of another revision"""
129
 
        br1, br2 = make_branches(self)
130
 
        revisions = br1.revision_history()
131
 
        revisions_2 = br2.revision_history()
132
 
        sources = br1
133
 
 
134
 
        self.assert_(is_ancestor(revisions[0], revisions[0], br1))
135
 
        self.assert_(is_ancestor(revisions[1], revisions[0], sources))
136
 
        self.assert_(not is_ancestor(revisions[0], revisions[1], sources))
137
 
        self.assert_(is_ancestor(revisions_2[3], revisions[0], sources))
138
 
        # disabled mbp 20050914, doesn't seem to happen anymore
139
 
        ## self.assertRaises(NoSuchRevision, is_ancestor, revisions_2[3],
140
 
        ##                  revisions[0], br1)        
141
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], sources))
142
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], br1))
143
 
        self.assert_(is_ancestor(revisions[3], revisions_2[3], sources))
144
 
        ## self.assert_(not is_ancestor(revisions[3], revisions_2[3], br1))
145
 
 
146
127
 
147
128
class TestIntermediateRevisions(TestCaseWithTransport):
148
129
 
155
136
        wt2.commit("Commit twelve", rev_id="b@u-0-8")
156
137
        wt2.commit("Commit thirtteen", rev_id="b@u-0-9")
157
138
 
158
 
        self.br1.fetch(self.br2)
159
 
        wt1.add_pending_merge(self.br2.revision_history()[6])
 
139
        wt1.merge_from_branch(self.br2)
160
140
        wt1.commit("Commit fourtten", rev_id="a@u-0-6")
161
141
 
162
 
        self.br2.fetch(self.br1)
163
 
        wt2.add_pending_merge(self.br1.revision_history()[6])
 
142
        wt2.merge_from_branch(self.br1)
164
143
        wt2.commit("Commit fifteen", rev_id="b@u-0-10")
165
144
 
166
 
        from bzrlib.revision import MultipleRevisionSources
167
 
        self.sources = MultipleRevisionSources(self.br1.repository,
168
 
                                               self.br2.repository)
169
 
 
170
 
 
171
145
 
172
146
class MockRevisionSource(object):
173
147
    """A RevisionSource that takes a pregenerated graph.
187
161
class TestCommonAncestor(TestCaseWithTransport):
188
162
    """Test checking whether a revision is an ancestor of another revision"""
189
163
 
190
 
    def test_common_ancestor(self):
191
 
        """Pick a reasonable merge base"""
192
 
        br1, br2 = make_branches(self)
193
 
        revisions = br1.revision_history()
194
 
        revisions_2 = br2.revision_history()
195
 
        sources = MultipleRevisionSources(br1.repository, br2.repository)
196
 
        expected_ancestors_list = {revisions[3]:(0, 0), 
197
 
                                   revisions[2]:(1, 1),
198
 
                                   revisions_2[4]:(2, 1), 
199
 
                                   revisions[1]:(3, 2),
200
 
                                   revisions_2[3]:(4, 2),
201
 
                                   revisions[0]:(5, 3) }
202
 
        ancestors_list = find_present_ancestors(revisions[3], sources)
203
 
        self.assertEquals(len(expected_ancestors_list), len(ancestors_list))
204
 
        for key, value in expected_ancestors_list.iteritems():
205
 
            self.assertEqual(ancestors_list[key], value, 
206
 
                              "key %r, %r != %r" % (key, ancestors_list[key],
207
 
                                                    value))
208
 
        self.assertEqual(common_ancestor(revisions[0], revisions[0], sources),
209
 
                          revisions[0])
210
 
        self.assertEqual(common_ancestor(revisions[1], revisions[2], sources),
211
 
                          revisions[1])
212
 
        self.assertEqual(common_ancestor(revisions[1], revisions[1], sources),
213
 
                          revisions[1])
214
 
        self.assertEqual(common_ancestor(revisions[2], revisions_2[4], sources),
215
 
                          revisions[2])
216
 
        self.assertEqual(common_ancestor(revisions[3], revisions_2[4], sources),
217
 
                          revisions_2[4])
218
 
        self.assertEqual(common_ancestor(revisions[4], revisions_2[5], sources),
219
 
                          revisions_2[4])
220
 
        self.assertTrue(common_ancestor(revisions[5], revisions_2[6], sources) in
221
 
                        (revisions[4], revisions_2[5]))
222
 
        self.assertTrue(common_ancestor(revisions_2[6], revisions[5], sources),
223
 
                        (revisions[4], revisions_2[5]))
224
 
        self.assertEqual(None, common_ancestor(None, revisions[5], sources))
225
 
        self.assertEqual(NULL_REVISION,
226
 
            common_ancestor(NULL_REVISION, NULL_REVISION, sources))
227
 
        self.assertEqual(NULL_REVISION,
228
 
            common_ancestor(revisions[0], NULL_REVISION, sources))
229
 
        self.assertEqual(NULL_REVISION,
230
 
            common_ancestor(NULL_REVISION, revisions[0], sources))
231
 
 
232
 
    def test_combined(self):
233
 
        """combined_graph
234
 
        Ensure it's not order-sensitive
235
 
        """
236
 
        br1, br2 = make_branches(self)
237
 
        source = MultipleRevisionSources(br1.repository, br2.repository)
238
 
        combined_1 = combined_graph(br1.last_revision(), 
239
 
                                    br2.last_revision(), source)
240
 
        combined_2 = combined_graph(br2.last_revision(),
241
 
                                    br1.last_revision(), source)
242
 
        self.assertEquals(combined_1[1], combined_2[1])
243
 
        self.assertEquals(combined_1[2], combined_2[2])
244
 
        self.assertEquals(combined_1[3], combined_2[3])
245
 
        self.assertEquals(combined_1, combined_2)
246
 
 
247
164
    def test_get_history(self):
248
165
        # TODO: test ghosts on the left hand branch's impact
249
166
        # TODO: test ghosts on all parents, we should get some
263
180
        history = rev.get_history(tree.branch.repository)
264
181
        self.assertEqual([None, '1', '2' ,'3'], history)
265
182
 
266
 
    def test_common_ancestor_rootless_graph(self):
267
 
        # common_ancestor on a graph with no reachable roots - only
268
 
        # ghosts - should still return a useful value.
269
 
        graph = Graph()
270
 
        # add a ghost node which would be a root if it wasn't a ghost.
271
 
        graph.add_ghost('a_ghost')
272
 
        # add a normal commit on top of that
273
 
        graph.add_node('rev1', ['a_ghost'])
274
 
        # add a left-branch revision
275
 
        graph.add_node('left', ['rev1'])
276
 
        # add a right-branch revision
277
 
        graph.add_node('right', ['rev1'])
278
 
        source = MockRevisionSource(graph)
279
 
        self.assertEqual('rev1', common_ancestor('left', 'right', source))
280
 
 
281
 
 
282
 
class TestMultipleRevisionSources(TestCaseWithTransport):
283
 
    """Tests for the MultipleRevisionSources adapter."""
284
 
 
285
 
    def test_get_revision_graph_merges_ghosts(self):
286
 
        # when we ask for the revision graph for B, which
287
 
        # is in repo 1 with a ghost of A, and which is not
288
 
        # in repo 2, which has A, the revision_graph()
289
 
        # should return A and B both.
290
 
        tree_1 = self.make_branch_and_tree('1')
291
 
        tree_1.add_pending_merge('A')
292
 
        tree_1.commit('foo', rev_id='B', allow_pointless=True)
293
 
        tree_2 = self.make_branch_and_tree('2')
294
 
        tree_2.commit('bar', rev_id='A', allow_pointless=True)
295
 
        source = MultipleRevisionSources(tree_1.branch.repository,
296
 
                                         tree_2.branch.repository)
297
 
        self.assertEqual({'B':['A'],
298
 
                          'A':[]},
299
 
                         source.get_revision_graph('B'))
 
183
 
 
184
class TestReservedId(TestCase):
 
185
 
 
186
    def test_is_reserved_id(self):
 
187
        self.assertEqual(True, revision.is_reserved_id(NULL_REVISION))
 
188
        self.assertEqual(True, revision.is_reserved_id(
 
189
            revision.CURRENT_REVISION))
 
190
        self.assertEqual(True, revision.is_reserved_id('arch:'))
 
191
        self.assertEqual(False, revision.is_reserved_id('null'))
 
192
        self.assertEqual(False, revision.is_reserved_id(
 
193
            'arch:a@example.com/c--b--v--r'))
 
194
        self.assertEqual(False, revision.is_reserved_id(None))
 
195
 
 
196
 
 
197
class TestRevisionMethods(TestCase):
 
198
 
 
199
    def test_get_summary(self):
 
200
        r = revision.Revision('1')
 
201
        r.message = 'a'
 
202
        self.assertEqual('a', r.get_summary())
 
203
        r.message = 'a\nb'
 
204
        self.assertEqual('a', r.get_summary())
 
205
        r.message = '\na\nb'
 
206
        self.assertEqual('a', r.get_summary())
 
207
 
 
208
    def test_get_apparent_author(self):
 
209
        r = revision.Revision('1')
 
210
        r.committer = 'A'
 
211
        self.assertEqual('A', r.get_apparent_author())
 
212
        r.properties['author'] = 'B'
 
213
        self.assertEqual('B', r.get_apparent_author())