~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_branch.py

  • Committer: John Arbash Meinel
  • Date: 2008-07-17 03:46:13 UTC
  • mto: This revision was merged to the branch mainline in revision 3557.
  • Revision ID: john@arbash-meinel.com-20080717034613-3cqwmu9mfshqwyet
Some code cleanups.

Remove extra comments.
Use 64 bit integer math when possible.
Use PyList_Append rather than foo.append()
Use PyUnicode_AsUTF8String rather than codecs.encode()
Make sure to raise an exception if the target directory doesn't exist.
Seems to have made a significant performance impact.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2010 Canonical Ltd
 
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
"""Tests for the Branch facility that are not interface  tests.
18
18
 
19
 
For interface tests see tests/per_branch/*.py.
 
19
For interface tests see tests/branch_implementations/*.py.
20
20
 
21
21
For concrete class tests see this file, and for meta-branch tests
22
22
also see this file.
23
23
"""
24
24
 
25
 
from cStringIO import StringIO
 
25
from StringIO import StringIO
26
26
 
27
27
from bzrlib import (
28
28
    branch as _mod_branch,
29
29
    bzrdir,
30
30
    config,
31
31
    errors,
32
 
    tests,
33
32
    trace,
34
 
    transport,
35
33
    urlutils,
36
34
    )
37
 
 
38
 
 
39
 
class TestDefaultFormat(tests.TestCase):
 
35
from bzrlib.branch import (
 
36
    Branch,
 
37
    BranchHooks,
 
38
    BranchFormat,
 
39
    BranchReferenceFormat,
 
40
    BzrBranch5,
 
41
    BzrBranchFormat5,
 
42
    BzrBranchFormat6,
 
43
    PullResult,
 
44
    )
 
45
from bzrlib.bzrdir import (BzrDirMetaFormat1, BzrDirMeta1, 
 
46
                           BzrDir, BzrDirFormat)
 
47
from bzrlib.errors import (NotBranchError,
 
48
                           UnknownFormatError,
 
49
                           UnknownHook,
 
50
                           UnsupportedFormatError,
 
51
                           )
 
52
 
 
53
from bzrlib.tests import TestCase, TestCaseWithTransport
 
54
from bzrlib.transport import get_transport
 
55
 
 
56
 
 
57
class TestDefaultFormat(TestCase):
40
58
 
41
59
    def test_default_format(self):
42
60
        # update this if you change the default branch format
43
 
        self.assertIsInstance(_mod_branch.BranchFormat.get_default_format(),
44
 
                _mod_branch.BzrBranchFormat7)
 
61
        self.assertIsInstance(BranchFormat.get_default_format(),
 
62
                BzrBranchFormat6)
45
63
 
46
64
    def test_default_format_is_same_as_bzrdir_default(self):
47
65
        # XXX: it might be nice if there was only one place the default was
48
 
        # set, but at the moment that's not true -- mbp 20070814 --
 
66
        # set, but at the moment that's not true -- mbp 20070814 -- 
49
67
        # https://bugs.launchpad.net/bzr/+bug/132376
50
 
        self.assertEqual(
51
 
            _mod_branch.BranchFormat.get_default_format(),
52
 
            bzrdir.BzrDirFormat.get_default_format().get_branch_format())
 
68
        self.assertEqual(BranchFormat.get_default_format(),
 
69
                BzrDirFormat.get_default_format().get_branch_format())
53
70
 
54
71
    def test_get_set_default_format(self):
55
72
        # set the format and then set it back again
56
 
        old_format = _mod_branch.BranchFormat.get_default_format()
57
 
        _mod_branch.BranchFormat.set_default_format(SampleBranchFormat())
 
73
        old_format = BranchFormat.get_default_format()
 
74
        BranchFormat.set_default_format(SampleBranchFormat())
58
75
        try:
59
76
            # the default branch format is used by the meta dir format
60
77
            # which is not the default bzrdir format at this point
61
 
            dir = bzrdir.BzrDirMetaFormat1().initialize('memory:///')
 
78
            dir = BzrDirMetaFormat1().initialize('memory:///')
62
79
            result = dir.create_branch()
63
80
            self.assertEqual(result, 'A branch')
64
81
        finally:
65
 
            _mod_branch.BranchFormat.set_default_format(old_format)
66
 
        self.assertEqual(old_format,
67
 
                         _mod_branch.BranchFormat.get_default_format())
68
 
 
69
 
 
70
 
class TestBranchFormat5(tests.TestCaseWithTransport):
 
82
            BranchFormat.set_default_format(old_format)
 
83
        self.assertEqual(old_format, BranchFormat.get_default_format())
 
84
 
 
85
 
 
86
class TestBranchFormat5(TestCaseWithTransport):
71
87
    """Tests specific to branch format 5"""
72
88
 
73
89
    def test_branch_format_5_uses_lockdir(self):
74
90
        url = self.get_url()
75
 
        bdir = bzrdir.BzrDirMetaFormat1().initialize(url)
76
 
        bdir.create_repository()
77
 
        branch = bdir.create_branch()
 
91
        bzrdir = BzrDirMetaFormat1().initialize(url)
 
92
        bzrdir.create_repository()
 
93
        branch = bzrdir.create_branch()
78
94
        t = self.get_transport()
79
95
        self.log("branch instance is %r" % branch)
80
 
        self.assert_(isinstance(branch, _mod_branch.BzrBranch5))
 
96
        self.assert_(isinstance(branch, BzrBranch5))
81
97
        self.assertIsDirectory('.', t)
82
98
        self.assertIsDirectory('.bzr/branch', t)
83
99
        self.assertIsDirectory('.bzr/branch/lock', t)
84
100
        branch.lock_write()
85
 
        self.addCleanup(branch.unlock)
86
 
        self.assertIsDirectory('.bzr/branch/lock/held', t)
 
101
        try:
 
102
            self.assertIsDirectory('.bzr/branch/lock/held', t)
 
103
        finally:
 
104
            branch.unlock()
87
105
 
88
106
    def test_set_push_location(self):
89
107
        from bzrlib.config import (locations_config_filename,
112
130
    # recursive section - that is, it appends the branch name.
113
131
 
114
132
 
115
 
class SampleBranchFormat(_mod_branch.BranchFormat):
 
133
class SampleBranchFormat(BranchFormat):
116
134
    """A sample format
117
135
 
118
 
    this format is initializable, unsupported to aid in testing the
 
136
    this format is initializable, unsupported to aid in testing the 
119
137
    open and open_downlevel routines.
120
138
    """
121
139
 
123
141
        """See BzrBranchFormat.get_format_string()."""
124
142
        return "Sample branch format."
125
143
 
126
 
    def initialize(self, a_bzrdir, name=None):
 
144
    def initialize(self, a_bzrdir):
127
145
        """Format 4 branches cannot be created."""
128
 
        t = a_bzrdir.get_branch_transport(self, name=name)
 
146
        t = a_bzrdir.get_branch_transport(self)
129
147
        t.put_bytes('format', self.get_format_string())
130
148
        return 'A branch'
131
149
 
132
150
    def is_supported(self):
133
151
        return False
134
152
 
135
 
    def open(self, transport, name=None, _found=False, ignore_fallbacks=False):
 
153
    def open(self, transport, _found=False):
136
154
        return "opened branch."
137
155
 
138
156
 
139
 
class TestBzrBranchFormat(tests.TestCaseWithTransport):
 
157
class TestBzrBranchFormat(TestCaseWithTransport):
140
158
    """Tests for the BzrBranchFormat facility."""
141
159
 
142
160
    def test_find_format(self):
143
161
        # is the right format object found for a branch?
144
162
        # create a branch with a few known format objects.
145
 
        # this is not quite the same as
 
163
        # this is not quite the same as 
146
164
        self.build_tree(["foo/", "bar/"])
147
165
        def check_format(format, url):
148
166
            dir = format._matchingbzrdir.initialize(url)
149
167
            dir.create_repository()
150
168
            format.initialize(dir)
151
 
            found_format = _mod_branch.BranchFormat.find_format(dir)
 
169
            found_format = BranchFormat.find_format(dir)
152
170
            self.failUnless(isinstance(found_format, format.__class__))
153
 
        check_format(_mod_branch.BzrBranchFormat5(), "bar")
154
 
 
 
171
        check_format(BzrBranchFormat5(), "bar")
 
172
        
155
173
    def test_find_format_not_branch(self):
156
174
        dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
157
 
        self.assertRaises(errors.NotBranchError,
158
 
                          _mod_branch.BranchFormat.find_format,
 
175
        self.assertRaises(NotBranchError,
 
176
                          BranchFormat.find_format,
159
177
                          dir)
160
178
 
161
179
    def test_find_format_unknown_format(self):
162
180
        dir = bzrdir.BzrDirMetaFormat1().initialize(self.get_url())
163
181
        SampleBranchFormat().initialize(dir)
164
 
        self.assertRaises(errors.UnknownFormatError,
165
 
                          _mod_branch.BranchFormat.find_format,
 
182
        self.assertRaises(UnknownFormatError,
 
183
                          BranchFormat.find_format,
166
184
                          dir)
167
185
 
168
186
    def test_register_unregister_format(self):
172
190
        # make a branch
173
191
        format.initialize(dir)
174
192
        # register a format for it.
175
 
        _mod_branch.BranchFormat.register_format(format)
 
193
        BranchFormat.register_format(format)
176
194
        # which branch.Open will refuse (not supported)
177
 
        self.assertRaises(errors.UnsupportedFormatError,
178
 
                          _mod_branch.Branch.open, self.get_url())
 
195
        self.assertRaises(UnsupportedFormatError, Branch.open, self.get_url())
179
196
        self.make_branch_and_tree('foo')
180
197
        # but open_downlevel will work
181
 
        self.assertEqual(
182
 
            format.open(dir),
183
 
            bzrdir.BzrDir.open(self.get_url()).open_branch(unsupported=True))
 
198
        self.assertEqual(format.open(dir), bzrdir.BzrDir.open(self.get_url()).open_branch(unsupported=True))
184
199
        # unregister the format
185
 
        _mod_branch.BranchFormat.unregister_format(format)
 
200
        BranchFormat.unregister_format(format)
186
201
        self.make_branch_and_tree('bar')
187
202
 
188
203
 
189
 
class TestBranch67(object):
190
 
    """Common tests for both branch 6 and 7 which are mostly the same."""
191
 
 
192
 
    def get_format_name(self):
193
 
        raise NotImplementedError(self.get_format_name)
194
 
 
195
 
    def get_format_name_subtree(self):
196
 
        raise NotImplementedError(self.get_format_name)
197
 
 
198
 
    def get_class(self):
199
 
        raise NotImplementedError(self.get_class)
 
204
class TestBranch6(TestCaseWithTransport):
200
205
 
201
206
    def test_creation(self):
202
 
        format = bzrdir.BzrDirMetaFormat1()
 
207
        format = BzrDirMetaFormat1()
203
208
        format.set_branch_format(_mod_branch.BzrBranchFormat6())
204
209
        branch = self.make_branch('a', format=format)
205
 
        self.assertIsInstance(branch, self.get_class())
206
 
        branch = self.make_branch('b', format=self.get_format_name())
207
 
        self.assertIsInstance(branch, self.get_class())
 
210
        self.assertIsInstance(branch, _mod_branch.BzrBranch6)
 
211
        branch = self.make_branch('b', format='dirstate-tags')
 
212
        self.assertIsInstance(branch, _mod_branch.BzrBranch6)
208
213
        branch = _mod_branch.Branch.open('a')
209
 
        self.assertIsInstance(branch, self.get_class())
 
214
        self.assertIsInstance(branch, _mod_branch.BzrBranch6)
210
215
 
211
216
    def test_layout(self):
212
 
        branch = self.make_branch('a', format=self.get_format_name())
 
217
        branch = self.make_branch('a', format='dirstate-tags')
213
218
        self.failUnlessExists('a/.bzr/branch/last-revision')
214
219
        self.failIfExists('a/.bzr/branch/revision-history')
215
 
        self.failIfExists('a/.bzr/branch/references')
216
220
 
217
221
    def test_config(self):
218
222
        """Ensure that all configuration data is stored in the branch"""
219
 
        branch = self.make_branch('a', format=self.get_format_name())
 
223
        branch = self.make_branch('a', format='dirstate-tags')
220
224
        branch.set_parent('http://bazaar-vcs.org')
221
225
        self.failIfExists('a/.bzr/branch/parent')
222
226
        self.assertEqual('http://bazaar-vcs.org', branch.get_parent())
229
233
        self.assertEqual('ftp://bazaar-vcs.org', branch.get_bound_location())
230
234
 
231
235
    def test_set_revision_history(self):
232
 
        builder = self.make_branch_builder('.', format=self.get_format_name())
233
 
        builder.build_snapshot('foo', None,
234
 
            [('add', ('', None, 'directory', None))],
235
 
            message='foo')
236
 
        builder.build_snapshot('bar', None, [], message='bar')
237
 
        branch = builder.get_branch()
238
 
        branch.lock_write()
239
 
        self.addCleanup(branch.unlock)
240
 
        branch.set_revision_history(['foo', 'bar'])
241
 
        branch.set_revision_history(['foo'])
242
 
        self.assertRaises(errors.NotLefthandHistory,
243
 
                          branch.set_revision_history, ['bar'])
 
236
        tree = self.make_branch_and_memory_tree('.',
 
237
            format='dirstate-tags')
 
238
        tree.lock_write()
 
239
        try:
 
240
            tree.add('.')
 
241
            tree.commit('foo', rev_id='foo')
 
242
            tree.commit('bar', rev_id='bar')
 
243
            tree.branch.set_revision_history(['foo', 'bar'])
 
244
            tree.branch.set_revision_history(['foo'])
 
245
            self.assertRaises(errors.NotLefthandHistory,
 
246
                              tree.branch.set_revision_history, ['bar'])
 
247
        finally:
 
248
            tree.unlock()
244
249
 
245
250
    def do_checkout_test(self, lightweight=False):
246
 
        tree = self.make_branch_and_tree('source',
247
 
            format=self.get_format_name_subtree())
 
251
        tree = self.make_branch_and_tree('source', format='dirstate-with-subtree')
248
252
        subtree = self.make_branch_and_tree('source/subtree',
249
 
            format=self.get_format_name_subtree())
 
253
            format='dirstate-with-subtree')
250
254
        subsubtree = self.make_branch_and_tree('source/subtree/subsubtree',
251
 
            format=self.get_format_name_subtree())
 
255
            format='dirstate-with-subtree')
252
256
        self.build_tree(['source/subtree/file',
253
257
                         'source/subtree/subsubtree/file'])
254
258
        subsubtree.add('file')
276
280
        self.do_checkout_test(lightweight=True)
277
281
 
278
282
    def test_set_push(self):
279
 
        branch = self.make_branch('source', format=self.get_format_name())
 
283
        branch = self.make_branch('source', format='dirstate-tags')
280
284
        branch.get_config().set_user_option('push_location', 'old',
281
285
            store=config.STORE_LOCATION)
282
286
        warnings = []
292
296
                         'locations.conf')
293
297
 
294
298
 
295
 
class TestBranch6(TestBranch67, tests.TestCaseWithTransport):
296
 
 
297
 
    def get_class(self):
298
 
        return _mod_branch.BzrBranch6
299
 
 
300
 
    def get_format_name(self):
301
 
        return "dirstate-tags"
302
 
 
303
 
    def get_format_name_subtree(self):
304
 
        return "dirstate-with-subtree"
305
 
 
306
 
    def test_set_stacked_on_url_errors(self):
307
 
        branch = self.make_branch('a', format=self.get_format_name())
308
 
        self.assertRaises(errors.UnstackableBranchFormat,
309
 
            branch.set_stacked_on_url, None)
310
 
 
311
 
    def test_default_stacked_location(self):
312
 
        branch = self.make_branch('a', format=self.get_format_name())
313
 
        self.assertRaises(errors.UnstackableBranchFormat, branch.get_stacked_on_url)
314
 
 
315
 
 
316
 
class TestBranch7(TestBranch67, tests.TestCaseWithTransport):
317
 
 
318
 
    def get_class(self):
319
 
        return _mod_branch.BzrBranch7
320
 
 
321
 
    def get_format_name(self):
322
 
        return "1.9"
323
 
 
324
 
    def get_format_name_subtree(self):
325
 
        return "development-subtree"
326
 
 
327
 
    def test_set_stacked_on_url_unstackable_repo(self):
328
 
        repo = self.make_repository('a', format='dirstate-tags')
329
 
        control = repo.bzrdir
330
 
        branch = _mod_branch.BzrBranchFormat7().initialize(control)
331
 
        target = self.make_branch('b')
332
 
        self.assertRaises(errors.UnstackableRepositoryFormat,
333
 
            branch.set_stacked_on_url, target.base)
334
 
 
335
 
    def test_clone_stacked_on_unstackable_repo(self):
336
 
        repo = self.make_repository('a', format='dirstate-tags')
337
 
        control = repo.bzrdir
338
 
        branch = _mod_branch.BzrBranchFormat7().initialize(control)
339
 
        # Calling clone should not raise UnstackableRepositoryFormat.
340
 
        cloned_bzrdir = control.clone('cloned')
341
 
 
342
 
    def _test_default_stacked_location(self):
343
 
        branch = self.make_branch('a', format=self.get_format_name())
344
 
        self.assertRaises(errors.NotStacked, branch.get_stacked_on_url)
345
 
 
346
 
    def test_stack_and_unstack(self):
347
 
        branch = self.make_branch('a', format=self.get_format_name())
348
 
        target = self.make_branch_and_tree('b', format=self.get_format_name())
349
 
        branch.set_stacked_on_url(target.branch.base)
350
 
        self.assertEqual(target.branch.base, branch.get_stacked_on_url())
351
 
        revid = target.commit('foo')
352
 
        self.assertTrue(branch.repository.has_revision(revid))
353
 
        branch.set_stacked_on_url(None)
354
 
        self.assertRaises(errors.NotStacked, branch.get_stacked_on_url)
355
 
        self.assertFalse(branch.repository.has_revision(revid))
356
 
 
357
 
    def test_open_opens_stacked_reference(self):
358
 
        branch = self.make_branch('a', format=self.get_format_name())
359
 
        target = self.make_branch_and_tree('b', format=self.get_format_name())
360
 
        branch.set_stacked_on_url(target.branch.base)
361
 
        branch = branch.bzrdir.open_branch()
362
 
        revid = target.commit('foo')
363
 
        self.assertTrue(branch.repository.has_revision(revid))
364
 
 
365
 
 
366
 
class BzrBranch8(tests.TestCaseWithTransport):
367
 
 
368
 
    def make_branch(self, location, format=None):
369
 
        if format is None:
370
 
            format = bzrdir.format_registry.make_bzrdir('1.9')
371
 
            format.set_branch_format(_mod_branch.BzrBranchFormat8())
372
 
        return tests.TestCaseWithTransport.make_branch(
373
 
            self, location, format=format)
374
 
 
375
 
    def create_branch_with_reference(self):
376
 
        branch = self.make_branch('branch')
377
 
        branch._set_all_reference_info({'file-id': ('path', 'location')})
378
 
        return branch
379
 
 
380
 
    @staticmethod
381
 
    def instrument_branch(branch, gets):
382
 
        old_get = branch._transport.get
383
 
        def get(*args, **kwargs):
384
 
            gets.append((args, kwargs))
385
 
            return old_get(*args, **kwargs)
386
 
        branch._transport.get = get
387
 
 
388
 
    def test_reference_info_caching_read_locked(self):
389
 
        gets = []
390
 
        branch = self.create_branch_with_reference()
391
 
        branch.lock_read()
392
 
        self.addCleanup(branch.unlock)
393
 
        self.instrument_branch(branch, gets)
394
 
        branch.get_reference_info('file-id')
395
 
        branch.get_reference_info('file-id')
396
 
        self.assertEqual(1, len(gets))
397
 
 
398
 
    def test_reference_info_caching_read_unlocked(self):
399
 
        gets = []
400
 
        branch = self.create_branch_with_reference()
401
 
        self.instrument_branch(branch, gets)
402
 
        branch.get_reference_info('file-id')
403
 
        branch.get_reference_info('file-id')
404
 
        self.assertEqual(2, len(gets))
405
 
 
406
 
    def test_reference_info_caching_write_locked(self):
407
 
        gets = []
408
 
        branch = self.make_branch('branch')
409
 
        branch.lock_write()
410
 
        self.instrument_branch(branch, gets)
411
 
        self.addCleanup(branch.unlock)
412
 
        branch._set_all_reference_info({'file-id': ('path2', 'location2')})
413
 
        path, location = branch.get_reference_info('file-id')
414
 
        self.assertEqual(0, len(gets))
415
 
        self.assertEqual('path2', path)
416
 
        self.assertEqual('location2', location)
417
 
 
418
 
    def test_reference_info_caches_cleared(self):
419
 
        branch = self.make_branch('branch')
420
 
        branch.lock_write()
421
 
        branch.set_reference_info('file-id', 'path2', 'location2')
422
 
        branch.unlock()
423
 
        doppelganger = _mod_branch.Branch.open('branch')
424
 
        doppelganger.set_reference_info('file-id', 'path3', 'location3')
425
 
        self.assertEqual(('path3', 'location3'),
426
 
                         branch.get_reference_info('file-id'))
427
 
 
428
 
class TestBranchReference(tests.TestCaseWithTransport):
 
299
class TestBranchReference(TestCaseWithTransport):
429
300
    """Tests for the branch reference facility."""
430
301
 
431
302
    def test_create_open_reference(self):
432
303
        bzrdirformat = bzrdir.BzrDirMetaFormat1()
433
 
        t = transport.get_transport(self.get_url('.'))
 
304
        t = get_transport(self.get_url('.'))
434
305
        t.mkdir('repo')
435
306
        dir = bzrdirformat.initialize(self.get_url('repo'))
436
307
        dir.create_repository()
437
308
        target_branch = dir.create_branch()
438
309
        t.mkdir('branch')
439
310
        branch_dir = bzrdirformat.initialize(self.get_url('branch'))
440
 
        made_branch = _mod_branch.BranchReferenceFormat().initialize(
441
 
            branch_dir, target_branch=target_branch)
 
311
        made_branch = BranchReferenceFormat().initialize(branch_dir, target_branch)
442
312
        self.assertEqual(made_branch.base, target_branch.base)
443
313
        opened_branch = branch_dir.open_branch()
444
314
        self.assertEqual(opened_branch.base, target_branch.base)
455
325
            _mod_branch.BranchReferenceFormat().get_reference(checkout.bzrdir))
456
326
 
457
327
 
458
 
class TestHooks(tests.TestCaseWithTransport):
 
328
class TestHooks(TestCase):
459
329
 
460
330
    def test_constructor(self):
461
331
        """Check that creating a BranchHooks instance has the right defaults."""
462
 
        hooks = _mod_branch.BranchHooks()
 
332
        hooks = BranchHooks()
463
333
        self.assertTrue("set_rh" in hooks, "set_rh not in %s" % hooks)
464
334
        self.assertTrue("post_push" in hooks, "post_push not in %s" % hooks)
465
335
        self.assertTrue("post_commit" in hooks, "post_commit not in %s" % hooks)
466
336
        self.assertTrue("pre_commit" in hooks, "pre_commit not in %s" % hooks)
467
337
        self.assertTrue("post_pull" in hooks, "post_pull not in %s" % hooks)
468
 
        self.assertTrue("post_uncommit" in hooks,
469
 
                        "post_uncommit not in %s" % hooks)
 
338
        self.assertTrue("post_uncommit" in hooks, "post_uncommit not in %s" % hooks)
470
339
        self.assertTrue("post_change_branch_tip" in hooks,
471
340
                        "post_change_branch_tip not in %s" % hooks)
472
 
        self.assertTrue("post_branch_init" in hooks,
473
 
                        "post_branch_init not in %s" % hooks)
474
 
        self.assertTrue("post_switch" in hooks,
475
 
                        "post_switch not in %s" % hooks)
476
341
 
477
342
    def test_installed_hooks_are_BranchHooks(self):
478
343
        """The installed hooks object should be a BranchHooks."""
479
344
        # the installed hooks are saved in self._preserved_hooks.
480
 
        self.assertIsInstance(self._preserved_hooks[_mod_branch.Branch][1],
481
 
                              _mod_branch.BranchHooks)
482
 
 
483
 
    def test_post_branch_init_hook(self):
484
 
        calls = []
485
 
        _mod_branch.Branch.hooks.install_named_hook('post_branch_init',
486
 
            calls.append, None)
487
 
        self.assertLength(0, calls)
488
 
        branch = self.make_branch('a')
489
 
        self.assertLength(1, calls)
490
 
        params = calls[0]
491
 
        self.assertIsInstance(params, _mod_branch.BranchInitHookParams)
492
 
        self.assertTrue(hasattr(params, 'bzrdir'))
493
 
        self.assertTrue(hasattr(params, 'branch'))
494
 
 
495
 
    def test_post_switch_hook(self):
496
 
        from bzrlib import switch
497
 
        calls = []
498
 
        _mod_branch.Branch.hooks.install_named_hook('post_switch',
499
 
            calls.append, None)
500
 
        tree = self.make_branch_and_tree('branch-1')
501
 
        self.build_tree(['branch-1/file-1'])
502
 
        tree.add('file-1')
503
 
        tree.commit('rev1')
504
 
        to_branch = tree.bzrdir.sprout('branch-2').open_branch()
505
 
        self.build_tree(['branch-1/file-2'])
506
 
        tree.add('file-2')
507
 
        tree.remove('file-1')
508
 
        tree.commit('rev2')
509
 
        checkout = tree.branch.create_checkout('checkout')
510
 
        self.assertLength(0, calls)
511
 
        switch.switch(checkout.bzrdir, to_branch)
512
 
        self.assertLength(1, calls)
513
 
        params = calls[0]
514
 
        self.assertIsInstance(params, _mod_branch.SwitchHookParams)
515
 
        self.assertTrue(hasattr(params, 'to_branch'))
516
 
        self.assertTrue(hasattr(params, 'revision_id'))
517
 
 
518
 
 
519
 
class TestBranchOptions(tests.TestCaseWithTransport):
520
 
 
521
 
    def setUp(self):
522
 
        super(TestBranchOptions, self).setUp()
523
 
        self.branch = self.make_branch('.')
524
 
        self.config = self.branch.get_config()
525
 
 
526
 
    def check_append_revisions_only(self, expected_value, value=None):
527
 
        """Set append_revisions_only in config and check its interpretation."""
528
 
        if value is not None:
529
 
            self.config.set_user_option('append_revisions_only', value)
530
 
        self.assertEqual(expected_value,
531
 
                         self.branch._get_append_revisions_only())
532
 
 
533
 
    def test_valid_append_revisions_only(self):
534
 
        self.assertEquals(None,
535
 
                          self.config.get_user_option('append_revisions_only'))
536
 
        self.check_append_revisions_only(None)
537
 
        self.check_append_revisions_only(False, 'False')
538
 
        self.check_append_revisions_only(True, 'True')
539
 
        # The following values will cause compatibility problems on projects
540
 
        # using older bzr versions (<2.2) but are accepted
541
 
        self.check_append_revisions_only(False, 'false')
542
 
        self.check_append_revisions_only(True, 'true')
543
 
 
544
 
    def test_invalid_append_revisions_only(self):
545
 
        """Ensure warning is noted on invalid settings"""
546
 
        self.warnings = []
547
 
        def warning(*args):
548
 
            self.warnings.append(args[0] % args[1:])
549
 
        self.overrideAttr(trace, 'warning', warning)
550
 
        self.check_append_revisions_only(None, 'not-a-bool')
551
 
        self.assertLength(1, self.warnings)
552
 
        self.assertEqual(
553
 
            'Value "not-a-bool" is not a boolean for "append_revisions_only"',
554
 
            self.warnings[0])
555
 
 
556
 
 
557
 
class TestPullResult(tests.TestCase):
 
345
        self.assertIsInstance(self._preserved_hooks[_mod_branch.Branch], BranchHooks)
 
346
 
 
347
 
 
348
class TestPullResult(TestCase):
558
349
 
559
350
    def test_pull_result_to_int(self):
560
351
        # to support old code, the pull result can be used as an int
561
 
        r = _mod_branch.PullResult()
 
352
        r = PullResult()
562
353
        r.old_revno = 10
563
354
        r.new_revno = 20
564
355
        # this usage of results is not recommended for new code (because it
566
357
        # it's still supported
567
358
        a = "%d revisions pulled" % r
568
359
        self.assertEqual(a, "10 revisions pulled")
569
 
 
570
 
    def test_report_changed(self):
571
 
        r = _mod_branch.PullResult()
572
 
        r.old_revid = "old-revid"
573
 
        r.old_revno = 10
574
 
        r.new_revid = "new-revid"
575
 
        r.new_revno = 20
576
 
        f = StringIO()
577
 
        r.report(f)
578
 
        self.assertEqual("Now on revision 20.\n", f.getvalue())
579
 
 
580
 
    def test_report_unchanged(self):
581
 
        r = _mod_branch.PullResult()
582
 
        r.old_revid = "same-revid"
583
 
        r.new_revid = "same-revid"
584
 
        f = StringIO()
585
 
        r.report(f)
586
 
        self.assertEqual("No revisions to pull.\n", f.getvalue())
587
 
 
588
 
 
589
 
class _StubLockable(object):
590
 
    """Helper for TestRunWithWriteLockedTarget."""
591
 
 
592
 
    def __init__(self, calls, unlock_exc=None):
593
 
        self.calls = calls
594
 
        self.unlock_exc = unlock_exc
595
 
 
596
 
    def lock_write(self):
597
 
        self.calls.append('lock_write')
598
 
 
599
 
    def unlock(self):
600
 
        self.calls.append('unlock')
601
 
        if self.unlock_exc is not None:
602
 
            raise self.unlock_exc
603
 
 
604
 
 
605
 
class _ErrorFromCallable(Exception):
606
 
    """Helper for TestRunWithWriteLockedTarget."""
607
 
 
608
 
 
609
 
class _ErrorFromUnlock(Exception):
610
 
    """Helper for TestRunWithWriteLockedTarget."""
611
 
 
612
 
 
613
 
class TestRunWithWriteLockedTarget(tests.TestCase):
614
 
    """Tests for _run_with_write_locked_target."""
615
 
 
616
 
    def setUp(self):
617
 
        tests.TestCase.setUp(self)
618
 
        self._calls = []
619
 
 
620
 
    def func_that_returns_ok(self):
621
 
        self._calls.append('func called')
622
 
        return 'ok'
623
 
 
624
 
    def func_that_raises(self):
625
 
        self._calls.append('func called')
626
 
        raise _ErrorFromCallable()
627
 
 
628
 
    def test_success_unlocks(self):
629
 
        lockable = _StubLockable(self._calls)
630
 
        result = _mod_branch._run_with_write_locked_target(
631
 
            lockable, self.func_that_returns_ok)
632
 
        self.assertEqual('ok', result)
633
 
        self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
634
 
 
635
 
    def test_exception_unlocks_and_propagates(self):
636
 
        lockable = _StubLockable(self._calls)
637
 
        self.assertRaises(_ErrorFromCallable,
638
 
                          _mod_branch._run_with_write_locked_target,
639
 
                          lockable, self.func_that_raises)
640
 
        self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
641
 
 
642
 
    def test_callable_succeeds_but_error_during_unlock(self):
643
 
        lockable = _StubLockable(self._calls, unlock_exc=_ErrorFromUnlock())
644
 
        self.assertRaises(_ErrorFromUnlock,
645
 
                          _mod_branch._run_with_write_locked_target,
646
 
                          lockable, self.func_that_returns_ok)
647
 
        self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
648
 
 
649
 
    def test_error_during_unlock_does_not_mask_original_error(self):
650
 
        lockable = _StubLockable(self._calls, unlock_exc=_ErrorFromUnlock())
651
 
        self.assertRaises(_ErrorFromCallable,
652
 
                          _mod_branch._run_with_write_locked_target,
653
 
                          lockable, self.func_that_raises)
654
 
        self.assertEqual(['lock_write', 'func called', 'unlock'], self._calls)
655
 
 
656