~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Martin Albisetti
  • Date: 2008-05-04 18:15:17 UTC
  • mto: (3431.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 3432.
  • Revision ID: argentina@gmail.com-20080504181517-3kxwgf01sprjzje3
 * Added directory structure for docs en spanish
 * Added index file for docs in spanish

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd.
 
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
import difflib
18
18
import os
19
19
import re
20
 
import string
 
20
import shutil
21
21
import sys
22
22
 
23
23
from bzrlib.lazy_import import lazy_import
30
30
from bzrlib import (
31
31
    branch as _mod_branch,
32
32
    bzrdir,
33
 
    cmdline,
34
 
    cleanup,
 
33
    commands,
35
34
    errors,
36
35
    osutils,
37
36
    patiencediff,
38
37
    textfile,
39
38
    timestamp,
40
 
    views,
41
39
    )
42
 
 
43
 
from bzrlib.workingtree import WorkingTree
44
40
""")
45
41
 
46
 
from bzrlib.registry import (
47
 
    Registry,
48
 
    )
49
42
from bzrlib.symbol_versioning import (
50
 
    deprecated_function,
51
 
    deprecated_in,
52
 
    )
53
 
from bzrlib.trace import mutter, note, warning
54
 
 
55
 
 
56
 
class AtTemplate(string.Template):
57
 
    """Templating class that uses @ instead of $."""
58
 
 
59
 
    delimiter = '@'
 
43
        deprecated_function,
 
44
        one_zero,
 
45
        one_three
 
46
        )
 
47
from bzrlib.trace import mutter, warning
60
48
 
61
49
 
62
50
# TODO: Rather than building a changeset object, we should probably
91
79
    # both sequences are empty.
92
80
    if not oldlines and not newlines:
93
81
        return
94
 
 
 
82
    
95
83
    if allow_binary is False:
96
84
        textfile.check_text_lines(oldlines)
97
85
        textfile.check_text_lines(newlines)
112
100
        ud[2] = ud[2].replace('-1,0', '-0,0')
113
101
    elif not newlines:
114
102
        ud[2] = ud[2].replace('+1,0', '+0,0')
 
103
    # work around for difflib emitting random spaces after the label
 
104
    ud[0] = ud[0][:-2] + '\n'
 
105
    ud[1] = ud[1][:-2] + '\n'
115
106
 
116
107
    for line in ud:
117
108
        to_file.write(line)
184
175
 
185
176
        if not diff_opts:
186
177
            diff_opts = []
187
 
        if sys.platform == 'win32':
188
 
            # Popen doesn't do the proper encoding for external commands
189
 
            # Since we are dealing with an ANSI api, use mbcs encoding
190
 
            old_filename = old_filename.encode('mbcs')
191
 
            new_filename = new_filename.encode('mbcs')
192
178
        diffcmd = ['diff',
193
179
                   '--label', old_filename,
194
180
                   old_abspath,
217
203
            break
218
204
        else:
219
205
            diffcmd.append('-u')
220
 
 
 
206
                  
221
207
        if diff_opts:
222
208
            diffcmd.extend(diff_opts)
223
209
 
224
210
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
225
211
        out,err = pipe.communicate()
226
212
        rc = pipe.returncode
227
 
 
 
213
        
228
214
        # internal_diff() adds a trailing newline, add one here for consistency
229
215
        out += '\n'
230
216
        if rc == 2:
265
251
                msg = 'signal %d' % (-rc)
266
252
            else:
267
253
                msg = 'exit code %d' % rc
268
 
 
269
 
            raise errors.BzrError('external diff failed with %s; command: %r'
 
254
                
 
255
            raise errors.BzrError('external diff failed with %s; command: %r' 
270
256
                                  % (rc, diffcmd))
271
257
 
272
258
 
290
276
                        new_abspath, e)
291
277
 
292
278
 
293
 
@deprecated_function(deprecated_in((2, 2, 0)))
294
 
def get_trees_and_branches_to_diff(path_list, revision_specs, old_url, new_url,
295
 
                                   apply_view=True):
296
 
    """Get the trees and specific files to diff given a list of paths.
297
 
 
298
 
    This method works out the trees to be diff'ed and the files of
299
 
    interest within those trees.
300
 
 
301
 
    :param path_list:
302
 
        the list of arguments passed to the diff command
303
 
    :param revision_specs:
304
 
        Zero, one or two RevisionSpecs from the diff command line,
305
 
        saying what revisions to compare.
306
 
    :param old_url:
307
 
        The url of the old branch or tree. If None, the tree to use is
308
 
        taken from the first path, if any, or the current working tree.
309
 
    :param new_url:
310
 
        The url of the new branch or tree. If None, the tree to use is
311
 
        taken from the first path, if any, or the current working tree.
312
 
    :param apply_view:
313
 
        if True and a view is set, apply the view or check that the paths
314
 
        are within it
315
 
    :returns:
316
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
317
 
        specific_files, extra_trees) where extra_trees is a sequence of
318
 
        additional trees to search in for file-ids.  The trees and branches
319
 
        are not locked.
320
 
    """
321
 
    op = cleanup.OperationWithCleanups(get_trees_and_branches_to_diff_locked)
322
 
    return op.run_simple(path_list, revision_specs, old_url, new_url,
323
 
            op.add_cleanup, apply_view=apply_view)
 
279
@deprecated_function(one_zero)
 
280
def diff_cmd_helper(tree, specific_files, external_diff_options, 
 
281
                    old_revision_spec=None, new_revision_spec=None,
 
282
                    revision_specs=None,
 
283
                    old_label='a/', new_label='b/'):
 
284
    """Helper for cmd_diff.
 
285
 
 
286
    :param tree:
 
287
        A WorkingTree
 
288
 
 
289
    :param specific_files:
 
290
        The specific files to compare, or None
 
291
 
 
292
    :param external_diff_options:
 
293
        If non-None, run an external diff, and pass it these options
 
294
 
 
295
    :param old_revision_spec:
 
296
        If None, use basis tree as old revision, otherwise use the tree for
 
297
        the specified revision. 
 
298
 
 
299
    :param new_revision_spec:
 
300
        If None, use working tree as new revision, otherwise use the tree for
 
301
        the specified revision.
324
302
    
325
 
 
326
 
def get_trees_and_branches_to_diff_locked(
327
 
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
 
303
    :param revision_specs: 
 
304
        Zero, one or two RevisionSpecs from the command line, saying what revisions 
 
305
        to compare.  This can be passed as an alternative to the old_revision_spec 
 
306
        and new_revision_spec parameters.
 
307
 
 
308
    The more general form is show_diff_trees(), where the caller
 
309
    supplies any two trees.
 
310
    """
 
311
 
 
312
    # TODO: perhaps remove the old parameters old_revision_spec and
 
313
    # new_revision_spec, since this is only really for use from cmd_diff and
 
314
    # it now always passes through a sequence of revision_specs -- mbp
 
315
    # 20061221
 
316
 
 
317
    def spec_tree(spec):
 
318
        if tree:
 
319
            revision = spec.in_store(tree.branch)
 
320
        else:
 
321
            revision = spec.in_store(None)
 
322
        revision_id = revision.rev_id
 
323
        branch = revision.branch
 
324
        return branch.repository.revision_tree(revision_id)
 
325
 
 
326
    if revision_specs is not None:
 
327
        assert (old_revision_spec is None
 
328
                and new_revision_spec is None)
 
329
        if len(revision_specs) > 0:
 
330
            old_revision_spec = revision_specs[0]
 
331
        if len(revision_specs) > 1:
 
332
            new_revision_spec = revision_specs[1]
 
333
 
 
334
    if old_revision_spec is None:
 
335
        old_tree = tree.basis_tree()
 
336
    else:
 
337
        old_tree = spec_tree(old_revision_spec)
 
338
 
 
339
    if (new_revision_spec is None
 
340
        or new_revision_spec.spec is None):
 
341
        new_tree = tree
 
342
    else:
 
343
        new_tree = spec_tree(new_revision_spec)
 
344
 
 
345
    if new_tree is not tree:
 
346
        extra_trees = (tree,)
 
347
    else:
 
348
        extra_trees = None
 
349
 
 
350
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
 
351
                           external_diff_options,
 
352
                           old_label=old_label, new_label=new_label,
 
353
                           extra_trees=extra_trees)
 
354
 
 
355
 
 
356
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url):
328
357
    """Get the trees and specific files to diff given a list of paths.
329
358
 
330
359
    This method works out the trees to be diff'ed and the files of
341
370
    :param new_url:
342
371
        The url of the new branch or tree. If None, the tree to use is
343
372
        taken from the first path, if any, or the current working tree.
344
 
    :param add_cleanup:
345
 
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
346
 
        will register cleanups that must be run to unlock the trees, etc.
347
 
    :param apply_view:
348
 
        if True and a view is set, apply the view or check that the paths
349
 
        are within it
350
373
    :returns:
351
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
352
 
        specific_files, extra_trees) where extra_trees is a sequence of
353
 
        additional trees to search in for file-ids.  The trees and branches
354
 
        will be read-locked until the cleanups registered via the add_cleanup
355
 
        param are run.
 
374
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
 
375
        extra_trees is a sequence of additional trees to search in for
 
376
        file-ids.
356
377
    """
357
378
    # Get the old and new revision specs
358
379
    old_revision_spec = None
381
402
        default_location = path_list[0]
382
403
        other_paths = path_list[1:]
383
404
 
384
 
    def lock_tree_or_branch(wt, br):
385
 
        if wt is not None:
386
 
            wt.lock_read()
387
 
            add_cleanup(wt.unlock)
388
 
        elif br is not None:
389
 
            br.lock_read()
390
 
            add_cleanup(br.unlock)
391
 
 
392
405
    # Get the old location
393
406
    specific_files = []
394
407
    if old_url is None:
395
408
        old_url = default_location
396
409
    working_tree, branch, relpath = \
397
410
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
398
 
    lock_tree_or_branch(working_tree, branch)
399
411
    if consider_relpath and relpath != '':
400
 
        if working_tree is not None and apply_view:
401
 
            views.check_path_in_view(working_tree, relpath)
402
412
        specific_files.append(relpath)
403
413
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
404
 
    old_branch = branch
405
414
 
406
415
    # Get the new location
407
416
    if new_url is None:
409
418
    if new_url != old_url:
410
419
        working_tree, branch, relpath = \
411
420
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
412
 
        lock_tree_or_branch(working_tree, branch)
413
421
        if consider_relpath and relpath != '':
414
 
            if working_tree is not None and apply_view:
415
 
                views.check_path_in_view(working_tree, relpath)
416
422
            specific_files.append(relpath)
417
423
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
418
424
        basis_is_default=working_tree is None)
419
 
    new_branch = branch
420
425
 
421
426
    # Get the specific files (all files is None, no files is [])
422
427
    if make_paths_wt_relative and working_tree is not None:
423
 
        try:
424
 
            from bzrlib.builtins import safe_relpath_files
425
 
            other_paths = safe_relpath_files(working_tree, other_paths,
426
 
            apply_view=apply_view)
427
 
        except errors.FileInWrongBranch:
428
 
            raise errors.BzrCommandError("Files are in different branches")
 
428
        other_paths = _relative_paths_in_tree(working_tree, other_paths)
429
429
    specific_files.extend(other_paths)
430
430
    if len(specific_files) == 0:
431
431
        specific_files = None
432
 
        if (working_tree is not None and working_tree.supports_views()
433
 
            and apply_view):
434
 
            view_files = working_tree.views.lookup_view()
435
 
            if view_files:
436
 
                specific_files = view_files
437
 
                view_str = views.view_display_str(view_files)
438
 
                note("*** Ignoring files outside view. View is %s" % view_str)
439
432
 
440
433
    # Get extra trees that ought to be searched for file-ids
441
434
    extra_trees = None
442
435
    if working_tree is not None and working_tree not in (old_tree, new_tree):
443
436
        extra_trees = (working_tree,)
444
 
    return old_tree, new_tree, old_branch, new_branch, specific_files, extra_trees
 
437
    return old_tree, new_tree, specific_files, extra_trees
445
438
 
446
439
 
447
440
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
455
448
                return branch.basis_tree()
456
449
        else:
457
450
            return tree
458
 
    return spec.as_tree(branch)
 
451
    if not spec.needs_branch():
 
452
        branch = _mod_branch.Branch.open(spec.get_branch())
 
453
    revision_id = spec.as_revision_id(branch)
 
454
    return branch.repository.revision_tree(revision_id)
 
455
 
 
456
 
 
457
def _relative_paths_in_tree(tree, paths):
 
458
    """Get the relative paths within a working tree.
 
459
 
 
460
    Each path may be either an absolute path or a path relative to the
 
461
    current working directory.
 
462
    """
 
463
    result = []
 
464
    for filename in paths:
 
465
        try:
 
466
            result.append(tree.relpath(osutils.dereference_path(filename)))
 
467
        except errors.PathNotChild:
 
468
            raise errors.BzrCommandError("Files are in different branches")
 
469
    return result
459
470
 
460
471
 
461
472
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
463
474
                    old_label='a/', new_label='b/',
464
475
                    extra_trees=None,
465
476
                    path_encoding='utf8',
466
 
                    using=None,
467
 
                    format_cls=None):
 
477
                    using=None):
468
478
    """Show in text form the changes from one tree to another.
469
479
 
470
 
    :param to_file: The output stream.
471
 
    :param specific_files:Include only changes to these files - None for all
472
 
        changes.
473
 
    :param external_diff_options: If set, use an external GNU diff and pass 
474
 
        these options.
475
 
    :param extra_trees: If set, more Trees to use for looking up file ids
476
 
    :param path_encoding: If set, the path will be encoded as specified, 
477
 
        otherwise is supposed to be utf8
478
 
    :param format_cls: Formatter class (DiffTree subclass)
 
480
    to_file
 
481
        The output stream.
 
482
 
 
483
    specific_files
 
484
        Include only changes to these files - None for all changes.
 
485
 
 
486
    external_diff_options
 
487
        If set, use an external GNU diff and pass these options.
 
488
 
 
489
    extra_trees
 
490
        If set, more Trees to use for looking up file ids
 
491
 
 
492
    path_encoding
 
493
        If set, the path will be encoded as specified, otherwise is supposed
 
494
        to be utf8
479
495
    """
480
 
    if format_cls is None:
481
 
        format_cls = DiffTree
482
496
    old_tree.lock_read()
483
497
    try:
484
498
        if extra_trees is not None:
486
500
                tree.lock_read()
487
501
        new_tree.lock_read()
488
502
        try:
489
 
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
490
 
                                                   path_encoding,
491
 
                                                   external_diff_options,
492
 
                                                   old_label, new_label, using)
 
503
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
 
504
                                                 path_encoding,
 
505
                                                 external_diff_options,
 
506
                                                 old_label, new_label, using)
493
507
            return differ.show_diff(specific_files, extra_trees)
494
508
        finally:
495
509
            new_tree.unlock()
502
516
 
503
517
def _patch_header_date(tree, file_id, path):
504
518
    """Returns a timestamp suitable for use in a patch header."""
505
 
    try:
506
 
        mtime = tree.get_file_mtime(file_id, path)
507
 
    except errors.FileTimestampUnavailable:
508
 
        mtime = 0
 
519
    mtime = tree.get_file_mtime(file_id, path)
 
520
    assert mtime is not None, \
 
521
        "got an mtime of None for file-id %s, path %s in tree %s" % (
 
522
                file_id, path, tree)
509
523
    return timestamp.format_patch_date(mtime)
510
524
 
511
525
 
 
526
def _raise_if_nonexistent(paths, old_tree, new_tree):
 
527
    """Complain if paths are not in either inventory or tree.
 
528
 
 
529
    It's OK with the files exist in either tree's inventory, or 
 
530
    if they exist in the tree but are not versioned.
 
531
    
 
532
    This can be used by operations such as bzr status that can accept
 
533
    unknown or ignored files.
 
534
    """
 
535
    mutter("check paths: %r", paths)
 
536
    if not paths:
 
537
        return
 
538
    s = old_tree.filter_unversioned_files(paths)
 
539
    s = new_tree.filter_unversioned_files(s)
 
540
    s = [path for path in s if not new_tree.has_filename(path)]
 
541
    if s:
 
542
        raise errors.PathsDoNotExist(sorted(s))
 
543
 
 
544
 
 
545
@deprecated_function(one_three)
 
546
def get_prop_change(meta_modified):
 
547
    if meta_modified:
 
548
        return " (properties changed)"
 
549
    else:
 
550
        return  ""
 
551
 
512
552
def get_executable_change(old_is_x, new_is_x):
513
553
    descr = { True:"+x", False:"-x", None:"??" }
514
554
    if old_is_x != new_is_x:
689
729
            return self.CANNOT_DIFF
690
730
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
691
731
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
692
 
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
693
 
            old_path, new_path)
 
732
        return self.diff_text(from_file_id, to_file_id, from_label, to_label)
694
733
 
695
 
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
696
 
        from_path=None, to_path=None):
 
734
    def diff_text(self, from_file_id, to_file_id, from_label, to_label):
697
735
        """Diff the content of given files in two trees
698
736
 
699
737
        :param from_file_id: The id of the file in the from tree.  If None,
701
739
        :param to_file_id: The id of the file in the to tree.  This may refer
702
740
            to a different file from from_file_id.  If None,
703
741
            the file is not present in the to tree.
704
 
        :param from_path: The path in the from tree or None if unknown.
705
 
        :param to_path: The path in the to tree or None if unknown.
706
742
        """
707
 
        def _get_text(tree, file_id, path):
 
743
        def _get_text(tree, file_id):
708
744
            if file_id is not None:
709
 
                return tree.get_file(file_id, path).readlines()
 
745
                return tree.get_file(file_id).readlines()
710
746
            else:
711
747
                return []
712
748
        try:
713
 
            from_text = _get_text(self.old_tree, from_file_id, from_path)
714
 
            to_text = _get_text(self.new_tree, to_file_id, to_path)
 
749
            from_text = _get_text(self.old_tree, from_file_id)
 
750
            to_text = _get_text(self.new_tree, to_file_id)
715
751
            self.text_differ(from_label, from_text, to_label, to_text,
716
752
                             self.to_file)
717
753
        except errors.BinaryFile:
727
763
                 path_encoding='utf-8'):
728
764
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
729
765
        self.command_template = command_template
730
 
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
 
766
        self._root = tempfile.mkdtemp(prefix='bzr-diff-')
731
767
 
732
768
    @classmethod
733
769
    def from_string(klass, command_string, old_tree, new_tree, to_file,
734
770
                    path_encoding='utf-8'):
735
 
        command_template = cmdline.split(command_string)
736
 
        if '@' not in command_string:
737
 
            command_template.extend(['@old_path', '@new_path'])
 
771
        command_template = commands.shlex_split_unicode(command_string)
 
772
        command_template.extend(['%(old_path)s', '%(new_path)s'])
738
773
        return klass(command_template, old_tree, new_tree, to_file,
739
774
                     path_encoding)
740
775
 
747
782
 
748
783
    def _get_command(self, old_path, new_path):
749
784
        my_map = {'old_path': old_path, 'new_path': new_path}
750
 
        return [AtTemplate(t).substitute(my_map) for t in
751
 
                self.command_template]
 
785
        return [t % my_map for t in self.command_template]
752
786
 
753
787
    def _execute(self, old_path, new_path):
754
788
        command = self._get_command(old_path, new_path)
764
798
        return proc.wait()
765
799
 
766
800
    def _try_symlink_root(self, tree, prefix):
767
 
        if (getattr(tree, 'abspath', None) is None
768
 
            or not osutils.host_os_dereferences_symlinks()):
 
801
        if not (getattr(tree, 'abspath', None) is not None
 
802
                and osutils.has_symlinks()):
769
803
            return False
770
804
        try:
771
805
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
774
808
                raise
775
809
        return True
776
810
 
777
 
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
778
 
                    allow_write=False):
779
 
        if not force_temp and isinstance(tree, WorkingTree):
780
 
            return tree.abspath(tree.id2path(file_id))
781
 
        
 
811
    def _write_file(self, file_id, tree, prefix, relpath):
782
812
        full_path = osutils.pathjoin(self._root, prefix, relpath)
783
 
        if not force_temp and self._try_symlink_root(tree, prefix):
 
813
        if self._try_symlink_root(tree, prefix):
784
814
            return full_path
785
815
        parent_dir = osutils.dirname(full_path)
786
816
        try:
797
827
                target.close()
798
828
        finally:
799
829
            source.close()
800
 
        try:
801
 
            mtime = tree.get_file_mtime(file_id)
802
 
        except errors.FileTimestampUnavailable:
803
 
            pass
804
 
        else:
805
 
            os.utime(full_path, (mtime, mtime))
806
 
        if not allow_write:
807
 
            osutils.make_readonly(full_path)
 
830
        osutils.make_readonly(full_path)
 
831
        mtime = tree.get_file_mtime(file_id)
 
832
        os.utime(full_path, (mtime, mtime))
808
833
        return full_path
809
834
 
810
 
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
811
 
                       allow_write_new=False):
 
835
    def _prepare_files(self, file_id, old_path, new_path):
812
836
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
813
 
                                         old_path, force_temp)
 
837
                                         old_path)
814
838
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
815
 
                                         new_path, force_temp,
816
 
                                         allow_write=allow_write_new)
 
839
                                         new_path)
817
840
        return old_disk_path, new_disk_path
818
841
 
819
842
    def finish(self):
820
 
        try:
821
 
            osutils.rmtree(self._root)
822
 
        except OSError, e:
823
 
            if e.errno != errno.ENOENT:
824
 
                mutter("The temporary directory \"%s\" was not "
825
 
                        "cleanly removed: %s." % (self._root, e))
 
843
        osutils.rmtree(self._root)
826
844
 
827
845
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
828
846
        if (old_kind, new_kind) != ('file', 'file'):
829
847
            return DiffPath.CANNOT_DIFF
830
 
        (old_disk_path, new_disk_path) = self._prepare_files(
831
 
                                                file_id, old_path, new_path)
832
 
        self._execute(old_disk_path, new_disk_path)
833
 
 
834
 
    def edit_file(self, file_id):
835
 
        """Use this tool to edit a file.
836
 
 
837
 
        A temporary copy will be edited, and the new contents will be
838
 
        returned.
839
 
 
840
 
        :param file_id: The id of the file to edit.
841
 
        :return: The new contents of the file.
842
 
        """
843
 
        old_path = self.old_tree.id2path(file_id)
844
 
        new_path = self.new_tree.id2path(file_id)
845
 
        new_abs_path = self._prepare_files(file_id, old_path, new_path,
846
 
                                           allow_write_new=True,
847
 
                                           force_temp=True)[1]
848
 
        command = self._get_command(osutils.pathjoin('old', old_path),
849
 
                                    osutils.pathjoin('new', new_path))
850
 
        subprocess.call(command, cwd=self._root)
851
 
        new_file = open(new_abs_path, 'r')
852
 
        try:
853
 
            return new_file.read()
854
 
        finally:
855
 
            new_file.close()
 
848
        self._prepare_files(file_id, old_path, new_path)
 
849
        self._execute(osutils.pathjoin('old', old_path),
 
850
                      osutils.pathjoin('new', new_path))
856
851
 
857
852
 
858
853
class DiffTree(object):
919
914
        else:
920
915
            extra_factories = []
921
916
        if external_diff_options:
 
917
            assert isinstance(external_diff_options, basestring)
922
918
            opts = external_diff_options.split()
923
919
            def diff_file(olab, olines, nlab, nlines, to_file):
924
920
                external_diff(olab, olines, nlab, nlines, to_file, opts)
932
928
    def show_diff(self, specific_files, extra_trees=None):
933
929
        """Write tree diff to self.to_file
934
930
 
935
 
        :param specific_files: the specific files to compare (recursive)
 
931
        :param sepecific_files: the specific files to compare (recursive)
936
932
        :param extra_trees: extra trees to use for mapping paths to file_ids
937
933
        """
938
934
        try:
960
956
                return path.encode(self.path_encoding, "replace")
961
957
        for (file_id, paths, changed_content, versioned, parent, name, kind,
962
958
             executable) in sorted(iterator, key=changes_key):
963
 
            # The root does not get diffed, and items with no known kind (that
964
 
            # is, missing) in both trees are skipped as well.
965
 
            if parent == (None, None) or kind == (None, None):
 
959
            if parent == (None, None):
966
960
                continue
967
961
            oldpath, newpath = paths
968
962
            oldpath_encoded = get_encoded_path(paths[0])
996
990
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
997
991
                                   newpath_encoded, prop_str))
998
992
            if changed_content:
999
 
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
 
993
                self.diff(file_id, oldpath, newpath)
1000
994
                has_changes = 1
1001
995
            if renamed:
1002
996
                has_changes = 1
1017
1011
            new_kind = self.new_tree.kind(file_id)
1018
1012
        except (errors.NoSuchId, errors.NoSuchFile):
1019
1013
            new_kind = None
1020
 
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
1021
 
 
1022
 
 
1023
 
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
 
1014
 
1024
1015
        result = DiffPath._diff_many(self.differs, file_id, old_path,
1025
1016
                                       new_path, old_kind, new_kind)
1026
1017
        if result is DiffPath.CANNOT_DIFF:
1028
1019
            if error_path is None:
1029
1020
                error_path = old_path
1030
1021
            raise errors.NoDiffFound(error_path)
1031
 
 
1032
 
 
1033
 
format_registry = Registry()
1034
 
format_registry.register('default', DiffTree)