~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Martin Pool
  • Date: 2008-05-08 04:18:41 UTC
  • mto: This revision was merged to the branch mainline in revision 3415.
  • Revision ID: mbp@sourcefrog.net-20080508041841-6cv1owy6y1gukja5
Remove dead main method from test_patches

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd.
 
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
import difflib
18
18
import os
19
19
import re
20
 
import string
 
20
import shutil
21
21
import sys
22
22
 
23
23
from bzrlib.lazy_import import lazy_import
28
28
import time
29
29
 
30
30
from bzrlib import (
31
 
    branch as _mod_branch,
32
31
    bzrdir,
33
 
    cmdline,
34
 
    cleanup,
 
32
    commands,
35
33
    errors,
36
34
    osutils,
37
35
    patiencediff,
38
36
    textfile,
39
37
    timestamp,
40
 
    views,
41
38
    )
42
 
 
43
 
from bzrlib.workingtree import WorkingTree
44
39
""")
45
40
 
46
 
from bzrlib.registry import (
47
 
    Registry,
48
 
    )
49
41
from bzrlib.symbol_versioning import (
50
 
    deprecated_function,
51
 
    deprecated_in,
52
 
    )
53
 
from bzrlib.trace import mutter, note, warning
54
 
 
55
 
 
56
 
class AtTemplate(string.Template):
57
 
    """Templating class that uses @ instead of $."""
58
 
 
59
 
    delimiter = '@'
 
42
        deprecated_function,
 
43
        one_zero,
 
44
        one_three
 
45
        )
 
46
from bzrlib.trace import mutter, warning
60
47
 
61
48
 
62
49
# TODO: Rather than building a changeset object, we should probably
91
78
    # both sequences are empty.
92
79
    if not oldlines and not newlines:
93
80
        return
94
 
 
 
81
    
95
82
    if allow_binary is False:
96
83
        textfile.check_text_lines(oldlines)
97
84
        textfile.check_text_lines(newlines)
112
99
        ud[2] = ud[2].replace('-1,0', '-0,0')
113
100
    elif not newlines:
114
101
        ud[2] = ud[2].replace('+1,0', '+0,0')
 
102
    # work around for difflib emitting random spaces after the label
 
103
    ud[0] = ud[0][:-2] + '\n'
 
104
    ud[1] = ud[1][:-2] + '\n'
115
105
 
116
106
    for line in ud:
117
107
        to_file.write(line)
184
174
 
185
175
        if not diff_opts:
186
176
            diff_opts = []
187
 
        if sys.platform == 'win32':
188
 
            # Popen doesn't do the proper encoding for external commands
189
 
            # Since we are dealing with an ANSI api, use mbcs encoding
190
 
            old_filename = old_filename.encode('mbcs')
191
 
            new_filename = new_filename.encode('mbcs')
192
177
        diffcmd = ['diff',
193
178
                   '--label', old_filename,
194
179
                   old_abspath,
217
202
            break
218
203
        else:
219
204
            diffcmd.append('-u')
220
 
 
 
205
                  
221
206
        if diff_opts:
222
207
            diffcmd.extend(diff_opts)
223
208
 
224
209
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
225
210
        out,err = pipe.communicate()
226
211
        rc = pipe.returncode
227
 
 
 
212
        
228
213
        # internal_diff() adds a trailing newline, add one here for consistency
229
214
        out += '\n'
230
215
        if rc == 2:
265
250
                msg = 'signal %d' % (-rc)
266
251
            else:
267
252
                msg = 'exit code %d' % rc
268
 
 
269
 
            raise errors.BzrError('external diff failed with %s; command: %r'
 
253
                
 
254
            raise errors.BzrError('external diff failed with %s; command: %r' 
270
255
                                  % (rc, diffcmd))
271
256
 
272
257
 
290
275
                        new_abspath, e)
291
276
 
292
277
 
293
 
@deprecated_function(deprecated_in((2, 2, 0)))
294
 
def get_trees_and_branches_to_diff(path_list, revision_specs, old_url, new_url,
295
 
                                   apply_view=True):
296
 
    """Get the trees and specific files to diff given a list of paths.
297
 
 
298
 
    This method works out the trees to be diff'ed and the files of
299
 
    interest within those trees.
300
 
 
301
 
    :param path_list:
302
 
        the list of arguments passed to the diff command
303
 
    :param revision_specs:
304
 
        Zero, one or two RevisionSpecs from the diff command line,
305
 
        saying what revisions to compare.
306
 
    :param old_url:
307
 
        The url of the old branch or tree. If None, the tree to use is
308
 
        taken from the first path, if any, or the current working tree.
309
 
    :param new_url:
310
 
        The url of the new branch or tree. If None, the tree to use is
311
 
        taken from the first path, if any, or the current working tree.
312
 
    :param apply_view:
313
 
        if True and a view is set, apply the view or check that the paths
314
 
        are within it
315
 
    :returns:
316
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
317
 
        specific_files, extra_trees) where extra_trees is a sequence of
318
 
        additional trees to search in for file-ids.  The trees and branches
319
 
        are not locked.
320
 
    """
321
 
    op = cleanup.OperationWithCleanups(get_trees_and_branches_to_diff_locked)
322
 
    return op.run_simple(path_list, revision_specs, old_url, new_url,
323
 
            op.add_cleanup, apply_view=apply_view)
 
278
@deprecated_function(one_zero)
 
279
def diff_cmd_helper(tree, specific_files, external_diff_options, 
 
280
                    old_revision_spec=None, new_revision_spec=None,
 
281
                    revision_specs=None,
 
282
                    old_label='a/', new_label='b/'):
 
283
    """Helper for cmd_diff.
 
284
 
 
285
    :param tree:
 
286
        A WorkingTree
 
287
 
 
288
    :param specific_files:
 
289
        The specific files to compare, or None
 
290
 
 
291
    :param external_diff_options:
 
292
        If non-None, run an external diff, and pass it these options
 
293
 
 
294
    :param old_revision_spec:
 
295
        If None, use basis tree as old revision, otherwise use the tree for
 
296
        the specified revision. 
 
297
 
 
298
    :param new_revision_spec:
 
299
        If None, use working tree as new revision, otherwise use the tree for
 
300
        the specified revision.
324
301
    
325
 
 
326
 
def get_trees_and_branches_to_diff_locked(
327
 
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
 
302
    :param revision_specs: 
 
303
        Zero, one or two RevisionSpecs from the command line, saying what revisions 
 
304
        to compare.  This can be passed as an alternative to the old_revision_spec 
 
305
        and new_revision_spec parameters.
 
306
 
 
307
    The more general form is show_diff_trees(), where the caller
 
308
    supplies any two trees.
 
309
    """
 
310
 
 
311
    # TODO: perhaps remove the old parameters old_revision_spec and
 
312
    # new_revision_spec, since this is only really for use from cmd_diff and
 
313
    # it now always passes through a sequence of revision_specs -- mbp
 
314
    # 20061221
 
315
 
 
316
    def spec_tree(spec):
 
317
        if tree:
 
318
            revision = spec.in_store(tree.branch)
 
319
        else:
 
320
            revision = spec.in_store(None)
 
321
        revision_id = revision.rev_id
 
322
        branch = revision.branch
 
323
        return branch.repository.revision_tree(revision_id)
 
324
 
 
325
    if revision_specs is not None:
 
326
        if len(revision_specs) > 0:
 
327
            old_revision_spec = revision_specs[0]
 
328
        if len(revision_specs) > 1:
 
329
            new_revision_spec = revision_specs[1]
 
330
 
 
331
    if old_revision_spec is None:
 
332
        old_tree = tree.basis_tree()
 
333
    else:
 
334
        old_tree = spec_tree(old_revision_spec)
 
335
 
 
336
    if (new_revision_spec is None
 
337
        or new_revision_spec.spec is None):
 
338
        new_tree = tree
 
339
    else:
 
340
        new_tree = spec_tree(new_revision_spec)
 
341
 
 
342
    if new_tree is not tree:
 
343
        extra_trees = (tree,)
 
344
    else:
 
345
        extra_trees = None
 
346
 
 
347
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
 
348
                           external_diff_options,
 
349
                           old_label=old_label, new_label=new_label,
 
350
                           extra_trees=extra_trees)
 
351
 
 
352
 
 
353
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url):
328
354
    """Get the trees and specific files to diff given a list of paths.
329
355
 
330
356
    This method works out the trees to be diff'ed and the files of
341
367
    :param new_url:
342
368
        The url of the new branch or tree. If None, the tree to use is
343
369
        taken from the first path, if any, or the current working tree.
344
 
    :param add_cleanup:
345
 
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
346
 
        will register cleanups that must be run to unlock the trees, etc.
347
 
    :param apply_view:
348
 
        if True and a view is set, apply the view or check that the paths
349
 
        are within it
350
370
    :returns:
351
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
352
 
        specific_files, extra_trees) where extra_trees is a sequence of
353
 
        additional trees to search in for file-ids.  The trees and branches
354
 
        will be read-locked until the cleanups registered via the add_cleanup
355
 
        param are run.
 
371
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
 
372
        extra_trees is a sequence of additional trees to search in for
 
373
        file-ids.
356
374
    """
357
375
    # Get the old and new revision specs
358
376
    old_revision_spec = None
381
399
        default_location = path_list[0]
382
400
        other_paths = path_list[1:]
383
401
 
384
 
    def lock_tree_or_branch(wt, br):
385
 
        if wt is not None:
386
 
            wt.lock_read()
387
 
            add_cleanup(wt.unlock)
388
 
        elif br is not None:
389
 
            br.lock_read()
390
 
            add_cleanup(br.unlock)
391
 
 
392
402
    # Get the old location
393
403
    specific_files = []
394
404
    if old_url is None:
395
405
        old_url = default_location
396
406
    working_tree, branch, relpath = \
397
407
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
398
 
    lock_tree_or_branch(working_tree, branch)
399
408
    if consider_relpath and relpath != '':
400
 
        if working_tree is not None and apply_view:
401
 
            views.check_path_in_view(working_tree, relpath)
402
409
        specific_files.append(relpath)
403
410
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
404
 
    old_branch = branch
405
411
 
406
412
    # Get the new location
407
413
    if new_url is None:
409
415
    if new_url != old_url:
410
416
        working_tree, branch, relpath = \
411
417
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
412
 
        lock_tree_or_branch(working_tree, branch)
413
418
        if consider_relpath and relpath != '':
414
 
            if working_tree is not None and apply_view:
415
 
                views.check_path_in_view(working_tree, relpath)
416
419
            specific_files.append(relpath)
417
420
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
418
421
        basis_is_default=working_tree is None)
419
 
    new_branch = branch
420
422
 
421
423
    # Get the specific files (all files is None, no files is [])
422
424
    if make_paths_wt_relative and working_tree is not None:
423
 
        try:
424
 
            from bzrlib.builtins import safe_relpath_files
425
 
            other_paths = safe_relpath_files(working_tree, other_paths,
426
 
            apply_view=apply_view)
427
 
        except errors.FileInWrongBranch:
428
 
            raise errors.BzrCommandError("Files are in different branches")
 
425
        other_paths = _relative_paths_in_tree(working_tree, other_paths)
429
426
    specific_files.extend(other_paths)
430
427
    if len(specific_files) == 0:
431
428
        specific_files = None
432
 
        if (working_tree is not None and working_tree.supports_views()
433
 
            and apply_view):
434
 
            view_files = working_tree.views.lookup_view()
435
 
            if view_files:
436
 
                specific_files = view_files
437
 
                view_str = views.view_display_str(view_files)
438
 
                note("*** Ignoring files outside view. View is %s" % view_str)
439
429
 
440
430
    # Get extra trees that ought to be searched for file-ids
441
431
    extra_trees = None
442
432
    if working_tree is not None and working_tree not in (old_tree, new_tree):
443
433
        extra_trees = (working_tree,)
444
 
    return old_tree, new_tree, old_branch, new_branch, specific_files, extra_trees
 
434
    return old_tree, new_tree, specific_files, extra_trees
445
435
 
446
436
 
447
437
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
455
445
                return branch.basis_tree()
456
446
        else:
457
447
            return tree
458
 
    return spec.as_tree(branch)
 
448
    revision = spec.in_store(branch)
 
449
    revision_id = revision.rev_id
 
450
    rev_branch = revision.branch
 
451
    return rev_branch.repository.revision_tree(revision_id)
 
452
 
 
453
 
 
454
def _relative_paths_in_tree(tree, paths):
 
455
    """Get the relative paths within a working tree.
 
456
 
 
457
    Each path may be either an absolute path or a path relative to the
 
458
    current working directory.
 
459
    """
 
460
    result = []
 
461
    for filename in paths:
 
462
        try:
 
463
            result.append(tree.relpath(osutils.dereference_path(filename)))
 
464
        except errors.PathNotChild:
 
465
            raise errors.BzrCommandError("Files are in different branches")
 
466
    return result
459
467
 
460
468
 
461
469
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
463
471
                    old_label='a/', new_label='b/',
464
472
                    extra_trees=None,
465
473
                    path_encoding='utf8',
466
 
                    using=None,
467
 
                    format_cls=None):
 
474
                    using=None):
468
475
    """Show in text form the changes from one tree to another.
469
476
 
470
 
    :param to_file: The output stream.
471
 
    :param specific_files:Include only changes to these files - None for all
472
 
        changes.
473
 
    :param external_diff_options: If set, use an external GNU diff and pass 
474
 
        these options.
475
 
    :param extra_trees: If set, more Trees to use for looking up file ids
476
 
    :param path_encoding: If set, the path will be encoded as specified, 
477
 
        otherwise is supposed to be utf8
478
 
    :param format_cls: Formatter class (DiffTree subclass)
 
477
    to_file
 
478
        The output stream.
 
479
 
 
480
    specific_files
 
481
        Include only changes to these files - None for all changes.
 
482
 
 
483
    external_diff_options
 
484
        If set, use an external GNU diff and pass these options.
 
485
 
 
486
    extra_trees
 
487
        If set, more Trees to use for looking up file ids
 
488
 
 
489
    path_encoding
 
490
        If set, the path will be encoded as specified, otherwise is supposed
 
491
        to be utf8
479
492
    """
480
 
    if format_cls is None:
481
 
        format_cls = DiffTree
482
493
    old_tree.lock_read()
483
494
    try:
484
495
        if extra_trees is not None:
486
497
                tree.lock_read()
487
498
        new_tree.lock_read()
488
499
        try:
489
 
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
490
 
                                                   path_encoding,
491
 
                                                   external_diff_options,
492
 
                                                   old_label, new_label, using)
 
500
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
 
501
                                                 path_encoding,
 
502
                                                 external_diff_options,
 
503
                                                 old_label, new_label, using)
493
504
            return differ.show_diff(specific_files, extra_trees)
494
505
        finally:
495
506
            new_tree.unlock()
502
513
 
503
514
def _patch_header_date(tree, file_id, path):
504
515
    """Returns a timestamp suitable for use in a patch header."""
505
 
    try:
506
 
        mtime = tree.get_file_mtime(file_id, path)
507
 
    except errors.FileTimestampUnavailable:
508
 
        mtime = 0
 
516
    mtime = tree.get_file_mtime(file_id, path)
509
517
    return timestamp.format_patch_date(mtime)
510
518
 
511
519
 
 
520
def _raise_if_nonexistent(paths, old_tree, new_tree):
 
521
    """Complain if paths are not in either inventory or tree.
 
522
 
 
523
    It's OK with the files exist in either tree's inventory, or 
 
524
    if they exist in the tree but are not versioned.
 
525
    
 
526
    This can be used by operations such as bzr status that can accept
 
527
    unknown or ignored files.
 
528
    """
 
529
    mutter("check paths: %r", paths)
 
530
    if not paths:
 
531
        return
 
532
    s = old_tree.filter_unversioned_files(paths)
 
533
    s = new_tree.filter_unversioned_files(s)
 
534
    s = [path for path in s if not new_tree.has_filename(path)]
 
535
    if s:
 
536
        raise errors.PathsDoNotExist(sorted(s))
 
537
 
 
538
 
 
539
@deprecated_function(one_three)
 
540
def get_prop_change(meta_modified):
 
541
    if meta_modified:
 
542
        return " (properties changed)"
 
543
    else:
 
544
        return  ""
 
545
 
512
546
def get_executable_change(old_is_x, new_is_x):
513
547
    descr = { True:"+x", False:"-x", None:"??" }
514
548
    if old_is_x != new_is_x:
689
723
            return self.CANNOT_DIFF
690
724
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
691
725
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
692
 
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
693
 
            old_path, new_path)
 
726
        return self.diff_text(from_file_id, to_file_id, from_label, to_label)
694
727
 
695
 
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
696
 
        from_path=None, to_path=None):
 
728
    def diff_text(self, from_file_id, to_file_id, from_label, to_label):
697
729
        """Diff the content of given files in two trees
698
730
 
699
731
        :param from_file_id: The id of the file in the from tree.  If None,
701
733
        :param to_file_id: The id of the file in the to tree.  This may refer
702
734
            to a different file from from_file_id.  If None,
703
735
            the file is not present in the to tree.
704
 
        :param from_path: The path in the from tree or None if unknown.
705
 
        :param to_path: The path in the to tree or None if unknown.
706
736
        """
707
 
        def _get_text(tree, file_id, path):
 
737
        def _get_text(tree, file_id):
708
738
            if file_id is not None:
709
 
                return tree.get_file(file_id, path).readlines()
 
739
                return tree.get_file(file_id).readlines()
710
740
            else:
711
741
                return []
712
742
        try:
713
 
            from_text = _get_text(self.old_tree, from_file_id, from_path)
714
 
            to_text = _get_text(self.new_tree, to_file_id, to_path)
 
743
            from_text = _get_text(self.old_tree, from_file_id)
 
744
            to_text = _get_text(self.new_tree, to_file_id)
715
745
            self.text_differ(from_label, from_text, to_label, to_text,
716
746
                             self.to_file)
717
747
        except errors.BinaryFile:
727
757
                 path_encoding='utf-8'):
728
758
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
729
759
        self.command_template = command_template
730
 
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
 
760
        self._root = tempfile.mkdtemp(prefix='bzr-diff-')
731
761
 
732
762
    @classmethod
733
763
    def from_string(klass, command_string, old_tree, new_tree, to_file,
734
764
                    path_encoding='utf-8'):
735
 
        command_template = cmdline.split(command_string)
736
 
        if '@' not in command_string:
737
 
            command_template.extend(['@old_path', '@new_path'])
 
765
        command_template = commands.shlex_split_unicode(command_string)
 
766
        command_template.extend(['%(old_path)s', '%(new_path)s'])
738
767
        return klass(command_template, old_tree, new_tree, to_file,
739
768
                     path_encoding)
740
769
 
747
776
 
748
777
    def _get_command(self, old_path, new_path):
749
778
        my_map = {'old_path': old_path, 'new_path': new_path}
750
 
        return [AtTemplate(t).substitute(my_map) for t in
751
 
                self.command_template]
 
779
        return [t % my_map for t in self.command_template]
752
780
 
753
781
    def _execute(self, old_path, new_path):
754
782
        command = self._get_command(old_path, new_path)
764
792
        return proc.wait()
765
793
 
766
794
    def _try_symlink_root(self, tree, prefix):
767
 
        if (getattr(tree, 'abspath', None) is None
768
 
            or not osutils.host_os_dereferences_symlinks()):
 
795
        if not (getattr(tree, 'abspath', None) is not None
 
796
                and osutils.has_symlinks()):
769
797
            return False
770
798
        try:
771
799
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
774
802
                raise
775
803
        return True
776
804
 
777
 
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
778
 
                    allow_write=False):
779
 
        if not force_temp and isinstance(tree, WorkingTree):
780
 
            return tree.abspath(tree.id2path(file_id))
781
 
        
 
805
    def _write_file(self, file_id, tree, prefix, relpath):
782
806
        full_path = osutils.pathjoin(self._root, prefix, relpath)
783
 
        if not force_temp and self._try_symlink_root(tree, prefix):
 
807
        if self._try_symlink_root(tree, prefix):
784
808
            return full_path
785
809
        parent_dir = osutils.dirname(full_path)
786
810
        try:
797
821
                target.close()
798
822
        finally:
799
823
            source.close()
800
 
        try:
801
 
            mtime = tree.get_file_mtime(file_id)
802
 
        except errors.FileTimestampUnavailable:
803
 
            pass
804
 
        else:
805
 
            os.utime(full_path, (mtime, mtime))
806
 
        if not allow_write:
807
 
            osutils.make_readonly(full_path)
 
824
        osutils.make_readonly(full_path)
 
825
        mtime = tree.get_file_mtime(file_id)
 
826
        os.utime(full_path, (mtime, mtime))
808
827
        return full_path
809
828
 
810
 
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
811
 
                       allow_write_new=False):
 
829
    def _prepare_files(self, file_id, old_path, new_path):
812
830
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
813
 
                                         old_path, force_temp)
 
831
                                         old_path)
814
832
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
815
 
                                         new_path, force_temp,
816
 
                                         allow_write=allow_write_new)
 
833
                                         new_path)
817
834
        return old_disk_path, new_disk_path
818
835
 
819
836
    def finish(self):
820
 
        try:
821
 
            osutils.rmtree(self._root)
822
 
        except OSError, e:
823
 
            if e.errno != errno.ENOENT:
824
 
                mutter("The temporary directory \"%s\" was not "
825
 
                        "cleanly removed: %s." % (self._root, e))
 
837
        osutils.rmtree(self._root)
826
838
 
827
839
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
828
840
        if (old_kind, new_kind) != ('file', 'file'):
829
841
            return DiffPath.CANNOT_DIFF
830
 
        (old_disk_path, new_disk_path) = self._prepare_files(
831
 
                                                file_id, old_path, new_path)
832
 
        self._execute(old_disk_path, new_disk_path)
833
 
 
834
 
    def edit_file(self, file_id):
835
 
        """Use this tool to edit a file.
836
 
 
837
 
        A temporary copy will be edited, and the new contents will be
838
 
        returned.
839
 
 
840
 
        :param file_id: The id of the file to edit.
841
 
        :return: The new contents of the file.
842
 
        """
843
 
        old_path = self.old_tree.id2path(file_id)
844
 
        new_path = self.new_tree.id2path(file_id)
845
 
        new_abs_path = self._prepare_files(file_id, old_path, new_path,
846
 
                                           allow_write_new=True,
847
 
                                           force_temp=True)[1]
848
 
        command = self._get_command(osutils.pathjoin('old', old_path),
849
 
                                    osutils.pathjoin('new', new_path))
850
 
        subprocess.call(command, cwd=self._root)
851
 
        new_file = open(new_abs_path, 'r')
852
 
        try:
853
 
            return new_file.read()
854
 
        finally:
855
 
            new_file.close()
 
842
        self._prepare_files(file_id, old_path, new_path)
 
843
        self._execute(osutils.pathjoin('old', old_path),
 
844
                      osutils.pathjoin('new', new_path))
856
845
 
857
846
 
858
847
class DiffTree(object):
932
921
    def show_diff(self, specific_files, extra_trees=None):
933
922
        """Write tree diff to self.to_file
934
923
 
935
 
        :param specific_files: the specific files to compare (recursive)
 
924
        :param sepecific_files: the specific files to compare (recursive)
936
925
        :param extra_trees: extra trees to use for mapping paths to file_ids
937
926
        """
938
927
        try:
960
949
                return path.encode(self.path_encoding, "replace")
961
950
        for (file_id, paths, changed_content, versioned, parent, name, kind,
962
951
             executable) in sorted(iterator, key=changes_key):
963
 
            # The root does not get diffed, and items with no known kind (that
964
 
            # is, missing) in both trees are skipped as well.
965
 
            if parent == (None, None) or kind == (None, None):
 
952
            if parent == (None, None):
966
953
                continue
967
954
            oldpath, newpath = paths
968
955
            oldpath_encoded = get_encoded_path(paths[0])
996
983
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
997
984
                                   newpath_encoded, prop_str))
998
985
            if changed_content:
999
 
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
 
986
                self.diff(file_id, oldpath, newpath)
1000
987
                has_changes = 1
1001
988
            if renamed:
1002
989
                has_changes = 1
1017
1004
            new_kind = self.new_tree.kind(file_id)
1018
1005
        except (errors.NoSuchId, errors.NoSuchFile):
1019
1006
            new_kind = None
1020
 
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
1021
 
 
1022
 
 
1023
 
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
 
1007
 
1024
1008
        result = DiffPath._diff_many(self.differs, file_id, old_path,
1025
1009
                                       new_path, old_kind, new_kind)
1026
1010
        if result is DiffPath.CANNOT_DIFF:
1028
1012
            if error_path is None:
1029
1013
                error_path = old_path
1030
1014
            raise errors.NoDiffFound(error_path)
1031
 
 
1032
 
 
1033
 
format_registry = Registry()
1034
 
format_registry.register('default', DiffTree)