← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to doc/developers/implementation-notes.txt

  • Committer: Vincent Ladeuil
  • Date: 2008-01-29 15:16:31 UTC
  • mto: (3206.1.1 trunk)
  • mto: This revision was merged to the branch mainline in revision 3207.
  • Revision ID: v.ladeuil+lp@free.fr-20080129151631-vqjd13tb405mobx6
Fix two more leaking tmp dirs, by reworking TransformPreview lock handling.

* bzrlib/tests/test_transform.py:
(TestTransformMerge): Revert previous patch and cleanly call
preview.finalize now that we can.

* bzrlib/tests/test_merge.py:
(TestMerge.test_make_preview_transform): Catch TransformPreview
leak.

* bzrlib/builtins.py:
(cmd_merge._do_preview): Finalize the TransformPreview or the
limbodir will stay in /tmp.

* bzrlib/transform.py:
(TreeTransformBase.__init__): Create the _deletiondir since it's
reffered to by finalize.
(TreeTransformBase.finalize): Delete the dir only if _deletiondir
is set.
(TreeTransform.__init__): Use a temp var for deletiondir and set
the attribute after the base class __init__ has been called.
(TransformPreview.__init__): Read locks the tree since finalize
wants to unlock it (as suggested by Aaron).

Show diffs side-by-side

added added

removed removed

Lines of Context:
doc/developers/implementation-notes.txt
1
 
Implementation notes
2
 
====================
3
 
 
4
 
.. toctree::
5
 
   :hidden:
6
 
 
7
 
   btree_index_prefetch
8
 
   last-modified
9
 
   content-filtering
10
 
   lca_tree_merging
11
 
 
12
 
 
13
 
* `BTree Index Prefetch <btree_index_prefetch.html>`_ |--| How bzr decides
14
 
  to pre-read extra nodes in the btree index.
15
 
 
16
 
* `Computing last_modified values <last-modified.html>`_ for inventory
17
 
  entries
18
 
 
19
 
* `Content filtering <content-filtering.html>`_
20
 
 
21
 
* `LCA Tree Merging <lca_tree_merging.html>`_ |--| Merging tree-shape when
22
 
  there is not a single unique ancestor (criss-cross merge).
23
 
 
24
 
 
25
 
.. |--| unicode:: U+2014
26
 
 
27
 
..
28
 
   vim: ft=rst tw=74 ai