← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/textinv.py

  • Committer: Vincent Ladeuil
  • Date: 2008-01-29 15:16:31 UTC
  • mto: (3206.1.1 trunk)
  • mto: This revision was merged to the branch mainline in revision 3207.
  • Revision ID: v.ladeuil+lp@free.fr-20080129151631-vqjd13tb405mobx6
Fix two more leaking tmp dirs, by reworking TransformPreview lock handling.

* bzrlib/tests/test_transform.py:
(TestTransformMerge): Revert previous patch and cleanly call
preview.finalize now that we can.

* bzrlib/tests/test_merge.py:
(TestMerge.test_make_preview_transform): Catch TransformPreview
leak.

* bzrlib/builtins.py:
(cmd_merge._do_preview): Finalize the TransformPreview or the
limbodir will stay in /tmp.

* bzrlib/transform.py:
(TreeTransformBase.__init__): Create the _deletiondir since it's
reffered to by finalize.
(TreeTransformBase.finalize): Delete the dir only if _deletiondir
is set.
(TreeTransform.__init__): Use a temp var for deletiondir and set
the attribute after the base class __init__ has been called.
(TransformPreview.__init__): Read locks the tree since finalize
wants to unlock it (as suggested by Aaron).

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/textinv.py
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
 
18
18
from bzrlib.errors import BzrError
19
 
from bzrlib.inventory import Inventory
 
19
from bzrlib.inventory import InventoryEntry, Inventory
20
20
 
21
21
 
22
22
START_MARK = "# bzr inventory format 3\n"
25
25
 
26
26
def escape(s):
27
27
    """Very simple URL-like escaping.
28
 
 
 
28
    
29
29
    (Why not just use backslashes?  Because then we couldn't parse
30
30
    lines just by splitting on spaces.)"""
31
31
    return (s.replace('\\', r'\x5c')
36
36
 
37
37
 
38
38
def unescape(s):
39
 
    if s.find(' ') != -1:
40
 
        raise AssertionError()
 
39
    assert s.find(' ') == -1
41
40
    s = (s.replace(r'\x20', ' ')
42
41
         .replace(r'\x09', '\t')
43
42
         .replace(r'\x0a', '\n')
46
45
    # TODO: What if there's anything else?
47
46
 
48
47
    return s
49
 
 
50
 
 
 
48
    
 
49
                     
51
50
 
52
51
 
53
52
def write_text_inventory(inv, outf):
56
55
    for path, ie in inv.iter_entries():
57
56
        if inv.is_root(ie.file_id):
58
57
            continue
59
 
 
 
58
        
60
59
        outf.write(ie.file_id + ' ')
61
60
        outf.write(escape(ie.name) + ' ')
62
61
        outf.write(ie.kind + ' ')
63
62
        outf.write(ie.parent_id + ' ')
64
 
 
 
63
        
65
64
        if ie.kind == 'file':
66
65
            outf.write(ie.text_id)
67
66
            outf.write(' ' + ie.text_sha1)
74
73
    """Return an inventory read in from tf"""
75
74
    if tf.readline() != START_MARK:
76
75
        raise BzrError("missing start mark")
77
 
 
 
76
    
78
77
    inv = Inventory()
79
78
 
80
79
    for l in tf:
86
85
              'kind': fields[2],
87
86
              'parent_id': fields[3]}
88
87
        ##inv.add(ie)
89
 
 
 
88
        
90
89
    if l != END_MARK:
91
90
        raise BzrError("missing end mark")
92
91
    return inv