← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_hooks.py

  • Committer: Vincent Ladeuil
  • Date: 2008-01-29 15:16:31 UTC
  • mto: (3206.1.1 trunk)
  • mto: This revision was merged to the branch mainline in revision 3207.
  • Revision ID: v.ladeuil+lp@free.fr-20080129151631-vqjd13tb405mobx6
Fix two more leaking tmp dirs, by reworking TransformPreview lock handling.

* bzrlib/tests/test_transform.py:
(TestTransformMerge): Revert previous patch and cleanly call
preview.finalize now that we can.

* bzrlib/tests/test_merge.py:
(TestMerge.test_make_preview_transform): Catch TransformPreview
leak.

* bzrlib/builtins.py:
(cmd_merge._do_preview): Finalize the TransformPreview or the
limbodir will stay in /tmp.

* bzrlib/transform.py:
(TreeTransformBase.__init__): Create the _deletiondir since it's
reffered to by finalize.
(TreeTransformBase.finalize): Delete the dir only if _deletiondir
is set.
(TreeTransform.__init__): Use a temp var for deletiondir and set
the attribute after the base class __init__ has been called.
(TransformPreview.__init__): Read locks the tree since finalize
wants to unlock it (as suggested by Aaron).

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_hooks.py
 
1
# Copyright (C) 2007 Canonical Ltd
 
2
#
 
3
# This program is free software; you can redistribute it and/or modify
 
4
# it under the terms of the GNU General Public License as published by
 
5
# the Free Software Foundation; either version 2 of the License, or
 
6
# (at your option) any later version.
 
7
#
 
8
# This program is distributed in the hope that it will be useful,
 
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 
11
# GNU General Public License for more details.
 
12
#
 
13
# You should have received a copy of the GNU General Public License
 
14
# along with this program; if not, write to the Free Software
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
16
 
 
17
"""Tests for the core Hooks logic."""
 
18
 
 
19
from bzrlib.hooks import (
 
20
    Hooks,
 
21
    )
 
22
from bzrlib.errors import (
 
23
    UnknownHook,
 
24
    )
 
25
 
 
26
from bzrlib.tests import TestCase
 
27
 
 
28
 
 
29
class TestHooks(TestCase):
 
30
 
 
31
    def test_install_hook_raises_unknown_hook(self):
 
32
        """install_hook should raise UnknownHook if a hook is unknown."""
 
33
        hooks = Hooks()
 
34
        self.assertRaises(UnknownHook, hooks.install_hook, 'silly', None)
 
35
 
 
36
    def test_install_hook_appends_known_hook(self):
 
37
        """install_hook should append the callable for known hooks."""
 
38
        hooks = Hooks()
 
39
        hooks['set_rh'] = []
 
40
        hooks.install_hook('set_rh', None)
 
41
        self.assertEqual(hooks['set_rh'], [None])
 
42
 
 
43
    def test_name_hook_and_retrieve_name(self):
 
44
        """name_hook puts the name in the names mapping."""
 
45
        hooks = Hooks()
 
46
        hooks['set_rh'] = []
 
47
        hooks.install_hook('set_rh', None)
 
48
        hooks.name_hook(None, 'demo')
 
49
        self.assertEqual("demo", hooks.get_hook_name(None))
 
50
 
 
51
    def test_get_unnamed_hook_name_is_unnamed(self):
 
52
        hooks = Hooks()
 
53
        hooks['set_rh'] = []
 
54
        hooks.install_hook('set_rh', None)
 
55
        self.assertEqual("No hook name", hooks.get_hook_name(None))