~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Aaron Bentley
  • Date: 2007-12-21 06:34:27 UTC
  • mto: This revision was merged to the branch mainline in revision 3140.
  • Revision ID: aaron.bentley@utoronto.ca-20071221063427-pavy148wf806gf11
Fix commit for a checkout sharing a repo with its branch (abentley, #177592)

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd.
 
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
import difflib
18
18
import os
19
19
import re
20
 
import string
21
20
import sys
22
21
 
23
22
from bzrlib.lazy_import import lazy_import
28
27
import time
29
28
 
30
29
from bzrlib import (
31
 
    branch as _mod_branch,
32
30
    bzrdir,
33
 
    cmdline,
34
 
    cleanup,
35
31
    errors,
36
32
    osutils,
37
33
    patiencediff,
38
34
    textfile,
39
35
    timestamp,
40
 
    views,
41
36
    )
42
 
 
43
 
from bzrlib.workingtree import WorkingTree
44
37
""")
45
38
 
46
 
from bzrlib.registry import (
47
 
    Registry,
48
 
    )
49
39
from bzrlib.symbol_versioning import (
50
 
    deprecated_function,
51
 
    deprecated_in,
52
 
    )
53
 
from bzrlib.trace import mutter, note, warning
54
 
 
55
 
 
56
 
class AtTemplate(string.Template):
57
 
    """Templating class that uses @ instead of $."""
58
 
 
59
 
    delimiter = '@'
 
40
        deprecated_function,
 
41
        one_zero,
 
42
        )
 
43
from bzrlib.trace import mutter, warning
60
44
 
61
45
 
62
46
# TODO: Rather than building a changeset object, we should probably
91
75
    # both sequences are empty.
92
76
    if not oldlines and not newlines:
93
77
        return
94
 
 
 
78
    
95
79
    if allow_binary is False:
96
80
        textfile.check_text_lines(oldlines)
97
81
        textfile.check_text_lines(newlines)
112
96
        ud[2] = ud[2].replace('-1,0', '-0,0')
113
97
    elif not newlines:
114
98
        ud[2] = ud[2].replace('+1,0', '+0,0')
 
99
    # work around for difflib emitting random spaces after the label
 
100
    ud[0] = ud[0][:-2] + '\n'
 
101
    ud[1] = ud[1][:-2] + '\n'
115
102
 
116
103
    for line in ud:
117
104
        to_file.write(line)
184
171
 
185
172
        if not diff_opts:
186
173
            diff_opts = []
187
 
        if sys.platform == 'win32':
188
 
            # Popen doesn't do the proper encoding for external commands
189
 
            # Since we are dealing with an ANSI api, use mbcs encoding
190
 
            old_filename = old_filename.encode('mbcs')
191
 
            new_filename = new_filename.encode('mbcs')
192
174
        diffcmd = ['diff',
193
175
                   '--label', old_filename,
194
176
                   old_abspath,
217
199
            break
218
200
        else:
219
201
            diffcmd.append('-u')
220
 
 
 
202
                  
221
203
        if diff_opts:
222
204
            diffcmd.extend(diff_opts)
223
205
 
224
206
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
225
207
        out,err = pipe.communicate()
226
208
        rc = pipe.returncode
227
 
 
 
209
        
228
210
        # internal_diff() adds a trailing newline, add one here for consistency
229
211
        out += '\n'
230
212
        if rc == 2:
265
247
                msg = 'signal %d' % (-rc)
266
248
            else:
267
249
                msg = 'exit code %d' % rc
268
 
 
269
 
            raise errors.BzrError('external diff failed with %s; command: %r'
 
250
                
 
251
            raise errors.BzrError('external diff failed with %s; command: %r' 
270
252
                                  % (rc, diffcmd))
271
253
 
272
254
 
290
272
                        new_abspath, e)
291
273
 
292
274
 
293
 
@deprecated_function(deprecated_in((2, 2, 0)))
294
 
def get_trees_and_branches_to_diff(path_list, revision_specs, old_url, new_url,
295
 
                                   apply_view=True):
296
 
    """Get the trees and specific files to diff given a list of paths.
297
 
 
298
 
    This method works out the trees to be diff'ed and the files of
299
 
    interest within those trees.
300
 
 
301
 
    :param path_list:
302
 
        the list of arguments passed to the diff command
303
 
    :param revision_specs:
304
 
        Zero, one or two RevisionSpecs from the diff command line,
305
 
        saying what revisions to compare.
306
 
    :param old_url:
307
 
        The url of the old branch or tree. If None, the tree to use is
308
 
        taken from the first path, if any, or the current working tree.
309
 
    :param new_url:
310
 
        The url of the new branch or tree. If None, the tree to use is
311
 
        taken from the first path, if any, or the current working tree.
312
 
    :param apply_view:
313
 
        if True and a view is set, apply the view or check that the paths
314
 
        are within it
315
 
    :returns:
316
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
317
 
        specific_files, extra_trees) where extra_trees is a sequence of
318
 
        additional trees to search in for file-ids.  The trees and branches
319
 
        are not locked.
320
 
    """
321
 
    op = cleanup.OperationWithCleanups(get_trees_and_branches_to_diff_locked)
322
 
    return op.run_simple(path_list, revision_specs, old_url, new_url,
323
 
            op.add_cleanup, apply_view=apply_view)
 
275
@deprecated_function(one_zero)
 
276
def diff_cmd_helper(tree, specific_files, external_diff_options, 
 
277
                    old_revision_spec=None, new_revision_spec=None,
 
278
                    revision_specs=None,
 
279
                    old_label='a/', new_label='b/'):
 
280
    """Helper for cmd_diff.
 
281
 
 
282
    :param tree:
 
283
        A WorkingTree
 
284
 
 
285
    :param specific_files:
 
286
        The specific files to compare, or None
 
287
 
 
288
    :param external_diff_options:
 
289
        If non-None, run an external diff, and pass it these options
 
290
 
 
291
    :param old_revision_spec:
 
292
        If None, use basis tree as old revision, otherwise use the tree for
 
293
        the specified revision. 
 
294
 
 
295
    :param new_revision_spec:
 
296
        If None, use working tree as new revision, otherwise use the tree for
 
297
        the specified revision.
324
298
    
325
 
 
326
 
def get_trees_and_branches_to_diff_locked(
327
 
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
 
299
    :param revision_specs: 
 
300
        Zero, one or two RevisionSpecs from the command line, saying what revisions 
 
301
        to compare.  This can be passed as an alternative to the old_revision_spec 
 
302
        and new_revision_spec parameters.
 
303
 
 
304
    The more general form is show_diff_trees(), where the caller
 
305
    supplies any two trees.
 
306
    """
 
307
 
 
308
    # TODO: perhaps remove the old parameters old_revision_spec and
 
309
    # new_revision_spec, since this is only really for use from cmd_diff and
 
310
    # it now always passes through a sequence of revision_specs -- mbp
 
311
    # 20061221
 
312
 
 
313
    def spec_tree(spec):
 
314
        if tree:
 
315
            revision = spec.in_store(tree.branch)
 
316
        else:
 
317
            revision = spec.in_store(None)
 
318
        revision_id = revision.rev_id
 
319
        branch = revision.branch
 
320
        return branch.repository.revision_tree(revision_id)
 
321
 
 
322
    if revision_specs is not None:
 
323
        assert (old_revision_spec is None
 
324
                and new_revision_spec is None)
 
325
        if len(revision_specs) > 0:
 
326
            old_revision_spec = revision_specs[0]
 
327
        if len(revision_specs) > 1:
 
328
            new_revision_spec = revision_specs[1]
 
329
 
 
330
    if old_revision_spec is None:
 
331
        old_tree = tree.basis_tree()
 
332
    else:
 
333
        old_tree = spec_tree(old_revision_spec)
 
334
 
 
335
    if (new_revision_spec is None
 
336
        or new_revision_spec.spec is None):
 
337
        new_tree = tree
 
338
    else:
 
339
        new_tree = spec_tree(new_revision_spec)
 
340
 
 
341
    if new_tree is not tree:
 
342
        extra_trees = (tree,)
 
343
    else:
 
344
        extra_trees = None
 
345
 
 
346
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
 
347
                           external_diff_options,
 
348
                           old_label=old_label, new_label=new_label,
 
349
                           extra_trees=extra_trees)
 
350
 
 
351
 
 
352
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url):
328
353
    """Get the trees and specific files to diff given a list of paths.
329
354
 
330
355
    This method works out the trees to be diff'ed and the files of
341
366
    :param new_url:
342
367
        The url of the new branch or tree. If None, the tree to use is
343
368
        taken from the first path, if any, or the current working tree.
344
 
    :param add_cleanup:
345
 
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
346
 
        will register cleanups that must be run to unlock the trees, etc.
347
 
    :param apply_view:
348
 
        if True and a view is set, apply the view or check that the paths
349
 
        are within it
350
369
    :returns:
351
 
        a tuple of (old_tree, new_tree, old_branch, new_branch,
352
 
        specific_files, extra_trees) where extra_trees is a sequence of
353
 
        additional trees to search in for file-ids.  The trees and branches
354
 
        will be read-locked until the cleanups registered via the add_cleanup
355
 
        param are run.
 
370
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
 
371
        extra_trees is a sequence of additional trees to search in for
 
372
        file-ids.
356
373
    """
357
374
    # Get the old and new revision specs
358
375
    old_revision_spec = None
369
386
 
370
387
    other_paths = []
371
388
    make_paths_wt_relative = True
372
 
    consider_relpath = True
373
389
    if path_list is None or len(path_list) == 0:
374
 
        # If no path is given, the current working tree is used
 
390
        # If no path is given, assume the current directory
375
391
        default_location = u'.'
376
 
        consider_relpath = False
377
392
    elif old_url is not None and new_url is not None:
378
393
        other_paths = path_list
379
394
        make_paths_wt_relative = False
381
396
        default_location = path_list[0]
382
397
        other_paths = path_list[1:]
383
398
 
384
 
    def lock_tree_or_branch(wt, br):
385
 
        if wt is not None:
386
 
            wt.lock_read()
387
 
            add_cleanup(wt.unlock)
388
 
        elif br is not None:
389
 
            br.lock_read()
390
 
            add_cleanup(br.unlock)
391
 
 
392
399
    # Get the old location
393
400
    specific_files = []
394
401
    if old_url is None:
395
402
        old_url = default_location
396
403
    working_tree, branch, relpath = \
397
404
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
398
 
    lock_tree_or_branch(working_tree, branch)
399
 
    if consider_relpath and relpath != '':
400
 
        if working_tree is not None and apply_view:
401
 
            views.check_path_in_view(working_tree, relpath)
 
405
    if relpath != '':
402
406
        specific_files.append(relpath)
403
407
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
404
 
    old_branch = branch
405
408
 
406
409
    # Get the new location
407
410
    if new_url is None:
409
412
    if new_url != old_url:
410
413
        working_tree, branch, relpath = \
411
414
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
412
 
        lock_tree_or_branch(working_tree, branch)
413
 
        if consider_relpath and relpath != '':
414
 
            if working_tree is not None and apply_view:
415
 
                views.check_path_in_view(working_tree, relpath)
 
415
        if relpath != '':
416
416
            specific_files.append(relpath)
417
417
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
418
418
        basis_is_default=working_tree is None)
419
 
    new_branch = branch
420
419
 
421
420
    # Get the specific files (all files is None, no files is [])
422
421
    if make_paths_wt_relative and working_tree is not None:
423
 
        try:
424
 
            from bzrlib.builtins import safe_relpath_files
425
 
            other_paths = safe_relpath_files(working_tree, other_paths,
426
 
            apply_view=apply_view)
427
 
        except errors.FileInWrongBranch:
428
 
            raise errors.BzrCommandError("Files are in different branches")
 
422
        other_paths = _relative_paths_in_tree(working_tree, other_paths)
429
423
    specific_files.extend(other_paths)
430
424
    if len(specific_files) == 0:
431
425
        specific_files = None
432
 
        if (working_tree is not None and working_tree.supports_views()
433
 
            and apply_view):
434
 
            view_files = working_tree.views.lookup_view()
435
 
            if view_files:
436
 
                specific_files = view_files
437
 
                view_str = views.view_display_str(view_files)
438
 
                note("*** Ignoring files outside view. View is %s" % view_str)
439
426
 
440
427
    # Get extra trees that ought to be searched for file-ids
441
428
    extra_trees = None
442
429
    if working_tree is not None and working_tree not in (old_tree, new_tree):
443
430
        extra_trees = (working_tree,)
444
 
    return old_tree, new_tree, old_branch, new_branch, specific_files, extra_trees
 
431
    return old_tree, new_tree, specific_files, extra_trees
445
432
 
446
433
 
447
434
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
455
442
                return branch.basis_tree()
456
443
        else:
457
444
            return tree
458
 
    return spec.as_tree(branch)
 
445
    revision = spec.in_store(branch)
 
446
    revision_id = revision.rev_id
 
447
    rev_branch = revision.branch
 
448
    return rev_branch.repository.revision_tree(revision_id)
 
449
 
 
450
 
 
451
def _relative_paths_in_tree(tree, paths):
 
452
    """Get the relative paths within a working tree.
 
453
 
 
454
    Each path may be either an absolute path or a path relative to the
 
455
    current working directory.
 
456
    """
 
457
    result = []
 
458
    for filename in paths:
 
459
        try:
 
460
            result.append(tree.relpath(osutils.dereference_path(filename)))
 
461
        except errors.PathNotChild:
 
462
            raise errors.BzrCommandError("Files are in different branches")
 
463
    return result
459
464
 
460
465
 
461
466
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
462
467
                    external_diff_options=None,
463
468
                    old_label='a/', new_label='b/',
464
469
                    extra_trees=None,
465
 
                    path_encoding='utf8',
466
 
                    using=None,
467
 
                    format_cls=None):
 
470
                    path_encoding='utf8'):
468
471
    """Show in text form the changes from one tree to another.
469
472
 
470
 
    :param to_file: The output stream.
471
 
    :param specific_files:Include only changes to these files - None for all
472
 
        changes.
473
 
    :param external_diff_options: If set, use an external GNU diff and pass 
474
 
        these options.
475
 
    :param extra_trees: If set, more Trees to use for looking up file ids
476
 
    :param path_encoding: If set, the path will be encoded as specified, 
477
 
        otherwise is supposed to be utf8
478
 
    :param format_cls: Formatter class (DiffTree subclass)
 
473
    to_file
 
474
        The output stream.
 
475
 
 
476
    specific_files
 
477
        Include only changes to these files - None for all changes.
 
478
 
 
479
    external_diff_options
 
480
        If set, use an external GNU diff and pass these options.
 
481
 
 
482
    extra_trees
 
483
        If set, more Trees to use for looking up file ids
 
484
 
 
485
    path_encoding
 
486
        If set, the path will be encoded as specified, otherwise is supposed
 
487
        to be utf8
479
488
    """
480
 
    if format_cls is None:
481
 
        format_cls = DiffTree
482
489
    old_tree.lock_read()
483
490
    try:
484
491
        if extra_trees is not None:
486
493
                tree.lock_read()
487
494
        new_tree.lock_read()
488
495
        try:
489
 
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
 
496
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
490
497
                                                   path_encoding,
491
498
                                                   external_diff_options,
492
 
                                                   old_label, new_label, using)
 
499
                                                   old_label, new_label)
493
500
            return differ.show_diff(specific_files, extra_trees)
494
501
        finally:
495
502
            new_tree.unlock()
502
509
 
503
510
def _patch_header_date(tree, file_id, path):
504
511
    """Returns a timestamp suitable for use in a patch header."""
505
 
    try:
506
 
        mtime = tree.get_file_mtime(file_id, path)
507
 
    except errors.FileTimestampUnavailable:
508
 
        mtime = 0
 
512
    mtime = tree.get_file_mtime(file_id, path)
 
513
    assert mtime is not None, \
 
514
        "got an mtime of None for file-id %s, path %s in tree %s" % (
 
515
                file_id, path, tree)
509
516
    return timestamp.format_patch_date(mtime)
510
517
 
511
518
 
512
 
def get_executable_change(old_is_x, new_is_x):
513
 
    descr = { True:"+x", False:"-x", None:"??" }
514
 
    if old_is_x != new_is_x:
515
 
        return ["%s to %s" % (descr[old_is_x], descr[new_is_x],)]
 
519
def _raise_if_nonexistent(paths, old_tree, new_tree):
 
520
    """Complain if paths are not in either inventory or tree.
 
521
 
 
522
    It's OK with the files exist in either tree's inventory, or 
 
523
    if they exist in the tree but are not versioned.
 
524
    
 
525
    This can be used by operations such as bzr status that can accept
 
526
    unknown or ignored files.
 
527
    """
 
528
    mutter("check paths: %r", paths)
 
529
    if not paths:
 
530
        return
 
531
    s = old_tree.filter_unversioned_files(paths)
 
532
    s = new_tree.filter_unversioned_files(s)
 
533
    s = [path for path in s if not new_tree.has_filename(path)]
 
534
    if s:
 
535
        raise errors.PathsDoNotExist(sorted(s))
 
536
 
 
537
 
 
538
def get_prop_change(meta_modified):
 
539
    if meta_modified:
 
540
        return " (properties changed)"
516
541
    else:
517
 
        return []
 
542
        return  ""
518
543
 
519
544
 
520
545
class DiffPath(object):
540
565
        self.to_file = to_file
541
566
        self.path_encoding = path_encoding
542
567
 
543
 
    def finish(self):
544
 
        pass
545
 
 
546
568
    @classmethod
547
569
    def from_diff_tree(klass, diff_tree):
548
570
        return klass(diff_tree.old_tree, diff_tree.new_tree,
568
590
    def __init__(self, differs):
569
591
        self.differs = differs
570
592
 
571
 
    def finish(self):
572
 
        pass
573
 
 
574
593
    @classmethod
575
594
    def from_diff_tree(klass, diff_tree):
576
595
        return klass(diff_tree.differs)
689
708
            return self.CANNOT_DIFF
690
709
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
691
710
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
692
 
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
693
 
            old_path, new_path)
 
711
        return self.diff_text(from_file_id, to_file_id, from_label, to_label)
694
712
 
695
 
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
696
 
        from_path=None, to_path=None):
 
713
    def diff_text(self, from_file_id, to_file_id, from_label, to_label):
697
714
        """Diff the content of given files in two trees
698
715
 
699
716
        :param from_file_id: The id of the file in the from tree.  If None,
701
718
        :param to_file_id: The id of the file in the to tree.  This may refer
702
719
            to a different file from from_file_id.  If None,
703
720
            the file is not present in the to tree.
704
 
        :param from_path: The path in the from tree or None if unknown.
705
 
        :param to_path: The path in the to tree or None if unknown.
706
721
        """
707
 
        def _get_text(tree, file_id, path):
 
722
        def _get_text(tree, file_id):
708
723
            if file_id is not None:
709
 
                return tree.get_file(file_id, path).readlines()
 
724
                return tree.get_file(file_id).readlines()
710
725
            else:
711
726
                return []
712
727
        try:
713
 
            from_text = _get_text(self.old_tree, from_file_id, from_path)
714
 
            to_text = _get_text(self.new_tree, to_file_id, to_path)
 
728
            from_text = _get_text(self.old_tree, from_file_id)
 
729
            to_text = _get_text(self.new_tree, to_file_id)
715
730
            self.text_differ(from_label, from_text, to_label, to_text,
716
731
                             self.to_file)
717
732
        except errors.BinaryFile:
721
736
        return self.CHANGED
722
737
 
723
738
 
724
 
class DiffFromTool(DiffPath):
725
 
 
726
 
    def __init__(self, command_template, old_tree, new_tree, to_file,
727
 
                 path_encoding='utf-8'):
728
 
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
729
 
        self.command_template = command_template
730
 
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
731
 
 
732
 
    @classmethod
733
 
    def from_string(klass, command_string, old_tree, new_tree, to_file,
734
 
                    path_encoding='utf-8'):
735
 
        command_template = cmdline.split(command_string)
736
 
        if '@' not in command_string:
737
 
            command_template.extend(['@old_path', '@new_path'])
738
 
        return klass(command_template, old_tree, new_tree, to_file,
739
 
                     path_encoding)
740
 
 
741
 
    @classmethod
742
 
    def make_from_diff_tree(klass, command_string):
743
 
        def from_diff_tree(diff_tree):
744
 
            return klass.from_string(command_string, diff_tree.old_tree,
745
 
                                     diff_tree.new_tree, diff_tree.to_file)
746
 
        return from_diff_tree
747
 
 
748
 
    def _get_command(self, old_path, new_path):
749
 
        my_map = {'old_path': old_path, 'new_path': new_path}
750
 
        return [AtTemplate(t).substitute(my_map) for t in
751
 
                self.command_template]
752
 
 
753
 
    def _execute(self, old_path, new_path):
754
 
        command = self._get_command(old_path, new_path)
755
 
        try:
756
 
            proc = subprocess.Popen(command, stdout=subprocess.PIPE,
757
 
                                    cwd=self._root)
758
 
        except OSError, e:
759
 
            if e.errno == errno.ENOENT:
760
 
                raise errors.ExecutableMissing(command[0])
761
 
            else:
762
 
                raise
763
 
        self.to_file.write(proc.stdout.read())
764
 
        return proc.wait()
765
 
 
766
 
    def _try_symlink_root(self, tree, prefix):
767
 
        if (getattr(tree, 'abspath', None) is None
768
 
            or not osutils.host_os_dereferences_symlinks()):
769
 
            return False
770
 
        try:
771
 
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
772
 
        except OSError, e:
773
 
            if e.errno != errno.EEXIST:
774
 
                raise
775
 
        return True
776
 
 
777
 
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
778
 
                    allow_write=False):
779
 
        if not force_temp and isinstance(tree, WorkingTree):
780
 
            return tree.abspath(tree.id2path(file_id))
781
 
        
782
 
        full_path = osutils.pathjoin(self._root, prefix, relpath)
783
 
        if not force_temp and self._try_symlink_root(tree, prefix):
784
 
            return full_path
785
 
        parent_dir = osutils.dirname(full_path)
786
 
        try:
787
 
            os.makedirs(parent_dir)
788
 
        except OSError, e:
789
 
            if e.errno != errno.EEXIST:
790
 
                raise
791
 
        source = tree.get_file(file_id, relpath)
792
 
        try:
793
 
            target = open(full_path, 'wb')
794
 
            try:
795
 
                osutils.pumpfile(source, target)
796
 
            finally:
797
 
                target.close()
798
 
        finally:
799
 
            source.close()
800
 
        try:
801
 
            mtime = tree.get_file_mtime(file_id)
802
 
        except errors.FileTimestampUnavailable:
803
 
            pass
804
 
        else:
805
 
            os.utime(full_path, (mtime, mtime))
806
 
        if not allow_write:
807
 
            osutils.make_readonly(full_path)
808
 
        return full_path
809
 
 
810
 
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
811
 
                       allow_write_new=False):
812
 
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
813
 
                                         old_path, force_temp)
814
 
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
815
 
                                         new_path, force_temp,
816
 
                                         allow_write=allow_write_new)
817
 
        return old_disk_path, new_disk_path
818
 
 
819
 
    def finish(self):
820
 
        try:
821
 
            osutils.rmtree(self._root)
822
 
        except OSError, e:
823
 
            if e.errno != errno.ENOENT:
824
 
                mutter("The temporary directory \"%s\" was not "
825
 
                        "cleanly removed: %s." % (self._root, e))
826
 
 
827
 
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
828
 
        if (old_kind, new_kind) != ('file', 'file'):
829
 
            return DiffPath.CANNOT_DIFF
830
 
        (old_disk_path, new_disk_path) = self._prepare_files(
831
 
                                                file_id, old_path, new_path)
832
 
        self._execute(old_disk_path, new_disk_path)
833
 
 
834
 
    def edit_file(self, file_id):
835
 
        """Use this tool to edit a file.
836
 
 
837
 
        A temporary copy will be edited, and the new contents will be
838
 
        returned.
839
 
 
840
 
        :param file_id: The id of the file to edit.
841
 
        :return: The new contents of the file.
842
 
        """
843
 
        old_path = self.old_tree.id2path(file_id)
844
 
        new_path = self.new_tree.id2path(file_id)
845
 
        new_abs_path = self._prepare_files(file_id, old_path, new_path,
846
 
                                           allow_write_new=True,
847
 
                                           force_temp=True)[1]
848
 
        command = self._get_command(osutils.pathjoin('old', old_path),
849
 
                                    osutils.pathjoin('new', new_path))
850
 
        subprocess.call(command, cwd=self._root)
851
 
        new_file = open(new_abs_path, 'r')
852
 
        try:
853
 
            return new_file.read()
854
 
        finally:
855
 
            new_file.close()
856
 
 
857
 
 
858
739
class DiffTree(object):
859
740
    """Provides textual representations of the difference between two trees.
860
741
 
900
781
    @classmethod
901
782
    def from_trees_options(klass, old_tree, new_tree, to_file,
902
783
                           path_encoding, external_diff_options, old_label,
903
 
                           new_label, using):
 
784
                           new_label):
904
785
        """Factory for producing a DiffTree.
905
786
 
906
787
        Designed to accept options used by show_diff_trees.
912
793
            binary to perform file comparison, using supplied options.
913
794
        :param old_label: Prefix to use for old file labels
914
795
        :param new_label: Prefix to use for new file labels
915
 
        :param using: Commandline to use to invoke an external diff tool
916
796
        """
917
 
        if using is not None:
918
 
            extra_factories = [DiffFromTool.make_from_diff_tree(using)]
919
 
        else:
920
 
            extra_factories = []
921
797
        if external_diff_options:
 
798
            assert isinstance(external_diff_options, basestring)
922
799
            opts = external_diff_options.split()
923
800
            def diff_file(olab, olines, nlab, nlines, to_file):
924
801
                external_diff(olab, olines, nlab, nlines, to_file, opts)
926
803
            diff_file = internal_diff
927
804
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
928
805
                             old_label, new_label, diff_file)
929
 
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
930
 
                     extra_factories)
 
806
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text)
931
807
 
932
808
    def show_diff(self, specific_files, extra_trees=None):
933
809
        """Write tree diff to self.to_file
934
810
 
935
 
        :param specific_files: the specific files to compare (recursive)
 
811
        :param sepecific_files: the specific files to compare (recursive)
936
812
        :param extra_trees: extra trees to use for mapping paths to file_ids
937
813
        """
938
 
        try:
939
 
            return self._show_diff(specific_files, extra_trees)
940
 
        finally:
941
 
            for differ in self.differs:
942
 
                differ.finish()
943
 
 
944
 
    def _show_diff(self, specific_files, extra_trees):
945
814
        # TODO: Generation of pseudo-diffs for added/deleted files could
946
815
        # be usefully made into a much faster special case.
947
 
        iterator = self.new_tree.iter_changes(self.old_tree,
948
 
                                               specific_files=specific_files,
949
 
                                               extra_trees=extra_trees,
950
 
                                               require_versioned=True)
 
816
 
 
817
        delta = self.new_tree.changes_from(self.old_tree,
 
818
            specific_files=specific_files,
 
819
            extra_trees=extra_trees, require_versioned=True)
 
820
 
951
821
        has_changes = 0
952
 
        def changes_key(change):
953
 
            old_path, new_path = change[1]
954
 
            path = new_path
955
 
            if path is None:
956
 
                path = old_path
957
 
            return path
958
 
        def get_encoded_path(path):
959
 
            if path is not None:
960
 
                return path.encode(self.path_encoding, "replace")
961
 
        for (file_id, paths, changed_content, versioned, parent, name, kind,
962
 
             executable) in sorted(iterator, key=changes_key):
963
 
            # The root does not get diffed, and items with no known kind (that
964
 
            # is, missing) in both trees are skipped as well.
965
 
            if parent == (None, None) or kind == (None, None):
966
 
                continue
967
 
            oldpath, newpath = paths
968
 
            oldpath_encoded = get_encoded_path(paths[0])
969
 
            newpath_encoded = get_encoded_path(paths[1])
970
 
            old_present = (kind[0] is not None and versioned[0])
971
 
            new_present = (kind[1] is not None and versioned[1])
972
 
            renamed = (parent[0], name[0]) != (parent[1], name[1])
973
 
 
974
 
            properties_changed = []
975
 
            properties_changed.extend(get_executable_change(executable[0], executable[1]))
976
 
 
977
 
            if properties_changed:
978
 
                prop_str = " (properties changed: %s)" % (", ".join(properties_changed),)
979
 
            else:
980
 
                prop_str = ""
981
 
 
982
 
            if (old_present, new_present) == (True, False):
983
 
                self.to_file.write("=== removed %s '%s'\n" %
984
 
                                   (kind[0], oldpath_encoded))
985
 
                newpath = oldpath
986
 
            elif (old_present, new_present) == (False, True):
987
 
                self.to_file.write("=== added %s '%s'\n" %
988
 
                                   (kind[1], newpath_encoded))
989
 
                oldpath = newpath
990
 
            elif renamed:
991
 
                self.to_file.write("=== renamed %s '%s' => '%s'%s\n" %
992
 
                    (kind[0], oldpath_encoded, newpath_encoded, prop_str))
993
 
            else:
994
 
                # if it was produced by iter_changes, it must be
995
 
                # modified *somehow*, either content or execute bit.
996
 
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
997
 
                                   newpath_encoded, prop_str))
998
 
            if changed_content:
999
 
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
1000
 
                has_changes = 1
1001
 
            if renamed:
1002
 
                has_changes = 1
 
822
        for path, file_id, kind in delta.removed:
 
823
            has_changes = 1
 
824
            path_encoded = path.encode(self.path_encoding, "replace")
 
825
            self.to_file.write("=== removed %s '%s'\n" % (kind, path_encoded))
 
826
            self.diff(file_id, path, path)
 
827
 
 
828
        for path, file_id, kind in delta.added:
 
829
            has_changes = 1
 
830
            path_encoded = path.encode(self.path_encoding, "replace")
 
831
            self.to_file.write("=== added %s '%s'\n" % (kind, path_encoded))
 
832
            self.diff(file_id, path, path)
 
833
        for (old_path, new_path, file_id, kind,
 
834
             text_modified, meta_modified) in delta.renamed:
 
835
            has_changes = 1
 
836
            prop_str = get_prop_change(meta_modified)
 
837
            oldpath_encoded = old_path.encode(self.path_encoding, "replace")
 
838
            newpath_encoded = new_path.encode(self.path_encoding, "replace")
 
839
            self.to_file.write("=== renamed %s '%s' => '%s'%s\n" % (kind,
 
840
                                oldpath_encoded, newpath_encoded, prop_str))
 
841
            if text_modified:
 
842
                self.diff(file_id, old_path, new_path)
 
843
        for path, file_id, kind, text_modified, meta_modified in\
 
844
            delta.modified:
 
845
            has_changes = 1
 
846
            prop_str = get_prop_change(meta_modified)
 
847
            path_encoded = path.encode(self.path_encoding, "replace")
 
848
            self.to_file.write("=== modified %s '%s'%s\n" % (kind,
 
849
                                path_encoded, prop_str))
 
850
            # The file may be in a different location in the old tree (because
 
851
            # the containing dir was renamed, but the file itself was not)
 
852
            if text_modified:
 
853
                old_path = self.old_tree.id2path(file_id)
 
854
                self.diff(file_id, old_path, path)
1003
855
        return has_changes
1004
856
 
1005
857
    def diff(self, file_id, old_path, new_path):
1017
869
            new_kind = self.new_tree.kind(file_id)
1018
870
        except (errors.NoSuchId, errors.NoSuchFile):
1019
871
            new_kind = None
1020
 
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
1021
 
 
1022
 
 
1023
 
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
 
872
 
1024
873
        result = DiffPath._diff_many(self.differs, file_id, old_path,
1025
874
                                       new_path, old_kind, new_kind)
1026
875
        if result is DiffPath.CANNOT_DIFF:
1028
877
            if error_path is None:
1029
878
                error_path = old_path
1030
879
            raise errors.NoDiffFound(error_path)
1031
 
 
1032
 
 
1033
 
format_registry = Registry()
1034
 
format_registry.register('default', DiffTree)