~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Ian Clatworthy
  • Date: 2007-12-07 04:21:59 UTC
  • mto: This revision was merged to the branch mainline in revision 3092.
  • Revision ID: ian.clatworthy@internode.on.net-20071207042159-n9rmhanqid1l7olh
Better PDF for Qiock Start Card (Ian Clatworthy)

Show diffs side-by-side

added added

removed removed

Lines of Context:
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
import difflib
18
18
import os
19
19
import re
20
 
import shutil
21
20
import sys
22
21
 
23
22
from bzrlib.lazy_import import lazy_import
28
27
import time
29
28
 
30
29
from bzrlib import (
31
 
    branch as _mod_branch,
32
 
    bzrdir,
33
 
    commands,
34
30
    errors,
35
31
    osutils,
36
32
    patiencediff,
37
33
    textfile,
38
34
    timestamp,
39
 
    views,
40
35
    )
41
36
""")
42
37
 
43
38
from bzrlib.symbol_versioning import (
44
 
    deprecated_function,
45
 
    )
46
 
from bzrlib.trace import mutter, note, warning
 
39
        deprecated_function,
 
40
        )
 
41
from bzrlib.trace import mutter, warning
47
42
 
48
43
 
49
44
# TODO: Rather than building a changeset object, we should probably
78
73
    # both sequences are empty.
79
74
    if not oldlines and not newlines:
80
75
        return
81
 
 
 
76
    
82
77
    if allow_binary is False:
83
78
        textfile.check_text_lines(oldlines)
84
79
        textfile.check_text_lines(newlines)
99
94
        ud[2] = ud[2].replace('-1,0', '-0,0')
100
95
    elif not newlines:
101
96
        ud[2] = ud[2].replace('+1,0', '+0,0')
 
97
    # work around for difflib emitting random spaces after the label
 
98
    ud[0] = ud[0][:-2] + '\n'
 
99
    ud[1] = ud[1][:-2] + '\n'
102
100
 
103
101
    for line in ud:
104
102
        to_file.write(line)
171
169
 
172
170
        if not diff_opts:
173
171
            diff_opts = []
174
 
        if sys.platform == 'win32':
175
 
            # Popen doesn't do the proper encoding for external commands
176
 
            # Since we are dealing with an ANSI api, use mbcs encoding
177
 
            old_filename = old_filename.encode('mbcs')
178
 
            new_filename = new_filename.encode('mbcs')
179
172
        diffcmd = ['diff',
180
173
                   '--label', old_filename,
181
174
                   old_abspath,
204
197
            break
205
198
        else:
206
199
            diffcmd.append('-u')
207
 
 
 
200
                  
208
201
        if diff_opts:
209
202
            diffcmd.extend(diff_opts)
210
203
 
211
204
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
212
205
        out,err = pipe.communicate()
213
206
        rc = pipe.returncode
214
 
 
 
207
        
215
208
        # internal_diff() adds a trailing newline, add one here for consistency
216
209
        out += '\n'
217
210
        if rc == 2:
252
245
                msg = 'signal %d' % (-rc)
253
246
            else:
254
247
                msg = 'exit code %d' % rc
255
 
 
256
 
            raise errors.BzrError('external diff failed with %s; command: %r'
 
248
                
 
249
            raise errors.BzrError('external diff failed with %s; command: %r' 
257
250
                                  % (rc, diffcmd))
258
251
 
259
252
 
277
270
                        new_abspath, e)
278
271
 
279
272
 
280
 
def _get_trees_to_diff(path_list, revision_specs, old_url, new_url,
281
 
    apply_view=True):
282
 
    """Get the trees and specific files to diff given a list of paths.
283
 
 
284
 
    This method works out the trees to be diff'ed and the files of
285
 
    interest within those trees.
286
 
 
287
 
    :param path_list:
288
 
        the list of arguments passed to the diff command
289
 
    :param revision_specs:
290
 
        Zero, one or two RevisionSpecs from the diff command line,
291
 
        saying what revisions to compare.
292
 
    :param old_url:
293
 
        The url of the old branch or tree. If None, the tree to use is
294
 
        taken from the first path, if any, or the current working tree.
295
 
    :param new_url:
296
 
        The url of the new branch or tree. If None, the tree to use is
297
 
        taken from the first path, if any, or the current working tree.
298
 
    :param apply_view:
299
 
        if True and a view is set, apply the view or check that the paths
300
 
        are within it
301
 
    :returns:
302
 
        a tuple of (old_tree, new_tree, specific_files, extra_trees) where
303
 
        extra_trees is a sequence of additional trees to search in for
304
 
        file-ids.
 
273
def diff_cmd_helper(tree, specific_files, external_diff_options, 
 
274
                    old_revision_spec=None, new_revision_spec=None,
 
275
                    revision_specs=None,
 
276
                    old_label='a/', new_label='b/'):
 
277
    """Helper for cmd_diff.
 
278
 
 
279
    :param tree:
 
280
        A WorkingTree
 
281
 
 
282
    :param specific_files:
 
283
        The specific files to compare, or None
 
284
 
 
285
    :param external_diff_options:
 
286
        If non-None, run an external diff, and pass it these options
 
287
 
 
288
    :param old_revision_spec:
 
289
        If None, use basis tree as old revision, otherwise use the tree for
 
290
        the specified revision. 
 
291
 
 
292
    :param new_revision_spec:
 
293
        If None, use working tree as new revision, otherwise use the tree for
 
294
        the specified revision.
 
295
    
 
296
    :param revision_specs: 
 
297
        Zero, one or two RevisionSpecs from the command line, saying what revisions 
 
298
        to compare.  This can be passed as an alternative to the old_revision_spec 
 
299
        and new_revision_spec parameters.
 
300
 
 
301
    The more general form is show_diff_trees(), where the caller
 
302
    supplies any two trees.
305
303
    """
306
 
    # Get the old and new revision specs
307
 
    old_revision_spec = None
308
 
    new_revision_spec = None
 
304
 
 
305
    # TODO: perhaps remove the old parameters old_revision_spec and
 
306
    # new_revision_spec, since this is only really for use from cmd_diff and
 
307
    # it now always passes through a sequence of revision_specs -- mbp
 
308
    # 20061221
 
309
 
 
310
    def spec_tree(spec):
 
311
        if tree:
 
312
            revision = spec.in_store(tree.branch)
 
313
        else:
 
314
            revision = spec.in_store(None)
 
315
        revision_id = revision.rev_id
 
316
        branch = revision.branch
 
317
        return branch.repository.revision_tree(revision_id)
 
318
 
309
319
    if revision_specs is not None:
 
320
        assert (old_revision_spec is None
 
321
                and new_revision_spec is None)
310
322
        if len(revision_specs) > 0:
311
323
            old_revision_spec = revision_specs[0]
312
 
            if old_url is None:
313
 
                old_url = old_revision_spec.get_branch()
314
324
        if len(revision_specs) > 1:
315
325
            new_revision_spec = revision_specs[1]
316
 
            if new_url is None:
317
 
                new_url = new_revision_spec.get_branch()
318
 
 
319
 
    other_paths = []
320
 
    make_paths_wt_relative = True
321
 
    consider_relpath = True
322
 
    if path_list is None or len(path_list) == 0:
323
 
        # If no path is given, the current working tree is used
324
 
        default_location = u'.'
325
 
        consider_relpath = False
326
 
    elif old_url is not None and new_url is not None:
327
 
        other_paths = path_list
328
 
        make_paths_wt_relative = False
329
 
    else:
330
 
        default_location = path_list[0]
331
 
        other_paths = path_list[1:]
332
 
 
333
 
    # Get the old location
334
 
    specific_files = []
335
 
    if old_url is None:
336
 
        old_url = default_location
337
 
    working_tree, branch, relpath = \
338
 
        bzrdir.BzrDir.open_containing_tree_or_branch(old_url)
339
 
    if consider_relpath and relpath != '':
340
 
        if working_tree is not None and apply_view:
341
 
            views.check_path_in_view(working_tree, relpath)
342
 
        specific_files.append(relpath)
343
 
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
344
 
 
345
 
    # Get the new location
346
 
    if new_url is None:
347
 
        new_url = default_location
348
 
    if new_url != old_url:
349
 
        working_tree, branch, relpath = \
350
 
            bzrdir.BzrDir.open_containing_tree_or_branch(new_url)
351
 
        if consider_relpath and relpath != '':
352
 
            if working_tree is not None and apply_view:
353
 
                views.check_path_in_view(working_tree, relpath)
354
 
            specific_files.append(relpath)
355
 
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
356
 
        basis_is_default=working_tree is None)
357
 
 
358
 
    # Get the specific files (all files is None, no files is [])
359
 
    if make_paths_wt_relative and working_tree is not None:
360
 
        try:
361
 
            from bzrlib.builtins import safe_relpath_files
362
 
            other_paths = safe_relpath_files(working_tree, other_paths,
363
 
            apply_view=apply_view)
364
 
        except errors.FileInWrongBranch:
365
 
            raise errors.BzrCommandError("Files are in different branches")
366
 
    specific_files.extend(other_paths)
367
 
    if len(specific_files) == 0:
368
 
        specific_files = None
369
 
        if (working_tree is not None and working_tree.supports_views()
370
 
            and apply_view):
371
 
            view_files = working_tree.views.lookup_view()
372
 
            if view_files:
373
 
                specific_files = view_files
374
 
                view_str = views.view_display_str(view_files)
375
 
                note("*** Ignoring files outside view. View is %s" % view_str)
376
 
 
377
 
    # Get extra trees that ought to be searched for file-ids
378
 
    extra_trees = None
379
 
    if working_tree is not None and working_tree not in (old_tree, new_tree):
380
 
        extra_trees = (working_tree,)
381
 
    return old_tree, new_tree, specific_files, extra_trees
382
 
 
383
 
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
384
 
    if branch is None and tree is not None:
385
 
        branch = tree.branch
386
 
    if spec is None or spec.spec is None:
387
 
        if basis_is_default:
388
 
            if tree is not None:
389
 
                return tree.basis_tree()
390
 
            else:
391
 
                return branch.basis_tree()
392
 
        else:
393
 
            return tree
394
 
    return spec.as_tree(branch)
 
326
 
 
327
    if old_revision_spec is None:
 
328
        old_tree = tree.basis_tree()
 
329
    else:
 
330
        old_tree = spec_tree(old_revision_spec)
 
331
 
 
332
    if (new_revision_spec is None
 
333
        or new_revision_spec.spec is None):
 
334
        new_tree = tree
 
335
    else:
 
336
        new_tree = spec_tree(new_revision_spec)
 
337
 
 
338
    if new_tree is not tree:
 
339
        extra_trees = (tree,)
 
340
    else:
 
341
        extra_trees = None
 
342
 
 
343
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
 
344
                           external_diff_options,
 
345
                           old_label=old_label, new_label=new_label,
 
346
                           extra_trees=extra_trees)
395
347
 
396
348
 
397
349
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
398
350
                    external_diff_options=None,
399
351
                    old_label='a/', new_label='b/',
400
352
                    extra_trees=None,
401
 
                    path_encoding='utf8',
402
 
                    using=None):
 
353
                    path_encoding='utf8'):
403
354
    """Show in text form the changes from one tree to another.
404
355
 
405
 
    to_file
406
 
        The output stream.
407
 
 
408
 
    specific_files
409
 
        Include only changes to these files - None for all changes.
 
356
    to_files
 
357
        If set, include only changes to these files.
410
358
 
411
359
    external_diff_options
412
360
        If set, use an external GNU diff and pass these options.
426
374
        new_tree.lock_read()
427
375
        try:
428
376
            differ = DiffTree.from_trees_options(old_tree, new_tree, to_file,
429
 
                                                 path_encoding,
430
 
                                                 external_diff_options,
431
 
                                                 old_label, new_label, using)
 
377
                                                   path_encoding,
 
378
                                                   external_diff_options,
 
379
                                                   old_label, new_label)
432
380
            return differ.show_diff(specific_files, extra_trees)
433
381
        finally:
434
382
            new_tree.unlock()
442
390
def _patch_header_date(tree, file_id, path):
443
391
    """Returns a timestamp suitable for use in a patch header."""
444
392
    mtime = tree.get_file_mtime(file_id, path)
 
393
    assert mtime is not None, \
 
394
        "got an mtime of None for file-id %s, path %s in tree %s" % (
 
395
                file_id, path, tree)
445
396
    return timestamp.format_patch_date(mtime)
446
397
 
447
398
 
448
 
def get_executable_change(old_is_x, new_is_x):
449
 
    descr = { True:"+x", False:"-x", None:"??" }
450
 
    if old_is_x != new_is_x:
451
 
        return ["%s to %s" % (descr[old_is_x], descr[new_is_x],)]
 
399
def _raise_if_nonexistent(paths, old_tree, new_tree):
 
400
    """Complain if paths are not in either inventory or tree.
 
401
 
 
402
    It's OK with the files exist in either tree's inventory, or 
 
403
    if they exist in the tree but are not versioned.
 
404
    
 
405
    This can be used by operations such as bzr status that can accept
 
406
    unknown or ignored files.
 
407
    """
 
408
    mutter("check paths: %r", paths)
 
409
    if not paths:
 
410
        return
 
411
    s = old_tree.filter_unversioned_files(paths)
 
412
    s = new_tree.filter_unversioned_files(s)
 
413
    s = [path for path in s if not new_tree.has_filename(path)]
 
414
    if s:
 
415
        raise errors.PathsDoNotExist(sorted(s))
 
416
 
 
417
 
 
418
def get_prop_change(meta_modified):
 
419
    if meta_modified:
 
420
        return " (properties changed)"
452
421
    else:
453
 
        return []
 
422
        return  ""
454
423
 
455
424
 
456
425
class DiffPath(object):
476
445
        self.to_file = to_file
477
446
        self.path_encoding = path_encoding
478
447
 
479
 
    def finish(self):
480
 
        pass
481
 
 
482
448
    @classmethod
483
449
    def from_diff_tree(klass, diff_tree):
484
450
        return klass(diff_tree.old_tree, diff_tree.new_tree,
504
470
    def __init__(self, differs):
505
471
        self.differs = differs
506
472
 
507
 
    def finish(self):
508
 
        pass
509
 
 
510
473
    @classmethod
511
474
    def from_diff_tree(klass, diff_tree):
512
475
        return klass(diff_tree.differs)
625
588
            return self.CANNOT_DIFF
626
589
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
627
590
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
628
 
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
629
 
            old_path, new_path)
 
591
        return self.diff_text(from_file_id, to_file_id, from_label, to_label)
630
592
 
631
 
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
632
 
        from_path=None, to_path=None):
 
593
    def diff_text(self, from_file_id, to_file_id, from_label, to_label):
633
594
        """Diff the content of given files in two trees
634
595
 
635
596
        :param from_file_id: The id of the file in the from tree.  If None,
637
598
        :param to_file_id: The id of the file in the to tree.  This may refer
638
599
            to a different file from from_file_id.  If None,
639
600
            the file is not present in the to tree.
640
 
        :param from_path: The path in the from tree or None if unknown.
641
 
        :param to_path: The path in the to tree or None if unknown.
642
601
        """
643
 
        def _get_text(tree, file_id, path):
 
602
        def _get_text(tree, file_id):
644
603
            if file_id is not None:
645
 
                return tree.get_file(file_id, path).readlines()
 
604
                return tree.get_file(file_id).readlines()
646
605
            else:
647
606
                return []
648
607
        try:
649
 
            from_text = _get_text(self.old_tree, from_file_id, from_path)
650
 
            to_text = _get_text(self.new_tree, to_file_id, to_path)
 
608
            from_text = _get_text(self.old_tree, from_file_id)
 
609
            to_text = _get_text(self.new_tree, to_file_id)
651
610
            self.text_differ(from_label, from_text, to_label, to_text,
652
611
                             self.to_file)
653
612
        except errors.BinaryFile:
657
616
        return self.CHANGED
658
617
 
659
618
 
660
 
class DiffFromTool(DiffPath):
661
 
 
662
 
    def __init__(self, command_template, old_tree, new_tree, to_file,
663
 
                 path_encoding='utf-8'):
664
 
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
665
 
        self.command_template = command_template
666
 
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
667
 
 
668
 
    @classmethod
669
 
    def from_string(klass, command_string, old_tree, new_tree, to_file,
670
 
                    path_encoding='utf-8'):
671
 
        command_template = commands.shlex_split_unicode(command_string)
672
 
        command_template.extend(['%(old_path)s', '%(new_path)s'])
673
 
        return klass(command_template, old_tree, new_tree, to_file,
674
 
                     path_encoding)
675
 
 
676
 
    @classmethod
677
 
    def make_from_diff_tree(klass, command_string):
678
 
        def from_diff_tree(diff_tree):
679
 
            return klass.from_string(command_string, diff_tree.old_tree,
680
 
                                     diff_tree.new_tree, diff_tree.to_file)
681
 
        return from_diff_tree
682
 
 
683
 
    def _get_command(self, old_path, new_path):
684
 
        my_map = {'old_path': old_path, 'new_path': new_path}
685
 
        return [t % my_map for t in self.command_template]
686
 
 
687
 
    def _execute(self, old_path, new_path):
688
 
        command = self._get_command(old_path, new_path)
689
 
        try:
690
 
            proc = subprocess.Popen(command, stdout=subprocess.PIPE,
691
 
                                    cwd=self._root)
692
 
        except OSError, e:
693
 
            if e.errno == errno.ENOENT:
694
 
                raise errors.ExecutableMissing(command[0])
695
 
            else:
696
 
                raise
697
 
        self.to_file.write(proc.stdout.read())
698
 
        return proc.wait()
699
 
 
700
 
    def _try_symlink_root(self, tree, prefix):
701
 
        if (getattr(tree, 'abspath', None) is None
702
 
            or not osutils.host_os_dereferences_symlinks()):
703
 
            return False
704
 
        try:
705
 
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
706
 
        except OSError, e:
707
 
            if e.errno != errno.EEXIST:
708
 
                raise
709
 
        return True
710
 
 
711
 
    def _write_file(self, file_id, tree, prefix, relpath):
712
 
        full_path = osutils.pathjoin(self._root, prefix, relpath)
713
 
        if self._try_symlink_root(tree, prefix):
714
 
            return full_path
715
 
        parent_dir = osutils.dirname(full_path)
716
 
        try:
717
 
            os.makedirs(parent_dir)
718
 
        except OSError, e:
719
 
            if e.errno != errno.EEXIST:
720
 
                raise
721
 
        source = tree.get_file(file_id, relpath)
722
 
        try:
723
 
            target = open(full_path, 'wb')
724
 
            try:
725
 
                osutils.pumpfile(source, target)
726
 
            finally:
727
 
                target.close()
728
 
        finally:
729
 
            source.close()
730
 
        osutils.make_readonly(full_path)
731
 
        mtime = tree.get_file_mtime(file_id)
732
 
        os.utime(full_path, (mtime, mtime))
733
 
        return full_path
734
 
 
735
 
    def _prepare_files(self, file_id, old_path, new_path):
736
 
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
737
 
                                         old_path)
738
 
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
739
 
                                         new_path)
740
 
        return old_disk_path, new_disk_path
741
 
 
742
 
    def finish(self):
743
 
        try:
744
 
            osutils.rmtree(self._root)
745
 
        except OSError, e:
746
 
            if e.errno != errno.ENOENT:
747
 
                mutter("The temporary directory \"%s\" was not "
748
 
                        "cleanly removed: %s." % (self._root, e))
749
 
 
750
 
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
751
 
        if (old_kind, new_kind) != ('file', 'file'):
752
 
            return DiffPath.CANNOT_DIFF
753
 
        self._prepare_files(file_id, old_path, new_path)
754
 
        self._execute(osutils.pathjoin('old', old_path),
755
 
                      osutils.pathjoin('new', new_path))
756
 
 
757
 
 
758
619
class DiffTree(object):
759
620
    """Provides textual representations of the difference between two trees.
760
621
 
800
661
    @classmethod
801
662
    def from_trees_options(klass, old_tree, new_tree, to_file,
802
663
                           path_encoding, external_diff_options, old_label,
803
 
                           new_label, using):
 
664
                           new_label):
804
665
        """Factory for producing a DiffTree.
805
666
 
806
667
        Designed to accept options used by show_diff_trees.
812
673
            binary to perform file comparison, using supplied options.
813
674
        :param old_label: Prefix to use for old file labels
814
675
        :param new_label: Prefix to use for new file labels
815
 
        :param using: Commandline to use to invoke an external diff tool
816
676
        """
817
 
        if using is not None:
818
 
            extra_factories = [DiffFromTool.make_from_diff_tree(using)]
819
 
        else:
820
 
            extra_factories = []
821
677
        if external_diff_options:
 
678
            assert isinstance(external_diff_options, basestring)
822
679
            opts = external_diff_options.split()
823
680
            def diff_file(olab, olines, nlab, nlines, to_file):
824
681
                external_diff(olab, olines, nlab, nlines, to_file, opts)
826
683
            diff_file = internal_diff
827
684
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
828
685
                             old_label, new_label, diff_file)
829
 
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
830
 
                     extra_factories)
 
686
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text)
831
687
 
832
688
    def show_diff(self, specific_files, extra_trees=None):
833
689
        """Write tree diff to self.to_file
835
691
        :param sepecific_files: the specific files to compare (recursive)
836
692
        :param extra_trees: extra trees to use for mapping paths to file_ids
837
693
        """
838
 
        try:
839
 
            return self._show_diff(specific_files, extra_trees)
840
 
        finally:
841
 
            for differ in self.differs:
842
 
                differ.finish()
843
 
 
844
 
    def _show_diff(self, specific_files, extra_trees):
845
694
        # TODO: Generation of pseudo-diffs for added/deleted files could
846
695
        # be usefully made into a much faster special case.
847
 
        iterator = self.new_tree.iter_changes(self.old_tree,
848
 
                                               specific_files=specific_files,
849
 
                                               extra_trees=extra_trees,
850
 
                                               require_versioned=True)
 
696
 
 
697
        delta = self.new_tree.changes_from(self.old_tree,
 
698
            specific_files=specific_files,
 
699
            extra_trees=extra_trees, require_versioned=True)
 
700
 
851
701
        has_changes = 0
852
 
        def changes_key(change):
853
 
            old_path, new_path = change[1]
854
 
            path = new_path
855
 
            if path is None:
856
 
                path = old_path
857
 
            return path
858
 
        def get_encoded_path(path):
859
 
            if path is not None:
860
 
                return path.encode(self.path_encoding, "replace")
861
 
        for (file_id, paths, changed_content, versioned, parent, name, kind,
862
 
             executable) in sorted(iterator, key=changes_key):
863
 
            # The root does not get diffed, and items with no known kind (that
864
 
            # is, missing) in both trees are skipped as well.
865
 
            if parent == (None, None) or kind == (None, None):
866
 
                continue
867
 
            oldpath, newpath = paths
868
 
            oldpath_encoded = get_encoded_path(paths[0])
869
 
            newpath_encoded = get_encoded_path(paths[1])
870
 
            old_present = (kind[0] is not None and versioned[0])
871
 
            new_present = (kind[1] is not None and versioned[1])
872
 
            renamed = (parent[0], name[0]) != (parent[1], name[1])
873
 
 
874
 
            properties_changed = []
875
 
            properties_changed.extend(get_executable_change(executable[0], executable[1]))
876
 
 
877
 
            if properties_changed:
878
 
                prop_str = " (properties changed: %s)" % (", ".join(properties_changed),)
879
 
            else:
880
 
                prop_str = ""
881
 
 
882
 
            if (old_present, new_present) == (True, False):
883
 
                self.to_file.write("=== removed %s '%s'\n" %
884
 
                                   (kind[0], oldpath_encoded))
885
 
                newpath = oldpath
886
 
            elif (old_present, new_present) == (False, True):
887
 
                self.to_file.write("=== added %s '%s'\n" %
888
 
                                   (kind[1], newpath_encoded))
889
 
                oldpath = newpath
890
 
            elif renamed:
891
 
                self.to_file.write("=== renamed %s '%s' => '%s'%s\n" %
892
 
                    (kind[0], oldpath_encoded, newpath_encoded, prop_str))
893
 
            else:
894
 
                # if it was produced by iter_changes, it must be
895
 
                # modified *somehow*, either content or execute bit.
896
 
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
897
 
                                   newpath_encoded, prop_str))
898
 
            if changed_content:
899
 
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
900
 
                has_changes = 1
901
 
            if renamed:
902
 
                has_changes = 1
 
702
        for path, file_id, kind in delta.removed:
 
703
            has_changes = 1
 
704
            path_encoded = path.encode(self.path_encoding, "replace")
 
705
            self.to_file.write("=== removed %s '%s'\n" % (kind, path_encoded))
 
706
            self.diff(file_id, path, path)
 
707
 
 
708
        for path, file_id, kind in delta.added:
 
709
            has_changes = 1
 
710
            path_encoded = path.encode(self.path_encoding, "replace")
 
711
            self.to_file.write("=== added %s '%s'\n" % (kind, path_encoded))
 
712
            self.diff(file_id, path, path)
 
713
        for (old_path, new_path, file_id, kind,
 
714
             text_modified, meta_modified) in delta.renamed:
 
715
            has_changes = 1
 
716
            prop_str = get_prop_change(meta_modified)
 
717
            oldpath_encoded = old_path.encode(self.path_encoding, "replace")
 
718
            newpath_encoded = new_path.encode(self.path_encoding, "replace")
 
719
            self.to_file.write("=== renamed %s '%s' => '%s'%s\n" % (kind,
 
720
                                oldpath_encoded, newpath_encoded, prop_str))
 
721
            if text_modified:
 
722
                self.diff(file_id, old_path, new_path)
 
723
        for path, file_id, kind, text_modified, meta_modified in\
 
724
            delta.modified:
 
725
            has_changes = 1
 
726
            prop_str = get_prop_change(meta_modified)
 
727
            path_encoded = path.encode(self.path_encoding, "replace")
 
728
            self.to_file.write("=== modified %s '%s'%s\n" % (kind,
 
729
                                path_encoded, prop_str))
 
730
            # The file may be in a different location in the old tree (because
 
731
            # the containing dir was renamed, but the file itself was not)
 
732
            if text_modified:
 
733
                old_path = self.old_tree.id2path(file_id)
 
734
                self.diff(file_id, old_path, path)
903
735
        return has_changes
904
736
 
905
737
    def diff(self, file_id, old_path, new_path):
917
749
            new_kind = self.new_tree.kind(file_id)
918
750
        except (errors.NoSuchId, errors.NoSuchFile):
919
751
            new_kind = None
920
 
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
921
 
 
922
 
 
923
 
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
 
752
 
924
753
        result = DiffPath._diff_many(self.differs, file_id, old_path,
925
754
                                       new_path, old_kind, new_kind)
926
755
        if result is DiffPath.CANNOT_DIFF: