219
216
self.assertEqual([], self._logged_reports)
218
def test_32_lock_wait_succeed(self):
219
"""Succeed when trying to acquire a lock that gets released
221
One thread holds on a lock and then releases it; another
224
# This test sometimes fails like this:
225
# Traceback (most recent call last):
227
# File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
228
# test_lockdir.py", line 247, in test_32_lock_wait_succeed
229
# self.assertEqual(1, len(self._logged_reports))
230
# AssertionError: not equal:
233
raise tests.TestSkipped("Test fails intermittently")
234
t = self.get_transport()
235
lf1 = LockDir(t, 'test_lock')
239
def wait_and_unlock():
242
unlocker = Thread(target=wait_and_unlock)
245
lf2 = LockDir(t, 'test_lock')
246
self.setup_log_reporter(lf2)
249
lf2.wait_lock(timeout=0.4, poll=0.1)
251
self.assertTrue(after - before <= 1.0)
255
# There should be only 1 report, even though it should have to
257
lock_base = lf2.transport.abspath(lf2.path)
258
self.assertEqual(1, len(self._logged_reports))
259
self.assertEqual('%s %s\n'
261
'Will continue to try until %s\n',
262
self._logged_reports[0][0])
263
args = self._logged_reports[0][1]
264
self.assertEqual('Unable to obtain', args[0])
265
self.assertEqual('lock %s' % (lock_base,), args[1])
266
self.assertStartsWith(args[2], 'held by ')
267
self.assertStartsWith(args[3], 'locked ')
268
self.assertEndsWith(args[3], ' ago')
269
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
271
def test_34_lock_write_waits(self):
272
"""LockDir.lock_write() will wait for the lock."""
273
# the test suite sets the default to 0 to make deadlocks fail fast.
274
# change it for this test, as we want to try a manual deadlock.
275
bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
276
t = self.get_transport()
277
lf1 = LockDir(t, 'test_lock')
281
def wait_and_unlock():
284
unlocker = Thread(target=wait_and_unlock)
287
lf2 = LockDir(t, 'test_lock')
288
self.setup_log_reporter(lf2)
296
# There should be only 1 report, even though it should have to
298
lock_base = lf2.transport.abspath(lf2.path)
299
self.assertEqual(1, len(self._logged_reports))
300
self.assertEqual('%s %s\n'
302
'Will continue to try until %s\n',
303
self._logged_reports[0][0])
304
args = self._logged_reports[0][1]
305
self.assertEqual('Unable to obtain', args[0])
306
self.assertEqual('lock %s' % (lock_base,), args[1])
307
self.assertStartsWith(args[2], 'held by ')
308
self.assertStartsWith(args[3], 'locked ')
309
self.assertEndsWith(args[3], ' ago')
310
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
312
def test_35_wait_lock_changing(self):
313
"""LockDir.wait_lock() will report if the lock changes underneath.
315
This is the stages we want to happen:
317
0) Synchronization locks are created and locked.
318
1) Lock1 obtains the lockdir, and releases the 'check' lock.
319
2) Lock2 grabs the 'check' lock, and checks the lockdir.
320
It sees the lockdir is already acquired, reports the fact,
321
and unsets the 'checked' lock.
322
3) Thread1 blocks on acquiring the 'checked' lock, and then tells
323
Lock1 to release and acquire the lockdir. This resets the 'check'
325
4) Lock2 acquires the 'check' lock, and checks again. It notices
326
that the holder of the lock has changed, and so reports a new
328
5) Thread1 blocks on the 'checked' lock, this time, it completely
329
unlocks the lockdir, allowing Lock2 to acquire the lock.
332
wait_to_check_lock = Lock()
333
wait_until_checked_lock = Lock()
335
wait_to_check_lock.acquire()
336
wait_until_checked_lock.acquire()
337
note('locked check and checked locks')
339
class LockDir1(LockDir):
340
"""Use the synchronization points for the first lock."""
342
def attempt_lock(self):
343
# Once we have acquired the lock, it is okay for
344
# the other lock to check it
346
return super(LockDir1, self).attempt_lock()
348
note('lock1: releasing check lock')
349
wait_to_check_lock.release()
351
class LockDir2(LockDir):
352
"""Use the synchronization points for the second lock."""
354
def attempt_lock(self):
355
note('lock2: waiting for check lock')
356
wait_to_check_lock.acquire()
357
note('lock2: acquired check lock')
359
return super(LockDir2, self).attempt_lock()
361
note('lock2: releasing checked lock')
362
wait_until_checked_lock.release()
364
t = self.get_transport()
365
lf1 = LockDir1(t, 'test_lock')
368
lf2 = LockDir2(t, 'test_lock')
369
self.setup_log_reporter(lf2)
371
def wait_and_switch():
373
# Block until lock2 has had a chance to check
374
note('lock1: waiting 1 for checked lock')
375
wait_until_checked_lock.acquire()
376
note('lock1: acquired for checked lock')
377
note('lock1: released lockdir')
379
note('lock1: acquiring lockdir')
380
# Create a new nonce, so the lock looks different.
381
lf1.nonce = osutils.rand_chars(20)
383
note('lock1: acquired lockdir')
385
# Block until lock2 has peeked again
386
note('lock1: waiting 2 for checked lock')
387
wait_until_checked_lock.acquire()
388
note('lock1: acquired for checked lock')
389
# Now unlock, and let lock 2 grab the lock
391
wait_to_check_lock.release()
393
unlocker = Thread(target=wait_and_switch)
396
# Wait and play against the other thread
397
lf2.wait_lock(timeout=1.0, poll=0.01)
402
# There should be 2 reports, because the lock changed
403
lock_base = lf2.transport.abspath(lf2.path)
404
self.assertEqual(2, len(self._logged_reports))
406
self.assertEqual('%s %s\n'
408
'Will continue to try until %s\n',
409
self._logged_reports[0][0])
410
args = self._logged_reports[0][1]
411
self.assertEqual('Unable to obtain', args[0])
412
self.assertEqual('lock %s' % (lock_base,), args[1])
413
self.assertStartsWith(args[2], 'held by ')
414
self.assertStartsWith(args[3], 'locked ')
415
self.assertEndsWith(args[3], ' ago')
416
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
418
self.assertEqual('%s %s\n'
420
'Will continue to try until %s\n',
421
self._logged_reports[1][0])
422
args = self._logged_reports[1][1]
423
self.assertEqual('Lock owner changed for', args[0])
424
self.assertEqual('lock %s' % (lock_base,), args[1])
425
self.assertStartsWith(args[2], 'held by ')
426
self.assertStartsWith(args[3], 'locked ')
427
self.assertEndsWith(args[3], ' ago')
428
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
221
430
def test_40_confirm_easy(self):
222
431
"""Confirm a lock that's already held"""
223
432
t = self.get_transport()
224
433
lf1 = LockDir(t, 'test_lock')
226
435
lf1.attempt_lock()
227
self.addCleanup(lf1.unlock)
230
438
def test_41_confirm_not_held(self):
332
535
# do this without IO redirection to ensure it doesn't prompt.
333
536
self.assertRaises(AssertionError, ld1.break_lock)
334
537
orig_factory = bzrlib.ui.ui_factory
335
bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
538
# silent ui - no need for stdout
539
bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
540
bzrlib.ui.ui_factory.stdin = StringIO("y\n")
338
543
self.assertRaises(LockBroken, ld1.unlock)
340
545
bzrlib.ui.ui_factory = orig_factory
342
def test_break_lock_corrupt_info(self):
343
"""break_lock works even if the info file is corrupt (and tells the UI
347
ld2 = self.get_lock()
350
ld.transport.put_bytes_non_atomic('test_lock/held/info', '\0')
352
class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
356
def get_boolean(self, prompt):
357
self.prompts.append(('boolean', prompt))
360
ui = LoggingUIFactory()
361
self.overrideAttr(bzrlib.ui, 'ui_factory', ui)
363
self.assertLength(1, ui.prompts)
364
self.assertEqual('boolean', ui.prompts[0][0])
365
self.assertStartsWith(ui.prompts[0][1], 'Break (corrupt LockDir')
366
self.assertRaises(LockBroken, ld.unlock)
368
def test_break_lock_missing_info(self):
369
"""break_lock works even if the info file is missing (and tells the UI
373
ld2 = self.get_lock()
376
ld.transport.delete('test_lock/held/info')
378
class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
382
def get_boolean(self, prompt):
383
self.prompts.append(('boolean', prompt))
386
ui = LoggingUIFactory()
387
orig_factory = bzrlib.ui.ui_factory
388
bzrlib.ui.ui_factory = ui
391
self.assertRaises(LockBroken, ld.unlock)
392
self.assertLength(0, ui.prompts)
394
bzrlib.ui.ui_factory = orig_factory
395
# Suppress warnings due to ld not being unlocked
396
# XXX: if lock_broken hook was invoked in this case, this hack would
397
# not be necessary. - Andrew Bennetts, 2010-09-06.
398
del self._lock_actions[:]
400
547
def test_create_missing_base_directory(self):
401
548
"""If LockDir.path doesn't exist, it can be created
485
631
# should be nothing before we start
487
633
t = self.get_transport().clone('test_lock')
489
634
def check_dir(a):
490
635
self.assertEquals(a, t.list_dir('.'))
493
637
# when held, that's all we see
494
638
ld1.attempt_lock()
495
self.addCleanup(ld1.unlock)
496
639
check_dir(['held'])
497
640
# second guy should fail
498
641
self.assertRaises(errors.LockContention, ld2.attempt_lock)
500
643
check_dir(['held'])
502
def test_no_lockdir_info(self):
503
"""We can cope with empty info files."""
504
# This seems like a fairly common failure case - see
505
# <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
506
# Processes are often interrupted after opening the file
507
# before the actual contents are committed.
508
t = self.get_transport()
510
t.mkdir('test_lock/held')
511
t.put_bytes('test_lock/held/info', '')
512
lf = LockDir(t, 'test_lock')
514
formatted_info = info.to_readable_dict()
516
dict(user='<unknown>', hostname='<unknown>', pid='<unknown>',
517
time_ago='(unknown)'),
520
def test_corrupt_lockdir_info(self):
521
"""We can cope with corrupt (and thus unparseable) info files."""
522
# This seems like a fairly common failure case too - see
523
# <https://bugs.launchpad.net/bzr/+bug/619872> for instance.
524
# In particular some systems tend to fill recently created files with
525
# nul bytes after recovering from a system crash.
526
t = self.get_transport()
528
t.mkdir('test_lock/held')
529
t.put_bytes('test_lock/held/info', '\0')
530
lf = LockDir(t, 'test_lock')
531
self.assertRaises(errors.LockCorrupt, lf.peek)
532
# Currently attempt_lock gives LockContention, but LockCorrupt would be
533
# a reasonable result too.
535
(errors.LockCorrupt, errors.LockContention), lf.attempt_lock)
536
self.assertRaises(errors.LockCorrupt, lf.validate_token, 'fake token')
538
def test_missing_lockdir_info(self):
539
"""We can cope with absent info files."""
540
t = self.get_transport()
542
t.mkdir('test_lock/held')
543
lf = LockDir(t, 'test_lock')
544
# In this case we expect the 'not held' result from peek, because peek
545
# cannot be expected to notice that there is a 'held' directory with no
547
self.assertEqual(None, lf.peek())
548
# And lock/unlock may work or give LockContention (but not any other
552
except LockContention:
553
# LockContention is ok, and expected on Windows
556
# no error is ok, and expected on POSIX (because POSIX allows
557
# os.rename over an empty directory).
559
# Currently raises TokenMismatch, but LockCorrupt would be reasonable
562
(errors.TokenMismatch, errors.LockCorrupt),
563
lf.validate_token, 'fake token')
566
class TestLockDirHooks(TestCaseWithTransport):
569
super(TestLockDirHooks, self).setUp()
573
return LockDir(self.get_transport(), 'test_lock')
575
def record_hook(self, result):
576
self._calls.append(result)
578
def test_LockDir_acquired_success(self):
579
# the LockDir.lock_acquired hook fires when a lock is acquired.
580
LockDir.hooks.install_named_hook('lock_acquired',
581
self.record_hook, 'record_hook')
584
self.assertEqual([], self._calls)
585
result = ld.attempt_lock()
586
lock_path = ld.transport.abspath(ld.path)
587
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
589
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
591
def test_LockDir_acquired_fail(self):
592
# the LockDir.lock_acquired hook does not fire on failure.
595
ld2 = self.get_lock()
597
# install a lock hook now, when the disk lock is locked
598
LockDir.hooks.install_named_hook('lock_acquired',
599
self.record_hook, 'record_hook')
600
self.assertRaises(errors.LockContention, ld.attempt_lock)
601
self.assertEqual([], self._calls)
603
self.assertEqual([], self._calls)
605
def test_LockDir_released_success(self):
606
# the LockDir.lock_released hook fires when a lock is acquired.
607
LockDir.hooks.install_named_hook('lock_released',
608
self.record_hook, 'record_hook')
611
self.assertEqual([], self._calls)
612
result = ld.attempt_lock()
613
self.assertEqual([], self._calls)
615
lock_path = ld.transport.abspath(ld.path)
616
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
618
def test_LockDir_released_fail(self):
619
# the LockDir.lock_released hook does not fire on failure.
622
ld2 = self.get_lock()
624
ld2.force_break(ld2.peek())
625
LockDir.hooks.install_named_hook('lock_released',
626
self.record_hook, 'record_hook')
627
self.assertRaises(LockBroken, ld.unlock)
628
self.assertEqual([], self._calls)
630
def test_LockDir_broken_success(self):
631
# the LockDir.lock_broken hook fires when a lock is broken.
634
ld2 = self.get_lock()
635
result = ld.attempt_lock()
636
LockDir.hooks.install_named_hook('lock_broken',
637
self.record_hook, 'record_hook')
638
ld2.force_break(ld2.peek())
639
lock_path = ld.transport.abspath(ld.path)
640
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
642
def test_LockDir_broken_failure(self):
643
# the LockDir.lock_broken hook does not fires when a lock is already
647
ld2 = self.get_lock()
648
result = ld.attempt_lock()
649
holder_info = ld2.peek()
651
LockDir.hooks.install_named_hook('lock_broken',
652
self.record_hook, 'record_hook')
653
ld2.force_break(holder_info)
654
lock_path = ld.transport.abspath(ld.path)
655
self.assertEqual([], self._calls)
658
class TestLockHeldInfo(TestCase):
659
"""Can get information about the lock holder, and detect whether they're
663
info = LockHeldInfo.for_this_process(None)
664
self.assertContainsRe(repr(info), r"LockHeldInfo\(.*\)")
666
def test_unicode(self):
667
info = LockHeldInfo.for_this_process(None)
668
self.assertContainsRe(unicode(info),
669
r'held by .* on .* \(process #\d+\), acquired .* ago')
671
def test_is_locked_by_this_process(self):
672
info = LockHeldInfo.for_this_process(None)
673
self.assertTrue(info.is_locked_by_this_process())
675
def test_is_not_locked_by_this_process(self):
676
info = LockHeldInfo.for_this_process(None)
677
info.info_dict['pid'] = '123123123123123'
678
self.assertFalse(info.is_locked_by_this_process())
680
def test_lock_holder_live_process(self):
681
"""Detect that the holder (this process) is still running."""
682
info = LockHeldInfo.for_this_process(None)
683
self.assertFalse(info.is_lock_holder_known_dead())
685
def test_lock_holder_dead_process(self):
686
"""Detect that the holder (this process) is still running."""
687
info = LockHeldInfo.for_this_process(None)
688
info.info_dict['pid'] = '123123123'
689
if sys.platform == 'win32':
691
'live lock holder detection not implemented yet on win32')
692
self.assertTrue(info.is_lock_holder_known_dead())
694
def test_lock_holder_other_machine(self):
695
"""The lock holder isn't here so we don't know if they're alive."""
696
info = LockHeldInfo.for_this_process(None)
697
info.info_dict['hostname'] = 'egg.example.com'
698
info.info_dict['pid'] = '123123123'
699
self.assertFalse(info.is_lock_holder_known_dead())
701
def test_lock_holder_other_user(self):
702
"""Only auto-break locks held by this user."""
703
info = LockHeldInfo.for_this_process(None)
704
info.info_dict['user'] = 'notme@example.com'
705
info.info_dict['pid'] = '123123123'
706
self.assertFalse(info.is_lock_holder_known_dead())
708
def test_no_good_hostname(self):
709
"""Correctly handle ambiguous hostnames.
711
If the lock's recorded with just 'localhost' we can't really trust
712
it's the same 'localhost'. (There are quite a few of them. :-)
713
So even if the process is known not to be alive, we can't say that's
716
self.overrideAttr(lockdir, 'get_host_name',
718
info = LockHeldInfo.for_this_process(None)
719
info.info_dict['pid'] = '123123123'
720
self.assertFalse(info.is_lock_holder_known_dead())
723
class TestStaleLockDir(TestCaseWithTransport):
724
"""Can automatically break stale locks.
726
:see: https://bugs.launchpad.net/bzr/+bug/220464
729
def test_auto_break_stale_lock(self):
730
"""Locks safely known to be stale are just cleaned up.
732
This generates a warning but no other user interaction.
734
# This is off by default at present; see the discussion in the bug.
735
# If you change the default, don't forget to update the docs.
736
config.GlobalConfig().set_user_option('locks.steal_dead', True)
737
# Create a lock pretending to come from a different nonexistent
738
# process on the same machine.
739
l1 = LockDir(self.get_transport(), 'a',
740
extra_holder_info={'pid': '12312313'})
741
token_1 = l1.attempt_lock()
742
l2 = LockDir(self.get_transport(), 'a')
743
token_2 = l2.attempt_lock()
744
# l1 will notice its lock was stolen.
745
self.assertRaises(errors.LockBroken,
749
def test_auto_break_stale_lock_configured_off(self):
750
"""Automatic breaking can be turned off"""
751
l1 = LockDir(self.get_transport(), 'a',
752
extra_holder_info={'pid': '12312313'})
753
token_1 = l1.attempt_lock()
754
self.addCleanup(l1.unlock)
755
l2 = LockDir(self.get_transport(), 'a')
756
# This fails now, because dead lock breaking is off by default.
757
self.assertRaises(LockContention,
759
# and it's in fact not broken