~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_smart.py

  • Committer: Robert Collins
  • Date: 2007-07-04 01:39:50 UTC
  • mto: This revision was merged to the branch mainline in revision 2581.
  • Revision ID: robertc@robertcollins.net-20070704013950-7pp23plwyqjvgkxg
Review feedback.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2011 Canonical Ltd
 
1
# Copyright (C) 2006, 2007 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
 
 
17
 
"""Tests for the smart wire/domain protocol.
18
 
 
19
 
This module contains tests for the domain-level smart requests and responses,
20
 
such as the 'Branch.lock_write' request. Many of these use specific disk
21
 
formats to exercise calls that only make sense for formats with specific
22
 
properties.
23
 
 
24
 
Tests for low-level protocol encoding are found in test_smart_transport.
25
 
"""
26
 
 
27
 
import bz2
28
 
 
29
 
from bzrlib import (
30
 
    branch as _mod_branch,
31
 
    bzrdir,
32
 
    errors,
33
 
    tests,
34
 
    transport,
35
 
    urlutils,
36
 
    versionedfile,
37
 
    )
38
 
from bzrlib.smart import (
39
 
    branch as smart_branch,
40
 
    bzrdir as smart_dir,
41
 
    repository as smart_repo,
42
 
    packrepository as smart_packrepo,
43
 
    request as smart_req,
44
 
    server,
45
 
    vfs,
46
 
    )
47
 
from bzrlib.tests import test_server
48
 
from bzrlib.transport import (
49
 
    chroot,
50
 
    memory,
51
 
    )
52
 
 
53
 
 
54
 
def load_tests(standard_tests, module, loader):
55
 
    """Multiply tests version and protocol consistency."""
56
 
    # FindRepository tests.
57
 
    scenarios = [
58
 
        ("find_repository", {
59
 
            "_request_class": smart_dir.SmartServerRequestFindRepositoryV1}),
60
 
        ("find_repositoryV2", {
61
 
            "_request_class": smart_dir.SmartServerRequestFindRepositoryV2}),
62
 
        ("find_repositoryV3", {
63
 
            "_request_class": smart_dir.SmartServerRequestFindRepositoryV3}),
64
 
        ]
65
 
    to_adapt, result = tests.split_suite_by_re(standard_tests,
66
 
        "TestSmartServerRequestFindRepository")
67
 
    v2_only, v1_and_2 = tests.split_suite_by_re(to_adapt,
68
 
        "_v2")
69
 
    tests.multiply_tests(v1_and_2, scenarios, result)
70
 
    # The first scenario is only applicable to v1 protocols, it is deleted
71
 
    # since.
72
 
    tests.multiply_tests(v2_only, scenarios[1:], result)
73
 
    return result
74
 
 
75
 
 
76
 
class TestCaseWithChrootedTransport(tests.TestCaseWithTransport):
77
 
 
78
 
    def setUp(self):
79
 
        self.vfs_transport_factory = memory.MemoryServer
80
 
        tests.TestCaseWithTransport.setUp(self)
81
 
        self._chroot_server = None
82
 
 
83
 
    def get_transport(self, relpath=None):
84
 
        if self._chroot_server is None:
85
 
            backing_transport = tests.TestCaseWithTransport.get_transport(self)
86
 
            self._chroot_server = chroot.ChrootServer(backing_transport)
87
 
            self.start_server(self._chroot_server)
88
 
        t = transport.get_transport_from_url(self._chroot_server.get_url())
89
 
        if relpath is not None:
90
 
            t = t.clone(relpath)
91
 
        return t
92
 
 
93
 
 
94
 
class TestCaseWithSmartMedium(tests.TestCaseWithMemoryTransport):
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
16
 
 
17
"""Tests for the smart wire/domain protococl."""
 
18
 
 
19
from StringIO import StringIO
 
20
import tempfile
 
21
import tarfile
 
22
 
 
23
from bzrlib import bzrdir, errors, smart, tests
 
24
from bzrlib.smart.request import SmartServerResponse
 
25
import bzrlib.smart.bzrdir
 
26
import bzrlib.smart.branch
 
27
import bzrlib.smart.repository
 
28
 
 
29
 
 
30
class TestCaseWithSmartMedium(tests.TestCaseWithTransport):
95
31
 
96
32
    def setUp(self):
97
33
        super(TestCaseWithSmartMedium, self).setUp()
99
35
        # the default or a parameterized class, but rather use the
100
36
        # TestCaseWithTransport infrastructure to set up a smart server and
101
37
        # transport.
102
 
        self.overrideAttr(self, "transport_server", self.make_transport_server)
103
 
 
104
 
    def make_transport_server(self):
105
 
        return test_server.SmartTCPServer_for_testing('-' + self.id())
 
38
        self.transport_server = smart.server.SmartTCPServer_for_testing
106
39
 
107
40
    def get_smart_medium(self):
108
41
        """Get a smart medium to use in tests."""
109
42
        return self.get_transport().get_smart_medium()
110
43
 
111
44
 
112
 
class TestByteStreamToStream(tests.TestCase):
113
 
 
114
 
    def test_repeated_substreams_same_kind_are_one_stream(self):
115
 
        # Make a stream - an iterable of bytestrings.
116
 
        stream = [('text', [versionedfile.FulltextContentFactory(('k1',), None,
117
 
            None, 'foo')]),('text', [
118
 
            versionedfile.FulltextContentFactory(('k2',), None, None, 'bar')])]
119
 
        fmt = bzrdir.format_registry.get('pack-0.92')().repository_format
120
 
        bytes = smart_repo._stream_to_byte_stream(stream, fmt)
121
 
        streams = []
122
 
        # Iterate the resulting iterable; checking that we get only one stream
123
 
        # out.
124
 
        fmt, stream = smart_repo._byte_stream_to_stream(bytes)
125
 
        for kind, substream in stream:
126
 
            streams.append((kind, list(substream)))
127
 
        self.assertLength(1, streams)
128
 
        self.assertLength(2, streams[0][1])
129
 
 
130
 
 
131
45
class TestSmartServerResponse(tests.TestCase):
132
46
 
133
47
    def test__eq__(self):
134
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', )),
135
 
            smart_req.SmartServerResponse(('ok', )))
136
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), 'body'),
137
 
            smart_req.SmartServerResponse(('ok', ), 'body'))
138
 
        self.assertNotEqual(smart_req.SmartServerResponse(('ok', )),
139
 
            smart_req.SmartServerResponse(('notok', )))
140
 
        self.assertNotEqual(smart_req.SmartServerResponse(('ok', ), 'body'),
141
 
            smart_req.SmartServerResponse(('ok', )))
 
48
        self.assertEqual(SmartServerResponse(('ok', )),
 
49
            SmartServerResponse(('ok', )))
 
50
        self.assertEqual(SmartServerResponse(('ok', ), 'body'),
 
51
            SmartServerResponse(('ok', ), 'body'))
 
52
        self.assertNotEqual(SmartServerResponse(('ok', )),
 
53
            SmartServerResponse(('notok', )))
 
54
        self.assertNotEqual(SmartServerResponse(('ok', ), 'body'),
 
55
            SmartServerResponse(('ok', )))
142
56
        self.assertNotEqual(None,
143
 
            smart_req.SmartServerResponse(('ok', )))
144
 
 
145
 
    def test__str__(self):
146
 
        """SmartServerResponses can be stringified."""
147
 
        self.assertEqual(
148
 
            "<SuccessfulSmartServerResponse args=('args',) body='body'>",
149
 
            str(smart_req.SuccessfulSmartServerResponse(('args',), 'body')))
150
 
        self.assertEqual(
151
 
            "<FailedSmartServerResponse args=('args',) body='body'>",
152
 
            str(smart_req.FailedSmartServerResponse(('args',), 'body')))
153
 
 
154
 
 
155
 
class TestSmartServerRequest(tests.TestCaseWithMemoryTransport):
156
 
 
157
 
    def test_translate_client_path(self):
158
 
        transport = self.get_transport()
159
 
        request = smart_req.SmartServerRequest(transport, 'foo/')
160
 
        self.assertEqual('./', request.translate_client_path('foo/'))
161
 
        self.assertRaises(
162
 
            errors.InvalidURLJoin, request.translate_client_path, 'foo/..')
163
 
        self.assertRaises(
164
 
            errors.PathNotChild, request.translate_client_path, '/')
165
 
        self.assertRaises(
166
 
            errors.PathNotChild, request.translate_client_path, 'bar/')
167
 
        self.assertEqual('./baz', request.translate_client_path('foo/baz'))
168
 
        e_acute = u'\N{LATIN SMALL LETTER E WITH ACUTE}'.encode('utf-8')
169
 
        self.assertEqual('./' + urlutils.escape(e_acute),
170
 
                         request.translate_client_path('foo/' + e_acute))
171
 
 
172
 
    def test_translate_client_path_vfs(self):
173
 
        """VfsRequests receive escaped paths rather than raw UTF-8."""
174
 
        transport = self.get_transport()
175
 
        request = vfs.VfsRequest(transport, 'foo/')
176
 
        e_acute = u'\N{LATIN SMALL LETTER E WITH ACUTE}'.encode('utf-8')
177
 
        escaped = urlutils.escape('foo/' + e_acute)
178
 
        self.assertEqual('./' + urlutils.escape(e_acute),
179
 
                         request.translate_client_path(escaped))
180
 
 
181
 
    def test_transport_from_client_path(self):
182
 
        transport = self.get_transport()
183
 
        request = smart_req.SmartServerRequest(transport, 'foo/')
184
 
        self.assertEqual(
185
 
            transport.base,
186
 
            request.transport_from_client_path('foo/').base)
187
 
 
188
 
 
189
 
class TestSmartServerBzrDirRequestCloningMetaDir(
190
 
    tests.TestCaseWithMemoryTransport):
191
 
    """Tests for BzrDir.cloning_metadir."""
192
 
 
193
 
    def test_cloning_metadir(self):
194
 
        """When there is a bzrdir present, the call succeeds."""
195
 
        backing = self.get_transport()
196
 
        dir = self.make_bzrdir('.')
197
 
        local_result = dir.cloning_metadir()
198
 
        request_class = smart_dir.SmartServerBzrDirRequestCloningMetaDir
199
 
        request = request_class(backing)
200
 
        expected = smart_req.SuccessfulSmartServerResponse(
201
 
            (local_result.network_name(),
202
 
            local_result.repository_format.network_name(),
203
 
            ('branch', local_result.get_branch_format().network_name())))
204
 
        self.assertEqual(expected, request.execute('', 'False'))
205
 
 
206
 
    def test_cloning_metadir_reference(self):
207
 
        """The request fails when bzrdir contains a branch reference."""
208
 
        backing = self.get_transport()
209
 
        referenced_branch = self.make_branch('referenced')
210
 
        dir = self.make_bzrdir('.')
211
 
        local_result = dir.cloning_metadir()
212
 
        reference = _mod_branch.BranchReferenceFormat().initialize(
213
 
            dir, target_branch=referenced_branch)
214
 
        reference_url = _mod_branch.BranchReferenceFormat().get_reference(dir)
215
 
        # The server shouldn't try to follow the branch reference, so it's fine
216
 
        # if the referenced branch isn't reachable.
217
 
        backing.rename('referenced', 'moved')
218
 
        request_class = smart_dir.SmartServerBzrDirRequestCloningMetaDir
219
 
        request = request_class(backing)
220
 
        expected = smart_req.FailedSmartServerResponse(('BranchReference',))
221
 
        self.assertEqual(expected, request.execute('', 'False'))
222
 
 
223
 
 
224
 
class TestSmartServerRequestCreateRepository(tests.TestCaseWithMemoryTransport):
225
 
    """Tests for BzrDir.create_repository."""
226
 
 
227
 
    def test_makes_repository(self):
228
 
        """When there is a bzrdir present, the call succeeds."""
229
 
        backing = self.get_transport()
230
 
        self.make_bzrdir('.')
231
 
        request_class = smart_dir.SmartServerRequestCreateRepository
232
 
        request = request_class(backing)
233
 
        reference_bzrdir_format = bzrdir.format_registry.get('pack-0.92')()
234
 
        reference_format = reference_bzrdir_format.repository_format
235
 
        network_name = reference_format.network_name()
236
 
        expected = smart_req.SuccessfulSmartServerResponse(
237
 
            ('ok', 'no', 'no', 'no', network_name))
238
 
        self.assertEqual(expected, request.execute('', network_name, 'True'))
239
 
 
240
 
 
241
 
class TestSmartServerRequestFindRepository(tests.TestCaseWithMemoryTransport):
 
57
            SmartServerResponse(('ok', )))
 
58
 
 
59
 
 
60
class TestSmartServerRequestFindRepository(tests.TestCaseWithTransport):
242
61
    """Tests for BzrDir.find_repository."""
243
62
 
244
63
    def test_no_repository(self):
245
64
        """When there is no repository to be found, ('norepository', ) is returned."""
246
65
        backing = self.get_transport()
247
 
        request = self._request_class(backing)
 
66
        request = smart.bzrdir.SmartServerRequestFindRepository(backing)
248
67
        self.make_bzrdir('.')
249
 
        self.assertEqual(smart_req.SmartServerResponse(('norepository', )),
250
 
            request.execute(''))
 
68
        self.assertEqual(SmartServerResponse(('norepository', )),
 
69
            request.execute(backing.local_abspath('')))
251
70
 
252
71
    def test_nonshared_repository(self):
253
 
        # nonshared repositorys only allow 'find' to return a handle when the
254
 
        # path the repository is being searched on is the same as that that
 
72
        # nonshared repositorys only allow 'find' to return a handle when the 
 
73
        # path the repository is being searched on is the same as that that 
255
74
        # the repository is at.
256
75
        backing = self.get_transport()
257
 
        request = self._request_class(backing)
 
76
        request = smart.bzrdir.SmartServerRequestFindRepository(backing)
258
77
        result = self._make_repository_and_result()
259
 
        self.assertEqual(result, request.execute(''))
 
78
        self.assertEqual(result, request.execute(backing.local_abspath('')))
260
79
        self.make_bzrdir('subdir')
261
 
        self.assertEqual(smart_req.SmartServerResponse(('norepository', )),
262
 
            request.execute('subdir'))
 
80
        self.assertEqual(SmartServerResponse(('norepository', )),
 
81
            request.execute(backing.local_abspath('subdir')))
263
82
 
264
83
    def _make_repository_and_result(self, shared=False, format=None):
265
84
        """Convenience function to setup a repository.
275
94
            subtrees = 'yes'
276
95
        else:
277
96
            subtrees = 'no'
278
 
        if repo._format.supports_external_lookups:
279
 
            external = 'yes'
280
 
        else:
281
 
            external = 'no'
282
 
        if (smart_dir.SmartServerRequestFindRepositoryV3 ==
283
 
            self._request_class):
284
 
            return smart_req.SuccessfulSmartServerResponse(
285
 
                ('ok', '', rich_root, subtrees, external,
286
 
                 repo._format.network_name()))
287
 
        elif (smart_dir.SmartServerRequestFindRepositoryV2 ==
288
 
            self._request_class):
289
 
            # All tests so far are on formats, and for non-external
290
 
            # repositories.
291
 
            return smart_req.SuccessfulSmartServerResponse(
292
 
                ('ok', '', rich_root, subtrees, external))
293
 
        else:
294
 
            return smart_req.SuccessfulSmartServerResponse(
295
 
                ('ok', '', rich_root, subtrees))
 
97
        return SmartServerResponse(('ok', '', rich_root, subtrees))
296
98
 
297
99
    def test_shared_repository(self):
298
100
        """When there is a shared repository, we get 'ok', 'relpath-to-repo'."""
299
101
        backing = self.get_transport()
300
 
        request = self._request_class(backing)
 
102
        request = smart.bzrdir.SmartServerRequestFindRepository(backing)
301
103
        result = self._make_repository_and_result(shared=True)
302
 
        self.assertEqual(result, request.execute(''))
 
104
        self.assertEqual(result, request.execute(backing.local_abspath('')))
303
105
        self.make_bzrdir('subdir')
304
 
        result2 = smart_req.SmartServerResponse(
305
 
            result.args[0:1] + ('..', ) + result.args[2:])
 
106
        result2 = SmartServerResponse(result.args[0:1] + ('..', ) + result.args[2:])
306
107
        self.assertEqual(result2,
307
 
            request.execute('subdir'))
 
108
            request.execute(backing.local_abspath('subdir')))
308
109
        self.make_bzrdir('subdir/deeper')
309
 
        result3 = smart_req.SmartServerResponse(
310
 
            result.args[0:1] + ('../..', ) + result.args[2:])
 
110
        result3 = SmartServerResponse(result.args[0:1] + ('../..', ) + result.args[2:])
311
111
        self.assertEqual(result3,
312
 
            request.execute('subdir/deeper'))
 
112
            request.execute(backing.local_abspath('subdir/deeper')))
313
113
 
314
114
    def test_rich_root_and_subtree_encoding(self):
315
115
        """Test for the format attributes for rich root and subtree support."""
316
116
        backing = self.get_transport()
317
 
        request = self._request_class(backing)
318
 
        result = self._make_repository_and_result(
319
 
            format='dirstate-with-subtree')
 
117
        request = smart.bzrdir.SmartServerRequestFindRepository(backing)
 
118
        result = self._make_repository_and_result(format='dirstate-with-subtree')
320
119
        # check the test will be valid
321
120
        self.assertEqual('yes', result.args[2])
322
121
        self.assertEqual('yes', result.args[3])
323
 
        self.assertEqual(result, request.execute(''))
324
 
 
325
 
    def test_supports_external_lookups_no_v2(self):
326
 
        """Test for the supports_external_lookups attribute."""
327
 
        backing = self.get_transport()
328
 
        request = self._request_class(backing)
329
 
        result = self._make_repository_and_result(
330
 
            format='dirstate-with-subtree')
331
 
        # check the test will be valid
332
 
        self.assertEqual('no', result.args[4])
333
 
        self.assertEqual(result, request.execute(''))
334
 
 
335
 
 
336
 
class TestSmartServerBzrDirRequestGetConfigFile(
337
 
    tests.TestCaseWithMemoryTransport):
338
 
    """Tests for BzrDir.get_config_file."""
339
 
 
340
 
    def test_present(self):
341
 
        backing = self.get_transport()
342
 
        dir = self.make_bzrdir('.')
343
 
        dir.get_config().set_default_stack_on("/")
344
 
        local_result = dir._get_config()._get_config_file().read()
345
 
        request_class = smart_dir.SmartServerBzrDirRequestConfigFile
346
 
        request = request_class(backing)
347
 
        expected = smart_req.SuccessfulSmartServerResponse((), local_result)
348
 
        self.assertEqual(expected, request.execute(''))
349
 
 
350
 
    def test_missing(self):
351
 
        backing = self.get_transport()
352
 
        dir = self.make_bzrdir('.')
353
 
        request_class = smart_dir.SmartServerBzrDirRequestConfigFile
354
 
        request = request_class(backing)
355
 
        expected = smart_req.SuccessfulSmartServerResponse((), '')
356
 
        self.assertEqual(expected, request.execute(''))
357
 
 
358
 
 
359
 
class TestSmartServerRequestInitializeBzrDir(tests.TestCaseWithMemoryTransport):
 
122
        self.assertEqual(result, request.execute(backing.local_abspath('')))
 
123
 
 
124
 
 
125
class TestSmartServerRequestInitializeBzrDir(tests.TestCaseWithTransport):
360
126
 
361
127
    def test_empty_dir(self):
362
128
        """Initializing an empty dir should succeed and do it."""
363
129
        backing = self.get_transport()
364
 
        request = smart_dir.SmartServerRequestInitializeBzrDir(backing)
365
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', )),
366
 
            request.execute(''))
 
130
        request = smart.bzrdir.SmartServerRequestInitializeBzrDir(backing)
 
131
        self.assertEqual(SmartServerResponse(('ok', )),
 
132
            request.execute(backing.local_abspath('.')))
367
133
        made_dir = bzrdir.BzrDir.open_from_transport(backing)
368
 
        # no branch, tree or repository is expected with the current
 
134
        # no branch, tree or repository is expected with the current 
369
135
        # default formart.
370
136
        self.assertRaises(errors.NoWorkingTree, made_dir.open_workingtree)
371
137
        self.assertRaises(errors.NotBranchError, made_dir.open_branch)
374
140
    def test_missing_dir(self):
375
141
        """Initializing a missing directory should fail like the bzrdir api."""
376
142
        backing = self.get_transport()
377
 
        request = smart_dir.SmartServerRequestInitializeBzrDir(backing)
 
143
        request = smart.bzrdir.SmartServerRequestInitializeBzrDir(backing)
378
144
        self.assertRaises(errors.NoSuchFile,
379
 
            request.execute, 'subdir')
 
145
            request.execute, backing.local_abspath('subdir'))
380
146
 
381
147
    def test_initialized_dir(self):
382
148
        """Initializing an extant bzrdir should fail like the bzrdir api."""
383
149
        backing = self.get_transport()
384
 
        request = smart_dir.SmartServerRequestInitializeBzrDir(backing)
 
150
        request = smart.bzrdir.SmartServerRequestInitializeBzrDir(backing)
385
151
        self.make_bzrdir('subdir')
386
152
        self.assertRaises(errors.FileExists,
387
 
            request.execute, 'subdir')
388
 
 
389
 
 
390
 
class TestSmartServerRequestBzrDirInitializeEx(
391
 
    tests.TestCaseWithMemoryTransport):
392
 
    """Basic tests for BzrDir.initialize_ex_1.16 in the smart server.
393
 
 
394
 
    The main unit tests in test_bzrdir exercise the API comprehensively.
395
 
    """
396
 
 
397
 
    def test_empty_dir(self):
398
 
        """Initializing an empty dir should succeed and do it."""
399
 
        backing = self.get_transport()
400
 
        name = self.make_bzrdir('reference')._format.network_name()
401
 
        request = smart_dir.SmartServerRequestBzrDirInitializeEx(backing)
402
 
        self.assertEqual(
403
 
            smart_req.SmartServerResponse(('', '', '', '', '', '', name,
404
 
                                           'False', '', '', '')),
405
 
            request.execute(name, '', 'True', 'False', 'False', '', '', '', '',
406
 
                            'False'))
407
 
        made_dir = bzrdir.BzrDir.open_from_transport(backing)
408
 
        # no branch, tree or repository is expected with the current
409
 
        # default format.
410
 
        self.assertRaises(errors.NoWorkingTree, made_dir.open_workingtree)
411
 
        self.assertRaises(errors.NotBranchError, made_dir.open_branch)
412
 
        self.assertRaises(errors.NoRepositoryPresent, made_dir.open_repository)
413
 
 
414
 
    def test_missing_dir(self):
415
 
        """Initializing a missing directory should fail like the bzrdir api."""
416
 
        backing = self.get_transport()
417
 
        name = self.make_bzrdir('reference')._format.network_name()
418
 
        request = smart_dir.SmartServerRequestBzrDirInitializeEx(backing)
419
 
        self.assertRaises(errors.NoSuchFile, request.execute, name,
420
 
            'subdir/dir', 'False', 'False', 'False', '', '', '', '', 'False')
421
 
 
422
 
    def test_initialized_dir(self):
423
 
        """Initializing an extant directory should fail like the bzrdir api."""
424
 
        backing = self.get_transport()
425
 
        name = self.make_bzrdir('reference')._format.network_name()
426
 
        request = smart_dir.SmartServerRequestBzrDirInitializeEx(backing)
427
 
        self.make_bzrdir('subdir')
428
 
        self.assertRaises(errors.FileExists, request.execute, name, 'subdir',
429
 
            'False', 'False', 'False', '', '', '', '', 'False')
430
 
 
431
 
 
432
 
class TestSmartServerRequestOpenBzrDir(tests.TestCaseWithMemoryTransport):
433
 
 
434
 
    def test_no_directory(self):
435
 
        backing = self.get_transport()
436
 
        request = smart_dir.SmartServerRequestOpenBzrDir(backing)
437
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
438
 
            request.execute('does-not-exist'))
439
 
 
440
 
    def test_empty_directory(self):
441
 
        backing = self.get_transport()
442
 
        backing.mkdir('empty')
443
 
        request = smart_dir.SmartServerRequestOpenBzrDir(backing)
444
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
445
 
            request.execute('empty'))
446
 
 
447
 
    def test_outside_root_client_path(self):
448
 
        backing = self.get_transport()
449
 
        request = smart_dir.SmartServerRequestOpenBzrDir(backing,
450
 
            root_client_path='root')
451
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
452
 
            request.execute('not-root'))
453
 
 
454
 
 
455
 
class TestSmartServerRequestOpenBzrDir_2_1(tests.TestCaseWithMemoryTransport):
456
 
 
457
 
    def test_no_directory(self):
458
 
        backing = self.get_transport()
459
 
        request = smart_dir.SmartServerRequestOpenBzrDir_2_1(backing)
460
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
461
 
            request.execute('does-not-exist'))
462
 
 
463
 
    def test_empty_directory(self):
464
 
        backing = self.get_transport()
465
 
        backing.mkdir('empty')
466
 
        request = smart_dir.SmartServerRequestOpenBzrDir_2_1(backing)
467
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
468
 
            request.execute('empty'))
469
 
 
470
 
    def test_present_without_workingtree(self):
471
 
        backing = self.get_transport()
472
 
        request = smart_dir.SmartServerRequestOpenBzrDir_2_1(backing)
473
 
        self.make_bzrdir('.')
474
 
        self.assertEqual(smart_req.SmartServerResponse(('yes', 'no')),
475
 
            request.execute(''))
476
 
 
477
 
    def test_outside_root_client_path(self):
478
 
        backing = self.get_transport()
479
 
        request = smart_dir.SmartServerRequestOpenBzrDir_2_1(backing,
480
 
            root_client_path='root')
481
 
        self.assertEqual(smart_req.SmartServerResponse(('no',)),
482
 
            request.execute('not-root'))
483
 
 
484
 
 
485
 
class TestSmartServerRequestOpenBzrDir_2_1_disk(TestCaseWithChrootedTransport):
486
 
 
487
 
    def test_present_with_workingtree(self):
488
 
        self.vfs_transport_factory = test_server.LocalURLServer
489
 
        backing = self.get_transport()
490
 
        request = smart_dir.SmartServerRequestOpenBzrDir_2_1(backing)
491
 
        bd = self.make_bzrdir('.')
492
 
        bd.create_repository()
493
 
        bd.create_branch()
494
 
        bd.create_workingtree()
495
 
        self.assertEqual(smart_req.SmartServerResponse(('yes', 'yes')),
496
 
            request.execute(''))
497
 
 
498
 
 
499
 
class TestSmartServerRequestOpenBranch(TestCaseWithChrootedTransport):
 
153
            request.execute, backing.local_abspath('subdir'))
 
154
 
 
155
 
 
156
class TestSmartServerRequestOpenBranch(tests.TestCaseWithTransport):
500
157
 
501
158
    def test_no_branch(self):
502
159
        """When there is no branch, ('nobranch', ) is returned."""
503
160
        backing = self.get_transport()
504
 
        request = smart_dir.SmartServerRequestOpenBranch(backing)
 
161
        request = smart.bzrdir.SmartServerRequestOpenBranch(backing)
505
162
        self.make_bzrdir('.')
506
 
        self.assertEqual(smart_req.SmartServerResponse(('nobranch', )),
507
 
            request.execute(''))
 
163
        self.assertEqual(SmartServerResponse(('nobranch', )),
 
164
            request.execute(backing.local_abspath('')))
508
165
 
509
166
    def test_branch(self):
510
167
        """When there is a branch, 'ok' is returned."""
511
168
        backing = self.get_transport()
512
 
        request = smart_dir.SmartServerRequestOpenBranch(backing)
 
169
        request = smart.bzrdir.SmartServerRequestOpenBranch(backing)
513
170
        self.make_branch('.')
514
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', '')),
515
 
            request.execute(''))
516
 
 
517
 
    def test_branch_reference(self):
518
 
        """When there is a branch reference, the reference URL is returned."""
519
 
        self.vfs_transport_factory = test_server.LocalURLServer
520
 
        backing = self.get_transport()
521
 
        request = smart_dir.SmartServerRequestOpenBranch(backing)
522
 
        branch = self.make_branch('branch')
523
 
        checkout = branch.create_checkout('reference',lightweight=True)
524
 
        reference_url = _mod_branch.BranchReferenceFormat().get_reference(
525
 
            checkout.bzrdir)
526
 
        self.assertFileEqual(reference_url, 'reference/.bzr/branch/location')
527
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', reference_url)),
528
 
            request.execute('reference'))
529
 
 
530
 
    def test_notification_on_branch_from_repository(self):
531
 
        """When there is a repository, the error should return details."""
532
 
        backing = self.get_transport()
533
 
        request = smart_dir.SmartServerRequestOpenBranch(backing)
534
 
        repo = self.make_repository('.')
535
 
        self.assertEqual(smart_req.SmartServerResponse(('nobranch',)),
536
 
            request.execute(''))
537
 
 
538
 
 
539
 
class TestSmartServerRequestOpenBranchV2(TestCaseWithChrootedTransport):
540
 
 
541
 
    def test_no_branch(self):
542
 
        """When there is no branch, ('nobranch', ) is returned."""
543
 
        backing = self.get_transport()
544
 
        self.make_bzrdir('.')
545
 
        request = smart_dir.SmartServerRequestOpenBranchV2(backing)
546
 
        self.assertEqual(smart_req.SmartServerResponse(('nobranch', )),
547
 
            request.execute(''))
548
 
 
549
 
    def test_branch(self):
550
 
        """When there is a branch, 'ok' is returned."""
551
 
        backing = self.get_transport()
552
 
        expected = self.make_branch('.')._format.network_name()
553
 
        request = smart_dir.SmartServerRequestOpenBranchV2(backing)
554
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
555
 
                ('branch', expected)),
556
 
                         request.execute(''))
557
 
 
558
 
    def test_branch_reference(self):
559
 
        """When there is a branch reference, the reference URL is returned."""
560
 
        self.vfs_transport_factory = test_server.LocalURLServer
561
 
        backing = self.get_transport()
562
 
        request = smart_dir.SmartServerRequestOpenBranchV2(backing)
563
 
        branch = self.make_branch('branch')
564
 
        checkout = branch.create_checkout('reference',lightweight=True)
565
 
        reference_url = _mod_branch.BranchReferenceFormat().get_reference(
566
 
            checkout.bzrdir)
567
 
        self.assertFileEqual(reference_url, 'reference/.bzr/branch/location')
568
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
569
 
                ('ref', reference_url)),
570
 
                         request.execute('reference'))
571
 
 
572
 
    def test_stacked_branch(self):
573
 
        """Opening a stacked branch does not open the stacked-on branch."""
574
 
        trunk = self.make_branch('trunk')
575
 
        feature = self.make_branch('feature')
576
 
        feature.set_stacked_on_url(trunk.base)
577
 
        opened_branches = []
578
 
        _mod_branch.Branch.hooks.install_named_hook(
579
 
            'open', opened_branches.append, None)
580
 
        backing = self.get_transport()
581
 
        request = smart_dir.SmartServerRequestOpenBranchV2(backing)
582
 
        request.setup_jail()
583
 
        try:
584
 
            response = request.execute('feature')
585
 
        finally:
586
 
            request.teardown_jail()
587
 
        expected_format = feature._format.network_name()
588
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
589
 
                ('branch', expected_format)),
590
 
                         response)
591
 
        self.assertLength(1, opened_branches)
592
 
 
593
 
    def test_notification_on_branch_from_repository(self):
594
 
        """When there is a repository, the error should return details."""
595
 
        backing = self.get_transport()
596
 
        request = smart_dir.SmartServerRequestOpenBranchV2(backing)
597
 
        repo = self.make_repository('.')
598
 
        self.assertEqual(smart_req.SmartServerResponse(('nobranch',)),
599
 
            request.execute(''))
600
 
 
601
 
 
602
 
class TestSmartServerRequestOpenBranchV3(TestCaseWithChrootedTransport):
603
 
 
604
 
    def test_no_branch(self):
605
 
        """When there is no branch, ('nobranch', ) is returned."""
606
 
        backing = self.get_transport()
607
 
        self.make_bzrdir('.')
608
 
        request = smart_dir.SmartServerRequestOpenBranchV3(backing)
609
 
        self.assertEqual(smart_req.SmartServerResponse(('nobranch',)),
610
 
            request.execute(''))
611
 
 
612
 
    def test_branch(self):
613
 
        """When there is a branch, 'ok' is returned."""
614
 
        backing = self.get_transport()
615
 
        expected = self.make_branch('.')._format.network_name()
616
 
        request = smart_dir.SmartServerRequestOpenBranchV3(backing)
617
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
618
 
                ('branch', expected)),
619
 
                         request.execute(''))
620
 
 
621
 
    def test_branch_reference(self):
622
 
        """When there is a branch reference, the reference URL is returned."""
623
 
        self.vfs_transport_factory = test_server.LocalURLServer
624
 
        backing = self.get_transport()
625
 
        request = smart_dir.SmartServerRequestOpenBranchV3(backing)
626
 
        branch = self.make_branch('branch')
627
 
        checkout = branch.create_checkout('reference',lightweight=True)
628
 
        reference_url = _mod_branch.BranchReferenceFormat().get_reference(
629
 
            checkout.bzrdir)
630
 
        self.assertFileEqual(reference_url, 'reference/.bzr/branch/location')
631
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
632
 
                ('ref', reference_url)),
633
 
                         request.execute('reference'))
634
 
 
635
 
    def test_stacked_branch(self):
636
 
        """Opening a stacked branch does not open the stacked-on branch."""
637
 
        trunk = self.make_branch('trunk')
638
 
        feature = self.make_branch('feature')
639
 
        feature.set_stacked_on_url(trunk.base)
640
 
        opened_branches = []
641
 
        _mod_branch.Branch.hooks.install_named_hook(
642
 
            'open', opened_branches.append, None)
643
 
        backing = self.get_transport()
644
 
        request = smart_dir.SmartServerRequestOpenBranchV3(backing)
645
 
        request.setup_jail()
646
 
        try:
647
 
            response = request.execute('feature')
648
 
        finally:
649
 
            request.teardown_jail()
650
 
        expected_format = feature._format.network_name()
651
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(
652
 
                ('branch', expected_format)),
653
 
                         response)
654
 
        self.assertLength(1, opened_branches)
655
 
 
656
 
    def test_notification_on_branch_from_repository(self):
657
 
        """When there is a repository, the error should return details."""
658
 
        backing = self.get_transport()
659
 
        request = smart_dir.SmartServerRequestOpenBranchV3(backing)
660
 
        repo = self.make_repository('.')
661
 
        self.assertEqual(smart_req.SmartServerResponse(
662
 
                ('nobranch', 'location is a repository')),
663
 
                         request.execute(''))
664
 
 
665
 
 
666
 
class TestSmartServerRequestRevisionHistory(tests.TestCaseWithMemoryTransport):
 
171
        self.assertEqual(SmartServerResponse(('ok', '')),
 
172
            request.execute(backing.local_abspath('')))
 
173
 
 
174
    def test_branch_reference(self):
 
175
        """When there is a branch reference, the reference URL is returned."""
 
176
        backing = self.get_transport()
 
177
        request = smart.bzrdir.SmartServerRequestOpenBranch(backing)
 
178
        branch = self.make_branch('branch')
 
179
        checkout = branch.create_checkout('reference',lightweight=True)
 
180
        # TODO: once we have an API to probe for references of any sort, we
 
181
        # can use it here.
 
182
        reference_url = backing.abspath('branch') + '/'
 
183
        self.assertFileEqual(reference_url, 'reference/.bzr/branch/location')
 
184
        self.assertEqual(SmartServerResponse(('ok', reference_url)),
 
185
            request.execute(backing.local_abspath('reference')))
 
186
 
 
187
 
 
188
class TestSmartServerRequestRevisionHistory(tests.TestCaseWithTransport):
667
189
 
668
190
    def test_empty(self):
669
191
        """For an empty branch, the body is empty."""
670
192
        backing = self.get_transport()
671
 
        request = smart_branch.SmartServerRequestRevisionHistory(backing)
 
193
        request = smart.branch.SmartServerRequestRevisionHistory(backing)
672
194
        self.make_branch('.')
673
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), ''),
674
 
            request.execute(''))
 
195
        self.assertEqual(SmartServerResponse(('ok', ), ''),
 
196
            request.execute(backing.local_abspath('')))
675
197
 
676
198
    def test_not_empty(self):
677
199
        """For a non-empty branch, the body is empty."""
678
200
        backing = self.get_transport()
679
 
        request = smart_branch.SmartServerRequestRevisionHistory(backing)
 
201
        request = smart.branch.SmartServerRequestRevisionHistory(backing)
680
202
        tree = self.make_branch_and_memory_tree('.')
681
203
        tree.lock_write()
682
204
        tree.add('')
684
206
        r2 = tree.commit('2nd commit', rev_id=u'\xc8'.encode('utf-8'))
685
207
        tree.unlock()
686
208
        self.assertEqual(
687
 
            smart_req.SmartServerResponse(('ok', ), ('\x00'.join([r1, r2]))),
688
 
            request.execute(''))
689
 
 
690
 
 
691
 
class TestSmartServerBranchRequest(tests.TestCaseWithMemoryTransport):
 
209
            SmartServerResponse(('ok', ), ('\x00'.join([r1, r2]))),
 
210
            request.execute(backing.local_abspath('')))
 
211
 
 
212
 
 
213
class TestSmartServerBranchRequest(tests.TestCaseWithTransport):
692
214
 
693
215
    def test_no_branch(self):
694
216
        """When there is a bzrdir and no branch, NotBranchError is raised."""
695
217
        backing = self.get_transport()
696
 
        request = smart_branch.SmartServerBranchRequest(backing)
 
218
        request = smart.branch.SmartServerBranchRequest(backing)
697
219
        self.make_bzrdir('.')
698
220
        self.assertRaises(errors.NotBranchError,
699
 
            request.execute, '')
 
221
            request.execute, backing.local_abspath(''))
700
222
 
701
223
    def test_branch_reference(self):
702
224
        """When there is a branch reference, NotBranchError is raised."""
703
225
        backing = self.get_transport()
704
 
        request = smart_branch.SmartServerBranchRequest(backing)
 
226
        request = smart.branch.SmartServerBranchRequest(backing)
705
227
        branch = self.make_branch('branch')
706
228
        checkout = branch.create_checkout('reference',lightweight=True)
707
229
        self.assertRaises(errors.NotBranchError,
708
 
            request.execute, 'checkout')
709
 
 
710
 
 
711
 
class TestSmartServerBranchRequestLastRevisionInfo(
712
 
    tests.TestCaseWithMemoryTransport):
 
230
            request.execute, backing.local_abspath('checkout'))
 
231
 
 
232
 
 
233
class TestSmartServerBranchRequestLastRevisionInfo(tests.TestCaseWithTransport):
713
234
 
714
235
    def test_empty(self):
715
236
        """For an empty branch, the result is ('ok', '0', 'null:')."""
716
237
        backing = self.get_transport()
717
 
        request = smart_branch.SmartServerBranchRequestLastRevisionInfo(backing)
 
238
        request = smart.branch.SmartServerBranchRequestLastRevisionInfo(backing)
718
239
        self.make_branch('.')
719
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', '0', 'null:')),
720
 
            request.execute(''))
 
240
        self.assertEqual(SmartServerResponse(('ok', '0', 'null:')),
 
241
            request.execute(backing.local_abspath('')))
721
242
 
722
243
    def test_not_empty(self):
723
244
        """For a non-empty branch, the result is ('ok', 'revno', 'revid')."""
724
245
        backing = self.get_transport()
725
 
        request = smart_branch.SmartServerBranchRequestLastRevisionInfo(backing)
 
246
        request = smart.branch.SmartServerBranchRequestLastRevisionInfo(backing)
726
247
        tree = self.make_branch_and_memory_tree('.')
727
248
        tree.lock_write()
728
249
        tree.add('')
731
252
        r2 = tree.commit('2nd commit', rev_id=rev_id_utf8)
732
253
        tree.unlock()
733
254
        self.assertEqual(
734
 
            smart_req.SmartServerResponse(('ok', '2', rev_id_utf8)),
735
 
            request.execute(''))
736
 
 
737
 
 
738
 
class TestSmartServerBranchRequestGetConfigFile(
739
 
    tests.TestCaseWithMemoryTransport):
 
255
            SmartServerResponse(('ok', '2', rev_id_utf8)),
 
256
            request.execute(backing.local_abspath('')))
 
257
 
 
258
 
 
259
class TestSmartServerBranchRequestGetConfigFile(tests.TestCaseWithTransport):
740
260
 
741
261
    def test_default(self):
742
262
        """With no file, we get empty content."""
743
263
        backing = self.get_transport()
744
 
        request = smart_branch.SmartServerBranchGetConfigFile(backing)
 
264
        request = smart.branch.SmartServerBranchGetConfigFile(backing)
745
265
        branch = self.make_branch('.')
746
266
        # there should be no file by default
747
267
        content = ''
748
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), content),
749
 
            request.execute(''))
 
268
        self.assertEqual(SmartServerResponse(('ok', ), content),
 
269
            request.execute(backing.local_abspath('')))
750
270
 
751
271
    def test_with_content(self):
752
272
        # SmartServerBranchGetConfigFile should return the content from
753
273
        # branch.control_files.get('branch.conf') for now - in the future it may
754
 
        # perform more complex processing.
755
 
        backing = self.get_transport()
756
 
        request = smart_branch.SmartServerBranchGetConfigFile(backing)
757
 
        branch = self.make_branch('.')
758
 
        branch._transport.put_bytes('branch.conf', 'foo bar baz')
759
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), 'foo bar baz'),
760
 
            request.execute(''))
761
 
 
762
 
 
763
 
class TestLockedBranch(tests.TestCaseWithMemoryTransport):
764
 
 
765
 
    def get_lock_tokens(self, branch):
766
 
        branch_token = branch.lock_write().branch_token
767
 
        repo_token = branch.repository.lock_write().repository_token
768
 
        branch.repository.unlock()
769
 
        return branch_token, repo_token
770
 
 
771
 
 
772
 
class TestSmartServerBranchRequestSetConfigOption(TestLockedBranch):
773
 
 
774
 
    def test_value_name(self):
775
 
        branch = self.make_branch('.')
776
 
        request = smart_branch.SmartServerBranchRequestSetConfigOption(
777
 
            branch.bzrdir.root_transport)
778
 
        branch_token, repo_token = self.get_lock_tokens(branch)
779
 
        config = branch._get_config()
780
 
        result = request.execute('', branch_token, repo_token, 'bar', 'foo',
781
 
            '')
782
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), result)
783
 
        self.assertEqual('bar', config.get_option('foo'))
784
 
        # Cleanup
785
 
        branch.unlock()
786
 
 
787
 
    def test_value_name_section(self):
788
 
        branch = self.make_branch('.')
789
 
        request = smart_branch.SmartServerBranchRequestSetConfigOption(
790
 
            branch.bzrdir.root_transport)
791
 
        branch_token, repo_token = self.get_lock_tokens(branch)
792
 
        config = branch._get_config()
793
 
        result = request.execute('', branch_token, repo_token, 'bar', 'foo',
794
 
            'gam')
795
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), result)
796
 
        self.assertEqual('bar', config.get_option('foo', 'gam'))
797
 
        # Cleanup
798
 
        branch.unlock()
799
 
 
800
 
 
801
 
class TestSmartServerBranchRequestSetConfigOptionDict(TestLockedBranch):
802
 
 
803
 
    def setUp(self):
804
 
        TestLockedBranch.setUp(self)
805
 
        # A dict with non-ascii keys and values to exercise unicode
806
 
        # roundtripping.
807
 
        self.encoded_value_dict = (
808
 
            'd5:ascii1:a11:unicode \xe2\x8c\x9a3:\xe2\x80\xbde')
809
 
        self.value_dict = {
810
 
            'ascii': 'a', u'unicode \N{WATCH}': u'\N{INTERROBANG}'}
811
 
 
812
 
    def test_value_name(self):
813
 
        branch = self.make_branch('.')
814
 
        request = smart_branch.SmartServerBranchRequestSetConfigOptionDict(
815
 
            branch.bzrdir.root_transport)
816
 
        branch_token, repo_token = self.get_lock_tokens(branch)
817
 
        config = branch._get_config()
818
 
        result = request.execute('', branch_token, repo_token,
819
 
            self.encoded_value_dict, 'foo', '')
820
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), result)
821
 
        self.assertEqual(self.value_dict, config.get_option('foo'))
822
 
        # Cleanup
823
 
        branch.unlock()
824
 
 
825
 
    def test_value_name_section(self):
826
 
        branch = self.make_branch('.')
827
 
        request = smart_branch.SmartServerBranchRequestSetConfigOptionDict(
828
 
            branch.bzrdir.root_transport)
829
 
        branch_token, repo_token = self.get_lock_tokens(branch)
830
 
        config = branch._get_config()
831
 
        result = request.execute('', branch_token, repo_token,
832
 
            self.encoded_value_dict, 'foo', 'gam')
833
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), result)
834
 
        self.assertEqual(self.value_dict, config.get_option('foo', 'gam'))
835
 
        # Cleanup
836
 
        branch.unlock()
837
 
 
838
 
 
839
 
class TestSmartServerBranchRequestSetTagsBytes(TestLockedBranch):
840
 
    # Only called when the branch format and tags match [yay factory
841
 
    # methods] so only need to test straight forward cases.
842
 
 
843
 
    def test_set_bytes(self):
844
 
        base_branch = self.make_branch('base')
845
 
        tag_bytes = base_branch._get_tags_bytes()
846
 
        # get_lock_tokens takes out a lock.
847
 
        branch_token, repo_token = self.get_lock_tokens(base_branch)
848
 
        request = smart_branch.SmartServerBranchSetTagsBytes(
849
 
            self.get_transport())
850
 
        response = request.execute('base', branch_token, repo_token)
851
 
        self.assertEqual(None, response)
852
 
        response = request.do_chunk(tag_bytes)
853
 
        self.assertEqual(None, response)
854
 
        response = request.do_end()
855
 
        self.assertEquals(
856
 
            smart_req.SuccessfulSmartServerResponse(()), response)
857
 
        base_branch.unlock()
858
 
 
859
 
    def test_lock_failed(self):
860
 
        base_branch = self.make_branch('base')
861
 
        base_branch.lock_write()
862
 
        tag_bytes = base_branch._get_tags_bytes()
863
 
        request = smart_branch.SmartServerBranchSetTagsBytes(
864
 
            self.get_transport())
865
 
        self.assertRaises(errors.TokenMismatch, request.execute,
866
 
            'base', 'wrong token', 'wrong token')
867
 
        # The request handler will keep processing the message parts, so even
868
 
        # if the request fails immediately do_chunk and do_end are still
869
 
        # called.
870
 
        request.do_chunk(tag_bytes)
871
 
        request.do_end()
872
 
        base_branch.unlock()
873
 
 
874
 
 
875
 
 
876
 
class SetLastRevisionTestBase(TestLockedBranch):
877
 
    """Base test case for verbs that implement set_last_revision."""
878
 
 
879
 
    def setUp(self):
880
 
        tests.TestCaseWithMemoryTransport.setUp(self)
881
 
        backing_transport = self.get_transport()
882
 
        self.request = self.request_class(backing_transport)
883
 
        self.tree = self.make_branch_and_memory_tree('.')
884
 
 
885
 
    def lock_branch(self):
886
 
        return self.get_lock_tokens(self.tree.branch)
887
 
 
888
 
    def unlock_branch(self):
889
 
        self.tree.branch.unlock()
890
 
 
891
 
    def set_last_revision(self, revision_id, revno):
892
 
        branch_token, repo_token = self.lock_branch()
893
 
        response = self._set_last_revision(
894
 
            revision_id, revno, branch_token, repo_token)
895
 
        self.unlock_branch()
896
 
        return response
897
 
 
898
 
    def assertRequestSucceeds(self, revision_id, revno):
899
 
        response = self.set_last_revision(revision_id, revno)
900
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(('ok',)),
901
 
                         response)
902
 
 
903
 
 
904
 
class TestSetLastRevisionVerbMixin(object):
905
 
    """Mixin test case for verbs that implement set_last_revision."""
906
 
 
907
 
    def test_set_null_to_null(self):
908
 
        """An empty branch can have its last revision set to 'null:'."""
909
 
        self.assertRequestSucceeds('null:', 0)
910
 
 
911
 
    def test_NoSuchRevision(self):
912
 
        """If the revision_id is not present, the verb returns NoSuchRevision.
913
 
        """
914
 
        revision_id = 'non-existent revision'
915
 
        self.assertEqual(smart_req.FailedSmartServerResponse(('NoSuchRevision',
916
 
                                                              revision_id)),
917
 
                         self.set_last_revision(revision_id, 1))
918
 
 
919
 
    def make_tree_with_two_commits(self):
920
 
        self.tree.lock_write()
921
 
        self.tree.add('')
922
 
        rev_id_utf8 = u'\xc8'.encode('utf-8')
923
 
        r1 = self.tree.commit('1st commit', rev_id=rev_id_utf8)
924
 
        r2 = self.tree.commit('2nd commit', rev_id='rev-2')
925
 
        self.tree.unlock()
926
 
 
927
 
    def test_branch_last_revision_info_is_updated(self):
928
 
        """A branch's tip can be set to a revision that is present in its
929
 
        repository.
930
 
        """
931
 
        # Make a branch with an empty revision history, but two revisions in
932
 
        # its repository.
933
 
        self.make_tree_with_two_commits()
934
 
        rev_id_utf8 = u'\xc8'.encode('utf-8')
935
 
        self.tree.branch.set_last_revision_info(0, 'null:')
936
 
        self.assertEqual(
937
 
            (0, 'null:'), self.tree.branch.last_revision_info())
938
 
        # We can update the branch to a revision that is present in the
939
 
        # repository.
940
 
        self.assertRequestSucceeds(rev_id_utf8, 1)
941
 
        self.assertEqual(
942
 
            (1, rev_id_utf8), self.tree.branch.last_revision_info())
943
 
 
944
 
    def test_branch_last_revision_info_rewind(self):
945
 
        """A branch's tip can be set to a revision that is an ancestor of the
946
 
        current tip.
947
 
        """
948
 
        self.make_tree_with_two_commits()
949
 
        rev_id_utf8 = u'\xc8'.encode('utf-8')
950
 
        self.assertEqual(
951
 
            (2, 'rev-2'), self.tree.branch.last_revision_info())
952
 
        self.assertRequestSucceeds(rev_id_utf8, 1)
953
 
        self.assertEqual(
954
 
            (1, rev_id_utf8), self.tree.branch.last_revision_info())
955
 
 
956
 
    def test_TipChangeRejected(self):
957
 
        """If a pre_change_branch_tip hook raises TipChangeRejected, the verb
958
 
        returns TipChangeRejected.
959
 
        """
960
 
        rejection_message = u'rejection message\N{INTERROBANG}'
961
 
        def hook_that_rejects(params):
962
 
            raise errors.TipChangeRejected(rejection_message)
963
 
        _mod_branch.Branch.hooks.install_named_hook(
964
 
            'pre_change_branch_tip', hook_that_rejects, None)
965
 
        self.assertEqual(
966
 
            smart_req.FailedSmartServerResponse(
967
 
                ('TipChangeRejected', rejection_message.encode('utf-8'))),
968
 
            self.set_last_revision('null:', 0))
969
 
 
970
 
 
971
 
class TestSmartServerBranchRequestSetLastRevision(
972
 
        SetLastRevisionTestBase, TestSetLastRevisionVerbMixin):
973
 
    """Tests for Branch.set_last_revision verb."""
974
 
 
975
 
    request_class = smart_branch.SmartServerBranchRequestSetLastRevision
976
 
 
977
 
    def _set_last_revision(self, revision_id, revno, branch_token, repo_token):
978
 
        return self.request.execute(
979
 
            '', branch_token, repo_token, revision_id)
980
 
 
981
 
 
982
 
class TestSmartServerBranchRequestSetLastRevisionInfo(
983
 
        SetLastRevisionTestBase, TestSetLastRevisionVerbMixin):
984
 
    """Tests for Branch.set_last_revision_info verb."""
985
 
 
986
 
    request_class = smart_branch.SmartServerBranchRequestSetLastRevisionInfo
987
 
 
988
 
    def _set_last_revision(self, revision_id, revno, branch_token, repo_token):
989
 
        return self.request.execute(
990
 
            '', branch_token, repo_token, revno, revision_id)
991
 
 
992
 
    def test_NoSuchRevision(self):
993
 
        """Branch.set_last_revision_info does not have to return
994
 
        NoSuchRevision if the revision_id is absent.
995
 
        """
996
 
        raise tests.TestNotApplicable()
997
 
 
998
 
 
999
 
class TestSmartServerBranchRequestSetLastRevisionEx(
1000
 
        SetLastRevisionTestBase, TestSetLastRevisionVerbMixin):
1001
 
    """Tests for Branch.set_last_revision_ex verb."""
1002
 
 
1003
 
    request_class = smart_branch.SmartServerBranchRequestSetLastRevisionEx
1004
 
 
1005
 
    def _set_last_revision(self, revision_id, revno, branch_token, repo_token):
1006
 
        return self.request.execute(
1007
 
            '', branch_token, repo_token, revision_id, 0, 0)
1008
 
 
1009
 
    def assertRequestSucceeds(self, revision_id, revno):
1010
 
        response = self.set_last_revision(revision_id, revno)
1011
 
        self.assertEqual(
1012
 
            smart_req.SuccessfulSmartServerResponse(('ok', revno, revision_id)),
1013
 
            response)
1014
 
 
1015
 
    def test_branch_last_revision_info_rewind(self):
1016
 
        """A branch's tip can be set to a revision that is an ancestor of the
1017
 
        current tip, but only if allow_overwrite_descendant is passed.
1018
 
        """
1019
 
        self.make_tree_with_two_commits()
1020
 
        rev_id_utf8 = u'\xc8'.encode('utf-8')
1021
 
        self.assertEqual(
1022
 
            (2, 'rev-2'), self.tree.branch.last_revision_info())
1023
 
        # If allow_overwrite_descendant flag is 0, then trying to set the tip
1024
 
        # to an older revision ID has no effect.
1025
 
        branch_token, repo_token = self.lock_branch()
1026
 
        response = self.request.execute(
1027
 
            '', branch_token, repo_token, rev_id_utf8, 0, 0)
1028
 
        self.assertEqual(
1029
 
            smart_req.SuccessfulSmartServerResponse(('ok', 2, 'rev-2')),
1030
 
            response)
1031
 
        self.assertEqual(
1032
 
            (2, 'rev-2'), self.tree.branch.last_revision_info())
1033
 
 
1034
 
        # If allow_overwrite_descendant flag is 1, then setting the tip to an
1035
 
        # ancestor works.
1036
 
        response = self.request.execute(
1037
 
            '', branch_token, repo_token, rev_id_utf8, 0, 1)
1038
 
        self.assertEqual(
1039
 
            smart_req.SuccessfulSmartServerResponse(('ok', 1, rev_id_utf8)),
1040
 
            response)
1041
 
        self.unlock_branch()
1042
 
        self.assertEqual(
1043
 
            (1, rev_id_utf8), self.tree.branch.last_revision_info())
1044
 
 
1045
 
    def make_branch_with_divergent_history(self):
1046
 
        """Make a branch with divergent history in its repo.
1047
 
 
1048
 
        The branch's tip will be 'child-2', and the repo will also contain
1049
 
        'child-1', which diverges from a common base revision.
1050
 
        """
1051
 
        self.tree.lock_write()
1052
 
        self.tree.add('')
1053
 
        r1 = self.tree.commit('1st commit')
1054
 
        revno_1, revid_1 = self.tree.branch.last_revision_info()
1055
 
        r2 = self.tree.commit('2nd commit', rev_id='child-1')
1056
 
        # Undo the second commit
1057
 
        self.tree.branch.set_last_revision_info(revno_1, revid_1)
1058
 
        self.tree.set_parent_ids([revid_1])
1059
 
        # Make a new second commit, child-2.  child-2 has diverged from
1060
 
        # child-1.
1061
 
        new_r2 = self.tree.commit('2nd commit', rev_id='child-2')
1062
 
        self.tree.unlock()
1063
 
 
1064
 
    def test_not_allow_diverged(self):
1065
 
        """If allow_diverged is not passed, then setting a divergent history
1066
 
        returns a Diverged error.
1067
 
        """
1068
 
        self.make_branch_with_divergent_history()
1069
 
        self.assertEqual(
1070
 
            smart_req.FailedSmartServerResponse(('Diverged',)),
1071
 
            self.set_last_revision('child-1', 2))
1072
 
        # The branch tip was not changed.
1073
 
        self.assertEqual('child-2', self.tree.branch.last_revision())
1074
 
 
1075
 
    def test_allow_diverged(self):
1076
 
        """If allow_diverged is passed, then setting a divergent history
1077
 
        succeeds.
1078
 
        """
1079
 
        self.make_branch_with_divergent_history()
1080
 
        branch_token, repo_token = self.lock_branch()
1081
 
        response = self.request.execute(
1082
 
            '', branch_token, repo_token, 'child-1', 1, 0)
1083
 
        self.assertEqual(
1084
 
            smart_req.SuccessfulSmartServerResponse(('ok', 2, 'child-1')),
1085
 
            response)
1086
 
        self.unlock_branch()
1087
 
        # The branch tip was changed.
1088
 
        self.assertEqual('child-1', self.tree.branch.last_revision())
1089
 
 
1090
 
 
1091
 
class TestSmartServerBranchRequestGetParent(tests.TestCaseWithMemoryTransport):
1092
 
 
1093
 
    def test_get_parent_none(self):
1094
 
        base_branch = self.make_branch('base')
1095
 
        request = smart_branch.SmartServerBranchGetParent(self.get_transport())
1096
 
        response = request.execute('base')
1097
 
        self.assertEquals(
1098
 
            smart_req.SuccessfulSmartServerResponse(('',)), response)
1099
 
 
1100
 
    def test_get_parent_something(self):
1101
 
        base_branch = self.make_branch('base')
1102
 
        base_branch.set_parent(self.get_url('foo'))
1103
 
        request = smart_branch.SmartServerBranchGetParent(self.get_transport())
1104
 
        response = request.execute('base')
1105
 
        self.assertEquals(
1106
 
            smart_req.SuccessfulSmartServerResponse(("../foo",)),
1107
 
            response)
1108
 
 
1109
 
 
1110
 
class TestSmartServerBranchRequestSetParent(TestLockedBranch):
1111
 
 
1112
 
    def test_set_parent_none(self):
1113
 
        branch = self.make_branch('base', format="1.9")
1114
 
        branch.lock_write()
1115
 
        branch._set_parent_location('foo')
1116
 
        branch.unlock()
1117
 
        request = smart_branch.SmartServerBranchRequestSetParentLocation(
1118
 
            self.get_transport())
1119
 
        branch_token, repo_token = self.get_lock_tokens(branch)
1120
 
        try:
1121
 
            response = request.execute('base', branch_token, repo_token, '')
1122
 
        finally:
1123
 
            branch.unlock()
1124
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), response)
1125
 
        self.assertEqual(None, branch.get_parent())
1126
 
 
1127
 
    def test_set_parent_something(self):
1128
 
        branch = self.make_branch('base', format="1.9")
1129
 
        request = smart_branch.SmartServerBranchRequestSetParentLocation(
1130
 
            self.get_transport())
1131
 
        branch_token, repo_token = self.get_lock_tokens(branch)
1132
 
        try:
1133
 
            response = request.execute('base', branch_token, repo_token,
1134
 
            'http://bar/')
1135
 
        finally:
1136
 
            branch.unlock()
1137
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(()), response)
1138
 
        self.assertEqual('http://bar/', branch.get_parent())
1139
 
 
1140
 
 
1141
 
class TestSmartServerBranchRequestGetTagsBytes(
1142
 
    tests.TestCaseWithMemoryTransport):
1143
 
    # Only called when the branch format and tags match [yay factory
1144
 
    # methods] so only need to test straight forward cases.
1145
 
 
1146
 
    def test_get_bytes(self):
1147
 
        base_branch = self.make_branch('base')
1148
 
        request = smart_branch.SmartServerBranchGetTagsBytes(
1149
 
            self.get_transport())
1150
 
        response = request.execute('base')
1151
 
        self.assertEquals(
1152
 
            smart_req.SuccessfulSmartServerResponse(('',)), response)
1153
 
 
1154
 
 
1155
 
class TestSmartServerBranchRequestGetStackedOnURL(tests.TestCaseWithMemoryTransport):
1156
 
 
1157
 
    def test_get_stacked_on_url(self):
1158
 
        base_branch = self.make_branch('base', format='1.6')
1159
 
        stacked_branch = self.make_branch('stacked', format='1.6')
1160
 
        # typically should be relative
1161
 
        stacked_branch.set_stacked_on_url('../base')
1162
 
        request = smart_branch.SmartServerBranchRequestGetStackedOnURL(
1163
 
            self.get_transport())
1164
 
        response = request.execute('stacked')
1165
 
        self.assertEquals(
1166
 
            smart_req.SmartServerResponse(('ok', '../base')),
1167
 
            response)
1168
 
 
1169
 
 
1170
 
class TestSmartServerBranchRequestLockWrite(TestLockedBranch):
1171
 
 
1172
 
    def setUp(self):
1173
 
        tests.TestCaseWithMemoryTransport.setUp(self)
 
274
        # perform more complex processing. 
 
275
        backing = self.get_transport()
 
276
        request = smart.branch.SmartServerBranchGetConfigFile(backing)
 
277
        branch = self.make_branch('.')
 
278
        branch.control_files.put_utf8('branch.conf', 'foo bar baz')
 
279
        self.assertEqual(SmartServerResponse(('ok', ), 'foo bar baz'),
 
280
            request.execute(backing.local_abspath('')))
 
281
 
 
282
 
 
283
class TestSmartServerBranchRequestSetLastRevision(tests.TestCaseWithTransport):
 
284
 
 
285
    def test_empty(self):
 
286
        backing = self.get_transport()
 
287
        request = smart.branch.SmartServerBranchRequestSetLastRevision(backing)
 
288
        b = self.make_branch('.')
 
289
        branch_token = b.lock_write()
 
290
        repo_token = b.repository.lock_write()
 
291
        b.repository.unlock()
 
292
        try:
 
293
            self.assertEqual(SmartServerResponse(('ok',)),
 
294
                request.execute(
 
295
                    backing.local_abspath(''), branch_token, repo_token,
 
296
                    'null:'))
 
297
        finally:
 
298
            b.unlock()
 
299
 
 
300
    def test_not_present_revision_id(self):
 
301
        backing = self.get_transport()
 
302
        request = smart.branch.SmartServerBranchRequestSetLastRevision(backing)
 
303
        b = self.make_branch('.')
 
304
        branch_token = b.lock_write()
 
305
        repo_token = b.repository.lock_write()
 
306
        b.repository.unlock()
 
307
        try:
 
308
            revision_id = 'non-existent revision'
 
309
            self.assertEqual(
 
310
                SmartServerResponse(('NoSuchRevision', revision_id)),
 
311
                request.execute(
 
312
                    backing.local_abspath(''), branch_token, repo_token,
 
313
                    revision_id))
 
314
        finally:
 
315
            b.unlock()
 
316
 
 
317
    def test_revision_id_present(self):
 
318
        backing = self.get_transport()
 
319
        request = smart.branch.SmartServerBranchRequestSetLastRevision(backing)
 
320
        tree = self.make_branch_and_memory_tree('.')
 
321
        tree.lock_write()
 
322
        tree.add('')
 
323
        rev_id_utf8 = u'\xc8'.encode('utf-8')
 
324
        r1 = tree.commit('1st commit', rev_id=rev_id_utf8)
 
325
        r2 = tree.commit('2nd commit')
 
326
        tree.unlock()
 
327
        branch_token = tree.branch.lock_write()
 
328
        repo_token = tree.branch.repository.lock_write()
 
329
        tree.branch.repository.unlock()
 
330
        try:
 
331
            self.assertEqual(
 
332
                SmartServerResponse(('ok',)),
 
333
                request.execute(
 
334
                    backing.local_abspath(''), branch_token, repo_token,
 
335
                    rev_id_utf8))
 
336
            self.assertEqual([rev_id_utf8], tree.branch.revision_history())
 
337
        finally:
 
338
            tree.branch.unlock()
 
339
 
 
340
    def test_revision_id_present2(self):
 
341
        backing = self.get_transport()
 
342
        request = smart.branch.SmartServerBranchRequestSetLastRevision(backing)
 
343
        tree = self.make_branch_and_memory_tree('.')
 
344
        tree.lock_write()
 
345
        tree.add('')
 
346
        rev_id_utf8 = u'\xc8'.encode('utf-8')
 
347
        r1 = tree.commit('1st commit', rev_id=rev_id_utf8)
 
348
        r2 = tree.commit('2nd commit')
 
349
        tree.unlock()
 
350
        tree.branch.set_revision_history([])
 
351
        branch_token = tree.branch.lock_write()
 
352
        repo_token = tree.branch.repository.lock_write()
 
353
        tree.branch.repository.unlock()
 
354
        try:
 
355
            self.assertEqual(
 
356
                SmartServerResponse(('ok',)),
 
357
                request.execute(
 
358
                    backing.local_abspath(''), branch_token, repo_token,
 
359
                    rev_id_utf8))
 
360
            self.assertEqual([rev_id_utf8], tree.branch.revision_history())
 
361
        finally:
 
362
            tree.branch.unlock()
 
363
 
 
364
 
 
365
class TestSmartServerBranchRequestLockWrite(tests.TestCaseWithTransport):
 
366
 
 
367
    def setUp(self):
 
368
        tests.TestCaseWithTransport.setUp(self)
 
369
        self.reduceLockdirTimeout()
1174
370
 
1175
371
    def test_lock_write_on_unlocked_branch(self):
1176
372
        backing = self.get_transport()
1177
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
1178
 
        branch = self.make_branch('.', format='knit')
 
373
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
 
374
        branch = self.make_branch('.')
1179
375
        repository = branch.repository
1180
 
        response = request.execute('')
 
376
        response = request.execute(backing.local_abspath(''))
1181
377
        branch_nonce = branch.control_files._lock.peek().get('nonce')
1182
378
        repository_nonce = repository.control_files._lock.peek().get('nonce')
1183
 
        self.assertEqual(smart_req.SmartServerResponse(
1184
 
                ('ok', branch_nonce, repository_nonce)),
1185
 
                         response)
 
379
        self.assertEqual(
 
380
            SmartServerResponse(('ok', branch_nonce, repository_nonce)),
 
381
            response)
1186
382
        # The branch (and associated repository) is now locked.  Verify that
1187
383
        # with a new branch object.
1188
384
        new_branch = repository.bzrdir.open_branch()
1189
385
        self.assertRaises(errors.LockContention, new_branch.lock_write)
1190
 
        # Cleanup
1191
 
        request = smart_branch.SmartServerBranchRequestUnlock(backing)
1192
 
        response = request.execute('', branch_nonce, repository_nonce)
1193
386
 
1194
387
    def test_lock_write_on_locked_branch(self):
1195
388
        backing = self.get_transport()
1196
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
 
389
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
1197
390
        branch = self.make_branch('.')
1198
 
        branch_token = branch.lock_write().branch_token
 
391
        branch.lock_write()
1199
392
        branch.leave_lock_in_place()
1200
393
        branch.unlock()
1201
 
        response = request.execute('')
 
394
        response = request.execute(backing.local_abspath(''))
1202
395
        self.assertEqual(
1203
 
            smart_req.SmartServerResponse(('LockContention',)), response)
1204
 
        # Cleanup
1205
 
        branch.lock_write(branch_token)
1206
 
        branch.dont_leave_lock_in_place()
1207
 
        branch.unlock()
 
396
            SmartServerResponse(('LockContention',)), response)
1208
397
 
1209
398
    def test_lock_write_with_tokens_on_locked_branch(self):
1210
399
        backing = self.get_transport()
1211
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
1212
 
        branch = self.make_branch('.', format='knit')
1213
 
        branch_token, repo_token = self.get_lock_tokens(branch)
 
400
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
 
401
        branch = self.make_branch('.')
 
402
        branch_token = branch.lock_write()
 
403
        repo_token = branch.repository.lock_write()
 
404
        branch.repository.unlock()
1214
405
        branch.leave_lock_in_place()
1215
406
        branch.repository.leave_lock_in_place()
1216
407
        branch.unlock()
1217
 
        response = request.execute('',
 
408
        response = request.execute(backing.local_abspath(''),
1218
409
                                   branch_token, repo_token)
1219
410
        self.assertEqual(
1220
 
            smart_req.SmartServerResponse(('ok', branch_token, repo_token)),
1221
 
            response)
1222
 
        # Cleanup
1223
 
        branch.repository.lock_write(repo_token)
1224
 
        branch.repository.dont_leave_lock_in_place()
1225
 
        branch.repository.unlock()
1226
 
        branch.lock_write(branch_token)
1227
 
        branch.dont_leave_lock_in_place()
1228
 
        branch.unlock()
 
411
            SmartServerResponse(('ok', branch_token, repo_token)), response)
1229
412
 
1230
413
    def test_lock_write_with_mismatched_tokens_on_locked_branch(self):
1231
414
        backing = self.get_transport()
1232
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
1233
 
        branch = self.make_branch('.', format='knit')
1234
 
        branch_token, repo_token = self.get_lock_tokens(branch)
 
415
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
 
416
        branch = self.make_branch('.')
 
417
        branch_token = branch.lock_write()
 
418
        repo_token = branch.repository.lock_write()
 
419
        branch.repository.unlock()
1235
420
        branch.leave_lock_in_place()
1236
421
        branch.repository.leave_lock_in_place()
1237
422
        branch.unlock()
1238
 
        response = request.execute('',
 
423
        response = request.execute(backing.local_abspath(''),
1239
424
                                   branch_token+'xxx', repo_token)
1240
425
        self.assertEqual(
1241
 
            smart_req.SmartServerResponse(('TokenMismatch',)), response)
1242
 
        # Cleanup
1243
 
        branch.repository.lock_write(repo_token)
1244
 
        branch.repository.dont_leave_lock_in_place()
1245
 
        branch.repository.unlock()
1246
 
        branch.lock_write(branch_token)
1247
 
        branch.dont_leave_lock_in_place()
1248
 
        branch.unlock()
 
426
            SmartServerResponse(('TokenMismatch',)), response)
1249
427
 
1250
428
    def test_lock_write_on_locked_repo(self):
1251
429
        backing = self.get_transport()
1252
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
1253
 
        branch = self.make_branch('.', format='knit')
1254
 
        repo = branch.repository
1255
 
        repo_token = repo.lock_write().repository_token
1256
 
        repo.leave_lock_in_place()
1257
 
        repo.unlock()
1258
 
        response = request.execute('')
 
430
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
 
431
        branch = self.make_branch('.')
 
432
        branch.repository.lock_write()
 
433
        branch.repository.leave_lock_in_place()
 
434
        branch.repository.unlock()
 
435
        response = request.execute(backing.local_abspath(''))
1259
436
        self.assertEqual(
1260
 
            smart_req.SmartServerResponse(('LockContention',)), response)
1261
 
        # Cleanup
1262
 
        repo.lock_write(repo_token)
1263
 
        repo.dont_leave_lock_in_place()
1264
 
        repo.unlock()
 
437
            SmartServerResponse(('LockContention',)), response)
1265
438
 
1266
439
    def test_lock_write_on_readonly_transport(self):
1267
440
        backing = self.get_readonly_transport()
1268
 
        request = smart_branch.SmartServerBranchRequestLockWrite(backing)
 
441
        request = smart.branch.SmartServerBranchRequestLockWrite(backing)
1269
442
        branch = self.make_branch('.')
1270
 
        root = self.get_transport().clone('/')
1271
 
        path = urlutils.relative_url(root.base, self.get_transport().base)
1272
 
        response = request.execute(path)
1273
 
        error_name, lock_str, why_str = response.args
1274
 
        self.assertFalse(response.is_successful())
1275
 
        self.assertEqual('LockFailed', error_name)
1276
 
 
1277
 
 
1278
 
class TestSmartServerBranchRequestUnlock(TestLockedBranch):
 
443
        response = request.execute('')
 
444
        self.assertEqual(
 
445
            SmartServerResponse(('UnlockableTransport',)), response)
 
446
 
 
447
 
 
448
class TestSmartServerBranchRequestUnlock(tests.TestCaseWithTransport):
1279
449
 
1280
450
    def setUp(self):
1281
 
        tests.TestCaseWithMemoryTransport.setUp(self)
 
451
        tests.TestCaseWithTransport.setUp(self)
 
452
        self.reduceLockdirTimeout()
1282
453
 
1283
454
    def test_unlock_on_locked_branch_and_repo(self):
1284
455
        backing = self.get_transport()
1285
 
        request = smart_branch.SmartServerBranchRequestUnlock(backing)
1286
 
        branch = self.make_branch('.', format='knit')
 
456
        request = smart.branch.SmartServerBranchRequestUnlock(backing)
 
457
        branch = self.make_branch('.')
1287
458
        # Lock the branch
1288
 
        branch_token, repo_token = self.get_lock_tokens(branch)
 
459
        branch_token = branch.lock_write()
 
460
        repo_token = branch.repository.lock_write()
 
461
        branch.repository.unlock()
1289
462
        # Unlock the branch (and repo) object, leaving the physical locks
1290
463
        # in place.
1291
464
        branch.leave_lock_in_place()
1292
465
        branch.repository.leave_lock_in_place()
1293
466
        branch.unlock()
1294
 
        response = request.execute('',
 
467
        response = request.execute(backing.local_abspath(''),
1295
468
                                   branch_token, repo_token)
1296
469
        self.assertEqual(
1297
 
            smart_req.SmartServerResponse(('ok',)), response)
 
470
            SmartServerResponse(('ok',)), response)
1298
471
        # The branch is now unlocked.  Verify that with a new branch
1299
472
        # object.
1300
473
        new_branch = branch.bzrdir.open_branch()
1303
476
 
1304
477
    def test_unlock_on_unlocked_branch_unlocked_repo(self):
1305
478
        backing = self.get_transport()
1306
 
        request = smart_branch.SmartServerBranchRequestUnlock(backing)
1307
 
        branch = self.make_branch('.', format='knit')
 
479
        request = smart.branch.SmartServerBranchRequestUnlock(backing)
 
480
        branch = self.make_branch('.')
1308
481
        response = request.execute(
1309
 
            '', 'branch token', 'repo token')
 
482
            backing.local_abspath(''), 'branch token', 'repo token')
1310
483
        self.assertEqual(
1311
 
            smart_req.SmartServerResponse(('TokenMismatch',)), response)
 
484
            SmartServerResponse(('TokenMismatch',)), response)
1312
485
 
1313
486
    def test_unlock_on_unlocked_branch_locked_repo(self):
1314
487
        backing = self.get_transport()
1315
 
        request = smart_branch.SmartServerBranchRequestUnlock(backing)
1316
 
        branch = self.make_branch('.', format='knit')
 
488
        request = smart.branch.SmartServerBranchRequestUnlock(backing)
 
489
        branch = self.make_branch('.')
1317
490
        # Lock the repository.
1318
 
        repo_token = branch.repository.lock_write().repository_token
 
491
        repo_token = branch.repository.lock_write()
1319
492
        branch.repository.leave_lock_in_place()
1320
493
        branch.repository.unlock()
1321
494
        # Issue branch lock_write request on the unlocked branch (with locked
1322
495
        # repo).
1323
 
        response = request.execute('', 'branch token', repo_token)
 
496
        response = request.execute(
 
497
            backing.local_abspath(''), 'branch token', repo_token)
1324
498
        self.assertEqual(
1325
 
            smart_req.SmartServerResponse(('TokenMismatch',)), response)
1326
 
        # Cleanup
1327
 
        branch.repository.lock_write(repo_token)
1328
 
        branch.repository.dont_leave_lock_in_place()
1329
 
        branch.repository.unlock()
1330
 
 
1331
 
 
1332
 
class TestSmartServerRepositoryRequest(tests.TestCaseWithMemoryTransport):
 
499
            SmartServerResponse(('TokenMismatch',)), response)
 
500
 
 
501
 
 
502
class TestSmartServerRepositoryRequest(tests.TestCaseWithTransport):
1333
503
 
1334
504
    def test_no_repository(self):
1335
505
        """Raise NoRepositoryPresent when there is a bzrdir and no repo."""
1338
508
        # its the exact path being looked at and the server is not
1339
509
        # searching.
1340
510
        backing = self.get_transport()
1341
 
        request = smart_repo.SmartServerRepositoryRequest(backing)
 
511
        request = smart.repository.SmartServerRepositoryRequest(backing)
1342
512
        self.make_repository('.', shared=True)
1343
513
        self.make_bzrdir('subdir')
1344
514
        self.assertRaises(errors.NoRepositoryPresent,
1345
 
            request.execute, 'subdir')
1346
 
 
1347
 
 
1348
 
class TestSmartServerRepositoryGetParentMap(tests.TestCaseWithMemoryTransport):
1349
 
 
1350
 
    def test_trivial_bzipped(self):
1351
 
        # This tests that the wire encoding is actually bzipped
1352
 
        backing = self.get_transport()
1353
 
        request = smart_repo.SmartServerRepositoryGetParentMap(backing)
1354
 
        tree = self.make_branch_and_memory_tree('.')
1355
 
 
1356
 
        self.assertEqual(None,
1357
 
            request.execute('', 'missing-id'))
1358
 
        # Note that it returns a body that is bzipped.
1359
 
        self.assertEqual(
1360
 
            smart_req.SuccessfulSmartServerResponse(('ok', ), bz2.compress('')),
1361
 
            request.do_body('\n\n0\n'))
1362
 
 
1363
 
    def test_trivial_include_missing(self):
1364
 
        backing = self.get_transport()
1365
 
        request = smart_repo.SmartServerRepositoryGetParentMap(backing)
1366
 
        tree = self.make_branch_and_memory_tree('.')
1367
 
 
1368
 
        self.assertEqual(None,
1369
 
            request.execute('', 'missing-id', 'include-missing:'))
1370
 
        self.assertEqual(
1371
 
            smart_req.SuccessfulSmartServerResponse(('ok', ),
1372
 
                bz2.compress('missing:missing-id')),
1373
 
            request.do_body('\n\n0\n'))
1374
 
 
1375
 
 
1376
 
class TestSmartServerRepositoryGetRevisionGraph(
1377
 
    tests.TestCaseWithMemoryTransport):
 
515
            request.execute, backing.local_abspath('subdir'))
 
516
 
 
517
 
 
518
class TestSmartServerRepositoryGetRevisionGraph(tests.TestCaseWithTransport):
1378
519
 
1379
520
    def test_none_argument(self):
1380
521
        backing = self.get_transport()
1381
 
        request = smart_repo.SmartServerRepositoryGetRevisionGraph(backing)
 
522
        request = smart.repository.SmartServerRepositoryGetRevisionGraph(backing)
1382
523
        tree = self.make_branch_and_memory_tree('.')
1383
524
        tree.lock_write()
1384
525
        tree.add('')
1389
530
        # the lines of revision_id->revision_parent_list has no guaranteed
1390
531
        # order coming out of a dict, so sort both our test and response
1391
532
        lines = sorted([' '.join([r2, r1]), r1])
1392
 
        response = request.execute('', '')
 
533
        response = request.execute(backing.local_abspath(''), '')
1393
534
        response.body = '\n'.join(sorted(response.body.split('\n')))
1394
535
 
1395
536
        self.assertEqual(
1396
 
            smart_req.SmartServerResponse(('ok', ), '\n'.join(lines)), response)
 
537
            SmartServerResponse(('ok', ), '\n'.join(lines)), response)
1397
538
 
1398
539
    def test_specific_revision_argument(self):
1399
540
        backing = self.get_transport()
1400
 
        request = smart_repo.SmartServerRepositoryGetRevisionGraph(backing)
 
541
        request = smart.repository.SmartServerRepositoryGetRevisionGraph(backing)
1401
542
        tree = self.make_branch_and_memory_tree('.')
1402
543
        tree.lock_write()
1403
544
        tree.add('')
1406
547
        r2 = tree.commit('2nd commit', rev_id=u'\xc8'.encode('utf-8'))
1407
548
        tree.unlock()
1408
549
 
1409
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), rev_id_utf8),
1410
 
            request.execute('', rev_id_utf8))
1411
 
 
 
550
        self.assertEqual(SmartServerResponse(('ok', ), rev_id_utf8),
 
551
            request.execute(backing.local_abspath(''), rev_id_utf8))
 
552
    
1412
553
    def test_no_such_revision(self):
1413
554
        backing = self.get_transport()
1414
 
        request = smart_repo.SmartServerRepositoryGetRevisionGraph(backing)
 
555
        request = smart.repository.SmartServerRepositoryGetRevisionGraph(backing)
1415
556
        tree = self.make_branch_and_memory_tree('.')
1416
557
        tree.lock_write()
1417
558
        tree.add('')
1419
560
        tree.unlock()
1420
561
 
1421
562
        # Note that it still returns body (of zero bytes).
1422
 
        self.assertEqual(smart_req.SmartServerResponse(
1423
 
                ('nosuchrevision', 'missingrevision', ), ''),
1424
 
                         request.execute('', 'missingrevision'))
1425
 
 
1426
 
 
1427
 
class TestSmartServerRepositoryGetRevIdForRevno(
1428
 
    tests.TestCaseWithMemoryTransport):
1429
 
 
1430
 
    def test_revno_found(self):
1431
 
        backing = self.get_transport()
1432
 
        request = smart_repo.SmartServerRepositoryGetRevIdForRevno(backing)
1433
 
        tree = self.make_branch_and_memory_tree('.')
1434
 
        tree.lock_write()
1435
 
        tree.add('')
1436
 
        rev1_id_utf8 = u'\xc8'.encode('utf-8')
1437
 
        rev2_id_utf8 = u'\xc9'.encode('utf-8')
1438
 
        tree.commit('1st commit', rev_id=rev1_id_utf8)
1439
 
        tree.commit('2nd commit', rev_id=rev2_id_utf8)
1440
 
        tree.unlock()
1441
 
 
1442
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', rev1_id_utf8)),
1443
 
            request.execute('', 1, (2, rev2_id_utf8)))
1444
 
 
1445
 
    def test_known_revid_missing(self):
1446
 
        backing = self.get_transport()
1447
 
        request = smart_repo.SmartServerRepositoryGetRevIdForRevno(backing)
1448
 
        repo = self.make_repository('.')
1449
 
        self.assertEqual(
1450
 
            smart_req.FailedSmartServerResponse(('nosuchrevision', 'ghost')),
1451
 
            request.execute('', 1, (2, 'ghost')))
1452
 
 
1453
 
    def test_history_incomplete(self):
1454
 
        backing = self.get_transport()
1455
 
        request = smart_repo.SmartServerRepositoryGetRevIdForRevno(backing)
1456
 
        parent = self.make_branch_and_memory_tree('parent', format='1.9')
1457
 
        parent.lock_write()
1458
 
        parent.add([''], ['TREE_ROOT'])
1459
 
        r1 = parent.commit(message='first commit')
1460
 
        r2 = parent.commit(message='second commit')
1461
 
        parent.unlock()
1462
 
        local = self.make_branch_and_memory_tree('local', format='1.9')
1463
 
        local.branch.pull(parent.branch)
1464
 
        local.set_parent_ids([r2])
1465
 
        r3 = local.commit(message='local commit')
1466
 
        local.branch.create_clone_on_transport(
1467
 
            self.get_transport('stacked'), stacked_on=self.get_url('parent'))
1468
 
        self.assertEqual(
1469
 
            smart_req.SmartServerResponse(('history-incomplete', 2, r2)),
1470
 
            request.execute('stacked', 1, (3, r3)))
1471
 
 
1472
 
 
1473
 
class GetStreamTestBase(tests.TestCaseWithMemoryTransport):
1474
 
 
1475
 
    def make_two_commit_repo(self):
1476
 
        tree = self.make_branch_and_memory_tree('.')
1477
 
        tree.lock_write()
1478
 
        tree.add('')
1479
 
        r1 = tree.commit('1st commit')
1480
 
        r2 = tree.commit('2nd commit', rev_id=u'\xc8'.encode('utf-8'))
1481
 
        tree.unlock()
1482
 
        repo = tree.branch.repository
1483
 
        return repo, r1, r2
1484
 
 
1485
 
 
1486
 
class TestSmartServerRepositoryGetStream(GetStreamTestBase):
1487
 
 
1488
 
    def test_ancestry_of(self):
1489
 
        """The search argument may be a 'ancestry-of' some heads'."""
1490
 
        backing = self.get_transport()
1491
 
        request = smart_repo.SmartServerRepositoryGetStream(backing)
1492
 
        repo, r1, r2 = self.make_two_commit_repo()
1493
 
        fetch_spec = ['ancestry-of', r2]
1494
 
        lines = '\n'.join(fetch_spec)
1495
 
        request.execute('', repo._format.network_name())
1496
 
        response = request.do_body(lines)
1497
 
        self.assertEqual(('ok',), response.args)
1498
 
        stream_bytes = ''.join(response.body_stream)
1499
 
        self.assertStartsWith(stream_bytes, 'Bazaar pack format 1')
1500
 
 
1501
 
    def test_search(self):
1502
 
        """The search argument may be a 'search' of some explicit keys."""
1503
 
        backing = self.get_transport()
1504
 
        request = smart_repo.SmartServerRepositoryGetStream(backing)
1505
 
        repo, r1, r2 = self.make_two_commit_repo()
1506
 
        fetch_spec = ['search', '%s %s' % (r1, r2), 'null:', '2']
1507
 
        lines = '\n'.join(fetch_spec)
1508
 
        request.execute('', repo._format.network_name())
1509
 
        response = request.do_body(lines)
1510
 
        self.assertEqual(('ok',), response.args)
1511
 
        stream_bytes = ''.join(response.body_stream)
1512
 
        self.assertStartsWith(stream_bytes, 'Bazaar pack format 1')
1513
 
 
1514
 
    def test_search_everything(self):
1515
 
        """A search of 'everything' returns a stream."""
1516
 
        backing = self.get_transport()
1517
 
        request = smart_repo.SmartServerRepositoryGetStream_1_19(backing)
1518
 
        repo, r1, r2 = self.make_two_commit_repo()
1519
 
        serialised_fetch_spec = 'everything'
1520
 
        request.execute('', repo._format.network_name())
1521
 
        response = request.do_body(serialised_fetch_spec)
1522
 
        self.assertEqual(('ok',), response.args)
1523
 
        stream_bytes = ''.join(response.body_stream)
1524
 
        self.assertStartsWith(stream_bytes, 'Bazaar pack format 1')
1525
 
 
1526
 
 
1527
 
class TestSmartServerRequestHasRevision(tests.TestCaseWithMemoryTransport):
 
563
        self.assertEqual(
 
564
            SmartServerResponse(('nosuchrevision', 'missingrevision', ), ''),
 
565
            request.execute(backing.local_abspath(''), 'missingrevision'))
 
566
 
 
567
 
 
568
class TestSmartServerRequestHasRevision(tests.TestCaseWithTransport):
1528
569
 
1529
570
    def test_missing_revision(self):
1530
571
        """For a missing revision, ('no', ) is returned."""
1531
572
        backing = self.get_transport()
1532
 
        request = smart_repo.SmartServerRequestHasRevision(backing)
 
573
        request = smart.repository.SmartServerRequestHasRevision(backing)
1533
574
        self.make_repository('.')
1534
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
1535
 
            request.execute('', 'revid'))
 
575
        self.assertEqual(SmartServerResponse(('no', )),
 
576
            request.execute(backing.local_abspath(''), 'revid'))
1536
577
 
1537
578
    def test_present_revision(self):
1538
579
        """For a present revision, ('yes', ) is returned."""
1539
580
        backing = self.get_transport()
1540
 
        request = smart_repo.SmartServerRequestHasRevision(backing)
 
581
        request = smart.repository.SmartServerRequestHasRevision(backing)
1541
582
        tree = self.make_branch_and_memory_tree('.')
1542
583
        tree.lock_write()
1543
584
        tree.add('')
1545
586
        r1 = tree.commit('a commit', rev_id=rev_id_utf8)
1546
587
        tree.unlock()
1547
588
        self.assertTrue(tree.branch.repository.has_revision(rev_id_utf8))
1548
 
        self.assertEqual(smart_req.SmartServerResponse(('yes', )),
1549
 
            request.execute('', rev_id_utf8))
1550
 
 
1551
 
 
1552
 
class TestSmartServerRepositoryGatherStats(tests.TestCaseWithMemoryTransport):
 
589
        self.assertEqual(SmartServerResponse(('yes', )),
 
590
            request.execute(backing.local_abspath(''), rev_id_utf8))
 
591
 
 
592
 
 
593
class TestSmartServerRepositoryGatherStats(tests.TestCaseWithTransport):
1553
594
 
1554
595
    def test_empty_revid(self):
1555
596
        """With an empty revid, we get only size an number and revisions"""
1556
597
        backing = self.get_transport()
1557
 
        request = smart_repo.SmartServerRepositoryGatherStats(backing)
 
598
        request = smart.repository.SmartServerRepositoryGatherStats(backing)
1558
599
        repository = self.make_repository('.')
1559
600
        stats = repository.gather_stats()
1560
 
        expected_body = 'revisions: 0\n'
1561
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), expected_body),
1562
 
                         request.execute('', '', 'no'))
 
601
        size = stats['size']
 
602
        expected_body = 'revisions: 0\nsize: %d\n' % size
 
603
        self.assertEqual(SmartServerResponse(('ok', ), expected_body),
 
604
                         request.execute(backing.local_abspath(''), '', 'no'))
1563
605
 
1564
606
    def test_revid_with_committers(self):
1565
607
        """For a revid we get more infos."""
1566
608
        backing = self.get_transport()
1567
609
        rev_id_utf8 = u'\xc8abc'.encode('utf-8')
1568
 
        request = smart_repo.SmartServerRepositoryGatherStats(backing)
 
610
        request = smart.repository.SmartServerRepositoryGatherStats(backing)
1569
611
        tree = self.make_branch_and_memory_tree('.')
1570
612
        tree.lock_write()
1571
613
        tree.add('')
1576
618
        tree.unlock()
1577
619
 
1578
620
        stats = tree.branch.repository.gather_stats()
 
621
        size = stats['size']
1579
622
        expected_body = ('firstrev: 123456.200 3600\n'
1580
623
                         'latestrev: 654321.400 0\n'
1581
 
                         'revisions: 2\n')
1582
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), expected_body),
1583
 
                         request.execute('',
 
624
                         'revisions: 2\n'
 
625
                         'size: %d\n' % size)
 
626
        self.assertEqual(SmartServerResponse(('ok', ), expected_body),
 
627
                         request.execute(backing.local_abspath(''),
1584
628
                                         rev_id_utf8, 'no'))
1585
629
 
1586
630
    def test_not_empty_repository_with_committers(self):
1587
631
        """For a revid and requesting committers we get the whole thing."""
1588
632
        backing = self.get_transport()
1589
633
        rev_id_utf8 = u'\xc8abc'.encode('utf-8')
1590
 
        request = smart_repo.SmartServerRepositoryGatherStats(backing)
 
634
        request = smart.repository.SmartServerRepositoryGatherStats(backing)
1591
635
        tree = self.make_branch_and_memory_tree('.')
1592
636
        tree.lock_write()
1593
637
        tree.add('')
1599
643
        tree.unlock()
1600
644
        stats = tree.branch.repository.gather_stats()
1601
645
 
 
646
        size = stats['size']
1602
647
        expected_body = ('committers: 2\n'
1603
648
                         'firstrev: 123456.200 3600\n'
1604
649
                         'latestrev: 654321.400 0\n'
1605
 
                         'revisions: 2\n')
1606
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), expected_body),
1607
 
                         request.execute('',
 
650
                         'revisions: 2\n'
 
651
                         'size: %d\n' % size)
 
652
        self.assertEqual(SmartServerResponse(('ok', ), expected_body),
 
653
                         request.execute(backing.local_abspath(''),
1608
654
                                         rev_id_utf8, 'yes'))
1609
655
 
1610
656
 
1611
 
class TestSmartServerRepositoryIsShared(tests.TestCaseWithMemoryTransport):
 
657
class TestSmartServerRepositoryIsShared(tests.TestCaseWithTransport):
1612
658
 
1613
659
    def test_is_shared(self):
1614
660
        """For a shared repository, ('yes', ) is returned."""
1615
661
        backing = self.get_transport()
1616
 
        request = smart_repo.SmartServerRepositoryIsShared(backing)
 
662
        request = smart.repository.SmartServerRepositoryIsShared(backing)
1617
663
        self.make_repository('.', shared=True)
1618
 
        self.assertEqual(smart_req.SmartServerResponse(('yes', )),
1619
 
            request.execute('', ))
 
664
        self.assertEqual(SmartServerResponse(('yes', )),
 
665
            request.execute(backing.local_abspath(''), ))
1620
666
 
1621
667
    def test_is_not_shared(self):
1622
668
        """For a shared repository, ('no', ) is returned."""
1623
669
        backing = self.get_transport()
1624
 
        request = smart_repo.SmartServerRepositoryIsShared(backing)
 
670
        request = smart.repository.SmartServerRepositoryIsShared(backing)
1625
671
        self.make_repository('.', shared=False)
1626
 
        self.assertEqual(smart_req.SmartServerResponse(('no', )),
1627
 
            request.execute('', ))
1628
 
 
1629
 
 
1630
 
class TestSmartServerRepositoryLockWrite(tests.TestCaseWithMemoryTransport):
 
672
        self.assertEqual(SmartServerResponse(('no', )),
 
673
            request.execute(backing.local_abspath(''), ))
 
674
 
 
675
 
 
676
class TestSmartServerRepositoryLockWrite(tests.TestCaseWithTransport):
 
677
 
 
678
    def setUp(self):
 
679
        tests.TestCaseWithTransport.setUp(self)
 
680
        self.reduceLockdirTimeout()
1631
681
 
1632
682
    def test_lock_write_on_unlocked_repo(self):
1633
683
        backing = self.get_transport()
1634
 
        request = smart_repo.SmartServerRepositoryLockWrite(backing)
1635
 
        repository = self.make_repository('.', format='knit')
1636
 
        response = request.execute('')
 
684
        request = smart.repository.SmartServerRepositoryLockWrite(backing)
 
685
        repository = self.make_repository('.')
 
686
        response = request.execute(backing.local_abspath(''))
1637
687
        nonce = repository.control_files._lock.peek().get('nonce')
1638
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', nonce)), response)
 
688
        self.assertEqual(SmartServerResponse(('ok', nonce)), response)
1639
689
        # The repository is now locked.  Verify that with a new repository
1640
690
        # object.
1641
691
        new_repo = repository.bzrdir.open_repository()
1642
692
        self.assertRaises(errors.LockContention, new_repo.lock_write)
1643
 
        # Cleanup
1644
 
        request = smart_repo.SmartServerRepositoryUnlock(backing)
1645
 
        response = request.execute('', nonce)
1646
693
 
1647
694
    def test_lock_write_on_locked_repo(self):
1648
695
        backing = self.get_transport()
1649
 
        request = smart_repo.SmartServerRepositoryLockWrite(backing)
1650
 
        repository = self.make_repository('.', format='knit')
1651
 
        repo_token = repository.lock_write().repository_token
 
696
        request = smart.repository.SmartServerRepositoryLockWrite(backing)
 
697
        repository = self.make_repository('.')
 
698
        repository.lock_write()
1652
699
        repository.leave_lock_in_place()
1653
700
        repository.unlock()
1654
 
        response = request.execute('')
 
701
        response = request.execute(backing.local_abspath(''))
1655
702
        self.assertEqual(
1656
 
            smart_req.SmartServerResponse(('LockContention',)), response)
1657
 
        # Cleanup
1658
 
        repository.lock_write(repo_token)
1659
 
        repository.dont_leave_lock_in_place()
1660
 
        repository.unlock()
 
703
            SmartServerResponse(('LockContention',)), response)
1661
704
 
1662
705
    def test_lock_write_on_readonly_transport(self):
1663
706
        backing = self.get_readonly_transport()
1664
 
        request = smart_repo.SmartServerRepositoryLockWrite(backing)
1665
 
        repository = self.make_repository('.', format='knit')
 
707
        request = smart.repository.SmartServerRepositoryLockWrite(backing)
 
708
        repository = self.make_repository('.')
1666
709
        response = request.execute('')
1667
 
        self.assertFalse(response.is_successful())
1668
 
        self.assertEqual('LockFailed', response.args[0])
1669
 
 
1670
 
 
1671
 
class TestInsertStreamBase(tests.TestCaseWithMemoryTransport):
1672
 
 
1673
 
    def make_empty_byte_stream(self, repo):
1674
 
        byte_stream = smart_repo._stream_to_byte_stream([], repo._format)
1675
 
        return ''.join(byte_stream)
1676
 
 
1677
 
 
1678
 
class TestSmartServerRepositoryInsertStream(TestInsertStreamBase):
1679
 
 
1680
 
    def test_insert_stream_empty(self):
1681
 
        backing = self.get_transport()
1682
 
        request = smart_repo.SmartServerRepositoryInsertStream(backing)
1683
 
        repository = self.make_repository('.')
1684
 
        response = request.execute('', '')
1685
 
        self.assertEqual(None, response)
1686
 
        response = request.do_chunk(self.make_empty_byte_stream(repository))
1687
 
        self.assertEqual(None, response)
1688
 
        response = request.do_end()
1689
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', )), response)
1690
 
 
1691
 
 
1692
 
class TestSmartServerRepositoryInsertStreamLocked(TestInsertStreamBase):
1693
 
 
1694
 
    def test_insert_stream_empty(self):
1695
 
        backing = self.get_transport()
1696
 
        request = smart_repo.SmartServerRepositoryInsertStreamLocked(
1697
 
            backing)
1698
 
        repository = self.make_repository('.', format='knit')
1699
 
        lock_token = repository.lock_write().repository_token
1700
 
        response = request.execute('', '', lock_token)
1701
 
        self.assertEqual(None, response)
1702
 
        response = request.do_chunk(self.make_empty_byte_stream(repository))
1703
 
        self.assertEqual(None, response)
1704
 
        response = request.do_end()
1705
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', )), response)
1706
 
        repository.unlock()
1707
 
 
1708
 
    def test_insert_stream_with_wrong_lock_token(self):
1709
 
        backing = self.get_transport()
1710
 
        request = smart_repo.SmartServerRepositoryInsertStreamLocked(
1711
 
            backing)
1712
 
        repository = self.make_repository('.', format='knit')
1713
 
        lock_token = repository.lock_write().repository_token
1714
 
        self.assertRaises(
1715
 
            errors.TokenMismatch, request.execute, '', '', 'wrong-token')
1716
 
        repository.unlock()
1717
 
 
1718
 
 
1719
 
class TestSmartServerRepositoryUnlock(tests.TestCaseWithMemoryTransport):
 
710
        self.assertEqual(
 
711
            SmartServerResponse(('UnlockableTransport',)), response)
 
712
 
 
713
 
 
714
class TestSmartServerRepositoryUnlock(tests.TestCaseWithTransport):
1720
715
 
1721
716
    def setUp(self):
1722
 
        tests.TestCaseWithMemoryTransport.setUp(self)
 
717
        tests.TestCaseWithTransport.setUp(self)
 
718
        self.reduceLockdirTimeout()
1723
719
 
1724
720
    def test_unlock_on_locked_repo(self):
1725
721
        backing = self.get_transport()
1726
 
        request = smart_repo.SmartServerRepositoryUnlock(backing)
1727
 
        repository = self.make_repository('.', format='knit')
1728
 
        token = repository.lock_write().repository_token
 
722
        request = smart.repository.SmartServerRepositoryUnlock(backing)
 
723
        repository = self.make_repository('.')
 
724
        token = repository.lock_write()
1729
725
        repository.leave_lock_in_place()
1730
726
        repository.unlock()
1731
 
        response = request.execute('', token)
 
727
        response = request.execute(backing.local_abspath(''), token)
1732
728
        self.assertEqual(
1733
 
            smart_req.SmartServerResponse(('ok',)), response)
 
729
            SmartServerResponse(('ok',)), response)
1734
730
        # The repository is now unlocked.  Verify that with a new repository
1735
731
        # object.
1736
732
        new_repo = repository.bzrdir.open_repository()
1739
735
 
1740
736
    def test_unlock_on_unlocked_repo(self):
1741
737
        backing = self.get_transport()
1742
 
        request = smart_repo.SmartServerRepositoryUnlock(backing)
1743
 
        repository = self.make_repository('.', format='knit')
1744
 
        response = request.execute('', 'some token')
 
738
        request = smart.repository.SmartServerRepositoryUnlock(backing)
 
739
        repository = self.make_repository('.')
 
740
        response = request.execute(backing.local_abspath(''), 'some token')
1745
741
        self.assertEqual(
1746
 
            smart_req.SmartServerResponse(('TokenMismatch',)), response)
1747
 
 
1748
 
 
1749
 
class TestSmartServerIsReadonly(tests.TestCaseWithMemoryTransport):
 
742
            SmartServerResponse(('TokenMismatch',)), response)
 
743
 
 
744
 
 
745
class TestSmartServerRepositoryTarball(tests.TestCaseWithTransport):
 
746
 
 
747
    def test_repository_tarball(self):
 
748
        backing = self.get_transport()
 
749
        request = smart.repository.SmartServerRepositoryTarball(backing)
 
750
        repository = self.make_repository('.')
 
751
        # make some extraneous junk in the repository directory which should
 
752
        # not be copied
 
753
        self.build_tree(['.bzr/repository/extra-junk'])
 
754
        response = request.execute(backing.local_abspath(''), 'bz2')
 
755
        self.assertEqual(('ok',), response.args)
 
756
        # body should be a tbz2
 
757
        body_file = StringIO(response.body)
 
758
        body_tar = tarfile.open('body_tar.tbz2', fileobj=body_file,
 
759
            mode='r|bz2')
 
760
        # let's make sure there are some key repository components inside it.
 
761
        # the tarfile returns directories with trailing slashes...
 
762
        names = set([n.rstrip('/') for n in body_tar.getnames()])
 
763
        self.assertTrue('.bzr/repository/lock' in names)
 
764
        self.assertTrue('.bzr/repository/format' in names)
 
765
        self.assertTrue('.bzr/repository/extra-junk' not in names,
 
766
            "extraneous file present in tar file")
 
767
 
 
768
 
 
769
class TestSmartServerIsReadonly(tests.TestCaseWithTransport):
1750
770
 
1751
771
    def test_is_readonly_no(self):
1752
772
        backing = self.get_transport()
1753
 
        request = smart_req.SmartServerIsReadonly(backing)
 
773
        request = smart.request.SmartServerIsReadonly(backing)
1754
774
        response = request.execute()
1755
775
        self.assertEqual(
1756
 
            smart_req.SmartServerResponse(('no',)), response)
 
776
            SmartServerResponse(('no',)), response)
1757
777
 
1758
778
    def test_is_readonly_yes(self):
1759
779
        backing = self.get_readonly_transport()
1760
 
        request = smart_req.SmartServerIsReadonly(backing)
 
780
        request = smart.request.SmartServerIsReadonly(backing)
1761
781
        response = request.execute()
1762
782
        self.assertEqual(
1763
 
            smart_req.SmartServerResponse(('yes',)), response)
1764
 
 
1765
 
 
1766
 
class TestSmartServerRepositorySetMakeWorkingTrees(
1767
 
    tests.TestCaseWithMemoryTransport):
1768
 
 
1769
 
    def test_set_false(self):
1770
 
        backing = self.get_transport()
1771
 
        repo = self.make_repository('.', shared=True)
1772
 
        repo.set_make_working_trees(True)
1773
 
        request_class = smart_repo.SmartServerRepositorySetMakeWorkingTrees
1774
 
        request = request_class(backing)
1775
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(('ok',)),
1776
 
            request.execute('', 'False'))
1777
 
        repo = repo.bzrdir.open_repository()
1778
 
        self.assertFalse(repo.make_working_trees())
1779
 
 
1780
 
    def test_set_true(self):
1781
 
        backing = self.get_transport()
1782
 
        repo = self.make_repository('.', shared=True)
1783
 
        repo.set_make_working_trees(False)
1784
 
        request_class = smart_repo.SmartServerRepositorySetMakeWorkingTrees
1785
 
        request = request_class(backing)
1786
 
        self.assertEqual(smart_req.SuccessfulSmartServerResponse(('ok',)),
1787
 
            request.execute('', 'True'))
1788
 
        repo = repo.bzrdir.open_repository()
1789
 
        self.assertTrue(repo.make_working_trees())
1790
 
 
1791
 
 
1792
 
class TestSmartServerPackRepositoryAutopack(tests.TestCaseWithTransport):
1793
 
 
1794
 
    def make_repo_needing_autopacking(self, path='.'):
1795
 
        # Make a repo in need of autopacking.
1796
 
        tree = self.make_branch_and_tree('.', format='pack-0.92')
1797
 
        repo = tree.branch.repository
1798
 
        # monkey-patch the pack collection to disable autopacking
1799
 
        repo._pack_collection._max_pack_count = lambda count: count
1800
 
        for x in range(10):
1801
 
            tree.commit('commit %s' % x)
1802
 
        self.assertEqual(10, len(repo._pack_collection.names()))
1803
 
        del repo._pack_collection._max_pack_count
1804
 
        return repo
1805
 
 
1806
 
    def test_autopack_needed(self):
1807
 
        repo = self.make_repo_needing_autopacking()
1808
 
        repo.lock_write()
1809
 
        self.addCleanup(repo.unlock)
1810
 
        backing = self.get_transport()
1811
 
        request = smart_packrepo.SmartServerPackRepositoryAutopack(
1812
 
            backing)
1813
 
        response = request.execute('')
1814
 
        self.assertEqual(smart_req.SmartServerResponse(('ok',)), response)
1815
 
        repo._pack_collection.reload_pack_names()
1816
 
        self.assertEqual(1, len(repo._pack_collection.names()))
1817
 
 
1818
 
    def test_autopack_not_needed(self):
1819
 
        tree = self.make_branch_and_tree('.', format='pack-0.92')
1820
 
        repo = tree.branch.repository
1821
 
        repo.lock_write()
1822
 
        self.addCleanup(repo.unlock)
1823
 
        for x in range(9):
1824
 
            tree.commit('commit %s' % x)
1825
 
        backing = self.get_transport()
1826
 
        request = smart_packrepo.SmartServerPackRepositoryAutopack(
1827
 
            backing)
1828
 
        response = request.execute('')
1829
 
        self.assertEqual(smart_req.SmartServerResponse(('ok',)), response)
1830
 
        repo._pack_collection.reload_pack_names()
1831
 
        self.assertEqual(9, len(repo._pack_collection.names()))
1832
 
 
1833
 
    def test_autopack_on_nonpack_format(self):
1834
 
        """A request to autopack a non-pack repo is a no-op."""
1835
 
        repo = self.make_repository('.', format='knit')
1836
 
        backing = self.get_transport()
1837
 
        request = smart_packrepo.SmartServerPackRepositoryAutopack(
1838
 
            backing)
1839
 
        response = request.execute('')
1840
 
        self.assertEqual(smart_req.SmartServerResponse(('ok',)), response)
1841
 
 
1842
 
 
1843
 
class TestSmartServerVfsGet(tests.TestCaseWithMemoryTransport):
1844
 
 
1845
 
    def test_unicode_path(self):
1846
 
        """VFS requests expect unicode paths to be escaped."""
1847
 
        filename = u'foo\N{INTERROBANG}'
1848
 
        filename_escaped = urlutils.escape(filename)
1849
 
        backing = self.get_transport()
1850
 
        request = vfs.GetRequest(backing)
1851
 
        backing.put_bytes_non_atomic(filename_escaped, 'contents')
1852
 
        self.assertEqual(smart_req.SmartServerResponse(('ok', ), 'contents'),
1853
 
            request.execute(filename_escaped))
 
783
            SmartServerResponse(('yes',)), response)
1854
784
 
1855
785
 
1856
786
class TestHandlers(tests.TestCase):
1857
787
    """Tests for the request.request_handlers object."""
1858
788
 
1859
 
    def test_all_registrations_exist(self):
1860
 
        """All registered request_handlers can be found."""
1861
 
        # If there's a typo in a register_lazy call, this loop will fail with
1862
 
        # an AttributeError.
1863
 
        for key, item in smart_req.request_handlers.iteritems():
1864
 
            pass
1865
 
 
1866
 
    def assertHandlerEqual(self, verb, handler):
1867
 
        self.assertEqual(smart_req.request_handlers.get(verb), handler)
1868
 
 
1869
789
    def test_registered_methods(self):
1870
790
        """Test that known methods are registered to the correct object."""
1871
 
        self.assertHandlerEqual('Branch.get_config_file',
1872
 
            smart_branch.SmartServerBranchGetConfigFile)
1873
 
        self.assertHandlerEqual('Branch.get_parent',
1874
 
            smart_branch.SmartServerBranchGetParent)
1875
 
        self.assertHandlerEqual('Branch.get_tags_bytes',
1876
 
            smart_branch.SmartServerBranchGetTagsBytes)
1877
 
        self.assertHandlerEqual('Branch.lock_write',
1878
 
            smart_branch.SmartServerBranchRequestLockWrite)
1879
 
        self.assertHandlerEqual('Branch.last_revision_info',
1880
 
            smart_branch.SmartServerBranchRequestLastRevisionInfo)
1881
 
        self.assertHandlerEqual('Branch.revision_history',
1882
 
            smart_branch.SmartServerRequestRevisionHistory)
1883
 
        self.assertHandlerEqual('Branch.set_config_option',
1884
 
            smart_branch.SmartServerBranchRequestSetConfigOption)
1885
 
        self.assertHandlerEqual('Branch.set_last_revision',
1886
 
            smart_branch.SmartServerBranchRequestSetLastRevision)
1887
 
        self.assertHandlerEqual('Branch.set_last_revision_info',
1888
 
            smart_branch.SmartServerBranchRequestSetLastRevisionInfo)
1889
 
        self.assertHandlerEqual('Branch.set_last_revision_ex',
1890
 
            smart_branch.SmartServerBranchRequestSetLastRevisionEx)
1891
 
        self.assertHandlerEqual('Branch.set_parent_location',
1892
 
            smart_branch.SmartServerBranchRequestSetParentLocation)
1893
 
        self.assertHandlerEqual('Branch.unlock',
1894
 
            smart_branch.SmartServerBranchRequestUnlock)
1895
 
        self.assertHandlerEqual('BzrDir.find_repository',
1896
 
            smart_dir.SmartServerRequestFindRepositoryV1)
1897
 
        self.assertHandlerEqual('BzrDir.find_repositoryV2',
1898
 
            smart_dir.SmartServerRequestFindRepositoryV2)
1899
 
        self.assertHandlerEqual('BzrDirFormat.initialize',
1900
 
            smart_dir.SmartServerRequestInitializeBzrDir)
1901
 
        self.assertHandlerEqual('BzrDirFormat.initialize_ex_1.16',
1902
 
            smart_dir.SmartServerRequestBzrDirInitializeEx)
1903
 
        self.assertHandlerEqual('BzrDir.cloning_metadir',
1904
 
            smart_dir.SmartServerBzrDirRequestCloningMetaDir)
1905
 
        self.assertHandlerEqual('BzrDir.get_config_file',
1906
 
            smart_dir.SmartServerBzrDirRequestConfigFile)
1907
 
        self.assertHandlerEqual('BzrDir.open_branch',
1908
 
            smart_dir.SmartServerRequestOpenBranch)
1909
 
        self.assertHandlerEqual('BzrDir.open_branchV2',
1910
 
            smart_dir.SmartServerRequestOpenBranchV2)
1911
 
        self.assertHandlerEqual('BzrDir.open_branchV3',
1912
 
            smart_dir.SmartServerRequestOpenBranchV3)
1913
 
        self.assertHandlerEqual('PackRepository.autopack',
1914
 
            smart_packrepo.SmartServerPackRepositoryAutopack)
1915
 
        self.assertHandlerEqual('Repository.gather_stats',
1916
 
            smart_repo.SmartServerRepositoryGatherStats)
1917
 
        self.assertHandlerEqual('Repository.get_parent_map',
1918
 
            smart_repo.SmartServerRepositoryGetParentMap)
1919
 
        self.assertHandlerEqual('Repository.get_rev_id_for_revno',
1920
 
            smart_repo.SmartServerRepositoryGetRevIdForRevno)
1921
 
        self.assertHandlerEqual('Repository.get_revision_graph',
1922
 
            smart_repo.SmartServerRepositoryGetRevisionGraph)
1923
 
        self.assertHandlerEqual('Repository.get_stream',
1924
 
            smart_repo.SmartServerRepositoryGetStream)
1925
 
        self.assertHandlerEqual('Repository.get_stream_1.19',
1926
 
            smart_repo.SmartServerRepositoryGetStream_1_19)
1927
 
        self.assertHandlerEqual('Repository.has_revision',
1928
 
            smart_repo.SmartServerRequestHasRevision)
1929
 
        self.assertHandlerEqual('Repository.insert_stream',
1930
 
            smart_repo.SmartServerRepositoryInsertStream)
1931
 
        self.assertHandlerEqual('Repository.insert_stream_locked',
1932
 
            smart_repo.SmartServerRepositoryInsertStreamLocked)
1933
 
        self.assertHandlerEqual('Repository.is_shared',
1934
 
            smart_repo.SmartServerRepositoryIsShared)
1935
 
        self.assertHandlerEqual('Repository.lock_write',
1936
 
            smart_repo.SmartServerRepositoryLockWrite)
1937
 
        self.assertHandlerEqual('Repository.tarball',
1938
 
            smart_repo.SmartServerRepositoryTarball)
1939
 
        self.assertHandlerEqual('Repository.unlock',
1940
 
            smart_repo.SmartServerRepositoryUnlock)
1941
 
        self.assertHandlerEqual('Transport.is_readonly',
1942
 
            smart_req.SmartServerIsReadonly)
1943
 
 
1944
 
 
1945
 
class SmartTCPServerHookTests(tests.TestCaseWithMemoryTransport):
1946
 
    """Tests for SmartTCPServer hooks."""
1947
 
 
1948
 
    def setUp(self):
1949
 
        super(SmartTCPServerHookTests, self).setUp()
1950
 
        self.server = server.SmartTCPServer(self.get_transport())
1951
 
 
1952
 
    def test_run_server_started_hooks(self):
1953
 
        """Test the server started hooks get fired properly."""
1954
 
        started_calls = []
1955
 
        server.SmartTCPServer.hooks.install_named_hook('server_started',
1956
 
            lambda backing_urls, url: started_calls.append((backing_urls, url)),
1957
 
            None)
1958
 
        started_ex_calls = []
1959
 
        server.SmartTCPServer.hooks.install_named_hook('server_started_ex',
1960
 
            lambda backing_urls, url: started_ex_calls.append((backing_urls, url)),
1961
 
            None)
1962
 
        self.server._sockname = ('example.com', 42)
1963
 
        self.server.run_server_started_hooks()
1964
 
        self.assertEquals(started_calls,
1965
 
            [([self.get_transport().base], 'bzr://example.com:42/')])
1966
 
        self.assertEquals(started_ex_calls,
1967
 
            [([self.get_transport().base], self.server)])
1968
 
 
1969
 
    def test_run_server_started_hooks_ipv6(self):
1970
 
        """Test that socknames can contain 4-tuples."""
1971
 
        self.server._sockname = ('::', 42, 0, 0)
1972
 
        started_calls = []
1973
 
        server.SmartTCPServer.hooks.install_named_hook('server_started',
1974
 
            lambda backing_urls, url: started_calls.append((backing_urls, url)),
1975
 
            None)
1976
 
        self.server.run_server_started_hooks()
1977
 
        self.assertEquals(started_calls,
1978
 
                [([self.get_transport().base], 'bzr://:::42/')])
1979
 
 
1980
 
    def test_run_server_stopped_hooks(self):
1981
 
        """Test the server stopped hooks."""
1982
 
        self.server._sockname = ('example.com', 42)
1983
 
        stopped_calls = []
1984
 
        server.SmartTCPServer.hooks.install_named_hook('server_stopped',
1985
 
            lambda backing_urls, url: stopped_calls.append((backing_urls, url)),
1986
 
            None)
1987
 
        self.server.run_server_stopped_hooks()
1988
 
        self.assertEquals(stopped_calls,
1989
 
            [([self.get_transport().base], 'bzr://example.com:42/')])
 
791
        self.assertEqual(
 
792
            smart.request.request_handlers.get('Branch.get_config_file'),
 
793
            smart.branch.SmartServerBranchGetConfigFile)
 
794
        self.assertEqual(
 
795
            smart.request.request_handlers.get('Branch.lock_write'),
 
796
            smart.branch.SmartServerBranchRequestLockWrite)
 
797
        self.assertEqual(
 
798
            smart.request.request_handlers.get('Branch.last_revision_info'),
 
799
            smart.branch.SmartServerBranchRequestLastRevisionInfo)
 
800
        self.assertEqual(
 
801
            smart.request.request_handlers.get('Branch.revision_history'),
 
802
            smart.branch.SmartServerRequestRevisionHistory)
 
803
        self.assertEqual(
 
804
            smart.request.request_handlers.get('Branch.set_last_revision'),
 
805
            smart.branch.SmartServerBranchRequestSetLastRevision)
 
806
        self.assertEqual(
 
807
            smart.request.request_handlers.get('Branch.unlock'),
 
808
            smart.branch.SmartServerBranchRequestUnlock)
 
809
        self.assertEqual(
 
810
            smart.request.request_handlers.get('BzrDir.find_repository'),
 
811
            smart.bzrdir.SmartServerRequestFindRepository)
 
812
        self.assertEqual(
 
813
            smart.request.request_handlers.get('BzrDirFormat.initialize'),
 
814
            smart.bzrdir.SmartServerRequestInitializeBzrDir)
 
815
        self.assertEqual(
 
816
            smart.request.request_handlers.get('BzrDir.open_branch'),
 
817
            smart.bzrdir.SmartServerRequestOpenBranch)
 
818
        self.assertEqual(
 
819
            smart.request.request_handlers.get('Repository.gather_stats'),
 
820
            smart.repository.SmartServerRepositoryGatherStats)
 
821
        self.assertEqual(
 
822
            smart.request.request_handlers.get('Repository.get_revision_graph'),
 
823
            smart.repository.SmartServerRepositoryGetRevisionGraph)
 
824
        self.assertEqual(
 
825
            smart.request.request_handlers.get('Repository.has_revision'),
 
826
            smart.repository.SmartServerRequestHasRevision)
 
827
        self.assertEqual(
 
828
            smart.request.request_handlers.get('Repository.is_shared'),
 
829
            smart.repository.SmartServerRepositoryIsShared)
 
830
        self.assertEqual(
 
831
            smart.request.request_handlers.get('Repository.lock_write'),
 
832
            smart.repository.SmartServerRepositoryLockWrite)
 
833
        self.assertEqual(
 
834
            smart.request.request_handlers.get('Repository.unlock'),
 
835
            smart.repository.SmartServerRepositoryUnlock)
 
836
        self.assertEqual(
 
837
            smart.request.request_handlers.get('Repository.tarball'),
 
838
            smart.repository.SmartServerRepositoryTarball)
 
839
        self.assertEqual(
 
840
            smart.request.request_handlers.get('Transport.is_readonly'),
 
841
            smart.request.SmartServerIsReadonly)