217
215
self.assertEqual([], self._logged_reports)
217
def test_32_lock_wait_succeed(self):
218
"""Succeed when trying to acquire a lock that gets released
220
One thread holds on a lock and then releases it; another
223
t = self.get_transport()
224
lf1 = LockDir(t, 'test_lock')
228
def wait_and_unlock():
231
unlocker = Thread(target=wait_and_unlock)
234
lf2 = LockDir(t, 'test_lock')
235
self.setup_log_reporter(lf2)
238
lf2.wait_lock(timeout=0.4, poll=0.1)
240
self.assertTrue(after - before <= 1.0)
244
# There should be only 1 report, even though it should have to
246
lock_base = lf2.transport.abspath(lf2.path)
247
self.assertEqual(1, len(self._logged_reports))
248
self.assertEqual('%s %s\n'
250
'Will continue to try until %s\n',
251
self._logged_reports[0][0])
252
args = self._logged_reports[0][1]
253
self.assertEqual('Unable to obtain', args[0])
254
self.assertEqual('lock %s' % (lock_base,), args[1])
255
self.assertStartsWith(args[2], 'held by ')
256
self.assertStartsWith(args[3], 'locked ')
257
self.assertEndsWith(args[3], ' ago')
258
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
260
def test_33_wait(self):
261
"""Succeed when waiting on a lock that gets released
263
The difference from test_32_lock_wait_succeed is that the second
264
caller does not actually acquire the lock, but just waits for it
265
to be released. This is done over a readonly transport.
267
t = self.get_transport()
268
lf1 = LockDir(t, 'test_lock')
272
def wait_and_unlock():
275
unlocker = Thread(target=wait_and_unlock)
278
lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
280
# wait but don't lock
281
lf2.wait(timeout=0.4, poll=0.1)
283
self.assertTrue(after - before <= 1.0)
287
def test_34_lock_write_waits(self):
288
"""LockDir.lock_write() will wait for the lock."""
289
# the test suite sets the default to 0 to make deadlocks fail fast.
290
# change it for this test, as we want to try a manual deadlock.
291
bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
292
t = self.get_transport()
293
lf1 = LockDir(t, 'test_lock')
297
def wait_and_unlock():
300
unlocker = Thread(target=wait_and_unlock)
303
lf2 = LockDir(t, 'test_lock')
304
self.setup_log_reporter(lf2)
312
# There should be only 1 report, even though it should have to
314
lock_base = lf2.transport.abspath(lf2.path)
315
self.assertEqual(1, len(self._logged_reports))
316
self.assertEqual('%s %s\n'
318
'Will continue to try until %s\n',
319
self._logged_reports[0][0])
320
args = self._logged_reports[0][1]
321
self.assertEqual('Unable to obtain', args[0])
322
self.assertEqual('lock %s' % (lock_base,), args[1])
323
self.assertStartsWith(args[2], 'held by ')
324
self.assertStartsWith(args[3], 'locked ')
325
self.assertEndsWith(args[3], ' ago')
326
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
328
def test_35_wait_lock_changing(self):
329
"""LockDir.wait_lock() will report if the lock changes underneath.
331
This is the stages we want to happen:
333
0) Synchronization locks are created and locked.
334
1) Lock1 obtains the lockdir, and releases the 'check' lock.
335
2) Lock2 grabs the 'check' lock, and checks the lockdir.
336
It sees the lockdir is already acquired, reports the fact,
337
and unsets the 'checked' lock.
338
3) Thread1 blocks on acquiring the 'checked' lock, and then tells
339
Lock1 to release and acquire the lockdir. This resets the 'check'
341
4) Lock2 acquires the 'check' lock, and checks again. It notices
342
that the holder of the lock has changed, and so reports a new
344
5) Thread1 blocks on the 'checked' lock, this time, it completely
345
unlocks the lockdir, allowing Lock2 to acquire the lock.
348
wait_to_check_lock = Lock()
349
wait_until_checked_lock = Lock()
351
wait_to_check_lock.acquire()
352
wait_until_checked_lock.acquire()
353
note('locked check and checked locks')
355
class LockDir1(LockDir):
356
"""Use the synchronization points for the first lock."""
358
def attempt_lock(self):
359
# Once we have acquired the lock, it is okay for
360
# the other lock to check it
362
return super(LockDir1, self).attempt_lock()
364
note('lock1: releasing check lock')
365
wait_to_check_lock.release()
367
class LockDir2(LockDir):
368
"""Use the synchronization points for the second lock."""
370
def attempt_lock(self):
371
note('lock2: waiting for check lock')
372
wait_to_check_lock.acquire()
373
note('lock2: acquired check lock')
375
return super(LockDir2, self).attempt_lock()
377
note('lock2: releasing checked lock')
378
wait_until_checked_lock.release()
380
t = self.get_transport()
381
lf1 = LockDir1(t, 'test_lock')
384
lf2 = LockDir2(t, 'test_lock')
385
self.setup_log_reporter(lf2)
387
def wait_and_switch():
389
# Block until lock2 has had a chance to check
390
note('lock1: waiting 1 for checked lock')
391
wait_until_checked_lock.acquire()
392
note('lock1: acquired for checked lock')
393
note('lock1: released lockdir')
395
note('lock1: acquiring lockdir')
396
# Create a new nonce, so the lock looks different.
397
lf1.nonce = osutils.rand_chars(20)
399
note('lock1: acquired lockdir')
401
# Block until lock2 has peeked again
402
note('lock1: waiting 2 for checked lock')
403
wait_until_checked_lock.acquire()
404
note('lock1: acquired for checked lock')
405
# Now unlock, and let lock 2 grab the lock
407
wait_to_check_lock.release()
409
unlocker = Thread(target=wait_and_switch)
412
# Wait and play against the other thread
413
lf2.wait_lock(timeout=1.0, poll=0.01)
418
# There should be 2 reports, because the lock changed
419
lock_base = lf2.transport.abspath(lf2.path)
420
self.assertEqual(2, len(self._logged_reports))
422
self.assertEqual('%s %s\n'
424
'Will continue to try until %s\n',
425
self._logged_reports[0][0])
426
args = self._logged_reports[0][1]
427
self.assertEqual('Unable to obtain', args[0])
428
self.assertEqual('lock %s' % (lock_base,), args[1])
429
self.assertStartsWith(args[2], 'held by ')
430
self.assertStartsWith(args[3], 'locked ')
431
self.assertEndsWith(args[3], ' ago')
432
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
434
self.assertEqual('%s %s\n'
436
'Will continue to try until %s\n',
437
self._logged_reports[1][0])
438
args = self._logged_reports[1][1]
439
self.assertEqual('Lock owner changed for', args[0])
440
self.assertEqual('lock %s' % (lock_base,), args[1])
441
self.assertStartsWith(args[2], 'held by ')
442
self.assertStartsWith(args[3], 'locked ')
443
self.assertEndsWith(args[3], ' ago')
444
self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
219
446
def test_40_confirm_easy(self):
220
447
"""Confirm a lock that's already held"""
221
448
t = self.get_transport()
222
449
lf1 = LockDir(t, 'test_lock')
224
451
lf1.attempt_lock()
225
self.addCleanup(lf1.unlock)
228
454
def test_41_confirm_not_held(self):
330
551
# do this without IO redirection to ensure it doesn't prompt.
331
552
self.assertRaises(AssertionError, ld1.break_lock)
332
553
orig_factory = bzrlib.ui.ui_factory
333
bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
554
# silent ui - no need for stdout
555
bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
556
bzrlib.ui.ui_factory.stdin = StringIO("y\n")
336
559
self.assertRaises(LockBroken, ld1.unlock)
338
561
bzrlib.ui.ui_factory = orig_factory
340
def test_break_lock_corrupt_info(self):
341
"""break_lock works even if the info file is corrupt (and tells the UI
345
ld2 = self.get_lock()
348
ld.transport.put_bytes_non_atomic('test_lock/held/info', '\0')
350
class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
354
def get_boolean(self, prompt):
355
self.prompts.append(('boolean', prompt))
358
ui = LoggingUIFactory()
359
self.overrideAttr(bzrlib.ui, 'ui_factory', ui)
361
self.assertLength(1, ui.prompts)
362
self.assertEqual('boolean', ui.prompts[0][0])
363
self.assertStartsWith(ui.prompts[0][1], 'Break (corrupt LockDir')
364
self.assertRaises(LockBroken, ld.unlock)
366
def test_break_lock_missing_info(self):
367
"""break_lock works even if the info file is missing (and tells the UI
371
ld2 = self.get_lock()
374
ld.transport.delete('test_lock/held/info')
376
class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
380
def get_boolean(self, prompt):
381
self.prompts.append(('boolean', prompt))
384
ui = LoggingUIFactory()
385
orig_factory = bzrlib.ui.ui_factory
386
bzrlib.ui.ui_factory = ui
389
self.assertRaises(LockBroken, ld.unlock)
390
self.assertLength(0, ui.prompts)
392
bzrlib.ui.ui_factory = orig_factory
393
# Suppress warnings due to ld not being unlocked
394
# XXX: if lock_broken hook was invoked in this case, this hack would
395
# not be necessary. - Andrew Bennetts, 2010-09-06.
396
del self._lock_actions[:]
398
563
def test_create_missing_base_directory(self):
399
564
"""If LockDir.path doesn't exist, it can be created
443
610
def test_lock_permission(self):
444
self.requireFeature(features.not_running_as_root)
445
611
if not osutils.supports_posix_readonly():
446
612
raise tests.TestSkipped('Cannot induce a permission failure')
447
613
ld1 = self.get_lock()
448
614
lock_path = ld1.transport.local_abspath('test_lock')
449
615
os.mkdir(lock_path)
450
616
osutils.make_readonly(lock_path)
451
self.assertRaises(errors.LockFailed, ld1.attempt_lock)
453
def test_lock_by_token(self):
454
ld1 = self.get_lock()
455
token = ld1.lock_write()
456
self.addCleanup(ld1.unlock)
457
self.assertNotEqual(None, token)
458
ld2 = self.get_lock()
459
t2 = ld2.lock_write(token)
460
self.addCleanup(ld2.unlock)
461
self.assertEqual(token, t2)
463
def test_lock_with_buggy_rename(self):
464
# test that lock acquisition handles servers which pretend they
465
# renamed correctly but that actually fail
466
t = transport.get_transport('brokenrename+' + self.get_url())
467
ld1 = LockDir(t, 'test_lock')
470
ld2 = LockDir(t, 'test_lock')
471
# we should fail to lock
472
e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
473
# now the original caller should succeed in unlocking
475
# and there should be nothing left over
476
self.assertEquals([], t.list_dir('test_lock'))
478
def test_failed_lock_leaves_no_trash(self):
479
# if we fail to acquire the lock, we don't leave pending directories
480
# behind -- https://bugs.launchpad.net/bzr/+bug/109169
481
ld1 = self.get_lock()
482
ld2 = self.get_lock()
483
# should be nothing before we start
485
t = self.get_transport().clone('test_lock')
488
self.assertEquals(a, t.list_dir('.'))
491
# when held, that's all we see
493
self.addCleanup(ld1.unlock)
495
# second guy should fail
496
self.assertRaises(errors.LockContention, ld2.attempt_lock)
500
def test_no_lockdir_info(self):
501
"""We can cope with empty info files."""
502
# This seems like a fairly common failure case - see
503
# <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
504
# Processes are often interrupted after opening the file
505
# before the actual contents are committed.
506
t = self.get_transport()
508
t.mkdir('test_lock/held')
509
t.put_bytes('test_lock/held/info', '')
510
lf = LockDir(t, 'test_lock')
512
formatted_info = info.to_readable_dict()
514
dict(user='<unknown>', hostname='<unknown>', pid='<unknown>',
515
time_ago='(unknown)'),
518
def test_corrupt_lockdir_info(self):
519
"""We can cope with corrupt (and thus unparseable) info files."""
520
# This seems like a fairly common failure case too - see
521
# <https://bugs.launchpad.net/bzr/+bug/619872> for instance.
522
# In particular some systems tend to fill recently created files with
523
# nul bytes after recovering from a system crash.
524
t = self.get_transport()
526
t.mkdir('test_lock/held')
527
t.put_bytes('test_lock/held/info', '\0')
528
lf = LockDir(t, 'test_lock')
529
self.assertRaises(errors.LockCorrupt, lf.peek)
530
# Currently attempt_lock gives LockContention, but LockCorrupt would be
531
# a reasonable result too.
533
(errors.LockCorrupt, errors.LockContention), lf.attempt_lock)
534
self.assertRaises(errors.LockCorrupt, lf.validate_token, 'fake token')
536
def test_missing_lockdir_info(self):
537
"""We can cope with absent info files."""
538
t = self.get_transport()
540
t.mkdir('test_lock/held')
541
lf = LockDir(t, 'test_lock')
542
# In this case we expect the 'not held' result from peek, because peek
543
# cannot be expected to notice that there is a 'held' directory with no
545
self.assertEqual(None, lf.peek())
546
# And lock/unlock may work or give LockContention (but not any other
550
except LockContention:
551
# LockContention is ok, and expected on Windows
554
# no error is ok, and expected on POSIX (because POSIX allows
555
# os.rename over an empty directory).
557
# Currently raises TokenMismatch, but LockCorrupt would be reasonable
560
(errors.TokenMismatch, errors.LockCorrupt),
561
lf.validate_token, 'fake token')
564
class TestLockDirHooks(TestCaseWithTransport):
567
super(TestLockDirHooks, self).setUp()
571
return LockDir(self.get_transport(), 'test_lock')
573
def record_hook(self, result):
574
self._calls.append(result)
576
def test_LockDir_acquired_success(self):
577
# the LockDir.lock_acquired hook fires when a lock is acquired.
578
LockDir.hooks.install_named_hook('lock_acquired',
579
self.record_hook, 'record_hook')
582
self.assertEqual([], self._calls)
583
result = ld.attempt_lock()
584
lock_path = ld.transport.abspath(ld.path)
585
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
587
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
589
def test_LockDir_acquired_fail(self):
590
# the LockDir.lock_acquired hook does not fire on failure.
593
ld2 = self.get_lock()
595
# install a lock hook now, when the disk lock is locked
596
LockDir.hooks.install_named_hook('lock_acquired',
597
self.record_hook, 'record_hook')
598
self.assertRaises(errors.LockContention, ld.attempt_lock)
599
self.assertEqual([], self._calls)
601
self.assertEqual([], self._calls)
603
def test_LockDir_released_success(self):
604
# the LockDir.lock_released hook fires when a lock is acquired.
605
LockDir.hooks.install_named_hook('lock_released',
606
self.record_hook, 'record_hook')
609
self.assertEqual([], self._calls)
610
result = ld.attempt_lock()
611
self.assertEqual([], self._calls)
613
lock_path = ld.transport.abspath(ld.path)
614
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
616
def test_LockDir_released_fail(self):
617
# the LockDir.lock_released hook does not fire on failure.
620
ld2 = self.get_lock()
622
ld2.force_break(ld2.peek())
623
LockDir.hooks.install_named_hook('lock_released',
624
self.record_hook, 'record_hook')
625
self.assertRaises(LockBroken, ld.unlock)
626
self.assertEqual([], self._calls)
628
def test_LockDir_broken_success(self):
629
# the LockDir.lock_broken hook fires when a lock is broken.
632
ld2 = self.get_lock()
633
result = ld.attempt_lock()
634
LockDir.hooks.install_named_hook('lock_broken',
635
self.record_hook, 'record_hook')
636
ld2.force_break(ld2.peek())
637
lock_path = ld.transport.abspath(ld.path)
638
self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
640
def test_LockDir_broken_failure(self):
641
# the LockDir.lock_broken hook does not fires when a lock is already
645
ld2 = self.get_lock()
646
result = ld.attempt_lock()
647
holder_info = ld2.peek()
649
LockDir.hooks.install_named_hook('lock_broken',
650
self.record_hook, 'record_hook')
651
ld2.force_break(holder_info)
652
lock_path = ld.transport.abspath(ld.path)
653
self.assertEqual([], self._calls)
656
class TestLockHeldInfo(TestCase):
657
"""Can get information about the lock holder, and detect whether they're
661
info = LockHeldInfo.for_this_process(None)
662
self.assertContainsRe(repr(info), r"LockHeldInfo\(.*\)")
664
def test_unicode(self):
665
info = LockHeldInfo.for_this_process(None)
666
self.assertContainsRe(unicode(info),
667
r'held by .* on .* \(process #\d+\), acquired .* ago')
669
def test_is_locked_by_this_process(self):
670
info = LockHeldInfo.for_this_process(None)
671
self.assertTrue(info.is_locked_by_this_process())
673
def test_is_not_locked_by_this_process(self):
674
info = LockHeldInfo.for_this_process(None)
675
info.info_dict['pid'] = '123123123123123'
676
self.assertFalse(info.is_locked_by_this_process())
678
def test_lock_holder_live_process(self):
679
"""Detect that the holder (this process) is still running."""
680
info = LockHeldInfo.for_this_process(None)
681
self.assertFalse(info.is_lock_holder_known_dead())
683
def test_lock_holder_dead_process(self):
684
"""Detect that the holder (this process) is still running."""
685
self.overrideAttr(lockdir, 'get_host_name',
686
lambda: 'aproperhostname')
687
info = LockHeldInfo.for_this_process(None)
688
info.info_dict['pid'] = '123123123'
689
self.assertTrue(info.is_lock_holder_known_dead())
691
def test_lock_holder_other_machine(self):
692
"""The lock holder isn't here so we don't know if they're alive."""
693
info = LockHeldInfo.for_this_process(None)
694
info.info_dict['hostname'] = 'egg.example.com'
695
info.info_dict['pid'] = '123123123'
696
self.assertFalse(info.is_lock_holder_known_dead())
698
def test_lock_holder_other_user(self):
699
"""Only auto-break locks held by this user."""
700
info = LockHeldInfo.for_this_process(None)
701
info.info_dict['user'] = 'notme@example.com'
702
info.info_dict['pid'] = '123123123'
703
self.assertFalse(info.is_lock_holder_known_dead())
705
def test_no_good_hostname(self):
706
"""Correctly handle ambiguous hostnames.
708
If the lock's recorded with just 'localhost' we can't really trust
709
it's the same 'localhost'. (There are quite a few of them. :-)
710
So even if the process is known not to be alive, we can't say that's
713
self.overrideAttr(lockdir, 'get_host_name',
715
info = LockHeldInfo.for_this_process(None)
716
info.info_dict['pid'] = '123123123'
717
self.assertFalse(info.is_lock_holder_known_dead())
720
class TestStaleLockDir(TestCaseWithTransport):
721
"""Can automatically break stale locks.
723
:see: https://bugs.launchpad.net/bzr/+bug/220464
726
def test_auto_break_stale_lock(self):
727
"""Locks safely known to be stale are just cleaned up.
729
This generates a warning but no other user interaction.
731
self.overrideAttr(lockdir, 'get_host_name',
732
lambda: 'aproperhostname')
733
# This is off by default at present; see the discussion in the bug.
734
# If you change the default, don't forget to update the docs.
735
config.GlobalConfig().set_user_option('locks.steal_dead', True)
736
# Create a lock pretending to come from a different nonexistent
737
# process on the same machine.
738
l1 = LockDir(self.get_transport(), 'a',
739
extra_holder_info={'pid': '12312313'})
740
token_1 = l1.attempt_lock()
741
l2 = LockDir(self.get_transport(), 'a')
742
token_2 = l2.attempt_lock()
743
# l1 will notice its lock was stolen.
744
self.assertRaises(errors.LockBroken,
748
def test_auto_break_stale_lock_configured_off(self):
749
"""Automatic breaking can be turned off"""
750
l1 = LockDir(self.get_transport(), 'a',
751
extra_holder_info={'pid': '12312313'})
752
token_1 = l1.attempt_lock()
753
self.addCleanup(l1.unlock)
754
l2 = LockDir(self.get_transport(), 'a')
755
# This fails now, because dead lock breaking is off by default.
756
self.assertRaises(LockContention,
758
# and it's in fact not broken
617
self.assertRaises(errors.PermissionDenied, ld1.attempt_lock)