← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/hooks.py

  • Committer: v.ladeuil+lp at free
  • Date: 2007-05-15 17:40:32 UTC
  • mto: (2485.8.44 bzr.connection.sharing)
  • mto: This revision was merged to the branch mainline in revision 2646.
  • Revision ID: v.ladeuil+lp@free.fr-20070515174032-qzdkangpv29l9e7g
Add a test that check that init connect only once. It fails.

* __init__.py:
(test_suite): Register the new test class.

* test_init.py: 
(InstrumentedTransport): A transport that can track connections.
(TransportHooks): Transport specific hooks.
(TestInit): Iniit command behavior tests.

* ftp.py:
(FtpTransport.__init__): Mark place that need fixing regarding
transport connection sharing

* builtins.py:
(cmd_init.run): Mark places that need fixing regarding transport
connection sharing.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/hooks.py
31
31
    FOO hook is triggered.
32
32
    """
33
33
 
34
 
    def __init__(self):
35
 
        dict.__init__(self)
36
 
        self._callable_names = {}
37
 
 
38
 
    def get_hook_name(self, a_callable):
39
 
        """Get the name for a_callable for UI display.
40
 
 
41
 
        If no name has been registered, the string 'No hook name' is returned.
42
 
        We use a fixed string rather than repr or the callables module because
43
 
        the code names are rarely meaningful for end users and this is not 
44
 
        intended for debugging.
45
 
        """
46
 
        return self._callable_names.get(a_callable, "No hook name")
47
 
 
48
34
    def install_hook(self, hook_name, a_callable):
49
35
        """Install a_callable in to the hook hook_name.
50
36
 
58
44
            self[hook_name].append(a_callable)
59
45
        except KeyError:
60
46
            raise errors.UnknownHook(self.__class__.__name__, hook_name)
61
 
 
62
 
    def name_hook(self, a_callable, name):
63
 
        """Associate name with a_callable to show users what is running."""
64
 
        self._callable_names[a_callable] = name