← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_bad_files.py

  • Committer: Andrew Bennetts
  • Date: 2007-03-26 06:24:01 UTC
  • mto: This revision was merged to the branch mainline in revision 2376.
  • Revision ID: andrew.bennetts@canonical.com-20070326062401-k3nbefzje5332jaf
Deal with review comments from Robert:

  * Add my name to the NEWS file
  * Move the test case to a new module in branch_implementations
  * Remove revision_history cruft from identitymap and test_identitymap
  * Improve some docstrings

Also, this fixes a bug where revision_history was not returning a copy of the
cached data, allowing the cache to be corrupted.

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/tests/test_bad_files.py
25
25
    errors,
26
26
    )
27
27
from bzrlib.status import show_tree_status
28
 
from bzrlib.tests import OsFifoFeature, TestCaseWithTransport
 
28
from bzrlib.tests import TestCaseWithTransport
29
29
 
30
30
 
31
31
def verify_status(tester, tree, value):
40
40
 
41
41
    def test_bad_files(self):
42
42
        """Test that bzr will ignore files it doesn't like"""
43
 
        self.requireFeature(OsFifoFeature)
 
43
        if getattr(os, 'mkfifo', None) is None:
 
44
            # TODO: Ultimately this should be TestSkipped
 
45
            # or PlatformDeficiency
 
46
            return
44
47
 
45
48
        wt = self.make_branch_and_tree('.')
46
49
        b = wt.branch
67
70
                           ])
68
71
 
69
72
        # We should raise an error if we are adding a bogus file
70
 
        self.assertRaises(errors.BadFileKindError, wt.smart_add, ['a-fifo'])
 
73
        self.assertRaises(errors.BadFileKindError,
 
74
                          add.smart_add_tree, wt, ['a-fifo'])
71
75
 
72
76
        # And the list of files shouldn't have been modified
73
77
        verify_status(self, wt,
78
82
 
79
83
        # Make sure smart_add can handle having a bogus
80
84
        # file in the way
81
 
        wt.smart_add([])
 
85
        add.smart_add_tree(wt, ['.'])
82
86
        verify_status(self, wt,
83
87
                          ['added:\n',
84
88
                           '  six\n',