~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/tests/test_revisionnamespaces.py

  • Committer: Aaron Bentley
  • Date: 2007-01-20 01:44:46 UTC
  • mto: This revision was merged to the branch mainline in revision 2241.
  • Revision ID: aaron.bentley@utoronto.ca-20070120014446-2znre037lrj823cd
Cleanup formatting and error handling

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005-2010 Canonical Ltd
 
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
import datetime
18
18
import os
19
19
import time
20
20
 
21
21
from bzrlib import (
22
 
    branch,
23
 
    bzrdir,
24
22
    errors,
25
 
    repository,
26
 
    revision as _mod_revision,
27
23
    )
 
24
from bzrlib.builtins import merge
28
25
from bzrlib.tests import TestCase, TestCaseWithTransport
29
 
from bzrlib.revisionspec import (
30
 
    RevisionSpec,
31
 
    RevisionSpec_revno,
32
 
    RevisionSpec_tag,
33
 
    )
 
26
from bzrlib.revisionspec import RevisionSpec, RevisionSpec_revno
34
27
 
35
28
 
36
29
def spec_in_history(spec, branch):
50
43
 
51
44
        self.tree = self.make_branch_and_tree('tree')
52
45
        self.build_tree(['tree/a'])
53
 
        self.tree.lock_write()
54
 
        self.addCleanup(self.tree.unlock)
55
46
        self.tree.add(['a'])
56
47
        self.tree.commit('a', rev_id='r1')
57
48
 
58
49
        self.tree2 = self.tree.bzrdir.sprout('tree2').open_workingtree()
59
50
        self.tree2.commit('alt', rev_id='alt_r2')
60
51
 
61
 
        self.tree.merge_from_branch(self.tree2.branch)
 
52
        self.tree.branch.repository.fetch(self.tree2.branch.repository,
 
53
                                          revision_id='alt_r2')
 
54
        self.tree.set_pending_merges(['alt_r2'])
62
55
        self.tree.commit('second', rev_id='r2')
63
56
 
64
57
    def get_in_history(self, revision_spec):
67
60
    def assertInHistoryIs(self, exp_revno, exp_revision_id, revision_spec):
68
61
        rev_info = self.get_in_history(revision_spec)
69
62
        self.assertEqual(exp_revno, rev_info.revno,
70
 
                         'Revision spec: %r returned wrong revno: %r != %r'
 
63
                         'Revision spec: %s returned wrong revno: %s != %s'
71
64
                         % (revision_spec, exp_revno, rev_info.revno))
72
65
        self.assertEqual(exp_revision_id, rev_info.rev_id,
73
 
                         'Revision spec: %r returned wrong revision id:'
74
 
                         ' %r != %r'
 
66
                         'Revision spec: %s returned wrong revision id:'
 
67
                         ' %s != %s'
75
68
                         % (revision_spec, exp_revision_id, rev_info.rev_id))
76
69
 
77
 
    def assertInvalid(self, revision_spec, extra='',
78
 
                      invalid_as_revision_id=True):
 
70
    def assertInvalid(self, revision_spec, extra=''):
79
71
        try:
80
72
            self.get_in_history(revision_spec)
81
73
        except errors.InvalidRevisionSpec, e:
82
74
            self.assertEqual(revision_spec, e.spec)
83
75
            self.assertEqual(extra, e.extra)
84
76
        else:
85
 
            self.fail('Expected InvalidRevisionSpec to be raised for'
86
 
                      ' %r.in_history' % (revision_spec,))
87
 
        if invalid_as_revision_id:
88
 
            try:
89
 
                spec = RevisionSpec.from_string(revision_spec)
90
 
                spec.as_revision_id(self.tree.branch)
91
 
            except errors.InvalidRevisionSpec, e:
92
 
                self.assertEqual(revision_spec, e.spec)
93
 
                self.assertEqual(extra, e.extra)
94
 
            else:
95
 
                self.fail('Expected InvalidRevisionSpec to be raised for'
96
 
                          ' %r.as_revision_id' % (revision_spec,))
97
 
 
98
 
    def assertAsRevisionId(self, revision_id, revision_spec):
99
 
        """Calling as_revision_id() should return the specified id."""
100
 
        spec = RevisionSpec.from_string(revision_spec)
101
 
        self.assertEqual(revision_id,
102
 
                         spec.as_revision_id(self.tree.branch))
103
 
 
104
 
    def get_as_tree(self, revision_spec, tree=None):
105
 
        if tree is None:
106
 
            tree = self.tree
107
 
        spec = RevisionSpec.from_string(revision_spec)
108
 
        return spec.as_tree(tree.branch)
109
 
 
110
 
 
111
 
class RevisionSpecMatchOnTrap(RevisionSpec):
112
 
 
113
 
    def _match_on(self, branch, revs):
114
 
        self.last_call = (branch, revs)
115
 
        return super(RevisionSpecMatchOnTrap, self)._match_on(branch, revs)
116
 
 
117
 
 
118
 
class TestRevisionSpecBase(TestRevisionSpec):
119
 
 
120
 
    def test_wants_revision_history(self):
121
 
        # If wants_revision_history = True, then _match_on should get the
122
 
        # branch revision history
123
 
        spec = RevisionSpecMatchOnTrap('foo', _internal=True)
124
 
        spec.in_history(self.tree.branch)
125
 
 
126
 
        self.assertEqual((self.tree.branch, ['r1' ,'r2']),
127
 
                         spec.last_call)
128
 
 
129
 
    def test_wants_no_revision_history(self):
130
 
        # If wants_revision_history = False, then _match_on should get None for
131
 
        # the branch revision history
132
 
        spec = RevisionSpecMatchOnTrap('foo', _internal=True)
133
 
        spec.wants_revision_history = False
134
 
        spec.in_history(self.tree.branch)
135
 
 
136
 
        self.assertEqual((self.tree.branch, None), spec.last_call)
137
 
 
 
77
            self.fail('Expected InvalidRevisionSpec to be raised for %s'
 
78
                      % (revision_spec,))
138
79
 
139
80
 
140
81
class TestOddRevisionSpec(TestRevisionSpec):
141
82
    """Test things that aren't normally thought of as revision specs"""
142
83
 
143
84
    def test_none(self):
144
 
        self.assertInHistoryIs(None, None, None)
 
85
        self.assertInHistoryIs(0, None, None)
145
86
 
146
87
    def test_object(self):
147
88
        self.assertRaises(TypeError, RevisionSpec.from_string, object())
148
89
 
149
 
 
150
 
class TestRevisionSpec_dwim(TestRevisionSpec):
151
 
 
152
 
    # Don't need to test revno's explicitly since TRS_revno already
153
 
    # covers that well for us
154
 
    def test_dwim_spec_revno(self):
155
 
        self.assertInHistoryIs(2, 'r2', '2')
156
 
        self.assertAsRevisionId('alt_r2', '1.1.1')
157
 
 
158
 
    def test_dwim_spec_revid(self):
159
 
        self.assertInHistoryIs(2, 'r2', 'r2')
160
 
 
161
 
    def test_dwim_spec_tag(self):
162
 
        self.tree.branch.tags.set_tag('footag', 'r1')
163
 
        self.assertAsRevisionId('r1', 'footag')
164
 
        self.tree.branch.tags.delete_tag('footag')
165
 
        self.assertRaises(errors.InvalidRevisionSpec,
166
 
                          self.get_in_history, 'footag')
167
 
 
168
 
    def test_dwim_spec_tag_that_looks_like_revno(self):
169
 
        # Test that we slip past revno with things that look like revnos,
170
 
        # but aren't.  Tags are convenient for testing this since we can
171
 
        # make them look however we want.
172
 
        self.tree.branch.tags.set_tag('3', 'r2')
173
 
        self.assertAsRevisionId('r2', '3')
174
 
        self.build_tree(['tree/b'])
175
 
        self.tree.add(['b'])
176
 
        self.tree.commit('b', rev_id='r3')
177
 
        self.assertAsRevisionId('r3', '3')
178
 
 
179
 
    def test_dwim_spec_date(self):
180
 
        self.assertAsRevisionId('r1', 'today')
181
 
 
182
 
    def test_dwim_spec_branch(self):
183
 
        self.assertInHistoryIs(None, 'alt_r2', 'tree2')
184
 
 
185
 
    def test_dwim_spec_nonexistent(self):
186
 
        self.assertInvalid('somethingrandom', invalid_as_revision_id=False)
187
 
        self.assertInvalid('-1.1', invalid_as_revision_id=False)
188
 
        self.assertInvalid('.1', invalid_as_revision_id=False)
189
 
        self.assertInvalid('1..1', invalid_as_revision_id=False)
190
 
        self.assertInvalid('1.2..1', invalid_as_revision_id=False)
191
 
        self.assertInvalid('1.', invalid_as_revision_id=False)
 
90
    def test_unregistered_spec(self):
 
91
        self.assertRaises(errors.NoSuchRevisionSpec,
 
92
                          RevisionSpec.from_string, 'foo')
 
93
        self.assertRaises(errors.NoSuchRevisionSpec,
 
94
                          RevisionSpec.from_string, '123a')
 
95
 
 
96
 
 
97
 
 
98
class TestRevnoFromString(TestCase):
 
99
 
 
100
    def test_from_string_dotted_decimal(self):
 
101
        self.assertRaises(errors.NoSuchRevisionSpec, RevisionSpec.from_string, '-1.1')
 
102
        self.assertRaises(errors.NoSuchRevisionSpec, RevisionSpec.from_string, '.1')
 
103
        self.assertRaises(errors.NoSuchRevisionSpec, RevisionSpec.from_string, '1..1')
 
104
        self.assertRaises(errors.NoSuchRevisionSpec, RevisionSpec.from_string, '1.2..1')
 
105
        self.assertRaises(errors.NoSuchRevisionSpec, RevisionSpec.from_string, '1.')
 
106
        self.assertIsInstance(RevisionSpec.from_string('1.1'), RevisionSpec_revno)
 
107
        self.assertIsInstance(RevisionSpec.from_string('1.1.3'), RevisionSpec_revno)
192
108
 
193
109
 
194
110
class TestRevisionSpec_revno(TestRevisionSpec):
195
111
 
196
112
    def test_positive_int(self):
197
 
        self.assertInHistoryIs(0, 'null:', '0')
 
113
        self.assertInHistoryIs(0, None, '0')
198
114
        self.assertInHistoryIs(1, 'r1', '1')
199
115
        self.assertInHistoryIs(2, 'r2', '2')
200
116
        self.assertInvalid('3')
201
117
 
202
118
    def test_dotted_decimal(self):
203
119
        self.assertInHistoryIs(None, 'alt_r2', '1.1.1')
204
 
        self.assertInvalid('1.1.123')
205
120
 
206
121
    def test_negative_int(self):
207
122
        self.assertInHistoryIs(2, 'r2', '-1')
212
127
        self.assertInHistoryIs(1, 'r1', '-100')
213
128
 
214
129
    def test_positive(self):
215
 
        self.assertInHistoryIs(0, 'null:', 'revno:0')
 
130
        self.assertInHistoryIs(0, None, 'revno:0')
216
131
        self.assertInHistoryIs(1, 'r1', 'revno:1')
217
132
        self.assertInHistoryIs(2, 'r2', 'revno:2')
218
133
 
301
216
        """Old revno:N:path tests"""
302
217
        wta = self.make_branch_and_tree('a')
303
218
        ba = wta.branch
304
 
 
 
219
        
305
220
        wta.commit('Commit one', rev_id='a@r-0-1')
306
221
        wta.commit('Commit two', rev_id='a@r-0-2')
307
222
        wta.commit('Commit three', rev_id='a@r-0-3')
325
240
        self.assertEqual((2, 'b@r-0-2'),
326
241
                         spec_in_history('revno:2:b/', None))
327
242
 
328
 
    def test_as_revision_id(self):
329
 
        self.assertAsRevisionId('null:', '0')
330
 
        self.assertAsRevisionId('r1', '1')
331
 
        self.assertAsRevisionId('r2', '2')
332
 
        self.assertAsRevisionId('r1', '-2')
333
 
        self.assertAsRevisionId('r2', '-1')
334
 
        self.assertAsRevisionId('alt_r2', '1.1.1')
335
 
 
336
 
    def test_as_tree(self):
337
 
        tree = self.get_as_tree('0')
338
 
        self.assertEquals(_mod_revision.NULL_REVISION, tree.get_revision_id())
339
 
        tree = self.get_as_tree('1')
340
 
        self.assertEquals('r1', tree.get_revision_id())
341
 
        tree = self.get_as_tree('2')
342
 
        self.assertEquals('r2', tree.get_revision_id())
343
 
        tree = self.get_as_tree('-2')
344
 
        self.assertEquals('r1', tree.get_revision_id())
345
 
        tree = self.get_as_tree('-1')
346
 
        self.assertEquals('r2', tree.get_revision_id())
347
 
        tree = self.get_as_tree('1.1.1')
348
 
        self.assertEquals('alt_r2', tree.get_revision_id())
349
243
 
350
244
 
351
245
class TestRevisionSpec_revid(TestRevisionSpec):
352
 
 
 
246
    
353
247
    def test_in_history(self):
354
248
        # We should be able to access revisions that are directly
355
249
        # in the history.
356
250
        self.assertInHistoryIs(1, 'r1', 'revid:r1')
357
251
        self.assertInHistoryIs(2, 'r2', 'revid:r2')
358
 
 
 
252
        
359
253
    def test_missing(self):
360
 
        self.assertInvalid('revid:r3', invalid_as_revision_id=False)
 
254
        self.assertInvalid('revid:r3')
361
255
 
362
256
    def test_merged(self):
363
257
        """We can reach revisions in the ancestry"""
366
260
    def test_not_here(self):
367
261
        self.tree2.commit('alt third', rev_id='alt_r3')
368
262
        # It exists in tree2, but not in tree
369
 
        self.assertInvalid('revid:alt_r3', invalid_as_revision_id=False)
 
263
        self.assertInvalid('revid:alt_r3')
370
264
 
371
265
    def test_in_repository(self):
372
266
        """We can get any revision id in the repository"""
376
270
                                          revision_id='alt_r3')
377
271
        self.assertInHistoryIs(None, 'alt_r3', 'revid:alt_r3')
378
272
 
379
 
    def test_unicode(self):
380
 
        """We correctly convert a unicode ui string to an encoded revid."""
381
 
        revision_id = u'\N{SNOWMAN}'.encode('utf-8')
382
 
        self.tree.commit('unicode', rev_id=revision_id)
383
 
        self.assertInHistoryIs(3, revision_id, u'revid:\N{SNOWMAN}')
384
 
        self.assertInHistoryIs(3, revision_id, 'revid:' + revision_id)
385
 
 
386
 
    def test_as_revision_id(self):
387
 
        self.assertAsRevisionId('r1', 'revid:r1')
388
 
        self.assertAsRevisionId('r2', 'revid:r2')
389
 
        self.assertAsRevisionId('alt_r2', 'revid:alt_r2')
390
 
 
391
273
 
392
274
class TestRevisionSpec_last(TestRevisionSpec):
393
275
 
394
276
    def test_positive(self):
395
277
        self.assertInHistoryIs(2, 'r2', 'last:1')
396
278
        self.assertInHistoryIs(1, 'r1', 'last:2')
397
 
        self.assertInHistoryIs(0, 'null:', 'last:3')
 
279
        self.assertInHistoryIs(0, None, 'last:3')
398
280
 
399
281
    def test_empty(self):
400
282
        self.assertInHistoryIs(2, 'r2', 'last:')
419
301
            pass
420
302
        self.assertInvalid('last:Y', extra='\n' + str(e))
421
303
 
422
 
    def test_as_revision_id(self):
423
 
        self.assertAsRevisionId('r2', 'last:1')
424
 
        self.assertAsRevisionId('r1', 'last:2')
425
 
 
426
304
 
427
305
class TestRevisionSpec_before(TestRevisionSpec):
428
306
 
431
309
        self.assertInHistoryIs(1, 'r1', 'before:-1')
432
310
 
433
311
    def test_before_one(self):
434
 
        self.assertInHistoryIs(0, 'null:', 'before:1')
 
312
        self.assertInHistoryIs(0, None, 'before:1')
435
313
 
436
314
    def test_before_none(self):
437
315
        self.assertInvalid('before:0',
452
330
        new_tree.commit('first', rev_id='new_r1')
453
331
        self.tree.branch.repository.fetch(new_tree.branch.repository,
454
332
                                          revision_id='new_r1')
455
 
        self.assertInHistoryIs(0, 'null:', 'before:revid:new_r1')
456
 
 
457
 
    def test_as_revision_id(self):
458
 
        self.assertAsRevisionId('r1', 'before:revid:r2')
459
 
        self.assertAsRevisionId('r1', 'before:2')
460
 
        self.assertAsRevisionId('r1', 'before:1.1.1')
461
 
        self.assertAsRevisionId('r1', 'before:revid:alt_r2')
 
333
        self.assertInHistoryIs(0, None, 'before:revid:new_r1')
462
334
 
463
335
 
464
336
class TestRevisionSpec_tag(TestRevisionSpec):
465
 
 
466
 
    def make_branch_and_tree(self, relpath):
467
 
        # override format as the default one may not support tags
468
 
        return TestRevisionSpec.make_branch_and_tree(
469
 
            self, relpath, format='dirstate-tags')
470
 
 
471
 
    def test_from_string_tag(self):
472
 
        spec = RevisionSpec.from_string('tag:bzr-0.14')
473
 
        self.assertIsInstance(spec, RevisionSpec_tag)
474
 
        self.assertEqual(spec.spec, 'bzr-0.14')
475
 
 
476
 
    def test_lookup_tag(self):
477
 
        self.tree.branch.tags.set_tag('bzr-0.14', 'r1')
478
 
        self.assertInHistoryIs(1, 'r1', 'tag:bzr-0.14')
479
 
        self.tree.branch.tags.set_tag('null_rev', 'null:')
480
 
        self.assertInHistoryIs(0, 'null:', 'tag:null_rev')
481
 
 
482
 
    def test_failed_lookup(self):
483
 
        # tags that don't exist give a specific message: arguably we should
484
 
        # just give InvalidRevisionSpec but I think this is more helpful
485
 
        self.assertRaises(errors.NoSuchTag,
486
 
            self.get_in_history,
487
 
            'tag:some-random-tag')
488
 
 
489
 
    def test_as_revision_id(self):
490
 
        self.tree.branch.tags.set_tag('my-tag', 'r2')
491
 
        self.tree.branch.tags.set_tag('null_rev', 'null:')
492
 
        self.assertAsRevisionId('r2', 'tag:my-tag')
493
 
        self.assertAsRevisionId('null:', 'tag:null_rev')
494
 
        self.assertAsRevisionId('r1', 'before:tag:my-tag')
 
337
    
 
338
    def test_invalid(self):
 
339
        self.assertInvalid('tag:foo', extra='\ntag: namespace registered,'
 
340
                                            ' but not implemented')
495
341
 
496
342
 
497
343
class TestRevisionSpec_date(TestRevisionSpec):
529
375
        self.assertInHistoryIs(2, 'new_r2',
530
376
            'date:%04d-%02d-%02d' % (now.year, now.month, now.day))
531
377
 
532
 
    def test_as_revision_id(self):
533
 
        self.assertAsRevisionId('new_r2', 'date:today')
534
 
 
535
378
 
536
379
class TestRevisionSpec_ancestor(TestRevisionSpec):
537
 
 
 
380
    
538
381
    def test_non_exact_branch(self):
539
382
        # It seems better to require an exact path to the branch
540
383
        # Branch.open() rather than using Branch.open_containing()
570
413
        self.assertRaises(errors.NoCommits,
571
414
                          spec_in_history, 'ancestor:new_tree',
572
415
                                           self.tree.branch)
573
 
 
 
416
                        
574
417
        self.assertRaises(errors.NoCommits,
575
418
                          spec_in_history, 'ancestor:tree',
576
419
                                           new_tree.branch)
577
420
 
578
 
    def test_as_revision_id(self):
579
 
        self.assertAsRevisionId('alt_r2', 'ancestor:tree2')
580
 
 
581
 
    def test_default(self):
582
 
        # We don't have a parent to default to
583
 
        self.assertRaises(errors.NotBranchError, self.get_in_history,
584
 
                          'ancestor:')
585
 
 
586
 
        # Create a branch with a parent to default to
587
 
        tree3 = self.tree.bzrdir.sprout('tree3').open_workingtree()
588
 
        tree3.commit('foo', rev_id='r3')
589
 
        self.tree = tree3
590
 
        self.assertInHistoryIs(2, 'r2', 'ancestor:')
591
 
 
592
421
 
593
422
class TestRevisionSpec_branch(TestRevisionSpec):
594
 
 
 
423
    
595
424
    def test_non_exact_branch(self):
596
425
        # It seems better to require an exact path to the branch
597
426
        # Branch.open() rather than using Branch.open_containing()
622
451
        new_tree = self.make_branch_and_tree('new_tree')
623
452
        self.assertRaises(errors.NoCommits,
624
453
                          self.get_in_history, 'branch:new_tree')
625
 
        self.assertRaises(errors.NoCommits,
626
 
                          self.get_as_tree, 'branch:new_tree')
627
 
 
628
 
    def test_as_revision_id(self):
629
 
        self.assertAsRevisionId('alt_r2', 'branch:tree2')
630
 
 
631
 
    def test_as_tree(self):
632
 
        tree = self.get_as_tree('branch:tree', self.tree2)
633
 
        self.assertEquals('r2', tree.get_revision_id())
634
 
        self.assertFalse(self.tree2.branch.repository.has_revision('r2'))
635
 
 
636
 
 
637
 
class TestRevisionSpec_submit(TestRevisionSpec):
638
 
 
639
 
    def test_submit_branch(self):
640
 
        # Common ancestor of trees is 'alt_r2'
641
 
        self.assertRaises(errors.NoSubmitBranch, self.get_in_history,
642
 
                          'submit:')
643
 
        self.tree.branch.set_parent('../tree2')
644
 
        self.assertInHistoryIs(None, 'alt_r2', 'submit:')
645
 
        self.tree.branch.set_parent('bogus')
646
 
        self.assertRaises(errors.NotBranchError, self.get_in_history,
647
 
            'submit:')
648
 
        # submit branch overrides parent branch
649
 
        self.tree.branch.set_submit_branch('tree2')
650
 
        self.assertInHistoryIs(None, 'alt_r2', 'submit:')
651
 
 
652
 
    def test_as_revision_id(self):
653
 
        self.tree.branch.set_submit_branch('tree2')
654
 
        self.assertAsRevisionId('alt_r2', 'branch:tree2')