1
# Copyright (C) 2006, 2007, 2008, 2009 Canonical Ltd
1
# Copyright (C) 2006 by Canonical Ltd
2
# Authors: Robert Collins <robert.collins@canonical.com>
3
4
# This program is free software; you can redistribute it and/or modify
4
5
# it under the terms of the GNU General Public License as published by
13
14
# You should have received a copy of the GNU General Public License
14
15
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
17
18
"""Symbol versioning
22
23
__all__ = ['deprecated_function',
25
25
'deprecated_method',
26
26
'DEPRECATED_PARAMETER',
27
27
'deprecated_passed',
28
'warn', 'set_warning_method', 'zero_seven',
32
34
from warnings import warn
37
37
DEPRECATED_PARAMETER = "A deprecated parameter marker."
40
def deprecated_in(version_tuple):
41
"""Generate a message that something was deprecated in a release.
43
>>> deprecated_in((1, 4, 0))
44
'%s was deprecated in version 1.4.0.'
46
return ("%%s was deprecated in version %s."
47
% bzrlib._format_version_tuple(version_tuple))
38
zero_seven = "%s was deprecated in version 0.7."
39
zero_eight = "%s was deprecated in version 0.8."
40
zero_nine = "%s was deprecated in version 0.9."
41
zero_ten = "%s was deprecated in version 0.10."
50
44
def set_warning_method(method):
61
55
# add that on top of the primitives, once we have all three written
65
def deprecation_string(a_callable, deprecation_version):
66
"""Generate an automatic deprecation string for a_callable.
68
:param a_callable: The callable to substitute into deprecation_version.
69
:param deprecation_version: A deprecation format warning string. This should
70
have a single %s operator in it. a_callable will be turned into a nice
71
python symbol and then substituted into deprecation_version.
73
# We also want to handle old-style classes, in particular exception, and
74
# they don't have an im_class attribute.
75
if getattr(a_callable, 'im_class', None) is None:
76
symbol = "%s.%s" % (a_callable.__module__,
79
symbol = "%s.%s.%s" % (a_callable.im_class.__module__,
80
a_callable.im_class.__name__,
83
return deprecation_version % symbol
86
58
def deprecated_function(deprecation_version):
87
59
"""Decorate a function so that use of it will trigger a warning."""
89
61
def function_decorator(callable):
90
62
"""This is the function python calls to perform the decoration."""
92
64
def decorated_function(*args, **kwargs):
93
65
"""This is the decorated function."""
94
from bzrlib import trace
95
trace.mutter_callsite(4, "Deprecated function called")
96
warn(deprecation_string(callable, deprecation_version),
97
DeprecationWarning, stacklevel=2)
66
symbol = "%s.%s" % (callable.__module__,
69
warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
98
70
return callable(*args, **kwargs)
99
71
_populate_decorated(callable, deprecation_version, "function",
100
72
decorated_function)
105
77
def deprecated_method(deprecation_version):
106
78
"""Decorate a method so that use of it will trigger a warning.
108
To deprecate a static or class method, use
114
80
To deprecate an entire class, decorate __init__.
117
83
def method_decorator(callable):
118
84
"""This is the function python calls to perform the decoration."""
120
86
def decorated_method(self, *args, **kwargs):
121
87
"""This is the decorated method."""
122
from bzrlib import trace
123
if callable.__name__ == '__init__':
124
symbol = "%s.%s" % (self.__class__.__module__,
125
self.__class__.__name__,
128
symbol = "%s.%s.%s" % (self.__class__.__module__,
129
self.__class__.__name__,
132
trace.mutter_callsite(4, "Deprecated method called")
88
symbol = "%s.%s.%s" % (self.__class__.__module__,
89
self.__class__.__name__,
133
92
warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
134
93
return callable(self, *args, **kwargs)
135
94
_populate_decorated(callable, deprecation_version, "method",
141
100
def deprecated_passed(parameter_value):
142
101
"""Return True if parameter_value was used."""
143
# FIXME: it might be nice to have a parameter deprecation decorator.
102
# FIXME: it might be nice to have a parameter deprecation decorator.
144
103
# it would need to handle positional and *args and **kwargs parameters,
145
104
# which means some mechanism to describe how the parameter was being
146
105
# passed before deprecation, and some way to deprecate parameters that
148
107
# we cannot just forward to a new method name.I.e. in the following
149
108
# examples we would want to have callers that pass any value to 'bad' be
150
109
# given a warning - because we have applied:
151
# @deprecated_parameter('bad', deprecated_in((1, 5, 0))
110
# @deprecated_parameter('bad', zero_seven)
153
112
# def __init__(self, bad=None)
154
113
# def __init__(self, bad, other)
166
125
if len(docstring_lines) == 0:
167
126
decorated_callable.__doc__ = deprecation_version % ("This " + label)
168
127
elif len(docstring_lines) == 1:
169
decorated_callable.__doc__ = (callable.__doc__
128
decorated_callable.__doc__ = (callable.__doc__
172
131
+ deprecation_version % ("This " + label)
191
150
decorated_callable.is_deprecated = True
194
def _dict_deprecation_wrapper(wrapped_method):
195
"""Returns a closure that emits a warning and calls the superclass"""
196
def cb(dep_dict, *args, **kwargs):
197
msg = 'access to %s' % (dep_dict._variable_name, )
198
msg = dep_dict._deprecation_version % (msg,)
200
msg += ' ' + dep_dict._advice
201
warn(msg, DeprecationWarning, stacklevel=2)
202
return wrapped_method(dep_dict, *args, **kwargs)
206
class DeprecatedDict(dict):
207
"""A dictionary that complains when read or written."""
217
"""Create a dict that warns when read or modified.
219
:param deprecation_version: string for the warning format to raise,
220
typically from deprecated_in()
221
:param initial_value: The contents of the dict
222
:param variable_name: This allows better warnings to be printed
223
:param advice: String of advice on what callers should do instead
224
of using this variable.
226
self._deprecation_version = deprecation_version
227
self._variable_name = variable_name
228
self._advice = advice
229
dict.__init__(self, initial_value)
231
# This isn't every possible method but it should trap anyone using the
232
# dict -- add more if desired
233
__len__ = _dict_deprecation_wrapper(dict.__len__)
234
__getitem__ = _dict_deprecation_wrapper(dict.__getitem__)
235
__setitem__ = _dict_deprecation_wrapper(dict.__setitem__)
236
__delitem__ = _dict_deprecation_wrapper(dict.__delitem__)
237
keys = _dict_deprecation_wrapper(dict.keys)
238
__contains__ = _dict_deprecation_wrapper(dict.__contains__)
241
153
def deprecated_list(deprecation_version, variable_name,
242
154
initial_value, extra=None):
243
155
"""Create a list that warns when modified
245
:param deprecation_version: string for the warning format to raise,
246
typically from deprecated_in()
157
:param deprecation_version: something like zero_nine
247
158
:param initial_value: The contents of the list
248
159
:param variable_name: This allows better warnings to be printed
249
160
:param extra: Extra info to print when printing a warning
262
173
def _warn_deprecated(self, func, *args, **kwargs):
263
174
warn(msg, DeprecationWarning, stacklevel=3)
264
175
return func(self, *args, **kwargs)
266
177
def append(self, obj):
267
178
"""appending to %s is deprecated""" % (variable_name,)
268
179
return self._warn_deprecated(list.append, obj)
280
191
return self._warn_deprecated(list.remove, value)
282
193
def pop(self, index=None):
283
"""pop'ing from %s is deprecated""" % (variable_name,)
194
"""pop'ing from from %s is deprecated""" % (variable_name,)
285
196
return self._warn_deprecated(list.pop, index)
288
199
return self._warn_deprecated(list.pop)
290
201
return _DeprecatedList(initial_value)
293
def _check_for_filter(error_only):
294
"""Check if there is already a filter for deprecation warnings.
296
:param error_only: Only match an 'error' filter
297
:return: True if a filter is found, False otherwise
300
for filter in warnings.filters:
301
if issubclass(DeprecationWarning, filter[2]):
302
# This filter will effect DeprecationWarning
303
if not error_only or filter[0] == 'error':
308
def suppress_deprecation_warnings(override=True):
309
"""Call this function to suppress all deprecation warnings.
311
When this is a final release version, we don't want to annoy users with
312
lots of deprecation warnings. We only want the deprecation warnings when
313
running a dev or release candidate.
315
:param override: If True, always set the ignore, if False, only set the
316
ignore if there isn't already a filter.
319
if not override and _check_for_filter(error_only=False):
320
# If there is already a filter effecting suppress_deprecation_warnings,
323
warnings.filterwarnings('ignore', category=DeprecationWarning)
326
def activate_deprecation_warnings(override=True):
327
"""Call this function to activate deprecation warnings.
329
When running in a 'final' release we suppress deprecation warnings.
330
However, the test suite wants to see them. So when running selftest, we
331
re-enable the deprecation warnings.
333
Note: warnings that have already been issued under 'ignore' will not be
334
reported after this point. The 'warnings' module has already marked them as
335
handled, so they don't get issued again.
337
:param override: If False, only add a filter if there isn't an error filter
338
already. (This slightly differs from suppress_deprecation_warnings, in
339
because it always overrides everything but -Werror).
342
if not override and _check_for_filter(error_only=True):
343
# DeprecationWarnings are already turned into errors, don't downgrade
346
warnings.filterwarnings('default', category=DeprecationWarning)
added
removed
bzrlib/symbol_versioning.py
