~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/commit.py

  • Committer: Robert Collins
  • Date: 2006-05-16 06:45:43 UTC
  • mto: (1713.1.1 integration)
  • mto: This revision was merged to the branch mainline in revision 1714.
  • Revision ID: robertc@robertcollins.net-20060516064543-5cb7cc63047ba98b
Start on bench_add, an add benchtest.

Show diffs side-by-side

added added

removed removed

Lines of Context:
72
72
from binascii import hexlify
73
73
from cStringIO import StringIO
74
74
 
 
75
from bzrlib.atomicfile import AtomicFile
75
76
from bzrlib.osutils import (local_time_offset,
76
77
                            rand_bytes, compact_date,
77
78
                            kind_marker, is_inside_any, quotefn,
78
 
                            sha_string, sha_strings, sha_file, isdir, isfile,
 
79
                            sha_file, isdir, isfile,
79
80
                            split_lines)
80
 
from bzrlib.branch import gen_file_id
81
81
import bzrlib.config
 
82
import bzrlib.errors as errors
82
83
from bzrlib.errors import (BzrError, PointlessCommit,
83
84
                           HistoryMissing,
84
85
                           ConflictsInTree,
85
86
                           StrictCommitFailed
86
87
                           )
87
 
import bzrlib.gpg as gpg
88
88
from bzrlib.revision import Revision
89
89
from bzrlib.testament import Testament
90
90
from bzrlib.trace import mutter, note, warning
91
91
from bzrlib.xml5 import serializer_v5
92
92
from bzrlib.inventory import Inventory, ROOT_ID
93
 
from bzrlib.weave import Weave
94
 
from bzrlib.weavefile import read_weave, write_weave_v5
95
 
from bzrlib.atomicfile import AtomicFile
96
 
 
97
 
 
 
93
from bzrlib.symbol_versioning import *
 
94
from bzrlib.workingtree import WorkingTree
 
95
 
 
96
 
 
97
@deprecated_function(zero_seven)
98
98
def commit(*args, **kwargs):
99
99
    """Commit a new revision to a branch.
100
100
 
124
124
    def missing(self, path):
125
125
        pass
126
126
 
 
127
 
127
128
class ReportCommitToLog(NullCommitReporter):
128
129
 
129
130
    def snapshot_change(self, change, path):
 
131
        if change == 'unchanged':
 
132
            return
130
133
        note("%s %s", change, path)
131
134
 
132
135
    def completed(self, revno, rev_id):
133
 
        note('committed r%d {%s}', revno, rev_id)
 
136
        note('Committed revision %d.', revno)
134
137
    
135
138
    def deleted(self, file_id):
136
139
        note('deleted %s', file_id)
141
144
    def missing(self, path):
142
145
        note('missing %s', path)
143
146
 
 
147
 
144
148
class Commit(object):
145
149
    """Task of committing a new revision.
146
150
 
166
170
            self.config = None
167
171
        
168
172
    def commit(self,
169
 
               branch, message,
 
173
               branch=DEPRECATED_PARAMETER, message=None,
170
174
               timestamp=None,
171
175
               timezone=None,
172
176
               committer=None,
175
179
               allow_pointless=True,
176
180
               strict=False,
177
181
               verbose=False,
178
 
               revprops=None):
 
182
               revprops=None,
 
183
               working_tree=None,
 
184
               local=False,
 
185
               reporter=None,
 
186
               config=None):
179
187
        """Commit working copy as a new revision.
180
188
 
 
189
        branch -- the deprecated branch to commit to. New callers should pass in 
 
190
                  working_tree instead
 
191
 
 
192
        message -- the commit message, a mandatory parameter
 
193
 
181
194
        timestamp -- if not None, seconds-since-epoch for a
182
195
             postdated/predated commit.
183
196
 
196
209
            contains unknown files.
197
210
 
198
211
        revprops -- Properties for new revision
 
212
        :param local: Perform a local only commit.
199
213
        """
200
214
        mutter('preparing to commit')
201
215
 
202
 
        self.branch = branch
203
 
        self.weave_store = branch.weave_store
 
216
        if deprecated_passed(branch):
 
217
            warn("Commit.commit (branch, ...): The branch parameter is "
 
218
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
 
219
                 DeprecationWarning, stacklevel=2)
 
220
            self.branch = branch
 
221
            self.work_tree = self.branch.bzrdir.open_workingtree()
 
222
        elif working_tree is None:
 
223
            raise BzrError("One of branch and working_tree must be passed into commit().")
 
224
        else:
 
225
            self.work_tree = working_tree
 
226
            self.branch = self.work_tree.branch
 
227
        if message is None:
 
228
            raise BzrError("The message keyword parameter is required for commit().")
 
229
 
 
230
        self.weave_store = self.branch.repository.weave_store
 
231
        self.bound_branch = None
 
232
        self.local = local
 
233
        self.master_branch = None
 
234
        self.master_locked = False
204
235
        self.rev_id = rev_id
205
236
        self.specific_files = specific_files
206
237
        self.allow_pointless = allow_pointless
207
 
        self.revprops = revprops
208
 
 
209
 
        if strict and branch.unknowns():
210
 
            raise StrictCommitFailed()
211
 
 
212
 
        if timestamp is None:
213
 
            self.timestamp = time.time()
214
 
        else:
215
 
            self.timestamp = long(timestamp)
216
 
            
217
 
        if self.config is None:
218
 
            self.config = bzrlib.config.BranchConfig(self.branch)
219
 
 
220
 
        if rev_id is None:
221
 
            self.rev_id = _gen_revision_id(self.config, self.timestamp)
222
 
        else:
223
 
            self.rev_id = rev_id
224
 
 
225
 
        if committer is None:
226
 
            self.committer = self.config.username()
227
 
        else:
228
 
            assert isinstance(committer, basestring), type(committer)
229
 
            self.committer = committer
230
 
 
231
 
        if timezone is None:
232
 
            self.timezone = local_time_offset()
233
 
        else:
234
 
            self.timezone = int(timezone)
235
 
 
236
 
        assert isinstance(message, basestring), type(message)
237
 
        self.message = message
238
 
        self._escape_commit_message()
239
 
 
240
 
        self.branch.lock_write()
 
238
        self.revprops = {}
 
239
        if revprops is not None:
 
240
            self.revprops.update(revprops)
 
241
 
 
242
        if reporter is None and self.reporter is None:
 
243
            self.reporter = NullCommitReporter()
 
244
        elif reporter is not None:
 
245
            self.reporter = reporter
 
246
 
 
247
        self.work_tree.lock_write()
241
248
        try:
242
 
            self.work_tree = self.branch.working_tree()
 
249
            # setup the bound branch variables as needed.
 
250
            self._check_bound_branch()
 
251
 
 
252
            # check for out of date working trees
 
253
            # if we are bound, then self.branch is the master branch and this
 
254
            # test is thus all we need.
 
255
            if self.work_tree.last_revision() != self.master_branch.last_revision():
 
256
                raise errors.OutOfDateTree(self.work_tree)
 
257
    
 
258
            if strict:
 
259
                # raise an exception as soon as we find a single unknown.
 
260
                for unknown in self.work_tree.unknowns():
 
261
                    raise StrictCommitFailed()
 
262
    
 
263
            if timestamp is None:
 
264
                self.timestamp = time.time()
 
265
            else:
 
266
                self.timestamp = long(timestamp)
 
267
                
 
268
            if self.config is None:
 
269
                self.config = bzrlib.config.BranchConfig(self.branch)
 
270
    
 
271
            if rev_id is None:
 
272
                self.rev_id = _gen_revision_id(self.config, self.timestamp)
 
273
            else:
 
274
                self.rev_id = rev_id
 
275
    
 
276
            if committer is None:
 
277
                self.committer = self.config.username()
 
278
            else:
 
279
                assert isinstance(committer, basestring), type(committer)
 
280
                self.committer = committer
 
281
    
 
282
            if timezone is None:
 
283
                self.timezone = local_time_offset()
 
284
            else:
 
285
                self.timezone = int(timezone)
 
286
    
 
287
            if isinstance(message, str):
 
288
                message = message.decode(bzrlib.user_encoding)
 
289
            assert isinstance(message, unicode), type(message)
 
290
            self.message = message
 
291
            self._escape_commit_message()
 
292
 
243
293
            self.work_inv = self.work_tree.inventory
244
 
            self.basis_tree = self.branch.basis_tree()
 
294
            self.basis_tree = self.work_tree.basis_tree()
245
295
            self.basis_inv = self.basis_tree.inventory
246
296
 
247
297
            self._gather_parents()
248
298
            if len(self.parents) > 1 and self.specific_files:
249
 
                raise NotImplementedError('selected-file commit of merges is not supported yet')
 
299
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
 
300
                        self.specific_files)
250
301
            self._check_parents_present()
251
302
            
252
303
            self._remove_deleted()
259
310
                    or self.new_inv != self.basis_inv):
260
311
                raise PointlessCommit()
261
312
 
262
 
            if len(list(self.work_tree.iter_conflicts()))>0:
 
313
            if len(self.work_tree.conflicts())>0:
263
314
                raise ConflictsInTree
264
315
 
265
 
            self._record_inventory()
 
316
            self.inv_sha1 = self.branch.repository.add_inventory(
 
317
                self.rev_id,
 
318
                self.new_inv,
 
319
                self.present_parents
 
320
                )
266
321
            self._make_revision()
267
 
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
 
322
            # revision data is in the local branch now.
 
323
            
 
324
            # upload revision data to the master.
 
325
            # this will propogate merged revisions too if needed.
 
326
            if self.bound_branch:
 
327
                self.master_branch.repository.fetch(self.branch.repository,
 
328
                                                    revision_id=self.rev_id)
 
329
                # now the master has the revision data
 
330
                # 'commit' to the master first so a timeout here causes the local
 
331
                # branch to be out of date
 
332
                self.master_branch.append_revision(self.rev_id)
 
333
 
 
334
            # and now do the commit locally.
268
335
            self.branch.append_revision(self.rev_id)
269
 
            self.branch.set_pending_merges([])
 
336
 
 
337
            self.work_tree.set_pending_merges([])
 
338
            self.work_tree.set_last_revision(self.rev_id)
 
339
            # now the work tree is up to date with the branch
 
340
            
 
341
            self.reporter.completed(self.branch.revno(), self.rev_id)
 
342
            if self.config.post_commit() is not None:
 
343
                hooks = self.config.post_commit().split(' ')
 
344
                # this would be nicer with twisted.python.reflect.namedAny
 
345
                for hook in hooks:
 
346
                    result = eval(hook + '(branch, rev_id)',
 
347
                                  {'branch':self.branch,
 
348
                                   'bzrlib':bzrlib,
 
349
                                   'rev_id':self.rev_id})
270
350
        finally:
271
 
            self.branch.unlock()
272
 
 
273
 
    def _record_inventory(self):
274
 
        """Store the inventory for the new revision."""
275
 
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
276
 
        self.inv_sha1 = sha_string(inv_text)
277
 
        s = self.branch.control_weaves
278
 
        s.add_text('inventory', self.rev_id,
279
 
                   split_lines(inv_text), self.present_parents,
280
 
                   self.branch.get_transaction())
 
351
            self._cleanup_bound_branch()
 
352
            self.work_tree.unlock()
 
353
 
 
354
    def _check_bound_branch(self):
 
355
        """Check to see if the local branch is bound.
 
356
 
 
357
        If it is bound, then most of the commit will actually be
 
358
        done using the remote branch as the target branch.
 
359
        Only at the end will the local branch be updated.
 
360
        """
 
361
        if self.local and not self.branch.get_bound_location():
 
362
            raise errors.LocalRequiresBoundBranch()
 
363
 
 
364
        if not self.local:
 
365
            self.master_branch = self.branch.get_master_branch()
 
366
 
 
367
        if not self.master_branch:
 
368
            # make this branch the reference branch for out of date checks.
 
369
            self.master_branch = self.branch
 
370
            return
 
371
 
 
372
        # If the master branch is bound, we must fail
 
373
        master_bound_location = self.master_branch.get_bound_location()
 
374
        if master_bound_location:
 
375
            raise errors.CommitToDoubleBoundBranch(self.branch,
 
376
                    self.master_branch, master_bound_location)
 
377
 
 
378
        # TODO: jam 20051230 We could automatically push local
 
379
        #       commits to the remote branch if they would fit.
 
380
        #       But for now, just require remote to be identical
 
381
        #       to local.
 
382
        
 
383
        # Make sure the local branch is identical to the master
 
384
        master_rh = self.master_branch.revision_history()
 
385
        local_rh = self.branch.revision_history()
 
386
        if local_rh != master_rh:
 
387
            raise errors.BoundBranchOutOfDate(self.branch,
 
388
                    self.master_branch)
 
389
 
 
390
        # Now things are ready to change the master branch
 
391
        # so grab the lock
 
392
        self.bound_branch = self.branch
 
393
        self.master_branch.lock_write()
 
394
        self.master_locked = True
 
395
####        
 
396
####        # Check to see if we have any pending merges. If we do
 
397
####        # those need to be pushed into the master branch
 
398
####        pending_merges = self.work_tree.pending_merges()
 
399
####        if pending_merges:
 
400
####            for revision_id in pending_merges:
 
401
####                self.master_branch.repository.fetch(self.bound_branch.repository,
 
402
####                                                    revision_id=revision_id)
 
403
 
 
404
    def _cleanup_bound_branch(self):
 
405
        """Executed at the end of a try/finally to cleanup a bound branch.
 
406
 
 
407
        If the branch wasn't bound, this is a no-op.
 
408
        If it was, it resents self.branch to the local branch, instead
 
409
        of being the master.
 
410
        """
 
411
        if not self.bound_branch:
 
412
            return
 
413
        if self.master_locked:
 
414
            self.master_branch.unlock()
281
415
 
282
416
    def _escape_commit_message(self):
283
417
        """Replace xml-incompatible control characters."""
 
418
        # FIXME: RBC 20060419 this should be done by the revision
 
419
        # serialiser not by commit. Then we can also add an unescaper
 
420
        # in the deserializer and start roundtripping revision messages
 
421
        # precisely. See repository_implementations/test_repository.py
 
422
        
284
423
        # Python strings can include characters that can't be
285
424
        # represented in well-formed XML; escape characters that
286
425
        # aren't listed in the XML specification
287
426
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
288
 
        if isinstance(self.message, unicode):
289
 
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
290
 
        else:
291
 
            # Use a regular 'str' as pattern to avoid having re.subn
292
 
            # return 'unicode' results.
293
 
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
294
427
        self.message, escape_count = re.subn(
295
 
            char_pattern,
 
428
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
296
429
            lambda match: match.group(0).encode('unicode_escape'),
297
430
            self.message)
298
431
        if escape_count:
300
433
 
301
434
    def _gather_parents(self):
302
435
        """Record the parents of a merge for merge detection."""
303
 
        pending_merges = self.branch.pending_merges()
 
436
        pending_merges = self.work_tree.pending_merges()
304
437
        self.parents = []
305
438
        self.parent_invs = []
306
439
        self.present_parents = []
309
442
            self.parents.append(precursor_id)
310
443
        self.parents += pending_merges
311
444
        for revision in self.parents:
312
 
            if self.branch.has_revision(revision):
313
 
                self.parent_invs.append(self.branch.get_inventory(revision))
 
445
            if self.branch.repository.has_revision(revision):
 
446
                inventory = self.branch.repository.get_inventory(revision)
 
447
                self.parent_invs.append(inventory)
314
448
                self.present_parents.append(revision)
315
449
 
316
450
    def _check_parents_present(self):
317
451
        for parent_id in self.parents:
318
452
            mutter('commit parent revision {%s}', parent_id)
319
 
            if not self.branch.has_revision(parent_id):
 
453
            if not self.branch.repository.has_revision(parent_id):
320
454
                if parent_id == self.branch.last_revision():
321
455
                    warning("parent is missing %r", parent_id)
322
456
                    raise HistoryMissing(self.branch, 'revision', parent_id)
325
459
            
326
460
    def _make_revision(self):
327
461
        """Record a new revision object for this commit."""
328
 
        self.rev = Revision(timestamp=self.timestamp,
329
 
                            timezone=self.timezone,
330
 
                            committer=self.committer,
331
 
                            message=self.message,
332
 
                            inventory_sha1=self.inv_sha1,
333
 
                            revision_id=self.rev_id,
334
 
                            properties=self.revprops)
335
 
        self.rev.parent_ids = self.parents
336
 
        rev_tmp = StringIO()
337
 
        serializer_v5.write_revision(self.rev, rev_tmp)
338
 
        rev_tmp.seek(0)
339
 
        if self.config.signature_needed():
340
 
            plaintext = Testament(self.rev, self.new_inv).as_short_text()
341
 
            self.branch.store_revision_signature(gpg.GPGStrategy(self.config),
342
 
                                                 plaintext, self.rev_id)
343
 
        self.branch.revision_store.add(rev_tmp, self.rev_id)
344
 
        mutter('new revision_id is {%s}', self.rev_id)
 
462
        rev = Revision(timestamp=self.timestamp,
 
463
                       timezone=self.timezone,
 
464
                       committer=self.committer,
 
465
                       message=self.message,
 
466
                       inventory_sha1=self.inv_sha1,
 
467
                       revision_id=self.rev_id,
 
468
                       properties=self.revprops)
 
469
        rev.parent_ids = self.parents
 
470
        self.branch.repository.add_revision(self.rev_id, rev, self.new_inv, self.config)
345
471
 
346
472
    def _remove_deleted(self):
347
473
        """Remove deleted files from the working inventories.
366
492
            deleted_ids.sort(reverse=True)
367
493
            for path, file_id in deleted_ids:
368
494
                del self.work_inv[file_id]
369
 
            self.branch._write_inventory(self.work_inv)
 
495
            self.work_tree._write_inventory(self.work_inv)
370
496
 
371
497
    def _store_snapshot(self):
372
498
        """Pass over inventory and record a snapshot.
380
506
        # mark-merge.  
381
507
        for path, ie in self.new_inv.iter_entries():
382
508
            previous_entries = ie.find_previous_heads(
383
 
                self.parent_invs, 
384
 
                self.weave_store.get_weave_or_empty(ie.file_id,
385
 
                    self.branch.get_transaction()))
 
509
                self.parent_invs,
 
510
                self.weave_store,
 
511
                self.branch.repository.get_transaction())
386
512
            if ie.revision is None:
387
513
                change = ie.snapshot(self.rev_id, path, previous_entries,
388
514
                                     self.work_tree, self.weave_store,
389
 
                                     self.branch.get_transaction())
 
515
                                     self.branch.repository.get_transaction())
390
516
            else:
391
517
                change = "unchanged"
392
518
            self.reporter.snapshot_change(change, path)
402
528
        revision set to their prior value.
403
529
        """
404
530
        mutter("Selecting files for commit with filter %s", self.specific_files)
405
 
        self.new_inv = Inventory()
 
531
        self.new_inv = Inventory(revision_id=self.rev_id)
406
532
        for path, new_ie in self.work_inv.iter_entries():
407
533
            file_id = new_ie.file_id
408
534
            mutter('check %s {%s}', path, new_ie.file_id)