~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/selftest/testrevision.py

  • Committer: abentley
  • Date: 2005-10-14 03:50:50 UTC
  • mto: (1185.25.1)
  • mto: This revision was merged to the branch mainline in revision 1460.
  • Revision ID: abentley@lappy-20051014035050-d779472ccb599a51
semi-broke merge

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005 Canonical Ltd
2
 
#
 
1
# (C) 2005 Canonical Ltd
 
2
 
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
5
5
# the Free Software Foundation; either version 2 of the License, or
6
6
# (at your option) any later version.
7
 
#
 
7
 
8
8
# This program is distributed in the hope that it will be useful,
9
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
11
# GNU General Public License for more details.
12
 
#
 
12
 
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
 
18
18
import os
19
 
import warnings
20
19
 
21
 
from bzrlib import (
22
 
    revision,
23
 
    )
 
20
from bzrlib.selftest import TestCaseInTempDir
24
21
from bzrlib.branch import Branch
25
 
from bzrlib.errors import NoSuchRevision
26
 
from bzrlib.deprecated_graph import Graph
 
22
from bzrlib.commit import commit
 
23
from bzrlib.fetch import fetch
27
24
from bzrlib.revision import (find_present_ancestors, combined_graph,
28
 
                             common_ancestor,
29
 
                             is_ancestor, MultipleRevisionSources,
30
 
                             NULL_REVISION)
31
 
from bzrlib.tests import TestCase, TestCaseWithTransport
 
25
                             is_ancestor, MultipleRevisionSources)
32
26
from bzrlib.trace import mutter
33
 
from bzrlib.workingtree import WorkingTree
34
 
 
35
 
# We're allowed to test deprecated interfaces
36
 
warnings.filterwarnings('ignore',
37
 
        '.*get_intervening_revisions was deprecated',
38
 
        DeprecationWarning,
39
 
        r'bzrlib\.tests\.test_revision')
40
 
 
41
 
# XXX: Make this a method of a merge base case
42
 
def make_branches(self):
 
27
from bzrlib.errors import NoSuchRevision
 
28
 
 
29
def make_branches():
43
30
    """Create two branches
44
31
 
45
32
    branch 1 has 6 commits, branch 2 has 3 commits
46
 
    commit 10 is a ghosted merge merge from branch 1
 
33
    commit 10 was a psuedo merge from branch 1
 
34
    but has been disabled until ghost support is
 
35
    implemented.
47
36
 
48
37
    the object graph is
49
38
    B:     A:
58
47
    so A is missing b6 at the start
59
48
    and B is missing a3, a4, a5
60
49
    """
61
 
    tree1 = self.make_branch_and_tree("branch1")
62
 
    br1 = tree1.branch
 
50
    os.mkdir("branch1")
 
51
    br1 = Branch.initialize("branch1")
63
52
    
64
 
    tree1.commit("Commit one", rev_id="a@u-0-0")
65
 
    tree1.commit("Commit two", rev_id="a@u-0-1")
66
 
    tree1.commit("Commit three", rev_id="a@u-0-2")
 
53
    commit(br1, "Commit one", rev_id="a@u-0-0")
 
54
    commit(br1, "Commit two", rev_id="a@u-0-1")
 
55
    commit(br1, "Commit three", rev_id="a@u-0-2")
67
56
 
68
 
    tree2 = tree1.bzrdir.clone("branch2").open_workingtree()
69
 
    br2 = tree2.branch
70
 
    tree2.commit("Commit four", rev_id="b@u-0-3")
71
 
    tree2.commit("Commit five", rev_id="b@u-0-4")
 
57
    os.mkdir("branch2")
 
58
    br2 = Branch.initialize("branch2")
 
59
    br2.update_revisions(br1)
 
60
    commit(br2, "Commit four", rev_id="b@u-0-3")
 
61
    commit(br2, "Commit five", rev_id="b@u-0-4")
72
62
    revisions_2 = br2.revision_history()
73
 
    self.assertEquals(revisions_2[-1], 'b@u-0-4')
74
 
    
75
 
    tree1.merge_from_branch(br2)
76
 
    tree1.commit("Commit six", rev_id="a@u-0-3")
77
 
    tree1.commit("Commit seven", rev_id="a@u-0-4")
78
 
    tree2.commit("Commit eight", rev_id="b@u-0-5")
79
 
    self.assertEquals(br2.revision_history()[-1], 'b@u-0-5')
80
 
    
81
 
    tree1.merge_from_branch(br2)
82
 
    tree1.commit("Commit nine", rev_id="a@u-0-5")
83
 
    # DO NOT MERGE HERE - we WANT a GHOST.
84
 
    tree2.add_parent_tree_id(br1.revision_history()[4])
85
 
    tree2.commit("Commit ten - ghost merge", rev_id="b@u-0-6")
 
63
    
 
64
    fetch(from_branch=br2, to_branch=br1)
 
65
    br1.add_pending_merge(revisions_2[4])
 
66
    assert revisions_2[4] == 'b@u-0-4'
 
67
    commit(br1, "Commit six", rev_id="a@u-0-3")
 
68
    commit(br1, "Commit seven", rev_id="a@u-0-4")
 
69
    commit(br2, "Commit eight", rev_id="b@u-0-5")
 
70
    
 
71
    fetch(from_branch=br2, to_branch=br1)
 
72
    br1.add_pending_merge(br2.revision_history()[5])
 
73
    commit(br1, "Commit nine", rev_id="a@u-0-5")
 
74
    # DO NOT FETCH HERE - we WANT a GHOST.
 
75
    #fetch(from_branch=br1, to_branch=br2)
 
76
    br2.add_pending_merge(br1.revision_history()[4])
 
77
    commit(br2, "Commit ten - ghost merge", rev_id="b@u-0-6")
86
78
    
87
79
    return br1, br2
88
80
 
89
81
 
90
 
class TestIsAncestor(TestCaseWithTransport):
91
 
 
 
82
class TestIsAncestor(TestCaseInTempDir):
92
83
    def test_recorded_ancestry(self):
93
84
        """Test that commit records all ancestors"""
94
 
        br1, br2 = make_branches(self)
 
85
        br1, br2 = make_branches()
95
86
        d = [('a@u-0-0', ['a@u-0-0']),
96
87
             ('a@u-0-1', ['a@u-0-0', 'a@u-0-1']),
97
88
             ('a@u-0-2', ['a@u-0-0', 'a@u-0-1', 'a@u-0-2']),
120
111
                if rev_id in br2_only and not branch is br2:
121
112
                    continue
122
113
                mutter('ancestry of {%s}: %r',
123
 
                       rev_id, branch.repository.get_ancestry(rev_id))
124
 
                result = sorted(branch.repository.get_ancestry(rev_id))
125
 
                self.assertEquals(result, [None] + sorted(anc))
 
114
                       rev_id, branch.get_ancestry(rev_id))
 
115
                self.assertEquals(sorted(branch.get_ancestry(rev_id)),
 
116
                                  [None] + sorted(anc))
126
117
    
127
118
    
128
119
    def test_is_ancestor(self):
129
120
        """Test checking whether a revision is an ancestor of another revision"""
130
 
        br1, br2 = make_branches(self)
 
121
        br1, br2 = make_branches()
131
122
        revisions = br1.revision_history()
132
123
        revisions_2 = br2.revision_history()
133
124
        sources = br1
134
125
 
135
 
        self.assert_(is_ancestor(revisions[0], revisions[0], br1))
136
 
        self.assert_(is_ancestor(revisions[1], revisions[0], sources))
137
 
        self.assert_(not is_ancestor(revisions[0], revisions[1], sources))
138
 
        self.assert_(is_ancestor(revisions_2[3], revisions[0], sources))
 
126
        assert is_ancestor(revisions[0], revisions[0], br1)
 
127
        assert is_ancestor(revisions[1], revisions[0], sources)
 
128
        assert not is_ancestor(revisions[0], revisions[1], sources)
 
129
        assert is_ancestor(revisions_2[3], revisions[0], sources)
139
130
        # disabled mbp 20050914, doesn't seem to happen anymore
140
131
        ## self.assertRaises(NoSuchRevision, is_ancestor, revisions_2[3],
141
132
        ##                  revisions[0], br1)        
142
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], sources))
143
 
        self.assert_(is_ancestor(revisions[3], revisions_2[4], br1))
144
 
        self.assert_(is_ancestor(revisions[3], revisions_2[3], sources))
145
 
        ## self.assert_(not is_ancestor(revisions[3], revisions_2[3], br1))
146
 
 
147
 
 
148
 
class TestIntermediateRevisions(TestCaseWithTransport):
 
133
        assert is_ancestor(revisions[3], revisions_2[4], sources)
 
134
        assert is_ancestor(revisions[3], revisions_2[4], br1)
 
135
        assert is_ancestor(revisions[3], revisions_2[3], sources)
 
136
        ## assert not is_ancestor(revisions[3], revisions_2[3], br1)
 
137
 
 
138
 
 
139
class TestIntermediateRevisions(TestCaseInTempDir):
149
140
 
150
141
    def setUp(self):
151
 
        TestCaseWithTransport.setUp(self)
152
 
        self.br1, self.br2 = make_branches(self)
153
 
        wt1 = self.br1.bzrdir.open_workingtree()
154
 
        wt2 = self.br2.bzrdir.open_workingtree()
155
 
        wt2.commit("Commit eleven", rev_id="b@u-0-7")
156
 
        wt2.commit("Commit twelve", rev_id="b@u-0-8")
157
 
        wt2.commit("Commit thirtteen", rev_id="b@u-0-9")
158
 
 
159
 
        wt1.merge_from_branch(self.br2)
160
 
        wt1.commit("Commit fourtten", rev_id="a@u-0-6")
161
 
 
162
 
        wt2.merge_from_branch(self.br1)
163
 
        wt2.commit("Commit fifteen", rev_id="b@u-0-10")
 
142
        from bzrlib.commit import commit
 
143
        TestCaseInTempDir.setUp(self)
 
144
        self.br1, self.br2 = make_branches()
 
145
 
 
146
        self.br2.commit("Commit eleven", rev_id="b@u-0-7")
 
147
        self.br2.commit("Commit twelve", rev_id="b@u-0-8")
 
148
        self.br2.commit("Commit thirtteen", rev_id="b@u-0-9")
 
149
 
 
150
        fetch(from_branch=self.br2, to_branch=self.br1)
 
151
        self.br1.add_pending_merge(self.br2.revision_history()[6])
 
152
        self.br1.commit("Commit fourtten", rev_id="a@u-0-6")
 
153
 
 
154
        fetch(from_branch=self.br1, to_branch=self.br2)
 
155
        self.br2.add_pending_merge(self.br1.revision_history()[6])
 
156
        self.br2.commit("Commit fifteen", rev_id="b@u-0-10")
164
157
 
165
158
        from bzrlib.revision import MultipleRevisionSources
166
 
        self.sources = MultipleRevisionSources(self.br1.repository,
167
 
                                               self.br2.repository)
168
 
 
169
 
 
170
 
 
171
 
class MockRevisionSource(object):
172
 
    """A RevisionSource that takes a pregenerated graph.
173
 
 
174
 
    This is useful for testing revision graph algorithms where
175
 
    the actual branch existing is irrelevant.
176
 
    """
177
 
 
178
 
    def __init__(self, full_graph):
179
 
        self._full_graph = full_graph
180
 
 
181
 
    def get_revision_graph_with_ghosts(self, revision_ids):
182
 
        # This is mocked out to just return a constant graph.
183
 
        return self._full_graph
184
 
 
185
 
 
186
 
class TestCommonAncestor(TestCaseWithTransport):
 
159
        self.sources = MultipleRevisionSources(self.br1, self.br2)
 
160
 
 
161
    def intervene(self, ancestor, revision, revision_history=None):
 
162
        from bzrlib.revision import get_intervening_revisions
 
163
        return get_intervening_revisions(ancestor,revision, self.sources, 
 
164
                                         revision_history)
 
165
 
 
166
    def test_intervene(self):
 
167
        """Find intermediate revisions, without requiring history"""
 
168
        from bzrlib.errors import NotAncestor, NoSuchRevision
 
169
        assert len(self.intervene('a@u-0-0', 'a@u-0-0')) == 0
 
170
        self.assertEqual(self.intervene('a@u-0-0', 'a@u-0-1'), ['a@u-0-1'])
 
171
        self.assertEqual(self.intervene('a@u-0-0', 'a@u-0-2'), 
 
172
                         ['a@u-0-1', 'a@u-0-2'])
 
173
        self.assertEqual(self.intervene('a@u-0-0', 'b@u-0-3'), 
 
174
                         ['a@u-0-1', 'a@u-0-2', 'b@u-0-3'])
 
175
        self.assertEqual(self.intervene('b@u-0-3', 'a@u-0-3'), 
 
176
                         ['b@u-0-4', 'a@u-0-3'])
 
177
        self.assertEqual(self.intervene('a@u-0-2', 'a@u-0-3', 
 
178
                                        self.br1.revision_history()), 
 
179
                         ['a@u-0-3'])
 
180
        self.assertEqual(self.intervene('a@u-0-0', 'a@u-0-5', 
 
181
                                        self.br1.revision_history()), 
 
182
                         ['a@u-0-1', 'a@u-0-2', 'a@u-0-3', 'a@u-0-4', 
 
183
                          'a@u-0-5'])
 
184
        self.assertEqual(self.intervene('a@u-0-0', 'b@u-0-6', 
 
185
                         self.br1.revision_history()), 
 
186
                         ['a@u-0-1', 'a@u-0-2', 'a@u-0-3', 'a@u-0-4', 
 
187
                          'b@u-0-6'])
 
188
        self.assertEqual(self.intervene('a@u-0-0', 'b@u-0-5'), 
 
189
                         ['a@u-0-1', 'a@u-0-2', 'b@u-0-3', 'b@u-0-4', 
 
190
                          'b@u-0-5'])
 
191
        self.assertEqual(self.intervene('b@u-0-3', 'b@u-0-6', 
 
192
                         self.br2.revision_history()), 
 
193
                         ['b@u-0-4', 'b@u-0-5', 'b@u-0-6'])
 
194
        self.assertEqual(self.intervene('b@u-0-6', 'b@u-0-10'), 
 
195
                         ['b@u-0-7', 'b@u-0-8', 'b@u-0-9', 'b@u-0-10'])
 
196
        self.assertEqual(self.intervene('b@u-0-6', 'b@u-0-10', 
 
197
                                        self.br2.revision_history()), 
 
198
                         ['b@u-0-7', 'b@u-0-8', 'b@u-0-9', 'b@u-0-10'])
 
199
        self.assertRaises(NotAncestor, self.intervene, 'b@u-0-10', 'b@u-0-6', 
 
200
                          self.br2.revision_history())
 
201
        self.assertRaises(NoSuchRevision, self.intervene, 'c@u-0-10', 
 
202
                          'b@u-0-6', self.br2.revision_history())
 
203
        self.assertRaises(NoSuchRevision, self.intervene, 'b@u-0-10', 
 
204
                          'c@u-0-6', self.br2.revision_history())
 
205
 
 
206
 
 
207
class TestCommonAncestor(TestCaseInTempDir):
187
208
    """Test checking whether a revision is an ancestor of another revision"""
188
209
 
 
210
    def test_old_common_ancestor(self):
 
211
        """Pick a resonable merge base using the old functionality"""
 
212
        from bzrlib.revision import old_common_ancestor as common_ancestor
 
213
        br1, br2 = make_branches()
 
214
        revisions = br1.revision_history()
 
215
        revisions_2 = br2.revision_history()
 
216
        sources = br1
 
217
 
 
218
        expected_ancestors_list = {revisions[3]:(0, 0), 
 
219
                                   revisions[2]:(1, 1),
 
220
                                   revisions_2[4]:(2, 1), 
 
221
                                   revisions[1]:(3, 2),
 
222
                                   revisions_2[3]:(4, 2),
 
223
                                   revisions[0]:(5, 3) }
 
224
        ancestors_list = find_present_ancestors(revisions[3], sources)
 
225
        assert len(expected_ancestors_list) == len(ancestors_list)
 
226
        for key, value in expected_ancestors_list.iteritems():
 
227
            self.assertEqual(ancestors_list[key], value, 
 
228
                              "key %r, %r != %r" % (key, ancestors_list[key],
 
229
                                                    value))
 
230
 
 
231
        self.assertEqual(common_ancestor(revisions[0], revisions[0], sources),
 
232
                          revisions[0])
 
233
        self.assertEqual(common_ancestor(revisions[1], revisions[2], sources),
 
234
                          revisions[1])
 
235
        self.assertEqual(common_ancestor(revisions[1], revisions[1], sources),
 
236
                          revisions[1])
 
237
        self.assertEqual(common_ancestor(revisions[2], revisions_2[4], sources),
 
238
                          revisions[2])
 
239
        self.assertEqual(common_ancestor(revisions[3], revisions_2[4], sources),
 
240
                          revisions_2[4])
 
241
        self.assertEqual(common_ancestor(revisions[4], revisions_2[5], sources),
 
242
                          revisions_2[4])
 
243
        fetch(from_branch=br2, to_branch=br1)
 
244
        self.assertEqual(common_ancestor(revisions[5], revisions_2[6], sources),
 
245
                          revisions[4]) # revisions_2[5] is equally valid
 
246
        self.assertEqual(common_ancestor(revisions_2[6], revisions[5], sources),
 
247
                          revisions_2[5])
 
248
 
189
249
    def test_common_ancestor(self):
190
250
        """Pick a reasonable merge base"""
191
 
        br1, br2 = make_branches(self)
 
251
        from bzrlib.revision import common_ancestor
 
252
        br1, br2 = make_branches()
192
253
        revisions = br1.revision_history()
193
254
        revisions_2 = br2.revision_history()
194
 
        sources = MultipleRevisionSources(br1.repository, br2.repository)
 
255
        sources = MultipleRevisionSources(br1, br2)
195
256
        expected_ancestors_list = {revisions[3]:(0, 0), 
196
257
                                   revisions[2]:(1, 1),
197
258
                                   revisions_2[4]:(2, 1), 
199
260
                                   revisions_2[3]:(4, 2),
200
261
                                   revisions[0]:(5, 3) }
201
262
        ancestors_list = find_present_ancestors(revisions[3], sources)
202
 
        self.assertEquals(len(expected_ancestors_list), len(ancestors_list))
 
263
        assert len(expected_ancestors_list) == len(ancestors_list)
203
264
        for key, value in expected_ancestors_list.iteritems():
204
265
            self.assertEqual(ancestors_list[key], value, 
205
266
                              "key %r, %r != %r" % (key, ancestors_list[key],
216
277
                          revisions_2[4])
217
278
        self.assertEqual(common_ancestor(revisions[4], revisions_2[5], sources),
218
279
                          revisions_2[4])
219
 
        self.assertTrue(common_ancestor(revisions[5], revisions_2[6], sources) in
220
 
                        (revisions[4], revisions_2[5]))
221
 
        self.assertTrue(common_ancestor(revisions_2[6], revisions[5], sources),
222
 
                        (revisions[4], revisions_2[5]))
223
 
        self.assertEqual(None, common_ancestor(None, revisions[5], sources))
224
 
        self.assertEqual(NULL_REVISION,
225
 
            common_ancestor(NULL_REVISION, NULL_REVISION, sources))
226
 
        self.assertEqual(NULL_REVISION,
227
 
            common_ancestor(revisions[0], NULL_REVISION, sources))
228
 
        self.assertEqual(NULL_REVISION,
229
 
            common_ancestor(NULL_REVISION, revisions[0], sources))
 
280
        self.assertEqual(common_ancestor(revisions[5], revisions_2[6], sources),
 
281
                          revisions[4]) # revisions_2[5] is equally valid
 
282
        self.assertEqual(common_ancestor(revisions_2[6], revisions[5], sources),
 
283
                          revisions[4]) # revisions_2[5] is equally valid
230
284
 
231
285
    def test_combined(self):
232
286
        """combined_graph
233
287
        Ensure it's not order-sensitive
234
288
        """
235
 
        br1, br2 = make_branches(self)
236
 
        source = MultipleRevisionSources(br1.repository, br2.repository)
237
 
        combined_1 = combined_graph(br1.last_revision(),
 
289
        br1, br2 = make_branches()
 
290
        source = MultipleRevisionSources(br1, br2)
 
291
        combined_1 = combined_graph(br1.last_revision(), 
238
292
                                    br2.last_revision(), source)
239
293
        combined_2 = combined_graph(br2.last_revision(),
240
294
                                    br1.last_revision(), source)
241
 
        self.assertEquals(combined_1[1], combined_2[1])
242
 
        self.assertEquals(combined_1[2], combined_2[2])
243
 
        self.assertEquals(combined_1[3], combined_2[3])
244
 
        self.assertEquals(combined_1, combined_2)
245
 
 
246
 
    def test_get_history(self):
247
 
        # TODO: test ghosts on the left hand branch's impact
248
 
        # TODO: test ghosts on all parents, we should get some
249
 
        # indicator. i.e. NULL_REVISION
250
 
        # RBC 20060608
251
 
        tree = self.make_branch_and_tree('.')
252
 
        tree.commit('1', rev_id = '1', allow_pointless=True)
253
 
        tree.commit('2', rev_id = '2', allow_pointless=True)
254
 
        tree.commit('3', rev_id = '3', allow_pointless=True)
255
 
        rev = tree.branch.repository.get_revision('1')
256
 
        history = rev.get_history(tree.branch.repository)
257
 
        self.assertEqual([None, '1'], history)
258
 
        rev = tree.branch.repository.get_revision('2')
259
 
        history = rev.get_history(tree.branch.repository)
260
 
        self.assertEqual([None, '1', '2'], history)
261
 
        rev = tree.branch.repository.get_revision('3')
262
 
        history = rev.get_history(tree.branch.repository)
263
 
        self.assertEqual([None, '1', '2' ,'3'], history)
264
 
 
265
 
    def test_common_ancestor_rootless_graph(self):
266
 
        # common_ancestor on a graph with no reachable roots - only
267
 
        # ghosts - should still return a useful value.
268
 
        graph = Graph()
269
 
        # add a ghost node which would be a root if it wasn't a ghost.
270
 
        graph.add_ghost('a_ghost')
271
 
        # add a normal commit on top of that
272
 
        graph.add_node('rev1', ['a_ghost'])
273
 
        # add a left-branch revision
274
 
        graph.add_node('left', ['rev1'])
275
 
        # add a right-branch revision
276
 
        graph.add_node('right', ['rev1'])
277
 
        source = MockRevisionSource(graph)
278
 
        self.assertEqual('rev1', common_ancestor('left', 'right', source))
279
 
 
280
 
 
281
 
class TestMultipleRevisionSources(TestCaseWithTransport):
282
 
    """Tests for the MultipleRevisionSources adapter."""
283
 
 
284
 
    def test_get_revision_graph_merges_ghosts(self):
285
 
        # when we ask for the revision graph for B, which
286
 
        # is in repo 1 with a ghost of A, and which is not
287
 
        # in repo 2, which has A, the revision_graph()
288
 
        # should return A and B both.
289
 
        tree_1 = self.make_branch_and_tree('1')
290
 
        tree_1.set_parent_ids(['A'], allow_leftmost_as_ghost=True)
291
 
        tree_1.commit('foo', rev_id='B', allow_pointless=True)
292
 
        tree_2 = self.make_branch_and_tree('2')
293
 
        tree_2.commit('bar', rev_id='A', allow_pointless=True)
294
 
        source = MultipleRevisionSources(tree_1.branch.repository,
295
 
                                         tree_2.branch.repository)
296
 
        self.assertEqual({'B':['A'],
297
 
                          'A':[]},
298
 
                         source.get_revision_graph('B'))
299
 
 
300
 
 
301
 
class TestReservedId(TestCase):
302
 
 
303
 
    def test_is_reserved_id(self):
304
 
        self.assertEqual(True, revision.is_reserved_id(NULL_REVISION))
305
 
        self.assertEqual(True, revision.is_reserved_id(
306
 
            revision.CURRENT_REVISION))
307
 
        self.assertEqual(True, revision.is_reserved_id('arch:'))
308
 
        self.assertEqual(False, revision.is_reserved_id('null'))
309
 
        self.assertEqual(False, revision.is_reserved_id(
310
 
            'arch:a@example.com/c--b--v--r'))
311
 
        self.assertEqual(False, revision.is_reserved_id(None))
 
295
        assert combined_1[1] == combined_2[1]
 
296
        assert combined_1[2] == combined_2[2]
 
297
        assert combined_1[3] == combined_2[3]
 
298
        assert combined_1 == combined_2