~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to bzrlib/selftest/test_smart_add.py

  • Committer: Martin Pool
  • Date: 2005-08-30 05:30:43 UTC
  • Revision ID: mbp@sourcefrog.net-20050830053042-58932432ee958d1e
- make get_parent() be a method of Branch; add simple tests for it

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2005, 2006 Canonical Ltd
2
 
#
3
 
# This program is free software; you can redistribute it and/or modify
4
 
# it under the terms of the GNU General Public License as published by
5
 
# the Free Software Foundation; either version 2 of the License, or
6
 
# (at your option) any later version.
7
 
#
8
 
# This program is distributed in the hope that it will be useful,
9
 
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
 
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
 
# GNU General Public License for more details.
12
 
#
13
 
# You should have received a copy of the GNU General Public License
14
 
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
 
 
17
 
from cStringIO import StringIO
18
1
import os
19
2
import unittest
20
3
 
21
 
from bzrlib import errors, ignores, osutils
22
 
from bzrlib.add import (
23
 
    AddAction,
24
 
    AddFromBaseAction,
25
 
    smart_add,
26
 
    smart_add_tree,
27
 
    )
28
 
from bzrlib.tests import TestCase, TestCaseWithTransport, TestSkipped
29
 
from bzrlib.errors import NoSuchFile
30
 
from bzrlib.inventory import InventoryFile, Inventory
31
 
from bzrlib.workingtree import WorkingTree
32
 
 
33
 
 
34
 
class TestSmartAdd(TestCaseWithTransport):
 
4
from bzrlib.selftest import TestCaseInTempDir, TestCase
 
5
from bzrlib.branch import Branch
 
6
from bzrlib.errors import NotBranchError, NotVersionedError
 
7
 
 
8
class TestSmartAdd(TestCaseInTempDir):
35
9
 
36
10
    def test_add_dot_from_root(self):
37
11
        """Test adding . from the root of the tree.""" 
38
12
        from bzrlib.add import smart_add
39
13
        paths = ("original/", "original/file1", "original/file2")
40
14
        self.build_tree(paths)
41
 
        wt = self.make_branch_and_tree('.')
42
 
        smart_add_tree(wt, (u".",))
 
15
        branch = Branch(".", init=True)
 
16
        smart_add((".",), False, True)
43
17
        for path in paths:
44
 
            self.assertNotEqual(wt.path2id(path), None)
 
18
            self.assertNotEqual(branch.inventory.path2id(path), None)
45
19
 
46
20
    def test_add_dot_from_subdir(self):
47
21
        """Test adding . from a subdir of the tree.""" 
48
22
        from bzrlib.add import smart_add
49
23
        paths = ("original/", "original/file1", "original/file2")
50
24
        self.build_tree(paths)
51
 
        wt = self.make_branch_and_tree('.')
 
25
        branch = Branch(".", init=True)
52
26
        os.chdir("original")
53
 
        smart_add_tree(wt, (u".",))
 
27
        smart_add((".",), False, True)
54
28
        for path in paths:
55
 
            self.assertNotEqual(wt.path2id(path), None)
 
29
            self.assertNotEqual(branch.inventory.path2id(path), None)
56
30
 
57
31
    def test_add_tree_from_above_tree(self):
58
32
        """Test adding a tree from above the tree.""" 
61
35
        branch_paths = ("branch/", "branch/original/", "branch/original/file1",
62
36
                        "branch/original/file2")
63
37
        self.build_tree(branch_paths)
64
 
        wt = self.make_branch_and_tree('branch')
65
 
        smart_add_tree(wt, ("branch",))
 
38
        branch = Branch("branch", init=True)
 
39
        smart_add(("branch",), False, True)
66
40
        for path in paths:
67
 
            self.assertNotEqual(wt.path2id(path), None)
 
41
            self.assertNotEqual(branch.inventory.path2id(path), None)
68
42
 
69
43
    def test_add_above_tree_preserves_tree(self):
70
44
        """Test nested trees are not affect by an add above them."""
76
50
                       "original/child/", "original/child/path")
77
51
        
78
52
        self.build_tree(build_paths)
79
 
        wt = self.make_branch_and_tree('.')
80
 
        child_tree = self.make_branch_and_tree('original/child')
81
 
        smart_add_tree(wt, (".",))
 
53
        branch = Branch(".", init=True)
 
54
        child_branch = Branch("original/child", init=True)
 
55
        smart_add((".",), False, True)
82
56
        for path in paths:
83
 
            self.assertNotEqual((path, wt.path2id(path)),
 
57
            self.assertNotEqual((path, branch.inventory.path2id(path)),
84
58
                                (path, None))
85
59
        for path in full_child_paths:
86
 
            self.assertEqual((path, wt.path2id(path)),
 
60
            self.assertEqual((path, branch.inventory.path2id(path)),
87
61
                             (path, None))
88
62
        for path in child_paths:
89
 
            self.assertEqual(child_tree.path2id(path), None)
 
63
            self.assertEqual(child_branch.inventory.path2id(path), None)
90
64
 
91
65
    def test_add_paths(self):
92
66
        """Test smart-adding a list of paths."""
93
67
        from bzrlib.add import smart_add
94
68
        paths = ("file1", "file2")
95
69
        self.build_tree(paths)
96
 
        wt = self.make_branch_and_tree('.')
97
 
        smart_add_tree(wt, paths)
 
70
        branch = Branch(".", init=True)
 
71
        smart_add(paths, False, True)
98
72
        for path in paths:
99
 
            self.assertNotEqual(wt.path2id(path), None)
100
 
    
101
 
    def test_add_ignored_nested_paths(self):
102
 
        """Test smart-adding a list of paths which includes ignored ones."""
103
 
        wt = self.make_branch_and_tree('.')
104
 
        tree_shape = ("adir/", "adir/CVS/", "adir/CVS/afile", "adir/CVS/afile2")
105
 
        add_paths = ("adir/CVS", "adir/CVS/afile", "adir")
106
 
        expected_paths = ("adir", "adir/CVS", "adir/CVS/afile", "adir/CVS/afile2")
107
 
        self.build_tree(tree_shape)
108
 
        smart_add_tree(wt, add_paths)
109
 
        for path in expected_paths:
110
 
            self.assertNotEqual(wt.path2id(path), None, "No id added for %s" % path)
111
 
 
112
 
    def test_save_false(self):
113
 
        """Test smart-adding a path with save set to false."""
114
 
        wt = self.make_branch_and_tree('.')
115
 
        self.build_tree(['file'])
116
 
        smart_add_tree(wt, ['file'], save=False)
117
 
        self.assertNotEqual(wt.path2id('file'), None, "No id added for 'file'")
118
 
        wt.read_working_inventory()
119
 
        self.assertEqual(wt.path2id('file'), None)
120
 
 
121
 
    def test_add_dry_run(self):
122
 
        """Test a dry run add, make sure nothing is added."""
123
 
        from bzrlib.commands import run_bzr
124
 
        eq = self.assertEqual
125
 
        wt = self.make_branch_and_tree('.')
126
 
        self.build_tree(['inertiatic/', 'inertiatic/esp'])
127
 
        eq(list(wt.unknowns()), ['inertiatic'])
128
 
        self.capture('add --dry-run .')
129
 
        eq(list(wt.unknowns()), ['inertiatic'])
130
 
 
131
 
    def test_add_non_existant(self):
132
 
        """Test smart-adding a file that does not exist."""
133
 
        from bzrlib.add import smart_add
134
 
        wt = self.make_branch_and_tree('.')
135
 
        self.assertRaises(NoSuchFile, smart_add_tree, wt, 'non-existant-file')
136
 
 
137
 
    def test_returns_and_ignores(self):
138
 
        """Correctly returns added/ignored files"""
139
 
        from bzrlib.commands import run_bzr
140
 
        wt = self.make_branch_and_tree('.')
141
 
        # The default ignore list includes '*.py[co]', but not CVS
142
 
        ignores._set_user_ignores(['*.py[co]'])
143
 
        self.build_tree(['inertiatic/', 'inertiatic/esp', 'inertiatic/CVS',
144
 
                        'inertiatic/foo.pyc'])
145
 
        added, ignored = smart_add_tree(wt, u'.')
146
 
        self.assertSubset(('inertiatic', 'inertiatic/esp', 'inertiatic/CVS'),
147
 
                          added)
148
 
        self.assertSubset(('*.py[co]',), ignored)
149
 
        self.assertSubset(('inertiatic/foo.pyc',), ignored['*.py[co]'])
150
 
 
151
 
 
152
 
class AddCustomIDAction(AddAction):
153
 
 
154
 
    def __call__(self, inv, parent_ie, path, kind):
155
 
        # The first part just logs if appropriate
156
 
        # Now generate a custom id
157
 
        file_id = kind + '-' + path.raw_path.replace('/', '%')
158
 
        if self.should_print:
159
 
            self._to_file.write('added %s with id %s\n' 
160
 
                                % (path.raw_path, file_id))
161
 
        return file_id
162
 
 
163
 
 
164
 
class TestSmartAddTree(TestCaseWithTransport):
 
73
            self.assertNotEqual(branch.inventory.path2id(path), None)
 
74
            
 
75
class TestSmartAddBranch(TestCaseInTempDir):
165
76
    """Test smart adds with a specified branch."""
166
77
 
167
78
    def test_add_dot_from_root(self):
168
79
        """Test adding . from the root of the tree.""" 
 
80
        from bzrlib.add import smart_add_branch
169
81
        paths = ("original/", "original/file1", "original/file2")
170
82
        self.build_tree(paths)
171
 
        wt = self.make_branch_and_tree('.')
172
 
        smart_add_tree(wt, (u".",))
 
83
        branch = Branch(".", init=True)
 
84
        smart_add_branch(branch, (".",), False, True)
173
85
        for path in paths:
174
 
            self.assertNotEqual(wt.path2id(path), None)
 
86
            self.assertNotEqual(branch.inventory.path2id(path), None)
175
87
 
176
88
    def test_add_dot_from_subdir(self):
177
89
        """Test adding . from a subdir of the tree.""" 
 
90
        from bzrlib.add import smart_add_branch
178
91
        paths = ("original/", "original/file1", "original/file2")
179
92
        self.build_tree(paths)
180
 
        wt = self.make_branch_and_tree('.')
 
93
        branch = Branch(".", init=True)
181
94
        os.chdir("original")
182
 
        smart_add_tree(wt, (u".",))
 
95
        smart_add_branch(branch, (".",), False, True)
183
96
        for path in paths:
184
 
            self.assertNotEqual(wt.path2id(path), None)
 
97
            self.assertNotEqual(branch.inventory.path2id(path), None)
185
98
 
186
99
    def test_add_tree_from_above_tree(self):
187
100
        """Test adding a tree from above the tree.""" 
 
101
        from bzrlib.add import smart_add_branch
188
102
        paths = ("original/", "original/file1", "original/file2")
189
103
        branch_paths = ("branch/", "branch/original/", "branch/original/file1",
190
104
                        "branch/original/file2")
191
105
        self.build_tree(branch_paths)
192
 
        tree = self.make_branch_and_tree('branch')
193
 
        smart_add_tree(tree, ("branch",))
 
106
        branch = Branch("branch", init=True)
 
107
        smart_add_branch(branch, ("branch",), False, True)
194
108
        for path in paths:
195
 
            self.assertNotEqual(tree.path2id(path), None)
 
109
            self.assertNotEqual(branch.inventory.path2id(path), None)
196
110
 
197
111
    def test_add_above_tree_preserves_tree(self):
198
112
        """Test nested trees are not affect by an add above them."""
 
113
        from bzrlib.add import smart_add_branch
199
114
        paths = ("original/", "original/file1", "original/file2")
200
115
        child_paths = ("path")
201
116
        full_child_paths = ("original/child", "original/child/path")
202
117
        build_paths = ("original/", "original/file1", "original/file2", 
203
118
                       "original/child/", "original/child/path")
204
119
        self.build_tree(build_paths)
205
 
        tree = self.make_branch_and_tree('.')
206
 
        child_tree = self.make_branch_and_tree("original/child")
207
 
        smart_add_tree(tree, (u".",))
 
120
        branch = Branch(".", init=True)
 
121
        child_branch = Branch("original/child", init=True)
 
122
        smart_add_branch(branch, (".",), False, True)
208
123
        for path in paths:
209
 
            self.assertNotEqual((path, tree.path2id(path)),
 
124
            self.assertNotEqual((path, branch.inventory.path2id(path)),
210
125
                                (path, None))
211
126
        for path in full_child_paths:
212
 
            self.assertEqual((path, tree.path2id(path)),
 
127
            self.assertEqual((path, branch.inventory.path2id(path)),
213
128
                             (path, None))
214
129
        for path in child_paths:
215
 
            self.assertEqual(child_tree.path2id(path), None)
 
130
            self.assertEqual(child_branch.inventory.path2id(path), None)
216
131
 
217
132
    def test_add_paths(self):
218
133
        """Test smart-adding a list of paths."""
 
134
        from bzrlib.add import smart_add_branch
219
135
        paths = ("file1", "file2")
220
136
        self.build_tree(paths)
221
 
        wt = self.make_branch_and_tree('.')
222
 
        smart_add_tree(wt, paths)
 
137
        branch = Branch(".", init=True)
 
138
        smart_add_branch(branch, paths, False, True)
223
139
        for path in paths:
224
 
            self.assertNotEqual(wt.path2id(path), None)
225
 
 
226
 
    def test_add_multiple_dirs(self):
227
 
        """Test smart adding multiple directories at once."""
228
 
        added_paths = ['file1', 'file2',
229
 
                       'dir1/', 'dir1/file3',
230
 
                       'dir1/subdir2/', 'dir1/subdir2/file4',
231
 
                       'dir2/', 'dir2/file5',
232
 
                      ]
233
 
        not_added = ['file6', 'dir3/', 'dir3/file7', 'dir3/file8']
234
 
        self.build_tree(added_paths)
235
 
        self.build_tree(not_added)
236
 
 
237
 
        wt = self.make_branch_and_tree('.')
238
 
        smart_add_tree(wt, ['file1', 'file2', 'dir1', 'dir2'])
239
 
 
240
 
        for path in added_paths:
241
 
            self.assertNotEqual(None, wt.path2id(path.rstrip('/')),
242
 
                    'Failed to add path: %s' % (path,))
243
 
        for path in not_added:
244
 
            self.assertEqual(None, wt.path2id(path.rstrip('/')),
245
 
                    'Accidentally added path: %s' % (path,))
246
 
 
247
 
    def test_custom_ids(self):
248
 
        sio = StringIO()
249
 
        action = AddCustomIDAction(to_file=sio, should_print=True)
250
 
        self.build_tree(['file1', 'dir1/', 'dir1/file2'])
251
 
 
252
 
        wt = self.make_branch_and_tree('.')
253
 
        smart_add_tree(wt, ['.'], action=action)
254
 
        # The order of adds is not strictly fixed:
255
 
        sio.seek(0)
256
 
        lines = sorted(sio.readlines())
257
 
        self.assertEqualDiff(['added dir1 with id directory-dir1\n',
258
 
                              'added dir1/file2 with id file-dir1%file2\n',
259
 
                              'added file1 with id file-file1\n',
260
 
                             ], lines)
261
 
        self.assertEqual([('', wt.inventory.root.file_id),
262
 
                          ('dir1', 'directory-dir1'),
263
 
                          ('dir1/file2', 'file-dir1%file2'),
264
 
                          ('file1', 'file-file1'),
265
 
                         ], [(path, ie.file_id) for path, ie
266
 
                                in wt.inventory.iter_entries()])
267
 
 
268
 
 
269
 
class TestAddFrom(TestCaseWithTransport):
270
 
    """Tests for AddFromBaseAction"""
271
 
 
272
 
    def make_base_tree(self):
273
 
        self.base_tree = self.make_branch_and_tree('base')
274
 
        self.build_tree(['base/a', 'base/b',
275
 
                         'base/dir/', 'base/dir/a',
276
 
                         'base/dir/subdir/',
277
 
                         'base/dir/subdir/b',
278
 
                        ])
279
 
        self.base_tree.add(['a', 'b', 'dir', 'dir/a',
280
 
                            'dir/subdir', 'dir/subdir/b'])
281
 
        self.base_tree.commit('creating initial tree.')
282
 
 
283
 
    def add_helper(self, base_tree, base_path, new_tree, file_list,
284
 
                   should_print=False):
285
 
        to_file = StringIO()
286
 
        base_tree.lock_read()
287
 
        try:
288
 
            new_tree.lock_write()
289
 
            try:
290
 
                action = AddFromBaseAction(base_tree, base_path,
291
 
                                           to_file=to_file,
292
 
                                           should_print=should_print)
293
 
                smart_add_tree(new_tree, file_list, action=action)
294
 
            finally:
295
 
                new_tree.unlock()
296
 
        finally:
297
 
            base_tree.unlock()
298
 
        return to_file.getvalue()
299
 
 
300
 
    def test_copy_all(self):
301
 
        self.make_base_tree()
302
 
        new_tree = self.make_branch_and_tree('new')
303
 
        files = ['a', 'b',
304
 
                 'dir/', 'dir/a',
305
 
                 'dir/subdir/',
306
 
                 'dir/subdir/b',
307
 
                ]
308
 
        self.build_tree(['new/' + fn for fn in files])
309
 
        self.add_helper(self.base_tree, '', new_tree, ['new'])
310
 
 
311
 
        for fn in files:
312
 
            base_file_id = self.base_tree.path2id(fn)
313
 
            new_file_id = new_tree.path2id(fn)
314
 
            self.assertEqual(base_file_id, new_file_id)
315
 
 
316
 
    def test_copy_from_dir(self):
317
 
        self.make_base_tree()
318
 
        new_tree = self.make_branch_and_tree('new')
319
 
 
320
 
        self.build_tree(['new/a', 'new/b', 'new/c',
321
 
                         'new/subdir/', 'new/subdir/b', 'new/subdir/d'])
322
 
        new_tree.set_root_id(self.base_tree.get_root_id())
323
 
        self.add_helper(self.base_tree, 'dir', new_tree, ['new'])
324
 
 
325
 
        # We know 'a' and 'b' exist in the root, and they are being added
326
 
        # in a new 'root'. Since ROOT ids have been set as the same, we will
327
 
        # use those ids
328
 
        self.assertEqual(self.base_tree.path2id('a'),
329
 
                         new_tree.path2id('a'))
330
 
        self.assertEqual(self.base_tree.path2id('b'),
331
 
                         new_tree.path2id('b'))
332
 
 
333
 
        # Because we specified 'dir/' as the base path, and we have
334
 
        # nothing named 'subdir' in the base tree, we should grab the
335
 
        # ids from there
336
 
        self.assertEqual(self.base_tree.path2id('dir/subdir'),
337
 
                         new_tree.path2id('subdir'))
338
 
        self.assertEqual(self.base_tree.path2id('dir/subdir/b'),
339
 
                         new_tree.path2id('subdir/b'))
340
 
 
341
 
        # These should get newly generated ids
342
 
        c_id = new_tree.path2id('c')
343
 
        self.assertNotEqual(None, c_id)
344
 
        self.failIf(c_id in self.base_tree)
345
 
 
346
 
        d_id = new_tree.path2id('subdir/d')
347
 
        self.assertNotEqual(None, d_id)
348
 
        self.failIf(d_id in self.base_tree)
349
 
 
350
 
    def test_copy_existing_dir(self):
351
 
        self.make_base_tree()
352
 
        new_tree = self.make_branch_and_tree('new')
353
 
        self.build_tree(['new/subby/', 'new/subby/a', 'new/subby/b'])
354
 
 
355
 
        subdir_file_id = self.base_tree.path2id('dir/subdir')
356
 
        new_tree.add(['subby'], [subdir_file_id])
357
 
        self.add_helper(self.base_tree, '', new_tree, ['new'])
358
 
        # Because 'subby' already points to subdir, we should add
359
 
        # 'b' with the same id
360
 
        self.assertEqual(self.base_tree.path2id('dir/subdir/b'),
361
 
                         new_tree.path2id('subby/b'))
362
 
 
363
 
        # 'subby/a' should be added with a new id because there is no
364
 
        # matching path or child of 'subby'.
365
 
        a_id = new_tree.path2id('subby/a')
366
 
        self.assertNotEqual(None, a_id)
367
 
        self.failIf(a_id in self.base_tree)
368
 
 
369
 
 
370
 
class TestAddNonNormalized(TestCaseWithTransport):
371
 
 
372
 
    def make(self):
373
 
        try:
374
 
            self.build_tree([u'a\u030a'])
375
 
        except UnicodeError:
376
 
            raise TestSkipped('Filesystem cannot create unicode filenames')
377
 
 
378
 
        self.wt = self.make_branch_and_tree('.')
379
 
 
380
 
    def test_accessible_explicit(self):
381
 
        self.make()
382
 
        orig = osutils.normalized_filename
383
 
        osutils.normalized_filename = osutils._accessible_normalized_filename
384
 
        try:
385
 
            smart_add_tree(self.wt, [u'a\u030a'])
386
 
            self.assertEqual([('', 'directory'), (u'\xe5', 'file')],
387
 
                    [(path, ie.kind) for path,ie in 
388
 
                        self.wt.inventory.iter_entries()])
389
 
        finally:
390
 
            osutils.normalized_filename = orig
391
 
 
392
 
    def test_accessible_implicit(self):
393
 
        self.make()
394
 
        orig = osutils.normalized_filename
395
 
        osutils.normalized_filename = osutils._accessible_normalized_filename
396
 
        try:
397
 
            smart_add_tree(self.wt, [])
398
 
            self.assertEqual([('', 'directory'), (u'\xe5', 'file')],
399
 
                    [(path, ie.kind) for path,ie in 
400
 
                        self.wt.inventory.iter_entries()])
401
 
        finally:
402
 
            osutils.normalized_filename = orig
403
 
 
404
 
    def test_inaccessible_explicit(self):
405
 
        self.make()
406
 
        orig = osutils.normalized_filename
407
 
        osutils.normalized_filename = osutils._inaccessible_normalized_filename
408
 
        try:
409
 
            self.assertRaises(errors.InvalidNormalization,
410
 
                    smart_add_tree, self.wt, [u'a\u030a'])
411
 
        finally:
412
 
            osutils.normalized_filename = orig
413
 
 
414
 
    def test_inaccessible_implicit(self):
415
 
        self.make()
416
 
        orig = osutils.normalized_filename
417
 
        osutils.normalized_filename = osutils._inaccessible_normalized_filename
418
 
        try:
419
 
            # TODO: jam 20060701 In the future, this should probably
420
 
            #       just ignore files that don't fit the normalization
421
 
            #       rules, rather than exploding
422
 
            self.assertRaises(errors.InvalidNormalization,
423
 
                    smart_add_tree, self.wt, [])
424
 
        finally:
425
 
            osutils.normalized_filename = orig
426
 
 
427
 
 
428
 
class TestAddActions(TestCase):
429
 
 
430
 
    def test_quiet(self):
431
 
        self.run_action("")
432
 
 
433
 
    def test__print(self):
434
 
        self.run_action("added path\n")
435
 
 
436
 
    def run_action(self, output):
437
 
        from bzrlib.add import AddAction, FastPath
438
 
        inv = Inventory()
 
140
            self.assertNotEqual(branch.inventory.path2id(path), None)
 
141
 
 
142
class TestAddCallbacks(TestCaseInTempDir):
 
143
 
 
144
    def setUp(self):
 
145
        from bzrlib.inventory import InventoryEntry
 
146
        super(TestAddCallbacks, self).setUp()
 
147
        self.entry = InventoryEntry("id", "name", "file", None)
 
148
 
 
149
    def test_null_callback(self):
 
150
        from bzrlib.add import _NullAddCallback
 
151
        _NullAddCallback('path', 'file', self.entry)
 
152
 
 
153
    def test_print_callback(self):
 
154
        from bzrlib.add import _PrintAddCallback
 
155
        from StringIO import StringIO
439
156
        stdout = StringIO()
440
 
        action = AddAction(to_file=stdout, should_print=bool(output))
441
 
 
442
 
        self.apply_redirected(None, stdout, None, action, inv, None, FastPath('path'), 'file')
443
 
        self.assertEqual(stdout.getvalue(), output)
 
157
        self.apply_redirected(None, stdout, None, _PrintAddCallback,
 
158
                              'path', 'file', self.entry)
 
159
        self.assertEqual(stdout.getvalue(), "added path\n")