← Back to branch summary

~bzr-pqm/bzr/bzr.dev

« back to all changes in this revision

Viewing changes to diff-delta.c

  • Committer: John Arbash Meinel
  • Date: 2009-03-02 20:27:18 UTC
  • mto: (0.17.31 trunk)
  • mto: This revision was merged to the branch mainline in revision 4280.
  • Revision ID: john@arbash-meinel.com-20090302202718-c7ojzhft35boi1kn
Add a bit of comments about things to do.

Show diffs side-by-side

added added

removed removed

Lines of Context:
diff-delta.c
392
392
                                i = val & index->hash_mask;
393
393
                                ref_top = index->src_buf + index->src_size;
394
394
                                ref_data = index->src_buf;
 
395
                                /* TODO: When using multiple indexes like this, the hash tables
 
396
                                 *               mapping val => index_entry become less efficient.
 
397
                                 *               You end up getting a lot more collisions in the hash,
 
398
                                 *               which doesn't actually lead to a entry->val match.
 
399
                                 */
395
400
                                for (entry = index->hash[i]; entry < index->hash[i+1];
396
401
                                         entry++) {
397
402
                                        const unsigned char *ref = entry->ptr;