~bzr-pqm/bzr/bzr.dev

  • Committer: John Arbash Meinel
  • Date: 2011-04-20 14:27:19 UTC
  • Revision ID: john@arbash-meinel.com-20110420142719-advs1k5vztqzbrgv
Fix bug #767177. Be more agressive with file.close() calls.

Our test suite gets a number of thread leaks and failures because it happens to get async
SFTPFile.close() calls. (if an SFTPFile closes due to __del__ it is done as an async request,
while if you call SFTPFile.close() it is done as a synchronous request.)
We have a couple other cases, probably. Namely SFTPTransport.get() also does an async
prefetch of the content, so if you don't .read() you'll also leak threads that think they
are doing work that you want.

The biggest change here, though, is using a try/finally in a generator, which is not 
python2.4 compatible.
Filename Latest Rev Last Changed Committer Comment Size
..
bzr-crashdb.conf 4797.33.16 14 years ago Robert Collins Update bugfix for 528114 to trunk. 174 bytes Diff Download File
README 4797.33.16 14 years ago Robert Collins Update bugfix for 528114 to trunk. 399 bytes Diff Download File
source_bzr.py 4797.33.16 14 years ago Robert Collins Update bugfix for 528114 to trunk. 1.4 KB Diff Download File