~bzr-pqm/bzr/bzr.dev : changes

~bzr-pqm/bzr/bzr.dev » Changes from revision 5247.2.40

Rev	Summary	Authors	Date
5247.2.20	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.19	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.18	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.17	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.16	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.15	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.14	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.13	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.12	Ensure that all transports close their underlying connection... Ensure that all transports close their underlying connection. * bzrlib/transport/sftp.py: (SFTPTransport.disconnect): Close the sftp connection. * bzrlib/transport/remote.py: (RemoteTransport.disconnect): The medium can be None. * bzrlib/transport/http/_urllib.py: (HttpTransport_urllib.disconnect): Close the http connection. * bzrlib/transport/http/_pycurl.py: (PyCurlTransport.disconnect): Close the Curl object. * bzrlib/transport/http/__init__.py: (SmartClientHTTPMedium.disconnect): Disconnect the backing http transport. * bzrlib/transport/gio_transport.py: (GioTransport.disconnect): Hmm, nothing obvious here. * bzrlib/transport/ftp/__init__.py: (FtpTransport.disconnect): Close the ftplib connection. * bzrlib/transport/__init__.py: (Transport.disconnect): A do-nothing implementation by default. (ConnectedTransport.disconnect): A new required method. * bzrlib/tests/test_smart_transport.py: (TestSmartTCPServer.test_get_error_unexpected) (SmartTCPTests.start_server): Revert to SmartServer waiting for a better way to capture the connections. * bzrlib/tests/per_transport.py: (TransportTests.test_connection_sharing): 'None' is better than 'object()' for a dummy connection. * bzrlib/tests/__init__.py: (TestCase._check_leaked_threads): Don't fail at first leak or all subsequent tests will fail too. A more elaborate scheme would be to use threading.enumerate() but that's a big hammer with little benefits as long as there exist "valid" leaks (like the smart server). (TestCaseWithMemoryTransport.setUp): Make sure we call transport.disconnect() for all created transports.	Vincent Ladeuil	14 years ago
5247.2.11	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.10	Use SmartTCPServer_for_testing instead of SmartTCPServer (br... Use SmartTCPServer_for_testing instead of SmartTCPServer (broken).	Vincent Ladeuil	14 years ago
5247.2.9	The smart server leaks one thread (daemonic) for each connec... The smart server leaks one thread (daemonic) for each connection. * bzrlib/tests/test_smart_transport.py: (SmartTCPTests.start_server): Use stop_server for consistency. (SmartTCPTests.stop_server): Rename from tearDownServer for consistency. (TestServerSocketUsage.test_server_closes_listening_sock_on_shutdown_after_request): Keep track of the server URL explicitly. * bzrlib/smart/server.py (SmartTCPServer.serve_conn): Mark the origin of the leak.	Vincent Ladeuil	14 years ago
5247.2.8	Merge sftp-leaks into catch-them-all Merge sftp-leaks into catch-them-all	Vincent Ladeuil	14 years ago
5247.2.7	Start requiring no leaks at all for tests purposes. Start requiring no leaks at all for tests purposes. * bzrlib/tests/__init__.py: (TestCase._check_leaked_threads): Rude but effective.	Vincent Ladeuil	14 years ago
5247.2.6	Clarify some iable/method names in the test servers. Clarify some iable/method names in the test servers. * bzrlib/tests/stub_sftp.py: (SocketListener.__init__): '_connection_callback is more explicit than '_callback'. (SFTPServer._run_server_entry): Mention that SocketDelay is probably ineffective for the connections themselves. (SFTPServer._run_server): 'ready' is more explicit than 'event'. * bzrlib/tests/http_server.py: (HttpServer.run_server): 'run_server' is more explicit than http_start.	Vincent Ladeuil	14 years ago
5247.2.5	Some cleanups. Some cleanups. * bzrlib/tests/test_server.py: (ThreadWithException): Use a better name for the internal event. * bzrlib/tests/test_http.py: (RecordingServer.start_server): Use ThreadWithException. (RecordingServer._accept_read_and_reply): Timeout is evil, don't use it :) * bzrlib/tests/http_server.py: (TestingHTTPServerMixin.shutdown_client_socket): Don't pollute ourput with caught exceptions. (HttpServer.start_server): Not a daemonic thread anymore.	Vincent Ladeuil	14 years ago
5247.2.4	Add an event to ThreadWithException that can be shared with ... Add an event to ThreadWithException that can be shared with the calling thread. * bzrlib/tests/test_server.py: (ThreadWithException.__init__): Add an 'event' parameter that can be shared with the caller. (ThreadWithException.run): Sset the event once the exception has been recorded so we can release the caller and provide the exception. (ThreadWithException.join): Properly raise the recorded exception. * bzrlib/tests/test_http.py: (TestHTTPServer.test_force_invalid_protocol): Just rely on assertRaises or we don't get the traceback on error. (TestHTTPServer.test_server_start_and_stop): Cleanup. * bzrlib/tests/http_server.py: (HttpServer._http_start): Simplified. (HttpServer.start_server): Leave the ThreadWithException do its work. (HttpServer.stop_server): Shutdown the server only if it was started.	Vincent Ladeuil	14 years ago
5247.2.3	join(timeout=0) is useful to check for an exception without ... join(timeout=0) is useful to check for an exception without stopping the thread. * bzrlib/tests/test_server.py: (ThreadWithException.join): Document the timeout=0 idiom. * bzrlib/tests/test_transport.py: (TestThreadWithException.test_exception_is_re_raised): Ensure join(timeout=0) can be called while leaving the thread running	Vincent Ladeuil	14 years ago
5247.2.2	Implement a thread that can re-raise exceptions. Implement a thread that can re-raise exceptions. * bzrlib/tests/test_transport.py: (TestThreadWithException): Test that the execption is re-raised at join() time. * bzrlib/tests/test_server.py: (ThreadWithException): We need a thread that catch and re-raise any exception.	Vincent Ladeuil	14 years ago
5247.2.1	Merge first-try into propagate-exceptions Merge first-try into propagate-exceptions	Vincent Ladeuil	14 years ago