~bzr-pqm/bzr/bzr.dev : changes

~bzr-pqm/bzr/bzr.dev » Changes from revision 3059.2.18

Rev	Summary	Authors	Date
3059.2.18	Take spiv review comments into account. Take spiv review comments into account. * bzrlib/transport/http/response.py: (RangeFile._seek_to_next_range): Factored out since this is now used by both seek and read. (RangeFile.read): Trigger next range recognition when needed. (RangeFile.seek): Don't seek over the range boundary if not required to. * bzrlib/transport/http/__init__.py: (HttpTransportBase._coalesce_readv.get_and_yield): Add a prophylactic assertionError. * bzrlib/tests/test_transport_implementations.py: Fix typos. * bzrlib/tests/test_http_response.py: (TestRangeFileMixin.test_read_zero, TestRangeFileMixin.test_seek_at_range_end, TestRangeFileMixin.test_read_at_range_end, TestRangeFileSizeUnknown.test_read_at_range_end, TestRangeFilMultipleRanges.test_seek_at_range_end, TestRangeFilMultipleRanges.test_read_at_range_end): More tests covering read(0).	Vincent Ladeuil	17 years ago
3059.2.17	Limit GET requests by body size instead of number of ranges. Limit GET requests by body size instead of number of ranges. * bzrlib/transport/http/response.py: Fix some error messages. (RangeFile.read_range_definition): Keep the range headers in the _headers attribute for easier debugging (especially for remote debugging). * bzrlib/transport/http/_pycurl.py: (PyCurlTransport): Replace _max_readv_combine by _get_max_size which is more approriate to the problem. * bzrlib/transport/http/__init__.py: (HttpTransportBase): Add a _get_max_size class attribute corresponding to the max_size _coalesced_offets max_size parameter. (HttpTransportBase._coalesce_readv): Limit the size of the get requests if _get_max_size is greater than 0 while still respecting the maximum number of ranges in a request. * bzrlib/tests/test_http.py: (TestRangeRequestServer.test_readv_get_max_size): Test the _get_max_size parameter. * bzrlib/transport/__init__.py: (Transport._coalesce_offsets): Add a max_size parameter limiting the size of the coalesced offsets. * bzrlib/tests/test_transport.py: (TestCoalesceOffsets.check): Add the max_size parameter. (TestCoalesceOffsets.test_coalesce_max_size, TestCoalesceOffsets.test_coalesce_no_max_size): Test the max_size parameter.	Vincent Ladeuil	17 years ago
3059.2.16	Cleanup (thanks again to --coverage). Cleanup (thanks again to --coverage). * bzrlib/transport/http/__init__.py: (HttpTransportBase._get_ranges_hinted): Deleted, not used anymore by _readv. (HttpTransportBase.offsets_to_ranges): Deprecated in 0.17.	Vincent Ladeuil	17 years ago
3059.2.15	Fix bogus test. Fix bogus test. * bzrlib/tests/test_http.py: (TestRanges._file_tail): Fix the test that was hiding the bug in RangeFile.seek.	Vincent Ladeuil	17 years ago
3059.2.14	Complete coverage by adding tests for more invalid inputs. F... Complete coverage by adding tests for more invalid inputs. Fix a bug when seeking from end (not used by bzrlib). * bzrlib/tests/test_http_response.py: (TestRangeFileMixin.test_seek_from_end): Strangely this one was missed in the previous refactoring and rewriting it revealed a bug already present in the original (pre-streamed) implementation. (TestRangeFileSingleRange): Revealed by --coverage, this can't be encountered in normal use. (TestRangeFilMultipleRanges.test_seek_from_end): Multiple range have a slighty different behavior. (TestRangeFileVarious.test_seek_whence): Revealed by --coverage. (TestRangeFileVarious.test_range_syntax): Revealed by --coverage, add more tests for invalid inputs. (TestHandleResponse.test_single_range_truncated, TestHandleResponse.test_multipart_no_content_range, TestHandleResponse.test_multipart_no_boundary): Revealed by --coverage, add more tests for invalid inputs. * bzrlib/transport/http/response.py: (RangeFile.seek): Off-by-one error for whence=2.	Vincent Ladeuil	17 years ago
3059.2.13	merge bzr.dev merge bzr.dev	Vincent Ladeuil	17 years ago
3059.2.12	Spiv review feedback. Spiv review feedback. * bzrlib/tests/test_http_response.py: Redesigned following spiv advices (with some liberties so all errors are still mine ;). * bzrlib/tests/test_errors.py: Add tests for InvalidRange and InvalidHttpRange. * bzrlib/tests/HttpServer.py: (TestingHTTPRequestHandler.get_multiple_ranges): One boundary line before each range and one final boundary line.	Vincent Ladeuil	17 years ago
3059.2.11	Fix typos mentioned by spiv. Fix typos mentioned by spiv.	Vincent Ladeuil	17 years ago
3059.2.10	Jam's review feedback. Jam's review feedback. * bzrlib/transport/http/response.py: (RangeFile.set_range_from_header): Catch ValueError only. * bzrlib/transport/http/__init__.py: (HttpTransportBase._readv, HttpTransportBase._coalesce_readv): 'file' is a builtin use rfile instead. * bzrlib/tests/test_transport_implementations.py: (TransportTests.test_get): Use izip.	Vincent Ladeuil	17 years ago
3059.2.9	Fix commit resolution error. Fix commit resolution error.	Vincent Ladeuil	17 years ago
3059.2.8	Update NEWS. Update NEWS.	Vincent Ladeuil	17 years ago
3059.2.7	Allow pycurl users to watch the blinkenlights and fix a bug ... Allow pycurl users to watch the blinkenlights and fix a bug when ranges are contiguous. * bzrlib/transport/http/response.py: (RangeFile.read): Fix indentation. (RangeFile.seek): Off-by-one error if the pos is after the range (i.e. at start + size), the range has been fully read, the next range should be started. * bzrlib/transport/http/_pycurl.py: (PyCurlTransport): Limit coalescing to issur more requests to compensate for the pycurl lack of feedback. * bzrlib/transport/http/__init__.py: (HttpTransportBase._get_ranges_hinted): Catch InvalidHttpRange, not InvalidRange which cannot occur here. * bzrlib/tests/test_http_response.py: (TestRangeFileAccess._file_multi_ranges): Add a third range contiguous to the second one. (TestRangeFileAccess.test_valid_accesses): Test the case where the last read ends at the end of the range leaving pos at a value equals to the start of a next contiguous range.	Vincent Ladeuil	17 years ago
3059.2.6	Light modifications after a failed attempt at making RangeFi... Light modifications after a failed attempt at making RangeFile iterable. * bzrlib/transport/http/__init__.py: (HttpTransportBase.get): Better document while we wrap th result into a StringIO(). * bzrlib/tests/test_http_response.py: (TestRanges.test_range_syntax): Provide a usable file-like object.	Vincent Ladeuil	17 years ago
3059.2.5	DAMN^64, the http test server is 1.0 not 1.1 :( Better pipe ... DAMN^64, the http test server is 1.0 not 1.1 :( Better pipe cleaning and less readv caching (since that's the point of the whole fix). * bzrlib/transport/http/_urllib2_wrappers.py: (Response.finish): Do the Right Thing to clean the pipe: most of the time we know exactly how many bytes are still to be read. And when we don't, we are not maintaining a persistent connection so we don't care. (AbstractHTTPConnection.__init__): Keep track of the last response handled. (AbstractHTTPConnection._mutter_connect): New method issuing the traces. (AbstractHTTPConnection.getresponse): Capture each response. (AbstractHTTPConnection.cleanup_pipe): Delegate the cleaning to the response, it knows better. (HTTPConnection.__init__): Not the right place to reliably trace the connections issued. (HTTPConnection.connect, HTTPSConnection.connect): Right place to reliably trace the connections issued. (AbstractHTTPHandler.do_open): The debug output for response was not done at the right place, resulting in trace doubling in case of retry on errors. * bzrlib/transport/http/__init__.py: (HttpTransportBase._readv): If the coalesced offsets order matches the provided offsets order, don't cache. Ftw.	Vincent Ladeuil	17 years ago
3059.2.4	Fix typo so that all tests pass now (after merging bzr.dev t... Fix typo so that all tests pass now (after merging bzr.dev to get rid of the is_ancestor failure). * bzrlib/transport/http/_pycurl.py: (PyCurlTransport._get_ranged): Fix typo.	Vincent Ladeuil	17 years ago
3059.2.3	merge bzr.dev merge bzr.dev	Vincent Ladeuil	17 years ago
3059.2.2	Read http responses on demand without buffering the whole bo... Read http responses on demand without buffering the whole body response. * bzrlib/transport/http/response.py: New implementation of handle_response with only one RangeFile class covering all the needs. The main purpose is to read the data on demand instead of buffering everything at the beginning. The main target is readv but get needs are addressed as well. (RangeFile): Respect socket use by handling ranges on the fly and never seeking backwards. (HttpRangeResponse, HttpMultipartRangeResponse): Deleted. (handle_response): The 'headers' parameter is now an HTTPMessage containing the response headers. Stop handling 4xx error codes, the clients do that themselves. * bzrlib/transport/http/_urllib2_wrappers.py: (AbstractHTTPConnection.cleanup_pipe): Renamed from 'fake_close' the new name is more appropriate and less scary (the content is the same though). (HTTPDefaultErrorHandler.http_error_default): Stop handling 416 here to get a finer control in the layer above. * bzrlib/transport/http/_urllib.py: (HttpTransport_urllib._perform): Cleanup the httplib pipe before each request so that clients can leave it dirty without worrying. (HttpTransport_urllib._get): Add 416 as an expected error so that we handle it (_urllib2_wrappers was handling it before). (HttpTransport_urllib._get): Handle 400 and 416 errors here. Don't bother cleaning the pipe anymore. (HttpTransport_urllib._post, HttpTransport_urllib._head): Don't bother cleaning the pipe anymore. * bzrlib/transport/http/_pycurl.py: (PyCurlTransport._get_ranged): Handle 400 and 416 errors here. Also use HTTPMessage to replace the _extract_headers use. (PyCurlTransport._parse_headers): New method. Create an HTTPMessage from the raw headers provided by pycurl. * bzrlib/transport/http/__init__.py: (_extract_headers): Deleted. HTTPMessage is a better alternative. (HttpTransportBase.get): Wrap the result in a StringIO since same callers want an iterable, stop gap to make the tests pass, MUST be fixed. (HttpTransportBase._readv): Also catch InvalidHttpRange. (HttpTransportBase._coalesce_readv): Indicates that only InvalidHttpRange (not InvalidRange) can be raised from there. * bzrlib/transport/__init__.py: (_CoalescedOffset.__repr__): Provided by jam and lost in previous patches. * bzrlib/tests/test_transport_implementations.py: (TransportTests.test_get): Switch from zip() to itertools.imap or the transport requests are all issued before reading the files. This works for sftp since several file-handles can be created on a single ssh connection, for ftp since all get() are StringIO buffered (bang head against desktop) and used to work with http before the http response rewriting. * bzrlib/tests/test_http_response.py: Test the new RangeFile implementation, get rid of now useless tests. All deleted tests have been reviewed to avoid test coverage regression. * bzrlib/tests/HttpServer.py: (TestingHTTPRequestHandler.get_multiple_ranges): Only one boundary line per part should be written. * bzrlib/errors.py: (InvalidRange.__init__): The msg was duplicated. (InvalidHttpRange.__init__): Add an optional 'msg' attribute.	Vincent Ladeuil	17 years ago
3059.2.1	merge fix for bug #172701, work continued on top of it merge fix for bug #172701, work continued on top of it	Vincent Ladeuil	17 years ago
3059	Allow insert_data_stream to insert differently annotated str... Allow insert_data_stream to insert differently annotated stream. (#165304, Robert Collins, Andrew Bennetts)	Canonical.com Patch ...	17 years ago
3058	(merge) windows standalone installer creates and uses plugin... (merge) windows standalone installer creates and uses plugins directory for system-wide plugins (#129298)	Canonical.com Patch ...	17 years ago

Older »