~bzr-pqm/bzr/bzr.dev

6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
1
# Copyright (C) 2005-2014 Canonical Ltd.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
2
#
1 by mbp at sourcefrog
import from baz patch-364
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
7
#
1 by mbp at sourcefrog
import from baz patch-364
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
12
#
1 by mbp at sourcefrog
import from baz patch-364
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1 by mbp at sourcefrog
import from baz patch-364
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
18
2520.4.140 by Aaron Bentley
Use matching blocks from mpdiff for knit delta creation
19
import difflib
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
20
import os
1899.1.5 by John Arbash Meinel
Always buffer the output of diff, so we can check if retcode==2 is because of Binary files
21
import re
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
22
import string
1996.3.9 by John Arbash Meinel
lazy_import diff.py
23
import sys
24
25
from bzrlib.lazy_import import lazy_import
26
lazy_import(globals(), """
27
import errno
1692.8.7 by James Henstridge
changes suggested by John Meinel
28
import subprocess
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
29
import tempfile
1740.2.5 by Aaron Bentley
Merge from bzr.dev
30
1955.2.10 by John Arbash Meinel
Unset a few other LANG type variables when spawning diff
31
from bzrlib import (
6207.3.3 by jelmer at samba
Fix tests and the like.
32
    cleanup,
4913.5.24 by Gordon Tyler
Added cmdline.split function, which replaces commands.shlex_split_unicode.
33
    cmdline,
6207.3.3 by jelmer at samba
Fix tests and the like.
34
    controldir,
1955.2.10 by John Arbash Meinel
Unset a few other LANG type variables when spawning diff
35
    errors,
36
    osutils,
1996.3.9 by John Arbash Meinel
lazy_import diff.py
37
    patiencediff,
38
    textfile,
1551.12.29 by Aaron Bentley
Copy and extend patch date formatting code, add patch-date parsing
39
    timestamp,
3586.1.21 by Ian Clatworthy
enhance diff to support views
40
    views,
1955.2.10 by John Arbash Meinel
Unset a few other LANG type variables when spawning diff
41
    )
4845.2.1 by Gary van der Merwe
When launching an external diff app, don't write temporary files for a working tree.
42
43
from bzrlib.workingtree import WorkingTree
6138.3.4 by Jonathan Riddell
add gettext() to uses of trace.note()
44
from bzrlib.i18n import gettext
1996.3.9 by John Arbash Meinel
lazy_import diff.py
45
""")
46
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
47
from bzrlib.registry import (
48
    Registry,
49
    )
3586.1.21 by Ian Clatworthy
enhance diff to support views
50
from bzrlib.trace import mutter, note, warning
1 by mbp at sourcefrog
import from baz patch-364
51
6524.5.8 by Paul Nixon
Changed "default_context_amount" to be "DEFAULT_CONTEXT_AMOUNT" to be
52
DEFAULT_CONTEXT_AMOUNT = 3
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
53
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
54
class AtTemplate(string.Template):
55
    """Templating class that uses @ instead of $."""
56
57
    delimiter = '@'
58
59
767 by Martin Pool
- files are only reported as modified if their name or parent has changed,
60
# TODO: Rather than building a changeset object, we should probably
61
# invoke callbacks on an object.  That object can either accumulate a
62
# list, write them out directly, etc etc.
63
2520.4.140 by Aaron Bentley
Use matching blocks from mpdiff for knit delta creation
64
65
class _PrematchedMatcher(difflib.SequenceMatcher):
66
    """Allow SequenceMatcher operations to use predetermined blocks"""
67
68
    def __init__(self, matching_blocks):
69
        difflib.SequenceMatcher(self, None, None)
70
        self.matching_blocks = matching_blocks
71
        self.opcodes = None
72
73
1558.15.11 by Aaron Bentley
Apply merge review suggestions
74
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
1711.2.30 by John Arbash Meinel
Fix bug in internal_diff handling of unicode paths
75
                  allow_binary=False, sequence_matcher=None,
6524.5.8 by Paul Nixon
Changed "default_context_amount" to be "DEFAULT_CONTEXT_AMOUNT" to be
76
                  path_encoding='utf8', context_lines=DEFAULT_CONTEXT_AMOUNT):
475 by Martin Pool
- rewrite diff using compare_trees()
77
    # FIXME: difflib is wrong if there is no trailing newline.
78
    # The syntax used by patch seems to be "\ No newline at
79
    # end of file" following the last diff line from that
80
    # file.  This is not trivial to insert into the
81
    # unified_diff output and it might be better to just fix
82
    # or replace that function.
83
84
    # In the meantime we at least make sure the patch isn't
85
    # mangled.
86
87
88
    # Special workaround for Python2.3, where difflib fails if
89
    # both sequences are empty.
90
    if not oldlines and not newlines:
91
        return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
92
1558.15.11 by Aaron Bentley
Apply merge review suggestions
93
    if allow_binary is False:
1996.3.9 by John Arbash Meinel
lazy_import diff.py
94
        textfile.check_text_lines(oldlines)
95
        textfile.check_text_lines(newlines)
475 by Martin Pool
- rewrite diff using compare_trees()
96
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
97
    if sequence_matcher is None:
1996.3.9 by John Arbash Meinel
lazy_import diff.py
98
        sequence_matcher = patiencediff.PatienceSequenceMatcher
99
    ud = patiencediff.unified_diff(oldlines, newlines,
4797.57.4 by Alexander Belchenko
if filename cannot be encoded in current path_encoding (user_encoding) then use foo.encode(path_encoding, 'replace') so we don't traceback
100
                      fromfile=old_filename.encode(path_encoding, 'replace'),
101
                      tofile=new_filename.encode(path_encoding, 'replace'),
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
102
                      n=context_lines, sequencematcher=sequence_matcher)
475 by Martin Pool
- rewrite diff using compare_trees()
103
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
104
    ud = list(ud)
3085.1.1 by John Arbash Meinel
Fix internal_diff to not fail when the texts are identical.
105
    if len(ud) == 0: # Identical contents, nothing to do
106
        return
475 by Martin Pool
- rewrite diff using compare_trees()
107
    # work-around for difflib being too smart for its own good
108
    # if /dev/null is "1,0", patch won't recognize it as /dev/null
109
    if not oldlines:
110
        ud[2] = ud[2].replace('-1,0', '-0,0')
111
    elif not newlines:
112
        ud[2] = ud[2].replace('+1,0', '+0,0')
113
804 by Martin Pool
Patch from John:
114
    for line in ud:
115
        to_file.write(line)
974.1.5 by Aaron Bentley
Fixed handling of missing newlines in udiffs
116
        if not line.endswith('\n'):
117
            to_file.write("\n\\ No newline at end of file\n")
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
118
    to_file.write('\n')
475 by Martin Pool
- rewrite diff using compare_trees()
119
120
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
121
def _spawn_external_diff(diffcmd, capture_errors=True):
6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
122
    """Spawn the external diff process, and return the child handle.
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
123
124
    :param diffcmd: The command list to spawn
2138.1.1 by Wouter van Heyst
Robuster external diff output handling.
125
    :param capture_errors: Capture stderr as well as setting LANG=C
126
        and LC_ALL=C. This lets us read and understand the output of diff,
127
        and respond to any errors.
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
128
    :return: A Popen object.
129
    """
130
    if capture_errors:
2321.2.2 by Alexander Belchenko
win32 fixes for test_external_diff_binary (gettext on win32 rely on $LANGUAGE)
131
        # construct minimal environment
132
        env = {}
133
        path = os.environ.get('PATH')
134
        if path is not None:
135
            env['PATH'] = path
2321.2.5 by Alexander Belchenko
external diff: no need for special code path for win32 (suggested by John Meinel)
136
        env['LANGUAGE'] = 'C'   # on win32 only LANGUAGE has effect
137
        env['LANG'] = 'C'
138
        env['LC_ALL'] = 'C'
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
139
        stderr = subprocess.PIPE
140
    else:
2321.2.2 by Alexander Belchenko
win32 fixes for test_external_diff_binary (gettext on win32 rely on $LANGUAGE)
141
        env = None
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
142
        stderr = None
143
144
    try:
145
        pipe = subprocess.Popen(diffcmd,
146
                                stdin=subprocess.PIPE,
147
                                stdout=subprocess.PIPE,
148
                                stderr=stderr,
2321.2.2 by Alexander Belchenko
win32 fixes for test_external_diff_binary (gettext on win32 rely on $LANGUAGE)
149
                                env=env)
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
150
    except OSError, e:
151
        if e.errno == errno.ENOENT:
152
            raise errors.NoDiff(str(e))
153
        raise
154
155
    return pipe
156
6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
157
# diff style options as of GNU diff v3.2
158
style_option_list = ['-c', '-C', '--context',
159
                     '-e', '--ed',
6597.2.4 by Vincent Ladeuil
Doh, this is *still* supported by diff 3.3 (just not documented in the man page nor the online help anymore).
160
                     '-f', '--forward-ed',
6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
161
                     '-q', '--brief',
162
                     '--normal',
163
                     '-n', '--rcs',
164
                     '-u', '-U', '--unified',
165
                     '-y', '--side-by-side',
166
                     '-D', '--ifdef']
167
168
def default_style_unified(diff_opts):
169
    """Default to unified diff style if alternative not specified in diff_opts.
170
171
        diff only allows one style to be specified; they don't override.
172
        Note that some of these take optargs, and the optargs can be
173
        directly appended to the options.
174
        This is only an approximate parser; it doesn't properly understand
175
        the grammar.
176
177
    :param diff_opts: List of options for external (GNU) diff.
178
    :return: List of options with default style=='unified'.
179
    """
180
    for s in style_option_list:
181
        for j in diff_opts:
182
            if j.startswith(s):
183
                break
184
        else:
185
            continue
186
        break
187
    else:
188
        diff_opts.append('-u')
189
    return diff_opts
190
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
191
1185.35.29 by Aaron Bentley
Support whitespace in diff filenames
192
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
571 by Martin Pool
- new --diff-options to pass options through to external
193
                  diff_opts):
568 by Martin Pool
- start adding support for showing diffs by calling out to
194
    """Display a diff by calling out to the external diff program."""
581 by Martin Pool
- make sure any bzr output is flushed before
195
    # make sure our own output is properly ordered before the diff
196
    to_file.flush()
197
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
198
    oldtmp_fd, old_abspath = tempfile.mkstemp(prefix='bzr-diff-old-')
199
    newtmp_fd, new_abspath = tempfile.mkstemp(prefix='bzr-diff-new-')
200
    oldtmpf = os.fdopen(oldtmp_fd, 'wb')
201
    newtmpf = os.fdopen(newtmp_fd, 'wb')
568 by Martin Pool
- start adding support for showing diffs by calling out to
202
203
    try:
204
        # TODO: perhaps a special case for comparing to or from the empty
205
        # sequence; can just use /dev/null on Unix
206
207
        # TODO: if either of the files being compared already exists as a
208
        # regular named file (e.g. in the working directory) then we can
209
        # compare directly to that, rather than copying it.
210
211
        oldtmpf.writelines(oldlines)
212
        newtmpf.writelines(newlines)
213
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
214
        oldtmpf.close()
215
        newtmpf.close()
568 by Martin Pool
- start adding support for showing diffs by calling out to
216
571 by Martin Pool
- new --diff-options to pass options through to external
217
        if not diff_opts:
218
            diff_opts = []
4422.1.1 by John Arbash Meinel
Possibly fix for bug #382709 handling non-ascii external filenames.
219
        if sys.platform == 'win32':
220
            # Popen doesn't do the proper encoding for external commands
221
            # Since we are dealing with an ANSI api, use mbcs encoding
222
            old_filename = old_filename.encode('mbcs')
4422.1.2 by Martin
Fix copy-and-paste error in previous change
223
            new_filename = new_filename.encode('mbcs')
571 by Martin Pool
- new --diff-options to pass options through to external
224
        diffcmd = ['diff',
1740.2.5 by Aaron Bentley
Merge from bzr.dev
225
                   '--label', old_filename,
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
226
                   old_abspath,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
227
                   '--label', new_filename,
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
228
                   new_abspath,
229
                   '--binary',
230
                  ]
571 by Martin Pool
- new --diff-options to pass options through to external
231
6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
232
        diff_opts = default_style_unified(diff_opts)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
233
571 by Martin Pool
- new --diff-options to pass options through to external
234
        if diff_opts:
235
            diffcmd.extend(diff_opts)
236
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
237
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
238
        out,err = pipe.communicate()
239
        rc = pipe.returncode
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
240
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
241
        # internal_diff() adds a trailing newline, add one here for consistency
242
        out += '\n'
1899.1.5 by John Arbash Meinel
Always buffer the output of diff, so we can check if retcode==2 is because of Binary files
243
        if rc == 2:
244
            # 'diff' gives retcode == 2 for all sorts of errors
245
            # one of those is 'Binary files differ'.
246
            # Bad options could also be the problem.
1904.1.4 by Marien Zwart
Make external diff in binary mode work with recent versions of diffutils.
247
            # 'Binary files' is not a real error, so we suppress that error.
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
248
            lang_c_out = out
249
250
            # Since we got here, we want to make sure to give an i18n error
251
            pipe = _spawn_external_diff(diffcmd, capture_errors=False)
252
            out, err = pipe.communicate()
253
254
            # Write out the new i18n diff response
255
            to_file.write(out+'\n')
256
            if pipe.returncode != 2:
1996.3.9 by John Arbash Meinel
lazy_import diff.py
257
                raise errors.BzrError(
258
                               'external diff failed with exit code 2'
2138.1.1 by Wouter van Heyst
Robuster external diff output handling.
259
                               ' when run with LANG=C and LC_ALL=C,'
260
                               ' but not when run natively: %r' % (diffcmd,))
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
261
262
            first_line = lang_c_out.split('\n', 1)[0]
1904.1.4 by Marien Zwart
Make external diff in binary mode work with recent versions of diffutils.
263
            # Starting with diffutils 2.8.4 the word "binary" was dropped.
264
            m = re.match('^(binary )?files.*differ$', first_line, re.I)
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
265
            if m is None:
1996.3.9 by John Arbash Meinel
lazy_import diff.py
266
                raise errors.BzrError('external diff failed with exit code 2;'
267
                                      ' command: %r' % (diffcmd,))
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
268
            else:
269
                # Binary files differ, just return
270
                return
271
272
        # If we got to here, we haven't written out the output of diff
273
        # do so now
274
        to_file.write(out)
275
        if rc not in (0, 1):
571 by Martin Pool
- new --diff-options to pass options through to external
276
            # returns 1 if files differ; that's OK
277
            if rc < 0:
278
                msg = 'signal %d' % (-rc)
279
            else:
280
                msg = 'exit code %d' % rc
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
281
282
            raise errors.BzrError('external diff failed with %s; command: %r'
6597.2.1 by Richard Wilbur
Split diff format option parser into a separate function, update to include all format options for GNU diff v3.2, and test parser.
283
                                  % (msg, diffcmd))
1899.1.6 by John Arbash Meinel
internal_diff always adds a trailing \n, make sure external_diff does too
284
285
568 by Martin Pool
- start adding support for showing diffs by calling out to
286
    finally:
287
        oldtmpf.close()                 # and delete
288
        newtmpf.close()
6597.2.3 by Vincent Ladeuil
Remove duplication in cleanups. Note that --forward-ed is not in diff 3.3 and may need to be removed from the supported options.
289
290
        def cleanup(path):
291
            # Warn in case the file couldn't be deleted (in case windows still
292
            # holds the file open, but not if the files have already been
293
            # deleted)
294
            try:
295
                os.remove(path)
296
            except OSError, e:
297
                if e.errno not in (errno.ENOENT,):
298
                    warning('Failed to delete temporary file: %s %s', path, e)
299
300
        cleanup(old_abspath)
301
        cleanup(new_abspath)
568 by Martin Pool
- start adding support for showing diffs by calling out to
302
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
303
5147.3.3 by Andrew Bennetts
Add get_trees_and_branches_to_diff_locked, leave get_trees_and_branches_to_diff unchanged for qbzr.
304
def get_trees_and_branches_to_diff_locked(
305
    path_list, revision_specs, old_url, new_url, add_cleanup, apply_view=True):
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
306
    """Get the trees and specific files to diff given a list of paths.
307
308
    This method works out the trees to be diff'ed and the files of
309
    interest within those trees.
310
311
    :param path_list:
312
        the list of arguments passed to the diff command
313
    :param revision_specs:
314
        Zero, one or two RevisionSpecs from the diff command line,
315
        saying what revisions to compare.
316
    :param old_url:
317
        The url of the old branch or tree. If None, the tree to use is
318
        taken from the first path, if any, or the current working tree.
319
    :param new_url:
320
        The url of the new branch or tree. If None, the tree to use is
321
        taken from the first path, if any, or the current working tree.
5147.3.1 by Andrew Bennetts
Avoid 6 branch/repo relocks in cmd_diff.
322
    :param add_cleanup:
323
        a callable like Command.add_cleanup.  get_trees_and_branches_to_diff
324
        will register cleanups that must be run to unlock the trees, etc.
3586.1.21 by Ian Clatworthy
enhance diff to support views
325
    :param apply_view:
326
        if True and a view is set, apply the view or check that the paths
327
        are within it
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
328
    :returns:
4739.3.1 by Jonathan Lange
Fix the docstring for get_trees_and_branches_to_diff.
329
        a tuple of (old_tree, new_tree, old_branch, new_branch,
330
        specific_files, extra_trees) where extra_trees is a sequence of
5147.3.1 by Andrew Bennetts
Avoid 6 branch/repo relocks in cmd_diff.
331
        additional trees to search in for file-ids.  The trees and branches
332
        will be read-locked until the cleanups registered via the add_cleanup
333
        param are run.
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
334
    """
335
    # Get the old and new revision specs
336
    old_revision_spec = None
337
    new_revision_spec = None
338
    if revision_specs is not None:
339
        if len(revision_specs) > 0:
340
            old_revision_spec = revision_specs[0]
3072.1.5 by Ian Clatworthy
more good ideas from abentley
341
            if old_url is None:
342
                old_url = old_revision_spec.get_branch()
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
343
        if len(revision_specs) > 1:
344
            new_revision_spec = revision_specs[1]
3072.1.5 by Ian Clatworthy
more good ideas from abentley
345
            if new_url is None:
346
                new_url = new_revision_spec.get_branch()
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
347
3072.1.5 by Ian Clatworthy
more good ideas from abentley
348
    other_paths = []
349
    make_paths_wt_relative = True
3164.1.1 by Ian Clatworthy
diff without arguments means the current tree, not the current directory
350
    consider_relpath = True
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
351
    if path_list is None or len(path_list) == 0:
3164.1.1 by Ian Clatworthy
diff without arguments means the current tree, not the current directory
352
        # If no path is given, the current working tree is used
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
353
        default_location = u'.'
3164.1.1 by Ian Clatworthy
diff without arguments means the current tree, not the current directory
354
        consider_relpath = False
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
355
    elif old_url is not None and new_url is not None:
356
        other_paths = path_list
3072.1.5 by Ian Clatworthy
more good ideas from abentley
357
        make_paths_wt_relative = False
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
358
    else:
359
        default_location = path_list[0]
360
        other_paths = path_list[1:]
361
5147.3.1 by Andrew Bennetts
Avoid 6 branch/repo relocks in cmd_diff.
362
    def lock_tree_or_branch(wt, br):
363
        if wt is not None:
364
            wt.lock_read()
365
            add_cleanup(wt.unlock)
366
        elif br is not None:
367
            br.lock_read()
368
            add_cleanup(br.unlock)
369
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
370
    # Get the old location
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
371
    specific_files = []
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
372
    if old_url is None:
373
        old_url = default_location
374
    working_tree, branch, relpath = \
6207.3.3 by jelmer at samba
Fix tests and the like.
375
        controldir.ControlDir.open_containing_tree_or_branch(old_url)
5147.3.1 by Andrew Bennetts
Avoid 6 branch/repo relocks in cmd_diff.
376
    lock_tree_or_branch(working_tree, branch)
3164.1.1 by Ian Clatworthy
diff without arguments means the current tree, not the current directory
377
    if consider_relpath and relpath != '':
3586.1.21 by Ian Clatworthy
enhance diff to support views
378
        if working_tree is not None and apply_view:
4032.4.1 by Eduardo Padoan
Moved diff._check_path_in_view() to views.check_path_in_view()
379
            views.check_path_in_view(working_tree, relpath)
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
380
        specific_files.append(relpath)
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
381
    old_tree = _get_tree_to_diff(old_revision_spec, working_tree, branch)
4705.1.1 by Gary van der Merwe
Change _get_trees_to_diff to get_trees_and_branches_to_diff.
382
    old_branch = branch
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
383
384
    # Get the new location
385
    if new_url is None:
386
        new_url = default_location
387
    if new_url != old_url:
388
        working_tree, branch, relpath = \
6207.3.3 by jelmer at samba
Fix tests and the like.
389
            controldir.ControlDir.open_containing_tree_or_branch(new_url)
5147.3.1 by Andrew Bennetts
Avoid 6 branch/repo relocks in cmd_diff.
390
        lock_tree_or_branch(working_tree, branch)
3164.1.1 by Ian Clatworthy
diff without arguments means the current tree, not the current directory
391
        if consider_relpath and relpath != '':
3586.1.21 by Ian Clatworthy
enhance diff to support views
392
            if working_tree is not None and apply_view:
4032.4.1 by Eduardo Padoan
Moved diff._check_path_in_view() to views.check_path_in_view()
393
                views.check_path_in_view(working_tree, relpath)
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
394
            specific_files.append(relpath)
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
395
    new_tree = _get_tree_to_diff(new_revision_spec, working_tree, branch,
396
        basis_is_default=working_tree is None)
4705.1.1 by Gary van der Merwe
Change _get_trees_to_diff to get_trees_and_branches_to_diff.
397
    new_branch = branch
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
398
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
399
    # Get the specific files (all files is None, no files is [])
3072.1.5 by Ian Clatworthy
more good ideas from abentley
400
    if make_paths_wt_relative and working_tree is not None:
5346.4.3 by Martin Pool
PathNotChild should not give a traceback.
401
        other_paths = working_tree.safe_relpath_files(
402
            other_paths,
403
            apply_view=apply_view)
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
404
    specific_files.extend(other_paths)
405
    if len(specific_files) == 0:
406
        specific_files = None
3586.1.21 by Ian Clatworthy
enhance diff to support views
407
        if (working_tree is not None and working_tree.supports_views()
408
            and apply_view):
409
            view_files = working_tree.views.lookup_view()
410
            if view_files:
411
                specific_files = view_files
412
                view_str = views.view_display_str(view_files)
6138.3.4 by Jonathan Riddell
add gettext() to uses of trace.note()
413
                note(gettext("*** Ignoring files outside view. View is %s") % view_str)
3072.1.2 by Ian Clatworthy
Test various --old and --new combinations
414
415
    # Get extra trees that ought to be searched for file-ids
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
416
    extra_trees = None
3072.1.5 by Ian Clatworthy
more good ideas from abentley
417
    if working_tree is not None and working_tree not in (old_tree, new_tree):
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
418
        extra_trees = (working_tree,)
6027.1.4 by Vincent Ladeuil
Remove ``diff.get_trees_and_branches_to_diff`` deprecated in 2.2.0 and the corrsponding tests.
419
    return (old_tree, new_tree, old_branch, new_branch,
420
            specific_files, extra_trees)
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
421
4739.3.1 by Jonathan Lange
Fix the docstring for get_trees_and_branches_to_diff.
422
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
423
def _get_tree_to_diff(spec, tree=None, branch=None, basis_is_default=True):
424
    if branch is None and tree is not None:
425
        branch = tree.branch
426
    if spec is None or spec.spec is None:
427
        if basis_is_default:
3072.1.5 by Ian Clatworthy
more good ideas from abentley
428
            if tree is not None:
429
                return tree.basis_tree()
430
            else:
431
                return branch.basis_tree()
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
432
        else:
433
            return tree
3655.3.1 by Lukáš Lalinský
Fix `bzr st -rbranch:PATH_TO_BRANCH`
434
    return spec.as_tree(branch)
3072.1.1 by Ian Clatworthy
Improved diff based on feedback from abentley
435
436
571 by Martin Pool
- new --diff-options to pass options through to external
437
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
438
                    external_diff_options=None,
1551.7.17 by Aaron Bentley
Switch to PathsNotVersioned, accept extra_trees
439
                    old_label='a/', new_label='b/',
2598.6.12 by ghigo
Move the encoding of the commit message at the command line level
440
                    extra_trees=None,
3123.6.2 by Aaron Bentley
Implement diff --using natively
441
                    path_encoding='utf8',
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
442
                    using=None,
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
443
                    format_cls=None,
6524.5.8 by Paul Nixon
Changed "default_context_amount" to be "DEFAULT_CONTEXT_AMOUNT" to be
444
                    context=DEFAULT_CONTEXT_AMOUNT):
550 by Martin Pool
- Refactor diff code into one that works purely on
445
    """Show in text form the changes from one tree to another.
446
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
447
    :param to_file: The output stream.
5891.1.3 by Andrew Bennetts
Move docstring formatting fixes.
448
    :param specific_files: Include only changes to these files - None for all
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
449
        changes.
450
    :param external_diff_options: If set, use an external GNU diff and pass 
451
        these options.
452
    :param extra_trees: If set, more Trees to use for looking up file ids
453
    :param path_encoding: If set, the path will be encoded as specified, 
454
        otherwise is supposed to be utf8
455
    :param format_cls: Formatter class (DiffTree subclass)
550 by Martin Pool
- Refactor diff code into one that works purely on
456
    """
6524.5.4 by Paul Nixon
Clearing up default context options
457
    if context is None:
6524.5.8 by Paul Nixon
Changed "default_context_amount" to be "DEFAULT_CONTEXT_AMOUNT" to be
458
        context = DEFAULT_CONTEXT_AMOUNT
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
459
    if format_cls is None:
460
        format_cls = DiffTree
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
461
    old_tree.lock_read()
462
    try:
2255.7.38 by John Arbash Meinel
show_diff_trees() should lock any extra trees it is passed.
463
        if extra_trees is not None:
464
            for tree in extra_trees:
465
                tree.lock_read()
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
466
        new_tree.lock_read()
467
        try:
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
468
            differ = format_cls.from_trees_options(old_tree, new_tree, to_file,
469
                                                   path_encoding,
470
                                                   external_diff_options,
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
471
                                                   old_label, new_label, using,
472
                                                   context_lines=context)
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
473
            return differ.show_diff(specific_files, extra_trees)
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
474
        finally:
475
            new_tree.unlock()
2255.7.38 by John Arbash Meinel
show_diff_trees() should lock any extra trees it is passed.
476
            if extra_trees is not None:
477
                for tree in extra_trees:
478
                    tree.unlock()
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
479
    finally:
480
        old_tree.unlock()
481
482
1740.2.5 by Aaron Bentley
Merge from bzr.dev
483
def _patch_header_date(tree, file_id, path):
484
    """Returns a timestamp suitable for use in a patch header."""
4976.1.3 by Jelmer Vernooij
Cope with ghosts in 'bzr diff'
485
    try:
486
        mtime = tree.get_file_mtime(file_id, path)
487
    except errors.FileTimestampUnavailable:
488
        mtime = 0
2405.1.2 by John Arbash Meinel
Fix bug #103870 by passing None instead of a (sometimes wrong) path
489
    return timestamp.format_patch_date(mtime)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
490
491
3268.1.1 by C Miller
Describe the property changes in diffs. Currently, this is the executable-bit
492
def get_executable_change(old_is_x, new_is_x):
493
    descr = { True:"+x", False:"-x", None:"??" }
494
    if old_is_x != new_is_x:
495
        return ["%s to %s" % (descr[old_is_x], descr[new_is_x],)]
496
    else:
497
        return []
498
1398 by Robert Collins
integrate in Gustavos x-bit patch
499
3009.2.22 by Aaron Bentley
Update names & docstring
500
class DiffPath(object):
3009.2.14 by Aaron Bentley
Update return type handling
501
    """Base type for command object that compare files"""
3009.2.17 by Aaron Bentley
Update docs
502
3009.2.14 by Aaron Bentley
Update return type handling
503
    # The type or contents of the file were unsuitable for diffing
3009.2.29 by Aaron Bentley
Change constants to strings
504
    CANNOT_DIFF = 'CANNOT_DIFF'
3009.2.14 by Aaron Bentley
Update return type handling
505
    # The file has changed in a semantic way
3009.2.29 by Aaron Bentley
Change constants to strings
506
    CHANGED = 'CHANGED'
507
    # The file content may have changed, but there is no semantic change
508
    UNCHANGED = 'UNCHANGED'
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
509
3009.2.13 by Aaron Bentley
Refactor differ to support registering differ factories
510
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8'):
3009.2.17 by Aaron Bentley
Update docs
511
        """Constructor.
512
513
        :param old_tree: The tree to show as the old tree in the comparison
514
        :param new_tree: The tree to show as new in the comparison
515
        :param to_file: The file to write comparison data to
516
        :param path_encoding: The character encoding to write paths in
517
        """
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
518
        self.old_tree = old_tree
519
        self.new_tree = new_tree
520
        self.to_file = to_file
3009.2.13 by Aaron Bentley
Refactor differ to support registering differ factories
521
        self.path_encoding = path_encoding
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
522
3123.6.2 by Aaron Bentley
Implement diff --using natively
523
    def finish(self):
524
        pass
525
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
526
    @classmethod
527
    def from_diff_tree(klass, diff_tree):
528
        return klass(diff_tree.old_tree, diff_tree.new_tree,
529
                     diff_tree.to_file, diff_tree.path_encoding)
530
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
531
    @staticmethod
532
    def _diff_many(differs, file_id, old_path, new_path, old_kind, new_kind):
533
        for file_differ in differs:
534
            result = file_differ.diff(file_id, old_path, new_path, old_kind,
535
                                      new_kind)
3009.2.22 by Aaron Bentley
Update names & docstring
536
            if result is not DiffPath.CANNOT_DIFF:
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
537
                return result
538
        else:
3009.2.22 by Aaron Bentley
Update names & docstring
539
            return DiffPath.CANNOT_DIFF
540
541
542
class DiffKindChange(object):
3009.2.17 by Aaron Bentley
Update docs
543
    """Special differ for file kind changes.
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
544
3009.2.17 by Aaron Bentley
Update docs
545
    Represents kind change as deletion + creation.  Uses the other differs
546
    to do this.
547
    """
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
548
    def __init__(self, differs):
549
        self.differs = differs
550
3123.6.2 by Aaron Bentley
Implement diff --using natively
551
    def finish(self):
552
        pass
553
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
554
    @classmethod
555
    def from_diff_tree(klass, diff_tree):
556
        return klass(diff_tree.differs)
557
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
558
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
3009.2.17 by Aaron Bentley
Update docs
559
        """Perform comparison
560
561
        :param file_id: The file_id of the file to compare
562
        :param old_path: Path of the file in the old tree
563
        :param new_path: Path of the file in the new tree
564
        :param old_kind: Old file-kind of the file
565
        :param new_kind: New file-kind of the file
566
        """
3009.2.18 by Aaron Bentley
Change KindChangeDiffer's anti-recursion to avoid kind pairs with None
567
        if None in (old_kind, new_kind):
3009.2.22 by Aaron Bentley
Update names & docstring
568
            return DiffPath.CANNOT_DIFF
569
        result = DiffPath._diff_many(self.differs, file_id, old_path,
3009.2.18 by Aaron Bentley
Change KindChangeDiffer's anti-recursion to avoid kind pairs with None
570
                                       new_path, old_kind, None)
3009.2.22 by Aaron Bentley
Update names & docstring
571
        if result is DiffPath.CANNOT_DIFF:
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
572
            return result
3009.2.22 by Aaron Bentley
Update names & docstring
573
        return DiffPath._diff_many(self.differs, file_id, old_path, new_path,
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
574
                                     None, new_kind)
575
576
3009.2.22 by Aaron Bentley
Update names & docstring
577
class DiffDirectory(DiffPath):
3009.2.19 by Aaron Bentley
Implement directory diffing
578
579
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
580
        """Perform comparison between two directories.  (dummy)
581
582
        """
583
        if 'directory' not in (old_kind, new_kind):
584
            return self.CANNOT_DIFF
585
        if old_kind not in ('directory', None):
586
            return self.CANNOT_DIFF
587
        if new_kind not in ('directory', None):
588
            return self.CANNOT_DIFF
589
        return self.CHANGED
590
3009.2.20 by Aaron Bentley
PEP8
591
3009.2.22 by Aaron Bentley
Update names & docstring
592
class DiffSymlink(DiffPath):
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
593
594
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
3009.2.17 by Aaron Bentley
Update docs
595
        """Perform comparison between two symlinks
596
597
        :param file_id: The file_id of the file to compare
598
        :param old_path: Path of the file in the old tree
599
        :param new_path: Path of the file in the new tree
600
        :param old_kind: Old file-kind of the file
601
        :param new_kind: New file-kind of the file
602
        """
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
603
        if 'symlink' not in (old_kind, new_kind):
3009.2.14 by Aaron Bentley
Update return type handling
604
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
605
        if old_kind == 'symlink':
606
            old_target = self.old_tree.get_symlink_target(file_id)
607
        elif old_kind is None:
608
            old_target = None
609
        else:
3009.2.14 by Aaron Bentley
Update return type handling
610
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
611
        if new_kind == 'symlink':
612
            new_target = self.new_tree.get_symlink_target(file_id)
613
        elif new_kind is None:
614
            new_target = None
615
        else:
3009.2.14 by Aaron Bentley
Update return type handling
616
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
617
        return self.diff_symlink(old_target, new_target)
618
619
    def diff_symlink(self, old_target, new_target):
620
        if old_target is None:
621
            self.to_file.write('=== target is %r\n' % new_target)
622
        elif new_target is None:
623
            self.to_file.write('=== target was %r\n' % old_target)
624
        else:
625
            self.to_file.write('=== target changed %r => %r\n' %
626
                              (old_target, new_target))
3009.2.14 by Aaron Bentley
Update return type handling
627
        return self.CHANGED
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
628
629
3009.2.22 by Aaron Bentley
Update names & docstring
630
class DiffText(DiffPath):
3009.2.2 by Aaron Bentley
Implement Differ object for abstracting diffing
631
3009.2.7 by Aaron Bentley
Move responsibility for generating diff labels into Differ.diff
632
    # GNU Patch uses the epoch date to detect files that are being added
633
    # or removed in a diff.
634
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
635
6524.5.5 by Paul Nixon
Added tests of configurable context
636
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8', 
637
                 old_label='', new_label='', text_differ=internal_diff, 
6524.5.8 by Paul Nixon
Changed "default_context_amount" to be "DEFAULT_CONTEXT_AMOUNT" to be
638
                 context_lines=DEFAULT_CONTEXT_AMOUNT):
3009.2.22 by Aaron Bentley
Update names & docstring
639
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
640
        self.text_differ = text_differ
641
        self.old_label = old_label
642
        self.new_label = new_label
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
643
        self.path_encoding = path_encoding
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
644
        self.context_lines = context_lines
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
645
646
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
3009.2.17 by Aaron Bentley
Update docs
647
        """Compare two files in unified diff format
648
649
        :param file_id: The file_id of the file to compare
650
        :param old_path: Path of the file in the old tree
651
        :param new_path: Path of the file in the new tree
652
        :param old_kind: Old file-kind of the file
653
        :param new_kind: New file-kind of the file
654
        """
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
655
        if 'file' not in (old_kind, new_kind):
3009.2.14 by Aaron Bentley
Update return type handling
656
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
657
        from_file_id = to_file_id = file_id
658
        if old_kind == 'file':
659
            old_date = _patch_header_date(self.old_tree, file_id, old_path)
660
        elif old_kind is None:
661
            old_date = self.EPOCH_DATE
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
662
            from_file_id = None
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
663
        else:
3009.2.14 by Aaron Bentley
Update return type handling
664
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
665
        if new_kind == 'file':
666
            new_date = _patch_header_date(self.new_tree, file_id, new_path)
667
        elif new_kind is None:
668
            new_date = self.EPOCH_DATE
669
            to_file_id = None
670
        else:
3009.2.14 by Aaron Bentley
Update return type handling
671
            return self.CANNOT_DIFF
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
672
        from_label = '%s%s\t%s' % (self.old_label, old_path, old_date)
673
        to_label = '%s%s\t%s' % (self.new_label, new_path, new_date)
4377.3.3 by Ian Clatworthy
avoid unnecessary id2path calculation when diffing
674
        return self.diff_text(from_file_id, to_file_id, from_label, to_label,
675
            old_path, new_path)
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
676
4377.3.3 by Ian Clatworthy
avoid unnecessary id2path calculation when diffing
677
    def diff_text(self, from_file_id, to_file_id, from_label, to_label,
678
        from_path=None, to_path=None):
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
679
        """Diff the content of given files in two trees
680
681
        :param from_file_id: The id of the file in the from tree.  If None,
682
            the file is not present in the from tree.
683
        :param to_file_id: The id of the file in the to tree.  This may refer
684
            to a different file from from_file_id.  If None,
685
            the file is not present in the to tree.
4377.3.3 by Ian Clatworthy
avoid unnecessary id2path calculation when diffing
686
        :param from_path: The path in the from tree or None if unknown.
687
        :param to_path: The path in the to tree or None if unknown.
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
688
        """
4377.3.3 by Ian Clatworthy
avoid unnecessary id2path calculation when diffing
689
        def _get_text(tree, file_id, path):
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
690
            if file_id is not None:
4708.2.2 by Martin
Workingtree changes sitting around since November, more explict closing of files in bzrlib
691
                return tree.get_file_lines(file_id, path)
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
692
            else:
693
                return []
694
        try:
4377.3.3 by Ian Clatworthy
avoid unnecessary id2path calculation when diffing
695
            from_text = _get_text(self.old_tree, from_file_id, from_path)
696
            to_text = _get_text(self.new_tree, to_file_id, to_path)
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
697
            self.text_differ(from_label, from_text, to_label, to_text,
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
698
                             self.to_file, path_encoding=self.path_encoding,
699
                             context_lines=self.context_lines)
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
700
        except errors.BinaryFile:
701
            self.to_file.write(
702
                  ("Binary files %s and %s differ\n" %
4797.57.4 by Alexander Belchenko
if filename cannot be encoded in current path_encoding (user_encoding) then use foo.encode(path_encoding, 'replace') so we don't traceback
703
                  (from_label, to_label)).encode(self.path_encoding,'replace'))
3009.2.14 by Aaron Bentley
Update return type handling
704
        return self.CHANGED
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
705
706
3123.6.2 by Aaron Bentley
Implement diff --using natively
707
class DiffFromTool(DiffPath):
708
709
    def __init__(self, command_template, old_tree, new_tree, to_file,
710
                 path_encoding='utf-8'):
711
        DiffPath.__init__(self, old_tree, new_tree, to_file, path_encoding)
712
        self.command_template = command_template
3638.3.2 by Vincent Ladeuil
Fix all calls to tempfile.mkdtemp to osutils.mkdtemp.
713
        self._root = osutils.mkdtemp(prefix='bzr-diff-')
3123.6.2 by Aaron Bentley
Implement diff --using natively
714
715
    @classmethod
716
    def from_string(klass, command_string, old_tree, new_tree, to_file,
717
                    path_encoding='utf-8'):
4913.5.24 by Gordon Tyler
Added cmdline.split function, which replaces commands.shlex_split_unicode.
718
        command_template = cmdline.split(command_string)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
719
        if '@' not in command_string:
720
            command_template.extend(['@old_path', '@new_path'])
3123.6.2 by Aaron Bentley
Implement diff --using natively
721
        return klass(command_template, old_tree, new_tree, to_file,
722
                     path_encoding)
723
724
    @classmethod
5349.1.4 by Matthäus G. Chajdas
Allow both --using and --diff-options.
725
    def make_from_diff_tree(klass, command_string, external_diff_options=None):
3123.6.2 by Aaron Bentley
Implement diff --using natively
726
        def from_diff_tree(diff_tree):
5349.1.4 by Matthäus G. Chajdas
Allow both --using and --diff-options.
727
            full_command_string = [command_string]
728
            if external_diff_options is not None:
729
                full_command_string += ' ' + external_diff_options
730
            return klass.from_string(full_command_string, diff_tree.old_tree,
3123.6.2 by Aaron Bentley
Implement diff --using natively
731
                                     diff_tree.new_tree, diff_tree.to_file)
732
        return from_diff_tree
733
734
    def _get_command(self, old_path, new_path):
735
        my_map = {'old_path': old_path, 'new_path': new_path}
5074.5.1 by INADA Naoki
merge #523746 fix from lp:~songofacandy/bzr/fix-523746-2
736
        command = [AtTemplate(t).substitute(my_map) for t in
737
                   self.command_template]
4634.171.2 by INADA Naoki
Make temporary filename more friendly for non ascii filename.
738
        if sys.platform == 'win32': # Popen doesn't accept unicode on win32
739
            command_encoded = []
740
            for c in command:
741
                if isinstance(c, unicode):
742
                    command_encoded.append(c.encode('mbcs'))
743
                else:
744
                    command_encoded.append(c)
745
            return command_encoded
746
        else:
747
            return command
3123.6.2 by Aaron Bentley
Implement diff --using natively
748
749
    def _execute(self, old_path, new_path):
3145.1.1 by Aaron Bentley
Handle missing tools gracefully in diff --using
750
        command = self._get_command(old_path, new_path)
751
        try:
752
            proc = subprocess.Popen(command, stdout=subprocess.PIPE,
753
                                    cwd=self._root)
754
        except OSError, e:
755
            if e.errno == errno.ENOENT:
756
                raise errors.ExecutableMissing(command[0])
3145.1.2 by Aaron Bentley
Don't swallow other OSErrors
757
            else:
758
                raise
3123.6.2 by Aaron Bentley
Implement diff --using natively
759
        self.to_file.write(proc.stdout.read())
760
        return proc.wait()
761
3123.6.5 by Aaron Bentley
Symlink to real files if possible
762
    def _try_symlink_root(self, tree, prefix):
3287.18.3 by Matt McClure
Toward a more acceptable patch for bug 209281.
763
        if (getattr(tree, 'abspath', None) is None
3287.18.14 by Matt McClure
Extracted a host_os_dereferences_symlinks method.
764
            or not osutils.host_os_dereferences_symlinks()):
3123.6.5 by Aaron Bentley
Symlink to real files if possible
765
            return False
766
        try:
767
            os.symlink(tree.abspath(''), osutils.pathjoin(self._root, prefix))
768
        except OSError, e:
769
            if e.errno != errno.EEXIST:
770
                raise
771
        return True
772
5074.5.8 by INADA Naoki
Use tempfile when filepath in tree is not be able to encode with fsencoding.
773
    @staticmethod
774
    def _fenc():
5074.5.9 by INADA Naoki
Make additional comments to clarify
775
        """Returns safe encoding for passing file path to diff tool"""
5074.5.8 by INADA Naoki
Use tempfile when filepath in tree is not be able to encode with fsencoding.
776
        if sys.platform == 'win32':
777
            return 'mbcs'
778
        else:
779
            # Don't fallback to 'utf-8' because subprocess may not be able to
780
            # handle utf-8 correctly when locale is not utf-8.
781
            return sys.getfilesystemencoding() or 'ascii'
782
783
    def _is_safepath(self, path):
784
        """Return true if `path` may be able to pass to subprocess."""
785
        fenc = self._fenc()
786
        try:
787
            return path == path.encode(fenc).decode(fenc)
788
        except UnicodeError:
789
            return False
790
5074.5.7 by INADA Naoki
Test for filename encoding can't test subprocess execution because
791
    def _safe_filename(self, prefix, relpath):
5074.5.8 by INADA Naoki
Use tempfile when filepath in tree is not be able to encode with fsencoding.
792
        """Replace unsafe character in `relpath` then join `self._root`,
793
        `prefix` and `relpath`."""
794
        fenc = self._fenc()
4634.171.4 by INADA Naoki
Append comment for why decode() needed before replace().
795
        # encoded_str.replace('?', '_') may break multibyte char.
796
        # So we should encode, decode, then replace(u'?', u'_')
4634.171.2 by INADA Naoki
Make temporary filename more friendly for non ascii filename.
797
        relpath_tmp = relpath.encode(fenc, 'replace').decode(fenc, 'replace')
4634.171.3 by INADA Naoki
Fix easy miss.
798
        relpath_tmp = relpath_tmp.replace(u'?', u'_')
5074.5.7 by INADA Naoki
Test for filename encoding can't test subprocess execution because
799
        return osutils.pathjoin(self._root, prefix, relpath_tmp)
800
801
    def _write_file(self, file_id, tree, prefix, relpath, force_temp=False,
802
                    allow_write=False):
803
        if not force_temp and isinstance(tree, WorkingTree):
5074.5.8 by INADA Naoki
Use tempfile when filepath in tree is not be able to encode with fsencoding.
804
            full_path = tree.abspath(tree.id2path(file_id))
805
            if self._is_safepath(full_path):
806
                return full_path
5074.5.7 by INADA Naoki
Test for filename encoding can't test subprocess execution because
807
808
        full_path = self._safe_filename(prefix, relpath)
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
809
        if not force_temp and self._try_symlink_root(tree, prefix):
3123.6.5 by Aaron Bentley
Symlink to real files if possible
810
            return full_path
3123.6.4 by Aaron Bentley
Set mtime (and atime) on files for --using
811
        parent_dir = osutils.dirname(full_path)
3123.6.2 by Aaron Bentley
Implement diff --using natively
812
        try:
813
            os.makedirs(parent_dir)
814
        except OSError, e:
815
            if e.errno != errno.EEXIST:
816
                raise
3123.6.6 by Aaron Bentley
Use relpath for get_file
817
        source = tree.get_file(file_id, relpath)
3123.6.2 by Aaron Bentley
Implement diff --using natively
818
        try:
3123.6.4 by Aaron Bentley
Set mtime (and atime) on files for --using
819
            target = open(full_path, 'wb')
3123.6.2 by Aaron Bentley
Implement diff --using natively
820
            try:
821
                osutils.pumpfile(source, target)
822
            finally:
823
                target.close()
824
        finally:
825
            source.close()
4976.1.3 by Jelmer Vernooij
Cope with ghosts in 'bzr diff'
826
        try:
827
            mtime = tree.get_file_mtime(file_id)
828
        except errors.FileTimestampUnavailable:
5151.3.2 by Martin
Don't try and warp files back to the 70s if no timestamp is available
829
            pass
830
        else:
831
            os.utime(full_path, (mtime, mtime))
5151.3.1 by Martin
Fix os.utime test failures, three on FAT filesystems and one with readonly files
832
        if not allow_write:
833
            osutils.make_readonly(full_path)
3123.6.4 by Aaron Bentley
Set mtime (and atime) on files for --using
834
        return full_path
3123.6.2 by Aaron Bentley
Implement diff --using natively
835
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
836
    def _prepare_files(self, file_id, old_path, new_path, force_temp=False,
837
                       allow_write_new=False):
3123.6.2 by Aaron Bentley
Implement diff --using natively
838
        old_disk_path = self._write_file(file_id, self.old_tree, 'old',
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
839
                                         old_path, force_temp)
3123.6.2 by Aaron Bentley
Implement diff --using natively
840
        new_disk_path = self._write_file(file_id, self.new_tree, 'new',
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
841
                                         new_path, force_temp,
842
                                         allow_write=allow_write_new)
3123.6.2 by Aaron Bentley
Implement diff --using natively
843
        return old_disk_path, new_disk_path
844
845
    def finish(self):
4354.6.1 by Martitza Mendez
Fix 363837 : catch OSError from osutils.rmtree and mutter to trace file.
846
        try:
847
            osutils.rmtree(self._root)
848
        except OSError, e:
849
            if e.errno != errno.ENOENT:
4399.1.1 by Ian Clatworthy
(igc) address temp file issue with diff --using on Windows (Martitza Mendez)
850
                mutter("The temporary directory \"%s\" was not "
851
                        "cleanly removed: %s." % (self._root, e))
3123.6.2 by Aaron Bentley
Implement diff --using natively
852
853
    def diff(self, file_id, old_path, new_path, old_kind, new_kind):
854
        if (old_kind, new_kind) != ('file', 'file'):
855
            return DiffPath.CANNOT_DIFF
4845.2.1 by Gary van der Merwe
When launching an external diff app, don't write temporary files for a working tree.
856
        (old_disk_path, new_disk_path) = self._prepare_files(
857
                                                file_id, old_path, new_path)
858
        self._execute(old_disk_path, new_disk_path)
4603.1.1 by Aaron Bentley
Initial pass at shelve-via-editor.
859
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
860
    def edit_file(self, file_id):
861
        """Use this tool to edit a file.
862
863
        A temporary copy will be edited, and the new contents will be
864
        returned.
865
866
        :param file_id: The id of the file to edit.
867
        :return: The new contents of the file.
868
        """
869
        old_path = self.old_tree.id2path(file_id)
870
        new_path = self.new_tree.id2path(file_id)
5074.5.1 by INADA Naoki
merge #523746 fix from lp:~songofacandy/bzr/fix-523746-2
871
        old_abs_path, new_abs_path = self._prepare_files(
872
                                            file_id, old_path, new_path,
873
                                            allow_write_new=True,
874
                                            force_temp=True)
875
        command = self._get_command(old_abs_path, new_abs_path)
4603.1.24 by Aaron Bentley
Fix call import/invocation.
876
        subprocess.call(command, cwd=self._root)
5074.5.1 by INADA Naoki
merge #523746 fix from lp:~songofacandy/bzr/fix-523746-2
877
        new_file = open(new_abs_path, 'rb')
4603.1.4 by Aaron Bentley
Implement DiffFromTool.edit_file
878
        try:
879
            return new_file.read()
880
        finally:
881
            new_file.close()
882
3123.6.2 by Aaron Bentley
Implement diff --using natively
883
3009.2.22 by Aaron Bentley
Update names & docstring
884
class DiffTree(object):
885
    """Provides textual representations of the difference between two trees.
886
887
    A DiffTree examines two trees and where a file-id has altered
888
    between them, generates a textual representation of the difference.
889
    DiffTree uses a sequence of DiffPath objects which are each
890
    given the opportunity to handle a given altered fileid. The list
891
    of DiffPath objects can be extended globally by appending to
892
    DiffTree.diff_factories, or for a specific diff operation by
3009.2.27 by Aaron Bentley
Use extra_factories instead of extra_diffs
893
    supplying the extra_factories option to the appropriate method.
3009.2.22 by Aaron Bentley
Update names & docstring
894
    """
895
896
    # list of factories that can provide instances of DiffPath objects
3009.2.17 by Aaron Bentley
Update docs
897
    # may be extended by plugins.
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
898
    diff_factories = [DiffSymlink.from_diff_tree,
899
                      DiffDirectory.from_diff_tree]
3009.2.13 by Aaron Bentley
Refactor differ to support registering differ factories
900
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
901
    def __init__(self, old_tree, new_tree, to_file, path_encoding='utf-8',
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
902
                 diff_text=None, extra_factories=None):
3009.2.17 by Aaron Bentley
Update docs
903
        """Constructor
904
905
        :param old_tree: Tree to show as old in the comparison
906
        :param new_tree: Tree to show as new in the comparison
907
        :param to_file: File to write comparision to
908
        :param path_encoding: Character encoding to write paths in
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
909
        :param diff_text: DiffPath-type object to use as a last resort for
3009.2.17 by Aaron Bentley
Update docs
910
            diffing text files.
3009.2.27 by Aaron Bentley
Use extra_factories instead of extra_diffs
911
        :param extra_factories: Factories of DiffPaths to try before any other
912
            DiffPaths"""
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
913
        if diff_text is None:
914
            diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
915
                                 '', '',  internal_diff)
3009.2.4 by Aaron Bentley
Make old_tree/new_tree construction parameters of Differ
916
        self.old_tree = old_tree
917
        self.new_tree = new_tree
3009.2.2 by Aaron Bentley
Implement Differ object for abstracting diffing
918
        self.to_file = to_file
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
919
        self.path_encoding = path_encoding
3009.2.13 by Aaron Bentley
Refactor differ to support registering differ factories
920
        self.differs = []
3009.2.27 by Aaron Bentley
Use extra_factories instead of extra_diffs
921
        if extra_factories is not None:
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
922
            self.differs.extend(f(self) for f in extra_factories)
923
        self.differs.extend(f(self) for f in self.diff_factories)
924
        self.differs.extend([diff_text, DiffKindChange.from_diff_tree(self)])
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
925
926
    @classmethod
927
    def from_trees_options(klass, old_tree, new_tree, to_file,
3009.2.17 by Aaron Bentley
Update docs
928
                           path_encoding, external_diff_options, old_label,
6524.5.4 by Paul Nixon
Clearing up default context options
929
                           new_label, using, context_lines):
3009.2.22 by Aaron Bentley
Update names & docstring
930
        """Factory for producing a DiffTree.
3009.2.17 by Aaron Bentley
Update docs
931
932
        Designed to accept options used by show_diff_trees.
5891.1.3 by Andrew Bennetts
Move docstring formatting fixes.
933
3009.2.17 by Aaron Bentley
Update docs
934
        :param old_tree: The tree to show as old in the comparison
935
        :param new_tree: The tree to show as new in the comparison
936
        :param to_file: File to write comparisons to
937
        :param path_encoding: Character encoding to use for writing paths
938
        :param external_diff_options: If supplied, use the installed diff
939
            binary to perform file comparison, using supplied options.
940
        :param old_label: Prefix to use for old file labels
941
        :param new_label: Prefix to use for new file labels
3123.6.2 by Aaron Bentley
Implement diff --using natively
942
        :param using: Commandline to use to invoke an external diff tool
3009.2.17 by Aaron Bentley
Update docs
943
        """
3123.6.2 by Aaron Bentley
Implement diff --using natively
944
        if using is not None:
5349.1.4 by Matthäus G. Chajdas
Allow both --using and --diff-options.
945
            extra_factories = [DiffFromTool.make_from_diff_tree(using, external_diff_options)]
3123.6.2 by Aaron Bentley
Implement diff --using natively
946
        else:
947
            extra_factories = []
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
948
        if external_diff_options:
949
            opts = external_diff_options.split()
6524.5.5 by Paul Nixon
Added tests of configurable context
950
            def diff_file(olab, olines, nlab, nlines, to_file, path_encoding=None, context_lines=None):
4797.57.2 by Alexander Belchenko
fixing test with external_diff
951
                """:param path_encoding: not used but required
952
                        to match the signature of internal_diff.
953
                """
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
954
                external_diff(olab, olines, nlab, nlines, to_file, opts)
955
        else:
956
            diff_file = internal_diff
3009.2.28 by Aaron Bentley
Add from_diff_tree factories
957
        diff_text = DiffText(old_tree, new_tree, to_file, path_encoding,
6524.5.1 by pauljnixon at gmail
Made diffs more configurable
958
                             old_label, new_label, diff_file, context_lines=context_lines)
3123.6.2 by Aaron Bentley
Implement diff --using natively
959
        return klass(old_tree, new_tree, to_file, path_encoding, diff_text,
960
                     extra_factories)
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
961
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
962
    def show_diff(self, specific_files, extra_trees=None):
3009.2.17 by Aaron Bentley
Update docs
963
        """Write tree diff to self.to_file
964
5131.1.4 by Jelmer Vernooij
Add test for custom diff format.
965
        :param specific_files: the specific files to compare (recursive)
3009.2.17 by Aaron Bentley
Update docs
966
        :param extra_trees: extra trees to use for mapping paths to file_ids
967
        """
3123.6.2 by Aaron Bentley
Implement diff --using natively
968
        try:
969
            return self._show_diff(specific_files, extra_trees)
970
        finally:
971
            for differ in self.differs:
972
                differ.finish()
973
974
    def _show_diff(self, specific_files, extra_trees):
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
975
        # TODO: Generation of pseudo-diffs for added/deleted files could
976
        # be usefully made into a much faster special case.
3254.1.1 by Aaron Bentley
Make Tree.iter_changes a public method
977
        iterator = self.new_tree.iter_changes(self.old_tree,
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
978
                                               specific_files=specific_files,
979
                                               extra_trees=extra_trees,
980
                                               require_versioned=True)
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
981
        has_changes = 0
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
982
        def changes_key(change):
983
            old_path, new_path = change[1]
984
            path = new_path
985
            if path is None:
986
                path = old_path
987
            return path
988
        def get_encoded_path(path):
989
            if path is not None:
990
                return path.encode(self.path_encoding, "replace")
991
        for (file_id, paths, changed_content, versioned, parent, name, kind,
992
             executable) in sorted(iterator, key=changes_key):
3619.4.2 by Robert Collins
Change bzrlib.diff.DiffTree.show_diff to skip entries missing in both trees.
993
            # The root does not get diffed, and items with no known kind (that
994
            # is, missing) in both trees are skipped as well.
995
            if parent == (None, None) or kind == (None, None):
3123.4.3 by Aaron Bentley
Tweak path handling
996
                continue
997
            oldpath, newpath = paths
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
998
            oldpath_encoded = get_encoded_path(paths[0])
999
            newpath_encoded = get_encoded_path(paths[1])
1000
            old_present = (kind[0] is not None and versioned[0])
1001
            new_present = (kind[1] is not None and versioned[1])
1002
            renamed = (parent[0], name[0]) != (parent[1], name[1])
3268.1.1 by C Miller
Describe the property changes in diffs. Currently, this is the executable-bit
1003
1004
            properties_changed = []
1005
            properties_changed.extend(get_executable_change(executable[0], executable[1]))
1006
1007
            if properties_changed:
1008
                prop_str = " (properties changed: %s)" % (", ".join(properties_changed),)
1009
            else:
1010
                prop_str = ""
1011
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
1012
            if (old_present, new_present) == (True, False):
1013
                self.to_file.write("=== removed %s '%s'\n" %
1014
                                   (kind[0], oldpath_encoded))
3123.4.3 by Aaron Bentley
Tweak path handling
1015
                newpath = oldpath
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
1016
            elif (old_present, new_present) == (False, True):
1017
                self.to_file.write("=== added %s '%s'\n" %
1018
                                   (kind[1], newpath_encoded))
3123.4.3 by Aaron Bentley
Tweak path handling
1019
                oldpath = newpath
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
1020
            elif renamed:
1021
                self.to_file.write("=== renamed %s '%s' => '%s'%s\n" %
1022
                    (kind[0], oldpath_encoded, newpath_encoded, prop_str))
3123.4.2 by Aaron Bentley
Handle diff with property change correctly
1023
            else:
3254.1.1 by Aaron Bentley
Make Tree.iter_changes a public method
1024
                # if it was produced by iter_changes, it must be
3123.4.2 by Aaron Bentley
Handle diff with property change correctly
1025
                # modified *somehow*, either content or execute bit.
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
1026
                self.to_file.write("=== modified %s '%s'%s\n" % (kind[0],
1027
                                   newpath_encoded, prop_str))
1028
            if changed_content:
4377.3.1 by Ian Clatworthy
faster diff on large trees
1029
                self._diff(file_id, oldpath, newpath, kind[0], kind[1])
3123.4.1 by Aaron Bentley
Diff sorts files in alphabetical order
1030
                has_changes = 1
1031
            if renamed:
1032
                has_changes = 1
3009.2.6 by Aaron Bentley
Convert show_diff_trees into a Differ method
1033
        return has_changes
3009.2.2 by Aaron Bentley
Implement Differ object for abstracting diffing
1034
3009.2.12 by Aaron Bentley
Associate labels with text diffing only
1035
    def diff(self, file_id, old_path, new_path):
3009.2.17 by Aaron Bentley
Update docs
1036
        """Perform a diff of a single file
1037
1038
        :param file_id: file-id of the file
1039
        :param old_path: The path of the file in the old tree
1040
        :param new_path: The path of the file in the new tree
1041
        """
3009.2.2 by Aaron Bentley
Implement Differ object for abstracting diffing
1042
        try:
3009.2.8 by Aaron Bentley
Support diffing without indirecting through inventory entries
1043
            old_kind = self.old_tree.kind(file_id)
3087.1.1 by Aaron Bentley
Diff handles missing files correctly, with no tracebacks
1044
        except (errors.NoSuchId, errors.NoSuchFile):
3009.2.8 by Aaron Bentley
Support diffing without indirecting through inventory entries
1045
            old_kind = None
3009.2.3 by Aaron Bentley
Detect missing files from inv operation
1046
        try:
3009.2.8 by Aaron Bentley
Support diffing without indirecting through inventory entries
1047
            new_kind = self.new_tree.kind(file_id)
3087.1.1 by Aaron Bentley
Diff handles missing files correctly, with no tracebacks
1048
        except (errors.NoSuchId, errors.NoSuchFile):
3009.2.8 by Aaron Bentley
Support diffing without indirecting through inventory entries
1049
            new_kind = None
4377.3.1 by Ian Clatworthy
faster diff on large trees
1050
        self._diff(file_id, old_path, new_path, old_kind, new_kind)
1051
1052
1053
    def _diff(self, file_id, old_path, new_path, old_kind, new_kind):
3009.2.22 by Aaron Bentley
Update names & docstring
1054
        result = DiffPath._diff_many(self.differs, file_id, old_path,
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
1055
                                       new_path, old_kind, new_kind)
3009.2.22 by Aaron Bentley
Update names & docstring
1056
        if result is DiffPath.CANNOT_DIFF:
3009.2.11 by Aaron Bentley
Refactor diff to be more pluggable
1057
            error_path = new_path
1058
            if error_path is None:
1059
                error_path = old_path
3009.2.22 by Aaron Bentley
Update names & docstring
1060
            raise errors.NoDiffFound(error_path)
5131.1.1 by Jelmer Vernooij
Add --format option to 'bzr diff'.
1061
1062
1063
format_registry = Registry()
1064
format_registry.register('default', DiffTree)