325
by Martin Pool
- more revfile design notes |
1 |
.. -*- mode: indented-text; compile-command: "make -C doc" -*-
|
321
by Martin Pool
doc: revfile storage and related things |
2 |
|
3 |
||
4 |
*******************
|
|
5 |
Things to do in bzr
|
|
6 |
*******************
|
|
7 |
||
287
by Martin Pool
- todo: plugins |
8 |
|
293
by Martin Pool
- todos |
9 |
See also various low-level TODOs in the source code. Try looking in |
284
by Martin Pool
- more TODO items |
10 |
the list archive or on gmane.org for previous discussion of these |
293
by Martin Pool
- todos |
11 |
issues. |
12 |
||
13 |
These are classified by approximate size: an hour or less, a day or |
|
14 |
less, and several days or more. |
|
15 |
||
282
by Martin Pool
- move all TODO items into ./TODO |
16 |
|
17 |
Small things
|
|
18 |
------------
|
|
19 |
||
20 |
* Add of a file that was present in the base revision should put back
|
|
21 |
the previous file-id. |
|
22 |
||
23 |
* Handle diff of files which do not have a trailing newline; probably
|
|
24 |
requires patching difflib to get it exactly right, or otherwise |
|
25 |
calling out to GNU diff. |
|
26 |
||
289
by Martin Pool
todo |
27 |
* -r option should take a revision-id as well as a revno.
|
28 |
||
322
by Martin Pool
- update todo list |
29 |
* ``bzr info`` should count only people with distinct email addresses as |
290
by Martin Pool
todo |
30 |
different committers. (Or perhaps only distinct userids?) |
31 |
||
322
by Martin Pool
- update todo list |
32 |
* On Windows, command-line arguments should be `glob-expanded`__, |
293
by Martin Pool
- todos |
33 |
because the shell doesn't do this. However, there are probably some |
34 |
commands where this shouldn't be done, such as 'bzr ignore', because |
|
35 |
we want to accept globs. |
|
36 |
||
329
by Martin Pool
- refactor command functions into command classes |
37 |
* ``bzr ignore`` command that just adds a line to the ``.bzrignore`` file |
38 |
and makes it versioned. Fix this to break symlinks. |
|
295
by Martin Pool
todo |
39 |
|
312
by Martin Pool
todo |
40 |
* Any useful sanity checks in 'bzr ignore'? Perhaps give a warning if
|
41 |
they try to add a single file which is already versioned, or if they |
|
42 |
add a pattern which already exists, or if it looks like they gave an |
|
43 |
unquoted glob. |
|
310
by Martin Pool
- new 'bzr ignored' command! |
44 |
|
325
by Martin Pool
- more revfile design notes |
45 |
__ http://mail.python.org/pipermail/python-list/2001-April/037847.html |
46 |
||
327
by Martin Pool
todo |
47 |
* Separate read and write version checks?
|
325
by Martin Pool
- more revfile design notes |
48 |
|
405
by Martin Pool
todo |
49 |
* ``bzr status DIR`` should give status on all files under that |
50 |
directory. |
|
51 |
||
484
by Martin Pool
todo |
52 |
* ``bzr log DIR`` should give changes to any files within DIR. |
53 |
||
329
by Martin Pool
- refactor command functions into command classes |
54 |
* ``bzr inventory -r REV`` and perhaps unify this with ``bzr ls``, |
55 |
giving options to display ids, types, etc. |
|
56 |
||
341
by Martin Pool
todo |
57 |
* Split BzrError into various more specific subclasses for different
|
58 |
errors people might want to catch. |
|
326
by Martin Pool
todo |
59 |
|
393
by Martin Pool
todo: export to tarball |
60 |
* If the export destination ends in '.tar', '.tar.gz', etc then create
|
61 |
a tarball instead of a directory. (Need to actually make a |
|
62 |
temporary directory and then tar that up.) |
|
63 |
||
64 |
http://www.gelato.unsw.edu.au/archives/git/0504/2194.html |
|
395
by Martin Pool
- fix error raised from invalid InventoryEntry name |
65 |
|
414
by Martin Pool
todo |
66 |
* RemoteBranch could maintain a cache either in memory or on disk. We
|
67 |
know more than an external cache might about which files are |
|
68 |
immutable and which can vary. On the other hand, it's much simpler |
|
69 |
to just use an external proxy cache. |
|
70 |
||
586
by Martin Pool
todo |
71 |
Perhaps ~/.bzr/http-cache. Baz has a fairly simple cache under |
72 |
~/.arch-cache, containing revision information encoded almost as a |
|
73 |
bunch of archives. Perhaps we could simply store full paths. |
|
74 |
||
487
by Martin Pool
todo |
75 |
* Maybe also store directories in the statcache so that we can quickly
|
76 |
identify that they still exist. |
|
77 |
||
570
by Martin Pool
doc |
78 |
* Diff should show timestamps; for files from the working directory we
|
79 |
can use the file itself; for files from a revision we should use the |
|
80 |
commit time of the revision. |
|
81 |
||
593
by Martin Pool
todo |
82 |
* Perhaps split command infrastructure from the actual command
|
83 |
definitions. |
|
84 |
||
85 |
* Cleaner support for negative boolean options like --no-recurse.
|
|
86 |
||
603
by Martin Pool
doc |
87 |
* Statcache should possibly map all file paths to / separators
|
88 |
||
642
by Martin Pool
- notes on patches for Windows |
89 |
* quotefn doubles all backslashes on Windows; this is probably not the
|
90 |
best thing to do. What would be a better way to safely represent |
|
91 |
filenames? Perhaps we could doublequote things containing spaces, |
|
92 |
on the principle that filenames containing quotes are unlikely? |
|
93 |
Nice for humans; less good for machine parsing. |
|
94 |
||
95 |
* Patches should probably use only forward slashes, even on Windows,
|
|
96 |
otherwise Unix patch can't apply them. (?) |
|
97 |
||
665
by Martin Pool
todo |
98 |
* Branch.update_revisions() inefficiently fetches revisions from the
|
99 |
remote server twice; once to find out what text and inventory they |
|
100 |
need and then again to actually get the thing. This is a bit |
|
101 |
inefficient. |
|
102 |
||
103 |
One complicating factor here is that we don't really want to have |
|
104 |
revisions present in the revision-store until all their constituent |
|
105 |
parts are also stored. |
|
106 |
||
107 |
The basic problem is that RemoteBranch.get_revision() and similar |
|
108 |
methods return object, but what we really want is the raw XML, which |
|
109 |
can be popped into our own store. That needs to be refactored. |
|
691
by Martin Pool
todo |
110 |
|
111 |
* ``bzr status FOO`` where foo is ignored should say so. |
|
724
by Martin Pool
- todo: bzr mkdir |
112 |
|
113 |
* ``bzr mkdir A...`` should just create and add A. |
|
818
by Martin Pool
- Clear pending-merge list when committing. |
114 |
|
115 |
* Guard against repeatedly merging any particular patch.
|
|
665
by Martin Pool
todo |
116 |
|
117 |
||
414
by Martin Pool
todo |
118 |
|
282
by Martin Pool
- move all TODO items into ./TODO |
119 |
Medium things
|
120 |
-------------
|
|
121 |
||
122 |
* Merge revert patch.
|
|
123 |
||
329
by Martin Pool
- refactor command functions into command classes |
124 |
* ``bzr mv`` that does either rename or move as in Unix. |
282
by Martin Pool
- move all TODO items into ./TODO |
125 |
|
478
by Martin Pool
- put back support for running diff or status on |
126 |
* More efficient diff of only selected files. We should be able to
|
127 |
just get the id for the selected files, look up their location and |
|
128 |
diff just those files. No need to traverse the entire inventories. |
|
282
by Martin Pool
- move all TODO items into ./TODO |
129 |
|
479
by Martin Pool
todo |
130 |
* ``bzr status DIR`` or ``bzr diff DIR`` should report on all changes |
131 |
under that directory. |
|
132 |
||
282
by Martin Pool
- move all TODO items into ./TODO |
133 |
* Fix up Inventory objects to represent root object as an entry.
|
134 |
||
552
by Martin Pool
- update todo list |
135 |
* Don't convert entire entry from ElementTree to an object when it is
|
136 |
read in, but rather wait until the program actually wants to know |
|
137 |
about that node. |
|
282
by Martin Pool
- move all TODO items into ./TODO |
138 |
|
139 |
* Extract changes from one revision to the next to a text form
|
|
140 |
suitable for transmission over email. |
|
141 |
||
142 |
* More test cases.
|
|
143 |
||
491
by Martin Pool
- Selective commit! |
144 |
- Selected-file commit
|
145 |
||
146 |
- Impossible selected-file commit: adding things in non-versioned
|
|
147 |
directories, crossing renames, etc. |
|
148 |
||
282
by Martin Pool
- move all TODO items into ./TODO |
149 |
* Write a reproducible benchmark, perhaps importing various kernel versions.
|
150 |
||
151 |
* Directly import diffs! It seems a bit redundant to need to rescan
|
|
152 |
the directory to work out what files diff added/deleted/changed when |
|
153 |
all the information is there in the diff in the first place. |
|
154 |
Getting the exact behaviour for added/deleted subdirectories etc |
|
155 |
might be hard. |
|
156 |
||
157 |
At the very least we could run diffstat over the diff, or perhaps |
|
158 |
read the status output from patch. Just knowing which files might |
|
159 |
be modified would be enough to guide the add and commit. |
|
160 |
||
161 |
Given this we might be able to import patches at 1/second or better. |
|
162 |
||
163 |
* Get branch over http.
|
|
164 |
||
165 |
* Pull pure updates over http.
|
|
166 |
||
167 |
* revfile compression.
|
|
168 |
||
169 |
* Split inventory into per-directory files.
|
|
170 |
||
284
by Martin Pool
- more TODO items |
171 |
* Fix ignore file parsing:
|
172 |
||
173 |
- fnmatch is not the same as unix patterns
|
|
174 |
||
175 |
- perhaps add extended globs from rsh/rsync
|
|
176 |
||
177 |
- perhaps a pattern that matches only directories or non-directories
|
|
178 |
||
312
by Martin Pool
todo |
179 |
* Consider using Python logging library as well as/instead of
|
180 |
bzrlib.trace. |
|
181 |
||
334
by Martin Pool
doc |
182 |
* Commands should give some progress indication by default.
|
183 |
||
184 |
- But quieten this with ``--silent``. |
|
185 |
||
312
by Martin Pool
todo |
186 |
* Change to using gettext message localization.
|
282
by Martin Pool
- move all TODO items into ./TODO |
187 |
|
315
by Martin Pool
todo |
188 |
* Make a clearer separation between internal and external bzrlib
|
189 |
interfaces. Make internal interfaces use protected names. Write at |
|
190 |
least some documentation for those APIs, probably as docstrings. |
|
191 |
||
192 |
Consider using ZopeInterface definitions for the external interface; |
|
193 |
I think these are already used in PyBaz. They allow automatic |
|
194 |
checking of the interface but may be unfamiliar to general Python |
|
321
by Martin Pool
doc: revfile storage and related things |
195 |
developers, so I'm not really keen. |
315
by Martin Pool
todo |
196 |
|
197 |
* Commands to dump out all command help into a manpage or HTML file or
|
|
198 |
whatever. |
|
199 |
||
326
by Martin Pool
todo |
200 |
* Handle symlinks in the working directory; at the very least it
|
201 |
should be possible for them to be present and ignored/unknown |
|
202 |
without causing assertion failures. |
|
203 |
||
204 |
Eventually symlinks should be versioned. |
|
205 |
||
329
by Martin Pool
- refactor command functions into command classes |
206 |
* Allow init in a subdirectory to create a nested repository, but only
|
207 |
if the subdirectory is not already versioned. Perhaps also require |
|
208 |
a ``--nested`` to protect against confusion.
|
|
209 |
||
210 |
* Branch names?
|
|
211 |
||
339
by Martin Pool
many more diffs |
212 |
* More test framework:
|
213 |
||
214 |
- Class that describes the state of a working tree so we can just
|
|
215 |
assert it's equal. |
|
216 |
||
342
by Martin Pool
todo |
217 |
* There are too many methods on Branch() that really manipulate the
|
346
by Martin Pool
todo |
218 |
WorkingTree. They should be moved across. |
219 |
||
220 |
Also there are some methods which are duplicated on Tree and |
|
221 |
Inventory objects, and it should be made more clear which ones are |
|
222 |
proxies and which ones behave differently, and how. |
|
342
by Martin Pool
todo |
223 |
|
361
by Martin Pool
todo |
224 |
* Try using XSLT to add some formatting to REST-generated HTML. Or
|
225 |
maybe write a small Python program that specifies a header and foot |
|
226 |
for the pages and calls into the docutils libraries. |
|
227 |
||
366
by Martin Pool
todo |
228 |
* --format=xml for log, status and other commands.
|
329
by Martin Pool
- refactor command functions into command classes |
229 |
|
370
by Martin Pool
todo |
230 |
* Attempting to explicitly add a file that's already added should give
|
231 |
a warning; however there should be no warning for directories (since |
|
232 |
we scan for new children) or files encountered in a directory that's |
|
233 |
being scanned. |
|
329
by Martin Pool
- refactor command functions into command classes |
234 |
|
377
by Martin Pool
- todo notes on inventory |
235 |
* Better handling of possible collisions on case-losing filesystems;
|
236 |
make sure a single file does not get added twice under different |
|
237 |
names. |
|
238 |
||
239 |
* Clean up XML inventory:
|
|
240 |
||
241 |
- Use nesting rather than parent_id pointers.
|
|
242 |
||
243 |
- Hold the ElementTree in memory in the Inventory object and work
|
|
244 |
directly on that, rather than converting into Python objects every |
|
453
by Martin Pool
- Split WorkingTree into its own file |
245 |
time it is read in. Probably still exposoe it through some kind of |
377
by Martin Pool
- todo notes on inventory |
246 |
object interface though, but perhaps that should just be a proxy |
247 |
for the elements. |
|
248 |
||
249 |
- Less special cases for the root directory.
|
|
250 |
||
388
by Martin Pool
doc |
251 |
* Perhaps inventories should remember the revision in which each file
|
252 |
was last changed, as well as its current state? This is a bit |
|
253 |
redundant but might often be interested to know. |
|
254 |
||
442
by Martin Pool
todo |
255 |
* stat cache should perhaps only stat files as necessary, rather than
|
256 |
doing them all up-front. On the other hand, that disallows the |
|
257 |
opimization of stating them in inode order. |
|
258 |
||
451
by Martin Pool
todo |
259 |
* It'd be nice to pipeline multiple HTTP requests. Often we can
|
260 |
predict what will be wanted in future: all revisions, or all texts |
|
261 |
in a particular revision, etc. |
|
262 |
||
263 |
urlgrabber's docs say they are working on batched downloads; we |
|
264 |
could perhaps ride on that or just create a background thread (ew). |
|
265 |
||
459
by Martin Pool
- diff now uses stat-cache -- much faster |
266 |
* Paranoid mode where we never trust SHA-1 matches.
|
267 |
||
502
by Martin Pool
todo |
268 |
* Don't commit if there are no changes unless forced.
|
269 |
||
522
by Martin Pool
todo |
270 |
* --dry-run mode for commit? (Or maybe just run with
|
271 |
check-command=false?) |
|
502
by Martin Pool
todo |
272 |
|
273 |
* Generally, be a bit more verbose unless --silent is specified.
|
|
274 |
||
522
by Martin Pool
todo |
275 |
* Function that finds all changes to files under a given directory;
|
276 |
perhaps log should use this if a directory is given. |
|
277 |
||
548
by Martin Pool
- Write statcache using \u style encoding to avoid |
278 |
* XML attributes might have trouble with filenames containing \n and
|
279 |
\r. Do we really want to support this? I think perhaps not. |
|
280 |
||
574
by Martin Pool
todo |
281 |
* Remember execute bits, so that exports will work OK.
|
282 |
||
579
by Martin Pool
todo |
283 |
* Unify smart_add and plain Branch.add(); perhaps smart_add should
|
284 |
just build a list of files to add and pass that to the regular add |
|
285 |
function. |
|
286 |
||
604
by Martin Pool
doc |
287 |
* Function to list a directory, saying in which revision each file was
|
288 |
last modified. Useful for web and gui interfaces, and slow to |
|
289 |
compute one file at a time. |
|
290 |
||
609
by Martin Pool
- cleanup test code |
291 |
* unittest is standard, but the results are kind of ugly; would be
|
292 |
nice to make it cleaner. |
|
293 |
||
627
by Martin Pool
todo |
294 |
* Check locking is correct during merge-related operations.
|
295 |
||
629
by Martin Pool
todo |
296 |
* Perhaps attempts to get locks should timeout after some period of
|
297 |
time, or at least display a progress message. |
|
298 |
||
702
by Martin Pool
todo: bzr upgrade |
299 |
* Split out upgrade functionality from check command into a separate
|
300 |
``bzr upgrade``.
|
|
301 |
||
738
by Martin Pool
- default plugin dir is ~/.bzr.conf/plugins |
302 |
* Don't pass around command classes but rather pass objects. This'd
|
303 |
make it cleaner to construct objects wrapping external commands. |
|
304 |
||
818
by Martin Pool
- Clear pending-merge list when committing. |
305 |
* Track all merged-in revisions in a versioned add-only metafile.
|
306 |
||
315
by Martin Pool
todo |
307 |
|
282
by Martin Pool
- move all TODO items into ./TODO |
308 |
Large things
|
309 |
------------
|
|
310 |
||
321
by Martin Pool
doc: revfile storage and related things |
311 |
* Generate annotations from current file relative to previous
|
312 |
annotations. |
|
313 |
||
314 |
- Is it necessary to store any kind of annotation where data was
|
|
315 |
deleted? |
|
316 |
||
325
by Martin Pool
- more revfile design notes |
317 |
* Update revfile_ format and make it active:
|
321
by Martin Pool
doc: revfile storage and related things |
318 |
|
319 |
- Texts should be identified by something keyed on the revision, not
|
|
320 |
an individual text-id. This is much more useful for annotate I |
|
321 |
think; we want to map back to the revision that last changed it. |
|
322 |
||
323 |
- Access revfile revisions through the Tree/Store classes.
|
|
324 |
||
325 |
- Check them from check commands.
|
|
326 |
||
327 |
- Store annotations.
|
|
328 |
||
325
by Martin Pool
- more revfile design notes |
329 |
.. _revfile: revfile.html |
330 |
||
294
by Martin Pool
todo |
331 |
* Hooks for pre-commit, post-commit, etc.
|
332 |
||
333 |
Consider the security implications; probably should not enable hooks |
|
334 |
for remotely-fetched branches by default. |
|
335 |
||
336 |
* Pre-commit check. If this hook is defined, it needs to be handled
|
|
337 |
specially: create a temporary directory containing the tree as it |
|
338 |
will be after the commit. This means excluding any ignored/unknown |
|
339 |
files, and respecting selective commits. Run the pre-commit check |
|
340 |
(e.g. compile and run test suite) in there. |
|
341 |
||
519
by Martin Pool
- todo: discussion of pre-commit tests |
342 |
Possibly this should be done by splitting the commit function into |
343 |
several parts (under a single interface). It is already rather |
|
344 |
large. Decomposition: |
|
345 |
||
346 |
- find tree modifications and prepare in-memory inventory
|
|
347 |
||
348 |
- export that inventory to a temporary directory
|
|
349 |
||
350 |
- run the test in that temporary directory
|
|
351 |
||
352 |
- if that succeeded, continue to actually finish the commit
|
|
353 |
||
354 |
What should be done with the text of modified files while this is |
|
355 |
underway? I don't think we want to count on holding them in memory |
|
356 |
and we can't trust the working files to stay in one place so I |
|
357 |
suppose we need to move them into the text store, or otherwise into |
|
358 |
a temporary directory. |
|
359 |
||
360 |
If the commit does not actually complete, we would rather the |
|
361 |
content was not left behind in the stores. |
|
362 |
||
282
by Martin Pool
- move all TODO items into ./TODO |
363 |
* Web interface
|
364 |
||
365 |
* GUI (maybe in Python GTK+?)
|
|
366 |
||
284
by Martin Pool
- more TODO items |
367 |
* C library interface
|
321
by Martin Pool
doc: revfile storage and related things |
368 |
|
369 |
* Expansion of $Id$ keywords within working files. Perhaps do this in
|
|
370 |
exports first as a simpler case because then we don't need to deal |
|
371 |
with removing the tags on the way back in. |
|
372 |
||
329
by Martin Pool
- refactor command functions into command classes |
373 |
* ``bzr find`` |