~bzr-pqm/bzr/bzr.dev

6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
1
# Copyright (C) 2005-2012, 2016 Robey Pointer <robey@lag.net>
2221.5.1 by Dmitry Vasiliev
Added support for Putty's SSH implementation
2
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
3
#
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
8
#
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
13
#
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
16
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
17
18
import os
19
import socket
2321.3.7 by Alexander Belchenko
fixes for passing test_sftp_transport on win32 (thankyou John)
20
import sys
1871.1.3 by Robert Collins
proof of concept slowsocket wrapper.
21
import time
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
22
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
23
from bzrlib import (
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
24
    config,
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
25
    controldir,
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
26
    errors,
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
27
    tests,
28
    transport as _mod_transport,
4222.3.13 by Jelmer Vernooij
Add tests to ensure sftp and ftp don't prompt for usernames.
29
    ui,
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
30
    )
31
from bzrlib.osutils import (
32
    lexists,
33
    )
34
from bzrlib.tests import (
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
35
    features,
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
36
    TestCaseWithTransport,
37
    TestCase,
38
    TestSkipped,
39
    )
2929.3.7 by Vincent Ladeuil
Rename bzrlib/test/HttpServer.py to bzrlib/tests/http_server.py and fix uses.
40
from bzrlib.tests.http_server import HttpServer
1711.2.132 by John Arbash Meinel
Clean up PEP8 and unused imports in bench_sftp.py, and missing import in bzrlib/tests/test_sftp_transport.py
41
import bzrlib.transport.http
2822.1.1 by v.ladeuil+lp at free
Fix #59150 (again) by handling paramiko availability for transport_util.py.
42
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
43
if features.paramiko.available():
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
44
    from bzrlib.transport import sftp as _mod_sftp
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
45
    from bzrlib.tests import stub_sftp
2822.1.1 by v.ladeuil+lp at free
Fix #59150 (again) by handling paramiko availability for transport_util.py.
46
1874.1.12 by Carl Friedrich Bolz
More fixes according to John's comments.
47
1874.1.14 by Carl Friedrich Bolz
Rename setup method to make its intent clearer. Some PEP 8 issues.
48
def set_test_transport_to_sftp(testcase):
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
49
    """A helper to set transports on test case instances."""
1874.1.6 by holger krekel
(cfbolz, hpk) Factor out common set_transport code.
50
    if getattr(testcase, '_get_remote_is_absolute', None) is None:
51
        testcase._get_remote_is_absolute = True
52
    if testcase._get_remote_is_absolute:
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
53
        testcase.transport_server = stub_sftp.SFTPAbsoluteServer
1874.1.6 by holger krekel
(cfbolz, hpk) Factor out common set_transport code.
54
    else:
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
55
        testcase.transport_server = stub_sftp.SFTPHomeDirServer
2004.1.25 by v.ladeuil+lp at free
Shuffle http related test code. Hopefully it ends up at the right place :)
56
    testcase.transport_readonly_server = HttpServer
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
57
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
58
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
59
class TestCaseWithSFTPServer(TestCaseWithTransport):
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
60
    """A test case base class that provides a sftp server on localhost."""
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
61
62
    def setUp(self):
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
63
        super(TestCaseWithSFTPServer, self).setUp()
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
64
        self.requireFeature(features.paramiko)
2381.1.1 by Robert Collins
Split out hpss test fixes which dont depend on new or altered API's.
65
        set_test_transport_to_sftp(self)
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
66
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
67
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
68
class SFTPLockTests(TestCaseWithSFTPServer):
1185.16.127 by Martin Pool
[patch] paramiko sftp tests (robey)
69
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
70
    def test_sftp_locks(self):
71
        from bzrlib.errors import LockError
72
        t = self.get_transport()
73
74
        l = t.lock_write('bogus')
5784.1.3 by Martin Pool
Switch away from using failUnlessExists and failIfExists
75
        self.assertPathExists('bogus.write-lock')
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
76
77
        # Don't wait for the lock, locking an already locked
78
        # file should raise an assert
79
        self.assertRaises(LockError, t.lock_write, 'bogus')
80
81
        l.unlock()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
82
        self.assertFalse(lexists('bogus.write-lock'))
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
83
6437.20.3 by Wouter van Heyst
mechanically replace file().write() pattern with a with-keyword version
84
        with open('something.write-lock', 'wb') as f: f.write('fake lock\n')
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
85
        self.assertRaises(LockError, t.lock_write, 'something')
86
        os.remove('something.write-lock')
87
88
        l = t.lock_write('something')
89
90
        l2 = t.lock_write('bogus')
91
92
        l.unlock()
93
        l2.unlock()
94
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
95
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
96
class SFTPTransportTestRelative(TestCaseWithSFTPServer):
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
97
    """Test the SFTP transport with homedir based relative paths."""
98
99
    def test__remote_path(self):
2823.1.4 by Vincent Ladeuil
Use assertIsSameRealPath to avoid OSX aliasing (specifically /tmp
100
        if sys.platform == 'darwin':
2823.1.11 by Vincent Ladeuil
Review feedback.
101
            # This test is about sftp absolute path handling. There is already
102
            # (in this test) a TODO about windows needing an absolute path
103
            # without drive letter. To me, using self.test_dir is a trick to
104
            # get an absolute path for comparison purposes.  That fails for OSX
105
            # because the sftp server doesn't resolve the links (and it doesn't
106
            # have to). --vila 20070924
2823.1.8 by Vincent Ladeuil
Rewrite expected failure message
107
            self.knownFailure('Mac OSX symlinks /tmp to /private/tmp,'
108
                              ' testing against self.test_dir'
109
                              ' is not appropriate')
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
110
        t = self.get_transport()
2321.3.7 by Alexander Belchenko
fixes for passing test_sftp_transport on win32 (thankyou John)
111
        # This test require unix-like absolute path
112
        test_dir = self.test_dir
113
        if sys.platform == 'win32':
114
            # using hack suggested by John Meinel.
115
            # TODO: write another mock server for this test
116
            #       and use absolute path without drive letter
117
            test_dir = '/' + test_dir
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
118
        # try what is currently used:
119
        # remote path = self._abspath(relpath)
2823.1.14 by Vincent Ladeuil
Fix 141382 by comparing real paths.
120
        self.assertIsSameRealPath(test_dir + '/relative',
121
                                  t._remote_path('relative'))
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
122
        # we dont os.path.join because windows gives us the wrong path
2321.3.7 by Alexander Belchenko
fixes for passing test_sftp_transport on win32 (thankyou John)
123
        root_segments = test_dir.split('/')
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
124
        root_parent = '/'.join(root_segments[:-1])
125
        # .. should be honoured
2823.1.14 by Vincent Ladeuil
Fix 141382 by comparing real paths.
126
        self.assertIsSameRealPath(root_parent + '/sibling',
127
                                  t._remote_path('../sibling'))
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
128
        # /  should be illegal ?
129
        ### FIXME decide and then test for all transports. RBC20051208
130
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
131
1986.1.10 by Robert Collins
Merge from bzr.dev, fixing found bugs handling 'has('/')' in MemoryTransport and SFTP transports.
132
class SFTPTransportTestRelativeRoot(TestCaseWithSFTPServer):
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
133
    """Test the SFTP transport with homedir based relative paths."""
134
135
    def setUp(self):
2485.8.43 by Vincent Ladeuil
Cleaning.
136
        # Only SFTPHomeDirServer is tested here
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
137
        self._get_remote_is_absolute = False
1986.1.10 by Robert Collins
Merge from bzr.dev, fixing found bugs handling 'has('/')' in MemoryTransport and SFTP transports.
138
        super(SFTPTransportTestRelativeRoot, self).setUp()
1530.1.6 by Robert Collins
Trim duplicate sftp tests.
139
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
140
    def test__remote_path_relative_root(self):
141
        # relative paths are preserved
142
        t = self.get_transport('')
6055.2.1 by Jelmer Vernooij
Add UnparsedUrl.
143
        self.assertEqual('/~/', t._parsed_url.path)
2485.8.27 by Vincent Ladeuil
Hearing jam saying "vila, you're trying too hard", I simplified again.
144
        # the remote path should be relative to home dir
145
        # (i.e. not begining with a '/')
1524.1.1 by Robert Collins
Test sftp with relative, absolute-in-homedir and absolute-not-in-homedir
146
        self.assertEqual('a', t._remote_path('a'))
147
148
1185.49.14 by John Arbash Meinel
[merge] bzr.dev
149
class SFTPNonServerTest(TestCase):
6552.1.4 by Vincent Ladeuil
Remaining tests matching setup(self) that can be rewritten with super().
150
1185.58.12 by John Arbash Meinel
Changing so that sftp tests are skipped rather than hidden when paramiko isn't present
151
    def setUp(self):
6552.1.4 by Vincent Ladeuil
Remaining tests matching setup(self) that can be rewritten with super().
152
        super(SFTPNonServerTest, self).setUp()
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
153
        self.requireFeature(features.paramiko)
1185.58.12 by John Arbash Meinel
Changing so that sftp tests are skipped rather than hidden when paramiko isn't present
154
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
155
    def test_parse_url_with_home_dir(self):
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
156
        s = _mod_sftp.SFTPTransport(
157
            'sftp://ro%62ey:h%40t@example.com:2222/~/relative')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
158
        self.assertEqual(s._parsed_url.host, 'example.com')
159
        self.assertEqual(s._parsed_url.port, 2222)
160
        self.assertEqual(s._parsed_url.user, 'robey')
161
        self.assertEqual(s._parsed_url.password, 'h@t')
162
        self.assertEqual(s._parsed_url.path, '/~/relative/')
1185.49.23 by John Arbash Meinel
bugreport from Matthieu Moy: relpath was failing, but throwing an unhelpful exception.
163
164
    def test_relpath(self):
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
165
        s = _mod_sftp.SFTPTransport('sftp://user@host.com/abs/path')
2485.8.20 by Vincent Ladeuil
Refactor SFTPTransport. Test suite passes.
166
        self.assertRaises(errors.PathNotChild, s.relpath,
167
                          'sftp://user@host.com/~/rel/path/sub')
1185.33.58 by Martin Pool
[patch] Better error when sftp urls are given with invalid port numbers (Matthieu Moy)
168
2013.1.2 by John Arbash Meinel
Add a test that we can always fall back to the paramiko vendor
169
    def test_get_paramiko_vendor(self):
170
        """Test that if no 'ssh' is available we get builtin paramiko"""
171
        from bzrlib.transport import ssh
172
        # set '.' as the only location in the path, forcing no 'ssh' to exist
5570.3.12 by Vincent Ladeuil
Replace osutils.set_or_unset_env calls with self.overrideEnv.
173
        self.overrideAttr(ssh, '_ssh_vendor_manager')
5570.3.13 by Vincent Ladeuil
Fix typo.
174
        self.overrideEnv('PATH', '.')
5570.3.12 by Vincent Ladeuil
Replace osutils.set_or_unset_env calls with self.overrideEnv.
175
        ssh._ssh_vendor_manager.clear_cache()
176
        vendor = ssh._get_ssh_vendor()
177
        self.assertIsInstance(vendor, ssh.ParamikoVendor)
2013.1.2 by John Arbash Meinel
Add a test that we can always fall back to the paramiko vendor
178
1986.1.10 by Robert Collins
Merge from bzr.dev, fixing found bugs handling 'has('/')' in MemoryTransport and SFTP transports.
179
    def test_abspath_root_sibling_server(self):
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
180
        server = stub_sftp.SFTPSiblingAbsoluteServer()
4934.3.3 by Martin Pool
Rename Server.setUp to Server.start_server
181
        server.start_server()
5570.3.12 by Vincent Ladeuil
Replace osutils.set_or_unset_env calls with self.overrideEnv.
182
        self.addCleanup(server.stop_server)
183
6083.1.1 by Jelmer Vernooij
Use get_transport_from_{url,path} in more places.
184
        transport = _mod_transport.get_transport_from_url(server.get_url())
5570.3.12 by Vincent Ladeuil
Replace osutils.set_or_unset_env calls with self.overrideEnv.
185
        self.assertFalse(transport.abspath('/').endswith('/~/'))
186
        self.assertTrue(transport.abspath('/').endswith('/'))
187
        del transport
1986.1.10 by Robert Collins
Merge from bzr.dev, fixing found bugs handling 'has('/')' in MemoryTransport and SFTP transports.
188
1185.40.4 by Robey Pointer
fix sftp urls to support the ietf draft url spec wrt relative vs absolute sftp urls (this will break existing branch urls); fix username/password parsing in sftp urls; add unit tests to make sure sftp url parsing is working
189
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
190
class SFTPBranchTest(TestCaseWithSFTPServer):
191
    """Test some stuff when accessing a bzr Branch over sftp"""
192
1185.49.26 by John Arbash Meinel
Adding tests for remote sftp branches without working trees, plus a bugfix to allow push to still work with a warning.
193
    def test_push_support(self):
194
        self.build_tree(['a/', 'a/foo'])
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
195
        t = controldir.ControlDir.create_standalone_workingtree('a')
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
196
        b = t.branch
1185.49.26 by John Arbash Meinel
Adding tests for remote sftp branches without working trees, plus a bugfix to allow push to still work with a warning.
197
        t.add('foo')
198
        t.commit('foo', rev_id='a1')
199
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
200
        b2 = controldir.ControlDir.create_branch_and_repo(self.get_url('/b'))
1185.49.26 by John Arbash Meinel
Adding tests for remote sftp branches without working trees, plus a bugfix to allow push to still work with a warning.
201
        b2.pull(b)
202
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
203
        self.assertEqual(b2.last_revision(), 'a1')
1185.49.26 by John Arbash Meinel
Adding tests for remote sftp branches without working trees, plus a bugfix to allow push to still work with a warning.
204
6437.20.3 by Wouter van Heyst
mechanically replace file().write() pattern with a with-keyword version
205
        with open('a/foo', 'wt') as f: f.write('something new in foo\n')
1185.31.48 by John Arbash Meinel
Added a small test to sftp to make sure some replacing was going on in the remote side.
206
        t.commit('new', rev_id='a2')
207
        b2.pull(b)
208
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
209
        self.assertEqual(b2.last_revision(), 'a2')
1185.31.48 by John Arbash Meinel
Added a small test to sftp to make sure some replacing was going on in the remote side.
210
1185.49.3 by John Arbash Meinel
Added a form of locking to sftp branches. Refactored _sftp_open_exclusive to take a relative path
211
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
212
class SSHVendorConnection(TestCaseWithSFTPServer):
213
    """Test that the ssh vendors can all connect.
214
215
    Verify that a full-handshake (SSH over loopback TCP) sftp connection works.
216
217
    We have 3 sftp implementations in the test suite:
218
      'loopback': Doesn't use ssh, just uses a local socket. Most tests are
219
                  done this way to save the handshaking time, so it is not
220
                  tested again here
221
      'none':     This uses paramiko's built-in ssh client and server, and layers
222
                  sftp on top of it.
223
      None:       If 'ssh' exists on the machine, then it will be spawned as a
224
                  child process.
225
    """
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
226
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
227
    def setUp(self):
228
        super(SSHVendorConnection, self).setUp()
229
230
        def create_server():
231
            """Just a wrapper so that when created, it will set _vendor"""
232
            # SFTPFullAbsoluteServer can handle any vendor,
233
            # it just needs to be set between the time it is instantiated
234
            # and the time .setUp() is called
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
235
            server = stub_sftp.SFTPFullAbsoluteServer()
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
236
            server._vendor = self._test_vendor
237
            return server
238
        self._test_vendor = 'loopback'
2018.5.42 by Robert Collins
Various hopefully improvements, but wsgi is broken, handing over to spiv :).
239
        self.vfs_transport_server = create_server
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
240
        f = open('a_file', 'wb')
241
        try:
242
            f.write('foobar\n')
243
        finally:
244
            f.close()
245
246
    def set_vendor(self, vendor):
247
        self._test_vendor = vendor
248
249
    def test_connection_paramiko(self):
1951.1.8 by Andrew Bennetts
Make _get_ssh_vendor return the vendor object, rather than just a string.
250
        from bzrlib.transport import ssh
251
        self.set_vendor(ssh.ParamikoVendor())
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
252
        t = self.get_transport()
253
        self.assertEqual('foobar\n', t.get('a_file').read())
254
255
    def test_connection_vendor(self):
256
        raise TestSkipped("We don't test spawning real ssh,"
257
                          " because it prompts for a password."
258
                          " Enable this test if we figure out"
259
                          " how to prevent this.")
260
        self.set_vendor(None)
261
        t = self.get_transport()
262
        self.assertEqual('foobar\n', t.get('a_file').read())
263
264
265
class SSHVendorBadConnection(TestCaseWithTransport):
266
    """Test that the ssh vendors handle bad connection properly
267
268
    We don't subclass TestCaseWithSFTPServer, because we don't actually
269
    need an SFTP connection.
270
    """
271
272
    def setUp(self):
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
273
        self.requireFeature(features.paramiko)
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
274
        super(SSHVendorBadConnection, self).setUp()
275
1185.49.35 by John Arbash Meinel
Update tests to use a truly unused port
276
        # open a random port, so we know nobody else is using it
277
        # but don't actually listen on the port.
278
        s = socket.socket()
279
        s.bind(('localhost', 0))
4985.2.1 by Vincent Ladeuil
Deploy addAttrCleanup on the whole test suite.
280
        self.addCleanup(s.close)
1185.49.35 by John Arbash Meinel
Update tests to use a truly unused port
281
        self.bogus_url = 'sftp://%s:%s/' % s.getsockname()
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
282
6331.5.1 by Martin Packman
Stop requiring a bzr subprocess in bt.test_sftp_transport for ssh connection error test
283
    def set_vendor(self, vendor, subprocess_stderr=None):
4985.2.1 by Vincent Ladeuil
Deploy addAttrCleanup on the whole test suite.
284
        from bzrlib.transport import ssh
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
285
        self.overrideAttr(ssh._ssh_vendor_manager, '_cached_ssh_vendor', vendor)
6331.5.1 by Martin Packman
Stop requiring a bzr subprocess in bt.test_sftp_transport for ssh connection error test
286
        if subprocess_stderr is not None:
287
            self.overrideAttr(ssh.SubprocessVendor, "_stderr_target",
288
                subprocess_stderr)
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
289
290
    def test_bad_connection_paramiko(self):
291
        """Test that a real connection attempt raises the right error"""
1951.1.8 by Andrew Bennetts
Make _get_ssh_vendor return the vendor object, rather than just a string.
292
        from bzrlib.transport import ssh
293
        self.set_vendor(ssh.ParamikoVendor())
6083.1.1 by Jelmer Vernooij
Use get_transport_from_{url,path} in more places.
294
        t = _mod_transport.get_transport_from_url(self.bogus_url)
2485.8.38 by Vincent Ladeuil
Finish sftp refactoring. Test suite passing.
295
        self.assertRaises(errors.ConnectionError, t.get, 'foobar')
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
296
297
    def test_bad_connection_ssh(self):
298
        """None => auto-detect vendor"""
6331.5.2 by Martin Packman
Close the devnull file on test cleanup
299
        f = file(os.devnull, "wb")
300
        self.addCleanup(f.close)
301
        self.set_vendor(None, f)
6331.5.1 by Martin Packman
Stop requiring a bzr subprocess in bt.test_sftp_transport for ssh connection error test
302
        t = _mod_transport.get_transport_from_url(self.bogus_url)
303
        try:
6331.5.3 by Martin Packman
Make the test more in the same style as its sibling as pointed out by vila in review
304
            self.assertRaises(errors.ConnectionError, t.get, 'foobar')
6331.5.1 by Martin Packman
Stop requiring a bzr subprocess in bt.test_sftp_transport for ssh connection error test
305
        except NameError, e:
306
            if "global name 'SSHException'" in str(e):
6331.5.3 by Martin Packman
Make the test more in the same style as its sibling as pointed out by vila in review
307
                self.knownFailure('Known NameError bug in paramiko 1.6.1')
6331.5.1 by Martin Packman
Stop requiring a bzr subprocess in bt.test_sftp_transport for ssh connection error test
308
            raise
1185.49.32 by John Arbash Meinel
Update tests to show that all ssh vendor failed connections work correctly, has some stipple from real ssh
309
1871.1.3 by Robert Collins
proof of concept slowsocket wrapper.
310
311
class SFTPLatencyKnob(TestCaseWithSFTPServer):
312
    """Test that the testing SFTPServer's latency knob works."""
313
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
314
    def test_latency_knob_slows_transport(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
315
        # change the latency knob to 500ms. We take about 40ms for a
1871.1.3 by Robert Collins
proof of concept slowsocket wrapper.
316
        # loopback connection ordinarily.
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
317
        start_time = time.time()
318
        self.get_server().add_latency = 0.5
319
        transport = self.get_transport()
2485.8.38 by Vincent Ladeuil
Finish sftp refactoring. Test suite passing.
320
        transport.has('not me') # Force connection by issuing a request
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
321
        with_latency_knob_time = time.time() - start_time
322
        self.assertTrue(with_latency_knob_time > 0.4)
323
324
    def test_default(self):
325
        # This test is potentially brittle: under extremely high machine load
326
        # it could fail, but that is quite unlikely
2631.1.1 by Aaron Bentley
Disable timing-sensitive test
327
        raise TestSkipped('Timing-sensitive test')
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
328
        start_time = time.time()
329
        transport = self.get_transport()
2485.8.38 by Vincent Ladeuil
Finish sftp refactoring. Test suite passing.
330
        transport.has('not me') # Force connection by issuing a request
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
331
        regular_time = time.time() - start_time
332
        self.assertTrue(regular_time < 0.5)
333
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
334
335
class FakeSocket(object):
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
336
    """Fake socket object used to test the SocketDelay wrapper without
337
    using a real socket.
338
    """
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
339
340
    def __init__(self):
341
        self._data = ""
342
343
    def send(self, data, flags=0):
344
        self._data += data
345
        return len(data)
346
347
    def sendall(self, data, flags=0):
348
        self._data += data
349
        return len(data)
350
351
    def recv(self, size, flags=0):
352
        if size < len(self._data):
353
            result = self._data[:size]
354
            self._data = self._data[size:]
355
            return result
356
        else:
357
            result = self._data
358
            self._data = ""
359
            return result
360
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
361
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
362
class TestSocketDelay(TestCase):
1874.1.9 by Carl Friedrich Bolz
Try to fix all the issues outline by john and Robert.
363
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
364
    def setUp(self):
6552.1.4 by Vincent Ladeuil
Remaining tests matching setup(self) that can be rewritten with super().
365
        super(TestSocketDelay, self).setUp()
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
366
        self.requireFeature(features.paramiko)
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
367
368
    def test_delay(self):
369
        sending = FakeSocket()
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
370
        receiving = stub_sftp.SocketDelay(sending, 0.1, bandwidth=1000000,
371
                                          really_sleep=False)
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
372
        # check that simulated time is charged only per round-trip:
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
373
        t1 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
374
        receiving.send("connect1")
375
        self.assertEqual(sending.recv(1024), "connect1")
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
376
        t2 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
377
        self.assertAlmostEqual(t2 - t1, 0.1)
378
        receiving.send("connect2")
379
        self.assertEqual(sending.recv(1024), "connect2")
380
        sending.send("hello")
381
        self.assertEqual(receiving.recv(1024), "hello")
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
382
        t3 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
383
        self.assertAlmostEqual(t3 - t2, 0.1)
384
        sending.send("hello")
385
        self.assertEqual(receiving.recv(1024), "hello")
386
        sending.send("hello")
387
        self.assertEqual(receiving.recv(1024), "hello")
388
        sending.send("hello")
389
        self.assertEqual(receiving.recv(1024), "hello")
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
390
        t4 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
391
        self.assertAlmostEqual(t4, t3)
392
393
    def test_bandwidth(self):
394
        sending = FakeSocket()
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
395
        receiving = stub_sftp.SocketDelay(sending, 0, bandwidth=8.0/(1024*1024),
396
                                          really_sleep=False)
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
397
        # check that simulated time is charged only per round-trip:
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
398
        t1 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
399
        receiving.send("connect")
400
        self.assertEqual(sending.recv(1024), "connect")
401
        sending.send("a" * 100)
402
        self.assertEqual(receiving.recv(1024), "a" * 100)
4797.11.2 by Vincent Ladeuil
Stop requiring testtools for sftp use.
403
        t2 = stub_sftp.SocketDelay.simulated_time
1874.1.2 by Carl Friedrich Bolz
Refined the SocketDelay to charge latency only once per round-trip and to
404
        self.assertAlmostEqual(t2 - t1, 100 + 7)
405
1874.1.3 by Carl Friedrich Bolz
Merge bzr.dev.
406
3815.2.4 by Martin Pool
merge fix for out-of-order SFTP readv
407
class ReadvFile(object):
5807.5.5 by Martin
Add close method to ReadvFile test object to fix failure
408
    """An object that acts like Paramiko's SFTPFile when readv() is used"""
3815.2.4 by Martin Pool
merge fix for out-of-order SFTP readv
409
410
    def __init__(self, data):
411
        self._data = data
412
413
    def readv(self, requests):
414
        for start, length in requests:
415
            yield self._data[start:start+length]
416
5807.5.5 by Martin
Add close method to ReadvFile test object to fix failure
417
    def close(self):
418
        pass
419
3815.2.4 by Martin Pool
merge fix for out-of-order SFTP readv
420
3882.7.16 by Martin Pool
Update SFTP tests to accommodate progress reporting
421
def _null_report_activity(*a, **k):
422
    pass
423
424
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
425
class Test_SFTPReadvHelper(tests.TestCase):
426
3686.1.6 by John Arbash Meinel
Respond to Martin's review comments.
427
    def checkGetRequests(self, expected_requests, offsets):
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
428
        self.requireFeature(features.paramiko)
3882.7.16 by Martin Pool
Update SFTP tests to accommodate progress reporting
429
        helper = _mod_sftp._SFTPReadvHelper(offsets, 'artificial_test',
430
            _null_report_activity)
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
431
        self.assertEqual(expected_requests, helper._get_requests())
432
433
    def test__get_requests(self):
434
        # Small single requests become a single readv request
3686.1.6 by John Arbash Meinel
Respond to Martin's review comments.
435
        self.checkGetRequests([(0, 100)],
436
                              [(0, 20), (30, 50), (20, 10), (80, 20)])
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
437
        # Non-contiguous ranges are given as multiple requests
3686.1.6 by John Arbash Meinel
Respond to Martin's review comments.
438
        self.checkGetRequests([(0, 20), (30, 50)],
439
                              [(10, 10), (30, 20), (0, 10), (50, 30)])
3686.1.2 by John Arbash Meinel
Start moving the readv code into a helper.
440
        # Ranges larger than _max_request_size (32kB) are broken up into
441
        # multiple requests, even if it actually spans multiple logical
442
        # requests
3686.1.6 by John Arbash Meinel
Respond to Martin's review comments.
443
        self.checkGetRequests([(0, 32768), (32768, 32768), (65536, 464)],
444
                              [(0, 40000), (40000, 100), (40100, 1900),
445
                               (42000, 24000)])
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
446
3815.2.4 by Martin Pool
merge fix for out-of-order SFTP readv
447
    def checkRequestAndYield(self, expected, data, offsets):
4913.2.16 by John Arbash Meinel
Move bzrlib.tests.ParamikoFeature to bzrlib.tests.features.paramiko
448
        self.requireFeature(features.paramiko)
3882.7.16 by Martin Pool
Update SFTP tests to accommodate progress reporting
449
        helper = _mod_sftp._SFTPReadvHelper(offsets, 'artificial_test',
450
            _null_report_activity)
3815.2.4 by Martin Pool
merge fix for out-of-order SFTP readv
451
        data_f = ReadvFile(data)
452
        result = list(helper.request_and_yield_offsets(data_f))
453
        self.assertEqual(expected, result)
454
455
    def test_request_and_yield_offsets(self):
456
        data = 'abcdefghijklmnopqrstuvwxyz'
457
        self.checkRequestAndYield([(0, 'a'), (5, 'f'), (10, 'klm')], data,
458
                                  [(0, 1), (5, 1), (10, 3)])
459
        # Should combine requests, and split them again
460
        self.checkRequestAndYield([(0, 'a'), (1, 'b'), (10, 'klm')], data,
461
                                  [(0, 1), (1, 1), (10, 3)])
462
        # Out of order requests. The requests should get combined, but then be
463
        # yielded out-of-order. We also need one that is at the end of a
464
        # previous range. See bug #293746
465
        self.checkRequestAndYield([(0, 'a'), (10, 'k'), (4, 'efg'), (1, 'bcd')],
466
                                  data, [(0, 1), (10, 1), (4, 3), (1, 3)])
467
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
468
469
class TestUsesAuthConfig(TestCaseWithSFTPServer):
3777.1.4 by Aaron Bentley
bzr+ssh and sftp both use ssh scheme.
470
    """Test that AuthenticationConfig can supply default usernames."""
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
471
3777.1.2 by Aaron Bentley
Make testing more thorough
472
    def get_transport_for_connection(self, set_config):
5247.4.18 by Vincent Ladeuil
Replace SocketListener by TestingTCPServerInAThread and fallouts,
473
        port = self.get_server().port
3777.1.2 by Aaron Bentley
Make testing more thorough
474
        if set_config:
475
            conf = config.AuthenticationConfig()
476
            conf._get_config().update(
3777.1.4 by Aaron Bentley
bzr+ssh and sftp both use ssh scheme.
477
                {'sftptest': {'scheme': 'ssh', 'port': port, 'user': 'bar'}})
3777.1.2 by Aaron Bentley
Make testing more thorough
478
            conf._save()
6083.1.1 by Jelmer Vernooij
Use get_transport_from_{url,path} in more places.
479
        t = _mod_transport.get_transport_from_url(
480
            'sftp://localhost:%d' % port)
3777.1.2 by Aaron Bentley
Make testing more thorough
481
        # force a connection to be performed.
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
482
        t.has('foo')
3777.1.2 by Aaron Bentley
Make testing more thorough
483
        return t
484
485
    def test_sftp_uses_config(self):
486
        t = self.get_transport_for_connection(set_config=True)
3777.1.1 by Aaron Bentley
Use auth.conf for sftp
487
        self.assertEqual('bar', t._get_credentials()[0])
3777.1.2 by Aaron Bentley
Make testing more thorough
488
489
    def test_sftp_is_none_if_no_config(self):
490
        t = self.get_transport_for_connection(set_config=False)
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
491
        self.assertIs(None, t._get_credentials()[0])
4222.3.13 by Jelmer Vernooij
Add tests to ensure sftp and ftp don't prompt for usernames.
492
493
    def test_sftp_doesnt_prompt_username(self):
494
        stdout = tests.StringIOWrapper()
495
        ui.ui_factory = tests.TestUIFactory(stdin='joe\nfoo\n', stdout=stdout)
496
        t = self.get_transport_for_connection(set_config=False)
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
497
        self.assertIs(None, t._get_credentials()[0])
4222.3.13 by Jelmer Vernooij
Add tests to ensure sftp and ftp don't prompt for usernames.
498
        # No prompts should've been printed, stdin shouldn't have been read
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
499
        self.assertEqual("", stdout.getvalue())
500
        self.assertEqual(0, ui.ui_factory.stdin.tell())