~bzr-pqm/bzr/bzr.dev

6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
1
# Copyright (C) 2005-2014, 2016 Canonical Ltd
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
16
17
"""Tests for finding and reading the bzr config file[s]."""
5912.5.7 by Martin
Minor cleanups and note about error case
18
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
19
from cStringIO import StringIO
6524.2.2 by Aaron Bentley
Test branchname config var.
20
from textwrap import dedent
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
21
import os
22
import sys
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
23
import threading
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
24
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
25
from testtools import matchers
26
1878.1.3 by John Arbash Meinel
some test cleanups
27
from bzrlib import (
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
28
    branch,
1878.1.3 by John Arbash Meinel
some test cleanups
29
    config,
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
30
    controldir,
4603.1.10 by Aaron Bentley
Provide change editor via config.
31
    diff,
1878.1.3 by John Arbash Meinel
some test cleanups
32
    errors,
33
    osutils,
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
34
    mail_client,
2900.2.14 by Vincent Ladeuil
More tests.
35
    ui,
1878.1.3 by John Arbash Meinel
some test cleanups
36
    urlutils,
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
37
    registry as _mod_registry,
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
38
    remote,
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
39
    tests,
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
40
    trace,
1878.1.3 by John Arbash Meinel
some test cleanups
41
    )
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
42
from bzrlib.symbol_versioning import (
43
    deprecated_in,
44
    )
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
45
from bzrlib.transport import remote as transport_remote
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
46
from bzrlib.tests import (
47
    features,
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
48
    scenarios,
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
49
    test_server,
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
50
    )
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
51
from bzrlib.util.configobj import configobj
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
52
53
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
54
def lockable_config_scenarios():
55
    return [
56
        ('global',
57
         {'config_class': config.GlobalConfig,
58
          'config_args': [],
59
          'config_section': 'DEFAULT'}),
60
        ('locations',
61
         {'config_class': config.LocationConfig,
62
          'config_args': ['.'],
63
          'config_section': '.'}),]
64
65
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
66
load_tests = scenarios.load_tests_apply_scenarios
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
67
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
68
# Register helpers to build stores
69
config.test_store_builder_registry.register(
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
70
    'configobj', lambda test: config.TransportIniFileStore(
71
        test.get_transport(), 'configobj.conf'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
72
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
73
    'bazaar', lambda test: config.GlobalStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
74
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
75
    'location', lambda test: config.LocationStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
76
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
77
78
def build_backing_branch(test, relpath,
79
                         transport_class=None, server_class=None):
80
    """Test helper to create a backing branch only once.
81
82
    Some tests needs multiple stores/stacks to check concurrent update
83
    behaviours. As such, they need to build different branch *objects* even if
84
    they share the branch on disk.
85
86
    :param relpath: The relative path to the branch. (Note that the helper
87
        should always specify the same relpath).
88
89
    :param transport_class: The Transport class the test needs to use.
90
91
    :param server_class: The server associated with the ``transport_class``
92
        above.
93
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
94
    Either both or neither of ``transport_class`` and ``server_class`` should
95
    be specified.
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
96
    """
97
    if transport_class is not None and server_class is not None:
98
        test.transport_class = transport_class
99
        test.transport_server = server_class
100
    elif not (transport_class is None and server_class is None):
101
        raise AssertionError('Specify both ``transport_class`` and '
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
102
                             '``server_class`` or neither of them')
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
103
    if getattr(test, 'backing_branch', None) is None:
104
        # First call, let's build the branch on disk
105
        test.backing_branch = test.make_branch(relpath)
106
107
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
108
def build_branch_store(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
109
    build_backing_branch(test, 'branch')
110
    b = branch.Branch.open('branch')
111
    return config.BranchStore(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
112
config.test_store_builder_registry.register('branch', build_branch_store)
113
114
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
115
def build_control_store(test):
116
    build_backing_branch(test, 'branch')
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
117
    b = controldir.ControlDir.open('branch')
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
118
    return config.ControlStore(b)
119
config.test_store_builder_registry.register('control', build_control_store)
120
121
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
122
def build_remote_branch_store(test):
123
    # There is only one permutation (but we won't be able to handle more with
124
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
125
    (transport_class,
126
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
127
    build_backing_branch(test, 'branch', transport_class, server_class)
128
    b = branch.Branch.open(test.get_url('branch'))
129
    return config.BranchStore(b)
130
config.test_store_builder_registry.register('remote_branch',
131
                                            build_remote_branch_store)
132
133
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
134
config.test_stack_builder_registry.register(
135
    'bazaar', lambda test: config.GlobalStack())
136
config.test_stack_builder_registry.register(
137
    'location', lambda test: config.LocationStack('.'))
138
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
139
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
140
def build_branch_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
141
    build_backing_branch(test, 'branch')
142
    b = branch.Branch.open('branch')
143
    return config.BranchStack(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
144
config.test_stack_builder_registry.register('branch', build_branch_stack)
145
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
146
6379.11.1 by Vincent Ladeuil
Migrate location options to config stacks.
147
def build_branch_only_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
148
    # There is only one permutation (but we won't be able to handle more with
149
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
150
    (transport_class,
151
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
152
    build_backing_branch(test, 'branch', transport_class, server_class)
153
    b = branch.Branch.open(test.get_url('branch'))
6379.11.2 by Vincent Ladeuil
No matter how weird BranchOnlyStack is, it's public, the FIXMEs should be enough for devs to notice.
154
    return config.BranchOnlyStack(b)
6379.11.1 by Vincent Ladeuil
Migrate location options to config stacks.
155
config.test_stack_builder_registry.register('branch_only',
156
                                            build_branch_only_stack)
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
157
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
158
def build_remote_control_stack(test):
159
    # There is only one permutation (but we won't be able to handle more with
160
    # this design anyway)
161
    (transport_class,
162
     server_class) = transport_remote.get_test_permutations()[0]
163
    # We need only a bzrdir for this, not a full branch, but it's not worth
164
    # creating a dedicated helper to create only the bzrdir
165
    build_backing_branch(test, 'branch', transport_class, server_class)
166
    b = branch.Branch.open(test.get_url('branch'))
6270.1.20 by Jelmer Vernooij
Revert RemoteBranchStack / RemoteControlStack changes.
167
    return config.RemoteControlStack(b.bzrdir)
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
168
config.test_stack_builder_registry.register('remote_control',
169
                                            build_remote_control_stack)
170
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
171
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
172
sample_long_alias="log -r-15..-1 --line"
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
173
sample_config_text = u"""
174
[DEFAULT]
175
email=Erik B\u00e5gfors <erik@bagfors.nu>
176
editor=vim
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
177
change_editor=vimdiff -of @new_path @old_path
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
178
gpg_signing_command=gnome-gpg
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
179
gpg_signing_key=DD4D5088
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
180
log_format=short
5971.1.58 by Jonathan Riddell
more tests for new config options
181
validate_signatures_in_log=true
182
acceptable_keys=amy
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
183
user_global_option=something
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
184
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
5321.2.3 by Vincent Ladeuil
Prefix mergetools option names with 'bzr.'.
185
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
186
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
187
bzr.default_mergetool=sometool
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
188
[ALIASES]
189
h=help
190
ll=""" + sample_long_alias + "\n"
191
192
193
sample_always_signatures = """
194
[DEFAULT]
195
check_signatures=ignore
196
create_signatures=always
197
"""
198
199
sample_ignore_signatures = """
200
[DEFAULT]
201
check_signatures=require
202
create_signatures=never
203
"""
204
205
sample_maybe_signatures = """
206
[DEFAULT]
207
check_signatures=ignore
208
create_signatures=when-required
209
"""
210
211
sample_branches_text = """
212
[http://www.example.com]
213
# Top level policy
214
email=Robert Collins <robertc@example.org>
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
215
normal_option = normal
216
appendpath_option = append
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
217
appendpath_option:policy = appendpath
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
218
norecurse_option = norecurse
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
219
norecurse_option:policy = norecurse
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
220
[http://www.example.com/ignoreparent]
221
# different project: ignore parent dir config
222
ignore_parents=true
223
[http://www.example.com/norecurse]
224
# configuration items that only apply to this dir
225
recurse=false
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
226
normal_option = norecurse
227
[http://www.example.com/dir]
228
appendpath_option = normal
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
229
[/b/]
230
check_signatures=require
231
# test trailing / matching with no children
232
[/a/]
233
check_signatures=check-available
234
gpg_signing_command=false
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
235
gpg_signing_key=default
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
236
user_local_option=local
237
# test trailing / matching
238
[/a/*]
239
#subdirs will match but not the parent
240
[/a/c]
241
check_signatures=ignore
242
post_commit=bzrlib.tests.test_config.post_commit
243
#testing explicit beats globs
244
"""
1553.6.3 by Erik BÃ¥gfors
tests for AliasesConfig
245
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
246
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
247
def create_configs(test):
248
    """Create configuration files for a given test.
249
250
    This requires creating a tree (and populate the ``test.tree`` attribute)
251
    and its associated branch and will populate the following attributes:
252
253
    - branch_config: A BranchConfig for the associated branch.
254
255
    - locations_config : A LocationConfig for the associated branch
256
257
    - bazaar_config: A GlobalConfig.
258
259
    The tree and branch are created in a 'tree' subdirectory so the tests can
260
    still use the test directory to stay outside of the branch.
261
    """
262
    tree = test.make_branch_and_tree('tree')
263
    test.tree = tree
264
    test.branch_config = config.BranchConfig(tree.branch)
265
    test.locations_config = config.LocationConfig(tree.basedir)
266
    test.bazaar_config = config.GlobalConfig()
267
5533.2.4 by Vincent Ladeuil
Fix whitespace issue.
268
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
269
def create_configs_with_file_option(test):
270
    """Create configuration files with a ``file`` option set in each.
271
272
    This builds on ``create_configs`` and add one ``file`` option in each
273
    configuration with a value which allows identifying the configuration file.
274
    """
275
    create_configs(test)
276
    test.bazaar_config.set_user_option('file', 'bazaar')
277
    test.locations_config.set_user_option('file', 'locations')
278
    test.branch_config.set_user_option('file', 'branch')
279
280
281
class TestOptionsMixin:
282
283
    def assertOptions(self, expected, conf):
284
        # We don't care about the parser (as it will make tests hard to write
285
        # and error-prone anyway)
286
        self.assertThat([opt[:4] for opt in conf._get_options()],
287
                        matchers.Equals(expected))
288
289
1474 by Robert Collins
Merge from Aaron Bentley.
290
class InstrumentedConfigObj(object):
291
    """A config obj look-enough-alike to record calls made to it."""
292
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
293
    def __contains__(self, thing):
294
        self._calls.append(('__contains__', thing))
295
        return False
296
297
    def __getitem__(self, key):
298
        self._calls.append(('__getitem__', key))
299
        return self
300
1551.2.20 by Aaron Bentley
Treated config files as utf-8
301
    def __init__(self, input, encoding=None):
302
        self._calls = [('__init__', input, encoding)]
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
303
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
304
    def __setitem__(self, key, value):
305
        self._calls.append(('__setitem__', key, value))
306
2120.6.4 by James Henstridge
add support for specifying policy when storing options
307
    def __delitem__(self, key):
308
        self._calls.append(('__delitem__', key))
309
310
    def keys(self):
311
        self._calls.append(('keys',))
312
        return []
313
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
314
    def reload(self):
315
        self._calls.append(('reload',))
316
1551.2.49 by abentley
Made ConfigObj output binary-identical files on win32 and *nix
317
    def write(self, arg):
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
318
        self._calls.append(('write',))
319
2120.6.4 by James Henstridge
add support for specifying policy when storing options
320
    def as_bool(self, value):
321
        self._calls.append(('as_bool', value))
322
        return False
323
324
    def get_value(self, section, name):
325
        self._calls.append(('get_value', section, name))
326
        return None
327
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
328
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
329
class FakeBranch(object):
330
6362.1.4 by Jelmer Vernooij
Fix tests.
331
    def __init__(self, base=None):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
332
        if base is None:
333
            self.base = "http://example.com/branches/demo"
334
        else:
335
            self.base = base
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
336
        self._transport = self.control_files = \
6362.1.4 by Jelmer Vernooij
Fix tests.
337
            FakeControlFilesAndTransport()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
338
4226.1.7 by Robert Collins
Alter test_config.FakeBranch in accordance with the Branch change to have a _get_config.
339
    def _get_config(self):
340
        return config.TransportConfig(self._transport, 'branch.conf')
341
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
342
    def lock_write(self):
343
        pass
344
345
    def unlock(self):
346
        pass
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
347
348
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
349
class FakeControlFilesAndTransport(object):
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
350
6362.1.4 by Jelmer Vernooij
Fix tests.
351
    def __init__(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
352
        self.files = {}
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
353
        self._transport = self
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
354
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
355
    def get(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
356
        # from Transport
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
357
        try:
358
            return StringIO(self.files[filename])
359
        except KeyError:
360
            raise errors.NoSuchFile(filename)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
361
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
362
    def get_bytes(self, filename):
363
        # from Transport
364
        try:
365
            return self.files[filename]
366
        except KeyError:
367
            raise errors.NoSuchFile(filename)
368
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
369
    def put(self, filename, fileobj):
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
370
        self.files[filename] = fileobj.read()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
371
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
372
    def put_file(self, filename, fileobj):
373
        return self.put(filename, fileobj)
374
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
375
376
class InstrumentedConfig(config.Config):
377
    """An instrumented config that supplies stubs for template methods."""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
378
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
379
    def __init__(self):
380
        super(InstrumentedConfig, self).__init__()
381
        self._calls = []
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
382
        self._signatures = config.CHECK_NEVER
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
383
384
    def _get_user_id(self):
385
        self._calls.append('_get_user_id')
386
        return "Robert Collins <robert.collins@example.org>"
387
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
388
    def _get_signature_checking(self):
389
        self._calls.append('_get_signature_checking')
390
        return self._signatures
391
4603.1.10 by Aaron Bentley
Provide change editor via config.
392
    def _get_change_editor(self):
393
        self._calls.append('_get_change_editor')
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
394
        return 'vimdiff -fo @new_path @old_path'
4603.1.10 by Aaron Bentley
Provide change editor via config.
395
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
396
1556.2.2 by Aaron Bentley
Fixed get_bool
397
bool_config = """[DEFAULT]
398
active = true
399
inactive = false
400
[UPPERCASE]
401
active = True
402
nonactive = False
403
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
404
405
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
406
class TestConfigObj(tests.TestCase):
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
407
1556.2.2 by Aaron Bentley
Fixed get_bool
408
    def test_get_bool(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
409
        co = config.ConfigObj(StringIO(bool_config))
1556.2.2 by Aaron Bentley
Fixed get_bool
410
        self.assertIs(co.get_bool('DEFAULT', 'active'), True)
411
        self.assertIs(co.get_bool('DEFAULT', 'inactive'), False)
412
        self.assertIs(co.get_bool('UPPERCASE', 'active'), True)
413
        self.assertIs(co.get_bool('UPPERCASE', 'nonactive'), False)
414
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
415
    def test_hash_sign_in_value(self):
416
        """
417
        Before 4.5.0, ConfigObj did not quote # signs in values, so they'd be
418
        treated as comments when read in again. (#86838)
419
        """
420
        co = config.ConfigObj()
421
        co['test'] = 'foo#bar'
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
422
        outfile = StringIO()
423
        co.write(outfile=outfile)
424
        lines = outfile.getvalue().splitlines()
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
425
        self.assertEqual(lines, ['test = "foo#bar"'])
426
        co2 = config.ConfigObj(lines)
427
        self.assertEqual(co2['test'], 'foo#bar')
428
5050.62.10 by Alexander Belchenko
test to illustrate the problem
429
    def test_triple_quotes(self):
430
        # Bug #710410: if the value string has triple quotes
431
        # then ConfigObj versions up to 4.7.2 will quote them wrong
5050.62.12 by Alexander Belchenko
added NEWS entry
432
        # and won't able to read them back
5050.62.10 by Alexander Belchenko
test to illustrate the problem
433
        triple_quotes_value = '''spam
434
""" that's my spam """
435
eggs'''
436
        co = config.ConfigObj()
437
        co['test'] = triple_quotes_value
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
438
        # While writing this test another bug in ConfigObj has been found:
5050.62.10 by Alexander Belchenko
test to illustrate the problem
439
        # method co.write() without arguments produces list of lines
440
        # one option per line, and multiline values are not split
441
        # across multiple lines,
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
442
        # and that breaks the parsing these lines back by ConfigObj.
443
        # This issue only affects test, but it's better to avoid
444
        # `co.write()` construct at all.
445
        # [bialix 20110222] bug report sent to ConfigObj's author
5050.62.10 by Alexander Belchenko
test to illustrate the problem
446
        outfile = StringIO()
447
        co.write(outfile=outfile)
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
448
        output = outfile.getvalue()
5050.62.10 by Alexander Belchenko
test to illustrate the problem
449
        # now we're trying to read it back
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
450
        co2 = config.ConfigObj(StringIO(output))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
451
        self.assertEqual(triple_quotes_value, co2['test'])
5050.62.10 by Alexander Belchenko
test to illustrate the problem
452
1556.2.2 by Aaron Bentley
Fixed get_bool
453
2900.1.1 by Vincent Ladeuil
454
erroneous_config = """[section] # line 1
455
good=good # line 2
456
[section] # line 3
457
whocares=notme # line 4
458
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
459
460
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
461
class TestConfigObjErrors(tests.TestCase):
2900.1.1 by Vincent Ladeuil
462
463
    def test_duplicate_section_name_error_line(self):
464
        try:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
465
            co = configobj.ConfigObj(StringIO(erroneous_config),
466
                                     raise_errors=True)
2900.1.1 by Vincent Ladeuil
467
        except config.configobj.DuplicateError, e:
468
            self.assertEqual(3, e.line_number)
469
        else:
470
            self.fail('Error in config file not detected')
471
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
472
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
473
class TestConfig(tests.TestCase):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
474
475
    def test_constructs(self):
476
        config.Config()
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
477
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
478
    def test_user_email(self):
479
        my_config = InstrumentedConfig()
480
        self.assertEqual('robert.collins@example.org', my_config.user_email())
481
        self.assertEqual(['_get_user_id'], my_config._calls)
482
483
    def test_username(self):
484
        my_config = InstrumentedConfig()
485
        self.assertEqual('Robert Collins <robert.collins@example.org>',
486
                         my_config.username())
487
        self.assertEqual(['_get_user_id'], my_config._calls)
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
488
489
    def test_signatures_default(self):
490
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
491
        self.assertFalse(
492
            self.applyDeprecated(deprecated_in((2, 5, 0)),
493
                my_config.signature_needed))
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
494
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
495
            self.applyDeprecated(deprecated_in((2, 5, 0)),
496
                my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
497
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
498
                self.applyDeprecated(deprecated_in((2, 5, 0)),
499
                    my_config.signing_policy))
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
500
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
501
    def test_signatures_template_method(self):
502
        my_config = InstrumentedConfig()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
503
        self.assertEqual(config.CHECK_NEVER,
504
            self.applyDeprecated(deprecated_in((2, 5, 0)),
505
                my_config.signature_checking))
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
506
        self.assertEqual(['_get_signature_checking'], my_config._calls)
507
508
    def test_signatures_template_method_none(self):
509
        my_config = InstrumentedConfig()
510
        my_config._signatures = None
511
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
512
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
513
                             my_config.signature_checking))
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
514
        self.assertEqual(['_get_signature_checking'], my_config._calls)
515
1442.1.56 by Robert Collins
gpg_signing_command configuration item
516
    def test_gpg_signing_command_default(self):
517
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
518
        self.assertEqual('gpg',
519
            self.applyDeprecated(deprecated_in((2, 5, 0)),
520
                my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
521
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
522
    def test_get_user_option_default(self):
523
        my_config = config.Config()
524
        self.assertEqual(None, my_config.get_user_option('no_option'))
525
1472 by Robert Collins
post commit hook, first pass implementation
526
    def test_post_commit_default(self):
527
        my_config = config.Config()
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
528
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
529
                                                    my_config.post_commit))
530
1472 by Robert Collins
post commit hook, first pass implementation
531
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
532
    def test_log_format_default(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
533
        my_config = config.Config()
6378.1.3 by Vincent Ladeuil
log_format has been migrated but the old config method needs to be deprecated.
534
        self.assertEqual('long',
535
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
536
                                              my_config.log_format))
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
537
5971.1.57 by Jonathan Riddell
tests for new config options
538
    def test_acceptable_keys_default(self):
539
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
540
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
541
            my_config.acceptable_keys))
5971.1.57 by Jonathan Riddell
tests for new config options
542
543
    def test_validate_signatures_in_log_default(self):
544
        my_config = config.Config()
545
        self.assertEqual(False, my_config.validate_signatures_in_log())
546
4603.1.10 by Aaron Bentley
Provide change editor via config.
547
    def test_get_change_editor(self):
548
        my_config = InstrumentedConfig()
549
        change_editor = my_config.get_change_editor('old_tree', 'new_tree')
550
        self.assertEqual(['_get_change_editor'], my_config._calls)
551
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
552
        self.assertEqual(['vimdiff', '-fo', '@new_path', '@old_path'],
4603.1.10 by Aaron Bentley
Provide change editor via config.
553
                         change_editor.command_template)
554
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
555
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
556
class TestConfigPath(tests.TestCase):
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
557
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
558
    def setUp(self):
559
        super(TestConfigPath, self).setUp()
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
560
        self.overrideEnv('HOME', '/home/bogus')
6589.2.1 by Andrew Starr-Bochicchio
The XDG Base Directory Specification uses the XDG_CACHE_HOME XDG_CACHE_HOME, not XDG_CACHE_DIR.
561
        self.overrideEnv('XDG_CACHE_HOME', '')
2309.2.6 by Alexander Belchenko
bzr now use Win32 API to determine Application Data location, and don't rely solely on $APPDATA
562
        if sys.platform == 'win32':
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
563
            self.overrideEnv(
564
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
565
            self.bzr_home = \
566
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
5519.4.3 by Neil Martinsen-Burrell
be permissive about using $XDG_CONFIG_HOME/bazaar, but dont complain
567
        else:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
568
            self.bzr_home = '/home/bogus/.bazaar'
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
569
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
570
    def test_config_dir(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
571
        self.assertEqual(config.config_dir(), self.bzr_home)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
572
6437.27.5 by Martin Packman
Document and test that config_dir now always returns unicode
573
    def test_config_dir_is_unicode(self):
574
        self.assertIsInstance(config.config_dir(), unicode)
575
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
576
    def test_config_filename(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
577
        self.assertEqual(config.config_filename(),
578
                         self.bzr_home + '/bazaar.conf')
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
579
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
580
    def test_locations_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
581
        self.assertEqual(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
582
                         self.bzr_home + '/locations.conf')
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
583
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
584
    def test_authentication_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
585
        self.assertEqual(config.authentication_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
586
                         self.bzr_home + '/authentication.conf')
587
4584.3.23 by Martin Pool
Correction to xdg_cache_dir and add a simple test
588
    def test_xdg_cache_dir(self):
589
        self.assertEqual(config.xdg_cache_dir(),
590
            '/home/bogus/.cache')
591
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
592
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
593
class TestXDGConfigDir(tests.TestCaseInTempDir):
594
    # must be in temp dir because config tests for the existence of the bazaar
595
    # subdirectory of $XDG_CONFIG_HOME
596
5519.4.9 by Neil Martinsen-Burrell
working tests
597
    def setUp(self):
6591.2.1 by Fabien Meghazi
Also honor $XDG_CONFIG_HOME specification on Mac OS X platform
598
        if sys.platform == 'win32':
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
599
            raise tests.TestNotApplicable(
600
                'XDG config dir not used on this platform')
5519.4.9 by Neil Martinsen-Burrell
working tests
601
        super(TestXDGConfigDir, self).setUp()
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
602
        self.overrideEnv('HOME', self.test_home_dir)
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
603
        # BZR_HOME overrides everything we want to test so unset it.
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
604
        self.overrideEnv('BZR_HOME', None)
5519.4.9 by Neil Martinsen-Burrell
working tests
605
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
606
    def test_xdg_config_dir_exists(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
607
        """When ~/.config/bazaar exists, use it as the config dir."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
608
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
609
        os.makedirs(newdir)
610
        self.assertEqual(config.config_dir(), newdir)
611
612
    def test_xdg_config_home(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
613
        """When XDG_CONFIG_HOME is set, use it."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
614
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
615
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
616
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
617
        os.makedirs(newdir)
618
        self.assertEqual(config.config_dir(), newdir)
619
620
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
621
class TestIniConfig(tests.TestCaseInTempDir):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
622
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
623
    def make_config_parser(self, s):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
624
        conf = config.IniBasedConfig.from_string(s)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
625
        return conf, conf._get_parser()
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
626
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
627
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
628
class TestIniConfigBuilding(TestIniConfig):
629
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
630
    def test_contructs(self):
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
631
        config.IniBasedConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
632
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
633
    def test_from_fp(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
634
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
635
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
636
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
637
    def test_cached(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
638
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
639
        parser = my_config._get_parser()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
640
        self.assertTrue(my_config._get_parser() is parser)
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
641
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
642
    def _dummy_chown(self, path, uid, gid):
643
        self.path, self.uid, self.gid = path, uid, gid
644
645
    def test_ini_config_ownership(self):
5345.5.8 by Vincent Ladeuil
More doc and ensure that the config is locked when _write_config_file is called.
646
        """Ensure that chown is happening during _write_config_file"""
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
647
        self.requireFeature(features.chown_feature)
648
        self.overrideAttr(os, 'chown', self._dummy_chown)
649
        self.path = self.uid = self.gid = None
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
650
        conf = config.IniBasedConfig(file_name='./foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
651
        conf._write_config_file()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
652
        self.assertEqual(self.path, './foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
653
        self.assertTrue(isinstance(self.uid, int))
654
        self.assertTrue(isinstance(self.gid, int))
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
655
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
656
    def test_get_filename_parameter_is_deprecated_(self):
657
        conf = self.callDeprecated([
658
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
659
            ' Use file_name instead.'],
660
            config.IniBasedConfig, lambda: 'ini.conf')
5345.3.1 by Vincent Ladeuil
Check that _get_filename() is called and produces the desired side effect.
661
        self.assertEqual('ini.conf', conf.file_name)
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
662
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
663
    def test_get_parser_file_parameter_is_deprecated_(self):
664
        config_file = StringIO(sample_config_text.encode('utf-8'))
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
665
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
666
        conf = self.callDeprecated([
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
667
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
668
            ' Use IniBasedConfig(_content=xxx) instead.'],
669
            conf._get_parser, file=config_file)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
670
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
671
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
672
class TestIniConfigSaving(tests.TestCaseInTempDir):
673
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
674
    def test_cant_save_without_a_file_name(self):
675
        conf = config.IniBasedConfig()
676
        self.assertRaises(AssertionError, conf._write_config_file)
677
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
678
    def test_saved_with_content(self):
679
        content = 'foo = bar\n'
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
680
        config.IniBasedConfig.from_string(content, file_name='./test.conf',
681
                                          save=True)
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
682
        self.assertFileEqual(content, 'test.conf')
683
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
684
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
685
class TestIniConfigOptionExpansion(tests.TestCase):
686
    """Test option expansion from the IniConfig level.
687
688
    What we really want here is to test the Config level, but the class being
689
    abstract as far as storing values is concerned, this can't be done
690
    properly (yet).
691
    """
692
    # FIXME: This should be rewritten when all configs share a storage
693
    # implementation -- vila 2011-02-18
694
695
    def get_config(self, string=None):
696
        if string is None:
697
            string = ''
698
        c = config.IniBasedConfig.from_string(string)
699
        return c
700
701
    def assertExpansion(self, expected, conf, string, env=None):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
702
        self.assertEqual(expected, conf.expand_options(string, env))
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
703
704
    def test_no_expansion(self):
705
        c = self.get_config('')
706
        self.assertExpansion('foo', c, 'foo')
707
708
    def test_env_adding_options(self):
709
        c = self.get_config('')
710
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
711
712
    def test_env_overriding_options(self):
713
        c = self.get_config('foo=baz')
714
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
715
716
    def test_simple_ref(self):
717
        c = self.get_config('foo=xxx')
718
        self.assertExpansion('xxx', c, '{foo}')
719
720
    def test_unknown_ref(self):
721
        c = self.get_config('')
722
        self.assertRaises(errors.ExpandingUnknownOption,
723
                          c.expand_options, '{foo}')
724
725
    def test_indirect_ref(self):
726
        c = self.get_config('''
727
foo=xxx
728
bar={foo}
729
''')
730
        self.assertExpansion('xxx', c, '{bar}')
731
732
    def test_embedded_ref(self):
733
        c = self.get_config('''
734
foo=xxx
735
bar=foo
736
''')
737
        self.assertExpansion('xxx', c, '{{bar}}')
738
739
    def test_simple_loop(self):
740
        c = self.get_config('foo={foo}')
741
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
742
743
    def test_indirect_loop(self):
744
        c = self.get_config('''
745
foo={bar}
746
bar={baz}
747
baz={foo}''')
748
        e = self.assertRaises(errors.OptionExpansionLoop,
749
                              c.expand_options, '{foo}')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
750
        self.assertEqual('foo->bar->baz', e.refs)
751
        self.assertEqual('{foo}', e.string)
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
752
753
    def test_list(self):
754
        conf = self.get_config('''
755
foo=start
756
bar=middle
757
baz=end
758
list={foo},{bar},{baz}
759
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
760
        self.assertEqual(['start', 'middle', 'end'],
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
761
                           conf.get_user_option('list', expand=True))
762
763
    def test_cascading_list(self):
764
        conf = self.get_config('''
765
foo=start,{bar}
766
bar=middle,{baz}
767
baz=end
768
list={foo}
769
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
770
        self.assertEqual(['start', 'middle', 'end'],
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
771
                           conf.get_user_option('list', expand=True))
772
773
    def test_pathological_hidden_list(self):
774
        conf = self.get_config('''
775
foo=bin
776
bar=go
777
start={foo
778
middle=},{
779
end=bar}
780
hidden={start}{middle}{end}
781
''')
782
        # Nope, it's either a string or a list, and the list wins as soon as a
783
        # ',' appears, so the string concatenation never occur.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
784
        self.assertEqual(['{foo', '}', '{', 'bar}'],
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
785
                          conf.get_user_option('hidden', expand=True))
786
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
787
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
788
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
789
790
    def get_config(self, location, string=None):
791
        if string is None:
792
            string = ''
793
        # Since we don't save the config we won't strictly require to inherit
794
        # from TestCaseInTempDir, but an error occurs so quickly...
795
        c = config.LocationConfig.from_string(string, location)
796
        return c
797
798
    def test_dont_cross_unrelated_section(self):
799
        c = self.get_config('/another/branch/path','''
800
[/one/branch/path]
801
foo = hello
802
bar = {foo}/2
803
804
[/another/branch/path]
805
bar = {foo}/2
806
''')
807
        self.assertRaises(errors.ExpandingUnknownOption,
808
                          c.get_user_option, 'bar', expand=True)
809
810
    def test_cross_related_sections(self):
811
        c = self.get_config('/project/branch/path','''
812
[/project]
813
foo = qu
814
815
[/project/branch/path]
816
bar = {foo}ux
817
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
818
        self.assertEqual('quux', c.get_user_option('bar', expand=True))
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
819
820
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
821
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
822
823
    def test_cannot_reload_without_name(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
824
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
825
        self.assertRaises(AssertionError, conf.reload)
826
827
    def test_reload_see_new_value(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
828
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
829
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
830
        c1._write_config_file()
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
831
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
832
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
833
        c2._write_config_file()
834
        self.assertEqual('vim', c1.get_user_option('editor'))
835
        self.assertEqual('emacs', c2.get_user_option('editor'))
836
        # Make sure we get the Right value
837
        c1.reload()
838
        self.assertEqual('emacs', c1.get_user_option('editor'))
839
840
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
841
class TestLockableConfig(tests.TestCaseInTempDir):
842
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
843
    scenarios = lockable_config_scenarios()
844
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
845
    # Set by load_tests
846
    config_class = None
847
    config_args = None
848
    config_section = None
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
849
850
    def setUp(self):
851
        super(TestLockableConfig, self).setUp()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
852
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
853
        self.config = self.create_config(self._content)
854
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
855
    def get_existing_config(self):
856
        return self.config_class(*self.config_args)
857
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
858
    def create_config(self, content):
5396.1.1 by Vincent Ladeuil
Fix python-2.6-ism.
859
        kwargs = dict(save=True)
860
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
861
        return c
862
863
    def test_simple_read_access(self):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
864
        self.assertEqual('1', self.config.get_user_option('one'))
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
865
866
    def test_simple_write_access(self):
867
        self.config.set_user_option('one', 'one')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
868
        self.assertEqual('one', self.config.get_user_option('one'))
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
869
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
870
    def test_listen_to_the_last_speaker(self):
871
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
872
        c2 = self.get_existing_config()
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
873
        c1.set_user_option('one', 'ONE')
874
        c2.set_user_option('two', 'TWO')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
875
        self.assertEqual('ONE', c1.get_user_option('one'))
876
        self.assertEqual('TWO', c2.get_user_option('two'))
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
877
        # The second update respect the first one
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
878
        self.assertEqual('ONE', c2.get_user_option('one'))
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
879
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
880
    def test_last_speaker_wins(self):
881
        # If the same config is not shared, the same variable modified twice
882
        # can only see a single result.
883
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
884
        c2 = self.get_existing_config()
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
885
        c1.set_user_option('one', 'c1')
886
        c2.set_user_option('one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
887
        self.assertEqual('c2', c2._get_user_option('one'))
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
888
        # The first modification is still available until another refresh
889
        # occur
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
890
        self.assertEqual('c1', c1._get_user_option('one'))
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
891
        c1.set_user_option('two', 'done')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
892
        self.assertEqual('c2', c1._get_user_option('one'))
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
893
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
894
    def test_writes_are_serialized(self):
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
895
        c1 = self.config
896
        c2 = self.get_existing_config()
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
897
898
        # We spawn a thread that will pause *during* the write
899
        before_writing = threading.Event()
900
        after_writing = threading.Event()
901
        writing_done = threading.Event()
902
        c1_orig = c1._write_config_file
903
        def c1_write_config_file():
904
            before_writing.set()
905
            c1_orig()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
906
            # The lock is held. We wait for the main thread to decide when to
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
907
            # continue
908
            after_writing.wait()
909
        c1._write_config_file = c1_write_config_file
910
        def c1_set_option():
911
            c1.set_user_option('one', 'c1')
912
            writing_done.set()
913
        t1 = threading.Thread(target=c1_set_option)
914
        # Collect the thread after the test
915
        self.addCleanup(t1.join)
916
        # Be ready to unblock the thread if the test goes wrong
917
        self.addCleanup(after_writing.set)
918
        t1.start()
919
        before_writing.wait()
920
        self.assertTrue(c1._lock.is_held)
921
        self.assertRaises(errors.LockContention,
922
                          c2.set_user_option, 'one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
923
        self.assertEqual('c1', c1.get_user_option('one'))
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
924
        # Let the lock be released
925
        after_writing.set()
926
        writing_done.wait()
927
        c2.set_user_option('one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
928
        self.assertEqual('c2', c2.get_user_option('one'))
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
929
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
930
    def test_read_while_writing(self):
931
       c1 = self.config
932
       # We spawn a thread that will pause *during* the write
933
       ready_to_write = threading.Event()
934
       do_writing = threading.Event()
935
       writing_done = threading.Event()
936
       c1_orig = c1._write_config_file
937
       def c1_write_config_file():
938
           ready_to_write.set()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
939
           # The lock is held. We wait for the main thread to decide when to
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
940
           # continue
941
           do_writing.wait()
942
           c1_orig()
943
           writing_done.set()
944
       c1._write_config_file = c1_write_config_file
945
       def c1_set_option():
946
           c1.set_user_option('one', 'c1')
947
       t1 = threading.Thread(target=c1_set_option)
948
       # Collect the thread after the test
949
       self.addCleanup(t1.join)
950
       # Be ready to unblock the thread if the test goes wrong
951
       self.addCleanup(do_writing.set)
952
       t1.start()
953
       # Ensure the thread is ready to write
954
       ready_to_write.wait()
955
       self.assertTrue(c1._lock.is_held)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
956
       self.assertEqual('c1', c1.get_user_option('one'))
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
957
       # If we read during the write, we get the old value
958
       c2 = self.get_existing_config()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
959
       self.assertEqual('1', c2.get_user_option('one'))
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
960
       # Let the writing occur and ensure it occurred
961
       do_writing.set()
962
       writing_done.wait()
963
       # Now we get the updated value
964
       c3 = self.get_existing_config()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
965
       self.assertEqual('c1', c3.get_user_option('one'))
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
966
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
967
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
968
class TestGetUserOptionAs(TestIniConfig):
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
969
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
970
    def test_get_user_option_as_bool(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
971
        conf, parser = self.make_config_parser("""
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
972
a_true_bool = true
973
a_false_bool = 0
974
an_invalid_bool = maybe
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
975
a_list = hmm, who knows ? # This is interpreted as a list !
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
976
""")
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
977
        get_bool = conf.get_user_option_as_bool
978
        self.assertEqual(True, get_bool('a_true_bool'))
979
        self.assertEqual(False, get_bool('a_false_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
980
        warnings = []
981
        def warning(*args):
982
            warnings.append(args[0] % args[1:])
983
        self.overrideAttr(trace, 'warning', warning)
984
        msg = 'Value "%s" is not a boolean for "%s"'
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
985
        self.assertIs(None, get_bool('an_invalid_bool'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
986
        self.assertEqual(msg % ('maybe', 'an_invalid_bool'), warnings[0])
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
987
        warnings = []
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
988
        self.assertIs(None, get_bool('not_defined_in_this_config'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
989
        self.assertEqual([], warnings)
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
990
991
    def test_get_user_option_as_list(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
992
        conf, parser = self.make_config_parser("""
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
993
a_list = a,b,c
994
length_1 = 1,
995
one_item = x
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
996
""")
997
        get_list = conf.get_user_option_as_list
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
998
        self.assertEqual(['a', 'b', 'c'], get_list('a_list'))
999
        self.assertEqual(['1'], get_list('length_1'))
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1000
        self.assertEqual('x', conf.get_user_option('one_item'))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1001
        # automatically cast to list
1002
        self.assertEqual(['x'], get_list('one_item'))
1003
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1004
    def test_get_user_option_as_int_from_SI(self):
1005
        conf, parser = self.make_config_parser("""
1006
plain = 100
1007
si_k = 5k,
1008
si_kb = 5kb,
1009
si_m = 5M,
1010
si_mb = 5MB,
1011
si_g = 5g,
1012
si_gb = 5gB,
1013
""")
6378.1.2 by Vincent Ladeuil
Migrate add.maximum_file_size to the new config scheme
1014
        def get_si(s, default=None):
1015
            return self.applyDeprecated(
1016
                deprecated_in((2, 5, 0)),
1017
                conf.get_user_option_as_int_from_SI, s, default)
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1018
        self.assertEqual(100, get_si('plain'))
1019
        self.assertEqual(5000, get_si('si_k'))
1020
        self.assertEqual(5000, get_si('si_kb'))
1021
        self.assertEqual(5000000, get_si('si_m'))
1022
        self.assertEqual(5000000, get_si('si_mb'))
1023
        self.assertEqual(5000000000, get_si('si_g'))
1024
        self.assertEqual(5000000000, get_si('si_gb'))
1025
        self.assertEqual(None, get_si('non-exist'))
1026
        self.assertEqual(42, get_si('non-exist-with-default',  42))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1027
6378.1.1 by Vincent Ladeuil
Add int_SI_from_store as a config option helper
1028
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1029
class TestSupressWarning(TestIniConfig):
1030
1031
    def make_warnings_config(self, s):
1032
        conf, parser = self.make_config_parser(s)
1033
        return conf.suppress_warning
1034
1035
    def test_suppress_warning_unknown(self):
1036
        suppress_warning = self.make_warnings_config('')
1037
        self.assertEqual(False, suppress_warning('unknown_warning'))
1038
1039
    def test_suppress_warning_known(self):
1040
        suppress_warning = self.make_warnings_config('suppress_warnings=a,b')
1041
        self.assertEqual(False, suppress_warning('c'))
1042
        self.assertEqual(True, suppress_warning('a'))
1043
        self.assertEqual(True, suppress_warning('b'))
1044
1045
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1046
class TestGetConfig(tests.TestCase):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1047
1048
    def test_constructs(self):
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1049
        config.GlobalConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1050
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1051
    def test_calls_read_filenames(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1052
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1053
        oldparserclass = config.ConfigObj
1054
        config.ConfigObj = InstrumentedConfigObj
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1055
        my_config = config.GlobalConfig()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1056
        try:
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1057
            parser = my_config._get_parser()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1058
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1059
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1060
        self.assertIsInstance(parser, InstrumentedConfigObj)
1551.2.20 by Aaron Bentley
Treated config files as utf-8
1061
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
1062
                                          'utf-8')])
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1063
1064
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1065
class TestBranchConfig(tests.TestCaseWithTransport):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1066
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1067
    def test_constructs_valid(self):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1068
        branch = FakeBranch()
1069
        my_config = config.BranchConfig(branch)
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1070
        self.assertIsNot(None, my_config)
1071
1072
    def test_constructs_error(self):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1073
        self.assertRaises(TypeError, config.BranchConfig)
1074
1075
    def test_get_location_config(self):
1076
        branch = FakeBranch()
1077
        my_config = config.BranchConfig(branch)
1078
        location_config = my_config._get_location_config()
1079
        self.assertEqual(branch.base, location_config.location)
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1080
        self.assertIs(location_config, my_config._get_location_config())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1081
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1082
    def test_get_config(self):
1083
        """The Branch.get_config method works properly"""
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
1084
        b = controldir.ControlDir.create_standalone_workingtree('.').branch
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1085
        my_config = b.get_config()
1086
        self.assertIs(my_config.get_user_option('wacky'), None)
1087
        my_config.set_user_option('wacky', 'unlikely')
1088
        self.assertEqual(my_config.get_user_option('wacky'), 'unlikely')
1089
1090
        # Ensure we get the same thing if we start again
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1091
        b2 = branch.Branch.open('.')
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1092
        my_config2 = b2.get_config()
1093
        self.assertEqual(my_config2.get_user_option('wacky'), 'unlikely')
1094
1824.1.1 by Robert Collins
Add BranchConfig.has_explicit_nickname call.
1095
    def test_has_explicit_nickname(self):
1096
        b = self.make_branch('.')
1097
        self.assertFalse(b.get_config().has_explicit_nickname())
1098
        b.nick = 'foo'
1099
        self.assertTrue(b.get_config().has_explicit_nickname())
1100
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1101
    def test_config_url(self):
1102
        """The Branch.get_config will use section that uses a local url"""
1103
        branch = self.make_branch('branch')
1104
        self.assertEqual('branch', branch.nick)
1105
1106
        local_url = urlutils.local_path_to_url('branch')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1107
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1108
            '[%s]\nnickname = foobar' % (local_url,),
1109
            local_url, save=True)
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1110
        self.assertIsNot(None, conf)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1111
        self.assertEqual('foobar', branch.nick)
1112
1113
    def test_config_local_path(self):
1114
        """The Branch.get_config will use a local system path"""
1115
        branch = self.make_branch('branch')
1116
        self.assertEqual('branch', branch.nick)
1117
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1118
        local_path = osutils.getcwd().encode('utf8')
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1119
        config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1120
            '[%s/branch]\nnickname = barry' % (local_path,),
1121
            'branch',  save=True)
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1122
        # Now the branch will find its nick via the location config
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1123
        self.assertEqual('barry', branch.nick)
1124
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1125
    def test_config_creates_local(self):
1126
        """Creating a new entry in config uses a local path."""
2230.3.6 by Aaron Bentley
work in progress bind stuff
1127
        branch = self.make_branch('branch', format='knit')
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1128
        branch.set_push_location('http://foobar')
1129
        local_path = osutils.getcwd().encode('utf8')
1130
        # Surprisingly ConfigObj doesn't create a trailing newline
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1131
        self.check_file_contents(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1132
                                 '[%s/branch]\n'
1133
                                 'push_location = http://foobar\n'
3221.7.1 by Matt Nordhoff
Upgrade ConfigObj to version 4.5.1.
1134
                                 'push_location:policy = norecurse\n'
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1135
                                 % (local_path,))
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1136
2120.5.4 by Alexander Belchenko
Whitebox test for Config.get_nickname (req. by Aaron Bentley)
1137
    def test_autonick_urlencoded(self):
1138
        b = self.make_branch('!repo')
1139
        self.assertEqual('!repo', b.get_config().get_nickname())
1140
6437.32.1 by Aaron Bentley
Use colocated branch names as nicknames.
1141
    def test_autonick_uses_branch_name(self):
1142
        b = self.make_branch('foo', name='bar')
1143
        self.assertEqual('bar', b.get_config().get_nickname())
1144
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1145
    def test_warn_if_masked(self):
1146
        warnings = []
1147
        def warning(*args):
1148
            warnings.append(args[0] % args[1:])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1149
        self.overrideAttr(trace, 'warning', warning)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1150
1151
        def set_option(store, warn_masked=True):
1152
            warnings[:] = []
1153
            conf.set_user_option('example_option', repr(store), store=store,
1154
                                 warn_masked=warn_masked)
1155
        def assertWarning(warning):
1156
            if warning is None:
1157
                self.assertEqual(0, len(warnings))
1158
            else:
1159
                self.assertEqual(1, len(warnings))
1160
                self.assertEqual(warning, warnings[0])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1161
        branch = self.make_branch('.')
1162
        conf = branch.get_config()
1163
        set_option(config.STORE_GLOBAL)
1164
        assertWarning(None)
1165
        set_option(config.STORE_BRANCH)
1166
        assertWarning(None)
1167
        set_option(config.STORE_GLOBAL)
1168
        assertWarning('Value "4" is masked by "3" from branch.conf')
1169
        set_option(config.STORE_GLOBAL, warn_masked=False)
1170
        assertWarning(None)
1171
        set_option(config.STORE_LOCATION)
1172
        assertWarning(None)
1173
        set_option(config.STORE_BRANCH)
1174
        assertWarning('Value "3" is masked by "0" from locations.conf')
1175
        set_option(config.STORE_BRANCH, warn_masked=False)
1176
        assertWarning(None)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1177
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1178
5448.1.1 by Vincent Ladeuil
Use TestCaseInTempDir for tests requiring disk resources
1179
class TestGlobalConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1180
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1181
    def test_user_id(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1182
        my_config = config.GlobalConfig.from_string(sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1183
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1184
                         my_config._get_user_id())
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1185
1186
    def test_absent_user_id(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1187
        my_config = config.GlobalConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1188
        self.assertEqual(None, my_config._get_user_id())
1189
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1190
    def test_signatures_always(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1191
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1192
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1193
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1194
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1195
        self.assertEqual(config.SIGN_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1196
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1197
                             my_config.signing_policy))
1198
        self.assertEqual(True,
1199
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1200
                my_config.signature_needed))
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1201
1202
    def test_signatures_if_possible(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1203
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1204
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1205
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1206
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1207
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1208
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1209
                             my_config.signing_policy))
1210
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1211
            my_config.signature_needed))
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1212
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1213
    def test_signatures_ignore(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1214
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1215
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1216
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1217
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1218
        self.assertEqual(config.SIGN_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1219
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1220
                             my_config.signing_policy))
1221
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1222
            my_config.signature_needed))
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1223
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1224
    def _get_sample_config(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1225
        my_config = config.GlobalConfig.from_string(sample_config_text)
1534.7.154 by Aaron Bentley
Removed changes from bzr.ab 1529..1536
1226
        return my_config
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1227
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1228
    def test_gpg_signing_command(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1229
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1230
        self.assertEqual("gnome-gpg",
1231
            self.applyDeprecated(
1232
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
1233
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1234
            my_config.signature_needed))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1235
6012.2.3 by Jonathan Riddell
add config option for signing key
1236
    def test_gpg_signing_key(self):
1237
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1238
        self.assertEqual("DD4D5088",
1239
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1240
                my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1241
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1242
    def _get_empty_config(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1243
        my_config = config.GlobalConfig()
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1244
        return my_config
1245
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1246
    def test_gpg_signing_command_unset(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1247
        my_config = self._get_empty_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1248
        self.assertEqual("gpg",
1249
            self.applyDeprecated(
1250
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1251
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1252
    def test_get_user_option_default(self):
1253
        my_config = self._get_empty_config()
1254
        self.assertEqual(None, my_config.get_user_option('no_option'))
1255
1256
    def test_get_user_option_global(self):
1257
        my_config = self._get_sample_config()
1258
        self.assertEqual("something",
1259
                         my_config.get_user_option('user_global_option'))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1260
1472 by Robert Collins
post commit hook, first pass implementation
1261
    def test_post_commit_default(self):
1262
        my_config = self._get_sample_config()
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1263
        self.assertEqual(None,
1264
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1265
                                              my_config.post_commit))
1472 by Robert Collins
post commit hook, first pass implementation
1266
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
1267
    def test_configured_logformat(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1268
        my_config = self._get_sample_config()
6378.1.3 by Vincent Ladeuil
log_format has been migrated but the old config method needs to be deprecated.
1269
        self.assertEqual("short",
1270
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1271
                                              my_config.log_format))
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1272
5971.1.58 by Jonathan Riddell
more tests for new config options
1273
    def test_configured_acceptable_keys(self):
1274
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1275
        self.assertEqual("amy",
1276
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1277
                my_config.acceptable_keys))
5971.1.58 by Jonathan Riddell
more tests for new config options
1278
1279
    def test_configured_validate_signatures_in_log(self):
1280
        my_config = self._get_sample_config()
1281
        self.assertEqual(True, my_config.validate_signatures_in_log())
1282
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1283
    def test_get_alias(self):
1284
        my_config = self._get_sample_config()
1285
        self.assertEqual('help', my_config.get_alias('h'))
1286
2900.3.6 by Tim Penhey
Added tests.
1287
    def test_get_aliases(self):
1288
        my_config = self._get_sample_config()
1289
        aliases = my_config.get_aliases()
1290
        self.assertEqual(2, len(aliases))
1291
        sorted_keys = sorted(aliases)
1292
        self.assertEqual('help', aliases[sorted_keys[0]])
1293
        self.assertEqual(sample_long_alias, aliases[sorted_keys[1]])
1294
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1295
    def test_get_no_alias(self):
1296
        my_config = self._get_sample_config()
1297
        self.assertEqual(None, my_config.get_alias('foo'))
1298
1299
    def test_get_long_alias(self):
1300
        my_config = self._get_sample_config()
1301
        self.assertEqual(sample_long_alias, my_config.get_alias('ll'))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1302
4603.1.10 by Aaron Bentley
Provide change editor via config.
1303
    def test_get_change_editor(self):
1304
        my_config = self._get_sample_config()
1305
        change_editor = my_config.get_change_editor('old', 'new')
1306
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
1307
        self.assertEqual('vimdiff -of @new_path @old_path',
4603.1.10 by Aaron Bentley
Provide change editor via config.
1308
                         ' '.join(change_editor.command_template))
1309
1310
    def test_get_no_change_editor(self):
1311
        my_config = self._get_empty_config()
1312
        change_editor = my_config.get_change_editor('old', 'new')
1313
        self.assertIs(None, change_editor)
1314
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1315
    def test_get_merge_tools(self):
1316
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1317
        tools = conf.get_merge_tools()
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1318
        self.log(repr(tools))
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1319
        self.assertEqual(
1320
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
1321
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
1322
            u'newtool' : u'"newtool with spaces" {this_temp}'},
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1323
            tools)
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1324
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1325
    def test_get_merge_tools_empty(self):
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1326
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1327
        tools = conf.get_merge_tools()
1328
        self.assertEqual({}, tools)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1329
1330
    def test_find_merge_tool(self):
1331
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1332
        cmdline = conf.find_merge_tool('sometool')
1333
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1334
1335
    def test_find_merge_tool_not_found(self):
1336
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1337
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
1338
        self.assertIs(cmdline, None)
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1339
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1340
    def test_find_merge_tool_known(self):
1341
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1342
        cmdline = conf.find_merge_tool('kdiff3')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
1343
        self.assertEqual('kdiff3 {base} {this} {other} -o {result}', cmdline)
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
1344
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1345
    def test_find_merge_tool_override_known(self):
1346
        conf = self._get_empty_config()
5321.1.112 by Gordon Tyler
Removed set_merge_tool, remove_merge_tool and set_default_merge_tool from Config.
1347
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1348
        cmdline = conf.find_merge_tool('kdiff3')
1349
        self.assertEqual('kdiff3 blah', cmdline)
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1350
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1351
2900.3.6 by Tim Penhey
Added tests.
1352
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
1353
1354
    def test_empty(self):
1355
        my_config = config.GlobalConfig()
1356
        self.assertEqual(0, len(my_config.get_aliases()))
1357
1358
    def test_set_alias(self):
1359
        my_config = config.GlobalConfig()
1360
        alias_value = 'commit --strict'
1361
        my_config.set_alias('commit', alias_value)
1362
        new_config = config.GlobalConfig()
1363
        self.assertEqual(alias_value, new_config.get_alias('commit'))
1364
1365
    def test_remove_alias(self):
1366
        my_config = config.GlobalConfig()
1367
        my_config.set_alias('commit', 'commit --strict')
1368
        # Now remove the alias again.
1369
        my_config.unset_alias('commit')
1370
        new_config = config.GlobalConfig()
1371
        self.assertIs(None, new_config.get_alias('commit'))
1372
1373
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1374
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1375
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1376
    def test_constructs_valid(self):
1377
        config.LocationConfig('http://example.com')
1378
1379
    def test_constructs_error(self):
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1380
        self.assertRaises(TypeError, config.LocationConfig)
1381
1382
    def test_branch_calls_read_filenames(self):
1474 by Robert Collins
Merge from Aaron Bentley.
1383
        # This is testing the correct file names are provided.
1384
        # TODO: consolidate with the test for GlobalConfigs filename checks.
1385
        #
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1386
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1387
        oldparserclass = config.ConfigObj
1388
        config.ConfigObj = InstrumentedConfigObj
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1389
        try:
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1390
            my_config = config.LocationConfig('http://www.example.com')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1391
            parser = my_config._get_parser()
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1392
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1393
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1394
        self.assertIsInstance(parser, InstrumentedConfigObj)
1474 by Robert Collins
Merge from Aaron Bentley.
1395
        self.assertEqual(parser._calls,
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1396
                         [('__init__', config.locations_config_filename(),
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1397
                           'utf-8')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1398
1399
    def test_get_global_config(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1400
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1401
        global_config = my_config._get_global_config()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1402
        self.assertIsInstance(global_config, config.GlobalConfig)
1403
        self.assertIs(global_config, my_config._get_global_config())
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1404
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1405
    def assertLocationMatching(self, expected):
1406
        self.assertEqual(expected,
1407
                         list(self.my_location_config._get_matching_sections()))
1408
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1409
    def test__get_matching_sections_no_match(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1410
        self.get_branch_config('/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1411
        self.assertLocationMatching([])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1412
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1413
    def test__get_matching_sections_exact(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1414
        self.get_branch_config('http://www.example.com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1415
        self.assertLocationMatching([('http://www.example.com', '')])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1416
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1417
    def test__get_matching_sections_suffix_does_not(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1418
        self.get_branch_config('http://www.example.com-com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1419
        self.assertLocationMatching([])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1420
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1421
    def test__get_matching_sections_subdir_recursive(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1422
        self.get_branch_config('http://www.example.com/com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1423
        self.assertLocationMatching([('http://www.example.com', 'com')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1424
1993.3.5 by James Henstridge
add back recurse=False option to config file
1425
    def test__get_matching_sections_ignoreparent(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1426
        self.get_branch_config('http://www.example.com/ignoreparent')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1427
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1428
                                      '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1429
1993.3.5 by James Henstridge
add back recurse=False option to config file
1430
    def test__get_matching_sections_ignoreparent_subdir(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1431
        self.get_branch_config(
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1432
            'http://www.example.com/ignoreparent/childbranch')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1433
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1434
                                      'childbranch')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1435
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1436
    def test__get_matching_sections_subdir_trailing_slash(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1437
        self.get_branch_config('/b')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1438
        self.assertLocationMatching([('/b/', '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1439
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1440
    def test__get_matching_sections_subdir_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1441
        self.get_branch_config('/a/foo')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1442
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1443
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1444
    def test__get_matching_sections_subdir_child_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1445
        self.get_branch_config('/a/foo/bar')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1446
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1447
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1448
    def test__get_matching_sections_trailing_slash_with_children(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1449
        self.get_branch_config('/a/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1450
        self.assertLocationMatching([('/a/', '')])
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1451
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1452
    def test__get_matching_sections_explicit_over_glob(self):
1453
        # XXX: 2006-09-08 jamesh
1454
        # This test only passes because ord('c') > ord('*').  If there
1455
        # was a config section for '/a/?', it would get precedence
1456
        # over '/a/c'.
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1457
        self.get_branch_config('/a/c')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1458
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1459
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1460
    def test__get_option_policy_normal(self):
1461
        self.get_branch_config('http://www.example.com')
1462
        self.assertEqual(
1463
            self.my_location_config._get_config_policy(
1464
            'http://www.example.com', 'normal_option'),
1465
            config.POLICY_NONE)
1466
1467
    def test__get_option_policy_norecurse(self):
1468
        self.get_branch_config('http://www.example.com')
1469
        self.assertEqual(
1470
            self.my_location_config._get_option_policy(
1471
            'http://www.example.com', 'norecurse_option'),
1472
            config.POLICY_NORECURSE)
1473
        # Test old recurse=False setting:
1474
        self.assertEqual(
1475
            self.my_location_config._get_option_policy(
1476
            'http://www.example.com/norecurse', 'normal_option'),
1477
            config.POLICY_NORECURSE)
1478
1479
    def test__get_option_policy_normal(self):
1480
        self.get_branch_config('http://www.example.com')
1481
        self.assertEqual(
1482
            self.my_location_config._get_option_policy(
1483
            'http://www.example.com', 'appendpath_option'),
1484
            config.POLICY_APPENDPATH)
1485
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1486
    def test__get_options_with_policy(self):
1487
        self.get_branch_config('/dir/subdir',
1488
                               location_config="""\
1489
[/dir]
1490
other_url = /other-dir
1491
other_url:policy = appendpath
1492
[/dir/subdir]
1493
other_url = /other-subdir
1494
""")
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1495
        self.assertOptions(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1496
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
1497
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
1498
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1499
            self.my_location_config)
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1500
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1501
    def test_location_without_username(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1502
        self.get_branch_config('http://www.example.com/ignoreparent')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1503
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1504
                         self.my_config.username())
1505
1506
    def test_location_not_listed(self):
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1507
        """Test that the global username is used when no location matches"""
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1508
        self.get_branch_config('/home/robertc/sources')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1509
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1510
                         self.my_config.username())
1511
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1512
    def test_overriding_location(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1513
        self.get_branch_config('http://www.example.com/foo')
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1514
        self.assertEqual('Robert Collins <robertc@example.org>',
1515
                         self.my_config.username())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1516
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1517
    def test_signatures_not_set(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1518
        self.get_branch_config('http://www.example.com',
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1519
                                 global_config=sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1520
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1521
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1522
                             self.my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1523
        self.assertEqual(config.SIGN_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1524
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1525
                             self.my_config.signing_policy))
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1526
1527
    def test_signatures_never(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1528
        self.get_branch_config('/a/c')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1529
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1530
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1531
                             self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1532
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1533
    def test_signatures_when_available(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1534
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1535
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1536
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1537
                             self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1538
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1539
    def test_signatures_always(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1540
        self.get_branch_config('/b')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1541
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1542
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1543
                         self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1544
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1545
    def test_gpg_signing_command(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1546
        self.get_branch_config('/b')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1547
        self.assertEqual("gnome-gpg",
1548
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1549
                self.my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1550
1551
    def test_gpg_signing_command_missing(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1552
        self.get_branch_config('/a')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1553
        self.assertEqual("false",
1554
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1555
                self.my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1556
6012.2.3 by Jonathan Riddell
add config option for signing key
1557
    def test_gpg_signing_key(self):
1558
        self.get_branch_config('/b')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1559
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
1560
            self.my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1561
6012.2.9 by Jonathan Riddell
fixes 68501
1562
    def test_gpg_signing_key_default(self):
6012.2.3 by Jonathan Riddell
add config option for signing key
1563
        self.get_branch_config('/a')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1564
        self.assertEqual("erik@bagfors.nu",
1565
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1566
                self.my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1567
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1568
    def test_get_user_option_global(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1569
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1570
        self.assertEqual('something',
1571
                         self.my_config.get_user_option('user_global_option'))
1572
1573
    def test_get_user_option_local(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1574
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1575
        self.assertEqual('local',
1576
                         self.my_config.get_user_option('user_local_option'))
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1577
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1578
    def test_get_user_option_appendpath(self):
1579
        # returned as is for the base path:
1580
        self.get_branch_config('http://www.example.com')
1581
        self.assertEqual('append',
1582
                         self.my_config.get_user_option('appendpath_option'))
1583
        # Extra path components get appended:
1584
        self.get_branch_config('http://www.example.com/a/b/c')
1585
        self.assertEqual('append/a/b/c',
1586
                         self.my_config.get_user_option('appendpath_option'))
1587
        # Overriden for http://www.example.com/dir, where it is a
1588
        # normal option:
1589
        self.get_branch_config('http://www.example.com/dir/a/b/c')
1590
        self.assertEqual('normal',
1591
                         self.my_config.get_user_option('appendpath_option'))
1592
1593
    def test_get_user_option_norecurse(self):
1594
        self.get_branch_config('http://www.example.com')
1595
        self.assertEqual('norecurse',
1596
                         self.my_config.get_user_option('norecurse_option'))
1597
        self.get_branch_config('http://www.example.com/dir')
1598
        self.assertEqual(None,
1599
                         self.my_config.get_user_option('norecurse_option'))
1600
        # http://www.example.com/norecurse is a recurse=False section
1601
        # that redefines normal_option.  Subdirectories do not pick up
1602
        # this redefinition.
1603
        self.get_branch_config('http://www.example.com/norecurse')
1604
        self.assertEqual('norecurse',
1605
                         self.my_config.get_user_option('normal_option'))
1606
        self.get_branch_config('http://www.example.com/norecurse/subdir')
1607
        self.assertEqual('normal',
1608
                         self.my_config.get_user_option('normal_option'))
1609
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1610
    def test_set_user_option_norecurse(self):
1611
        self.get_branch_config('http://www.example.com')
1612
        self.my_config.set_user_option('foo', 'bar',
1613
                                       store=config.STORE_LOCATION_NORECURSE)
1614
        self.assertEqual(
1615
            self.my_location_config._get_option_policy(
1616
            'http://www.example.com', 'foo'),
1617
            config.POLICY_NORECURSE)
1618
1619
    def test_set_user_option_appendpath(self):
1620
        self.get_branch_config('http://www.example.com')
1621
        self.my_config.set_user_option('foo', 'bar',
1622
                                       store=config.STORE_LOCATION_APPENDPATH)
1623
        self.assertEqual(
1624
            self.my_location_config._get_option_policy(
1625
            'http://www.example.com', 'foo'),
1626
            config.POLICY_APPENDPATH)
1627
1628
    def test_set_user_option_change_policy(self):
1629
        self.get_branch_config('http://www.example.com')
1630
        self.my_config.set_user_option('norecurse_option', 'normal',
1631
                                       store=config.STORE_LOCATION)
1632
        self.assertEqual(
1633
            self.my_location_config._get_option_policy(
1634
            'http://www.example.com', 'norecurse_option'),
1635
            config.POLICY_NONE)
1636
1637
    def test_set_user_option_recurse_false_section(self):
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1638
        # The following section has recurse=False set.  The test is to
1639
        # make sure that a normal option can be added to the section,
1640
        # converting recurse=False to the norecurse policy.
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1641
        self.get_branch_config('http://www.example.com/norecurse')
2120.6.11 by James Henstridge
s/0.13/0.14/ in deprecation warning
1642
        self.callDeprecated(['The recurse option is deprecated as of 0.14.  '
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1643
                             'The section "http://www.example.com/norecurse" '
1644
                             'has been converted to use policies.'],
1645
                            self.my_config.set_user_option,
1646
                            'foo', 'bar', store=config.STORE_LOCATION)
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1647
        self.assertEqual(
1648
            self.my_location_config._get_option_policy(
1649
            'http://www.example.com/norecurse', 'foo'),
1650
            config.POLICY_NONE)
1651
        # The previously existing option is still norecurse:
1652
        self.assertEqual(
1653
            self.my_location_config._get_option_policy(
1654
            'http://www.example.com/norecurse', 'normal_option'),
1655
            config.POLICY_NORECURSE)
1656
1472 by Robert Collins
post commit hook, first pass implementation
1657
    def test_post_commit_default(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1658
        self.get_branch_config('/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1659
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1660
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1661
                                              self.my_config.post_commit))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1662
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1663
    def get_branch_config(self, location, global_config=None,
1664
                          location_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1665
        my_branch = FakeBranch(location)
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1666
        if global_config is None:
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1667
            global_config = sample_config_text
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1668
        if location_config is None:
1669
            location_config = sample_branches_text
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1670
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1671
        config.GlobalConfig.from_string(global_config, save=True)
1672
        config.LocationConfig.from_string(location_config, my_branch.base,
1673
                                          save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1674
        my_config = config.BranchConfig(my_branch)
1675
        self.my_config = my_config
1676
        self.my_location_config = my_config._get_location_config()
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1677
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1678
    def test_set_user_setting_sets_and_saves(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1679
        self.get_branch_config('/a/c')
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1680
        record = InstrumentedConfigObj("foo")
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1681
        self.my_location_config._parser = record
1185.62.6 by John Arbash Meinel
Updated test_set_user_setting_sets_and_saves to remove the print statement, and make sure it is doing the right thing
1682
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1683
        self.callDeprecated(['The recurse option is deprecated as of '
1684
                             '0.14.  The section "/a/c" has been '
1685
                             'converted to use policies.'],
1686
                            self.my_config.set_user_option,
1687
                            'foo', 'bar', store=config.STORE_LOCATION)
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
1688
        self.assertEqual([('reload',),
1689
                          ('__contains__', '/a/c'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1690
                          ('__contains__', '/a/c/'),
1691
                          ('__setitem__', '/a/c', {}),
1692
                          ('__getitem__', '/a/c'),
1693
                          ('__setitem__', 'foo', 'bar'),
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1694
                          ('__getitem__', '/a/c'),
1695
                          ('as_bool', 'recurse'),
1696
                          ('__getitem__', '/a/c'),
1697
                          ('__delitem__', 'recurse'),
1698
                          ('__getitem__', '/a/c'),
1699
                          ('keys',),
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
1700
                          ('__getitem__', '/a/c'),
1701
                          ('__contains__', 'foo:policy'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1702
                          ('write',)],
1703
                         record._calls[1:])
1704
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1705
    def test_set_user_setting_sets_and_saves2(self):
1706
        self.get_branch_config('/a/c')
1707
        self.assertIs(self.my_config.get_user_option('foo'), None)
1708
        self.my_config.set_user_option('foo', 'bar')
1709
        self.assertEqual(
3616.2.6 by Mark Hammond
Fix test_set_user_setting_sets_and_saves2 on windows by stripping EOL
1710
            self.my_config.branch.control_files.files['branch.conf'].strip(),
1711
            'foo = bar')
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1712
        self.assertEqual(self.my_config.get_user_option('foo'), 'bar')
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1713
        self.my_config.set_user_option('foo', 'baz',
1714
                                       store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1715
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
1716
        self.my_config.set_user_option('foo', 'qux')
1717
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1718
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1719
    def test_get_bzr_remote_path(self):
1720
        my_config = config.LocationConfig('/a/c')
1721
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1722
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1723
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1724
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1725
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1726
1185.62.7 by John Arbash Meinel
Whitespace cleanup.
1727
1770.2.8 by Aaron Bentley
Add precedence test
1728
precedence_global = 'option = global'
1729
precedence_branch = 'option = branch'
1730
precedence_location = """
1731
[http://]
1732
recurse = true
1733
option = recurse
1734
[http://example.com/specific]
1735
option = exact
1736
"""
1737
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1738
class TestBranchConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1739
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1740
    def get_branch_config(self, global_config=None, location=None,
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1741
                          location_config=None, branch_data_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1742
        my_branch = FakeBranch(location)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1743
        if global_config is not None:
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1744
            config.GlobalConfig.from_string(global_config, save=True)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1745
        if location_config is not None:
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
1746
            config.LocationConfig.from_string(location_config, my_branch.base,
1747
                                              save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1748
        my_config = config.BranchConfig(my_branch)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1749
        if branch_data_config is not None:
1750
            my_config.branch.control_files.files['branch.conf'] = \
1751
                branch_data_config
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1752
        return my_config
1753
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1754
    def test_user_id(self):
6362.1.4 by Jelmer Vernooij
Fix tests.
1755
        branch = FakeBranch()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1756
        my_config = config.BranchConfig(branch)
6362.1.4 by Jelmer Vernooij
Fix tests.
1757
        self.assertIsNot(None, my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1758
        my_config.branch.control_files.files['email'] = "John"
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1759
        my_config.set_user_option('email',
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1760
                                  "Robert Collins <robertc@example.org>")
1761
        self.assertEqual("Robert Collins <robertc@example.org>",
6362.1.4 by Jelmer Vernooij
Fix tests.
1762
                        my_config.username())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1763
1861.4.1 by Matthieu Moy
BZREMAIL renamed to BZR_EMAIL.
1764
    def test_BZR_EMAIL_OVERRIDES(self):
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1765
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1766
        branch = FakeBranch()
1767
        my_config = config.BranchConfig(branch)
1768
        self.assertEqual("Robert Collins <robertc@example.org>",
1769
                         my_config.username())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1770
1442.1.19 by Robert Collins
BranchConfigs inherit signature_checking policy from their LocationConfig.
1771
    def test_signatures_forced(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1772
        my_config = self.get_branch_config(
1773
            global_config=sample_always_signatures)
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1774
        self.assertEqual(config.CHECK_NEVER,
1775
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1776
                my_config.signature_checking))
1777
        self.assertEqual(config.SIGN_ALWAYS,
1778
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1779
                my_config.signing_policy))
1780
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
1781
            my_config.signature_needed))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1782
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1783
    def test_signatures_forced_branch(self):
1784
        my_config = self.get_branch_config(
1785
            global_config=sample_ignore_signatures,
1786
            branch_data_config=sample_always_signatures)
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1787
        self.assertEqual(config.CHECK_NEVER,
1788
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1789
                my_config.signature_checking))
1790
        self.assertEqual(config.SIGN_ALWAYS,
1791
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1792
                my_config.signing_policy))
1793
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
1794
            my_config.signature_needed))
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1795
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1796
    def test_gpg_signing_command(self):
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1797
        my_config = self.get_branch_config(
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1798
            global_config=sample_config_text,
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1799
            # branch data cannot set gpg_signing_command
1800
            branch_data_config="gpg_signing_command=pgp")
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1801
        self.assertEqual('gnome-gpg',
1802
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1803
                my_config.gpg_signing_command))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1804
1805
    def test_get_user_option_global(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1806
        my_config = self.get_branch_config(global_config=sample_config_text)
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1807
        self.assertEqual('something',
1808
                         my_config.get_user_option('user_global_option'))
1472 by Robert Collins
post commit hook, first pass implementation
1809
1810
    def test_post_commit_default(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1811
        my_config = self.get_branch_config(global_config=sample_config_text,
1812
                                      location='/a/c',
1813
                                      location_config=sample_branches_text)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1814
        self.assertEqual(my_config.branch.base, '/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1815
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1816
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1817
                                              my_config.post_commit))
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1818
        my_config.set_user_option('post_commit', 'rmtree_root')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1819
        # post-commit is ignored when present in branch data
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1820
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1821
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1822
                                              my_config.post_commit))
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1823
        my_config.set_user_option('post_commit', 'rmtree_root',
1824
                                  store=config.STORE_LOCATION)
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1825
        self.assertEqual('rmtree_root',
1826
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1827
                                              my_config.post_commit))
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1828
1770.2.8 by Aaron Bentley
Add precedence test
1829
    def test_config_precedence(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1830
        # FIXME: eager test, luckily no persitent config file makes it fail
1831
        # -- vila 20100716
1770.2.8 by Aaron Bentley
Add precedence test
1832
        my_config = self.get_branch_config(global_config=precedence_global)
1833
        self.assertEqual(my_config.get_user_option('option'), 'global')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1834
        my_config = self.get_branch_config(global_config=precedence_global,
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1835
                                           branch_data_config=precedence_branch)
1770.2.8 by Aaron Bentley
Add precedence test
1836
        self.assertEqual(my_config.get_user_option('option'), 'branch')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1837
        my_config = self.get_branch_config(
1838
            global_config=precedence_global,
1839
            branch_data_config=precedence_branch,
1840
            location_config=precedence_location)
1770.2.8 by Aaron Bentley
Add precedence test
1841
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1842
        my_config = self.get_branch_config(
1843
            global_config=precedence_global,
1844
            branch_data_config=precedence_branch,
1845
            location_config=precedence_location,
1846
            location='http://example.com/specific')
1770.2.8 by Aaron Bentley
Add precedence test
1847
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1848
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1849
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1850
class TestMailAddressExtraction(tests.TestCase):
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1851
1852
    def test_extract_email_address(self):
1853
        self.assertEqual('jane@test.com',
1854
                         config.extract_email_address('Jane <jane@test.com>'))
2055.2.2 by John Arbash Meinel
Switch extract_email_address() to use a more specific exception
1855
        self.assertRaises(errors.NoEmailInUsername,
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1856
                          config.extract_email_address, 'Jane Tester')
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1857
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1858
    def test_parse_username(self):
1859
        self.assertEqual(('', 'jdoe@example.com'),
1860
                         config.parse_username('jdoe@example.com'))
1861
        self.assertEqual(('', 'jdoe@example.com'),
1862
                         config.parse_username('<jdoe@example.com>'))
1863
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1864
                         config.parse_username('John Doe <jdoe@example.com>'))
1865
        self.assertEqual(('John Doe', ''),
1866
                         config.parse_username('John Doe'))
3063.3.3 by Lukáš Lalinský
Add one more test for config.parse_username().
1867
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1868
                         config.parse_username('John Doe jdoe@example.com'))
2562.1.2 by John Arbash Meinel
Clean up whitespace
1869
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1870
class TestTreeConfig(tests.TestCaseWithTransport):
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1871
1872
    def test_get_value(self):
1873
        """Test that retreiving a value from a section is possible"""
1874
        branch = self.make_branch('.')
1875
        tree_config = config.TreeConfig(branch)
1876
        tree_config.set_option('value', 'key', 'SECTION')
1877
        tree_config.set_option('value2', 'key2')
1878
        tree_config.set_option('value3-top', 'key3')
1879
        tree_config.set_option('value3-section', 'key3', 'SECTION')
1880
        value = tree_config.get_option('key', 'SECTION')
1881
        self.assertEqual(value, 'value')
1882
        value = tree_config.get_option('key2')
1883
        self.assertEqual(value, 'value2')
1884
        self.assertEqual(tree_config.get_option('non-existant'), None)
1885
        value = tree_config.get_option('non-existant', 'SECTION')
1886
        self.assertEqual(value, None)
1887
        value = tree_config.get_option('non-existant', default='default')
1888
        self.assertEqual(value, 'default')
1889
        self.assertEqual(tree_config.get_option('key2', 'NOSECTION'), None)
1890
        value = tree_config.get_option('key2', 'NOSECTION', default='default')
1891
        self.assertEqual(value, 'default')
1892
        value = tree_config.get_option('key3')
1893
        self.assertEqual(value, 'value3-top')
1894
        value = tree_config.get_option('key3', 'SECTION')
1895
        self.assertEqual(value, 'value3-section')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
1896
1897
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1898
class TestTransportConfig(tests.TestCaseWithTransport):
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1899
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1900
    def test_load_utf8(self):
1901
        """Ensure we can load an utf8-encoded file."""
1902
        t = self.get_transport()
1903
        unicode_user = u'b\N{Euro Sign}ar'
1904
        unicode_content = u'user=%s' % (unicode_user,)
1905
        utf8_content = unicode_content.encode('utf8')
1906
        # Store the raw content in the config file
1907
        t.put_bytes('foo.conf', utf8_content)
1908
        conf = config.TransportConfig(t, 'foo.conf')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
1909
        self.assertEqual(unicode_user, conf.get_option('user'))
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1910
1911
    def test_load_non_ascii(self):
1912
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
1913
        t = self.get_transport()
1914
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
1915
        conf = config.TransportConfig(t, 'foo.conf')
1916
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
1917
1918
    def test_load_erroneous_content(self):
1919
        """Ensure we display a proper error on content that can't be parsed."""
1920
        t = self.get_transport()
1921
        t.put_bytes('foo.conf', '[open_section\n')
1922
        conf = config.TransportConfig(t, 'foo.conf')
1923
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
1924
6110.5.1 by Jelmer Vernooij
Warn when a configuration file can not be opened.
1925
    def test_load_permission_denied(self):
1926
        """Ensure we get an empty config file if the file is inaccessible."""
1927
        warnings = []
1928
        def warning(*args):
1929
            warnings.append(args[0] % args[1:])
1930
        self.overrideAttr(trace, 'warning', warning)
1931
1932
        class DenyingTransport(object):
1933
1934
            def __init__(self, base):
1935
                self.base = base
1936
1937
            def get_bytes(self, relpath):
1938
                raise errors.PermissionDenied(relpath, "")
1939
1940
        cfg = config.TransportConfig(
1941
            DenyingTransport("nonexisting://"), 'control.conf')
1942
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
1943
        self.assertEqual(
6110.5.1 by Jelmer Vernooij
Warn when a configuration file can not be opened.
1944
            warnings,
1945
            [u'Permission denied while trying to open configuration file '
1946
             u'nonexisting:///control.conf.'])
1947
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1948
    def test_get_value(self):
1949
        """Test that retreiving a value from a section is possible"""
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1950
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1951
                                               'control.conf')
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1952
        bzrdir_config.set_option('value', 'key', 'SECTION')
1953
        bzrdir_config.set_option('value2', 'key2')
1954
        bzrdir_config.set_option('value3-top', 'key3')
1955
        bzrdir_config.set_option('value3-section', 'key3', 'SECTION')
1956
        value = bzrdir_config.get_option('key', 'SECTION')
1957
        self.assertEqual(value, 'value')
1958
        value = bzrdir_config.get_option('key2')
1959
        self.assertEqual(value, 'value2')
1960
        self.assertEqual(bzrdir_config.get_option('non-existant'), None)
1961
        value = bzrdir_config.get_option('non-existant', 'SECTION')
1962
        self.assertEqual(value, None)
1963
        value = bzrdir_config.get_option('non-existant', default='default')
1964
        self.assertEqual(value, 'default')
1965
        self.assertEqual(bzrdir_config.get_option('key2', 'NOSECTION'), None)
1966
        value = bzrdir_config.get_option('key2', 'NOSECTION',
1967
                                         default='default')
1968
        self.assertEqual(value, 'default')
1969
        value = bzrdir_config.get_option('key3')
1970
        self.assertEqual(value, 'value3-top')
1971
        value = bzrdir_config.get_option('key3', 'SECTION')
1972
        self.assertEqual(value, 'value3-section')
1973
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1974
    def test_set_unset_default_stack_on(self):
1975
        my_dir = self.make_bzrdir('.')
4288.1.3 by Robert Collins
Fix BzrDirConfig tests.
1976
        bzrdir_config = config.BzrDirConfig(my_dir)
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1977
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1978
        bzrdir_config.set_default_stack_on('Foo')
3242.3.14 by Aaron Bentley
Make BzrDirConfig use TransportConfig
1979
        self.assertEqual('Foo', bzrdir_config._config.get_option(
1980
                         'default_stack_on'))
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1981
        self.assertEqual('Foo', bzrdir_config.get_default_stack_on())
1982
        bzrdir_config.set_default_stack_on(None)
1983
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1984
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1985
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
1986
class TestOldConfigHooks(tests.TestCaseWithTransport):
1987
1988
    def setUp(self):
1989
        super(TestOldConfigHooks, self).setUp()
1990
        create_configs_with_file_option(self)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
1991
1992
    def assertGetHook(self, conf, name, value):
1993
        calls = []
1994
        def hook(*args):
1995
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
1996
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
1997
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
1998
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
1999
        self.assertLength(0, calls)
2000
        actual_value = conf.get_user_option(name)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2001
        self.assertEqual(value, actual_value)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2002
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2003
        self.assertEqual((conf, name, value), calls[0])
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2004
2005
    def test_get_hook_bazaar(self):
2006
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
2007
2008
    def test_get_hook_locations(self):
2009
        self.assertGetHook(self.locations_config, 'file', 'locations')
2010
2011
    def test_get_hook_branch(self):
2012
        # Since locations masks branch, we define a different option
2013
        self.branch_config.set_user_option('file2', 'branch')
2014
        self.assertGetHook(self.branch_config, 'file2', 'branch')
2015
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2016
    def assertSetHook(self, conf, name, value):
2017
        calls = []
2018
        def hook(*args):
2019
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2020
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2021
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2022
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2023
        self.assertLength(0, calls)
2024
        conf.set_user_option(name, value)
2025
        self.assertLength(1, calls)
2026
        # We can't assert the conf object below as different configs use
2027
        # different means to implement set_user_option and we care only about
2028
        # coverage here.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2029
        self.assertEqual((name, value), calls[0][1:])
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2030
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2031
    def test_set_hook_bazaar(self):
2032
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
2033
2034
    def test_set_hook_locations(self):
2035
        self.assertSetHook(self.locations_config, 'foo', 'locations')
2036
2037
    def test_set_hook_branch(self):
2038
        self.assertSetHook(self.branch_config, 'foo', 'branch')
2039
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2040
    def assertRemoveHook(self, conf, name, section_name=None):
2041
        calls = []
2042
        def hook(*args):
2043
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2044
        config.OldConfigHooks.install_named_hook('remove', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2045
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2046
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2047
        self.assertLength(0, calls)
2048
        conf.remove_user_option(name, section_name)
2049
        self.assertLength(1, calls)
2050
        # We can't assert the conf object below as different configs use
2051
        # different means to implement remove_user_option and we care only about
2052
        # coverage here.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2053
        self.assertEqual((name,), calls[0][1:])
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2054
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2055
    def test_remove_hook_bazaar(self):
2056
        self.assertRemoveHook(self.bazaar_config, 'file')
2057
2058
    def test_remove_hook_locations(self):
2059
        self.assertRemoveHook(self.locations_config, 'file',
2060
                              self.locations_config.location)
2061
2062
    def test_remove_hook_branch(self):
2063
        self.assertRemoveHook(self.branch_config, 'file')
2064
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2065
    def assertLoadHook(self, name, conf_class, *conf_args):
2066
        calls = []
2067
        def hook(*args):
2068
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2069
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2070
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2071
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2072
        self.assertLength(0, calls)
2073
        # Build a config
2074
        conf = conf_class(*conf_args)
2075
        # Access an option to trigger a load
2076
        conf.get_user_option(name)
2077
        self.assertLength(1, calls)
2078
        # Since we can't assert about conf, we just use the number of calls ;-/
2079
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2080
    def test_load_hook_bazaar(self):
2081
        self.assertLoadHook('file', config.GlobalConfig)
2082
2083
    def test_load_hook_locations(self):
2084
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
2085
2086
    def test_load_hook_branch(self):
2087
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
2088
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2089
    def assertSaveHook(self, conf):
2090
        calls = []
2091
        def hook(*args):
2092
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2093
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2094
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2095
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2096
        self.assertLength(0, calls)
2097
        # Setting an option triggers a save
2098
        conf.set_user_option('foo', 'bar')
2099
        self.assertLength(1, calls)
2100
        # Since we can't assert about conf, we just use the number of calls ;-/
2101
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2102
    def test_save_hook_bazaar(self):
2103
        self.assertSaveHook(self.bazaar_config)
2104
2105
    def test_save_hook_locations(self):
2106
        self.assertSaveHook(self.locations_config)
2107
2108
    def test_save_hook_branch(self):
2109
        self.assertSaveHook(self.branch_config)
2110
2111
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2112
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
2113
    """Tests config hooks for remote configs.
2114
2115
    No tests for the remove hook as this is not implemented there.
2116
    """
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2117
2118
    def setUp(self):
2119
        super(TestOldConfigHooksForRemote, self).setUp()
2120
        self.transport_server = test_server.SmartTCPServer_for_testing
2121
        create_configs_with_file_option(self)
2122
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2123
    def assertGetHook(self, conf, name, value):
2124
        calls = []
2125
        def hook(*args):
2126
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2127
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2128
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2129
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2130
        self.assertLength(0, calls)
2131
        actual_value = conf.get_option(name)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2132
        self.assertEqual(value, actual_value)
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2133
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2134
        self.assertEqual((conf, name, value), calls[0])
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2135
2136
    def test_get_hook_remote_branch(self):
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2137
        remote_branch = branch.Branch.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2138
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2139
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2140
    def test_get_hook_remote_bzrdir(self):
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2141
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2142
        conf = remote_bzrdir._get_config()
2143
        conf.set_option('remotedir', 'file')
2144
        self.assertGetHook(conf, 'file', 'remotedir')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2145
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2146
    def assertSetHook(self, conf, name, value):
2147
        calls = []
2148
        def hook(*args):
2149
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2150
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2151
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2152
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2153
        self.assertLength(0, calls)
2154
        conf.set_option(value, name)
2155
        self.assertLength(1, calls)
2156
        # We can't assert the conf object below as different configs use
2157
        # different means to implement set_user_option and we care only about
2158
        # coverage here.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2159
        self.assertEqual((name, value), calls[0][1:])
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2160
2161
    def test_set_hook_remote_branch(self):
2162
        remote_branch = branch.Branch.open(self.get_url('tree'))
2163
        self.addCleanup(remote_branch.lock_write().unlock)
2164
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
2165
2166
    def test_set_hook_remote_bzrdir(self):
2167
        remote_branch = branch.Branch.open(self.get_url('tree'))
2168
        self.addCleanup(remote_branch.lock_write().unlock)
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2169
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2170
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
2171
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2172
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
2173
        calls = []
2174
        def hook(*args):
2175
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2176
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2177
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2178
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2179
        self.assertLength(0, calls)
2180
        # Build a config
2181
        conf = conf_class(*conf_args)
2182
        # Access an option to trigger a load
2183
        conf.get_option(name)
2184
        self.assertLength(expected_nb_calls, calls)
2185
        # Since we can't assert about conf, we just use the number of calls ;-/
2186
2187
    def test_load_hook_remote_branch(self):
2188
        remote_branch = branch.Branch.open(self.get_url('tree'))
2189
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
2190
2191
    def test_load_hook_remote_bzrdir(self):
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2192
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2193
        # The config file doesn't exist, set an option to force its creation
2194
        conf = remote_bzrdir._get_config()
2195
        conf.set_option('remotedir', 'file')
2196
        # We get one call for the server and one call for the client, this is
2197
        # caused by the differences in implementations betwen
2198
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
2199
        # SmartServerBranchGetConfigFile (in smart/branch.py)
2200
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
2201
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2202
    def assertSaveHook(self, conf):
2203
        calls = []
2204
        def hook(*args):
2205
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2206
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2207
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2208
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2209
        self.assertLength(0, calls)
2210
        # Setting an option triggers a save
2211
        conf.set_option('foo', 'bar')
2212
        self.assertLength(1, calls)
2213
        # Since we can't assert about conf, we just use the number of calls ;-/
2214
2215
    def test_save_hook_remote_branch(self):
2216
        remote_branch = branch.Branch.open(self.get_url('tree'))
2217
        self.addCleanup(remote_branch.lock_write().unlock)
2218
        self.assertSaveHook(remote_branch._get_config())
2219
2220
    def test_save_hook_remote_bzrdir(self):
2221
        remote_branch = branch.Branch.open(self.get_url('tree'))
2222
        self.addCleanup(remote_branch.lock_write().unlock)
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2223
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2224
        self.assertSaveHook(remote_bzrdir._get_config())
2225
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2226
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
2227
class TestOptionNames(tests.TestCase):
2228
2229
    def is_valid(self, name):
2230
        return config._option_ref_re.match('{%s}' % name) is not None
2231
2232
    def test_valid_names(self):
2233
        self.assertTrue(self.is_valid('foo'))
2234
        self.assertTrue(self.is_valid('foo.bar'))
2235
        self.assertTrue(self.is_valid('f1'))
2236
        self.assertTrue(self.is_valid('_'))
2237
        self.assertTrue(self.is_valid('__bar__'))
2238
        self.assertTrue(self.is_valid('a_'))
2239
        self.assertTrue(self.is_valid('a1'))
6587.2.4 by Vincent Ladeuil
Allow hyphens in option names to unbreak compatibility.
2240
        # Don't break bzr-svn for no good reason
2241
        self.assertTrue(self.is_valid('guessed-layout'))
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
2242
2243
    def test_invalid_names(self):
2244
        self.assertFalse(self.is_valid(' foo'))
2245
        self.assertFalse(self.is_valid('foo '))
2246
        self.assertFalse(self.is_valid('1'))
2247
        self.assertFalse(self.is_valid('1,2'))
2248
        self.assertFalse(self.is_valid('foo$'))
2249
        self.assertFalse(self.is_valid('!foo'))
2250
        self.assertFalse(self.is_valid('foo.'))
2251
        self.assertFalse(self.is_valid('foo..bar'))
2252
        self.assertFalse(self.is_valid('{}'))
2253
        self.assertFalse(self.is_valid('{a}'))
2254
        self.assertFalse(self.is_valid('a\n'))
6587.2.4 by Vincent Ladeuil
Allow hyphens in option names to unbreak compatibility.
2255
        self.assertFalse(self.is_valid('-'))
2256
        self.assertFalse(self.is_valid('-a'))
2257
        self.assertFalse(self.is_valid('a-'))
2258
        self.assertFalse(self.is_valid('a--a'))
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
2259
2260
    def assertSingleGroup(self, reference):
2261
        # the regexp is used with split and as such should match the reference
2262
        # *only*, if more groups needs to be defined, (?:...) should be used.
2263
        m = config._option_ref_re.match('{a}')
2264
        self.assertLength(1, m.groups())
2265
2266
    def test_valid_references(self):
2267
        self.assertSingleGroup('{a}')
2268
        self.assertSingleGroup('{{a}}')
2269
2270
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2271
class TestOption(tests.TestCase):
2272
2273
    def test_default_value(self):
2274
        opt = config.Option('foo', default='bar')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2275
        self.assertEqual('bar', opt.get_default())
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2276
6349.3.1 by Vincent Ladeuil
Allow config option default value to be a python callable
2277
    def test_callable_default_value(self):
2278
        def bar_as_unicode():
2279
            return u'bar'
2280
        opt = config.Option('foo', default=bar_as_unicode)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2281
        self.assertEqual('bar', opt.get_default())
6349.3.1 by Vincent Ladeuil
Allow config option default value to be a python callable
2282
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2283
    def test_default_value_from_env(self):
2284
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
2285
        self.overrideEnv('FOO', 'quux')
2286
        # Env variable provides a default taking over the option one
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2287
        self.assertEqual('quux', opt.get_default())
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2288
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2289
    def test_first_default_value_from_env_wins(self):
2290
        opt = config.Option('foo', default='bar',
2291
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
2292
        self.overrideEnv('FOO', 'foo')
2293
        self.overrideEnv('BAZ', 'baz')
2294
        # The first env var set wins
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2295
        self.assertEqual('foo', opt.get_default())
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2296
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
2297
    def test_not_supported_list_default_value(self):
2298
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
2299
2300
    def test_not_supported_object_default_value(self):
2301
        self.assertRaises(AssertionError, config.Option, 'foo',
2302
                          default=object())
2303
6349.3.1 by Vincent Ladeuil
Allow config option default value to be a python callable
2304
    def test_not_supported_callable_default_value_not_unicode(self):
2305
        def bar_not_unicode():
2306
            return 'bar'
2307
        opt = config.Option('foo', default=bar_not_unicode)
2308
        self.assertRaises(AssertionError, opt.get_default)
2309
6437.42.1 by Jelmer Vernooij
Make sure help options can provide their own help topic.
2310
    def test_get_help_topic(self):
2311
        opt = config.Option('foo')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2312
        self.assertEqual('foo', opt.get_help_topic())
6437.42.1 by Jelmer Vernooij
Make sure help options can provide their own help topic.
2313
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2314
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2315
class TestOptionConverter(tests.TestCase):
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2316
2317
    def assertConverted(self, expected, opt, value):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2318
        self.assertEqual(expected, opt.convert_from_unicode(None, value))
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2319
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2320
    def assertCallsWarning(self, opt, value):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2321
        warnings = []
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2322
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2323
        def warning(*args):
2324
            warnings.append(args[0] % args[1:])
2325
        self.overrideAttr(trace, 'warning', warning)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2326
        self.assertEqual(None, opt.convert_from_unicode(None, value))
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2327
        self.assertLength(1, warnings)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2328
        self.assertEqual(
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2329
            'Value "%s" is not valid for "%s"' % (value, opt.name),
2330
            warnings[0])
2331
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2332
    def assertCallsError(self, opt, value):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2333
        self.assertRaises(errors.ConfigOptionValueError,
2334
                          opt.convert_from_unicode, None, value)
2335
2336
    def assertConvertInvalid(self, opt, invalid_value):
2337
        opt.invalid = None
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2338
        self.assertEqual(None, opt.convert_from_unicode(None, invalid_value))
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2339
        opt.invalid = 'warning'
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2340
        self.assertCallsWarning(opt, invalid_value)
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2341
        opt.invalid = 'error'
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2342
        self.assertCallsError(opt, invalid_value)
2343
2344
2345
class TestOptionWithBooleanConverter(TestOptionConverter):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2346
2347
    def get_option(self):
2348
        return config.Option('foo', help='A boolean.',
2349
                             from_unicode=config.bool_from_store)
2350
2351
    def test_convert_invalid(self):
2352
        opt = self.get_option()
2353
        # A string that is not recognized as a boolean
2354
        self.assertConvertInvalid(opt, u'invalid-boolean')
2355
        # A list of strings is never recognized as a boolean
2356
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
2357
2358
    def test_convert_valid(self):
2359
        opt = self.get_option()
2360
        self.assertConverted(True, opt, u'True')
2361
        self.assertConverted(True, opt, u'1')
2362
        self.assertConverted(False, opt, u'False')
2363
2364
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2365
class TestOptionWithIntegerConverter(TestOptionConverter):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2366
2367
    def get_option(self):
2368
        return config.Option('foo', help='An integer.',
2369
                             from_unicode=config.int_from_store)
2370
2371
    def test_convert_invalid(self):
2372
        opt = self.get_option()
2373
        # A string that is not recognized as an integer
2374
        self.assertConvertInvalid(opt, u'forty-two')
2375
        # A list of strings is never recognized as an integer
2376
        self.assertConvertInvalid(opt, [u'a', u'list'])
2377
2378
    def test_convert_valid(self):
2379
        opt = self.get_option()
2380
        self.assertConverted(16, opt, u'16')
2381
2382
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2383
class TestOptionWithSIUnitConverter(TestOptionConverter):
6378.1.1 by Vincent Ladeuil
Add int_SI_from_store as a config option helper
2384
2385
    def get_option(self):
2386
        return config.Option('foo', help='An integer in SI units.',
2387
                             from_unicode=config.int_SI_from_store)
2388
2389
    def test_convert_invalid(self):
2390
        opt = self.get_option()
2391
        self.assertConvertInvalid(opt, u'not-a-unit')
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2392
        self.assertConvertInvalid(opt, u'Gb')  # Forgot the value
2393
        self.assertConvertInvalid(opt, u'1b')  # Forgot the unit
6378.1.1 by Vincent Ladeuil
Add int_SI_from_store as a config option helper
2394
        self.assertConvertInvalid(opt, u'1GG')
2395
        self.assertConvertInvalid(opt, u'1Mbb')
2396
        self.assertConvertInvalid(opt, u'1MM')
2397
2398
    def test_convert_valid(self):
2399
        opt = self.get_option()
2400
        self.assertConverted(int(5e3), opt, u'5kb')
2401
        self.assertConverted(int(5e6), opt, u'5M')
2402
        self.assertConverted(int(5e6), opt, u'5MB')
2403
        self.assertConverted(int(5e9), opt, u'5g')
2404
        self.assertConverted(int(5e9), opt, u'5gB')
2405
        self.assertConverted(100, opt, u'100')
2406
2407
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2408
class TestListOption(TestOptionConverter):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2409
2410
    def get_option(self):
2411
        return config.ListOption('foo', help='A list.')
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2412
2413
    def test_convert_invalid(self):
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
2414
        opt = self.get_option()
2415
        # We don't even try to convert a list into a list, we only expect
2416
        # strings
2417
        self.assertConvertInvalid(opt, [1])
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2418
        # No string is invalid as all forms can be converted to a list
2419
2420
    def test_convert_valid(self):
2421
        opt = self.get_option()
2422
        # An empty string is an empty list
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2423
        self.assertConverted([], opt, '')  # Using a bare str() just in case
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2424
        self.assertConverted([], opt, u'')
2425
        # A boolean
2426
        self.assertConverted([u'True'], opt, u'True')
2427
        # An integer
2428
        self.assertConverted([u'42'], opt, u'42')
2429
        # A single string
2430
        self.assertConverted([u'bar'], opt, u'bar')
2431
2432
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2433
class TestRegistryOption(TestOptionConverter):
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2434
2435
    def get_option(self, registry):
2436
        return config.RegistryOption('foo', registry,
6607.1.1 by Vincent Ladeuil
Rename assertWarns in test_config to avoid clashing with unittest2 assertWarns
2437
                                     help='A registry option.')
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2438
2439
    def test_convert_invalid(self):
2440
        registry = _mod_registry.Registry()
2441
        opt = self.get_option(registry)
2442
        self.assertConvertInvalid(opt, [1])
2443
        self.assertConvertInvalid(opt, u"notregistered")
2444
2445
    def test_convert_valid(self):
2446
        registry = _mod_registry.Registry()
2447
        registry.register("someval", 1234)
2448
        opt = self.get_option(registry)
2449
        # Using a bare str() just in case
2450
        self.assertConverted(1234, opt, "someval")
2451
        self.assertConverted(1234, opt, u'someval')
2452
        self.assertConverted(None, opt, None)
2453
2454
    def test_help(self):
2455
        registry = _mod_registry.Registry()
2456
        registry.register("someval", 1234, help="some option")
2457
        registry.register("dunno", 1234, help="some other option")
2458
        opt = self.get_option(registry)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2459
        self.assertEqual(
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2460
            'A registry option.\n'
2461
            '\n'
2462
            'The following values are supported:\n'
2463
            ' dunno - some other option\n'
2464
            ' someval - some option\n',
6449.2.2 by Jelmer Vernooij
Moar tests.
2465
            opt.help)
2466
2467
    def test_get_help_text(self):
2468
        registry = _mod_registry.Registry()
2469
        registry.register("someval", 1234, help="some option")
2470
        registry.register("dunno", 1234, help="some other option")
2471
        opt = self.get_option(registry)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2472
        self.assertEqual(
6449.2.2 by Jelmer Vernooij
Moar tests.
2473
            'A registry option.\n'
2474
            '\n'
2475
            'The following values are supported:\n'
2476
            ' dunno - some other option\n'
2477
            ' someval - some option\n',
2478
            opt.get_help_text())
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2479
2480
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2481
class TestOptionRegistry(tests.TestCase):
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2482
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2483
    def setUp(self):
2484
        super(TestOptionRegistry, self).setUp()
2485
        # Always start with an empty registry
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2486
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2487
        self.registry = config.option_registry
2488
2489
    def test_register(self):
2490
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2491
        self.registry.register(opt)
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2492
        self.assertIs(opt, self.registry.get('foo'))
2493
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2494
    def test_registered_help(self):
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2495
        opt = config.Option('foo', help='A simple option')
2496
        self.registry.register(opt)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2497
        self.assertEqual('A simple option', self.registry.get_help('foo'))
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2498
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
2499
    def test_dont_register_illegal_name(self):
2500
        self.assertRaises(errors.IllegalOptionName,
2501
                          self.registry.register, config.Option(' foo'))
2502
        self.assertRaises(errors.IllegalOptionName,
2503
                          self.registry.register, config.Option('bar,'))
2504
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2505
    lazy_option = config.Option('lazy_foo', help='Lazy help')
2506
2507
    def test_register_lazy(self):
2508
        self.registry.register_lazy('lazy_foo', self.__module__,
2509
                                    'TestOptionRegistry.lazy_option')
2510
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
2511
2512
    def test_registered_lazy_help(self):
2513
        self.registry.register_lazy('lazy_foo', self.__module__,
2514
                                    'TestOptionRegistry.lazy_option')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2515
        self.assertEqual('Lazy help', self.registry.get_help('lazy_foo'))
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2516
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
2517
    def test_dont_lazy_register_illegal_name(self):
2518
        # This is where the root cause of http://pad.lv/1235099 is better
2519
        # understood: 'register_lazy' doc string mentions that key should match
2520
        # the option name which indirectly requires that the option name is a
2521
        # valid python identifier. We violate that rule here (using a key that
2522
        # doesn't match the option name) to test the option name checking.
2523
        self.assertRaises(errors.IllegalOptionName,
2524
                          self.registry.register_lazy, ' foo', self.__module__,
2525
                          'TestOptionRegistry.lazy_option')
2526
        self.assertRaises(errors.IllegalOptionName,
2527
                          self.registry.register_lazy, '1,2', self.__module__,
2528
                          'TestOptionRegistry.lazy_option')
2529
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2530
2531
class TestRegisteredOptions(tests.TestCase):
2532
    """All registered options should verify some constraints."""
2533
2534
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
2535
                 in config.option_registry.iteritems()]
2536
2537
    def setUp(self):
2538
        super(TestRegisteredOptions, self).setUp()
2539
        self.registry = config.option_registry
2540
2541
    def test_proper_name(self):
2542
        # An option should be registered under its own name, this can't be
2543
        # checked at registration time for the lazy ones.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2544
        self.assertEqual(self.option_name, self.option.name)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2545
2546
    def test_help_is_set(self):
2547
        option_help = self.registry.get_help(self.option_name)
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2548
        # Come on, think about the user, he really wants to know what the
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2549
        # option is about
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2550
        self.assertIsNot(None, option_help)
6614.1.2 by Vincent Ladeuil
Fix assertNotEquals being deprecated by using assertNotEqual.
2551
        self.assertNotEqual('', option_help)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2552
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2553
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2554
class TestSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2555
2556
    # FIXME: Parametrize so that all sections produced by Stores run these
5743.3.1 by Vincent Ladeuil
Add a docstring and dates to FIXMEs.
2557
    # tests -- vila 2011-04-01
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2558
2559
    def test_get_a_value(self):
2560
        a_dict = dict(foo='bar')
5743.3.11 by Vincent Ladeuil
Config sections only implement read access.
2561
        section = config.Section('myID', a_dict)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2562
        self.assertEqual('bar', section.get('foo'))
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2563
5743.3.10 by Vincent Ladeuil
Fix typos mentioned in reviews.
2564
    def test_get_unknown_option(self):
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2565
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2566
        section = config.Section(None, a_dict)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2567
        self.assertEqual('out of thin air',
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2568
                          section.get('foo', 'out of thin air'))
2569
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2570
    def test_options_is_shared(self):
2571
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2572
        section = config.Section(None, a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2573
        self.assertIs(a_dict, section.options)
2574
2575
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2576
class TestMutableSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2577
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2578
    scenarios = [('mutable',
2579
                  {'get_section':
2580
                       lambda opts: config.MutableSection('myID', opts)},),
2581
        ]
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2582
2583
    def test_set(self):
2584
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2585
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2586
        section.set('foo', 'new_value')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2587
        self.assertEqual('new_value', section.get('foo'))
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2588
        # The change appears in the shared section
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2589
        self.assertEqual('new_value', a_dict.get('foo'))
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2590
        # We keep track of the change
2591
        self.assertTrue('foo' in section.orig)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2592
        self.assertEqual('bar', section.orig.get('foo'))
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2593
2594
    def test_set_preserve_original_once(self):
2595
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2596
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2597
        section.set('foo', 'first_value')
2598
        section.set('foo', 'second_value')
2599
        # We keep track of the original value
2600
        self.assertTrue('foo' in section.orig)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2601
        self.assertEqual('bar', section.orig.get('foo'))
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2602
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2603
    def test_remove(self):
2604
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2605
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2606
        section.remove('foo')
2607
        # We get None for unknown options via the default value
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2608
        self.assertEqual(None, section.get('foo'))
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2609
        # Or we just get the default value
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2610
        self.assertEqual('unknown', section.get('foo', 'unknown'))
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2611
        self.assertFalse('foo' in section.options)
2612
        # We keep track of the deletion
2613
        self.assertTrue('foo' in section.orig)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2614
        self.assertEqual('bar', section.orig.get('foo'))
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2615
2616
    def test_remove_new_option(self):
2617
        a_dict = dict()
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2618
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2619
        section.set('foo', 'bar')
2620
        section.remove('foo')
2621
        self.assertFalse('foo' in section.options)
2622
        # The option didn't exist initially so it we need to keep track of it
2623
        # with a special value
2624
        self.assertTrue('foo' in section.orig)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2625
        self.assertEqual(config._NewlyCreatedOption, section.orig['foo'])
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2626
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2627
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2628
class TestCommandLineStore(tests.TestCase):
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2629
2630
    def setUp(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2631
        super(TestCommandLineStore, self).setUp()
2632
        self.store = config.CommandLineStore()
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2633
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2634
2635
    def get_section(self):
2636
        """Get the unique section for the command line overrides."""
2637
        sections = list(self.store.get_sections())
2638
        self.assertLength(1, sections)
2639
        store, section = sections[0]
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2640
        self.assertEqual(self.store, store)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2641
        return section
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2642
2643
    def test_no_override(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2644
        self.store._from_cmdline([])
2645
        section = self.get_section()
2646
        self.assertLength(0, list(section.iter_option_names()))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2647
2648
    def test_simple_override(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2649
        self.store._from_cmdline(['a=b'])
2650
        section = self.get_section()
2651
        self.assertEqual('b', section.get('a'))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2652
2653
    def test_list_override(self):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2654
        opt = config.ListOption('l')
2655
        config.option_registry.register(opt)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2656
        self.store._from_cmdline(['l=1,2,3'])
2657
        val = self.get_section().get('l')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2658
        self.assertEqual('1,2,3', val)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2659
        # Reminder: lists should be registered as such explicitely, otherwise
2660
        # the conversion needs to be done afterwards.
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2661
        self.assertEqual(['1', '2', '3'],
2662
                         opt.convert_from_unicode(self.store, val))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2663
2664
    def test_multiple_overrides(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2665
        self.store._from_cmdline(['a=b', 'x=y'])
2666
        section = self.get_section()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2667
        self.assertEqual('b', section.get('a'))
2668
        self.assertEqual('y', section.get('x'))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2669
2670
    def test_wrong_syntax(self):
2671
        self.assertRaises(errors.BzrCommandError,
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2672
                          self.store._from_cmdline, ['a=b', 'c'])
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2673
6404.4.1 by Vincent Ladeuil
Properly support config.CommandLineStore in ``bzr config``
2674
class TestStoreMinimalAPI(tests.TestCaseWithTransport):
2675
2676
    scenarios = [(key, {'get_store': builder}) for key, builder
2677
                 in config.test_store_builder_registry.iteritems()] + [
2678
        ('cmdline', {'get_store': lambda test: config.CommandLineStore()})]
2679
2680
    def test_id(self):
2681
        store = self.get_store(self)
2682
        if type(store) == config.TransportIniFileStore:
6404.4.2 by Vincent Ladeuil
test_id is not applicable (which is why is it skipped) to TransportIniFileStore.
2683
            raise tests.TestNotApplicable(
6404.4.1 by Vincent Ladeuil
Properly support config.CommandLineStore in ``bzr config``
2684
                "%s is not a concrete Store implementation"
2685
                " so it doesn't need an id" % (store.__class__.__name__,))
2686
        self.assertIsNot(None, store.id)
2687
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2688
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2689
class TestStore(tests.TestCaseWithTransport):
2690
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2691
    def assertSectionContent(self, expected, (store, section)):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2692
        """Assert that some options have the proper values in a section."""
2693
        expected_name, expected_options = expected
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2694
        self.assertEqual(expected_name, section.id)
2695
        self.assertEqual(
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2696
            expected_options,
2697
            dict([(k, section.get(k)) for k in expected_options.keys()]))
2698
2699
2700
class TestReadonlyStore(TestStore):
2701
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2702
    scenarios = [(key, {'get_store': builder}) for key, builder
2703
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2704
2705
    def test_building_delays_load(self):
2706
        store = self.get_store(self)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2707
        self.assertEqual(False, store.is_loaded())
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2708
        store._load_from_string('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2709
        self.assertEqual(True, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2710
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2711
    def test_get_no_sections_for_empty(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2712
        store = self.get_store(self)
2713
        store._load_from_string('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2714
        self.assertEqual([], list(store.get_sections()))
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2715
2716
    def test_get_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2717
        store = self.get_store(self)
2718
        store._load_from_string('foo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2719
        sections = list(store.get_sections())
2720
        self.assertLength(1, sections)
2721
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2722
2723
    def test_get_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2724
        store = self.get_store(self)
2725
        store._load_from_string('[baz]\nfoo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2726
        sections = list(store.get_sections())
2727
        self.assertLength(1, sections)
2728
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2729
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2730
    def test_load_from_string_fails_for_non_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2731
        store = self.get_store(self)
2732
        store._load_from_string('foo=bar')
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2733
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
2734
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2735
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2736
class TestStoreQuoting(TestStore):
2737
2738
    scenarios = [(key, {'get_store': builder}) for key, builder
2739
                 in config.test_store_builder_registry.iteritems()]
2740
2741
    def setUp(self):
2742
        super(TestStoreQuoting, self).setUp()
2743
        self.store = self.get_store(self)
2744
        # We need a loaded store but any content will do
2745
        self.store._load_from_string('')
2746
2747
    def assertIdempotent(self, s):
2748
        """Assert that quoting an unquoted string is a no-op and vice-versa.
2749
2750
        What matters here is that option values, as they appear in a store, can
2751
        be safely round-tripped out of the store and back.
2752
2753
        :param s: A string, quoted if required.
2754
        """
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2755
        self.assertEqual(s, self.store.quote(self.store.unquote(s)))
2756
        self.assertEqual(s, self.store.unquote(self.store.quote(s)))
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2757
2758
    def test_empty_string(self):
2759
        if isinstance(self.store, config.IniFileStore):
2760
            # configobj._quote doesn't handle empty values
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2761
            self.assertRaises(AssertionError,
2762
                              self.assertIdempotent, '')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2763
        else:
2764
            self.assertIdempotent('')
2765
        # But quoted empty strings are ok
2766
        self.assertIdempotent('""')
2767
2768
    def test_embedded_spaces(self):
2769
        self.assertIdempotent('" a b c "')
2770
2771
    def test_embedded_commas(self):
2772
        self.assertIdempotent('" a , b c "')
2773
2774
    def test_simple_comma(self):
2775
        if isinstance(self.store, config.IniFileStore):
2776
            # configobj requires that lists are special-cased
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2777
           self.assertRaises(AssertionError,
2778
                             self.assertIdempotent, ',')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2779
        else:
2780
            self.assertIdempotent(',')
2781
        # When a single comma is required, quoting is also required
2782
        self.assertIdempotent('","')
2783
2784
    def test_list(self):
2785
        if isinstance(self.store, config.IniFileStore):
2786
            # configobj requires that lists are special-cased
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2787
            self.assertRaises(AssertionError,
2788
                              self.assertIdempotent, 'a,b')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2789
        else:
2790
            self.assertIdempotent('a,b')
2791
2792
6404.3.1 by Vincent Ladeuil
Robustly unquote configuration values (workaround configobj presenting a section as a dict in weird edge cases)
2793
class TestDictFromStore(tests.TestCase):
2794
2795
    def test_unquote_not_string(self):
2796
        conf = config.MemoryStack('x=2\n[a_section]\na=1\n')
2797
        value = conf.get('a_section')
2798
        # Urgh, despite 'conf' asking for the no-name section, we get the
2799
        # content of another section as a dict o_O
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2800
        self.assertEqual({'a': '1'}, value)
6404.3.1 by Vincent Ladeuil
Robustly unquote configuration values (workaround configobj presenting a section as a dict in weird edge cases)
2801
        unquoted = conf.store.unquote(value)
2802
        # Which cannot be unquoted but shouldn't crash either (the use cases
2803
        # are getting the value or displaying it. In the later case, '%s' will
2804
        # do).
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2805
        self.assertEqual({'a': '1'}, unquoted)
2806
        self.assertEqual("{u'a': u'1'}", '%s' % (unquoted,))
6404.3.1 by Vincent Ladeuil
Robustly unquote configuration values (workaround configobj presenting a section as a dict in weird edge cases)
2807
2808
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2809
class TestIniFileStoreContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2810
    """Simulate loading a config store with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2811
2812
    All files produced by bzr are in utf8 content.
2813
2814
    Users may modify them manually and end up with a file that can't be
2815
    loaded. We need to issue proper error messages in this case.
2816
    """
2817
2818
    invalid_utf8_char = '\xff'
2819
2820
    def test_load_utf8(self):
2821
        """Ensure we can load an utf8-encoded file."""
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2822
        t = self.get_transport()
2823
        # From http://pad.lv/799212
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2824
        unicode_user = u'b\N{Euro Sign}ar'
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2825
        unicode_content = u'user=%s' % (unicode_user,)
2826
        utf8_content = unicode_content.encode('utf8')
2827
        # Store the raw content in the config file
2828
        t.put_bytes('foo.conf', utf8_content)
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2829
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2830
        store.load()
2831
        stack = config.Stack([store.get_sections], store)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2832
        self.assertEqual(unicode_user, stack.get('user'))
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2833
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2834
    def test_load_non_ascii(self):
2835
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2836
        t = self.get_transport()
2837
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2838
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2839
        self.assertRaises(errors.ConfigContentError, store.load)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2840
2841
    def test_load_erroneous_content(self):
2842
        """Ensure we display a proper error on content that can't be parsed."""
2843
        t = self.get_transport()
2844
        t.put_bytes('foo.conf', '[open_section\n')
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2845
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2846
        self.assertRaises(errors.ParseConfigError, store.load)
2847
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2848
    def test_load_permission_denied(self):
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2849
        """Ensure we get warned when trying to load an inaccessible file."""
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2850
        warnings = []
2851
        def warning(*args):
2852
            warnings.append(args[0] % args[1:])
2853
        self.overrideAttr(trace, 'warning', warning)
2854
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2855
        t = self.get_transport()
2856
2857
        def get_bytes(relpath):
2858
            raise errors.PermissionDenied(relpath, "")
2859
        t.get_bytes = get_bytes
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2860
        store = config.TransportIniFileStore(t, 'foo.conf')
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2861
        self.assertRaises(errors.PermissionDenied, store.load)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2862
        self.assertEqual(
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2863
            warnings,
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2864
            [u'Permission denied while trying to load configuration store %s.'
2865
             % store.external_url()])
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2866
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2867
2868
class TestIniConfigContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2869
    """Simulate loading a IniBasedConfig with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2870
2871
    All files produced by bzr are in utf8 content.
2872
2873
    Users may modify them manually and end up with a file that can't be
2874
    loaded. We need to issue proper error messages in this case.
2875
    """
2876
2877
    invalid_utf8_char = '\xff'
2878
2879
    def test_load_utf8(self):
2880
        """Ensure we can load an utf8-encoded file."""
2881
        # From http://pad.lv/799212
2882
        unicode_user = u'b\N{Euro Sign}ar'
2883
        unicode_content = u'user=%s' % (unicode_user,)
2884
        utf8_content = unicode_content.encode('utf8')
2885
        # Store the raw content in the config file
2886
        with open('foo.conf', 'wb') as f:
2887
            f.write(utf8_content)
2888
        conf = config.IniBasedConfig(file_name='foo.conf')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2889
        self.assertEqual(unicode_user, conf.get_user_option('user'))
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2890
2891
    def test_load_badly_encoded_content(self):
2892
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2893
        with open('foo.conf', 'wb') as f:
2894
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
2895
        conf = config.IniBasedConfig(file_name='foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2896
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2897
2898
    def test_load_erroneous_content(self):
2899
        """Ensure we display a proper error on content that can't be parsed."""
2900
        with open('foo.conf', 'wb') as f:
2901
            f.write('[open_section\n')
2902
        conf = config.IniBasedConfig(file_name='foo.conf')
2903
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
2904
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2905
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2906
class TestMutableStore(TestStore):
2907
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2908
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
2909
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2910
2911
    def setUp(self):
2912
        super(TestMutableStore, self).setUp()
2913
        self.transport = self.get_transport()
2914
2915
    def has_store(self, store):
2916
        store_basename = urlutils.relative_url(self.transport.external_url(),
2917
                                               store.external_url())
2918
        return self.transport.has(store_basename)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2919
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2920
    def test_save_empty_creates_no_file(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2921
        # FIXME: There should be a better way than relying on the test
2922
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2923
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2924
            raise tests.TestNotApplicable(
2925
                'branch.conf is *always* created when a branch is initialized')
2926
        store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2927
        store.save()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2928
        self.assertEqual(False, self.has_store(store))
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2929
6499.2.1 by Vincent Ladeuil
Save branch config options only during the final unlock
2930
    def test_mutable_section_shared(self):
2931
        store = self.get_store(self)
2932
        store._load_from_string('foo=bar\n')
2933
        # FIXME: There should be a better way than relying on the test
2934
        # parametrization to identify branch.conf -- vila 2011-0526
2935
        if self.store_id in ('branch', 'remote_branch'):
2936
            # branch stores requires write locked branches
2937
            self.addCleanup(store.branch.lock_write().unlock)
2938
        section1 = store.get_mutable_section(None)
2939
        section2 = store.get_mutable_section(None)
2940
        # If we get different sections, different callers won't share the
2941
        # modification
2942
        self.assertIs(section1, section2)
2943
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2944
    def test_save_emptied_succeeds(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2945
        store = self.get_store(self)
2946
        store._load_from_string('foo=bar\n')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2947
        # FIXME: There should be a better way than relying on the test
2948
        # parametrization to identify branch.conf -- vila 2011-0526
2949
        if self.store_id in ('branch', 'remote_branch'):
2950
            # branch stores requires write locked branches
2951
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2952
        section = store.get_mutable_section(None)
2953
        section.remove('foo')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2954
        store.save()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2955
        self.assertEqual(True, self.has_store(store))
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2956
        modified_store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2957
        sections = list(modified_store.get_sections())
2958
        self.assertLength(0, sections)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2959
2960
    def test_save_with_content_succeeds(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2961
        # FIXME: There should be a better way than relying on the test
2962
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2963
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2964
            raise tests.TestNotApplicable(
2965
                'branch.conf is *always* created when a branch is initialized')
2966
        store = self.get_store(self)
2967
        store._load_from_string('foo=bar\n')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2968
        self.assertEqual(False, self.has_store(store))
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2969
        store.save()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
2970
        self.assertEqual(True, self.has_store(store))
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2971
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2972
        sections = list(modified_store.get_sections())
2973
        self.assertLength(1, sections)
2974
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2975
2976
    def test_set_option_in_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2977
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2978
        # FIXME: There should be a better way than relying on the test
2979
        # parametrization to identify branch.conf -- vila 2011-0526
2980
        if self.store_id in ('branch', 'remote_branch'):
2981
            # branch stores requires write locked branches
2982
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2983
        section = store.get_mutable_section(None)
2984
        section.set('foo', 'bar')
2985
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2986
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2987
        sections = list(modified_store.get_sections())
2988
        self.assertLength(1, sections)
2989
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2990
2991
    def test_set_option_in_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2992
        store = self.get_store(self)
2993
        store._load_from_string('')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2994
        # FIXME: There should be a better way than relying on the test
2995
        # parametrization to identify branch.conf -- vila 2011-0526
2996
        if self.store_id in ('branch', 'remote_branch'):
2997
            # branch stores requires write locked branches
2998
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2999
        section = store.get_mutable_section(None)
3000
        section.set('foo', 'bar')
3001
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
3002
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3003
        sections = list(modified_store.get_sections())
3004
        self.assertLength(1, sections)
3005
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
3006
3007
    def test_set_option_in_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
3008
        store = self.get_store(self)
3009
        store._load_from_string('')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3010
        # FIXME: There should be a better way than relying on the test
3011
        # parametrization to identify branch.conf -- vila 2011-0526
3012
        if self.store_id in ('branch', 'remote_branch'):
3013
            # branch stores requires write locked branches
3014
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3015
        section = store.get_mutable_section('baz')
3016
        section.set('foo', 'bar')
3017
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
3018
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3019
        sections = list(modified_store.get_sections())
3020
        self.assertLength(1, sections)
3021
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
3022
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3023
    def test_load_hook(self):
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3024
        # First, we need to ensure that the store exists
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3025
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3026
        # FIXME: There should be a better way than relying on the test
3027
        # parametrization to identify branch.conf -- vila 2011-0526
3028
        if self.store_id in ('branch', 'remote_branch'):
3029
            # branch stores requires write locked branches
3030
            self.addCleanup(store.branch.lock_write().unlock)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3031
        section = store.get_mutable_section('baz')
3032
        section.set('foo', 'bar')
3033
        store.save()
3034
        # Now we can try to load it
5743.8.11 by Vincent Ladeuil
Restrict the scope when testing hooks to avoid spurious failures.
3035
        store = self.get_store(self)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3036
        calls = []
3037
        def hook(*args):
3038
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3039
        config.ConfigHooks.install_named_hook('load', hook, None)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3040
        self.assertLength(0, calls)
3041
        store.load()
3042
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3043
        self.assertEqual((store,), calls[0])
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
3044
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
3045
    def test_save_hook(self):
3046
        calls = []
3047
        def hook(*args):
3048
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3049
        config.ConfigHooks.install_named_hook('save', hook, None)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
3050
        self.assertLength(0, calls)
3051
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3052
        # FIXME: There should be a better way than relying on the test
3053
        # parametrization to identify branch.conf -- vila 2011-0526
3054
        if self.store_id in ('branch', 'remote_branch'):
3055
            # branch stores requires write locked branches
3056
            self.addCleanup(store.branch.lock_write().unlock)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
3057
        section = store.get_mutable_section('baz')
3058
        section.set('foo', 'bar')
3059
        store.save()
3060
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3061
        self.assertEqual((store,), calls[0])
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
3062
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
3063
    def test_set_mark_dirty(self):
3064
        stack = config.MemoryStack('')
3065
        self.assertLength(0, stack.store.dirty_sections)
3066
        stack.set('foo', 'baz')
3067
        self.assertLength(1, stack.store.dirty_sections)
6404.5.3 by Vincent Ladeuil
If at least one mutable section contain a change, the store needs to be saved
3068
        self.assertTrue(stack.store._need_saving())
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
3069
3070
    def test_remove_mark_dirty(self):
3071
        stack = config.MemoryStack('foo=bar')
3072
        self.assertLength(0, stack.store.dirty_sections)
3073
        stack.remove('foo')
3074
        self.assertLength(1, stack.store.dirty_sections)
6404.5.3 by Vincent Ladeuil
If at least one mutable section contain a change, the store needs to be saved
3075
        self.assertTrue(stack.store._need_saving())
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
3076
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3077
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3078
class TestStoreSaveChanges(tests.TestCaseWithTransport):
3079
    """Tests that config changes are kept in memory and saved on-demand."""
3080
3081
    def setUp(self):
3082
        super(TestStoreSaveChanges, self).setUp()
3083
        self.transport = self.get_transport()
3084
        # Most of the tests involve two stores pointing to the same persistent
3085
        # storage to observe the effects of concurrent changes
3086
        self.st1 = config.TransportIniFileStore(self.transport, 'foo.conf')
3087
        self.st2 = config.TransportIniFileStore(self.transport, 'foo.conf')
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3088
        self.warnings = []
3089
        def warning(*args):
3090
            self.warnings.append(args[0] % args[1:])
3091
        self.overrideAttr(trace, 'warning', warning)
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3092
3093
    def has_store(self, store):
3094
        store_basename = urlutils.relative_url(self.transport.external_url(),
3095
                                               store.external_url())
3096
        return self.transport.has(store_basename)
3097
3098
    def get_stack(self, store):
3099
        # Any stack will do as long as it uses the right store, just a single
3100
        # no-name section is enough
3101
        return config.Stack([store.get_sections], store)
3102
3103
    def test_no_changes_no_save(self):
3104
        s = self.get_stack(self.st1)
3105
        s.store.save_changes()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3106
        self.assertEqual(False, self.has_store(self.st1))
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3107
3108
    def test_unrelated_concurrent_update(self):
3109
        s1 = self.get_stack(self.st1)
3110
        s2 = self.get_stack(self.st2)
3111
        s1.set('foo', 'bar')
3112
        s2.set('baz', 'quux')
3113
        s1.store.save()
3114
        # Changes don't propagate magically
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3115
        self.assertEqual(None, s1.get('baz'))
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3116
        s2.store.save_changes()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3117
        self.assertEqual('quux', s2.get('baz'))
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3118
        # Changes are acquired when saving
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3119
        self.assertEqual('bar', s2.get('foo'))
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3120
        # Since there is no overlap, no warnings are emitted
3121
        self.assertLength(0, self.warnings)
3122
3123
    def test_concurrent_update_modified(self):
3124
        s1 = self.get_stack(self.st1)
3125
        s2 = self.get_stack(self.st2)
3126
        s1.set('foo', 'bar')
3127
        s2.set('foo', 'baz')
3128
        s1.store.save()
3129
        # Last speaker wins
3130
        s2.store.save_changes()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3131
        self.assertEqual('baz', s2.get('foo'))
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3132
        # But the user get a warning
3133
        self.assertLength(1, self.warnings)
3134
        warning = self.warnings[0]
3135
        self.assertStartsWith(warning, 'Option foo in section None')
3136
        self.assertEndsWith(warning, 'was changed from <CREATED> to bar.'
3137
                            ' The baz value will be saved.')
3138
3139
    def test_concurrent_deletion(self):
3140
        self.st1._load_from_string('foo=bar')
3141
        self.st1.save()
3142
        s1 = self.get_stack(self.st1)
3143
        s2 = self.get_stack(self.st2)
3144
        s1.remove('foo')
3145
        s2.remove('foo')
3146
        s1.store.save_changes()
3147
        # No warning yet
3148
        self.assertLength(0, self.warnings)
3149
        s2.store.save_changes()
3150
        # Now we get one
3151
        self.assertLength(1, self.warnings)
3152
        warning = self.warnings[0]
3153
        self.assertStartsWith(warning, 'Option foo in section None')
3154
        self.assertEndsWith(warning, 'was changed from bar to <CREATED>.'
3155
                            ' The <DELETED> value will be saved.')
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3156
3157
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3158
class TestQuotingIniFileStore(tests.TestCaseWithTransport):
3159
3160
    def get_store(self):
3161
        return config.TransportIniFileStore(self.get_transport(), 'foo.conf')
3162
3163
    def test_get_quoted_string(self):
3164
        store = self.get_store()
3165
        store._load_from_string('foo= " abc "')
3166
        stack = config.Stack([store.get_sections])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3167
        self.assertEqual(' abc ', stack.get('foo'))
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3168
3169
    def test_set_quoted_string(self):
3170
        store = self.get_store()
3171
        stack = config.Stack([store.get_sections], store)
3172
        stack.set('foo', ' a b c ')
3173
        store.save()
6421.1.1 by Martin Packman
Fix test_config failure by expecting suitable platform newlines in config file
3174
        self.assertFileEqual('foo = " a b c "' + os.linesep, 'foo.conf')
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3175
3176
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3177
class TestTransportIniFileStore(TestStore):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3178
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
3179
    def test_loading_unknown_file_fails(self):
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3180
        store = config.TransportIniFileStore(self.get_transport(),
3181
            'I-do-not-exist')
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
3182
        self.assertRaises(errors.NoSuchFile, store.load)
3183
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3184
    def test_invalid_content(self):
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3185
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3186
        self.assertEqual(False, store.is_loaded())
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3187
        exc = self.assertRaises(
3188
            errors.ParseConfigError, store._load_from_string,
3189
            'this is invalid !')
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3190
        self.assertEndsWith(exc.filename, 'foo.conf')
3191
        # And the load failed
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3192
        self.assertEqual(False, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3193
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3194
    def test_get_embedded_sections(self):
5743.2.11 by Vincent Ladeuil
Basic store.set implementation.
3195
        # A more complicated example (which also shows that section names and
3196
        # option names share the same name space...)
5743.4.7 by Vincent Ladeuil
The test is now specific to ConfigObjStore and highlight a pending problem there.
3197
        # FIXME: This should be fixed by forbidding dicts as values ?
3198
        # -- vila 2011-04-05
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3199
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3200
        store._load_from_string('''
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3201
foo=bar
3202
l=1,2
3203
[DEFAULT]
3204
foo_in_DEFAULT=foo_DEFAULT
3205
[bar]
3206
foo_in_bar=barbar
3207
[baz]
3208
foo_in_baz=barbaz
3209
[[qux]]
3210
foo_in_qux=quux
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3211
''')
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3212
        sections = list(store.get_sections())
3213
        self.assertLength(4, sections)
3214
        # The default section has no name.
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3215
        # List values are provided as strings and need to be explicitly
3216
        # converted by specifying from_unicode=list_from_store at option
3217
        # registration
3218
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
3219
                                  sections[0])
3220
        self.assertSectionContent(
3221
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
3222
        self.assertSectionContent(
3223
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3224
        # sub sections are provided as embedded dicts.
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
3225
        self.assertSectionContent(
3226
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
3227
            sections[3])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3228
5743.4.5 by Vincent Ladeuil
Split store tests between readonly and mutable ones.
3229
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3230
class TestLockableIniFileStore(TestStore):
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3231
3232
    def test_create_store_in_created_dir(self):
5743.6.21 by Vincent Ladeuil
Tighten the test.
3233
        self.assertPathDoesNotExist('dir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3234
        t = self.get_transport('dir/subdir')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3235
        store = config.LockableIniFileStore(t, 'foo.conf')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3236
        store.get_mutable_section(None).set('foo', 'bar')
3237
        store.save()
5743.6.21 by Vincent Ladeuil
Tighten the test.
3238
        self.assertPathExists('dir/subdir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3239
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3240
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3241
class TestConcurrentStoreUpdates(TestStore):
5743.10.13 by Vincent Ladeuil
Mention that the the concurrent update tests are not targeted at *all* Store implementations.
3242
    """Test that Stores properly handle conccurent updates.
3243
3244
    New Store implementation may fail some of these tests but until such
3245
    implementations exist it's hard to properly filter them from the scenarios
3246
    applied here. If you encounter such a case, contact the bzr devs.
3247
    """
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3248
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3249
    scenarios = [(key, {'get_stack': builder}) for key, builder
3250
                 in config.test_stack_builder_registry.iteritems()]
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3251
3252
    def setUp(self):
3253
        super(TestConcurrentStoreUpdates, self).setUp()
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3254
        self.stack = self.get_stack(self)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3255
        if not isinstance(self.stack, config._CompatibleStack):
3256
            raise tests.TestNotApplicable(
3257
                '%s is not meant to be compatible with the old config design'
3258
                % (self.stack,))
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3259
        self.stack.set('one', '1')
3260
        self.stack.set('two', '2')
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3261
        # Flush the store
3262
        self.stack.store.save()
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3263
3264
    def test_simple_read_access(self):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3265
        self.assertEqual('1', self.stack.get('one'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3266
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3267
    def test_simple_write_access(self):
3268
        self.stack.set('one', 'one')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3269
        self.assertEqual('one', self.stack.get('one'))
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3270
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3271
    def test_listen_to_the_last_speaker(self):
3272
        c1 = self.stack
3273
        c2 = self.get_stack(self)
3274
        c1.set('one', 'ONE')
3275
        c2.set('two', 'TWO')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3276
        self.assertEqual('ONE', c1.get('one'))
3277
        self.assertEqual('TWO', c2.get('two'))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3278
        # The second update respect the first one
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3279
        self.assertEqual('ONE', c2.get('one'))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3280
3281
    def test_last_speaker_wins(self):
3282
        # If the same config is not shared, the same variable modified twice
3283
        # can only see a single result.
3284
        c1 = self.stack
3285
        c2 = self.get_stack(self)
3286
        c1.set('one', 'c1')
3287
        c2.set('one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3288
        self.assertEqual('c2', c2.get('one'))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3289
        # The first modification is still available until another refresh
3290
        # occur
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3291
        self.assertEqual('c1', c1.get('one'))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3292
        c1.set('two', 'done')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3293
        self.assertEqual('c2', c1.get('one'))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3294
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3295
    def test_writes_are_serialized(self):
3296
        c1 = self.stack
3297
        c2 = self.get_stack(self)
3298
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3299
        # We spawn a thread that will pause *during* the config saving.
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3300
        before_writing = threading.Event()
3301
        after_writing = threading.Event()
3302
        writing_done = threading.Event()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3303
        c1_save_without_locking_orig = c1.store.save_without_locking
3304
        def c1_save_without_locking():
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3305
            before_writing.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3306
            c1_save_without_locking_orig()
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3307
            # The lock is held. We wait for the main thread to decide when to
3308
            # continue
3309
            after_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3310
        c1.store.save_without_locking = c1_save_without_locking
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3311
        def c1_set():
3312
            c1.set('one', 'c1')
3313
            writing_done.set()
3314
        t1 = threading.Thread(target=c1_set)
3315
        # Collect the thread after the test
3316
        self.addCleanup(t1.join)
3317
        # Be ready to unblock the thread if the test goes wrong
3318
        self.addCleanup(after_writing.set)
3319
        t1.start()
3320
        before_writing.wait()
3321
        self.assertRaises(errors.LockContention,
3322
                          c2.set, 'one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3323
        self.assertEqual('c1', c1.get('one'))
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3324
        # Let the lock be released
3325
        after_writing.set()
3326
        writing_done.wait()
3327
        c2.set('one', 'c2')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3328
        self.assertEqual('c2', c2.get('one'))
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3329
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3330
    def test_read_while_writing(self):
3331
       c1 = self.stack
3332
       # We spawn a thread that will pause *during* the write
3333
       ready_to_write = threading.Event()
3334
       do_writing = threading.Event()
3335
       writing_done = threading.Event()
3336
       # We override the _save implementation so we know the store is locked
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3337
       c1_save_without_locking_orig = c1.store.save_without_locking
3338
       def c1_save_without_locking():
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3339
           ready_to_write.set()
3340
           # The lock is held. We wait for the main thread to decide when to
3341
           # continue
3342
           do_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3343
           c1_save_without_locking_orig()
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3344
           writing_done.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3345
       c1.store.save_without_locking = c1_save_without_locking
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3346
       def c1_set():
3347
           c1.set('one', 'c1')
3348
       t1 = threading.Thread(target=c1_set)
3349
       # Collect the thread after the test
3350
       self.addCleanup(t1.join)
3351
       # Be ready to unblock the thread if the test goes wrong
3352
       self.addCleanup(do_writing.set)
3353
       t1.start()
3354
       # Ensure the thread is ready to write
3355
       ready_to_write.wait()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3356
       self.assertEqual('c1', c1.get('one'))
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3357
       # If we read during the write, we get the old value
3358
       c2 = self.get_stack(self)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3359
       self.assertEqual('1', c2.get('one'))
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3360
       # Let the writing occur and ensure it occurred
3361
       do_writing.set()
3362
       writing_done.wait()
3363
       # Now we get the updated value
3364
       c3 = self.get_stack(self)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3365
       self.assertEqual('c1', c3.get('one'))
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3366
3367
    # FIXME: It may be worth looking into removing the lock dir when it's not
3368
    # needed anymore and look at possible fallouts for concurrent lockers. This
3369
    # will matter if/when we use config files outside of bazaar directories
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3370
    # (.bazaar or .bzr) -- vila 20110-04-111
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3371
3372
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3373
class TestSectionMatcher(TestStore):
3374
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3375
    scenarios = [('location', {'matcher': config.LocationMatcher}),
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3376
                 ('id', {'matcher': config.NameMatcher}),]
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3377
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3378
    def setUp(self):
3379
        super(TestSectionMatcher, self).setUp()
3380
        # Any simple store is good enough
3381
        self.get_store = config.test_store_builder_registry.get('configobj')
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3382
3383
    def test_no_matches_for_empty_stores(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3384
        store = self.get_store(self)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3385
        store._load_from_string('')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3386
        matcher = self.matcher(store, '/bar')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3387
        self.assertEqual([], list(matcher.get_sections()))
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3388
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3389
    def test_build_doesnt_load_store(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3390
        store = self.get_store(self)
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
3391
        self.matcher(store, '/bar')
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3392
        self.assertFalse(store.is_loaded())
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3393
3394
3395
class TestLocationSection(tests.TestCase):
3396
3397
    def get_section(self, options, extra_path):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3398
        section = config.Section('foo', options)
6402.2.1 by Vincent Ladeuil
Get rid of LocationSection.length as its not needed in the general case.
3399
        return config.LocationSection(section, extra_path)
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3400
3401
    def test_simple_option(self):
3402
        section = self.get_section({'foo': 'bar'}, '')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3403
        self.assertEqual('bar', section.get('foo'))
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3404
3405
    def test_option_with_extra_path(self):
3406
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
3407
                                   'baz')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3408
        self.assertEqual('bar/baz', section.get('foo'))
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3409
3410
    def test_invalid_policy(self):
3411
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
3412
                                   'baz')
3413
        # invalid policies are ignored
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3414
        self.assertEqual('bar', section.get('foo'))
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3415
3416
3417
class TestLocationMatcher(TestStore):
3418
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3419
    def setUp(self):
3420
        super(TestLocationMatcher, self).setUp()
3421
        # Any simple store is good enough
3422
        self.get_store = config.test_store_builder_registry.get('configobj')
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3423
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3424
    def test_unrelated_section_excluded(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3425
        store = self.get_store(self)
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3426
        store._load_from_string('''
3427
[/foo]
3428
section=/foo
3429
[/foo/baz]
3430
section=/foo/baz
3431
[/foo/bar]
3432
section=/foo/bar
3433
[/foo/bar/baz]
3434
section=/foo/bar/baz
3435
[/quux/quux]
3436
section=/quux/quux
3437
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3438
        self.assertEqual(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3439
                           '/quux/quux'],
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3440
                          [section.id for _, section in store.get_sections()])
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3441
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3442
        sections = [section for _, section in matcher.get_sections()]
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3443
        self.assertEqual(['/foo/bar', '/foo'],
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3444
                          [section.id for section in sections])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3445
        self.assertEqual(['quux', 'bar/quux'],
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3446
                          [section.extra_path for section in sections])
3447
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3448
    def test_more_specific_sections_first(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3449
        store = self.get_store(self)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3450
        store._load_from_string('''
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3451
[/foo]
3452
section=/foo
3453
[/foo/bar]
3454
section=/foo/bar
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3455
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3456
        self.assertEqual(['/foo', '/foo/bar'],
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3457
                          [section.id for _, section in store.get_sections()])
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3458
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3459
        sections = [section for _, section in matcher.get_sections()]
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3460
        self.assertEqual(['/foo/bar', '/foo'],
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3461
                          [section.id for section in sections])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3462
        self.assertEqual(['baz', 'bar/baz'],
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3463
                          [section.extra_path for section in sections])
3464
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3465
    def test_appendpath_in_no_name_section(self):
3466
        # It's a bit weird to allow appendpath in a no-name section, but
3467
        # someone may found a use for it
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3468
        store = self.get_store(self)
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3469
        store._load_from_string('''
3470
foo=bar
3471
foo:policy = appendpath
3472
''')
3473
        matcher = config.LocationMatcher(store, 'dir/subdir')
3474
        sections = list(matcher.get_sections())
3475
        self.assertLength(1, sections)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3476
        self.assertEqual('bar/dir/subdir', sections[0][1].get('foo'))
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3477
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3478
    def test_file_urls_are_normalized(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3479
        store = self.get_store(self)
5912.3.1 by Vincent Ladeuil
Fix spurious windows-specific test failure
3480
        if sys.platform == 'win32':
3481
            expected_url = 'file:///C:/dir/subdir'
3482
            expected_location = 'C:/dir/subdir'
3483
        else:
3484
            expected_url = 'file:///dir/subdir'
3485
            expected_location = '/dir/subdir'
3486
        matcher = config.LocationMatcher(store, expected_url)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3487
        self.assertEqual(expected_location, matcher.location)
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3488
6524.2.4 by Aaron Bentley
branchname falls back to basename.
3489
    def test_branch_name_colo(self):
3490
        store = self.get_store(self)
3491
        store._load_from_string(dedent("""\
3492
            [/]
3493
            push_location=my{branchname}
3494
        """))
3495
        matcher = config.LocationMatcher(store, 'file:///,branch=example%3c')
3496
        self.assertEqual('example<', matcher.branch_name)
3497
        ((_, section),) = matcher.get_sections()
3498
        self.assertEqual('example<', section.locals['branchname'])
3499
3500
    def test_branch_name_basename(self):
3501
        store = self.get_store(self)
3502
        store._load_from_string(dedent("""\
3503
            [/]
3504
            push_location=my{branchname}
3505
        """))
3506
        matcher = config.LocationMatcher(store, 'file:///parent/example%3c')
3507
        self.assertEqual('example<', matcher.branch_name)
3508
        ((_, section),) = matcher.get_sections()
3509
        self.assertEqual('example<', section.locals['branchname'])
3510
5743.1.20 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3511
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3512
class TestStartingPathMatcher(TestStore):
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3513
3514
    def setUp(self):
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3515
        super(TestStartingPathMatcher, self).setUp()
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3516
        # Any simple store is good enough
3517
        self.store = config.IniFileStore()
3518
3519
    def assertSectionIDs(self, expected, location, content):
3520
        self.store._load_from_string(content)
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3521
        matcher = config.StartingPathMatcher(self.store, location)
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3522
        sections = list(matcher.get_sections())
3523
        self.assertLength(len(expected), sections)
3524
        self.assertEqual(expected, [section.id for _, section in sections])
3525
        return sections
3526
3527
    def test_empty(self):
6402.2.7 by Vincent Ladeuil
Cleanup a bit and make sure we use at least one file:// url in the tests.
3528
        self.assertSectionIDs([], self.get_url(), '')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3529
6402.2.8 by Vincent Ladeuil
Feedback from review.
3530
    def test_url_vs_local_paths(self):
3531
        # The matcher location is an url and the section names are local paths
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
3532
        self.assertSectionIDs(['/foo/bar', '/foo'],
3533
                              'file:///foo/bar/baz', '''\
6402.2.8 by Vincent Ladeuil
Feedback from review.
3534
[/foo]
3535
[/foo/bar]
3536
''')
3537
3538
    def test_local_path_vs_url(self):
3539
        # The matcher location is a local path and the section names are urls
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
3540
        self.assertSectionIDs(['file:///foo/bar', 'file:///foo'],
3541
                              '/foo/bar/baz', '''\
6402.2.8 by Vincent Ladeuil
Feedback from review.
3542
[file:///foo]
3543
[file:///foo/bar]
3544
''')
3545
3546
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3547
    def test_no_name_section_included_when_present(self):
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3548
        # Note that other tests will cover the case where the no-name section
3549
        # is empty and as such, not included.
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3550
        sections = self.assertSectionIDs(['/foo/bar', '/foo', None],
3551
                                         '/foo/bar/baz', '''\
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3552
option = defined so the no-name section exists
3553
[/foo]
3554
[/foo/bar]
3555
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3556
        self.assertEqual(['baz', 'bar/baz', '/foo/bar/baz'],
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3557
                          [s.locals['relpath'] for _, s in sections])
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3558
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3559
    def test_order_reversed(self):
3560
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
3561
[/foo]
3562
[/foo/bar]
3563
''')
3564
3565
    def test_unrelated_section_excluded(self):
3566
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
3567
[/foo]
3568
[/foo/qux]
3569
[/foo/bar]
3570
''')
3571
3572
    def test_glob_included(self):
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3573
        sections = self.assertSectionIDs(['/foo/*/baz', '/foo/b*', '/foo'],
3574
                                         '/foo/bar/baz', '''\
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3575
[/foo]
3576
[/foo/qux]
3577
[/foo/b*]
3578
[/foo/*/baz]
3579
''')
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3580
        # Note that 'baz' as a relpath for /foo/b* is not fully correct, but
6402.2.8 by Vincent Ladeuil
Feedback from review.
3581
        # nothing really is... as far using {relpath} to append it to something
3582
        # else, this seems good enough though.
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3583
        self.assertEqual(['', 'baz', 'bar/baz'],
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3584
                          [s.locals['relpath'] for _, s in sections])
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3585
3586
    def test_respect_order(self):
3587
        self.assertSectionIDs(['/foo', '/foo/b*', '/foo/*/baz'],
3588
                              '/foo/bar/baz', '''\
3589
[/foo/*/baz]
3590
[/foo/qux]
3591
[/foo/b*]
3592
[/foo]
3593
''')
3594
3595
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3596
class TestNameMatcher(TestStore):
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3597
3598
    def setUp(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3599
        super(TestNameMatcher, self).setUp()
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3600
        self.matcher = config.NameMatcher
3601
        # Any simple store is good enough
3602
        self.get_store = config.test_store_builder_registry.get('configobj')
3603
3604
    def get_matching_sections(self, name):
3605
        store = self.get_store(self)
3606
        store._load_from_string('''
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3607
[foo]
3608
option=foo
3609
[foo/baz]
3610
option=foo/baz
3611
[bar]
3612
option=bar
3613
''')
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3614
        matcher = self.matcher(store, name)
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3615
        return list(matcher.get_sections())
3616
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3617
    def test_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3618
        sections = self.get_matching_sections('foo')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3619
        self.assertLength(1, sections)
3620
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
3621
3622
    def test_not_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3623
        sections = self.get_matching_sections('baz')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3624
        self.assertLength(0, sections)
3625
3626
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3627
class TestBaseStackGet(tests.TestCase):
3628
3629
    def setUp(self):
3630
        super(TestBaseStackGet, self).setUp()
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3631
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3632
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3633
    def test_get_first_definition(self):
3634
        store1 = config.IniFileStore()
3635
        store1._load_from_string('foo=bar')
3636
        store2 = config.IniFileStore()
3637
        store2._load_from_string('foo=baz')
3638
        conf = config.Stack([store1.get_sections, store2.get_sections])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3639
        self.assertEqual('bar', conf.get('foo'))
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3640
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3641
    def test_get_with_registered_default_value(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3642
        config.option_registry.register(config.Option('foo', default='bar'))
3643
        conf_stack = config.Stack([])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3644
        self.assertEqual('bar', conf_stack.get('foo'))
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
3645
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3646
    def test_get_without_registered_default_value(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3647
        config.option_registry.register(config.Option('foo'))
3648
        conf_stack = config.Stack([])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3649
        self.assertEqual(None, conf_stack.get('foo'))
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3650
3651
    def test_get_without_default_value_for_not_registered(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3652
        conf_stack = config.Stack([])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3653
        self.assertEqual(None, conf_stack.get('foo'))
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3654
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3655
    def test_get_for_empty_section_callable(self):
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3656
        conf_stack = config.Stack([lambda : []])
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3657
        self.assertEqual(None, conf_stack.get('foo'))
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3658
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3659
    def test_get_for_broken_callable(self):
3660
        # Trying to use and invalid callable raises an exception on first use
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3661
        conf_stack = config.Stack([object])
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3662
        self.assertRaises(TypeError, conf_stack.get, 'foo')
3663
3664
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3665
class TestStackWithSimpleStore(tests.TestCase):
3666
3667
    def setUp(self):
3668
        super(TestStackWithSimpleStore, self).setUp()
3669
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3670
        self.registry = config.option_registry
3671
3672
    def get_conf(self, content=None):
3673
        return config.MemoryStack(content)
3674
3675
    def test_override_value_from_env(self):
6523.1.1 by Vincent Ladeuil
Fix some test issues raised by mgz.
3676
        self.overrideEnv('FOO', None)
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3677
        self.registry.register(
3678
            config.Option('foo', default='bar', override_from_env=['FOO']))
3679
        self.overrideEnv('FOO', 'quux')
3680
        # Env variable provides a default taking over the option one
3681
        conf = self.get_conf('foo=store')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3682
        self.assertEqual('quux', conf.get('foo'))
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3683
3684
    def test_first_override_value_from_env_wins(self):
6523.1.1 by Vincent Ladeuil
Fix some test issues raised by mgz.
3685
        self.overrideEnv('NO_VALUE', None)
3686
        self.overrideEnv('FOO', None)
3687
        self.overrideEnv('BAZ', None)
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3688
        self.registry.register(
3689
            config.Option('foo', default='bar',
3690
                          override_from_env=['NO_VALUE', 'FOO', 'BAZ']))
3691
        self.overrideEnv('FOO', 'foo')
3692
        self.overrideEnv('BAZ', 'baz')
3693
        # The first env var set wins
3694
        conf = self.get_conf('foo=store')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3695
        self.assertEqual('foo', conf.get('foo'))
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3696
3697
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3698
class TestMemoryStack(tests.TestCase):
3699
3700
    def test_get(self):
3701
        conf = config.MemoryStack('foo=bar')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3702
        self.assertEqual('bar', conf.get('foo'))
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3703
3704
    def test_set(self):
3705
        conf = config.MemoryStack('foo=bar')
3706
        conf.set('foo', 'baz')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3707
        self.assertEqual('baz', conf.get('foo'))
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3708
3709
    def test_no_content(self):
3710
        conf = config.MemoryStack()
3711
        # No content means no loading
3712
        self.assertFalse(conf.store.is_loaded())
6393.1.2 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
3713
        self.assertRaises(NotImplementedError, conf.get, 'foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3714
        # But a content can still be provided
3715
        conf.store._load_from_string('foo=bar')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3716
        self.assertEqual('bar', conf.get('foo'))
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3717
3718
6466.1.4 by Vincent Ladeuil
Fix typo and add tests.
3719
class TestStackIterSections(tests.TestCase):
3720
3721
    def test_empty_stack(self):
3722
        conf = config.Stack([])
3723
        sections = list(conf.iter_sections())
3724
        self.assertLength(0, sections)
3725
3726
    def test_empty_store(self):
3727
        store = config.IniFileStore()
3728
        store._load_from_string('')
3729
        conf = config.Stack([store.get_sections])
3730
        sections = list(conf.iter_sections())
3731
        self.assertLength(0, sections)
3732
3733
    def test_simple_store(self):
3734
        store = config.IniFileStore()
3735
        store._load_from_string('foo=bar')
3736
        conf = config.Stack([store.get_sections])
3737
        tuples = list(conf.iter_sections())
3738
        self.assertLength(1, tuples)
3739
        (found_store, found_section) = tuples[0]
3740
        self.assertIs(store, found_store)
3741
3742
    def test_two_stores(self):
3743
        store1 = config.IniFileStore()
3744
        store1._load_from_string('foo=bar')
3745
        store2 = config.IniFileStore()
3746
        store2._load_from_string('bar=qux')
3747
        conf = config.Stack([store1.get_sections, store2.get_sections])
3748
        tuples = list(conf.iter_sections())
3749
        self.assertLength(2, tuples)
3750
        self.assertIs(store1, tuples[0][0])
3751
        self.assertIs(store2, tuples[1][0])
3752
3753
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3754
class TestStackWithTransport(tests.TestCaseWithTransport):
3755
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3756
    scenarios = [(key, {'get_stack': builder}) for key, builder
3757
                 in config.test_stack_builder_registry.iteritems()]
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3758
3759
5743.11.1 by Vincent Ladeuil
Add a note about config store builders being called several times by some tests.
3760
class TestConcreteStacks(TestStackWithTransport):
3761
3762
    def test_build_stack(self):
3763
        # Just a smoke test to help debug builders
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
3764
        self.get_stack(self)
5743.11.1 by Vincent Ladeuil
Add a note about config store builders being called several times by some tests.
3765
3766
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3767
class TestStackGet(TestStackWithTransport):
3768
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3769
    def setUp(self):
3770
        super(TestStackGet, self).setUp()
3771
        self.conf = self.get_stack(self)
3772
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3773
    def test_get_for_empty_stack(self):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3774
        self.assertEqual(None, self.conf.get('foo'))
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3775
3776
    def test_get_hook(self):
6260.3.2 by Vincent Ladeuil
Only the DEFAULT section is searched for the normal uses of bazaar.conf
3777
        self.conf.set('foo', 'bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3778
        calls = []
3779
        def hook(*args):
3780
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3781
        config.ConfigHooks.install_named_hook('get', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3782
        self.assertLength(0, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3783
        value = self.conf.get('foo')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3784
        self.assertEqual('bar', value)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3785
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3786
        self.assertEqual((self.conf, 'foo', 'bar'), calls[0])
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3787
3788
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3789
class TestStackGetWithConverter(tests.TestCase):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3790
3791
    def setUp(self):
3792
        super(TestStackGetWithConverter, self).setUp()
3793
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3794
        self.registry = config.option_registry
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3795
3796
    def get_conf(self, content=None):
3797
        return config.MemoryStack(content)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3798
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3799
    def register_bool_option(self, name, default=None, default_from_env=None):
3800
        b = config.Option(name, help='A boolean.',
3801
                          default=default, default_from_env=default_from_env,
3802
                          from_unicode=config.bool_from_store)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3803
        self.registry.register(b)
3804
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3805
    def test_get_default_bool_None(self):
3806
        self.register_bool_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3807
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3808
        self.assertEqual(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3809
3810
    def test_get_default_bool_True(self):
3811
        self.register_bool_option('foo', u'True')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3812
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3813
        self.assertEqual(True, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3814
3815
    def test_get_default_bool_False(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3816
        self.register_bool_option('foo', False)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3817
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3818
        self.assertEqual(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3819
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3820
    def test_get_default_bool_False_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3821
        self.register_bool_option('foo', u'False')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3822
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3823
        self.assertEqual(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3824
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3825
    def test_get_default_bool_from_env_converted(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3826
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
3827
        self.overrideEnv('FOO', 'False')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3828
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3829
        self.assertEqual(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3830
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3831
    def test_get_default_bool_when_conversion_fails(self):
3832
        self.register_bool_option('foo', default='True')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3833
        conf = self.get_conf('foo=invalid boolean')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3834
        self.assertEqual(True, conf.get('foo'))
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3835
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3836
    def register_integer_option(self, name,
3837
                                default=None, default_from_env=None):
3838
        i = config.Option(name, help='An integer.',
3839
                          default=default, default_from_env=default_from_env,
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3840
                          from_unicode=config.int_from_store)
3841
        self.registry.register(i)
3842
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3843
    def test_get_default_integer_None(self):
3844
        self.register_integer_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3845
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3846
        self.assertEqual(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3847
3848
    def test_get_default_integer(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3849
        self.register_integer_option('foo', 42)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3850
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3851
        self.assertEqual(42, conf.get('foo'))
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3852
3853
    def test_get_default_integer_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3854
        self.register_integer_option('foo', u'42')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3855
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3856
        self.assertEqual(42, conf.get('foo'))
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3857
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3858
    def test_get_default_integer_from_env(self):
3859
        self.register_integer_option('foo', default_from_env=['FOO'])
3860
        self.overrideEnv('FOO', '18')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3861
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3862
        self.assertEqual(18, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3863
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3864
    def test_get_default_integer_when_conversion_fails(self):
3865
        self.register_integer_option('foo', default='12')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3866
        conf = self.get_conf('foo=invalid integer')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3867
        self.assertEqual(12, conf.get('foo'))
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3868
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3869
    def register_list_option(self, name, default=None, default_from_env=None):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3870
        l = config.ListOption(name, help='A list.', default=default,
3871
                              default_from_env=default_from_env)
6059.2.1 by Vincent Ladeuil
Implement list config options.
3872
        self.registry.register(l)
3873
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3874
    def test_get_default_list_None(self):
3875
        self.register_list_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3876
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3877
        self.assertEqual(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3878
3879
    def test_get_default_list_empty(self):
3880
        self.register_list_option('foo', '')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3881
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3882
        self.assertEqual([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3883
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3884
    def test_get_default_list_from_env(self):
3885
        self.register_list_option('foo', default_from_env=['FOO'])
3886
        self.overrideEnv('FOO', '')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3887
        conf = self.get_conf('')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3888
        self.assertEqual([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3889
3890
    def test_get_with_list_converter_no_item(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3891
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3892
        conf = self.get_conf('foo=,')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3893
        self.assertEqual([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3894
3895
    def test_get_with_list_converter_many_items(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3896
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3897
        conf = self.get_conf('foo=m,o,r,e')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3898
        self.assertEqual(['m', 'o', 'r', 'e'], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3899
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3900
    def test_get_with_list_converter_embedded_spaces_many_items(self):
3901
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3902
        conf = self.get_conf('foo=" bar", "baz "')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3903
        self.assertEqual([' bar', 'baz '], conf.get('foo'))
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3904
3905
    def test_get_with_list_converter_stripped_spaces_many_items(self):
3906
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3907
        conf = self.get_conf('foo= bar ,  baz ')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3908
        self.assertEqual(['bar', 'baz'], conf.get('foo'))
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3909
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3910
6082.5.20 by Vincent Ladeuil
Refactor iter_option_refs out of Stack so it can be reused.
3911
class TestIterOptionRefs(tests.TestCase):
3912
    """iter_option_refs is a bit unusual, document some cases."""
3913
3914
    def assertRefs(self, expected, string):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3915
        self.assertEqual(expected, list(config.iter_option_refs(string)))
6082.5.20 by Vincent Ladeuil
Refactor iter_option_refs out of Stack so it can be reused.
3916
3917
    def test_empty(self):
3918
        self.assertRefs([(False, '')], '')
3919
3920
    def test_no_refs(self):
3921
        self.assertRefs([(False, 'foo bar')], 'foo bar')
3922
3923
    def test_single_ref(self):
3924
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
3925
3926
    def test_broken_ref(self):
3927
        self.assertRefs([(False, '{foo')], '{foo')
3928
3929
    def test_embedded_ref(self):
3930
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
3931
                        '{{foo}}')
3932
3933
    def test_two_refs(self):
3934
        self.assertRefs([(False, ''), (True, '{foo}'),
3935
                         (False, ''), (True, '{bar}'),
3936
                         (False, ''),],
3937
                        '{foo}{bar}')
3938
6351.1.1 by Vincent Ladeuil
Don't accept \n as part of a config option reference
3939
    def test_newline_in_refs_are_not_matched(self):
3940
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
3941
6082.5.20 by Vincent Ladeuil
Refactor iter_option_refs out of Stack so it can be reused.
3942
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3943
class TestStackExpandOptions(tests.TestCaseWithTransport):
3944
3945
    def setUp(self):
3946
        super(TestStackExpandOptions, self).setUp()
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3947
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3948
        self.registry = config.option_registry
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3949
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
3950
        self.conf = config.Stack([store.get_sections], store)
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3951
3952
    def assertExpansion(self, expected, string, env=None):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3953
        self.assertEqual(expected, self.conf.expand_options(string, env))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3954
3955
    def test_no_expansion(self):
3956
        self.assertExpansion('foo', 'foo')
3957
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3958
    def test_expand_default_value(self):
3959
        self.conf.store._load_from_string('bar=baz')
3960
        self.registry.register(config.Option('foo', default=u'{bar}'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3961
        self.assertEqual('baz', self.conf.get('foo', expand=True))
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3962
3963
    def test_expand_default_from_env(self):
3964
        self.conf.store._load_from_string('bar=baz')
3965
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
3966
        self.overrideEnv('FOO', '{bar}')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3967
        self.assertEqual('baz', self.conf.get('foo', expand=True))
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3968
3969
    def test_expand_default_on_failed_conversion(self):
3970
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
3971
        self.registry.register(
3972
            config.Option('foo', default=u'{bar}',
3973
                          from_unicode=config.int_from_store))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
3974
        self.assertEqual(42, self.conf.get('foo', expand=True))
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3975
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3976
    def test_env_adding_options(self):
3977
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3978
3979
    def test_env_overriding_options(self):
3980
        self.conf.store._load_from_string('foo=baz')
3981
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3982
3983
    def test_simple_ref(self):
3984
        self.conf.store._load_from_string('foo=xxx')
3985
        self.assertExpansion('xxx', '{foo}')
3986
3987
    def test_unknown_ref(self):
3988
        self.assertRaises(errors.ExpandingUnknownOption,
3989
                          self.conf.expand_options, '{foo}')
3990
6587.2.2 by Vincent Ladeuil
Stricter checks on configuration option names
3991
    def test_illegal_def_is_ignored(self):
3992
        self.assertExpansion('{1,2}', '{1,2}')
3993
        self.assertExpansion('{ }', '{ }')
3994
        self.assertExpansion('${Foo,f}', '${Foo,f}')
3995
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3996
    def test_indirect_ref(self):
3997
        self.conf.store._load_from_string('''
3998
foo=xxx
3999
bar={foo}
4000
''')
4001
        self.assertExpansion('xxx', '{bar}')
4002
4003
    def test_embedded_ref(self):
4004
        self.conf.store._load_from_string('''
4005
foo=xxx
4006
bar=foo
4007
''')
4008
        self.assertExpansion('xxx', '{{bar}}')
4009
4010
    def test_simple_loop(self):
4011
        self.conf.store._load_from_string('foo={foo}')
4012
        self.assertRaises(errors.OptionExpansionLoop,
4013
                          self.conf.expand_options, '{foo}')
4014
4015
    def test_indirect_loop(self):
4016
        self.conf.store._load_from_string('''
4017
foo={bar}
4018
bar={baz}
4019
baz={foo}''')
4020
        e = self.assertRaises(errors.OptionExpansionLoop,
4021
                              self.conf.expand_options, '{foo}')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4022
        self.assertEqual('foo->bar->baz', e.refs)
4023
        self.assertEqual('{foo}', e.string)
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
4024
4025
    def test_list(self):
4026
        self.conf.store._load_from_string('''
4027
foo=start
4028
bar=middle
4029
baz=end
4030
list={foo},{bar},{baz}
4031
''')
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
4032
        self.registry.register(
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
4033
            config.ListOption('list'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4034
        self.assertEqual(['start', 'middle', 'end'],
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
4035
                           self.conf.get('list', expand=True))
4036
4037
    def test_cascading_list(self):
4038
        self.conf.store._load_from_string('''
4039
foo=start,{bar}
4040
bar=middle,{baz}
4041
baz=end
4042
list={foo}
4043
''')
6466.1.3 by Vincent Ladeuil
Values should never be converted during expansion.
4044
        self.registry.register(config.ListOption('list'))
4045
        # Register an intermediate option as a list to ensure no conversion
6466.1.4 by Vincent Ladeuil
Fix typo and add tests.
4046
        # happen while expanding. Conversion should only occur for the original
6466.1.3 by Vincent Ladeuil
Values should never be converted during expansion.
4047
        # option ('list' here).
4048
        self.registry.register(config.ListOption('baz'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4049
        self.assertEqual(['start', 'middle', 'end'],
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
4050
                           self.conf.get('list', expand=True))
4051
4052
    def test_pathologically_hidden_list(self):
4053
        self.conf.store._load_from_string('''
4054
foo=bin
4055
bar=go
4056
start={foo
4057
middle=},{
4058
end=bar}
4059
hidden={start}{middle}{end}
4060
''')
6082.5.13 by Vincent Ladeuil
Fix typos.
4061
        # What matters is what the registration says, the conversion happens
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
4062
        # only after all expansions have been performed
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
4063
        self.registry.register(config.ListOption('hidden'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4064
        self.assertEqual(['bin', 'go'],
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
4065
                          self.conf.get('hidden', expand=True))
4066
4067
4068
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
4069
4070
    def setUp(self):
4071
        super(TestStackCrossSectionsExpand, self).setUp()
4072
4073
    def get_config(self, location, string):
4074
        if string is None:
4075
            string = ''
4076
        # Since we don't save the config we won't strictly require to inherit
4077
        # from TestCaseInTempDir, but an error occurs so quickly...
4078
        c = config.LocationStack(location)
4079
        c.store._load_from_string(string)
4080
        return c
4081
4082
    def test_dont_cross_unrelated_section(self):
4083
        c = self.get_config('/another/branch/path','''
4084
[/one/branch/path]
4085
foo = hello
4086
bar = {foo}/2
4087
4088
[/another/branch/path]
4089
bar = {foo}/2
4090
''')
4091
        self.assertRaises(errors.ExpandingUnknownOption,
4092
                          c.get, 'bar', expand=True)
4093
4094
    def test_cross_related_sections(self):
4095
        c = self.get_config('/project/branch/path','''
4096
[/project]
4097
foo = qu
4098
4099
[/project/branch/path]
4100
bar = {foo}ux
4101
''')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4102
        self.assertEqual('quux', c.get('bar', expand=True))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
4103
4104
6082.5.19 by Vincent Ladeuil
Bah, cross stores expansion already works of course, tests added.
4105
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
4106
4107
    def test_cross_global_locations(self):
4108
        l_store = config.LocationStore()
4109
        l_store._load_from_string('''
4110
[/branch]
4111
lfoo = loc-foo
4112
lbar = {gbar}
4113
''')
4114
        l_store.save()
4115
        g_store = config.GlobalStore()
4116
        g_store._load_from_string('''
4117
[DEFAULT]
4118
gfoo = {lfoo}
4119
gbar = glob-bar
4120
''')
4121
        g_store.save()
4122
        stack = config.LocationStack('/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4123
        self.assertEqual('glob-bar', stack.get('lbar', expand=True))
4124
        self.assertEqual('loc-foo', stack.get('gfoo', expand=True))
6082.5.19 by Vincent Ladeuil
Bah, cross stores expansion already works of course, tests added.
4125
4126
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4127
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
4128
6082.5.25 by Vincent Ladeuil
Add ``basename`` as a section local option
4129
    def test_expand_locals_empty(self):
4130
        l_store = config.LocationStore()
4131
        l_store._load_from_string('''
4132
[/home/user/project]
4133
base = {basename}
4134
rel = {relpath}
4135
''')
4136
        l_store.save()
4137
        stack = config.LocationStack('/home/user/project/')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4138
        self.assertEqual('', stack.get('base', expand=True))
4139
        self.assertEqual('', stack.get('rel', expand=True))
6082.5.25 by Vincent Ladeuil
Add ``basename`` as a section local option
4140
4141
    def test_expand_basename_locally(self):
4142
        l_store = config.LocationStore()
4143
        l_store._load_from_string('''
4144
[/home/user/project]
4145
bfoo = {basename}
4146
''')
4147
        l_store.save()
4148
        stack = config.LocationStack('/home/user/project/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4149
        self.assertEqual('branch', stack.get('bfoo', expand=True))
6082.5.25 by Vincent Ladeuil
Add ``basename`` as a section local option
4150
6082.5.28 by Vincent Ladeuil
Add a test to better expose the feature
4151
    def test_expand_basename_locally_longer_path(self):
4152
        l_store = config.LocationStore()
4153
        l_store._load_from_string('''
4154
[/home/user]
4155
bfoo = {basename}
4156
''')
4157
        l_store.save()
4158
        stack = config.LocationStack('/home/user/project/dir/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4159
        self.assertEqual('branch', stack.get('bfoo', expand=True))
6082.5.28 by Vincent Ladeuil
Add a test to better expose the feature
4160
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4161
    def test_expand_relpath_locally(self):
4162
        l_store = config.LocationStore()
4163
        l_store._load_from_string('''
4164
[/home/user/project]
4165
lfoo = loc-foo/{relpath}
4166
''')
4167
        l_store.save()
4168
        stack = config.LocationStack('/home/user/project/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4169
        self.assertEqual('loc-foo/branch', stack.get('lfoo', expand=True))
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4170
4171
    def test_expand_relpath_unknonw_in_global(self):
4172
        g_store = config.GlobalStore()
4173
        g_store._load_from_string('''
4174
[DEFAULT]
4175
gfoo = {relpath}
4176
''')
4177
        g_store.save()
4178
        stack = config.LocationStack('/home/user/project/branch')
4179
        self.assertRaises(errors.ExpandingUnknownOption,
4180
                          stack.get, 'gfoo', expand=True)
4181
4182
    def test_expand_local_option_locally(self):
4183
        l_store = config.LocationStore()
4184
        l_store._load_from_string('''
4185
[/home/user/project]
4186
lfoo = loc-foo/{relpath}
4187
lbar = {gbar}
4188
''')
4189
        l_store.save()
4190
        g_store = config.GlobalStore()
4191
        g_store._load_from_string('''
4192
[DEFAULT]
4193
gfoo = {lfoo}
4194
gbar = glob-bar
4195
''')
4196
        g_store.save()
4197
        stack = config.LocationStack('/home/user/project/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4198
        self.assertEqual('glob-bar', stack.get('lbar', expand=True))
4199
        self.assertEqual('loc-foo/branch', stack.get('gfoo', expand=True))
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4200
4201
    def test_locals_dont_leak(self):
4202
        """Make sure we chose the right local in presence of several sections.
4203
        """
4204
        l_store = config.LocationStore()
4205
        l_store._load_from_string('''
4206
[/home/user]
4207
lfoo = loc-foo/{relpath}
4208
[/home/user/project]
4209
lfoo = loc-foo/{relpath}
4210
''')
4211
        l_store.save()
4212
        stack = config.LocationStack('/home/user/project/branch')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4213
        self.assertEqual('loc-foo/branch', stack.get('lfoo', expand=True))
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4214
        stack = config.LocationStack('/home/user/bar/baz')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4215
        self.assertEqual('loc-foo/bar/baz', stack.get('lfoo', expand=True))
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4216
4217
6270.1.20 by Jelmer Vernooij
Revert RemoteBranchStack / RemoteControlStack changes.
4218
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4219
class TestStackSet(TestStackWithTransport):
4220
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4221
    def test_simple_set(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4222
        conf = self.get_stack(self)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4223
        self.assertEqual(None, conf.get('foo'))
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4224
        conf.set('foo', 'baz')
4225
        # Did we get it back ?
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4226
        self.assertEqual('baz', conf.get('foo'))
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4227
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4228
    def test_set_creates_a_new_section(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4229
        conf = self.get_stack(self)
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4230
        conf.set('foo', 'baz')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4231
        self.assertEqual, 'baz', conf.get('foo')
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4232
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4233
    def test_set_hook(self):
4234
        calls = []
4235
        def hook(*args):
4236
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
4237
        config.ConfigHooks.install_named_hook('set', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4238
        self.assertLength(0, calls)
4239
        conf = self.get_stack(self)
4240
        conf.set('foo', 'bar')
4241
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4242
        self.assertEqual((conf, 'foo', 'bar'), calls[0])
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4243
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4244
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4245
class TestStackRemove(TestStackWithTransport):
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4246
4247
    def test_remove_existing(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4248
        conf = self.get_stack(self)
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
4249
        conf.set('foo', 'bar')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4250
        self.assertEqual('bar', conf.get('foo'))
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4251
        conf.remove('foo')
4252
        # Did we get it back ?
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4253
        self.assertEqual(None, conf.get('foo'))
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4254
4255
    def test_remove_unknown(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4256
        conf = self.get_stack(self)
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4257
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
4258
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4259
    def test_remove_hook(self):
4260
        calls = []
4261
        def hook(*args):
4262
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
4263
        config.ConfigHooks.install_named_hook('remove', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4264
        self.assertLength(0, calls)
4265
        conf = self.get_stack(self)
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
4266
        conf.set('foo', 'bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4267
        conf.remove('foo')
4268
        self.assertLength(1, calls)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4269
        self.assertEqual((conf, 'foo'), calls[0])
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4270
5743.6.1 by Vincent Ladeuil
Outline concrete stacks and basic smoke tests.
4271
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
4272
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4273
4274
    def setUp(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4275
        super(TestConfigGetOptions, self).setUp()
4276
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4277
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4278
    def test_no_variable(self):
4279
        # Using branch should query branch, locations and bazaar
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4280
        self.assertOptions([], self.branch_config)
4281
4282
    def test_option_in_bazaar(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4283
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4284
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4285
                           self.bazaar_config)
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4286
4287
    def test_option_in_locations(self):
4288
        self.locations_config.set_user_option('file', 'locations')
4289
        self.assertOptions(
4290
            [('file', 'locations', self.tree.basedir, 'locations')],
4291
            self.locations_config)
4292
4293
    def test_option_in_branch(self):
4294
        self.branch_config.set_user_option('file', 'branch')
4295
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
4296
                           self.branch_config)
4297
4298
    def test_option_in_bazaar_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4299
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4300
        self.branch_config.set_user_option('file', 'branch')
4301
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
4302
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4303
                           self.branch_config)
4304
4305
    def test_option_in_branch_and_locations(self):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4306
        # Hmm, locations override branch :-/
4307
        self.locations_config.set_user_option('file', 'locations')
4308
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4309
        self.assertOptions(
4310
            [('file', 'locations', self.tree.basedir, 'locations'),
4311
             ('file', 'branch', 'DEFAULT', 'branch'),],
4312
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4313
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4314
    def test_option_in_bazaar_locations_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4315
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4316
        self.locations_config.set_user_option('file', 'locations')
4317
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4318
        self.assertOptions(
4319
            [('file', 'locations', self.tree.basedir, 'locations'),
4320
             ('file', 'branch', 'DEFAULT', 'branch'),
4321
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4322
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4323
4324
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
4325
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4326
4327
    def setUp(self):
4328
        super(TestConfigRemoveOption, self).setUp()
4329
        create_configs_with_file_option(self)
4330
5447.4.11 by Vincent Ladeuil
Implement ``bzr config --remove <option>``.
4331
    def test_remove_in_locations(self):
4332
        self.locations_config.remove_user_option('file', self.tree.basedir)
4333
        self.assertOptions(
4334
            [('file', 'branch', 'DEFAULT', 'branch'),
4335
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4336
            self.branch_config)
4337
4338
    def test_remove_in_branch(self):
4339
        self.branch_config.remove_user_option('file')
4340
        self.assertOptions(
4341
            [('file', 'locations', self.tree.basedir, 'locations'),
4342
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4343
            self.branch_config)
4344
4345
    def test_remove_in_bazaar(self):
4346
        self.bazaar_config.remove_user_option('file')
4347
        self.assertOptions(
4348
            [('file', 'locations', self.tree.basedir, 'locations'),
4349
             ('file', 'branch', 'DEFAULT', 'branch'),],
4350
            self.branch_config)
4351
5447.4.7 by Vincent Ladeuil
Check error message if the test is checking for errors or we have unexpected success for wrong errors.
4352
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4353
class TestConfigGetSections(tests.TestCaseWithTransport):
4354
4355
    def setUp(self):
4356
        super(TestConfigGetSections, self).setUp()
4357
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4358
4359
    def assertSectionNames(self, expected, conf, name=None):
4360
        """Check which sections are returned for a given config.
4361
4362
        If fallback configurations exist their sections can be included.
4363
4364
        :param expected: A list of section names.
4365
4366
        :param conf: The configuration that will be queried.
4367
4368
        :param name: An optional section name that will be passed to
4369
            get_sections().
4370
        """
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
4371
        sections = list(conf._get_sections(name))
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4372
        self.assertLength(len(expected), sections)
6587.2.1 by Vincent Ladeuil
Fix pep8 warnings: unused import, unused variables, shadowing variables.
4373
        self.assertEqual(expected, [n for n, _, _ in sections])
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4374
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4375
    def test_bazaar_default_section(self):
4376
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4377
4378
    def test_locations_default_section(self):
4379
        # No sections are defined in an empty file
4380
        self.assertSectionNames([], self.locations_config)
4381
4382
    def test_locations_named_section(self):
4383
        self.locations_config.set_user_option('file', 'locations')
4384
        self.assertSectionNames([self.tree.basedir], self.locations_config)
4385
4386
    def test_locations_matching_sections(self):
4387
        loc_config = self.locations_config
4388
        loc_config.set_user_option('file', 'locations')
4389
        # We need to cheat a bit here to create an option in sections above and
4390
        # below the 'location' one.
4391
        parser = loc_config._get_parser()
4392
        # locations.cong deals with '/' ignoring native os.sep
4393
        location_names = self.tree.basedir.split('/')
4394
        parent = '/'.join(location_names[:-1])
4395
        child = '/'.join(location_names + ['child'])
4396
        parser[parent] = {}
4397
        parser[parent]['file'] = 'parent'
4398
        parser[child] = {}
4399
        parser[child]['file'] = 'child'
4400
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
4401
4402
    def test_branch_data_default_section(self):
4403
        self.assertSectionNames([None],
4404
                                self.branch_config._get_branch_data_config())
4405
4406
    def test_branch_default_sections(self):
4407
        # No sections are defined in an empty locations file
4408
        self.assertSectionNames([None, 'DEFAULT'],
4409
                                self.branch_config)
4410
        # Unless we define an option
4411
        self.branch_config._get_location_config().set_user_option(
4412
            'file', 'locations')
4413
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
4414
                                self.branch_config)
4415
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4416
    def test_bazaar_named_section(self):
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4417
        # We need to cheat as the API doesn't give direct access to sections
4418
        # other than DEFAULT.
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4419
        self.bazaar_config.set_alias('bazaar', 'bzr')
4420
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4421
4422
6499.3.6 by Vincent Ladeuil
Add test to ensure local config files are shared.
4423
class TestSharedStores(tests.TestCaseInTempDir):
4424
4425
    def test_bazaar_conf_shared(self):
4426
        g1 = config.GlobalStack()
4427
        g2 = config.GlobalStack()
4428
        # The two stacks share the same store
4429
        self.assertIs(g1.store, g2.store)
4430
4431
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4432
class TestAuthenticationConfigFile(tests.TestCase):
2900.2.14 by Vincent Ladeuil
More tests.
4433
    """Test the authentication.conf file matching"""
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4434
4435
    def _got_user_passwd(self, expected_user, expected_password,
4436
                         config, *args, **kwargs):
4437
        credentials = config.get_credentials(*args, **kwargs)
4438
        if credentials is None:
4439
            user = None
4440
            password = None
4441
        else:
4442
            user = credentials['user']
4443
            password = credentials['password']
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4444
        self.assertEqual(expected_user, user)
4445
        self.assertEqual(expected_password, password)
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4446
2978.5.1 by John Arbash Meinel
Fix bug #162494, 'bzr register-branch' needs proper auth handling.
4447
    def test_empty_config(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4448
        conf = config.AuthenticationConfig(_file=StringIO())
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4449
        self.assertEqual({}, conf._get_config())
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4450
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
4451
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
4452
    def test_non_utf8_config(self):
4453
        conf = config.AuthenticationConfig(_file=StringIO(
4454
                'foo = bar\xff'))
5987.1.3 by Vincent Ladeuil
Proper message when authentication.conf has non-utf8 content
4455
        self.assertRaises(errors.ConfigContentError, conf._get_config)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
4456
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4457
    def test_missing_auth_section_header(self):
4458
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
4459
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
4460
4461
    def test_auth_section_header_not_closed(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4462
        conf = config.AuthenticationConfig(_file=StringIO('[DEF'))
4463
        self.assertRaises(errors.ParseConfigError, conf._get_config)
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4464
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4465
    def test_auth_value_not_boolean(self):
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4466
        conf = config.AuthenticationConfig(_file=StringIO(
4467
                """[broken]
4468
scheme=ftp
4469
user=joe
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4470
verify_certificates=askme # Error: Not a boolean
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4471
"""))
4472
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4473
4474
    def test_auth_value_not_int(self):
2900.2.22 by Vincent Ladeuil
Polishing.
4475
        conf = config.AuthenticationConfig(_file=StringIO(
4476
                """[broken]
4477
scheme=ftp
4478
user=joe
4479
port=port # Error: Not an int
4480
"""))
4481
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4482
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4483
    def test_unknown_password_encoding(self):
4484
        conf = config.AuthenticationConfig(_file=StringIO(
4485
                """[broken]
4486
scheme=ftp
4487
user=joe
4488
password_encoding=unknown
4489
"""))
4490
        self.assertRaises(ValueError, conf.get_password,
4491
                          'ftp', 'foo.net', 'joe')
4492
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4493
    def test_credentials_for_scheme_host(self):
4494
        conf = config.AuthenticationConfig(_file=StringIO(
4495
                """# Identity on foo.net
4496
[ftp definition]
4497
scheme=ftp
4498
host=foo.net
4499
user=joe
4500
password=secret-pass
4501
"""))
4502
        # Basic matching
4503
        self._got_user_passwd('joe', 'secret-pass', conf, 'ftp', 'foo.net')
4504
        # different scheme
4505
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
4506
        # different host
4507
        self._got_user_passwd(None, None, conf, 'ftp', 'bar.net')
4508
4509
    def test_credentials_for_host_port(self):
4510
        conf = config.AuthenticationConfig(_file=StringIO(
4511
                """# Identity on foo.net
4512
[ftp definition]
4513
scheme=ftp
4514
port=10021
4515
host=foo.net
4516
user=joe
4517
password=secret-pass
4518
"""))
4519
        # No port
4520
        self._got_user_passwd('joe', 'secret-pass',
4521
                              conf, 'ftp', 'foo.net', port=10021)
4522
        # different port
4523
        self._got_user_passwd(None, None, conf, 'ftp', 'foo.net')
4524
4525
    def test_for_matching_host(self):
4526
        conf = config.AuthenticationConfig(_file=StringIO(
4527
                """# Identity on foo.net
4528
[sourceforge]
4529
scheme=bzr
4530
host=bzr.sf.net
4531
user=joe
4532
password=joepass
4533
[sourceforge domain]
4534
scheme=bzr
4535
host=.bzr.sf.net
4536
user=georges
4537
password=bendover
4538
"""))
4539
        # matching domain
4540
        self._got_user_passwd('georges', 'bendover',
4541
                              conf, 'bzr', 'foo.bzr.sf.net')
4542
        # phishing attempt
4543
        self._got_user_passwd(None, None,
4544
                              conf, 'bzr', 'bbzr.sf.net')
4545
4546
    def test_for_matching_host_None(self):
4547
        conf = config.AuthenticationConfig(_file=StringIO(
4548
                """# Identity on foo.net
4549
[catchup bzr]
4550
scheme=bzr
4551
user=joe
4552
password=joepass
4553
[DEFAULT]
4554
user=georges
4555
password=bendover
4556
"""))
4557
        # match no host
4558
        self._got_user_passwd('joe', 'joepass',
4559
                              conf, 'bzr', 'quux.net')
4560
        # no host but different scheme
4561
        self._got_user_passwd('georges', 'bendover',
4562
                              conf, 'ftp', 'quux.net')
4563
4564
    def test_credentials_for_path(self):
4565
        conf = config.AuthenticationConfig(_file=StringIO(
4566
                """
4567
[http dir1]
4568
scheme=http
4569
host=bar.org
4570
path=/dir1
4571
user=jim
4572
password=jimpass
4573
[http dir2]
4574
scheme=http
4575
host=bar.org
4576
path=/dir2
4577
user=georges
4578
password=bendover
4579
"""))
4580
        # no path no dice
4581
        self._got_user_passwd(None, None,
4582
                              conf, 'http', host='bar.org', path='/dir3')
4583
        # matching path
4584
        self._got_user_passwd('georges', 'bendover',
4585
                              conf, 'http', host='bar.org', path='/dir2')
4586
        # matching subdir
4587
        self._got_user_passwd('jim', 'jimpass',
4588
                              conf, 'http', host='bar.org',path='/dir1/subdir')
4589
4590
    def test_credentials_for_user(self):
4591
        conf = config.AuthenticationConfig(_file=StringIO(
4592
                """
4593
[with user]
4594
scheme=http
4595
host=bar.org
4596
user=jim
4597
password=jimpass
4598
"""))
4599
        # Get user
4600
        self._got_user_passwd('jim', 'jimpass',
4601
                              conf, 'http', 'bar.org')
4602
        # Get same user
4603
        self._got_user_passwd('jim', 'jimpass',
4604
                              conf, 'http', 'bar.org', user='jim')
4605
        # Don't get a different user if one is specified
4606
        self._got_user_passwd(None, None,
4607
                              conf, 'http', 'bar.org', user='georges')
4608
3418.4.1 by Vincent Ladeuil
Reproduce bug 199440.
4609
    def test_credentials_for_user_without_password(self):
4610
        conf = config.AuthenticationConfig(_file=StringIO(
4611
                """
4612
[without password]
4613
scheme=http
4614
host=bar.org
4615
user=jim
4616
"""))
4617
        # Get user but no password
4618
        self._got_user_passwd('jim', None,
4619
                              conf, 'http', 'bar.org')
4620
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4621
    def test_verify_certificates(self):
4622
        conf = config.AuthenticationConfig(_file=StringIO(
4623
                """
4624
[self-signed]
4625
scheme=https
4626
host=bar.org
4627
user=jim
4628
password=jimpass
4629
verify_certificates=False
4630
[normal]
4631
scheme=https
4632
host=foo.net
4633
user=georges
4634
password=bendover
4635
"""))
4636
        credentials = conf.get_credentials('https', 'bar.org')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4637
        self.assertEqual(False, credentials.get('verify_certificates'))
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4638
        credentials = conf.get_credentials('https', 'foo.net')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4639
        self.assertEqual(True, credentials.get('verify_certificates'))
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4640
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4641
4642
class TestAuthenticationStorage(tests.TestCaseInTempDir):
4643
3777.1.8 by Aaron Bentley
Commit work-in-progress
4644
    def test_set_credentials(self):
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4645
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4646
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4647
        99, path='/foo', verify_certificates=False, realm='realm')
3777.1.8 by Aaron Bentley
Commit work-in-progress
4648
        credentials = conf.get_credentials(host='host', scheme='scheme',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4649
                                           port=99, path='/foo',
4650
                                           realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4651
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4652
                       'verify_certificates': False, 'scheme': 'scheme',
4653
                       'host': 'host', 'port': 99, 'path': '/foo',
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4654
                       'realm': 'realm'}
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4655
        self.assertEqual(CREDENTIALS, credentials)
4656
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4657
            host='host', scheme='scheme', port=99, path='/foo', realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4658
        self.assertEqual(CREDENTIALS, credentials_from_disk)
3777.1.8 by Aaron Bentley
Commit work-in-progress
4659
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4660
    def test_reset_credentials_different_name(self):
4661
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4662
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password'),
4663
        conf.set_credentials('name2', 'host', 'user2', 'scheme', 'password'),
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4664
        self.assertIs(None, conf._get_config().get('name'))
4665
        credentials = conf.get_credentials(host='host', scheme='scheme')
4666
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4667
                       'password', 'verify_certificates': True,
4668
                       'scheme': 'scheme', 'host': 'host', 'port': None,
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4669
                       'path': None, 'realm': None}
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4670
        self.assertEqual(CREDENTIALS, credentials)
4671
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4672
2900.2.14 by Vincent Ladeuil
More tests.
4673
class TestAuthenticationConfig(tests.TestCase):
4674
    """Test AuthenticationConfig behaviour"""
4675
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4676
    def _check_default_password_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4677
                                       host=None, port=None, realm=None,
4678
                                       path=None):
2900.2.14 by Vincent Ladeuil
More tests.
4679
        if host is None:
4680
            host = 'bar.org'
4681
        user, password = 'jim', 'precious'
4682
        expected_prompt = expected_prompt_format % {
4683
            'scheme': scheme, 'host': host, 'port': port,
4684
            'user': user, 'realm': realm}
4685
4686
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4687
        stderr = tests.StringIOWrapper()
2900.2.14 by Vincent Ladeuil
More tests.
4688
        ui.ui_factory = tests.TestUIFactory(stdin=password + '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4689
                                            stdout=stdout, stderr=stderr)
2900.2.14 by Vincent Ladeuil
More tests.
4690
        # We use an empty conf so that the user is always prompted
4691
        conf = config.AuthenticationConfig()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4692
        self.assertEqual(password,
2900.2.14 by Vincent Ladeuil
More tests.
4693
                          conf.get_password(scheme, host, user, port=port,
4694
                                            realm=realm, path=path))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4695
        self.assertEqual(expected_prompt, stderr.getvalue())
4696
        self.assertEqual('', stdout.getvalue())
2900.2.14 by Vincent Ladeuil
More tests.
4697
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4698
    def _check_default_username_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4699
                                       host=None, port=None, realm=None,
4700
                                       path=None):
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4701
        if host is None:
4702
            host = 'bar.org'
4703
        username = 'jim'
4704
        expected_prompt = expected_prompt_format % {
4705
            'scheme': scheme, 'host': host, 'port': port,
4706
            'realm': realm}
4707
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4708
        stderr = tests.StringIOWrapper()
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4709
        ui.ui_factory = tests.TestUIFactory(stdin=username+ '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4710
                                            stdout=stdout, stderr=stderr)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4711
        # We use an empty conf so that the user is always prompted
4712
        conf = config.AuthenticationConfig()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4713
        self.assertEqual(username, conf.get_user(scheme, host, port=port,
4222.3.5 by Jelmer Vernooij
Fix test.
4714
                          realm=realm, path=path, ask=True))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4715
        self.assertEqual(expected_prompt, stderr.getvalue())
4716
        self.assertEqual('', stdout.getvalue())
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4717
4718
    def test_username_defaults_prompts(self):
4719
        # HTTP prompts can't be tested here, see test_http.py
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4720
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
4721
        self._check_default_username_prompt(
4722
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
4723
        self._check_default_username_prompt(
4724
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4725
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4726
    def test_username_default_no_prompt(self):
4727
        conf = config.AuthenticationConfig()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4728
        self.assertEqual(None,
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4729
            conf.get_user('ftp', 'example.com'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4730
        self.assertEqual("explicitdefault",
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4731
            conf.get_user('ftp', 'example.com', default="explicitdefault"))
4732
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4733
    def test_password_default_prompts(self):
2900.2.19 by Vincent Ladeuil
Mention proxy and https in the password prompts, with tests.
4734
        # HTTP prompts can't be tested here, see test_http.py
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4735
        self._check_default_password_prompt(
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4736
            u'FTP %(user)s@%(host)s password: ', 'ftp')
4737
        self._check_default_password_prompt(
4738
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
4739
        self._check_default_password_prompt(
4740
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
2900.2.14 by Vincent Ladeuil
More tests.
4741
        # SMTP port handling is a bit special (it's handled if embedded in the
4742
        # host too)
2900.2.22 by Vincent Ladeuil
Polishing.
4743
        # FIXME: should we: forbid that, extend it to other schemes, leave
4744
        # things as they are that's fine thank you ?
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4745
        self._check_default_password_prompt(
4746
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
4747
        self._check_default_password_prompt(
4748
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
4749
        self._check_default_password_prompt(
4750
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
2900.2.14 by Vincent Ladeuil
More tests.
4751
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4752
    def test_ssh_password_emits_warning(self):
4753
        conf = config.AuthenticationConfig(_file=StringIO(
4754
                """
4755
[ssh with password]
4756
scheme=ssh
4757
host=bar.org
4758
user=jim
4759
password=jimpass
4760
"""))
4761
        entered_password = 'typed-by-hand'
4762
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4763
        stderr = tests.StringIOWrapper()
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4764
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4765
                                            stdout=stdout, stderr=stderr)
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4766
4767
        # Since the password defined in the authentication config is ignored,
4768
        # the user is prompted
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4769
        self.assertEqual(entered_password,
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4770
                          conf.get_password('ssh', 'bar.org', user='jim'))
4771
        self.assertContainsRe(
4794.1.17 by Robert Collins
Fix from vila for type log_log.
4772
            self.get_log(),
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4773
            'password ignored in section \[ssh with password\]')
4774
3420.1.3 by Vincent Ladeuil
John's review feedback.
4775
    def test_ssh_without_password_doesnt_emit_warning(self):
4776
        conf = config.AuthenticationConfig(_file=StringIO(
4777
                """
4778
[ssh with password]
4779
scheme=ssh
4780
host=bar.org
4781
user=jim
4782
"""))
4783
        entered_password = 'typed-by-hand'
4784
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4785
        stderr = tests.StringIOWrapper()
3420.1.3 by Vincent Ladeuil
John's review feedback.
4786
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4787
                                            stdout=stdout,
4788
                                            stderr=stderr)
3420.1.3 by Vincent Ladeuil
John's review feedback.
4789
4790
        # Since the password defined in the authentication config is ignored,
4791
        # the user is prompted
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4792
        self.assertEqual(entered_password,
3420.1.3 by Vincent Ladeuil
John's review feedback.
4793
                          conf.get_password('ssh', 'bar.org', user='jim'))
3420.1.4 by Vincent Ladeuil
Fix comment.
4794
        # No warning shoud be emitted since there is no password. We are only
4795
        # providing "user".
3420.1.3 by Vincent Ladeuil
John's review feedback.
4796
        self.assertNotContainsRe(
4794.1.15 by Robert Collins
Review feedback.
4797
            self.get_log(),
3420.1.3 by Vincent Ladeuil
John's review feedback.
4798
            'password ignored in section \[ssh with password\]')
4799
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4800
    def test_uses_fallback_stores(self):
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
4801
        self.overrideAttr(config, 'credential_store_registry',
4802
                          config.CredentialStoreRegistry())
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4803
        store = StubCredentialStore()
4804
        store.add_credentials("http", "example.com", "joe", "secret")
4805
        config.credential_store_registry.register("stub", store, fallback=True)
4806
        conf = config.AuthenticationConfig(_file=StringIO())
4807
        creds = conf.get_credentials("http", "example.com")
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4808
        self.assertEqual("joe", creds["user"])
4809
        self.assertEqual("secret", creds["password"])
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4810
2900.2.14 by Vincent Ladeuil
More tests.
4811
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4812
class StubCredentialStore(config.CredentialStore):
4813
4814
    def __init__(self):
4815
        self._username = {}
4816
        self._password = {}
4817
4818
    def add_credentials(self, scheme, host, user, password=None):
4819
        self._username[(scheme, host)] = user
4820
        self._password[(scheme, host)] = password
4821
4822
    def get_credentials(self, scheme, host, port=None, user=None,
4823
        path=None, realm=None):
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4824
        key = (scheme, host)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4825
        if not key in self._username:
4826
            return None
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4827
        return { "scheme": scheme, "host": host, "port": port,
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4828
                "user": self._username[key], "password": self._password[key]}
4829
4830
4831
class CountingCredentialStore(config.CredentialStore):
4832
4833
    def __init__(self):
4834
        self._calls = 0
4835
4836
    def get_credentials(self, scheme, host, port=None, user=None,
4837
        path=None, realm=None):
4838
        self._calls += 1
4839
        return None
4840
4841
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4842
class TestCredentialStoreRegistry(tests.TestCase):
4843
4844
    def _get_cs_registry(self):
4845
        return config.credential_store_registry
4846
4847
    def test_default_credential_store(self):
4848
        r = self._get_cs_registry()
4849
        default = r.get_credential_store(None)
4850
        self.assertIsInstance(default, config.PlainTextCredentialStore)
4851
4852
    def test_unknown_credential_store(self):
4853
        r = self._get_cs_registry()
4854
        # It's hard to imagine someone creating a credential store named
4855
        # 'unknown' so we use that as an never registered key.
4856
        self.assertRaises(KeyError, r.get_credential_store, 'unknown')
4857
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4858
    def test_fallback_none_registered(self):
4859
        r = config.CredentialStoreRegistry()
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4860
        self.assertEqual(None,
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4861
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4862
4863
    def test_register(self):
4864
        r = config.CredentialStoreRegistry()
4865
        r.register("stub", StubCredentialStore(), fallback=False)
4866
        r.register("another", StubCredentialStore(), fallback=True)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4867
        self.assertEqual(["another", "stub"], r.keys())
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4868
4869
    def test_register_lazy(self):
4870
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4871
        r.register_lazy("stub", "bzrlib.tests.test_config",
4872
                        "StubCredentialStore", fallback=False)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4873
        self.assertEqual(["stub"], r.keys())
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4874
        self.assertIsInstance(r.get_credential_store("stub"),
4875
                              StubCredentialStore)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4876
4877
    def test_is_fallback(self):
4878
        r = config.CredentialStoreRegistry()
4879
        r.register("stub1", None, fallback=False)
4880
        r.register("stub2", None, fallback=True)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4881
        self.assertEqual(False, r.is_fallback("stub1"))
4882
        self.assertEqual(True, r.is_fallback("stub2"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4883
4884
    def test_no_fallback(self):
4885
        r = config.CredentialStoreRegistry()
4886
        store = CountingCredentialStore()
4887
        r.register("count", store, fallback=False)
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4888
        self.assertEqual(None,
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4889
                          r.get_fallback_credentials("http", "example.com"))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4890
        self.assertEqual(0, store._calls)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4891
4892
    def test_fallback_credentials(self):
4893
        r = config.CredentialStoreRegistry()
4894
        store = StubCredentialStore()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4895
        store.add_credentials("http", "example.com",
4896
                              "somebody", "geheim")
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4897
        r.register("stub", store, fallback=True)
4898
        creds = r.get_fallback_credentials("http", "example.com")
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4899
        self.assertEqual("somebody", creds["user"])
4900
        self.assertEqual("geheim", creds["password"])
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4901
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4902
    def test_fallback_first_wins(self):
4903
        r = config.CredentialStoreRegistry()
4904
        stub1 = StubCredentialStore()
4905
        stub1.add_credentials("http", "example.com",
4906
                              "somebody", "stub1")
4907
        r.register("stub1", stub1, fallback=True)
4908
        stub2 = StubCredentialStore()
4909
        stub2.add_credentials("http", "example.com",
4910
                              "somebody", "stub2")
4911
        r.register("stub2", stub1, fallback=True)
4912
        creds = r.get_fallback_credentials("http", "example.com")
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4913
        self.assertEqual("somebody", creds["user"])
4914
        self.assertEqual("stub1", creds["password"])
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4915
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4916
4917
class TestPlainTextCredentialStore(tests.TestCase):
4918
4919
    def test_decode_password(self):
4920
        r = config.credential_store_registry
4921
        plain_text = r.get_credential_store()
4922
        decoded = plain_text.decode_password(dict(password='secret'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4923
        self.assertEqual('secret', decoded)
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4924
5912.5.5 by Florian Dorn
re-added blanks
4925
5912.5.6 by Martin
Revert to implementation in config rather than a plugin
4926
class TestBase64CredentialStore(tests.TestCase):
4927
4928
    def test_decode_password(self):
4929
        r = config.credential_store_registry
4930
        plain_text = r.get_credential_store('base64')
5912.5.7 by Martin
Minor cleanups and note about error case
4931
        decoded = plain_text.decode_password(dict(password='c2VjcmV0'))
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4932
        self.assertEqual('secret', decoded)
5912.5.6 by Martin
Revert to implementation in config rather than a plugin
4933
4934
2900.2.14 by Vincent Ladeuil
More tests.
4935
# FIXME: Once we have a way to declare authentication to all test servers, we
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4936
# can implement generic tests.
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4937
# test_user_password_in_url
4938
# test_user_in_url_password_from_config
4939
# test_user_in_url_password_prompted
4940
# test_user_in_config
4941
# test_user_getpass.getuser
4942
# test_user_prompted ?
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4943
class TestAuthenticationRing(tests.TestCaseWithTransport):
4944
    pass
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4945
4946
4947
class TestAutoUserId(tests.TestCase):
4948
    """Test inferring an automatic user name."""
4949
4950
    def test_auto_user_id(self):
4951
        """Automatic inference of user name.
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4952
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4953
        This is a bit hard to test in an isolated way, because it depends on
4954
        system functions that go direct to /etc or perhaps somewhere else.
4955
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
4956
        to be able to choose a user name with no configuration.
4957
        """
4958
        if sys.platform == 'win32':
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
4959
            raise tests.TestSkipped(
4960
                "User name inference not implemented on win32")
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4961
        realname, address = config._auto_user_id()
4962
        if os.path.exists('/etc/mailname'):
5813.1.1 by Jelmer Vernooij
Allow realname to be empty in tests.
4963
            self.assertIsNot(None, realname)
4964
            self.assertIsNot(None, address)
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4965
        else:
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4966
            self.assertEqual((None, None), (realname, address))
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4967
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4968
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4969
class TestDefaultMailDomain(tests.TestCaseInTempDir):
4970
    """Test retrieving default domain from mailname file"""
4971
4972
    def test_default_mail_domain_simple(self):
4973
        f = file('simple', 'w')
6538.4.5 by Haw Loeung (hloeung)
[hloeung] Use try/finally to make sure the tests don't leak any file descriptors if they fail.
4974
        try:
4975
            f.write("domainname.com\n")
4976
        finally:
4977
            f.close()
6538.4.3 by Haw Loeung (hloeung)
[hloeung] Minor cosmetic changes.
4978
        r = config._get_default_mail_domain('simple')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4979
        self.assertEqual('domainname.com', r)
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4980
4981
    def test_default_mail_domain_no_eol(self):
6538.4.5 by Haw Loeung (hloeung)
[hloeung] Use try/finally to make sure the tests don't leak any file descriptors if they fail.
4982
        f = file('no_eol', 'w')
4983
        try:
4984
            f.write("domainname.com")
4985
        finally:
4986
            f.close()
4987
        r = config._get_default_mail_domain('no_eol')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4988
        self.assertEqual('domainname.com', r)
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4989
4990
    def test_default_mail_domain_multiple_lines(self):
4991
        f = file('multiple_lines', 'w')
6538.4.5 by Haw Loeung (hloeung)
[hloeung] Use try/finally to make sure the tests don't leak any file descriptors if they fail.
4992
        try:
4993
            f.write("domainname.com\nsome other text\n")
4994
        finally:
4995
            f.close()
6538.4.3 by Haw Loeung (hloeung)
[hloeung] Minor cosmetic changes.
4996
        r = config._get_default_mail_domain('multiple_lines')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
4997
        self.assertEqual('domainname.com', r)
6538.4.2 by Haw Loeung (hloeung)
[hloeung] Also added missing unit tests.
4998
4999
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5000
class EmailOptionTests(tests.TestCase):
5001
5002
    def test_default_email_uses_BZR_EMAIL(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
5003
        conf = config.MemoryStack('email=jelmer@debian.org')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5004
        # BZR_EMAIL takes precedence over EMAIL
5005
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
5006
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
5007
        self.assertEqual('jelmer@samba.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5008
5009
    def test_default_email_uses_EMAIL(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
5010
        conf = config.MemoryStack('')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5011
        self.overrideEnv('BZR_EMAIL', None)
5012
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
5013
        self.assertEqual('jelmer@apache.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5014
5015
    def test_BZR_EMAIL_overrides(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
5016
        conf = config.MemoryStack('email=jelmer@debian.org')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5017
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
5018
        self.assertEqual('jelmer@apache.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
5019
        self.overrideEnv('BZR_EMAIL', None)
5020
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
5021
        self.assertEqual('jelmer@debian.org', conf.get('email'))
6449.5.6 by Jelmer Vernooij
Port mail client tests to config stacks.
5022
5023
5024
class MailClientOptionTests(tests.TestCase):
5025
5026
    def test_default(self):
5027
        conf = config.MemoryStack('')
5028
        client = conf.get('mail_client')
5029
        self.assertIs(client, mail_client.DefaultMail)
5030
5031
    def test_evolution(self):
5032
        conf = config.MemoryStack('mail_client=evolution')
5033
        client = conf.get('mail_client')
5034
        self.assertIs(client, mail_client.Evolution)
5035
5036
    def test_kmail(self):
5037
        conf = config.MemoryStack('mail_client=kmail')
5038
        client = conf.get('mail_client')
5039
        self.assertIs(client, mail_client.KMail)
5040
5041
    def test_mutt(self):
5042
        conf = config.MemoryStack('mail_client=mutt')
5043
        client = conf.get('mail_client')
5044
        self.assertIs(client, mail_client.Mutt)
5045
5046
    def test_thunderbird(self):
5047
        conf = config.MemoryStack('mail_client=thunderbird')
5048
        client = conf.get('mail_client')
5049
        self.assertIs(client, mail_client.Thunderbird)
5050
5051
    def test_explicit_default(self):
5052
        conf = config.MemoryStack('mail_client=default')
5053
        client = conf.get('mail_client')
5054
        self.assertIs(client, mail_client.DefaultMail)
5055
5056
    def test_editor(self):
5057
        conf = config.MemoryStack('mail_client=editor')
5058
        client = conf.get('mail_client')
5059
        self.assertIs(client, mail_client.Editor)
5060
5061
    def test_mapi(self):
5062
        conf = config.MemoryStack('mail_client=mapi')
5063
        client = conf.get('mail_client')
5064
        self.assertIs(client, mail_client.MAPIClient)
5065
5066
    def test_xdg_email(self):
5067
        conf = config.MemoryStack('mail_client=xdg-email')
5068
        client = conf.get('mail_client')
5069
        self.assertIs(client, mail_client.XDGEmail)
5070
5071
    def test_unknown(self):
5072
        conf = config.MemoryStack('mail_client=firebird')
5073
        self.assertRaises(errors.ConfigOptionValueError, conf.get,
5074
                'mail_client')