~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2007-2010 Canonical Ltd
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
18
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
19
from bzrlib import registry
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
20
from bzrlib.lazy_import import lazy_import
21
lazy_import(globals(), """
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
22
from bzrlib import errors, urlutils
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
23
""")
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
24
25
2376.4.7 by jml at canonical
- Add docstrings to tests.
26
"""Provides a shorthand for referring to bugs on a variety of bug trackers.
27
28
'commit --fixes' stores references to bugs as a <bug_url> -> <bug_status>
29
mapping in the properties for that revision.
30
31
However, it's inconvenient to type out full URLs for bugs on the command line,
32
particularly given that many users will be using only a single bug tracker per
33
branch.
34
35
Thus, this module provides a registry of types of bug tracker (e.g. Launchpad,
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
36
Trac). Given an abbreviated name (e.g. 'lp', 'twisted') and a branch with
2376.4.7 by jml at canonical
- Add docstrings to tests.
37
configuration information, these tracker types can return an instance capable
38
of converting bug IDs into URLs.
39
"""
40
41
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
42
_bugs_help = \
43
"""When making a commit, metadata about bugs fixed by that change can be
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
44
recorded by using the ``--fixes`` option. For each bug marked as fixed, an
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
45
entry is included in the 'bugs' revision property stating '<url> <status>'.
3154.1.1 by Ian Clatworthy
Minor tweaks to bug tracker integration documentation
46
(The only ``status`` value currently supported is ``fixed.``)
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
47
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
48
The ``--fixes`` option allows you to specify a bug tracker and a bug identifier
49
rather than a full URL. This looks like::
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
50
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
51
    bzr commit --fixes <tracker>:<id>
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
52
6120.1.2 by Jelmer Vernooij
Doc doc doc.
53
or::
54
55
    bzr commit --fixes <id>
56
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
57
where "<tracker>" is an identifier for the bug tracker, and "<id>" is the
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
58
identifier for that bug within the bugtracker, usually the bug number.
6120.1.2 by Jelmer Vernooij
Doc doc doc.
59
If "<tracker>" is not specified the ``bugtracker`` set in the branch
60
or global configuration is used.
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
61
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
62
Bazaar knows about a few bug trackers that have many users. If
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
63
you use one of these bug trackers then there is no setup required to
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
64
use this feature, you just need to know the tracker identifier to use.
65
These are the bugtrackers that are built in:
66
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
67
  ============================ ============ ============
68
  URL                          Abbreviation Example
69
  ============================ ============ ============
70
  https://bugs.launchpad.net/  lp           lp:12345
71
  http://bugs.debian.org/      deb          deb:12345
72
  http://bugzilla.gnome.org/   gnome        gnome:12345
73
  ============================ ============ ============
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
74
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
75
For the bug trackers not listed above configuration is required.
76
Support for generating the URLs for any project using Bugzilla or Trac
77
is built in, along with a template mechanism for other bugtrackers with
3535.10.6 by James Westby
Mention that the a plugin can support their tracker as the last resort.
78
simple URL schemes. If your bug tracker can't be described by one
79
of the schemes described below then you can write a plugin to support
80
it.
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
81
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
82
If you use Bugzilla or Trac, then you only need to set a configuration
83
variable which contains the base URL of the bug tracker. These options
84
can go into ``bazaar.conf``, ``branch.conf`` or into a branch-specific
85
configuration section in ``locations.conf``.  You can set up these values
86
for each of the projects you work on.
87
88
Note: As you provide a short name for each tracker, you can specify one or
89
more bugs in one or more trackers at commit time if you wish.
90
3860.2.1 by Martin Pool
Mention in 'help bugs' the syntax for Launchpad
91
Launchpad
92
---------
93
94
Use ``bzr commit --fixes lp:2`` to record that this commit fixes bug 2.
95
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
96
bugzilla_<tracker>_url
97
----------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
98
99
If present, the location of the Bugzilla bug tracker referred to by
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
100
<tracker>. This option can then be used together with ``bzr commit
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
101
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
102
example::
103
5444.1.1 by Martin Pool
Updated URL for Squid bugzilla
104
    bugzilla_squid_url = http://bugs.squid-cache.org
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
105
106
would allow ``bzr commit --fixes squid:1234`` to mark Squid's bug 1234 as
107
fixed.
108
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
109
trac_<tracker>_url
110
------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
111
112
If present, the location of the Trac instance referred to by
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
113
<tracker>. This option can then be used together with ``bzr commit
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
114
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
115
example::
116
117
    trac_twisted_url = http://www.twistedmatrix.com/trac
118
119
would allow ``bzr commit --fixes twisted:1234`` to mark Twisted's bug 1234 as
120
fixed.
121
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
122
bugtracker_<tracker>_url
123
------------------------
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
124
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
125
If present, the location of a generic bug tracker instance referred to by
4927.2.6 by Ian Clatworthy
Nicer formatting of bug tracking topic
126
<tracker>. The location must contain an ``{id}`` placeholder,
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
127
which will be replaced by a specific bug ID. This option can then be used
128
together with ``bzr commit --fixes`` to mark bugs in that tracker as being
129
fixed by that commit. For example::
130
131
    bugtracker_python_url = http://bugs.python.org/issue{id}
132
133
would allow ``bzr commit --fixes python:1234`` to mark bug 1234 in Python's
134
Roundup bug tracker as fixed, or::
135
136
    bugtracker_cpan_url = http://rt.cpan.org/Public/Bug/Display.html?id={id}
137
5409.3.1 by Alexandre Garnier
Allow using string bug ID with generic bug trackers.
138
would allow ``bzr commit --fixes cpan:1234`` to mark bug 1234 in CPAN's
139
RT bug tracker as fixed, or::
140
141
    bugtracker_hudson_url = http://issues.hudson-ci.org/browse/{id}
142
143
would allow ``bzr commit --fixes hudson:HUDSON-1234`` to mark bug HUDSON-1234
144
in Hudson's JIRA bug tracker as fixed.
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
145
"""
146
147
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
148
def get_bug_url(abbreviated_bugtracker_name, branch, bug_id):
149
    """Return a URL pointing to the canonical web page of the bug identified by
150
    'bug_id'.
151
    """
152
    tracker = tracker_registry.get_tracker(abbreviated_bugtracker_name, branch)
153
    return tracker.get_bug_url(bug_id)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
154
155
156
class TrackerRegistry(registry.Registry):
157
    """Registry of bug tracker types."""
158
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
159
    def get_tracker(self, abbreviated_bugtracker_name, branch):
160
        """Return the first registered tracker that understands
161
        'abbreviated_bugtracker_name'.
2376.4.7 by jml at canonical
- Add docstrings to tests.
162
163
        If no such tracker is found, raise KeyError.
164
        """
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
165
        for tracker_name in self.keys():
166
            tracker_type = self.get(tracker_name)
167
            tracker = tracker_type.get(abbreviated_bugtracker_name, branch)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
168
            if tracker is not None:
169
                return tracker
2376.4.28 by Jonathan Lange
Focus the tests better and clean up some dodgy bits in UnknownBugTrackerAbbreviation
170
        raise errors.UnknownBugTrackerAbbreviation(abbreviated_bugtracker_name,
171
                                                   branch)
2376.4.7 by jml at canonical
- Add docstrings to tests.
172
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
173
    def help_topic(self, topic):
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
174
        return _bugs_help
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
175
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
176
177
tracker_registry = TrackerRegistry()
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
178
"""Registry of bug trackers."""
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
179
2376.4.15 by Jonathan Lange
Whitespace cleanup
180
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
181
class BugTracker(object):
182
    """Base class for bug trackers."""
183
184
    def check_bug_id(self, bug_id):
185
        """Check that the bug_id is valid.
186
187
        The base implementation assumes that all bug_ids are valid.
188
        """
189
190
    def get_bug_url(self, bug_id):
191
        """Return the URL for bug_id. Raise an error if bug ID is malformed."""
192
        self.check_bug_id(bug_id)
193
        return self._get_bug_url(bug_id)
194
195
    def _get_bug_url(self, bug_id):
196
        """Given a validated bug_id, return the bug's web page's URL."""
197
198
199
class IntegerBugTracker(BugTracker):
200
    """A bug tracker that only allows integer bug IDs."""
201
202
    def check_bug_id(self, bug_id):
203
        try:
204
            int(bug_id)
205
        except ValueError:
206
            raise errors.MalformedBugIdentifier(bug_id, "Must be an integer")
207
208
209
class UniqueIntegerBugTracker(IntegerBugTracker):
2376.4.19 by Jonathan Lange
Rename SimpleBugTracker to UniqueBugTracker
210
    """A style of bug tracker that exists in one place only, such as Launchpad.
2376.4.15 by Jonathan Lange
Whitespace cleanup
211
2376.4.41 by Jonathan Lange
Update UniqueIntegerBugTracker docstring for new API
212
    If you have one of these trackers then register an instance passing in an
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
213
    abbreviated name for the bug tracker and a base URL. The bug ids are
214
    appended directly to the URL.
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
215
    """
216
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
217
    def __init__(self, abbreviated_bugtracker_name, base_url):
218
        self.abbreviation = abbreviated_bugtracker_name
219
        self.base_url = base_url
220
221
    def get(self, abbreviated_bugtracker_name, branch):
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
222
        """Returns the tracker if the abbreviation matches. Returns None
223
        otherwise."""
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
224
        if abbreviated_bugtracker_name != self.abbreviation:
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
225
            return None
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
226
        return self
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
227
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
228
    def _get_bug_url(self, bug_id):
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
229
        """Return the URL for bug_id."""
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
230
        return self.base_url + bug_id
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
231
232
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
233
tracker_registry.register(
234
    'launchpad', UniqueIntegerBugTracker('lp', 'https://launchpad.net/bugs/'))
235
236
237
tracker_registry.register(
2376.4.29 by Jonathan Lange
Tests for builtin trackers.
238
    'debian', UniqueIntegerBugTracker('deb', 'http://bugs.debian.org/'))
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
239
2376.4.15 by Jonathan Lange
Whitespace cleanup
240
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
241
tracker_registry.register('gnome',
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
242
    UniqueIntegerBugTracker('gnome',
243
                            'http://bugzilla.gnome.org/show_bug.cgi?id='))
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
244
245
5409.3.1 by Alexandre Garnier
Allow using string bug ID with generic bug trackers.
246
class URLParametrizedBugTracker(BugTracker):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
247
    """A type of bug tracker that can be found on a variety of different sites,
248
    and thus needs to have the base URL configured.
249
250
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
5409.3.1 by Alexandre Garnier
Allow using string bug ID with generic bug trackers.
251
    `type_name` is the name of the type of tracker and `abbreviation`
252
    is a short name for the particular instance.
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
253
    """
254
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
255
    def get(self, abbreviation, branch):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
256
        config = branch.get_config()
257
        url = config.get_user_option(
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
258
            "%s_%s_url" % (self.type_name, abbreviation), expand=False)
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
259
        if url is None:
260
            return None
261
        self._base_url = url
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
262
        return self
263
264
    def __init__(self, type_name, bug_area):
265
        self.type_name = type_name
266
        self._bug_area = bug_area
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
267
268
    def _get_bug_url(self, bug_id):
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
269
        """Return a URL for a bug on this Trac instance."""
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
270
        return urlutils.join(self._base_url, self._bug_area) + str(bug_id)
271
272
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
273
class URLParametrizedIntegerBugTracker(IntegerBugTracker,
274
                                       URLParametrizedBugTracker):
275
    """A type of bug tracker that  only allows integer bug IDs.
276
277
    This can be found on a variety of different sites, and thus needs to have
278
    the base URL configured.
5409.3.1 by Alexandre Garnier
Allow using string bug ID with generic bug trackers.
279
280
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
281
    `type_name` is the name of the type of tracker (e.g. 'bugzilla' or 'trac')
282
    and `abbreviation` is a short name for the particular instance (e.g.
283
    'squid' or 'apache').
284
    """
285
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
286
tracker_registry.register(
287
    'trac', URLParametrizedIntegerBugTracker('trac', 'ticket/'))
288
289
tracker_registry.register(
290
    'bugzilla',
291
    URLParametrizedIntegerBugTracker('bugzilla', 'show_bug.cgi?id='))
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
292
293
5409.3.1 by Alexandre Garnier
Allow using string bug ID with generic bug trackers.
294
class GenericBugTracker(URLParametrizedBugTracker):
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
295
    """Generic bug tracker specified by an URL template."""
296
297
    def __init__(self):
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
298
        super(GenericBugTracker, self).__init__('bugtracker', None)
299
300
    def get(self, abbreviation, branch):
301
        self._abbreviation = abbreviation
302
        return super(GenericBugTracker, self).get(abbreviation, branch)
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
303
304
    def _get_bug_url(self, bug_id):
305
        """Given a validated bug_id, return the bug's web page's URL."""
306
        if '{id}' not in self._base_url:
307
            raise errors.InvalidBugTrackerURL(self._abbreviation,
308
                                              self._base_url)
309
        return self._base_url.replace('{id}', str(bug_id))
310
311
312
tracker_registry.register('generic', GenericBugTracker())
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
313
314
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
315
FIXED = 'fixed'
316
4119.4.3 by Jonathan Lange
Add Revision.iter_bugs.
317
ALLOWED_BUG_STATUSES = set([FIXED])
318
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
319
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
320
def encode_fixes_bug_urls(bug_urls):
4119.4.5 by Jonathan Lange
Fix the docstring.
321
    """Get the revision property value for a commit that fixes bugs.
322
323
    :param bug_urls: An iterable of escaped URLs to bugs. These normally
324
        come from `get_bug_url`.
325
    :return: A string that will be set as the 'bugs' property of a revision
326
        as part of a commit.
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
327
    """
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
328
    return '\n'.join(('%s %s' % (url, FIXED)) for url in bug_urls)