~bzr-pqm/bzr/bzr.dev

5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
1551.8.30 by Aaron Bentley
Tweak from review comments
53
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
57
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
58
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
59
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
60
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
61
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
62
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
63
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
64
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
65
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
66
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib.osutils import (get_user_encoding,
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
68
                            is_inside_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
69
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
70
                            splitpath,
71
                            )
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
72
from bzrlib.trace import mutter, note, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
73
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
74
from bzrlib import symbol_versioning
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
75
from bzrlib.urlutils import unescape_for_display
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
76
from bzrlib.i18n import gettext
1189 by Martin Pool
- BROKEN: partial support for commit into weave
77
78
class NullCommitReporter(object):
79
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
80
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
81
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
82
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
83
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
84
                                   "to started.", DeprecationWarning,
85
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
86
        pass
87
88
    def snapshot_change(self, change, path):
89
        pass
90
91
    def completed(self, revno, rev_id):
92
        pass
93
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
94
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
        pass
96
97
    def missing(self, path):
98
        pass
99
100
    def renamed(self, change, old_path, new_path):
101
        pass
102
2789.2.11 by Ian Clatworthy
remove more reporting stuff
103
    def is_verbose(self):
104
        return False
105
106
107
class ReportCommitToLog(NullCommitReporter):
108
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
109
    def _note(self, format, *args):
110
        """Output a message.
111
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
112
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
113
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
114
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
116
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
117
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
119
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
120
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
121
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
122
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
123
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
124
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
125
            # When started was added, location was only made optional by
126
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
127
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
128
                                   "to started.", DeprecationWarning,
129
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
130
            location = ''
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
131
        self._note(gettext('Committing%s'), location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
132
133
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
134
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
135
        # self._note goes to the console too; so while we want to log the
136
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
        # term we should rearrange the reporting structure, but for now
138
        # we just mutter seperately. We mutter the revid and revno together
139
        # so that concurrent bzr invocations won't lead to confusion.
140
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
141
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
142
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
143
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
144
145
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
146
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
148
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
150
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
151
    def is_verbose(self):
152
        return True
153
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
154
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
class Commit(object):
156
    """Task of committing a new revision.
157
158
    This is a MethodObject: it accumulates state as the commit is
159
    prepared, and then it is discarded.  It doesn't represent
160
    historical revisions, just the act of recording a new one.
161
162
            missing_ids
163
            Modified to hold a list of files that have been deleted from
164
            the working directory; these should be removed from the
165
            working inventory.
485 by Martin Pool
- move commit code into its own module
166
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
169
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
170
        """Create a Commit object.
171
172
        :param reporter: the default reporter to use or None to decide later
173
        """
174
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
175
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
176
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
177
    @staticmethod
178
    def update_revprops(revprops, branch, authors=None, author=None,
179
                        local=False, possible_master_transports=None):
180
        if revprops is None:
181
            revprops = {}
182
        if possible_master_transports is None:
183
            possible_master_transports = []
184
        if not 'branch-nick' in revprops:
185
            revprops['branch-nick'] = branch._get_nick(
186
                local,
187
                possible_master_transports)
188
        if authors is not None:
189
            if author is not None:
190
                raise AssertionError('Specifying both author and authors '
191
                        'is not allowed. Specify just authors instead')
192
            if 'author' in revprops or 'authors' in revprops:
193
                # XXX: maybe we should just accept one of them?
194
                raise AssertionError('author property given twice')
195
            if authors:
196
                for individual in authors:
197
                    if '\n' in individual:
198
                        raise AssertionError('\\n is not a valid character '
199
                                'in an author identity')
200
                revprops['authors'] = '\n'.join(authors)
201
        if author is not None:
202
            symbol_versioning.warn('The parameter author was deprecated'
203
                   ' in version 1.13. Use authors instead',
204
                   DeprecationWarning)
205
            if 'author' in revprops or 'authors' in revprops:
206
                # XXX: maybe we should just accept one of them?
207
                raise AssertionError('author property given twice')
208
            if '\n' in author:
209
                raise AssertionError('\\n is not a valid character '
210
                        'in an author identity')
211
            revprops['authors'] = author
212
        return revprops
213
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
215
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
               timestamp=None,
217
               timezone=None,
218
               committer=None,
219
               specific_files=None,
220
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
221
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
222
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
223
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
224
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
225
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
226
               local=False,
227
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
228
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
229
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
230
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
231
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
232
               possible_master_transports=None,
233
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
        """Commit working copy as a new revision.
235
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
236
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
237
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
238
239
        :param timestamp: if not None, seconds-since-epoch for a
240
            postdated/predated commit.
241
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
242
        :param specific_files: If not None, commit only those files. An empty
243
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
244
245
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
246
            Useful for test or import commands that need to tightly
247
            control what revisions are assigned.  If you duplicate
248
            a revision id that exists elsewhere it is your own fault.
249
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
250
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
251
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
252
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
253
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
255
            contains unknown files.
256
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
257
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
258
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
259
        :param reporter: the reporter to use or None for the default
260
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
261
        :param recursive: If set to 'down', commit in any subtrees that have
262
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
263
        :param exclude: None or a list of relative paths to exclude from the
264
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
265
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
266
        :param lossy: When committing to a foreign VCS, ignore any
267
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
268
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
269
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
270
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
271
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
272
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
273
        return operation.run(
274
               message=message,
275
               timestamp=timestamp,
276
               timezone=timezone,
277
               committer=committer,
278
               specific_files=specific_files,
279
               rev_id=rev_id,
280
               allow_pointless=allow_pointless,
281
               strict=strict,
282
               verbose=verbose,
283
               working_tree=working_tree,
284
               local=local,
285
               reporter=reporter,
286
               message_callback=message_callback,
287
               recursive=recursive,
288
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
289
               possible_master_transports=possible_master_transports,
290
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
291
292
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
293
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
294
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
295
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
296
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
297
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
298
        if working_tree is None:
299
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
300
        else:
301
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
302
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
303
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
304
                if not self.branch.repository.supports_rich_root():
305
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
306
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
307
            if message is not None:
308
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
309
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
310
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
311
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
312
                raise BzrError("The message or message_callback keyword"
313
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
314
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
315
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
316
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
317
        if exclude is not None:
318
            self.exclude = sorted(
319
                minimum_path_selection(exclude))
320
        else:
321
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
322
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
323
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
324
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
325
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
326
        # self.specific_files is None to indicate no filter, or any iterable to
327
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
328
        if specific_files is not None:
329
            self.specific_files = sorted(
330
                minimum_path_selection(specific_files))
331
        else:
332
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
333
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
334
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
335
        self.message_callback = message_callback
336
        self.timestamp = timestamp
337
        self.timezone = timezone
338
        self.committer = committer
339
        self.strict = strict
340
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
341
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
342
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
343
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
344
        self.parents = self.work_tree.get_parent_ids()
345
        # We can use record_iter_changes IFF iter_changes is compatible with
346
        # the command line parameters, and the repository has fast delta
347
        # generation. See bug 347649.
348
        self.use_record_iter_changes = (
349
            not self.exclude and 
350
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
351
            (self.branch.repository._format.fast_deltas or
352
             len(self.parents) < 2))
5582.10.6 by Jelmer Vernooij
Fix ui imports.
353
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
354
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
355
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
356
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
357
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
358
        operation.add_cleanup(self.basis_tree.unlock)
359
        # Cannot commit with conflicts present.
360
        if len(self.work_tree.conflicts()) > 0:
361
            raise ConflictsInTree
362
363
        # Setup the bound branch variables as needed.
364
        self._check_bound_branch(operation, possible_master_transports)
365
366
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
367
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
368
369
        # Complete configuration setup
370
        if reporter is not None:
371
            self.reporter = reporter
372
        elif self.reporter is None:
373
            self.reporter = self._select_reporter()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
374
        if self.config_stack is None:
6449.6.4 by Jelmer Vernooij
Use config stack.
375
            self.config_stack = self.work_tree.get_config_stack()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
376
377
        self._set_specific_file_ids()
378
379
        # Setup the progress bar. As the number of files that need to be
380
        # committed in unknown, progress is reported as stages.
381
        # We keep track of entries separately though and include that
382
        # information in the progress bar during the relevant stages.
383
        self.pb_stage_name = ""
384
        self.pb_stage_count = 0
385
        self.pb_stage_total = 5
386
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
387
            # 2 extra stages: "Uploading data to master branch" and "Merging
388
            # tags to master branch"
389
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
390
        self.pb.show_pct = False
391
        self.pb.show_spinner = False
392
        self.pb.show_eta = False
393
        self.pb.show_count = True
394
        self.pb.show_bar = True
395
396
        self._gather_parents()
397
        # After a merge, a selected file commit is not supported.
398
        # See 'bzr help merge' for an explanation as to why.
399
        if len(self.parents) > 1 and self.specific_files is not None:
400
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
401
        # Excludes are a form of selected file commit.
402
        if len(self.parents) > 1 and self.exclude:
403
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
404
405
        # Collect the changes
406
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
407
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
408
        self.builder = self.branch.get_commit_builder(self.parents,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
409
            self.config_stack, timestamp, timezone, committer, self.revprops,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
410
            rev_id, lossy=lossy)
5718.4.9 by Jelmer Vernooij
Fix logic for raising ExcludesUnsupported exception. It's a pity we have no record-iter-changes-only formats in bzr.dev.
411
        if not self.builder.supports_record_entry_contents and self.exclude:
5718.4.5 by Jelmer Vernooij
Move ExcludesUnsupported raise location.
412
            self.builder.abort()
413
            raise errors.ExcludesUnsupported(self.branch.repository)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
414
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
415
        if self.builder.updates_branch and self.bound_branch:
416
            self.builder.abort()
417
            raise AssertionError(
418
                "bound branches not supported for commit builders "
419
                "that update the branch")
420
1189 by Martin Pool
- BROKEN: partial support for commit into weave
421
        try:
5718.4.8 by Jelmer Vernooij
Revert conditional will_record_deletes.
422
            self.builder.will_record_deletes()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
423
            # find the location being committed to
424
            if self.bound_branch:
425
                master_location = self.master_branch.base
426
            else:
427
                master_location = self.branch.base
428
429
            # report the start of the commit
430
            self.reporter.started(new_revno, self.rev_id, master_location)
431
432
            self._update_builder_with_changes()
433
            self._check_pointless()
434
435
            # TODO: Now the new inventory is known, check for conflicts.
436
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
437
            # weave lines, because nothing should be recorded until it is known
438
            # that commit will succeed.
439
            self._set_progress_stage("Saving data locally")
440
            self.builder.finish_inventory()
441
442
            # Prompt the user for a commit message if none provided
443
            message = message_callback(self)
444
            self.message = message
445
446
            # Add revision data to the local branch
447
            self.rev_id = self.builder.commit(self.message)
448
449
        except Exception, e:
450
            mutter("aborting commit write group because of exception:")
451
            trace.log_exception_quietly()
452
            self.builder.abort()
453
            raise
454
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
455
        self._update_branches(old_revno, old_revid, new_revno)
456
457
        # Make the working tree be up to date with the branch. This
458
        # includes automatic changes scheduled to be made to the tree, such
459
        # as updating its basis and unversioning paths that were missing.
460
        self.work_tree.unversion(self.deleted_ids)
461
        self._set_progress_stage("Updating the working tree")
462
        self.work_tree.update_basis_by_delta(self.rev_id,
463
             self.builder.get_basis_delta())
464
        self.reporter.completed(new_revno, self.rev_id)
465
        self._process_post_hooks(old_revno, new_revno)
466
        return self.rev_id
467
468
    def _update_branches(self, old_revno, old_revid, new_revno):
469
        """Update the master and local branch to the new revision.
470
471
        This will try to make sure that the master branch is updated
472
        before the local branch.
473
474
        :param old_revno: Revision number of master branch before the
475
            commit
476
        :param old_revid: Tip of master branch before the commit
477
        :param new_revno: Revision number of the new commit
478
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
479
        if not self.builder.updates_branch:
480
            self._process_pre_hooks(old_revno, new_revno)
481
482
            # Upload revision data to the master.
483
            # this will propagate merged revisions too if needed.
484
            if self.bound_branch:
485
                self._set_progress_stage("Uploading data to master branch")
486
                # 'commit' to the master first so a timeout here causes the
487
                # local branch to be out of date
488
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
489
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
490
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
491
                    self.branch.fetch(self.master_branch, self.rev_id)
492
493
            # and now do the commit locally.
494
            self.branch.set_last_revision_info(new_revno, self.rev_id)
495
        else:
496
            try:
497
                self._process_pre_hooks(old_revno, new_revno)
498
            except:
499
                # The commit builder will already have updated the branch,
500
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
501
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
502
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
503
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
504
        # Merge local tags to remote
505
        if self.bound_branch:
506
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
507
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
508
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
509
            if tag_conflicts:
510
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
6138.3.5 by Jonathan Riddell
make the test suite pass
511
                note( gettext("Conflicting tags in bound branch:\n{0}".format(
512
                    "\n".join(warning_lines))) )
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
513
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
514
    def _select_reporter(self):
515
        """Select the CommitReporter to use."""
516
        if is_quiet():
517
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
518
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
519
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
520
    def _check_pointless(self):
521
        if self.allow_pointless:
522
            return
523
        # A merge with no effect on files
524
        if len(self.parents) > 1:
525
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
526
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
527
            return
528
        raise PointlessCommit()
529
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
530
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
531
        """Check to see if the local branch is bound.
532
533
        If it is bound, then most of the commit will actually be
534
        done using the remote branch as the target branch.
535
        Only at the end will the local branch be updated.
536
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
537
        if self.local and not self.branch.get_bound_location():
538
            raise errors.LocalRequiresBoundBranch()
539
540
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
541
            self.master_branch = self.branch.get_master_branch(
542
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
543
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
544
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
545
            # make this branch the reference branch for out of date checks.
546
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
547
            return
548
549
        # If the master branch is bound, we must fail
550
        master_bound_location = self.master_branch.get_bound_location()
551
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
552
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
553
                    self.master_branch, master_bound_location)
554
555
        # TODO: jam 20051230 We could automatically push local
556
        #       commits to the remote branch if they would fit.
557
        #       But for now, just require remote to be identical
558
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
559
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
560
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
561
        master_info = self.master_branch.last_revision_info()
562
        local_info = self.branch.last_revision_info()
563
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
564
            raise errors.BoundBranchOutOfDate(self.branch,
565
                    self.master_branch)
566
567
        # Now things are ready to change the master branch
568
        # so grab the lock
569
        self.bound_branch = self.branch
570
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
571
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
572
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
573
    def _check_out_of_date_tree(self):
574
        """Check that the working tree is up to date.
575
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
576
        :return: old_revision_number, old_revision_id, new_revision_number
577
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
578
        """
579
        try:
580
            first_tree_parent = self.work_tree.get_parent_ids()[0]
581
        except IndexError:
582
            # if there are no parents, treat our parent as 'None'
583
            # this is so that we still consider the master branch
584
            # - in a checkout scenario the tree may have no
585
            # parents but the branch may do.
586
            first_tree_parent = bzrlib.revision.NULL_REVISION
587
        old_revno, master_last = self.master_branch.last_revision_info()
588
        if master_last != first_tree_parent:
589
            if master_last != bzrlib.revision.NULL_REVISION:
590
                raise errors.OutOfDateTree(self.work_tree)
591
        if self.branch.repository.has_revision(first_tree_parent):
592
            new_revno = old_revno + 1
593
        else:
594
            # ghost parents never appear in revision history.
595
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
596
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
597
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
598
    def _process_pre_hooks(self, old_revno, new_revno):
599
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
600
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
601
        self._process_hooks("pre_commit", old_revno, new_revno)
602
603
    def _process_post_hooks(self, old_revno, new_revno):
604
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
605
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
606
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
607
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
608
        # 0.15^H^H^H^H 2.5.0)
609
        post_commit = self.config_stack.get('post_commit')
610
        if post_commit is not None:
611
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
612
            # this would be nicer with twisted.python.reflect.namedAny
613
            for hook in hooks:
614
                result = eval(hook + '(branch, rev_id)',
615
                              {'branch':self.branch,
616
                               'bzrlib':bzrlib,
617
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
618
        # process new style post commit hooks
619
        self._process_hooks("post_commit", old_revno, new_revno)
620
621
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
622
        if not Branch.hooks[hook_name]:
623
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
624
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
625
        # new style commit hooks:
626
        if not self.bound_branch:
627
            hook_master = self.branch
628
            hook_local = None
629
        else:
630
            hook_master = self.master_branch
631
            hook_local = self.branch
632
        # With bound branches, when the master is behind the local branch,
633
        # the 'old_revno' and old_revid values here are incorrect.
634
        # XXX: FIXME ^. RBC 20060206
635
        if self.parents:
636
            old_revid = self.parents[0]
637
        else:
638
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
639
2659.3.9 by NamNguyen
branch.py:
640
        if hook_name == "pre_commit":
641
            future_tree = self.builder.revision_tree()
642
            tree_delta = future_tree.changes_from(self.basis_tree,
643
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
644
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
645
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
646
            # show the running hook in the progress bar. As hooks may
647
            # end up doing nothing (e.g. because they are not configured by
648
            # the user) this is still showing progress, not showing overall
649
            # actions - its up to each plugin to show a UI if it want's to
650
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
651
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
652
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
653
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
654
            if 'hooks' in debug.debug_flags:
655
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
656
            if hook_name == "post_commit":
657
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
658
                     self.rev_id)
659
            elif hook_name == "pre_commit":
660
                hook(hook_local, hook_master,
661
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
662
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
663
1223 by Martin Pool
- store inventories in weave
664
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
665
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
666
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
667
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
668
        if self.use_record_iter_changes:
669
            return
6405.2.5 by Jelmer Vernooij
Add root_inventory.
670
        self.basis_inv = self.basis_tree.root_inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
671
        self.parent_invs = [self.basis_inv]
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
672
        for revision in self.parents[1:]:
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
673
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
674
                mutter('commit parent revision {%s}', revision)
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
675
                inventory = self.branch.repository.get_inventory(revision)
676
                self.parent_invs.append(inventory)
677
            else:
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
678
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
679
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
680
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
681
        """Update the commit builder with the data about what has changed.
682
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
683
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
684
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
685
        mutter("Selecting files for commit with filter %s", specific_files)
686
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
687
        self._check_strict()
688
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
689
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
690
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
691
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
692
            for file_id, path, fs_hash in self.builder.record_iter_changes(
693
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
694
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
695
        else:
696
            # Build the new inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
697
            self._populate_from_inventory()
698
            self._record_unselected()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
699
            self._report_and_accumulate_deletes()
700
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
701
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
702
        """Process iter_changes.
703
704
        This method reports on the changes in iter_changes to the user, and 
705
        converts 'missing' entries in the iter_changes iterator to 'deleted'
706
        entries. 'missing' entries have their
707
708
        :param iter_changes: An iter_changes to process.
709
        :return: A generator of changes.
710
        """
711
        reporter = self.reporter
712
        report_changes = reporter.is_verbose()
713
        deleted_ids = []
714
        for change in iter_changes:
715
            if report_changes:
716
                old_path = change[1][0]
717
                new_path = change[1][1]
718
                versioned = change[3][1]
719
            kind = change[6][1]
720
            versioned = change[3][1]
721
            if kind is None and versioned:
722
                # 'missing' path
723
                if report_changes:
724
                    reporter.missing(new_path)
725
                deleted_ids.append(change[0])
726
                # Reset the new path (None) and new versioned flag (False)
727
                change = (change[0], (change[1][0], None), change[2],
728
                    (change[3][0], False)) + change[4:]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
729
                new_path = change[1][1]
730
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
731
            elif kind == 'tree-reference':
732
                if self.recursive == 'down':
733
                    self._commit_nested_tree(change[0], change[1][1])
734
            if change[3][0] or change[3][1]:
735
                yield change
736
                if report_changes:
737
                    if new_path is None:
738
                        reporter.deleted(old_path)
739
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
740
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
741
                    elif old_path != new_path:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
742
                        reporter.renamed(gettext('renamed'), old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
743
                    else:
744
                        if (new_path or 
745
                            self.work_tree.branch.repository._format.rich_root_data):
746
                            # Don't report on changes to '' in non rich root
747
                            # repositories.
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
748
                            reporter.snapshot_change(gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
749
            self._next_progress_entry()
750
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
751
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
752
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
753
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
754
        # If specific files are selected, then all un-selected files must be
755
        # recorded in their previous state. For more details, see
756
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
757
        if self.specific_files or self.exclude:
758
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
759
            for path, old_ie in self.basis_inv.iter_entries():
5967.7.1 by Martin Pool
Deprecate __contains__ on Tree and Inventory
760
                if self.builder.new_inventory.has_id(old_ie.file_id):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
761
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
762
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
763
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
764
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
765
                    # was inside the selected path, and not excluded - if not
766
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
767
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
768
                # From here down it was either not selected, or was excluded:
769
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
770
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
771
                # Note: specific file commits after a merge are currently
772
                # prohibited. This test is for sanity/safety in case it's
773
                # required after that changes.
774
                if len(self.parents) > 1:
775
                    ie.revision = None
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
776
                self.builder.record_entry_contents(ie, self.parent_invs, path,
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
777
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
778
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
779
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
780
        if (isinstance(self.basis_inv, Inventory)
781
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
782
            # the older Inventory classes provide a _byid dict, and building a
783
            # set from the keys of this dict is substantially faster than even
784
            # getting a set of ids from the inventory
785
            #
786
            # <lifeless> set(dict) is roughly the same speed as
787
            # set(iter(dict)) and both are significantly slower than
788
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
789
            deleted_ids = set(self.basis_inv._byid.keys()) - \
790
               set(self.builder.new_inventory._byid.keys())
791
        else:
792
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
793
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
794
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
795
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
796
                for file_id in deleted_ids]
797
            deleted.sort()
798
            # XXX: this is not quite directory-order sorting
799
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
800
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
801
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
802
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
803
    def _check_strict(self):
804
        # XXX: when we use iter_changes this would likely be faster if
805
        # iter_changes would check for us (even in the presence of
806
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
807
        if self.strict:
808
            # raise an exception as soon as we find a single unknown.
809
            for unknown in self.work_tree.unknowns():
810
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
811
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
812
    def _populate_from_inventory(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
813
        """Populate the CommitBuilder by walking the working tree inventory."""
814
        # Build the revision inventory.
815
        #
816
        # This starts by creating a new empty inventory. Depending on
817
        # which files are selected for commit, and what is present in the
818
        # current tree, the new inventory is populated. inventory entries
819
        # which are candidates for modification have their revision set to
820
        # None; inventory entries that are carried over untouched have their
821
        # revision set to their prior value.
822
        #
823
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
824
        # results to create a new inventory at the same time, which results
825
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
826
        # ADHB 11-07-2006
827
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
828
        specific_files = self.specific_files
829
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
830
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
831
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
832
        # A tree of paths that have been deleted. E.g. if foo/bar has been
833
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
834
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
835
        # XXX: Note that entries may have the wrong kind because the entry does
836
        # not reflect the status on disk.
6405.2.5 by Jelmer Vernooij
Add root_inventory.
837
        # FIXME: Nested trees
838
        work_inv = self.work_tree.root_inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
839
        # NB: entries will include entries within the excluded ids/paths
840
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
841
        entries = work_inv.iter_entries_by_dir(
842
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
843
        for path, existing_ie in entries:
844
            file_id = existing_ie.file_id
845
            name = existing_ie.name
846
            parent_id = existing_ie.parent_id
847
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
849
            # The deleted path ids are also recorded so they can be explicitly
850
            # unversioned later.
851
            if deleted_paths:
852
                path_segments = splitpath(path)
853
                deleted_dict = deleted_paths
854
                for segment in path_segments:
855
                    deleted_dict = deleted_dict.get(segment, None)
856
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
857
                        # We either took a path not present in the dict
858
                        # (deleted_dict was None), or we've reached an empty
859
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
860
                        break
861
                else:
862
                    deleted_dict = None
863
                if deleted_dict is not None:
864
                    # the path has a deleted parent, do not add it.
865
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
866
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
867
                # Skip excluded paths. Excluded paths are processed by
868
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
869
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
870
            content_summary = self.work_tree.path_content_summary(path)
871
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
872
            # Note that when a filter of specific files is given, we must only
873
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
874
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
875
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
876
                    if not deleted_paths:
877
                        # path won't have been split yet.
878
                        path_segments = splitpath(path)
879
                    deleted_dict = deleted_paths
880
                    for segment in path_segments:
881
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
882
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
883
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
884
                    deleted_ids.append(file_id)
885
                    continue
4595.11.14 by Martin Pool
Small code cleanups
886
            # TODO: have the builder do the nested commit just-in-time IF and
887
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
888
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
889
                # enforce repository nested tree policy.
890
                if (not self.work_tree.supports_tree_reference() or
891
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
892
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
893
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
894
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
895
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
896
                    nested_revision_id = self._commit_nested_tree(
897
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
898
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
899
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
900
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
901
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
902
903
            # Record an entry for this item
904
            # Note: I don't particularly want to have the existing_ie
905
            # parameter but the test suite currently (28-Jun-07) breaks
906
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
907
            definitely_changed = kind != existing_ie.kind
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
908
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
909
                parent_id, definitely_changed, existing_ie, report_changes,
910
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
911
912
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
913
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
914
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
915
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
916
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
917
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
918
        # FIXME: be more comprehensive here:
919
        # this works when both trees are in --trees repository,
920
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
921
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
922
        # finally implement the explicit-caches approach design
923
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
924
        if sub_tree.branch.repository.has_same_location(
925
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
926
            sub_tree.branch.repository = \
927
                self.work_tree.branch.repository
928
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
929
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
930
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
931
                message_callback=self.message_callback,
932
                timestamp=self.timestamp, timezone=self.timezone,
933
                committer=self.committer,
934
                allow_pointless=self.allow_pointless,
935
                strict=self.strict, verbose=self.verbose,
936
                local=self.local, reporter=self.reporter)
937
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
938
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
939
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
940
    def _record_entry(self, path, file_id, specific_files, kind, name,
941
        parent_id, definitely_changed, existing_ie, report_changes,
942
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
943
        "Record the new inventory entry for a path if any."
944
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
945
        # mutter('%s selected for commit', path)
946
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
947
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
948
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
949
            ie = existing_ie.copy()
950
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
951
        # For carried over entries we don't care about the fs hash - the repo
952
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
953
        _, _, fs_hash = self.builder.record_entry_contents(
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
954
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
955
        if report_changes:
956
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
957
        if fs_hash:
958
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
959
        return ie
960
961
    def _report_change(self, ie, path):
962
        """Report a change to the user.
963
964
        The change that has occurred is described relative to the basis
965
        inventory.
966
        """
967
        if (self.basis_inv.has_id(ie.file_id)):
968
            basis_ie = self.basis_inv[ie.file_id]
969
        else:
970
            basis_ie = None
971
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
972
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
973
            InventoryEntry.MODIFIED_AND_RENAMED):
974
            old_path = self.basis_inv.id2path(ie.file_id)
975
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
976
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
977
        else:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
978
            if change == gettext('unchanged'):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
979
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
980
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
981
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
982
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
983
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
984
        """Set the progress stage and emit an update to the progress bar."""
985
        self.pb_stage_name = name
986
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
987
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
988
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
989
        else:
990
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
991
        self._emit_progress()
992
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
993
    def _next_progress_entry(self):
994
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
995
        self.pb_entries_count += 1
996
        self._emit_progress()
997
998
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
999
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
1000
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1001
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
1002
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
1003
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
1004
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
1005
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1006
    def _set_specific_file_ids(self):
1007
        """populate self.specific_file_ids if we will use it."""
1008
        if not self.use_record_iter_changes:
1009
            # If provided, ensure the specified files are versioned
1010
            if self.specific_files is not None:
1011
                # Note: This routine is being called because it raises
1012
                # PathNotVersionedError as a side effect of finding the IDs. We
1013
                # later use the ids we found as input to the working tree
1014
                # inventory iterator, so we only consider those ids rather than
1015
                # examining the whole tree again.
1016
                # XXX: Dont we have filter_unversioned to do this more
1017
                # cheaply?
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
1018
                self.specific_file_ids = tree.find_ids_across_trees(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1019
                    self.specific_files, [self.basis_tree, self.work_tree])
1020
            else:
1021
                self.specific_file_ids = None