4986.2.1
by Martin Pool
Remove tearDown in tests in favor of addCleanup |
1 |
# Copyright (C) 2009, 2010 Canonical Ltd
|
3990.3.2
by Andrew Bennetts
Fix the do_body NotImplementedError log spam. |
2 |
#
|
3 |
# This program is free software; you can redistribute it and/or modify
|
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
7 |
#
|
|
8 |
# This program is distributed in the hope that it will be useful,
|
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
12 |
#
|
|
13 |
# You should have received a copy of the GNU General Public License
|
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
3990.3.2
by Andrew Bennetts
Fix the do_body NotImplementedError log spam. |
16 |
|
17 |
"""Tests for smart server request infrastructure (bzrlib.smart.request)."""
|
|
18 |
||
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
19 |
import threading |
20 |
||
5273.1.7
by Vincent Ladeuil
No more use of the get_transport imported *symbol*, all uses are through |
21 |
from bzrlib import ( |
22 |
errors, |
|
23 |
transport, |
|
24 |
)
|
|
4205.2.1
by Andrew Bennetts
Fix BzrDir.open in non-main (and non-server-request) thread when bzrlib.smart.request's _pre_open_hook is installed. |
25 |
from bzrlib.bzrdir import BzrDir |
3990.3.2
by Andrew Bennetts
Fix the do_body NotImplementedError log spam. |
26 |
from bzrlib.smart import request |
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
27 |
from bzrlib.tests import TestCase, TestCaseWithMemoryTransport |
3990.3.2
by Andrew Bennetts
Fix the do_body NotImplementedError log spam. |
28 |
|
29 |
||
3990.3.3
by Andrew Bennetts
Add a test that unexpected request bodies trigger a SmartProtocolError from request implementations. |
30 |
class NoBodyRequest(request.SmartServerRequest): |
31 |
"""A request that does not implement do_body."""
|
|
32 |
||
33 |
def do(self): |
|
34 |
return request.SuccessfulSmartServerResponse(('ok',)) |
|
35 |
||
36 |
||
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
37 |
class DoErrorRequest(request.SmartServerRequest): |
38 |
"""A request that raises an error from self.do()."""
|
|
5273.1.7
by Vincent Ladeuil
No more use of the get_transport imported *symbol*, all uses are through |
39 |
|
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
40 |
def do(self): |
41 |
raise errors.NoSuchFile('xyzzy') |
|
42 |
||
43 |
||
5677.2.8
by Martin
More tests for handling of unexpected remote errors |
44 |
class DoUnexpectedErrorRequest(request.SmartServerRequest): |
45 |
"""A request that encounters a generic error in self.do()"""
|
|
46 |
||
47 |
def do(self): |
|
48 |
dict()[1] |
|
49 |
||
50 |
||
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
51 |
class ChunkErrorRequest(request.SmartServerRequest): |
52 |
"""A request that raises an error from self.do_chunk()."""
|
|
53 |
||
54 |
def do(self): |
|
55 |
"""No-op."""
|
|
56 |
pass
|
|
57 |
||
58 |
def do_chunk(self, bytes): |
|
59 |
raise errors.NoSuchFile('xyzzy') |
|
60 |
||
61 |
||
62 |
class EndErrorRequest(request.SmartServerRequest): |
|
63 |
"""A request that raises an error from self.do_end()."""
|
|
64 |
||
65 |
def do(self): |
|
66 |
"""No-op."""
|
|
67 |
pass
|
|
68 |
||
69 |
def do_chunk(self, bytes): |
|
70 |
"""No-op."""
|
|
71 |
pass
|
|
72 |
||
73 |
def do_end(self): |
|
74 |
raise errors.NoSuchFile('xyzzy') |
|
75 |
||
76 |
||
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
77 |
class CheckJailRequest(request.SmartServerRequest): |
78 |
||
79 |
def __init__(self, *args): |
|
80 |
request.SmartServerRequest.__init__(self, *args) |
|
81 |
self.jail_transports_log = [] |
|
82 |
||
83 |
def do(self): |
|
84 |
self.jail_transports_log.append(request.jail_info.transports) |
|
85 |
||
86 |
def do_chunk(self, bytes): |
|
87 |
self.jail_transports_log.append(request.jail_info.transports) |
|
88 |
||
89 |
def do_end(self): |
|
90 |
self.jail_transports_log.append(request.jail_info.transports) |
|
91 |
||
92 |
||
3990.3.2
by Andrew Bennetts
Fix the do_body NotImplementedError log spam. |
93 |
class TestSmartRequest(TestCase): |
94 |
||
95 |
def test_request_class_without_do_body(self): |
|
96 |
"""If a request has no body data, and the request's implementation does
|
|
97 |
not override do_body, then no exception is raised.
|
|
98 |
"""
|
|
99 |
# Create a SmartServerRequestHandler with a SmartServerRequest subclass
|
|
100 |
# that does not implement do_body.
|
|
101 |
handler = request.SmartServerRequestHandler( |
|
102 |
None, {'foo': NoBodyRequest}, '/') |
|
103 |
# Emulate a request with no body (i.e. just args).
|
|
104 |
handler.args_received(('foo',)) |
|
105 |
handler.end_received() |
|
3990.3.3
by Andrew Bennetts
Add a test that unexpected request bodies trigger a SmartProtocolError from request implementations. |
106 |
# Request done, no exception was raised.
|
107 |
||
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
108 |
def test_only_request_code_is_jailed(self): |
109 |
transport = 'dummy transport' |
|
110 |
handler = request.SmartServerRequestHandler( |
|
111 |
transport, {'foo': CheckJailRequest}, '/') |
|
112 |
handler.args_received(('foo',)) |
|
113 |
self.assertEqual(None, request.jail_info.transports) |
|
114 |
handler.accept_body('bytes') |
|
115 |
self.assertEqual(None, request.jail_info.transports) |
|
116 |
handler.end_received() |
|
117 |
self.assertEqual(None, request.jail_info.transports) |
|
118 |
self.assertEqual( |
|
119 |
[[transport]] * 3, handler._command.jail_transports_log) |
|
120 |
||
4797.85.31
by John Arbash Meinel
Categorize all of the requests as safe/unsafe/semi/stream for retrying purposes. |
121 |
def test_all_registered_requests_are_safety_qualified(self): |
122 |
unclassified_requests = [] |
|
4797.85.32
by John Arbash Meinel
Per request, change |
123 |
allowed_info = ('read', 'idem', 'mutate', 'semivfs', 'semi', 'stream') |
4797.85.31
by John Arbash Meinel
Categorize all of the requests as safe/unsafe/semi/stream for retrying purposes. |
124 |
for key in request.request_handlers.keys(): |
125 |
info = request.request_handlers.get_info(key) |
|
4797.85.32
by John Arbash Meinel
Per request, change |
126 |
if info is None or info not in allowed_info: |
4797.85.31
by John Arbash Meinel
Categorize all of the requests as safe/unsafe/semi/stream for retrying purposes. |
127 |
unclassified_requests.append(key) |
128 |
if unclassified_requests: |
|
129 |
self.fail('These requests were not categorized as safe/unsafe' |
|
130 |
' to retry: %s' % (unclassified_requests,)) |
|
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
131 |
|
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
132 |
|
133 |
class TestSmartRequestHandlerErrorTranslation(TestCase): |
|
134 |
"""Tests that SmartServerRequestHandler will translate exceptions raised by
|
|
135 |
a SmartServerRequest into FailedSmartServerResponses.
|
|
136 |
"""
|
|
137 |
||
138 |
def assertNoResponse(self, handler): |
|
139 |
self.assertEqual(None, handler.response) |
|
140 |
||
141 |
def assertResponseIsTranslatedError(self, handler): |
|
142 |
expected_translation = ('NoSuchFile', 'xyzzy') |
|
143 |
self.assertEqual( |
|
144 |
request.FailedSmartServerResponse(expected_translation), |
|
145 |
handler.response) |
|
146 |
||
147 |
def test_error_translation_from_args_received(self): |
|
148 |
handler = request.SmartServerRequestHandler( |
|
149 |
None, {'foo': DoErrorRequest}, '/') |
|
150 |
handler.args_received(('foo',)) |
|
151 |
self.assertResponseIsTranslatedError(handler) |
|
152 |
||
153 |
def test_error_translation_from_chunk_received(self): |
|
154 |
handler = request.SmartServerRequestHandler( |
|
155 |
None, {'foo': ChunkErrorRequest}, '/') |
|
156 |
handler.args_received(('foo',)) |
|
157 |
self.assertNoResponse(handler) |
|
158 |
handler.accept_body('bytes') |
|
159 |
self.assertResponseIsTranslatedError(handler) |
|
160 |
||
161 |
def test_error_translation_from_end_received(self): |
|
162 |
handler = request.SmartServerRequestHandler( |
|
163 |
None, {'foo': EndErrorRequest}, '/') |
|
164 |
handler.args_received(('foo',)) |
|
165 |
self.assertNoResponse(handler) |
|
166 |
handler.end_received() |
|
167 |
self.assertResponseIsTranslatedError(handler) |
|
168 |
||
5677.2.8
by Martin
More tests for handling of unexpected remote errors |
169 |
def test_unexpected_error_translation(self): |
170 |
handler = request.SmartServerRequestHandler( |
|
171 |
None, {'foo': DoUnexpectedErrorRequest}, '/') |
|
172 |
handler.args_received(('foo',)) |
|
173 |
self.assertEqual( |
|
174 |
request.FailedSmartServerResponse(('error', 'KeyError', "1")), |
|
175 |
handler.response) |
|
176 |
||
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
177 |
|
178 |
class TestRequestHanderErrorTranslation(TestCase): |
|
179 |
"""Tests for bzrlib.smart.request._translate_error."""
|
|
180 |
||
181 |
def assertTranslationEqual(self, expected_tuple, error): |
|
182 |
self.assertEqual(expected_tuple, request._translate_error(error)) |
|
183 |
||
184 |
def test_NoSuchFile(self): |
|
185 |
self.assertTranslationEqual( |
|
186 |
('NoSuchFile', 'path'), errors.NoSuchFile('path')) |
|
187 |
||
188 |
def test_LockContention(self): |
|
4556.2.7
by Andrew Bennetts
Update test. |
189 |
# For now, LockContentions are always transmitted with no details.
|
190 |
# Eventually they should include a relpath or url or something else to
|
|
191 |
# identify which lock is busy.
|
|
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
192 |
self.assertTranslationEqual( |
4556.2.7
by Andrew Bennetts
Update test. |
193 |
('LockContention',), errors.LockContention('lock', 'msg')) |
4144.3.1
by Andrew Bennetts
Add Repository.insert_stream_locked server-side implementation, plus tests for server-side _translate_error. |
194 |
|
195 |
def test_TokenMismatch(self): |
|
196 |
self.assertTranslationEqual( |
|
197 |
('TokenMismatch', 'some-token', 'actual-token'), |
|
198 |
errors.TokenMismatch('some-token', 'actual-token')) |
|
199 |
||
5677.2.1
by Martin
Detect and report MemoryError during a smart server request |
200 |
def test_MemoryError(self): |
201 |
self.assertTranslationEqual(("MemoryError",), MemoryError()) |
|
202 |
||
5677.2.8
by Martin
More tests for handling of unexpected remote errors |
203 |
def test_generic_Exception(self): |
204 |
self.assertTranslationEqual(('error', 'Exception', ""), |
|
205 |
Exception()) |
|
206 |
||
207 |
def test_generic_BzrError(self): |
|
208 |
self.assertTranslationEqual(('error', 'BzrError', "some text"), |
|
209 |
errors.BzrError(msg="some text")) |
|
210 |
||
211 |
def test_generic_zlib_error(self): |
|
212 |
from zlib import error |
|
213 |
msg = "Error -3 while decompressing data: incorrect data check" |
|
214 |
self.assertTranslationEqual(('error', 'zlib.error', msg), |
|
215 |
error(msg)) |
|
216 |
||
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
217 |
|
218 |
class TestRequestJail(TestCaseWithMemoryTransport): |
|
5273.1.7
by Vincent Ladeuil
No more use of the get_transport imported *symbol*, all uses are through |
219 |
|
4160.2.2
by Andrew Bennetts
Add setup_jail and teardown_jail to SmartServerRequest. |
220 |
def test_jail(self): |
221 |
transport = self.get_transport('blah') |
|
222 |
req = request.SmartServerRequest(transport) |
|
223 |
self.assertEqual(None, request.jail_info.transports) |
|
224 |
req.setup_jail() |
|
225 |
self.assertEqual([transport], request.jail_info.transports) |
|
226 |
req.teardown_jail() |
|
227 |
self.assertEqual(None, request.jail_info.transports) |
|
228 |
||
4160.2.5
by Andrew Bennetts
Add test_jail_hook. |
229 |
|
230 |
class TestJailHook(TestCaseWithMemoryTransport): |
|
231 |
||
4986.2.1
by Martin Pool
Remove tearDown in tests in favor of addCleanup |
232 |
def setUp(self): |
4986.2.8
by Martin Pool
Add missing super.setUp call |
233 |
super(TestJailHook, self).setUp() |
4986.2.1
by Martin Pool
Remove tearDown in tests in favor of addCleanup |
234 |
def clear_jail_info(): |
235 |
request.jail_info.transports = None |
|
236 |
self.addCleanup(clear_jail_info) |
|
4160.2.5
by Andrew Bennetts
Add test_jail_hook. |
237 |
|
238 |
def test_jail_hook(self): |
|
239 |
request.jail_info.transports = None |
|
240 |
_pre_open_hook = request._pre_open_hook |
|
241 |
# Any transport is fine if jail_info.transports is None
|
|
242 |
t = self.get_transport('foo') |
|
243 |
_pre_open_hook(t) |
|
244 |
# A transport in jail_info.transports is allowed
|
|
245 |
request.jail_info.transports = [t] |
|
246 |
_pre_open_hook(t) |
|
247 |
# A child of a transport in jail_info is allowed
|
|
248 |
_pre_open_hook(t.clone('child')) |
|
249 |
# A parent is not allowed
|
|
4294.2.10
by Robert Collins
Review feedback. |
250 |
self.assertRaises(errors.JailBreak, _pre_open_hook, t.clone('..')) |
4160.2.5
by Andrew Bennetts
Add test_jail_hook. |
251 |
# A completely unrelated transport is not allowed
|
5273.1.7
by Vincent Ladeuil
No more use of the get_transport imported *symbol*, all uses are through |
252 |
self.assertRaises(errors.JailBreak, _pre_open_hook, |
6083.1.1
by Jelmer Vernooij
Use get_transport_from_{url,path} in more places. |
253 |
transport.get_transport_from_url('http://host/')) |
4160.2.5
by Andrew Bennetts
Add test_jail_hook. |
254 |
|
4205.2.1
by Andrew Bennetts
Fix BzrDir.open in non-main (and non-server-request) thread when bzrlib.smart.request's _pre_open_hook is installed. |
255 |
def test_open_bzrdir_in_non_main_thread(self): |
256 |
"""Opening a bzrdir in a non-main thread should work ok.
|
|
257 |
|
|
258 |
This makes sure that the globally-installed
|
|
259 |
bzrlib.smart.request._pre_open_hook, which uses a threading.local(),
|
|
260 |
works in a newly created thread.
|
|
261 |
"""
|
|
262 |
bzrdir = self.make_bzrdir('.') |
|
263 |
transport = bzrdir.root_transport |
|
264 |
thread_result = [] |
|
265 |
def t(): |
|
266 |
BzrDir.open_from_transport(transport) |
|
267 |
thread_result.append('ok') |
|
268 |
thread = threading.Thread(target=t) |
|
269 |
thread.start() |
|
270 |
thread.join() |
|
271 |
self.assertEqual(['ok'], thread_result) |
|
272 |