~bzr-pqm/bzr/bzr.dev

5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1551.8.30 by Aaron Bentley
Tweak from review comments
52
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
53
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
54
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
55
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
56
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
57
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
58
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
59
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
60
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
61
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
62
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
63
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
64
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
65
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
66
from bzrlib.osutils import (get_user_encoding,
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
67
                            is_inside_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
68
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
69
                            splitpath,
70
                            )
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
71
from bzrlib.trace import mutter, note, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
72
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
73
from bzrlib import symbol_versioning
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
74
from bzrlib.urlutils import unescape_for_display
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
75
from bzrlib.i18n import gettext
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
77
class NullCommitReporter(object):
78
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
79
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
80
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
81
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
82
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
83
                                   "to started.", DeprecationWarning,
84
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
85
        pass
86
87
    def snapshot_change(self, change, path):
88
        pass
89
90
    def completed(self, revno, rev_id):
91
        pass
92
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
93
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
94
        pass
95
96
    def missing(self, path):
97
        pass
98
99
    def renamed(self, change, old_path, new_path):
100
        pass
101
2789.2.11 by Ian Clatworthy
remove more reporting stuff
102
    def is_verbose(self):
103
        return False
104
105
106
class ReportCommitToLog(NullCommitReporter):
107
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
108
    def _note(self, format, *args):
109
        """Output a message.
110
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
111
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
112
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
113
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
114
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
115
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
116
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
117
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
118
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
119
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
120
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
121
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
122
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
123
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
124
            # When started was added, location was only made optional by
125
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
126
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
127
                                   "to started.", DeprecationWarning,
128
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
129
            location = ''
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
130
        self._note(gettext('Committing%s'), location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
131
132
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
133
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
134
        # self._note goes to the console too; so while we want to log the
135
        # rev_id, we can't trivially only log it. (See bug 526425). Long
136
        # term we should rearrange the reporting structure, but for now
137
        # we just mutter seperately. We mutter the revid and revno together
138
        # so that concurrent bzr invocations won't lead to confusion.
139
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
140
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
141
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
142
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
143
144
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
145
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
146
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
147
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
148
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
149
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
150
    def is_verbose(self):
151
        return True
152
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
153
1189 by Martin Pool
- BROKEN: partial support for commit into weave
154
class Commit(object):
155
    """Task of committing a new revision.
156
157
    This is a MethodObject: it accumulates state as the commit is
158
    prepared, and then it is discarded.  It doesn't represent
159
    historical revisions, just the act of recording a new one.
160
161
            missing_ids
162
            Modified to hold a list of files that have been deleted from
163
            the working directory; these should be removed from the
164
            working inventory.
485 by Martin Pool
- move commit code into its own module
165
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
166
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
167
                 reporter=None,
168
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
169
        """Create a Commit object.
170
171
        :param reporter: the default reporter to use or None to decide later
172
        """
173
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
174
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
175
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
176
    @staticmethod
177
    def update_revprops(revprops, branch, authors=None, author=None,
178
                        local=False, possible_master_transports=None):
179
        if revprops is None:
180
            revprops = {}
181
        if possible_master_transports is None:
182
            possible_master_transports = []
183
        if not 'branch-nick' in revprops:
184
            revprops['branch-nick'] = branch._get_nick(
185
                local,
186
                possible_master_transports)
187
        if authors is not None:
188
            if author is not None:
189
                raise AssertionError('Specifying both author and authors '
190
                        'is not allowed. Specify just authors instead')
191
            if 'author' in revprops or 'authors' in revprops:
192
                # XXX: maybe we should just accept one of them?
193
                raise AssertionError('author property given twice')
194
            if authors:
195
                for individual in authors:
196
                    if '\n' in individual:
197
                        raise AssertionError('\\n is not a valid character '
198
                                'in an author identity')
199
                revprops['authors'] = '\n'.join(authors)
200
        if author is not None:
201
            symbol_versioning.warn('The parameter author was deprecated'
202
                   ' in version 1.13. Use authors instead',
203
                   DeprecationWarning)
204
            if 'author' in revprops or 'authors' in revprops:
205
                # XXX: maybe we should just accept one of them?
206
                raise AssertionError('author property given twice')
207
            if '\n' in author:
208
                raise AssertionError('\\n is not a valid character '
209
                        'in an author identity')
210
            revprops['authors'] = author
211
        return revprops
212
1189 by Martin Pool
- BROKEN: partial support for commit into weave
213
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
214
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
215
               timestamp=None,
216
               timezone=None,
217
               committer=None,
218
               specific_files=None,
219
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
220
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
221
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
222
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
223
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
224
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
225
               local=False,
226
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
227
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
228
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
229
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
230
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
231
               possible_master_transports=None,
232
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
        """Commit working copy as a new revision.
234
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
235
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
236
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
237
238
        :param timestamp: if not None, seconds-since-epoch for a
239
            postdated/predated commit.
240
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
241
        :param specific_files: If not None, commit only those files. An empty
242
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
243
244
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
245
            Useful for test or import commands that need to tightly
246
            control what revisions are assigned.  If you duplicate
247
            a revision id that exists elsewhere it is your own fault.
248
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
249
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
250
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
251
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
252
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
253
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
254
            contains unknown files.
255
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
256
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
257
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
258
        :param reporter: the reporter to use or None for the default
259
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
260
        :param recursive: If set to 'down', commit in any subtrees that have
261
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
262
        :param exclude: None or a list of relative paths to exclude from the
263
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
264
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
265
        :param lossy: When committing to a foreign VCS, ignore any
266
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
267
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
268
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
269
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
270
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
271
        self.config = config or self.config
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
272
        return operation.run(
273
               message=message,
274
               timestamp=timestamp,
275
               timezone=timezone,
276
               committer=committer,
277
               specific_files=specific_files,
278
               rev_id=rev_id,
279
               allow_pointless=allow_pointless,
280
               strict=strict,
281
               verbose=verbose,
282
               working_tree=working_tree,
283
               local=local,
284
               reporter=reporter,
285
               message_callback=message_callback,
286
               recursive=recursive,
287
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
288
               possible_master_transports=possible_master_transports,
289
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
290
291
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
292
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
293
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
294
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
295
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
296
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
297
        if working_tree is None:
298
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
299
        else:
300
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
301
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
302
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
303
                if not self.branch.repository.supports_rich_root():
304
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
305
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
306
            if message is not None:
307
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
308
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
309
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
310
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
311
                raise BzrError("The message or message_callback keyword"
312
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
313
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
314
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
315
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
316
        if exclude is not None:
317
            self.exclude = sorted(
318
                minimum_path_selection(exclude))
319
        else:
320
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
321
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
322
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
323
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
324
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
325
        # self.specific_files is None to indicate no filter, or any iterable to
326
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
327
        if specific_files is not None:
328
            self.specific_files = sorted(
329
                minimum_path_selection(specific_files))
330
        else:
331
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
332
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
333
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
334
        self.message_callback = message_callback
335
        self.timestamp = timestamp
336
        self.timezone = timezone
337
        self.committer = committer
338
        self.strict = strict
339
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
340
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
341
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
342
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
343
        self.parents = self.work_tree.get_parent_ids()
344
        # We can use record_iter_changes IFF iter_changes is compatible with
345
        # the command line parameters, and the repository has fast delta
346
        # generation. See bug 347649.
347
        self.use_record_iter_changes = (
348
            not self.exclude and 
349
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
350
            (self.branch.repository._format.fast_deltas or
351
             len(self.parents) < 2))
5582.10.6 by Jelmer Vernooij
Fix ui imports.
352
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
353
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
354
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
355
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
356
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
357
        operation.add_cleanup(self.basis_tree.unlock)
358
        # Cannot commit with conflicts present.
359
        if len(self.work_tree.conflicts()) > 0:
360
            raise ConflictsInTree
361
362
        # Setup the bound branch variables as needed.
363
        self._check_bound_branch(operation, possible_master_transports)
364
365
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
366
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
367
368
        # Complete configuration setup
369
        if reporter is not None:
370
            self.reporter = reporter
371
        elif self.reporter is None:
372
            self.reporter = self._select_reporter()
373
        if self.config is None:
374
            self.config = self.branch.get_config()
375
376
        self._set_specific_file_ids()
377
378
        # Setup the progress bar. As the number of files that need to be
379
        # committed in unknown, progress is reported as stages.
380
        # We keep track of entries separately though and include that
381
        # information in the progress bar during the relevant stages.
382
        self.pb_stage_name = ""
383
        self.pb_stage_count = 0
384
        self.pb_stage_total = 5
385
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
386
            # 2 extra stages: "Uploading data to master branch" and "Merging
387
            # tags to master branch"
388
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
389
        self.pb.show_pct = False
390
        self.pb.show_spinner = False
391
        self.pb.show_eta = False
392
        self.pb.show_count = True
393
        self.pb.show_bar = True
394
395
        self._gather_parents()
396
        # After a merge, a selected file commit is not supported.
397
        # See 'bzr help merge' for an explanation as to why.
398
        if len(self.parents) > 1 and self.specific_files is not None:
399
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
400
        # Excludes are a form of selected file commit.
401
        if len(self.parents) > 1 and self.exclude:
402
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
403
404
        # Collect the changes
405
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
406
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
407
        self.builder = self.branch.get_commit_builder(self.parents,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
408
            self.config, timestamp, timezone, committer, self.revprops,
409
            rev_id, lossy=lossy)
5718.4.9 by Jelmer Vernooij
Fix logic for raising ExcludesUnsupported exception. It's a pity we have no record-iter-changes-only formats in bzr.dev.
410
        if not self.builder.supports_record_entry_contents and self.exclude:
5718.4.5 by Jelmer Vernooij
Move ExcludesUnsupported raise location.
411
            self.builder.abort()
412
            raise errors.ExcludesUnsupported(self.branch.repository)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
413
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
414
        if self.builder.updates_branch and self.bound_branch:
415
            self.builder.abort()
416
            raise AssertionError(
417
                "bound branches not supported for commit builders "
418
                "that update the branch")
419
1189 by Martin Pool
- BROKEN: partial support for commit into weave
420
        try:
5718.4.8 by Jelmer Vernooij
Revert conditional will_record_deletes.
421
            self.builder.will_record_deletes()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
422
            # find the location being committed to
423
            if self.bound_branch:
424
                master_location = self.master_branch.base
425
            else:
426
                master_location = self.branch.base
427
428
            # report the start of the commit
429
            self.reporter.started(new_revno, self.rev_id, master_location)
430
431
            self._update_builder_with_changes()
432
            self._check_pointless()
433
434
            # TODO: Now the new inventory is known, check for conflicts.
435
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
436
            # weave lines, because nothing should be recorded until it is known
437
            # that commit will succeed.
438
            self._set_progress_stage("Saving data locally")
439
            self.builder.finish_inventory()
440
441
            # Prompt the user for a commit message if none provided
442
            message = message_callback(self)
443
            self.message = message
444
445
            # Add revision data to the local branch
446
            self.rev_id = self.builder.commit(self.message)
447
448
        except Exception, e:
449
            mutter("aborting commit write group because of exception:")
450
            trace.log_exception_quietly()
451
            self.builder.abort()
452
            raise
453
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
454
        self._update_branches(old_revno, old_revid, new_revno)
455
456
        # Make the working tree be up to date with the branch. This
457
        # includes automatic changes scheduled to be made to the tree, such
458
        # as updating its basis and unversioning paths that were missing.
459
        self.work_tree.unversion(self.deleted_ids)
460
        self._set_progress_stage("Updating the working tree")
461
        self.work_tree.update_basis_by_delta(self.rev_id,
462
             self.builder.get_basis_delta())
463
        self.reporter.completed(new_revno, self.rev_id)
464
        self._process_post_hooks(old_revno, new_revno)
465
        return self.rev_id
466
467
    def _update_branches(self, old_revno, old_revid, new_revno):
468
        """Update the master and local branch to the new revision.
469
470
        This will try to make sure that the master branch is updated
471
        before the local branch.
472
473
        :param old_revno: Revision number of master branch before the
474
            commit
475
        :param old_revid: Tip of master branch before the commit
476
        :param new_revno: Revision number of the new commit
477
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
478
        if not self.builder.updates_branch:
479
            self._process_pre_hooks(old_revno, new_revno)
480
481
            # Upload revision data to the master.
482
            # this will propagate merged revisions too if needed.
483
            if self.bound_branch:
484
                self._set_progress_stage("Uploading data to master branch")
485
                # 'commit' to the master first so a timeout here causes the
486
                # local branch to be out of date
487
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
488
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
489
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
490
                    self.branch.fetch(self.master_branch, self.rev_id)
491
492
            # and now do the commit locally.
493
            self.branch.set_last_revision_info(new_revno, self.rev_id)
494
        else:
495
            try:
496
                self._process_pre_hooks(old_revno, new_revno)
497
            except:
498
                # The commit builder will already have updated the branch,
499
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
500
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
501
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
502
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
503
        # Merge local tags to remote
504
        if self.bound_branch:
505
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
506
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
507
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
508
            if tag_conflicts:
509
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
6138.3.5 by Jonathan Riddell
make the test suite pass
510
                note( gettext("Conflicting tags in bound branch:\n{0}".format(
511
                    "\n".join(warning_lines))) )
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
512
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
513
    def _select_reporter(self):
514
        """Select the CommitReporter to use."""
515
        if is_quiet():
516
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
517
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
518
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
519
    def _check_pointless(self):
520
        if self.allow_pointless:
521
            return
522
        # A merge with no effect on files
523
        if len(self.parents) > 1:
524
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
525
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
526
            return
527
        raise PointlessCommit()
528
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
529
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
530
        """Check to see if the local branch is bound.
531
532
        If it is bound, then most of the commit will actually be
533
        done using the remote branch as the target branch.
534
        Only at the end will the local branch be updated.
535
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
536
        if self.local and not self.branch.get_bound_location():
537
            raise errors.LocalRequiresBoundBranch()
538
539
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
540
            self.master_branch = self.branch.get_master_branch(
541
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
542
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
543
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
544
            # make this branch the reference branch for out of date checks.
545
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
546
            return
547
548
        # If the master branch is bound, we must fail
549
        master_bound_location = self.master_branch.get_bound_location()
550
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
551
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
552
                    self.master_branch, master_bound_location)
553
554
        # TODO: jam 20051230 We could automatically push local
555
        #       commits to the remote branch if they would fit.
556
        #       But for now, just require remote to be identical
557
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
558
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
559
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
560
        master_info = self.master_branch.last_revision_info()
561
        local_info = self.branch.last_revision_info()
562
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
563
            raise errors.BoundBranchOutOfDate(self.branch,
564
                    self.master_branch)
565
566
        # Now things are ready to change the master branch
567
        # so grab the lock
568
        self.bound_branch = self.branch
569
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
570
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
571
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
572
    def _check_out_of_date_tree(self):
573
        """Check that the working tree is up to date.
574
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
575
        :return: old_revision_number, old_revision_id, new_revision_number
576
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
577
        """
578
        try:
579
            first_tree_parent = self.work_tree.get_parent_ids()[0]
580
        except IndexError:
581
            # if there are no parents, treat our parent as 'None'
582
            # this is so that we still consider the master branch
583
            # - in a checkout scenario the tree may have no
584
            # parents but the branch may do.
585
            first_tree_parent = bzrlib.revision.NULL_REVISION
586
        old_revno, master_last = self.master_branch.last_revision_info()
587
        if master_last != first_tree_parent:
588
            if master_last != bzrlib.revision.NULL_REVISION:
589
                raise errors.OutOfDateTree(self.work_tree)
590
        if self.branch.repository.has_revision(first_tree_parent):
591
            new_revno = old_revno + 1
592
        else:
593
            # ghost parents never appear in revision history.
594
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
595
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
596
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
597
    def _process_pre_hooks(self, old_revno, new_revno):
598
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
599
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
600
        self._process_hooks("pre_commit", old_revno, new_revno)
601
602
    def _process_post_hooks(self, old_revno, new_revno):
603
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
604
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
605
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
606
        # old style commit hooks - should be deprecated ? (obsoleted in
607
        # 0.15)
608
        if self.config.post_commit() is not None:
609
            hooks = self.config.post_commit().split(' ')
610
            # this would be nicer with twisted.python.reflect.namedAny
611
            for hook in hooks:
612
                result = eval(hook + '(branch, rev_id)',
613
                              {'branch':self.branch,
614
                               'bzrlib':bzrlib,
615
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
616
        # process new style post commit hooks
617
        self._process_hooks("post_commit", old_revno, new_revno)
618
619
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
620
        if not Branch.hooks[hook_name]:
621
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
622
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
623
        # new style commit hooks:
624
        if not self.bound_branch:
625
            hook_master = self.branch
626
            hook_local = None
627
        else:
628
            hook_master = self.master_branch
629
            hook_local = self.branch
630
        # With bound branches, when the master is behind the local branch,
631
        # the 'old_revno' and old_revid values here are incorrect.
632
        # XXX: FIXME ^. RBC 20060206
633
        if self.parents:
634
            old_revid = self.parents[0]
635
        else:
636
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
637
2659.3.9 by NamNguyen
branch.py:
638
        if hook_name == "pre_commit":
639
            future_tree = self.builder.revision_tree()
640
            tree_delta = future_tree.changes_from(self.basis_tree,
641
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
642
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
643
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
644
            # show the running hook in the progress bar. As hooks may
645
            # end up doing nothing (e.g. because they are not configured by
646
            # the user) this is still showing progress, not showing overall
647
            # actions - its up to each plugin to show a UI if it want's to
648
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
649
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
650
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
651
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
652
            if 'hooks' in debug.debug_flags:
653
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
654
            if hook_name == "post_commit":
655
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
656
                     self.rev_id)
657
            elif hook_name == "pre_commit":
658
                hook(hook_local, hook_master,
659
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
660
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
661
1223 by Martin Pool
- store inventories in weave
662
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
663
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
664
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
665
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
666
        if self.use_record_iter_changes:
667
            return
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
668
        self.basis_inv = self.basis_tree.inventory
669
        self.parent_invs = [self.basis_inv]
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
670
        for revision in self.parents[1:]:
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
671
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
672
                mutter('commit parent revision {%s}', revision)
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
673
                inventory = self.branch.repository.get_inventory(revision)
674
                self.parent_invs.append(inventory)
675
            else:
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
676
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
677
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
678
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
679
        """Update the commit builder with the data about what has changed.
680
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
681
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
682
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
683
        mutter("Selecting files for commit with filter %s", specific_files)
684
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
685
        self._check_strict()
686
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
687
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
688
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
689
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
690
            for file_id, path, fs_hash in self.builder.record_iter_changes(
691
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
692
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
693
        else:
694
            # Build the new inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
695
            self._populate_from_inventory()
696
            self._record_unselected()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
697
            self._report_and_accumulate_deletes()
698
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
699
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
700
        """Process iter_changes.
701
702
        This method reports on the changes in iter_changes to the user, and 
703
        converts 'missing' entries in the iter_changes iterator to 'deleted'
704
        entries. 'missing' entries have their
705
706
        :param iter_changes: An iter_changes to process.
707
        :return: A generator of changes.
708
        """
709
        reporter = self.reporter
710
        report_changes = reporter.is_verbose()
711
        deleted_ids = []
712
        for change in iter_changes:
713
            if report_changes:
714
                old_path = change[1][0]
715
                new_path = change[1][1]
716
                versioned = change[3][1]
717
            kind = change[6][1]
718
            versioned = change[3][1]
719
            if kind is None and versioned:
720
                # 'missing' path
721
                if report_changes:
722
                    reporter.missing(new_path)
723
                deleted_ids.append(change[0])
724
                # Reset the new path (None) and new versioned flag (False)
725
                change = (change[0], (change[1][0], None), change[2],
726
                    (change[3][0], False)) + change[4:]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
727
                new_path = change[1][1]
728
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
729
            elif kind == 'tree-reference':
730
                if self.recursive == 'down':
731
                    self._commit_nested_tree(change[0], change[1][1])
732
            if change[3][0] or change[3][1]:
733
                yield change
734
                if report_changes:
735
                    if new_path is None:
736
                        reporter.deleted(old_path)
737
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
738
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
739
                    elif old_path != new_path:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
740
                        reporter.renamed(gettext('renamed'), old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
741
                    else:
742
                        if (new_path or 
743
                            self.work_tree.branch.repository._format.rich_root_data):
744
                            # Don't report on changes to '' in non rich root
745
                            # repositories.
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
746
                            reporter.snapshot_change(gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
747
            self._next_progress_entry()
748
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
749
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
750
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
751
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
752
        # If specific files are selected, then all un-selected files must be
753
        # recorded in their previous state. For more details, see
754
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
755
        if self.specific_files or self.exclude:
756
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
757
            for path, old_ie in self.basis_inv.iter_entries():
5967.7.1 by Martin Pool
Deprecate __contains__ on Tree and Inventory
758
                if self.builder.new_inventory.has_id(old_ie.file_id):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
759
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
760
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
761
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
762
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
763
                    # was inside the selected path, and not excluded - if not
764
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
765
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
766
                # From here down it was either not selected, or was excluded:
767
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
768
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
769
                # Note: specific file commits after a merge are currently
770
                # prohibited. This test is for sanity/safety in case it's
771
                # required after that changes.
772
                if len(self.parents) > 1:
773
                    ie.revision = None
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
774
                self.builder.record_entry_contents(ie, self.parent_invs, path,
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
775
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
776
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
777
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
778
        if (isinstance(self.basis_inv, Inventory)
779
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
780
            # the older Inventory classes provide a _byid dict, and building a
781
            # set from the keys of this dict is substantially faster than even
782
            # getting a set of ids from the inventory
783
            #
784
            # <lifeless> set(dict) is roughly the same speed as
785
            # set(iter(dict)) and both are significantly slower than
786
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
787
            deleted_ids = set(self.basis_inv._byid.keys()) - \
788
               set(self.builder.new_inventory._byid.keys())
789
        else:
790
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
791
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
792
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
793
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
794
                for file_id in deleted_ids]
795
            deleted.sort()
796
            # XXX: this is not quite directory-order sorting
797
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
798
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
799
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
800
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
801
    def _check_strict(self):
802
        # XXX: when we use iter_changes this would likely be faster if
803
        # iter_changes would check for us (even in the presence of
804
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
805
        if self.strict:
806
            # raise an exception as soon as we find a single unknown.
807
            for unknown in self.work_tree.unknowns():
808
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
809
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
810
    def _populate_from_inventory(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
811
        """Populate the CommitBuilder by walking the working tree inventory."""
812
        # Build the revision inventory.
813
        #
814
        # This starts by creating a new empty inventory. Depending on
815
        # which files are selected for commit, and what is present in the
816
        # current tree, the new inventory is populated. inventory entries
817
        # which are candidates for modification have their revision set to
818
        # None; inventory entries that are carried over untouched have their
819
        # revision set to their prior value.
820
        #
821
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
822
        # results to create a new inventory at the same time, which results
823
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
824
        # ADHB 11-07-2006
825
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
826
        specific_files = self.specific_files
827
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
828
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
829
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
830
        # A tree of paths that have been deleted. E.g. if foo/bar has been
831
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
832
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
833
        # XXX: Note that entries may have the wrong kind because the entry does
834
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
835
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
836
        # NB: entries will include entries within the excluded ids/paths
837
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
838
        entries = work_inv.iter_entries_by_dir(
839
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
840
        for path, existing_ie in entries:
841
            file_id = existing_ie.file_id
842
            name = existing_ie.name
843
            parent_id = existing_ie.parent_id
844
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
845
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
846
            # The deleted path ids are also recorded so they can be explicitly
847
            # unversioned later.
848
            if deleted_paths:
849
                path_segments = splitpath(path)
850
                deleted_dict = deleted_paths
851
                for segment in path_segments:
852
                    deleted_dict = deleted_dict.get(segment, None)
853
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
854
                        # We either took a path not present in the dict
855
                        # (deleted_dict was None), or we've reached an empty
856
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
857
                        break
858
                else:
859
                    deleted_dict = None
860
                if deleted_dict is not None:
861
                    # the path has a deleted parent, do not add it.
862
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
863
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
864
                # Skip excluded paths. Excluded paths are processed by
865
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
866
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
867
            content_summary = self.work_tree.path_content_summary(path)
868
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
869
            # Note that when a filter of specific files is given, we must only
870
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
871
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
872
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
873
                    if not deleted_paths:
874
                        # path won't have been split yet.
875
                        path_segments = splitpath(path)
876
                    deleted_dict = deleted_paths
877
                    for segment in path_segments:
878
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
879
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
880
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
881
                    deleted_ids.append(file_id)
882
                    continue
4595.11.14 by Martin Pool
Small code cleanups
883
            # TODO: have the builder do the nested commit just-in-time IF and
884
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
885
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
886
                # enforce repository nested tree policy.
887
                if (not self.work_tree.supports_tree_reference() or
888
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
889
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
890
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
891
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
892
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
893
                    nested_revision_id = self._commit_nested_tree(
894
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
895
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
896
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
897
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
898
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
899
900
            # Record an entry for this item
901
            # Note: I don't particularly want to have the existing_ie
902
            # parameter but the test suite currently (28-Jun-07) breaks
903
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
904
            definitely_changed = kind != existing_ie.kind
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
905
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
906
                parent_id, definitely_changed, existing_ie, report_changes,
907
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
908
909
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
910
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
911
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
912
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
913
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
914
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
915
        # FIXME: be more comprehensive here:
916
        # this works when both trees are in --trees repository,
917
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
918
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
919
        # finally implement the explicit-caches approach design
920
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
921
        if sub_tree.branch.repository.has_same_location(
922
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
923
            sub_tree.branch.repository = \
924
                self.work_tree.branch.repository
925
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
926
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
927
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
928
                message_callback=self.message_callback,
929
                timestamp=self.timestamp, timezone=self.timezone,
930
                committer=self.committer,
931
                allow_pointless=self.allow_pointless,
932
                strict=self.strict, verbose=self.verbose,
933
                local=self.local, reporter=self.reporter)
934
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
935
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
936
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
937
    def _record_entry(self, path, file_id, specific_files, kind, name,
938
        parent_id, definitely_changed, existing_ie, report_changes,
939
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
940
        "Record the new inventory entry for a path if any."
941
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
942
        # mutter('%s selected for commit', path)
943
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
944
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
945
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
946
            ie = existing_ie.copy()
947
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
948
        # For carried over entries we don't care about the fs hash - the repo
949
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
950
        _, _, fs_hash = self.builder.record_entry_contents(
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
951
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
952
        if report_changes:
953
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
954
        if fs_hash:
955
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
956
        return ie
957
958
    def _report_change(self, ie, path):
959
        """Report a change to the user.
960
961
        The change that has occurred is described relative to the basis
962
        inventory.
963
        """
964
        if (self.basis_inv.has_id(ie.file_id)):
965
            basis_ie = self.basis_inv[ie.file_id]
966
        else:
967
            basis_ie = None
968
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
969
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
970
            InventoryEntry.MODIFIED_AND_RENAMED):
971
            old_path = self.basis_inv.id2path(ie.file_id)
972
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
973
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
974
        else:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
975
            if change == gettext('unchanged'):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
976
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
977
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
978
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
979
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
980
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
981
        """Set the progress stage and emit an update to the progress bar."""
982
        self.pb_stage_name = name
983
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
984
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
985
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
986
        else:
987
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
988
        self._emit_progress()
989
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
990
    def _next_progress_entry(self):
991
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
992
        self.pb_entries_count += 1
993
        self._emit_progress()
994
995
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
996
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
997
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
998
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
999
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
1000
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
1001
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
1002
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1003
    def _set_specific_file_ids(self):
1004
        """populate self.specific_file_ids if we will use it."""
1005
        if not self.use_record_iter_changes:
1006
            # If provided, ensure the specified files are versioned
1007
            if self.specific_files is not None:
1008
                # Note: This routine is being called because it raises
1009
                # PathNotVersionedError as a side effect of finding the IDs. We
1010
                # later use the ids we found as input to the working tree
1011
                # inventory iterator, so we only consider those ids rather than
1012
                # examining the whole tree again.
1013
                # XXX: Dont we have filter_unversioned to do this more
1014
                # cheaply?
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
1015
                self.specific_file_ids = tree.find_ids_across_trees(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1016
                    self.specific_files, [self.basis_tree, self.work_tree])
1017
            else:
1018
                self.specific_file_ids = None