5599.2.1
by John Arbash Meinel
Fix breaking corrupt lock files on Windows. |
1 |
# Copyright (C) 2006-2011 Canonical Ltd
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
2 |
#
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
3 |
# This program is free software; you can redistribute it and/or modify
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
7 |
#
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
8 |
# This program is distributed in the hope that it will be useful,
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
12 |
#
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
13 |
# You should have received a copy of the GNU General Public License
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
16 |
|
1553.5.31
by Martin Pool
LockDir doc corrections |
17 |
"""On-disk mutex protecting a resource
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
18 |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
19 |
bzr on-disk objects are locked by the existence of a directory with a
|
20 |
particular name within the control directory. We use this rather than OS
|
|
21 |
internal locks (such as flock etc) because they can be seen across all
|
|
22 |
transports, including http.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
23 |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
24 |
Objects can be read if there is only physical read access; therefore
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
25 |
readers can never be required to create a lock, though they will
|
26 |
check whether a writer is using the lock. Writers can't detect
|
|
27 |
whether anyone else is reading from the resource as they write.
|
|
28 |
This works because of ordering constraints that make sure readers
|
|
29 |
see a consistent view of existing data.
|
|
30 |
||
31 |
Waiting for a lock must be done by polling; this can be aborted after
|
|
32 |
a timeout.
|
|
33 |
||
34 |
Locks must always be explicitly released, typically from a try/finally
|
|
35 |
block -- they are not released from a finalizer or when Python
|
|
36 |
exits.
|
|
37 |
||
38 |
Locks may fail to be released if the process is abruptly terminated
|
|
39 |
(machine stop, SIGKILL) or if a remote transport becomes permanently
|
|
40 |
disconnected. There is therefore a method to break an existing lock.
|
|
41 |
This should rarely be used, and generally only with user approval.
|
|
42 |
Locks contain some information on when the lock was taken and by who
|
|
43 |
which may guide in deciding whether it can safely be broken. (This is
|
|
44 |
similar to the messages displayed by emacs and vim.) Note that if the
|
|
45 |
lock holder is still alive they will get no notification that the lock
|
|
46 |
has been broken and will continue their work -- so it is important to be
|
|
47 |
sure they are actually dead.
|
|
48 |
||
49 |
A lock is represented on disk by a directory of a particular name,
|
|
50 |
containing an information file. Taking a lock is done by renaming a
|
|
51 |
temporary directory into place. We use temporary directories because
|
|
52 |
for all known transports and filesystems we believe that exactly one
|
|
53 |
attempt to claim the lock will succeed and the others will fail. (Files
|
|
54 |
won't do because some filesystems or transports only have
|
|
55 |
rename-and-overwrite, making it hard to tell who won.)
|
|
56 |
||
57 |
The desired characteristics are:
|
|
58 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
59 |
* Locks are not reentrant. (That is, a client that tries to take a
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
60 |
lock it already holds may deadlock or fail.)
|
61 |
* Stale locks can be guessed at by a heuristic
|
|
62 |
* Lost locks can be broken by any client
|
|
63 |
* Failed lock operations leave little or no mess
|
|
64 |
* Deadlocks are avoided by having a timeout always in use, clients
|
|
65 |
desiring indefinite waits can retry or set a silly big timeout.
|
|
66 |
||
67 |
Storage formats use the locks, and also need to consider concurrency
|
|
68 |
issues underneath the lock. A format may choose not to use a lock
|
|
69 |
at all for some operations.
|
|
70 |
||
71 |
LockDirs always operate over a Transport. The transport may be readonly, in
|
|
72 |
which case the lock can be queried but not acquired.
|
|
73 |
||
74 |
Locks are identified by a path name, relative to a base transport.
|
|
75 |
||
76 |
Calling code will typically want to make sure there is exactly one LockDir
|
|
77 |
object per actual lock on disk. This module does nothing to prevent aliasing
|
|
78 |
and deadlocks will likely occur if the locks are aliased.
|
|
79 |
||
80 |
In the future we may add a "freshen" method which can be called
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
81 |
by a lock holder to check that their lock has not been broken, and to
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
82 |
update the timestamp within it.
|
83 |
||
1553.5.18
by Martin Pool
LockDir should use Transport.rename when releasing locks too. |
84 |
Example usage:
|
85 |
||
86 |
>>> from bzrlib.transport.memory import MemoryTransport
|
|
87 |
>>> # typically will be obtained from a BzrDir, Branch, etc
|
|
88 |
>>> t = MemoryTransport()
|
|
89 |
>>> l = LockDir(t, 'sample-lock')
|
|
1553.5.61
by Martin Pool
Locks protecting LockableFiles must now be explicitly created before use. |
90 |
>>> l.create()
|
2555.3.11
by Martin Pool
fix up doctest example for token being returned from wait_lock |
91 |
>>> token = l.wait_lock()
|
1553.5.18
by Martin Pool
LockDir should use Transport.rename when releasing locks too. |
92 |
>>> # do something here
|
93 |
>>> l.unlock()
|
|
94 |
||
5425.6.1
by Martin Pool
Only detect as stale locks from the same user |
95 |
Some classes of stale locks can be predicted by checking: the host name is the
|
96 |
same as the local host name; the user name is the same as the local user; the
|
|
97 |
process id no longer exists. The check on user name is not strictly necessary
|
|
98 |
but helps protect against colliding host names.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
99 |
"""
|
100 |
||
2555.3.10
by Martin Pool
doc |
101 |
|
102 |
# TODO: We sometimes have the problem that our attempt to rename '1234' to
|
|
103 |
# 'held' fails because the transport server moves into an existing directory,
|
|
104 |
# rather than failing the rename. If we made the info file name the same as
|
|
105 |
# the locked directory name we would avoid this problem because moving into
|
|
106 |
# the held directory would implicitly clash. However this would not mesh with
|
|
107 |
# the existing locking code and needs a new format of the containing object.
|
|
108 |
# -- robertc, mbp 20070628
|
|
109 |
||
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
110 |
import errno |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
111 |
import os |
112 |
import time |
|
113 |
||
2055.2.1
by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email |
114 |
from bzrlib import ( |
5425.4.15
by Martin Pool
Add steal_dead_locks option letting automatic lock-breaking be turned off |
115 |
config, |
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
116 |
debug, |
2055.2.1
by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email |
117 |
errors, |
3331.3.1
by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing |
118 |
lock, |
4852.1.1
by John Arbash Meinel
Change the LockDir code to use get_bytes rather than get(). |
119 |
osutils, |
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
120 |
ui, |
121 |
urlutils, |
|
2055.2.1
by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email |
122 |
)
|
4634.85.9
by Andrew Bennetts
Add some experimental decorators: @only_raises(..) and @cleanup_method. |
123 |
from bzrlib.decorators import only_raises |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
124 |
from bzrlib.errors import ( |
125 |
DirectoryNotEmpty, |
|
126 |
FileExists, |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
127 |
LockBreakMismatch, |
1553.5.23
by Martin Pool
Start LockDir.confirm method and LockBroken exception |
128 |
LockBroken, |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
129 |
LockContention, |
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
130 |
LockCorrupt, |
2872.5.1
by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701). |
131 |
LockFailed, |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
132 |
LockNotHeld, |
133 |
NoSuchFile, |
|
1662.1.12
by Martin Pool
Translate unknown sftp errors to PathError, no NoSuchFile |
134 |
PathError, |
1558.10.1
by Aaron Bentley
Handle lockdirs over NFS properly |
135 |
ResourceBusy, |
2872.5.1
by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701). |
136 |
TransportError, |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
137 |
)
|
1957.1.1
by John Arbash Meinel
Report to the user when we are spinning on a lock |
138 |
from bzrlib.trace import mutter, note |
3224.5.40
by Andrew Bennetts
Keep importing format_delta into lockdir.py (why does pyflakes say it is unused?) |
139 |
from bzrlib.osutils import format_delta, rand_chars, get_host_name |
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
140 |
from bzrlib.i18n import gettext |
3224.5.31
by Andrew Bennetts
A couple more lazy imports, helps 'bzr log --line -r -1' a little. |
141 |
|
142 |
from bzrlib.lazy_import import lazy_import |
|
143 |
lazy_import(globals(), """ |
|
3224.5.39
by Andrew Bennetts
Tweak lazy_import in lockdir.py to avoid confusing DocTestSuite |
144 |
from bzrlib import rio
|
3224.5.31
by Andrew Bennetts
A couple more lazy imports, helps 'bzr log --line -r -1' a little. |
145 |
""") |
1957.1.15
by John Arbash Meinel
Review feedback from Robert |
146 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
147 |
# XXX: At the moment there is no consideration of thread safety on LockDir
|
148 |
# objects. This should perhaps be updated - e.g. if two threads try to take a
|
|
149 |
# lock at the same time they should *both* get it. But then that's unlikely
|
|
150 |
# to be a good idea.
|
|
151 |
||
152 |
# TODO: Perhaps store some kind of note like the bzr command line in the lock
|
|
153 |
# info?
|
|
154 |
||
155 |
# TODO: Some kind of callback run while polling a lock to show progress
|
|
156 |
# indicators.
|
|
157 |
||
1553.5.59
by Martin Pool
Pass file/mode bits through to creation of lock files/dirs |
158 |
# TODO: Make sure to pass the right file and directory mode bits to all
|
159 |
# files/dirs created.
|
|
160 |
||
1957.1.15
by John Arbash Meinel
Review feedback from Robert |
161 |
|
5284.6.7
by Parth Malwankar
set _DEFAULT_TIMEOUT_SECONDS to 30s based on discussion on bug #592148 |
162 |
_DEFAULT_TIMEOUT_SECONDS = 30 |
1957.1.9
by John Arbash Meinel
Change default timeouts, and report differently the first failure |
163 |
_DEFAULT_POLL_SECONDS = 1.0 |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
164 |
|
1957.1.15
by John Arbash Meinel
Review feedback from Robert |
165 |
|
3724.1.1
by Martin Pool
Move Lock hooks onto a base Lock class and make them more consistent with other lock classes |
166 |
class LockDir(lock.Lock): |
3331.3.5
by Martin Pool
Move physical lock hooks onto new PhysicalLock class variable |
167 |
"""Write-lock guarding access to data.
|
168 |
"""
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
169 |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
170 |
__INFO_NAME = '/info' |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
171 |
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
172 |
def __init__(self, transport, path, file_modebits=0644, dir_modebits=0755, |
173 |
extra_holder_info=None): |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
174 |
"""Create a new LockDir object.
|
175 |
||
176 |
The LockDir is initially unlocked - this just creates the object.
|
|
177 |
||
178 |
:param transport: Transport which will contain the lock
|
|
179 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
180 |
:param path: Path to the lock within the base directory of the
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
181 |
transport.
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
182 |
|
183 |
:param extra_holder_info: If passed, {str:str} dict of extra or
|
|
184 |
updated information to insert into the info file when the lock is
|
|
185 |
taken.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
186 |
"""
|
187 |
self.transport = transport |
|
188 |
self.path = path |
|
189 |
self._lock_held = False |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
190 |
self._locked_via_token = False |
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
191 |
self._fake_read_lock = False |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
192 |
self._held_dir = path + '/held' |
193 |
self._held_info_path = self._held_dir + self.__INFO_NAME |
|
1553.5.59
by Martin Pool
Pass file/mode bits through to creation of lock files/dirs |
194 |
self._file_modebits = file_modebits |
195 |
self._dir_modebits = dir_modebits |
|
1957.1.1
by John Arbash Meinel
Report to the user when we are spinning on a lock |
196 |
self._report_function = note |
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
197 |
self.extra_holder_info = extra_holder_info |
5425.4.25
by Martin Pool
Support auto-stealing dead locks, but turn it off by default. |
198 |
self._warned_about_lock_holder = None |
1957.1.1
by John Arbash Meinel
Report to the user when we are spinning on a lock |
199 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
200 |
def __repr__(self): |
201 |
return '%s(%s%s)' % (self.__class__.__name__, |
|
4556.2.6
by Andrew Bennetts
More conservative fix for LockContention serialisation. |
202 |
self.transport.base, |
203 |
self.path) |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
204 |
|
1553.5.13
by Martin Pool
New Transport.rename that mustn't overwrite |
205 |
is_held = property(lambda self: self._lock_held) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
206 |
|
1666.1.4
by Robert Collins
* 'Metadir' is now the default disk format. This improves behaviour in |
207 |
def create(self, mode=None): |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
208 |
"""Create the on-disk lock.
|
209 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
210 |
This is typically only called when the object/directory containing the
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
211 |
directory is first created. The lock is not held when it's created.
|
212 |
"""
|
|
2555.3.13
by Martin Pool
LockDir cleanups |
213 |
self._trace("create lock directory") |
2872.5.1
by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701). |
214 |
try: |
215 |
self.transport.mkdir(self.path, mode=mode) |
|
216 |
except (TransportError, PathError), e: |
|
217 |
raise LockFailed(self, e) |
|
218 |
||
2555.3.20
by Martin Pool
rename _lock_core to _attempt_lock |
219 |
def _attempt_lock(self): |
2555.3.13
by Martin Pool
LockDir cleanups |
220 |
"""Make the pending directory and attempt to rename into place.
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
221 |
|
2555.3.13
by Martin Pool
LockDir cleanups |
222 |
If the rename succeeds, we read back the info file to check that we
|
223 |
really got the lock.
|
|
224 |
||
225 |
If we fail to acquire the lock, this method is responsible for
|
|
226 |
cleaning up the pending directory if possible. (But it doesn't do
|
|
227 |
that yet.)
|
|
228 |
||
229 |
:returns: The nonce of the lock, if it was successfully acquired.
|
|
230 |
||
5425.6.3
by Martin Pool
PEP8 cleanups |
231 |
:raises LockContention: If the lock is held by someone else. The
|
232 |
exception contains the info of the current holder of the lock.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
233 |
"""
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
234 |
self._trace("lock_write...") |
235 |
start_time = time.time() |
|
2872.5.1
by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701). |
236 |
try: |
237 |
tmpname = self._create_pending_dir() |
|
238 |
except (errors.TransportError, PathError), e: |
|
239 |
self._trace("... failed to create pending dir, %s", e) |
|
240 |
raise LockFailed(self, e) |
|
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
241 |
while True: |
242 |
try: |
|
243 |
self.transport.rename(tmpname, self._held_dir) |
|
244 |
break
|
|
245 |
except (errors.TransportError, PathError, DirectoryNotEmpty, |
|
246 |
FileExists, ResourceBusy), e: |
|
247 |
self._trace("... contention, %s", e) |
|
248 |
other_holder = self.peek() |
|
249 |
self._trace("other holder is %r" % other_holder) |
|
5425.4.25
by Martin Pool
Support auto-stealing dead locks, but turn it off by default. |
250 |
try: |
251 |
self._handle_lock_contention(other_holder) |
|
252 |
except: |
|
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
253 |
self._remove_pending_dir(tmpname) |
5425.4.25
by Martin Pool
Support auto-stealing dead locks, but turn it off by default. |
254 |
raise
|
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
255 |
except Exception, e: |
256 |
self._trace("... lock failed, %s", e) |
|
257 |
self._remove_pending_dir(tmpname) |
|
258 |
raise
|
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
259 |
# We must check we really got the lock, because Launchpad's sftp
|
260 |
# server at one time had a bug were the rename would successfully
|
|
261 |
# move the new directory into the existing directory, which was
|
|
262 |
# incorrect. It's possible some other servers or filesystems will
|
|
263 |
# have a similar bug allowing someone to think they got the lock
|
|
264 |
# when it's already held.
|
|
4634.114.1
by Martin Pool
Better message when lockdir goes missing after rename succeeds |
265 |
#
|
5243.1.2
by Martin
Point launchpad links in comments at production server rather than edge |
266 |
# See <https://bugs.launchpad.net/bzr/+bug/498378> for one case.
|
4634.114.1
by Martin Pool
Better message when lockdir goes missing after rename succeeds |
267 |
#
|
268 |
# Strictly the check is unnecessary and a waste of time for most
|
|
269 |
# people, but probably worth trapping if something is wrong.
|
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
270 |
info = self.peek() |
271 |
self._trace("after locking, info=%r", info) |
|
4634.114.1
by Martin Pool
Better message when lockdir goes missing after rename succeeds |
272 |
if info is None: |
273 |
raise LockFailed(self, "lock was renamed into place, but " |
|
274 |
"now is missing!") |
|
4634.138.2
by Martin Pool
Copy with lock info file being empty |
275 |
if info.get('nonce') != self.nonce: |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
276 |
self._trace("rename succeeded, " |
277 |
"but lock is still held by someone else") |
|
278 |
raise LockContention(self) |
|
279 |
self._lock_held = True |
|
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
280 |
self._trace("... lock succeeded after %dms", |
281 |
(time.time() - start_time) * 1000) |
|
2555.3.6
by Martin Pool
Restore disabled LockDir trace message |
282 |
return self.nonce |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
283 |
|
5425.4.25
by Martin Pool
Support auto-stealing dead locks, but turn it off by default. |
284 |
def _handle_lock_contention(self, other_holder): |
285 |
"""A lock we want to take is held by someone else.
|
|
286 |
||
287 |
This function can: tell the user about it; possibly detect that it's
|
|
288 |
safe or appropriate to steal the lock, or just raise an exception.
|
|
289 |
||
290 |
If this function returns (without raising an exception) the lock will
|
|
291 |
be attempted again.
|
|
292 |
||
293 |
:param other_holder: A LockHeldInfo for the current holder; note that
|
|
294 |
it might be None if the lock can be seen to be held but the info
|
|
295 |
can't be read.
|
|
296 |
"""
|
|
297 |
if (other_holder is not None): |
|
298 |
if other_holder.is_lock_holder_known_dead(): |
|
6059.4.1
by Vincent Ladeuil
Migrate locks.steal_dead to stack-based config. |
299 |
if self.get_config().get('locks.steal_dead'): |
5425.4.25
by Martin Pool
Support auto-stealing dead locks, but turn it off by default. |
300 |
ui.ui_factory.show_user_warning( |
301 |
'locks_steal_dead', |
|
302 |
lock_url=urlutils.join(self.transport.base, self.path), |
|
303 |
other_holder_info=unicode(other_holder)) |
|
304 |
self.force_break(other_holder) |
|
305 |
self._trace("stole lock from dead holder") |
|
306 |
return
|
|
307 |
raise LockContention(self) |
|
308 |
||
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
309 |
def _remove_pending_dir(self, tmpname): |
310 |
"""Remove the pending directory
|
|
311 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
312 |
This is called if we failed to rename into place, so that the pending
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
313 |
dirs don't clutter up the lockdir.
|
314 |
"""
|
|
315 |
self._trace("remove %s", tmpname) |
|
2555.3.18
by Martin Pool
Don't fail hard when removing pending lockdir |
316 |
try: |
317 |
self.transport.delete(tmpname + self.__INFO_NAME) |
|
318 |
self.transport.rmdir(tmpname) |
|
319 |
except PathError, e: |
|
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
320 |
note(gettext("error removing pending lock: %s"), e) |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
321 |
|
2555.3.13
by Martin Pool
LockDir cleanups |
322 |
def _create_pending_dir(self): |
323 |
tmpname = '%s/%s.tmp' % (self.path, rand_chars(10)) |
|
324 |
try: |
|
325 |
self.transport.mkdir(tmpname) |
|
326 |
except NoSuchFile: |
|
327 |
# This may raise a FileExists exception
|
|
328 |
# which is okay, it will be caught later and determined
|
|
329 |
# to be a LockContention.
|
|
330 |
self._trace("lock directory does not exist, creating it") |
|
331 |
self.create(mode=self._dir_modebits) |
|
332 |
# After creating the lock directory, try again
|
|
333 |
self.transport.mkdir(tmpname) |
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
334 |
info = LockHeldInfo.for_this_process(self.extra_holder_info) |
335 |
self.nonce = info.get('nonce') |
|
2555.3.13
by Martin Pool
LockDir cleanups |
336 |
# We use put_file_non_atomic because we just created a new unique
|
337 |
# directory so we don't have to worry about files existing there.
|
|
338 |
# We'll rename the whole directory into place to get atomic
|
|
339 |
# properties
|
|
340 |
self.transport.put_bytes_non_atomic(tmpname + self.__INFO_NAME, |
|
5425.4.6
by Martin Pool
Move preparation of new locks into LockHeldInfo |
341 |
info.to_bytes()) |
2555.3.13
by Martin Pool
LockDir cleanups |
342 |
return tmpname |
343 |
||
4634.85.9
by Andrew Bennetts
Add some experimental decorators: @only_raises(..) and @cleanup_method. |
344 |
@only_raises(LockNotHeld, LockBroken) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
345 |
def unlock(self): |
1553.5.30
by Martin Pool
docstring for LockDir.unlock |
346 |
"""Release a held lock
|
347 |
"""
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
348 |
if self._fake_read_lock: |
349 |
self._fake_read_lock = False |
|
350 |
return
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
351 |
if not self._lock_held: |
4509.3.25
by Martin Pool
Add an option for unlock errors to be non-fatal |
352 |
return lock.cant_unlock_not_held(self) |
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
353 |
if self._locked_via_token: |
354 |
self._locked_via_token = False |
|
355 |
self._lock_held = False |
|
356 |
else: |
|
3331.3.1
by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing |
357 |
old_nonce = self.nonce |
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
358 |
# rename before deleting, because we can't atomically remove the
|
359 |
# whole tree
|
|
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
360 |
start_time = time.time() |
361 |
self._trace("unlocking") |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
362 |
tmpname = '%s/releasing.%s.tmp' % (self.path, rand_chars(20)) |
363 |
# gotta own it to unlock
|
|
364 |
self.confirm() |
|
365 |
self.transport.rename(self._held_dir, tmpname) |
|
366 |
self._lock_held = False |
|
367 |
self.transport.delete(tmpname + self.__INFO_NAME) |
|
2555.3.14
by Martin Pool
Better handling in LockDir of rename that moves one directory within another |
368 |
try: |
369 |
self.transport.rmdir(tmpname) |
|
370 |
except DirectoryNotEmpty, e: |
|
371 |
# There might have been junk left over by a rename that moved
|
|
372 |
# another locker within the 'held' directory. do a slower
|
|
373 |
# deletion where we list the directory and remove everything
|
|
374 |
# within it.
|
|
375 |
#
|
|
376 |
# Maybe this should be broader to allow for ftp servers with
|
|
377 |
# non-specific error messages?
|
|
378 |
self._trace("doing recursive deletion of non-empty directory " |
|
379 |
"%s", tmpname) |
|
380 |
self.transport.delete_tree(tmpname) |
|
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
381 |
self._trace("... unlock succeeded after %dms", |
382 |
(time.time() - start_time) * 1000) |
|
3331.3.2
by Robert Collins
Polish on lock hooks to be easier to use. |
383 |
result = lock.LockResult(self.transport.abspath(self.path), |
4327.1.2
by Vincent Ladeuil
Introduce a new lock_broken hook. |
384 |
old_nonce) |
3331.3.6
by Martin Pool
merge trunk |
385 |
for hook in self.hooks['lock_released']: |
3331.3.1
by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing |
386 |
hook(result) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
387 |
|
1687.1.5
by Robert Collins
Add break_lock utility function to LockDir. |
388 |
def break_lock(self): |
389 |
"""Break a lock not held by this instance of LockDir.
|
|
390 |
||
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
391 |
This is a UI centric function: it uses the ui.ui_factory to
|
1687.1.5
by Robert Collins
Add break_lock utility function to LockDir. |
392 |
prompt for input if a lock is detected and there is any doubt about
|
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
393 |
it possibly being still active. force_break is the non-interactive
|
394 |
version.
|
|
5416.2.3
by Martin Pool
Better test for break-lock; show lock URLs as they're broken |
395 |
|
396 |
:returns: LockResult for the broken lock.
|
|
1687.1.5
by Robert Collins
Add break_lock utility function to LockDir. |
397 |
"""
|
1687.1.6
by Robert Collins
Extend LockableFiles to support break_lock() calls. |
398 |
self._check_not_locked() |
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
399 |
try: |
400 |
holder_info = self.peek() |
|
401 |
except LockCorrupt, e: |
|
402 |
# The lock info is corrupt.
|
|
5425.4.23
by Martin Pool
Resolve conflicts against trunk |
403 |
if ui.ui_factory.get_boolean(u"Break (corrupt %r)" % (self,)): |
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
404 |
self.force_break_corrupt(e.file_data) |
405 |
return
|
|
1687.1.5
by Robert Collins
Add break_lock utility function to LockDir. |
406 |
if holder_info is not None: |
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
407 |
if ui.ui_factory.confirm_action( |
5425.6.2
by Martin Pool
Lock holder human version is now unicode, not str |
408 |
u"Break %(lock_info)s", |
5425.4.30
by Martin Pool
Restore confirmation name that was used to force breaking |
409 |
'bzrlib.lockdir.break', |
5425.6.2
by Martin Pool
Lock holder human version is now unicode, not str |
410 |
dict(lock_info=unicode(holder_info))): |
5416.2.3
by Martin Pool
Better test for break-lock; show lock URLs as they're broken |
411 |
result = self.force_break(holder_info) |
5425.4.13
by Martin Pool
Steal locks of dead local processes, with a user warning |
412 |
ui.ui_factory.show_message( |
5416.2.3
by Martin Pool
Better test for break-lock; show lock URLs as they're broken |
413 |
"Broke lock %s" % result.lock_url) |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
414 |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
415 |
def force_break(self, dead_holder_info): |
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
416 |
"""Release a lock held by another process.
|
417 |
||
418 |
WARNING: This should only be used when the other process is dead; if
|
|
419 |
it still thinks it has the lock there will be two concurrent writers.
|
|
420 |
In general the user's approval should be sought for lock breaks.
|
|
421 |
||
422 |
After the lock is broken it will not be held by any process.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
423 |
It is possible that another process may sneak in and take the
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
424 |
lock before the breaking process acquires it.
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
425 |
|
5425.6.3
by Martin Pool
PEP8 cleanups |
426 |
:param dead_holder_info:
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
427 |
Must be the result of a previous LockDir.peek() call; this is used
|
428 |
to check that it's still held by the same process that the user
|
|
429 |
decided was dead. If this is not the current holder,
|
|
430 |
LockBreakMismatch is raised.
|
|
5425.4.4
by Martin Pool
merge trunk |
431 |
|
5416.2.3
by Martin Pool
Better test for break-lock; show lock URLs as they're broken |
432 |
:returns: LockResult for the broken lock.
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
433 |
"""
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
434 |
if not isinstance(dead_holder_info, LockHeldInfo): |
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
435 |
raise ValueError("dead_holder_info: %r" % dead_holder_info) |
1687.1.6
by Robert Collins
Extend LockableFiles to support break_lock() calls. |
436 |
self._check_not_locked() |
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
437 |
current_info = self.peek() |
438 |
if current_info is None: |
|
1553.5.26
by Martin Pool
Breaking an already-released lock should just succeed |
439 |
# must have been recently released
|
440 |
return
|
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
441 |
if current_info != dead_holder_info: |
442 |
raise LockBreakMismatch(self, current_info, dead_holder_info) |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
443 |
tmpname = '%s/broken.%s.tmp' % (self.path, rand_chars(20)) |
444 |
self.transport.rename(self._held_dir, tmpname) |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
445 |
# check that we actually broke the right lock, not someone else;
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
446 |
# there's a small race window between checking it and doing the
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
447 |
# rename.
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
448 |
broken_info_path = tmpname + self.__INFO_NAME |
449 |
broken_info = self._read_info_file(broken_info_path) |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
450 |
if broken_info != dead_holder_info: |
451 |
raise LockBreakMismatch(self, broken_info, dead_holder_info) |
|
452 |
self.transport.delete(broken_info_path) |
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
453 |
self.transport.rmdir(tmpname) |
4327.1.2
by Vincent Ladeuil
Introduce a new lock_broken hook. |
454 |
result = lock.LockResult(self.transport.abspath(self.path), |
455 |
current_info.get('nonce')) |
|
456 |
for hook in self.hooks['lock_broken']: |
|
457 |
hook(result) |
|
5416.2.3
by Martin Pool
Better test for break-lock; show lock URLs as they're broken |
458 |
return result |
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
459 |
|
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
460 |
def force_break_corrupt(self, corrupt_info_lines): |
461 |
"""Release a lock that has been corrupted.
|
|
5425.6.3
by Martin Pool
PEP8 cleanups |
462 |
|
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
463 |
This is very similar to force_break, it except it doesn't assume that
|
464 |
self.peek() can work.
|
|
5425.6.3
by Martin Pool
PEP8 cleanups |
465 |
|
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
466 |
:param corrupt_info_lines: the lines of the corrupted info file, used
|
467 |
to check that the lock hasn't changed between reading the (corrupt)
|
|
468 |
info file and calling force_break_corrupt.
|
|
469 |
"""
|
|
470 |
# XXX: this copes with unparseable info files, but what about missing
|
|
471 |
# info files? Or missing lock dirs?
|
|
472 |
self._check_not_locked() |
|
473 |
tmpname = '%s/broken.%s.tmp' % (self.path, rand_chars(20)) |
|
474 |
self.transport.rename(self._held_dir, tmpname) |
|
475 |
# check that we actually broke the right lock, not someone else;
|
|
476 |
# there's a small race window between checking it and doing the
|
|
477 |
# rename.
|
|
478 |
broken_info_path = tmpname + self.__INFO_NAME |
|
5599.2.1
by John Arbash Meinel
Fix breaking corrupt lock files on Windows. |
479 |
broken_content = self.transport.get_bytes(broken_info_path) |
480 |
broken_lines = osutils.split_lines(broken_content) |
|
4634.161.1
by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files. |
481 |
if broken_lines != corrupt_info_lines: |
482 |
raise LockBreakMismatch(self, broken_lines, corrupt_info_lines) |
|
483 |
self.transport.delete(broken_info_path) |
|
484 |
self.transport.rmdir(tmpname) |
|
485 |
result = lock.LockResult(self.transport.abspath(self.path)) |
|
486 |
for hook in self.hooks['lock_broken']: |
|
487 |
hook(result) |
|
488 |
||
1687.1.6
by Robert Collins
Extend LockableFiles to support break_lock() calls. |
489 |
def _check_not_locked(self): |
490 |
"""If the lock is held by this instance, raise an error."""
|
|
491 |
if self._lock_held: |
|
492 |
raise AssertionError("can't break own lock: %r" % self) |
|
493 |
||
1553.5.20
by Martin Pool
Start adding LockDir.confirm() method |
494 |
def confirm(self): |
495 |
"""Make sure that the lock is still held by this locker.
|
|
496 |
||
497 |
This should only fail if the lock was broken by user intervention,
|
|
498 |
or if the lock has been affected by a bug.
|
|
499 |
||
500 |
If the lock is not thought to be held, raises LockNotHeld. If
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
501 |
the lock is thought to be held but has been broken, raises
|
1553.5.20
by Martin Pool
Start adding LockDir.confirm() method |
502 |
LockBroken.
|
503 |
"""
|
|
504 |
if not self._lock_held: |
|
505 |
raise LockNotHeld(self) |
|
1553.5.23
by Martin Pool
Start LockDir.confirm method and LockBroken exception |
506 |
info = self.peek() |
507 |
if info is None: |
|
508 |
# no lock there anymore!
|
|
509 |
raise LockBroken(self) |
|
510 |
if info.get('nonce') != self.nonce: |
|
511 |
# there is a lock, but not ours
|
|
512 |
raise LockBroken(self) |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
513 |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
514 |
def _read_info_file(self, path): |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
515 |
"""Read one given info file.
|
516 |
||
517 |
peek() reads the info file of the lock holder, if any.
|
|
518 |
"""
|
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
519 |
return LockHeldInfo.from_info_file_bytes( |
520 |
self.transport.get_bytes(path)) |
|
1553.5.20
by Martin Pool
Start adding LockDir.confirm() method |
521 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
522 |
def peek(self): |
523 |
"""Check if the lock is held by anyone.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
524 |
|
4634.138.2
by Martin Pool
Copy with lock info file being empty |
525 |
If it is held, this returns the lock info structure as a dict
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
526 |
which contains some information about the current lock holder.
|
527 |
Otherwise returns None.
|
|
528 |
"""
|
|
529 |
try: |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
530 |
info = self._read_info_file(self._held_info_path) |
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
531 |
self._trace("peek -> held") |
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
532 |
return info |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
533 |
except NoSuchFile, e: |
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
534 |
self._trace("peek -> not held") |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
535 |
|
1993.1.2
by John Arbash Meinel
Use Stanza.to_string() rather than a RioWriter |
536 |
def _prepare_info(self): |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
537 |
"""Write information about a pending lock to a temporary file.
|
538 |
"""
|
|
539 |
||
2555.3.13
by Martin Pool
LockDir cleanups |
540 |
def attempt_lock(self): |
541 |
"""Take the lock; fail if it's already held.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
542 |
|
2555.3.13
by Martin Pool
LockDir cleanups |
543 |
If you wish to block until the lock can be obtained, call wait_lock()
|
544 |
instead.
|
|
545 |
||
546 |
:return: The lock token.
|
|
547 |
:raises LockContention: if the lock is held by someone else.
|
|
548 |
"""
|
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
549 |
if self._fake_read_lock: |
550 |
raise LockContention(self) |
|
3331.3.1
by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing |
551 |
result = self._attempt_lock() |
3331.3.2
by Robert Collins
Polish on lock hooks to be easier to use. |
552 |
hook_result = lock.LockResult(self.transport.abspath(self.path), |
553 |
self.nonce) |
|
3331.3.6
by Martin Pool
merge trunk |
554 |
for hook in self.hooks['lock_acquired']: |
3331.3.1
by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing |
555 |
hook(hook_result) |
556 |
return result |
|
2555.3.13
by Martin Pool
LockDir cleanups |
557 |
|
5609.30.1
by Martin Pool
Avoid UnboundLocalError reporting url when wait_lock fails |
558 |
def lock_url_for_display(self): |
559 |
"""Give a nicely-printable representation of the URL of this lock."""
|
|
560 |
# As local lock urls are correct we display them.
|
|
561 |
# We avoid displaying remote lock urls.
|
|
562 |
lock_url = self.transport.abspath(self.path) |
|
563 |
if lock_url.startswith('file://'): |
|
564 |
lock_url = lock_url.split('.bzr/')[0] |
|
565 |
else: |
|
566 |
lock_url = '' |
|
567 |
return lock_url |
|
568 |
||
2555.3.13
by Martin Pool
LockDir cleanups |
569 |
def wait_lock(self, timeout=None, poll=None, max_attempts=None): |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
570 |
"""Wait a certain period for a lock.
|
571 |
||
572 |
If the lock can be acquired within the bounded time, it
|
|
573 |
is taken and this returns. Otherwise, LockContention
|
|
574 |
is raised. Either way, this function should return within
|
|
575 |
approximately `timeout` seconds. (It may be a bit more if
|
|
576 |
a transport operation takes a long time to complete.)
|
|
2555.3.5
by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek() |
577 |
|
2555.3.13
by Martin Pool
LockDir cleanups |
578 |
:param timeout: Approximate maximum amount of time to wait for the
|
579 |
lock, in seconds.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
580 |
|
2555.3.13
by Martin Pool
LockDir cleanups |
581 |
:param poll: Delay in seconds between retrying the lock.
|
582 |
||
583 |
:param max_attempts: Maximum number of times to try to lock.
|
|
584 |
||
2555.3.5
by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek() |
585 |
:return: The lock token.
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
586 |
"""
|
1957.1.17
by John Arbash Meinel
Change tests that expect locking to fail to timeout sooner. |
587 |
if timeout is None: |
588 |
timeout = _DEFAULT_TIMEOUT_SECONDS |
|
589 |
if poll is None: |
|
590 |
poll = _DEFAULT_POLL_SECONDS |
|
2555.3.13
by Martin Pool
LockDir cleanups |
591 |
# XXX: the transport interface doesn't let us guard against operations
|
592 |
# there taking a long time, so the total elapsed time or poll interval
|
|
593 |
# may be more than was requested.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
594 |
deadline = time.time() + timeout |
1957.1.13
by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock |
595 |
deadline_str = None |
1957.1.7
by John Arbash Meinel
Add the ability to report if the lock changes from underneath you |
596 |
last_info = None |
2555.3.13
by Martin Pool
LockDir cleanups |
597 |
attempt_count = 0 |
5609.30.1
by Martin Pool
Avoid UnboundLocalError reporting url when wait_lock fails |
598 |
lock_url = self.lock_url_for_display() |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
599 |
while True: |
2555.3.13
by Martin Pool
LockDir cleanups |
600 |
attempt_count += 1 |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
601 |
try: |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
602 |
return self.attempt_lock() |
603 |
except LockContention: |
|
604 |
# possibly report the blockage, then try again
|
|
605 |
pass
|
|
606 |
# TODO: In a few cases, we find out that there's contention by
|
|
607 |
# reading the held info and observing that it's not ours. In
|
|
608 |
# those cases it's a bit redundant to read it again. However,
|
|
609 |
# the normal case (??) is that the rename fails and so we
|
|
610 |
# don't know who holds the lock. For simplicity we peek
|
|
611 |
# always.
|
|
612 |
new_info = self.peek() |
|
613 |
if new_info is not None and new_info != last_info: |
|
614 |
if last_info is None: |
|
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
615 |
start = gettext('Unable to obtain') |
1957.1.9
by John Arbash Meinel
Change default timeouts, and report differently the first failure |
616 |
else: |
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
617 |
start = gettext('Lock owner changed for') |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
618 |
last_info = new_info |
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
619 |
msg = gettext('{0} lock {1} {2}.').format(start, lock_url, |
620 |
new_info) |
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
621 |
if deadline_str is None: |
622 |
deadline_str = time.strftime('%H:%M:%S', |
|
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
623 |
time.localtime(deadline)) |
5284.6.3
by Parth Malwankar
fixed tests. closed review comments by mgz. |
624 |
if timeout > 0: |
6150.3.9
by Jonathan Riddell
don't include new line at start of gettext() |
625 |
msg += '\n' + gettext( |
626 |
'Will continue to try until %s, unless ' |
|
6150.3.11
by Jonathan Riddell
syntax fixes |
627 |
'you press Ctrl-C.') % deadline_str |
6150.3.9
by Jonathan Riddell
don't include new line at start of gettext() |
628 |
msg += '\n' + gettext('See "bzr help break-lock" for more.') |
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
629 |
self._report_function(msg) |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
630 |
if (max_attempts is not None) and (attempt_count >= max_attempts): |
631 |
self._trace("exceeded %d attempts") |
|
632 |
raise LockContention(self) |
|
633 |
if time.time() + poll < deadline: |
|
634 |
self._trace("waiting %ss", poll) |
|
635 |
time.sleep(poll) |
|
636 |
else: |
|
5284.6.4
by Parth Malwankar
local urls are now shows as they are valid. |
637 |
# As timeout is always 0 for remote locks
|
638 |
# this block is applicable only for local
|
|
639 |
# lock contention
|
|
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
640 |
self._trace("timeout after waiting %ss", timeout) |
5284.6.9
by Parth Malwankar
cleaner handling of lock_url display. |
641 |
raise LockContention('(local)', lock_url) |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
642 |
|
2018.5.75
by Andrew Bennetts
Add Repository.{dont_,}leave_lock_in_place. |
643 |
def leave_in_place(self): |
644 |
self._locked_via_token = True |
|
645 |
||
646 |
def dont_leave_in_place(self): |
|
647 |
self._locked_via_token = False |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
648 |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
649 |
def lock_write(self, token=None): |
650 |
"""Wait for and acquire the lock.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
651 |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
652 |
:param token: if this is already locked, then lock_write will fail
|
653 |
unless the token matches the existing lock.
|
|
654 |
:returns: a token if this instance supports tokens, otherwise None.
|
|
655 |
:raises TokenLockingNotSupported: when a token is given but this
|
|
656 |
instance doesn't support using token locks.
|
|
2279.7.7
by Andrew Bennetts
LockDir, Repository and Branch lock token changes from the hpss branch. |
657 |
:raises MismatchedToken: if the specified token doesn't match the token
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
658 |
of the existing lock.
|
2018.5.145
by Andrew Bennetts
Add a brief explanation of what tokens are used for to lock_write docstrings. |
659 |
|
660 |
A token should be passed in if you know that you have locked the object
|
|
661 |
some other way, and need to synchronise this object's state with that
|
|
662 |
fact.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
663 |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
664 |
XXX: docstring duplicated from LockableFiles.lock_write.
|
665 |
"""
|
|
666 |
if token is not None: |
|
667 |
self.validate_token(token) |
|
2018.5.75
by Andrew Bennetts
Add Repository.{dont_,}leave_lock_in_place. |
668 |
self.nonce = token |
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
669 |
self._lock_held = True |
670 |
self._locked_via_token = True |
|
2018.5.78
by Andrew Bennetts
Implement RemoteRepository.lock_write/unlock to expect and send tokens over the |
671 |
return token |
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
672 |
else: |
2555.3.5
by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek() |
673 |
return self.wait_lock() |
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
674 |
|
675 |
def lock_read(self): |
|
1759.2.1
by Jelmer Vernooij
Fix some types (found using aspell). |
676 |
"""Compatibility-mode shared lock.
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
677 |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
678 |
LockDir doesn't support shared read-only locks, so this
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
679 |
just pretends that the lock is taken but really does nothing.
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
680 |
"""
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
681 |
# At the moment Branches are commonly locked for read, but
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
682 |
# we can't rely on that remotely. Once this is cleaned up,
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
683 |
# reenable this warning to prevent it coming back in
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
684 |
# -- mbp 20060303
|
685 |
## warn("LockDir.lock_read falls back to write lock")
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
686 |
if self._lock_held or self._fake_read_lock: |
687 |
raise LockContention(self) |
|
688 |
self._fake_read_lock = True |
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
689 |
|
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
690 |
def validate_token(self, token): |
691 |
if token is not None: |
|
692 |
info = self.peek() |
|
693 |
if info is None: |
|
694 |
# Lock isn't held
|
|
695 |
lock_token = None |
|
696 |
else: |
|
697 |
lock_token = info.get('nonce') |
|
698 |
if token != lock_token: |
|
699 |
raise errors.TokenMismatch(token, lock_token) |
|
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
700 |
else: |
2555.3.16
by Martin Pool
Clean up patch to make divergence from mainline smaller. |
701 |
self._trace("revalidated by token %r", token) |
2279.7.1
by Andrew Bennetts
``LockableFiles.lock_write()`` now accepts a ``token`` keyword argument, so that |
702 |
|
2555.3.3
by Martin Pool
Simple lock tracing in LockDir |
703 |
def _trace(self, format, *args): |
704 |
if 'lock' not in debug.debug_flags: |
|
705 |
return
|
|
706 |
mutter(str(self) + ": " + (format % args)) |
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
707 |
|
5425.4.15
by Martin Pool
Add steal_dead_locks option letting automatic lock-breaking be turned off |
708 |
def get_config(self): |
709 |
"""Get the configuration that governs this lockdir."""
|
|
710 |
# XXX: This really should also use the locationconfig at least, but
|
|
711 |
# that seems a bit hard to hook up at the moment. -- mbp 20110329
|
|
6059.4.1
by Vincent Ladeuil
Migrate locks.steal_dead to stack-based config. |
712 |
# FIXME: The above is still true ;) -- vila 20110811
|
713 |
return config.GlobalStack() |
|
5425.4.15
by Martin Pool
Add steal_dead_locks option letting automatic lock-breaking be turned off |
714 |
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
715 |
|
716 |
class LockHeldInfo(object): |
|
717 |
"""The information recorded about a held lock.
|
|
718 |
||
719 |
This information is recorded into the lock when it's taken, and it can be
|
|
5425.6.3
by Martin Pool
PEP8 cleanups |
720 |
read back by any process with access to the lockdir. It can be used, for
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
721 |
example, to tell the user who holds the lock, or to try to detect whether
|
722 |
the lock holder is still alive.
|
|
723 |
||
724 |
Prior to bzr 2.4 a simple dict was used instead of an object.
|
|
725 |
"""
|
|
726 |
||
727 |
def __init__(self, info_dict): |
|
728 |
self.info_dict = info_dict |
|
729 |
||
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
730 |
def __repr__(self): |
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
731 |
"""Return a debugging representation of this object."""
|
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
732 |
return "%s(%r)" % (self.__class__.__name__, self.info_dict) |
733 |
||
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
734 |
def __unicode__(self): |
735 |
"""Return a user-oriented description of this object."""
|
|
736 |
d = self.to_readable_dict() |
|
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
737 |
return ( gettext( |
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
738 |
u'held by %(user)s on %(hostname)s (process #%(pid)s), ' |
6150.3.1
by Jonathan Riddell
gettext() in launchpad plugin |
739 |
u'acquired %(time_ago)s') % d) |
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
740 |
|
741 |
def to_readable_dict(self): |
|
742 |
"""Turn the holder info into a dict of human-readable attributes.
|
|
743 |
||
744 |
For example, the start time is presented relative to the current time,
|
|
745 |
rather than as seconds since the epoch.
|
|
5425.6.3
by Martin Pool
PEP8 cleanups |
746 |
|
747 |
Returns a list of [user, hostname, pid, time_ago] all as readable
|
|
5425.4.18
by Martin Pool
Cleaner and consistent user-orientend representation of LockHeldInfo |
748 |
strings.
|
749 |
"""
|
|
750 |
start_time = self.info_dict.get('start_time') |
|
751 |
if start_time is None: |
|
752 |
time_ago = '(unknown)' |
|
753 |
else: |
|
754 |
time_ago = format_delta( |
|
755 |
time.time() - int(self.info_dict['start_time'])) |
|
756 |
user = self.info_dict.get('user', '<unknown>') |
|
757 |
hostname = self.info_dict.get('hostname', '<unknown>') |
|
758 |
pid = self.info_dict.get('pid', '<unknown>') |
|
759 |
return dict( |
|
760 |
user=user, |
|
761 |
hostname=hostname, |
|
762 |
pid=pid, |
|
763 |
time_ago=time_ago) |
|
764 |
||
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
765 |
def get(self, field_name): |
766 |
"""Return the contents of a field from the lock info, or None."""
|
|
767 |
return self.info_dict.get(field_name) |
|
768 |
||
769 |
@classmethod
|
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
770 |
def for_this_process(cls, extra_holder_info): |
5425.4.6
by Martin Pool
Move preparation of new locks into LockHeldInfo |
771 |
"""Return a new LockHeldInfo for a lock taken by this process.
|
772 |
"""
|
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
773 |
info = dict( |
5425.4.6
by Martin Pool
Move preparation of new locks into LockHeldInfo |
774 |
hostname=get_host_name(), |
775 |
pid=str(os.getpid()), |
|
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
776 |
nonce=rand_chars(20), |
5425.4.6
by Martin Pool
Move preparation of new locks into LockHeldInfo |
777 |
start_time=str(int(time.time())), |
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
778 |
user=get_username_for_lock_info(), |
5425.4.10
by Martin Pool
Allow storing extra info into lockdir info files to aid testing |
779 |
)
|
780 |
if extra_holder_info is not None: |
|
781 |
info.update(extra_holder_info) |
|
782 |
return cls(info) |
|
5425.4.6
by Martin Pool
Move preparation of new locks into LockHeldInfo |
783 |
|
784 |
def to_bytes(self): |
|
785 |
s = rio.Stanza(**self.info_dict) |
|
786 |
return s.to_string() |
|
787 |
||
788 |
@classmethod
|
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
789 |
def from_info_file_bytes(cls, info_file_bytes): |
790 |
"""Construct from the contents of the held file."""
|
|
791 |
lines = osutils.split_lines(info_file_bytes) |
|
792 |
try: |
|
793 |
stanza = rio.read_stanza(lines) |
|
794 |
except ValueError, e: |
|
795 |
mutter('Corrupt lock info file: %r', lines) |
|
796 |
raise LockCorrupt("could not parse lock info file: " + str(e), |
|
797 |
lines) |
|
798 |
if stanza is None: |
|
799 |
# see bug 185013; we fairly often end up with the info file being
|
|
800 |
# empty after an interruption; we could log a message here but
|
|
801 |
# there may not be much we can say
|
|
802 |
return cls({}) |
|
803 |
else: |
|
804 |
return cls(stanza.as_dict()) |
|
805 |
||
806 |
def __cmp__(self, other): |
|
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
807 |
"""Value comparison of lock holders."""
|
5425.4.3
by Martin Pool
Represent lock held info as an object, not just a dict |
808 |
return ( |
809 |
cmp(type(self), type(other)) |
|
810 |
or cmp(self.info_dict, other.info_dict)) |
|
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
811 |
|
812 |
def is_locked_by_this_process(self): |
|
5425.6.3
by Martin Pool
PEP8 cleanups |
813 |
"""True if this process seems to be the current lock holder."""
|
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
814 |
return ( |
815 |
self.get('hostname') == get_host_name() |
|
816 |
and self.get('pid') == str(os.getpid()) |
|
817 |
and self.get('user') == get_username_for_lock_info()) |
|
818 |
||
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
819 |
def is_lock_holder_known_dead(self): |
820 |
"""True if the lock holder process is known to be dead.
|
|
821 |
||
822 |
False if it's either known to be still alive, or if we just can't tell.
|
|
823 |
||
824 |
We can be fairly sure the lock holder is dead if it declared the same
|
|
825 |
hostname and there is no process with the given pid alive. If people
|
|
826 |
have multiple machines with the same hostname this may cause trouble.
|
|
827 |
||
828 |
This doesn't check whether the lock holder is in fact the same process
|
|
829 |
calling this method. (In that case it will return true.)
|
|
830 |
"""
|
|
831 |
if self.get('hostname') != get_host_name(): |
|
832 |
return False |
|
5425.4.9
by Martin Pool
Defensively handle 'localhost' in detecting dead locks |
833 |
if self.get('hostname') == 'localhost': |
834 |
# Too ambiguous.
|
|
835 |
return False |
|
5425.6.1
by Martin Pool
Only detect as stale locks from the same user |
836 |
if self.get('user') != get_username_for_lock_info(): |
837 |
# Could well be another local process by a different user, but
|
|
838 |
# just to be safe we won't conclude about this either.
|
|
839 |
return False |
|
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
840 |
pid_str = self.info_dict.get('pid', None) |
841 |
if not pid_str: |
|
842 |
mutter("no pid recorded in %r" % (self, )) |
|
843 |
return False |
|
844 |
try: |
|
845 |
pid = int(pid_str) |
|
846 |
except ValueError: |
|
5425.6.3
by Martin Pool
PEP8 cleanups |
847 |
mutter("can't parse pid %r from %r" |
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
848 |
% (pid_str, self)) |
849 |
return False |
|
5425.5.5
by Martin
Quick implementation of dead process detection on win32 |
850 |
return osutils.is_local_pid_dead(pid) |
5425.4.8
by Martin Pool
Basic detection of known dead lock holders |
851 |
|
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
852 |
|
853 |
def get_username_for_lock_info(): |
|
854 |
"""Get a username suitable for putting into a lock.
|
|
855 |
||
856 |
It's ok if what's written here is not a proper email address as long
|
|
857 |
as it gives some clue who the user is.
|
|
858 |
"""
|
|
859 |
try: |
|
5425.4.15
by Martin Pool
Add steal_dead_locks option letting automatic lock-breaking be turned off |
860 |
return config.GlobalConfig().username() |
5425.4.7
by Martin Pool
Add and test is_locked_by_this_process |
861 |
except errors.NoWhoami: |
862 |
return osutils.getuser_unicode() |