~bzr-pqm/bzr/bzr.dev

5557.1.7 by John Arbash Meinel
Merge in the bzr.dev 5582
1
# Copyright (C) 2005-2011 Canonical Ltd
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
16
17
"""Tests for finding and reading the bzr config file[s]."""
18
# import system imports here
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
19
from cStringIO import StringIO
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
20
import os
21
import sys
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
22
import threading
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
23
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
24
25
from testtools import matchers
26
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
27
#import bzrlib specific imports here
1878.1.3 by John Arbash Meinel
some test cleanups
28
from bzrlib import (
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
29
    branch,
30
    bzrdir,
1878.1.3 by John Arbash Meinel
some test cleanups
31
    config,
4603.1.10 by Aaron Bentley
Provide change editor via config.
32
    diff,
1878.1.3 by John Arbash Meinel
some test cleanups
33
    errors,
34
    osutils,
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
35
    mail_client,
2900.2.14 by Vincent Ladeuil
More tests.
36
    ui,
1878.1.3 by John Arbash Meinel
some test cleanups
37
    urlutils,
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
38
    remote,
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
39
    tests,
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
40
    trace,
1878.1.3 by John Arbash Meinel
some test cleanups
41
    )
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
42
from bzrlib.symbol_versioning import (
43
    deprecated_in,
44
    )
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
45
from bzrlib.transport import remote as transport_remote
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
46
from bzrlib.tests import (
47
    features,
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
48
    scenarios,
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
49
    test_server,
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
50
    )
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
51
from bzrlib.util.configobj import configobj
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
52
53
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
54
def lockable_config_scenarios():
55
    return [
56
        ('global',
57
         {'config_class': config.GlobalConfig,
58
          'config_args': [],
59
          'config_section': 'DEFAULT'}),
60
        ('locations',
61
         {'config_class': config.LocationConfig,
62
          'config_args': ['.'],
63
          'config_section': '.'}),]
64
65
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
66
load_tests = scenarios.load_tests_apply_scenarios
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
67
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
68
# Register helpers to build stores
69
config.test_store_builder_registry.register(
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
70
    'configobj', lambda test: config.IniFileStore(test.get_transport(),
71
                                                  'configobj.conf'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
72
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
73
    'bazaar', lambda test: config.GlobalStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
74
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
75
    'location', lambda test: config.LocationStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
76
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
77
78
def build_backing_branch(test, relpath,
79
                         transport_class=None, server_class=None):
80
    """Test helper to create a backing branch only once.
81
82
    Some tests needs multiple stores/stacks to check concurrent update
83
    behaviours. As such, they need to build different branch *objects* even if
84
    they share the branch on disk.
85
86
    :param relpath: The relative path to the branch. (Note that the helper
87
        should always specify the same relpath).
88
89
    :param transport_class: The Transport class the test needs to use.
90
91
    :param server_class: The server associated with the ``transport_class``
92
        above.
93
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
94
    Either both or neither of ``transport_class`` and ``server_class`` should
95
    be specified.
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
96
    """
97
    if transport_class is not None and server_class is not None:
98
        test.transport_class = transport_class
99
        test.transport_server = server_class
100
    elif not (transport_class is None and server_class is None):
101
        raise AssertionError('Specify both ``transport_class`` and '
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
102
                             '``server_class`` or neither of them')
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
103
    if getattr(test, 'backing_branch', None) is None:
104
        # First call, let's build the branch on disk
105
        test.backing_branch = test.make_branch(relpath)
106
107
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
108
def build_branch_store(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
109
    build_backing_branch(test, 'branch')
110
    b = branch.Branch.open('branch')
111
    return config.BranchStore(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
112
config.test_store_builder_registry.register('branch', build_branch_store)
113
114
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
115
def build_control_store(test):
116
    build_backing_branch(test, 'branch')
117
    b = bzrdir.BzrDir.open('branch')
118
    return config.ControlStore(b)
119
config.test_store_builder_registry.register('control', build_control_store)
120
121
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
122
def build_remote_branch_store(test):
123
    # There is only one permutation (but we won't be able to handle more with
124
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
125
    (transport_class,
126
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
127
    build_backing_branch(test, 'branch', transport_class, server_class)
128
    b = branch.Branch.open(test.get_url('branch'))
129
    return config.BranchStore(b)
130
config.test_store_builder_registry.register('remote_branch',
131
                                            build_remote_branch_store)
132
133
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
134
config.test_stack_builder_registry.register(
135
    'bazaar', lambda test: config.GlobalStack())
136
config.test_stack_builder_registry.register(
137
    'location', lambda test: config.LocationStack('.'))
138
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
139
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
140
def build_branch_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
141
    build_backing_branch(test, 'branch')
142
    b = branch.Branch.open('branch')
143
    return config.BranchStack(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
144
config.test_stack_builder_registry.register('branch', build_branch_stack)
145
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
146
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
147
def build_remote_branch_stack(test):
148
    # There is only one permutation (but we won't be able to handle more with
149
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
150
    (transport_class,
151
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
152
    build_backing_branch(test, 'branch', transport_class, server_class)
153
    b = branch.Branch.open(test.get_url('branch'))
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
154
    return config.RemoteBranchStack(b)
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
155
config.test_stack_builder_registry.register('remote_branch',
156
                                            build_remote_branch_stack)
157
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
158
def build_remote_control_stack(test):
159
    # There is only one permutation (but we won't be able to handle more with
160
    # this design anyway)
161
    (transport_class,
162
     server_class) = transport_remote.get_test_permutations()[0]
163
    # We need only a bzrdir for this, not a full branch, but it's not worth
164
    # creating a dedicated helper to create only the bzrdir
165
    build_backing_branch(test, 'branch', transport_class, server_class)
166
    b = branch.Branch.open(test.get_url('branch'))
167
    return config.RemoteControlStack(b.bzrdir)
168
config.test_stack_builder_registry.register('remote_control',
169
                                            build_remote_control_stack)
170
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
171
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
172
sample_long_alias="log -r-15..-1 --line"
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
173
sample_config_text = u"""
174
[DEFAULT]
175
email=Erik B\u00e5gfors <erik@bagfors.nu>
176
editor=vim
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
177
change_editor=vimdiff -of @new_path @old_path
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
178
gpg_signing_command=gnome-gpg
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
179
gpg_signing_key=DD4D5088
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
180
log_format=short
5971.1.58 by Jonathan Riddell
more tests for new config options
181
validate_signatures_in_log=true
182
acceptable_keys=amy
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
183
user_global_option=something
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
184
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
5321.2.3 by Vincent Ladeuil
Prefix mergetools option names with 'bzr.'.
185
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
186
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
187
bzr.default_mergetool=sometool
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
188
[ALIASES]
189
h=help
190
ll=""" + sample_long_alias + "\n"
191
192
193
sample_always_signatures = """
194
[DEFAULT]
195
check_signatures=ignore
196
create_signatures=always
197
"""
198
199
sample_ignore_signatures = """
200
[DEFAULT]
201
check_signatures=require
202
create_signatures=never
203
"""
204
205
sample_maybe_signatures = """
206
[DEFAULT]
207
check_signatures=ignore
208
create_signatures=when-required
209
"""
210
211
sample_branches_text = """
212
[http://www.example.com]
213
# Top level policy
214
email=Robert Collins <robertc@example.org>
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
215
normal_option = normal
216
appendpath_option = append
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
217
appendpath_option:policy = appendpath
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
218
norecurse_option = norecurse
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
219
norecurse_option:policy = norecurse
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
220
[http://www.example.com/ignoreparent]
221
# different project: ignore parent dir config
222
ignore_parents=true
223
[http://www.example.com/norecurse]
224
# configuration items that only apply to this dir
225
recurse=false
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
226
normal_option = norecurse
227
[http://www.example.com/dir]
228
appendpath_option = normal
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
229
[/b/]
230
check_signatures=require
231
# test trailing / matching with no children
232
[/a/]
233
check_signatures=check-available
234
gpg_signing_command=false
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
235
gpg_signing_key=default
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
236
user_local_option=local
237
# test trailing / matching
238
[/a/*]
239
#subdirs will match but not the parent
240
[/a/c]
241
check_signatures=ignore
242
post_commit=bzrlib.tests.test_config.post_commit
243
#testing explicit beats globs
244
"""
1553.6.3 by Erik BÃ¥gfors
tests for AliasesConfig
245
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
246
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
247
def create_configs(test):
248
    """Create configuration files for a given test.
249
250
    This requires creating a tree (and populate the ``test.tree`` attribute)
251
    and its associated branch and will populate the following attributes:
252
253
    - branch_config: A BranchConfig for the associated branch.
254
255
    - locations_config : A LocationConfig for the associated branch
256
257
    - bazaar_config: A GlobalConfig.
258
259
    The tree and branch are created in a 'tree' subdirectory so the tests can
260
    still use the test directory to stay outside of the branch.
261
    """
262
    tree = test.make_branch_and_tree('tree')
263
    test.tree = tree
264
    test.branch_config = config.BranchConfig(tree.branch)
265
    test.locations_config = config.LocationConfig(tree.basedir)
266
    test.bazaar_config = config.GlobalConfig()
267
5533.2.4 by Vincent Ladeuil
Fix whitespace issue.
268
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
269
def create_configs_with_file_option(test):
270
    """Create configuration files with a ``file`` option set in each.
271
272
    This builds on ``create_configs`` and add one ``file`` option in each
273
    configuration with a value which allows identifying the configuration file.
274
    """
275
    create_configs(test)
276
    test.bazaar_config.set_user_option('file', 'bazaar')
277
    test.locations_config.set_user_option('file', 'locations')
278
    test.branch_config.set_user_option('file', 'branch')
279
280
281
class TestOptionsMixin:
282
283
    def assertOptions(self, expected, conf):
284
        # We don't care about the parser (as it will make tests hard to write
285
        # and error-prone anyway)
286
        self.assertThat([opt[:4] for opt in conf._get_options()],
287
                        matchers.Equals(expected))
288
289
1474 by Robert Collins
Merge from Aaron Bentley.
290
class InstrumentedConfigObj(object):
291
    """A config obj look-enough-alike to record calls made to it."""
292
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
293
    def __contains__(self, thing):
294
        self._calls.append(('__contains__', thing))
295
        return False
296
297
    def __getitem__(self, key):
298
        self._calls.append(('__getitem__', key))
299
        return self
300
1551.2.20 by Aaron Bentley
Treated config files as utf-8
301
    def __init__(self, input, encoding=None):
302
        self._calls = [('__init__', input, encoding)]
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
303
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
304
    def __setitem__(self, key, value):
305
        self._calls.append(('__setitem__', key, value))
306
2120.6.4 by James Henstridge
add support for specifying policy when storing options
307
    def __delitem__(self, key):
308
        self._calls.append(('__delitem__', key))
309
310
    def keys(self):
311
        self._calls.append(('keys',))
312
        return []
313
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
314
    def reload(self):
315
        self._calls.append(('reload',))
316
1551.2.49 by abentley
Made ConfigObj output binary-identical files on win32 and *nix
317
    def write(self, arg):
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
318
        self._calls.append(('write',))
319
2120.6.4 by James Henstridge
add support for specifying policy when storing options
320
    def as_bool(self, value):
321
        self._calls.append(('as_bool', value))
322
        return False
323
324
    def get_value(self, section, name):
325
        self._calls.append(('get_value', section, name))
326
        return None
327
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
328
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
329
class FakeBranch(object):
330
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
331
    def __init__(self, base=None, user_id=None):
332
        if base is None:
333
            self.base = "http://example.com/branches/demo"
334
        else:
335
            self.base = base
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
336
        self._transport = self.control_files = \
337
            FakeControlFilesAndTransport(user_id=user_id)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
338
4226.1.7 by Robert Collins
Alter test_config.FakeBranch in accordance with the Branch change to have a _get_config.
339
    def _get_config(self):
340
        return config.TransportConfig(self._transport, 'branch.conf')
341
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
342
    def lock_write(self):
343
        pass
344
345
    def unlock(self):
346
        pass
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
347
348
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
349
class FakeControlFilesAndTransport(object):
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
350
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
351
    def __init__(self, user_id=None):
352
        self.files = {}
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
353
        if user_id:
354
            self.files['email'] = user_id
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
355
        self._transport = self
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
356
1185.65.29 by Robert Collins
Implement final review suggestions.
357
    def get_utf8(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
358
        # from LockableFiles
359
        raise AssertionError("get_utf8 should no longer be used")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
360
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
361
    def get(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
362
        # from Transport
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
363
        try:
364
            return StringIO(self.files[filename])
365
        except KeyError:
366
            raise errors.NoSuchFile(filename)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
367
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
368
    def get_bytes(self, filename):
369
        # from Transport
370
        try:
371
            return self.files[filename]
372
        except KeyError:
373
            raise errors.NoSuchFile(filename)
374
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
375
    def put(self, filename, fileobj):
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
376
        self.files[filename] = fileobj.read()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
377
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
378
    def put_file(self, filename, fileobj):
379
        return self.put(filename, fileobj)
380
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
381
382
class InstrumentedConfig(config.Config):
383
    """An instrumented config that supplies stubs for template methods."""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
384
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
385
    def __init__(self):
386
        super(InstrumentedConfig, self).__init__()
387
        self._calls = []
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
388
        self._signatures = config.CHECK_NEVER
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
389
390
    def _get_user_id(self):
391
        self._calls.append('_get_user_id')
392
        return "Robert Collins <robert.collins@example.org>"
393
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
394
    def _get_signature_checking(self):
395
        self._calls.append('_get_signature_checking')
396
        return self._signatures
397
4603.1.10 by Aaron Bentley
Provide change editor via config.
398
    def _get_change_editor(self):
399
        self._calls.append('_get_change_editor')
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
400
        return 'vimdiff -fo @new_path @old_path'
4603.1.10 by Aaron Bentley
Provide change editor via config.
401
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
402
1556.2.2 by Aaron Bentley
Fixed get_bool
403
bool_config = """[DEFAULT]
404
active = true
405
inactive = false
406
[UPPERCASE]
407
active = True
408
nonactive = False
409
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
410
411
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
412
class TestConfigObj(tests.TestCase):
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
413
1556.2.2 by Aaron Bentley
Fixed get_bool
414
    def test_get_bool(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
415
        co = config.ConfigObj(StringIO(bool_config))
1556.2.2 by Aaron Bentley
Fixed get_bool
416
        self.assertIs(co.get_bool('DEFAULT', 'active'), True)
417
        self.assertIs(co.get_bool('DEFAULT', 'inactive'), False)
418
        self.assertIs(co.get_bool('UPPERCASE', 'active'), True)
419
        self.assertIs(co.get_bool('UPPERCASE', 'nonactive'), False)
420
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
421
    def test_hash_sign_in_value(self):
422
        """
423
        Before 4.5.0, ConfigObj did not quote # signs in values, so they'd be
424
        treated as comments when read in again. (#86838)
425
        """
426
        co = config.ConfigObj()
427
        co['test'] = 'foo#bar'
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
428
        outfile = StringIO()
429
        co.write(outfile=outfile)
430
        lines = outfile.getvalue().splitlines()
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
431
        self.assertEqual(lines, ['test = "foo#bar"'])
432
        co2 = config.ConfigObj(lines)
433
        self.assertEqual(co2['test'], 'foo#bar')
434
5050.62.10 by Alexander Belchenko
test to illustrate the problem
435
    def test_triple_quotes(self):
436
        # Bug #710410: if the value string has triple quotes
437
        # then ConfigObj versions up to 4.7.2 will quote them wrong
5050.62.12 by Alexander Belchenko
added NEWS entry
438
        # and won't able to read them back
5050.62.10 by Alexander Belchenko
test to illustrate the problem
439
        triple_quotes_value = '''spam
440
""" that's my spam """
441
eggs'''
442
        co = config.ConfigObj()
443
        co['test'] = triple_quotes_value
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
444
        # While writing this test another bug in ConfigObj has been found:
5050.62.10 by Alexander Belchenko
test to illustrate the problem
445
        # method co.write() without arguments produces list of lines
446
        # one option per line, and multiline values are not split
447
        # across multiple lines,
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
448
        # and that breaks the parsing these lines back by ConfigObj.
449
        # This issue only affects test, but it's better to avoid
450
        # `co.write()` construct at all.
451
        # [bialix 20110222] bug report sent to ConfigObj's author
5050.62.10 by Alexander Belchenko
test to illustrate the problem
452
        outfile = StringIO()
453
        co.write(outfile=outfile)
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
454
        output = outfile.getvalue()
5050.62.10 by Alexander Belchenko
test to illustrate the problem
455
        # now we're trying to read it back
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
456
        co2 = config.ConfigObj(StringIO(output))
5050.62.10 by Alexander Belchenko
test to illustrate the problem
457
        self.assertEquals(triple_quotes_value, co2['test'])
458
1556.2.2 by Aaron Bentley
Fixed get_bool
459
2900.1.1 by Vincent Ladeuil
460
erroneous_config = """[section] # line 1
461
good=good # line 2
462
[section] # line 3
463
whocares=notme # line 4
464
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
465
466
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
467
class TestConfigObjErrors(tests.TestCase):
2900.1.1 by Vincent Ladeuil
468
469
    def test_duplicate_section_name_error_line(self):
470
        try:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
471
            co = configobj.ConfigObj(StringIO(erroneous_config),
472
                                     raise_errors=True)
2900.1.1 by Vincent Ladeuil
473
        except config.configobj.DuplicateError, e:
474
            self.assertEqual(3, e.line_number)
475
        else:
476
            self.fail('Error in config file not detected')
477
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
478
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
479
class TestConfig(tests.TestCase):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
480
481
    def test_constructs(self):
482
        config.Config()
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
483
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
484
    def test_no_default_editor(self):
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
485
        self.assertRaises(
486
            NotImplementedError,
487
            self.applyDeprecated, deprecated_in((2, 4, 0)),
488
            config.Config().get_editor)
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
489
490
    def test_user_email(self):
491
        my_config = InstrumentedConfig()
492
        self.assertEqual('robert.collins@example.org', my_config.user_email())
493
        self.assertEqual(['_get_user_id'], my_config._calls)
494
495
    def test_username(self):
496
        my_config = InstrumentedConfig()
497
        self.assertEqual('Robert Collins <robert.collins@example.org>',
498
                         my_config.username())
499
        self.assertEqual(['_get_user_id'], my_config._calls)
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
500
501
    def test_signatures_default(self):
502
        my_config = config.Config()
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
503
        self.assertFalse(my_config.signature_needed())
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
504
        self.assertEqual(config.CHECK_IF_POSSIBLE,
505
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
506
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
507
                         my_config.signing_policy())
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
508
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
509
    def test_signatures_template_method(self):
510
        my_config = InstrumentedConfig()
511
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
512
        self.assertEqual(['_get_signature_checking'], my_config._calls)
513
514
    def test_signatures_template_method_none(self):
515
        my_config = InstrumentedConfig()
516
        my_config._signatures = None
517
        self.assertEqual(config.CHECK_IF_POSSIBLE,
518
                         my_config.signature_checking())
519
        self.assertEqual(['_get_signature_checking'], my_config._calls)
520
1442.1.56 by Robert Collins
gpg_signing_command configuration item
521
    def test_gpg_signing_command_default(self):
522
        my_config = config.Config()
523
        self.assertEqual('gpg', my_config.gpg_signing_command())
524
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
525
    def test_get_user_option_default(self):
526
        my_config = config.Config()
527
        self.assertEqual(None, my_config.get_user_option('no_option'))
528
1472 by Robert Collins
post commit hook, first pass implementation
529
    def test_post_commit_default(self):
530
        my_config = config.Config()
531
        self.assertEqual(None, my_config.post_commit())
532
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
533
    def test_log_format_default(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
534
        my_config = config.Config()
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
535
        self.assertEqual('long', my_config.log_format())
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
536
5971.1.57 by Jonathan Riddell
tests for new config options
537
    def test_acceptable_keys_default(self):
538
        my_config = config.Config()
539
        self.assertEqual(None, my_config.acceptable_keys())
540
541
    def test_validate_signatures_in_log_default(self):
542
        my_config = config.Config()
543
        self.assertEqual(False, my_config.validate_signatures_in_log())
544
4603.1.10 by Aaron Bentley
Provide change editor via config.
545
    def test_get_change_editor(self):
546
        my_config = InstrumentedConfig()
547
        change_editor = my_config.get_change_editor('old_tree', 'new_tree')
548
        self.assertEqual(['_get_change_editor'], my_config._calls)
549
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
550
        self.assertEqual(['vimdiff', '-fo', '@new_path', '@old_path'],
4603.1.10 by Aaron Bentley
Provide change editor via config.
551
                         change_editor.command_template)
552
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
553
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
554
class TestConfigPath(tests.TestCase):
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
555
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
556
    def setUp(self):
557
        super(TestConfigPath, self).setUp()
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
558
        self.overrideEnv('HOME', '/home/bogus')
559
        self.overrideEnv('XDG_CACHE_DIR', '')
2309.2.6 by Alexander Belchenko
bzr now use Win32 API to determine Application Data location, and don't rely solely on $APPDATA
560
        if sys.platform == 'win32':
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
561
            self.overrideEnv(
562
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
563
            self.bzr_home = \
564
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
5519.4.3 by Neil Martinsen-Burrell
be permissive about using $XDG_CONFIG_HOME/bazaar, but dont complain
565
        else:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
566
            self.bzr_home = '/home/bogus/.bazaar'
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
567
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
568
    def test_config_dir(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
569
        self.assertEqual(config.config_dir(), self.bzr_home)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
570
571
    def test_config_filename(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
572
        self.assertEqual(config.config_filename(),
573
                         self.bzr_home + '/bazaar.conf')
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
574
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
575
    def test_locations_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
576
        self.assertEqual(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
577
                         self.bzr_home + '/locations.conf')
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
578
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
579
    def test_authentication_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
580
        self.assertEqual(config.authentication_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
581
                         self.bzr_home + '/authentication.conf')
582
4584.3.23 by Martin Pool
Correction to xdg_cache_dir and add a simple test
583
    def test_xdg_cache_dir(self):
584
        self.assertEqual(config.xdg_cache_dir(),
585
            '/home/bogus/.cache')
586
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
587
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
588
class TestXDGConfigDir(tests.TestCaseInTempDir):
589
    # must be in temp dir because config tests for the existence of the bazaar
590
    # subdirectory of $XDG_CONFIG_HOME
591
5519.4.9 by Neil Martinsen-Burrell
working tests
592
    def setUp(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
593
        if sys.platform in ('darwin', 'win32'):
594
            raise tests.TestNotApplicable(
595
                'XDG config dir not used on this platform')
5519.4.9 by Neil Martinsen-Burrell
working tests
596
        super(TestXDGConfigDir, self).setUp()
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
597
        self.overrideEnv('HOME', self.test_home_dir)
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
598
        # BZR_HOME overrides everything we want to test so unset it.
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
599
        self.overrideEnv('BZR_HOME', None)
5519.4.9 by Neil Martinsen-Burrell
working tests
600
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
601
    def test_xdg_config_dir_exists(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
602
        """When ~/.config/bazaar exists, use it as the config dir."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
603
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
604
        os.makedirs(newdir)
605
        self.assertEqual(config.config_dir(), newdir)
606
607
    def test_xdg_config_home(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
608
        """When XDG_CONFIG_HOME is set, use it."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
609
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
610
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
611
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
612
        os.makedirs(newdir)
613
        self.assertEqual(config.config_dir(), newdir)
614
615
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
616
class TestIniConfig(tests.TestCaseInTempDir):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
617
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
618
    def make_config_parser(self, s):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
619
        conf = config.IniBasedConfig.from_string(s)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
620
        return conf, conf._get_parser()
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
621
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
622
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
623
class TestIniConfigBuilding(TestIniConfig):
624
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
625
    def test_contructs(self):
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
626
        my_config = config.IniBasedConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
627
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
628
    def test_from_fp(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
629
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
630
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
631
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
632
    def test_cached(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
633
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
634
        parser = my_config._get_parser()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
635
        self.assertTrue(my_config._get_parser() is parser)
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
636
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
637
    def _dummy_chown(self, path, uid, gid):
638
        self.path, self.uid, self.gid = path, uid, gid
639
640
    def test_ini_config_ownership(self):
5345.5.8 by Vincent Ladeuil
More doc and ensure that the config is locked when _write_config_file is called.
641
        """Ensure that chown is happening during _write_config_file"""
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
642
        self.requireFeature(features.chown_feature)
643
        self.overrideAttr(os, 'chown', self._dummy_chown)
644
        self.path = self.uid = self.gid = None
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
645
        conf = config.IniBasedConfig(file_name='./foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
646
        conf._write_config_file()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
647
        self.assertEquals(self.path, './foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
648
        self.assertTrue(isinstance(self.uid, int))
649
        self.assertTrue(isinstance(self.gid, int))
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
650
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
651
    def test_get_filename_parameter_is_deprecated_(self):
652
        conf = self.callDeprecated([
653
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
654
            ' Use file_name instead.'],
655
            config.IniBasedConfig, lambda: 'ini.conf')
5345.3.1 by Vincent Ladeuil
Check that _get_filename() is called and produces the desired side effect.
656
        self.assertEqual('ini.conf', conf.file_name)
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
657
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
658
    def test_get_parser_file_parameter_is_deprecated_(self):
659
        config_file = StringIO(sample_config_text.encode('utf-8'))
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
660
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
661
        conf = self.callDeprecated([
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
662
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
663
            ' Use IniBasedConfig(_content=xxx) instead.'],
664
            conf._get_parser, file=config_file)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
665
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
666
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
667
class TestIniConfigSaving(tests.TestCaseInTempDir):
668
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
669
    def test_cant_save_without_a_file_name(self):
670
        conf = config.IniBasedConfig()
671
        self.assertRaises(AssertionError, conf._write_config_file)
672
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
673
    def test_saved_with_content(self):
674
        content = 'foo = bar\n'
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
675
        conf = config.IniBasedConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
676
            content, file_name='./test.conf', save=True)
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
677
        self.assertFileEqual(content, 'test.conf')
678
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
679
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
680
class TestIniConfigOptionExpansionDefaultValue(tests.TestCaseInTempDir):
681
    """What is the default value of expand for config options.
682
683
    This is an opt-in beta feature used to evaluate whether or not option
684
    references can appear in dangerous place raising exceptions, disapearing
685
    (and as such corrupting data) or if it's safe to activate the option by
686
    default.
687
688
    Note that these tests relies on config._expand_default_value being already
689
    overwritten in the parent class setUp.
690
    """
691
692
    def setUp(self):
693
        super(TestIniConfigOptionExpansionDefaultValue, self).setUp()
694
        self.config = None
695
        self.warnings = []
696
        def warning(*args):
697
            self.warnings.append(args[0] % args[1:])
698
        self.overrideAttr(trace, 'warning', warning)
699
700
    def get_config(self, expand):
701
        c = config.GlobalConfig.from_string('bzr.config.expand=%s' % (expand,),
702
                                            save=True)
703
        return c
704
705
    def assertExpandIs(self, expected):
706
        actual = config._get_expand_default_value()
707
        #self.config.get_user_option_as_bool('bzr.config.expand')
708
        self.assertEquals(expected, actual)
709
710
    def test_default_is_None(self):
711
        self.assertEquals(None, config._expand_default_value)
712
713
    def test_default_is_False_even_if_None(self):
714
        self.config = self.get_config(None)
715
        self.assertExpandIs(False)
716
717
    def test_default_is_False_even_if_invalid(self):
718
        self.config = self.get_config('<your choice>')
719
        self.assertExpandIs(False)
720
        # ...
721
        # Huh ? My choice is False ? Thanks, always happy to hear that :D
722
        # Wait, you've been warned !
723
        self.assertLength(1, self.warnings)
724
        self.assertEquals(
725
            'Value "<your choice>" is not a boolean for "bzr.config.expand"',
726
            self.warnings[0])
727
728
    def test_default_is_True(self):
729
        self.config = self.get_config(True)
730
        self.assertExpandIs(True)
5743.10.10 by Vincent Ladeuil
Remove spurious space
731
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
732
    def test_default_is_False(self):
733
        self.config = self.get_config(False)
734
        self.assertExpandIs(False)
5743.10.10 by Vincent Ladeuil
Remove spurious space
735
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
736
737
class TestIniConfigOptionExpansion(tests.TestCase):
738
    """Test option expansion from the IniConfig level.
739
740
    What we really want here is to test the Config level, but the class being
741
    abstract as far as storing values is concerned, this can't be done
742
    properly (yet).
743
    """
744
    # FIXME: This should be rewritten when all configs share a storage
745
    # implementation -- vila 2011-02-18
746
747
    def get_config(self, string=None):
748
        if string is None:
749
            string = ''
750
        c = config.IniBasedConfig.from_string(string)
751
        return c
752
753
    def assertExpansion(self, expected, conf, string, env=None):
754
        self.assertEquals(expected, conf.expand_options(string, env))
755
756
    def test_no_expansion(self):
757
        c = self.get_config('')
758
        self.assertExpansion('foo', c, 'foo')
759
760
    def test_env_adding_options(self):
761
        c = self.get_config('')
762
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
763
764
    def test_env_overriding_options(self):
765
        c = self.get_config('foo=baz')
766
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
767
768
    def test_simple_ref(self):
769
        c = self.get_config('foo=xxx')
770
        self.assertExpansion('xxx', c, '{foo}')
771
772
    def test_unknown_ref(self):
773
        c = self.get_config('')
774
        self.assertRaises(errors.ExpandingUnknownOption,
775
                          c.expand_options, '{foo}')
776
777
    def test_indirect_ref(self):
778
        c = self.get_config('''
779
foo=xxx
780
bar={foo}
781
''')
782
        self.assertExpansion('xxx', c, '{bar}')
783
784
    def test_embedded_ref(self):
785
        c = self.get_config('''
786
foo=xxx
787
bar=foo
788
''')
789
        self.assertExpansion('xxx', c, '{{bar}}')
790
791
    def test_simple_loop(self):
792
        c = self.get_config('foo={foo}')
793
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
794
795
    def test_indirect_loop(self):
796
        c = self.get_config('''
797
foo={bar}
798
bar={baz}
799
baz={foo}''')
800
        e = self.assertRaises(errors.OptionExpansionLoop,
801
                              c.expand_options, '{foo}')
802
        self.assertEquals('foo->bar->baz', e.refs)
803
        self.assertEquals('{foo}', e.string)
804
805
    def test_list(self):
806
        conf = self.get_config('''
807
foo=start
808
bar=middle
809
baz=end
810
list={foo},{bar},{baz}
811
''')
812
        self.assertEquals(['start', 'middle', 'end'],
813
                           conf.get_user_option('list', expand=True))
814
815
    def test_cascading_list(self):
816
        conf = self.get_config('''
817
foo=start,{bar}
818
bar=middle,{baz}
819
baz=end
820
list={foo}
821
''')
822
        self.assertEquals(['start', 'middle', 'end'],
823
                           conf.get_user_option('list', expand=True))
824
825
    def test_pathological_hidden_list(self):
826
        conf = self.get_config('''
827
foo=bin
828
bar=go
829
start={foo
830
middle=},{
831
end=bar}
832
hidden={start}{middle}{end}
833
''')
834
        # Nope, it's either a string or a list, and the list wins as soon as a
835
        # ',' appears, so the string concatenation never occur.
836
        self.assertEquals(['{foo', '}', '{', 'bar}'],
837
                          conf.get_user_option('hidden', expand=True))
838
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
839
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
840
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
841
842
    def get_config(self, location, string=None):
843
        if string is None:
844
            string = ''
845
        # Since we don't save the config we won't strictly require to inherit
846
        # from TestCaseInTempDir, but an error occurs so quickly...
847
        c = config.LocationConfig.from_string(string, location)
848
        return c
849
850
    def test_dont_cross_unrelated_section(self):
851
        c = self.get_config('/another/branch/path','''
852
[/one/branch/path]
853
foo = hello
854
bar = {foo}/2
855
856
[/another/branch/path]
857
bar = {foo}/2
858
''')
859
        self.assertRaises(errors.ExpandingUnknownOption,
860
                          c.get_user_option, 'bar', expand=True)
861
862
    def test_cross_related_sections(self):
863
        c = self.get_config('/project/branch/path','''
864
[/project]
865
foo = qu
866
867
[/project/branch/path]
868
bar = {foo}ux
869
''')
870
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
871
872
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
873
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
874
875
    def test_cannot_reload_without_name(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
876
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
877
        self.assertRaises(AssertionError, conf.reload)
878
879
    def test_reload_see_new_value(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
880
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
881
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
882
        c1._write_config_file()
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
883
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
884
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
885
        c2._write_config_file()
886
        self.assertEqual('vim', c1.get_user_option('editor'))
887
        self.assertEqual('emacs', c2.get_user_option('editor'))
888
        # Make sure we get the Right value
889
        c1.reload()
890
        self.assertEqual('emacs', c1.get_user_option('editor'))
891
892
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
893
class TestLockableConfig(tests.TestCaseInTempDir):
894
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
895
    scenarios = lockable_config_scenarios()
896
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
897
    # Set by load_tests
898
    config_class = None
899
    config_args = None
900
    config_section = None
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
901
902
    def setUp(self):
903
        super(TestLockableConfig, self).setUp()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
904
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
905
        self.config = self.create_config(self._content)
906
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
907
    def get_existing_config(self):
908
        return self.config_class(*self.config_args)
909
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
910
    def create_config(self, content):
5396.1.1 by Vincent Ladeuil
Fix python-2.6-ism.
911
        kwargs = dict(save=True)
912
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
913
        return c
914
915
    def test_simple_read_access(self):
916
        self.assertEquals('1', self.config.get_user_option('one'))
917
918
    def test_simple_write_access(self):
919
        self.config.set_user_option('one', 'one')
920
        self.assertEquals('one', self.config.get_user_option('one'))
921
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
922
    def test_listen_to_the_last_speaker(self):
923
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
924
        c2 = self.get_existing_config()
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
925
        c1.set_user_option('one', 'ONE')
926
        c2.set_user_option('two', 'TWO')
927
        self.assertEquals('ONE', c1.get_user_option('one'))
928
        self.assertEquals('TWO', c2.get_user_option('two'))
929
        # The second update respect the first one
930
        self.assertEquals('ONE', c2.get_user_option('one'))
931
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
932
    def test_last_speaker_wins(self):
933
        # If the same config is not shared, the same variable modified twice
934
        # can only see a single result.
935
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
936
        c2 = self.get_existing_config()
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
937
        c1.set_user_option('one', 'c1')
938
        c2.set_user_option('one', 'c2')
939
        self.assertEquals('c2', c2._get_user_option('one'))
940
        # The first modification is still available until another refresh
941
        # occur
942
        self.assertEquals('c1', c1._get_user_option('one'))
943
        c1.set_user_option('two', 'done')
944
        self.assertEquals('c2', c1._get_user_option('one'))
945
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
946
    def test_writes_are_serialized(self):
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
947
        c1 = self.config
948
        c2 = self.get_existing_config()
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
949
950
        # We spawn a thread that will pause *during* the write
951
        before_writing = threading.Event()
952
        after_writing = threading.Event()
953
        writing_done = threading.Event()
954
        c1_orig = c1._write_config_file
955
        def c1_write_config_file():
956
            before_writing.set()
957
            c1_orig()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
958
            # The lock is held. We wait for the main thread to decide when to
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
959
            # continue
960
            after_writing.wait()
961
        c1._write_config_file = c1_write_config_file
962
        def c1_set_option():
963
            c1.set_user_option('one', 'c1')
964
            writing_done.set()
965
        t1 = threading.Thread(target=c1_set_option)
966
        # Collect the thread after the test
967
        self.addCleanup(t1.join)
968
        # Be ready to unblock the thread if the test goes wrong
969
        self.addCleanup(after_writing.set)
970
        t1.start()
971
        before_writing.wait()
972
        self.assertTrue(c1._lock.is_held)
973
        self.assertRaises(errors.LockContention,
974
                          c2.set_user_option, 'one', 'c2')
975
        self.assertEquals('c1', c1.get_user_option('one'))
976
        # Let the lock be released
977
        after_writing.set()
978
        writing_done.wait()
979
        c2.set_user_option('one', 'c2')
980
        self.assertEquals('c2', c2.get_user_option('one'))
981
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
982
    def test_read_while_writing(self):
983
       c1 = self.config
984
       # We spawn a thread that will pause *during* the write
985
       ready_to_write = threading.Event()
986
       do_writing = threading.Event()
987
       writing_done = threading.Event()
988
       c1_orig = c1._write_config_file
989
       def c1_write_config_file():
990
           ready_to_write.set()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
991
           # The lock is held. We wait for the main thread to decide when to
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
992
           # continue
993
           do_writing.wait()
994
           c1_orig()
995
           writing_done.set()
996
       c1._write_config_file = c1_write_config_file
997
       def c1_set_option():
998
           c1.set_user_option('one', 'c1')
999
       t1 = threading.Thread(target=c1_set_option)
1000
       # Collect the thread after the test
1001
       self.addCleanup(t1.join)
1002
       # Be ready to unblock the thread if the test goes wrong
1003
       self.addCleanup(do_writing.set)
1004
       t1.start()
1005
       # Ensure the thread is ready to write
1006
       ready_to_write.wait()
1007
       self.assertTrue(c1._lock.is_held)
1008
       self.assertEquals('c1', c1.get_user_option('one'))
1009
       # If we read during the write, we get the old value
1010
       c2 = self.get_existing_config()
1011
       self.assertEquals('1', c2.get_user_option('one'))
1012
       # Let the writing occur and ensure it occurred
1013
       do_writing.set()
1014
       writing_done.wait()
1015
       # Now we get the updated value
1016
       c3 = self.get_existing_config()
1017
       self.assertEquals('c1', c3.get_user_option('one'))
1018
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
1019
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1020
class TestGetUserOptionAs(TestIniConfig):
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
1021
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
1022
    def test_get_user_option_as_bool(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1023
        conf, parser = self.make_config_parser("""
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
1024
a_true_bool = true
1025
a_false_bool = 0
1026
an_invalid_bool = maybe
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1027
a_list = hmm, who knows ? # This is interpreted as a list !
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
1028
""")
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1029
        get_bool = conf.get_user_option_as_bool
1030
        self.assertEqual(True, get_bool('a_true_bool'))
1031
        self.assertEqual(False, get_bool('a_false_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1032
        warnings = []
1033
        def warning(*args):
1034
            warnings.append(args[0] % args[1:])
1035
        self.overrideAttr(trace, 'warning', warning)
1036
        msg = 'Value "%s" is not a boolean for "%s"'
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1037
        self.assertIs(None, get_bool('an_invalid_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1038
        self.assertEquals(msg % ('maybe', 'an_invalid_bool'), warnings[0])
1039
        warnings = []
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1040
        self.assertIs(None, get_bool('not_defined_in_this_config'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1041
        self.assertEquals([], warnings)
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1042
1043
    def test_get_user_option_as_list(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1044
        conf, parser = self.make_config_parser("""
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1045
a_list = a,b,c
1046
length_1 = 1,
1047
one_item = x
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1048
""")
1049
        get_list = conf.get_user_option_as_list
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1050
        self.assertEqual(['a', 'b', 'c'], get_list('a_list'))
1051
        self.assertEqual(['1'], get_list('length_1'))
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1052
        self.assertEqual('x', conf.get_user_option('one_item'))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1053
        # automatically cast to list
1054
        self.assertEqual(['x'], get_list('one_item'))
1055
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1056
    def test_get_user_option_as_int_from_SI(self):
1057
        conf, parser = self.make_config_parser("""
1058
plain = 100
1059
si_k = 5k,
1060
si_kb = 5kb,
1061
si_m = 5M,
1062
si_mb = 5MB,
1063
si_g = 5g,
1064
si_gb = 5gB,
1065
""")
1066
        get_si = conf.get_user_option_as_int_from_SI
1067
        self.assertEqual(100, get_si('plain'))
1068
        self.assertEqual(5000, get_si('si_k'))
1069
        self.assertEqual(5000, get_si('si_kb'))
1070
        self.assertEqual(5000000, get_si('si_m'))
1071
        self.assertEqual(5000000, get_si('si_mb'))
1072
        self.assertEqual(5000000000, get_si('si_g'))
1073
        self.assertEqual(5000000000, get_si('si_gb'))
1074
        self.assertEqual(None, get_si('non-exist'))
1075
        self.assertEqual(42, get_si('non-exist-with-default',  42))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1076
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1077
class TestSupressWarning(TestIniConfig):
1078
1079
    def make_warnings_config(self, s):
1080
        conf, parser = self.make_config_parser(s)
1081
        return conf.suppress_warning
1082
1083
    def test_suppress_warning_unknown(self):
1084
        suppress_warning = self.make_warnings_config('')
1085
        self.assertEqual(False, suppress_warning('unknown_warning'))
1086
1087
    def test_suppress_warning_known(self):
1088
        suppress_warning = self.make_warnings_config('suppress_warnings=a,b')
1089
        self.assertEqual(False, suppress_warning('c'))
1090
        self.assertEqual(True, suppress_warning('a'))
1091
        self.assertEqual(True, suppress_warning('b'))
1092
1093
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1094
class TestGetConfig(tests.TestCase):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1095
1096
    def test_constructs(self):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1097
        my_config = config.GlobalConfig()
1098
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1099
    def test_calls_read_filenames(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1100
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1101
        oldparserclass = config.ConfigObj
1102
        config.ConfigObj = InstrumentedConfigObj
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1103
        my_config = config.GlobalConfig()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1104
        try:
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1105
            parser = my_config._get_parser()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1106
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1107
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1108
        self.assertIsInstance(parser, InstrumentedConfigObj)
1551.2.20 by Aaron Bentley
Treated config files as utf-8
1109
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
1110
                                          'utf-8')])
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1111
1112
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1113
class TestBranchConfig(tests.TestCaseWithTransport):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1114
1115
    def test_constructs(self):
1116
        branch = FakeBranch()
1117
        my_config = config.BranchConfig(branch)
1118
        self.assertRaises(TypeError, config.BranchConfig)
1119
1120
    def test_get_location_config(self):
1121
        branch = FakeBranch()
1122
        my_config = config.BranchConfig(branch)
1123
        location_config = my_config._get_location_config()
1124
        self.assertEqual(branch.base, location_config.location)
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1125
        self.assertIs(location_config, my_config._get_location_config())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1126
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1127
    def test_get_config(self):
1128
        """The Branch.get_config method works properly"""
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1129
        b = bzrdir.BzrDir.create_standalone_workingtree('.').branch
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1130
        my_config = b.get_config()
1131
        self.assertIs(my_config.get_user_option('wacky'), None)
1132
        my_config.set_user_option('wacky', 'unlikely')
1133
        self.assertEqual(my_config.get_user_option('wacky'), 'unlikely')
1134
1135
        # Ensure we get the same thing if we start again
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1136
        b2 = branch.Branch.open('.')
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1137
        my_config2 = b2.get_config()
1138
        self.assertEqual(my_config2.get_user_option('wacky'), 'unlikely')
1139
1824.1.1 by Robert Collins
Add BranchConfig.has_explicit_nickname call.
1140
    def test_has_explicit_nickname(self):
1141
        b = self.make_branch('.')
1142
        self.assertFalse(b.get_config().has_explicit_nickname())
1143
        b.nick = 'foo'
1144
        self.assertTrue(b.get_config().has_explicit_nickname())
1145
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1146
    def test_config_url(self):
1147
        """The Branch.get_config will use section that uses a local url"""
1148
        branch = self.make_branch('branch')
1149
        self.assertEqual('branch', branch.nick)
1150
1151
        local_url = urlutils.local_path_to_url('branch')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1152
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1153
            '[%s]\nnickname = foobar' % (local_url,),
1154
            local_url, save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1155
        self.assertEqual('foobar', branch.nick)
1156
1157
    def test_config_local_path(self):
1158
        """The Branch.get_config will use a local system path"""
1159
        branch = self.make_branch('branch')
1160
        self.assertEqual('branch', branch.nick)
1161
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1162
        local_path = osutils.getcwd().encode('utf8')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1163
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1164
            '[%s/branch]\nnickname = barry' % (local_path,),
1165
            'branch',  save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1166
        self.assertEqual('barry', branch.nick)
1167
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1168
    def test_config_creates_local(self):
1169
        """Creating a new entry in config uses a local path."""
2230.3.6 by Aaron Bentley
work in progress bind stuff
1170
        branch = self.make_branch('branch', format='knit')
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1171
        branch.set_push_location('http://foobar')
1172
        local_path = osutils.getcwd().encode('utf8')
1173
        # Surprisingly ConfigObj doesn't create a trailing newline
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1174
        self.check_file_contents(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1175
                                 '[%s/branch]\n'
1176
                                 'push_location = http://foobar\n'
3221.7.1 by Matt Nordhoff
Upgrade ConfigObj to version 4.5.1.
1177
                                 'push_location:policy = norecurse\n'
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1178
                                 % (local_path,))
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1179
2120.5.4 by Alexander Belchenko
Whitebox test for Config.get_nickname (req. by Aaron Bentley)
1180
    def test_autonick_urlencoded(self):
1181
        b = self.make_branch('!repo')
1182
        self.assertEqual('!repo', b.get_config().get_nickname())
1183
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1184
    def test_warn_if_masked(self):
1185
        warnings = []
1186
        def warning(*args):
1187
            warnings.append(args[0] % args[1:])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1188
        self.overrideAttr(trace, 'warning', warning)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1189
1190
        def set_option(store, warn_masked=True):
1191
            warnings[:] = []
1192
            conf.set_user_option('example_option', repr(store), store=store,
1193
                                 warn_masked=warn_masked)
1194
        def assertWarning(warning):
1195
            if warning is None:
1196
                self.assertEqual(0, len(warnings))
1197
            else:
1198
                self.assertEqual(1, len(warnings))
1199
                self.assertEqual(warning, warnings[0])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1200
        branch = self.make_branch('.')
1201
        conf = branch.get_config()
1202
        set_option(config.STORE_GLOBAL)
1203
        assertWarning(None)
1204
        set_option(config.STORE_BRANCH)
1205
        assertWarning(None)
1206
        set_option(config.STORE_GLOBAL)
1207
        assertWarning('Value "4" is masked by "3" from branch.conf')
1208
        set_option(config.STORE_GLOBAL, warn_masked=False)
1209
        assertWarning(None)
1210
        set_option(config.STORE_LOCATION)
1211
        assertWarning(None)
1212
        set_option(config.STORE_BRANCH)
1213
        assertWarning('Value "3" is masked by "0" from locations.conf')
1214
        set_option(config.STORE_BRANCH, warn_masked=False)
1215
        assertWarning(None)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1216
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1217
5448.1.1 by Vincent Ladeuil
Use TestCaseInTempDir for tests requiring disk resources
1218
class TestGlobalConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1219
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1220
    def test_user_id(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1221
        my_config = config.GlobalConfig.from_string(sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1222
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1223
                         my_config._get_user_id())
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1224
1225
    def test_absent_user_id(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1226
        my_config = config.GlobalConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1227
        self.assertEqual(None, my_config._get_user_id())
1228
1229
    def test_configured_editor(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1230
        my_config = config.GlobalConfig.from_string(sample_config_text)
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
1231
        editor = self.applyDeprecated(
1232
            deprecated_in((2, 4, 0)), my_config.get_editor)
1233
        self.assertEqual('vim', editor)
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1234
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1235
    def test_signatures_always(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1236
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1237
        self.assertEqual(config.CHECK_NEVER,
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1238
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1239
        self.assertEqual(config.SIGN_ALWAYS,
1240
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1241
        self.assertEqual(True, my_config.signature_needed())
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1242
1243
    def test_signatures_if_possible(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1244
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1245
        self.assertEqual(config.CHECK_NEVER,
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1246
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1247
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
1248
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1249
        self.assertEqual(False, my_config.signature_needed())
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1250
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1251
    def test_signatures_ignore(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1252
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1253
        self.assertEqual(config.CHECK_ALWAYS,
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1254
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1255
        self.assertEqual(config.SIGN_NEVER,
1256
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1257
        self.assertEqual(False, my_config.signature_needed())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1258
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1259
    def _get_sample_config(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1260
        my_config = config.GlobalConfig.from_string(sample_config_text)
1534.7.154 by Aaron Bentley
Removed changes from bzr.ab 1529..1536
1261
        return my_config
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1262
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1263
    def test_gpg_signing_command(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1264
        my_config = self._get_sample_config()
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1265
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
1266
        self.assertEqual(False, my_config.signature_needed())
1267
6012.2.3 by Jonathan Riddell
add config option for signing key
1268
    def test_gpg_signing_key(self):
1269
        my_config = self._get_sample_config()
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1270
        self.assertEqual("DD4D5088", my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1271
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1272
    def _get_empty_config(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1273
        my_config = config.GlobalConfig()
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1274
        return my_config
1275
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1276
    def test_gpg_signing_command_unset(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1277
        my_config = self._get_empty_config()
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1278
        self.assertEqual("gpg", my_config.gpg_signing_command())
1279
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1280
    def test_get_user_option_default(self):
1281
        my_config = self._get_empty_config()
1282
        self.assertEqual(None, my_config.get_user_option('no_option'))
1283
1284
    def test_get_user_option_global(self):
1285
        my_config = self._get_sample_config()
1286
        self.assertEqual("something",
1287
                         my_config.get_user_option('user_global_option'))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1288
1472 by Robert Collins
post commit hook, first pass implementation
1289
    def test_post_commit_default(self):
1290
        my_config = self._get_sample_config()
1291
        self.assertEqual(None, my_config.post_commit())
1292
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
1293
    def test_configured_logformat(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1294
        my_config = self._get_sample_config()
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
1295
        self.assertEqual("short", my_config.log_format())
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1296
5971.1.58 by Jonathan Riddell
more tests for new config options
1297
    def test_configured_acceptable_keys(self):
1298
        my_config = self._get_sample_config()
1299
        self.assertEqual("amy", my_config.acceptable_keys())
1300
1301
    def test_configured_validate_signatures_in_log(self):
1302
        my_config = self._get_sample_config()
1303
        self.assertEqual(True, my_config.validate_signatures_in_log())
1304
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1305
    def test_get_alias(self):
1306
        my_config = self._get_sample_config()
1307
        self.assertEqual('help', my_config.get_alias('h'))
1308
2900.3.6 by Tim Penhey
Added tests.
1309
    def test_get_aliases(self):
1310
        my_config = self._get_sample_config()
1311
        aliases = my_config.get_aliases()
1312
        self.assertEqual(2, len(aliases))
1313
        sorted_keys = sorted(aliases)
1314
        self.assertEqual('help', aliases[sorted_keys[0]])
1315
        self.assertEqual(sample_long_alias, aliases[sorted_keys[1]])
1316
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1317
    def test_get_no_alias(self):
1318
        my_config = self._get_sample_config()
1319
        self.assertEqual(None, my_config.get_alias('foo'))
1320
1321
    def test_get_long_alias(self):
1322
        my_config = self._get_sample_config()
1323
        self.assertEqual(sample_long_alias, my_config.get_alias('ll'))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1324
4603.1.10 by Aaron Bentley
Provide change editor via config.
1325
    def test_get_change_editor(self):
1326
        my_config = self._get_sample_config()
1327
        change_editor = my_config.get_change_editor('old', 'new')
1328
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
1329
        self.assertEqual('vimdiff -of @new_path @old_path',
4603.1.10 by Aaron Bentley
Provide change editor via config.
1330
                         ' '.join(change_editor.command_template))
1331
1332
    def test_get_no_change_editor(self):
1333
        my_config = self._get_empty_config()
1334
        change_editor = my_config.get_change_editor('old', 'new')
1335
        self.assertIs(None, change_editor)
1336
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1337
    def test_get_merge_tools(self):
1338
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1339
        tools = conf.get_merge_tools()
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1340
        self.log(repr(tools))
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1341
        self.assertEqual(
1342
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
1343
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
1344
            u'newtool' : u'"newtool with spaces" {this_temp}'},
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1345
            tools)
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1346
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1347
    def test_get_merge_tools_empty(self):
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1348
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1349
        tools = conf.get_merge_tools()
1350
        self.assertEqual({}, tools)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1351
1352
    def test_find_merge_tool(self):
1353
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1354
        cmdline = conf.find_merge_tool('sometool')
1355
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1356
1357
    def test_find_merge_tool_not_found(self):
1358
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1359
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
1360
        self.assertIs(cmdline, None)
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1361
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1362
    def test_find_merge_tool_known(self):
1363
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1364
        cmdline = conf.find_merge_tool('kdiff3')
1365
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
1366
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1367
    def test_find_merge_tool_override_known(self):
1368
        conf = self._get_empty_config()
5321.1.112 by Gordon Tyler
Removed set_merge_tool, remove_merge_tool and set_default_merge_tool from Config.
1369
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1370
        cmdline = conf.find_merge_tool('kdiff3')
1371
        self.assertEqual('kdiff3 blah', cmdline)
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1372
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1373
2900.3.6 by Tim Penhey
Added tests.
1374
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
1375
1376
    def test_empty(self):
1377
        my_config = config.GlobalConfig()
1378
        self.assertEqual(0, len(my_config.get_aliases()))
1379
1380
    def test_set_alias(self):
1381
        my_config = config.GlobalConfig()
1382
        alias_value = 'commit --strict'
1383
        my_config.set_alias('commit', alias_value)
1384
        new_config = config.GlobalConfig()
1385
        self.assertEqual(alias_value, new_config.get_alias('commit'))
1386
1387
    def test_remove_alias(self):
1388
        my_config = config.GlobalConfig()
1389
        my_config.set_alias('commit', 'commit --strict')
1390
        # Now remove the alias again.
1391
        my_config.unset_alias('commit')
1392
        new_config = config.GlobalConfig()
1393
        self.assertIs(None, new_config.get_alias('commit'))
1394
1395
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1396
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1397
1398
    def test_constructs(self):
1399
        my_config = config.LocationConfig('http://example.com')
1400
        self.assertRaises(TypeError, config.LocationConfig)
1401
1402
    def test_branch_calls_read_filenames(self):
1474 by Robert Collins
Merge from Aaron Bentley.
1403
        # This is testing the correct file names are provided.
1404
        # TODO: consolidate with the test for GlobalConfigs filename checks.
1405
        #
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1406
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1407
        oldparserclass = config.ConfigObj
1408
        config.ConfigObj = InstrumentedConfigObj
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1409
        try:
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1410
            my_config = config.LocationConfig('http://www.example.com')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1411
            parser = my_config._get_parser()
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1412
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1413
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1414
        self.assertIsInstance(parser, InstrumentedConfigObj)
1474 by Robert Collins
Merge from Aaron Bentley.
1415
        self.assertEqual(parser._calls,
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1416
                         [('__init__', config.locations_config_filename(),
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1417
                           'utf-8')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1418
1419
    def test_get_global_config(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1420
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1421
        global_config = my_config._get_global_config()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1422
        self.assertIsInstance(global_config, config.GlobalConfig)
1423
        self.assertIs(global_config, my_config._get_global_config())
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1424
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1425
    def assertLocationMatching(self, expected):
1426
        self.assertEqual(expected,
1427
                         list(self.my_location_config._get_matching_sections()))
1428
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1429
    def test__get_matching_sections_no_match(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1430
        self.get_branch_config('/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1431
        self.assertLocationMatching([])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1432
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1433
    def test__get_matching_sections_exact(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1434
        self.get_branch_config('http://www.example.com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1435
        self.assertLocationMatching([('http://www.example.com', '')])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1436
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1437
    def test__get_matching_sections_suffix_does_not(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1438
        self.get_branch_config('http://www.example.com-com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1439
        self.assertLocationMatching([])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1440
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1441
    def test__get_matching_sections_subdir_recursive(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1442
        self.get_branch_config('http://www.example.com/com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1443
        self.assertLocationMatching([('http://www.example.com', 'com')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1444
1993.3.5 by James Henstridge
add back recurse=False option to config file
1445
    def test__get_matching_sections_ignoreparent(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1446
        self.get_branch_config('http://www.example.com/ignoreparent')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1447
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1448
                                      '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1449
1993.3.5 by James Henstridge
add back recurse=False option to config file
1450
    def test__get_matching_sections_ignoreparent_subdir(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1451
        self.get_branch_config(
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1452
            'http://www.example.com/ignoreparent/childbranch')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1453
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1454
                                      'childbranch')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1455
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1456
    def test__get_matching_sections_subdir_trailing_slash(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1457
        self.get_branch_config('/b')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1458
        self.assertLocationMatching([('/b/', '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1459
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1460
    def test__get_matching_sections_subdir_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1461
        self.get_branch_config('/a/foo')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1462
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1463
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1464
    def test__get_matching_sections_subdir_child_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1465
        self.get_branch_config('/a/foo/bar')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1466
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1467
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1468
    def test__get_matching_sections_trailing_slash_with_children(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1469
        self.get_branch_config('/a/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1470
        self.assertLocationMatching([('/a/', '')])
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1471
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1472
    def test__get_matching_sections_explicit_over_glob(self):
1473
        # XXX: 2006-09-08 jamesh
1474
        # This test only passes because ord('c') > ord('*').  If there
1475
        # was a config section for '/a/?', it would get precedence
1476
        # over '/a/c'.
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1477
        self.get_branch_config('/a/c')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1478
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1479
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1480
    def test__get_option_policy_normal(self):
1481
        self.get_branch_config('http://www.example.com')
1482
        self.assertEqual(
1483
            self.my_location_config._get_config_policy(
1484
            'http://www.example.com', 'normal_option'),
1485
            config.POLICY_NONE)
1486
1487
    def test__get_option_policy_norecurse(self):
1488
        self.get_branch_config('http://www.example.com')
1489
        self.assertEqual(
1490
            self.my_location_config._get_option_policy(
1491
            'http://www.example.com', 'norecurse_option'),
1492
            config.POLICY_NORECURSE)
1493
        # Test old recurse=False setting:
1494
        self.assertEqual(
1495
            self.my_location_config._get_option_policy(
1496
            'http://www.example.com/norecurse', 'normal_option'),
1497
            config.POLICY_NORECURSE)
1498
1499
    def test__get_option_policy_normal(self):
1500
        self.get_branch_config('http://www.example.com')
1501
        self.assertEqual(
1502
            self.my_location_config._get_option_policy(
1503
            'http://www.example.com', 'appendpath_option'),
1504
            config.POLICY_APPENDPATH)
1505
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1506
    def test__get_options_with_policy(self):
1507
        self.get_branch_config('/dir/subdir',
1508
                               location_config="""\
1509
[/dir]
1510
other_url = /other-dir
1511
other_url:policy = appendpath
1512
[/dir/subdir]
1513
other_url = /other-subdir
1514
""")
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1515
        self.assertOptions(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1516
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
1517
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
1518
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1519
            self.my_location_config)
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1520
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1521
    def test_location_without_username(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1522
        self.get_branch_config('http://www.example.com/ignoreparent')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1523
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1524
                         self.my_config.username())
1525
1526
    def test_location_not_listed(self):
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1527
        """Test that the global username is used when no location matches"""
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1528
        self.get_branch_config('/home/robertc/sources')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1529
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1530
                         self.my_config.username())
1531
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1532
    def test_overriding_location(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1533
        self.get_branch_config('http://www.example.com/foo')
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1534
        self.assertEqual('Robert Collins <robertc@example.org>',
1535
                         self.my_config.username())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1536
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1537
    def test_signatures_not_set(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1538
        self.get_branch_config('http://www.example.com',
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1539
                                 global_config=sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1540
        self.assertEqual(config.CHECK_ALWAYS,
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1541
                         self.my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1542
        self.assertEqual(config.SIGN_NEVER,
1543
                         self.my_config.signing_policy())
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1544
1545
    def test_signatures_never(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1546
        self.get_branch_config('/a/c')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1547
        self.assertEqual(config.CHECK_NEVER,
1548
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1549
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1550
    def test_signatures_when_available(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1551
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1552
        self.assertEqual(config.CHECK_IF_POSSIBLE,
1553
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1554
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1555
    def test_signatures_always(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1556
        self.get_branch_config('/b')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1557
        self.assertEqual(config.CHECK_ALWAYS,
1558
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1559
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1560
    def test_gpg_signing_command(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1561
        self.get_branch_config('/b')
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1562
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
1563
1564
    def test_gpg_signing_command_missing(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1565
        self.get_branch_config('/a')
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1566
        self.assertEqual("false", self.my_config.gpg_signing_command())
1567
6012.2.3 by Jonathan Riddell
add config option for signing key
1568
    def test_gpg_signing_key(self):
1569
        self.get_branch_config('/b')
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1570
        self.assertEqual("DD4D5088", self.my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1571
6012.2.9 by Jonathan Riddell
fixes 68501
1572
    def test_gpg_signing_key_default(self):
6012.2.3 by Jonathan Riddell
add config option for signing key
1573
        self.get_branch_config('/a')
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1574
        self.assertEqual("erik@bagfors.nu", self.my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1575
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1576
    def test_get_user_option_global(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1577
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1578
        self.assertEqual('something',
1579
                         self.my_config.get_user_option('user_global_option'))
1580
1581
    def test_get_user_option_local(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1582
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1583
        self.assertEqual('local',
1584
                         self.my_config.get_user_option('user_local_option'))
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1585
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1586
    def test_get_user_option_appendpath(self):
1587
        # returned as is for the base path:
1588
        self.get_branch_config('http://www.example.com')
1589
        self.assertEqual('append',
1590
                         self.my_config.get_user_option('appendpath_option'))
1591
        # Extra path components get appended:
1592
        self.get_branch_config('http://www.example.com/a/b/c')
1593
        self.assertEqual('append/a/b/c',
1594
                         self.my_config.get_user_option('appendpath_option'))
1595
        # Overriden for http://www.example.com/dir, where it is a
1596
        # normal option:
1597
        self.get_branch_config('http://www.example.com/dir/a/b/c')
1598
        self.assertEqual('normal',
1599
                         self.my_config.get_user_option('appendpath_option'))
1600
1601
    def test_get_user_option_norecurse(self):
1602
        self.get_branch_config('http://www.example.com')
1603
        self.assertEqual('norecurse',
1604
                         self.my_config.get_user_option('norecurse_option'))
1605
        self.get_branch_config('http://www.example.com/dir')
1606
        self.assertEqual(None,
1607
                         self.my_config.get_user_option('norecurse_option'))
1608
        # http://www.example.com/norecurse is a recurse=False section
1609
        # that redefines normal_option.  Subdirectories do not pick up
1610
        # this redefinition.
1611
        self.get_branch_config('http://www.example.com/norecurse')
1612
        self.assertEqual('norecurse',
1613
                         self.my_config.get_user_option('normal_option'))
1614
        self.get_branch_config('http://www.example.com/norecurse/subdir')
1615
        self.assertEqual('normal',
1616
                         self.my_config.get_user_option('normal_option'))
1617
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1618
    def test_set_user_option_norecurse(self):
1619
        self.get_branch_config('http://www.example.com')
1620
        self.my_config.set_user_option('foo', 'bar',
1621
                                       store=config.STORE_LOCATION_NORECURSE)
1622
        self.assertEqual(
1623
            self.my_location_config._get_option_policy(
1624
            'http://www.example.com', 'foo'),
1625
            config.POLICY_NORECURSE)
1626
1627
    def test_set_user_option_appendpath(self):
1628
        self.get_branch_config('http://www.example.com')
1629
        self.my_config.set_user_option('foo', 'bar',
1630
                                       store=config.STORE_LOCATION_APPENDPATH)
1631
        self.assertEqual(
1632
            self.my_location_config._get_option_policy(
1633
            'http://www.example.com', 'foo'),
1634
            config.POLICY_APPENDPATH)
1635
1636
    def test_set_user_option_change_policy(self):
1637
        self.get_branch_config('http://www.example.com')
1638
        self.my_config.set_user_option('norecurse_option', 'normal',
1639
                                       store=config.STORE_LOCATION)
1640
        self.assertEqual(
1641
            self.my_location_config._get_option_policy(
1642
            'http://www.example.com', 'norecurse_option'),
1643
            config.POLICY_NONE)
1644
1645
    def test_set_user_option_recurse_false_section(self):
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1646
        # The following section has recurse=False set.  The test is to
1647
        # make sure that a normal option can be added to the section,
1648
        # converting recurse=False to the norecurse policy.
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1649
        self.get_branch_config('http://www.example.com/norecurse')
2120.6.11 by James Henstridge
s/0.13/0.14/ in deprecation warning
1650
        self.callDeprecated(['The recurse option is deprecated as of 0.14.  '
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1651
                             'The section "http://www.example.com/norecurse" '
1652
                             'has been converted to use policies.'],
1653
                            self.my_config.set_user_option,
1654
                            'foo', 'bar', store=config.STORE_LOCATION)
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1655
        self.assertEqual(
1656
            self.my_location_config._get_option_policy(
1657
            'http://www.example.com/norecurse', 'foo'),
1658
            config.POLICY_NONE)
1659
        # The previously existing option is still norecurse:
1660
        self.assertEqual(
1661
            self.my_location_config._get_option_policy(
1662
            'http://www.example.com/norecurse', 'normal_option'),
1663
            config.POLICY_NORECURSE)
1664
1472 by Robert Collins
post commit hook, first pass implementation
1665
    def test_post_commit_default(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1666
        self.get_branch_config('/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1667
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1472 by Robert Collins
post commit hook, first pass implementation
1668
                         self.my_config.post_commit())
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1669
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1670
    def get_branch_config(self, location, global_config=None,
1671
                          location_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1672
        my_branch = FakeBranch(location)
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1673
        if global_config is None:
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1674
            global_config = sample_config_text
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1675
        if location_config is None:
1676
            location_config = sample_branches_text
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1677
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1678
        my_global_config = config.GlobalConfig.from_string(global_config,
1679
                                                           save=True)
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1680
        my_location_config = config.LocationConfig.from_string(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1681
            location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1682
        my_config = config.BranchConfig(my_branch)
1683
        self.my_config = my_config
1684
        self.my_location_config = my_config._get_location_config()
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1685
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1686
    def test_set_user_setting_sets_and_saves(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1687
        self.get_branch_config('/a/c')
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1688
        record = InstrumentedConfigObj("foo")
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1689
        self.my_location_config._parser = record
1185.62.6 by John Arbash Meinel
Updated test_set_user_setting_sets_and_saves to remove the print statement, and make sure it is doing the right thing
1690
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1691
        self.callDeprecated(['The recurse option is deprecated as of '
1692
                             '0.14.  The section "/a/c" has been '
1693
                             'converted to use policies.'],
1694
                            self.my_config.set_user_option,
1695
                            'foo', 'bar', store=config.STORE_LOCATION)
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
1696
        self.assertEqual([('reload',),
1697
                          ('__contains__', '/a/c'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1698
                          ('__contains__', '/a/c/'),
1699
                          ('__setitem__', '/a/c', {}),
1700
                          ('__getitem__', '/a/c'),
1701
                          ('__setitem__', 'foo', 'bar'),
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1702
                          ('__getitem__', '/a/c'),
1703
                          ('as_bool', 'recurse'),
1704
                          ('__getitem__', '/a/c'),
1705
                          ('__delitem__', 'recurse'),
1706
                          ('__getitem__', '/a/c'),
1707
                          ('keys',),
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
1708
                          ('__getitem__', '/a/c'),
1709
                          ('__contains__', 'foo:policy'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1710
                          ('write',)],
1711
                         record._calls[1:])
1712
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1713
    def test_set_user_setting_sets_and_saves2(self):
1714
        self.get_branch_config('/a/c')
1715
        self.assertIs(self.my_config.get_user_option('foo'), None)
1716
        self.my_config.set_user_option('foo', 'bar')
1717
        self.assertEqual(
3616.2.6 by Mark Hammond
Fix test_set_user_setting_sets_and_saves2 on windows by stripping EOL
1718
            self.my_config.branch.control_files.files['branch.conf'].strip(),
1719
            'foo = bar')
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1720
        self.assertEqual(self.my_config.get_user_option('foo'), 'bar')
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1721
        self.my_config.set_user_option('foo', 'baz',
1722
                                       store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1723
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
1724
        self.my_config.set_user_option('foo', 'qux')
1725
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1726
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1727
    def test_get_bzr_remote_path(self):
1728
        my_config = config.LocationConfig('/a/c')
1729
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1730
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1731
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1732
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1733
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1734
1185.62.7 by John Arbash Meinel
Whitespace cleanup.
1735
1770.2.8 by Aaron Bentley
Add precedence test
1736
precedence_global = 'option = global'
1737
precedence_branch = 'option = branch'
1738
precedence_location = """
1739
[http://]
1740
recurse = true
1741
option = recurse
1742
[http://example.com/specific]
1743
option = exact
1744
"""
1745
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1746
class TestBranchConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1747
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1748
    def get_branch_config(self, global_config=None, location=None,
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1749
                          location_config=None, branch_data_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1750
        my_branch = FakeBranch(location)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1751
        if global_config is not None:
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1752
            my_global_config = config.GlobalConfig.from_string(global_config,
1753
                                                               save=True)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1754
        if location_config is not None:
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1755
            my_location_config = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1756
                location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1757
        my_config = config.BranchConfig(my_branch)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1758
        if branch_data_config is not None:
1759
            my_config.branch.control_files.files['branch.conf'] = \
1760
                branch_data_config
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1761
        return my_config
1762
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1763
    def test_user_id(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1764
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1765
        my_config = config.BranchConfig(branch)
1766
        self.assertEqual("Robert Collins <robertc@example.net>",
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1767
                         my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1768
        my_config.branch.control_files.files['email'] = "John"
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1769
        my_config.set_user_option('email',
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1770
                                  "Robert Collins <robertc@example.org>")
1771
        self.assertEqual("John", my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1772
        del my_config.branch.control_files.files['email']
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1773
        self.assertEqual("Robert Collins <robertc@example.org>",
1774
                         my_config.username())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1775
1776
    def test_not_set_in_branch(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1777
        my_config = self.get_branch_config(global_config=sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1778
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1779
                         my_config._get_user_id())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1780
        my_config.branch.control_files.files['email'] = "John"
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1781
        self.assertEqual("John", my_config._get_user_id())
1782
1861.4.1 by Matthieu Moy
BZREMAIL renamed to BZR_EMAIL.
1783
    def test_BZR_EMAIL_OVERRIDES(self):
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1784
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1785
        branch = FakeBranch()
1786
        my_config = config.BranchConfig(branch)
1787
        self.assertEqual("Robert Collins <robertc@example.org>",
1788
                         my_config.username())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1789
1442.1.19 by Robert Collins
BranchConfigs inherit signature_checking policy from their LocationConfig.
1790
    def test_signatures_forced(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1791
        my_config = self.get_branch_config(
1792
            global_config=sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1793
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1794
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1795
        self.assertTrue(my_config.signature_needed())
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1796
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1797
    def test_signatures_forced_branch(self):
1798
        my_config = self.get_branch_config(
1799
            global_config=sample_ignore_signatures,
1800
            branch_data_config=sample_always_signatures)
1801
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1802
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1803
        self.assertTrue(my_config.signature_needed())
1804
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1805
    def test_gpg_signing_command(self):
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1806
        my_config = self.get_branch_config(
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1807
            global_config=sample_config_text,
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1808
            # branch data cannot set gpg_signing_command
1809
            branch_data_config="gpg_signing_command=pgp")
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1810
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1811
1812
    def test_get_user_option_global(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1813
        my_config = self.get_branch_config(global_config=sample_config_text)
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1814
        self.assertEqual('something',
1815
                         my_config.get_user_option('user_global_option'))
1472 by Robert Collins
post commit hook, first pass implementation
1816
1817
    def test_post_commit_default(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1818
        my_config = self.get_branch_config(global_config=sample_config_text,
1819
                                      location='/a/c',
1820
                                      location_config=sample_branches_text)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1821
        self.assertEqual(my_config.branch.base, '/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1822
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1472 by Robert Collins
post commit hook, first pass implementation
1823
                         my_config.post_commit())
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1824
        my_config.set_user_option('post_commit', 'rmtree_root')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1825
        # post-commit is ignored when present in branch data
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1826
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1827
                         my_config.post_commit())
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1828
        my_config.set_user_option('post_commit', 'rmtree_root',
1829
                                  store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1830
        self.assertEqual('rmtree_root', my_config.post_commit())
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1831
1770.2.8 by Aaron Bentley
Add precedence test
1832
    def test_config_precedence(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1833
        # FIXME: eager test, luckily no persitent config file makes it fail
1834
        # -- vila 20100716
1770.2.8 by Aaron Bentley
Add precedence test
1835
        my_config = self.get_branch_config(global_config=precedence_global)
1836
        self.assertEqual(my_config.get_user_option('option'), 'global')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1837
        my_config = self.get_branch_config(global_config=precedence_global,
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1838
                                           branch_data_config=precedence_branch)
1770.2.8 by Aaron Bentley
Add precedence test
1839
        self.assertEqual(my_config.get_user_option('option'), 'branch')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1840
        my_config = self.get_branch_config(
1841
            global_config=precedence_global,
1842
            branch_data_config=precedence_branch,
1843
            location_config=precedence_location)
1770.2.8 by Aaron Bentley
Add precedence test
1844
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1845
        my_config = self.get_branch_config(
1846
            global_config=precedence_global,
1847
            branch_data_config=precedence_branch,
1848
            location_config=precedence_location,
1849
            location='http://example.com/specific')
1770.2.8 by Aaron Bentley
Add precedence test
1850
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1851
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
1852
    def test_get_mail_client(self):
1853
        config = self.get_branch_config()
1854
        client = config.get_mail_client()
2681.1.24 by Aaron Bentley
Handle default mail client by trying xdg-email, falling back to editor
1855
        self.assertIsInstance(client, mail_client.DefaultMail)
1856
2790.2.2 by Keir Mierle
Change alphabetic ordering into two categories; one for specific clients the other for generic options.
1857
        # Specific clients
2681.1.21 by Aaron Bentley
Refactor prompt generation to make it testable, test it with unicode
1858
        config.set_user_option('mail_client', 'evolution')
1859
        client = config.get_mail_client()
1860
        self.assertIsInstance(client, mail_client.Evolution)
1861
2681.5.1 by ghigo
Add KMail support to bzr send
1862
        config.set_user_option('mail_client', 'kmail')
1863
        client = config.get_mail_client()
1864
        self.assertIsInstance(client, mail_client.KMail)
1865
2790.2.1 by Keir Mierle
Add Mutt as a supported client email program. Also rearranges various listings
1866
        config.set_user_option('mail_client', 'mutt')
1867
        client = config.get_mail_client()
1868
        self.assertIsInstance(client, mail_client.Mutt)
1869
1870
        config.set_user_option('mail_client', 'thunderbird')
1871
        client = config.get_mail_client()
1872
        self.assertIsInstance(client, mail_client.Thunderbird)
1873
2790.2.2 by Keir Mierle
Change alphabetic ordering into two categories; one for specific clients the other for generic options.
1874
        # Generic options
1875
        config.set_user_option('mail_client', 'default')
1876
        client = config.get_mail_client()
1877
        self.assertIsInstance(client, mail_client.DefaultMail)
1878
1879
        config.set_user_option('mail_client', 'editor')
1880
        client = config.get_mail_client()
1881
        self.assertIsInstance(client, mail_client.Editor)
1882
1883
        config.set_user_option('mail_client', 'mapi')
1884
        client = config.get_mail_client()
1885
        self.assertIsInstance(client, mail_client.MAPIClient)
1886
2681.1.23 by Aaron Bentley
Add support for xdg-email
1887
        config.set_user_option('mail_client', 'xdg-email')
1888
        client = config.get_mail_client()
1889
        self.assertIsInstance(client, mail_client.XDGEmail)
1890
2681.1.10 by Aaron Bentley
Clean up handling of unknown mail clients
1891
        config.set_user_option('mail_client', 'firebird')
1892
        self.assertRaises(errors.UnknownMailClient, config.get_mail_client)
1893
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1894
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1895
class TestMailAddressExtraction(tests.TestCase):
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1896
1897
    def test_extract_email_address(self):
1898
        self.assertEqual('jane@test.com',
1899
                         config.extract_email_address('Jane <jane@test.com>'))
2055.2.2 by John Arbash Meinel
Switch extract_email_address() to use a more specific exception
1900
        self.assertRaises(errors.NoEmailInUsername,
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1901
                          config.extract_email_address, 'Jane Tester')
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1902
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1903
    def test_parse_username(self):
1904
        self.assertEqual(('', 'jdoe@example.com'),
1905
                         config.parse_username('jdoe@example.com'))
1906
        self.assertEqual(('', 'jdoe@example.com'),
1907
                         config.parse_username('<jdoe@example.com>'))
1908
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1909
                         config.parse_username('John Doe <jdoe@example.com>'))
1910
        self.assertEqual(('John Doe', ''),
1911
                         config.parse_username('John Doe'))
3063.3.3 by Lukáš Lalinský
Add one more test for config.parse_username().
1912
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1913
                         config.parse_username('John Doe jdoe@example.com'))
2562.1.2 by John Arbash Meinel
Clean up whitespace
1914
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1915
class TestTreeConfig(tests.TestCaseWithTransport):
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1916
1917
    def test_get_value(self):
1918
        """Test that retreiving a value from a section is possible"""
1919
        branch = self.make_branch('.')
1920
        tree_config = config.TreeConfig(branch)
1921
        tree_config.set_option('value', 'key', 'SECTION')
1922
        tree_config.set_option('value2', 'key2')
1923
        tree_config.set_option('value3-top', 'key3')
1924
        tree_config.set_option('value3-section', 'key3', 'SECTION')
1925
        value = tree_config.get_option('key', 'SECTION')
1926
        self.assertEqual(value, 'value')
1927
        value = tree_config.get_option('key2')
1928
        self.assertEqual(value, 'value2')
1929
        self.assertEqual(tree_config.get_option('non-existant'), None)
1930
        value = tree_config.get_option('non-existant', 'SECTION')
1931
        self.assertEqual(value, None)
1932
        value = tree_config.get_option('non-existant', default='default')
1933
        self.assertEqual(value, 'default')
1934
        self.assertEqual(tree_config.get_option('key2', 'NOSECTION'), None)
1935
        value = tree_config.get_option('key2', 'NOSECTION', default='default')
1936
        self.assertEqual(value, 'default')
1937
        value = tree_config.get_option('key3')
1938
        self.assertEqual(value, 'value3-top')
1939
        value = tree_config.get_option('key3', 'SECTION')
1940
        self.assertEqual(value, 'value3-section')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
1941
1942
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1943
class TestTransportConfig(tests.TestCaseWithTransport):
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1944
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1945
    def test_load_utf8(self):
1946
        """Ensure we can load an utf8-encoded file."""
1947
        t = self.get_transport()
1948
        unicode_user = u'b\N{Euro Sign}ar'
1949
        unicode_content = u'user=%s' % (unicode_user,)
1950
        utf8_content = unicode_content.encode('utf8')
1951
        # Store the raw content in the config file
1952
        t.put_bytes('foo.conf', utf8_content)
1953
        conf = config.TransportConfig(t, 'foo.conf')
1954
        self.assertEquals(unicode_user, conf.get_option('user'))
1955
1956
    def test_load_non_ascii(self):
1957
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
1958
        t = self.get_transport()
1959
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
1960
        conf = config.TransportConfig(t, 'foo.conf')
1961
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
1962
1963
    def test_load_erroneous_content(self):
1964
        """Ensure we display a proper error on content that can't be parsed."""
1965
        t = self.get_transport()
1966
        t.put_bytes('foo.conf', '[open_section\n')
1967
        conf = config.TransportConfig(t, 'foo.conf')
1968
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
1969
6110.5.1 by Jelmer Vernooij
Warn when a configuration file can not be opened.
1970
    def test_load_permission_denied(self):
1971
        """Ensure we get an empty config file if the file is inaccessible."""
1972
        warnings = []
1973
        def warning(*args):
1974
            warnings.append(args[0] % args[1:])
1975
        self.overrideAttr(trace, 'warning', warning)
1976
1977
        class DenyingTransport(object):
1978
1979
            def __init__(self, base):
1980
                self.base = base
1981
1982
            def get_bytes(self, relpath):
1983
                raise errors.PermissionDenied(relpath, "")
1984
1985
        cfg = config.TransportConfig(
1986
            DenyingTransport("nonexisting://"), 'control.conf')
1987
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
1988
        self.assertEquals(
1989
            warnings,
1990
            [u'Permission denied while trying to open configuration file '
1991
             u'nonexisting:///control.conf.'])
1992
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1993
    def test_get_value(self):
1994
        """Test that retreiving a value from a section is possible"""
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1995
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1996
                                               'control.conf')
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1997
        bzrdir_config.set_option('value', 'key', 'SECTION')
1998
        bzrdir_config.set_option('value2', 'key2')
1999
        bzrdir_config.set_option('value3-top', 'key3')
2000
        bzrdir_config.set_option('value3-section', 'key3', 'SECTION')
2001
        value = bzrdir_config.get_option('key', 'SECTION')
2002
        self.assertEqual(value, 'value')
2003
        value = bzrdir_config.get_option('key2')
2004
        self.assertEqual(value, 'value2')
2005
        self.assertEqual(bzrdir_config.get_option('non-existant'), None)
2006
        value = bzrdir_config.get_option('non-existant', 'SECTION')
2007
        self.assertEqual(value, None)
2008
        value = bzrdir_config.get_option('non-existant', default='default')
2009
        self.assertEqual(value, 'default')
2010
        self.assertEqual(bzrdir_config.get_option('key2', 'NOSECTION'), None)
2011
        value = bzrdir_config.get_option('key2', 'NOSECTION',
2012
                                         default='default')
2013
        self.assertEqual(value, 'default')
2014
        value = bzrdir_config.get_option('key3')
2015
        self.assertEqual(value, 'value3-top')
2016
        value = bzrdir_config.get_option('key3', 'SECTION')
2017
        self.assertEqual(value, 'value3-section')
2018
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
2019
    def test_set_unset_default_stack_on(self):
2020
        my_dir = self.make_bzrdir('.')
4288.1.3 by Robert Collins
Fix BzrDirConfig tests.
2021
        bzrdir_config = config.BzrDirConfig(my_dir)
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
2022
        self.assertIs(None, bzrdir_config.get_default_stack_on())
2023
        bzrdir_config.set_default_stack_on('Foo')
3242.3.14 by Aaron Bentley
Make BzrDirConfig use TransportConfig
2024
        self.assertEqual('Foo', bzrdir_config._config.get_option(
2025
                         'default_stack_on'))
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
2026
        self.assertEqual('Foo', bzrdir_config.get_default_stack_on())
2027
        bzrdir_config.set_default_stack_on(None)
2028
        self.assertIs(None, bzrdir_config.get_default_stack_on())
2029
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
2030
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2031
class TestOldConfigHooks(tests.TestCaseWithTransport):
2032
2033
    def setUp(self):
2034
        super(TestOldConfigHooks, self).setUp()
2035
        create_configs_with_file_option(self)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2036
2037
    def assertGetHook(self, conf, name, value):
2038
        calls = []
2039
        def hook(*args):
2040
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2041
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2042
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2043
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2044
        self.assertLength(0, calls)
2045
        actual_value = conf.get_user_option(name)
2046
        self.assertEquals(value, actual_value)
2047
        self.assertLength(1, calls)
2048
        self.assertEquals((conf, name, value), calls[0])
2049
2050
    def test_get_hook_bazaar(self):
2051
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
2052
2053
    def test_get_hook_locations(self):
2054
        self.assertGetHook(self.locations_config, 'file', 'locations')
2055
2056
    def test_get_hook_branch(self):
2057
        # Since locations masks branch, we define a different option
2058
        self.branch_config.set_user_option('file2', 'branch')
2059
        self.assertGetHook(self.branch_config, 'file2', 'branch')
2060
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2061
    def assertSetHook(self, conf, name, value):
2062
        calls = []
2063
        def hook(*args):
2064
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2065
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2066
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2067
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2068
        self.assertLength(0, calls)
2069
        conf.set_user_option(name, value)
2070
        self.assertLength(1, calls)
2071
        # We can't assert the conf object below as different configs use
2072
        # different means to implement set_user_option and we care only about
2073
        # coverage here.
2074
        self.assertEquals((name, value), calls[0][1:])
2075
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2076
    def test_set_hook_bazaar(self):
2077
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
2078
2079
    def test_set_hook_locations(self):
2080
        self.assertSetHook(self.locations_config, 'foo', 'locations')
2081
2082
    def test_set_hook_branch(self):
2083
        self.assertSetHook(self.branch_config, 'foo', 'branch')
2084
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2085
    def assertRemoveHook(self, conf, name, section_name=None):
2086
        calls = []
2087
        def hook(*args):
2088
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2089
        config.OldConfigHooks.install_named_hook('remove', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2090
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2091
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2092
        self.assertLength(0, calls)
2093
        conf.remove_user_option(name, section_name)
2094
        self.assertLength(1, calls)
2095
        # We can't assert the conf object below as different configs use
2096
        # different means to implement remove_user_option and we care only about
2097
        # coverage here.
2098
        self.assertEquals((name,), calls[0][1:])
2099
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2100
    def test_remove_hook_bazaar(self):
2101
        self.assertRemoveHook(self.bazaar_config, 'file')
2102
2103
    def test_remove_hook_locations(self):
2104
        self.assertRemoveHook(self.locations_config, 'file',
2105
                              self.locations_config.location)
2106
2107
    def test_remove_hook_branch(self):
2108
        self.assertRemoveHook(self.branch_config, 'file')
2109
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2110
    def assertLoadHook(self, name, conf_class, *conf_args):
2111
        calls = []
2112
        def hook(*args):
2113
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2114
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2115
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2116
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2117
        self.assertLength(0, calls)
2118
        # Build a config
2119
        conf = conf_class(*conf_args)
2120
        # Access an option to trigger a load
2121
        conf.get_user_option(name)
2122
        self.assertLength(1, calls)
2123
        # Since we can't assert about conf, we just use the number of calls ;-/
2124
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2125
    def test_load_hook_bazaar(self):
2126
        self.assertLoadHook('file', config.GlobalConfig)
2127
2128
    def test_load_hook_locations(self):
2129
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
2130
2131
    def test_load_hook_branch(self):
2132
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
2133
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2134
    def assertSaveHook(self, conf):
2135
        calls = []
2136
        def hook(*args):
2137
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2138
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2139
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2140
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2141
        self.assertLength(0, calls)
2142
        # Setting an option triggers a save
2143
        conf.set_user_option('foo', 'bar')
2144
        self.assertLength(1, calls)
2145
        # Since we can't assert about conf, we just use the number of calls ;-/
2146
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2147
    def test_save_hook_bazaar(self):
2148
        self.assertSaveHook(self.bazaar_config)
2149
2150
    def test_save_hook_locations(self):
2151
        self.assertSaveHook(self.locations_config)
2152
2153
    def test_save_hook_branch(self):
2154
        self.assertSaveHook(self.branch_config)
2155
2156
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2157
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
2158
    """Tests config hooks for remote configs.
2159
2160
    No tests for the remove hook as this is not implemented there.
2161
    """
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2162
2163
    def setUp(self):
2164
        super(TestOldConfigHooksForRemote, self).setUp()
2165
        self.transport_server = test_server.SmartTCPServer_for_testing
2166
        create_configs_with_file_option(self)
2167
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2168
    def assertGetHook(self, conf, name, value):
2169
        calls = []
2170
        def hook(*args):
2171
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2172
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2173
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2174
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2175
        self.assertLength(0, calls)
2176
        actual_value = conf.get_option(name)
2177
        self.assertEquals(value, actual_value)
2178
        self.assertLength(1, calls)
2179
        self.assertEquals((conf, name, value), calls[0])
2180
2181
    def test_get_hook_remote_branch(self):
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2182
        remote_branch = branch.Branch.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2183
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2184
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2185
    def test_get_hook_remote_bzrdir(self):
2186
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2187
        conf = remote_bzrdir._get_config()
2188
        conf.set_option('remotedir', 'file')
2189
        self.assertGetHook(conf, 'file', 'remotedir')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2190
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2191
    def assertSetHook(self, conf, name, value):
2192
        calls = []
2193
        def hook(*args):
2194
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2195
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2196
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2197
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2198
        self.assertLength(0, calls)
2199
        conf.set_option(value, name)
2200
        self.assertLength(1, calls)
2201
        # We can't assert the conf object below as different configs use
2202
        # different means to implement set_user_option and we care only about
2203
        # coverage here.
2204
        self.assertEquals((name, value), calls[0][1:])
2205
2206
    def test_set_hook_remote_branch(self):
2207
        remote_branch = branch.Branch.open(self.get_url('tree'))
2208
        self.addCleanup(remote_branch.lock_write().unlock)
2209
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
2210
2211
    def test_set_hook_remote_bzrdir(self):
2212
        remote_branch = branch.Branch.open(self.get_url('tree'))
2213
        self.addCleanup(remote_branch.lock_write().unlock)
2214
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2215
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
2216
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2217
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
2218
        calls = []
2219
        def hook(*args):
2220
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2221
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2222
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2223
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2224
        self.assertLength(0, calls)
2225
        # Build a config
2226
        conf = conf_class(*conf_args)
2227
        # Access an option to trigger a load
2228
        conf.get_option(name)
2229
        self.assertLength(expected_nb_calls, calls)
2230
        # Since we can't assert about conf, we just use the number of calls ;-/
2231
2232
    def test_load_hook_remote_branch(self):
2233
        remote_branch = branch.Branch.open(self.get_url('tree'))
2234
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
2235
2236
    def test_load_hook_remote_bzrdir(self):
2237
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2238
        # The config file doesn't exist, set an option to force its creation
2239
        conf = remote_bzrdir._get_config()
2240
        conf.set_option('remotedir', 'file')
2241
        # We get one call for the server and one call for the client, this is
2242
        # caused by the differences in implementations betwen
2243
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
2244
        # SmartServerBranchGetConfigFile (in smart/branch.py)
2245
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
2246
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2247
    def assertSaveHook(self, conf):
2248
        calls = []
2249
        def hook(*args):
2250
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2251
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2252
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2253
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2254
        self.assertLength(0, calls)
2255
        # Setting an option triggers a save
2256
        conf.set_option('foo', 'bar')
2257
        self.assertLength(1, calls)
2258
        # Since we can't assert about conf, we just use the number of calls ;-/
2259
2260
    def test_save_hook_remote_branch(self):
2261
        remote_branch = branch.Branch.open(self.get_url('tree'))
2262
        self.addCleanup(remote_branch.lock_write().unlock)
2263
        self.assertSaveHook(remote_branch._get_config())
2264
2265
    def test_save_hook_remote_bzrdir(self):
2266
        remote_branch = branch.Branch.open(self.get_url('tree'))
2267
        self.addCleanup(remote_branch.lock_write().unlock)
2268
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2269
        self.assertSaveHook(remote_bzrdir._get_config())
2270
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2271
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2272
class TestOption(tests.TestCase):
2273
2274
    def test_default_value(self):
2275
        opt = config.Option('foo', default='bar')
2276
        self.assertEquals('bar', opt.get_default())
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2277
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2278
    def test_default_value_from_env(self):
2279
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
2280
        self.overrideEnv('FOO', 'quux')
2281
        # Env variable provides a default taking over the option one
2282
        self.assertEquals('quux', opt.get_default())
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2283
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2284
    def test_first_default_value_from_env_wins(self):
2285
        opt = config.Option('foo', default='bar',
2286
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
2287
        self.overrideEnv('FOO', 'foo')
2288
        self.overrideEnv('BAZ', 'baz')
2289
        # The first env var set wins
2290
        self.assertEquals('foo', opt.get_default())
2291
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
2292
    def test_not_supported_list_default_value(self):
2293
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
2294
2295
    def test_not_supported_object_default_value(self):
2296
        self.assertRaises(AssertionError, config.Option, 'foo',
2297
                          default=object())
2298
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2299
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2300
class TestOptionConverterMixin(object):
2301
2302
    def assertConverted(self, expected, opt, value):
2303
        self.assertEquals(expected, opt.convert_from_unicode(value))
2304
2305
    def assertWarns(self, opt, value):
2306
        warnings = []
2307
        def warning(*args):
2308
            warnings.append(args[0] % args[1:])
2309
        self.overrideAttr(trace, 'warning', warning)
2310
        self.assertEquals(None, opt.convert_from_unicode(value))
2311
        self.assertLength(1, warnings)
2312
        self.assertEquals(
2313
            'Value "%s" is not valid for "%s"' % (value, opt.name),
2314
            warnings[0])
2315
2316
    def assertErrors(self, opt, value):
2317
        self.assertRaises(errors.ConfigOptionValueError,
2318
                          opt.convert_from_unicode, value)
2319
2320
    def assertConvertInvalid(self, opt, invalid_value):
2321
        opt.invalid = None
2322
        self.assertEquals(None, opt.convert_from_unicode(invalid_value))
2323
        opt.invalid = 'warning'
2324
        self.assertWarns(opt, invalid_value)
2325
        opt.invalid = 'error'
2326
        self.assertErrors(opt, invalid_value)
2327
2328
2329
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
2330
2331
    def get_option(self):
2332
        return config.Option('foo', help='A boolean.',
2333
                             from_unicode=config.bool_from_store)
2334
2335
    def test_convert_invalid(self):
2336
        opt = self.get_option()
2337
        # A string that is not recognized as a boolean
2338
        self.assertConvertInvalid(opt, u'invalid-boolean')
2339
        # A list of strings is never recognized as a boolean
2340
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
2341
2342
    def test_convert_valid(self):
2343
        opt = self.get_option()
2344
        self.assertConverted(True, opt, u'True')
2345
        self.assertConverted(True, opt, u'1')
2346
        self.assertConverted(False, opt, u'False')
2347
2348
2349
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
2350
2351
    def get_option(self):
2352
        return config.Option('foo', help='An integer.',
2353
                             from_unicode=config.int_from_store)
2354
2355
    def test_convert_invalid(self):
2356
        opt = self.get_option()
2357
        # A string that is not recognized as an integer
2358
        self.assertConvertInvalid(opt, u'forty-two')
2359
        # A list of strings is never recognized as an integer
2360
        self.assertConvertInvalid(opt, [u'a', u'list'])
2361
2362
    def test_convert_valid(self):
2363
        opt = self.get_option()
2364
        self.assertConverted(16, opt, u'16')
2365
2366
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
2367
2368
    def get_option(self):
2369
        return config.Option('foo', help='A list.',
2370
                             from_unicode=config.list_from_store)
2371
2372
    def test_convert_invalid(self):
2373
        # No string is invalid as all forms can be converted to a list
2374
        pass
2375
2376
    def test_convert_valid(self):
2377
        opt = self.get_option()
2378
        # An empty string is an empty list
2379
        self.assertConverted([], opt, '') # Using a bare str() just in case
2380
        self.assertConverted([], opt, u'')
2381
        # A boolean
2382
        self.assertConverted([u'True'], opt, u'True')
2383
        # An integer
2384
        self.assertConverted([u'42'], opt, u'42')
2385
        # A single string
2386
        self.assertConverted([u'bar'], opt, u'bar')
2387
        # A list remains a list (configObj will turn a string containing commas
2388
        # into a list, but that's not what we're testing here)
2389
        self.assertConverted([u'foo', u'1', u'True'],
2390
                             opt, [u'foo', u'1', u'True'])
2391
2392
2393
class TestOptionConverterMixin(object):
2394
2395
    def assertConverted(self, expected, opt, value):
2396
        self.assertEquals(expected, opt.convert_from_unicode(value))
2397
2398
    def assertWarns(self, opt, value):
2399
        warnings = []
2400
        def warning(*args):
2401
            warnings.append(args[0] % args[1:])
2402
        self.overrideAttr(trace, 'warning', warning)
2403
        self.assertEquals(None, opt.convert_from_unicode(value))
2404
        self.assertLength(1, warnings)
2405
        self.assertEquals(
2406
            'Value "%s" is not valid for "%s"' % (value, opt.name),
2407
            warnings[0])
2408
2409
    def assertErrors(self, opt, value):
2410
        self.assertRaises(errors.ConfigOptionValueError,
2411
                          opt.convert_from_unicode, value)
2412
2413
    def assertConvertInvalid(self, opt, invalid_value):
2414
        opt.invalid = None
2415
        self.assertEquals(None, opt.convert_from_unicode(invalid_value))
2416
        opt.invalid = 'warning'
2417
        self.assertWarns(opt, invalid_value)
2418
        opt.invalid = 'error'
2419
        self.assertErrors(opt, invalid_value)
2420
2421
2422
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
2423
2424
    def get_option(self):
2425
        return config.Option('foo', help='A boolean.',
2426
                             from_unicode=config.bool_from_store)
2427
2428
    def test_convert_invalid(self):
2429
        opt = self.get_option()
2430
        # A string that is not recognized as a boolean
2431
        self.assertConvertInvalid(opt, u'invalid-boolean')
2432
        # A list of strings is never recognized as a boolean
2433
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
2434
2435
    def test_convert_valid(self):
2436
        opt = self.get_option()
2437
        self.assertConverted(True, opt, u'True')
2438
        self.assertConverted(True, opt, u'1')
2439
        self.assertConverted(False, opt, u'False')
2440
2441
2442
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
2443
2444
    def get_option(self):
2445
        return config.Option('foo', help='An integer.',
2446
                             from_unicode=config.int_from_store)
2447
2448
    def test_convert_invalid(self):
2449
        opt = self.get_option()
2450
        # A string that is not recognized as an integer
2451
        self.assertConvertInvalid(opt, u'forty-two')
2452
        # A list of strings is never recognized as an integer
2453
        self.assertConvertInvalid(opt, [u'a', u'list'])
2454
2455
    def test_convert_valid(self):
2456
        opt = self.get_option()
2457
        self.assertConverted(16, opt, u'16')
2458
6082.5.10 by Vincent Ladeuil
Tweaks suggested by jam during review.
2459
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2460
class TestOptionWithListConverter(tests.TestCase, TestOptionConverterMixin):
2461
2462
    def get_option(self):
2463
        return config.Option('foo', help='A list.',
2464
                             from_unicode=config.list_from_store)
2465
2466
    def test_convert_invalid(self):
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
2467
        opt = self.get_option()
2468
        # We don't even try to convert a list into a list, we only expect
2469
        # strings
2470
        self.assertConvertInvalid(opt, [1])
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2471
        # No string is invalid as all forms can be converted to a list
2472
2473
    def test_convert_valid(self):
2474
        opt = self.get_option()
2475
        # An empty string is an empty list
2476
        self.assertConverted([], opt, '') # Using a bare str() just in case
2477
        self.assertConverted([], opt, u'')
2478
        # A boolean
2479
        self.assertConverted([u'True'], opt, u'True')
2480
        # An integer
2481
        self.assertConverted([u'42'], opt, u'42')
2482
        # A single string
2483
        self.assertConverted([u'bar'], opt, u'bar')
2484
2485
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2486
class TestOptionRegistry(tests.TestCase):
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2487
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2488
    def setUp(self):
2489
        super(TestOptionRegistry, self).setUp()
2490
        # Always start with an empty registry
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2491
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2492
        self.registry = config.option_registry
2493
2494
    def test_register(self):
2495
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2496
        self.registry.register(opt)
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2497
        self.assertIs(opt, self.registry.get('foo'))
2498
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2499
    def test_registered_help(self):
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2500
        opt = config.Option('foo', help='A simple option')
2501
        self.registry.register(opt)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2502
        self.assertEquals('A simple option', self.registry.get_help('foo'))
2503
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2504
    lazy_option = config.Option('lazy_foo', help='Lazy help')
2505
2506
    def test_register_lazy(self):
2507
        self.registry.register_lazy('lazy_foo', self.__module__,
2508
                                    'TestOptionRegistry.lazy_option')
2509
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
2510
2511
    def test_registered_lazy_help(self):
2512
        self.registry.register_lazy('lazy_foo', self.__module__,
2513
                                    'TestOptionRegistry.lazy_option')
2514
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
2515
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2516
2517
class TestRegisteredOptions(tests.TestCase):
2518
    """All registered options should verify some constraints."""
2519
2520
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
2521
                 in config.option_registry.iteritems()]
2522
2523
    def setUp(self):
2524
        super(TestRegisteredOptions, self).setUp()
2525
        self.registry = config.option_registry
2526
2527
    def test_proper_name(self):
2528
        # An option should be registered under its own name, this can't be
2529
        # checked at registration time for the lazy ones.
2530
        self.assertEquals(self.option_name, self.option.name)
2531
2532
    def test_help_is_set(self):
2533
        option_help = self.registry.get_help(self.option_name)
2534
        self.assertNotEquals(None, option_help)
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2535
        # Come on, think about the user, he really wants to know what the
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2536
        # option is about
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2537
        self.assertIsNot(None, option_help)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2538
        self.assertNotEquals('', option_help)
2539
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2540
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2541
class TestSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2542
2543
    # FIXME: Parametrize so that all sections produced by Stores run these
5743.3.1 by Vincent Ladeuil
Add a docstring and dates to FIXMEs.
2544
    # tests -- vila 2011-04-01
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2545
2546
    def test_get_a_value(self):
2547
        a_dict = dict(foo='bar')
5743.3.11 by Vincent Ladeuil
Config sections only implement read access.
2548
        section = config.Section('myID', a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2549
        self.assertEquals('bar', section.get('foo'))
2550
5743.3.10 by Vincent Ladeuil
Fix typos mentioned in reviews.
2551
    def test_get_unknown_option(self):
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2552
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2553
        section = config.Section(None, a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2554
        self.assertEquals('out of thin air',
2555
                          section.get('foo', 'out of thin air'))
2556
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2557
    def test_options_is_shared(self):
2558
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2559
        section = config.Section(None, a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2560
        self.assertIs(a_dict, section.options)
2561
2562
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2563
class TestMutableSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2564
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2565
    scenarios = [('mutable',
2566
                  {'get_section':
2567
                       lambda opts: config.MutableSection('myID', opts)},),
2568
                 ('cmdline',
2569
                  {'get_section':
2570
                       lambda opts: config.CommandLineSection(opts)},),
2571
        ]
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2572
2573
    def test_set(self):
2574
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2575
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2576
        section.set('foo', 'new_value')
2577
        self.assertEquals('new_value', section.get('foo'))
2578
        # The change appears in the shared section
2579
        self.assertEquals('new_value', a_dict.get('foo'))
2580
        # We keep track of the change
2581
        self.assertTrue('foo' in section.orig)
2582
        self.assertEquals('bar', section.orig.get('foo'))
2583
2584
    def test_set_preserve_original_once(self):
2585
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2586
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2587
        section.set('foo', 'first_value')
2588
        section.set('foo', 'second_value')
2589
        # We keep track of the original value
2590
        self.assertTrue('foo' in section.orig)
2591
        self.assertEquals('bar', section.orig.get('foo'))
2592
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2593
    def test_remove(self):
2594
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2595
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2596
        section.remove('foo')
2597
        # We get None for unknown options via the default value
2598
        self.assertEquals(None, section.get('foo'))
2599
        # Or we just get the default value
2600
        self.assertEquals('unknown', section.get('foo', 'unknown'))
2601
        self.assertFalse('foo' in section.options)
2602
        # We keep track of the deletion
2603
        self.assertTrue('foo' in section.orig)
2604
        self.assertEquals('bar', section.orig.get('foo'))
2605
2606
    def test_remove_new_option(self):
2607
        a_dict = dict()
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2608
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2609
        section.set('foo', 'bar')
2610
        section.remove('foo')
2611
        self.assertFalse('foo' in section.options)
2612
        # The option didn't exist initially so it we need to keep track of it
2613
        # with a special value
2614
        self.assertTrue('foo' in section.orig)
5743.3.6 by Vincent Ladeuil
Use a name less likely to be reused.
2615
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2616
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2617
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2618
class TestCommandLineSection(tests.TestCase):
2619
2620
    def setUp(self):
2621
        super(TestCommandLineSection, self).setUp()
2622
        self.section = config.CommandLineSection()
2623
2624
    def test_no_override(self):
2625
        self.section._from_cmdline([])
2626
        # FIXME: we want some iterator over all options, failing that, we peek
2627
        # under the cover -- vila 2011-09026
2628
        self.assertLength(0, self.section.options)
2629
2630
    def test_simple_override(self):
2631
        self.section._from_cmdline(['a=b'])
2632
        self.assertEqual('b', self.section.get('a'))
2633
2634
    def test_list_override(self):
2635
        self.section._from_cmdline(['l=1,2,3'])
2636
        val = self.section.get('l')
2637
        self.assertEqual('1,2,3', val)
2638
        # Reminder: lists should registered as such explicitely, otherwise the
2639
        # conversion needs to be done afterwards.
2640
        self.assertEqual(['1', '2', '3'], config.list_from_store(val))
2641
2642
    def test_multiple_overrides(self):
2643
        self.section._from_cmdline(['a=b', 'x=y'])
2644
        self.assertEquals('b', self.section.get('a'))
2645
        self.assertEquals('y', self.section.get('x'))
2646
2647
    def test_wrong_syntax(self):
2648
        self.assertRaises(errors.BzrCommandError,
2649
                          self.section._from_cmdline, ['a=b', 'c'])
2650
2651
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2652
class TestStore(tests.TestCaseWithTransport):
2653
2654
    def assertSectionContent(self, expected, section):
2655
        """Assert that some options have the proper values in a section."""
2656
        expected_name, expected_options = expected
2657
        self.assertEquals(expected_name, section.id)
2658
        self.assertEquals(
2659
            expected_options,
2660
            dict([(k, section.get(k)) for k in expected_options.keys()]))
2661
2662
2663
class TestReadonlyStore(TestStore):
2664
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2665
    scenarios = [(key, {'get_store': builder}) for key, builder
2666
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2667
2668
    def test_building_delays_load(self):
2669
        store = self.get_store(self)
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2670
        self.assertEquals(False, store.is_loaded())
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2671
        store._load_from_string('')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2672
        self.assertEquals(True, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2673
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2674
    def test_get_no_sections_for_empty(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2675
        store = self.get_store(self)
2676
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2677
        self.assertEquals([], list(store.get_sections()))
2678
2679
    def test_get_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2680
        store = self.get_store(self)
2681
        store._load_from_string('foo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2682
        sections = list(store.get_sections())
2683
        self.assertLength(1, sections)
2684
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2685
2686
    def test_get_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2687
        store = self.get_store(self)
2688
        store._load_from_string('[baz]\nfoo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2689
        sections = list(store.get_sections())
2690
        self.assertLength(1, sections)
2691
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2692
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2693
    def test_load_from_string_fails_for_non_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2694
        store = self.get_store(self)
2695
        store._load_from_string('foo=bar')
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2696
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
2697
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2698
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2699
class TestIniFileStoreContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2700
    """Simulate loading a config store with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2701
2702
    All files produced by bzr are in utf8 content.
2703
2704
    Users may modify them manually and end up with a file that can't be
2705
    loaded. We need to issue proper error messages in this case.
2706
    """
2707
2708
    invalid_utf8_char = '\xff'
2709
2710
    def test_load_utf8(self):
2711
        """Ensure we can load an utf8-encoded file."""
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2712
        t = self.get_transport()
2713
        # From http://pad.lv/799212
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2714
        unicode_user = u'b\N{Euro Sign}ar'
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2715
        unicode_content = u'user=%s' % (unicode_user,)
2716
        utf8_content = unicode_content.encode('utf8')
2717
        # Store the raw content in the config file
2718
        t.put_bytes('foo.conf', utf8_content)
2719
        store = config.IniFileStore(t, 'foo.conf')
2720
        store.load()
2721
        stack = config.Stack([store.get_sections], store)
2722
        self.assertEquals(unicode_user, stack.get('user'))
2723
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2724
    def test_load_non_ascii(self):
2725
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2726
        t = self.get_transport()
2727
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
2728
        store = config.IniFileStore(t, 'foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2729
        self.assertRaises(errors.ConfigContentError, store.load)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2730
2731
    def test_load_erroneous_content(self):
2732
        """Ensure we display a proper error on content that can't be parsed."""
2733
        t = self.get_transport()
2734
        t.put_bytes('foo.conf', '[open_section\n')
2735
        store = config.IniFileStore(t, 'foo.conf')
2736
        self.assertRaises(errors.ParseConfigError, store.load)
2737
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2738
    def test_load_permission_denied(self):
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2739
        """Ensure we get warned when trying to load an inaccessible file."""
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2740
        warnings = []
2741
        def warning(*args):
2742
            warnings.append(args[0] % args[1:])
2743
        self.overrideAttr(trace, 'warning', warning)
2744
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2745
        t = self.get_transport()
2746
2747
        def get_bytes(relpath):
2748
            raise errors.PermissionDenied(relpath, "")
2749
        t.get_bytes = get_bytes
2750
        store = config.IniFileStore(t, 'foo.conf')
2751
        self.assertRaises(errors.PermissionDenied, store.load)
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2752
        self.assertEquals(
2753
            warnings,
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2754
            [u'Permission denied while trying to load configuration store %s.'
2755
             % store.external_url()])
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2756
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2757
2758
class TestIniConfigContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2759
    """Simulate loading a IniBasedConfig with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2760
2761
    All files produced by bzr are in utf8 content.
2762
2763
    Users may modify them manually and end up with a file that can't be
2764
    loaded. We need to issue proper error messages in this case.
2765
    """
2766
2767
    invalid_utf8_char = '\xff'
2768
2769
    def test_load_utf8(self):
2770
        """Ensure we can load an utf8-encoded file."""
2771
        # From http://pad.lv/799212
2772
        unicode_user = u'b\N{Euro Sign}ar'
2773
        unicode_content = u'user=%s' % (unicode_user,)
2774
        utf8_content = unicode_content.encode('utf8')
2775
        # Store the raw content in the config file
2776
        with open('foo.conf', 'wb') as f:
2777
            f.write(utf8_content)
2778
        conf = config.IniBasedConfig(file_name='foo.conf')
2779
        self.assertEquals(unicode_user, conf.get_user_option('user'))
2780
2781
    def test_load_badly_encoded_content(self):
2782
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2783
        with open('foo.conf', 'wb') as f:
2784
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
2785
        conf = config.IniBasedConfig(file_name='foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2786
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2787
2788
    def test_load_erroneous_content(self):
2789
        """Ensure we display a proper error on content that can't be parsed."""
2790
        with open('foo.conf', 'wb') as f:
2791
            f.write('[open_section\n')
2792
        conf = config.IniBasedConfig(file_name='foo.conf')
2793
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
2794
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2795
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2796
class TestMutableStore(TestStore):
2797
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2798
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
2799
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2800
2801
    def setUp(self):
2802
        super(TestMutableStore, self).setUp()
2803
        self.transport = self.get_transport()
2804
2805
    def has_store(self, store):
2806
        store_basename = urlutils.relative_url(self.transport.external_url(),
2807
                                               store.external_url())
2808
        return self.transport.has(store_basename)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2809
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2810
    def test_save_empty_creates_no_file(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2811
        # FIXME: There should be a better way than relying on the test
2812
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2813
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2814
            raise tests.TestNotApplicable(
2815
                'branch.conf is *always* created when a branch is initialized')
2816
        store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2817
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2818
        self.assertEquals(False, self.has_store(store))
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2819
2820
    def test_save_emptied_succeeds(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2821
        store = self.get_store(self)
2822
        store._load_from_string('foo=bar\n')
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2823
        section = store.get_mutable_section(None)
2824
        section.remove('foo')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2825
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2826
        self.assertEquals(True, self.has_store(store))
2827
        modified_store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2828
        sections = list(modified_store.get_sections())
2829
        self.assertLength(0, sections)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2830
2831
    def test_save_with_content_succeeds(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2832
        # FIXME: There should be a better way than relying on the test
2833
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2834
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2835
            raise tests.TestNotApplicable(
2836
                'branch.conf is *always* created when a branch is initialized')
2837
        store = self.get_store(self)
2838
        store._load_from_string('foo=bar\n')
2839
        self.assertEquals(False, self.has_store(store))
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2840
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2841
        self.assertEquals(True, self.has_store(store))
2842
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2843
        sections = list(modified_store.get_sections())
2844
        self.assertLength(1, sections)
2845
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2846
2847
    def test_set_option_in_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2848
        store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2849
        section = store.get_mutable_section(None)
2850
        section.set('foo', 'bar')
2851
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2852
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2853
        sections = list(modified_store.get_sections())
2854
        self.assertLength(1, sections)
2855
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2856
2857
    def test_set_option_in_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2858
        store = self.get_store(self)
2859
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2860
        section = store.get_mutable_section(None)
2861
        section.set('foo', 'bar')
2862
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2863
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2864
        sections = list(modified_store.get_sections())
2865
        self.assertLength(1, sections)
2866
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2867
2868
    def test_set_option_in_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2869
        store = self.get_store(self)
2870
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2871
        section = store.get_mutable_section('baz')
2872
        section.set('foo', 'bar')
2873
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2874
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2875
        sections = list(modified_store.get_sections())
2876
        self.assertLength(1, sections)
2877
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2878
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2879
    def test_load_hook(self):
2880
        # We first needs to ensure that the store exists
2881
        store = self.get_store(self)
2882
        section = store.get_mutable_section('baz')
2883
        section.set('foo', 'bar')
2884
        store.save()
2885
        # Now we can try to load it
5743.8.11 by Vincent Ladeuil
Restrict the scope when testing hooks to avoid spurious failures.
2886
        store = self.get_store(self)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2887
        calls = []
2888
        def hook(*args):
2889
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2890
        config.ConfigHooks.install_named_hook('load', hook, None)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2891
        self.assertLength(0, calls)
2892
        store.load()
2893
        self.assertLength(1, calls)
2894
        self.assertEquals((store,), calls[0])
2895
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2896
    def test_save_hook(self):
2897
        calls = []
2898
        def hook(*args):
2899
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2900
        config.ConfigHooks.install_named_hook('save', hook, None)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2901
        self.assertLength(0, calls)
2902
        store = self.get_store(self)
2903
        section = store.get_mutable_section('baz')
2904
        section.set('foo', 'bar')
2905
        store.save()
2906
        self.assertLength(1, calls)
2907
        self.assertEquals((store,), calls[0])
2908
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2909
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2910
class TestIniFileStore(TestStore):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2911
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
2912
    def test_loading_unknown_file_fails(self):
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2913
        store = config.IniFileStore(self.get_transport(), 'I-do-not-exist')
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
2914
        self.assertRaises(errors.NoSuchFile, store.load)
2915
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2916
    def test_invalid_content(self):
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2917
        store = config.IniFileStore(self.get_transport(), 'foo.conf', )
2918
        self.assertEquals(False, store.is_loaded())
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2919
        exc = self.assertRaises(
2920
            errors.ParseConfigError, store._load_from_string,
2921
            'this is invalid !')
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2922
        self.assertEndsWith(exc.filename, 'foo.conf')
2923
        # And the load failed
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2924
        self.assertEquals(False, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2925
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2926
    def test_get_embedded_sections(self):
5743.2.11 by Vincent Ladeuil
Basic store.set implementation.
2927
        # A more complicated example (which also shows that section names and
2928
        # option names share the same name space...)
5743.4.7 by Vincent Ladeuil
The test is now specific to ConfigObjStore and highlight a pending problem there.
2929
        # FIXME: This should be fixed by forbidding dicts as values ?
2930
        # -- vila 2011-04-05
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2931
        store = config.IniFileStore(self.get_transport(), 'foo.conf', )
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2932
        store._load_from_string('''
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2933
foo=bar
2934
l=1,2
2935
[DEFAULT]
2936
foo_in_DEFAULT=foo_DEFAULT
2937
[bar]
2938
foo_in_bar=barbar
2939
[baz]
2940
foo_in_baz=barbaz
2941
[[qux]]
2942
foo_in_qux=quux
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2943
''')
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2944
        sections = list(store.get_sections())
2945
        self.assertLength(4, sections)
2946
        # The default section has no name.
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
2947
        # List values are provided as strings and need to be explicitly
2948
        # converted by specifying from_unicode=list_from_store at option
2949
        # registration
2950
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
2951
                                  sections[0])
2952
        self.assertSectionContent(
2953
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
2954
        self.assertSectionContent(
2955
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2956
        # sub sections are provided as embedded dicts.
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
2957
        self.assertSectionContent(
2958
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
2959
            sections[3])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2960
5743.4.5 by Vincent Ladeuil
Split store tests between readonly and mutable ones.
2961
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2962
class TestLockableIniFileStore(TestStore):
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2963
2964
    def test_create_store_in_created_dir(self):
5743.6.21 by Vincent Ladeuil
Tighten the test.
2965
        self.assertPathDoesNotExist('dir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2966
        t = self.get_transport('dir/subdir')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2967
        store = config.LockableIniFileStore(t, 'foo.conf')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2968
        store.get_mutable_section(None).set('foo', 'bar')
2969
        store.save()
5743.6.21 by Vincent Ladeuil
Tighten the test.
2970
        self.assertPathExists('dir/subdir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2971
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2972
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2973
class TestConcurrentStoreUpdates(TestStore):
5743.10.13 by Vincent Ladeuil
Mention that the the concurrent update tests are not targeted at *all* Store implementations.
2974
    """Test that Stores properly handle conccurent updates.
2975
2976
    New Store implementation may fail some of these tests but until such
2977
    implementations exist it's hard to properly filter them from the scenarios
2978
    applied here. If you encounter such a case, contact the bzr devs.
2979
    """
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2980
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2981
    scenarios = [(key, {'get_stack': builder}) for key, builder
2982
                 in config.test_stack_builder_registry.iteritems()]
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2983
2984
    def setUp(self):
2985
        super(TestConcurrentStoreUpdates, self).setUp()
2986
        self._content = 'one=1\ntwo=2\n'
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2987
        self.stack = self.get_stack(self)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2988
        if not isinstance(self.stack, config._CompatibleStack):
2989
            raise tests.TestNotApplicable(
2990
                '%s is not meant to be compatible with the old config design'
2991
                % (self.stack,))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2992
        self.stack.store._load_from_string(self._content)
2993
        # Flush the store
2994
        self.stack.store.save()
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2995
2996
    def test_simple_read_access(self):
2997
        self.assertEquals('1', self.stack.get('one'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2998
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2999
    def test_simple_write_access(self):
3000
        self.stack.set('one', 'one')
3001
        self.assertEquals('one', self.stack.get('one'))
3002
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3003
    def test_listen_to_the_last_speaker(self):
3004
        c1 = self.stack
3005
        c2 = self.get_stack(self)
3006
        c1.set('one', 'ONE')
3007
        c2.set('two', 'TWO')
3008
        self.assertEquals('ONE', c1.get('one'))
3009
        self.assertEquals('TWO', c2.get('two'))
3010
        # The second update respect the first one
3011
        self.assertEquals('ONE', c2.get('one'))
3012
3013
    def test_last_speaker_wins(self):
3014
        # If the same config is not shared, the same variable modified twice
3015
        # can only see a single result.
3016
        c1 = self.stack
3017
        c2 = self.get_stack(self)
3018
        c1.set('one', 'c1')
3019
        c2.set('one', 'c2')
3020
        self.assertEquals('c2', c2.get('one'))
3021
        # The first modification is still available until another refresh
3022
        # occur
3023
        self.assertEquals('c1', c1.get('one'))
3024
        c1.set('two', 'done')
3025
        self.assertEquals('c2', c1.get('one'))
3026
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3027
    def test_writes_are_serialized(self):
3028
        c1 = self.stack
3029
        c2 = self.get_stack(self)
3030
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3031
        # We spawn a thread that will pause *during* the config saving.
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3032
        before_writing = threading.Event()
3033
        after_writing = threading.Event()
3034
        writing_done = threading.Event()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3035
        c1_save_without_locking_orig = c1.store.save_without_locking
3036
        def c1_save_without_locking():
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3037
            before_writing.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3038
            c1_save_without_locking_orig()
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3039
            # The lock is held. We wait for the main thread to decide when to
3040
            # continue
3041
            after_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3042
        c1.store.save_without_locking = c1_save_without_locking
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3043
        def c1_set():
3044
            c1.set('one', 'c1')
3045
            writing_done.set()
3046
        t1 = threading.Thread(target=c1_set)
3047
        # Collect the thread after the test
3048
        self.addCleanup(t1.join)
3049
        # Be ready to unblock the thread if the test goes wrong
3050
        self.addCleanup(after_writing.set)
3051
        t1.start()
3052
        before_writing.wait()
3053
        self.assertRaises(errors.LockContention,
3054
                          c2.set, 'one', 'c2')
3055
        self.assertEquals('c1', c1.get('one'))
3056
        # Let the lock be released
3057
        after_writing.set()
3058
        writing_done.wait()
3059
        c2.set('one', 'c2')
3060
        self.assertEquals('c2', c2.get('one'))
3061
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3062
    def test_read_while_writing(self):
3063
       c1 = self.stack
3064
       # We spawn a thread that will pause *during* the write
3065
       ready_to_write = threading.Event()
3066
       do_writing = threading.Event()
3067
       writing_done = threading.Event()
3068
       # We override the _save implementation so we know the store is locked
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3069
       c1_save_without_locking_orig = c1.store.save_without_locking
3070
       def c1_save_without_locking():
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3071
           ready_to_write.set()
3072
           # The lock is held. We wait for the main thread to decide when to
3073
           # continue
3074
           do_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3075
           c1_save_without_locking_orig()
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3076
           writing_done.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3077
       c1.store.save_without_locking = c1_save_without_locking
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3078
       def c1_set():
3079
           c1.set('one', 'c1')
3080
       t1 = threading.Thread(target=c1_set)
3081
       # Collect the thread after the test
3082
       self.addCleanup(t1.join)
3083
       # Be ready to unblock the thread if the test goes wrong
3084
       self.addCleanup(do_writing.set)
3085
       t1.start()
3086
       # Ensure the thread is ready to write
3087
       ready_to_write.wait()
3088
       self.assertEquals('c1', c1.get('one'))
3089
       # If we read during the write, we get the old value
3090
       c2 = self.get_stack(self)
3091
       self.assertEquals('1', c2.get('one'))
3092
       # Let the writing occur and ensure it occurred
3093
       do_writing.set()
3094
       writing_done.wait()
3095
       # Now we get the updated value
3096
       c3 = self.get_stack(self)
3097
       self.assertEquals('c1', c3.get('one'))
3098
3099
    # FIXME: It may be worth looking into removing the lock dir when it's not
3100
    # needed anymore and look at possible fallouts for concurrent lockers. This
3101
    # will matter if/when we use config files outside of bazaar directories
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3102
    # (.bazaar or .bzr) -- vila 20110-04-111
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3103
3104
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3105
class TestSectionMatcher(TestStore):
3106
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3107
    scenarios = [('location', {'matcher': config.LocationMatcher}),
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3108
                 ('id', {'matcher': config.NameMatcher}),]
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3109
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3110
    def get_store(self, file_name):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3111
        return config.IniFileStore(self.get_readonly_transport(), file_name)
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3112
3113
    def test_no_matches_for_empty_stores(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3114
        store = self.get_store('foo.conf')
3115
        store._load_from_string('')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3116
        matcher = self.matcher(store, '/bar')
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3117
        self.assertEquals([], list(matcher.get_sections()))
3118
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3119
    def test_build_doesnt_load_store(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3120
        store = self.get_store('foo.conf')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3121
        matcher = self.matcher(store, '/bar')
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3122
        self.assertFalse(store.is_loaded())
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3123
3124
3125
class TestLocationSection(tests.TestCase):
3126
3127
    def get_section(self, options, extra_path):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3128
        section = config.Section('foo', options)
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3129
        # We don't care about the length so we use '0'
3130
        return config.LocationSection(section, 0, extra_path)
3131
3132
    def test_simple_option(self):
3133
        section = self.get_section({'foo': 'bar'}, '')
3134
        self.assertEquals('bar', section.get('foo'))
3135
3136
    def test_option_with_extra_path(self):
3137
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
3138
                                   'baz')
3139
        self.assertEquals('bar/baz', section.get('foo'))
3140
3141
    def test_invalid_policy(self):
3142
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
3143
                                   'baz')
3144
        # invalid policies are ignored
3145
        self.assertEquals('bar', section.get('foo'))
3146
3147
3148
class TestLocationMatcher(TestStore):
3149
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3150
    def get_store(self, file_name):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3151
        return config.IniFileStore(self.get_readonly_transport(), file_name)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3152
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3153
    def test_unrelated_section_excluded(self):
3154
        store = self.get_store('foo.conf')
3155
        store._load_from_string('''
3156
[/foo]
3157
section=/foo
3158
[/foo/baz]
3159
section=/foo/baz
3160
[/foo/bar]
3161
section=/foo/bar
3162
[/foo/bar/baz]
3163
section=/foo/bar/baz
3164
[/quux/quux]
3165
section=/quux/quux
3166
''')
3167
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
3168
                           '/quux/quux'],
3169
                          [section.id for section in store.get_sections()])
3170
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
3171
        sections = list(matcher.get_sections())
3172
        self.assertEquals([3, 2],
3173
                          [section.length for section in sections])
3174
        self.assertEquals(['/foo/bar', '/foo'],
3175
                          [section.id for section in sections])
3176
        self.assertEquals(['quux', 'bar/quux'],
3177
                          [section.extra_path for section in sections])
3178
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3179
    def test_more_specific_sections_first(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3180
        store = self.get_store('foo.conf')
3181
        store._load_from_string('''
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3182
[/foo]
3183
section=/foo
3184
[/foo/bar]
3185
section=/foo/bar
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3186
''')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3187
        self.assertEquals(['/foo', '/foo/bar'],
3188
                          [section.id for section in store.get_sections()])
3189
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
3190
        sections = list(matcher.get_sections())
3191
        self.assertEquals([3, 2],
3192
                          [section.length for section in sections])
3193
        self.assertEquals(['/foo/bar', '/foo'],
3194
                          [section.id for section in sections])
3195
        self.assertEquals(['baz', 'bar/baz'],
3196
                          [section.extra_path for section in sections])
3197
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3198
    def test_appendpath_in_no_name_section(self):
3199
        # It's a bit weird to allow appendpath in a no-name section, but
3200
        # someone may found a use for it
3201
        store = self.get_store('foo.conf')
3202
        store._load_from_string('''
3203
foo=bar
3204
foo:policy = appendpath
3205
''')
3206
        matcher = config.LocationMatcher(store, 'dir/subdir')
3207
        sections = list(matcher.get_sections())
3208
        self.assertLength(1, sections)
3209
        self.assertEquals('bar/dir/subdir', sections[0].get('foo'))
3210
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3211
    def test_file_urls_are_normalized(self):
3212
        store = self.get_store('foo.conf')
5912.3.1 by Vincent Ladeuil
Fix spurious windows-specific test failure
3213
        if sys.platform == 'win32':
3214
            expected_url = 'file:///C:/dir/subdir'
3215
            expected_location = 'C:/dir/subdir'
3216
        else:
3217
            expected_url = 'file:///dir/subdir'
3218
            expected_location = '/dir/subdir'
3219
        matcher = config.LocationMatcher(store, expected_url)
3220
        self.assertEquals(expected_location, matcher.location)
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3221
5743.1.20 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3222
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3223
class TestNameMatcher(TestStore):
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3224
3225
    def setUp(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3226
        super(TestNameMatcher, self).setUp()
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3227
        self.store = config.IniFileStore(self.get_readonly_transport(),
3228
                                         'foo.conf')
3229
        self.store._load_from_string('''
3230
[foo]
3231
option=foo
3232
[foo/baz]
3233
option=foo/baz
3234
[bar]
3235
option=bar
3236
''')
3237
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3238
    def get_matching_sections(self, name):
3239
        matcher = config.NameMatcher(self.store, name)
3240
        return list(matcher.get_sections())
3241
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3242
    def test_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3243
        sections = self.get_matching_sections('foo')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3244
        self.assertLength(1, sections)
3245
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
3246
3247
    def test_not_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3248
        sections = self.get_matching_sections('baz')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3249
        self.assertLength(0, sections)
3250
3251
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3252
class TestStackGet(tests.TestCase):
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3253
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3254
    # FIXME: This should be parametrized for all known Stack or dedicated
5743.1.3 by Vincent Ladeuil
Don't forget to parametrized for people *providing* new stacks.
3255
    # paramerized tests created to avoid bloating -- vila 2011-03-31
3256
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3257
    def overrideOptionRegistry(self):
3258
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3259
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3260
    def test_single_config_get(self):
3261
        conf = dict(foo='bar')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3262
        conf_stack = config.Stack([conf])
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3263
        self.assertEquals('bar', conf_stack.get('foo'))
3264
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3265
    def test_get_with_registered_default_value(self):
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
3266
        conf_stack = config.Stack([dict()])
3267
        opt = config.Option('foo', default='bar')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3268
        self.overrideOptionRegistry()
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
3269
        config.option_registry.register('foo', opt)
3270
        self.assertEquals('bar', conf_stack.get('foo'))
3271
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3272
    def test_get_without_registered_default_value(self):
3273
        conf_stack = config.Stack([dict()])
3274
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3275
        self.overrideOptionRegistry()
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3276
        config.option_registry.register('foo', opt)
3277
        self.assertEquals(None, conf_stack.get('foo'))
3278
3279
    def test_get_without_default_value_for_not_registered(self):
3280
        conf_stack = config.Stack([dict()])
3281
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3282
        self.overrideOptionRegistry()
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3283
        self.assertEquals(None, conf_stack.get('foo'))
3284
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3285
    def test_get_first_definition(self):
3286
        conf1 = dict(foo='bar')
3287
        conf2 = dict(foo='baz')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3288
        conf_stack = config.Stack([conf1, conf2])
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3289
        self.assertEquals('bar', conf_stack.get('foo'))
3290
5743.1.2 by Vincent Ladeuil
Stacks can be used as read-only sections.
3291
    def test_get_embedded_definition(self):
3292
        conf1 = dict(yy='12')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3293
        conf2 = config.Stack([dict(xx='42'), dict(foo='baz')])
3294
        conf_stack = config.Stack([conf1, conf2])
5743.1.2 by Vincent Ladeuil
Stacks can be used as read-only sections.
3295
        self.assertEquals('baz', conf_stack.get('foo'))
3296
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3297
    def test_get_for_empty_section_callable(self):
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3298
        conf_stack = config.Stack([lambda : []])
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3299
        self.assertEquals(None, conf_stack.get('foo'))
3300
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3301
    def test_get_for_broken_callable(self):
3302
        # Trying to use and invalid callable raises an exception on first use
3303
        conf_stack = config.Stack([lambda : object()])
3304
        self.assertRaises(TypeError, conf_stack.get, 'foo')
3305
3306
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3307
class TestStackWithTransport(tests.TestCaseWithTransport):
3308
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3309
    scenarios = [(key, {'get_stack': builder}) for key, builder
3310
                 in config.test_stack_builder_registry.iteritems()]
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3311
3312
5743.11.1 by Vincent Ladeuil
Add a note about config store builders being called several times by some tests.
3313
class TestConcreteStacks(TestStackWithTransport):
3314
3315
    def test_build_stack(self):
3316
        # Just a smoke test to help debug builders
3317
        stack = self.get_stack(self)
3318
3319
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3320
class TestStackGet(TestStackWithTransport):
3321
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3322
    def setUp(self):
3323
        super(TestStackGet, self).setUp()
3324
        self.conf = self.get_stack(self)
3325
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3326
    def test_get_for_empty_stack(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3327
        self.assertEquals(None, self.conf.get('foo'))
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3328
3329
    def test_get_hook(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3330
        self.conf.store._load_from_string('foo=bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3331
        calls = []
3332
        def hook(*args):
3333
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3334
        config.ConfigHooks.install_named_hook('get', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3335
        self.assertLength(0, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3336
        value = self.conf.get('foo')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3337
        self.assertEquals('bar', value)
3338
        self.assertLength(1, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3339
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
3340
3341
3342
class TestStackGetWithConverter(TestStackGet):
3343
3344
    def setUp(self):
3345
        super(TestStackGetWithConverter, self).setUp()
3346
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3347
        self.registry = config.option_registry
3348
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3349
    def register_bool_option(self, name, default=None, default_from_env=None):
3350
        b = config.Option(name, help='A boolean.',
3351
                          default=default, default_from_env=default_from_env,
3352
                          from_unicode=config.bool_from_store)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3353
        self.registry.register(b)
3354
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3355
    def test_get_default_bool_None(self):
3356
        self.register_bool_option('foo')
3357
        self.assertEquals(None, self.conf.get('foo'))
3358
3359
    def test_get_default_bool_True(self):
3360
        self.register_bool_option('foo', u'True')
3361
        self.assertEquals(True, self.conf.get('foo'))
3362
3363
    def test_get_default_bool_False(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3364
        self.register_bool_option('foo', False)
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3365
        self.assertEquals(False, self.conf.get('foo'))
3366
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3367
    def test_get_default_bool_False_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3368
        self.register_bool_option('foo', u'False')
3369
        self.assertEquals(False, self.conf.get('foo'))
3370
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3371
    def test_get_default_bool_from_env_converted(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3372
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
3373
        self.overrideEnv('FOO', 'False')
3374
        self.assertEquals(False, self.conf.get('foo'))
3375
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3376
    def test_get_default_bool_when_conversion_fails(self):
3377
        self.register_bool_option('foo', default='True')
3378
        self.conf.store._load_from_string('foo=invalid boolean')
3379
        self.assertEquals(True, self.conf.get('foo'))
3380
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3381
    def register_integer_option(self, name,
3382
                                default=None, default_from_env=None):
3383
        i = config.Option(name, help='An integer.',
3384
                          default=default, default_from_env=default_from_env,
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3385
                          from_unicode=config.int_from_store)
3386
        self.registry.register(i)
3387
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3388
    def test_get_default_integer_None(self):
3389
        self.register_integer_option('foo')
3390
        self.assertEquals(None, self.conf.get('foo'))
3391
3392
    def test_get_default_integer(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3393
        self.register_integer_option('foo', 42)
3394
        self.assertEquals(42, self.conf.get('foo'))
3395
3396
    def test_get_default_integer_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3397
        self.register_integer_option('foo', u'42')
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3398
        self.assertEquals(42, self.conf.get('foo'))
3399
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3400
    def test_get_default_integer_from_env(self):
3401
        self.register_integer_option('foo', default_from_env=['FOO'])
3402
        self.overrideEnv('FOO', '18')
3403
        self.assertEquals(18, self.conf.get('foo'))
3404
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3405
    def test_get_default_integer_when_conversion_fails(self):
3406
        self.register_integer_option('foo', default='12')
3407
        self.conf.store._load_from_string('foo=invalid integer')
3408
        self.assertEquals(12, self.conf.get('foo'))
3409
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3410
    def register_list_option(self, name, default=None, default_from_env=None):
3411
        l = config.Option(name, help='A list.',
3412
                          default=default, default_from_env=default_from_env,
6059.2.1 by Vincent Ladeuil
Implement list config options.
3413
                          from_unicode=config.list_from_store)
3414
        self.registry.register(l)
3415
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3416
    def test_get_default_list_None(self):
3417
        self.register_list_option('foo')
3418
        self.assertEquals(None, self.conf.get('foo'))
3419
3420
    def test_get_default_list_empty(self):
3421
        self.register_list_option('foo', '')
6059.2.1 by Vincent Ladeuil
Implement list config options.
3422
        self.assertEquals([], self.conf.get('foo'))
3423
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3424
    def test_get_default_list_from_env(self):
3425
        self.register_list_option('foo', default_from_env=['FOO'])
3426
        self.overrideEnv('FOO', '')
6059.2.1 by Vincent Ladeuil
Implement list config options.
3427
        self.assertEquals([], self.conf.get('foo'))
3428
3429
    def test_get_with_list_converter_no_item(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3430
        self.register_list_option('foo', None)
6059.2.1 by Vincent Ladeuil
Implement list config options.
3431
        self.conf.store._load_from_string('foo=,')
3432
        self.assertEquals([], self.conf.get('foo'))
3433
3434
    def test_get_with_list_converter_many_items(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3435
        self.register_list_option('foo', None)
6059.2.1 by Vincent Ladeuil
Implement list config options.
3436
        self.conf.store._load_from_string('foo=m,o,r,e')
3437
        self.assertEquals(['m', 'o', 'r', 'e'], self.conf.get('foo'))
3438
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3439
    def test_get_with_list_converter_embedded_spaces_many_items(self):
3440
        self.register_list_option('foo', None)
3441
        self.conf.store._load_from_string('foo=" bar", "baz "')
3442
        self.assertEquals([' bar', 'baz '], self.conf.get('foo'))
3443
3444
    def test_get_with_list_converter_stripped_spaces_many_items(self):
3445
        self.register_list_option('foo', None)
3446
        self.conf.store._load_from_string('foo= bar ,  baz ')
3447
        self.assertEquals(['bar', 'baz'], self.conf.get('foo'))
3448
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3449
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3450
class TestStackExpandOptions(tests.TestCaseWithTransport):
3451
3452
    def setUp(self):
3453
        super(TestStackExpandOptions, self).setUp()
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3454
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3455
        self.registry = config.option_registry
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3456
        self.conf = build_branch_stack(self)
3457
3458
    def assertExpansion(self, expected, string, env=None):
3459
        self.assertEquals(expected, self.conf.expand_options(string, env))
3460
3461
    def test_no_expansion(self):
3462
        self.assertExpansion('foo', 'foo')
3463
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3464
    def test_expand_default_value(self):
3465
        self.conf.store._load_from_string('bar=baz')
3466
        self.registry.register(config.Option('foo', default=u'{bar}'))
3467
        self.assertEquals('baz', self.conf.get('foo', expand=True))
3468
3469
    def test_expand_default_from_env(self):
3470
        self.conf.store._load_from_string('bar=baz')
3471
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
3472
        self.overrideEnv('FOO', '{bar}')
3473
        self.assertEquals('baz', self.conf.get('foo', expand=True))
3474
3475
    def test_expand_default_on_failed_conversion(self):
3476
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
3477
        self.registry.register(
3478
            config.Option('foo', default=u'{bar}',
3479
                          from_unicode=config.int_from_store))
3480
        self.assertEquals(42, self.conf.get('foo', expand=True))
3481
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3482
    def test_env_adding_options(self):
3483
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3484
3485
    def test_env_overriding_options(self):
3486
        self.conf.store._load_from_string('foo=baz')
3487
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3488
3489
    def test_simple_ref(self):
3490
        self.conf.store._load_from_string('foo=xxx')
3491
        self.assertExpansion('xxx', '{foo}')
3492
3493
    def test_unknown_ref(self):
3494
        self.assertRaises(errors.ExpandingUnknownOption,
3495
                          self.conf.expand_options, '{foo}')
3496
3497
    def test_indirect_ref(self):
3498
        self.conf.store._load_from_string('''
3499
foo=xxx
3500
bar={foo}
3501
''')
3502
        self.assertExpansion('xxx', '{bar}')
3503
3504
    def test_embedded_ref(self):
3505
        self.conf.store._load_from_string('''
3506
foo=xxx
3507
bar=foo
3508
''')
3509
        self.assertExpansion('xxx', '{{bar}}')
3510
3511
    def test_simple_loop(self):
3512
        self.conf.store._load_from_string('foo={foo}')
3513
        self.assertRaises(errors.OptionExpansionLoop,
3514
                          self.conf.expand_options, '{foo}')
3515
3516
    def test_indirect_loop(self):
3517
        self.conf.store._load_from_string('''
3518
foo={bar}
3519
bar={baz}
3520
baz={foo}''')
3521
        e = self.assertRaises(errors.OptionExpansionLoop,
3522
                              self.conf.expand_options, '{foo}')
3523
        self.assertEquals('foo->bar->baz', e.refs)
3524
        self.assertEquals('{foo}', e.string)
3525
3526
    def test_list(self):
3527
        self.conf.store._load_from_string('''
3528
foo=start
3529
bar=middle
3530
baz=end
3531
list={foo},{bar},{baz}
3532
''')
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3533
        self.registry.register(
3534
            config.Option('list', from_unicode=config.list_from_store))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3535
        self.assertEquals(['start', 'middle', 'end'],
3536
                           self.conf.get('list', expand=True))
3537
3538
    def test_cascading_list(self):
3539
        self.conf.store._load_from_string('''
3540
foo=start,{bar}
3541
bar=middle,{baz}
3542
baz=end
3543
list={foo}
3544
''')
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3545
        self.registry.register(
3546
            config.Option('list', from_unicode=config.list_from_store))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3547
        self.assertEquals(['start', 'middle', 'end'],
3548
                           self.conf.get('list', expand=True))
3549
3550
    def test_pathologically_hidden_list(self):
3551
        self.conf.store._load_from_string('''
3552
foo=bin
3553
bar=go
3554
start={foo
3555
middle=},{
3556
end=bar}
3557
hidden={start}{middle}{end}
3558
''')
6082.5.13 by Vincent Ladeuil
Fix typos.
3559
        # What matters is what the registration says, the conversion happens
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3560
        # only after all expansions have been performed
3561
        self.registry.register(
3562
            config.Option('hidden', from_unicode=config.list_from_store))
3563
        self.assertEquals(['bin', 'go'],
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3564
                          self.conf.get('hidden', expand=True))
3565
3566
3567
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
3568
3569
    def setUp(self):
3570
        super(TestStackCrossSectionsExpand, self).setUp()
3571
3572
    def get_config(self, location, string):
3573
        if string is None:
3574
            string = ''
3575
        # Since we don't save the config we won't strictly require to inherit
3576
        # from TestCaseInTempDir, but an error occurs so quickly...
3577
        c = config.LocationStack(location)
3578
        c.store._load_from_string(string)
3579
        return c
3580
3581
    def test_dont_cross_unrelated_section(self):
3582
        c = self.get_config('/another/branch/path','''
3583
[/one/branch/path]
3584
foo = hello
3585
bar = {foo}/2
3586
3587
[/another/branch/path]
3588
bar = {foo}/2
3589
''')
3590
        self.assertRaises(errors.ExpandingUnknownOption,
3591
                          c.get, 'bar', expand=True)
3592
3593
    def test_cross_related_sections(self):
3594
        c = self.get_config('/project/branch/path','''
3595
[/project]
3596
foo = qu
3597
3598
[/project/branch/path]
3599
bar = {foo}ux
3600
''')
3601
        self.assertEquals('quux', c.get('bar', expand=True))
3602
3603
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3604
class TestStackSet(TestStackWithTransport):
3605
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3606
    def test_simple_set(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3607
        conf = self.get_stack(self)
3608
        conf.store._load_from_string('foo=bar')
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3609
        self.assertEquals('bar', conf.get('foo'))
3610
        conf.set('foo', 'baz')
3611
        # Did we get it back ?
3612
        self.assertEquals('baz', conf.get('foo'))
3613
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3614
    def test_set_creates_a_new_section(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3615
        conf = self.get_stack(self)
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3616
        conf.set('foo', 'baz')
5743.1.9 by Vincent Ladeuil
Fix the issue by allowing delayed section acquisition.
3617
        self.assertEquals, 'baz', conf.get('foo')
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3618
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3619
    def test_set_hook(self):
3620
        calls = []
3621
        def hook(*args):
3622
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3623
        config.ConfigHooks.install_named_hook('set', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3624
        self.assertLength(0, calls)
3625
        conf = self.get_stack(self)
3626
        conf.set('foo', 'bar')
3627
        self.assertLength(1, calls)
3628
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
3629
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3630
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3631
class TestStackRemove(TestStackWithTransport):
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3632
3633
    def test_remove_existing(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3634
        conf = self.get_stack(self)
3635
        conf.store._load_from_string('foo=bar')
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3636
        self.assertEquals('bar', conf.get('foo'))
3637
        conf.remove('foo')
3638
        # Did we get it back ?
3639
        self.assertEquals(None, conf.get('foo'))
3640
3641
    def test_remove_unknown(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3642
        conf = self.get_stack(self)
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3643
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
3644
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3645
    def test_remove_hook(self):
3646
        calls = []
3647
        def hook(*args):
3648
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3649
        config.ConfigHooks.install_named_hook('remove', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3650
        self.assertLength(0, calls)
3651
        conf = self.get_stack(self)
3652
        conf.store._load_from_string('foo=bar')
3653
        conf.remove('foo')
3654
        self.assertLength(1, calls)
3655
        self.assertEquals((conf, 'foo'), calls[0])
3656
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3657
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
3658
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3659
3660
    def setUp(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3661
        super(TestConfigGetOptions, self).setUp()
3662
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3663
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3664
    def test_no_variable(self):
3665
        # Using branch should query branch, locations and bazaar
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3666
        self.assertOptions([], self.branch_config)
3667
3668
    def test_option_in_bazaar(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3669
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3670
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3671
                           self.bazaar_config)
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3672
3673
    def test_option_in_locations(self):
3674
        self.locations_config.set_user_option('file', 'locations')
3675
        self.assertOptions(
3676
            [('file', 'locations', self.tree.basedir, 'locations')],
3677
            self.locations_config)
3678
3679
    def test_option_in_branch(self):
3680
        self.branch_config.set_user_option('file', 'branch')
3681
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
3682
                           self.branch_config)
3683
3684
    def test_option_in_bazaar_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3685
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3686
        self.branch_config.set_user_option('file', 'branch')
3687
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
3688
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3689
                           self.branch_config)
3690
3691
    def test_option_in_branch_and_locations(self):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3692
        # Hmm, locations override branch :-/
3693
        self.locations_config.set_user_option('file', 'locations')
3694
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3695
        self.assertOptions(
3696
            [('file', 'locations', self.tree.basedir, 'locations'),
3697
             ('file', 'branch', 'DEFAULT', 'branch'),],
3698
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3699
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3700
    def test_option_in_bazaar_locations_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3701
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3702
        self.locations_config.set_user_option('file', 'locations')
3703
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3704
        self.assertOptions(
3705
            [('file', 'locations', self.tree.basedir, 'locations'),
3706
             ('file', 'branch', 'DEFAULT', 'branch'),
3707
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3708
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3709
3710
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
3711
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3712
3713
    def setUp(self):
3714
        super(TestConfigRemoveOption, self).setUp()
3715
        create_configs_with_file_option(self)
3716
5447.4.11 by Vincent Ladeuil
Implement ``bzr config --remove <option>``.
3717
    def test_remove_in_locations(self):
3718
        self.locations_config.remove_user_option('file', self.tree.basedir)
3719
        self.assertOptions(
3720
            [('file', 'branch', 'DEFAULT', 'branch'),
3721
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3722
            self.branch_config)
3723
3724
    def test_remove_in_branch(self):
3725
        self.branch_config.remove_user_option('file')
3726
        self.assertOptions(
3727
            [('file', 'locations', self.tree.basedir, 'locations'),
3728
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3729
            self.branch_config)
3730
3731
    def test_remove_in_bazaar(self):
3732
        self.bazaar_config.remove_user_option('file')
3733
        self.assertOptions(
3734
            [('file', 'locations', self.tree.basedir, 'locations'),
3735
             ('file', 'branch', 'DEFAULT', 'branch'),],
3736
            self.branch_config)
3737
5447.4.7 by Vincent Ladeuil
Check error message if the test is checking for errors or we have unexpected success for wrong errors.
3738
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3739
class TestConfigGetSections(tests.TestCaseWithTransport):
3740
3741
    def setUp(self):
3742
        super(TestConfigGetSections, self).setUp()
3743
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3744
3745
    def assertSectionNames(self, expected, conf, name=None):
3746
        """Check which sections are returned for a given config.
3747
3748
        If fallback configurations exist their sections can be included.
3749
3750
        :param expected: A list of section names.
3751
3752
        :param conf: The configuration that will be queried.
3753
3754
        :param name: An optional section name that will be passed to
3755
            get_sections().
3756
        """
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
3757
        sections = list(conf._get_sections(name))
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3758
        self.assertLength(len(expected), sections)
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
3759
        self.assertEqual(expected, [name for name, _, _ in sections])
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3760
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3761
    def test_bazaar_default_section(self):
3762
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3763
3764
    def test_locations_default_section(self):
3765
        # No sections are defined in an empty file
3766
        self.assertSectionNames([], self.locations_config)
3767
3768
    def test_locations_named_section(self):
3769
        self.locations_config.set_user_option('file', 'locations')
3770
        self.assertSectionNames([self.tree.basedir], self.locations_config)
3771
3772
    def test_locations_matching_sections(self):
3773
        loc_config = self.locations_config
3774
        loc_config.set_user_option('file', 'locations')
3775
        # We need to cheat a bit here to create an option in sections above and
3776
        # below the 'location' one.
3777
        parser = loc_config._get_parser()
3778
        # locations.cong deals with '/' ignoring native os.sep
3779
        location_names = self.tree.basedir.split('/')
3780
        parent = '/'.join(location_names[:-1])
3781
        child = '/'.join(location_names + ['child'])
3782
        parser[parent] = {}
3783
        parser[parent]['file'] = 'parent'
3784
        parser[child] = {}
3785
        parser[child]['file'] = 'child'
3786
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
3787
3788
    def test_branch_data_default_section(self):
3789
        self.assertSectionNames([None],
3790
                                self.branch_config._get_branch_data_config())
3791
3792
    def test_branch_default_sections(self):
3793
        # No sections are defined in an empty locations file
3794
        self.assertSectionNames([None, 'DEFAULT'],
3795
                                self.branch_config)
3796
        # Unless we define an option
3797
        self.branch_config._get_location_config().set_user_option(
3798
            'file', 'locations')
3799
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
3800
                                self.branch_config)
3801
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3802
    def test_bazaar_named_section(self):
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3803
        # We need to cheat as the API doesn't give direct access to sections
3804
        # other than DEFAULT.
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3805
        self.bazaar_config.set_alias('bazaar', 'bzr')
3806
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3807
3808
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
3809
class TestAuthenticationConfigFile(tests.TestCase):
2900.2.14 by Vincent Ladeuil
More tests.
3810
    """Test the authentication.conf file matching"""
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3811
3812
    def _got_user_passwd(self, expected_user, expected_password,
3813
                         config, *args, **kwargs):
3814
        credentials = config.get_credentials(*args, **kwargs)
3815
        if credentials is None:
3816
            user = None
3817
            password = None
3818
        else:
3819
            user = credentials['user']
3820
            password = credentials['password']
3821
        self.assertEquals(expected_user, user)
3822
        self.assertEquals(expected_password, password)
3823
2978.5.1 by John Arbash Meinel
Fix bug #162494, 'bzr register-branch' needs proper auth handling.
3824
    def test_empty_config(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3825
        conf = config.AuthenticationConfig(_file=StringIO())
3826
        self.assertEquals({}, conf._get_config())
3827
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
3828
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
3829
    def test_non_utf8_config(self):
3830
        conf = config.AuthenticationConfig(_file=StringIO(
3831
                'foo = bar\xff'))
5987.1.3 by Vincent Ladeuil
Proper message when authentication.conf has non-utf8 content
3832
        self.assertRaises(errors.ConfigContentError, conf._get_config)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3833
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3834
    def test_missing_auth_section_header(self):
3835
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
3836
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3837
3838
    def test_auth_section_header_not_closed(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3839
        conf = config.AuthenticationConfig(_file=StringIO('[DEF'))
3840
        self.assertRaises(errors.ParseConfigError, conf._get_config)
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
3841
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3842
    def test_auth_value_not_boolean(self):
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
3843
        conf = config.AuthenticationConfig(_file=StringIO(
3844
                """[broken]
3845
scheme=ftp
3846
user=joe
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
3847
verify_certificates=askme # Error: Not a boolean
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
3848
"""))
3849
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3850
3851
    def test_auth_value_not_int(self):
2900.2.22 by Vincent Ladeuil
Polishing.
3852
        conf = config.AuthenticationConfig(_file=StringIO(
3853
                """[broken]
3854
scheme=ftp
3855
user=joe
3856
port=port # Error: Not an int
3857
"""))
3858
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3859
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
3860
    def test_unknown_password_encoding(self):
3861
        conf = config.AuthenticationConfig(_file=StringIO(
3862
                """[broken]
3863
scheme=ftp
3864
user=joe
3865
password_encoding=unknown
3866
"""))
3867
        self.assertRaises(ValueError, conf.get_password,
3868
                          'ftp', 'foo.net', 'joe')
3869
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3870
    def test_credentials_for_scheme_host(self):
3871
        conf = config.AuthenticationConfig(_file=StringIO(
3872
                """# Identity on foo.net
3873
[ftp definition]
3874
scheme=ftp
3875
host=foo.net
3876
user=joe
3877
password=secret-pass
3878
"""))
3879
        # Basic matching
3880
        self._got_user_passwd('joe', 'secret-pass', conf, 'ftp', 'foo.net')
3881
        # different scheme
3882
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
3883
        # different host
3884
        self._got_user_passwd(None, None, conf, 'ftp', 'bar.net')
3885
3886
    def test_credentials_for_host_port(self):
3887
        conf = config.AuthenticationConfig(_file=StringIO(
3888
                """# Identity on foo.net
3889
[ftp definition]
3890
scheme=ftp
3891
port=10021
3892
host=foo.net
3893
user=joe
3894
password=secret-pass
3895
"""))
3896
        # No port
3897
        self._got_user_passwd('joe', 'secret-pass',
3898
                              conf, 'ftp', 'foo.net', port=10021)
3899
        # different port
3900
        self._got_user_passwd(None, None, conf, 'ftp', 'foo.net')
3901
3902
    def test_for_matching_host(self):
3903
        conf = config.AuthenticationConfig(_file=StringIO(
3904
                """# Identity on foo.net
3905
[sourceforge]
3906
scheme=bzr
3907
host=bzr.sf.net
3908
user=joe
3909
password=joepass
3910
[sourceforge domain]
3911
scheme=bzr
3912
host=.bzr.sf.net
3913
user=georges
3914
password=bendover
3915
"""))
3916
        # matching domain
3917
        self._got_user_passwd('georges', 'bendover',
3918
                              conf, 'bzr', 'foo.bzr.sf.net')
3919
        # phishing attempt
3920
        self._got_user_passwd(None, None,
3921
                              conf, 'bzr', 'bbzr.sf.net')
3922
3923
    def test_for_matching_host_None(self):
3924
        conf = config.AuthenticationConfig(_file=StringIO(
3925
                """# Identity on foo.net
3926
[catchup bzr]
3927
scheme=bzr
3928
user=joe
3929
password=joepass
3930
[DEFAULT]
3931
user=georges
3932
password=bendover
3933
"""))
3934
        # match no host
3935
        self._got_user_passwd('joe', 'joepass',
3936
                              conf, 'bzr', 'quux.net')
3937
        # no host but different scheme
3938
        self._got_user_passwd('georges', 'bendover',
3939
                              conf, 'ftp', 'quux.net')
3940
3941
    def test_credentials_for_path(self):
3942
        conf = config.AuthenticationConfig(_file=StringIO(
3943
                """
3944
[http dir1]
3945
scheme=http
3946
host=bar.org
3947
path=/dir1
3948
user=jim
3949
password=jimpass
3950
[http dir2]
3951
scheme=http
3952
host=bar.org
3953
path=/dir2
3954
user=georges
3955
password=bendover
3956
"""))
3957
        # no path no dice
3958
        self._got_user_passwd(None, None,
3959
                              conf, 'http', host='bar.org', path='/dir3')
3960
        # matching path
3961
        self._got_user_passwd('georges', 'bendover',
3962
                              conf, 'http', host='bar.org', path='/dir2')
3963
        # matching subdir
3964
        self._got_user_passwd('jim', 'jimpass',
3965
                              conf, 'http', host='bar.org',path='/dir1/subdir')
3966
3967
    def test_credentials_for_user(self):
3968
        conf = config.AuthenticationConfig(_file=StringIO(
3969
                """
3970
[with user]
3971
scheme=http
3972
host=bar.org
3973
user=jim
3974
password=jimpass
3975
"""))
3976
        # Get user
3977
        self._got_user_passwd('jim', 'jimpass',
3978
                              conf, 'http', 'bar.org')
3979
        # Get same user
3980
        self._got_user_passwd('jim', 'jimpass',
3981
                              conf, 'http', 'bar.org', user='jim')
3982
        # Don't get a different user if one is specified
3983
        self._got_user_passwd(None, None,
3984
                              conf, 'http', 'bar.org', user='georges')
3985
3418.4.1 by Vincent Ladeuil
Reproduce bug 199440.
3986
    def test_credentials_for_user_without_password(self):
3987
        conf = config.AuthenticationConfig(_file=StringIO(
3988
                """
3989
[without password]
3990
scheme=http
3991
host=bar.org
3992
user=jim
3993
"""))
3994
        # Get user but no password
3995
        self._got_user_passwd('jim', None,
3996
                              conf, 'http', 'bar.org')
3997
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3998
    def test_verify_certificates(self):
3999
        conf = config.AuthenticationConfig(_file=StringIO(
4000
                """
4001
[self-signed]
4002
scheme=https
4003
host=bar.org
4004
user=jim
4005
password=jimpass
4006
verify_certificates=False
4007
[normal]
4008
scheme=https
4009
host=foo.net
4010
user=georges
4011
password=bendover
4012
"""))
4013
        credentials = conf.get_credentials('https', 'bar.org')
4014
        self.assertEquals(False, credentials.get('verify_certificates'))
4015
        credentials = conf.get_credentials('https', 'foo.net')
4016
        self.assertEquals(True, credentials.get('verify_certificates'))
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4017
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4018
4019
class TestAuthenticationStorage(tests.TestCaseInTempDir):
4020
3777.1.8 by Aaron Bentley
Commit work-in-progress
4021
    def test_set_credentials(self):
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4022
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4023
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4024
        99, path='/foo', verify_certificates=False, realm='realm')
3777.1.8 by Aaron Bentley
Commit work-in-progress
4025
        credentials = conf.get_credentials(host='host', scheme='scheme',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4026
                                           port=99, path='/foo',
4027
                                           realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4028
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4029
                       'verify_certificates': False, 'scheme': 'scheme', 
4030
                       'host': 'host', 'port': 99, 'path': '/foo', 
4031
                       'realm': 'realm'}
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4032
        self.assertEqual(CREDENTIALS, credentials)
4033
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4034
            host='host', scheme='scheme', port=99, path='/foo', realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4035
        self.assertEqual(CREDENTIALS, credentials_from_disk)
3777.1.8 by Aaron Bentley
Commit work-in-progress
4036
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4037
    def test_reset_credentials_different_name(self):
4038
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4039
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password'),
4040
        conf.set_credentials('name2', 'host', 'user2', 'scheme', 'password'),
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4041
        self.assertIs(None, conf._get_config().get('name'))
4042
        credentials = conf.get_credentials(host='host', scheme='scheme')
4043
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4044
                       'password', 'verify_certificates': True, 
4045
                       'scheme': 'scheme', 'host': 'host', 'port': None, 
4046
                       'path': None, 'realm': None}
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4047
        self.assertEqual(CREDENTIALS, credentials)
4048
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4049
2900.2.14 by Vincent Ladeuil
More tests.
4050
class TestAuthenticationConfig(tests.TestCase):
4051
    """Test AuthenticationConfig behaviour"""
4052
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4053
    def _check_default_password_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4054
                                       host=None, port=None, realm=None,
4055
                                       path=None):
2900.2.14 by Vincent Ladeuil
More tests.
4056
        if host is None:
4057
            host = 'bar.org'
4058
        user, password = 'jim', 'precious'
4059
        expected_prompt = expected_prompt_format % {
4060
            'scheme': scheme, 'host': host, 'port': port,
4061
            'user': user, 'realm': realm}
4062
4063
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4064
        stderr = tests.StringIOWrapper()
2900.2.14 by Vincent Ladeuil
More tests.
4065
        ui.ui_factory = tests.TestUIFactory(stdin=password + '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4066
                                            stdout=stdout, stderr=stderr)
2900.2.14 by Vincent Ladeuil
More tests.
4067
        # We use an empty conf so that the user is always prompted
4068
        conf = config.AuthenticationConfig()
4069
        self.assertEquals(password,
4070
                          conf.get_password(scheme, host, user, port=port,
4071
                                            realm=realm, path=path))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4072
        self.assertEquals(expected_prompt, stderr.getvalue())
4073
        self.assertEquals('', stdout.getvalue())
2900.2.14 by Vincent Ladeuil
More tests.
4074
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4075
    def _check_default_username_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4076
                                       host=None, port=None, realm=None,
4077
                                       path=None):
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4078
        if host is None:
4079
            host = 'bar.org'
4080
        username = 'jim'
4081
        expected_prompt = expected_prompt_format % {
4082
            'scheme': scheme, 'host': host, 'port': port,
4083
            'realm': realm}
4084
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4085
        stderr = tests.StringIOWrapper()
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4086
        ui.ui_factory = tests.TestUIFactory(stdin=username+ '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4087
                                            stdout=stdout, stderr=stderr)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4088
        # We use an empty conf so that the user is always prompted
4089
        conf = config.AuthenticationConfig()
4222.3.5 by Jelmer Vernooij
Fix test.
4090
        self.assertEquals(username, conf.get_user(scheme, host, port=port,
4091
                          realm=realm, path=path, ask=True))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4092
        self.assertEquals(expected_prompt, stderr.getvalue())
4093
        self.assertEquals('', stdout.getvalue())
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4094
4095
    def test_username_defaults_prompts(self):
4096
        # HTTP prompts can't be tested here, see test_http.py
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4097
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
4098
        self._check_default_username_prompt(
4099
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
4100
        self._check_default_username_prompt(
4101
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4102
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4103
    def test_username_default_no_prompt(self):
4104
        conf = config.AuthenticationConfig()
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
4105
        self.assertEquals(None,
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4106
            conf.get_user('ftp', 'example.com'))
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
4107
        self.assertEquals("explicitdefault",
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4108
            conf.get_user('ftp', 'example.com', default="explicitdefault"))
4109
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4110
    def test_password_default_prompts(self):
2900.2.19 by Vincent Ladeuil
Mention proxy and https in the password prompts, with tests.
4111
        # HTTP prompts can't be tested here, see test_http.py
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4112
        self._check_default_password_prompt(
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4113
            u'FTP %(user)s@%(host)s password: ', 'ftp')
4114
        self._check_default_password_prompt(
4115
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
4116
        self._check_default_password_prompt(
4117
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
2900.2.14 by Vincent Ladeuil
More tests.
4118
        # SMTP port handling is a bit special (it's handled if embedded in the
4119
        # host too)
2900.2.22 by Vincent Ladeuil
Polishing.
4120
        # FIXME: should we: forbid that, extend it to other schemes, leave
4121
        # things as they are that's fine thank you ?
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4122
        self._check_default_password_prompt(
4123
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
4124
        self._check_default_password_prompt(
4125
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
4126
        self._check_default_password_prompt(
4127
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
2900.2.14 by Vincent Ladeuil
More tests.
4128
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4129
    def test_ssh_password_emits_warning(self):
4130
        conf = config.AuthenticationConfig(_file=StringIO(
4131
                """
4132
[ssh with password]
4133
scheme=ssh
4134
host=bar.org
4135
user=jim
4136
password=jimpass
4137
"""))
4138
        entered_password = 'typed-by-hand'
4139
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4140
        stderr = tests.StringIOWrapper()
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4141
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4142
                                            stdout=stdout, stderr=stderr)
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4143
4144
        # Since the password defined in the authentication config is ignored,
4145
        # the user is prompted
4146
        self.assertEquals(entered_password,
4147
                          conf.get_password('ssh', 'bar.org', user='jim'))
4148
        self.assertContainsRe(
4794.1.17 by Robert Collins
Fix from vila for type log_log.
4149
            self.get_log(),
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4150
            'password ignored in section \[ssh with password\]')
4151
3420.1.3 by Vincent Ladeuil
John's review feedback.
4152
    def test_ssh_without_password_doesnt_emit_warning(self):
4153
        conf = config.AuthenticationConfig(_file=StringIO(
4154
                """
4155
[ssh with password]
4156
scheme=ssh
4157
host=bar.org
4158
user=jim
4159
"""))
4160
        entered_password = 'typed-by-hand'
4161
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4162
        stderr = tests.StringIOWrapper()
3420.1.3 by Vincent Ladeuil
John's review feedback.
4163
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4164
                                            stdout=stdout,
4165
                                            stderr=stderr)
3420.1.3 by Vincent Ladeuil
John's review feedback.
4166
4167
        # Since the password defined in the authentication config is ignored,
4168
        # the user is prompted
4169
        self.assertEquals(entered_password,
4170
                          conf.get_password('ssh', 'bar.org', user='jim'))
3420.1.4 by Vincent Ladeuil
Fix comment.
4171
        # No warning shoud be emitted since there is no password. We are only
4172
        # providing "user".
3420.1.3 by Vincent Ladeuil
John's review feedback.
4173
        self.assertNotContainsRe(
4794.1.15 by Robert Collins
Review feedback.
4174
            self.get_log(),
3420.1.3 by Vincent Ladeuil
John's review feedback.
4175
            'password ignored in section \[ssh with password\]')
4176
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4177
    def test_uses_fallback_stores(self):
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
4178
        self.overrideAttr(config, 'credential_store_registry',
4179
                          config.CredentialStoreRegistry())
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4180
        store = StubCredentialStore()
4181
        store.add_credentials("http", "example.com", "joe", "secret")
4182
        config.credential_store_registry.register("stub", store, fallback=True)
4183
        conf = config.AuthenticationConfig(_file=StringIO())
4184
        creds = conf.get_credentials("http", "example.com")
4185
        self.assertEquals("joe", creds["user"])
4186
        self.assertEquals("secret", creds["password"])
4187
2900.2.14 by Vincent Ladeuil
More tests.
4188
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4189
class StubCredentialStore(config.CredentialStore):
4190
4191
    def __init__(self):
4192
        self._username = {}
4193
        self._password = {}
4194
4195
    def add_credentials(self, scheme, host, user, password=None):
4196
        self._username[(scheme, host)] = user
4197
        self._password[(scheme, host)] = password
4198
4199
    def get_credentials(self, scheme, host, port=None, user=None,
4200
        path=None, realm=None):
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4201
        key = (scheme, host)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4202
        if not key in self._username:
4203
            return None
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4204
        return { "scheme": scheme, "host": host, "port": port,
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4205
                "user": self._username[key], "password": self._password[key]}
4206
4207
4208
class CountingCredentialStore(config.CredentialStore):
4209
4210
    def __init__(self):
4211
        self._calls = 0
4212
4213
    def get_credentials(self, scheme, host, port=None, user=None,
4214
        path=None, realm=None):
4215
        self._calls += 1
4216
        return None
4217
4218
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4219
class TestCredentialStoreRegistry(tests.TestCase):
4220
4221
    def _get_cs_registry(self):
4222
        return config.credential_store_registry
4223
4224
    def test_default_credential_store(self):
4225
        r = self._get_cs_registry()
4226
        default = r.get_credential_store(None)
4227
        self.assertIsInstance(default, config.PlainTextCredentialStore)
4228
4229
    def test_unknown_credential_store(self):
4230
        r = self._get_cs_registry()
4231
        # It's hard to imagine someone creating a credential store named
4232
        # 'unknown' so we use that as an never registered key.
4233
        self.assertRaises(KeyError, r.get_credential_store, 'unknown')
4234
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4235
    def test_fallback_none_registered(self):
4236
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4237
        self.assertEquals(None,
4238
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4239
4240
    def test_register(self):
4241
        r = config.CredentialStoreRegistry()
4242
        r.register("stub", StubCredentialStore(), fallback=False)
4243
        r.register("another", StubCredentialStore(), fallback=True)
4244
        self.assertEquals(["another", "stub"], r.keys())
4245
4246
    def test_register_lazy(self):
4247
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4248
        r.register_lazy("stub", "bzrlib.tests.test_config",
4249
                        "StubCredentialStore", fallback=False)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4250
        self.assertEquals(["stub"], r.keys())
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4251
        self.assertIsInstance(r.get_credential_store("stub"),
4252
                              StubCredentialStore)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4253
4254
    def test_is_fallback(self):
4255
        r = config.CredentialStoreRegistry()
4256
        r.register("stub1", None, fallback=False)
4257
        r.register("stub2", None, fallback=True)
4258
        self.assertEquals(False, r.is_fallback("stub1"))
4259
        self.assertEquals(True, r.is_fallback("stub2"))
4260
4261
    def test_no_fallback(self):
4262
        r = config.CredentialStoreRegistry()
4263
        store = CountingCredentialStore()
4264
        r.register("count", store, fallback=False)
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4265
        self.assertEquals(None,
4266
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4267
        self.assertEquals(0, store._calls)
4268
4269
    def test_fallback_credentials(self):
4270
        r = config.CredentialStoreRegistry()
4271
        store = StubCredentialStore()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4272
        store.add_credentials("http", "example.com",
4273
                              "somebody", "geheim")
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4274
        r.register("stub", store, fallback=True)
4275
        creds = r.get_fallback_credentials("http", "example.com")
4276
        self.assertEquals("somebody", creds["user"])
4277
        self.assertEquals("geheim", creds["password"])
4278
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4279
    def test_fallback_first_wins(self):
4280
        r = config.CredentialStoreRegistry()
4281
        stub1 = StubCredentialStore()
4282
        stub1.add_credentials("http", "example.com",
4283
                              "somebody", "stub1")
4284
        r.register("stub1", stub1, fallback=True)
4285
        stub2 = StubCredentialStore()
4286
        stub2.add_credentials("http", "example.com",
4287
                              "somebody", "stub2")
4288
        r.register("stub2", stub1, fallback=True)
4289
        creds = r.get_fallback_credentials("http", "example.com")
4290
        self.assertEquals("somebody", creds["user"])
4291
        self.assertEquals("stub1", creds["password"])
4292
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4293
4294
class TestPlainTextCredentialStore(tests.TestCase):
4295
4296
    def test_decode_password(self):
4297
        r = config.credential_store_registry
4298
        plain_text = r.get_credential_store()
4299
        decoded = plain_text.decode_password(dict(password='secret'))
4300
        self.assertEquals('secret', decoded)
4301
4302
2900.2.14 by Vincent Ladeuil
More tests.
4303
# FIXME: Once we have a way to declare authentication to all test servers, we
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4304
# can implement generic tests.
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4305
# test_user_password_in_url
4306
# test_user_in_url_password_from_config
4307
# test_user_in_url_password_prompted
4308
# test_user_in_config
4309
# test_user_getpass.getuser
4310
# test_user_prompted ?
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4311
class TestAuthenticationRing(tests.TestCaseWithTransport):
4312
    pass
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4313
4314
4315
class TestAutoUserId(tests.TestCase):
4316
    """Test inferring an automatic user name."""
4317
4318
    def test_auto_user_id(self):
4319
        """Automatic inference of user name.
4320
        
4321
        This is a bit hard to test in an isolated way, because it depends on
4322
        system functions that go direct to /etc or perhaps somewhere else.
4323
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
4324
        to be able to choose a user name with no configuration.
4325
        """
4326
        if sys.platform == 'win32':
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
4327
            raise tests.TestSkipped(
4328
                "User name inference not implemented on win32")
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4329
        realname, address = config._auto_user_id()
4330
        if os.path.exists('/etc/mailname'):
5813.1.1 by Jelmer Vernooij
Allow realname to be empty in tests.
4331
            self.assertIsNot(None, realname)
4332
            self.assertIsNot(None, address)
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4333
        else:
4334
            self.assertEquals((None, None), (realname, address))
4335