5609.52.1
by Martin Pool
Cope with buggy squids interrupting the response before a mime multipart boundary |
1 |
# Copyright (C) 2006-2011 Canonical Ltd
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
2 |
#
|
3 |
# This program is free software; you can redistribute it and/or modify
|
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
7 |
#
|
|
8 |
# This program is distributed in the hope that it will be useful,
|
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
12 |
#
|
|
13 |
# You should have received a copy of the GNU General Public License
|
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
16 |
|
17 |
"""Handlers for HTTP Responses.
|
|
18 |
||
19 |
The purpose of these classes is to provide a uniform interface for clients
|
|
20 |
to standard HTTP responses, single range responses and multipart range
|
|
21 |
responses.
|
|
22 |
"""
|
|
23 |
||
24 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
25 |
import httplib |
3408.6.1
by Eric Holmberg
Fix for Bug #215426 in which bzr can cause a MemoryError in socket.recv while |
26 |
from cStringIO import StringIO |
3535.1.2
by Adrian Wilkins
Fix ability to use IIS as a dumb HTTP server. |
27 |
import rfc822 |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
28 |
|
29 |
from bzrlib import ( |
|
30 |
errors, |
|
31 |
trace, |
|
3408.6.1
by Eric Holmberg
Fix for Bug #215426 in which bzr can cause a MemoryError in socket.recv while |
32 |
osutils, |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
33 |
)
|
34 |
||
35 |
||
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
36 |
# A RangeFile expects the following grammar (simplified to outline the
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
37 |
# assumptions we rely upon).
|
38 |
||
39 |
# file: whole_file
|
|
40 |
# | single_range
|
|
41 |
# | multiple_range
|
|
42 |
||
43 |
# whole_file: [content_length_header] data
|
|
44 |
||
45 |
# single_range: content_range_header data
|
|
46 |
||
47 |
# multiple_range: boundary_header boundary (content_range_header data boundary)+
|
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
48 |
|
49 |
class RangeFile(object): |
|
1786.1.8
by John Arbash Meinel
[merge] Johan Rydberg test updates |
50 |
"""File-like object that allow access to partial available data.
|
51 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
52 |
All accesses should happen sequentially since the acquisition occurs during
|
53 |
an http response reception (as sockets can't be seeked, we simulate the
|
|
54 |
seek by just reading and discarding the data).
|
|
55 |
||
56 |
The access pattern is defined by a set of ranges discovered as reading
|
|
57 |
progress. Only one range is available at a given time, so all accesses
|
|
58 |
should happen with monotonically increasing offsets.
|
|
1786.1.8
by John Arbash Meinel
[merge] Johan Rydberg test updates |
59 |
"""
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
60 |
|
3146.3.4
by Vincent Ladeuil
Review feedback, simpler loops. |
61 |
# in _checked_read() below, we may have to discard several MB in the worst
|
62 |
# case. To avoid buffering that much, we read and discard by chunks
|
|
63 |
# instead. The underlying file is either a socket or a StringIO, so reading
|
|
64 |
# 8k chunks should be fine.
|
|
65 |
_discarded_buf_size = 8192 |
|
66 |
||
3408.6.1
by Eric Holmberg
Fix for Bug #215426 in which bzr can cause a MemoryError in socket.recv while |
67 |
# maximum size of read requests -- used to avoid MemoryError issues in recv
|
68 |
_max_read_size = 512 * 1024 |
|
69 |
||
3945.1.8
by Vincent Ladeuil
Add more tests, fix pycurl double handling, revert previous tracking. |
70 |
def __init__(self, path, infile): |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
71 |
"""Constructor.
|
72 |
||
73 |
:param path: File url, for error reports.
|
|
74 |
:param infile: File-like socket set at body start.
|
|
75 |
"""
|
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
76 |
self._path = path |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
77 |
self._file = infile |
78 |
self._boundary = None |
|
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
79 |
# When using multi parts response, this will be set with the headers
|
80 |
# associated with the range currently read.
|
|
81 |
self._headers = None |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
82 |
# Default to the whole file of unspecified size
|
83 |
self.set_range(0, -1) |
|
84 |
||
85 |
def set_range(self, start, size): |
|
86 |
"""Change the range mapping"""
|
|
87 |
self._start = start |
|
88 |
self._size = size |
|
89 |
# Set the new _pos since that's what we want to expose
|
|
90 |
self._pos = self._start |
|
91 |
||
92 |
def set_boundary(self, boundary): |
|
93 |
"""Define the boundary used in a multi parts message.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
94 |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
95 |
The file should be at the beginning of the body, the first range
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
96 |
definition is read and taken into account.
|
97 |
"""
|
|
98 |
self._boundary = boundary |
|
99 |
# Decode the headers and setup the first range
|
|
100 |
self.read_boundary() |
|
101 |
self.read_range_definition() |
|
102 |
||
103 |
def read_boundary(self): |
|
104 |
"""Read the boundary headers defining a new range"""
|
|
105 |
boundary_line = '\r\n' |
|
106 |
while boundary_line == '\r\n': |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
107 |
# RFC2616 19.2 Additional CRLFs may precede the first boundary
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
108 |
# string entity.
|
109 |
# To be on the safe side we allow it before any boundary line
|
|
110 |
boundary_line = self._file.readline() |
|
3535.1.4
by adwi2
Changes as suggested by Mr Ladeuil. |
111 |
|
5609.52.1
by Martin Pool
Cope with buggy squids interrupting the response before a mime multipart boundary |
112 |
if boundary_line == '': |
113 |
# A timeout in the proxy server caused the response to end early.
|
|
114 |
# See launchpad bug 198646.
|
|
115 |
raise errors.HttpBoundaryMissing( |
|
116 |
self._path, |
|
117 |
self._boundary) |
|
118 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
119 |
if boundary_line != '--' + self._boundary + '\r\n': |
3535.1.3
by adwi2
Fix ability to use IIS as a dumb HTTP server by unquoting the boundary |
120 |
# rfc822.unquote() incorrectly unquotes strings enclosed in <>
|
121 |
# IIS 6 and 7 incorrectly wrap boundary strings in <>
|
|
122 |
# together they make a beautiful bug, which we will be gracious
|
|
123 |
# about here
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
124 |
if (self._unquote_boundary(boundary_line) != |
3535.1.4
by adwi2
Changes as suggested by Mr Ladeuil. |
125 |
'--' + self._boundary + '\r\n'): |
3535.1.3
by adwi2
Fix ability to use IIS as a dumb HTTP server by unquoting the boundary |
126 |
raise errors.InvalidHttpResponse( |
127 |
self._path, |
|
3537.1.1
by Vincent Ladeuil
Fix some more PEP8isms and delete useless import |
128 |
"Expected a boundary (%s) line, got '%s'" |
129 |
% (self._boundary, boundary_line)) |
|
130 |
||
3535.1.2
by Adrian Wilkins
Fix ability to use IIS as a dumb HTTP server. |
131 |
def _unquote_boundary(self, b): |
132 |
return b[:2] + rfc822.unquote(b[2:-2]) + b[-2:] |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
133 |
|
134 |
def read_range_definition(self): |
|
135 |
"""Read a new range definition in a multi parts message.
|
|
136 |
||
137 |
Parse the headers including the empty line following them so that we
|
|
138 |
are ready to read the data itself.
|
|
139 |
"""
|
|
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
140 |
self._headers = httplib.HTTPMessage(self._file, seekable=0) |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
141 |
# Extract the range definition
|
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
142 |
content_range = self._headers.getheader('content-range', None) |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
143 |
if content_range is None: |
144 |
raise errors.InvalidHttpResponse( |
|
145 |
self._path, |
|
146 |
'Content-Range header missing in a multi-part response') |
|
147 |
self.set_range_from_header(content_range) |
|
148 |
||
149 |
def set_range_from_header(self, content_range): |
|
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
150 |
"""Helper to set the new range from its description in the headers"""
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
151 |
try: |
152 |
rtype, values = content_range.split() |
|
3059.2.10
by Vincent Ladeuil
Jam's review feedback. |
153 |
except ValueError: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
154 |
raise errors.InvalidHttpRange(self._path, content_range, |
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
155 |
'Malformed header') |
3059.2.11
by Vincent Ladeuil
Fix typos mentioned by spiv. |
156 |
if rtype != 'bytes': |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
157 |
raise errors.InvalidHttpRange(self._path, content_range, |
158 |
"Unsupported range type '%s'" % rtype) |
|
159 |
try: |
|
160 |
# We don't need total, but note that it may be either the file size
|
|
161 |
# or '*' if the server can't or doesn't want to return the file
|
|
162 |
# size.
|
|
163 |
start_end, total = values.split('/') |
|
164 |
start, end = start_end.split('-') |
|
165 |
start = int(start) |
|
166 |
end = int(end) |
|
3059.2.10
by Vincent Ladeuil
Jam's review feedback. |
167 |
except ValueError: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
168 |
raise errors.InvalidHttpRange(self._path, content_range, |
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
169 |
'Invalid range values') |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
170 |
size = end - start + 1 |
171 |
if size <= 0: |
|
172 |
raise errors.InvalidHttpRange(self._path, content_range, |
|
3059.2.17
by Vincent Ladeuil
Limit GET requests by body size instead of number of ranges. |
173 |
'Invalid range, size <= 0') |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
174 |
self.set_range(start, size) |
175 |
||
176 |
def _checked_read(self, size): |
|
3146.3.2
by Vincent Ladeuil
Fix #179368 by keeping the current range hint on ShortReadvErrors. |
177 |
"""Read the file checking for short reads.
|
178 |
||
179 |
The data read is discarded along the way.
|
|
180 |
"""
|
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
181 |
pos = self._pos |
3146.3.4
by Vincent Ladeuil
Review feedback, simpler loops. |
182 |
remaining = size |
183 |
while remaining > 0: |
|
184 |
data = self._file.read(min(remaining, self._discarded_buf_size)) |
|
185 |
remaining -= len(data) |
|
186 |
if not data: |
|
187 |
raise errors.ShortReadvError(self._path, pos, size, |
|
188 |
size - remaining) |
|
189 |
self._pos += size |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
190 |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
191 |
def _seek_to_next_range(self): |
192 |
# We will cross range boundaries
|
|
193 |
if self._boundary is None: |
|
194 |
# If we don't have a boundary, we can't find another range
|
|
3146.3.2
by Vincent Ladeuil
Fix #179368 by keeping the current range hint on ShortReadvErrors. |
195 |
raise errors.InvalidRange(self._path, self._pos, |
196 |
"Range (%s, %s) exhausted" |
|
197 |
% (self._start, self._size)) |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
198 |
self.read_boundary() |
199 |
self.read_range_definition() |
|
200 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
201 |
def read(self, size=-1): |
3408.6.3
by Andrew Bennetts
Docstring/NEWS tweaks requested by Ian's review. |
202 |
"""Read size bytes from the current position in the file.
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
203 |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
204 |
Reading across ranges is not supported. We rely on the underlying http
|
205 |
client to clean the socket if we leave bytes unread. This may occur for
|
|
206 |
the final boundary line of a multipart response or for any range
|
|
207 |
request not entirely consumed by the client (due to offset coalescing)
|
|
3408.6.3
by Andrew Bennetts
Docstring/NEWS tweaks requested by Ian's review. |
208 |
|
209 |
:param size: The number of bytes to read. Leave unspecified or pass
|
|
210 |
-1 to read to EOF.
|
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
211 |
"""
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
212 |
if (self._size > 0 |
213 |
and self._pos == self._start + self._size): |
|
214 |
if size == 0: |
|
215 |
return '' |
|
216 |
else: |
|
217 |
self._seek_to_next_range() |
|
218 |
elif self._pos < self._start: |
|
219 |
raise errors.InvalidRange( |
|
220 |
self._path, self._pos, |
|
221 |
"Can't read %s bytes before range (%s, %s)" |
|
222 |
% (size, self._start, self._size)) |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
223 |
if self._size > 0: |
224 |
if size > 0 and self._pos + size > self._start + self._size: |
|
225 |
raise errors.InvalidRange( |
|
226 |
self._path, self._pos, |
|
227 |
"Can't read %s bytes across range (%s, %s)" |
|
228 |
% (size, self._start, self._size)) |
|
229 |
||
3408.6.1
by Eric Holmberg
Fix for Bug #215426 in which bzr can cause a MemoryError in socket.recv while |
230 |
# read data from file
|
231 |
buffer = StringIO() |
|
232 |
limited = size |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
233 |
if self._size > 0: |
234 |
# Don't read past the range definition
|
|
235 |
limited = self._start + self._size - self._pos |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
236 |
if size >= 0: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
237 |
limited = min(limited, size) |
3945.1.8
by Vincent Ladeuil
Add more tests, fix pycurl double handling, revert previous tracking. |
238 |
osutils.pumpfile(self._file, buffer, limited, self._max_read_size) |
3408.6.1
by Eric Holmberg
Fix for Bug #215426 in which bzr can cause a MemoryError in socket.recv while |
239 |
data = buffer.getvalue() |
240 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
241 |
# Update _pos respecting the data effectively read
|
242 |
self._pos += len(data) |
|
243 |
return data |
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
244 |
|
245 |
def seek(self, offset, whence=0): |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
246 |
start_pos = self._pos |
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
247 |
if whence == 0: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
248 |
final_pos = offset |
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
249 |
elif whence == 1: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
250 |
final_pos = start_pos + offset |
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
251 |
elif whence == 2: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
252 |
if self._size > 0: |
3059.2.14
by Vincent Ladeuil
Complete coverage by adding tests for more invalid inputs. Fix a |
253 |
final_pos = self._start + self._size + offset # offset < 0 |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
254 |
else: |
255 |
raise errors.InvalidRange( |
|
256 |
self._path, self._pos, |
|
3059.2.14
by Vincent Ladeuil
Complete coverage by adding tests for more invalid inputs. Fix a |
257 |
"RangeFile: can't seek from end while size is unknown") |
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
258 |
else: |
259 |
raise ValueError("Invalid value %s for whence." % whence) |
|
260 |
||
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
261 |
if final_pos < self._pos: |
262 |
# Can't seek backwards
|
|
263 |
raise errors.InvalidRange( |
|
264 |
self._path, self._pos, |
|
265 |
'RangeFile: trying to seek backwards to %s' % final_pos) |
|
266 |
||
267 |
if self._size > 0: |
|
268 |
cur_limit = self._start + self._size |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
269 |
while final_pos > cur_limit: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
270 |
# We will cross range boundaries
|
271 |
remain = cur_limit - self._pos |
|
272 |
if remain > 0: |
|
273 |
# Finish reading the current range
|
|
274 |
self._checked_read(remain) |
|
3059.2.18
by Vincent Ladeuil
Take spiv review comments into account. |
275 |
self._seek_to_next_range() |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
276 |
cur_limit = self._start + self._size |
277 |
||
278 |
size = final_pos - self._pos |
|
279 |
if size > 0: # size can be < 0 if we crossed a range boundary |
|
280 |
# We don't need the data, just read it and throw it away
|
|
281 |
self._checked_read(size) |
|
1750.1.2
by Michael Ellerman
Add support for HTTP multipart ranges and hook it into http+urllib. |
282 |
|
1786.1.8
by John Arbash Meinel
[merge] Johan Rydberg test updates |
283 |
def tell(self): |
284 |
return self._pos |
|
285 |
||
1786.1.5
by John Arbash Meinel
Move the common Multipart stuff into plain http, and wrap pycurl response so that it matches the urllib response object. |
286 |
|
3945.1.8
by Vincent Ladeuil
Add more tests, fix pycurl double handling, revert previous tracking. |
287 |
def handle_response(url, code, msg, data): |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
288 |
"""Interpret the code & headers and wrap the provided data in a RangeFile.
|
289 |
||
290 |
This is a factory method which returns an appropriate RangeFile based on
|
|
291 |
the code & headers it's given.
|
|
1786.1.21
by John Arbash Meinel
(broken) Work on factoring out handle_response so we can test with fake headers. |
292 |
|
293 |
:param url: The url being processed. Mostly for error reporting
|
|
294 |
:param code: The integer HTTP response code
|
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
295 |
:param msg: An HTTPMessage containing the headers for the response
|
1786.1.27
by John Arbash Meinel
Fix up the http transports so that tests pass with the new configuration. |
296 |
:param data: A file-like object that can be read() to get the
|
297 |
requested data
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
298 |
:return: A file-like object that can seek()+read() the
|
1786.1.21
by John Arbash Meinel
(broken) Work on factoring out handle_response so we can test with fake headers. |
299 |
ranges indicated by the headers.
|
300 |
"""
|
|
3945.1.8
by Vincent Ladeuil
Add more tests, fix pycurl double handling, revert previous tracking. |
301 |
rfile = RangeFile(url, data) |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
302 |
if code == 200: |
303 |
# A whole file
|
|
304 |
size = msg.getheader('content-length', None) |
|
305 |
if size is None: |
|
306 |
size = -1 |
|
307 |
else: |
|
308 |
size = int(size) |
|
309 |
rfile.set_range(0, size) |
|
310 |
elif code == 206: |
|
311 |
content_type = msg.getheader('content-type', None) |
|
312 |
if content_type is None: |
|
313 |
# When there is no content-type header we treat the response as
|
|
314 |
# being of type 'application/octet-stream' as per RFC2616 section
|
|
315 |
# 7.2.1.
|
|
2073.1.1
by John Arbash Meinel
Robert's comments: Refer to RFC2616 to explain how we handle missing Content-Type |
316 |
# Therefore it is obviously not multipart
|
317 |
content_type = 'application/octet-stream' |
|
2070.1.1
by John Arbash Meinel
Fix bug #62473 by not requiring content-type in range responses |
318 |
is_multipart = False |
319 |
else: |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
320 |
is_multipart = (msg.getmaintype() == 'multipart' |
321 |
and msg.getsubtype() == 'byteranges') |
|
1786.1.26
by John Arbash Meinel
Update and test handle_response. |
322 |
|
2070.1.1
by John Arbash Meinel
Fix bug #62473 by not requiring content-type in range responses |
323 |
if is_multipart: |
1786.1.26
by John Arbash Meinel
Update and test handle_response. |
324 |
# Full fledged multipart response
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
325 |
rfile.set_boundary(msg.getparam('boundary')) |
1786.1.26
by John Arbash Meinel
Update and test handle_response. |
326 |
else: |
327 |
# A response to a range request, but not multipart
|
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
328 |
content_range = msg.getheader('content-range', None) |
329 |
if content_range is None: |
|
1786.1.26
by John Arbash Meinel
Update and test handle_response. |
330 |
raise errors.InvalidHttpResponse(url, |
331 |
'Missing the Content-Range header in a 206 range response') |
|
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
332 |
rfile.set_range_from_header(content_range) |
1786.1.40
by John Arbash Meinel
code cleanups from Martin Pool. |
333 |
else: |
3059.2.2
by Vincent Ladeuil
Read http responses on demand without buffering the whole body |
334 |
raise errors.InvalidHttpResponse(url, |
335 |
'Unknown response code %s' % code) |
|
336 |
||
337 |
return rfile |
|
1786.1.21
by John Arbash Meinel
(broken) Work on factoring out handle_response so we can test with fake headers. |
338 |