~bzr-pqm/bzr/bzr.dev

5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1551.8.30 by Aaron Bentley
Tweak from review comments
52
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
53
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
54
    errors,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
55
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
57
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
58
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
59
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
60
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
61
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
62
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
63
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
64
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
65
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
66
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib.osutils import (get_user_encoding,
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
68
                            is_inside_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
69
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
70
                            splitpath,
71
                            )
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
72
from bzrlib.trace import mutter, note, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
73
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
74
from bzrlib import symbol_versioning
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
75
from bzrlib.urlutils import unescape_for_display
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
77
78
class NullCommitReporter(object):
79
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
80
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
81
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
82
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
83
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
84
                                   "to started.", DeprecationWarning,
85
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
86
        pass
87
88
    def snapshot_change(self, change, path):
89
        pass
90
91
    def completed(self, revno, rev_id):
92
        pass
93
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
94
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
        pass
96
97
    def missing(self, path):
98
        pass
99
100
    def renamed(self, change, old_path, new_path):
101
        pass
102
2789.2.11 by Ian Clatworthy
remove more reporting stuff
103
    def is_verbose(self):
104
        return False
105
106
107
class ReportCommitToLog(NullCommitReporter):
108
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
109
    def _note(self, format, *args):
110
        """Output a message.
111
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
112
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
113
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
114
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
116
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
117
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
119
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
120
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
121
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
122
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
123
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
124
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
125
            # When started was added, location was only made optional by
126
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
127
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
128
                                   "to started.", DeprecationWarning,
129
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
130
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
131
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
132
133
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
        self._note('Committed revision %d.', revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
135
        # self._note goes to the console too; so while we want to log the
136
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
        # term we should rearrange the reporting structure, but for now
138
        # we just mutter seperately. We mutter the revid and revno together
139
        # so that concurrent bzr invocations won't lead to confusion.
140
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
141
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
142
    def deleted(self, path):
143
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
144
145
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
146
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
148
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
150
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
151
    def is_verbose(self):
152
        return True
153
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
154
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
class Commit(object):
156
    """Task of committing a new revision.
157
158
    This is a MethodObject: it accumulates state as the commit is
159
    prepared, and then it is discarded.  It doesn't represent
160
    historical revisions, just the act of recording a new one.
161
162
            missing_ids
163
            Modified to hold a list of files that have been deleted from
164
            the working directory; these should be removed from the
165
            working inventory.
485 by Martin Pool
- move commit code into its own module
166
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
                 reporter=None,
169
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
170
        """Create a Commit object.
171
172
        :param reporter: the default reporter to use or None to decide later
173
        """
174
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
175
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
176
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
177
    @staticmethod
178
    def update_revprops(revprops, branch, authors=None, author=None,
179
                        local=False, possible_master_transports=None):
180
        if revprops is None:
181
            revprops = {}
182
        if possible_master_transports is None:
183
            possible_master_transports = []
184
        if not 'branch-nick' in revprops:
185
            revprops['branch-nick'] = branch._get_nick(
186
                local,
187
                possible_master_transports)
188
        if authors is not None:
189
            if author is not None:
190
                raise AssertionError('Specifying both author and authors '
191
                        'is not allowed. Specify just authors instead')
192
            if 'author' in revprops or 'authors' in revprops:
193
                # XXX: maybe we should just accept one of them?
194
                raise AssertionError('author property given twice')
195
            if authors:
196
                for individual in authors:
197
                    if '\n' in individual:
198
                        raise AssertionError('\\n is not a valid character '
199
                                'in an author identity')
200
                revprops['authors'] = '\n'.join(authors)
201
        if author is not None:
202
            symbol_versioning.warn('The parameter author was deprecated'
203
                   ' in version 1.13. Use authors instead',
204
                   DeprecationWarning)
205
            if 'author' in revprops or 'authors' in revprops:
206
                # XXX: maybe we should just accept one of them?
207
                raise AssertionError('author property given twice')
208
            if '\n' in author:
209
                raise AssertionError('\\n is not a valid character '
210
                        'in an author identity')
211
            revprops['authors'] = author
212
        return revprops
213
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
215
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
               timestamp=None,
217
               timezone=None,
218
               committer=None,
219
               specific_files=None,
220
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
221
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
222
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
223
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
224
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
225
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
226
               local=False,
227
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
228
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
229
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
230
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
231
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
232
               possible_master_transports=None,
233
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
        """Commit working copy as a new revision.
235
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
236
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
237
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
238
239
        :param timestamp: if not None, seconds-since-epoch for a
240
            postdated/predated commit.
241
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
242
        :param specific_files: If not None, commit only those files. An empty
243
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
244
245
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
246
            Useful for test or import commands that need to tightly
247
            control what revisions are assigned.  If you duplicate
248
            a revision id that exists elsewhere it is your own fault.
249
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
250
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
251
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
252
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
253
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
255
            contains unknown files.
256
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
257
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
258
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
259
        :param reporter: the reporter to use or None for the default
260
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
261
        :param recursive: If set to 'down', commit in any subtrees that have
262
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
263
        :param exclude: None or a list of relative paths to exclude from the
264
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
265
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
266
        :param lossy: When committing to a foreign VCS, ignore any
267
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
268
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
269
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
270
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
271
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
272
        self.config = config or self.config
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
273
        return operation.run(
274
               message=message,
275
               timestamp=timestamp,
276
               timezone=timezone,
277
               committer=committer,
278
               specific_files=specific_files,
279
               rev_id=rev_id,
280
               allow_pointless=allow_pointless,
281
               strict=strict,
282
               verbose=verbose,
283
               working_tree=working_tree,
284
               local=local,
285
               reporter=reporter,
286
               message_callback=message_callback,
287
               recursive=recursive,
288
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
289
               possible_master_transports=possible_master_transports,
290
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
291
292
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
293
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
294
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
295
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
296
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
297
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
298
        if working_tree is None:
299
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
300
        else:
301
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
302
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
303
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
304
                if not self.branch.repository.supports_rich_root():
305
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
306
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
307
            if message is not None:
308
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
309
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
310
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
311
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
312
                raise BzrError("The message or message_callback keyword"
313
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
314
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
315
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
316
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
317
        if exclude is not None:
318
            self.exclude = sorted(
319
                minimum_path_selection(exclude))
320
        else:
321
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
322
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
323
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
324
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
325
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
326
        # self.specific_files is None to indicate no filter, or any iterable to
327
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
328
        if specific_files is not None:
329
            self.specific_files = sorted(
330
                minimum_path_selection(specific_files))
331
        else:
332
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
333
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
334
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
335
        self.message_callback = message_callback
336
        self.timestamp = timestamp
337
        self.timezone = timezone
338
        self.committer = committer
339
        self.strict = strict
340
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
341
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
342
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
343
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
344
        self.parents = self.work_tree.get_parent_ids()
345
        # We can use record_iter_changes IFF iter_changes is compatible with
346
        # the command line parameters, and the repository has fast delta
347
        # generation. See bug 347649.
348
        self.use_record_iter_changes = (
349
            not self.exclude and 
350
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
351
            (self.branch.repository._format.fast_deltas or
352
             len(self.parents) < 2))
5582.10.6 by Jelmer Vernooij
Fix ui imports.
353
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
354
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
355
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
356
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
357
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
358
        operation.add_cleanup(self.basis_tree.unlock)
359
        # Cannot commit with conflicts present.
360
        if len(self.work_tree.conflicts()) > 0:
361
            raise ConflictsInTree
362
363
        # Setup the bound branch variables as needed.
364
        self._check_bound_branch(operation, possible_master_transports)
365
366
        # Check that the working tree is up to date
367
        old_revno, new_revno = self._check_out_of_date_tree()
368
369
        # Complete configuration setup
370
        if reporter is not None:
371
            self.reporter = reporter
372
        elif self.reporter is None:
373
            self.reporter = self._select_reporter()
374
        if self.config is None:
375
            self.config = self.branch.get_config()
376
377
        self._set_specific_file_ids()
378
379
        # Setup the progress bar. As the number of files that need to be
380
        # committed in unknown, progress is reported as stages.
381
        # We keep track of entries separately though and include that
382
        # information in the progress bar during the relevant stages.
383
        self.pb_stage_name = ""
384
        self.pb_stage_count = 0
385
        self.pb_stage_total = 5
386
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
387
            # 2 extra stages: "Uploading data to master branch" and "Merging
388
            # tags to master branch"
389
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
390
        self.pb.show_pct = False
391
        self.pb.show_spinner = False
392
        self.pb.show_eta = False
393
        self.pb.show_count = True
394
        self.pb.show_bar = True
395
396
        self._gather_parents()
397
        # After a merge, a selected file commit is not supported.
398
        # See 'bzr help merge' for an explanation as to why.
399
        if len(self.parents) > 1 and self.specific_files is not None:
400
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
401
        # Excludes are a form of selected file commit.
402
        if len(self.parents) > 1 and self.exclude:
403
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
404
405
        # Collect the changes
406
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
407
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
408
        self.builder = self.branch.get_commit_builder(self.parents,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
409
            self.config, timestamp, timezone, committer, self.revprops,
410
            rev_id, lossy=lossy)
5718.4.9 by Jelmer Vernooij
Fix logic for raising ExcludesUnsupported exception. It's a pity we have no record-iter-changes-only formats in bzr.dev.
411
        if not self.builder.supports_record_entry_contents and self.exclude:
5718.4.5 by Jelmer Vernooij
Move ExcludesUnsupported raise location.
412
            self.builder.abort()
413
            raise errors.ExcludesUnsupported(self.branch.repository)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
414
1189 by Martin Pool
- BROKEN: partial support for commit into weave
415
        try:
5718.4.8 by Jelmer Vernooij
Revert conditional will_record_deletes.
416
            self.builder.will_record_deletes()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
417
            # find the location being committed to
418
            if self.bound_branch:
419
                master_location = self.master_branch.base
420
            else:
421
                master_location = self.branch.base
422
423
            # report the start of the commit
424
            self.reporter.started(new_revno, self.rev_id, master_location)
425
426
            self._update_builder_with_changes()
427
            self._check_pointless()
428
429
            # TODO: Now the new inventory is known, check for conflicts.
430
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
431
            # weave lines, because nothing should be recorded until it is known
432
            # that commit will succeed.
433
            self._set_progress_stage("Saving data locally")
434
            self.builder.finish_inventory()
435
436
            # Prompt the user for a commit message if none provided
437
            message = message_callback(self)
438
            self.message = message
439
440
            # Add revision data to the local branch
441
            self.rev_id = self.builder.commit(self.message)
442
443
        except Exception, e:
444
            mutter("aborting commit write group because of exception:")
445
            trace.log_exception_quietly()
446
            self.builder.abort()
447
            raise
448
449
        self._process_pre_hooks(old_revno, new_revno)
450
451
        # Upload revision data to the master.
452
        # this will propagate merged revisions too if needed.
453
        if self.bound_branch:
454
            self._set_progress_stage("Uploading data to master branch")
455
            # 'commit' to the master first so a timeout here causes the
456
            # local branch to be out of date
5777.7.1 by Jelmer Vernooij
Add lossy argument to Branch.import_last_revision_info_and_tags.
457
            (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
458
                self.branch, new_revno, self.rev_id, lossy=lossy)
459
            if lossy:
460
                self.branch.fetch(self.master_branch, self.rev_id)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
461
462
        # and now do the commit locally.
463
        self.branch.set_last_revision_info(new_revno, self.rev_id)
464
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
465
        # Merge local tags to remote
466
        if self.bound_branch:
467
            self._set_progress_stage("Merging tags to master branch")
468
            tag_conflicts = self.branch.tags.merge_to(self.master_branch.tags)
469
            if tag_conflicts:
470
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
471
                note("Conflicting tags in bound branch:\n" +
472
                    "\n".join(warning_lines))
473
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
474
        # Make the working tree be up to date with the branch. This
475
        # includes automatic changes scheduled to be made to the tree, such
476
        # as updating its basis and unversioning paths that were missing.
477
        self.work_tree.unversion(self.deleted_ids)
478
        self._set_progress_stage("Updating the working tree")
479
        self.work_tree.update_basis_by_delta(self.rev_id,
480
             self.builder.get_basis_delta())
481
        self.reporter.completed(new_revno, self.rev_id)
482
        self._process_post_hooks(old_revno, new_revno)
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
483
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
484
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
485
    def _select_reporter(self):
486
        """Select the CommitReporter to use."""
487
        if is_quiet():
488
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
489
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
490
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
491
    def _check_pointless(self):
492
        if self.allow_pointless:
493
            return
494
        # A merge with no effect on files
495
        if len(self.parents) > 1:
496
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
497
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
498
            return
499
        raise PointlessCommit()
500
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
501
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
502
        """Check to see if the local branch is bound.
503
504
        If it is bound, then most of the commit will actually be
505
        done using the remote branch as the target branch.
506
        Only at the end will the local branch be updated.
507
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
508
        if self.local and not self.branch.get_bound_location():
509
            raise errors.LocalRequiresBoundBranch()
510
511
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
512
            self.master_branch = self.branch.get_master_branch(
513
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
514
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
515
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
516
            # make this branch the reference branch for out of date checks.
517
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
518
            return
519
520
        # If the master branch is bound, we must fail
521
        master_bound_location = self.master_branch.get_bound_location()
522
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
523
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
524
                    self.master_branch, master_bound_location)
525
526
        # TODO: jam 20051230 We could automatically push local
527
        #       commits to the remote branch if they would fit.
528
        #       But for now, just require remote to be identical
529
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
530
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
531
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
532
        master_info = self.master_branch.last_revision_info()
533
        local_info = self.branch.last_revision_info()
534
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
535
            raise errors.BoundBranchOutOfDate(self.branch,
536
                    self.master_branch)
537
538
        # Now things are ready to change the master branch
539
        # so grab the lock
540
        self.bound_branch = self.branch
541
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
542
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
543
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
544
    def _check_out_of_date_tree(self):
545
        """Check that the working tree is up to date.
546
547
        :return: old_revision_number,new_revision_number tuple
548
        """
549
        try:
550
            first_tree_parent = self.work_tree.get_parent_ids()[0]
551
        except IndexError:
552
            # if there are no parents, treat our parent as 'None'
553
            # this is so that we still consider the master branch
554
            # - in a checkout scenario the tree may have no
555
            # parents but the branch may do.
556
            first_tree_parent = bzrlib.revision.NULL_REVISION
557
        old_revno, master_last = self.master_branch.last_revision_info()
558
        if master_last != first_tree_parent:
559
            if master_last != bzrlib.revision.NULL_REVISION:
560
                raise errors.OutOfDateTree(self.work_tree)
561
        if self.branch.repository.has_revision(first_tree_parent):
562
            new_revno = old_revno + 1
563
        else:
564
            # ghost parents never appear in revision history.
565
            new_revno = 1
566
        return old_revno,new_revno
567
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
568
    def _process_pre_hooks(self, old_revno, new_revno):
569
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
570
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
571
        self._process_hooks("pre_commit", old_revno, new_revno)
572
573
    def _process_post_hooks(self, old_revno, new_revno):
574
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
575
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
576
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
577
        # old style commit hooks - should be deprecated ? (obsoleted in
578
        # 0.15)
579
        if self.config.post_commit() is not None:
580
            hooks = self.config.post_commit().split(' ')
581
            # this would be nicer with twisted.python.reflect.namedAny
582
            for hook in hooks:
583
                result = eval(hook + '(branch, rev_id)',
584
                              {'branch':self.branch,
585
                               'bzrlib':bzrlib,
586
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
587
        # process new style post commit hooks
588
        self._process_hooks("post_commit", old_revno, new_revno)
589
590
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
591
        if not Branch.hooks[hook_name]:
592
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
593
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
594
        # new style commit hooks:
595
        if not self.bound_branch:
596
            hook_master = self.branch
597
            hook_local = None
598
        else:
599
            hook_master = self.master_branch
600
            hook_local = self.branch
601
        # With bound branches, when the master is behind the local branch,
602
        # the 'old_revno' and old_revid values here are incorrect.
603
        # XXX: FIXME ^. RBC 20060206
604
        if self.parents:
605
            old_revid = self.parents[0]
606
        else:
607
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
608
2659.3.9 by NamNguyen
branch.py:
609
        if hook_name == "pre_commit":
610
            future_tree = self.builder.revision_tree()
611
            tree_delta = future_tree.changes_from(self.basis_tree,
612
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
613
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
614
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
615
            # show the running hook in the progress bar. As hooks may
616
            # end up doing nothing (e.g. because they are not configured by
617
            # the user) this is still showing progress, not showing overall
618
            # actions - its up to each plugin to show a UI if it want's to
619
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
620
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
621
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
622
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
623
            if 'hooks' in debug.debug_flags:
624
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
625
            if hook_name == "post_commit":
626
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
627
                     self.rev_id)
628
            elif hook_name == "pre_commit":
629
                hook(hook_local, hook_master,
630
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
631
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
632
1223 by Martin Pool
- store inventories in weave
633
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
634
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
635
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
636
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
637
        if self.use_record_iter_changes:
638
            return
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
639
        self.basis_inv = self.basis_tree.inventory
640
        self.parent_invs = [self.basis_inv]
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
641
        for revision in self.parents[1:]:
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
642
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
643
                mutter('commit parent revision {%s}', revision)
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
644
                inventory = self.branch.repository.get_inventory(revision)
645
                self.parent_invs.append(inventory)
646
            else:
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
647
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
648
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
649
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
650
        """Update the commit builder with the data about what has changed.
651
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
652
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
653
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
654
        mutter("Selecting files for commit with filter %s", specific_files)
655
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
656
        self._check_strict()
657
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
658
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
659
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
660
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
661
            for file_id, path, fs_hash in self.builder.record_iter_changes(
662
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
663
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
664
        else:
665
            # Build the new inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
666
            self._populate_from_inventory()
667
            self._record_unselected()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
668
            self._report_and_accumulate_deletes()
669
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
670
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
671
        """Process iter_changes.
672
673
        This method reports on the changes in iter_changes to the user, and 
674
        converts 'missing' entries in the iter_changes iterator to 'deleted'
675
        entries. 'missing' entries have their
676
677
        :param iter_changes: An iter_changes to process.
678
        :return: A generator of changes.
679
        """
680
        reporter = self.reporter
681
        report_changes = reporter.is_verbose()
682
        deleted_ids = []
683
        for change in iter_changes:
684
            if report_changes:
685
                old_path = change[1][0]
686
                new_path = change[1][1]
687
                versioned = change[3][1]
688
            kind = change[6][1]
689
            versioned = change[3][1]
690
            if kind is None and versioned:
691
                # 'missing' path
692
                if report_changes:
693
                    reporter.missing(new_path)
694
                deleted_ids.append(change[0])
695
                # Reset the new path (None) and new versioned flag (False)
696
                change = (change[0], (change[1][0], None), change[2],
697
                    (change[3][0], False)) + change[4:]
698
            elif kind == 'tree-reference':
699
                if self.recursive == 'down':
700
                    self._commit_nested_tree(change[0], change[1][1])
701
            if change[3][0] or change[3][1]:
702
                yield change
703
                if report_changes:
704
                    if new_path is None:
705
                        reporter.deleted(old_path)
706
                    elif old_path is None:
707
                        reporter.snapshot_change('added', new_path)
708
                    elif old_path != new_path:
709
                        reporter.renamed('renamed', old_path, new_path)
710
                    else:
711
                        if (new_path or 
712
                            self.work_tree.branch.repository._format.rich_root_data):
713
                            # Don't report on changes to '' in non rich root
714
                            # repositories.
715
                            reporter.snapshot_change('modified', new_path)
716
            self._next_progress_entry()
717
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
718
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
719
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
720
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
721
        # If specific files are selected, then all un-selected files must be
722
        # recorded in their previous state. For more details, see
723
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
724
        if self.specific_files or self.exclude:
725
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
726
            for path, old_ie in self.basis_inv.iter_entries():
5967.7.1 by Martin Pool
Deprecate __contains__ on Tree and Inventory
727
                if self.builder.new_inventory.has_id(old_ie.file_id):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
728
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
729
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
730
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
731
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
732
                    # was inside the selected path, and not excluded - if not
733
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
734
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
735
                # From here down it was either not selected, or was excluded:
736
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
737
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
738
                # Note: specific file commits after a merge are currently
739
                # prohibited. This test is for sanity/safety in case it's
740
                # required after that changes.
741
                if len(self.parents) > 1:
742
                    ie.revision = None
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
743
                self.builder.record_entry_contents(ie, self.parent_invs, path,
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
744
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
745
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
746
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
747
        if (isinstance(self.basis_inv, Inventory)
748
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
749
            # the older Inventory classes provide a _byid dict, and building a
750
            # set from the keys of this dict is substantially faster than even
751
            # getting a set of ids from the inventory
752
            #
753
            # <lifeless> set(dict) is roughly the same speed as
754
            # set(iter(dict)) and both are significantly slower than
755
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
756
            deleted_ids = set(self.basis_inv._byid.keys()) - \
757
               set(self.builder.new_inventory._byid.keys())
758
        else:
759
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
760
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
761
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
762
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
763
                for file_id in deleted_ids]
764
            deleted.sort()
765
            # XXX: this is not quite directory-order sorting
766
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
767
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
768
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
769
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
770
    def _check_strict(self):
771
        # XXX: when we use iter_changes this would likely be faster if
772
        # iter_changes would check for us (even in the presence of
773
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
774
        if self.strict:
775
            # raise an exception as soon as we find a single unknown.
776
            for unknown in self.work_tree.unknowns():
777
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
778
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
779
    def _populate_from_inventory(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
780
        """Populate the CommitBuilder by walking the working tree inventory."""
781
        # Build the revision inventory.
782
        #
783
        # This starts by creating a new empty inventory. Depending on
784
        # which files are selected for commit, and what is present in the
785
        # current tree, the new inventory is populated. inventory entries
786
        # which are candidates for modification have their revision set to
787
        # None; inventory entries that are carried over untouched have their
788
        # revision set to their prior value.
789
        #
790
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
791
        # results to create a new inventory at the same time, which results
792
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
793
        # ADHB 11-07-2006
794
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
795
        specific_files = self.specific_files
796
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
797
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
798
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
799
        # A tree of paths that have been deleted. E.g. if foo/bar has been
800
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
801
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
802
        # XXX: Note that entries may have the wrong kind because the entry does
803
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
804
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
805
        # NB: entries will include entries within the excluded ids/paths
806
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
807
        entries = work_inv.iter_entries_by_dir(
808
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
809
        for path, existing_ie in entries:
810
            file_id = existing_ie.file_id
811
            name = existing_ie.name
812
            parent_id = existing_ie.parent_id
813
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
814
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
815
            # The deleted path ids are also recorded so they can be explicitly
816
            # unversioned later.
817
            if deleted_paths:
818
                path_segments = splitpath(path)
819
                deleted_dict = deleted_paths
820
                for segment in path_segments:
821
                    deleted_dict = deleted_dict.get(segment, None)
822
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
823
                        # We either took a path not present in the dict
824
                        # (deleted_dict was None), or we've reached an empty
825
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
826
                        break
827
                else:
828
                    deleted_dict = None
829
                if deleted_dict is not None:
830
                    # the path has a deleted parent, do not add it.
831
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
832
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
833
                # Skip excluded paths. Excluded paths are processed by
834
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
835
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
836
            content_summary = self.work_tree.path_content_summary(path)
837
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
838
            # Note that when a filter of specific files is given, we must only
839
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
840
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
841
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
842
                    if not deleted_paths:
843
                        # path won't have been split yet.
844
                        path_segments = splitpath(path)
845
                    deleted_dict = deleted_paths
846
                    for segment in path_segments:
847
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
849
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
850
                    deleted_ids.append(file_id)
851
                    continue
4595.11.14 by Martin Pool
Small code cleanups
852
            # TODO: have the builder do the nested commit just-in-time IF and
853
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
854
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
855
                # enforce repository nested tree policy.
856
                if (not self.work_tree.supports_tree_reference() or
857
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
858
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
859
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
860
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
861
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
862
                    nested_revision_id = self._commit_nested_tree(
863
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
864
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
865
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
866
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
867
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
868
869
            # Record an entry for this item
870
            # Note: I don't particularly want to have the existing_ie
871
            # parameter but the test suite currently (28-Jun-07) breaks
872
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
873
            definitely_changed = kind != existing_ie.kind
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
874
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
875
                parent_id, definitely_changed, existing_ie, report_changes,
876
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
877
878
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
879
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
880
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
881
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
882
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
883
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
884
        # FIXME: be more comprehensive here:
885
        # this works when both trees are in --trees repository,
886
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
887
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
888
        # finally implement the explicit-caches approach design
889
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
890
        if sub_tree.branch.repository.has_same_location(
891
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
892
            sub_tree.branch.repository = \
893
                self.work_tree.branch.repository
894
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
895
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
896
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
897
                message_callback=self.message_callback,
898
                timestamp=self.timestamp, timezone=self.timezone,
899
                committer=self.committer,
900
                allow_pointless=self.allow_pointless,
901
                strict=self.strict, verbose=self.verbose,
902
                local=self.local, reporter=self.reporter)
903
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
904
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
905
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
906
    def _record_entry(self, path, file_id, specific_files, kind, name,
907
        parent_id, definitely_changed, existing_ie, report_changes,
908
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
909
        "Record the new inventory entry for a path if any."
910
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
911
        # mutter('%s selected for commit', path)
912
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
913
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
914
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
915
            ie = existing_ie.copy()
916
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
917
        # For carried over entries we don't care about the fs hash - the repo
918
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
919
        _, _, fs_hash = self.builder.record_entry_contents(
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
920
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
921
        if report_changes:
922
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
923
        if fs_hash:
924
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
925
        return ie
926
927
    def _report_change(self, ie, path):
928
        """Report a change to the user.
929
930
        The change that has occurred is described relative to the basis
931
        inventory.
932
        """
933
        if (self.basis_inv.has_id(ie.file_id)):
934
            basis_ie = self.basis_inv[ie.file_id]
935
        else:
936
            basis_ie = None
937
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
938
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
939
            InventoryEntry.MODIFIED_AND_RENAMED):
940
            old_path = self.basis_inv.id2path(ie.file_id)
941
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
942
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
943
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
944
            if change == 'unchanged':
945
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
946
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
947
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
948
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
949
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
950
        """Set the progress stage and emit an update to the progress bar."""
951
        self.pb_stage_name = name
952
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
953
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
954
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
955
        else:
956
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
957
        self._emit_progress()
958
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
959
    def _next_progress_entry(self):
960
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
961
        self.pb_entries_count += 1
962
        self._emit_progress()
963
964
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
965
        if self.pb_entries_count is not None:
966
            text = "%s [%d] - Stage" % (self.pb_stage_name,
967
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
968
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
969
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
970
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
971
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
972
    def _set_specific_file_ids(self):
973
        """populate self.specific_file_ids if we will use it."""
974
        if not self.use_record_iter_changes:
975
            # If provided, ensure the specified files are versioned
976
            if self.specific_files is not None:
977
                # Note: This routine is being called because it raises
978
                # PathNotVersionedError as a side effect of finding the IDs. We
979
                # later use the ids we found as input to the working tree
980
                # inventory iterator, so we only consider those ids rather than
981
                # examining the whole tree again.
982
                # XXX: Dont we have filter_unversioned to do this more
983
                # cheaply?
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
984
                self.specific_file_ids = tree.find_ids_across_trees(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
985
                    self.specific_files, [self.basis_tree, self.work_tree])
986
            else:
987
                self.specific_file_ids = None