~bzr-pqm/bzr/bzr.dev

4988.10.3 by John Arbash Meinel
Merge bzr.dev 5007, resolve conflict, update NEWS
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
369 by Martin Pool
- Split out log printing into new show_log function
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
369 by Martin Pool
- Split out log printing into new show_log function
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
369 by Martin Pool
- Split out log printing into new show_log function
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
369 by Martin Pool
- Split out log printing into new show_log function
16
375 by Martin Pool
- New command touching-revisions and function to trace
17
18
527 by Martin Pool
- refactor log command
19
"""Code to show logs of changes.
20
21
Various flavors of log can be produced:
22
23
* for one file, or the whole tree, and (not done yet) for
24
  files in a given directory
25
26
* in "verbose" mode with a description of what changed from one
27
  version to the next
28
29
* with file-ids and revision-ids shown
30
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
31
Logs are actually written out through an abstract LogFormatter
32
interface, which allows for different preferred formats.  Plugins can
33
register formats too.
34
35
Logs can be produced in either forward (oldest->newest) or reverse
36
(newest->oldest) order.
37
38
Logs can be filtered to show only revisions matching a particular
39
search string, or within a particular range of revisions.  The range
40
can be given as date/times, which are reduced to revisions before
41
calling in here.
42
43
In verbose mode we show a summary of what changed in each particular
44
revision.  Note that this is the delta for changes in that revision
2466.12.2 by Kent Gibson
shift log output with only merge revisions to the left margin
45
relative to its left-most parent, not the delta relative to the last
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
46
logged revision.  So for example if you ask for a verbose log of
47
changes touching hello.c you will get a list of those revisions also
48
listing other things that were changed in the same revision, but not
49
all the changes since the previous revision that touched hello.c.
527 by Martin Pool
- refactor log command
50
"""
51
2997.1.2 by Kent Gibson
Move all imports to top of log.py
52
import codecs
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
53
from cStringIO import StringIO
2997.1.2 by Kent Gibson
Move all imports to top of log.py
54
from itertools import (
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
55
    chain,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
56
    izip,
57
    )
1624.1.3 by Robert Collins
Convert log to use the new tsort.merge_sort routine.
58
import re
2997.1.2 by Kent Gibson
Move all imports to top of log.py
59
import sys
60
from warnings import (
61
    warn,
62
    )
1185.33.41 by Martin Pool
Fix regression of 'bzr log -v' - it wasn't showing changed files at all. (#4676)
63
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
64
from bzrlib.lazy_import import lazy_import
65
lazy_import(globals(), """
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
66
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib import (
4202.2.1 by Ian Clatworthy
get directory logging working again
68
    bzrdir,
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
69
    config,
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
70
    diff,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
71
    errors,
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
72
    foreign,
4797.57.10 by Alexander Belchenko
path_encoding selection logic extracted as helper function
73
    osutils,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
74
    repository as _mod_repository,
75
    revision as _mod_revision,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
76
    revisionspec,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
77
    trace,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
78
    tsort,
79
    )
80
""")
81
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
82
from bzrlib import (
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
83
    registry,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
84
    )
85
from bzrlib.osutils import (
86
    format_date,
4379.4.1 by Ian Clatworthy
make log --long faster
87
    format_date_with_offset_in_original_timezone,
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
88
    get_terminal_encoding,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
89
    terminal_width,
90
    )
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
91
from bzrlib.symbol_versioning import (
92
    deprecated_function,
93
    deprecated_in,
94
    )
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
95
375 by Martin Pool
- New command touching-revisions and function to trace
96
97
def find_touching_revisions(branch, file_id):
98
    """Yield a description of revisions which affect the file_id.
99
100
    Each returned element is (revno, revision_id, description)
101
102
    This is the list of revisions where the file is either added,
103
    modified, renamed or deleted.
104
105
    TODO: Perhaps some way to limit this to only particular revisions,
522 by Martin Pool
todo
106
    or to traverse a non-mainline set of revisions?
375 by Martin Pool
- New command touching-revisions and function to trace
107
    """
108
    last_ie = None
109
    last_path = None
110
    revno = 1
111
    for revision_id in branch.revision_history():
5035.3.1 by Jelmer Vernooij
Remove Repository.get_revision_inventory.
112
        this_inv = branch.repository.get_inventory(revision_id)
375 by Martin Pool
- New command touching-revisions and function to trace
113
        if file_id in this_inv:
114
            this_ie = this_inv[file_id]
115
            this_path = this_inv.id2path(file_id)
116
        else:
117
            this_ie = this_path = None
118
119
        # now we know how it was last time, and how it is in this revision.
120
        # are those two states effectively the same or not?
121
122
        if not this_ie and not last_ie:
123
            # not present in either
124
            pass
125
        elif this_ie and not last_ie:
126
            yield revno, revision_id, "added " + this_path
127
        elif not this_ie and last_ie:
128
            # deleted here
129
            yield revno, revision_id, "deleted " + last_path
130
        elif this_path != last_path:
131
            yield revno, revision_id, ("renamed %s => %s" % (last_path, this_path))
132
        elif (this_ie.text_size != last_ie.text_size
133
              or this_ie.text_sha1 != last_ie.text_sha1):
134
            yield revno, revision_id, "modified " + this_path
135
136
        last_ie = this_ie
137
        last_path = this_path
138
        revno += 1
139
140
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
141
def _enumerate_history(branch):
142
    rh = []
143
    revno = 1
144
    for rev_id in branch.revision_history():
145
        rh.append((revno, rev_id))
146
        revno += 1
147
    return rh
148
149
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
150
def show_log(branch,
151
             lf,
152
             specific_fileid=None,
153
             verbose=False,
154
             direction='reverse',
155
             start_revision=None,
156
             end_revision=None,
157
             search=None,
158
             limit=None,
159
             show_diff=False):
160
    """Write out human-readable log of commits to this branch.
161
162
    This function is being retained for backwards compatibility but
163
    should not be extended with new parameters. Use the new Logger class
164
    instead, eg. Logger(branch, rqst).show(lf), adding parameters to the
4205.1.1 by Ian Clatworthy
log multiple files and directories (Ian Clatworthy)
165
    make_log_request_dict function.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
166
167
    :param lf: The LogFormatter object showing the output.
168
169
    :param specific_fileid: If not None, list only the commits affecting the
170
        specified file, rather than all commits.
171
172
    :param verbose: If True show added/changed/deleted/renamed files.
173
174
    :param direction: 'reverse' (default) is latest to earliest; 'forward' is
175
        earliest to latest.
176
177
    :param start_revision: If not None, only show revisions >= start_revision
178
179
    :param end_revision: If not None, only show revisions <= end_revision
180
181
    :param search: If not None, only show revisions with matching commit
182
        messages
183
184
    :param limit: If set, shows only 'limit' revisions, all revisions are shown
185
        if None or 0.
186
187
    :param show_diff: If True, output a diff after each revision.
188
    """
189
    # Convert old-style parameters to new-style parameters
190
    if specific_fileid is not None:
191
        file_ids = [specific_fileid]
192
    else:
193
        file_ids = None
194
    if verbose:
195
        if file_ids:
196
            delta_type = 'partial'
197
        else:
198
            delta_type = 'full'
199
    else:
200
        delta_type = None
201
    if show_diff:
202
        if file_ids:
203
            diff_type = 'partial'
204
        else:
205
            diff_type = 'full'
206
    else:
207
        diff_type = None
208
209
    # Build the request and execute it
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
210
    rqst = make_log_request_dict(direction=direction, specific_fileids=file_ids,
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
211
        start_revision=start_revision, end_revision=end_revision,
212
        limit=limit, message_search=search,
213
        delta_type=delta_type, diff_type=diff_type)
214
    Logger(branch, rqst).show(lf)
215
216
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
217
# Note: This needs to be kept this in sync with the defaults in
218
# make_log_request_dict() below
219
_DEFAULT_REQUEST_PARAMS = {
220
    'direction': 'reverse',
221
    'levels': 1,
222
    'generate_tags': True,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
223
    'exclude_common_ancestry': False,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
224
    '_match_using_deltas': True,
225
    }
226
227
228
def make_log_request_dict(direction='reverse', specific_fileids=None,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
229
                          start_revision=None, end_revision=None, limit=None,
230
                          message_search=None, levels=1, generate_tags=True,
231
                          delta_type=None,
232
                          diff_type=None, _match_using_deltas=True,
233
                          exclude_common_ancestry=False,
234
                          ):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
235
    """Convenience function for making a logging request dictionary.
236
237
    Using this function may make code slightly safer by ensuring
238
    parameters have the correct names. It also provides a reference
239
    point for documenting the supported parameters.
240
241
    :param direction: 'reverse' (default) is latest to earliest;
242
      'forward' is earliest to latest.
243
244
    :param specific_fileids: If not None, only include revisions
245
      affecting the specified files, rather than all revisions.
246
247
    :param start_revision: If not None, only generate
248
      revisions >= start_revision
249
250
    :param end_revision: If not None, only generate
251
      revisions <= end_revision
252
253
    :param limit: If set, generate only 'limit' revisions, all revisions
254
      are shown if None or 0.
255
256
    :param message_search: If not None, only include revisions with
257
      matching commit messages
258
259
    :param levels: the number of levels of revisions to
260
      generate; 1 for just the mainline; 0 for all levels.
261
262
    :param generate_tags: If True, include tags for matched revisions.
263
264
    :param delta_type: Either 'full', 'partial' or None.
265
      'full' means generate the complete delta - adds/deletes/modifies/etc;
266
      'partial' means filter the delta using specific_fileids;
267
      None means do not generate any delta.
268
269
    :param diff_type: Either 'full', 'partial' or None.
270
      'full' means generate the complete diff - adds/deletes/modifies/etc;
271
      'partial' means filter the diff using specific_fileids;
272
      None means do not generate any diff.
273
274
    :param _match_using_deltas: a private parameter controlling the
275
      algorithm used for matching specific_fileids. This parameter
276
      may be removed in the future so bzrlib client code should NOT
277
      use it.
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
278
279
    :param exclude_common_ancestry: Whether -rX..Y should be interpreted as a
280
      range operator or as a graph difference.
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
281
    """
282
    return {
283
        'direction': direction,
284
        'specific_fileids': specific_fileids,
285
        'start_revision': start_revision,
286
        'end_revision': end_revision,
287
        'limit': limit,
288
        'message_search': message_search,
289
        'levels': levels,
290
        'generate_tags': generate_tags,
291
        'delta_type': delta_type,
292
        'diff_type': diff_type,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
293
        'exclude_common_ancestry': exclude_common_ancestry,
4202.2.1 by Ian Clatworthy
get directory logging working again
294
        # Add 'private' attributes for features that may be deprecated
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
295
        '_match_using_deltas': _match_using_deltas,
296
    }
297
298
299
def _apply_log_request_defaults(rqst):
300
    """Apply default values to a request dictionary."""
301
    result = _DEFAULT_REQUEST_PARAMS
302
    if rqst:
303
        result.update(rqst)
304
    return result
4202.2.1 by Ian Clatworthy
get directory logging working again
305
306
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
307
class LogGenerator(object):
308
    """A generator of log revisions."""
309
310
    def iter_log_revisions(self):
311
        """Iterate over LogRevision objects.
312
313
        :return: An iterator yielding LogRevision objects.
314
        """
315
        raise NotImplementedError(self.iter_log_revisions)
316
317
318
class Logger(object):
4955.5.3 by Vincent Ladeuil
Cleanup.
319
    """An object that generates, formats and displays a log."""
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
320
321
    def __init__(self, branch, rqst):
322
        """Create a Logger.
323
324
        :param branch: the branch to log
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
325
        :param rqst: A dictionary specifying the query parameters.
326
          See make_log_request_dict() for supported values.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
327
        """
328
        self.branch = branch
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
329
        self.rqst = _apply_log_request_defaults(rqst)
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
330
331
    def show(self, lf):
332
        """Display the log.
333
334
        :param lf: The LogFormatter object to send the output to.
335
        """
336
        if not isinstance(lf, LogFormatter):
337
            warn("not a LogFormatter instance: %r" % lf)
338
339
        self.branch.lock_read()
340
        try:
341
            if getattr(lf, 'begin_log', None):
342
                lf.begin_log()
343
            self._show_body(lf)
344
            if getattr(lf, 'end_log', None):
345
                lf.end_log()
346
        finally:
347
            self.branch.unlock()
348
349
    def _show_body(self, lf):
350
        """Show the main log output.
351
352
        Subclasses may wish to override this.
353
        """
354
        # Tweak the LogRequest based on what the LogFormatter can handle.
355
        # (There's no point generating stuff if the formatter can't display it.)
356
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
357
        rqst['levels'] = lf.get_levels()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
358
        if not getattr(lf, 'supports_tags', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
359
            rqst['generate_tags'] = False
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
360
        if not getattr(lf, 'supports_delta', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
361
            rqst['delta_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
362
        if not getattr(lf, 'supports_diff', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
363
            rqst['diff_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
364
365
        # Find and print the interesting revisions
366
        generator = self._generator_factory(self.branch, rqst)
367
        for lr in generator.iter_log_revisions():
368
            lf.log_revision(lr)
4208.2.1 by Ian Clatworthy
merge indicators in log --long
369
        lf.show_advice()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
370
371
    def _generator_factory(self, branch, rqst):
372
        """Make the LogGenerator object to use.
373
        
374
        Subclasses may wish to override this.
375
        """
376
        return _DefaultLogGenerator(branch, rqst)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
377
378
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
379
class _StartNotLinearAncestor(Exception):
380
    """Raised when a start revision is not found walking left-hand history."""
381
382
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
383
class _DefaultLogGenerator(LogGenerator):
384
    """The default generator of log revisions."""
4202.2.1 by Ian Clatworthy
get directory logging working again
385
386
    def __init__(self, branch, rqst):
387
        self.branch = branch
388
        self.rqst = rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
389
        if rqst.get('generate_tags') and branch.supports_tags():
4202.2.1 by Ian Clatworthy
get directory logging working again
390
            self.rev_tag_dict = branch.tags.get_reverse_tag_dict()
391
        else:
392
            self.rev_tag_dict = {}
393
394
    def iter_log_revisions(self):
395
        """Iterate over LogRevision objects.
396
397
        :return: An iterator yielding LogRevision objects.
398
        """
399
        rqst = self.rqst
4379.4.1 by Ian Clatworthy
make log --long faster
400
        levels = rqst.get('levels')
401
        limit = rqst.get('limit')
402
        diff_type = rqst.get('diff_type')
4202.2.1 by Ian Clatworthy
get directory logging working again
403
        log_count = 0
404
        revision_iterator = self._create_log_revision_iterator()
405
        for revs in revision_iterator:
406
            for (rev_id, revno, merge_depth), rev, delta in revs:
407
                # 0 levels means show everything; merge_depth counts from 0
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
408
                if levels != 0 and merge_depth >= levels:
4202.2.1 by Ian Clatworthy
get directory logging working again
409
                    continue
4379.4.1 by Ian Clatworthy
make log --long faster
410
                if diff_type is None:
411
                    diff = None
412
                else:
413
                    diff = self._format_diff(rev, rev_id, diff_type)
4202.2.1 by Ian Clatworthy
get directory logging working again
414
                yield LogRevision(rev, revno, merge_depth, delta,
415
                    self.rev_tag_dict.get(rev_id), diff)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
416
                if limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
417
                    log_count += 1
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
418
                    if log_count >= limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
419
                        return
420
4379.4.1 by Ian Clatworthy
make log --long faster
421
    def _format_diff(self, rev, rev_id, diff_type):
4202.2.1 by Ian Clatworthy
get directory logging working again
422
        repo = self.branch.repository
423
        if len(rev.parent_ids) == 0:
424
            ancestor_id = _mod_revision.NULL_REVISION
425
        else:
426
            ancestor_id = rev.parent_ids[0]
427
        tree_1 = repo.revision_tree(ancestor_id)
428
        tree_2 = repo.revision_tree(rev_id)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
429
        file_ids = self.rqst.get('specific_fileids')
4202.2.1 by Ian Clatworthy
get directory logging working again
430
        if diff_type == 'partial' and file_ids is not None:
431
            specific_files = [tree_2.id2path(id) for id in file_ids]
432
        else:
433
            specific_files = None
434
        s = StringIO()
4797.57.10 by Alexander Belchenko
path_encoding selection logic extracted as helper function
435
        path_encoding = osutils.get_diff_header_encoding()
4202.2.1 by Ian Clatworthy
get directory logging working again
436
        diff.show_diff_trees(tree_1, tree_2, s, specific_files, old_label='',
4797.57.9 by Alexander Belchenko
using terminal_encoding for log -p
437
            new_label='', path_encoding=path_encoding)
4202.2.1 by Ian Clatworthy
get directory logging working again
438
        return s.getvalue()
439
440
    def _create_log_revision_iterator(self):
441
        """Create a revision iterator for log.
442
443
        :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
444
            delta).
445
        """
446
        self.start_rev_id, self.end_rev_id = _get_revision_limits(
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
447
            self.branch, self.rqst.get('start_revision'),
448
            self.rqst.get('end_revision'))
449
        if self.rqst.get('_match_using_deltas'):
4202.2.1 by Ian Clatworthy
get directory logging working again
450
            return self._log_revision_iterator_using_delta_matching()
451
        else:
452
            # We're using the per-file-graph algorithm. This scales really
453
            # well but only makes sense if there is a single file and it's
454
            # not a directory
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
455
            file_count = len(self.rqst.get('specific_fileids'))
4202.2.1 by Ian Clatworthy
get directory logging working again
456
            if file_count != 1:
457
                raise BzrError("illegal LogRequest: must match-using-deltas "
458
                    "when logging %d files" % file_count)
459
            return self._log_revision_iterator_using_per_file_graph()
460
461
    def _log_revision_iterator_using_delta_matching(self):
462
        # Get the base revisions, filtering by the revision range
463
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
464
        generate_merge_revisions = rqst.get('levels') != 1
465
        delayed_graph_generation = not rqst.get('specific_fileids') and (
466
                rqst.get('limit') or self.start_rev_id or self.end_rev_id)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
467
        view_revisions = _calc_view_revisions(
468
            self.branch, self.start_rev_id, self.end_rev_id,
469
            rqst.get('direction'),
470
            generate_merge_revisions=generate_merge_revisions,
471
            delayed_graph_generation=delayed_graph_generation,
472
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
4202.2.1 by Ian Clatworthy
get directory logging working again
473
474
        # Apply the other filters
475
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
476
            rqst.get('delta_type'), rqst.get('message_search'),
477
            file_ids=rqst.get('specific_fileids'),
478
            direction=rqst.get('direction'))
4202.2.1 by Ian Clatworthy
get directory logging working again
479
480
    def _log_revision_iterator_using_per_file_graph(self):
481
        # Get the base revisions, filtering by the revision range.
482
        # Note that we always generate the merge revisions because
483
        # filter_revisions_touching_file_id() requires them ...
484
        rqst = self.rqst
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
485
        view_revisions = _calc_view_revisions(
486
            self.branch, self.start_rev_id, self.end_rev_id,
487
            rqst.get('direction'), generate_merge_revisions=True,
488
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
489
        if not isinstance(view_revisions, list):
490
            view_revisions = list(view_revisions)
4202.2.1 by Ian Clatworthy
get directory logging working again
491
        view_revisions = _filter_revisions_touching_file_id(self.branch,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
492
            rqst.get('specific_fileids')[0], view_revisions,
493
            include_merges=rqst.get('levels') != 1)
4202.2.1 by Ian Clatworthy
get directory logging working again
494
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
495
            rqst.get('delta_type'), rqst.get('message_search'))
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
496
497
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
498
def _calc_view_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
499
                         generate_merge_revisions,
500
                         delayed_graph_generation=False,
501
                         exclude_common_ancestry=False,
502
                         ):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
503
    """Calculate the revisions to view.
504
505
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
506
             a list of the same tuples.
507
    """
5097.1.13 by Vincent Ladeuil
Add more tests.
508
    if (exclude_common_ancestry and start_rev_id == end_rev_id):
509
        raise errors.BzrCommandError(
510
            '--exclude-common-ancestry requires two different revisions')
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
511
    if direction not in ('reverse', 'forward'):
512
        raise ValueError('invalid direction %r' % direction)
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
513
    br_revno, br_rev_id = branch.last_revision_info()
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
514
    if br_revno == 0:
515
        return []
516
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
517
    if (end_rev_id and start_rev_id == end_rev_id
5129.1.3 by Vincent Ladeuil
Slightly refactor the direction handling in log.
518
        and (not generate_merge_revisions
519
             or not _has_merges(branch, end_rev_id))):
5097.1.13 by Vincent Ladeuil
Add more tests.
520
        # If a single revision is requested, check we can handle it
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
521
        iter_revs = _generate_one_revision(branch, end_rev_id, br_rev_id,
522
                                           br_revno)
523
    elif not generate_merge_revisions:
524
        # If we only want to see linear revisions, we can iterate ...
525
        iter_revs = _generate_flat_revisions(branch, start_rev_id, end_rev_id,
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
526
                                             direction, exclude_common_ancestry)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
527
        if direction == 'forward':
528
            iter_revs = reversed(iter_revs)
4202.2.1 by Ian Clatworthy
get directory logging working again
529
    else:
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
530
        iter_revs = _generate_all_revisions(branch, start_rev_id, end_rev_id,
531
                                            direction, delayed_graph_generation,
532
                                            exclude_common_ancestry)
533
        if direction == 'forward':
534
            iter_revs = _rebase_merge_depth(reverse_by_depth(list(iter_revs)))
535
    return iter_revs
4202.2.1 by Ian Clatworthy
get directory logging working again
536
537
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
538
def _generate_one_revision(branch, rev_id, br_rev_id, br_revno):
4202.2.1 by Ian Clatworthy
get directory logging working again
539
    if rev_id == br_rev_id:
540
        # It's the tip
541
        return [(br_rev_id, br_revno, 0)]
542
    else:
543
        revno = branch.revision_id_to_dotted_revno(rev_id)
544
        revno_str = '.'.join(str(n) for n in revno)
545
        return [(rev_id, revno_str, 0)]
546
547
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
548
def _generate_flat_revisions(branch, start_rev_id, end_rev_id, direction,
549
                             exclude_common_ancestry=False):
550
    result = _linear_view_revisions(
551
        branch, start_rev_id, end_rev_id,
552
        exclude_common_ancestry=exclude_common_ancestry)
4202.2.1 by Ian Clatworthy
get directory logging working again
553
    # If a start limit was given and it's not obviously an
554
    # ancestor of the end limit, check it before outputting anything
555
    if direction == 'forward' or (start_rev_id
556
        and not _is_obvious_ancestor(branch, start_rev_id, end_rev_id)):
557
        try:
558
            result = list(result)
559
        except _StartNotLinearAncestor:
560
            raise errors.BzrCommandError('Start revision not found in'
561
                ' left-hand history of end revision.')
562
    return result
563
564
565
def _generate_all_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
566
                            delayed_graph_generation,
567
                            exclude_common_ancestry=False):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
568
    # On large trees, generating the merge graph can take 30-60 seconds
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
569
    # so we delay doing it until a merge is detected, incrementally
4955.7.5 by Vincent Ladeuil
Fixed as per Ian's review.
570
    # returning initial (non-merge) revisions while we can.
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
571
572
    # The above is only true for old formats (<= 0.92), for newer formats, a
573
    # couple of seconds only should be needed to load the whole graph and the
574
    # other graph operations needed are even faster than that -- vila 100201
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
575
    initial_revisions = []
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
576
    if delayed_graph_generation:
577
        try:
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
578
            for rev_id, revno, depth in  _linear_view_revisions(
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
579
                branch, start_rev_id, end_rev_id, exclude_common_ancestry):
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
580
                if _has_merges(branch, rev_id):
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
581
                    # The end_rev_id can be nested down somewhere. We need an
582
                    # explicit ancestry check. There is an ambiguity here as we
583
                    # may not raise _StartNotLinearAncestor for a revision that
584
                    # is an ancestor but not a *linear* one. But since we have
585
                    # loaded the graph to do the check (or calculate a dotted
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
586
                    # revno), we may as well accept to show the log...  We need
587
                    # the check only if start_rev_id is not None as all
588
                    # revisions have _mod_revision.NULL_REVISION as an ancestor
589
                    # -- vila 20100319
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
590
                    graph = branch.repository.get_graph()
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
591
                    if (start_rev_id is not None
592
                        and not graph.is_ancestor(start_rev_id, end_rev_id)):
593
                        raise _StartNotLinearAncestor()
5097.1.1 by Vincent Ladeuil
Reduce duplication.
594
                    # Since we collected the revisions so far, we need to
595
                    # adjust end_rev_id.
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
596
                    end_rev_id = rev_id
597
                    break
598
                else:
599
                    initial_revisions.append((rev_id, revno, depth))
600
            else:
601
                # No merged revisions found
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
602
                return initial_revisions
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
603
        except _StartNotLinearAncestor:
604
            # A merge was never detected so the lower revision limit can't
605
            # be nested down somewhere
606
            raise errors.BzrCommandError('Start revision not found in'
607
                ' history of end revision.')
3936.3.15 by Ian Clatworthy
faster long log for a limited range with no merges
608
5097.1.1 by Vincent Ladeuil
Reduce duplication.
609
    # We exit the loop above because we encounter a revision with merges, from
610
    # this revision, we need to switch to _graph_view_revisions.
611
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
612
    # A log including nested merges is required. If the direction is reverse,
613
    # we rebase the initial merge depths so that the development line is
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
614
    # shown naturally, i.e. just like it is for linear logging. We can easily
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
615
    # make forward the exact opposite display, but showing the merge revisions
616
    # indented at the end seems slightly nicer in that case.
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
617
    view_revisions = chain(iter(initial_revisions),
618
        _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
619
                              rebase_initial_depths=(direction == 'reverse'),
620
                              exclude_common_ancestry=exclude_common_ancestry))
621
    return view_revisions
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
622
530 by Martin Pool
- put back verbose log support for reversed logs
623
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
624
def _has_merges(branch, rev_id):
625
    """Does a revision have multiple parents or not?"""
3936.3.40 by Ian Clatworthy
review feedback from jam
626
    parents = branch.repository.get_parent_map([rev_id]).get(rev_id, [])
627
    return len(parents) > 1
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
628
629
3936.3.31 by Ian Clatworthy
nicer obvious ancestor checking
630
def _is_obvious_ancestor(branch, start_rev_id, end_rev_id):
631
    """Is start_rev_id an obvious ancestor of end_rev_id?"""
632
    if start_rev_id and end_rev_id:
633
        start_dotted = branch.revision_id_to_dotted_revno(start_rev_id)
634
        end_dotted = branch.revision_id_to_dotted_revno(end_rev_id)
635
        if len(start_dotted) == 1 and len(end_dotted) == 1:
636
            # both on mainline
637
            return start_dotted[0] <= end_dotted[0]
638
        elif (len(start_dotted) == 3 and len(end_dotted) == 3 and
639
            start_dotted[0:1] == end_dotted[0:1]):
640
            # both on same development line
641
            return start_dotted[2] <= end_dotted[2]
642
        else:
643
            # not obvious
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
644
            return False
4955.5.3 by Vincent Ladeuil
Cleanup.
645
    # if either start or end is not specified then we use either the first or
646
    # the last revision and *they* are obvious ancestors.
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
647
    return True
648
649
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
650
def _linear_view_revisions(branch, start_rev_id, end_rev_id,
651
                           exclude_common_ancestry=False):
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
652
    """Calculate a sequence of revisions to view, newest to oldest.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
653
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
654
    :param start_rev_id: the lower revision-id
655
    :param end_rev_id: the upper revision-id
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
656
    :param exclude_common_ancestry: Whether the start_rev_id should be part of
657
        the iterated revisions.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
658
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
659
    :raises _StartNotLinearAncestor: if a start_rev_id is specified but
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
660
        is not found walking the left-hand history
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
661
    """
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
662
    br_revno, br_rev_id = branch.last_revision_info()
3943.4.5 by John Arbash Meinel
Restore _linear_view_revisions.
663
    repo = branch.repository
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
664
    if start_rev_id is None and end_rev_id is None:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
665
        cur_revno = br_revno
666
        for revision_id in repo.iter_reverse_revision_history(br_rev_id):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
667
            yield revision_id, str(cur_revno), 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
668
            cur_revno -= 1
3936.3.14 by Ian Clatworthy
bug fix
669
    else:
670
        if end_rev_id is None:
671
            end_rev_id = br_rev_id
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
672
        found_start = start_rev_id is None
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
673
        for revision_id in repo.iter_reverse_revision_history(end_rev_id):
3936.3.26 by Ian Clatworthy
use new dotted-revno-revision-id conversion methods to simplify & speed up code
674
            revno = branch.revision_id_to_dotted_revno(revision_id)
675
            revno_str = '.'.join(str(n) for n in revno)
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
676
            if not found_start and revision_id == start_rev_id:
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
677
                if not exclude_common_ancestry:
678
                    yield revision_id, revno_str, 0
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
679
                found_start = True
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
680
                break
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
681
            else:
682
                yield revision_id, revno_str, 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
683
        else:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
684
            if not found_start:
685
                raise _StartNotLinearAncestor()
3302.1.3 by Aaron Bentley
Add optimization of the simple case of generating view revisions
686
687
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
688
def _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
689
                          rebase_initial_depths=True,
690
                          exclude_common_ancestry=False):
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
691
    """Calculate revisions to view including merges, newest to oldest.
692
693
    :param branch: the branch
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
694
    :param start_rev_id: the lower revision-id
695
    :param end_rev_id: the upper revision-id
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
696
    :param rebase_initial_depth: should depths be rebased until a mainline
697
      revision is found?
698
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
699
    """
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
700
    if exclude_common_ancestry:
701
        stop_rule = 'with-merges-without-common-ancestry'
702
    else:
703
        stop_rule = 'with-merges'
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
704
    view_revisions = branch.iter_merge_sorted_revisions(
705
        start_revision_id=end_rev_id, stop_revision_id=start_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
706
        stop_rule=stop_rule)
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
707
    if not rebase_initial_depths:
708
        for (rev_id, merge_depth, revno, end_of_merge
709
             ) in view_revisions:
710
            yield rev_id, '.'.join(map(str, revno)), merge_depth
711
    else:
712
        # We're following a development line starting at a merged revision.
713
        # We need to adjust depths down by the initial depth until we find
714
        # a depth less than it. Then we use that depth as the adjustment.
715
        # If and when we reach the mainline, depth adjustment ends.
716
        depth_adjustment = None
717
        for (rev_id, merge_depth, revno, end_of_merge
718
             ) in view_revisions:
719
            if depth_adjustment is None:
720
                depth_adjustment = merge_depth
721
            if depth_adjustment:
722
                if merge_depth < depth_adjustment:
4955.5.3 by Vincent Ladeuil
Cleanup.
723
                    # From now on we reduce the depth adjustement, this can be
724
                    # surprising for users. The alternative requires two passes
725
                    # which breaks the fast display of the first revision
726
                    # though.
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
727
                    depth_adjustment = merge_depth
728
                merge_depth -= depth_adjustment
729
            yield rev_id, '.'.join(map(str, revno)), merge_depth
730
731
4955.4.14 by Vincent Ladeuil
Properly deprecate log.calculate_view_revisions.
732
@deprecated_function(deprecated_in((2, 2, 0)))
3936.3.13 by Ian Clatworthy
feedback from jameinel
733
def calculate_view_revisions(branch, start_revision, end_revision, direction,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
734
        specific_fileid, generate_merge_revisions):
3936.3.13 by Ian Clatworthy
feedback from jameinel
735
    """Calculate the revisions to view.
736
737
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
738
             a list of the same tuples.
739
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
740
    start_rev_id, end_rev_id = _get_revision_limits(branch, start_revision,
741
        end_revision)
742
    view_revisions = list(_calc_view_revisions(branch, start_rev_id, end_rev_id,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
743
        direction, generate_merge_revisions or specific_fileid))
3936.3.13 by Ian Clatworthy
feedback from jameinel
744
    if specific_fileid:
745
        view_revisions = _filter_revisions_touching_file_id(branch,
746
            specific_fileid, view_revisions,
747
            include_merges=generate_merge_revisions)
3936.3.28 by Ian Clatworthy
api compatibility: calculate_view_revisions rebases merge depth again
748
    return _rebase_merge_depth(view_revisions)
3936.3.13 by Ian Clatworthy
feedback from jameinel
749
750
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
751
def _rebase_merge_depth(view_revisions):
752
    """Adjust depths upwards so the top level is 0."""
753
    # If either the first or last revision have a merge_depth of 0, we're done
754
    if view_revisions and view_revisions[0][2] and view_revisions[-1][2]:
755
        min_depth = min([d for r,n,d in view_revisions])
756
        if min_depth != 0:
757
            view_revisions = [(r,n,d-min_depth) for r,n,d in view_revisions]
758
    return view_revisions
759
760
3936.3.16 by Ian Clatworthy
use deltas to match files in selected use cases
761
def make_log_rev_iterator(branch, view_revisions, generate_delta, search,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
762
        file_ids=None, direction='reverse'):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
763
    """Create a revision iterator for log.
764
765
    :param branch: The branch being logged.
766
    :param view_revisions: The revisions being viewed.
767
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
768
      Permitted values are None, 'full' and 'partial'.
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
769
    :param search: A user text search string.
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
770
    :param file_ids: If non empty, only revisions matching one or more of
771
      the file-ids are to be kept.
772
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
773
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
774
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
775
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
776
    # Convert view_revisions into (view, None, None) groups to fit with
777
    # the standard interface here.
778
    if type(view_revisions) == list:
3642.1.7 by Robert Collins
Review feedback.
779
        # A single batch conversion is faster than many incremental ones.
780
        # As we have all the data, do a batch conversion.
3642.1.5 by Robert Collins
Separate out batching of revisions.
781
        nones = [None] * len(view_revisions)
782
        log_rev_iterator = iter([zip(view_revisions, nones, nones)])
783
    else:
784
        def _convert():
785
            for view in view_revisions:
786
                yield (view, None, None)
787
        log_rev_iterator = iter([_convert()])
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
788
    for adapter in log_adapters:
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
789
        # It would be nicer if log adapters were first class objects
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
790
        # with custom parameters. This will do for now. IGC 20090127
791
        if adapter == _make_delta_filter:
792
            log_rev_iterator = adapter(branch, generate_delta,
793
                search, log_rev_iterator, file_ids, direction)
794
        else:
795
            log_rev_iterator = adapter(branch, generate_delta,
796
                search, log_rev_iterator)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
797
    return log_rev_iterator
798
799
3642.1.7 by Robert Collins
Review feedback.
800
def _make_search_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
801
    """Create a filtered iterator of log_rev_iterator matching on a regex.
802
803
    :param branch: The branch being logged.
804
    :param generate_delta: Whether to generate a delta for each revision.
805
    :param search: A user text search string.
806
    :param log_rev_iterator: An input iterator containing all revisions that
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
807
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
808
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
809
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
810
    """
811
    if search is None:
812
        return log_rev_iterator
5326.2.1 by Parth Malwankar
added InvalidPattern error.
813
    searchRE = re.compile(search, re.IGNORECASE)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
814
    return _filter_message_re(searchRE, log_rev_iterator)
815
816
817
def _filter_message_re(searchRE, log_rev_iterator):
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
818
    for revs in log_rev_iterator:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
819
        new_revs = []
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
820
        for (rev_id, revno, merge_depth), rev, delta in revs:
821
            if searchRE.search(rev.message):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
822
                new_revs.append(((rev_id, revno, merge_depth), rev, delta))
823
        yield new_revs
824
825
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
826
def _make_delta_filter(branch, generate_delta, search, log_rev_iterator,
827
    fileids=None, direction='reverse'):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
828
    """Add revision deltas to a log iterator if needed.
829
830
    :param branch: The branch being logged.
831
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
832
      Permitted values are None, 'full' and 'partial'.
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
833
    :param search: A user text search string.
834
    :param log_rev_iterator: An input iterator containing all revisions that
835
        could be displayed, in lists.
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
836
    :param fileids: If non empty, only revisions matching one or more of
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
837
      the file-ids are to be kept.
838
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
839
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
840
        delta).
841
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
842
    if not generate_delta and not fileids:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
843
        return log_rev_iterator
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
844
    return _generate_deltas(branch.repository, log_rev_iterator,
845
        generate_delta, fileids, direction)
846
847
4202.2.1 by Ian Clatworthy
get directory logging working again
848
def _generate_deltas(repository, log_rev_iterator, delta_type, fileids,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
849
    direction):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
850
    """Create deltas for each batch of revisions in log_rev_iterator.
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
851
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
852
    If we're only generating deltas for the sake of filtering against
853
    file-ids, we stop generating deltas once all file-ids reach the
854
    appropriate life-cycle point. If we're receiving data newest to
855
    oldest, then that life-cycle point is 'add', otherwise it's 'remove'.
856
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
857
    check_fileids = fileids is not None and len(fileids) > 0
858
    if check_fileids:
859
        fileid_set = set(fileids)
860
        if direction == 'reverse':
861
            stop_on = 'add'
862
        else:
863
            stop_on = 'remove'
864
    else:
865
        fileid_set = None
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
866
    for revs in log_rev_iterator:
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
867
        # If we were matching against fileids and we've run out,
3936.3.40 by Ian Clatworthy
review feedback from jam
868
        # there's nothing left to do
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
869
        if check_fileids and not fileid_set:
3936.3.40 by Ian Clatworthy
review feedback from jam
870
            return
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
871
        revisions = [rev[1] for rev in revs]
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
872
        new_revs = []
4202.2.1 by Ian Clatworthy
get directory logging working again
873
        if delta_type == 'full' and not check_fileids:
874
            deltas = repository.get_deltas_for_revisions(revisions)
875
            for rev, delta in izip(revs, deltas):
876
                new_revs.append((rev[0], rev[1], delta))
877
        else:
878
            deltas = repository.get_deltas_for_revisions(revisions, fileid_set)
879
            for rev, delta in izip(revs, deltas):
880
                if check_fileids:
881
                    if delta is None or not delta.has_changed():
882
                        continue
883
                    else:
884
                        _update_fileids(delta, fileid_set, stop_on)
885
                        if delta_type is None:
886
                            delta = None
887
                        elif delta_type == 'full':
888
                            # If the file matches all the time, rebuilding
889
                            # a full delta like this in addition to a partial
4202.2.4 by Ian Clatworthy
comment tweak from vila's review
890
                            # one could be slow. However, it's likely that
4202.2.1 by Ian Clatworthy
get directory logging working again
891
                            # most revisions won't get this far, making it
892
                            # faster to filter on the partial deltas and
893
                            # build the occasional full delta than always
894
                            # building full deltas and filtering those.
895
                            rev_id = rev[0][0]
896
                            delta = repository.get_revision_delta(rev_id)
897
                new_revs.append((rev[0], rev[1], delta))
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
898
        yield new_revs
899
900
4202.2.1 by Ian Clatworthy
get directory logging working again
901
def _update_fileids(delta, fileids, stop_on):
902
    """Update the set of file-ids to search based on file lifecycle events.
903
    
904
    :param fileids: a set of fileids to update
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
905
    :param stop_on: either 'add' or 'remove' - take file-ids out of the
906
      fileids set once their add or remove entry is detected respectively
907
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
908
    if stop_on == 'add':
909
        for item in delta.added:
910
            if item[1] in fileids:
911
                fileids.remove(item[1])
912
    elif stop_on == 'delete':
913
        for item in delta.removed:
914
            if item[1] in fileids:
915
                fileids.remove(item[1])
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
916
917
3642.1.7 by Robert Collins
Review feedback.
918
def _make_revision_objects(branch, generate_delta, search, log_rev_iterator):
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
919
    """Extract revision objects from the repository
920
921
    :param branch: The branch being logged.
922
    :param generate_delta: Whether to generate a delta for each revision.
923
    :param search: A user text search string.
924
    :param log_rev_iterator: An input iterator containing all revisions that
925
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
926
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
927
        delta).
928
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
929
    repository = branch.repository
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
930
    for revs in log_rev_iterator:
931
        # r = revision_id, n = revno, d = merge depth
932
        revision_ids = [view[0] for view, _, _ in revs]
933
        revisions = repository.get_revisions(revision_ids)
934
        revs = [(rev[0], revision, rev[2]) for rev, revision in
935
            izip(revs, revisions)]
936
        yield revs
937
938
3642.1.7 by Robert Collins
Review feedback.
939
def _make_batch_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.5 by Robert Collins
Separate out batching of revisions.
940
    """Group up a single large batch into smaller ones.
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
941
942
    :param branch: The branch being logged.
943
    :param generate_delta: Whether to generate a delta for each revision.
944
    :param search: A user text search string.
3642.1.5 by Robert Collins
Separate out batching of revisions.
945
    :param log_rev_iterator: An input iterator containing all revisions that
946
        could be displayed, in lists.
3874.2.4 by Vincent Ladeuil
Fix too long lines.
947
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
948
        delta).
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
949
    """
950
    repository = branch.repository
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
951
    num = 9
3642.1.5 by Robert Collins
Separate out batching of revisions.
952
    for batch in log_rev_iterator:
953
        batch = iter(batch)
954
        while True:
955
            step = [detail for _, detail in zip(range(num), batch)]
956
            if len(step) == 0:
957
                break
958
            yield step
959
            num = min(int(num * 1.5), 200)
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
960
961
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
962
def _get_revision_limits(branch, start_revision, end_revision):
963
    """Get and check revision limits.
964
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
965
    :param  branch: The branch containing the revisions.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
966
967
    :param  start_revision: The first revision to be logged.
968
            For backwards compatibility this may be a mainline integer revno,
969
            but for merge revision support a RevisionInfo is expected.
970
971
    :param  end_revision: The last revision to be logged.
972
            For backwards compatibility this may be a mainline integer revno,
973
            but for merge revision support a RevisionInfo is expected.
974
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
975
    :return: (start_rev_id, end_rev_id) tuple.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
976
    """
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
977
    branch_revno, branch_rev_id = branch.last_revision_info()
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
978
    start_rev_id = None
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
979
    if start_revision is None:
980
        start_revno = 1
981
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
982
        if isinstance(start_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
983
            start_rev_id = start_revision.rev_id
984
            start_revno = start_revision.revno or 1
985
        else:
986
            branch.check_real_revno(start_revision)
987
            start_revno = start_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
988
            start_rev_id = branch.get_rev_id(start_revno)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
989
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
990
    end_rev_id = None
991
    if end_revision is None:
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
992
        end_revno = branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
993
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
994
        if isinstance(end_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
995
            end_rev_id = end_revision.rev_id
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
996
            end_revno = end_revision.revno or branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
997
        else:
998
            branch.check_real_revno(end_revision)
999
            end_revno = end_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
1000
            end_rev_id = branch.get_rev_id(end_revno)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1001
3936.3.4 by Ian Clatworthy
fix empty_branch log
1002
    if branch_revno != 0:
1003
        if (start_rev_id == _mod_revision.NULL_REVISION
1004
            or end_rev_id == _mod_revision.NULL_REVISION):
1005
            raise errors.BzrCommandError('Logging revision 0 is invalid.')
1006
        if start_revno > end_revno:
1007
            raise errors.BzrCommandError("Start revision must be older than "
1008
                                         "the end revision.")
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1009
    return (start_rev_id, end_rev_id)
1010
1011
1012
def _get_mainline_revs(branch, start_revision, end_revision):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1013
    """Get the mainline revisions from the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1014
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1015
    Generates the list of mainline revisions for the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1016
1017
    :param  branch: The branch containing the revisions.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1018
1019
    :param  start_revision: The first revision to be logged.
1020
            For backwards compatibility this may be a mainline integer revno,
1021
            but for merge revision support a RevisionInfo is expected.
1022
1023
    :param  end_revision: The last revision to be logged.
1024
            For backwards compatibility this may be a mainline integer revno,
1025
            but for merge revision support a RevisionInfo is expected.
1026
1027
    :return: A (mainline_revs, rev_nos, start_rev_id, end_rev_id) tuple.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1028
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1029
    branch_revno, branch_last_revision = branch.last_revision_info()
1030
    if branch_revno == 0:
1031
        return None, None, None, None
1032
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1033
    # For mainline generation, map start_revision and end_revision to
1034
    # mainline revnos. If the revision is not on the mainline choose the
1035
    # appropriate extreme of the mainline instead - the extra will be
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1036
    # filtered later.
1037
    # Also map the revisions to rev_ids, to be used in the later filtering
1038
    # stage.
1039
    start_rev_id = None
1040
    if start_revision is None:
1041
        start_revno = 1
1042
    else:
1043
        if isinstance(start_revision, revisionspec.RevisionInfo):
1044
            start_rev_id = start_revision.rev_id
1045
            start_revno = start_revision.revno or 1
1046
        else:
1047
            branch.check_real_revno(start_revision)
1048
            start_revno = start_revision
1049
1050
    end_rev_id = None
1051
    if end_revision is None:
1052
        end_revno = branch_revno
1053
    else:
1054
        if isinstance(end_revision, revisionspec.RevisionInfo):
1055
            end_rev_id = end_revision.rev_id
1056
            end_revno = end_revision.revno or branch_revno
1057
        else:
1058
            branch.check_real_revno(end_revision)
1059
            end_revno = end_revision
1060
1061
    if ((start_rev_id == _mod_revision.NULL_REVISION)
1062
        or (end_rev_id == _mod_revision.NULL_REVISION)):
1063
        raise errors.BzrCommandError('Logging revision 0 is invalid.')
1064
    if start_revno > end_revno:
1065
        raise errors.BzrCommandError("Start revision must be older than "
1066
                                     "the end revision.")
1067
1068
    if end_revno < start_revno:
1069
        return None, None, None, None
1070
    cur_revno = branch_revno
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1071
    rev_nos = {}
1072
    mainline_revs = []
1073
    for revision_id in branch.repository.iter_reverse_revision_history(
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1074
                        branch_last_revision):
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1075
        if cur_revno < start_revno:
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1076
            # We have gone far enough, but we always add 1 more revision
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1077
            rev_nos[revision_id] = cur_revno
1078
            mainline_revs.append(revision_id)
1079
            break
1080
        if cur_revno <= end_revno:
1081
            rev_nos[revision_id] = cur_revno
1082
            mainline_revs.append(revision_id)
1083
        cur_revno -= 1
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1084
    else:
1085
        # We walked off the edge of all revisions, so we add a 'None' marker
1086
        mainline_revs.append(None)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1087
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1088
    mainline_revs.reverse()
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1089
1090
    # override the mainline to look like the revision history.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1091
    return mainline_revs, rev_nos, start_rev_id, end_rev_id
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1092
1093
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1094
@deprecated_function(deprecated_in((2, 2, 0)))
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1095
def _filter_revision_range(view_revisions, start_rev_id, end_rev_id):
1096
    """Filter view_revisions based on revision ranges.
1097
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1098
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1099
            tuples to be filtered.
1100
1101
    :param start_rev_id: If not NONE specifies the first revision to be logged.
1102
            If NONE then all revisions up to the end_rev_id are logged.
1103
1104
    :param end_rev_id: If not NONE specifies the last revision to be logged.
1105
            If NONE then all revisions up to the end of the log are logged.
1106
1107
    :return: The filtered view_revisions.
1108
    """
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1109
    if start_rev_id or end_rev_id:
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1110
        revision_ids = [r for r, n, d in view_revisions]
1111
        if start_rev_id:
1112
            start_index = revision_ids.index(start_rev_id)
1113
        else:
1114
            start_index = 0
1115
        if start_rev_id == end_rev_id:
1116
            end_index = start_index
1117
        else:
1118
            if end_rev_id:
1119
                end_index = revision_ids.index(end_rev_id)
1120
            else:
1121
                end_index = len(view_revisions) - 1
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1122
        # To include the revisions merged into the last revision,
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1123
        # extend end_rev_id down to, but not including, the next rev
1124
        # with the same or lesser merge_depth
1125
        end_merge_depth = view_revisions[end_index][2]
1126
        try:
1127
            for index in xrange(end_index+1, len(view_revisions)+1):
1128
                if view_revisions[index][2] <= end_merge_depth:
1129
                    end_index = index - 1
1130
                    break
1131
        except IndexError:
1132
            # if the search falls off the end then log to the end as well
1133
            end_index = len(view_revisions) - 1
1134
        view_revisions = view_revisions[start_index:end_index+1]
1135
    return view_revisions
1136
1137
3940.1.3 by Ian Clatworthy
fix code
1138
def _filter_revisions_touching_file_id(branch, file_id, view_revisions,
1139
    include_merges=True):
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1140
    r"""Return the list of revision ids which touch a given file id.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1141
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1142
    The function filters view_revisions and returns a subset.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1143
    This includes the revisions which directly change the file id,
1144
    and the revisions which merge these changes. So if the
1145
    revision graph is::
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1146
        A-.
1147
        |\ \
1148
        B C E
1149
        |/ /
1150
        D |
1151
        |\|
1152
        | F
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1153
        |/
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1154
        G
1155
1156
    And 'C' changes a file, then both C and D will be returned. F will not be
1157
    returned even though it brings the changes to C into the branch starting
1158
    with E. (Note that if we were using F as the tip instead of G, then we
1159
    would see C, D, F.)
1160
1161
    This will also be restricted based on a subset of the mainline.
1162
1163
    :param branch: The branch where we can get text revision information.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1164
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1165
    :param file_id: Filter out revisions that do not touch file_id.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1166
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1167
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
1168
        tuples. This is the list of revisions which will be filtered. It is
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1169
        assumed that view_revisions is in merge_sort order (i.e. newest
1170
        revision first ).
1171
3940.1.3 by Ian Clatworthy
fix code
1172
    :param include_merges: include merge revisions in the result or not
1173
2359.1.8 by John Arbash Meinel
doc
1174
    :return: A list of (revision_id, dotted_revno, merge_depth) tuples.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1175
    """
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1176
    # Lookup all possible text keys to determine which ones actually modified
1177
    # the file.
1178
    text_keys = [(file_id, rev_id) for rev_id, revno, depth in view_revisions]
4183.3.1 by Vincent Ladeuil
Fix bug #346431 by allowing log._filter_revisions_touching_file_id to be
1179
    next_keys = None
3711.3.16 by John Arbash Meinel
Doc update.
1180
    # Looking up keys in batches of 1000 can cut the time in half, as well as
1181
    # memory consumption. GraphIndex *does* like to look for a few keys in
1182
    # parallel, it just doesn't like looking for *lots* of keys in parallel.
3711.3.19 by John Arbash Meinel
Add a TODO discussing how our index requests should evolve.
1183
    # TODO: This code needs to be re-evaluated periodically as we tune the
1184
    #       indexing layer. We might consider passing in hints as to the known
1185
    #       access pattern (sparse/clustered, high success rate/low success
1186
    #       rate). This particular access is clustered with a low success rate.
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1187
    get_parent_map = branch.repository.texts.get_parent_map
1188
    modified_text_revisions = set()
1189
    chunk_size = 1000
1190
    for start in xrange(0, len(text_keys), chunk_size):
1191
        next_keys = text_keys[start:start + chunk_size]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1192
        # Only keep the revision_id portion of the key
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1193
        modified_text_revisions.update(
1194
            [k[1] for k in get_parent_map(next_keys)])
1195
    del text_keys, next_keys
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1196
1197
    result = []
1198
    # Track what revisions will merge the current revision, replace entries
1199
    # with 'None' when they have been added to result
1200
    current_merge_stack = [None]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1201
    for info in view_revisions:
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1202
        rev_id, revno, depth = info
1203
        if depth == len(current_merge_stack):
1204
            current_merge_stack.append(info)
1205
        else:
1206
            del current_merge_stack[depth + 1:]
1207
            current_merge_stack[-1] = info
1208
1209
        if rev_id in modified_text_revisions:
1210
            # This needs to be logged, along with the extra revisions
1211
            for idx in xrange(len(current_merge_stack)):
1212
                node = current_merge_stack[idx]
1213
                if node is not None:
3940.1.3 by Ian Clatworthy
fix code
1214
                    if include_merges or node[2] == 0:
1215
                        result.append(node)
1216
                        current_merge_stack[idx] = None
3711.3.4 by John Arbash Meinel
Significantly faster, but consuming more memory.
1217
    return result
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1218
1219
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1220
@deprecated_function(deprecated_in((2, 2, 0)))
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1221
def get_view_revisions(mainline_revs, rev_nos, branch, direction,
1756.2.22 by Aaron Bentley
Apply review comments
1222
                       include_merges=True):
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1223
    """Produce an iterator of revisions to show
1224
    :return: an iterator of (revision_id, revno, merge_depth)
1225
    (if there is no revno for a revision, None is supplied)
1226
    """
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1227
    if not include_merges:
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1228
        revision_ids = mainline_revs[1:]
1229
        if direction == 'reverse':
1230
            revision_ids.reverse()
1231
        for revision_id in revision_ids:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1232
            yield revision_id, str(rev_nos[revision_id]), 0
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1233
        return
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1234
    graph = branch.repository.get_graph()
1235
    # This asks for all mainline revisions, which means we only have to spider
1236
    # sideways, rather than depth history. That said, its still size-of-history
1237
    # and should be addressed.
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1238
    # mainline_revisions always includes an extra revision at the beginning, so
1239
    # don't request it.
3287.6.8 by Robert Collins
Reduce code duplication as per review.
1240
    parent_map = dict(((key, value) for key, value in
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1241
        graph.iter_ancestry(mainline_revs[1:]) if value is not None))
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1242
    # filter out ghosts; merge_sort errors on ghosts.
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
1243
    rev_graph = _mod_repository._strip_NULL_ghosts(parent_map)
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1244
    merge_sorted_revisions = tsort.merge_sort(
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1245
        rev_graph,
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1246
        mainline_revs[-1],
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1247
        mainline_revs,
1248
        generate_revno=True)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1249
1250
    if direction == 'forward':
1251
        # forward means oldest first.
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1252
        merge_sorted_revisions = reverse_by_depth(merge_sorted_revisions)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1253
    elif direction != 'reverse':
1254
        raise ValueError('invalid direction %r' % direction)
1255
3874.2.4 by Vincent Ladeuil
Fix too long lines.
1256
    for (sequence, rev_id, merge_depth, revno, end_of_merge
1257
         ) in merge_sorted_revisions:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1258
        yield rev_id, '.'.join(map(str, revno)), merge_depth
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1259
1260
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1261
def reverse_by_depth(merge_sorted_revisions, _depth=0):
1262
    """Reverse revisions by depth.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1263
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1264
    Revisions with a different depth are sorted as a group with the previous
1265
    revision of that depth.  There may be no topological justification for this,
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1266
    but it looks much nicer.
1267
    """
3842.2.6 by Vincent Ladeuil
Fix typo.
1268
    # Add a fake revision at start so that we can always attach sub revisions
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1269
    merge_sorted_revisions = [(None, None, _depth)] + merge_sorted_revisions
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1270
    zd_revisions = []
1271
    for val in merge_sorted_revisions:
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1272
        if val[2] == _depth:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1273
            # Each revision at the current depth becomes a chunk grouping all
1274
            # higher depth revisions.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1275
            zd_revisions.append([val])
1276
        else:
1277
            zd_revisions[-1].append(val)
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1278
    for revisions in zd_revisions:
1279
        if len(revisions) > 1:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1280
            # We have higher depth revisions, let reverse them locally
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1281
            revisions[1:] = reverse_by_depth(revisions[1:], _depth + 1)
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1282
    zd_revisions.reverse()
1283
    result = []
1284
    for chunk in zd_revisions:
1285
        result.extend(chunk)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1286
    if _depth == 0:
1287
        # Top level call, get rid of the fake revisions that have been added
1288
        result = [r for r in result if r[0] is not None and r[1] is not None]
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1289
    return result
1290
1291
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1292
class LogRevision(object):
1293
    """A revision to be logged (by LogFormatter.log_revision).
1294
1295
    A simple wrapper for the attributes of a revision to be logged.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1296
    The attributes may or may not be populated, as determined by the
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1297
    logging options and the log formatter capabilities.
1298
    """
1299
2490.1.2 by John Arbash Meinel
Cleanup according to PEP8 and some other small whitespace fixes
1300
    def __init__(self, rev=None, revno=None, merge_depth=0, delta=None,
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1301
                 tags=None, diff=None):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1302
        self.rev = rev
3936.3.39 by Ian Clatworthy
merge bzr.dev r3975
1303
        self.revno = str(revno)
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1304
        self.merge_depth = merge_depth
1305
        self.delta = delta
1306
        self.tags = tags
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1307
        self.diff = diff
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1308
1309
794 by Martin Pool
- Merge John's nice short-log format.
1310
class LogFormatter(object):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1311
    """Abstract class to display log messages.
1312
1313
    At a minimum, a derived class must implement the log_revision method.
1314
1315
    If the LogFormatter needs to be informed of the beginning or end of
1316
    a log it should implement the begin_log and/or end_log hook methods.
1317
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1318
    A LogFormatter should define the following supports_XXX flags
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1319
    to indicate which LogRevision attributes it supports:
1320
1321
    - supports_delta must be True if this log formatter supports delta.
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1322
        Otherwise the delta attribute may not be populated.  The 'delta_format'
1323
        attribute describes whether the 'short_status' format (1) or the long
3936.3.2 by Ian Clatworthy
minor cleanups
1324
        one (2) should be used.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1325
1326
    - supports_merge_revisions must be True if this log formatter supports
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
1327
        merge revisions.  If not, then only mainline revisions will be passed
1328
        to the formatter.
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1329
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1330
    - preferred_levels is the number of levels this formatter defaults to.
1331
        The default value is zero meaning display all levels.
1332
        This value is only relevant if supports_merge_revisions is True.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1333
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1334
    - supports_tags must be True if this log formatter supports tags.
1335
        Otherwise the tags attribute may not be populated.
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1336
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1337
    - supports_diff must be True if this log formatter supports diffs.
1338
        Otherwise the diff attribute may not be populated.
1339
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1340
    Plugins can register functions to show custom revision properties using
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1341
    the properties_handler_registry. The registered function
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1342
    must respect the following interface description:
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1343
        def my_show_properties(properties_dict):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1344
            # code that returns a dict {'name':'value'} of the properties
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1345
            # to be shown
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1346
    """
3947.1.10 by Ian Clatworthy
review feedback from vila
1347
    preferred_levels = 0
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1348
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1349
    def __init__(self, to_file, show_ids=False, show_timezone='original',
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
1350
                 delta_format=None, levels=None, show_advice=False,
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1351
                 to_exact_file=None, author_list_handler=None):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1352
        """Create a LogFormatter.
1353
1354
        :param to_file: the file to output to
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1355
        :param to_exact_file: if set, gives an output stream to which 
1356
             non-Unicode diffs are written.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1357
        :param show_ids: if True, revision-ids are to be displayed
1358
        :param show_timezone: the timezone to use
1359
        :param delta_format: the level of delta information to display
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1360
          or None to leave it to the formatter to decide
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1361
        :param levels: the number of levels to display; None or -1 to
1362
          let the log formatter decide.
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1363
        :param show_advice: whether to show advice at the end of the
1364
          log or not
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1365
        :param author_list_handler: callable generating a list of
1366
          authors to display for a given revision
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1367
        """
794 by Martin Pool
- Merge John's nice short-log format.
1368
        self.to_file = to_file
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1369
        # 'exact' stream used to show diff, it should print content 'as is'
1370
        # and should not try to decode/encode it to unicode to avoid bug #328007
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1371
        if to_exact_file is not None:
1372
            self.to_exact_file = to_exact_file
1373
        else:
4792.8.12 by Martin Pool
comment
1374
            # XXX: somewhat hacky; this assumes it's a codec writer; it's better
1375
            # for code that expects to get diffs to pass in the exact file
1376
            # stream
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1377
            self.to_exact_file = getattr(to_file, 'stream', to_file)
794 by Martin Pool
- Merge John's nice short-log format.
1378
        self.show_ids = show_ids
1379
        self.show_timezone = show_timezone
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1380
        if delta_format is None:
1381
            # Ensures backward compatibility
1382
            delta_format = 2 # long format
1383
        self.delta_format = delta_format
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1384
        self.levels = levels
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1385
        self._show_advice = show_advice
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1386
        self._merge_count = 0
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1387
        self._author_list_handler = author_list_handler
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1388
3947.1.10 by Ian Clatworthy
review feedback from vila
1389
    def get_levels(self):
1390
        """Get the number of levels to display or 0 for all."""
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1391
        if getattr(self, 'supports_merge_revisions', False):
1392
            if self.levels is None or self.levels == -1:
4217.2.1 by Ian Clatworthy
fix log advice when the # of levels is implicit
1393
                self.levels = self.preferred_levels
1394
        else:
1395
            self.levels = 1
1396
        return self.levels
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1397
3947.1.10 by Ian Clatworthy
review feedback from vila
1398
    def log_revision(self, revision):
1399
        """Log a revision.
1400
1401
        :param  revision:   The LogRevision to be logged.
1402
        """
1403
        raise NotImplementedError('not implemented in abstract base')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1404
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1405
    def show_advice(self):
1406
        """Output user advice, if any, when the log is completed."""
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1407
        if self._show_advice and self.levels == 1 and self._merge_count > 0:
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1408
            advice_sep = self.get_advice_separator()
1409
            if advice_sep:
1410
                self.to_file.write(advice_sep)
4208.2.2 by Ian Clatworthy
show --levels 0 in advice, not just -n0
1411
            self.to_file.write(
4221.2.1 by Ian Clatworthy
--include-merges as an alias for --levels 0 in log
1412
                "Use --include-merges or -n0 to see merged revisions.\n")
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1413
1414
    def get_advice_separator(self):
1415
        """Get the text separating the log from the closing advice."""
1416
        return ''
1417
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1418
    def short_committer(self, rev):
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1419
        name, address = config.parse_username(rev.committer)
1420
        if name:
3063.3.1 by Lukáš Lalinský
Fall back to showing e-mail in ``log --short/--line`` if the committer/author has only e-mail.
1421
            return name
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1422
        return address
2388.1.11 by Alexander Belchenko
changes after John's review
1423
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1424
    def short_author(self, rev):
4081.3.14 by Martin von Gagern
Pass keyword arguments of authors method by name.
1425
        return self.authors(rev, 'first', short=True, sep=', ')
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1426
1427
    def authors(self, rev, who, short=False, sep=None):
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1428
        """Generate list of authors, taking --authors option into account.
1429
1430
        The caller has to specify the name of a author list handler,
1431
        as provided by the author list registry, using the ``who``
1432
        argument.  That name only sets a default, though: when the
1433
        user selected a different author list generation using the
1434
        ``--authors`` command line switch, as represented by the
1435
        ``author_list_handler`` constructor argument, that value takes
1436
        precedence.
1437
1438
        :param rev: The revision for which to generate the list of authors.
1439
        :param who: Name of the default handler.
1440
        :param short: Whether to shorten names to either name or address.
1441
        :param sep: What separator to use for automatic concatenation.
1442
        """
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1443
        if self._author_list_handler is not None:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1444
            # The user did specify --authors, which overrides the default
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1445
            author_list_handler = self._author_list_handler
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1446
        else:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1447
            # The user didn't specify --authors, so we use the caller's default
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1448
            author_list_handler = author_list_registry.get(who)
1449
        names = author_list_handler(rev)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1450
        if short:
1451
            for i in range(len(names)):
1452
                name, address = config.parse_username(names[i])
1453
                if name:
1454
                    names[i] = name
1455
                else:
1456
                    names[i] = address
1457
        if sep is not None:
1458
            names = sep.join(names)
1459
        return names
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1460
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1461
    def merge_marker(self, revision):
4213.1.1 by Ian Clatworthy
merge indicators in log --long (Ian Clatworthy)
1462
        """Get the merge marker to include in the output or '' if none."""
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1463
        if len(revision.rev.parent_ids) > 1:
1464
            self._merge_count += 1
1465
            return ' [merge]'
1466
        else:
1467
            return ''
1468
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
1469
    def show_properties(self, revision, indent):
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1470
        """Displays the custom properties returned by each registered handler.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1471
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1472
        If a registered handler raises an error it is propagated.
3144.7.5 by Guillermo Gonzalez
* some improvements to the doctstring in show_properties method and in LogFormatter
1473
        """
4379.4.1 by Ian Clatworthy
make log --long faster
1474
        for line in self.custom_properties(revision):
1475
            self.to_file.write("%s%s\n" % (indent, line))
1476
1477
    def custom_properties(self, revision):
1478
        """Format the custom properties returned by each registered handler.
1479
1480
        If a registered handler raises an error it is propagated.
1481
1482
        :return: a list of formatted lines (excluding trailing newlines)
1483
        """
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1484
        lines = self._foreign_info_properties(revision)
1485
        for key, handler in properties_handler_registry.iteritems():
1486
            lines.extend(self._format_properties(handler(revision)))
1487
        return lines
1488
1489
    def _foreign_info_properties(self, rev):
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1490
        """Custom log displayer for foreign revision identifiers.
1491
1492
        :param rev: Revision object.
1493
        """
1494
        # Revision comes directly from a foreign repository
1495
        if isinstance(rev, foreign.ForeignRevision):
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
1496
            return self._format_properties(
1497
                rev.mapping.vcs.show_foreign_revid(rev.foreign_revid))
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1498
1499
        # Imported foreign revision revision ids always contain :
1500
        if not ":" in rev.revision_id:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1501
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1502
1503
        # Revision was once imported from a foreign repository
1504
        try:
1505
            foreign_revid, mapping = \
1506
                foreign.foreign_vcs_registry.parse_revision_id(rev.revision_id)
1507
        except errors.InvalidRevisionId:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1508
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1509
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1510
        return self._format_properties(
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1511
            mapping.vcs.show_foreign_revid(foreign_revid))
1512
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1513
    def _format_properties(self, properties):
4379.4.1 by Ian Clatworthy
make log --long faster
1514
        lines = []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1515
        for key, value in properties.items():
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1516
            lines.append(key + ': ' + value)
4379.4.1 by Ian Clatworthy
make log --long faster
1517
        return lines
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1518
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1519
    def show_diff(self, to_file, diff, indent):
1520
        for l in diff.rstrip().split('\n'):
1521
            to_file.write(indent + '%s\n' % (l,))
1522
2388.1.11 by Alexander Belchenko
changes after John's review
1523
4379.4.1 by Ian Clatworthy
make log --long faster
1524
# Separator between revisions in long format
1525
_LONG_SEP = '-' * 60
1526
1527
794 by Martin Pool
- Merge John's nice short-log format.
1528
class LongLogFormatter(LogFormatter):
2388.1.11 by Alexander Belchenko
changes after John's review
1529
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1530
    supports_merge_revisions = True
4206.1.1 by Ian Clatworthy
log mainline by default
1531
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1532
    supports_delta = True
1533
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1534
    supports_diff = True
2388.1.10 by Alexander Belchenko
Slightly reworked: use None instead of [] as default tags list; PEP-8
1535
4379.4.1 by Ian Clatworthy
make log --long faster
1536
    def __init__(self, *args, **kwargs):
1537
        super(LongLogFormatter, self).__init__(*args, **kwargs)
1538
        if self.show_timezone == 'original':
1539
            self.date_string = self._date_string_original_timezone
1540
        else:
1541
            self.date_string = self._date_string_with_timezone
1542
1543
    def _date_string_with_timezone(self, rev):
1544
        return format_date(rev.timestamp, rev.timezone or 0,
1545
                           self.show_timezone)
1546
1547
    def _date_string_original_timezone(self, rev):
1548
        return format_date_with_offset_in_original_timezone(rev.timestamp,
1549
            rev.timezone or 0)
1550
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1551
    def log_revision(self, revision):
1552
        """Log a revision, either merged or not."""
2671.2.5 by Lukáš Lalinský
Fixes for comments from the mailing list.
1553
        indent = '    ' * revision.merge_depth
4379.4.1 by Ian Clatworthy
make log --long faster
1554
        lines = [_LONG_SEP]
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1555
        if revision.revno is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1556
            lines.append('revno: %s%s' % (revision.revno,
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1557
                self.merge_marker(revision)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1558
        if revision.tags:
4379.4.1 by Ian Clatworthy
make log --long faster
1559
            lines.append('tags: %s' % (', '.join(revision.tags)))
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1560
        if self.show_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1561
            lines.append('revision-id: %s' % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1562
            for parent_id in revision.rev.parent_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1563
                lines.append('parent: %s' % (parent_id,))
1564
        lines.extend(self.custom_properties(revision.rev))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1565
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1566
        committer = revision.rev.committer
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1567
        authors = self.authors(revision.rev, 'all')
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1568
        if authors != [committer]:
4379.4.1 by Ian Clatworthy
make log --long faster
1569
            lines.append('author: %s' % (", ".join(authors),))
1570
        lines.append('committer: %s' % (committer,))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1571
1572
        branch_nick = revision.rev.properties.get('branch-nick', None)
1573
        if branch_nick is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1574
            lines.append('branch nick: %s' % (branch_nick,))
1575
1576
        lines.append('timestamp: %s' % (self.date_string(revision.rev),))
1577
1578
        lines.append('message:')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1579
        if not revision.rev.message:
4379.4.1 by Ian Clatworthy
make log --long faster
1580
            lines.append('  (no message)')
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1581
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1582
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1583
            for l in message.split('\n'):
4379.4.1 by Ian Clatworthy
make log --long faster
1584
                lines.append('  %s' % (l,))
1585
1586
        # Dump the output, appending the delta and diff if requested
1587
        to_file = self.to_file
1588
        to_file.write("%s%s\n" % (indent, ('\n' + indent).join(lines)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1589
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1590
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1591
            from bzrlib.delta import report_delta
1592
            report_delta(to_file, revision.delta, short_status=False, 
1593
                         show_ids=self.show_ids, indent=indent)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1594
        if revision.diff is not None:
1595
            to_file.write(indent + 'diff:\n')
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1596
            to_file.flush()
3943.5.6 by Ian Clatworthy
feedback from jam's review
1597
            # Note: we explicitly don't indent the diff (relative to the
1598
            # revision information) so that the output can be fed to patch -p0
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1599
            self.show_diff(self.to_exact_file, revision.diff, indent)
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1600
            self.to_exact_file.flush()
794 by Martin Pool
- Merge John's nice short-log format.
1601
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1602
    def get_advice_separator(self):
1603
        """Get the text separating the log from the closing advice."""
1604
        return '-' * 60 + '\n'
1605
794 by Martin Pool
- Merge John's nice short-log format.
1606
1607
class ShortLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1608
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1609
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1610
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1611
    supports_delta = True
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1612
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1613
    supports_diff = True
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1614
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1615
    def __init__(self, *args, **kwargs):
1616
        super(ShortLogFormatter, self).__init__(*args, **kwargs)
1617
        self.revno_width_by_depth = {}
1618
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1619
    def log_revision(self, revision):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1620
        # We need two indents: one per depth and one for the information
1621
        # relative to that indent. Most mainline revnos are 5 chars or
3970.1.1 by Ian Clatworthy
log -n/--levels (Ian Clatworthy)
1622
        # less while dotted revnos are typically 11 chars or less. Once
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1623
        # calculated, we need to remember the offset for a given depth
1624
        # as we might be starting from a dotted revno in the first column
1625
        # and we want subsequent mainline revisions to line up.
1626
        depth = revision.merge_depth
1627
        indent = '    ' * depth
1628
        revno_width = self.revno_width_by_depth.get(depth)
1629
        if revno_width is None:
1630
            if revision.revno.find('.') == -1:
3947.1.10 by Ian Clatworthy
review feedback from vila
1631
                # mainline revno, e.g. 12345
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1632
                revno_width = 5
1633
            else:
3947.1.10 by Ian Clatworthy
review feedback from vila
1634
                # dotted revno, e.g. 12345.10.55
1635
                revno_width = 11
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1636
            self.revno_width_by_depth[depth] = revno_width
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1637
        offset = ' ' * (revno_width + 1)
1638
794 by Martin Pool
- Merge John's nice short-log format.
1639
        to_file = self.to_file
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1640
        tags = ''
1641
        if revision.tags:
3946.3.2 by Ian Clatworthy
add tests & NEWS item
1642
            tags = ' {%s}' % (', '.join(revision.tags))
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1643
        to_file.write(indent + "%*s %s\t%s%s%s\n" % (revno_width,
1644
                revision.revno, self.short_author(revision.rev),
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1645
                format_date(revision.rev.timestamp,
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1646
                            revision.rev.timezone or 0,
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1647
                            self.show_timezone, date_fmt="%Y-%m-%d",
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1648
                            show_offset=False),
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1649
                tags, self.merge_marker(revision)))
3976.3.1 by Neil Martinsen-Burrell
Add custom properties handling to short log format
1650
        self.show_properties(revision.rev, indent+offset)
794 by Martin Pool
- Merge John's nice short-log format.
1651
        if self.show_ids:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1652
            to_file.write(indent + offset + 'revision-id:%s\n'
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1653
                          % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1654
        if not revision.rev.message:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1655
            to_file.write(indent + offset + '(no message)\n')
794 by Martin Pool
- Merge John's nice short-log format.
1656
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1657
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1658
            for l in message.split('\n'):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1659
                to_file.write(indent + offset + '%s\n' % (l,))
794 by Martin Pool
- Merge John's nice short-log format.
1660
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1661
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1662
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1663
            from bzrlib.delta import report_delta
5076.4.6 by Arnaud Jeansen
Go back to unified report_delta method (i.e. former TreeDelta.show())
1664
            report_delta(to_file, revision.delta, 
1665
                         short_status=self.delta_format==1, 
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1666
                         show_ids=self.show_ids, indent=indent + offset)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1667
        if revision.diff is not None:
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1668
            self.show_diff(self.to_exact_file, revision.diff, '      ')
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1669
        to_file.write('\n')
794 by Martin Pool
- Merge John's nice short-log format.
1670
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1671
1185.12.25 by Aaron Bentley
Added one-line log format
1672
class LineLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1673
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1674
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1675
    preferred_levels = 1
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1676
    supports_tags = True
2997.1.1 by Kent Gibson
Support logging single merge revisions with short and line log formatters.
1677
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1678
    def __init__(self, *args, **kwargs):
1679
        super(LineLogFormatter, self).__init__(*args, **kwargs)
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1680
        width = terminal_width()
1681
        if width is not None:
1682
            # we need one extra space for terminals that wrap on last char
1683
            width = width - 1
1684
        self._max_chars = width
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1685
1185.12.25 by Aaron Bentley
Added one-line log format
1686
    def truncate(self, str, max_len):
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1687
        if max_len is None or len(str) <= max_len:
1185.12.25 by Aaron Bentley
Added one-line log format
1688
            return str
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1689
        return str[:max_len-3] + '...'
1185.12.25 by Aaron Bentley
Added one-line log format
1690
1691
    def date_string(self, rev):
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1692
        return format_date(rev.timestamp, rev.timezone or 0,
1185.12.25 by Aaron Bentley
Added one-line log format
1693
                           self.show_timezone, date_fmt="%Y-%m-%d",
1694
                           show_offset=False)
1695
1696
    def message(self, rev):
1697
        if not rev.message:
1698
            return '(no message)'
1699
        else:
1700
            return rev.message
1701
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1702
    def log_revision(self, revision):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1703
        indent = '  ' * revision.merge_depth
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1704
        self.to_file.write(self.log_string(revision.revno, revision.rev,
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1705
            self._max_chars, revision.tags, indent))
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1706
        self.to_file.write('\n')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1707
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1708
    def log_string(self, revno, rev, max_chars, tags=None, prefix=''):
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1709
        """Format log info into one string. Truncate tail of string
3677.1.1 by Vincent Ladeuil
Begin fixing bug #233817.
1710
        :param  revno:      revision number or None.
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1711
                            Revision numbers counts from 1.
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1712
        :param  rev:        revision object
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1713
        :param  max_chars:  maximum length of resulting string
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1714
        :param  tags:       list of tags or None
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1715
        :param  prefix:     string to prefix each line
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1716
        :return:            formatted truncated string
1717
        """
1718
        out = []
1719
        if revno:
1720
            # show revno only when is not None
3946.3.4 by Ian Clatworthy
minor cleanup
1721
            out.append("%s:" % revno)
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1722
        out.append(self.truncate(self.short_author(rev), 20))
1185.12.25 by Aaron Bentley
Added one-line log format
1723
        out.append(self.date_string(rev))
3983.2.1 by Neil Martinsen-Burrell
add merge indication to the line format
1724
        if len(rev.parent_ids) > 1:
1725
            out.append('[merge]')
3946.3.3 by Ian Clatworthy
feedback from jelmer re position of tags in --line
1726
        if tags:
1727
            tag_str = '{%s}' % (', '.join(tags))
1728
            out.append(tag_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
1729
        out.append(rev.get_summary())
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1730
        return self.truncate(prefix + " ".join(out).rstrip('\n'), max_chars)
794 by Martin Pool
- Merge John's nice short-log format.
1731
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1732
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1733
class GnuChangelogLogFormatter(LogFormatter):
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1734
1735
    supports_merge_revisions = True
1736
    supports_delta = True
1737
1738
    def log_revision(self, revision):
1739
        """Log a revision, either merged or not."""
1740
        to_file = self.to_file
1741
1742
        date_str = format_date(revision.rev.timestamp,
1743
                               revision.rev.timezone or 0,
1744
                               self.show_timezone,
1745
                               date_fmt='%Y-%m-%d',
1746
                               show_offset=False)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1747
        committer_str = self.authors(revision.rev, 'first', sep=', ')
4081.3.6 by Martin von Gagern
Drop space to make John happy.
1748
        committer_str = committer_str.replace(' <', '  <')
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1749
        to_file.write('%s  %s\n\n' % (date_str,committer_str))
1750
4137.1.1 by James Westby
Small improvements to the GNU ChangeLog formatter.
1751
        if revision.delta is not None and revision.delta.has_changed():
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1752
            for c in revision.delta.added + revision.delta.removed + revision.delta.modified:
1753
                path, = c[:1]
1754
                to_file.write('\t* %s:\n' % (path,))
1755
            for c in revision.delta.renamed:
1756
                oldpath,newpath = c[:2]
1757
                # For renamed files, show both the old and the new path
1758
                to_file.write('\t* %s:\n\t* %s:\n' % (oldpath,newpath))
1759
            to_file.write('\n')
1760
1761
        if not revision.rev.message:
1762
            to_file.write('\tNo commit message\n')
1763
        else:
1764
            message = revision.rev.message.rstrip('\r\n')
1765
            for l in message.split('\n'):
1766
                to_file.write('\t%s\n' % (l.lstrip(),))
1767
            to_file.write('\n')
1768
1769
1185.12.27 by Aaron Bentley
Use line log for pending merges
1770
def line_log(rev, max_chars):
1771
    lf = LineLogFormatter(None)
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1772
    return lf.log_string(None, rev, max_chars)
1185.12.27 by Aaron Bentley
Use line log for pending merges
1773
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1774
1775
class LogFormatterRegistry(registry.Registry):
1776
    """Registry for log formatters"""
1777
1778
    def make_formatter(self, name, *args, **kwargs):
1779
        """Construct a formatter from arguments.
1780
1781
        :param name: Name of the formatter to construct.  'short', 'long' and
1782
            'line' are built-in.
1783
        """
1784
        return self.get(name)(*args, **kwargs)
1785
1786
    def get_default(self, branch):
1787
        return self.get(branch.get_config().log_format())
1788
1789
1790
log_formatter_registry = LogFormatterRegistry()
1791
1792
1793
log_formatter_registry.register('short', ShortLogFormatter,
1794
                                'Moderately short log format')
1795
log_formatter_registry.register('long', LongLogFormatter,
1796
                                'Detailed log format')
1797
log_formatter_registry.register('line', LineLogFormatter,
1798
                                'Log format with one line per revision')
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1799
log_formatter_registry.register('gnu-changelog', GnuChangelogLogFormatter,
1800
                                'Format used by GNU ChangeLog files')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1801
794 by Martin Pool
- Merge John's nice short-log format.
1802
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1803
def register_formatter(name, formatter):
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1804
    log_formatter_registry.register(name, formatter)
1805
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1806
794 by Martin Pool
- Merge John's nice short-log format.
1807
def log_formatter(name, *args, **kwargs):
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1808
    """Construct a formatter from arguments.
1809
1185.12.27 by Aaron Bentley
Use line log for pending merges
1810
    name -- Name of the formatter to construct; currently 'long', 'short' and
1811
        'line' are supported.
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1812
    """
794 by Martin Pool
- Merge John's nice short-log format.
1813
    try:
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1814
        return log_formatter_registry.make_formatter(name, *args, **kwargs)
1553.2.2 by Erik Bågfors
Made "unknown log formatter" error message work
1815
    except KeyError:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1816
        raise errors.BzrCommandError("unknown log formatter: %r" % name)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1817
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1818
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1819
def author_list_all(rev):
1820
    return rev.get_apparent_authors()[:]
1821
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1822
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1823
def author_list_first(rev):
1824
    lst = rev.get_apparent_authors()
1825
    try:
1826
        return [lst[0]]
1827
    except IndexError:
1828
        return []
1829
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1830
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1831
def author_list_committer(rev):
1832
    return [rev.committer]
1833
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1834
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1835
author_list_registry = registry.Registry()
1836
1837
author_list_registry.register('all', author_list_all,
1838
                              'All authors')
1839
1840
author_list_registry.register('first', author_list_first,
1841
                              'The first author')
1842
1843
author_list_registry.register('committer', author_list_committer,
1844
                              'The committer')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1845
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1846
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1847
def show_one_log(revno, rev, delta, verbose, to_file, show_timezone):
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
1848
    # deprecated; for compatibility
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1849
    lf = LongLogFormatter(to_file=to_file, show_timezone=show_timezone)
1850
    lf.show(revno, rev, delta)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1851
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1852
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1853
def show_changed_revisions(branch, old_rh, new_rh, to_file=None,
1854
                           log_format='long'):
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1855
    """Show the change in revision history comparing the old revision history to the new one.
1856
1857
    :param branch: The branch where the revisions exist
1858
    :param old_rh: The old revision history
1859
    :param new_rh: The new revision history
1860
    :param to_file: A file to write the results to. If None, stdout will be used
1861
    """
1862
    if to_file is None:
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
1863
        to_file = codecs.getwriter(get_terminal_encoding())(sys.stdout,
1864
            errors='replace')
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1865
    lf = log_formatter(log_format,
1866
                       show_ids=False,
1867
                       to_file=to_file,
1868
                       show_timezone='original')
1869
1870
    # This is the first index which is different between
1871
    # old and new
1872
    base_idx = None
1873
    for i in xrange(max(len(new_rh),
1874
                        len(old_rh))):
1875
        if (len(new_rh) <= i
1876
            or len(old_rh) <= i
1877
            or new_rh[i] != old_rh[i]):
1878
            base_idx = i
1879
            break
1880
1881
    if base_idx is None:
1882
        to_file.write('Nothing seems to have changed\n')
1883
        return
1884
    ## TODO: It might be nice to do something like show_log
1885
    ##       and show the merged entries. But since this is the
1886
    ##       removed revisions, it shouldn't be as important
1887
    if base_idx < len(old_rh):
1888
        to_file.write('*'*60)
1889
        to_file.write('\nRemoved Revisions:\n')
1890
        for i in range(base_idx, len(old_rh)):
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
1891
            rev = branch.repository.get_revision(old_rh[i])
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1892
            lr = LogRevision(rev, i+1, 0, None)
1893
            lf.log_revision(lr)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1894
        to_file.write('*'*60)
1895
        to_file.write('\n\n')
1896
    if base_idx < len(new_rh):
1897
        to_file.write('Added Revisions:\n')
1898
        show_log(branch,
1899
                 lf,
1900
                 None,
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1901
                 verbose=False,
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1902
                 direction='forward',
1903
                 start_revision=base_idx+1,
1904
                 end_revision=len(new_rh),
1905
                 search=None)
1906
3144.7.4 by Guillermo Gonzalez
* move the function regisstry into a real Registry instead of a list
1907
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1908
def get_history_change(old_revision_id, new_revision_id, repository):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1909
    """Calculate the uncommon lefthand history between two revisions.
1910
1911
    :param old_revision_id: The original revision id.
1912
    :param new_revision_id: The new revision id.
3848.1.22 by Aaron Bentley
Fix spelling
1913
    :param repository: The repository to use for the calculation.
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1914
1915
    return old_history, new_history
1916
    """
3848.1.6 by Aaron Bentley
Implement get_history_change
1917
    old_history = []
1918
    old_revisions = set()
1919
    new_history = []
1920
    new_revisions = set()
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1921
    new_iter = repository.iter_reverse_revision_history(new_revision_id)
1922
    old_iter = repository.iter_reverse_revision_history(old_revision_id)
3848.1.6 by Aaron Bentley
Implement get_history_change
1923
    stop_revision = None
1924
    do_old = True
1925
    do_new = True
1926
    while do_new or do_old:
1927
        if do_new:
1928
            try:
1929
                new_revision = new_iter.next()
1930
            except StopIteration:
1931
                do_new = False
1932
            else:
1933
                new_history.append(new_revision)
1934
                new_revisions.add(new_revision)
1935
                if new_revision in old_revisions:
1936
                    stop_revision = new_revision
1937
                    break
1938
        if do_old:
1939
            try:
1940
                old_revision = old_iter.next()
1941
            except StopIteration:
1942
                do_old = False
1943
            else:
1944
                old_history.append(old_revision)
1945
                old_revisions.add(old_revision)
1946
                if old_revision in new_revisions:
1947
                    stop_revision = old_revision
1948
                    break
1949
    new_history.reverse()
1950
    old_history.reverse()
1951
    if stop_revision is not None:
1952
        new_history = new_history[new_history.index(stop_revision) + 1:]
1953
        old_history = old_history[old_history.index(stop_revision) + 1:]
1954
    return old_history, new_history
1955
1956
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1957
def show_branch_change(branch, output, old_revno, old_revision_id):
1958
    """Show the changes made to a branch.
1959
1960
    :param branch: The branch to show changes about.
1961
    :param output: A file-like object to write changes to.
1962
    :param old_revno: The revno of the old tip.
1963
    :param old_revision_id: The revision_id of the old tip.
1964
    """
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1965
    new_revno, new_revision_id = branch.last_revision_info()
1966
    old_history, new_history = get_history_change(old_revision_id,
1967
                                                  new_revision_id,
1968
                                                  branch.repository)
1969
    if old_history == [] and new_history == []:
1970
        output.write('Nothing seems to have changed\n')
1971
        return
1972
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1973
    log_format = log_formatter_registry.get_default(branch)
1974
    lf = log_format(show_ids=False, to_file=output, show_timezone='original')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1975
    if old_history != []:
1976
        output.write('*'*60)
1977
        output.write('\nRemoved Revisions:\n')
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1978
        show_flat_log(branch.repository, old_history, old_revno, lf)
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1979
        output.write('*'*60)
1980
        output.write('\n\n')
1981
    if new_history != []:
3848.1.9 by Aaron Bentley
new/old sections are omitted as appropriate.
1982
        output.write('Added Revisions:\n')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1983
        start_revno = new_revno - len(new_history) + 1
1984
        show_log(branch, lf, None, verbose=False, direction='forward',
1985
                 start_revision=start_revno,)
1986
1987
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1988
def show_flat_log(repository, history, last_revno, lf):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1989
    """Show a simple log of the specified history.
1990
1991
    :param repository: The repository to retrieve revisions from.
1992
    :param history: A list of revision_ids indicating the lefthand history.
1993
    :param last_revno: The revno of the last revision_id in the history.
1994
    :param lf: The log formatter to use.
1995
    """
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1996
    start_revno = last_revno - len(history) + 1
1997
    revisions = repository.get_revisions(history)
1998
    for i, rev in enumerate(revisions):
1999
        lr = LogRevision(rev, i + last_revno, 0, None)
2000
        lf.log_revision(lr)
2001
2002
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2003
def _get_info_for_log_files(revisionspec_list, file_list, add_cleanup):
4202.2.1 by Ian Clatworthy
get directory logging working again
2004
    """Find file-ids and kinds given a list of files and a revision range.
2005
2006
    We search for files at the end of the range. If not found there,
2007
    we try the start of the range.
2008
2009
    :param revisionspec_list: revision range as parsed on the command line
2010
    :param file_list: the list of paths given on the command line;
2011
      the first of these can be a branch location or a file path,
2012
      the remainder must be file paths
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2013
    :param add_cleanup: When the branch returned is read locked,
2014
      an unlock call will be queued to the cleanup.
4202.2.1 by Ian Clatworthy
get directory logging working again
2015
    :return: (branch, info_list, start_rev_info, end_rev_info) where
2016
      info_list is a list of (relative_path, file_id, kind) tuples where
2017
      kind is one of values 'directory', 'file', 'symlink', 'tree-reference'.
4634.90.1 by Andrew Bennetts
Fix ObjectNotLocked error during 'bzr log' by acquiring branch read lock as soon as cmd_log acquires the branch, only releasing it at the end.
2018
      branch will be read-locked.
3943.6.4 by Ian Clatworthy
review feedback from vila
2019
    """
5346.4.2 by Martin Pool
Move internal_tree_files and safe_relpath_files onto WorkingTree
2020
    from builtins import _get_revision_range
4202.2.1 by Ian Clatworthy
get directory logging working again
2021
    tree, b, path = bzrdir.BzrDir.open_containing_tree_or_branch(file_list[0])
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2022
    add_cleanup(b.lock_read().unlock)
4202.2.1 by Ian Clatworthy
get directory logging working again
2023
    # XXX: It's damn messy converting a list of paths to relative paths when
2024
    # those paths might be deleted ones, they might be on a case-insensitive
2025
    # filesystem and/or they might be in silly locations (like another branch).
2026
    # For example, what should "log bzr://branch/dir/file1 file2" do? (Is
2027
    # file2 implicitly in the same dir as file1 or should its directory be
2028
    # taken from the current tree somehow?) For now, this solves the common
2029
    # case of running log in a nested directory, assuming paths beyond the
2030
    # first one haven't been deleted ...
2031
    if tree:
5346.4.2 by Martin Pool
Move internal_tree_files and safe_relpath_files onto WorkingTree
2032
        relpaths = [path] + tree.safe_relpath_files(file_list[1:])
4202.2.1 by Ian Clatworthy
get directory logging working again
2033
    else:
2034
        relpaths = [path] + file_list[1:]
2035
    info_list = []
2036
    start_rev_info, end_rev_info = _get_revision_range(revisionspec_list, b,
2037
        "log")
4296.2.1 by Jelmer Vernooij
Don't retrieve the tree if log is called on the root.
2038
    if relpaths in ([], [u'']):
2039
        return b, [], start_rev_info, end_rev_info
4202.2.1 by Ian Clatworthy
get directory logging working again
2040
    if start_rev_info is None and end_rev_info is None:
3943.6.4 by Ian Clatworthy
review feedback from vila
2041
        if tree is None:
2042
            tree = b.basis_tree()
4202.2.1 by Ian Clatworthy
get directory logging working again
2043
        tree1 = None
2044
        for fp in relpaths:
2045
            file_id = tree.path2id(fp)
2046
            kind = _get_kind_for_file_id(tree, file_id)
2047
            if file_id is None:
2048
                # go back to when time began
2049
                if tree1 is None:
2050
                    try:
2051
                        rev1 = b.get_rev_id(1)
2052
                    except errors.NoSuchRevision:
2053
                        # No history at all
2054
                        file_id = None
2055
                        kind = None
2056
                    else:
2057
                        tree1 = b.repository.revision_tree(rev1)
2058
                if tree1:
2059
                    file_id = tree1.path2id(fp)
2060
                    kind = _get_kind_for_file_id(tree1, file_id)
2061
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2062
4202.2.1 by Ian Clatworthy
get directory logging working again
2063
    elif start_rev_info == end_rev_info:
3943.6.4 by Ian Clatworthy
review feedback from vila
2064
        # One revision given - file must exist in it
4202.2.1 by Ian Clatworthy
get directory logging working again
2065
        tree = b.repository.revision_tree(end_rev_info.rev_id)
2066
        for fp in relpaths:
2067
            file_id = tree.path2id(fp)
2068
            kind = _get_kind_for_file_id(tree, file_id)
2069
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2070
4202.2.1 by Ian Clatworthy
get directory logging working again
2071
    else:
3943.6.4 by Ian Clatworthy
review feedback from vila
2072
        # Revision range given. Get the file-id from the end tree.
2073
        # If that fails, try the start tree.
4202.2.1 by Ian Clatworthy
get directory logging working again
2074
        rev_id = end_rev_info.rev_id
3943.6.4 by Ian Clatworthy
review feedback from vila
2075
        if rev_id is None:
2076
            tree = b.basis_tree()
2077
        else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2078
            tree = b.repository.revision_tree(rev_id)
2079
        tree1 = None
2080
        for fp in relpaths:
3943.6.4 by Ian Clatworthy
review feedback from vila
2081
            file_id = tree.path2id(fp)
4202.2.1 by Ian Clatworthy
get directory logging working again
2082
            kind = _get_kind_for_file_id(tree, file_id)
2083
            if file_id is None:
2084
                if tree1 is None:
2085
                    rev_id = start_rev_info.rev_id
2086
                    if rev_id is None:
2087
                        rev1 = b.get_rev_id(1)
2088
                        tree1 = b.repository.revision_tree(rev1)
2089
                    else:
2090
                        tree1 = b.repository.revision_tree(rev_id)
2091
                file_id = tree1.path2id(fp)
2092
                kind = _get_kind_for_file_id(tree1, file_id)
2093
            info_list.append((fp, file_id, kind))
2094
    return b, info_list, start_rev_info, end_rev_info
2095
2096
2097
def _get_kind_for_file_id(tree, file_id):
2098
    """Return the kind of a file-id or None if it doesn't exist."""
2099
    if file_id is not None:
2100
        return tree.kind(file_id)
3943.6.4 by Ian Clatworthy
review feedback from vila
2101
    else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2102
        return None
3943.6.4 by Ian Clatworthy
review feedback from vila
2103
2104
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
2105
properties_handler_registry = registry.Registry()
3830.4.1 by Jelmer Vernooij
Add base classes for foreign branches.
2106
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2107
# Use the properties handlers to print out bug information if available
2108
def _bugs_properties_handler(revision):
2109
    if revision.properties.has_key('bugs'):
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2110
        bug_lines = revision.properties['bugs'].split('\n')
2111
        bug_rows = [line.split(' ', 1) for line in bug_lines]
2112
        fixed_bug_urls = [row[0] for row in bug_rows if
2113
                          len(row) > 1 and row[1] == 'fixed']
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
2114
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2115
        if fixed_bug_urls:
2116
            return {'fixes bug(s)': ' '.join(fixed_bug_urls)}
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2117
    return {}
2118
2119
properties_handler_registry.register('bugs_properties_handler',
2120
                                     _bugs_properties_handler)
2121
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2122
2123
# adapters which revision ids to log are filtered. When log is called, the
2124
# log_rev_iterator is adapted through each of these factory methods.
2125
# Plugins are welcome to mutate this list in any way they like - as long
2126
# as the overall behaviour is preserved. At this point there is no extensible
2127
# mechanism for getting parameters to each factory method, and until there is
2128
# this won't be considered a stable api.
2129
log_adapters = [
2130
    # core log logic
3642.1.7 by Robert Collins
Review feedback.
2131
    _make_batch_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2132
    # read revision objects
3642.1.7 by Robert Collins
Review feedback.
2133
    _make_revision_objects,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2134
    # filter on log messages
3642.1.7 by Robert Collins
Review feedback.
2135
    _make_search_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2136
    # generate deltas for things we will show
3642.1.7 by Robert Collins
Review feedback.
2137
    _make_delta_filter
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2138
    ]