~bzr-pqm/bzr/bzr.dev

5086.1.2 by Vincent Ladeuil
Cosmetic changes.
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
750 by Martin Pool
- stubbed-out tests for python plugins
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
750 by Martin Pool
- stubbed-out tests for python plugins
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
2052.3.1 by John Arbash Meinel
Add tests to cleanup the copyright of all source files
12
#
750 by Martin Pool
- stubbed-out tests for python plugins
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
750 by Martin Pool
- stubbed-out tests for python plugins
16
17
"""Tests for plugins"""
18
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
19
# XXX: There are no plugin tests at the moment because the plugin module
20
# affects the global state of the process.  See bzrlib/plugins.py for more
21
# comments.
22
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
23
from cStringIO import StringIO
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
24
import logging
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
25
import os
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
26
import sys
750 by Martin Pool
- stubbed-out tests for python plugins
27
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
28
import bzrlib
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
29
from bzrlib import (
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
30
    errors,
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
31
    osutils,
32
    plugin,
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
33
    plugins,
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
34
    tests,
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
35
    trace,
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
36
    )
1141 by Martin Pool
- rename FunctionalTest to TestCaseInTempDir
37
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
38
1492 by Robert Collins
Support decoration of commands.
39
# TODO: Write a test for plugin decoration of commands.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
40
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
41
class TestPluginMixin(object):
42
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
43
    def create_plugin(self, name, source=None, dir='.', file_name=None):
44
        if source is None:
45
            source = '''\
46
"""This is the doc for %s"""
47
''' % (name)
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
48
        if file_name is None:
49
            file_name = name + '.py'
50
        # 'source' must not fail to load
5086.1.7 by Vincent Ladeuil
Cleaner fix for bug #411413.
51
        path = osutils.pathjoin(dir, file_name)
52
        f = open(path, 'w')
53
        self.addCleanup(os.unlink, path)
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
54
        try:
55
            f.write(source + '\n')
56
        finally:
57
            f.close()
58
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
59
    def create_plugin_package(self, name, dir=None, source=None):
60
        if dir is None:
61
            dir = name
62
        if source is None:
63
            source = '''\
64
"""This is the doc for %s"""
65
dir_source = '%s'
66
''' % (name, dir)
67
        os.makedirs(dir)
5086.5.9 by Vincent Ladeuil
More tests.
68
        def cleanup():
69
            # Workaround lazy import random? madness
70
            osutils.rmtree(dir)
71
        self.addCleanup(cleanup)
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
72
        self.create_plugin(name, source, dir,
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
73
                           file_name='__init__.py')
74
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
75
    def _unregister_plugin(self, name):
76
        """Remove the plugin from sys.modules and the bzrlib namespace."""
77
        py_name = 'bzrlib.plugins.%s' % name
78
        if py_name in sys.modules:
79
            del sys.modules[py_name]
80
        if getattr(bzrlib.plugins, name, None) is not None:
81
            delattr(bzrlib.plugins, name)
82
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
83
    def _unregister_plugin_submodule(self, plugin_name, submodule_name):
84
        """Remove the submodule from sys.modules and the bzrlib namespace."""
85
        py_name = 'bzrlib.plugins.%s.%s' % (plugin_name, submodule_name)
86
        if py_name in sys.modules:
87
            del sys.modules[py_name]
5268.6.3 by Vincent Ladeuil
BZR_PLUGINS_AT should use packages properly to handle relative imports.
88
        plugin = getattr(bzrlib.plugins, plugin_name, None)
89
        if plugin is not None:
90
            if getattr(plugin, submodule_name, None) is not None:
91
                delattr(plugin, submodule_name)
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
92
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
93
    def assertPluginUnknown(self, name):
5086.1.9 by Vincent Ladeuil
Fix bogus helpers and add a test.
94
        self.failIf(getattr(bzrlib.plugins, name, None) is not None)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
95
        self.failIf('bzrlib.plugins.%s' % name in sys.modules)
96
97
    def assertPluginKnown(self, name):
5086.1.9 by Vincent Ladeuil
Fix bogus helpers and add a test.
98
        self.failUnless(getattr(bzrlib.plugins, name, None) is not None)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
99
        self.failUnless('bzrlib.plugins.%s' % name in sys.modules)
100
101
102
class TestLoadingPlugins(tests.TestCaseInTempDir, TestPluginMixin):
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
103
104
    activeattributes = {}
105
106
    def test_plugins_with_the_same_name_are_not_loaded(self):
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
107
        # This test tests that having two plugins in different directories does
108
        # not result in both being loaded when they have the same name.  get a
109
        # file name we can use which is also a valid attribute for accessing in
110
        # activeattributes. - we cannot give import parameters.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
111
        tempattribute = "0"
112
        self.failIf(tempattribute in self.activeattributes)
113
        # set a place for the plugins to record their loading, and at the same
114
        # time validate that the location the plugins should record to is
115
        # valid and correct.
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
116
        self.__class__.activeattributes [tempattribute] = []
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
117
        self.failUnless(tempattribute in self.activeattributes)
118
        # create two plugin directories
119
        os.mkdir('first')
120
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
121
        # write a plugin that will record when its loaded in the
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
122
        # tempattribute list.
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
123
        template = ("from bzrlib.tests.test_plugins import TestLoadingPlugins\n"
124
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
125
126
        outfile = open(os.path.join('first', 'plugin.py'), 'w')
127
        try:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
128
            outfile.write(template % (tempattribute, 'first'))
129
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
130
        finally:
131
            outfile.close()
132
133
        outfile = open(os.path.join('second', 'plugin.py'), 'w')
134
        try:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
135
            outfile.write(template % (tempattribute, 'second'))
136
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
137
        finally:
138
            outfile.close()
139
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
140
        try:
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
141
            bzrlib.plugin.load_from_path(['first', 'second'])
142
            self.assertEqual(['first'], self.activeattributes[tempattribute])
143
        finally:
144
            # remove the plugin 'plugin'
145
            del self.activeattributes[tempattribute]
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
146
            self._unregister_plugin('plugin')
147
        self.assertPluginUnknown('plugin')
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
148
149
    def test_plugins_from_different_dirs_can_demand_load(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
150
        self.failIf('bzrlib.plugins.pluginone' in sys.modules)
151
        self.failIf('bzrlib.plugins.plugintwo' in sys.modules)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
152
        # This test tests that having two plugins in different
153
        # directories with different names allows them both to be loaded, when
154
        # we do a direct import statement.
155
        # Determine a file name we can use which is also a valid attribute
156
        # for accessing in activeattributes. - we cannot give import parameters.
157
        tempattribute = "different-dirs"
158
        self.failIf(tempattribute in self.activeattributes)
159
        # set a place for the plugins to record their loading, and at the same
160
        # time validate that the location the plugins should record to is
161
        # valid and correct.
162
        bzrlib.tests.test_plugins.TestLoadingPlugins.activeattributes \
163
            [tempattribute] = []
164
        self.failUnless(tempattribute in self.activeattributes)
165
        # create two plugin directories
166
        os.mkdir('first')
167
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
168
        # write plugins that will record when they are loaded in the
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
169
        # tempattribute list.
170
        template = ("from bzrlib.tests.test_plugins import TestLoadingPlugins\n"
171
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
172
173
        outfile = open(os.path.join('first', 'pluginone.py'), 'w')
174
        try:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
175
            outfile.write(template % (tempattribute, 'first'))
176
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
177
        finally:
178
            outfile.close()
179
180
        outfile = open(os.path.join('second', 'plugintwo.py'), 'w')
181
        try:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
182
            outfile.write(template % (tempattribute, 'second'))
183
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
184
        finally:
185
            outfile.close()
186
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
187
        oldpath = bzrlib.plugins.__path__
188
        try:
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
189
            self.failIf('bzrlib.plugins.pluginone' in sys.modules)
190
            self.failIf('bzrlib.plugins.plugintwo' in sys.modules)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
191
            bzrlib.plugins.__path__ = ['first', 'second']
192
            exec "import bzrlib.plugins.pluginone"
193
            self.assertEqual(['first'], self.activeattributes[tempattribute])
194
            exec "import bzrlib.plugins.plugintwo"
195
            self.assertEqual(['first', 'second'],
196
                self.activeattributes[tempattribute])
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
197
        finally:
198
            # remove the plugin 'plugin'
199
            del self.activeattributes[tempattribute]
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
200
            self._unregister_plugin('pluginone')
201
            self._unregister_plugin('plugintwo')
202
        self.assertPluginUnknown('pluginone')
203
        self.assertPluginUnknown('plugintwo')
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
204
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
205
    def test_plugins_can_load_from_directory_with_trailing_slash(self):
206
        # This test tests that a plugin can load from a directory when the
207
        # directory in the path has a trailing slash.
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
208
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
209
        self.assertPluginUnknown('ts_plugin')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
210
        tempattribute = "trailing-slash"
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
211
        self.failIf(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
212
        # set a place for the plugin to record its loading, and at the same
213
        # time validate that the location the plugin should record to is
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
214
        # valid and correct.
215
        bzrlib.tests.test_plugins.TestLoadingPlugins.activeattributes \
216
            [tempattribute] = []
217
        self.failUnless(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
218
        # create a directory for the plugin
219
        os.mkdir('plugin_test')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
220
        # write a plugin that will record when its loaded in the
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
221
        # tempattribute list.
222
        template = ("from bzrlib.tests.test_plugins import TestLoadingPlugins\n"
223
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
224
225
        outfile = open(os.path.join('plugin_test', 'ts_plugin.py'), 'w')
226
        try:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
227
            outfile.write(template % (tempattribute, 'plugin'))
2911.6.4 by Blake Winton
Fix test failures
228
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
229
        finally:
230
            outfile.close()
231
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
232
        try:
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
233
            bzrlib.plugin.load_from_path(['plugin_test'+os.sep])
234
            self.assertEqual(['plugin'], self.activeattributes[tempattribute])
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
235
        finally:
236
            del self.activeattributes[tempattribute]
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
237
            self._unregister_plugin('ts_plugin')
238
        self.assertPluginUnknown('ts_plugin')
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
239
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
240
    def load_and_capture(self, name):
241
        """Load plugins from '.' capturing the output.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
242
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
243
        :param name: The name of the plugin.
244
        :return: A string with the log from the plugin loading call.
245
        """
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
246
        # Capture output
247
        stream = StringIO()
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
248
        try:
249
            handler = logging.StreamHandler(stream)
250
            log = logging.getLogger('bzr')
251
            log.addHandler(handler)
252
            try:
253
                try:
254
                    bzrlib.plugin.load_from_path(['.'])
255
                finally:
256
                    if 'bzrlib.plugins.%s' % name in sys.modules:
257
                        del sys.modules['bzrlib.plugins.%s' % name]
258
                    if getattr(bzrlib.plugins, name, None):
259
                        delattr(bzrlib.plugins, name)
260
            finally:
261
                # Stop capturing output
262
                handler.flush()
263
                handler.close()
264
                log.removeHandler(handler)
265
            return stream.getvalue()
266
        finally:
267
            stream.close()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
268
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
269
    def test_plugin_with_bad_api_version_reports(self):
270
        # This plugin asks for bzrlib api version 1.0.0, which is not supported
271
        # anymore.
272
        name = 'wants100.py'
273
        f = file(name, 'w')
274
        try:
275
            f.write("import bzrlib.api\n"
276
                "bzrlib.api.require_any_api(bzrlib, [(1, 0, 0)])\n")
277
        finally:
278
            f.close()
279
280
        log = self.load_and_capture(name)
281
        self.assertContainsRe(log,
282
            r"It requested API version")
283
284
    def test_plugin_with_bad_name_does_not_load(self):
285
        # The file name here invalid for a python module.
286
        name = 'bzr-bad plugin-name..py'
287
        file(name, 'w').close()
288
        log = self.load_and_capture(name)
289
        self.assertContainsRe(log,
3290.1.1 by James Westby
Strip "bzr_" from the start of the suggested plugin name.
290
            r"Unable to load 'bzr-bad plugin-name\.' in '\.' as a plugin "
291
            "because the file path isn't a valid module name; try renaming "
292
            "it to 'bad_plugin_name_'\.")
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
293
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
294
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
295
class TestPlugins(tests.TestCaseInTempDir, TestPluginMixin):
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
296
297
    def setup_plugin(self, source=""):
298
        # This test tests a new plugin appears in bzrlib.plugin.plugins().
299
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
300
        self.assertPluginUnknown('plugin')
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
301
        # write a plugin that _cannot_ fail to load.
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
302
        file('plugin.py', 'w').write(source + '\n')
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
303
        self.addCleanup(self.teardown_plugin)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
304
        plugin.load_from_path(['.'])
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
305
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
306
    def teardown_plugin(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
307
        self._unregister_plugin('plugin')
308
        self.assertPluginUnknown('plugin')
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
309
310
    def test_plugin_appears_in_plugins(self):
311
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
312
        self.assertPluginKnown('plugin')
313
        p = plugin.plugins()['plugin']
314
        self.assertIsInstance(p, bzrlib.plugin.PlugIn)
315
        self.assertEqual(p.module, plugins.plugin)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
316
317
    def test_trivial_plugin_get_path(self):
318
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
319
        p = plugin.plugins()['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
320
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
321
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
322
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
323
    def test_plugin_get_path_py_not_pyc(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
324
        # first import creates plugin.pyc
325
        self.setup_plugin()
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
326
        self.teardown_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
327
        plugin.load_from_path(['.']) # import plugin.pyc
328
        p = plugin.plugins()['plugin']
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
329
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
330
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
331
332
    def test_plugin_get_path_pyc_only(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
333
        # first import creates plugin.pyc (or plugin.pyo depending on __debug__)
334
        self.setup_plugin()
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
335
        self.teardown_plugin()
336
        os.unlink(self.test_dir + '/plugin.py')
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
337
        plugin.load_from_path(['.']) # import plugin.pyc (or .pyo)
338
        p = plugin.plugins()['plugin']
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
339
        if __debug__:
340
            plugin_path = self.test_dir + '/plugin.pyc'
341
        else:
342
            plugin_path = self.test_dir + '/plugin.pyo'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
343
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
344
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
345
    def test_no_test_suite_gives_None_for_test_suite(self):
346
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
347
        p = plugin.plugins()['plugin']
348
        self.assertEqual(None, p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
349
350
    def test_test_suite_gives_test_suite_result(self):
351
        source = """def test_suite(): return 'foo'"""
352
        self.setup_plugin(source)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
353
        p = plugin.plugins()['plugin']
354
        self.assertEqual('foo', p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
355
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
356
    def test_no_load_plugin_tests_gives_None_for_load_plugin_tests(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
357
        self.setup_plugin()
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
358
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
359
        p = plugin.plugins()['plugin']
360
        self.assertEqual(None, p.load_plugin_tests(loader))
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
361
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
362
    def test_load_plugin_tests_gives_load_plugin_tests_result(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
363
        source = """
364
def load_tests(standard_tests, module, loader):
365
    return 'foo'"""
366
        self.setup_plugin(source)
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
367
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
368
        p = plugin.plugins()['plugin']
369
        self.assertEqual('foo', p.load_plugin_tests(loader))
370
371
    def check_version_info(self, expected, source='', name='plugin'):
372
        self.setup_plugin(source)
373
        self.assertEqual(expected, plugin.plugins()[name].version_info())
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
374
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
375
    def test_no_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
376
        self.check_version_info(None)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
377
378
    def test_with_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
379
        self.check_version_info((1, 2, 3, 'dev', 4),
380
                                "version_info = (1, 2, 3, 'dev', 4)")
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
381
382
    def test_short_version_info_gets_padded(self):
383
        # the gtk plugin has version_info = (1,2,3) rather than the 5-tuple.
384
        # so we adapt it
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
385
        self.check_version_info((1, 2, 3, 'final', 0),
386
                                "version_info = (1, 2, 3)")
387
388
    def check_version(self, expected, source=None, name='plugin'):
389
        self.setup_plugin(source)
390
        self.assertEqual(expected, plugins[name].__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
391
392
    def test_no_version_info___version__(self):
393
        self.setup_plugin()
394
        plugin = bzrlib.plugin.plugins()['plugin']
395
        self.assertEqual("unknown", plugin.__version__)
396
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
397
    def test_str__version__with_version_info(self):
398
        self.setup_plugin("version_info = '1.2.3'")
399
        plugin = bzrlib.plugin.plugins()['plugin']
400
        self.assertEqual("1.2.3", plugin.__version__)
401
402
    def test_noniterable__version__with_version_info(self):
403
        self.setup_plugin("version_info = (1)")
404
        plugin = bzrlib.plugin.plugins()['plugin']
405
        self.assertEqual("1", plugin.__version__)
406
407
    def test_1__version__with_version_info(self):
408
        self.setup_plugin("version_info = (1,)")
409
        plugin = bzrlib.plugin.plugins()['plugin']
410
        self.assertEqual("1", plugin.__version__)
411
412
    def test_1_2__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
413
        self.setup_plugin("version_info = (1, 2)")
414
        plugin = bzrlib.plugin.plugins()['plugin']
415
        self.assertEqual("1.2", plugin.__version__)
416
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
417
    def test_1_2_3__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
418
        self.setup_plugin("version_info = (1, 2, 3)")
419
        plugin = bzrlib.plugin.plugins()['plugin']
420
        self.assertEqual("1.2.3", plugin.__version__)
421
422
    def test_candidate__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
423
        self.setup_plugin("version_info = (1, 2, 3, 'candidate', 1)")
424
        plugin = bzrlib.plugin.plugins()['plugin']
425
        self.assertEqual("1.2.3rc1", plugin.__version__)
426
427
    def test_dev__version__with_version_info(self):
428
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 0)")
429
        plugin = bzrlib.plugin.plugins()['plugin']
430
        self.assertEqual("1.2.3dev", plugin.__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
431
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
432
    def test_dev_fallback__version__with_version_info(self):
433
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 4)")
434
        plugin = bzrlib.plugin.plugins()['plugin']
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
435
        self.assertEqual("1.2.3dev4", plugin.__version__)
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
436
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
437
    def test_final__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
438
        self.setup_plugin("version_info = (1, 2, 3, 'final', 0)")
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
439
        plugin = bzrlib.plugin.plugins()['plugin']
440
        self.assertEqual("1.2.3", plugin.__version__)
441
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
442
    def test_final_fallback__version__with_version_info(self):
443
        self.setup_plugin("version_info = (1, 2, 3, 'final', 2)")
444
        plugin = bzrlib.plugin.plugins()['plugin']
445
        self.assertEqual("1.2.3.final.2", plugin.__version__)
446
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
447
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
448
class TestPluginHelp(tests.TestCaseInTempDir):
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
449
450
    def split_help_commands(self):
451
        help = {}
452
        current = None
3908.1.1 by Andrew Bennetts
Try harder to avoid loading plugins during the test suite.
453
        out, err = self.run_bzr('--no-plugins help commands')
454
        for line in out.splitlines():
2034.1.2 by Aaron Bentley
Fix testcase
455
            if not line.startswith(' '):
456
                current = line.split()[0]
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
457
            help[current] = help.get(current, '') + line
458
459
        return help
460
461
    def test_plugin_help_builtins_unaffected(self):
462
        # Check we don't get false positives
463
        help_commands = self.split_help_commands()
464
        for cmd_name in bzrlib.commands.builtin_command_names():
465
            if cmd_name in bzrlib.commands.plugin_command_names():
466
                continue
467
            try:
2432.1.12 by Robert Collins
Relocate command help onto Command.
468
                help = bzrlib.commands.get_cmd_object(cmd_name).get_help_text()
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
469
            except NotImplementedError:
470
                # some commands have no help
471
                pass
472
            else:
2666.1.1 by Ian Clatworthy
Bazaar User Reference generated from online help
473
                self.assertNotContainsRe(help, 'plugin "[^"]*"')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
474
2432.1.12 by Robert Collins
Relocate command help onto Command.
475
            if cmd_name in help_commands.keys():
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
476
                # some commands are hidden
477
                help = help_commands[cmd_name]
2666.1.1 by Ian Clatworthy
Bazaar User Reference generated from online help
478
                self.assertNotContainsRe(help, 'plugin "[^"]*"')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
479
480
    def test_plugin_help_shows_plugin(self):
481
        # Create a test plugin
482
        os.mkdir('plugin_test')
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
483
        f = open(osutils.pathjoin('plugin_test', 'myplug.py'), 'w')
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
484
        f.write("""\
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
485
from bzrlib import commands
486
class cmd_myplug(commands.Command):
5131.2.1 by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings
487
    __doc__ = '''Just a simple test plugin.'''
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
488
    aliases = ['mplg']
489
    def run(self):
490
        print 'Hello from my plugin'
491
492
"""
493
)
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
494
        f.close()
495
496
        try:
497
            # Check its help
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
498
            bzrlib.plugin.load_from_path(['plugin_test'])
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
499
            bzrlib.commands.register_command( bzrlib.plugins.myplug.cmd_myplug)
2530.3.4 by Martin Pool
Deprecate run_bzr_captured in favour of just run_bzr
500
            help = self.run_bzr('help myplug')[0]
2666.1.1 by Ian Clatworthy
Bazaar User Reference generated from online help
501
            self.assertContainsRe(help, 'plugin "myplug"')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
502
            help = self.split_help_commands()['myplug']
2034.1.4 by Aaron Bentley
Change angle brackets to square brackets
503
            self.assertContainsRe(help, '\[myplug\]')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
504
        finally:
2204.3.2 by Alexander Belchenko
cherrypicking: test_plugin_help_shows_plugin: fix cleanup after test
505
            # unregister command
3785.1.1 by Aaron Bentley
Switch from dict to Registry for plugin_cmds
506
            if 'myplug' in bzrlib.commands.plugin_cmds:
507
                bzrlib.commands.plugin_cmds.remove('myplug')
2204.3.2 by Alexander Belchenko
cherrypicking: test_plugin_help_shows_plugin: fix cleanup after test
508
            # remove the plugin 'myplug'
509
            if getattr(bzrlib.plugins, 'myplug', None):
510
                delattr(bzrlib.plugins, 'myplug')
2215.4.1 by Alexander Belchenko
Bugfix #68124: Allow plugins import from zip archives.
511
512
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
513
class TestHelpIndex(tests.TestCase):
514
    """Tests for the PluginsHelpIndex class."""
515
516
    def test_default_constructable(self):
517
        index = plugin.PluginsHelpIndex()
518
519
    def test_get_topics_None(self):
520
        """Searching for None returns an empty list."""
521
        index = plugin.PluginsHelpIndex()
522
        self.assertEqual([], index.get_topics(None))
523
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
524
    def test_get_topics_for_plugin(self):
525
        """Searching for plugin name gets its docstring."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
526
        index = plugin.PluginsHelpIndex()
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
527
        # make a new plugin here for this test, even if we're run with
528
        # --no-plugins
529
        self.assertFalse(sys.modules.has_key('bzrlib.plugins.demo_module'))
530
        demo_module = FakeModule('', 'bzrlib.plugins.demo_module')
531
        sys.modules['bzrlib.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
532
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
533
            topics = index.get_topics('demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
534
            self.assertEqual(1, len(topics))
535
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
536
            self.assertEqual(demo_module, topics[0].module)
537
        finally:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
538
            del sys.modules['bzrlib.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
539
540
    def test_get_topics_no_topic(self):
541
        """Searching for something that is not a plugin returns []."""
542
        # test this by using a name that cannot be a plugin - its not
543
        # a valid python identifier.
544
        index = plugin.PluginsHelpIndex()
545
        self.assertEqual([], index.get_topics('nothing by this name'))
546
547
    def test_prefix(self):
548
        """PluginsHelpIndex has a prefix of 'plugins/'."""
549
        index = plugin.PluginsHelpIndex()
550
        self.assertEqual('plugins/', index.prefix)
551
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
552
    def test_get_plugin_topic_with_prefix(self):
553
        """Searching for plugins/demo_module returns help."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
554
        index = plugin.PluginsHelpIndex()
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
555
        self.assertFalse(sys.modules.has_key('bzrlib.plugins.demo_module'))
556
        demo_module = FakeModule('', 'bzrlib.plugins.demo_module')
557
        sys.modules['bzrlib.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
558
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
559
            topics = index.get_topics('plugins/demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
560
            self.assertEqual(1, len(topics))
561
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
562
            self.assertEqual(demo_module, topics[0].module)
563
        finally:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
564
            del sys.modules['bzrlib.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
565
566
567
class FakeModule(object):
568
    """A fake module to test with."""
569
570
    def __init__(self, doc, name):
571
        self.__doc__ = doc
572
        self.__name__ = name
573
574
575
class TestModuleHelpTopic(tests.TestCase):
576
    """Tests for the ModuleHelpTopic class."""
577
578
    def test_contruct(self):
579
        """Construction takes the module to document."""
580
        mod = FakeModule('foo', 'foo')
581
        topic = plugin.ModuleHelpTopic(mod)
582
        self.assertEqual(mod, topic.module)
583
584
    def test_get_help_text_None(self):
585
        """A ModuleHelpTopic returns the docstring for get_help_text."""
586
        mod = FakeModule(None, 'demo')
587
        topic = plugin.ModuleHelpTopic(mod)
588
        self.assertEqual("Plugin 'demo' has no docstring.\n",
589
            topic.get_help_text())
590
591
    def test_get_help_text_no_carriage_return(self):
592
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
593
        mod = FakeModule('one line of help', 'demo')
594
        topic = plugin.ModuleHelpTopic(mod)
595
        self.assertEqual("one line of help\n",
596
            topic.get_help_text())
597
598
    def test_get_help_text_carriage_return(self):
599
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
600
        mod = FakeModule('two lines of help\nand more\n', 'demo')
601
        topic = plugin.ModuleHelpTopic(mod)
602
        self.assertEqual("two lines of help\nand more\n",
603
            topic.get_help_text())
604
605
    def test_get_help_text_with_additional_see_also(self):
606
        mod = FakeModule('two lines of help\nand more', 'demo')
607
        topic = plugin.ModuleHelpTopic(mod)
608
        self.assertEqual("two lines of help\nand more\nSee also: bar, foo\n",
609
            topic.get_help_text(['foo', 'bar']))
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
610
611
    def test_get_help_topic(self):
612
        """The help topic for a plugin is its module name."""
2432.1.30 by Robert Collins
Fix the ModuleHelpTopic get_help_topic to be tested with closer to real world data and strip the bzrlib.plugins. prefix from the name.
613
        mod = FakeModule('two lines of help\nand more', 'bzrlib.plugins.demo')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
614
        topic = plugin.ModuleHelpTopic(mod)
615
        self.assertEqual('demo', topic.get_help_topic())
2432.1.30 by Robert Collins
Fix the ModuleHelpTopic get_help_topic to be tested with closer to real world data and strip the bzrlib.plugins. prefix from the name.
616
        mod = FakeModule('two lines of help\nand more', 'bzrlib.plugins.foo_bar')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
617
        topic = plugin.ModuleHelpTopic(mod)
618
        self.assertEqual('foo_bar', topic.get_help_topic())
3835.2.7 by Aaron Bentley
Add tests for plugins
619
620
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
621
class TestLoadFromPath(tests.TestCaseInTempDir):
622
623
    def setUp(self):
624
        super(TestLoadFromPath, self).setUp()
625
        # Change bzrlib.plugin to think no plugins have been loaded yet.
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
626
        self.overrideAttr(bzrlib.plugins, '__path__', [])
627
        self.overrideAttr(plugin, '_loaded', False)
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
628
629
        # Monkey-patch load_from_path to stop it from actually loading anything.
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
630
        self.overrideAttr(plugin, 'load_from_path', lambda dirs: None)
3835.2.7 by Aaron Bentley
Add tests for plugins
631
632
    def test_set_plugins_path_with_args(self):
633
        plugin.set_plugins_path(['a', 'b'])
634
        self.assertEqual(['a', 'b'], bzrlib.plugins.__path__)
635
636
    def test_set_plugins_path_defaults(self):
637
        plugin.set_plugins_path()
638
        self.assertEqual(plugin.get_standard_plugins_path(),
639
                         bzrlib.plugins.__path__)
640
641
    def test_get_standard_plugins_path(self):
642
        path = plugin.get_standard_plugins_path()
643
        for directory in path:
4412.2.1 by Vincent Ladeuil
Fix some OSX test regressions (well actual test bugs indeed).
644
            self.assertNotContainsRe(directory, r'\\/$')
3835.2.7 by Aaron Bentley
Add tests for plugins
645
        try:
646
            from distutils.sysconfig import get_python_lib
647
        except ImportError:
648
            pass
649
        else:
650
            if sys.platform != 'win32':
651
                python_lib = get_python_lib()
652
                for directory in path:
653
                    if directory.startswith(python_lib):
654
                        break
655
                else:
656
                    self.fail('No path to global plugins')
657
658
    def test_get_standard_plugins_path_env(self):
659
        os.environ['BZR_PLUGIN_PATH'] = 'foo/'
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
660
        path = plugin.get_standard_plugins_path()
661
        for directory in path:
662
            self.assertNotContainsRe(directory, r'\\/$')
3835.2.7 by Aaron Bentley
Add tests for plugins
663
664
    def test_load_plugins(self):
665
        plugin.load_plugins(['.'])
666
        self.assertEqual(bzrlib.plugins.__path__, ['.'])
667
        # subsequent loads are no-ops
668
        plugin.load_plugins(['foo'])
669
        self.assertEqual(bzrlib.plugins.__path__, ['.'])
670
671
    def test_load_plugins_default(self):
672
        plugin.load_plugins()
673
        path = plugin.get_standard_plugins_path()
674
        self.assertEqual(path, bzrlib.plugins.__path__)
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
675
676
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
677
class TestEnvPluginPath(tests.TestCase):
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
678
679
    def setUp(self):
680
        super(TestEnvPluginPath, self).setUp()
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
681
        self.overrideAttr(plugin, 'DEFAULT_PLUGIN_PATH', None)
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
682
683
        self.user = plugin.get_user_plugin_path()
684
        self.site = plugin.get_site_plugin_path()
685
        self.core = plugin.get_core_plugin_path()
686
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
687
    def _list2paths(self, *args):
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
688
        paths = []
689
        for p in args:
690
            plugin._append_new_path(paths, p)
691
        return paths
692
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
693
    def _set_path(self, *args):
694
        path = os.pathsep.join(self._list2paths(*args))
695
        osutils.set_or_unset_env('BZR_PLUGIN_PATH', path)
696
697
    def check_path(self, expected_dirs, setting_dirs):
698
        if setting_dirs:
699
            self._set_path(*setting_dirs)
700
        actual = plugin.get_standard_plugins_path()
701
        self.assertEquals(self._list2paths(*expected_dirs), actual)
702
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
703
    def test_default(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
704
        self.check_path([self.user, self.core, self.site],
705
                        None)
706
707
    def test_adhoc_policy(self):
708
        self.check_path([self.user, self.core, self.site],
709
                        ['+user', '+core', '+site'])
710
711
    def test_fallback_policy(self):
712
        self.check_path([self.core, self.site, self.user],
713
                        ['+core', '+site', '+user'])
714
715
    def test_override_policy(self):
716
        self.check_path([self.user, self.site, self.core],
717
                        ['+user', '+site', '+core'])
718
719
    def test_disable_user(self):
720
        self.check_path([self.core, self.site], ['-user'])
721
722
    def test_disable_user_twice(self):
723
        # Ensures multiple removals don't left cruft
724
        self.check_path([self.core, self.site], ['-user', '-user'])
725
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
726
    def test_duplicates_are_removed(self):
727
        self.check_path([self.user, self.core, self.site],
728
                        ['+user', '+user'])
729
        # And only the first reference is kept (since the later references will
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
730
        # only produce '<plugin> already loaded' mutters)
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
731
        self.check_path([self.user, self.core, self.site],
732
                        ['+user', '+user', '+core',
733
                         '+user', '+site', '+site',
734
                         '+core'])
735
5086.1.5 by Vincent Ladeuil
Fix typo in test name.
736
    def test_disable_overrides_enable(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
737
        self.check_path([self.core, self.site], ['-user', '+user'])
738
739
    def test_disable_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
740
        self.check_path([self.site], ['-core'])
741
        self.check_path([self.user, self.site], ['+user', '-core'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
742
743
    def test_disable_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
744
        self.check_path([self.core], ['-site'])
745
        self.check_path([self.user, self.core], ['-site', '+user'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
746
747
    def test_override_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
748
        self.check_path(['mysite', self.user, self.core],
749
                        ['mysite', '-site', '+user'])
750
        self.check_path(['mysite', self.core],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
751
                        ['mysite', '-site'])
752
753
    def test_override_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
754
        self.check_path(['mycore', self.user, self.site],
755
                        ['mycore', '-core', '+user', '+site'])
756
        self.check_path(['mycore', self.site],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
757
                        ['mycore', '-core'])
758
759
    def test_my_plugin_only(self):
760
        self.check_path(['myplugin'], ['myplugin', '-user', '-core', '-site'])
761
762
    def test_my_plugin_first(self):
763
        self.check_path(['myplugin', self.core, self.site, self.user],
764
                        ['myplugin', '+core', '+site', '+user'])
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
765
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
766
    def test_bogus_references(self):
767
        self.check_path(['+foo', '-bar', self.core, self.site],
768
                        ['+foo', '-bar'])
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
769
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
770
771
class TestDisablePlugin(tests.TestCaseInTempDir, TestPluginMixin):
772
5086.1.7 by Vincent Ladeuil
Cleaner fix for bug #411413.
773
    def setUp(self):
774
        super(TestDisablePlugin, self).setUp()
775
        self.create_plugin_package('test_foo')
776
        # Make sure we don't pollute the plugins namespace
777
        self.overrideAttr(plugins, '__path__')
778
        # Be paranoid in case a test fail
779
        self.addCleanup(self._unregister_plugin, 'test_foo')
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
780
781
    def test_cannot_import(self):
5086.1.10 by Vincent Ladeuil
Fixed as per review comments.
782
        osutils.set_or_unset_env('BZR_DISABLE_PLUGINS', 'test_foo')
783
        plugin.set_plugins_path(['.'])
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
784
        try:
785
            import bzrlib.plugins.test_foo
786
        except ImportError:
787
            pass
5086.1.7 by Vincent Ladeuil
Cleaner fix for bug #411413.
788
        self.assertPluginUnknown('test_foo')
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
789
5086.1.9 by Vincent Ladeuil
Fix bogus helpers and add a test.
790
    def test_regular_load(self):
791
        self.overrideAttr(plugin, '_loaded', False)
792
        plugin.load_plugins(['.'])
793
        self.assertPluginKnown('test_foo')
5131.2.1 by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings
794
        self.assertDocstring("This is the doc for test_foo",
795
                             bzrlib.plugins.test_foo)
5086.1.9 by Vincent Ladeuil
Fix bogus helpers and add a test.
796
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
797
    def test_not_loaded(self):
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
798
        self.warnings = []
799
        def captured_warning(*args, **kwargs):
800
            self.warnings.append((args, kwargs))
801
        self.overrideAttr(trace, 'warning', captured_warning)
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
802
        # Reset the flag that protect against double loading
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
803
        self.overrideAttr(plugin, '_loaded', False)
5086.1.10 by Vincent Ladeuil
Fixed as per review comments.
804
        osutils.set_or_unset_env('BZR_DISABLE_PLUGINS', 'test_foo')
5086.5.4 by Vincent Ladeuil
Merge for fixes from 411413-plugin-path
805
        plugin.load_plugins(['.'])
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
806
        self.assertPluginUnknown('test_foo')
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
807
        # Make sure we don't warn about the plugin ImportError since this has
808
        # been *requested* by the user.
809
        self.assertLength(0, self.warnings)
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
810
811
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
812
class TestLoadPluginAtSyntax(tests.TestCase):
813
814
    def _get_paths(self, paths):
815
        return plugin._get_specific_plugin_paths(paths)
816
817
    def test_empty(self):
818
        self.assertEquals([], self._get_paths(None))
819
        self.assertEquals([], self._get_paths(''))
820
821
    def test_one_path(self):
822
        self.assertEquals([('b', 'man')], self._get_paths('b@man'))
823
824
    def test_bogus_path(self):
5268.5.2 by Vincent Ladeuil
Catch the wrong path descriptions in BZR_PLUGINS_AT.
825
        # We need a '@'
826
        self.assertRaises(errors.BzrCommandError, self._get_paths, 'batman')
827
        # Too much '@' isn't good either
828
        self.assertRaises(errors.BzrCommandError, self._get_paths,
829
                          'batman@mobile@cave')
830
        # An empty description probably indicates a problem
831
        self.assertRaises(errors.BzrCommandError, self._get_paths,
832
                          os.pathsep.join(['batman@cave', '', 'robin@mobile']))
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
833
834
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
835
class TestLoadPluginAt(tests.TestCaseInTempDir, TestPluginMixin):
836
837
    def setUp(self):
838
        super(TestLoadPluginAt, self).setUp()
839
        # Make sure we don't pollute the plugins namespace
840
        self.overrideAttr(plugins, '__path__')
841
        # Reset the flag that protect against double loading
842
        self.overrideAttr(plugin, '_loaded', False)
843
        # Create the same plugin in two directories
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
844
        self.create_plugin_package('test_foo', dir='non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
845
        # The "normal" directory, we use 'standard' instead of 'plugins' to
846
        # avoid depending on the precise naming.
847
        self.create_plugin_package('test_foo', dir='standard/test_foo')
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
848
        # All the tests will load the 'test_foo' plugin from various locations
849
        self.addCleanup(self._unregister_plugin, 'test_foo')
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
850
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
851
    def assertTestFooLoadedFrom(self, path):
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
852
        self.assertPluginKnown('test_foo')
5131.2.1 by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings
853
        self.assertDocstring('This is the doc for test_foo',
854
                             bzrlib.plugins.test_foo)
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
855
        self.assertEqual(path, bzrlib.plugins.test_foo.dir_source)
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
856
857
    def test_regular_load(self):
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
858
        plugin.load_plugins(['standard'])
859
        self.assertTestFooLoadedFrom('standard/test_foo')
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
860
861
    def test_import(self):
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
862
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
863
        plugin.set_plugins_path(['standard'])
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
864
        try:
865
            import bzrlib.plugins.test_foo
866
        except ImportError:
867
            pass
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
868
        self.assertTestFooLoadedFrom('non-standard-dir')
869
870
    def test_loading(self):
871
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
872
        plugin.load_plugins(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
873
        self.assertTestFooLoadedFrom('non-standard-dir')
874
875
    def test_compiled_loaded(self):
876
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
877
        plugin.load_plugins(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
878
        self.assertTestFooLoadedFrom('non-standard-dir')
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
879
        self.assertIsSameRealPath('non-standard-dir/__init__.py',
880
                                  bzrlib.plugins.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
881
882
        # Try importing again now that the source has been compiled
883
        self._unregister_plugin('test_foo')
884
        plugin._loaded = False
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
885
        plugin.load_plugins(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
886
        self.assertTestFooLoadedFrom('non-standard-dir')
5086.5.11 by Vincent Ladeuil
Fix pqm failure.
887
        if __debug__:
888
            suffix = 'pyc'
889
        else:
890
            suffix = 'pyo'
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
891
        self.assertIsSameRealPath('non-standard-dir/__init__.%s' % suffix,
892
                                  bzrlib.plugins.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
893
894
    def test_submodule_loading(self):
895
        # We create an additional directory under the one for test_foo
896
        self.create_plugin_package('test_bar', dir='non-standard-dir/test_bar')
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
897
        self.addCleanup(self._unregister_plugin_submodule,
898
                        'test_foo', 'test_bar')
5086.5.9 by Vincent Ladeuil
More tests.
899
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
900
        plugin.set_plugins_path(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
901
        import bzrlib.plugins.test_foo
902
        self.assertEqual('bzrlib.plugins.test_foo',
903
                         bzrlib.plugins.test_foo.__package__)
904
        import bzrlib.plugins.test_foo.test_bar
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
905
        self.assertIsSameRealPath('non-standard-dir/test_bar/__init__.py',
906
                                  bzrlib.plugins.test_foo.test_bar.__file__)
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
907
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
908
    def test_relative_submodule_loading(self):
909
        self.create_plugin_package('test_foo', dir='another-dir', source='''
910
import test_bar
911
''')
912
        # We create an additional directory under the one for test_foo
913
        self.create_plugin_package('test_bar', dir='another-dir/test_bar')
914
        self.addCleanup(self._unregister_plugin_submodule,
915
                        'test_foo', 'test_bar')
916
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@another-dir')
917
        plugin.set_plugins_path(['standard'])
918
        import bzrlib.plugins.test_foo
919
        self.assertEqual('bzrlib.plugins.test_foo',
920
                         bzrlib.plugins.test_foo.__package__)
921
        self.assertIsSameRealPath('another-dir/test_bar/__init__.py',
922
                                  bzrlib.plugins.test_foo.test_bar.__file__)
923
5086.5.15 by Vincent Ladeuil
Fixed as per Ian's review.
924
    def test_loading_from___init__only(self):
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
925
        # We rename the existing __init__.py file to ensure that we don't load
926
        # a random file
927
        init = 'non-standard-dir/__init__.py'
928
        random = 'non-standard-dir/setup.py'
929
        os.rename(init, random)
930
        self.addCleanup(os.rename, random, init)
931
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@non-standard-dir')
932
        plugin.load_plugins(['standard'])
933
        self.assertPluginUnknown('test_foo')
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
934
935
    def test_loading_from_specific_file(self):
936
        plugin_dir = 'non-standard-dir'
937
        plugin_file_name = 'iamtestfoo.py'
938
        plugin_path = osutils.pathjoin(plugin_dir, plugin_file_name)
939
        source = '''\
940
"""This is the doc for %s"""
941
dir_source = '%s'
942
''' % ('test_foo', plugin_path)
943
        self.create_plugin('test_foo', source=source,
944
                           dir=plugin_dir, file_name=plugin_file_name)
945
        osutils.set_or_unset_env('BZR_PLUGINS_AT', 'test_foo@%s' % plugin_path)
946
        plugin.load_plugins(['standard'])
947
        self.assertTestFooLoadedFrom(plugin_path)