4634.122.4
by John Arbash Meinel
Add a test which exposes the bug in revert. |
1 |
# Copyright (C) 2006, 2007, 2009, 2010 Canonical Ltd
|
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
2 |
#
|
3 |
# This program is free software; you can redistribute it and/or modify
|
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
7 |
#
|
|
8 |
# This program is distributed in the hope that it will be useful,
|
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
12 |
#
|
|
13 |
# You should have received a copy of the GNU General Public License
|
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
16 |
|
2499.1.1
by Aaron Bentley
Revert does not try to preserve file contents produced by revert |
17 |
import os |
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
18 |
|
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
19 |
from bzrlib import merge, tests, transform, workingtree |
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
20 |
|
21 |
||
22 |
class TestRevert(tests.TestCaseWithTransport): |
|
23 |
"""Ensure that revert behaves as expected"""
|
|
24 |
||
25 |
def test_revert_merged_dir(self): |
|
26 |
"""Reverting a merge that adds a directory deletes the directory"""
|
|
27 |
source_tree = self.make_branch_and_tree('source') |
|
28 |
source_tree.commit('empty tree') |
|
29 |
target_tree = source_tree.bzrdir.sprout('target').open_workingtree() |
|
30 |
self.build_tree(['source/dir/', 'source/dir/contents']) |
|
31 |
source_tree.add(['dir', 'dir/contents'], ['dir-id', 'contents-id']) |
|
32 |
source_tree.commit('added dir') |
|
3146.4.6
by Aaron Bentley
Fix locking issues in revert tests |
33 |
target_tree.lock_write() |
34 |
self.addCleanup(target_tree.unlock) |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
35 |
merge.merge_inner(target_tree.branch, source_tree.basis_tree(), |
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
36 |
target_tree.basis_tree(), this_tree=target_tree) |
37 |
self.failUnlessExists('target/dir') |
|
38 |
self.failUnlessExists('target/dir/contents') |
|
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
39 |
target_tree.revert() |
1551.8.15
by Aaron Bentley
bug #54172: handle new directories properly in revert |
40 |
self.failIfExists('target/dir/contents') |
41 |
self.failIfExists('target/dir') |
|
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
42 |
|
43 |
def test_revert_new(self): |
|
44 |
"""Only locally-changed new files should be preserved when reverting
|
|
45 |
||
46 |
When a file isn't present in revert's target tree:
|
|
47 |
If a file hasn't been committed, revert should unversion it, but not
|
|
48 |
delete it.
|
|
49 |
If a file has local changes, revert should unversion it, but not
|
|
50 |
delete it.
|
|
51 |
If a file has no changes from the last commit, revert should delete it.
|
|
52 |
If a file has changes due to a merge, revert should delete it.
|
|
53 |
"""
|
|
54 |
tree = self.make_branch_and_tree('tree') |
|
55 |
tree.commit('empty tree') |
|
56 |
merge_target = tree.bzrdir.sprout('merge_target').open_workingtree() |
|
57 |
self.build_tree(['tree/new_file']) |
|
1551.8.33
by Aaron Bentley
Changes from review |
58 |
|
59 |
# newly-added files should not be deleted
|
|
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
60 |
tree.add('new_file') |
2255.7.37
by Robert Collins
Dont use a basis tree that is not in the tree's parents for revert testing - its not guaranteed usable. |
61 |
basis_tree = tree.branch.repository.revision_tree(tree.last_revision()) |
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
62 |
tree.revert() |
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
63 |
self.failUnlessExists('tree/new_file') |
1551.8.33
by Aaron Bentley
Changes from review |
64 |
|
65 |
# unchanged files should be deleted
|
|
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
66 |
tree.add('new_file') |
67 |
tree.commit('add new_file') |
|
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
68 |
tree.revert(old_tree=basis_tree) |
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
69 |
self.failIfExists('tree/new_file') |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
70 |
|
1551.8.33
by Aaron Bentley
Changes from review |
71 |
# files should be deleted if their changes came from merges
|
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
72 |
merge_target.merge_from_branch(tree.branch) |
73 |
self.failUnlessExists('merge_target/new_file') |
|
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
74 |
merge_target.revert() |
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
75 |
self.failIfExists('merge_target/new_file') |
1551.8.33
by Aaron Bentley
Changes from review |
76 |
|
77 |
# files should not be deleted if changed after a merge
|
|
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
78 |
merge_target.merge_from_branch(tree.branch) |
79 |
self.failUnlessExists('merge_target/new_file') |
|
1551.8.33
by Aaron Bentley
Changes from review |
80 |
self.build_tree_contents([('merge_target/new_file', 'new_contents')]) |
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
81 |
merge_target.revert() |
1551.8.32
by Aaron Bentley
Fix iteraction of revert and files not present in target_tree |
82 |
self.failUnlessExists('merge_target/new_file') |
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
83 |
|
84 |
def tree_with_executable(self): |
|
85 |
tree = self.make_branch_and_tree('tree') |
|
86 |
tt = transform.TreeTransform(tree) |
|
87 |
tt.new_file('newfile', tt.root, 'helooo!', 'newfile-id', True) |
|
88 |
tt.apply() |
|
3146.4.6
by Aaron Bentley
Fix locking issues in revert tests |
89 |
tree.lock_write() |
90 |
try: |
|
91 |
self.assertTrue(tree.is_executable('newfile-id')) |
|
92 |
tree.commit('added newfile') |
|
93 |
finally: |
|
94 |
tree.unlock() |
|
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
95 |
return tree |
96 |
||
97 |
def test_preserve_execute(self): |
|
98 |
tree = self.tree_with_executable() |
|
99 |
tt = transform.TreeTransform(tree) |
|
100 |
newfile = tt.trans_id_tree_file_id('newfile-id') |
|
101 |
tt.delete_contents(newfile) |
|
102 |
tt.create_file('Woooorld!', newfile) |
|
103 |
tt.apply() |
|
104 |
tree = workingtree.WorkingTree.open('tree') |
|
3146.4.6
by Aaron Bentley
Fix locking issues in revert tests |
105 |
tree.lock_write() |
106 |
self.addCleanup(tree.unlock) |
|
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
107 |
self.assertTrue(tree.is_executable('newfile-id')) |
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
108 |
transform.revert(tree, tree.basis_tree(), None, backups=True) |
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
109 |
self.assertEqual('helooo!', tree.get_file('newfile-id').read()) |
110 |
self.assertTrue(tree.is_executable('newfile-id')) |
|
111 |
||
112 |
def test_revert_executable(self): |
|
113 |
tree = self.tree_with_executable() |
|
114 |
tt = transform.TreeTransform(tree) |
|
115 |
newfile = tt.trans_id_tree_file_id('newfile-id') |
|
116 |
tt.set_executability(False, newfile) |
|
117 |
tt.apply() |
|
3146.4.6
by Aaron Bentley
Fix locking issues in revert tests |
118 |
tree.lock_write() |
119 |
self.addCleanup(tree.unlock) |
|
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
120 |
transform.revert(tree, tree.basis_tree(), None) |
1551.9.10
by Aaron Bentley
Fix bugs in execute bit handling by revert |
121 |
self.assertTrue(tree.is_executable('newfile-id')) |
2499.1.1
by Aaron Bentley
Revert does not try to preserve file contents produced by revert |
122 |
|
123 |
def test_revert_deletes_files_from_revert(self): |
|
124 |
tree = self.make_branch_and_tree('.') |
|
125 |
self.build_tree(['file']) |
|
126 |
tree.add('file') |
|
127 |
tree.commit('added file', rev_id='rev1') |
|
128 |
os.unlink('file') |
|
129 |
tree.commit('removed file') |
|
130 |
self.failIfExists('file') |
|
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
131 |
tree.revert(old_tree=tree.branch.repository.revision_tree('rev1')) |
2499.1.1
by Aaron Bentley
Revert does not try to preserve file contents produced by revert |
132 |
self.failUnlessExists('file') |
2748.3.2
by Aaron Bentley
Fix revert, remove-tree, and various tests to use None for 'no files specified' |
133 |
tree.revert() |
2499.1.1
by Aaron Bentley
Revert does not try to preserve file contents produced by revert |
134 |
self.failIfExists('file') |
135 |
self.assertEqual({}, tree.merge_modified()) |
|
2748.3.3
by Aaron Bentley
Add a deprecation warning for revert([]), and handle as revert(None) for now |
136 |
|
137 |
def test_empty_deprecated(self): |
|
138 |
tree = self.make_branch_and_tree('.') |
|
139 |
self.build_tree(['file']) |
|
140 |
tree.add('file') |
|
141 |
self.callDeprecated(['Using [] to revert all files is deprecated' |
|
142 |
' as of bzr 0.91. Please use None (the default) instead.'], |
|
143 |
tree.revert, []) |
|
144 |
self.assertIs(None, tree.path2id('file')) |
|
1551.19.4
by Aaron Bentley
Add failing test case |
145 |
|
146 |
def test_revert_file_in_deleted_dir(self): |
|
147 |
tree = self.make_branch_and_tree('.') |
|
1551.19.9
by Aaron Bentley
Update from review |
148 |
self.build_tree(['dir/', 'dir/file1', 'dir/file2']) |
149 |
tree.add(['dir', 'dir/file1', 'dir/file2'], |
|
150 |
['dir-id', 'file1-id', 'file2-id']) |
|
151 |
tree.commit("Added files") |
|
152 |
os.unlink('dir/file1') |
|
153 |
os.unlink('dir/file2') |
|
1551.19.4
by Aaron Bentley
Add failing test case |
154 |
os.rmdir('dir') |
1551.19.9
by Aaron Bentley
Update from review |
155 |
tree.remove(['dir/', 'dir/file1', 'dir/file2']) |
156 |
tree.revert(['dir/file1']) |
|
157 |
self.failUnlessExists('dir/file1') |
|
158 |
self.failIfExists('dir/file2') |
|
159 |
self.assertEqual('dir-id', tree.path2id('dir')) |
|
4634.122.4
by John Arbash Meinel
Add a test which exposes the bug in revert. |
160 |
|
161 |
def test_revert_root_id_change(self): |
|
162 |
tree = self.make_branch_and_tree('.') |
|
163 |
tree.set_root_id('initial-root-id') |
|
164 |
self.build_tree(['file1']) |
|
165 |
tree.add(['file1']) |
|
166 |
tree.commit('first') |
|
167 |
tree.set_root_id('temp-root-id') |
|
168 |
self.assertEqual('temp-root-id', tree.get_root_id()) |
|
169 |
tree.revert() |
|
170 |
self.assertEqual('initial-root-id', tree.get_root_id()) |