~bzr-pqm/bzr/bzr.dev

4797.32.2 by John Arbash Meinel
merge 2.1, resolving NEWS conflict.
1
# Copyright (C) 2006-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1553.5.12 by Martin Pool
New LockDir locking mechanism
16
17
"""Tests for LockDir"""
18
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
19
from cStringIO import StringIO
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
20
import os
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
21
from threading import Thread, Lock
1553.5.12 by Martin Pool
New LockDir locking mechanism
22
import time
23
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
24
import bzrlib
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
25
from bzrlib import (
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
26
    config,
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
27
    errors,
3331.3.13 by Martin Pool
Fix up imports
28
    lock,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
29
    osutils,
1551.10.4 by Aaron Bentley
Update to skip on win32
30
    tests,
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
31
    transport,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
32
    )
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
33
from bzrlib.errors import (
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
34
    LockBreakMismatch,
35
    LockBroken,
36
    LockContention,
37
    LockError,
38
    LockFailed,
39
    LockNotHeld,
40
    )
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
41
from bzrlib.lockdir import LockDir
1553.5.33 by Martin Pool
LockDir review comment fixes
42
from bzrlib.tests import TestCaseWithTransport
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
43
from bzrlib.trace import note
1553.5.12 by Martin Pool
New LockDir locking mechanism
44
45
# These tests sometimes use threads to test the behaviour of lock files with
46
# concurrent actors.  This is not a typical (or necessarily supported) use;
47
# they're really meant for guarding between processes.
48
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
49
# These tests are run on the default transport provided by the test framework
50
# (typically a local disk transport).  That can be changed by the --transport
51
# option to bzr selftest.  The required properties of the transport
52
# implementation are tested separately.  (The main requirement is just that
53
# they don't allow overwriting nonempty directories.)
54
1553.5.12 by Martin Pool
New LockDir locking mechanism
55
class TestLockDir(TestCaseWithTransport):
56
    """Test LockDir operations"""
57
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
58
    def logging_report_function(self, fmt, *args):
59
        self._logged_reports.append((fmt, args))
60
61
    def setup_log_reporter(self, lock_dir):
62
        self._logged_reports = []
63
        lock_dir._report_function = self.logging_report_function
64
1553.5.12 by Martin Pool
New LockDir locking mechanism
65
    def test_00_lock_creation(self):
66
        """Creation of lock file on a transport"""
67
        t = self.get_transport()
68
        lf = LockDir(t, 'test_lock')
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
69
        self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
70
71
    def test_01_lock_repr(self):
72
        """Lock string representation"""
73
        lf = LockDir(self.get_transport(), 'test_lock')
74
        r = repr(lf)
75
        self.assertContainsRe(r, r'^LockDir\(.*/test_lock\)$')
76
77
    def test_02_unlocked_peek(self):
78
        lf = LockDir(self.get_transport(), 'test_lock')
79
        self.assertEqual(lf.peek(), None)
80
1687.1.3 by Robert Collins
Make LockDir.unlock check the lock is still intact.
81
    def get_lock(self):
82
        return LockDir(self.get_transport(), 'test_lock')
83
84
    def test_unlock_after_break_raises(self):
85
        ld = self.get_lock()
86
        ld2 = self.get_lock()
87
        ld.create()
88
        ld.attempt_lock()
89
        ld2.force_break(ld2.peek())
90
        self.assertRaises(LockBroken, ld.unlock)
91
1553.5.12 by Martin Pool
New LockDir locking mechanism
92
    def test_03_readonly_peek(self):
93
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
94
        self.assertEqual(lf.peek(), None)
95
96
    def test_10_lock_uncontested(self):
97
        """Acquire and release a lock"""
98
        t = self.get_transport()
99
        lf = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
100
        lf.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
101
        lf.attempt_lock()
102
        try:
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
103
            self.assertTrue(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
104
        finally:
105
            lf.unlock()
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
106
            self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
107
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
108
    def test_11_create_readonly_transport(self):
109
        """Fail to create lock on readonly transport"""
110
        t = self.get_readonly_transport()
111
        lf = LockDir(t, 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
112
        self.assertRaises(LockFailed, lf.create)
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
113
114
    def test_12_lock_readonly_transport(self):
1553.5.12 by Martin Pool
New LockDir locking mechanism
115
        """Fail to lock on readonly transport"""
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
116
        lf = LockDir(self.get_transport(), 'test_lock')
117
        lf.create()
118
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
119
        self.assertRaises(LockFailed, lf.attempt_lock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
120
121
    def test_20_lock_contested(self):
122
        """Contention to get a lock"""
123
        t = self.get_transport()
124
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
125
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
126
        lf1.attempt_lock()
127
        lf2 = LockDir(t, 'test_lock')
128
        try:
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
129
            # locking is between LockDir instances; aliases within
1553.5.12 by Martin Pool
New LockDir locking mechanism
130
            # a single process are not detected
131
            lf2.attempt_lock()
132
            self.fail('Failed to detect lock collision')
133
        except LockContention, e:
134
            self.assertEqual(e.lock, lf2)
135
            self.assertContainsRe(str(e),
136
                    r'^Could not acquire.*test_lock.*$')
137
        lf1.unlock()
138
139
    def test_20_lock_peek(self):
140
        """Peek at the state of a lock"""
141
        t = self.get_transport()
142
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
143
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
144
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
145
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
146
        # lock is held, should get some info on it
147
        info1 = lf1.peek()
148
        self.assertEqual(set(info1.keys()),
149
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
150
        # should get the same info if we look at it through a different
151
        # instance
152
        info2 = LockDir(t, 'test_lock').peek()
153
        self.assertEqual(info1, info2)
154
        # locks which are never used should be not-held
155
        self.assertEqual(LockDir(t, 'other_lock').peek(), None)
156
157
    def test_21_peek_readonly(self):
158
        """Peek over a readonly transport"""
159
        t = self.get_transport()
160
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
161
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
162
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
163
        self.assertEqual(lf2.peek(), None)
164
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
165
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
166
        info2 = lf2.peek()
167
        self.assertTrue(info2)
168
        self.assertEqual(info2['nonce'], lf1.nonce)
169
170
    def test_30_lock_wait_fail(self):
171
        """Wait on a lock, then fail
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
172
1553.5.12 by Martin Pool
New LockDir locking mechanism
173
        We ask to wait up to 400ms; this should fail within at most one
174
        second.  (Longer times are more realistic but we don't want the test
175
        suite to take too long, and this should do for now.)
176
        """
177
        t = self.get_transport()
178
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
179
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
180
        lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
181
        self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
182
        lf1.attempt_lock()
183
        try:
184
            before = time.time()
185
            self.assertRaises(LockContention, lf2.wait_lock,
186
                              timeout=0.4, poll=0.1)
187
            after = time.time()
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
188
            # it should only take about 0.4 seconds, but we allow more time in
189
            # case the machine is heavily loaded
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
190
            self.assertTrue(after - before <= 8.0,
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
191
                    "took %f seconds to detect lock contention" % (after - before))
1553.5.12 by Martin Pool
New LockDir locking mechanism
192
        finally:
193
            lf1.unlock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
194
        self.assertEqual(1, len(self._logged_reports))
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
195
        self.assertEqual(self._logged_reports[0][0],
5284.6.9 by Parth Malwankar
cleaner handling of lock_url display.
196
            '%s lock %s held by %s\n'
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
197
            'at %s [process #%s], acquired %s.\n'
198
            'Will continue to try until %s, unless '
199
            'you press Ctrl-C.\n'
200
            'See "bzr help break-lock" for more.')
5284.6.4 by Parth Malwankar
local urls are now shows as they are valid.
201
        start, lock_url, user, hostname, pid, time_ago, deadline_str = \
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
202
            self._logged_reports[0][1]
203
        self.assertEqual(start, u'Unable to obtain')
204
        self.assertEqual(user, u'jrandom@example.com')
205
        # skip hostname
206
        self.assertContainsRe(pid, r'\d+')
207
        self.assertContainsRe(time_ago, r'.* ago')
208
        self.assertContainsRe(deadline_str, r'\d{2}:\d{2}:\d{2}')
1553.5.12 by Martin Pool
New LockDir locking mechanism
209
210
    def test_31_lock_wait_easy(self):
211
        """Succeed when waiting on a lock with no contention.
212
        """
213
        t = self.get_transport()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
214
        lf1 = LockDir(t, 'test_lock')
215
        lf1.create()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
216
        self.setup_log_reporter(lf1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
217
        try:
218
            before = time.time()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
219
            lf1.wait_lock(timeout=0.4, poll=0.1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
220
            after = time.time()
221
            self.assertTrue(after - before <= 1.0)
222
        finally:
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
223
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
224
        self.assertEqual([], self._logged_reports)
1553.5.12 by Martin Pool
New LockDir locking mechanism
225
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
226
    def test_32_lock_wait_succeed(self):
227
        """Succeed when trying to acquire a lock that gets released
228
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
229
        One thread holds on a lock and then releases it; another
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
230
        tries to lock it.
231
        """
1551.15.22 by Aaron Bentley
Redo test skip
232
        # This test sometimes fails like this:
233
        # Traceback (most recent call last):
234
235
        #   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
236
        # test_lockdir.py", line 247, in test_32_lock_wait_succeed
237
        #     self.assertEqual(1, len(self._logged_reports))
238
        # AssertionError: not equal:
239
        # a = 1
240
        # b = 0
241
        raise tests.TestSkipped("Test fails intermittently")
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
242
        t = self.get_transport()
243
        lf1 = LockDir(t, 'test_lock')
244
        lf1.create()
245
        lf1.attempt_lock()
246
247
        def wait_and_unlock():
248
            time.sleep(0.1)
249
            lf1.unlock()
250
        unlocker = Thread(target=wait_and_unlock)
251
        unlocker.start()
252
        try:
253
            lf2 = LockDir(t, 'test_lock')
254
            self.setup_log_reporter(lf2)
255
            before = time.time()
256
            # wait and then lock
257
            lf2.wait_lock(timeout=0.4, poll=0.1)
258
            after = time.time()
259
            self.assertTrue(after - before <= 1.0)
260
        finally:
261
            unlocker.join()
262
263
        # There should be only 1 report, even though it should have to
264
        # wait for a while
265
        lock_base = lf2.transport.abspath(lf2.path)
266
        self.assertEqual(1, len(self._logged_reports))
267
        self.assertEqual('%s %s\n'
268
                         '%s\n%s\n'
269
                         'Will continue to try until %s\n',
270
                         self._logged_reports[0][0])
271
        args = self._logged_reports[0][1]
272
        self.assertEqual('Unable to obtain', args[0])
273
        self.assertEqual('lock %s' % (lock_base,), args[1])
274
        self.assertStartsWith(args[2], 'held by ')
275
        self.assertStartsWith(args[3], 'locked ')
276
        self.assertEndsWith(args[3], ' ago')
277
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
278
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
279
    def test_34_lock_write_waits(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
280
        """LockDir.lock_write() will wait for the lock."""
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
281
        # the test suite sets the default to 0 to make deadlocks fail fast.
282
        # change it for this test, as we want to try a manual deadlock.
2631.1.4 by Aaron Bentley
Fix test skip
283
        raise tests.TestSkipped('Timing-sensitive test')
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
284
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
285
        t = self.get_transport()
286
        lf1 = LockDir(t, 'test_lock')
287
        lf1.create()
288
        lf1.attempt_lock()
289
290
        def wait_and_unlock():
291
            time.sleep(0.1)
292
            lf1.unlock()
293
        unlocker = Thread(target=wait_and_unlock)
294
        unlocker.start()
295
        try:
296
            lf2 = LockDir(t, 'test_lock')
297
            self.setup_log_reporter(lf2)
298
            before = time.time()
299
            # wait and then lock
300
            lf2.lock_write()
301
            after = time.time()
302
        finally:
303
            unlocker.join()
304
305
        # There should be only 1 report, even though it should have to
306
        # wait for a while
307
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
308
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
309
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
310
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
311
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
312
                         self._logged_reports[0][0])
313
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
314
        self.assertEqual('Unable to obtain', args[0])
315
        self.assertEqual('lock %s' % (lock_base,), args[1])
316
        self.assertStartsWith(args[2], 'held by ')
317
        self.assertStartsWith(args[3], 'locked ')
318
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
319
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
320
321
    def test_35_wait_lock_changing(self):
322
        """LockDir.wait_lock() will report if the lock changes underneath.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
323
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
324
        This is the stages we want to happen:
325
326
        0) Synchronization locks are created and locked.
327
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
328
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
329
           It sees the lockdir is already acquired, reports the fact,
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
330
           and unsets the 'checked' lock.
331
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
332
           Lock1 to release and acquire the lockdir. This resets the 'check'
333
           lock.
334
        4) Lock2 acquires the 'check' lock, and checks again. It notices
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
335
           that the holder of the lock has changed, and so reports a new
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
336
           lock holder.
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
337
        5) Thread1 blocks on the 'checked' lock, this time, it completely
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
338
           unlocks the lockdir, allowing Lock2 to acquire the lock.
339
        """
340
3497.1.1 by Martin Pool
xfail test_35_wait_lock_changing
341
        raise tests.KnownFailure(
342
            "timing dependency in lock tests (#213182)")
343
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
344
        wait_to_check_lock = Lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
345
        wait_until_checked_lock = Lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
346
347
        wait_to_check_lock.acquire()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
348
        wait_until_checked_lock.acquire()
349
        note('locked check and checked locks')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
350
351
        class LockDir1(LockDir):
352
            """Use the synchronization points for the first lock."""
353
354
            def attempt_lock(self):
355
                # Once we have acquired the lock, it is okay for
356
                # the other lock to check it
357
                try:
358
                    return super(LockDir1, self).attempt_lock()
359
                finally:
360
                    note('lock1: releasing check lock')
361
                    wait_to_check_lock.release()
362
363
        class LockDir2(LockDir):
364
            """Use the synchronization points for the second lock."""
365
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
366
            def attempt_lock(self):
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
367
                note('lock2: waiting for check lock')
368
                wait_to_check_lock.acquire()
369
                note('lock2: acquired check lock')
370
                try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
371
                    return super(LockDir2, self).attempt_lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
372
                finally:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
373
                    note('lock2: releasing checked lock')
374
                    wait_until_checked_lock.release()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
375
376
        t = self.get_transport()
377
        lf1 = LockDir1(t, 'test_lock')
378
        lf1.create()
379
380
        lf2 = LockDir2(t, 'test_lock')
381
        self.setup_log_reporter(lf2)
382
383
        def wait_and_switch():
384
            lf1.attempt_lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
385
            # Block until lock2 has had a chance to check
386
            note('lock1: waiting 1 for checked lock')
387
            wait_until_checked_lock.acquire()
388
            note('lock1: acquired for checked lock')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
389
            note('lock1: released lockdir')
390
            lf1.unlock()
391
            note('lock1: acquiring lockdir')
392
            # Create a new nonce, so the lock looks different.
393
            lf1.nonce = osutils.rand_chars(20)
394
            lf1.lock_write()
395
            note('lock1: acquired lockdir')
396
397
            # Block until lock2 has peeked again
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
398
            note('lock1: waiting 2 for checked lock')
399
            wait_until_checked_lock.acquire()
400
            note('lock1: acquired for checked lock')
401
            # Now unlock, and let lock 2 grab the lock
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
402
            lf1.unlock()
403
            wait_to_check_lock.release()
404
405
        unlocker = Thread(target=wait_and_switch)
406
        unlocker.start()
407
        try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
408
            # Wait and play against the other thread
2709.1.1 by Martin Pool
Make TestLockDir.test_35_wait_lock_changing less timing-sensitive
409
            lf2.wait_lock(timeout=20.0, poll=0.01)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
410
        finally:
411
            unlocker.join()
412
        lf2.unlock()
413
414
        # There should be 2 reports, because the lock changed
415
        lock_base = lf2.transport.abspath(lf2.path)
416
        self.assertEqual(2, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
417
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.15 by John Arbash Meinel
Review feedback from Robert
418
        self.assertEqual('%s %s\n'
419
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
420
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
421
                         'you press Ctrl-C.\n'
422
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
423
                         self._logged_reports[0][0])
424
        args = self._logged_reports[0][1]
425
        self.assertEqual('Unable to obtain', args[0])
426
        self.assertEqual('lock %s' % (lock_base,), args[1])
427
        self.assertStartsWith(args[2], 'held by ')
428
        self.assertStartsWith(args[3], 'locked ')
429
        self.assertEndsWith(args[3], ' ago')
430
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
431
1957.1.15 by John Arbash Meinel
Review feedback from Robert
432
        self.assertEqual('%s %s\n'
433
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
434
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
435
                         'you press Ctrl-C.\n'
436
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
437
                         self._logged_reports[1][0])
438
        args = self._logged_reports[1][1]
439
        self.assertEqual('Lock owner changed for', args[0])
440
        self.assertEqual('lock %s' % (lock_base,), args[1])
441
        self.assertStartsWith(args[2], 'held by ')
442
        self.assertStartsWith(args[3], 'locked ')
443
        self.assertEndsWith(args[3], ' ago')
444
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
445
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
446
    def test_40_confirm_easy(self):
447
        """Confirm a lock that's already held"""
448
        t = self.get_transport()
449
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
450
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
451
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
452
        self.addCleanup(lf1.unlock)
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
453
        lf1.confirm()
454
455
    def test_41_confirm_not_held(self):
456
        """Confirm a lock that's already held"""
457
        t = self.get_transport()
458
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
459
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
460
        self.assertRaises(LockNotHeld, lf1.confirm)
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
461
462
    def test_42_confirm_broken_manually(self):
463
        """Confirm a lock broken by hand"""
464
        t = self.get_transport()
465
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
466
        lf1.create()
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
467
        lf1.attempt_lock()
468
        t.move('test_lock', 'lock_gone_now')
469
        self.assertRaises(LockBroken, lf1.confirm)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
470
        # Clean up
471
        t.move('lock_gone_now', 'test_lock')
472
        lf1.unlock()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
473
474
    def test_43_break(self):
475
        """Break a lock whose caller has forgotten it"""
476
        t = self.get_transport()
477
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
478
        lf1.create()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
479
        lf1.attempt_lock()
480
        # we incorrectly discard the lock object without unlocking it
481
        del lf1
482
        # someone else sees it's still locked
483
        lf2 = LockDir(t, 'test_lock')
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
484
        holder_info = lf2.peek()
485
        self.assertTrue(holder_info)
486
        lf2.force_break(holder_info)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
487
        # now we should be able to take it
488
        lf2.attempt_lock()
4327.1.4 by Vincent Ladeuil
Fix lock test failures by taking lock breaking into account.
489
        self.addCleanup(lf2.unlock)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
490
        lf2.confirm()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
491
492
    def test_44_break_already_released(self):
493
        """Lock break races with regular release"""
494
        t = self.get_transport()
495
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
496
        lf1.create()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
497
        lf1.attempt_lock()
498
        # someone else sees it's still locked
499
        lf2 = LockDir(t, 'test_lock')
500
        holder_info = lf2.peek()
501
        # in the interim the lock is released
502
        lf1.unlock()
503
        # break should succeed
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
504
        lf2.force_break(holder_info)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
505
        # now we should be able to take it
506
        lf2.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
507
        self.addCleanup(lf2.unlock)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
508
        lf2.confirm()
509
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
510
    def test_45_break_mismatch(self):
511
        """Lock break races with someone else acquiring it"""
512
        t = self.get_transport()
513
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
514
        lf1.create()
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
515
        lf1.attempt_lock()
516
        # someone else sees it's still locked
517
        lf2 = LockDir(t, 'test_lock')
518
        holder_info = lf2.peek()
519
        # in the interim the lock is released
520
        lf1.unlock()
521
        lf3 = LockDir(t, 'test_lock')
522
        lf3.attempt_lock()
523
        # break should now *fail*
524
        self.assertRaises(LockBreakMismatch, lf2.force_break,
525
                          holder_info)
526
        lf3.unlock()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
527
528
    def test_46_fake_read_lock(self):
529
        t = self.get_transport()
530
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
531
        lf1.create()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
532
        lf1.lock_read()
533
        lf1.unlock()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
534
535
    def test_50_lockdir_representation(self):
536
        """Check the on-disk representation of LockDirs is as expected.
537
538
        There should always be a top-level directory named by the lock.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
539
        When the lock is held, there should be a lockname/held directory
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
540
        containing an info file.
541
        """
542
        t = self.get_transport()
543
        lf1 = LockDir(t, 'test_lock')
544
        lf1.create()
545
        self.assertTrue(t.has('test_lock'))
546
        lf1.lock_write()
547
        self.assertTrue(t.has('test_lock/held/info'))
548
        lf1.unlock()
549
        self.assertFalse(t.has('test_lock/held/info'))
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
550
551
    def test_break_lock(self):
552
        # the ui based break_lock routine should Just Work (tm)
553
        ld1 = self.get_lock()
554
        ld2 = self.get_lock()
555
        ld1.create()
556
        ld1.lock_write()
1687.1.6 by Robert Collins
Extend LockableFiles to support break_lock() calls.
557
        # do this without IO redirection to ensure it doesn't prompt.
558
        self.assertRaises(AssertionError, ld1.break_lock)
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
559
        orig_factory = bzrlib.ui.ui_factory
4449.3.27 by Martin Pool
More test updates to use CannedInputUIFactory
560
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
561
        try:
562
            ld2.break_lock()
563
            self.assertRaises(LockBroken, ld1.unlock)
564
        finally:
565
            bzrlib.ui.ui_factory = orig_factory
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
566
567
    def test_create_missing_base_directory(self):
568
        """If LockDir.path doesn't exist, it can be created
569
570
        Some people manually remove the entire lock/ directory trying
571
        to unlock a stuck repository/branch/etc. Rather than failing
572
        after that, just create the lock directory when needed.
573
        """
574
        t = self.get_transport()
575
        lf1 = LockDir(t, 'test_lock')
576
577
        lf1.create()
578
        self.failUnless(t.has('test_lock'))
579
580
        t.rmdir('test_lock')
581
        self.failIf(t.has('test_lock'))
582
583
        # This will create 'test_lock' if it needs to
584
        lf1.lock_write()
585
        self.failUnless(t.has('test_lock'))
586
        self.failUnless(t.has('test_lock/held/info'))
587
588
        lf1.unlock()
589
        self.failIf(t.has('test_lock/held/info'))
1957.1.6 by John Arbash Meinel
[merge] bzr.dev 2009
590
1957.1.5 by John Arbash Meinel
Create a helper function for formatting lock information
591
    def test__format_lock_info(self):
592
        ld1 = self.get_lock()
593
        ld1.create()
594
        ld1.lock_write()
595
        try:
596
            info_list = ld1._format_lock_info(ld1.peek())
597
        finally:
598
            ld1.unlock()
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
599
        self.assertEqual(info_list[0], u'jrandom@example.com')
600
        # info_list[1] is hostname. we skip this.
601
        self.assertContainsRe(info_list[2], '^\d+$') # pid
602
        self.assertContainsRe(info_list[3], r'^\d+ seconds? ago$') # time_ago
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
603
604
    def test_lock_without_email(self):
605
        global_config = config.GlobalConfig()
606
        # Intentionally has no email address
607
        global_config.set_user_option('email', 'User Identity')
608
        ld1 = self.get_lock()
609
        ld1.create()
610
        ld1.lock_write()
611
        ld1.unlock()
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
612
613
    def test_lock_permission(self):
1551.10.4 by Aaron Bentley
Update to skip on win32
614
        if not osutils.supports_posix_readonly():
3107.2.2 by John Arbash Meinel
feedback from Martin.
615
            raise tests.TestSkipped('Cannot induce a permission failure')
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
616
        ld1 = self.get_lock()
617
        lock_path = ld1.transport.local_abspath('test_lock')
618
        os.mkdir(lock_path)
619
        osutils.make_readonly(lock_path)
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
620
        self.assertRaises(errors.LockFailed, ld1.attempt_lock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
621
622
    def test_lock_by_token(self):
623
        ld1 = self.get_lock()
624
        token = ld1.lock_write()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
625
        self.addCleanup(ld1.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
626
        self.assertNotEqual(None, token)
627
        ld2 = self.get_lock()
628
        t2 = ld2.lock_write(token)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
629
        self.addCleanup(ld2.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
630
        self.assertEqual(token, t2)
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
631
632
    def test_lock_with_buggy_rename(self):
633
        # test that lock acquisition handles servers which pretend they
634
        # renamed correctly but that actually fail
635
        t = transport.get_transport('brokenrename+' + self.get_url())
636
        ld1 = LockDir(t, 'test_lock')
637
        ld1.create()
638
        ld1.attempt_lock()
639
        ld2 = LockDir(t, 'test_lock')
2555.3.14 by Martin Pool
Better handling in LockDir of rename that moves one directory within another
640
        # we should fail to lock
641
        e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
642
        # now the original caller should succeed in unlocking
643
        ld1.unlock()
644
        # and there should be nothing left over
645
        self.assertEquals([], t.list_dir('test_lock'))
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
646
647
    def test_failed_lock_leaves_no_trash(self):
648
        # if we fail to acquire the lock, we don't leave pending directories
649
        # behind -- https://bugs.launchpad.net/bzr/+bug/109169
650
        ld1 = self.get_lock()
651
        ld2 = self.get_lock()
652
        # should be nothing before we start
653
        ld1.create()
654
        t = self.get_transport().clone('test_lock')
655
        def check_dir(a):
656
            self.assertEquals(a, t.list_dir('.'))
657
        check_dir([])
658
        # when held, that's all we see
659
        ld1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
660
        self.addCleanup(ld1.unlock)
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
661
        check_dir(['held'])
662
        # second guy should fail
663
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
664
        # no kibble
665
        check_dir(['held'])
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
666
4634.138.1 by Martin Pool
Add failing test for \#185103
667
    def test_no_lockdir_info(self):
668
        """We can cope with empty info files."""
669
        # This seems like a fairly common failure case - see
5243.1.2 by Martin
Point launchpad links in comments at production server rather than edge
670
        # <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
4634.138.1 by Martin Pool
Add failing test for \#185103
671
        # Processes are often interrupted after opening the file
672
        # before the actual contents are committed.
673
        t = self.get_transport()
674
        t.mkdir('test_lock')
675
        t.mkdir('test_lock/held')
676
        t.put_bytes('test_lock/held/info', '')
677
        lf = LockDir(t, 'test_lock')
4634.138.2 by Martin Pool
Copy with lock info file being empty
678
        info = lf.peek()
679
        formatted_info = lf._format_lock_info(info)
680
        self.assertEquals(
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
681
            ['<unknown>', '<unknown>', '<unknown>', '(unknown)'],
4634.138.2 by Martin Pool
Copy with lock info file being empty
682
            formatted_info)
4634.138.1 by Martin Pool
Add failing test for \#185103
683
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
684
685
class TestLockDirHooks(TestCaseWithTransport):
686
687
    def setUp(self):
688
        super(TestLockDirHooks, self).setUp()
689
        self._calls = []
690
691
    def get_lock(self):
692
        return LockDir(self.get_transport(), 'test_lock')
693
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
694
    def record_hook(self, result):
695
        self._calls.append(result)
696
3331.3.12 by Martin Pool
Remove PhysicalLock class
697
    def test_LockDir_acquired_success(self):
698
        # the LockDir.lock_acquired hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
699
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
700
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
701
        ld = self.get_lock()
702
        ld.create()
703
        self.assertEqual([], self._calls)
704
        result = ld.attempt_lock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
705
        lock_path = ld.transport.abspath(ld.path)
706
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
707
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
708
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
709
3331.3.12 by Martin Pool
Remove PhysicalLock class
710
    def test_LockDir_acquired_fail(self):
711
        # the LockDir.lock_acquired hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
712
        ld = self.get_lock()
713
        ld.create()
714
        ld2 = self.get_lock()
715
        ld2.attempt_lock()
716
        # install a lock hook now, when the disk lock is locked
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
717
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
718
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
719
        self.assertRaises(errors.LockContention, ld.attempt_lock)
720
        self.assertEqual([], self._calls)
721
        ld2.unlock()
722
        self.assertEqual([], self._calls)
723
3331.3.12 by Martin Pool
Remove PhysicalLock class
724
    def test_LockDir_released_success(self):
725
        # the LockDir.lock_released hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
726
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
727
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
728
        ld = self.get_lock()
729
        ld.create()
730
        self.assertEqual([], self._calls)
731
        result = ld.attempt_lock()
732
        self.assertEqual([], self._calls)
733
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
734
        lock_path = ld.transport.abspath(ld.path)
735
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
736
3331.3.12 by Martin Pool
Remove PhysicalLock class
737
    def test_LockDir_released_fail(self):
738
        # the LockDir.lock_released hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
739
        ld = self.get_lock()
740
        ld.create()
741
        ld2 = self.get_lock()
742
        ld.attempt_lock()
743
        ld2.force_break(ld2.peek())
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
744
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
745
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
746
        self.assertRaises(LockBroken, ld.unlock)
747
        self.assertEqual([], self._calls)
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
748
749
    def test_LockDir_broken_success(self):
750
        # the LockDir.lock_broken hook fires when a lock is broken.
751
        ld = self.get_lock()
752
        ld.create()
753
        ld2 = self.get_lock()
754
        result = ld.attempt_lock()
755
        LockDir.hooks.install_named_hook('lock_broken',
756
                                         self.record_hook, 'record_hook')
757
        ld2.force_break(ld2.peek())
758
        lock_path = ld.transport.abspath(ld.path)
759
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
760
761
    def test_LockDir_broken_failure(self):
762
        # the LockDir.lock_broken hook does not fires when a lock is already
763
        # released.
764
        ld = self.get_lock()
765
        ld.create()
766
        ld2 = self.get_lock()
767
        result = ld.attempt_lock()
768
        holder_info = ld2.peek()
769
        ld.unlock()
770
        LockDir.hooks.install_named_hook('lock_broken',
771
                                         self.record_hook, 'record_hook')
772
        ld2.force_break(holder_info)
773
        lock_path = ld.transport.abspath(ld.path)
774
        self.assertEqual([], self._calls)