4988.10.5
by John Arbash Meinel
Merge bzr.dev 5021 to resolve NEWS |
1 |
# Copyright (C) 2005, 2006, 2007, 2009, 2010 Canonical Ltd
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
2 |
#
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
3 |
# This program is free software; you can redistribute it and/or modify
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
7 |
#
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
8 |
# This program is distributed in the hope that it will be useful,
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
12 |
#
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
13 |
# You should have received a copy of the GNU General Public License
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
16 |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
17 |
# TODO: 'bzr resolve' should accept a directory name and work from that
|
1185.16.11
by Martin Pool
todo |
18 |
# point down
|
19 |
||
1185.16.33
by Martin Pool
- move 'conflict' and 'resolved' from shipped plugin to regular builtins |
20 |
import os |
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
21 |
|
22 |
from bzrlib.lazy_import import lazy_import |
|
23 |
lazy_import(globals(), """ |
|
1185.16.33
by Martin Pool
- move 'conflict' and 'resolved' from shipped plugin to regular builtins |
24 |
import errno
|
25 |
||
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
26 |
from bzrlib import (
|
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
27 |
builtins,
|
4597.2.29
by Vincent Ladeuil
Fixed as per Andrew's review comments. |
28 |
cleanup,
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
29 |
commands,
|
30 |
errors,
|
|
31 |
osutils,
|
|
32 |
rio,
|
|
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
33 |
trace,
|
4597.3.64
by Vincent Ladeuil
Fixed as per Aaron's remark. |
34 |
transform,
|
4597.3.24
by Vincent Ladeuil
Fix imports in bzrlib/conflicts.py. |
35 |
workingtree,
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
36 |
)
|
37 |
""") |
|
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
38 |
from bzrlib import ( |
39 |
option, |
|
40 |
registry, |
|
41 |
)
|
|
1534.10.6
by Aaron Bentley
Conflict serialization working for WorkingTree3 |
42 |
|
43 |
||
44 |
CONFLICT_SUFFIXES = ('.THIS', '.BASE', '.OTHER') |
|
45 |
||
1185.14.3
by Aaron Bentley
Copied conflict lister in |
46 |
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
47 |
class cmd_conflicts(commands.Command): |
5131.2.1
by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings |
48 |
__doc__ = """List files with conflicts. |
1551.2.18
by Aaron Bentley
Updated docs to clarify conflict handling |
49 |
|
50 |
Merge will do its best to combine the changes in two branches, but there
|
|
51 |
are some kinds of problems only a human can fix. When it encounters those,
|
|
52 |
it will mark a conflict. A conflict means that you need to fix something,
|
|
53 |
before you should commit.
|
|
54 |
||
1551.9.8
by Aaron Bentley
Add --text parameter to conflicts |
55 |
Conflicts normally are listed as short, human-readable messages. If --text
|
56 |
is supplied, the pathnames of files with text conflicts are listed,
|
|
57 |
instead. (This is useful for editing all files with text conflicts.)
|
|
58 |
||
1551.2.18
by Aaron Bentley
Updated docs to clarify conflict handling |
59 |
Use bzr resolve when you have fixed a problem.
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
60 |
"""
|
2598.1.1
by Martin Pool
Add test for and documentation of option style, fix up existing options to comply |
61 |
takes_options = [ |
5171.3.13
by Martin von Gagern
Add --directory option to 7 more commands. |
62 |
'directory', |
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
63 |
option.Option('text', |
64 |
help='List paths of files with text conflicts.'), |
|
2598.1.1
by Martin Pool
Add test for and documentation of option style, fix up existing options to comply |
65 |
]
|
4927.2.1
by Ian Clatworthy
conflicts topic renamed to conflict-types and other minor help clean-ups |
66 |
_see_also = ['resolve', 'conflict-types'] |
1551.9.8
by Aaron Bentley
Add --text parameter to conflicts |
67 |
|
5171.3.13
by Martin von Gagern
Add --directory option to 7 more commands. |
68 |
def run(self, text=False, directory=u'.'): |
69 |
wt = workingtree.WorkingTree.open_containing(directory)[0] |
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
70 |
for conflict in wt.conflicts(): |
1551.9.8
by Aaron Bentley
Add --text parameter to conflicts |
71 |
if text: |
72 |
if conflict.typestring != 'text conflict': |
|
73 |
continue
|
|
74 |
self.outf.write(conflict.path + '\n') |
|
75 |
else: |
|
76 |
self.outf.write(str(conflict) + '\n') |
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
77 |
|
1652.1.1
by Martin Pool
Fix 'bzr resolve' run from subdirectory |
78 |
|
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
79 |
resolve_action_registry = registry.Registry() |
80 |
||
81 |
||
82 |
resolve_action_registry.register( |
|
83 |
'done', 'done', 'Marks the conflict as resolved' ) |
|
84 |
resolve_action_registry.register( |
|
4597.3.67
by Vincent Ladeuil
Settle with --take-this and --take-other as action names. |
85 |
'take-this', 'take_this', |
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
86 |
'Resolve the conflict preserving the version in the working tree' ) |
87 |
resolve_action_registry.register( |
|
4597.3.67
by Vincent Ladeuil
Settle with --take-this and --take-other as action names. |
88 |
'take-other', 'take_other', |
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
89 |
'Resolve the conflict taking the merged version into account' ) |
90 |
resolve_action_registry.default_key = 'done' |
|
91 |
||
92 |
class ResolveActionOption(option.RegistryOption): |
|
93 |
||
94 |
def __init__(self): |
|
95 |
super(ResolveActionOption, self).__init__( |
|
96 |
'action', 'How to resolve the conflict.', |
|
97 |
value_switches=True, |
|
98 |
registry=resolve_action_registry) |
|
99 |
||
100 |
||
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
101 |
class cmd_resolve(commands.Command): |
5131.2.1
by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings |
102 |
__doc__ = """Mark a conflict as resolved. |
1551.2.18
by Aaron Bentley
Updated docs to clarify conflict handling |
103 |
|
104 |
Merge will do its best to combine the changes in two branches, but there
|
|
105 |
are some kinds of problems only a human can fix. When it encounters those,
|
|
106 |
it will mark a conflict. A conflict means that you need to fix something,
|
|
107 |
before you should commit.
|
|
108 |
||
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
109 |
Once you have fixed a problem, use "bzr resolve" to automatically mark
|
4798.7.1
by Neil Martinsen-Burrell
fix some formatting and see also usage |
110 |
text conflicts as fixed, "bzr resolve FILE" to mark a specific conflict as
|
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
111 |
resolved, or "bzr resolve --all" to mark all conflicts as resolved.
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
112 |
"""
|
1185.33.24
by Martin Pool
Add alias 'resolved' |
113 |
aliases = ['resolved'] |
1185.14.3
by Aaron Bentley
Copied conflict lister in |
114 |
takes_args = ['file*'] |
2598.1.2
by Martin Pool
Also check that option help ends in a period, and fix those that don't |
115 |
takes_options = [ |
5171.3.13
by Martin von Gagern
Add --directory option to 7 more commands. |
116 |
'directory', |
4597.3.51
by Vincent Ladeuil
Implement conflicts.ResolveActionOption. |
117 |
option.Option('all', help='Resolve all conflicts in this tree.'), |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
118 |
ResolveActionOption(), |
2598.1.2
by Martin Pool
Also check that option help ends in a period, and fix those that don't |
119 |
]
|
4798.7.1
by Neil Martinsen-Burrell
fix some formatting and see also usage |
120 |
_see_also = ['conflicts'] |
5171.3.13
by Martin von Gagern
Add --directory option to 7 more commands. |
121 |
def run(self, file_list=None, all=False, action=None, directory=u'.'): |
1652.1.3
by Martin Pool
Improved bzr resolve command line handling |
122 |
if all: |
123 |
if file_list: |
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
124 |
raise errors.BzrCommandError("If --all is specified," |
125 |
" no FILE may be provided") |
|
5171.3.13
by Martin von Gagern
Add --directory option to 7 more commands. |
126 |
tree = workingtree.WorkingTree.open_containing(directory)[0] |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
127 |
if action is None: |
128 |
action = 'done' |
|
1185.14.3
by Aaron Bentley
Copied conflict lister in |
129 |
else: |
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
130 |
tree, file_list = builtins.tree_files(file_list) |
1652.1.3
by Martin Pool
Improved bzr resolve command line handling |
131 |
if file_list is None: |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
132 |
if action is None: |
4597.3.56
by Vincent Ladeuil
Add a NEWS entry and prepare submission. |
133 |
# FIXME: There is a special case here related to the option
|
134 |
# handling that could be clearer and easier to discover by
|
|
135 |
# providing an --auto action (bug #344013 and #383396) and
|
|
136 |
# make it mandatory instead of implicit and active only
|
|
137 |
# when no file_list is provided -- vila 091229
|
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
138 |
action = 'auto' |
139 |
else: |
|
140 |
if action is None: |
|
141 |
action = 'done' |
|
142 |
if action == 'auto': |
|
143 |
if file_list is None: |
|
2120.7.3
by Aaron Bentley
Update resolve command to automatically mark conflicts as resolved |
144 |
un_resolved, resolved = tree.auto_resolve() |
145 |
if len(un_resolved) > 0: |
|
146 |
trace.note('%d conflict(s) auto-resolved.', len(resolved)) |
|
147 |
trace.note('Remaining conflicts:') |
|
148 |
for conflict in un_resolved: |
|
149 |
trace.note(conflict) |
|
150 |
return 1 |
|
151 |
else: |
|
152 |
trace.note('All conflicts resolved.') |
|
153 |
return 0 |
|
154 |
else: |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
155 |
# FIXME: This can never occur but the block above needs some
|
4597.3.56
by Vincent Ladeuil
Add a NEWS entry and prepare submission. |
156 |
# refactoring to transfer tree.auto_resolve() to
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
157 |
# conflict.auto(tree) --vila 091242
|
158 |
pass
|
|
159 |
else: |
|
160 |
resolve(tree, file_list, action=action) |
|
161 |
||
162 |
||
163 |
def resolve(tree, paths=None, ignore_misses=False, recursive=False, |
|
164 |
action='done'): |
|
3017.2.2
by Aaron Bentley
Add docstring to resolve |
165 |
"""Resolve some or all of the conflicts in a working tree.
|
166 |
||
167 |
:param paths: If None, resolve all conflicts. Otherwise, select only
|
|
168 |
specified conflicts.
|
|
169 |
:param recursive: If True, then elements of paths which are directories
|
|
170 |
have all their children resolved, etc. When invoked as part of
|
|
171 |
recursive commands like revert, this should be True. For commands
|
|
172 |
or applications wishing finer-grained control, like the resolve
|
|
173 |
command, this should be False.
|
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
174 |
:param ignore_misses: If False, warnings will be printed if the supplied
|
175 |
paths do not have conflicts.
|
|
176 |
:param action: How the conflict should be resolved,
|
|
3017.2.2
by Aaron Bentley
Add docstring to resolve |
177 |
"""
|
1997.1.3
by Robert Collins
All WorkingTree methods which write to the tree, but not to the branch |
178 |
tree.lock_tree_write() |
1534.10.10
by Aaron Bentley
Resolve uses the new stuff. |
179 |
try: |
1534.10.23
by Aaron Bentley
Removed conflicts_to_stanzas and stanzas_to_conflicts |
180 |
tree_conflicts = tree.conflicts() |
1534.10.10
by Aaron Bentley
Resolve uses the new stuff. |
181 |
if paths is None: |
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
182 |
new_conflicts = ConflictList() |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
183 |
to_process = tree_conflicts |
1534.10.10
by Aaron Bentley
Resolve uses the new stuff. |
184 |
else: |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
185 |
new_conflicts, to_process = tree_conflicts.select_conflicts( |
186 |
tree, paths, ignore_misses, recursive) |
|
187 |
for conflict in to_process: |
|
188 |
try: |
|
189 |
conflict._do(action, tree) |
|
190 |
conflict.cleanup(tree) |
|
191 |
except NotImplementedError: |
|
192 |
new_conflicts.append(conflict) |
|
1534.10.10
by Aaron Bentley
Resolve uses the new stuff. |
193 |
try: |
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
194 |
tree.set_conflicts(new_conflicts) |
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
195 |
except errors.UnsupportedOperation: |
1534.10.10
by Aaron Bentley
Resolve uses the new stuff. |
196 |
pass
|
4597.3.26
by Vincent Ladeuil
Tests passing for a minimal --interactive implementation. |
197 |
finally: |
198 |
tree.unlock() |
|
199 |
||
200 |
||
1185.35.1
by Aaron Bentley
Implemented conflicts.restore |
201 |
def restore(filename): |
4597.2.6
by Vincent Ladeuil
Cleanup doc string. |
202 |
"""Restore a conflicted file to the state it was in before merging.
|
203 |
||
204 |
Only text restoration is supported at present.
|
|
1185.35.1
by Aaron Bentley
Implemented conflicts.restore |
205 |
"""
|
206 |
conflicted = False |
|
207 |
try: |
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
208 |
osutils.rename(filename + ".THIS", filename) |
1185.35.1
by Aaron Bentley
Implemented conflicts.restore |
209 |
conflicted = True |
210 |
except OSError, e: |
|
211 |
if e.errno != errno.ENOENT: |
|
212 |
raise
|
|
213 |
try: |
|
214 |
os.unlink(filename + ".BASE") |
|
215 |
conflicted = True |
|
216 |
except OSError, e: |
|
217 |
if e.errno != errno.ENOENT: |
|
218 |
raise
|
|
219 |
try: |
|
220 |
os.unlink(filename + ".OTHER") |
|
221 |
conflicted = True |
|
222 |
except OSError, e: |
|
223 |
if e.errno != errno.ENOENT: |
|
224 |
raise
|
|
225 |
if not conflicted: |
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
226 |
raise errors.NotConflicted(filename) |
1534.10.4
by Aaron Bentley
Implemented conflict serialization |
227 |
|
228 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
229 |
class ConflictList(object): |
1652.1.1
by Martin Pool
Fix 'bzr resolve' run from subdirectory |
230 |
"""List of conflicts.
|
231 |
||
232 |
Typically obtained from WorkingTree.conflicts()
|
|
233 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
234 |
Can be instantiated from stanzas or from Conflict subclasses.
|
235 |
"""
|
|
236 |
||
237 |
def __init__(self, conflicts=None): |
|
238 |
object.__init__(self) |
|
239 |
if conflicts is None: |
|
240 |
self.__list = [] |
|
241 |
else: |
|
242 |
self.__list = conflicts |
|
243 |
||
1652.1.1
by Martin Pool
Fix 'bzr resolve' run from subdirectory |
244 |
def is_empty(self): |
245 |
return len(self.__list) == 0 |
|
246 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
247 |
def __len__(self): |
248 |
return len(self.__list) |
|
249 |
||
250 |
def __iter__(self): |
|
251 |
return iter(self.__list) |
|
252 |
||
253 |
def __getitem__(self, key): |
|
254 |
return self.__list[key] |
|
255 |
||
256 |
def append(self, conflict): |
|
257 |
return self.__list.append(conflict) |
|
258 |
||
259 |
def __eq__(self, other_list): |
|
260 |
return list(self) == list(other_list) |
|
261 |
||
262 |
def __ne__(self, other_list): |
|
263 |
return not (self == other_list) |
|
264 |
||
265 |
def __repr__(self): |
|
266 |
return "ConflictList(%r)" % self.__list |
|
267 |
||
268 |
@staticmethod
|
|
269 |
def from_stanzas(stanzas): |
|
270 |
"""Produce a new ConflictList from an iterable of stanzas"""
|
|
271 |
conflicts = ConflictList() |
|
272 |
for stanza in stanzas: |
|
273 |
conflicts.append(Conflict.factory(**stanza.as_dict())) |
|
274 |
return conflicts |
|
275 |
||
276 |
def to_stanzas(self): |
|
277 |
"""Generator of stanzas"""
|
|
278 |
for conflict in self: |
|
279 |
yield conflict.as_stanza() |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
280 |
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
281 |
def to_strings(self): |
282 |
"""Generate strings for the provided conflicts"""
|
|
283 |
for conflict in self: |
|
284 |
yield str(conflict) |
|
285 |
||
286 |
def remove_files(self, tree): |
|
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
287 |
"""Remove the THIS, BASE and OTHER files for listed conflicts"""
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
288 |
for conflict in self: |
289 |
if not conflict.has_files: |
|
290 |
continue
|
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
291 |
conflict.cleanup(tree) |
1534.10.21
by Aaron Bentley
Moved and renamed conflict functions |
292 |
|
1551.15.58
by Aaron Bentley
Status honours selected paths for conflicts (#127606) |
293 |
def select_conflicts(self, tree, paths, ignore_misses=False, |
294 |
recurse=False): |
|
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
295 |
"""Select the conflicts associated with paths in a tree.
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
296 |
|
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
297 |
File-ids are also used for this.
|
1551.7.10
by Aaron Bentley
Remerge doesn't clear unrelated conflicts |
298 |
:return: a pair of ConflictLists: (not_selected, selected)
|
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
299 |
"""
|
300 |
path_set = set(paths) |
|
301 |
ids = {} |
|
302 |
selected_paths = set() |
|
303 |
new_conflicts = ConflictList() |
|
304 |
selected_conflicts = ConflictList() |
|
305 |
for path in paths: |
|
306 |
file_id = tree.path2id(path) |
|
307 |
if file_id is not None: |
|
308 |
ids[file_id] = path |
|
309 |
||
310 |
for conflict in self: |
|
311 |
selected = False |
|
312 |
for key in ('path', 'conflict_path'): |
|
313 |
cpath = getattr(conflict, key, None) |
|
314 |
if cpath is None: |
|
315 |
continue
|
|
316 |
if cpath in path_set: |
|
317 |
selected = True |
|
318 |
selected_paths.add(cpath) |
|
1551.15.58
by Aaron Bentley
Status honours selected paths for conflicts (#127606) |
319 |
if recurse: |
320 |
if osutils.is_inside_any(path_set, cpath): |
|
321 |
selected = True |
|
322 |
selected_paths.add(cpath) |
|
323 |
||
1534.10.25
by Aaron Bentley
Move select_conflicts into ConflictList |
324 |
for key in ('file_id', 'conflict_file_id'): |
325 |
cfile_id = getattr(conflict, key, None) |
|
326 |
if cfile_id is None: |
|
327 |
continue
|
|
328 |
try: |
|
329 |
cpath = ids[cfile_id] |
|
330 |
except KeyError: |
|
331 |
continue
|
|
332 |
selected = True |
|
333 |
selected_paths.add(cpath) |
|
334 |
if selected: |
|
335 |
selected_conflicts.append(conflict) |
|
336 |
else: |
|
337 |
new_conflicts.append(conflict) |
|
338 |
if ignore_misses is not True: |
|
339 |
for path in [p for p in paths if p not in selected_paths]: |
|
340 |
if not os.path.exists(tree.abspath(path)): |
|
341 |
print "%s does not exist" % path |
|
342 |
else: |
|
343 |
print "%s is not conflicted" % path |
|
344 |
return new_conflicts, selected_conflicts |
|
345 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
346 |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
347 |
class Conflict(object): |
348 |
"""Base class for all types of conflict"""
|
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
349 |
|
4597.3.56
by Vincent Ladeuil
Add a NEWS entry and prepare submission. |
350 |
# FIXME: cleanup should take care of that ? -- vila 091229
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
351 |
has_files = False |
352 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
353 |
def __init__(self, path, file_id=None): |
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
354 |
self.path = path |
2309.4.13
by John Arbash Meinel
Conflicts go through Stanza so the need to be aware of utf8 versus unicode file ids. |
355 |
# warn turned off, because the factory blindly transfers the Stanza
|
356 |
# values to __init__ and Stanza is purely a Unicode api.
|
|
357 |
self.file_id = osutils.safe_file_id(file_id, warn=False) |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
358 |
|
359 |
def as_stanza(self): |
|
1996.3.33
by John Arbash Meinel
make bzrlib/conflicts.py lazy |
360 |
s = rio.Stanza(type=self.typestring, path=self.path) |
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
361 |
if self.file_id is not None: |
2309.4.13
by John Arbash Meinel
Conflicts go through Stanza so the need to be aware of utf8 versus unicode file ids. |
362 |
# Stanza requires Unicode apis
|
363 |
s.add('file_id', self.file_id.decode('utf8')) |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
364 |
return s |
365 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
366 |
def _cmp_list(self): |
367 |
return [type(self), self.path, self.file_id] |
|
368 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
369 |
def __cmp__(self, other): |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
370 |
if getattr(other, "_cmp_list", None) is None: |
371 |
return -1 |
|
372 |
return cmp(self._cmp_list(), other._cmp_list()) |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
373 |
|
1551.7.11
by Aaron Bentley
Add WorkingTree.add_conflicts |
374 |
def __hash__(self): |
375 |
return hash((type(self), self.path, self.file_id)) |
|
376 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
377 |
def __eq__(self, other): |
378 |
return self.__cmp__(other) == 0 |
|
379 |
||
380 |
def __ne__(self, other): |
|
381 |
return not self.__eq__(other) |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
382 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
383 |
def __str__(self): |
384 |
return self.format % self.__dict__ |
|
385 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
386 |
def __repr__(self): |
387 |
rdict = dict(self.__dict__) |
|
388 |
rdict['class'] = self.__class__.__name__ |
|
389 |
return self.rformat % rdict |
|
390 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
391 |
@staticmethod
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
392 |
def factory(type, **kwargs): |
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
393 |
global ctype |
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
394 |
return ctype[type](**kwargs) |
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
395 |
|
1666.1.4
by Robert Collins
* 'Metadir' is now the default disk format. This improves behaviour in |
396 |
@staticmethod
|
397 |
def sort_key(conflict): |
|
398 |
if conflict.path is not None: |
|
399 |
return conflict.path, conflict.typestring |
|
400 |
elif getattr(conflict, "conflict_path", None) is not None: |
|
401 |
return conflict.conflict_path, conflict.typestring |
|
402 |
else: |
|
403 |
return None, conflict.typestring |
|
404 |
||
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
405 |
def _do(self, action, tree): |
406 |
"""Apply the specified action to the conflict.
|
|
407 |
||
408 |
:param action: The method name to call.
|
|
409 |
||
410 |
:param tree: The tree passed as a parameter to the method.
|
|
411 |
"""
|
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
412 |
meth = getattr(self, 'action_%s' % action, None) |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
413 |
if meth is None: |
414 |
raise NotImplementedError(self.__class__.__name__ + '.' + action) |
|
415 |
meth(tree) |
|
416 |
||
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
417 |
def associated_filenames(self): |
418 |
"""The names of the files generated to help resolve the conflict."""
|
|
419 |
raise NotImplementedError(self.associated_filenames) |
|
420 |
||
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
421 |
def cleanup(self, tree): |
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
422 |
for fname in self.associated_filenames(): |
423 |
try: |
|
424 |
osutils.delete_any(tree.abspath(fname)) |
|
425 |
except OSError, e: |
|
426 |
if e.errno != errno.ENOENT: |
|
427 |
raise
|
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
428 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
429 |
def action_done(self, tree): |
4597.3.54
by Vincent Ladeuil
There is no point to define Conflict.done() multiple times. |
430 |
"""Mark the conflict as solved once it has been handled."""
|
431 |
# This method does nothing but simplifies the design of upper levels.
|
|
432 |
pass
|
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
433 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
434 |
def action_take_this(self, tree): |
435 |
raise NotImplementedError(self.action_take_this) |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
436 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
437 |
def action_take_other(self, tree): |
438 |
raise NotImplementedError(self.action_take_other) |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
439 |
|
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
440 |
def _resolve_with_cleanups(self, tree, *args, **kwargs): |
441 |
tt = transform.TreeTransform(tree) |
|
442 |
op = cleanup.OperationWithCleanups(self._resolve) |
|
443 |
op.add_cleanup(tt.finalize) |
|
444 |
op.run_simple(tt, *args, **kwargs) |
|
445 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
446 |
|
447 |
class PathConflict(Conflict): |
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
448 |
"""A conflict was encountered merging file paths"""
|
449 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
450 |
typestring = 'path conflict' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
451 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
452 |
format = 'Path conflict: %(path)s / %(conflict_path)s' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
453 |
|
454 |
rformat = '%(class)s(%(path)r, %(conflict_path)r, %(file_id)r)' |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
455 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
456 |
def __init__(self, path, conflict_path=None, file_id=None): |
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
457 |
Conflict.__init__(self, path, file_id) |
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
458 |
self.conflict_path = conflict_path |
459 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
460 |
def as_stanza(self): |
461 |
s = Conflict.as_stanza(self) |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
462 |
if self.conflict_path is not None: |
463 |
s.add('conflict_path', self.conflict_path) |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
464 |
return s |
465 |
||
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
466 |
def associated_filenames(self): |
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
467 |
# No additional files have been generated here
|
468 |
return [] |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
469 |
|
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
470 |
def _resolve(self, tt, file_id, path, winner): |
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
471 |
"""Resolve the conflict.
|
472 |
||
473 |
:param tt: The TreeTransform where the conflict is resolved.
|
|
474 |
:param file_id: The retained file id.
|
|
475 |
:param path: The retained path.
|
|
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
476 |
:param winner: 'this' or 'other' indicates which side is the winner.
|
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
477 |
"""
|
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
478 |
path_to_create = None |
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
479 |
if winner == 'this': |
480 |
if self.path == '<deleted>': |
|
481 |
return # Nothing to do |
|
482 |
if self.conflict_path == '<deleted>': |
|
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
483 |
path_to_create = self.path |
484 |
revid = tt._tree.get_parent_ids()[0] |
|
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
485 |
elif winner == 'other': |
486 |
if self.conflict_path == '<deleted>': |
|
487 |
return # Nothing to do |
|
488 |
if self.path == '<deleted>': |
|
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
489 |
path_to_create = self.conflict_path |
490 |
# FIXME: If there are more than two parents we may need to
|
|
491 |
# iterate. Taking the last parent is the safer bet in the mean
|
|
492 |
# time. -- vila 20100309
|
|
493 |
revid = tt._tree.get_parent_ids()[-1] |
|
4597.7.18
by Vincent Ladeuil
Start addressing Andrew's concerns. |
494 |
else: |
495 |
# Programmer error
|
|
496 |
raise AssertionError('bad winner: %r' % (winner,)) |
|
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
497 |
if path_to_create is not None: |
498 |
tid = tt.trans_id_tree_path(path_to_create) |
|
499 |
transform.create_from_tree( |
|
500 |
tt, tt.trans_id_tree_path(path_to_create), |
|
4597.7.15
by Vincent Ladeuil
Workaround bug #533547. |
501 |
self._revision_tree(tt._tree, revid), file_id) |
4597.7.14
by Vincent Ladeuil
Tweak the fix to not use helpers but let resolve restore the old version. |
502 |
tt.version_file(file_id, tid) |
503 |
||
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
504 |
# Adjust the path for the retained file id
|
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
505 |
tid = tt.trans_id_file_id(file_id) |
506 |
parent_tid = tt.get_tree_parent(tid) |
|
507 |
tt.adjust_path(path, parent_tid, tid) |
|
508 |
tt.apply() |
|
509 |
||
4597.7.15
by Vincent Ladeuil
Workaround bug #533547. |
510 |
def _revision_tree(self, tree, revid): |
511 |
return tree.branch.repository.revision_tree(revid) |
|
512 |
||
4597.7.16
by Vincent Ladeuil
Some cleanup. |
513 |
def _infer_file_id(self, tree): |
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
514 |
# Prior to bug #531967, file_id wasn't always set, there may still be
|
515 |
# conflict files in the wild so we need to cope with them
|
|
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
516 |
# Establish which path we should use to find back the file-id
|
517 |
possible_paths = [] |
|
518 |
for p in (self.path, self.conflict_path): |
|
519 |
if p == '<deleted>': |
|
520 |
# special hard-coded path
|
|
521 |
continue
|
|
522 |
if p is not None: |
|
523 |
possible_paths.append(p) |
|
524 |
# Search the file-id in the parents with any path available
|
|
525 |
file_id = None |
|
526 |
for revid in tree.get_parent_ids(): |
|
4597.7.15
by Vincent Ladeuil
Workaround bug #533547. |
527 |
revtree = self._revision_tree(tree, revid) |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
528 |
for p in possible_paths: |
529 |
file_id = revtree.path2id(p) |
|
530 |
if file_id is not None: |
|
531 |
return revtree, file_id |
|
532 |
return None, None |
|
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
533 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
534 |
def action_take_this(self, tree): |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
535 |
if self.file_id is not None: |
4597.7.11
by Vincent Ladeuil
Fix #531967 by creating helpers for PathConflicts when a deletion |
536 |
self._resolve_with_cleanups(tree, self.file_id, self.path, |
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
537 |
winner='this') |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
538 |
else: |
539 |
# Prior to bug #531967 we need to find back the file_id and restore
|
|
540 |
# the content from there
|
|
4597.7.16
by Vincent Ladeuil
Some cleanup. |
541 |
revtree, file_id = self._infer_file_id(tree) |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
542 |
tree.revert([revtree.id2path(file_id)], |
543 |
old_tree=revtree, backups=False) |
|
4597.3.33
by Vincent Ladeuil
Implement --interactive for PathConflict. |
544 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
545 |
def action_take_other(self, tree): |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
546 |
if self.file_id is not None: |
4597.7.11
by Vincent Ladeuil
Fix #531967 by creating helpers for PathConflicts when a deletion |
547 |
self._resolve_with_cleanups(tree, self.file_id, |
548 |
self.conflict_path, |
|
4597.7.13
by Vincent Ladeuil
Remove some duplication. |
549 |
winner='other') |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
550 |
else: |
551 |
# Prior to bug #531967 we need to find back the file_id and restore
|
|
552 |
# the content from there
|
|
4597.7.16
by Vincent Ladeuil
Some cleanup. |
553 |
revtree, file_id = self._infer_file_id(tree) |
4597.7.9
by Vincent Ladeuil
Resolve the PathConflict when the file-id has been lost due to bug #531967. |
554 |
tree.revert([revtree.id2path(file_id)], |
555 |
old_tree=revtree, backups=False) |
|
4597.3.33
by Vincent Ladeuil
Implement --interactive for PathConflict. |
556 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
557 |
|
558 |
class ContentsConflict(PathConflict): |
|
4597.8.1
by Vincent Ladeuil
Fix doc string. |
559 |
"""The files are of different types (or both binary), or not present"""
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
560 |
|
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
561 |
has_files = True |
562 |
||
1534.10.20
by Aaron Bentley
Got all tests passing |
563 |
typestring = 'contents conflict' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
564 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
565 |
format = 'Contents conflict in %(path)s' |
566 |
||
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
567 |
def associated_filenames(self): |
568 |
return [self.path + suffix for suffix in ('.BASE', '.OTHER')] |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
569 |
|
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
570 |
def _resolve(self, tt, suffix_to_remove): |
4597.2.26
by Vincent Ladeuil
Fix bug #529968 by renaming the kept file on content conflicts. |
571 |
"""Resolve the conflict.
|
572 |
||
4597.2.29
by Vincent Ladeuil
Fixed as per Andrew's review comments. |
573 |
:param tt: The TreeTransform where the conflict is resolved.
|
4597.2.27
by Vincent Ladeuil
Address some Andrew's review points. |
574 |
:param suffix_to_remove: Either 'THIS' or 'OTHER'
|
4597.2.26
by Vincent Ladeuil
Fix bug #529968 by renaming the kept file on content conflicts. |
575 |
|
576 |
The resolution is symmetric, when taking THIS, OTHER is deleted and
|
|
577 |
item.THIS is renamed into item and vice-versa.
|
|
578 |
"""
|
|
4597.2.29
by Vincent Ladeuil
Fixed as per Andrew's review comments. |
579 |
try: |
580 |
# Delete 'item.THIS' or 'item.OTHER' depending on
|
|
581 |
# suffix_to_remove
|
|
582 |
tt.delete_contents( |
|
583 |
tt.trans_id_tree_path(self.path + '.' + suffix_to_remove)) |
|
584 |
except errors.NoSuchFile: |
|
585 |
# There are valid cases where 'item.suffix_to_remove' either
|
|
586 |
# never existed or was already deleted (including the case
|
|
587 |
# where the user deleted it)
|
|
588 |
pass
|
|
589 |
# Rename 'item.suffix_to_remove' (note that if
|
|
590 |
# 'item.suffix_to_remove' has been deleted, this is a no-op)
|
|
591 |
this_tid = tt.trans_id_file_id(self.file_id) |
|
592 |
parent_tid = tt.get_tree_parent(this_tid) |
|
593 |
tt.adjust_path(self.path, parent_tid, this_tid) |
|
594 |
tt.apply() |
|
595 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
596 |
def action_take_this(self, tree): |
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
597 |
self._resolve_with_cleanups(tree, 'OTHER') |
4597.3.28
by Vincent Ladeuil
Implement --interactive for ContentsConflict. |
598 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
599 |
def action_take_other(self, tree): |
4597.7.8
by Vincent Ladeuil
Some refactoring to help address bug #531967. |
600 |
self._resolve_with_cleanups(tree, 'THIS') |
4597.3.30
by Vincent Ladeuil
Light changes learned while starting to understand multiple conflicts on |
601 |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
602 |
|
4597.3.29
by Vincent Ladeuil
Fix bogus tests. |
603 |
# FIXME: TextConflict is about a single file-id, there never is a conflict_path
|
604 |
# attribute so we shouldn't inherit from PathConflict but simply from Conflict
|
|
4597.3.48
by Vincent Ladeuil
Start cleaning BRANCH.TODO by pushing changes to either the python modules or the documentation. |
605 |
|
606 |
# TODO: There should be a base revid attribute to better inform the user about
|
|
607 |
# how the conflicts were generated.
|
|
1534.10.20
by Aaron Bentley
Got all tests passing |
608 |
class TextConflict(PathConflict): |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
609 |
"""The merge algorithm could not resolve all differences encountered."""
|
610 |
||
1534.10.24
by Aaron Bentley
Eliminated conflicts_to_strings, made remove_files a ConflictList member |
611 |
has_files = True |
612 |
||
1534.10.20
by Aaron Bentley
Got all tests passing |
613 |
typestring = 'text conflict' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
614 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
615 |
format = 'Text conflict in %(path)s' |
616 |
||
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
617 |
def associated_filenames(self): |
618 |
return [self.path + suffix for suffix in CONFLICT_SUFFIXES] |
|
4597.3.33
by Vincent Ladeuil
Implement --interactive for PathConflict. |
619 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
620 |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
621 |
class HandledConflict(Conflict): |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
622 |
"""A path problem that has been provisionally resolved.
|
623 |
This is intended to be a base class.
|
|
624 |
"""
|
|
625 |
||
626 |
rformat = "%(class)s(%(action)r, %(path)r, %(file_id)r)" |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
627 |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
628 |
def __init__(self, action, path, file_id=None): |
629 |
Conflict.__init__(self, path, file_id) |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
630 |
self.action = action |
631 |
||
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
632 |
def _cmp_list(self): |
633 |
return Conflict._cmp_list(self) + [self.action] |
|
634 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
635 |
def as_stanza(self): |
636 |
s = Conflict.as_stanza(self) |
|
637 |
s.add('action', self.action) |
|
638 |
return s |
|
639 |
||
5013.2.4
by Vincent Ladeuil
``bzr add`` won't blindly add conflict related files. |
640 |
def associated_filenames(self): |
641 |
# Nothing has been generated here
|
|
642 |
return [] |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
643 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
644 |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
645 |
class HandledPathConflict(HandledConflict): |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
646 |
"""A provisionally-resolved path problem involving two paths.
|
647 |
This is intended to be a base class.
|
|
648 |
"""
|
|
649 |
||
650 |
rformat = "%(class)s(%(action)r, %(path)r, %(conflict_path)r,"\ |
|
651 |
" %(file_id)r, %(conflict_file_id)r)" |
|
652 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
653 |
def __init__(self, action, path, conflict_path, file_id=None, |
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
654 |
conflict_file_id=None): |
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
655 |
HandledConflict.__init__(self, action, path, file_id) |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
656 |
self.conflict_path = conflict_path |
2309.4.13
by John Arbash Meinel
Conflicts go through Stanza so the need to be aware of utf8 versus unicode file ids. |
657 |
# warn turned off, because the factory blindly transfers the Stanza
|
658 |
# values to __init__.
|
|
659 |
self.conflict_file_id = osutils.safe_file_id(conflict_file_id, |
|
660 |
warn=False) |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
661 |
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
662 |
def _cmp_list(self): |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
663 |
return HandledConflict._cmp_list(self) + [self.conflict_path, |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
664 |
self.conflict_file_id] |
665 |
||
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
666 |
def as_stanza(self): |
667 |
s = HandledConflict.as_stanza(self) |
|
668 |
s.add('conflict_path', self.conflict_path) |
|
669 |
if self.conflict_file_id is not None: |
|
2309.4.13
by John Arbash Meinel
Conflicts go through Stanza so the need to be aware of utf8 versus unicode file ids. |
670 |
s.add('conflict_file_id', self.conflict_file_id.decode('utf8')) |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
671 |
|
1534.10.19
by Aaron Bentley
Stanza conversion, cooking |
672 |
return s |
1534.10.20
by Aaron Bentley
Got all tests passing |
673 |
|
674 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
675 |
class DuplicateID(HandledPathConflict): |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
676 |
"""Two files want the same file_id."""
|
677 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
678 |
typestring = 'duplicate id' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
679 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
680 |
format = 'Conflict adding id to %(conflict_path)s. %(action)s %(path)s.' |
681 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
682 |
|
683 |
class DuplicateEntry(HandledPathConflict): |
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
684 |
"""Two directory entries want to have the same name."""
|
685 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
686 |
typestring = 'duplicate' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
687 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
688 |
format = 'Conflict adding file %(conflict_path)s. %(action)s %(path)s.' |
689 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
690 |
def action_take_this(self, tree): |
4597.3.26
by Vincent Ladeuil
Tests passing for a minimal --interactive implementation. |
691 |
tree.remove([self.conflict_path], force=True, keep_files=False) |
692 |
tree.rename_one(self.path, self.conflict_path) |
|
693 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
694 |
def action_take_other(self, tree): |
4597.3.26
by Vincent Ladeuil
Tests passing for a minimal --interactive implementation. |
695 |
tree.remove([self.path], force=True, keep_files=False) |
696 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
697 |
|
698 |
class ParentLoop(HandledPathConflict): |
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
699 |
"""An attempt to create an infinitely-looping directory structure.
|
700 |
This is rare, but can be produced like so:
|
|
701 |
||
702 |
tree A:
|
|
4597.3.50
by Vincent Ladeuil
Integrate most of BRANCH.TOTO into bzrlib/help_topics/en/conflicts.txt, fix a typo in a test. |
703 |
mv foo bar
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
704 |
tree B:
|
4597.3.50
by Vincent Ladeuil
Integrate most of BRANCH.TOTO into bzrlib/help_topics/en/conflicts.txt, fix a typo in a test. |
705 |
mv bar foo
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
706 |
merge A and B
|
707 |
"""
|
|
708 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
709 |
typestring = 'parent loop' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
710 |
|
4597.8.8
by Vincent Ladeuil
Exhibit bug #537956. |
711 |
format = 'Conflict moving %(path)s into %(conflict_path)s. %(action)s.' |
1534.10.20
by Aaron Bentley
Got all tests passing |
712 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
713 |
def action_take_this(self, tree): |
4597.3.34
by Vincent Ladeuil
Implement --interactive for ParentLoop. |
714 |
# just acccept bzr proposal
|
715 |
pass
|
|
716 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
717 |
def action_take_other(self, tree): |
4597.3.50
by Vincent Ladeuil
Integrate most of BRANCH.TOTO into bzrlib/help_topics/en/conflicts.txt, fix a typo in a test. |
718 |
# FIXME: We shouldn't have to manipulate so many paths here (and there
|
719 |
# is probably a bug or two...)
|
|
4597.3.64
by Vincent Ladeuil
Fixed as per Aaron's remark. |
720 |
base_path = osutils.basename(self.path) |
4597.3.34
by Vincent Ladeuil
Implement --interactive for ParentLoop. |
721 |
conflict_base_path = osutils.basename(self.conflict_path) |
4597.3.64
by Vincent Ladeuil
Fixed as per Aaron's remark. |
722 |
tt = transform.TreeTransform(tree) |
723 |
try: |
|
724 |
p_tid = tt.trans_id_file_id(self.file_id) |
|
725 |
parent_tid = tt.get_tree_parent(p_tid) |
|
726 |
cp_tid = tt.trans_id_file_id(self.conflict_file_id) |
|
727 |
cparent_tid = tt.get_tree_parent(cp_tid) |
|
728 |
tt.adjust_path(base_path, cparent_tid, cp_tid) |
|
729 |
tt.adjust_path(conflict_base_path, parent_tid, p_tid) |
|
730 |
tt.apply() |
|
731 |
finally: |
|
732 |
tt.finalize() |
|
4597.3.34
by Vincent Ladeuil
Implement --interactive for ParentLoop. |
733 |
|
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
734 |
|
735 |
class UnversionedParent(HandledConflict): |
|
4597.2.1
by Vincent Ladeuil
Fix some typos. |
736 |
"""An attempt to version a file whose parent directory is not versioned.
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
737 |
Typically, the result of a merge where one tree unversioned the directory
|
738 |
and the other added a versioned file to it.
|
|
739 |
"""
|
|
740 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
741 |
typestring = 'unversioned parent' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
742 |
|
1551.8.22
by Aaron Bentley
Improve message when OTHER deletes an in-use tree |
743 |
format = 'Conflict because %(path)s is not versioned, but has versioned'\ |
744 |
' children. %(action)s.' |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
745 |
|
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
746 |
# FIXME: We silently do nothing to make tests pass, but most probably the
|
747 |
# conflict shouldn't exist (the long story is that the conflict is
|
|
748 |
# generated with another one that can be resolved properly) -- vila 091224
|
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
749 |
def action_take_this(self, tree): |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
750 |
pass
|
751 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
752 |
def action_take_other(self, tree): |
4597.3.52
by Vincent Ladeuil
Replace --interactive by --action. |
753 |
pass
|
754 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
755 |
|
756 |
class MissingParent(HandledConflict): |
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
757 |
"""An attempt to add files to a directory that is not present.
|
1551.8.22
by Aaron Bentley
Improve message when OTHER deletes an in-use tree |
758 |
Typically, the result of a merge where THIS deleted the directory and
|
759 |
the OTHER added a file to it.
|
|
4597.3.50
by Vincent Ladeuil
Integrate most of BRANCH.TOTO into bzrlib/help_topics/en/conflicts.txt, fix a typo in a test. |
760 |
See also: DeletingParent (same situation, THIS and OTHER reversed)
|
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
761 |
"""
|
762 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
763 |
typestring = 'missing parent' |
1534.10.22
by Aaron Bentley
Got ConflictList implemented |
764 |
|
1534.10.20
by Aaron Bentley
Got all tests passing |
765 |
format = 'Conflict adding files to %(path)s. %(action)s.' |
766 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
767 |
def action_take_this(self, tree): |
4597.3.31
by Vincent Ladeuil
Implement --interactive for MissingParent. |
768 |
tree.remove([self.path], force=True, keep_files=False) |
769 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
770 |
def action_take_other(self, tree): |
4597.3.31
by Vincent Ladeuil
Implement --interactive for MissingParent. |
771 |
# just acccept bzr proposal
|
772 |
pass
|
|
773 |
||
1534.10.20
by Aaron Bentley
Got all tests passing |
774 |
|
1551.8.22
by Aaron Bentley
Improve message when OTHER deletes an in-use tree |
775 |
class DeletingParent(HandledConflict): |
776 |
"""An attempt to add files to a directory that is not present.
|
|
777 |
Typically, the result of a merge where one OTHER deleted the directory and
|
|
778 |
the THIS added a file to it.
|
|
779 |
"""
|
|
780 |
||
781 |
typestring = 'deleting parent' |
|
782 |
||
1551.8.23
by Aaron Bentley
Tweaked conflict message to be more understandable |
783 |
format = "Conflict: can't delete %(path)s because it is not empty. "\ |
784 |
"%(action)s." |
|
1551.8.22
by Aaron Bentley
Improve message when OTHER deletes an in-use tree |
785 |
|
4597.3.32
by Vincent Ladeuil
Implement --interactive for DeletingParent noting the inconsistency. |
786 |
# FIXME: It's a bit strange that the default action is not coherent with
|
787 |
# MissingParent from the *user* pov.
|
|
788 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
789 |
def action_take_this(self, tree): |
4597.3.32
by Vincent Ladeuil
Implement --interactive for DeletingParent noting the inconsistency. |
790 |
# just acccept bzr proposal
|
791 |
pass
|
|
792 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
793 |
def action_take_other(self, tree): |
4597.3.32
by Vincent Ladeuil
Implement --interactive for DeletingParent noting the inconsistency. |
794 |
tree.remove([self.path], force=True, keep_files=False) |
795 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
796 |
|
3144.4.2
by Aaron Bentley
Handle non-directory parent conflicts (abentley, #177390) |
797 |
class NonDirectoryParent(HandledConflict): |
4597.3.35
by Vincent Ladeuil
Implement --interactive for NonDirectoryParent, sort of. |
798 |
"""An attempt to add files to a directory that is not a directory or
|
3144.4.2
by Aaron Bentley
Handle non-directory parent conflicts (abentley, #177390) |
799 |
an attempt to change the kind of a directory with files.
|
800 |
"""
|
|
801 |
||
802 |
typestring = 'non-directory parent' |
|
803 |
||
804 |
format = "Conflict: %(path)s is not a directory, but has files in it."\ |
|
805 |
" %(action)s." |
|
806 |
||
4597.3.68
by Vincent Ladeuil
Don't use rest syntax for text displayed as-is to users. |
807 |
# FIXME: .OTHER should be used instead of .new when the conflict is created
|
808 |
||
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
809 |
def action_take_this(self, tree): |
4597.3.55
by Vincent Ladeuil
More cleanup. |
810 |
# FIXME: we should preserve that path when the conflict is generated !
|
4597.3.35
by Vincent Ladeuil
Implement --interactive for NonDirectoryParent, sort of. |
811 |
if self.path.endswith('.new'): |
812 |
conflict_path = self.path[:-(len('.new'))] |
|
813 |
tree.remove([self.path], force=True, keep_files=False) |
|
814 |
tree.add(conflict_path) |
|
815 |
else: |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
816 |
raise NotImplementedError(self.action_take_this) |
4597.3.35
by Vincent Ladeuil
Implement --interactive for NonDirectoryParent, sort of. |
817 |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
818 |
def action_take_other(self, tree): |
4597.3.55
by Vincent Ladeuil
More cleanup. |
819 |
# FIXME: we should preserve that path when the conflict is generated !
|
4597.3.35
by Vincent Ladeuil
Implement --interactive for NonDirectoryParent, sort of. |
820 |
if self.path.endswith('.new'): |
821 |
conflict_path = self.path[:-(len('.new'))] |
|
822 |
tree.remove([conflict_path], force=True, keep_files=False) |
|
823 |
tree.rename_one(self.path, conflict_path) |
|
824 |
else: |
|
4597.3.73
by Vincent Ladeuil
All Conflict action method names start with 'action_' to avoid potential namespace collisions |
825 |
raise NotImplementedError(self.action_take_other) |
4597.3.35
by Vincent Ladeuil
Implement --interactive for NonDirectoryParent, sort of. |
826 |
|
827 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
828 |
ctype = {} |
1534.10.20
by Aaron Bentley
Got all tests passing |
829 |
|
830 |
||
1534.10.18
by Aaron Bentley
Defined all new Conflict types |
831 |
def register_types(*conflict_types): |
832 |
"""Register a Conflict subclass for serialization purposes"""
|
|
833 |
global ctype |
|
834 |
for conflict_type in conflict_types: |
|
835 |
ctype[conflict_type.typestring] = conflict_type |
|
836 |
||
837 |
register_types(ContentsConflict, TextConflict, PathConflict, DuplicateID, |
|
1551.8.22
by Aaron Bentley
Improve message when OTHER deletes an in-use tree |
838 |
DuplicateEntry, ParentLoop, UnversionedParent, MissingParent, |
3144.4.2
by Aaron Bentley
Handle non-directory parent conflicts (abentley, #177390) |
839 |
DeletingParent, NonDirectoryParent) |